[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - connectivity/source
connectivity/source/drivers/firebird/Util.cxx | 92 ++
1 file changed, 52 insertions(+), 40 deletions(-)
New commits:
commit 698d5809ea237c78bbbd4e85aa4f73685a4db025
Author: Julien Nabet
AuthorDate: Wed Oct 28 22:38:28 2020 +0100
Commit: Lionel Mamane
CommitDate: Fri Oct 30 06:51:13 2020 +0100
tdf#137801: Firebird fix warn when changing a table having a field type BLOB
OTableController::alterColumns() from
dbaccess/source/ui/tabledesign/TableController.cxx
checks if a column changes with:
if((nType != pField->GetType() ||
sTypeName != pField->GetTypeName() ||
etc
See
https://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/tabledesign/TableController.cxx?r=585cefd1#1002
So for example for "BLOB" field, LO was comparing "SQL_BLOB" from
"sTypeName" with "BLOB" from "pField->GetTypeName()"
In the same way, LO was comparing "SQL_LONG" from "sTypeName" with
"INTEGER" from "pField->GetTypeName()"
or "SQL_VARYING" from "sTypeName" with "VARCHAR" from
"pField->GetTypeName()"
Change-Id: I3632f3ee5845b4f07d606fddd586951a3deea67f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104979
Tested-by: Jenkins
Reviewed-by: Julien Nabet
(cherry picked from commit 5b33b1a6b0f251202e89cef436efd4719c3fc0c4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104963
Reviewed-by: Lionel Mamane
diff --git a/connectivity/source/drivers/firebird/Util.cxx
b/connectivity/source/drivers/firebird/Util.cxx
index 7befd4b99014..7bdb12b8eb29 100644
--- a/connectivity/source/drivers/firebird/Util.cxx
+++ b/connectivity/source/drivers/firebird/Util.cxx
@@ -181,47 +181,59 @@ sal_Int32 firebird::ColumnTypeInfo::getSdbcType() const
OUString firebird::ColumnTypeInfo::getColumnTypeName() const
{
-short aType = m_aType & ~1; // Remove last bit -- it is used to denote
whether column
-// can store Null, not needed for type determination
-
-switch (aType)
+sal_Int32 nDataType = this->getSdbcType();
+switch (nDataType)
{
- case SQL_TEXT:
- return "SQL_TEXT";
- case SQL_VARYING:
- return "SQL_VARYING";
- case SQL_SHORT:
- return "SQL_SHORT";
- case SQL_LONG:
- return "SQL_LONG";
- case SQL_FLOAT:
- return "SQL_FLOAT";
- case SQL_DOUBLE:
- return "SQL_DOUBLE";
- case SQL_D_FLOAT:
- return "SQL_D_FLOAT";
- case SQL_TIMESTAMP:
- return "SQL_TIMESTAMP";
- case SQL_BLOB:
- return "SQL_BLOB";
- case SQL_ARRAY:
- return "SQL_ARRAY";
- case SQL_TYPE_TIME:
- return "SQL_TYPE_TIME";
- case SQL_TYPE_DATE:
- return "SQL_TYPE_DATE";
- case SQL_INT64:
- return "SQL_INT64";
- case SQL_NULL:
- return "SQL_NULL";
- case SQL_QUAD:
- return "SQL_QUAD";
- case SQL_BOOLEAN:
- return "SQL_BOOLEAN";
- default:
- assert(false); // Should never happen
- return OUString();
-}
+case DataType::BIT:
+return "BIT";
+case DataType::TINYINT:
+return "TINYINT";
+case DataType::SMALLINT:
+return "SMALLINT";
+case DataType::INTEGER:
+return "INTEGER";
+case DataType::BIGINT:
+return "BIGINT";
+case DataType::FLOAT:
+return "FLOAT";
+case DataType::REAL:
+return "REAL";
+case DataType::DOUBLE:
+return "DOUBLE";
+case DataType::NUMERIC:
+return "NUMERIC";
+case DataType::DECIMAL:
+return "DECIMAL";
+case DataType::CHAR:
+return "CHAR";
+case DataType::VARCHAR:
+return "VARCHAR";
+case DataType::LONGVARCHAR:
+return "LONGVARCHAR";
+case DataType::DATE:
+return "DATE";
+case DataType::TIME:
+return "TIME";
+case DataType::TIMESTAMP:
+return "TIMESTAMP";
+case DataType::BINARY:
+return "BINARY";
+case DataType::LONGVARBINARY:
+return "LONGVARBINARY";
+case DataType::ARRAY:
+return "ARRAY";
+case DataType::BLOB:
+return "BLOB";
+case DataType::CLOB:
+return "CLOB";
+case DataType::BOOLEAN:
+return "BOOLEAN";
+case DataType::SQLNULL:
+return "NULL";
+default:
+assert(false); // Should never happen
+return OUString();
+ }
}
short firebird::getFBTypeFromBlrType(short blrType)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 134289] FILEOPEN PPTX: text shifts to the left when box is too narrow (text horizontally centers around upper/left corner instead of starting there)
https://bugs.documentfoundation.org/show_bug.cgi?id=134289 Aron Budea changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED Version|4.1 all versions|6.4.0.0.alpha0+ --- Comment #12 from Aron Budea --- (In reply to Xisco Faulí from comment #4) > Reproduced in ... > Version: 5.2.0.0.alpha0+ > Build ID: 3ca42d8d51174010d5e8a32b96e9b4c0b3730a53 > Threads 4; Ver: 4.19; Render: default; This was a bit unfortunate choice of version, indeed the bug is there in 5.2.0.4, but it's gone in 5.3.0.3, thus this wasn't an old issue, but a recent regression. (In reply to Gerald Pfeifer from comment #11) > Digging into this a bit, it appears bug #137023 (which is newer than > mine ;-) is a duplicate by Xisco that got fixed by Miklos? It's actually a duplicate of bug 129685, confirmed using the bibisect-linux-64-7.1 bibisect repo (bug 137023 is a regression from that other bugfix). *** This bug has been marked as a duplicate of bug 129685 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137144] some toolbar font size fractions wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=137144 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137112] Header Spacing diakog setting behave as expected or different for docx
https://bugs.documentfoundation.org/show_bug.cgi?id=137112 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137502] FILEOPEN with a non-latin filename (I have tried Greek and Cyrillic) does lead to an error message or a defunct soffice.bin process
https://bugs.documentfoundation.org/show_bug.cgi?id=137502 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137436] Sign existing PDF doesn't show my certificate (works fine with regular documents)
https://bugs.documentfoundation.org/show_bug.cgi?id=137436 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137514] Screenshot of PDF export dialog > General tab is outdated
https://bugs.documentfoundation.org/show_bug.cgi?id=137514 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137491] Please consider not hiding comments during save operation
https://bugs.documentfoundation.org/show_bug.cgi?id=137491 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132255] crash converting Cal sheet into Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=132255 --- Comment #9 from QA Administrators --- Dear cyril.langlois, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127423] Font feature dialog: Reimplement some checkboxes as tri-state
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137509] Writer table selection cursors massively oversized and offset (HiDPI)
https://bugs.documentfoundation.org/show_bug.cgi?id=137509 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127423] Font feature dialog: Reimplement some checkboxes as tri-state
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127423] Font feature dialog: Reimplement some checkboxes as tri-state
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131731] Some letters don't show in edit mode for a slide
https://bugs.documentfoundation.org/show_bug.cgi?id=131731 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131731] Some letters don't show in edit mode for a slide
https://bugs.documentfoundation.org/show_bug.cgi?id=131731 --- Comment #7 from QA Administrators --- Dear birdinspace, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130397] ZoomText program causes Libre Office to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=130397 --- Comment #6 from QA Administrators --- Dear Gary G. Martin, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132396] "Missing hyphenation info" pop-up banner displayed for Chinese which has no concept of hyphenation
https://bugs.documentfoundation.org/show_bug.cgi?id=132396 --- Comment #6 from QA Administrators --- Dear 5s7cigse6x, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132509] When I convert my LibreOffice document with pictures to PDF, it stretches out images
https://bugs.documentfoundation.org/show_bug.cgi?id=132509 --- Comment #3 from QA Administrators --- Dear Savvy, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131504] A 0.5 pt table border is made too fat when exporten to PNG or jpg
https://bugs.documentfoundation.org/show_bug.cgi?id=131504 --- Comment #3 from QA Administrators --- Dear Ed Keizer, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137490] [UI] Groupedbar user interface uses "Header 1/2" menu items for "Heading 1/2" cell styles
https://bugs.documentfoundation.org/show_bug.cgi?id=137490 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127423] Font feature dialog: Reimplement some checkboxes as tri-state
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 131038] Tables and Form Controls not interacting
https://bugs.documentfoundation.org/show_bug.cgi?id=131038 --- Comment #4 from QA Administrators --- Dear Guy, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130351] Cross-reference as hyperlink
https://bugs.documentfoundation.org/show_bug.cgi?id=130351 --- Comment #4 from QA Administrators --- Dear Sebők Gábor, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129679] When validating a cell as cell range I click on the source field, it results in only being capable of select cells and nothing more.
https://bugs.documentfoundation.org/show_bug.cgi?id=129679 --- Comment #4 from QA Administrators --- Dear kodaichi_san, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129603] Calc formatting: print preview shows different row height view than working version
https://bugs.documentfoundation.org/show_bug.cgi?id=129603 --- Comment #2 from QA Administrators --- Dear Chet Valdes, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 130615] Typing lags when typing inside tables
https://bugs.documentfoundation.org/show_bug.cgi?id=130615 --- Comment #8 from QA Administrators --- Dear galenyeo1, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/qa basic/source
basic/qa/basic_coverage/test_method_name_variable.vb | 35
basic/source/runtime/runtime.cxx | 40 +++
2 files changed, 75 insertions(+)
New commits:
commit 48d46bcc903aedf0dd82746222c5333e3cd116a1
Author: Andreas Heinisch
AuthorDate: Thu Oct 22 20:03:44 2020 +0200
Commit: Mike Kaganski
CommitDate: Fri Oct 30 05:12:25 2020 +0100
tdf#85371 - grant write access to the method used as a variable
During the creation of the parameter list of a method, explicitly grant
write access to the method which will used as a variable. Otherwise, the
name of the method can't be used in certain statements, i.e., index in a
for loop or as a dimension in ReDim.
Change-Id: I3e4c49c21fd3345d5ddd69bc31a5823b5de5b8e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104696
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/basic/qa/basic_coverage/test_method_name_variable.vb
b/basic/qa/basic_coverage/test_method_name_variable.vb
new file mode 100644
index ..ea45366c0f7d
--- /dev/null
+++ b/basic/qa/basic_coverage/test_method_name_variable.vb
@@ -0,0 +1,35 @@
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+
+Function assignVarToMethod() As Integer
+
+' method name used as dimension specifier
+Dim fieldOfLongs() As Long
+ReDim fieldOfLongs(assignVarToMethod) As Long
+
+' method name used as loop index
+Dim sum As Integer
+For assignVarToMethod = 1 To 3
+sum = sum + assignVarToMethod
+Next assignVarToMethod
+assignVarToMethod = sum
+
+End Function
+
+Function doUnitTest() As Integer
+
+doUnitTest = 0
+
+' tdf#85371 - check if the name of the method can be used as a variable in
certain statements
+If (assignVarToMethod() <> 6) Then Exit Function
+' tdf#85371 - check if an assignment to the function fails outside of the
function itself
+assignVarToMethod = 0
+If (assignVarToMethod() <> 6) Then Exit Function
+
+doUnitTest = 1
+
+End Function
diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index 498c71628dba..0606b78ca420 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -83,6 +83,34 @@ using namespace ::com::sun::star;
static void lcl_clearImpl( SbxVariableRef const & refVar, SbxDataType const &
eType );
static void lcl_eraseImpl( SbxVariableRef const & refVar, bool bVBAEnabled );
+namespace
+{
+class ScopedWritableGuard
+{
+public:
+ScopedWritableGuard(const SbxVariableRef& rVar, bool bMakeWritable)
+: m_rVar(rVar)
+, m_bReset(bMakeWritable && !rVar->CanWrite())
+{
+if (m_bReset)
+{
+m_rVar->SetFlag(SbxFlagBits::Write);
+}
+}
+~ScopedWritableGuard()
+{
+if (m_bReset)
+{
+m_rVar->ResetFlag(SbxFlagBits::Write);
+}
+}
+
+private:
+SbxVariableRef m_rVar;
+bool m_bReset;
+};
+}
+
bool SbiRuntime::isVBAEnabled()
{
bool bResult = false;
@@ -1131,6 +1159,9 @@ void SbiRuntime::PushFor()
p->refEnd = PopVar();
SbxVariableRef xBgn = PopVar();
p->refVar = PopVar();
+// tdf#85371 - grant explicitly write access to the index variable
+// since it could be the name of a method itself used in the next
statement.
+ScopedWritableGuard aGuard(p->refVar, p->refVar.get() == pMeth);
*(p->refVar) = *xBgn;
nForLvl++;
}
@@ -2583,6 +2614,9 @@ void SbiRuntime::StepNEXT()
StarBASIC::FatalError( ERRCODE_BASIC_INTERNAL_ERROR );
return;
}
+// tdf#85371 - grant explicitly write access to the index variable
+// since it could be the name of a method itself used in the next
statement.
+ScopedWritableGuard aGuard(pForStk->refVar, pForStk->refVar.get() ==
pMeth);
pForStk->refVar->Compute( SbxPLUS, *pForStk->refInc );
}
@@ -3360,7 +3394,13 @@ void SbiRuntime::StepBASED( sal_uInt32 nOp1 )
sal_uInt16 uBase = static_cast(nOp1 & 1); // Can only be
0 or 1
p1->PutInteger( uBase );
if( !bCompatible )
+{
+// tdf#85371 - grant explicitly write access to the dimension variable
+// since in Star/OpenOffice Basic the upper index border is affected,
+// and the dimension variable could be the name of the method itself.
+ScopedWritableGuard aGuard(x2, x2.get() == pMeth);
x2->Compute( SbxPLUS, *p1 );
+}
PushVar( x2.get() ); // first the Expr
PushVar( p1 ); // then the Base
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137867] New: Not able to add replacement rule in Font Replacement dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=137867 Bug ID: 137867 Summary: Not able to add replacement rule in Font Replacement dialog Product: LibreOffice Version: 6.4.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: suokunl...@126.com Tools > Options > LibreOffice > Fonts, the replacement table function is not working anymore (The √ mark is grayed out and is not functioning when clicking on it). Fedora 32 x64 版本: 6.4.6.2 Build ID: 0ce51a4fd21bff07a5c061082cc82c5ed232f115 CPU 线程: 4; 操作系统: Linux 5.8; 界面渲染: 默认; VCL: gtk3; 区域语言: zh-CN (zh_CN.UTF-8); UI 语言: zh-CN Calc: threaded Version: 7.0.3.0.0+ Build ID: a9bad3ef281c825bf57437a1b5154e413d7f18cd CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: zh-CN (zh_CN.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 127423] Font feature dialog: Reimplement some checkboxes as tri-state
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 --- Comment #5 from Volga --- Created attachment 166864 --> https://bugs.documentfoundation.org/attachment.cgi?id=166864=edit GIF recording So let's see what happened to me. Here is illustrated with Libertinus Serif font (https://github.com/alerque/libertinus). Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); 界面: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 127423] Font feature dialog: Reimplement some checkboxes as tri-state
https://bugs.documentfoundation.org/show_bug.cgi?id=127423 --- Comment #5 from Volga --- Created attachment 166864 --> https://bugs.documentfoundation.org/attachment.cgi?id=166864=edit GIF recording So let's see what happened to me. Here is illustrated with Libertinus Serif font (https://github.com/alerque/libertinus). Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); 界面: zh-CN Calc: threaded -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
MacUpdate - your app listing has been updated
Title: Untitled Document App Listing Updated Hi The Document Foundation, We have updated your application listing for LibreOffice 7.0.3.1 on MacUpdate.com. Please take a moment to review your application's information to make sure that everything is correct. View your updated app listing You can login to your Developer Account to reply to comments and view stats, or submit new updates and changes to your app listing. Desktop Install Compatibility MacUpdate Desktop 6 is helping developers make it easier for users to fully install and use their apps. Download Desktop 6 and to ensure your app works with the “Install” link on our download pages. Advertise With MacUpdate The best Mac devs advertise their apps on MacUpdate.com because it’s the most targeted, highly performing Mac app advertising you can find on the web. Contact a...@macupdate.com to guarantee your annual ad campaigns get booked and expand your app’s audience. Learn more Questions? Contact our Content Update Team upda...@macupdate.com. You are receiving this offer because you have an app listed on MacUpdate.com. Add us to your address book or white list to ensure reliable delivery. © 2018 MacUpdate - All Rights Reserved 526 W. 14th St. #100 • Traverse City, MI 49684 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 137687] Count words and symbols show incorrect after change text
https://bugs.documentfoundation.org/show_bug.cgi?id=137687 davidjaynewy...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Component|LibreOffice |Writer Ever confirmed|0 |1 --- Comment #2 from davidjaynewy...@gmail.com --- Thank you for reporting the bug. I can confirm that the bug is present in Version: 7.0.3.1 Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Mac OS X 10.10.5; UI render: default; VCL: osx Locale: en-US (en.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137693] Tree net lines aren't shown for non gtk3
https://bugs.documentfoundation.org/show_bug.cgi?id=137693 Jim Raykowski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 137693, which changed state. Bug 137693 Summary: Tree net lines aren't shown for non gtk3 https://bugs.documentfoundation.org/show_bug.cgi?id=137693 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137866] Position/Size fields in LO Draw "scrunch" when clicking between two shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=137866 --- Comment #2 from mwtjunkm...@gmail.com --- Created attachment 166863 --> https://bugs.documentfoundation.org/attachment.cgi?id=166863=edit fields hosed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137866] Position/Size fields in LO Draw "scrunch" when clicking between two shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=137866 mwtjunkm...@gmail.com changed: What|Removed |Added CC||mwtjunkm...@gmail.com --- Comment #1 from mwtjunkm...@gmail.com --- Created attachment 166862 --> https://bugs.documentfoundation.org/attachment.cgi?id=166862=edit fields looking normal -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137866] New: Position/Size fields in LO Draw "scrunch" when clicking between two shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=137866 Bug ID: 137866 Summary: Position/Size fields in LO Draw "scrunch" when clicking between two shapes Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mwtjunkm...@gmail.com Description: I was crafting a new LO Draw document and noticed when I clicked between two pictures that the position/size fields off the to the right collapsed in height. The fields collapse to less than the height necessary to display their contents. I tested again using just a couple of squares on a brand new document, same thing. Steps to Reproduce: 1. Launch LO Draw 2. Draw any two shapes on a page, doesn't matter what. 3. Click on one of the shapes. 4. Observe the field/size properties off to the right. 5. Click the other shape. 6. Observe the field/size properties off to the right. Actual Results: Fields collapse to less than the height necessary to display their contents. Expected Results: No change in field height. Reproducible: Always User Profile Reset: No Additional Info: This bug occurred in a Windows environment. Please test using Windows. Version: 7.1.0.0.alpha1+ (x64) Build ID: 5d51b8f5ac0a82c458f792c11985407a5eeb6fd5 CPU threads: 8; OS: Windows 10.0 Build 20246; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137812] Crash in: rptui::::lcl_getQuotedFunctionName
https://bugs.documentfoundation.org/show_bug.cgi?id=137812 --- Comment #3 from Michael Manning --- Forgot to mention that in all instances but one, Libreoffice hung and required a force quit. Only once did Libreoffice crash and generate this automatic crash report. I am uncertain how to follow up those instances where Libreoffice hangs to determine the cause of this but have assumed that it has got into a loop somewhere. Mike -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137812] Crash in: rptui::::lcl_getQuotedFunctionName
https://bugs.documentfoundation.org/show_bug.cgi?id=137812 Michael Manning changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 Hardware|All |x86-64 (AMD64) --- Comment #2 from Michael Manning --- I am learning to use Base with postgresql and have been loosely following the Casanova tutorial and modifying this as required. There have been no issues working with tables, queries and forms. An issue arises when working with reports. One of the reports listed by Casanova is a report on payments by patients where the grouping is used to calculate the total amount paid by a patient for a specified time period. This is achieved by using the sorting and grouping function to calculate a group footer. In the group footer, a field using a function to calculate the accumulation of the payment amount of a group is inserted into the group footer. Every time I have attempted to insert this, Libreoffice hangs and I have had to do a Force Quit to exit. I have attempted a number of reports for this and have built a number of queries on which the report is based. The queries appear fine. I have not been able to progress past this step so my next approach is to: 1. repeat the exercise using the embedded hsql database to rule out potential issues with the use of postgresql. 2. If this still fails, I plan to revert to an earlier version of Libreoffice to see if the issue is still present. Any input from other users of Base + Postgresql would be most welcome. Mike -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137144] some toolbar font size fractions wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=137144 --- Comment #1 from jpkarolja...@gmail.com --- I tested the bug with: Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 16; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL I was able to reproduce everything as stated. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136235] FILEOPEN PPTX: labels of piechart illegible - labels positioned on identically colored pies
https://bugs.documentfoundation.org/show_bug.cgi?id=136235 Gerald Pfeifer changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #9 from Gerald Pfeifer --- I confirm my original testcase looks as desired. Also confirmed by "The example document in PP and Impress 7.1alpha" from NISZ LibreOffice Team - thank you! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137112] Header Spacing diakog setting behave as expected or different for docx
https://bugs.documentfoundation.org/show_bug.cgi?id=137112 --- Comment #1 from jpkarolja...@gmail.com --- This is my libre office version: Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 16; OS: Windows 10.0 Build 18362; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL I was able to reproduce the first part in which the header did not shrink. 4. Delete a few enter.. notice the header not shrinking I was unable to to reproduce the second part. It remained at 0.50 cm for me and did not revert back to 2.84 cm. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134289] FILEOPEN PPTX: text shifts to the left when box is too narrow (text horizontally centers around upper/left corner instead of starting there)
https://bugs.documentfoundation.org/show_bug.cgi?id=134289 --- Comment #11 from Gerald Pfeifer --- Is it possible this has been addressed in the meantime? I appear not to be able to reproduce this for the original document nor "Another two slides" with current -dev builds of LO 7.1 and LO 7.0? Digging into this a bit, it appears bug #137023 (which is newer than mine ;-) is a duplicate by Xisco that got fixed by Miklos? - Xisco? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136957] FILEOPEN PPTX: dotted line partially disappears in presentation mode (only)
https://bugs.documentfoundation.org/show_bug.cgi?id=136957 --- Comment #8 from Gerald Pfeifer --- (In reply to Aron Budea from comment #7) > Actually, it's been bibisected to Regina's commit, the commit that goes > under Norbert's name is the one in the bibisect repository, and is not > relevant. The relevant commit hash is always what follows "source sha:", > which points to a commit in the LibreOffice repository. Ah, thank you for the background, Aron. Thanks also for your color, Regina. I'll see how we can address this one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135108] Err:540 is unjustified and persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=135108 --- Comment #6 from tor...@yahoo.com --- The error occurs with a new file. With an existing file (reloaded), Step1 does an immediate copy, without Err:540. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128233] macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
https://bugs.documentfoundation.org/show_bug.cgi?id=128233 --- Comment #37 from Rob --- Had the problem back after updating to LO 7.0.3.1 Solved by re-executing: codesign -vvv --deep --strict /Applications/LibreOffice.app -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137802] CRASH When deleting shape+textframe anchored to page
https://bugs.documentfoundation.org/show_bug.cgi?id=137802 Xisco Faulí changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED CC||xiscofa...@libreoffice.org Assignee|libreoffice-b...@lists.free |bakos.attilakar...@nisz.hu |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116703] Make clear distinction on differences between "Export" and "Save As", and move items in those filters accordingly
https://bugs.documentfoundation.org/show_bug.cgi?id=116703 --- Comment #21 from Telesto --- (In reply to Mihkel Tõnnov from comment #20) > Well, there is a warning when saving as non-ODF... And a checkbox to disable that dialog and people are really forgetful. And export working pretty well 80% of the time, so people obviously start to ignore those.. They highlighting bug mess on of those examples. Or style name mess and plenty of duplicates. Flip-flopping around. Option 4 also fine :-). Never annoyed me However Save as File Format picker should get some warning that docx export doesn't equal a 100% MSO document. Nor LibreOffice being features being 100 transposable to MSO. To page anchoring/to paragraph anchoring/ highlighting as background c. Numerous additional page breaks. They warning still suggesting a full native docx being generated without applying tricks to match docx --- FWIW: Not really seeing they point of Export and Export As though (Writer), can both not be merged somehow? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 116703] Make clear distinction on differences between "Export" and "Save As", and move items in those filters accordingly
https://bugs.documentfoundation.org/show_bug.cgi?id=116703 --- Comment #21 from Telesto --- (In reply to Mihkel Tõnnov from comment #20) > Well, there is a warning when saving as non-ODF... And a checkbox to disable that dialog and people are really forgetful. And export working pretty well 80% of the time, so people obviously start to ignore those.. They highlighting bug mess on of those examples. Or style name mess and plenty of duplicates. Flip-flopping around. Option 4 also fine :-). Never annoyed me However Save as File Format picker should get some warning that docx export doesn't equal a 100% MSO document. Nor LibreOffice being features being 100 transposable to MSO. To page anchoring/to paragraph anchoring/ highlighting as background c. Numerous additional page breaks. They warning still suggesting a full native docx being generated without applying tricks to match docx --- FWIW: Not really seeing they point of Export and Export As though (Writer), can both not be merged somehow? -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 137484] "Restart Numbering" does not "stick" for first list in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=137484 --- Comment #2 from wcrup...@gmail.com --- I didn't say version 7.0.2.2. I said version 6.4.6.2. We are not willing to uptake version 7 at this time. This is a corporate setting and we will stay on the 6.x codeline for some time yet. Furthermore, it's trivial to reproduce - every time - with version 6.4.6.2. This has NOTHING TO DO with Master documents per se. It's just that when a master document is being used, this bug is really painful; all of the sub-documents have their numbering continued from the previous sub-document. And when you have 30+ sub-documents... see what I mean? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137754] Crash when applying styles in a table within Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=137754 Kevin Suo changed: What|Removed |Added Keywords|bibisectRequest | -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135108] Err:540 is unjustified and persistent
https://bugs.documentfoundation.org/show_bug.cgi?id=135108 --- Comment #5 from tor...@yahoo.com --- (In reply to Eike Rathke from comment #4) > That means I tried in both 6.4.0 and 6.4.7 and could not reproduce the error. Versions 6.4.0 and 6.4.7? Since I use LO 7.0.1.2(x64), it seems the bug was introduced recently -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137860] Start Center: Left column using wrong font color after setting application background in general colour preferences (see comment #3)
https://bugs.documentfoundation.org/show_bug.cgi?id=137860 steve -_- changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137860] Start Center: Left column using wrong font color after setting application background in general colour preferences (see comment #3)
https://bugs.documentfoundation.org/show_bug.cgi?id=137860 steve -_- changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from steve -_- --- Confirming this is fixed in Version: 7.1.0.0.alpha1+ Build ID: 5d51b8f5ac0a82c458f792c11985407a5eeb6fd5 CPU threads: 8; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded Start center left column is light and no longer using application background color. Thanks so much. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121553] Editing: Firebird: Table editor erroneously prompts to change CLOB field to a BLOB field during alter table
https://bugs.documentfoundation.org/show_bug.cgi?id=121553 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7801 --- Comment #6 from Julien Nabet --- Of course, related with tdf#137801 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121553] Editing: Firebird: Table editor erroneously prompts to change CLOB field to a BLOB field during alter table
https://bugs.documentfoundation.org/show_bug.cgi?id=121553
Julien Nabet changed:
What|Removed |Added
CC||serval2...@yahoo.fr
--- Comment #5 from Julien Nabet ---
Lionel: I tried 2 ways to fix this:
1) In ODatabaseMetaData::getTypeInfo(), replace:
aRow[1] = new ORowSetValueDecorator(OUString("BLOB")); // BLOB, with subtype 1
by
aRow[1] = new ORowSetValueDecorator(OUString("CLOB")); // BLOB, with subtype 1
See
https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx?r=1daeea3a#885
2) In firebird::ColumnTypeInfo::getColumnTypeName()
Replace:
case DataType::CLOB:
return "CLOB";
by
case DataType::CLOB:
return "BLOB";
See connectivity/source/drivers/firebird/Util.cxx (not present in Opengrok yet
since the patch is recent).
But considering http://www.firebirdfaq.org/faq48/, if we want to stick to
Firebird naming, I think 2) should be chosen.
Now I must recognize it's not easy to think the impacts of each way.
Any thoughts?
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137860] Start Center: Left column using wrong font color after setting application background in general colour preferences (see comment #3)
https://bugs.documentfoundation.org/show_bug.cgi?id=137860 steve -_- changed: What|Removed |Added Summary|Start Center: Left column |Start Center: Left column |using wrong font color |using wrong font color |after setting application |after setting application |background in general |background in general |colour preferences |colour preferences (see ||comment #3) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/04090001.xhp |1 - 1 file changed, 1 deletion(-) New commits: commit 535ed65d68c14ae2b43c8f5fabbd7af574fe33c5 Author: Seth Chaiklin AuthorDate: Fri Oct 30 00:22:11 2020 +0200 Commit: Seth Chaiklin CommitDate: Thu Oct 29 23:27:33 2020 +0100 tdf#131206 remove irrelevant paragraph - should have been removed with the table about numbering formats that do not appear in this dialog tab. Change-Id: I685dd880d28f09427334e542fa3f7213bf07a57a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104964 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/source/text/swriter/01/04090001.xhp b/source/text/swriter/01/04090001.xhp index 05468cae3..e13af2874 100644 --- a/source/text/swriter/01/04090001.xhp +++ b/source/text/swriter/01/04090001.xhp @@ -161,7 +161,6 @@ When you click "Additional formats", the Number Format dialog opens, where you can define a custom format. If you choose "Chapter number without separator" for a chapter field, the separators that are specified for chapter number in Tools - Chapter numbering are not displayed. If you choose "chapter number" as the format for reference fields, only the number of the chapter heading containing the referenced object is displayed in the field. If the paragraph style for the chapter heading is not numbered, the field is left blank. -The following number range formats are for paragraphs formatted with numbered or bulleted lists: Inserts the field as static content, that is, the field cannot be updated. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit eb55d1a29a1ffb9e5c8c3f2bcfd97bf3d3ca49f9 Author: Seth Chaiklin AuthorDate: Fri Oct 30 00:27:33 2020 +0200 Commit: Gerrit Code Review CommitDate: Thu Oct 29 23:27:33 2020 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 535ed65d68c14ae2b43c8f5fabbd7af574fe33c5 - tdf#131206 remove irrelevant paragraph - should have been removed with the table about numbering formats that do not appear in this dialog tab. Change-Id: I685dd880d28f09427334e542fa3f7213bf07a57a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104964 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/helpcontent2 b/helpcontent2 index 9b101f66be19..535ed65d68c1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 9b101f66be1998f47e4816a6faaae6536bbae8f4 +Subproject commit 535ed65d68c14ae2b43c8f5fabbd7af574fe33c5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 52efd55eb16a087082364ba45d439e0acead02f7 Author: Andrea Gelmini AuthorDate: Thu Oct 29 23:21:19 2020 +0100 Commit: Gerrit Code Review CommitDate: Thu Oct 29 23:21:19 2020 +0100 Update git submodules * Update helpcontent2 from branch 'master' to 9b101f66be1998f47e4816a6faaae6536bbae8f4 - Fix typo Change-Id: I67f045e8cfa202bffd39ec8a015c937d4038c938 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105029 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index fb345611dd28..9b101f66be19 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit fb345611dd2859fd697dd6861583759e454b5501 +Subproject commit 9b101f66be1998f47e4816a6faaae6536bbae8f4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source sw/source
sd/source/ui/view/ViewTabBar.cxx |2 +- sw/source/core/doc/textboxhelper.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 23fa80dfc9ef7e68b5bbe01cc75cb07ebc0888b9 Author: Andrea Gelmini AuthorDate: Thu Oct 29 20:55:07 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Thu Oct 29 23:20:47 2020 +0100 Fix typos Change-Id: I0b0231eafdc8ff1ed64fc366735ea5882b3e8618 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105031 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/sd/source/ui/view/ViewTabBar.cxx b/sd/source/ui/view/ViewTabBar.cxx index c045b2295827..e2a42434e6f4 100644 --- a/sd/source/ui/view/ViewTabBar.cxx +++ b/sd/source/ui/view/ViewTabBar.cxx @@ -525,7 +525,7 @@ void ViewTabBar::UpdateTabBarButtons() int nWidthReq = rNotebook.get_preferred_size().Width(); // The excess width over the page request that the notebook uses we will // use this later to help measure the best height-for-width given the -// eventual allocatated width of the notebook +// eventual allocated width of the notebook mnNoteBookWidthPadding = nWidthReq - nMaxPageWidthReq; } diff --git a/sw/source/core/doc/textboxhelper.cxx b/sw/source/core/doc/textboxhelper.cxx index e982174e51ac..82a1c9b6fdd7 100644 --- a/sw/source/core/doc/textboxhelper.cxx +++ b/sw/source/core/doc/textboxhelper.cxx @@ -409,7 +409,7 @@ void SwTextBoxHelper::syncProperty(SwFrameFormat* pShape, const OUString& rPrope auto xTextFrame = SwXTextFrame::CreateXTextFrame(*pFormat->GetDoc(), pFormat); uno::Reference xCursor = xTextFrame->getText()->createTextCursor(); -// Select all paragraps in the textframe +// Select all paragraphs in the textframe xCursor->gotoStart(false); xCursor->gotoEnd(true); uno::Reference xFrameParaProps(xCursor, uno::UNO_QUERY); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/swriter/guide/hidden_text_display.xhp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9b101f66be1998f47e4816a6faaae6536bbae8f4 Author: Andrea Gelmini AuthorDate: Thu Oct 29 20:51:54 2020 +0100 Commit: Adolfo Jayme Barrientos CommitDate: Thu Oct 29 23:21:19 2020 +0100 Fix typo Change-Id: I67f045e8cfa202bffd39ec8a015c937d4038c938 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105029 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/source/text/swriter/guide/hidden_text_display.xhp b/source/text/swriter/guide/hidden_text_display.xhp index 93014d4d3..01244aa96 100644 --- a/source/text/swriter/guide/hidden_text_display.xhp +++ b/source/text/swriter/guide/hidden_text_display.xhp @@ -33,7 +33,7 @@ If you have a text that was hidden by defining a condition with a variable, you have several options to display the hidden text. Do one of the following: -Check the Hidden Paragrephs box in the dialog %PRODUCTNAME - PreferencesTools - Options - %PRODUCTNAME Writer - View. +Check the Hidden Paragraphs box in the dialog %PRODUCTNAME - PreferencesTools - Options - %PRODUCTNAME Writer - View. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/itrpaint.cxx | 15 +--
sw/source/core/text/porlay.cxx | 11 +++
sw/source/core/text/porlay.hxx |3 ---
sw/source/core/text/porrst.cxx | 30 +-
sw/source/core/text/porrst.hxx | 11 ---
sw/source/core/text/redlnitr.cxx | 13 ++---
sw/source/core/text/redlnitr.hxx |2 +-
7 files changed, 56 insertions(+), 29 deletions(-)
New commits:
commit 37d85df2d2fd53ee436f24484b48aafc91d501b1
Author: László Németh
AuthorDate: Thu Oct 29 13:37:21 2020 +0100
Commit: László Németh
CommitDate: Thu Oct 29 23:19:09 2020 +0100
tdf#105967 sw change tracking: fix pilcrow color
Paint strikeout/underline based on redline color
and settings at the inserted or deleted paragraph
break.
Follow-up of commit 350dbba44ee7703b1da11cc4732a5090ce5efe3d
(tdf#105967 sw change tracking: fix pilcrow symbol).
Note: because the pilcrow symbol is painted by
the temporary text portion SwTmpEndPortion, see
sw/qa/extras/layout/data/tdf42748.fodt for testing.
Change-Id: I4c9c6bb7ce445aa30224fabe7162a19df0df08b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105007
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/source/core/text/itrpaint.cxx b/sw/source/core/text/itrpaint.cxx
index b00507c907c8..153131a2a3e9 100644
--- a/sw/source/core/text/itrpaint.cxx
+++ b/sw/source/core/text/itrpaint.cxx
@@ -427,8 +427,19 @@ void SwTextPainter::DrawTextLine( const SwRect ,
SwSaveClip ,
GetInfo().GetOpt().IsParagraph() && !GetTextFrame()->GetFollow() &&
GetInfo().GetIdx() >=
TextFrameIndex(GetInfo().GetText().getLength()))
{
-const SwTmpEndPortion aEnd( *pEndTempl, m_pCurr->HasRedlineEnd(),
- m_pCurr->HasRedlineEndDel() );
+bool bHasRedlineEnd( GetRedln() && m_pCurr->HasRedlineEnd() );
+if( bHasRedlineEnd )
+{
+TextFrameIndex nOffset = GetInfo().GetIdx();
+SeekStartAndChg( GetInfo(), true );
+std::pair const pos(
+GetTextFrame()->MapViewToModel(nOffset));
+GetRedln()->Seek(*m_pFont, pos.first->GetIndex(), pos.second,
0);
+}
+const SwTmpEndPortion aEnd( *pEndTempl,
+ bHasRedlineEnd ? m_pFont->GetUnderline() :
LINESTYLE_NONE,
+ bHasRedlineEnd ? m_pFont->GetStrikeout() :
STRIKEOUT_NONE,
+ bHasRedlineEnd ? m_pFont->GetColor() : COL_AUTO );
GetFnt()->ChgPhysFnt( GetInfo().GetVsh(), *pOut );
if ( bAdjustBaseLine )
diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 69a7c39b5dc2..148d909f6449 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -605,18 +605,14 @@ void SwLineLayout::CalcLine( SwTextFormatter ,
SwTextFormatInfo )
if( bHasRedline )
{
OUString sRedlineText;
-bool bHasRedlineEnd, bHasRedlineEndDel;
+bool bHasRedlineEnd;
bHasRedline = rLine.GetRedln()->CheckLine(start.first->GetIndex(),
start.second,
-end.first->GetIndex(), end.second, sRedlineText, bHasRedlineEnd,
bHasRedlineEndDel );
+end.first->GetIndex(), end.second, sRedlineText, bHasRedlineEnd);
if( bHasRedline )
{
SetRedlineText( sRedlineText );
if( bHasRedlineEnd )
-{
SetRedlineEnd( bHasRedlineEnd );
-if( bHasRedlineEndDel )
-SetRedlineEndDel( bHasRedlineEndDel );
-}
}
}
SetRedline( bHasRedline );
@@ -679,8 +675,7 @@ void SwLineLayout::ResetFlags()
{
m_bFormatAdj = m_bDummy = m_bEndHyph = m_bMidHyph = m_bFly
= m_bRest = m_bBlinking = m_bClipping = m_bContent = m_bRedline
-= m_bRedlineEnd = m_bRedlineEndDel
-= m_bForcedLeftMargin = m_bHanging = false;
+= m_bRedlineEnd = m_bForcedLeftMargin = m_bHanging = false;
}
SwLineLayout::SwLineLayout()
diff --git a/sw/source/core/text/porlay.hxx b/sw/source/core/text/porlay.hxx
index 39e50d28ba94..5126460b5424 100644
--- a/sw/source/core/text/porlay.hxx
+++ b/sw/source/core/text/porlay.hxx
@@ -94,7 +94,6 @@ private:
bool m_bContent : 1; // Text for line numbering
bool m_bRedline : 1; // The Redlining
bool m_bRedlineEnd: 1; // Redlining for paragraph mark: tracked change at
the end
-bool m_bRedlineEndDel : 1; // Redlining for paragraph mark: tracked
deletion at the end
bool m_bForcedLeftMargin : 1; // Left adjustment moved by the Fly
bool m_bHanging : 1; // Contains a hanging portion in the margin
bool m_bUnderscore : 1;
@@ -134,8 +133,6 @@ public:
bool HasRedline() const { return m_bRedline; }
void SetRedlineEnd( const bool bNew ) { m_bRedlineEnd = bNew; }
bool HasRedlineEnd()
[Libreoffice-bugs] [Bug 105967] Tracked edits to line/paragraph breaks not formatted according to inserted/deleted status
https://bugs.documentfoundation.org/show_bug.cgi?id=105967 --- Comment #8 from Commit Notification --- László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/37d85df2d2fd53ee436f24484b48aafc91d501b1 tdf#105967 sw change tracking: fix pilcrow color It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 116703] Make clear distinction on differences between "Export" and "Save As", and move items in those filters accordingly
https://bugs.documentfoundation.org/show_bug.cgi?id=116703 --- Comment #20 from Mihkel Tõnnov --- (In reply to Heiko Tietze from comment #16) > Option 0: > Keep as it is under the assumption (expert) users are familiar with the > organization. +0.8 My personal preference, but maybe not the best solution for general public. It has its logic, though. > Option 1: > We keep only the open document formats in Save/As and move everything else > into Export. This has been done for GIMP and it's very annoying (but clear > to understand). Please no D: The GIMP approach bites me in the face every time I use the damn thing. (Even though I understand the rationale.) > Option 2: > SaveAs holds open document formats and MSO. Meaning html, dbf, slk, csv / > rtf, txt / mml get moved into Export. Somewhat confusing in case of Calc > since CSV is as important as Excel. Or in case of html when Writer is used > as editor. Why only MSO? And where to even draw the line after that? E.g. RTF and (especially) CSV are used quite a lot, and presumably expected to be found from "normal" Save dialog. > Option 3: > We drop Export and keep everything under SaveAs. IIRC the list of supported > file formats can become quite large. This would make things worse wrt perceived compatibility/completeness. Also would necessitate some sort of comments or section titles in the list (as Telesto mentioned). > Option 4: > Keep only "lossy" formats under Export. That applies to all raster graphic > formats- loading exported data does not allow editing. For Draw html, pdf > and svg would go to SaveAs, in case of Calc html and xml, etc. In the end, > the function is kind of "Export to Raster Graphic". +0.2 For average (not dumb-) user, I think this makes the most sense out of the discussed options. Although for consistency, I think PDF should stay under Export also in Draw. Also, "lossy" as criterion might be problematic, as e.g. CSV is definitely "lossy" when it comes to formatting :) (Sure, there's a warning...) > Option 5: > Different menu options with Save As > Open Document | Microsoft Office > (another menu entry for other office suites)| Markup Languages (html, xml, > svg, mml, csv) | Raster Graphics. Not sure where to put epub and PDF, maybe > Markup, but we could drop this format since we have a dedicated command. Can all the save/export formats really fit under a single category? Also, it would probably take a user at least two attempts to find where e.g. CSV or RTF or XML is under such a structure (terms like "markup language" probably aren't understood by everyone). (In reply to Telesto from comment #17) > Original vision: 1 next 5 (based on MacOS Pages) > Directly saving new documents into DOCX/DOC is unadvised and people > shouldn't do that. This certainly doesn't work out to well. And having it > under Save As suggests kind of full compatibility. Well, there is a warning when saving as non-ODF... -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 116703] Make clear distinction on differences between "Export" and "Save As", and move items in those filters accordingly
https://bugs.documentfoundation.org/show_bug.cgi?id=116703 --- Comment #20 from Mihkel Tõnnov --- (In reply to Heiko Tietze from comment #16) > Option 0: > Keep as it is under the assumption (expert) users are familiar with the > organization. +0.8 My personal preference, but maybe not the best solution for general public. It has its logic, though. > Option 1: > We keep only the open document formats in Save/As and move everything else > into Export. This has been done for GIMP and it's very annoying (but clear > to understand). Please no D: The GIMP approach bites me in the face every time I use the damn thing. (Even though I understand the rationale.) > Option 2: > SaveAs holds open document formats and MSO. Meaning html, dbf, slk, csv / > rtf, txt / mml get moved into Export. Somewhat confusing in case of Calc > since CSV is as important as Excel. Or in case of html when Writer is used > as editor. Why only MSO? And where to even draw the line after that? E.g. RTF and (especially) CSV are used quite a lot, and presumably expected to be found from "normal" Save dialog. > Option 3: > We drop Export and keep everything under SaveAs. IIRC the list of supported > file formats can become quite large. This would make things worse wrt perceived compatibility/completeness. Also would necessitate some sort of comments or section titles in the list (as Telesto mentioned). > Option 4: > Keep only "lossy" formats under Export. That applies to all raster graphic > formats- loading exported data does not allow editing. For Draw html, pdf > and svg would go to SaveAs, in case of Calc html and xml, etc. In the end, > the function is kind of "Export to Raster Graphic". +0.2 For average (not dumb-) user, I think this makes the most sense out of the discussed options. Although for consistency, I think PDF should stay under Export also in Draw. Also, "lossy" as criterion might be problematic, as e.g. CSV is definitely "lossy" when it comes to formatting :) (Sure, there's a warning...) > Option 5: > Different menu options with Save As > Open Document | Microsoft Office > (another menu entry for other office suites)| Markup Languages (html, xml, > svg, mml, csv) | Raster Graphics. Not sure where to put epub and PDF, maybe > Markup, but we could drop this format since we have a dedicated command. Can all the save/export formats really fit under a single category? Also, it would probably take a user at least two attempts to find where e.g. CSV or RTF or XML is under such a structure (terms like "markup language" probably aren't understood by everyone). (In reply to Telesto from comment #17) > Original vision: 1 next 5 (based on MacOS Pages) > Directly saving new documents into DOCX/DOC is unadvised and people > shouldn't do that. This certainly doesn't work out to well. And having it > under Save As suggests kind of full compatibility. Well, there is a warning when saving as non-ODF... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51780] [META] Default to Firebird not HSQLDB in Base (for _new_ files)
https://bugs.documentfoundation.org/show_bug.cgi?id=51780 Bug 51780 depends on bug 125941, which changed state. Bug 125941 Summary: FIREBIRD: Tableeditor tries to change BLOB-Fields every time you will edit a table. https://bugs.documentfoundation.org/show_bug.cgi?id=125941 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137865] .uno:StylesPreview use wrong background color (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=137865 andreas_k changed: What|Removed |Added Blocks||112286 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112286 [Bug 112286] [META] gtk3 themeing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125941] FIREBIRD: Tableeditor tries to change BLOB-Fields every time you will edit a table.
https://bugs.documentfoundation.org/show_bug.cgi?id=125941 Julien Nabet changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #7 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I don't reproduce this anymore. I think it's a dup of tdf#137801 Don't hesitate to reopen this tracker if you still reproduce this with a build which includes: https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b33b1a6b0f251202e89cef436efd4719c3fc0c4 tdf#137801: Firebird fix warn when changing a table having a field type BLOB ... *** This bug has been marked as a duplicate of bug 137801 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112286] [META] gtk3 themeing
https://bugs.documentfoundation.org/show_bug.cgi?id=112286 andreas_k changed: What|Removed |Added Depends on||137865 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137865 [Bug 137865] .uno:StylesPreview use wrong background color (gtk3) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137865] New: .uno:StylesPreview use wrong background color (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=137865 Bug ID: 137865 Summary: .uno:StylesPreview use wrong background color (gtk3) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kain...@gmail.com Created attachment 166860 --> https://bugs.documentfoundation.org/attachment.cgi?id=166860=edit gtk3 backend theme It look like the .uno:StylesPreview (stylespreview.ui) use the wrong widget background color. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svx/source svx/uiconfig sw/uiconfig
svx/source/inc/StylesPreviewWindow.hxx |4 -
svx/source/tbxctrls/StylesPreviewToolBoxControl.cxx |6 +-
svx/source/tbxctrls/StylesPreviewWindow.cxx |6 +-
svx/source/tbxctrls/tbcontrl.cxx|4 +
svx/uiconfig/ui/stylespreview.ui| 57
sw/uiconfig/swriter/ui/notebookbar.ui |1
6 files changed, 47 insertions(+), 31 deletions(-)
New commits:
commit 55e0a9f5506ca95238b3b70cb9beb33d089577f4
Author: andreas kainz
AuthorDate: Thu Oct 29 14:31:35 2020 +0100
Commit: Andreas Kainz
CommitDate: Thu Oct 29 23:09:49 2020 +0100
StylesPreview in Writer NB arrangement in two rows
Change-Id: I05e0b903e7d51cb2487f18f5bbeb6228ba7c945f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105008
Tested-by: Jenkins
Reviewed-by: Andreas Kainz
diff --git a/svx/source/inc/StylesPreviewWindow.hxx
b/svx/source/inc/StylesPreviewWindow.hxx
index 2b930672d23f..8381f3b72c49 100644
--- a/svx/source/inc/StylesPreviewWindow.hxx
+++ b/svx/source/inc/StylesPreviewWindow.hxx
@@ -74,7 +74,7 @@ private:
class StylesPreviewWindow_Base
{
protected:
-static constexpr unsigned STYLES_COUNT = 4;
+static constexpr unsigned STYLES_COUNT = 6;
std::unique_ptr m_xStyleControllers[STYLES_COUNT];
std::unique_ptr m_xStyleControllersWeld[STYLES_COUNT];
@@ -124,4 +124,4 @@ public:
#endif
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/svx/source/tbxctrls/StylesPreviewToolBoxControl.cxx
b/svx/source/tbxctrls/StylesPreviewToolBoxControl.cxx
index 9b78a0e7aaf0..47995067ae03 100644
--- a/svx/source/tbxctrls/StylesPreviewToolBoxControl.cxx
+++ b/svx/source/tbxctrls/StylesPreviewToolBoxControl.cxx
@@ -68,8 +68,8 @@ void StylesPreviewToolBoxControl::InitializeStyles(
css::uno::Reference xParaStyles;
xStylesSupplier->getStyleFamilies()->getByName("ParagraphStyles")
>>= xParaStyles;
static const std::vector aWriterStyles
-= { "Standard", "Text body", "Title", "Subtitle",
-"Heading 1", "Heading 2", "Heading 3", "Quotations" };
+= { "Standard", "Text body", "Heading 1", "Heading 2",
"Heading 3",
+"Heading 4", "Title", "Subtitle", "Quotations",
"Preformatted Text" };
for (const OUString& aStyle : aWriterStyles)
{
try
@@ -185,4 +185,4 @@
com_sun_star_comp_svx_StylesPreviewToolBoxControl_get_implementation(
return cppu::acquire(new StylesPreviewToolBoxControl());
}
-/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s
cinkeys+=0=break: */
diff --git a/svx/source/tbxctrls/StylesPreviewWindow.cxx
b/svx/source/tbxctrls/StylesPreviewWindow.cxx
index 7448592f2162..265fea39b956 100644
--- a/svx/source/tbxctrls/StylesPreviewWindow.cxx
+++ b/svx/source/tbxctrls/StylesPreviewWindow.cxx
@@ -369,7 +369,7 @@ StylesPreviewWindow_Base::StylesPreviewWindow_Base(
m_xStyleControllersWeld[i].reset(
new weld::CustomWeld(xBuilder, sId, *m_xStyleControllers[i]));
-m_xStyleControllersWeld[i]->set_size_request(100, 60);
+m_xStyleControllersWeld[i]->set_size_request(128, 28);
}
m_xUp->connect_clicked(LINK(this, StylesPreviewWindow_Base, GoUp));
@@ -477,14 +477,14 @@ IMPL_LINK(StylesPreviewWindow_Base, GoUp, const OString&,
/*rItem*/, void)
if (m_nStyleIterator == 0)
m_nStyleIterator = m_aAllStyles.size();
else
-m_nStyleIterator--;
+m_nStyleIterator = m_nStyleIterator - 2;
Update();
}
IMPL_LINK(StylesPreviewWindow_Base, GoDown, const OString&, /*rItem*/, void)
{
-m_nStyleIterator++;
+m_nStyleIterator = m_nStyleIterator + 2;
Update();
}
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index af2eea072998..548aced8073c 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -2560,7 +2560,9 @@ struct SvxStyleToolBoxControl::Impl
"Heading 1",
"Heading 2",
"Heading 3",
-"Quotations"
+"Heading 4",
+"Quotations",
+"Preformatted Text"
};
for( const OUString& aStyle: aWriterStyles )
{
diff --git a/svx/uiconfig/ui/stylespreview.ui b/svx/uiconfig/ui/stylespreview.ui
index fd3edce9cc20..389860619859 100644
--- a/svx/uiconfig/ui/stylespreview.ui
+++ b/svx/uiconfig/ui/stylespreview.ui
@@ -1,32 +1,39 @@
-
+
True
False
True
-6
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/firebird/Util.cxx | 92 ++
1 file changed, 52 insertions(+), 40 deletions(-)
New commits:
commit 5b33b1a6b0f251202e89cef436efd4719c3fc0c4
Author: Julien Nabet
AuthorDate: Wed Oct 28 22:38:28 2020 +0100
Commit: Julien Nabet
CommitDate: Thu Oct 29 22:50:02 2020 +0100
tdf#137801: Firebird fix warn when changing a table having a field type BLOB
OTableController::alterColumns() from
dbaccess/source/ui/tabledesign/TableController.cxx
checks if a column changes with:
if((nType != pField->GetType() ||
sTypeName != pField->GetTypeName() ||
etc
See
https://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/tabledesign/TableController.cxx?r=585cefd1#1002
So for example for "BLOB" field, LO was comparing "SQL_BLOB" from
"sTypeName" with "BLOB" from "pField->GetTypeName()"
In the same way, LO was comparing "SQL_LONG" from "sTypeName" with
"INTEGER" from "pField->GetTypeName()"
or "SQL_VARYING" from "sTypeName" with "VARCHAR" from
"pField->GetTypeName()"
Change-Id: I3632f3ee5845b4f07d606fddd586951a3deea67f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104979
Tested-by: Jenkins
Reviewed-by: Julien Nabet
diff --git a/connectivity/source/drivers/firebird/Util.cxx
b/connectivity/source/drivers/firebird/Util.cxx
index 7befd4b99014..7bdb12b8eb29 100644
--- a/connectivity/source/drivers/firebird/Util.cxx
+++ b/connectivity/source/drivers/firebird/Util.cxx
@@ -181,47 +181,59 @@ sal_Int32 firebird::ColumnTypeInfo::getSdbcType() const
OUString firebird::ColumnTypeInfo::getColumnTypeName() const
{
-short aType = m_aType & ~1; // Remove last bit -- it is used to denote
whether column
-// can store Null, not needed for type determination
-
-switch (aType)
+sal_Int32 nDataType = this->getSdbcType();
+switch (nDataType)
{
- case SQL_TEXT:
- return "SQL_TEXT";
- case SQL_VARYING:
- return "SQL_VARYING";
- case SQL_SHORT:
- return "SQL_SHORT";
- case SQL_LONG:
- return "SQL_LONG";
- case SQL_FLOAT:
- return "SQL_FLOAT";
- case SQL_DOUBLE:
- return "SQL_DOUBLE";
- case SQL_D_FLOAT:
- return "SQL_D_FLOAT";
- case SQL_TIMESTAMP:
- return "SQL_TIMESTAMP";
- case SQL_BLOB:
- return "SQL_BLOB";
- case SQL_ARRAY:
- return "SQL_ARRAY";
- case SQL_TYPE_TIME:
- return "SQL_TYPE_TIME";
- case SQL_TYPE_DATE:
- return "SQL_TYPE_DATE";
- case SQL_INT64:
- return "SQL_INT64";
- case SQL_NULL:
- return "SQL_NULL";
- case SQL_QUAD:
- return "SQL_QUAD";
- case SQL_BOOLEAN:
- return "SQL_BOOLEAN";
- default:
- assert(false); // Should never happen
- return OUString();
-}
+case DataType::BIT:
+return "BIT";
+case DataType::TINYINT:
+return "TINYINT";
+case DataType::SMALLINT:
+return "SMALLINT";
+case DataType::INTEGER:
+return "INTEGER";
+case DataType::BIGINT:
+return "BIGINT";
+case DataType::FLOAT:
+return "FLOAT";
+case DataType::REAL:
+return "REAL";
+case DataType::DOUBLE:
+return "DOUBLE";
+case DataType::NUMERIC:
+return "NUMERIC";
+case DataType::DECIMAL:
+return "DECIMAL";
+case DataType::CHAR:
+return "CHAR";
+case DataType::VARCHAR:
+return "VARCHAR";
+case DataType::LONGVARCHAR:
+return "LONGVARCHAR";
+case DataType::DATE:
+return "DATE";
+case DataType::TIME:
+return "TIME";
+case DataType::TIMESTAMP:
+return "TIMESTAMP";
+case DataType::BINARY:
+return "BINARY";
+case DataType::LONGVARBINARY:
+return "LONGVARBINARY";
+case DataType::ARRAY:
+return "ARRAY";
+case DataType::BLOB:
+return "BLOB";
+case DataType::CLOB:
+return "CLOB";
+case DataType::BOOLEAN:
+return "BOOLEAN";
+case DataType::SQLNULL:
+return "NULL";
+default:
+assert(false); // Should never happen
+return OUString();
+ }
}
short firebird::getFBTypeFromBlrType(short blrType)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 135657] Error activating object: General OLE error.
https://bugs.documentfoundation.org/show_bug.cgi?id=135657 Telesto changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #3 from Telesto --- (In reply to Dieter from comment #2) > I confirm it with > > But I can't assess, if this is a bug or not. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137852] Installed custome font (FLloyd Wright p22 eaglefeather) and it changed menues and lost fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=137852 --- Comment #2 from Carl Gustafson --- I was asked by Uwe Auer if I had recreated my systems font cache using sudo fc-cache -f -v . I did that to no effect. Nothing appears to have changed. is is possible or helpful if I sent you a couple of screenshots of what I am talking about? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend
https://bugs.documentfoundation.org/show_bug.cgi?id=123265 --- Comment #61 from hellwoodfire --- Thank you, Heiko and Maxim! You are awesome! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Dieter changed: What|Removed |Added Depends on||135657 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135657 [Bug 135657] Error activating object: General OLE error. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135657] Error activating object: General OLE error.
https://bugs.documentfoundation.org/show_bug.cgi?id=135657 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| Blocks||90486 --- Comment #2 from Dieter --- I confirm it with Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: he-IL (de_DE); UI: en-GB Calc: threaded But I can't assess, if this is a bug or not. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90486 [Bug 90486] [META] Chart bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/section.cxx | 59 +++--
1 file changed, 31 insertions(+), 28 deletions(-)
New commits:
commit 6b367107d7c51fc868ab0a116019ee26408a0395
Author: Bjoern Michaelsen
AuthorDate: Wed Oct 28 23:16:21 2020 +0100
Commit: Bjoern Michaelsen
CommitDate: Thu Oct 29 22:16:57 2020 +0100
Section: dont call obsolete ModifyNotification directly
Change-Id: Iefc502d5bd7cd3650a4abf3e79794d06fadd894e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104982
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/source/core/docnode/section.cxx
b/sw/source/core/docnode/section.cxx
index 04050ccdbb24..55bc3aee8fe7 100644
--- a/sw/source/core/docnode/section.cxx
+++ b/sw/source/core/docnode/section.cxx
@@ -67,30 +67,35 @@ using namespace ::com::sun::star;
namespace {
-class SwIntrnlSectRefLink : public SwBaseLink
-{
-SwSectionFormat& m_rSectFormat;
+void lcl_SwClientNotify(SwModify& rModify, const SfxPoolItem* pOldNew)
+{
+const sw::LegacyModifyHint aHint(pOldNew, pOldNew);
+rModify.SwClientNotify(rModify, aHint);
+}
-public:
-SwIntrnlSectRefLink(SwSectionFormat& rFormat, SfxLinkUpdateMode
nUpdateType)
-: SwBaseLink(nUpdateType, SotClipboardFormatId::RTF)
-, m_rSectFormat(rFormat)
-{}
+class SwIntrnlSectRefLink : public SwBaseLink
+{
+SwSectionFormat& m_rSectFormat;
-virtual void Closed() override;
-virtual ::sfx2::SvBaseLink::UpdateResult DataChanged(
-const OUString& rMimeType, const css::uno::Any & rValue ) override;
+public:
+SwIntrnlSectRefLink(SwSectionFormat& rFormat, SfxLinkUpdateMode
nUpdateType)
+: SwBaseLink(nUpdateType, SotClipboardFormatId::RTF)
+, m_rSectFormat(rFormat)
+{}
-virtual const SwNode* GetAnchor() const override;
-virtual bool IsInRange( sal_uLong nSttNd, sal_uLong nEndNd ) const
override;
+virtual void Closed() override;
+virtual ::sfx2::SvBaseLink::UpdateResult DataChanged(
+const OUString& rMimeType, const css::uno::Any & rValue ) override;
-SwSectionNode* GetSectNode()
-{
-const SwNode* pSectNd( GetAnchor() );
-return const_cast( dynamic_cast(
pSectNd ) );
-}
-};
+virtual const SwNode* GetAnchor() const override;
+virtual bool IsInRange( sal_uLong nSttNd, sal_uLong nEndNd ) const
override;
+SwSectionNode* GetSectNode()
+{
+const SwNode* pSectNd( GetAnchor() );
+return const_cast( dynamic_cast( pSectNd ) );
+}
+};
}
SwSectionData::SwSectionData(SectionType const eType, OUString const& rName)
@@ -254,7 +259,7 @@ SwSection::~SwSection()
// If the Section is the last Client in the Format we can delete it
SwPtrMsgPoolItem aMsgHint( RES_REMOVE_UNO_OBJECT, pFormat );
-pFormat->ModifyNotification( , );
+lcl_SwClientNotify(*pFormat, );
if( !pFormat->HasWriterListeners() )
{
// Do not add to the Undo. This should've happened earlier.
@@ -315,7 +320,7 @@ void SwSection::ImplSetHiddenFlag(bool const bTmpHidden,
bool const bCondition)
// Tell all Children that they are hidden
SwMsgPoolItem aMsgItem( RES_SECTION_HIDDEN );
-pFormat->ModifyNotification( , );
+lcl_SwClientNotify(*pFormat, );
// Delete all Frames
pFormat->DelFrames();
@@ -330,7 +335,7 @@ void SwSection::ImplSetHiddenFlag(bool const bTmpHidden,
bool const bCondition)
{
// Tell all Children that the Parent is not hidden anymore
SwMsgPoolItem aMsgItem( RES_SECTION_NOT_HIDDEN );
-pFormat->ModifyNotification( , );
+lcl_SwClientNotify(*pFormat, );
pFormat->MakeFrames();
}
@@ -716,7 +721,7 @@ void SwSectionFormat::DelFrames()
if( pCNd )
{
const SfxPoolItem& rItem = pCNd->GetSwAttrSet().Get( RES_PAGEDESC );
-pCNd->ModifyNotification( , );
+lcl_SwClientNotify(*pCNd, );
}
}
@@ -968,16 +973,14 @@ void SwSectionFormat::UpdateParent()
if (!pProtect->IsContentProtected() !=
!pSection->IsProtectFlag())
{
-pLast->ModifyNotification( static_cast(pProtect),
-static_cast(pProtect) );
+lcl_SwClientNotify(*static_cast(pLast),
static_cast(pProtect));
}
// edit in readonly sections
if (!pEditInReadonly->GetValue() !=
!pSection->IsEditInReadonlyFlag())
{
-pLast->ModifyNotification( static_cast(pEditInReadonly),
-static_cast(pEditInReadonly) );
+lcl_SwClientNotify(*static_cast(pLast),
static_cast(pEditInReadonly));
}
if( bIsHidden ==
[Libreoffice-bugs] [Bug 137452] Reducing the size of a centered image results in a gap
https://bugs.documentfoundation.org/show_bug.cgi?id=137452 Dieter changed: What|Removed |Added Blocks||103152 Ever confirmed|0 |1 Whiteboard| QA:needsComment| OS|Linux (All) |All CC||dgp-m...@gmx.de Status|UNCONFIRMED |NEW --- Comment #1 from Dieter --- I confirm it with Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: he-IL (de_DE); UI: en-GB Calc: threaded With enabled formatting marks you can see, that there is still a formating mark, but wthiout a function Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103152 [Bug 103152] [META] Writer image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152 Dieter changed: What|Removed |Added Depends on||137452 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137452 [Bug 137452] Reducing the size of a centered image results in a gap -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123265] Show menu icons by default in GTK3 Backend
https://bugs.documentfoundation.org/show_bug.cgi?id=123265 --- Comment #60 from Vincent Bamps --- I tested LibreOffice version 7.0.3 on Linux 18 Mint Cinnamon 64-bit. It works. I was stuck on version LibreOffice 6.3.5 because the problem occurred for the next versions and till version 7.0.3. Thanks a lot to all the people working on this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137484] "Restart Numbering" does not "stick" for first list in a document
https://bugs.documentfoundation.org/show_bug.cgi?id=137484 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- I can't confirm it with Version: 7.0.2.2 (x64) Build ID: 8349ace3c3162073abd90d81fd06dcfb6b36b994 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: he-IL (de_DE); UI: en-GB Calc: threaded But I didn't test with master document. If this is the focus of your bug, you should adjust bug summary and steps to reproduce. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137864] New: Master slides formatting for outline text format not saved (and rendered)
https://bugs.documentfoundation.org/show_bug.cgi?id=137864 Bug ID: 137864 Summary: Master slides formatting for outline text format not saved (and rendered) Product: LibreOffice Version: 7.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Master slides formatting for outline text format not saved (and rendered) Steps to Reproduce: 1. Open Impress 2. View -> Master Slide 3. Select the The Outline Format Object area (auto layout) 4. Right click -> Area -> Apply a background color 5. Right click -> Line -> Select lovely continuous line with nice width 6. Go back to normal mode 7. Press Enter in slide panel (to add a new slide) -> No effect of Master slide 8. Save the file 9. Reload 10. look at the master slide -> empty Actual Results: 1. They formatting is not applied to the first slide (I think it should), but off topic here 2. They formatting is lost Expected Results: Formatting of master slide should work Reproducible: Always User Profile Reset: No Additional Info: Found in Version: 7.1.0.0.alpha0+ (x64) Build ID: 94e6e140491de31c0788c91af855a75a3bb12709 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL not in 6.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137864] Master slides formatting for outline text format not saved (and rendered)
https://bugs.documentfoundation.org/show_bug.cgi?id=137864 Telesto changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-0' - svtools/source
svtools/source/control/ctrlbox.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 25f8e4c43d8a083199077256ee6d7430d29d0ae3
Author: Jan-Marek Glogowski
AuthorDate: Thu Oct 29 17:22:03 2020 +0100
Commit: Caolán McNamara
CommitDate: Thu Oct 29 21:50:10 2020 +0100
tdf#132536 free the cached VirtualDevices
Once again I forgot, that VclPtr is not really a shared pointer,
as someone has to release the contained instance. It just prevents
others from working on a dangling pointer and also freeing the
contained instance multiple times. Using a "Scoped" variant
in the vector instead of the loop doesn't compile.
This fixes the major memory leak when deleting the last
FontNameBox, which freed the caching VclPtr vector but not the
contained VirtualDevice instances. It seems there is still some
other minor leak left to fix, probably unrelated to the regressing
patch.
Found, after I realized the memory leak just happened with font
preview enabled...
Regressed-by: 2e0a32b51681fb356699b4a722f461f55a46b890
Change-Id: Ic0c60cd31bb6dabf03b0f8bd232390e784421588
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105017
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit d11e6edec3116f647fa085a297e29c677f5b8662)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104961
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/svtools/source/control/ctrlbox.cxx
b/svtools/source/control/ctrlbox.cxx
index 555d35a94aa0..4a57f2e5b7fe 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -359,6 +359,8 @@ FontNameBox::~FontNameBox()
--gFontNameBoxes;
if (!gFontNameBoxes)
{
+for (auto : gFontPreviewVirDevs)
+rDev.disposeAndClear();
gFontPreviewVirDevs.clear();
gRenderedFontNames.clear();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137844] Cannot rename slide if space is kept
https://bugs.documentfoundation.org/show_bug.cgi?id=137844 --- Comment #2 from Telesto --- Hmm strange not in Draw -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137844] Cannot rename slide if space is kept
https://bugs.documentfoundation.org/show_bug.cgi?id=137844 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- confirm Version: 7.1.0.0.alpha0+ (x64) Build ID: fca525d570f4fada3db1a9bbee2e88a5a02839d9 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111448] libreoffice calc does not save(or load) position, size and orientation of embedded pictures correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=111448 Regina Henschel changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de |desktop.org | Status|NEW |ASSIGNED --- Comment #16 from Regina Henschel --- It is a file open error with vertical flipped custom shapes. Proposed patch is in https://gerrit.libreoffice.org/c/core/+/104643. Waiting for review. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137754] Crash when applying styles in a table within Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=137754 Commit Notification changed: What|Removed |Added Whiteboard||target:7.1.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137754] Crash when applying styles in a table within Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=137754 --- Comment #9 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9f6fbe36da3d53df0b64c41e9ea51cc20d442a30 tdf#137754 Crash in styles tree in sidebar in impress It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/templdlg.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 9f6fbe36da3d53df0b64c41e9ea51cc20d442a30 Author: Noel Grandin AuthorDate: Thu Oct 29 19:55:37 2020 +0200 Commit: Noel Grandin CommitDate: Thu Oct 29 21:29:59 2020 +0100 tdf#137754 Crash in styles tree in sidebar in impress this is a timing bug - easier to hit on a slow machine, or with a debug build - it happens when mouse movement triggers a request for a tooltip in the tree, but the tree is in a transition state. Change-Id: Ibed7ffd01483b26f2debb1aa9cc99e23b38ba950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105025 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx index e9bfc17fa876..a23b4d904dd5 100644 --- a/sfx2/source/dialog/templdlg.cxx +++ b/sfx2/source/dialog/templdlg.cxx @@ -241,6 +241,8 @@ IMPL_LINK(SfxCommonTemplateDialog_Impl, QueryTooltipHdl, const weld::TreeIter&, OUString sQuickHelpText(aTemplName); const SfxStyleFamilyItem* pItem = GetFamilyItem_Impl(); +if (!pItem) +return sQuickHelpText; SfxStyleSheetBase* pStyle = pStyleSheetPool->Find(aTemplName, pItem->GetFamily()); if (pStyle && pStyle->IsUsed()) // pStyle is in use in the document? ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137754] Crash when applying styles in a table within Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=137754 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/inc/treeopt.hxx |2 -
cui/source/options/treeopt.cxx | 55 ++---
2 files changed, 31 insertions(+), 26 deletions(-)
New commits:
commit 78c6e88e163f50eccc1cebdb2defe9ec4af248ce
Author: Caolán McNamara
AuthorDate: Thu Oct 29 16:56:54 2020 +
Commit: Caolán McNamara
CommitDate: Thu Oct 29 21:22:25 2020 +0100
have just the one handler for ok/apply options
'apply' is only really working the first time it is pressed in a page, I
want
to be able to apply to change e.g. notebookbar icon size and then change
that
again and apply and get the expected display size
Change-Id: I7f051ad4063f0e99f822cc06fbe4a0ab49588fbd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105020
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index 4c7bfe8986ac..eb4b93526356 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -161,8 +161,8 @@ private:
DECL_LINK(ShowPageHdl_Impl, weld::TreeView&, void);
DECL_LINK(BackHdl_Impl, weld::Button&, void);
DECL_LINK(ApplyHdl_Impl, weld::Button&, void);
-DECL_LINK(OKHdl_Impl, weld::Button&, void);
DECL_LINK(HelpHdl_Impl, weld::Widget&, bool);
+void ResetCurrentPageFromConfig();
void SelectHdl_Impl();
virtual short run() override;
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 7b537238f9c5..d4250052df3f 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -620,7 +620,7 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, ShowPageHdl_Impl,
weld::TreeView&, void)
SelectHdl_Impl();
}
-IMPL_LINK_NOARG(OfaTreeOptionsDialog, BackHdl_Impl, weld::Button&, void)
+void OfaTreeOptionsDialog::ResetCurrentPageFromConfig()
{
if (!(xCurrentPageEntry && xTreeLB->get_iter_depth(*xCurrentPageEntry)))
return;
@@ -638,6 +638,11 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, BackHdl_Impl,
weld::Button&, void)
pPageInfo->m_xExtPage->ResetPage();
}
+IMPL_LINK_NOARG(OfaTreeOptionsDialog, BackHdl_Impl, weld::Button&, void)
+{
+ResetCurrentPageFromConfig();
+}
+
void OfaTreeOptionsDialog::ApplyOptions()
{
std::unique_ptr xEntry = xTreeLB->make_iterator();
@@ -671,19 +676,6 @@ void OfaTreeOptionsDialog::ApplyOptions()
}
}
-IMPL_LINK_NOARG(OfaTreeOptionsDialog, ApplyHdl_Impl, weld::Button&, void)
-{
-ApplyOptions();
-
-if ( bNeedsRestart )
-{
-SolarMutexGuard aGuard;
-if
(svtools::executeRestartDialog(comphelper::getProcessComponentContext(),
-m_xDialog.get(), eRestartReason))
-m_xDialog->response(RET_OK);
-}
-}
-
IMPL_LINK_NOARG(OfaTreeOptionsDialog, HelpHdl_Impl, weld::Widget&, bool)
{
Help* pHelp = Application::GetHelp();
@@ -700,8 +692,10 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, HelpHdl_Impl,
weld::Widget&, bool)
return true;
}
-IMPL_LINK_NOARG(OfaTreeOptionsDialog, OKHdl_Impl, weld::Button&, void)
+IMPL_LINK(OfaTreeOptionsDialog, ApplyHdl_Impl, weld::Button&, rButton, void)
{
+bool bOkPressed = == xOkPB.get();
+
if (xCurrentPageEntry && xTreeLB->get_iter_depth(*xCurrentPageEntry))
{
OptionsPageInfo* pPageInfo =
reinterpret_cast(xTreeLB->get_id(*xCurrentPageEntry).toInt64());
@@ -717,17 +711,30 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, OKHdl_Impl,
weld::Button&, void)
DeactivateRC nLeave =
pPageInfo->m_xPage->DeactivatePage(pGroupInfo->m_pOutItemSet.get());
if ( nLeave == DeactivateRC::KeepPage )
{
-// the page mustn't be left
-xTreeLB->select(*xCurrentPageEntry);
-return;
+// the page mustn't be left, so return early
+assert(xTreeLB->is_selected(*xCurrentPageEntry)); //
presumably this must be true here
+if (bOkPressed)
+return;
}
}
-pPageInfo->m_xPage->set_visible(false);
}
}
ApplyOptions();
-m_xDialog->response(RET_OK);
+ApplyItemSets();
+utl::ConfigManager::storeConfigItems();
+
+if (bOkPressed)
+m_xDialog->response(RET_OK);
+else
+{
+// for the Apply case, now that the settings are saved to config,
+// reload the current page so it knows what the config now states
+ResetCurrentPageFromConfig();
+// reselect it to undo possible DeactivatePage above
+xCurrentPageEntry.reset();
+SelectHdl_Impl();
+}
if ( bNeedsRestart )
{
@@ -735,9 +742,6 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, OKHdl_Impl,
weld::Button&, void)
::svtools::executeRestartDialog(comphelper::getProcessComponentContext(),
m_pParent, eRestartReason);
}
-
-ApplyItemSets();
[Libreoffice-commits] core.git: cui/source
cui/source/inc/treeopt.hxx |2 +-
cui/source/options/treeopt.cxx | 11 ---
2 files changed, 5 insertions(+), 8 deletions(-)
New commits:
commit 806c696ccdac69e274cbfeac0cb45ea59555c01d
Author: Caolán McNamara
AuthorDate: Thu Oct 29 16:04:13 2020 +
Commit: Caolán McNamara
CommitDate: Thu Oct 29 21:22:09 2020 +0100
call ExtPage::DeactivatePage for apply as well as ok
I think the concerns at https://gerrit.libreoffice.org/c/core/+/54980/
are on balance overly conservative and its safer to make apply behave
the same as ok wrt that call
Change-Id: I889290c23dc9a7d4bb751769a509932142be5795
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105019
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index e0ec4eb42354..4c7bfe8986ac 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -156,7 +156,7 @@ private:
static VectorOfNodes LoadNodes( Module* pModule, const OUString&
rExtensionId );
voidInsertNodes( const VectorOfNodes& rNodeList );
-voidApplyOptions( bool deactivate );
+voidApplyOptions();
DECL_LINK(ShowPageHdl_Impl, weld::TreeView&, void);
DECL_LINK(BackHdl_Impl, weld::Button&, void);
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 5cb3fde4677b..7b537238f9c5 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -638,7 +638,7 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, BackHdl_Impl,
weld::Button&, void)
pPageInfo->m_xExtPage->ResetPage();
}
-void OfaTreeOptionsDialog::ApplyOptions(bool deactivate)
+void OfaTreeOptionsDialog::ApplyOptions()
{
std::unique_ptr xEntry = xTreeLB->make_iterator();
bool bEntry = xTreeLB->get_iter_first(*xEntry);
@@ -658,10 +658,7 @@ void OfaTreeOptionsDialog::ApplyOptions(bool deactivate)
if ( pPageInfo->m_xExtPage )
{
-if ( deactivate )
-{
-pPageInfo->m_xExtPage->DeactivatePage();
-}
+pPageInfo->m_xExtPage->DeactivatePage();
pPageInfo->m_xExtPage->SavePage();
}
if ( pPageInfo->m_xPage && RID_OPTPAGE_CHART_DEFCOLORS ==
pPageInfo->m_nPageId )
@@ -676,7 +673,7 @@ void OfaTreeOptionsDialog::ApplyOptions(bool deactivate)
IMPL_LINK_NOARG(OfaTreeOptionsDialog, ApplyHdl_Impl, weld::Button&, void)
{
-ApplyOptions(/*deactivate =*/false);
+ApplyOptions();
if ( bNeedsRestart )
{
@@ -729,7 +726,7 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, OKHdl_Impl,
weld::Button&, void)
}
}
-ApplyOptions(/*deactivate =*/ true);
+ApplyOptions();
m_xDialog->response(RET_OK);
if ( bNeedsRestart )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/options/treeopt.cxx | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
New commits:
commit bdd9ccc3f1a0db9345ad0a0109aa8b65405650ab
Author: Caolán McNamara
AuthorDate: Thu Oct 29 16:01:02 2020 +
Commit: Caolán McNamara
CommitDate: Thu Oct 29 21:21:41 2020 +0100
move block for RET_OK conditional return into Ok handler
making it clearer what happens on "ok", no logic change intended
Change-Id: I1d57500d2fbeded4cd7c7fd48fd1f4296b78e41d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105018
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 8ec8a0b3d252..5cb3fde4677b 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -738,6 +738,9 @@ IMPL_LINK_NOARG(OfaTreeOptionsDialog, OKHdl_Impl,
weld::Button&, void)
::svtools::executeRestartDialog(comphelper::getProcessComponentContext(),
m_pParent, eRestartReason);
}
+
+ApplyItemSets();
+utl::ConfigManager::storeConfigItems();
}
void OfaTreeOptionsDialog::ApplyItemSets()
@@ -1932,15 +1935,7 @@ short OfaTreeOptionsDialog::run()
pClamp.reset( new SvxDicListChgClamp( xDictionaryList ) );
}
-short nRet = SfxOkDialogController::run();
-
-if( RET_OK == nRet )
-{
-ApplyItemSets();
-utl::ConfigManager::storeConfigItems();
-}
-
-return nRet;
+return SfxOkDialogController::run();
}
// class ExtensionsTabPage ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: idl/Executable_svidl.mk
idl/Executable_svidl.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 1ec39615b91b299c48be90f134840d89517ab4c3 Author: Caolán McNamara AuthorDate: Thu Oct 29 17:12:41 2020 + Commit: Caolán McNamara CommitDate: Thu Oct 29 21:20:57 2020 +0100 fix oss-fuzz build failure /work/instdir/program/libtllo.a(stream.o):stream.cxx:function tools::isEmptyFileUrl(rtl::OUString const&): error: undefined reference to 'comphelper::isFileUrl(rtl::OUString const&)' /src/libreoffice/solenv/gbuild/LinkTarget.mk:667: recipe for target '/work/workdir/LinkTarget/Executable/svidl' failed Change-Id: I9ed31787c6d98ea516dd6927f8aa8b589c3b9824 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105024 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/idl/Executable_svidl.mk b/idl/Executable_svidl.mk index fe0933795392..b710f0542429 100644 --- a/idl/Executable_svidl.mk +++ b/idl/Executable_svidl.mk @@ -33,6 +33,7 @@ $(eval $(call gb_Executable_set_include,svidl,\ $(eval $(call gb_Executable_use_sdk_api,svidl)) $(eval $(call gb_Executable_use_libraries,svidl,\ + comphelper \ tl \ sal \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - 7 commits - configure.ac l10ntools/inc l10ntools/source sal/osl sal/qa
configure.ac |2 +-
l10ntools/inc/tokens.h |2 +-
l10ntools/source/export.cxx |2 +-
l10ntools/source/srclex.l|4 ++--
sal/osl/all/log.cxx | 27 +++
sal/qa/osl/file/osl_File.cxx |2 +-
6 files changed, 21 insertions(+), 18 deletions(-)
New commits:
commit 100c2a51604a1bde45062426fb4a05c0502142d5
Author: Samuel Mehrbrodt
AuthorDate: Thu Oct 29 21:18:37 2020 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Oct 29 21:20:09 2020 +0100
Release 5.4.13
Change-Id: Ib459674dc1970636ab0050401bda915b7b3c0e4c
diff --git a/configure.ac b/configure.ac
index 9f2d8bb17402..83ac32bdd8b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([LibreOffice],[5.4.12.0],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[5.4.13.0],[],[],[http://documentfoundation.org/])
AC_PREREQ([2.59])
commit 28cca6737cdc83e50023181aa8328e225e46e886
Author: Samuel Mehrbrodt
AuthorDate: Thu Oct 29 21:19:24 2020 +0100
Commit: Samuel Mehrbrodt
CommitDate: Thu Oct 29 21:20:09 2020 +0100
Fix build with recent WIN SDK
TEXT was already defined somewhere
Change-Id: If78ed6fd2c7d7d75a977ca531b8fbb399ec0b5dd
diff --git a/l10ntools/inc/tokens.h b/l10ntools/inc/tokens.h
index 95370cf70a7e..6d0d15d72e5e 100644
--- a/l10ntools/inc/tokens.h
+++ b/l10ntools/inc/tokens.h
@@ -42,7 +42,7 @@
#define SMALRESOURCE505 /* PageItem { */
#define TEXTLINE506 /* TEXT = "hhh" */
#define LONGTEXTLINE507 /* TEXT = "hhh" TEST "HHH" ... */
-#define TEXT508 /* "Something like this"*/
+#define _TEXT508 /* "Something like this"*/
#define LEVELUP 509 /* {*/
#define LEVELDOWN 510 /* }; */
#define APPFONTMAPPING 511 /* MAP_APPFONT(10,10) */
diff --git a/l10ntools/source/export.cxx b/l10ntools/source/export.cxx
index b4995ca04fb5..8c6a21b8a8b9 100644
--- a/l10ntools/source/export.cxx
+++ b/l10ntools/source/export.cxx
@@ -557,7 +557,7 @@ void Export::Execute( int nToken, const char * pToken )
}
}
break;
-case TEXT:
+case _TEXT:
case LISTTEXT_:
case LISTTEXT: {
// this is an entry for a List
diff --git a/l10ntools/source/srclex.l b/l10ntools/source/srclex.l
index 8fbb58361319..894807271e66 100644
--- a/l10ntools/source/srclex.l
+++ b/l10ntools/source/srclex.l
@@ -135,8 +135,8 @@ void YYWarning();
}
\".*\" {
-/* TEXT // "A Text" */
- WorkOnTokenSet( TEXT, yytext );
+/* _TEXT // "A Text" */
+ WorkOnTokenSet( _TEXT, yytext );
}
"{"[ \t]*\\? {
commit a3e9cd54b3ee4658cc0429c8858beea86035616a
Author: Thorsten Behrens
AuthorDate: Tue Jun 5 14:23:08 2018 +0200
Commit: Samuel Mehrbrodt
CommitDate: Thu Oct 29 20:33:36 2020 +0100
sal: WNT -> _WIN32
Still some holdouts from that bad old habit it seems.
Reviewed-on: https://gerrit.libreoffice.org/55331
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 92ed91610d30246e671226da081da748f6b16aae)
Change-Id: Ib0fe2c7eb006649b121668c549ff8e0bb060e120
diff --git a/sal/osl/all/log.cxx b/sal/osl/all/log.cxx
index 0fa1a75cd54e..b9d54fb200f2 100644
--- a/sal/osl/all/log.cxx
+++ b/sal/osl/all/log.cxx
@@ -31,7 +31,7 @@
#if defined ANDROID
#include
-#elif defined WNT
+#elif defined _WIN32
#include
#include
#define OSL_DETAIL_GETPID _getpid()
@@ -100,7 +100,7 @@ char const * getEnvironmentVariable(const char* env) {
return p2;
}
-#ifdef WNT
+#ifdef _WIN32
# define INI_STRINGBUF_SIZE 1024
bool getValueFromLoggingIniFile(const char* key, char* value) {
@@ -143,7 +143,7 @@ char const * getLogLevel() {
if (env != nullptr)
return env;
-#ifdef WNT
+#ifdef _WIN32
static char logLevel[INI_STRINGBUF_SIZE];
if (getValueFromLoggingIniFile("LogLevel", logLevel))
return logLevel;
@@ -158,7 +158,7 @@ std::ofstream * getLogFile() {
if (!logFile)
{
-#ifdef WNT
+#ifdef _WIN32
static char logFilePath[INI_STRINGBUF_SIZE];
if (getValueFromLoggingIniFile("LogFilePath", logFilePath))
logFile = logFilePath;
diff --git a/sal/qa/osl/file/osl_File.cxx b/sal/qa/osl/file/osl_File.cxx
index 4e635a1d559f..d62ae760ea12 100644
--- a/sal/qa/osl/file/osl_File.cxx
+++ b/sal/qa/osl/file/osl_File.cxx
@@ -5085,7 +5085,7 @@ namespace osl_Directory
rc != osl::FileBase::E_None
);
}
-#endif /* WNT */
+#endif /*
[Libreoffice-bugs] [Bug 137542] SIGSEGV on tab cycling focus to input field in a table cell
https://bugs.documentfoundation.org/show_bug.cgi?id=137542
--- Comment #3 from chark...@pobox.com ---
I am not really familiar with the LO code base, but tried to at least narrow
down the source of the crash. When triggering the focus change,
SwTextShell::ExecField is called and triggers this case:
case FN_GOTO_NEXT_INPUTFLD:
case FN_GOTO_PREV_INPUTFLD:
{
bool bRet = false;
SwFieldType* pField = rSh.GetFieldType( 0, SwFieldIds::Input );
const bool bAddSetExpressionFields = !(
rSh.GetViewOptions()->IsReadonly() );
if ( pField != nullptr
&& rSh.MoveFieldType(
pField,
FN_GOTO_NEXT_INPUTFLD == nSlot,
SwFieldIds::Unknown,
bAddSetExpressionFields ) )
{
rSh.ClearMark();
if (!rSh.IsMultiSelection()
&& (nullptr != dynamic_cast(
SwCursorShell::GetTextFieldAtCursor(rSh.GetCursor(), true
{
rSh.SttSelect();
rSh.SelectText(
SwCursorShell::StartOfInputFieldAtPos(
*(rSh.GetCursor()->Start()) ) + 1,
SwCursorShell::EndOfInputFieldAtPos(
*(rSh.GetCursor()->Start()) ) - 1 );
}
else
{
rSh.StartInputFieldDlg(rSh.GetCurField(true), false,
false, GetView().GetFrameWeld());
}
bRet = true;
}
rReq.SetReturnValue( SfxBoolItem( nSlot, bRet ));
}
break;
In the working case, SwCursorShell::GetTextFieldAtCursor(...) != nullptr and
the nested if condition is true and focus changes without problem. In the
broken case, SwCursorShell::GetTextFieldAtCursor(...) == nullptr, triggering
the else case of the nested if, eventually leading to the segfault. Digging
further into the GetTextFieldAtCursor code path, the difference arises down in
lcl_GetTextAttrs in sw/source/core/txtnode/ndtxt.cxx:
static void
lcl_GetTextAttrs(
std::vector *const pVector,
SwTextAttr **const ppTextAttr,
SwpHints const *const pSwpHints,
sal_Int32 const nIndex, sal_uInt16 const nWhich,
enum SwTextNode::GetTextAttrMode const eMode)
When this function is called during focus change in the working case, pSwpHints
has a single hint which is assigned to *ppTextAttr, which is then used to get
the GetTextFieldAtCursor return value. In the broken case (with text preceding
the second input field), pSwpHints has TWO hints, with the hint from the
working case at index 1 and another hint at index 0. This block of code in that
function breaks early in the broken case:
sal_Int32 const nHintStart = pHint->GetStart();
if (nIndex < nHintStart)
break; // hints are sorted by which, so we are done...
nIndex=0 and nHintStart=0 in the working case, but nIndex=0 and nHintStart=1 in
the broken case. Hopefully this will hope narrow things down for someone
familiar with this code. It might be a while before I can get back to it!
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108747] [META] File properties/settings (meta data) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108747 Bug 108747 depends on bug 136983, which changed state. Bug 136983 Summary: Wrong setting for DOC properties https://bugs.documentfoundation.org/show_bug.cgi?id=136983 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
