[Libreoffice-bugs] [Bug 138956] Pattern fill not available (and can cause crash)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138956

V Stuart Foote  changed:

   What|Removed |Added

 Attachment #168300|crash stack trace of STR|crash stack trace of STR
description|from dupe bug 138956|changing area fill from
   |changing area fill from |bitmap to pattern SB
   |bitmap to pattern SB|Properties deck, similar
   |Properties deck, similar|with Area fill dialog
   |with Area fill dialog   |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138973] Sidebar Gallery deck crashing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138973

--- Comment #8 from V Stuart Foote  ---
Created attachment 168301
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168301=edit
crash stack trace of STR from dupe bug 138956 changing area fill from bitmap to
pattern SB Properties deck, similar with Area fill dialog


As with OP here, STR of bug 138956 do not crash with default GDI rendering, but
do crash with Skia (Vulkan or raster).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138956] Pattern fill not available (and can cause crash)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138956

--- Comment #6 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #5)
> Created attachment 168300 [details]
> crash stack trace of STR from dupe bug 138956 changing area fill from bitmap
> to pattern SB Properties deck, similar with Area fill dialog

As with OP here, STR of bug 138956 do not crash with default GDI rendering, but
do crash with Skia (Vulkan or raster).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138956] Pattern fill not available (and can cause crash)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138956

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #5 from V Stuart Foote  ---
Created attachment 168300
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168300=edit
crash stack trace of STR from dupe bug 138956 changing area fill from bitmap to
pattern SB Properties deck, similar with Area fill dialog

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138975] category dialogs in template manager should not show "None" as category

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138975

--- Comment #5 from sdc.bla...@youmail.dk ---
(In reply to Peter Toye from comment #4)
> and then what happens if someone decides to have a subdirectory called
> 'none'? 
In my tests:

1.  In Template Manager:  Can add a new category "None" and delete the category
"None" as well. (no problem)

2.  Can add manually the directory "None" to a "user path" and it shows up in
the Category list  (as expected).  And can be deleted.

Can be a little fiddly, if you try your own tests -- because of "refresh"
problem -- but summa summarum:   No problem with a user-created category called
"None" 

> This exposes what seems to me to be a design problem - by using the
> same mechanism (subdirectory) to expose two separate concepts (category and
> file container), they get confused.
I think this assertion is wrong. You have not studied my updated help about
categories and groupuinames.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - xmlsecurity/qa xmlsecurity/source

[Miklos Vajna (via logerrit)]

 xmlsecurity/qa/unit/pdfsigning/data/bad-cert-p3-stamp.pdf |binary
 xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx |   18 
 xmlsecurity/source/pdfio/pdfdocument.cxx  |   63 --
 3 files changed, 76 insertions(+), 5 deletions(-)

New commits:
commit 4c04745a2deee6590970d5139be958817b8b3591
Author: Miklos Vajna 
AuthorDate: Wed Nov 4 21:39:04 2020 +0100
Commit: Miklos Vajna 
CommitDate: Fri Dec 18 16:52:07 2020 +0100

xmlsecurity: reject a few dangerous annotation types during pdf sig verify

(cherry picked from commit f231dacde9df1c4aa5f4e0970535c4f4093364a7)

Conflicts:
include/vcl/filter/PDFiumLibrary.hxx
xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
xmlsecurity/source/helper/pdfsignaturehelper.cxx
xmlsecurity/source/pdfio/pdfdocument.cxx

Change-Id: I950b49a6e7181639daf27348ddfa0f36586baa65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107969
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/xmlsecurity/qa/unit/pdfsigning/data/bad-cert-p3-stamp.pdf 
b/xmlsecurity/qa/unit/pdfsigning/data/bad-cert-p3-stamp.pdf
new file mode 100644
index ..b30f5b03867c
Binary files /dev/null and 
b/xmlsecurity/qa/unit/pdfsigning/data/bad-cert-p3-stamp.pdf differ
diff --git a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx 
b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
index 899a7567c4a3..91e565cf2813 100644
--- a/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
+++ b/xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
@@ -73,6 +73,7 @@ public:
 void testPartial();
 void testPartialInBetween();
 void testBadCertP1();
+void testBadCertP3Stamp();
 /// Test writing a PAdES signature.
 void testSigningCertificateAttribute();
 /// Test that we accept files which are supposed to be good.
@@ -96,6 +97,7 @@ public:
 CPPUNIT_TEST(testPartial);
 CPPUNIT_TEST(testPartialInBetween);
 CPPUNIT_TEST(testBadCertP1);
+CPPUNIT_TEST(testBadCertP3Stamp);
 CPPUNIT_TEST(testSigningCertificateAttribute);
 CPPUNIT_TEST(testGood);
 CPPUNIT_TEST(testTokenize);
@@ -419,6 +421,22 @@ void PDFSigningTest::testBadCertP1()
  rInformation.nStatus);
 }
 
+void PDFSigningTest::testBadCertP3Stamp()
+{
+std::vector aInfos
+= verify(m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"bad-cert-p3-stamp.pdf", 1,
+ /*rExpectedSubFilter=*/OString());
+CPPUNIT_ASSERT(!aInfos.empty());
+SignatureInformation& rInformation = aInfos[0];
+
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 0 (SecurityOperationStatus_UNKNOWN)
+// - Actual  : 1 (SecurityOperationStatus_OPERATION_SUCCEEDED)
+// i.e. adding a stamp annotation was not considered as a bad modification.
+
CPPUNIT_ASSERT_EQUAL(xml::crypto::SecurityOperationStatus::SecurityOperationStatus_UNKNOWN,
+ rInformation.nStatus);
+}
+
 void PDFSigningTest::testSigningCertificateAttribute()
 {
 // Create a new signature.
diff --git a/xmlsecurity/source/pdfio/pdfdocument.cxx 
b/xmlsecurity/source/pdfio/pdfdocument.cxx
index 7b697d6d86eb..160bbee6bcde 100644
--- a/xmlsecurity/source/pdfio/pdfdocument.cxx
+++ b/xmlsecurity/source/pdfio/pdfdocument.cxx
@@ -38,6 +38,11 @@
 #include 
 #include 
 #include 
+#include 
+
+#if HAVE_FEATURE_PDFIUM
+#include 
+#endif
 
 #ifdef XMLSEC_CRYPTO_NSS
 #include 
@@ -167,8 +172,29 @@ bool IsCompleteSignature(SvStream& rStream, 
vcl::filter::PDFDocument& rDocument,
 return std::find(rAllEOFs.begin(), rAllEOFs.end(), nFileEnd) != 
rAllEOFs.end();
 }
 
+/**
+ * Contains checksums of a PDF page, which is rendered without annotations. It 
also contains
+ * the geometry of a few dangerous annotation types.
+ */
+struct PageChecksum
+{
+BitmapChecksum m_nPageContent;
+std::vector m_aAnnotations;
+bool operator==(const PageChecksum& rChecksum) const;
+};
+
+bool PageChecksum::operator==(const PageChecksum& rChecksum) const
+{
+if (m_nPageContent != rChecksum.m_nPageContent)
+{
+return false;
+}
+
+return m_aAnnotations == rChecksum.m_aAnnotations;
+}
+
 /// Collects the checksum of each page of one version of the PDF.
-void AnalyizeSignatureStream(SvMemoryStream& rStream, 
std::vector& rPageChecksums,
+void AnalyizeSignatureStream(SvMemoryStream& rStream, 
std::vector& rPageChecksums,
  int nMDPPerm)
 {
 #if HAVE_FEATURE_PDFIUM
@@ -185,8 +211,35 @@ void AnalyizeSignatureStream(SvMemoryStream& rStream, 
std::vectorgetChecksum(nMDPPerm);
-rPageChecksums.push_back(nPageChecksum);
+PageChecksum aPageChecksum;
+aPageChecksum.m_nPageContent = pPdfPage->getChecksum(nMDPPerm);
+for (int i = 0; i < FPDFPage_GetAnnotCount(pPdfPage->getPointer()); 
++i)
+{
+FPDF_ANNOTATION pAnnotation = 

[Libreoffice-bugs] [Bug 138865] Selecting a tree view row with a check box entry toggles the entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138865

--- Comment #13 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/ee601c71908dc05fb0f3bd6c4916041d889e96e2

tdf#138865 don't set ColumnToggleType::Check

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138865] Selecting a tree view row with a check box entry toggles the entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138865

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|target:7.2.0 target:7.1.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139040] BASE: Open two same report when press "enter" key on report name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139040

Alexey Chernous  changed:

   What|Removed |Added

Summary|BASE: Open two report when  |BASE: Open two same report
   |press "enter" key on report |when press "enter" key on
   |name|report name

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - cui/source

[Jan-Marek Glogowski (via logerrit)]

 cui/source/options/fontsubs.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit ee601c71908dc05fb0f3bd6c4916041d889e96e2
Author: Jan-Marek Glogowski 
AuthorDate: Thu Dec 17 19:30:26 2020 +0100
Commit: Caolán McNamara 
CommitDate: Fri Dec 18 16:49:09 2020 +0100

tdf#138865 don't set ColumnToggleType::Check

We don't want any hidden, magic checkbox for this table, as the
user explicitly has to toggle the desired replacement modes,
which isn't in any way related to a row selection.

Change-Id: I3f9a73d41cc8727aa6380172221ea07068ef74c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107920
Reviewed-by: Attila Szűcs 
Reviewed-by: László Németh 
Reviewed-by: Jan-Marek Glogowski 
Tested-by: Jenkins
Tested-by: László Németh 
(cherry picked from commit 4cabfc30bf2db873930cef4f7f1b0243ae2fde28)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107908
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx
index d94112822f65..4f46e3aa8e53 100644
--- a/cui/source/options/fontsubs.cxx
+++ b/cui/source/options/fontsubs.cxx
@@ -54,7 +54,6 @@ SvxFontSubstTabPage::SvxFontSubstTabPage(weld::Container* 
pPage, weld::DialogCon
 
 m_xCheckLB->set_size_request(m_xCheckLB->get_approximate_digit_width() * 
60,
  m_xCheckLB->get_height_rows(8));
-m_xCheckLB->enable_toggle_buttons(weld::ColumnToggleType::Check);
 m_xCheckLB->set_help_id(HID_OFA_FONT_SUBST_CLB);
 m_xCheckLB->set_selection_mode(SelectionMode::Multiple);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 139040] New: BASE: Open two report when press "enter" key on report name

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139040

Bug ID: 139040
   Summary: BASE: Open two report when press "enter" key on report
name
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: alexc...@ya.ru

Description:
If I select report name in 'Reports' tab on main window and press [ENTER] key
on keyboard then two same report files will be opened.

Steps to Reproduce:
1. Create new database document;
2. Create table from some default template;
3. Create report based on table;
4. Select report name in 'Reports' tab on main window;
5. Press [ENTER] key on keyboard;

Actual Results:
Will be open two same report files.

Expected Results:
Will be open one report file.

Note:
If click on selected report name by mouse button or choice context menu, then
will be open one report as expected.

Version: 7.0.4.2
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); ИП: ru-RU
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sfx2/source

[Caolán McNamara (via logerrit)]

 sfx2/source/doc/templatedlg.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit cba301460f1aaa1834e72796935cc1e88d74c19b
Author: Caolán McNamara 
AuthorDate: Fri Dec 18 13:16:18 2020 +
Commit: Caolán McNamara 
CommitDate: Fri Dec 18 16:48:46 2020 +0100

Delete Category dialog includes '~' text in the titlebar

Change-Id: I8581e5219ffc690e686a0d563463c19b682ea04b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107910
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 313bf591862a..26787f0d2ac9 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -1110,7 +,7 @@ void SfxTemplateManagerDlg::OnCategoryDelete()
 SfxTemplateCategoryDialog aDlg(m_xDialog.get());
 aDlg.SetCategoryLBEntries(mxLocalView->getFolderNames());
 aDlg.HideNewCategoryOption();
-aDlg.set_title(SfxResId(STR_CATEGORY_DELETE));
+
aDlg.set_title(MnemonicGenerator::EraseAllMnemonicChars(SfxResId(STR_CATEGORY_DELETE)));
 aDlg.SetSelectLabelText(SfxResId(STR_CATEGORY_SELECT));
 
 if (aDlg.run() == RET_OK)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: editeng/source include/editeng

[Caolán McNamara (via logerrit)]

 editeng/source/editeng/editview.cxx |5 +
 include/editeng/editview.hxx|1 +
 2 files changed, 6 insertions(+)

New commits:
commit 69f1f7f61506131ca203e43b799e7422e98b82a5
Author: Caolán McNamara 
AuthorDate: Fri Dec 18 09:34:48 2020 +
Commit: Caolán McNamara 
CommitDate: Fri Dec 18 16:47:23 2020 +0100

add GetOutputDevice to EditView

Change-Id: I8b2555669106096b9ab37e0cc89267f5759efa3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107958
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/editeng/source/editeng/editview.cxx 
b/editeng/source/editeng/editview.cxx
index 877c59f1c520..99e3f67730d5 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -348,6 +348,11 @@ vcl::Window* EditView::GetWindow() const
 return pImpEditView->pOutWin;
 }
 
+OutputDevice& EditView::GetOutputDevice() const
+{
+return pImpEditView->GetOutputDevice();
+}
+
 bool EditView::HasOtherViewWindow( vcl::Window* pWin )
 {
 OutWindowSet& rOutWindowSet = pImpEditView->aOutWindowSet;
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index 5552e05b1313..7189f40d63ff 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -166,6 +166,7 @@ public:
 
 voidSetWindow( vcl::Window* pWin );
 vcl::Window*GetWindow() const;
+OutputDevice&   GetOutputDevice() const;
 
 boolHasOtherViewWindow( vcl::Window* pWin );
 boolAddOtherViewWindow( vcl::Window* pWin );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 139039] New: PDF: Error message if filepath is URG coded

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139039

Bug ID: 139039
   Summary: PDF: Error message if filepath is URG coded
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: thomas.schnei...@sys-thos.de

An error message occurs on trying to export to PDF if the export path is URL
coded, i.e. if it contains "%"(percent) characters:

Error message dialog (german):
"Fehler beim Speichern des Dokumentes ...document name...:
Allgemeiner Fehler.
Allgemeiner Ein-/Ausgabefehler."

In english probably it may be:
"Error on saving document ...document name...:
General error.
General I/O error."

Tested Versions:
- V.6.3.3
- V.6.4.6
- V.7.0.1

Version 5.4.7 works correctly!

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138846] Add label to "Settings" button in Template Manager and change label to "Categories"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138846

--- Comment #5 from sdc.bla...@youmail.dk ---
Was there any decision about the *name* of the label for the "gear" icon (which
will remain visible only by tooltip)?

The Category actions (New, Rename, Delete) in the submenu are not "settings"  

otoh  "Refresh" and "Reset default..." are not category-related

... so neither label is good.

Not advocating any direction, just need to know if it will change, so that I
can finish updating the template manager help page.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138846] Add label to "Settings" button in Template Manager and change label to "Categories"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138846

--- Comment #5 from sdc.bla...@youmail.dk ---
Was there any decision about the *name* of the label for the "gear" icon (which
will remain visible only by tooltip)?

The Category actions (New, Rename, Delete) in the submenu are not "settings"  

otoh  "Refresh" and "Reset default..." are not category-related

... so neither label is good.

Not advocating any direction, just need to know if it will change, so that I
can finish updating the template manager help page.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: include/vcl vcl/source

[Henry Castro (via logerrit)]

 include/vcl/toolkit/dialog.hxx |1 +
 vcl/source/window/dialog.cxx   |8 
 2 files changed, 9 insertions(+)

New commits:
commit c266dae3fbea14cdd29e590d9ec8f519813143b3
Author: Henry Castro 
AuthorDate: Fri Dec 4 15:38:35 2020 -0400
Commit: Henry Castro 
CommitDate: Fri Dec 18 16:27:46 2020 +0100

lok: jsbuilder: fix disable dialog tunneling

When a client side issue command to show the Macro Selector Dialog
to the server side, it is not necessary the dialog sends window
invalidate.

I guess the dialog tunneling progressively will be deprecated in
favor of JSDialog, that it will send JSON data to client side,
then it will be constructed to html element using a javascript
dialog builder. (I am wondering why sending JSON?, the server side
can just send the HTML string, and no need for javascript dialog builder).

Change-Id: Ia88f431ed9a860bb9bb30caaaf0f7f889d765115
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107240
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/include/vcl/toolkit/dialog.hxx b/include/vcl/toolkit/dialog.hxx
index 922bb8e46164..cbda9ee4b6fc 100644
--- a/include/vcl/toolkit/dialog.hxx
+++ b/include/vcl/toolkit/dialog.hxx
@@ -109,6 +109,7 @@ public:
 virtual voidStateChanged( StateChangedType nStateChange ) override;
 virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
 virtual voidCommand( const CommandEvent& rCEvt ) override;
+virtual voidPixelInvalidate(const tools::Rectangle* pRectangle) 
override;
 
 virtual void queue_resize(StateChangedType eReason = 
StateChangedType::Layout) override;
 virtual bool set_property(const OString , const OUString ) 
override;
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index cf240167d588..c3899483b0a4 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -396,6 +396,14 @@ void Dialog::ImplInitDialogData()
 mpDialogImpl.reset(new DialogImpl);
 }
 
+void Dialog::PixelInvalidate(const tools::Rectangle* pRectangle)
+{
+if (!mpDialogImpl->m_bLOKTunneling)
+return;
+
+Window::PixelInvalidate(pRectangle);
+}
+
 vcl::Window* Dialog::GetDefaultParent(WinBits nStyle)
 {
 vcl::Window* pParent = Application::GetDefDialogParent();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 138956] Pattern fill not available (and can cause crash)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138956

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Keywords||bibisected, bisected,
   ||regression
 Resolution|--- |DUPLICATE

--- Comment #4 from Aron Budea  ---
I could repro, and bibisect the crash to the same commit as bug 138973, thus
marking as duplicate.

*** This bug has been marked as a duplicate of bug 138973 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138973] Sidebar Gallery deck crashing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138973

--- Comment #7 from Aron Budea  ---
*** Bug 138956 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138973] Sidebar Gallery deck crashing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138973

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected,
   ||regression
 OS|Windows (All)   |All
 CC||noelgran...@gmail.com

--- Comment #6 from Aron Budea  ---
Bibisected to the following commit using repo bibisect-linux-64-7.2. Adding CC:
to Noel Grandin.

I've used the following command to start LO with Skia on Linux:
SAL_USE_VCLPLUGIN=gen SAL_ENABLESKIA=1 ./soffice

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c521e614359d236405754134a54e8a05bdb1c44c
author  Noel 2020-12-14 13:55:49 +0200
committer   Noel Grandin  2020-12-14
14:34:06 +0100

loplugin:unusedenumconstants

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/source

[Henry Castro (via logerrit)]

 desktop/source/lib/init.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 51ba81931518e17fe7c00481d7c230621415b728
Author: Henry Castro 
AuthorDate: Thu Oct 15 16:10:31 2020 -0400
Commit: Henry Castro 
CommitDate: Fri Dec 18 16:21:10 2020 +0100

lok: initialize to dispatch ".uno:RunMacro" command

The ".uno:RunMacro" command it is needed for
client side to show the Macro Selector Dialog.

Change-Id: I8f01b9f5cc985119c9215734a6484ed7a0e30080
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107886
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index cc2cee9913c0..945f3a2adf7c 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -2821,7 +2821,8 @@ static void doc_iniUnoCommands ()
 OUString(".uno:FreezePanesColumn"),
 OUString(".uno:FreezePanesRow"),
 OUString(".uno:Sidebar"),
-OUString(".uno:SheetRightToLeft")
+OUString(".uno:SheetRightToLeft"),
+OUString(".uno:RunMacro")
 };
 
 util::URL aCommandURL;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - translations

[Andras Timar (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e2952df6e186e69cf782597e8b1eeb92ba5a70f0
Author: Andras Timar 
AuthorDate: Fri Dec 18 16:21:03 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Dec 18 16:21:03 2020 +0100

Update git submodules

* Update translations from branch 'distro/collabora/cp-6.4'
  to 2ba607b3f87ba2e877520034f516499fc12a111d
  - Updated translations of AutoFilter, Validation, etc. in Calc

Change-Id: I09bc54be9be157ac86f0ddb2516ef8406cb2e710

diff --git a/translations b/translations
index 4418735900f7..2ba607b3f87b 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 4418735900f7b96584fb9f2cd247e1ca858266f3
+Subproject commit 2ba607b3f87ba2e877520034f516499fc12a111d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Branch 'distro/collabora/cp-6.4' - source/ar source/as source/ast source/bg source/bn-IN source/br source/ca source/ca-valencia source/cs source/cy source/da so

[Andras Timar (via logerrit)]

 source/ar/sc/messages.po  |  632 ++--
 source/as/sc/messages.po  |  631 ++--
 source/ast/sc/messages.po |  627 ++--
 source/bg/sc/messages.po  |  627 ++--
 source/bn-IN/sc/messages.po   |  630 ++--
 source/br/sc/messages.po  |  631 ++--
 source/ca-valencia/sc/messages.po |  627 ++--
 source/ca/sc/messages.po  |  627 ++--
 source/cs/sc/messages.po  |  627 ++--
 source/cy/sc/messages.po  |  627 ++--
 source/da/sc/messages.po  |  627 ++--
 source/de/sc/messages.po  |  627 ++--
 source/el/sc/messages.po  |  627 ++--
 source/en-GB/sc/messages.po   |  627 ++--
 source/es/sc/messages.po  |  610 ++--
 source/et/sc/messages.po  |  627 ++--
 source/eu/sc/messages.po  |  627 ++--
 source/fi/sc/messages.po  |  627 ++--
 source/fr/sc/messages.po  |  627 ++--
 source/ga/sc/messages.po  |  627 ++--
 source/gd/sc/messages.po  |  627 ++--
 source/gl/sc/messages.po  |  627 ++--
 source/gu/sc/messages.po  |  629 ++--
 source/he/sc/messages.po  |  633 ++--
 source/hi/sc/messages.po  |  632 ++--
 source/hr/sc/messages.po  |  627 ++--
 source/hu/sc/messages.po  |  627 ++--
 source/id/sc/messages.po  |  627 ++--
 source/is/sc/messages.po  |  627 ++--
 source/it/sc/messages.po  |  627 ++--
 source/ja/sc/messages.po  |  627 ++--
 source/km/sc/messages.po  |  629 ++--
 source/kn/sc/messages.po  |  630 ++--
 source/ko/sc/messages.po  |  627 ++--
 source/lt/sc/messages.po  |  627 ++--
 source/lv/sc/messages.po  |  627 ++--
 source/ml/sc/messages.po  |  631 ++--
 source/mr/sc/messages.po  |  629 ++--
 source/nb/sc/messages.po  |  627 ++--
 source/nl/sc/messages.po  |  627 ++--
 source/nn/sc/messages.po  |  627 ++--
 source/oc/sc/messages.po  |  627 ++--
 source/or/sc/messages.po  |  631 ++--
 source/pa-IN/sc/messages.po   |  627 ++--
 source/pl/sc/messages.po  |  627 ++--
 source/pt-BR/sc/messages.po   |  627 ++--
 source/pt/sc/messages.po  |  627 ++--
 source/ro/sc/messages.po  |  631 ++--
 source/ru/sc/messages.po  |  627 ++--
 source/sk/sc/messages.po  |  627 ++--
 source/sl/sc/messages.po  | 5454 --
 source/sr-Latn/sc/messages.po |  628 ++--
 source/sr/sc/messages.po  |  628 ++--
 source/sv/sc/messages.po  |  627 ++--
 source/ta/sc/messages.po  |  631 ++--
 source/te/sc/messages.po  |  629 ++--
 source/tr/sc/messages.po  |  627 ++--
 source/uk/sc/messages.po  |  627 ++--
 source/vi/sc/messages.po  |  627 ++--
 source/zh-CN/sc/messages.po   |  627 ++--
 source/zh-TW/sc/messages.po   |  627 ++--
 61 files changed, 26131 insertions(+), 16982 deletions(-)

New commits:
commit 2ba607b3f87ba2e877520034f516499fc12a111d
Author: Andras Timar 
AuthorDate: Fri Dec 18 16:20:46 2020 +0100
Commit: Andras Timar 
CommitDate: Fri Dec 18 16:20:46 2020 +0100

Updated translations of AutoFilter, Validation, etc. in Calc

Change-Id: I09bc54be9be157ac86f0ddb2516ef8406cb2e710

diff --git a/source/ar/sc/messages.po b/source/ar/sc/messages.po
index 134e66a304d..6e920cc7a24 100644
--- a/source/ar/sc/messages.po
+++ b/source/ar/sc/messages.po
@@ -3,7 +3,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2020-04-29 13:12+0200\n"
+"POT-Creation-Date: 2020-12-18 12:51+0100\n"
 "PO-Revision-Date: 2018-11-12 11:34+\n"
 "Last-Translator: Anonymous Pootle User\n"
 "Language-Team: LANGUAGE \n"
@@ -17467,242 +17467,215 @@ msgctxt "STR_MENU_SORT_CUSTOM"
 msgid "Custom Sort"
 msgstr "فرز مخصص"
 
-#. YeT6Y
-#: sc/inc/strings.hrc:169
-msgctxt "STR_BTN_TOGGLE_ALL"
-msgid "All"
-msgstr "الكل"
-
-#. RqBMw
-#: sc/inc/strings.hrc:170
-#, fuzzy
-msgctxt "STR_BTN_SELECT_CURRENT"
-msgid "Show only the current item."
-msgstr "إظهار العنصر الحالي فقط."
-
-#. VnRK2
-#: sc/inc/strings.hrc:171
-#, fuzzy
-msgctxt "STR_BTN_UNSELECT_CURRENT"
-msgid "Hide only the current item."
-msgstr "إخفاء العنصر الحالي فقط."
-
-#. eWCA7
-#: sc/inc/strings.hrc:172
-#, fuzzy
-msgctxt "STR_EDIT_SEARCH_ITEMS"
-msgid "Search items..."
-msgstr "ابحث عن عناصر..."
-
 #. bpBbA
-#: sc/inc/strings.hrc:174
+#: sc/inc/strings.hrc:170
 msgctxt "SCSTR_QHELP_POSWND"
 msgid "Name Box"
 msgstr "مربع الاسم"
 
 #. GeNTF
-#: sc/inc/strings.hrc:175
+#: sc/inc/strings.hrc:171
 msgctxt "SCSTR_QHELP_INPUTWND"
 msgid "Input line"
 msgstr "سطر اﻹدخال"
 
 #. E6mnF
-#: sc/inc/strings.hrc:176
+#: sc/inc/strings.hrc:172
 msgctxt "SCSTR_QHELP_BTNCALC"
 msgid "Function Wizard"
 msgstr "مرشد الدوال"
 
 #. rU6xA
-#: sc/inc/strings.hrc:177
+#: sc/inc/strings.hrc:173
 msgctxt 

[Libreoffice-bugs] [Bug 138975] category dialogs in template manager should not show "None" as category

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138975

--- Comment #4 from Peter Toye  ---
Is the question why "none" appears as a category without any apparent function,
or is it whether a template should be allowed without a category?

What happens if there is a template file in the top level of a template
directory? Presumably it has no category, and this needs to be catered for in
the Template manager. If this isn't allowed, the template manager needs to
check and warn if it finds any such files; I agree that this is an extension of
its scope. If it is allowed, the 'none' category should stay - and then what
happens if someone decides to have a subdirectory called 'none'? This exposes
what seems to me to be a design problem - by using the same mechanism
(subdirectory) to expose two separate concepts (category and file container),
they get confused.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138982] VIEWING Enhancement: Show cursor position as percentage of document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138982

--- Comment #7 from V Stuart Foote  ---
(In reply to Jay from comment #6)
> 
> Evidence of wider use:  "The three act play." A structure used WIDELY in
> plays, novels, and movies. Since ancient Greece.
> 
> Benefit for programming? I can't believe given the wide availability of
> excellent and free IDE's for programming that anyone uses libre writer for
> programming. 
> 
> I've made my request and outlined the use for it. If you don't want to
> implement it close this one and move on to the next ticket. It's probably
> not worth the effort to setup a build environment. I'll put a bounty on it
> or fork the code to make a word processor for writers.

Providing status bar textual description, as supplement the visual queue
already provided in the vert scroll bar, has limited value to our 'Benjamin'
users, and does not belong in the UI.

But, as Heiko suggests, fertile ground for a macro or even publish as an
extension, presumably with other UI optimizations "useful to writers". 

IMHO => WF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 138982] VIEWING Enhancement: Show cursor position as percentage of document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138982

--- Comment #7 from V Stuart Foote  ---
(In reply to Jay from comment #6)
> 
> Evidence of wider use:  "The three act play." A structure used WIDELY in
> plays, novels, and movies. Since ancient Greece.
> 
> Benefit for programming? I can't believe given the wide availability of
> excellent and free IDE's for programming that anyone uses libre writer for
> programming. 
> 
> I've made my request and outlined the use for it. If you don't want to
> implement it close this one and move on to the next ticket. It's probably
> not worth the effort to setup a build environment. I'll put a bounty on it
> or fork the code to make a word processor for writers.

Providing status bar textual description, as supplement the visual queue
already provided in the vert scroll bar, has limited value to our 'Benjamin'
users, and does not belong in the UI.

But, as Heiko suggests, fertile ground for a macro or even publish as an
extension, presumably with other UI optimizations "useful to writers". 

IMHO => WF

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/vcl vcl/source xmlsecurity/inc xmlsecurity/qa xmlsecurity/source xmlsecurity/workben

[Miklos Vajna (via logerrit)]

 include/vcl/filter/PDFiumLibrary.hxx|2 
 include/vcl/filter/pdfdocument.hxx  |6 +
 vcl/source/filter/ipdf/pdfdocument.cxx  |   82 ++--
 vcl/source/pdf/PDFiumLibrary.cxx|   12 +-
 xmlsecurity/inc/pdfio/pdfdocument.hxx   |2 
 xmlsecurity/qa/unit/pdfsigning/data/bad-cert-p1.pdf |binary
 xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx   |   25 +-
 xmlsecurity/source/helper/pdfsignaturehelper.cxx|5 -
 xmlsecurity/source/pdfio/pdfdocument.cxx|   17 ++--
 xmlsecurity/workben/pdfverify.cxx   |3 
 10 files changed, 130 insertions(+), 24 deletions(-)

New commits:
commit 255ff5f6f9f11f72fca48b337c8dc6f2d08e8d6b
Author: Miklos Vajna 
AuthorDate: Mon Oct 19 16:50:07 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Dec 18 16:02:08 2020 +0100

xmlsecurity: handle MDP permission during PDF verify

(cherry picked from commit 586f6abee92af3cdabdce034b607b9a046ed3946)

Conflicts:
include/vcl/filter/PDFiumLibrary.hxx
vcl/source/filter/ipdf/pdfdocument.cxx
vcl/source/pdf/PDFiumLibrary.cxx
xmlsecurity/inc/pdfio/pdfdocument.hxx
xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx
xmlsecurity/source/helper/pdfsignaturehelper.cxx

(cherry picked from commit 00479937dc071246cc27f33fd6397668448a7ed9)

Change-Id: I626fca7c03079fb0374c577dcfe024e7db6ed5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107966
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/PDFiumLibrary.hxx 
b/include/vcl/filter/PDFiumLibrary.hxx
index 60ece6b7cbc9..34b28787eb37 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -60,7 +60,7 @@ public:
 FPDF_PAGE getPointer() { return mpPage; }
 
 /// Get bitmap checksum of the page, without annotations/commenting.
-BitmapChecksum getChecksum();
+BitmapChecksum getChecksum(int nMDPPerm);
 };
 
 struct PDFiumLibrary : public rtl::StaticWithInit, 
PDFiumLibrary>
diff --git a/include/vcl/filter/pdfdocument.hxx 
b/include/vcl/filter/pdfdocument.hxx
index 65f72f301c8f..a814a7da3c15 100644
--- a/include/vcl/filter/pdfdocument.hxx
+++ b/include/vcl/filter/pdfdocument.hxx
@@ -359,6 +359,7 @@ public:
 size_t GetObjectOffset(size_t nIndex) const;
 const std::vector< std::unique_ptr >& GetElements();
 std::vector GetPages();
+PDFObjectElement* GetCatalog();
 /// Remember the end location of an EOF token.
 void PushBackEOF(size_t nOffset);
 /// Look up object based on object number, possibly by parsing object 
streams.
@@ -381,6 +382,11 @@ public:
 bool Write(SvStream& rStream);
 /// Get a list of signatures embedded into this document.
 std::vector GetSignatureWidgets();
+/**
+ * Get the value of the "modification detection and prevention" permission:
+ * Valid values are 1, 2 and 3: only 3 allows annotations after signing.
+ */
+int GetMDPPerm();
 /// Remove the nth signature from read document in the edit buffer.
 bool RemoveSignature(size_t nPosition);
 /// Get byte offsets of the end of incremental updates.
diff --git a/vcl/source/filter/ipdf/pdfdocument.cxx 
b/vcl/source/filter/ipdf/pdfdocument.cxx
index 6851bef19b91..b17ffb25999f 100644
--- a/vcl/source/filter/ipdf/pdfdocument.cxx
+++ b/vcl/source/filter/ipdf/pdfdocument.cxx
@@ -1793,10 +1793,8 @@ static void visitPages(PDFObjectElement* pPages, 
std::vector&
 pPages->setVisiting(false);
 }
 
-std::vector PDFDocument::GetPages()
+PDFObjectElement* PDFDocument::GetCatalog()
 {
-std::vector aRet;
-
 PDFReferenceElement* pRoot = nullptr;
 
 
@@ -1817,11 +1815,18 @@ std::vector PDFDocument::GetPages()
 
 if (!pRoot)
 {
-SAL_WARN("vcl.filter", "PDFDocument::GetPages: trailer has no Root 
key");
-return aRet;
+SAL_WARN("vcl.filter", "PDFDocument::GetCatalog: trailer has no Root 
key");
+return nullptr;
 }
 
-PDFObjectElement* pCatalog = pRoot->LookupObject();
+return pRoot->LookupObject();
+}
+
+std::vector PDFDocument::GetPages()
+{
+std::vector aRet;
+
+PDFObjectElement* pCatalog = GetCatalog();
 if (!pCatalog)
 {
 SAL_WARN("vcl.filter", "PDFDocument::GetPages: trailer has no 
catalog");
@@ -1896,6 +1901,71 @@ std::vector 
PDFDocument::GetSignatureWidgets()
 return aRet;
 }
 
+int PDFDocument::GetMDPPerm()
+{
+int nRet = 3;
+
+std::vector aSignatures = GetSignatureWidgets();
+if (aSignatures.empty())
+{
+return nRet;
+}
+
+for (const auto& pSignature : aSignatures)
+{
+vcl::filter::PDFObjectElement* pSig = pSignature->LookupObject("V");
+if (!pSig)
+{
+SAL_WARN("vcl.filter", "PDFDocument::GetMDPPerm: can't find 
signature object");
+continue;
+}

[Libreoffice-bugs] [Bug 138846] Add label to "Settings" button in Template Manager and change label to "Categories"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138846

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138846] Add label to "Settings" button in Template Manager and change label to "Categories"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138846

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 138846] Add label to "Settings" button in Template Manager and change label to "Categories"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138846

--- Comment #4 from Heiko Tietze  ---
Created attachment 168299
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168299=edit
Mockup

We discussed the topic in the design meeting. Jan's proposal in comment 2
sounds like the best solution, then still without label. But we should also
consider to use not a menu but a standard button and have all interactions in a
dialog. It would list all categories with the related functions in one dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138846] Add label to "Settings" button in Template Manager and change label to "Categories"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138846

--- Comment #4 from Heiko Tietze  ---
Created attachment 168299
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168299=edit
Mockup

We discussed the topic in the design meeting. Jan's proposal in comment 2
sounds like the best solution, then still without label. But we should also
consider to use not a menu but a standard button and have all interactions in a
dialog. It would list all categories with the related functions in one dialog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 138285] FIND AND REPLACE DIALOG: Allow users to see the replace result before moving to the next search

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138285

--- Comment #5 from Heiko Tietze  ---
We discussed this topic in the design meeting.

There are concerns that if a feature is needed anyway. But replacement lacks on
proper feedback at most applications. And Consgor's idea in comment 3 is
tempting. The problem however is how to realize the interaction. Moving the
mouse from replace to next and back is annoying. We could change the
label/function but it has drawbacks when the search parameters change and
exchanging next/replace buttons' position is bad usability and totally
confusing. So how to do the Replace->Next->Replace thing?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138285] FIND AND REPLACE DIALOG: Allow users to see the replace result before moving to the next search

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138285

--- Comment #5 from Heiko Tietze  ---
We discussed this topic in the design meeting.

There are concerns that if a feature is needed anyway. But replacement lacks on
proper feedback at most applications. And Consgor's idea in comment 3 is
tempting. The problem however is how to realize the interaction. Moving the
mouse from replace to next and back is annoying. We could change the
label/function but it has drawbacks when the search parameters change and
exchanging next/replace buttons' position is bad usability and totally
confusing. So how to do the Replace->Next->Replace thing?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: configure.ac

[Christian Lohmaier (via logerrit)]

 configure.ac |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit d691b46e52d173cf945130df01bd35b5c4c0f539
Author: Christian Lohmaier 
AuthorDate: Fri Dec 18 15:40:37 2020 +0100
Commit: Christian Lohmaier 
CommitDate: Fri Dec 18 15:40:37 2020 +0100

cross-compilation targets really do need all AC_CONFIG_FILES

Build doesn't fail after just a make clean, but do fail with a
completely fresh checkout
regression from https://gerrit.libreoffice.org/c/core/+/107655

Change-Id: Id05f747548729449fbda6306fc27e35377b80569

diff --git a/configure.ac b/configure.ac
index 1458c394c9fc..89c44b74e4f9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5156,7 +5156,9 @@ if test "$cross_compiling" = "yes"; then
 hardened_runtime.xcent.in \
 instsetoo_native/util/openoffice.lst.in \
 config_host/*.in \
-sysui/desktop/macosx/Info.plist.in) \
+sysui/desktop/macosx/Info.plist.in \
+.vscode/vs-code-template.code-workspace.in \
+) \
 | (cd CONF-FOR-BUILD && tar xf -)
 cp configure CONF-FOR-BUILD
 test -d config_build && cp -p config_build/*.h CONF-FOR-BUILD/config_host 
2>/dev/null
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 139038] some space between m and e letter under 'name' word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139038

--- Comment #1 from Venkat anil  ---
space observed for each word where 'e' comes after 'm'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139038] New: some space between m and e letter under 'name' word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139038

Bug ID: 139038
   Summary: some space between m and e letter under 'name' word
   Product: LibreOffice
   Version: 6.4.7.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vakn@gmail.com

Description:
some space between m and e letter under 'name' word in "Text Document" 

Steps to Reproduce:
1. type the 'name' word in "Text Document" 
2. you can see the gap
3.

Actual Results:
gap between m and e, when typed "name"

Expected Results:
there should not be any gap between m and e


Reproducible: Always


User Profile Reset: Yes



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (10)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139012] UI: Font tab formatting options could be shown in button instead of drop down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139012

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
(In reply to Telesto from comment #0)
> ...
> Actual Results:
> Drop down for formatting options
> 
> Expected Results:
> Probably also a matter of taste..  kind of liking the idea of formatting
> buttons (as in toolbar) instead of drop down. I might be more visual
> oriented. Disliking reading lines of text.. And stuff being hidden behind
> drop down. So no never now what's kind of options are in the list.. And the
> number of options being pretty limited
> 
> OTOH: font effects does the same.. and the list with options to long to
> replace with buttons.. so based on consistency the current makes sense
> 
> 
The 'Font' tab of the 'Default Paragraph Style' style SB deck's dialog has just
three "selections" droplists for selection of 'Font', 'Style', and 'Size' with
a button control to launch a smart type 'Features' dialog to select Graphite or
OpenType features of the font.  The layout of the dialog will shift depending
on per user language setting selection (Tools -> Options -> Language Settings
-> Languages).

But for any dialog layout, I fail to see how a Button control rather than a
Droplist would be appropriate for selection of Font, Style or Size?

-1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138975] category dialogs in template manager should not show "None" as category

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138975

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |akshaydeepi...@gmail.com,
   |.freedesktop.org|heiko.tietze@documentfounda
   ||tion.org,
   ||s.mehrbr...@gmail.com
   Keywords|needsUXEval |

--- Comment #3 from Heiko Tietze  ---
So it looks like "None" was add to allow mpLBCategory->SelectEntryPos(0) in
SfxTemplateCategoryDialog::SetCategoryLBEntries. Could be resolved by testing
if the item count is greater than zero.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138975] category dialogs in template manager should not show "None" as category

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138975

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |akshaydeepi...@gmail.com,
   |.freedesktop.org|heiko.tietze@documentfounda
   ||tion.org,
   ||s.mehrbr...@gmail.com
   Keywords|needsUXEval |

--- Comment #3 from Heiko Tietze  ---
So it looks like "None" was add to allow mpLBCategory->SelectEntryPos(0) in
SfxTemplateCategoryDialog::SetCategoryLBEntries. Could be resolved by testing
if the item count is greater than zero.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 138884] Crash when deleting default draw template (gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138884

Caolán McNamara  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138865] Selecting a tree view row with a check box entry toggles the entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138865

Jan-Marek Glogowski  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 122094] FILEOPEN XLSX, Conditional formatting condition not working the same in LO as MSO.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122094

Tibor Nagy (NISZ)  changed:

   What|Removed |Added

   Assignee|nagy.tib...@nisz.hu |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138884] Crash when deleting default draw template (gen)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138884

--- Comment #9 from Caolán McNamara  ---
right click context menu delete entry crashes, but the "Delete" key deletes
without a crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139037] UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139037

Telesto  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139037] UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139037

Telesto  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139037] New: UI: collapsed pre-formatted text in style inspector keeps expanding after each cursor position change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139037

Bug ID: 139037
   Summary: UI:  collapsed pre-formatted text in style inspector
keeps expanding after each cursor position change
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
UI:  collapsed pre-formatted text in style inspector keeps expanding after each
cursor position change

Steps to Reproduce:
1. Open attachment 168296
2. Set screen to windowed mode say 12 inch screen
3. Activate Style inspector in the sidebar
4. Collapse pre-formatted text -> Looking for DF
5. Place cursor somewhere else -> pre-formatted text expands again

Actual Results:
pre-formatted text keeps expanding

Expected Results:
Keeping closed.. looking for DF specifics.. and my screen is small! 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: e97a81e94511b52987a50b7bdb72c922899da588
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138972] Database copy over loses database info in version 7.0.3.1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138972

--- Comment #4 from C Sara  ---
I downloaded the 7.0.4 version and it’s still having Database items disappear
once dragged and dropped.(In reply to m.a.riosv from comment #3)
> I can't reproduce it with
> Version: 7.0.4.2 (x64)
> Build ID: dcf040e67528d9187c66b2379df5ea4407429775
> CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL:
> win
> Locale: es-ES (es_ES); Interfaz: es-ES Calc: CL

I downloaded the 7.0.4 version and it’s still having Database items disappear
once dragged and dropped.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139036] UI: visual glitch header line not following page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139036

--- Comment #1 from Telesto  ---
Created attachment 168296
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168296=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139036] New: UI: visual glitch header line not following page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139036

Bug ID: 139036
   Summary: UI: visual glitch header line not following page
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
UI: visual glitch header line not following page

Steps to Reproduce:
1. Open the attached file
2. Make sure the sidebar is present and deck visible.. make it pretty width
3. Place mouse cursor top of the page and left click (blue header appears)
3. press CTRL+SHIFT+M
4. Resize the sidebar 
5. press CTRL+SHIFT+M -> Notice the header line not being adjusted

Actual Results:
Blue line not adjusted to page

Expected Results:
Ideally following


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64)
Build ID: e97a81e94511b52987a50b7bdb72c922899da588
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138975] category dialogs in template manager should not show "None" as category

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138975

--- Comment #2 from Caolán McNamara  ---
That commit just moved the string out from
sfx2/uiconfig/ui/saveastemplatedlg.ui and
sfx2/uiconfig/ui/templatecategorydlg.ui and into STR_CATEGORY_NONE. The "None"
entries exist since
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca040d16d06fead95ad7ed8d10f5995fbade1219
e.g. "SfxSaveAsTemplateDialog::SetCategoryLBEntries" the original "New Template
Manager"

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

Telesto  changed:

   What|Removed |Added

 Attachment #168291|0   |1
is obsolete||
 Attachment #168294|0   |1
is obsolete||

--- Comment #7 from Telesto  ---
Created attachment 168295
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168295=edit
Example file (Hello Brave World)

Still in adjusting mode to distinguish feature from bug(s): 

1. Open the attached file 
2. Double click "brave"
3. Drag it to middle of brave
4. Observe a spacing is added before and after -> Word simply disallows drag &
drop inside existing word (wrong 1, IMHO
5. Undo
6. Type something.. notice the selection area being extended including space
before -> Wrong 2, IMHO
7. Undo
8. Deselect brave
9. Re-select brave by double clicking
10. Drag it before 'new"
11. Start typing before 'new' (notice bold DF formatting/ does also happen with
CS style) -> Thing this off too, compare with Word

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138975] category dialogs in template manager should not show "None" as category

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138975

--- Comment #2 from Caolán McNamara  ---
That commit just moved the string out from
sfx2/uiconfig/ui/saveastemplatedlg.ui and
sfx2/uiconfig/ui/templatecategorydlg.ui and into STR_CATEGORY_NONE. The "None"
entries exist since
https://cgit.freedesktop.org/libreoffice/core/commit/?id=ca040d16d06fead95ad7ed8d10f5995fbade1219
e.g. "SfxSaveAsTemplateDialog::SetCategoryLBEntries" the original "New Template
Manager"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-ux-advise] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

Telesto  changed:

   What|Removed |Added

 Attachment #168291|0   |1
is obsolete||
 Attachment #168294|0   |1
is obsolete||

--- Comment #7 from Telesto  ---
Created attachment 168295
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168295=edit
Example file (Hello Brave World)

Still in adjusting mode to distinguish feature from bug(s): 

1. Open the attached file 
2. Double click "brave"
3. Drag it to middle of brave
4. Observe a spacing is added before and after -> Word simply disallows drag &
drop inside existing word (wrong 1, IMHO
5. Undo
6. Type something.. notice the selection area being extended including space
before -> Wrong 2, IMHO
7. Undo
8. Deselect brave
9. Re-select brave by double clicking
10. Drag it before 'new"
11. Start typing before 'new' (notice bold DF formatting/ does also happen with
CS style) -> Thing this off too, compare with Word

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 137474] Allow multiple tags in tight extensions dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137474

Heiko Tietze  changed:

   What|Removed |Added

   Priority|high|medium

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34391] FORMATTING: Implementing Table Styles

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=34391

Heiko Tietze  changed:

   What|Removed |Added

 Blocks|101772  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101772
[Bug 101772] UI - View source -> XML source raw editing mode, "make Dreamweaver
obsolete"
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 101772] UI - View source -> XML source raw editing mode, "make Dreamweaver obsolete"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101772

Heiko Tietze  changed:

   What|Removed |Added

 Depends on|31481   |
 Depends on|34391   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=31481
[Bug 31481] [RFE] Split pane in same window for side-by-side proof reading/
translating of 2 different files
https://bugs.documentfoundation.org/show_bug.cgi?id=34391
[Bug 34391] FORMATTING: Implementing Table Styles
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 101772] UI - View source -> XML source raw editing mode, "make Dreamweaver obsolete"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101772

Heiko Tietze  changed:

   What|Removed |Added

 Depends on|31481   |
 Depends on|34391   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=31481
[Bug 31481] [RFE] Split pane in same window for side-by-side proof reading/
translating of 2 different files
https://bugs.documentfoundation.org/show_bug.cgi?id=34391
[Bug 34391] FORMATTING: Implementing Table Styles
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 31481] [RFE] Split pane in same window for side-by-side proof reading/ translating of 2 different files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=31481

Heiko Tietze  changed:

   What|Removed |Added

 Blocks|101772  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=101772
[Bug 101772] UI - View source -> XML source raw editing mode, "make Dreamweaver
obsolete"
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139035] New: Windows crashed after installing LibreOffice_7.0.3_Win_x64.msi

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139035

Bug ID: 139035
   Summary: Windows crashed after installing
LibreOffice_7.0.3_Win_x64.msi
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mdgi...@tiscali.co.uk

Description:
I successfully installed 7.0.3 on my laptop the installation did NOT require a
reboot of Windows.
Laptop details:
  Edition: Windows 10 Pro
  Version: 1909
  OS Build: 18363.1256
  Processor:Intel(R) Pentium(R) CPU4415U @2.30GHz
  RAM: 4GB (£.89GB available)
The laptop was purchased with the OS pre-installed.

I installed 7.0.3 on my tower PC and the installation said (on 2 occasions)
that a reboot would be required. After the installation was complete the
LibreOffice installer suggested rebooting so I did. All appeared fine until I
started LibreOffice. When the startup logo should have appeared all that I
could see was the dark line, the shadow. Then the whole screen went black (not
a BSOD) and the PC restarted. After the PC had restarted I tried to run
LibreOffice once more with the same result: all I could see was the dark line,
the shadow. Then the whole screen went black and the PC restarted. I then
downloaded the LibreOffice_7.0.3_Win_x64.msi file again (in case the first
download was corrupted) and tried reinstalling but it said that a reboot would
be required so I aborted the second installation attempt in case it permanently
affected Windows.
I uninstalled 7.0.3 (this took a surprisingly long time: about 10 minutes) and
reinstalled 6.4.7.2. This installed cleanly and runs perfectly.
PC details:
  Edition: Windows 10 Pro
  Version: 2004
  OS Build: 19041.685
  Experience: Windows Feature Experience Pack 120.2212.551.0
  Processor: AMD A10-7850K Radeon R7.12 Compute cores 4C 8G 3.70GHz
  RAM: 8GB (6.94 GB available)
The PC is older than the laptop and had Windows 7 on it for which I got the
free upgrade to Windows 10 Pro. 

I hope that this helps,
Mike.

Steps to Reproduce:
1. Install 7.0.3
2. Reboot
3. Windows crashes

See a more complete description in the "Description" panel above

Actual Results:
Windows crashes

Expected Results:
Windows not crashing


Reproducible: Always


User Profile Reset: No



Additional Info:
Well, not crash my PC !!

I cannot copy the information from menu Help-About as LibreOffice crashed the
PC before the startup logo appeared.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138982] VIEWING Enhancement: Show cursor position as percentage of document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138982

--- Comment #6 from Jay  ---
(In reply to Heiko Tietze from comment #5)
> (In reply to Jay from comment #4)
> > The position within the page/line is not useful for writing fiction.
> 
> Do you have evidence of a wider use case? Otherwise I'd prefer a solution
> per extension. Point is that I can easily make a rough estimation of current
> page by total pages to get the percentage. Same for lines/characters
> (comment 3), which has the benefit for programming and any tasks that
> involve monospace fonts.

Evidence of wider use:  "The three act play." A structure used WIDELY in plays,
novels, and movies. Since ancient Greece.

Benefit for programming? I can't believe given the wide availability of
excellent and free IDE's for programming that anyone uses libre writer for
programming. 

I've made my request and outlined the use for it. If you don't want to
implement it close this one and move on to the next ticket. It's probably not
worth the effort to setup a build environment. I'll put a bounty on it or fork
the code to make a word processor for writers.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 138982] VIEWING Enhancement: Show cursor position as percentage of document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138982

--- Comment #6 from Jay  ---
(In reply to Heiko Tietze from comment #5)
> (In reply to Jay from comment #4)
> > The position within the page/line is not useful for writing fiction.
> 
> Do you have evidence of a wider use case? Otherwise I'd prefer a solution
> per extension. Point is that I can easily make a rough estimation of current
> page by total pages to get the percentage. Same for lines/characters
> (comment 3), which has the benefit for programming and any tasks that
> involve monospace fonts.

Evidence of wider use:  "The three act play." A structure used WIDELY in plays,
novels, and movies. Since ancient Greece.

Benefit for programming? I can't believe given the wide availability of
excellent and free IDE's for programming that anyone uses libre writer for
programming. 

I've made my request and outlined the use for it. If you don't want to
implement it close this one and move on to the next ticket. It's probably not
worth the effort to setup a build environment. I'll put a bounty on it or fork
the code to make a word processor for writers.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 138995] FILEOPEN DOCX: A shape in front of textbox is position behind textbox (fine with DOC)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138995

Telesto  changed:

   What|Removed |Added

Summary|A shape in front of textbox |FILEOPEN DOCX: A shape in
   |is position behind textbox  |front of textbox is
   |after DOCX export (fine |position behind textbox
   |with DOC)   |(fine with DOC)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139032] Testing Bugzilla

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139032

Buovjaga  changed:

   What|Removed |Added

  Component|LibreOffice |deletionRequest
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 108456] [META] Style modify dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108456
Bug 108456 depends on bug 139017, which changed state.

Bug 139017 Summary: "Create Style" dialog box should be labeled "New Style from 
Selection"
https://bugs.documentfoundation.org/show_bug.cgi?id=139017

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139017] "Create Style" dialog box should be labeled "New Style from Selection"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139017

sdc.bla...@youmail.dk changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #3 from sdc.bla...@youmail.dk ---
Resetting to NEW -- because the following still remains to be done (for reasons
listed above).

> 3.  Add label "Custom Styles in Document" between entry box and display
> window.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/vcl vcl/source xmlsecurity/Library_xmlsecurity.mk xmlsecurity/qa xmlsecurity/source xmlsecurity/workben

[Miklos Vajna (via logerrit)]

 include/vcl/filter/PDFiumLibrary.hxx   |   
30 
 vcl/source/pdf/PDFiumLibrary.cxx   |   
31 
 xmlsecurity/Library_xmlsecurity.mk |   
 5 
 xmlsecurity/qa/unit/signing/data/hide-and-replace-shadow-file-signed-2.pdf 
|binary
 xmlsecurity/qa/unit/signing/signing.cxx|   
18 ++
 xmlsecurity/source/pdfio/pdfdocument.cxx   |   
70 ++
 xmlsecurity/workben/pdfverify.cxx  |   
 5 
 7 files changed, 156 insertions(+), 3 deletions(-)

New commits:
commit 3bd3fbe77ba0fb86e82f157b15f9626d586e96fa
Author: Miklos Vajna 
AuthorDate: Fri Sep 4 17:17:48 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Dec 18 13:54:19 2020 +0100

xmlsecurity: pdf incremental updates that are non-commenting are invalid

I.e. it's OK to add incremental updates for annotation/commenting
purposes and that doesn't invalite existing signatures. Everything else
does.

(cherry picked from commit 61834cd574568613f0b0a2ee099a60fa5a8d9804)

Conflicts:
include/vcl/filter/PDFiumLibrary.hxx
vcl/source/pdf/PDFiumLibrary.cxx
xmlsecurity/qa/unit/signing/signing.cxx
xmlsecurity/source/pdfio/pdfdocument.cxx
xmlsecurity/workben/pdfverify.cxx

Change-Id: I4607c242b3c6f6b01517b02407e9e7a095e2e069
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107944
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/PDFiumLibrary.hxx 
b/include/vcl/filter/PDFiumLibrary.hxx
index 1f6d97045088..60ece6b7cbc9 100644
--- a/include/vcl/filter/PDFiumLibrary.hxx
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -17,6 +17,9 @@
 #include 
 #include 
 #include 
+#include 
+
+#include 
 
 namespace vcl
 {
@@ -33,6 +36,33 @@ public:
 ~PDFium();
 };
 
+class VCL_DLLPUBLIC PDFiumPage final
+{
+private:
+FPDF_PAGE mpPage;
+
+private:
+PDFiumPage(const PDFiumPage&) = delete;
+PDFiumPage& operator=(const PDFiumPage&) = delete;
+
+public:
+PDFiumPage(FPDF_PAGE pPage)
+: mpPage(pPage)
+{
+}
+
+~PDFiumPage()
+{
+if (mpPage)
+FPDF_ClosePage(mpPage);
+}
+
+FPDF_PAGE getPointer() { return mpPage; }
+
+/// Get bitmap checksum of the page, without annotations/commenting.
+BitmapChecksum getChecksum();
+};
+
 struct PDFiumLibrary : public rtl::StaticWithInit, 
PDFiumLibrary>
 {
 std::shared_ptr operator()() { return std::make_shared(); }
diff --git a/vcl/source/pdf/PDFiumLibrary.cxx b/vcl/source/pdf/PDFiumLibrary.cxx
index 9d822c34642c..a8774b15bb4e 100644
--- a/vcl/source/pdf/PDFiumLibrary.cxx
+++ b/vcl/source/pdf/PDFiumLibrary.cxx
@@ -15,6 +15,9 @@
 #include 
 #include 
 
+#include 
+#include 
+
 namespace vcl
 {
 namespace pdf
@@ -31,6 +34,34 @@ PDFium::PDFium()
 
 PDFium::~PDFium() { FPDF_DestroyLibrary(); }
 
+BitmapChecksum PDFiumPage::getChecksum()
+{
+size_t nPageWidth = FPDF_GetPageWidth(mpPage);
+size_t nPageHeight = FPDF_GetPageHeight(mpPage);
+FPDF_BITMAP pPdfBitmap = FPDFBitmap_Create(nPageWidth, nPageHeight, 
/*alpha=*/1);
+if (!pPdfBitmap)
+{
+return 0;
+}
+
+// Intentionally not using FPDF_ANNOT here, annotations/commenting is OK 
to not affect the
+// checksum, signature verification wants this.
+FPDF_RenderPageBitmap(pPdfBitmap, mpPage, /*start_x=*/0, /*start_y=*/0, 
nPageWidth, nPageHeight,
+  /*rotate=*/0, /*flags=*/0);
+Bitmap aBitmap(Size(nPageWidth, nPageHeight), 24);
+{
+Bitmap::ScopedWriteAccess pWriteAccess(aBitmap);
+const auto pPdfBuffer = static_cast(FPDFBitmap_GetBuffer(pPdfBitmap));
+const int nStride = FPDFBitmap_GetStride(pPdfBitmap);
+for (size_t nRow = 0; nRow < nPageHeight; ++nRow)
+{
+const sal_uInt8* pPdfLine = pPdfBuffer + (nStride * nRow);
+pWriteAccess->CopyScanline(nRow, pPdfLine, 
ScanlineFormat::N32BitTcBgra, nStride);
+}
+}
+return aBitmap.GetChecksum();
+}
+
 } // end pdf
 } // end vcl
 
diff --git a/xmlsecurity/Library_xmlsecurity.mk 
b/xmlsecurity/Library_xmlsecurity.mk
index 22d27c717155..26d1549089c2 100644
--- a/xmlsecurity/Library_xmlsecurity.mk
+++ b/xmlsecurity/Library_xmlsecurity.mk
@@ -20,7 +20,10 @@ $(eval $(call gb_Library_add_defs,xmlsecurity,\
 -DXMLSECURITY_DLLIMPLEMENTATION \
 ))
 
-$(eval $(call gb_Library_use_externals,xmlsecurity,boost_headers))
+$(eval $(call gb_Library_use_externals,xmlsecurity,\
+   boost_headers \
+   $(if $(filter PDFIUM,$(BUILD_TYPE)),pdfium) \
+))
 
 $(eval $(call 
gb_Library_set_precompiled_header,xmlsecurity,$(SRCDIR)/xmlsecurity/inc/pch/precompiled_xmlsecurity))
 
diff --git 
a/xmlsecurity/qa/unit/signing/data/hide-and-replace-shadow-file-signed-2.pdf 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - include/vcl svx/source vcl/Library_vcl.mk vcl/qa vcl/source

[Tomaž Vajngerl (via logerrit)]

 include/vcl/filter/PDFiumLibrary.hxx   |   46 +
 svx/source/svdraw/svdpdf.cxx   |   14 +-
 svx/source/svdraw/svdpdf.hxx   |4 ++
 vcl/Library_vcl.mk |1 
 vcl/qa/cppunit/pdfexport/pdfexport.cxx |   11 ++-
 vcl/source/filter/ipdf/pdfread.cxx |   26 +++---
 vcl/source/pdf/PDFiumLibrary.cxx   |   39 +++
 7 files changed, 101 insertions(+), 40 deletions(-)

New commits:
commit 7acba39a9b3c17b83e3365e3e4ff2b4f2a3cc778
Author: Tomaž Vajngerl 
AuthorDate: Sun May 31 11:50:20 2020 +0200
Commit: Miklos Vajna 
CommitDate: Fri Dec 18 13:54:06 2020 +0100

pdfium: only init pdfium library one and destroy on LO exit

With more and more usage of PDFium, it is hard to keep track of
the life-time of the PDFium library, so it can happen that a
FPDF_DestroyLibrary happens when we still have another instance
where PDFium is still use. The result of this is a crash. To
prevent this, just initialize the library once and delete, when
on LO exit.

This can be improved in the future to only keep the library
active when in actual use.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95391
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 067a8a954c8e1d8d6465a4ab5fb61e93f16c26c2)

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95933
Tested-by: Tomaž Vajngerl 
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 3538b83c8d83e66f63c745bd769d118117704026)

Conflicts:
vcl/qa/cppunit/pdfexport/pdfexport.cxx
vcl/source/filter/ipdf/pdfread.cxx
vcl/source/graphic/VectorGraphicSearch.cxx

Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107943
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/PDFiumLibrary.hxx 
b/include/vcl/filter/PDFiumLibrary.hxx
new file mode 100644
index ..1f6d97045088
--- /dev/null
+++ b/include/vcl/filter/PDFiumLibrary.hxx
@@ -0,0 +1,46 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#pragma once
+
+#include 
+
+#if HAVE_FEATURE_PDFIUM
+
+#include 
+#include 
+#include 
+
+namespace vcl
+{
+namespace pdf
+{
+class VCL_DLLPUBLIC PDFium final
+{
+private:
+PDFium(const PDFium&) = delete;
+PDFium& operator=(const PDFium&) = delete;
+
+public:
+PDFium();
+~PDFium();
+};
+
+struct PDFiumLibrary : public rtl::StaticWithInit, 
PDFiumLibrary>
+{
+std::shared_ptr operator()() { return std::make_shared(); }
+};
+
+} // namespace pdf
+} // namespace pdf
+
+#endif // HAVE_FEATURE_PDFIUM
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/svdraw/svdpdf.cxx b/svx/source/svdraw/svdpdf.cxx
index 9e49a3d1e90a..78437f247123 100644
--- a/svx/source/svdraw/svdpdf.cxx
+++ b/svx/source/svdraw/svdpdf.cxx
@@ -147,6 +147,7 @@ ImpSdrPdfImport::ImpSdrPdfImport(SdrModel& rModel, 
SdrLayerID nLay, const tools:
 , mnPageCount(0)
 , mdPageWidthPts(0)
 , mdPageHeightPts(0)
+, mpPDFium(vcl::pdf::PDFiumLibrary::get())
 {
 mpVD->EnableOutput(false);
 mpVD->SetLineColor();
@@ -160,13 +161,6 @@ ImpSdrPdfImport::ImpSdrPdfImport(SdrModel& rModel, 
SdrLayerID nLay, const tools:
svl::Items{});
 checkClip();
 
-FPDF_LIBRARY_CONFIG aConfig;
-aConfig.version = 2;
-aConfig.m_pUserFontPaths = nullptr;
-aConfig.m_pIsolate = nullptr;
-aConfig.m_v8EmbedderSlot = 0;
-FPDF_InitLibraryWithConfig();
-
 // Load the buffer using pdfium.
 mpPdfDocument = FPDF_LoadMemDocument(mpPdfData->data(), mpPdfData->size(),
  /*password=*/nullptr);
@@ -199,11 +193,7 @@ ImpSdrPdfImport::ImpSdrPdfImport(SdrModel& rModel, 
SdrLayerID nLay, const tools:
 mnPageCount = FPDF_GetPageCount(mpPdfDocument);
 }
 
-ImpSdrPdfImport::~ImpSdrPdfImport()
-{
-FPDF_CloseDocument(mpPdfDocument);
-FPDF_DestroyLibrary();
-}
+ImpSdrPdfImport::~ImpSdrPdfImport() { FPDF_CloseDocument(mpPdfDocument); }
 
 void ImpSdrPdfImport::DoObjects(SvdProgressInfo* pProgrInfo, sal_uInt32* 
pActionsToReport,
 int nPageIndex)
diff --git a/svx/source/svdraw/svdpdf.hxx b/svx/source/svdraw/svdpdf.hxx
index fd97768dc233..0b293e894709 100644
--- a/svx/source/svdraw/svdpdf.hxx
+++ b/svx/source/svdraw/svdpdf.hxx
@@ -41,6 +41,8 @@
 #include 
 #include 
 
+#include 
+
 // Forward Declarations
 
 class SfxItemSet;
@@ -207,6 +209,8 @@ class ImpSdrPdfImport 

[Libreoffice-bugs] [Bug 138865] Selecting a tree view row with a check box entry toggles the entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138865

--- Comment #12 from Commit Notification 
 ---
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4cabfc30bf2db873930cef4f7f1b0243ae2fde28

tdf#138865 don't set ColumnToggleType::Check

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138865] Selecting a tree view row with a check box entry toggles the entry

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138865

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source

[Jan-Marek Glogowski (via logerrit)]

 cui/source/options/fontsubs.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4cabfc30bf2db873930cef4f7f1b0243ae2fde28
Author: Jan-Marek Glogowski 
AuthorDate: Thu Dec 17 19:30:26 2020 +0100
Commit: Jan-Marek Glogowski 
CommitDate: Fri Dec 18 13:47:56 2020 +0100

tdf#138865 don't set ColumnToggleType::Check

We don't want any hidden, magic checkbox for this table, as the
user explicitly has to toggle the desired replacement modes,
which isn't in any way related to a row selection.

Change-Id: I3f9a73d41cc8727aa6380172221ea07068ef74c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107920
Reviewed-by: Attila Szűcs 
Reviewed-by: László Németh 
Reviewed-by: Jan-Marek Glogowski 
Tested-by: Jenkins
Tested-by: László Németh 

diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx
index fa05481d0663..07c4f7e9f51e 100644
--- a/cui/source/options/fontsubs.cxx
+++ b/cui/source/options/fontsubs.cxx
@@ -54,7 +54,6 @@ SvxFontSubstTabPage::SvxFontSubstTabPage(weld::Container* 
pPage, weld::DialogCon
 
 m_xCheckLB->set_size_request(m_xCheckLB->get_approximate_digit_width() * 
60,
  m_xCheckLB->get_height_rows(8));
-m_xCheckLB->enable_toggle_buttons(weld::ColumnToggleType::Check);
 m_xCheckLB->set_help_id(HID_OFA_FONT_SUBST_CLB);
 m_xCheckLB->set_selection_mode(SelectionMode::Multiple);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

Telesto  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

--- Comment #6 from Telesto  ---
(In reply to Telesto from comment #4)
> Step 6 certainly wrong (probably side-effect). And maybe and likely only
> visually showing the wrong selection.. as dragging the word doesn't eat the
> space

Step 4 is apparently as normal.. comparing with Word.. so a feature not a bug
(sorry 

The undo changing selecting is a bug. If you start typing.. the space will be
replaced to.. Compare with Word

Happy to create new report (as comment 0 containing a non-bug)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

Telesto  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|NOTABUG |---

--- Comment #6 from Telesto  ---
(In reply to Telesto from comment #4)
> Step 6 certainly wrong (probably side-effect). And maybe and likely only
> visually showing the wrong selection.. as dragging the word doesn't eat the
> space

Step 4 is apparently as normal.. comparing with Word.. so a feature not a bug
(sorry 

The undo changing selecting is a bug. If you start typing.. the space will be
replaced to.. Compare with Word

Happy to create new report (as comment 0 containing a non-bug)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

--- Comment #5 from Telesto  ---
Created attachment 168294
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168294=edit
Screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

--- Comment #5 from Telesto  ---
Created attachment 168294
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168294=edit
Screencast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

--- Comment #4 from Telesto  ---
(In reply to Heiko Tietze from comment #2)
> It's a feature not a bug. If you pick a real world example like "Hello brave
> new world!" and you move world between the l's of Hello and undo there wont
> be a trailing space after/before the exclamation mark. Shall we put effort
> into consistency and drop the space from the last word of a not finished
> document? Don't think so.

Kind of 2 bugs here (step 4 & 6_.. Ad step 4 to spaces are introduced (before
and after). So resultis "Hel world lo" where I would expect "Helworldlo".
At undo the selection 'world' has become ' world'

Step 4 can be seen as feature.. making drag and drop of words easier...

Step 6 certainly wrong (probably side-effect). And maybe and likely only
visually showing the wrong selection.. as dragging the word doesn't eat the
space

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

--- Comment #4 from Telesto  ---
(In reply to Heiko Tietze from comment #2)
> It's a feature not a bug. If you pick a real world example like "Hello brave
> new world!" and you move world between the l's of Hello and undo there wont
> be a trailing space after/before the exclamation mark. Shall we put effort
> into consistency and drop the space from the last word of a not finished
> document? Don't think so.

Kind of 2 bugs here (step 4 & 6_.. Ad step 4 to spaces are introduced (before
and after). So resultis "Hel world lo" where I would expect "Helworldlo".
At undo the selection 'world' has become ' world'

Step 4 can be seen as feature.. making drag and drop of words easier...

Step 6 certainly wrong (probably side-effect). And maybe and likely only
visually showing the wrong selection.. as dragging the word doesn't eat the
space

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 138995] A shape in front of textbox is position behind textbox after DOCX export (fine with DOC)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138995

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Keywords||filter:docx

--- Comment #4 from Regina Henschel  ---
It seems to be an import error. If I save the attached file to docx, then the
docx-file has the correct stacking order in Word.

It seems there is a mishandling of property "wrap through". The blue ellipse is
in front of the orange background of the text box, but behind the text of the
text box. So the stacking order seems to be correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139034] SPAM

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139034

Mike Kaganski  changed:

   What|Removed |Added

  Component|Installation|deletionRequest
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED
Summary|If yes, then it is a simple |SPAM
   |process. Now, for wireless  |
   |setup, you need the |
   |following.  |
URL|https://quick-helps.com/|

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - translations

[Andras Timar (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0c402356100bf4c0db342d31fcfca53d41eba962
Author: Andras Timar 
AuthorDate: Fri Dec 18 13:33:37 2020 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Dec 18 13:33:37 2020 +0100

Update git submodules

* Update translations from branch 'distro/collabora/cp-6.4'
  to 4418735900f7b96584fb9f2cd247e1ca858266f3
  - Translation update for 'Impress Table Shadow' feature

Change-Id: I21b277d71ea1cf4d7036683faf40e10c47f97ee0

diff --git a/translations b/translations
index c68bab7cc30d..4418735900f7 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit c68bab7cc30dfa80ac049eff819fdc1ea022f779
+Subproject commit 4418735900f7b96584fb9f2cd247e1ca858266f3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Branch 'distro/collabora/cp-6.4' - source/ar source/as source/ast source/bg source/bn-IN source/br source/ca source/ca-valencia source/cs source/cy source/da so

[Andras Timar (via logerrit)]

 source/ar/cui/messages.po  |  433 ++---
 source/as/cui/messages.po  |  433 ++---
 source/ast/cui/messages.po |  433 ++---
 source/bg/cui/messages.po  |  433 ++---
 source/bn-IN/cui/messages.po   |  433 ++---
 source/br/cui/messages.po  |  433 ++---
 source/ca-valencia/cui/messages.po |  433 ++---
 source/ca/cui/messages.po  |  433 ++---
 source/cs/cui/messages.po  |  433 ++---
 source/cy/cui/messages.po  |  433 ++---
 source/da/cui/messages.po  |  433 ++---
 source/de/cui/messages.po  |  433 ++---
 source/el/cui/messages.po  |  433 ++---
 source/en-GB/cui/messages.po   |  433 ++---
 source/es/cui/messages.po  |  172 +-
 source/et/cui/messages.po  |  433 ++---
 source/eu/cui/messages.po  |  433 ++---
 source/fi/cui/messages.po  |  433 ++---
 source/fr/cui/messages.po  |  433 ++---
 source/ga/cui/messages.po  |  433 ++---
 source/gd/cui/messages.po  |  433 ++---
 source/gl/cui/messages.po  |  433 ++---
 source/gu/cui/messages.po  |  433 ++---
 source/he/cui/messages.po  |  433 ++---
 source/hi/cui/messages.po  |  433 ++---
 source/hr/cui/messages.po  |  433 ++---
 source/hu/cui/messages.po  |  433 ++---
 source/id/cui/messages.po  |  433 ++---
 source/is/cui/messages.po  |  433 ++---
 source/it/cui/messages.po  |  433 ++---
 source/ja/cui/messages.po  |  433 ++---
 source/km/cui/messages.po  |  433 ++---
 source/kn/cui/messages.po  |  433 ++---
 source/ko/cui/messages.po  |  433 ++---
 source/lt/cui/messages.po  |  433 ++---
 source/lv/cui/messages.po  |  433 ++---
 source/ml/cui/messages.po  |  433 ++---
 source/mr/cui/messages.po  |  433 ++---
 source/nb/cui/messages.po  |  433 ++---
 source/nl/cui/messages.po  |  433 ++---
 source/nn/cui/messages.po  |  433 ++---
 source/oc/cui/messages.po  |  433 ++---
 source/or/cui/messages.po  |  433 ++---
 source/pa-IN/cui/messages.po   |  433 ++---
 source/pl/cui/messages.po  |  433 ++---
 source/pt-BR/cui/messages.po   |  433 ++---
 source/pt/cui/messages.po  |  433 ++---
 source/ro/cui/messages.po  |  435 ++---
 source/ru/cui/messages.po  |  433 ++---
 source/sk/cui/messages.po  |  433 ++---
 source/sl/cui/messages.po  | 3037 ++---
 source/sr-Latn/cui/messages.po |  439 ++---
 source/sr/cui/messages.po  |  439 ++---
 source/sv/cui/messages.po  |  433 ++---
 source/ta/cui/messages.po  |  437 ++---
 source/te/cui/messages.po  |  437 ++---
 source/tr/cui/messages.po  |  433 ++---
 source/uk/cui/messages.po  |  433 ++---
 source/vi/cui/messages.po  |  433 ++---
 source/zh-CN/cui/messages.po   |  433 ++---
 source/zh-TW/cui/messages.po   |  433 ++---
 61 files changed, 17046 insertions(+), 11732 deletions(-)

New commits:
commit 4418735900f7b96584fb9f2cd247e1ca858266f3
Author: Andras Timar 
AuthorDate: Fri Dec 18 13:33:03 2020 +0100
Commit: Andras Timar 
CommitDate: Fri Dec 18 13:33:03 2020 +0100

Translation update for 'Impress Table Shadow' feature

Change-Id: I21b277d71ea1cf4d7036683faf40e10c47f97ee0

diff --git a/source/ar/cui/messages.po b/source/ar/cui/messages.po
index 641f3e6d7bc..84455e1c1a9 100644
--- a/source/ar/cui/messages.po
+++ b/source/ar/cui/messages.po
@@ -3,7 +3,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI\n;
-"POT-Creation-Date: 2020-02-27 12:57+0100\n"
+"POT-Creation-Date: 2020-12-18 12:51+0100\n"
 "PO-Revision-Date: 2020-08-05 13:35+\n"
 "Last-Translator: صفا الفليج \n"
 "Language-Team: Arabic 
\n"
@@ -4263,163 +4263,163 @@ msgid "Parameters"
 msgstr "المعاملات"
 
 #. nxZTH
-#: cui/uiconfig/ui/applyautofmtpage.ui:47
+#: cui/uiconfig/ui/applyautofmtpage.ui:53
 msgctxt "applyautofmtpage|edit"
 msgid "_Edit..."
 msgstr "_حرر..."
 
 #. sYxng
-#: cui/uiconfig/ui/applyautofmtpage.ui:65
+#: cui/uiconfig/ui/applyautofmtpage.ui:71
 msgctxt "applyautofmtpage|label1"
 msgid "[M]: Replace while modifying existing text"
 msgstr "[ت]: تنسيق تلقائي أثناء تعديل النص الموجود"
 
 #. FtXg9
-#: cui/uiconfig/ui/applyautofmtpage.ui:77
+#: cui/uiconfig/ui/applyautofmtpage.ui:83
 msgctxt "applyautofmtpage|label2"
 msgid "[T]: AutoCorrect while typing"
 msgstr "[ك]: تصحيح تلقائي أثناء الكتابة"
 
 #. NujUD
-#: cui/uiconfig/ui/applyautofmtpage.ui:122
+#: cui/uiconfig/ui/applyautofmtpage.ui:128
 msgctxt "applyautofmtpage|m"
 msgid "[M]"
 msgstr "[ت]"
 
 #. qanx6
-#: cui/uiconfig/ui/applyautofmtpage.ui:137
+#: cui/uiconfig/ui/applyautofmtpage.ui:150
 msgctxt 

[Libreoffice-bugs] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

--- Comment #3 from Telesto  ---
Created attachment 168291
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168291=edit
Example file (Hello Brave World)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

--- Comment #3 from Telesto  ---
Created attachment 168291
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168291=edit
Example file (Hello Brave World)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139034] If yes, then it is a simple process. Now, for wireless setup, you need the following.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139034

cameron  changed:

   What|Removed |Added

   Keywords||accessibility
URL||https://quick-helps.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139034] New: If yes, then it is a simple process. Now, for wireless setup, you need the following.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139034

Bug ID: 139034
   Summary: If yes, then it is a simple process. Now, for wireless
setup, you need the following.
   Product: LibreOffice
   Version: 3.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: davidcameron1980flor...@gmail.com

Description:
If yes, then it is a simple process. Now, for wireless setup, you need the
following. USB cord, power cable, Officejet Pro 8035 driver, and wireless
router. 

Actual Results:
50

Expected Results:
30


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
17

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130275] "Insert > Field > More Fields" dialog is too high/tall - the OK/Cancel buttons get hidden behind the bottom panel of 'gnome-panel'

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130275

Kevin Suo  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |suokunl...@126.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #9 from Kevin Suo  ---
I've submitted the patch on gerrit:
https://gerrit.libreoffice.org/c/core/+/107965

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139033] New: Imported, rotated BMP doesn't save in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139033

Bug ID: 139033
   Summary: Imported, rotated BMP doesn't save in Writer
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: john.davies...@gmail.com

Description:
If I import an image (BMP in this case) into Writer, rotate it, save it (as a
.DOCX), then close writer, when I open writer again & load in the document, the
rotated BMP has gone.
Importing with no rotate will save OK.

Steps to Reproduce:
1.load in and rotate a BMP in Writer, save as .DOCX, close Writer.
2.Open Writer, load in document, BP has vanished.
3.

Actual Results:
As above

Expected Results:
As above


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138993] Remove commas in numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138993

--- Comment #14 from Uwe Auer  ---
Now I'm not sure whether this is an enhancement request or it is to be
considered a bug based on current supposed/intended functionality.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138993] Remove commas in numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138993

--- Comment #13 from Uwe Auer  ---
Steps to reproduce (from testing)

- Open a new Calc sheet
- Assure in Tools -> Options -> LibreOffice ->  Formula -> Section: Separators
-> Option: Function separator is set to "," (comma), which e.g is default for
English (USA)
- Insert: =1,947.68-1000

Actual Result: ERR:509

Expected Result: 947.68

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/source

[Szymon Kłos (via logerrit)]

 vcl/source/app/salvtables.cxx |3 ++-
 vcl/source/control/button.cxx |2 +-
 vcl/source/window/dialog.cxx  |2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 70f2fc7a10f41204e353bd3487377983a1018b53
Author: Szymon Kłos 
AuthorDate: Thu Dec 17 14:44:51 2020 +0100
Commit: Szymon Kłos 
CommitDate: Fri Dec 18 13:00:47 2020 +0100

lok: don't use focus window to request help

Use clicked button instead - what leads to the correct window.
If only focused window was taken into account sometimes
it caused incorrect help link to be used.

Change-Id: I645dc1ffa6a6d6d363ea5f9874fa830c441516c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107882
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index af2f66ca9b0e..4285b037c880 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -70,6 +70,7 @@
 #include 
 #include 
 #include 
+#include 
 
 SalFrame::SalFrame()
 : m_pWindow(nullptr)
@@ -6218,7 +6219,7 @@ void SalInstanceWindow::help()
 {
 //show help for widget with keyboard focus
 vcl::Window* pWidget = ImplGetSVData()->mpWinData->mpFocusWin;
-if (!pWidget)
+if (!pWidget || comphelper::LibreOfficeKit::isActive())
 pWidget = m_xWindow;
 OString sHelpId = pWidget->GetHelpId();
 while (sHelpId.isEmpty())
diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index a4ae36cffe15..fecb052628b7 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -1774,7 +1774,7 @@ void HelpButton::Click()
 if ( !GetClickHdl() )
 {
 vcl::Window* pFocusWin = Application::GetFocusWindow();
-if ( !pFocusWin )
+if ( !pFocusWin || comphelper::LibreOfficeKit::isActive() )
 pFocusWin = this;
 
 HelpEvent aEvt( pFocusWin->GetPointerPosPixel(), 
HelpEventMode::CONTEXT );
diff --git a/vcl/source/window/dialog.cxx b/vcl/source/window/dialog.cxx
index df9135f43058..536228b97ec8 100644
--- a/vcl/source/window/dialog.cxx
+++ b/vcl/source/window/dialog.cxx
@@ -1374,7 +1374,7 @@ IMPL_LINK(Dialog, ResponseHdl, Button*, pButton, void)
 if (nResponse == RET_HELP)
 {
 vcl::Window* pFocusWin = Application::GetFocusWindow();
-if (!pFocusWin)
+if (!pFocusWin || comphelper::LibreOfficeKit::isActive())
 pFocusWin = pButton;
 HelpEvent aEvt(pFocusWin->GetPointerPosPixel(), 
HelpEventMode::CONTEXT);
 pFocusWin->RequestHelp(aEvt);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 139029] The drag and drop position indicator and the actual 'drop' mismatched in table (arrow position defines the dropzone)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139029

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #6 from Heiko Tietze  ---
Happens only if the vertical position differs between the columns. If the left
cell has three lines (not necessarily paragraphs) or if you drag 'n drop from
the first line in the right column, the target position updates immediately
after moving the cursor behind the column border.

Version: 6.4.7.2
Build ID: 6.4.7-6
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5; 
Locale: de-DE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139029] The drag and drop position indicator and the actual 'drop' mismatched in table (arrow position defines the dropzone)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139029

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Keywords|needsUXEval |
 Ever confirmed|0   |1
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org

--- Comment #6 from Heiko Tietze  ---
Happens only if the vertical position differs between the columns. If the left
cell has three lines (not necessarily paragraphs) or if you drag 'n drop from
the first line in the right column, the target position updates immediately
after moving the cursor behind the column border.

Version: 6.4.7.2
Build ID: 6.4.7-6
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5; 
Locale: de-DE (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139032] New: Testing Bugzilla

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139032

Bug ID: 139032
   Summary: Testing Bugzilla
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mike.saund...@documentfoundation.org

Description:
Testing Bugzilla (problem reported on Twitter)

Steps to Reproduce:
1. No
2.
3.

Actual Results:
Nothing

Expected Results:
Nothing


Reproducible: Always


User Profile Reset: No



Additional Info:
Nothing

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||michael.st...@cib.de

--- Comment #2 from Heiko Tietze  ---
It's a feature not a bug. If you pick a real world example like "Hello brave
new world!" and you move world between the l's of Hello and undo there wont be
a trailing space after/before the exclamation mark. Shall we put effort into
consistency and drop the space from the last word of a not finished document?
Don't think so.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 139030] Spaces appear at thin air when drag & dropping text (or the visible selecting being wrong)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139030

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG
 CC||michael.st...@cib.de

--- Comment #2 from Heiko Tietze  ---
It's a feature not a bug. If you pick a real world example like "Hello brave
new world!" and you move world between the l's of Hello and undo there wont be
a trailing space after/before the exclamation mark. Shall we put effort into
consistency and drop the space from the last word of a not finished document?
Don't think so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 139031] Text alignment and width in PDF export dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139031

--- Comment #1 from medmedin2014  ---
Created attachment 168290
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168290=edit
image 2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 139031] New: Text alignment and width in PDF export dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139031

Bug ID: 139031
   Summary: Text alignment and width in PDF export dialog
   Product: LibreOffice
   Version: 7.0.3.1 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: med.medin.2...@gmail.com

Created attachment 168289
  --> https://bugs.documentfoundation.org/attachment.cgi?id=168289=edit
image 1

See attached images for more info.

Version: 7.0.3.1
Build ID: 00(Build:1)
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: en-US (en_US.UTF-8); UI: en-US
7.0.3-2
Calc: threaded

Operating System: Manjaro Linux
KDE Plasma Version: 5.20.4
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.2
Kernel Version: 5.4.80-2-MANJARO
OS Type: 64-bit

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 128216] UI: Relative paths should be displayed as relative

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128216

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5506

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135506] Relative paths are shown as absolute paths

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135506

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=86
   ||785,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8216
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
Thanks for reporting the bug. I haven't tested, but it sounds to me like a
duplicate of bug 128216. Waht do you think?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86785] Relative links UX in Writer master documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86785

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5506

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 138993] Remove commas in numbers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138993

--- Comment #12 from Uwe Auer  ---
ere's another test case with £ GBP pound symbol
> 
> 1. =£1000
> 2. Err:501
> 
> 
> 
> Similar example with $ doesn't work, as that's a special character, there's
> probably no way to use that in the formal box?
> 
> 1. =$1000
> 2. #REF!

Please don't mix issues, though these examples are no issues at all and are to
be expected since =£1000 is not a recognized number but text and =$1000 no a
valid reference.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs