[Libreoffice-bugs] [Bug 137561] LibreOffice Calc crashed when I attempt to change a formula using Find/Replace
https://bugs.documentfoundation.org/show_bug.cgi?id=137561 Justin L changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #10 from Justin L --- I believe that all of these settings are visible under advanced settings - so you can use the GUI to change the settings (if you can find them). Tools - Options - Advanced - Open Expert Configuration. That should be a little less intimidating - and also less error-prone than editing an XML file by hand. In any case, it sounds like the reported issue is resolved, so I'm closing it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sfx2/source sw/inc sw/sdi sw/source
sfx2/source/control/unoctitm.cxx|4 ++-- sw/inc/mdiexp.hxx |5 + sw/inc/view.hxx |2 +- sw/sdi/swriter.sdi |2 +- sw/source/core/view/viewsh.cxx | 26 +- sw/source/uibase/docvw/edtwin3.cxx |5 ++--- sw/source/uibase/inc/bookctrl.hxx |3 --- sw/source/uibase/uiview/pview.cxx | 14 +- sw/source/uibase/uiview/view2.cxx | 34 -- sw/source/uibase/utlui/bookctrl.cxx | 20 10 files changed, 45 insertions(+), 70 deletions(-) New commits: commit 2bd03b6de32a8bd6ff7d075752eda051a43e4add Author: Jim Raykowski AuthorDate: Fri Sep 18 01:32:01 2020 -0800 Commit: Adolfo Jayme Barrientos CommitDate: Wed Dec 23 08:51:50 2020 +0100 tdf#89709 Make statusbar page number/bookmarks control tooltip show Change-Id: I3a84ae29d4758799e1ee7e2ab1349ca3b30fb5f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102883 Tested-by: Jenkins Reviewed-by: Jim Raykowski (cherry picked from commit c81fea2e78d66c1978cb2340868c938ba9d6c9f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107701 Reviewed-by: Adolfo Jayme Barrientos diff --git a/sfx2/source/control/unoctitm.cxx b/sfx2/source/control/unoctitm.cxx index d51e5f3b443f..b32235b4ca48 100644 --- a/sfx2/source/control/unoctitm.cxx +++ b/sfx2/source/control/unoctitm.cxx @@ -1211,7 +1211,6 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, SfxViewFrame* pViewFra aEvent.FeatureURL.Path == "RowColSelCount" || aEvent.FeatureURL.Path == "StatusPageStyle" || aEvent.FeatureURL.Path == "StateTableCell" || - aEvent.FeatureURL.Path == "StatePageNumber" || aEvent.FeatureURL.Path == "StateWordCount" || aEvent.FeatureURL.Path == "PageStyleName" || aEvent.FeatureURL.Path == "PageStatus" || @@ -1271,7 +1270,8 @@ static void InterceptLOKStateChangeEvent(sal_uInt16 nSID, SfxViewFrame* pViewFra aBuffer.append(OUString::number(aSize.Width)).append(" x ").append(OUString::number(aSize.Height)); } } -else if (aEvent.FeatureURL.Path == "LanguageStatus") +else if (aEvent.FeatureURL.Path == "LanguageStatus" || + aEvent.FeatureURL.Path == "StatePageNumber") { css::uno::Sequence< OUString > aSeq; diff --git a/sw/inc/mdiexp.hxx b/sw/inc/mdiexp.hxx index eee934b66ddf..3901fce1c12f 100644 --- a/sw/inc/mdiexp.hxx +++ b/sw/inc/mdiexp.hxx @@ -34,10 +34,7 @@ extern bool IsScrollMDI(SwViewShell const * pVwSh, const SwRect &); extern void SizeNotify(SwViewShell const * pVwSh, const Size &); // Update of status bar during an action. -extern void PageNumNotify( SwViewShell const * pVwSh, -sal_uInt16 nPhyNum, -sal_uInt16 nVirtNum, - const OUString& rPg ); +extern void PageNumNotify(SwViewShell const * pVwSh); enum FlyMode { FLY_DRAG_START, FLY_DRAG, FLY_DRAG_END }; extern void FrameNotify( SwViewShell* pVwSh, FlyMode eMode = FLY_DRAG ); diff --git a/sw/inc/view.hxx b/sw/inc/view.hxx index 280388e1ac25..abdba739c3b7 100644 --- a/sw/inc/view.hxx +++ b/sw/inc/view.hxx @@ -547,7 +547,7 @@ public: voidInsertCaption(const InsCaptionOpt *pOpt); // Async call by Core -voidUpdatePageNums(sal_uInt16 nPhyNum, sal_uInt16 nVirtNum, const OUString& rPgStr); +void UpdatePageNums(); OUStringGetPageStr(sal_uInt16 nPhyNum, sal_uInt16 nVirtNum, const OUString& rPgStr); diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi index ccfc2821c4dc..9a03663dc19d 100644 --- a/sw/sdi/swriter.sdi +++ b/sw/sdi/swriter.sdi @@ -5785,7 +5785,7 @@ SfxVoidItem StateBookmark FN_STAT_BOOKMARK GroupId = SfxGroupId::Intern; ] -SfxStringItem StatePageNumber FN_STAT_PAGE +SfxStringListItem StatePageNumber FN_STAT_PAGE [ AutoUpdate = FALSE, diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index 1cc7288a6200..acf81134ba6b 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -1043,25 +1043,17 @@ void SwViewShell::SizeChgNotify() if ( !Imp()->IsCalcLayoutProgress() && dynamic_cast( this ) != nullptr ) { -const SwFrame *pCnt = static_cast(this)->GetCurrFrame( false ); -const SwPageFrame *pPage; -if ( pCnt && nullptr != (pPage = pCnt->FindPageFrame()) ) -{ -const sal_uInt16 nVirtNum = pPage->GetVirtPageNum(); -const SvxNumberType& rNum = pPage->GetPageDesc()->GetNumType(); -OUString sDisplay = rNum.GetNumStr( nVirtNum ); -PageNumNotify( this, pCnt->GetPhyPageNum(), nVirtNum, sDisplay ); +PageNumNotify(this); -if (comphelper::LibreOfficeKit::isActive()) -{ -
[Libreoffice-bugs] [Bug 139003] LO Calc: Exporting a Bubble Chart to PNG/JPG loses transparency of bubbles
https://bugs.documentfoundation.org/show_bug.cgi?id=139003 Martin Srdoš changed: What|Removed |Added Keywords||bisected --- Comment #4 from Martin Srdoš --- eacb701442c56f8adf5168de4b66a92a40248c75 is the first bad commit commit eacb701442c56f8adf5168de4b66a92a40248c75 Author: Norbert Thiebaud Date: Thu Aug 13 16:26:24 2020 -0700 source sha:bf021c369f2306ee507da9bd3cc4cd10ac5d234c source sha:bf021c369f2306ee507da9bd3cc4cd10ac5d234c I wanted to add Mike Kaganski to CC list, but there is "mike.kagan...@collabora.com did not match anything". I am sending mail to him. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9e0e40d65d92490b2946f4e2ac7ce763209a8339 Author: Olivier Hallot AuthorDate: Wed Dec 23 04:50:08 2020 -0300 Commit: Gerrit Code Review CommitDate: Wed Dec 23 08:50:08 2020 +0100 Update git submodules * Update helpcontent2 from branch 'libreoffice-7-1' to 44783fdc08c17e0103c79ad4471a1c3ddc33be29 - Fix a "D'oh! you found a bug" + Some refactor on the pages. Change-Id: Iec37d94dfa40292eeaae3dae3cf6ab1189fa8d2a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/108009 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/helpcontent2 b/helpcontent2 index 83a954cd538b..44783fdc08c1 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 83a954cd538bf5b56292067c3897971f685afb04 +Subproject commit 44783fdc08c17e0103c79ad4471a1c3ddc33be29 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139176] New: bug
https://bugs.documentfoundation.org/show_bug.cgi?id=139176 Bug ID: 139176 Summary: bug Product: cppunit Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mohitvermaj...@gmail.com CC: markus.mohrh...@googlemail.com A software bug is an error, flaw or fault in a computer program or system that causes it to produce an incorrect or unexpected result, or to behave in unintended ways. ... Bugs can trigger errors that may have ripple effects. Bugs may have subtle effects or cause the program to crash or freeze the computer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137421] Export as PDF misses fonts even if exported as PDF/A
https://bugs.documentfoundation.org/show_bug.cgi?id=137421 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=50 ||879 --- Comment #7 from Justin L --- Please retest in 7.1 to see if the issue is acceptable. Note the comments in bug 50879 that indicate that embedding an entire font in a PDF normally is not considered acceptable - for obvious size reasons. So please check if the workaround of forcing the edit text to be one of the standard fonts is acceptable. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121509] FILESAVE DOCX Shape jumps out of the frame after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121509 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1510 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121510] FILESAVE DOC Shape that is anchored "to frame" is lost after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121510 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1509 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121509] FILESAVE DOCX Shape jumps out of the frame after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121509 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=40 ||540 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40540] FILESAVE Losing shapes inside frame while saving to .DOC (MSO2003) (vector grafics)
https://bugs.documentfoundation.org/show_bug.cgi?id=40540 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1509 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139151] Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=139151 --- Comment #3 from hel...@wolff-dattenberg.net --- I start LibreOffice. In the menu left site I clicked "Impress Präsentation". Then it happened. LibreOffice crashed. When I start LibreOffice again, the new Imress Presentationis restored. Please note the attachment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139169] Shapes inside floating frame lost on DOC export
https://bugs.documentfoundation.org/show_bug.cgi?id=139169 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #3 from Telesto --- *** This bug has been marked as a duplicate of bug 40540 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40540] FILESAVE Losing shapes inside frame while saving to .DOC (MSO2003) (vector grafics)
https://bugs.documentfoundation.org/show_bug.cgi?id=40540 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #33 from Telesto --- *** Bug 139169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139151] Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=139151 --- Comment #2 from hel...@wolff-dattenberg.net --- Created attachment 168443 --> https://bugs.documentfoundation.org/attachment.cgi?id=168443=edit a describtion of "About LibreOfficeDev I start LibreOffice. In the menu left site I clicked "Impress Präsentation". Then it happened. LibreOffice crashed. When I start LibreOffice again, the new Impress Presentation is restored. Please note the attachment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135310] [META] Writer outline view bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=135310 --- Comment #7 from R. Hutchins --- Created attachment 168442 --> https://bugs.documentfoundation.org/attachment.cgi?id=168442=edit Illustration of requested darkening of "tree" structure The outline view is such a great improvement that I'm hesitant to even hazard a suggestion but I will anyway. The lines indicating the structure of the outline tree are almost invisible. These are the latitude and longitude of the Navigator; could they be made more prominent? Darker? Colored? Lengthen the horizontal lines? Thank you Jim Raikowski! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139003] LO Calc: Exporting a Bubble Chart to PNG/JPG loses transparency of bubbles
https://bugs.documentfoundation.org/show_bug.cgi?id=139003 Martin Srdoš changed: What|Removed |Added Keywords||bibisectRequest, regression -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121509] FILESAVE DOCX Shape jumps out of the frame after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121509 Aron Budea changed: What|Removed |Added Version|5.2 all versions|4.3.0.4 release --- Comment #12 from Aron Budea --- (In reply to Telesto from comment #11) > FWIW: it looked OK in 4.2 (for LO, didn't check MSO) It wasn't looking great in Word after saving as DOCX in 4.2.0.4, the shape was out of place in the top left corner of the page. In Writer it looks fine in 4.2.0.4, while no shape is shown in 4.3.0.4. In between there are crashes either at start or when you try to load the generated DOCX, and also ranges where the saved DOCX is empty. Eg. the frame returns without the shape somewhere in the following range: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=e81212315b5fe22e1005d41149a0ea1a557bf412..fe451fb94a33c914c0a7c1265c013d9704af850a -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/cib_contract57d' - 6 commits - download.lst external/pdfium RepositoryExternal.mk solenv/flatpak-manifest.in svx/source vcl/qa
RepositoryExternal.mk |1 download.lst |4 - external/pdfium/Library_pdfium.mk | 32 + external/pdfium/UnpackedTarball_pdfium.mk |3 external/pdfium/build.patch.1 | 46 -- external/pdfium/c++20-comparison.patch | 13 external/pdfium/inc/pch/precompiled_pdfium.hxx | 66 ++-- external/pdfium/visibility.patch.1 | 45 - solenv/flatpak-manifest.in |6 - svx/source/svdraw/svdpdf.cxx | 27 vcl/qa/cppunit/pdfexport/pdfexport.cxx | 81 + 11 files changed, 182 insertions(+), 142 deletions(-) New commits: commit 6b0e621b94da45739ce49f6ef137c9c84d00a086 Author: Miklos Vajna AuthorDate: Wed Jan 22 21:02:05 2020 +0100 Commit: Vasily Melenchuk CommitDate: Tue Dec 22 23:39:05 2020 +0300 pdfium: don't patch out the COMPONENT_BUILD check, define it So next time we update, no need to adapt a failing patch. Change-Id: I785f16047d1decbf922177fdde4bc6aad7cfebfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87215 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 08cfadf76c52..27e7f07d49ba 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -4154,6 +4154,7 @@ ifneq ($(ENABLE_PDFIUM),) define gb_LinkTarget__use_pdfium $(call gb_LinkTarget_set_include,$(1),\ -I$(call gb_UnpackedTarball_get_dir,pdfium)/public \ + -DCOMPONENT_BUILD \ $$(INCLUDE) \ ) $(call gb_LinkTarget_use_libraries,$(1),pdfium) diff --git a/external/pdfium/Library_pdfium.mk b/external/pdfium/Library_pdfium.mk index 1d645909b58a..8607fde503eb 100644 --- a/external/pdfium/Library_pdfium.mk +++ b/external/pdfium/Library_pdfium.mk @@ -31,6 +31,7 @@ $(eval $(call gb_Library_add_defs,pdfium,\ -DMEMORY_TOOL_REPLACES_ALLOCATOR \ -DUNICODE \ -DWIN32_LEAN_AND_MEAN \ +-DCOMPONENT_BUILD \ )) $(eval $(call gb_Library_set_generated_cxx_suffix,pdfium,cpp)) diff --git a/external/pdfium/UnpackedTarball_pdfium.mk b/external/pdfium/UnpackedTarball_pdfium.mk index ba1a7e994dbf..93d3fede6e3c 100644 --- a/external/pdfium/UnpackedTarball_pdfium.mk +++ b/external/pdfium/UnpackedTarball_pdfium.mk @@ -8,7 +8,6 @@ # pdfium_patches := -pdfium_patches += visibility.patch.1 pdfium_patches += ubsan.patch # Fixes build on our baseline. pdfium_patches += build.patch.1 diff --git a/external/pdfium/visibility.patch.1 b/external/pdfium/visibility.patch.1 deleted file mode 100644 index 14a380bbfa16.. --- a/external/pdfium/visibility.patch.1 +++ /dev/null @@ -1,22 +0,0 @@ -diff --git a/public/fpdfview.h b/public/fpdfview.h -index 0542b0541..2c9a37b4a 100644 a/public/fpdfview.h -+++ b/public/fpdfview.h -@@ -175,7 +175,6 @@ typedef int FPDF_ANNOT_APPEARANCEMODE; - // Dictionary value types. - typedef int FPDF_OBJECT_TYPE; - --#if defined(COMPONENT_BUILD) - // FPDF_EXPORT should be consistent with |export| in the pdfium_fuzzer - // template in testing/fuzzers/BUILD.gn. - #if defined(WIN32) -@@ -191,9 +190,6 @@ typedef int FPDF_OBJECT_TYPE; - #define FPDF_EXPORT - #endif // defined(FPDF_IMPLEMENTATION) - #endif // defined(WIN32) --#else --#define FPDF_EXPORT --#endif // defined(COMPONENT_BUILD) - - #if defined(WIN32) && defined(FPDFSDK_EXPORTS) - #define FPDF_CALLCONV __stdcall commit 3f86d67a7367b4e7dfdc67f7cbdd71058e3aa5fb Author: Stephan Bergmann AuthorDate: Fri Jan 17 18:27:14 2020 +0100 Commit: Vasily Melenchuk CommitDate: Tue Dec 22 23:38:44 2020 +0300 external/pdfium: C++20 comparison operator fix Missing const leads to overload resolution ambiguity when a synthesized candidate of operator == for a reversed-argument rewrite conflicts with the actual operator ==, due to the asymmetric const-ness of the implicit object parameter and the RHS parameter: > In file included from workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.cpp:7: > In file included from workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.h:11: > llvm/inst/include/c++/v1/vector:1369:27: error: use of overloaded operator '!=' is ambiguous (with operand types 'std::__1::__vector_base >::allocator_type' (aka 'FxAllocAllocator') and 'std::__1::__vector_base >::allocator_type') > if (__base::__alloc() != __c.__alloc()) > ~ ^ ~ > llvm/inst/include/c++/v1/vector:1359:5: note: in instantiation of member function 'std::__1::vector >::__move_assign' requested here > __move_assign(__x, integral_constant ^ > workdir/UnpackedTarball/pdfium/core/fxge/cfx_font.cpp:384:24: note: in instantiation of member function 'std::__1::vector >::operator=' requested here > m_FontDataAllocation = std::vector>( >^ >
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source
sw/qa/extras/ooxmlexport/data/croppedAndRotated.odt |binary sw/qa/extras/ooxmlexport/ooxmlexport13.cxx |4 - sw/qa/extras/ooxmlexport/ooxmlexport15.cxx | 14 ++ sw/qa/inc/swmodeltestbase.hxx |8 +++ sw/source/filter/ww8/docxattributeoutput.cxx| 42 sw/source/filter/ww8/docxattributeoutput.hxx|3 - 6 files changed, 53 insertions(+), 18 deletions(-) New commits: commit d0b5d0a7e6405742c0de746e7b740fd2547654cd Author: Mike Kaganski AuthorDate: Fri Dec 18 13:12:50 2020 +0300 Commit: Mike Kaganski CommitDate: Wed Dec 23 07:41:00 2020 +0100 tdf#138953: use original (cropped, but unrotated) object size in spPr This not only fixes the regression from b226383a83e41bbced9fc2a02dc09a449401ec97, but also makes the written size more correct than before, when it was slightly larger compared to original object size. Corrected unit test for tdf#116371 reflect that: the object in ODT is 241.78 mm x 240.61 mm. It previously was exported as 241.88 x 240.70; now the exported size is closer: 241.79 x 240.63. This backport introduces getShapes from 36e62098c8c541c4a3fb63eced591cf29ac56e4a to make backporting easier. Change-Id: Ibfe85c7cd98c089e58af8d7f3848990af8e1100f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107957 Tested-by: Jenkins Reviewed-by: Mike Kaganski Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108227 Tested-by: Jenkins CollaboraOffice diff --git a/sw/qa/extras/ooxmlexport/data/croppedAndRotated.odt b/sw/qa/extras/ooxmlexport/data/croppedAndRotated.odt new file mode 100644 index ..825db09da8bf Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/croppedAndRotated.odt differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx index 5fbe91f16070..f26859d48e4e 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport13.cxx @@ -554,8 +554,8 @@ DECLARE_OOXMLEXPORT_TEST(testTdf116371, "tdf116371.odt") auto xShape(getShape(1)); CPPUNIT_ASSERT_DOUBLES_EQUAL(4700.0, getProperty(xShape, "RotateAngle"), 10); auto frameRect = getProperty(xShape, "FrameRect"); -CPPUNIT_ASSERT_EQUAL(sal_Int32(24070), frameRect.Height); -CPPUNIT_ASSERT_EQUAL(sal_Int32(24188), frameRect.Width); +CPPUNIT_ASSERT_EQUAL(sal_Int32(24063), frameRect.Height); +CPPUNIT_ASSERT_EQUAL(sal_Int32(24179), frameRect.Width); } DECLARE_OOXMLEXPORT_TEST(testFrameSizeExport, "floating-tables-anchor.docx") diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx index a663e914db1e..843ef1f3704c 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport15.cxx @@ -143,6 +143,20 @@ DECLARE_OOXMLEXPORT_TEST(testTdf135973, "tdf135973.odt") } } +DECLARE_OOXMLEXPORT_TEST(testTdf138953, "croppedAndRotated.odt") +{ +CPPUNIT_ASSERT_EQUAL(1, getShapes()); +CPPUNIT_ASSERT_EQUAL(1, getPages()); +// Make sure the rotation is exported correctly, and size not distorted +auto xShape(getShape(1)); +CPPUNIT_ASSERT_EQUAL(27000.0, getProperty(xShape, "RotateAngle")); +auto frameRect = getProperty(xShape, "FrameRect"); +// Before the fix, original object size (i.e., before cropping) was written to spPr in OOXML, +// and the resulting object size was much larger than should be. +CPPUNIT_ASSERT_EQUAL(sal_Int32(12961), frameRect.Height); +CPPUNIT_ASSERT_EQUAL(sal_Int32(8664), frameRect.Width); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sw/qa/inc/swmodeltestbase.hxx b/sw/qa/inc/swmodeltestbase.hxx index 38f8e95a4a40..6119365c6392 100644 --- a/sw/qa/inc/swmodeltestbase.hxx +++ b/sw/qa/inc/swmodeltestbase.hxx @@ -895,6 +895,14 @@ protected: return xCursor->getPage(); } +/// Get shape count. +int getShapes() const +{ +uno::Reference xDrawPageSupplier(mxComponent, uno::UNO_QUERY); +uno::Reference xDraws = xDrawPageSupplier->getDrawPage(); +return xDraws->getCount(); +} + /** * Given that some problem doesn't affect the result in the importer, we * test the resulting file directly, by opening the zip file, parsing an diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 0e849c8142d7..7d614a206c7b 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -4764,13 +4764,12 @@ void DocxAttributeOutput::DefaultStyle() /* Writes tag back to document.xml if a file contains a cropped image. * NOTE : Tested on images of type JPEG,EMF/WMF,BMP, PNG and GIF. */ -void DocxAttributeOutput::WriteSrcRect(const SdrObject* pSdrObj, const SwFrameFormat* pFrameFormat ) +void
[Libreoffice-commits] core.git: writerfilter/qa xmloff/source
writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx |2 +- xmloff/source/style/xmlstyle.cxx |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit ca7d0835008b2333eaebe88030f94b5e072d0eb6 Author: Stephan Bergmann AuthorDate: Tue Dec 22 20:01:28 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Dec 23 07:34:10 2020 +0100 Fix dubious OUStringLiteral with automatic storage duration Change-Id: I0c80ce6efbbc950ce975e55663a5643ea8fb37f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108215 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx b/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx index 77bd616f37d6..355b61898cf8 100644 --- a/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx @@ -90,7 +90,7 @@ CPPUNIT_TEST_FIXTURE(Test, testNumberingRestartStyleParent) uno::UNO_QUERY); uno::Reference xParaEnum = xParaEnumAccess->createEnumeration(); uno::Reference xPara; -OUStringLiteral aProp(u"ListLabelString"); +static OUStringLiteral aProp(u"ListLabelString"); xPara.set(xParaEnum->nextElement(), uno::UNO_QUERY); CPPUNIT_ASSERT_EQUAL(OUString("A."), xPara->getPropertyValue(aProp).get()); xPara.set(xParaEnum->nextElement(), uno::UNO_QUERY); diff --git a/xmloff/source/style/xmlstyle.cxx b/xmloff/source/style/xmlstyle.cxx index ced74c90aab5..9453e1963729 100644 --- a/xmloff/source/style/xmlstyle.cxx +++ b/xmloff/source/style/xmlstyle.cxx @@ -51,6 +51,7 @@ #include #include +#include #include using namespace ::com::sun::star; @@ -598,7 +599,7 @@ Reference < XAutoStyleFamily > SvXMLStylesContext::GetAutoStyles( XmlStyleFamily xAutoStyles = mxParaAutoStyles; else { -OUStringLiteral sName = bPara ? OUStringLiteral( u"ParagraphStyles" ): OUStringLiteral( u"CharacterStyles" ); +OUString sName(bPara ? std::u16string_view( u"ParagraphStyles" ): std::u16string_view( u"CharacterStyles" )); Reference< XAutoStylesSupplier > xAutoStylesSupp( GetImport().GetModel(), UNO_QUERY ); Reference< XAutoStyles > xAutoStyleFamilies = xAutoStylesSupp->getAutoStyles(); if (xAutoStyleFamilies->hasByName(sName)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/unoidl/unopage.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit bbf65fd839a757b0f446c1cffb7938f82a6a1e67 Author: Stephan Bergmann AuthorDate: Tue Dec 22 19:56:56 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Dec 23 07:31:29 2020 +0100 Use optional rest argument of OUString::startsWith Change-Id: Id8f9e7464c2c35a1a5ffadbc4c9c5d1f0d780923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/sd/source/ui/unoidl/unopage.cxx b/sd/source/ui/unoidl/unopage.cxx index 54a779ade127..b082556d17b6 100644 --- a/sd/source/ui/unoidl/unopage.cxx +++ b/sd/source/ui/unoidl/unopage.cxx @@ -2226,10 +2226,10 @@ void SAL_CALL SdDrawPage::setName( const OUString& rName ) return; // check if this is the default 'page1234' name -if(aName.startsWith( sEmptyPageName )) +OUString aNumber; +if(aName.startsWith( sEmptyPageName, )) { -// ok, it maybe is, first get the number part after 'page' -OUString aNumber( aName.copy( sizeof( sEmptyPageName ) - 1 ) ); +// ok, it maybe is, aNumber is the number part after 'page' // create the page number sal_Int32 nPageNumber = aNumber.toInt32(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: starmath/source
starmath/source/mathmlexport.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 2fa55357223595a98c0dbc8bdb917b77a170da80 Author: Stephan Bergmann AuthorDate: Tue Dec 22 19:53:31 2020 +0100 Commit: Stephan Bergmann CommitDate: Wed Dec 23 07:30:59 2020 +0100 Use OUStringChar Change-Id: I4780de855682d252bd12bcf8f0c0c7230098f3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/starmath/source/mathmlexport.cxx b/starmath/source/mathmlexport.cxx index b20c5acd935a..29a25008f9f6 100644 --- a/starmath/source/mathmlexport.cxx +++ b/starmath/source/mathmlexport.cxx @@ -646,8 +646,7 @@ void SmXMLExport::ExportBinaryDiagonal(const SmNode* pNode, int nLevel) { // Scoping for creation SvXMLElementExport aMo(*this, XML_NAMESPACE_MATH, XML_MO, true, true); -sal_Unicode const nArse[2] = { MS_BACKSLASH, 0x00 }; -GetDocHandler()->characters(nArse); +GetDocHandler()->characters(OUStringChar(MS_BACKSLASH)); } ExportNodes(pNode->GetSubNode(1), nLevel); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 106178] Page break slow repaint
https://bugs.documentfoundation.org/show_bug.cgi?id=106178 --- Comment #8 from edencap --- Nice to see this post here and thanks for sharing this to us. PerYourHealthy is online bill pay portal which allows users to pay their hospital bills while sitting at home. The user can simply get a login, complete the entire process without facing any kind of trouble at www.peryourhealth.com pay bill https://peryourhealth.vip -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 99477] EDITING: "View> Freeze Cells> Freeze First..." does not work if the sheet is already frozen
https://bugs.documentfoundation.org/show_bug.cgi?id=99477 William Kie changed: What|Removed |Added URL||https://www.offiice-setupp. ||com --- Comment #34 from William Kie --- I am a Blogger and Digital Marketing Analyst by profession. Having 3+ Years Experience in SEO SMO & PPC. Hire me for any Digital Marketing Services. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104110] FILEOPEN RTF: The text within a textbox contained in a drawing canvas is invisible
https://bugs.documentfoundation.org/show_bug.cgi?id=104110 Aron Budea changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=12 | |6173| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139110] FILEOPEN RTF: Text frame in autoshape textbox is mispositioned
https://bugs.documentfoundation.org/show_bug.cgi?id=139110 Aron Budea changed: What|Removed |Added Attachment #168395|application/msword |application/rtf mime type|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139110] FILEOPEN RTF: Text frame in autoshape textbox is mispositioned
https://bugs.documentfoundation.org/show_bug.cgi?id=139110 Aron Budea changed: What|Removed |Added Attachment #168364|application/msword |application/rtf mime type|| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121509] FILESAVE DOCX Shape jumps out of the frame after export
https://bugs.documentfoundation.org/show_bug.cgi?id=121509 Aron Budea changed: What|Removed |Added Attachment #146734|application/binary |application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139175] New: Import from Apple Pages
https://bugs.documentfoundation.org/show_bug.cgi?id=139175 Bug ID: 139175 Summary: Import from Apple Pages Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sratcliffjo...@mac.com Description: Apple's Pages has been more than a little ignored for some years and is missing key functionality which means, at least for me, I have to find an alternative. Libre Office includes a critical function that Pages does not: Setting an individual page to Landscape in a portrait document. But I want to import my existing 300 page Pages document without going through a conversion to PDF or MS Word. Steps to Reproduce: 1.Try to import a Pages document 2. 3. Actual Results: Its not possible Expected Results: Its not possible Reproducible: Always User Profile Reset: No Additional Info: Given the user an option to import a Pages document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139020] elementary: Proposal to Revert All Blue-Violet Color Arrow Pair to One Coherent Color
https://bugs.documentfoundation.org/show_bug.cgi?id=139020 --- Comment #4 from andreas_k --- (In reply to andreas_k from comment #2) > > b) either orange. We can see original orange element in Bring to Front > > (.uno:BringToFront) which was taken from > > https://github.com/elementary/icons/blob/master/actions/24/selection-top.svg > > Yes the old orange was a bit to bright. The new one from elementary is > better. So let's go with orange. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
icon-themes/elementary/cmd/32/conditionalformatdialog.png |binary icon-themes/elementary/cmd/sc_basicideappear.png |binary icon-themes/elementary_svg/cmd/32/conditionalformatdialog.svg |1 + icon-themes/elementary_svg/cmd/sc_basicideappear.svg |1 + 4 files changed, 2 insertions(+) New commits: commit cfab2f5ee4724d5759e7aa000234a4bd309c3e2d Author: Rizal Muttaqin AuthorDate: Wed Dec 23 05:05:25 2020 +0700 Commit: Rizal Muttaqin CommitDate: Wed Dec 23 05:48:27 2020 +0100 elementary: restore deleted Macro Editor & Pivot Table icons Change-Id: I2906674004223916152f3d8b893237410969036d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108226 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin diff --git a/icon-themes/elementary/cmd/32/conditionalformatdialog.png b/icon-themes/elementary/cmd/32/conditionalformatdialog.png new file mode 100644 index ..2e99736f5977 Binary files /dev/null and b/icon-themes/elementary/cmd/32/conditionalformatdialog.png differ diff --git a/icon-themes/elementary/cmd/sc_basicideappear.png b/icon-themes/elementary/cmd/sc_basicideappear.png new file mode 100644 index ..21202eb6c47e Binary files /dev/null and b/icon-themes/elementary/cmd/sc_basicideappear.png differ diff --git a/icon-themes/elementary_svg/cmd/32/conditionalformatdialog.svg b/icon-themes/elementary_svg/cmd/32/conditionalformatdialog.svg new file mode 100644 index ..992a01a9394d --- /dev/null +++ b/icon-themes/elementary_svg/cmd/32/conditionalformatdialog.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file diff --git a/icon-themes/elementary_svg/cmd/sc_basicideappear.svg b/icon-themes/elementary_svg/cmd/sc_basicideappear.svg new file mode 100644 index ..a074d9a9ad74 --- /dev/null +++ b/icon-themes/elementary_svg/cmd/sc_basicideappear.svg @@ -0,0 +1 @@ +http://www.w3.org/2000/svg; xmlns:xlink="http://www.w3.org/1999/xlink;> \ No newline at end of file ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 120949] [META] Elementary icons
https://bugs.documentfoundation.org/show_bug.cgi?id=120949 Rizal Muttaqin changed: What|Removed |Added Depends on||139174 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139174 [Bug 139174] [UI] elementary: icons for (work)sheet does not represent actual sheet -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139174] [UI] elementary: icons for (work)sheet does not represent actual sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=139174 Rizal Muttaqin changed: What|Removed |Added Blocks||120949 Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org |desktop.org | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120949 [Bug 120949] [META] Elementary icons -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139174] New: [UI] elementary: icons for (work)sheet does not represent actual sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=139174 Bug ID: 139174 Summary: [UI] elementary: icons for (work)sheet does not represent actual sheet Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: riz...@libreoffice.org Created attachment 168441 --> https://bugs.documentfoundation.org/attachment.cgi?id=168441=edit Sheet related icons in elementary theme Using elementary icon in Calc, I notice that icons for sheet related command are not looked like an actual sheet, rather than a plain table Step to reproduce 1. Change icon theme to elementary (Tools > Options > View) 2. Open up Calc, right click on sheet list in the bottom 3. Change UI to Tabbed, go to Layout, see some icons with Sheet name 4. Enable menubar, go to Edit > Select 5. See of each icon there Version: 7.0.4.2 Build ID: 00(Build:2) CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5 Locale: id-ID (id_ID.UTF-8); UI: en-US Ubuntu package version: 1:7.0.4~rc2-0ubuntu0.20.04.2 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139142] Directly applied font is reset from Input List field after saving to DOCX and reloading
https://bugs.documentfoundation.org/show_bug.cgi?id=139142 mulla.tasa...@gmail.com changed: What|Removed |Added CC||mulla.tasa...@gmail.com --- Comment #1 from mulla.tasa...@gmail.com --- Thank you for reporting the bug. I can not reproduce the bug in Version: 7.2.0.0.alpha0+ (x64) Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/source
basic/source/inc/rtlproto.hxx |2 basic/source/runtime/stdobj.cxx | 612 2 files changed, 306 insertions(+), 308 deletions(-) New commits: commit 8f0a57d076d9f720d7918b51cfc04bec472a530d Author: Mike Kaganski AuthorDate: Tue Dec 22 12:55:49 2020 +0300 Commit: Mike Kaganski CommitDate: Wed Dec 23 05:31:30 2020 +0100 Drop RTLNAME obfuscating macro which only purpose is to make "git grep SbRtl_Foo" a kind of IQ test. Change-Id: I47cfc2ecd1cc4a5ecf2e348465554fa2caeaccf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108218 Tested-by: Jenkins Reviewed-by: Mike Kaganski diff --git a/basic/source/inc/rtlproto.hxx b/basic/source/inc/rtlproto.hxx index 2d0cb78f84b7..0bc7ac24a4ec 100644 --- a/basic/source/inc/rtlproto.hxx +++ b/basic/source/inc/rtlproto.hxx @@ -21,8 +21,6 @@ #include -#define RTLNAME( name ) _##name - typedef void( *RtlCall ) ( StarBASIC* p, SbxArray& rArgs, bool bWrite ); // Properties diff --git a/basic/source/runtime/stdobj.cxx b/basic/source/runtime/stdobj.cxx index b2627748915a..18f8f255d4d2 100644 --- a/basic/source/runtime/stdobj.cxx +++ b/basic/source/runtime/stdobj.cxx @@ -69,428 +69,428 @@ struct Methods { static Methods aMethods[] = { -{ "Abs",SbxDOUBLE,1 | FUNCTION_, RTLNAME(Abs),0 }, +{ "Abs",SbxDOUBLE,1 | FUNCTION_, SbRtl_Abs,0 }, { "number", SbxDOUBLE, 0,nullptr,0 }, -{ "Array", SbxOBJECT,FUNCTION_, RTLNAME(Array),0 }, -{ "Asc",SbxLONG, 1 | FUNCTION_, RTLNAME(Asc),0 }, +{ "Array", SbxOBJECT,FUNCTION_, SbRtl_Array,0 }, +{ "Asc",SbxLONG, 1 | FUNCTION_, SbRtl_Asc,0 }, { "string", SbxSTRING, 0,nullptr,0 }, -{ "AscW", SbxLONG, 1 | FUNCTION_ | COMPATONLY_, RTLNAME(Asc),0}, +{ "AscW", SbxLONG, 1 | FUNCTION_ | COMPATONLY_, SbRtl_Asc,0}, { "string", SbxSTRING, 0,nullptr,0 }, -{ "Atn",SbxDOUBLE,1 | FUNCTION_, RTLNAME(Atn),0 }, +{ "Atn",SbxDOUBLE,1 | FUNCTION_, SbRtl_Atn,0 }, { "number", SbxDOUBLE, 0,nullptr,0 }, -{ "ATTR_ARCHIVE", SbxINTEGER, CPROP_,RTLNAME(ATTR_ARCHIVE),0}, -{ "ATTR_DIRECTORY", SbxINTEGER, CPROP_,RTLNAME(ATTR_DIRECTORY),0 }, -{ "ATTR_HIDDEN",SbxINTEGER, CPROP_,RTLNAME(ATTR_HIDDEN),0 }, -{ "ATTR_NORMAL",SbxINTEGER, CPROP_,RTLNAME(ATTR_NORMAL),0 }, -{ "ATTR_READONLY", SbxINTEGER, CPROP_,RTLNAME(ATTR_READONLY),0 }, -{ "ATTR_SYSTEM",SbxINTEGER, CPROP_,RTLNAME(ATTR_SYSTEM),0 }, -{ "ATTR_VOLUME",SbxINTEGER, CPROP_,RTLNAME(ATTR_VOLUME),0 }, - -{ "Beep", SbxNULL, FUNCTION_, RTLNAME(Beep),0}, -{ "Blue",SbxINTEGER, 1 | FUNCTION_ | NORMONLY_, RTLNAME(Blue),0 }, +{ "ATTR_ARCHIVE", SbxINTEGER, CPROP_,SbRtl_ATTR_ARCHIVE,0}, +{ "ATTR_DIRECTORY", SbxINTEGER, CPROP_,SbRtl_ATTR_DIRECTORY,0 }, +{ "ATTR_HIDDEN",SbxINTEGER, CPROP_,SbRtl_ATTR_HIDDEN,0 }, +{ "ATTR_NORMAL",SbxINTEGER, CPROP_,SbRtl_ATTR_NORMAL,0 }, +{ "ATTR_READONLY", SbxINTEGER, CPROP_,SbRtl_ATTR_READONLY,0 }, +{ "ATTR_SYSTEM",SbxINTEGER, CPROP_,SbRtl_ATTR_SYSTEM,0 }, +{ "ATTR_VOLUME",SbxINTEGER, CPROP_,SbRtl_ATTR_VOLUME,0 }, + +{ "Beep", SbxNULL, FUNCTION_, SbRtl_Beep,0}, +{ "Blue",SbxINTEGER, 1 | FUNCTION_ | NORMONLY_, SbRtl_Blue,0 }, { "RGB-Value", SbxLONG, 0,nullptr,0 }, -{ "CallByName", SbxVARIANT, 3 | FUNCTION_, RTLNAME(CallByName),0 }, +{ "CallByName", SbxVARIANT, 3 | FUNCTION_, SbRtl_CallByName,0 }, { "Object", SbxOBJECT, 0,nullptr,0 }, { "ProcedureName",SbxSTRING, 0,nullptr,0 }, { "CallType", SbxINTEGER, 0,nullptr,0 }, -{ "CBool", SbxBOOL, 1 | FUNCTION_, RTLNAME(CBool),0 }, +{ "CBool", SbxBOOL, 1 | FUNCTION_, SbRtl_CBool,0 }, { "expression", SbxVARIANT, 0,nullptr,0 }, -{ "CByte", SbxBYTE, 1 | FUNCTION_, RTLNAME(CByte),0 }, +{ "CByte", SbxBYTE, 1 | FUNCTION_, SbRtl_CByte,0 }, { "expression", SbxVARIANT, 0,nullptr,0 }, -{ "CCur", SbxCURRENCY, 1 | FUNCTION_, RTLNAME(CCur),0}, +{ "CCur", SbxCURRENCY, 1 | FUNCTION_, SbRtl_CCur,0}, { "expression", SbxVARIANT, 0,nullptr,0 }, -{ "CDate", SbxDATE, 1 | FUNCTION_, RTLNAME(CDate),0 }, +{ "CDate", SbxDATE, 1 | FUNCTION_, SbRtl_CDate,0 }, { "expression", SbxVARIANT, 0,nullptr,0 }, -{ "CDateFromUnoDate", SbxDATE, 1 | FUNCTION_, RTLNAME(CDateFromUnoDate),0}, +{ "CDateFromUnoDate", SbxDATE, 1 |
[Libreoffice-bugs] [Bug 139144] FILESAVE DOCX: Missing frames in footer after export
https://bugs.documentfoundation.org/show_bug.cgi?id=139144 mulla.tasa...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||mulla.tasa...@gmail.com --- Comment #3 from mulla.tasa...@gmail.com --- Thank you for reporting the bug. I can confirm that the bug is present in Version: 7.0.3.1 (x64) Build ID: d7547858d014d4cf69878db179d326fc3483e082 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL Version: 7.2.0.0.alpha0+ (x64) Build ID: 761a672d62df1891b9f4f367a499b220ab2b33fa CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139074] CRASH on Paste from clipboard into dialog or other floating window, paste to document canvas is fine; Windows only?
https://bugs.documentfoundation.org/show_bug.cgi?id=139074 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138738] graphic error
https://bugs.documentfoundation.org/show_bug.cgi?id=138738 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138740] position and size is not correctly saved after vertical flipping a two anchored shape
https://bugs.documentfoundation.org/show_bug.cgi?id=138740 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138746] Two undo steps when using 'clear direct formatting' from set paragraph style dropdown in the toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=138746 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136864] If columns has a formula in them, and cell is copied or cut to another cell, sort follows (rightly) the copied or cut cell, therefore sort, sorts wrongly.
https://bugs.documentfoundation.org/show_bug.cgi?id=136864 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138756] Image transparent/white if the anchor to paragraph snaps to previous page (while image still on the following page)
https://bugs.documentfoundation.org/show_bug.cgi?id=138756 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138745] The selection area in certain area's is twice as blue as expected after undo
https://bugs.documentfoundation.org/show_bug.cgi?id=138745 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138753] Frame disappears/ becoming transparent dragging the frame up after DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=138753 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138730] Enhancement: Linking slides
https://bugs.documentfoundation.org/show_bug.cgi?id=138730 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138754] Undo/redo duplicating the pasting of an image frame (with image)
https://bugs.documentfoundation.org/show_bug.cgi?id=138754 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138735] Memory usage doubled opening a basic file (from 200 to 400 MB) since 7.1 (skia related)
https://bugs.documentfoundation.org/show_bug.cgi?id=138735 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138728] Help for default template, excess prompt and right-click
https://bugs.documentfoundation.org/show_bug.cgi?id=138728 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138726] mixing paragraph styles gets weird format values
https://bugs.documentfoundation.org/show_bug.cgi?id=138726 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138733] Blue-colored left border and bottom lines remain after leaving Tables, Queries and Forms icon menus.
https://bugs.documentfoundation.org/show_bug.cgi?id=138733 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138737] Writer 4.4.7.2 is opening in 3 seconds (warm start) while 7.1 takes 8 seconds
https://bugs.documentfoundation.org/show_bug.cgi?id=138737 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138727] Help right-hand pane lacks scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=138727 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139137] Mac OSX Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133303] Spreadsheet export as PDF produces zero margin document
https://bugs.documentfoundation.org/show_bug.cgi?id=133303 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139137] Mac OSX Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133303] Spreadsheet export as PDF produces zero margin document
https://bugs.documentfoundation.org/show_bug.cgi?id=133303 --- Comment #7 from QA Administrators --- Dear PK Seet, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133263] resizing RTL table column width hides text / displaces text beyond cell boundaries
https://bugs.documentfoundation.org/show_bug.cgi?id=133263 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133263] resizing RTL table column width hides text / displaces text beyond cell boundaries
https://bugs.documentfoundation.org/show_bug.cgi?id=133263 --- Comment #4 from QA Administrators --- Dear yallabalagan, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134296] error: install hyphenation package for locale
https://bugs.documentfoundation.org/show_bug.cgi?id=134296 --- Comment #2 from QA Administrators --- Dear fabi...@webmail.co.za, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131918] FILESAVE Graph -> Data Ranges -> Data Series - does not keep data series order after save and reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=131918 --- Comment #2 from QA Administrators --- Dear michal, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134292] Crash in: com::sun::star::uno::Sequence::~Sequence()
https://bugs.documentfoundation.org/show_bug.cgi?id=134292 --- Comment #2 from QA Administrators --- Dear vijaya chandra, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90739] FORMULA EXPORTING: exporting formula to MS word loses formatting, shifts rendered image
https://bugs.documentfoundation.org/show_bug.cgi?id=90739 --- Comment #31 from QA Administrators --- Dear Yury, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59181] docx formulas with messed parentheses hierarchy don't show correctly in LibO
https://bugs.documentfoundation.org/show_bug.cgi?id=59181 --- Comment #14 from QA Administrators --- Dear Ruslan Kabatsayev, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105460] FILEOPEN text color in SmartArt is different than in PP
https://bugs.documentfoundation.org/show_bug.cgi?id=105460 --- Comment #5 from QA Administrators --- Dear Haleh Alemasoom, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105346] Swash glyph clipped (EB Garamond)
https://bugs.documentfoundation.org/show_bug.cgi?id=105346 --- Comment #7 from QA Administrators --- Dear Volga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139086] 7.2.0.0 Microsoft Windows version of LO Draw crashes upon opening a file whose background is set to a bitmap
https://bugs.documentfoundation.org/show_bug.cgi?id=139086 --- Comment #20 from mwtjunkm...@gmail.com --- (In reply to Luboš Luňák from comment #19) > (In reply to mwtjunkmail from comment #8) > > NOT using Vulkan creates its own set of problems, which are still listed in > > the bug tracker under my user name as New, like a 1-pixel line top and left > > on black backgrounds, slow scrolling and zooming, all sorts of things. I can > > see if life's different now, but with none of those bugs addressed, I doubt > > it. > > I am not aware of any such Skia problems, and do not see them listed in the > #129062 metabug. Can you add them there to the dependency list, or at least > list them here? Unless you meant 'not using Skia', which is different from > 'not using Vulkan'. > #117160 #135912 #134237 #139172 I've many more open bugs that the above that are still sitting there not picked up yet by anyone, but the above are the ones specific to the presence/lack of having the Skia option selected. I've a total of 15 new/unconfirmed bugs reported at the moment, all against Windows version of LO Draw, Impress, or Base. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore' - include/vcl vcl/source
include/vcl/BinaryDataContainer.hxx | 59 + include/vcl/gfxlink.hxx | 14 +++ vcl/source/gdi/gfxlink.cxx | 64 +++- 3 files changed, 93 insertions(+), 44 deletions(-) New commits: commit 9c06701a2d588321348ad28dcd427a6f14912334 Author: Tomaž Vajngerl AuthorDate: Mon Dec 21 21:47:39 2020 +0900 Commit: Tomaž Vajngerl CommitDate: Wed Dec 23 11:38:42 2020 +0900 vcl: add BinaryDataContainer and change GfxLink to use it Add a wrapper for shared_ptr called BinaryDataContainer, which is used to easily manage the binary data - mainly for a better reuse, control and to prevent duplication. Change-Id: I68140ec379dba4a5ab1b624a334129bba2401998 diff --git a/include/vcl/BinaryDataContainer.hxx b/include/vcl/BinaryDataContainer.hxx new file mode 100644 index ..7ec9926b245c --- /dev/null +++ b/include/vcl/BinaryDataContainer.hxx @@ -0,0 +1,59 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + */ + +#pragma once + +#include +#include +#include +#include + +class VCL_DLLPUBLIC BinaryDataContainer final +{ +private: +// the binary data +std::shared_ptr> mpData; + +public: +explicit BinaryDataContainer() {} + +explicit BinaryDataContainer(size_t nSize) +: mpData(std::make_shared>(nSize)) +{ +} + +explicit BinaryDataContainer(const sal_uInt8* pData, size_t nSize) +: mpData(std::make_shared>(nSize)) +{ +std::copy(pData, pData + nSize, mpData->data()); +} + +explicit BinaryDataContainer(const BinaryDataContainer& rBinaryDataContainer) = default; +explicit BinaryDataContainer(BinaryDataContainer&& rBinaryDataContainer) = default; +BinaryDataContainer& operator=(const BinaryDataContainer& rBinaryDataContainer) = default; +BinaryDataContainer& operator=(BinaryDataContainer&& rBinaryDataContainer) = default; + +size_t getSize() const { return mpData ? mpData->size() : 0; } + +bool isEmpty() const { return mpData ? mpData->empty() : true; } + +const sal_uInt8* getData() const { return mpData ? mpData->data() : nullptr; } + +size_t calculateHash() const +{ +size_t nSeed = 0; +boost::hash_combine(nSeed, getSize()); +for (sal_uInt8 const& rByte : *mpData) +boost::hash_combine(nSeed, rByte); +return nSeed; +} +}; + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/include/vcl/gfxlink.hxx b/include/vcl/gfxlink.hxx index 72352f6902a1..85bb85cb53f2 100644 --- a/include/vcl/gfxlink.hxx +++ b/include/vcl/gfxlink.hxx @@ -23,6 +23,7 @@ #include #include #include +#include #include class SvStream; @@ -61,20 +62,17 @@ class VCL_DLLPUBLIC GfxLink private: GfxLinkType meType; sal_uInt32 mnUserId; -mutable std::shared_ptr mpSwapInData; +BinaryDataContainer maDataContainer; mutable size_t maHash; -sal_uInt32 mnSwapInDataSize; MapMode maPrefMapMode; SizemaPrefSize; boolmbPrefMapModeValid; boolmbPrefSizeValid; -SAL_DLLPRIVATE std::shared_ptr GetSwapInData() const; public: -GfxLink(); - -// pBuff = The Graphic data. This class takes ownership of this -GfxLink( std::unique_ptr pBuf, sal_uInt32 nBufSize, GfxLinkType nType ); +GfxLink(); +explicit GfxLink(std::unique_ptr pBuf, sal_uInt32 nBufSize, GfxLinkType nType); +explicit GfxLink(BinaryDataContainer const & rDataConainer, GfxLinkType nType); booloperator==( const GfxLink& ) const; @@ -85,7 +83,7 @@ public: voidSetUserId( sal_uInt32 nUserId ) { mnUserId = nUserId; } sal_uInt32 GetUserId() const { return mnUserId; } -sal_uInt32 GetDataSize() const { return mnSwapInDataSize;} +sal_uInt32 GetDataSize() const { return maDataContainer.getSize(); } const sal_uInt8*GetData() const; const Size& GetPrefSize() const { return maPrefSize;} diff --git a/vcl/source/gdi/gfxlink.cxx b/vcl/source/gdi/gfxlink.cxx index 83936c277ead..82b37fe4e668 100644 --- a/vcl/source/gdi/gfxlink.cxx +++ b/vcl/source/gdi/gfxlink.cxx @@ -30,60 +30,61 @@ GfxLink::GfxLink() : meType(GfxLinkType::NONE) , mnUserId(0) , maHash(0) -, mnSwapInDataSize(0) , mbPrefMapModeValid(false) , mbPrefSizeValid(false) { } - - GfxLink::GfxLink(std::unique_ptr pBuf, sal_uInt32 nSize, GfxLinkType nType) : meType(nType) , mnUserId(0) -,
[Libreoffice-commits] core.git: configure.ac Repository.mk RepositoryModule_build.mk solenv/gbuild svx/Executable_gengal.mk svx/Module_svx.mk
Repository.mk |2 RepositoryModule_build.mk | 62 ++--- configure.ac |4 - solenv/gbuild/extensions/pre_BuildTools.mk |2 svx/Executable_gengal.mk |4 + svx/Module_svx.mk |6 ++ 6 files changed, 45 insertions(+), 35 deletions(-) New commits: commit 5de0f4e7b52e5d1c12ac658d4aedc91b9ac342cd Author: Jan-Marek Glogowski AuthorDate: Mon Dec 21 16:28:29 2020 +0100 Commit: Jan-Marek Glogowski CommitDate: Wed Dec 23 01:52:11 2020 +0100 Don't lock galleries build into DESKTOP And add the missing dependency of Executable_gengal on Package_svx_gengal, so the actual executable script is created in instdir_for_build for the cross-toolset. Change-Id: I98ea1d58273c871f0a3b804a93970eedfb7f8908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108108 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski diff --git a/Repository.mk b/Repository.mk index 5311a5d1b84b..8407fcb7bf05 100644 --- a/Repository.mk +++ b/Repository.mk @@ -904,7 +904,7 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\ sfx2_emojiconfig \ $(call gb_Helper_optional,DESKTOP,\ $(if $(filter-out WNT,$(OS)),$(if $(ENABLE_MACOSX_SANDBOX),,shell_senddoc))) \ - $(call gb_Helper_optional,DESKTOP,$(if $(filter-out MACOSX WNT,$(OS)),svx_gengal)) \ + $(call gb_Helper_optional,DESKTOP,$(if $(filter-out EMSCRIPTEN MACOSX WNT,$(OS)),svx_gengal)) \ $(if $(USING_X11),vcl_fontunxppds) \ $(if $(filter $(OS),MACOSX),vcl_osxres) \ xmloff_dtd \ diff --git a/RepositoryModule_build.mk b/RepositoryModule_build.mk index 09bad286cffe..3ea89f432c41 100644 --- a/RepositoryModule_build.mk +++ b/RepositoryModule_build.mk @@ -56,38 +56,38 @@ $(eval $(call gb_Module_add_moduledirs,cross_toolset,\ unotools \ ure \ xmlreader \ + $(if $(WITH_GALLERY_BUILD), \ + avmedia \ + basic \ + canvas \ + configmgr \ + connectivity \ + cppcanvas \ + drawinglayer \ + editeng \ + emfio \ + filter \ + framework \ + linguistic \ + officecfg \ + package \ + postprocess \ + sfx2 \ + shell \ + sot \ + svgio \ + svl \ + svtools \ + svx \ + toolkit \ + ucb \ + unoxml \ + uui \ + vcl \ + xmloff \ + xmlscript \ + ) \ $(call gb_Helper_optional_for_host,DESKTOP, \ - $(if $(WITH_GALLERY_BUILD), \ - avmedia \ - basic \ - canvas \ - configmgr \ - connectivity \ - cppcanvas \ - drawinglayer \ - editeng \ - emfio \ - filter \ - framework \ - linguistic \ - officecfg \ - package \ - postprocess \ - sfx2 \ - shell \ - sot \ - svgio \ - svl \ - svtools \ - svx \ - toolkit \ - ucb \ - unoxml \ - uui \ - vcl \ - xmloff \ - xmlscript \ - ) \ helpcompiler \ xmlhelp \ ) \ diff --git a/configure.ac b/configure.ac index a256feeac194..bffdbd69cae6 100644 --- a/configure.ac +++ b/configure.ac @@ -2905,10 +2905,10 @@ AC_SUBST(SYSBASE) dnl === dnl Sort out various gallery compilation options dnl === +WITH_GALLERY_BUILD=TRUE AC_MSG_CHECKING([how to build and package galleries]) if test -n "${with_galleries}"; then if test "$with_galleries" = "build"; then -WITH_GALLERY_BUILD=TRUE AC_MSG_RESULT([build from source images internally]) elif test "$with_galleries" = "no"; then WITH_GALLERY_BUILD= @@ -2918,7 +2918,6 @@ if test -n "${with_galleries}"; then fi else if test $_os != iOS -a $_os != Android; then -WITH_GALLERY_BUILD=TRUE AC_MSG_RESULT([internal src images for desktop]) else WITH_GALLERY_BUILD= @@ -5188,6 +5187,7 @@ if test "$cross_compiling" = "yes"; then fi test -n
[Libreoffice-bugs] [Bug 139173] New: Incorrect bounds on formula DEC2HEX
https://bugs.documentfoundation.org/show_bug.cgi?id=139173 Bug ID: 139173 Summary: Incorrect bounds on formula DEC2HEX Product: LibreOffice Version: 6.4.7.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: cameron.pinne...@gmail.com Description: In MS Excel the formulae DEC2BIN, DEC2OCT, and DEC2HEX have valid inputs as integers m in the range -2^n <= m < 2^n, where n is given by DEC2BIN: n=9 DEC2OCT: n=29 DEC2HEX: n=39 LibreOffice Calc gets this right for DEC2BIN and DEC2OCT, but not DEC2HEX. There, the valid range is erroneously: -2^39 - 1 <= m < 2^39 + 1. In other words, in Excel we have: =DEC2HEX(2^39) == #NUM! =DEC2HEX(-2^39 - 1) == #NUM! But in LOCalc: =DEC2HEX(2^39) == "80" =DEC2HEX(-2^39 - 1) == "7F" This is surprising and does not seem like intended behaviour. I have not yet investigated whether the other base conversion functions have inconsistent bounds as well. Steps to Reproduce: In a cell do =DEC2HEX(2^39) or DEC2HEX(-2^39 - 1) Actual Results: Answers are "80" and "7F" respectively. Expected Results: Answers should be #NUM! in both cases, in accordance with Excel. Reproducible: Always User Profile Reset: No Additional Info: OS: Manjaro Linux LibreOffice Calc version: 6.4.7.2 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122902] Impress hangs for a while when opening or saving a document. FILEOPEN FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=122902 Clay Spence changed: What|Removed |Added Resolution|INSUFFICIENTDATA|FIXED --- Comment #23 from Clay Spence --- I just tested with 7.0.4. (https://download.documentfoundation.org/libreoffice/stable/7.0.4/deb/x86_64/LibreOffice_7.0.4_Linux_x86-64_deb.tar.gz) The problem with Impress hanging for a while when opening a document with a background color gradient didn't happen when I tried it with this version. It does still happen with 7.0.3.1 (the current version in my computer running Ubuntu). Thanks, and I apologize for taking so long to get back to this. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139169] Shapes inside floating frame lost on DOC export
https://bugs.documentfoundation.org/show_bug.cgi?id=139169 --- Comment #2 from sdc.bla...@youmail.dk --- Why is this not a duplicate of bug 40540 ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135508] Relative linked text sections should automatically read on document opening
https://bugs.documentfoundation.org/show_bug.cgi?id=135508 --- Comment #2 from Sascha Z --- (In reply to Dieter from comment #1) > Sascha, I think this is more an enhancement request than a bug, because > everything works as it should (but of course, improvement is alwys > possible). So let's ask design team. > > cc: Design-Team for further input and decision Thanks for your replay Dieter. I am from design team myself and open to discuss it in one of our meetings. ATM LibO ALWAYS ask the user to update relative linked documents even if the document itself wasn't changed (open right after last save) and linked documents haven't moved or changed. So LibO always ask without any reason. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 135508] Relative linked text sections should automatically read on document opening
https://bugs.documentfoundation.org/show_bug.cgi?id=135508 --- Comment #2 from Sascha Z --- (In reply to Dieter from comment #1) > Sascha, I think this is more an enhancement request than a bug, because > everything works as it should (but of course, improvement is alwys > possible). So let's ask design team. > > cc: Design-Team for further input and decision Thanks for your replay Dieter. I am from design team myself and open to discuss it in one of our meetings. ATM LibO ALWAYS ask the user to update relative linked documents even if the document itself wasn't changed (open right after last save) and linked documents haven't moved or changed. So LibO always ask without any reason. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139042] Freeze Rows And Columns Only freezing a row OR a column
https://bugs.documentfoundation.org/show_bug.cgi?id=139042 raal changed: What|Removed |Added Resolution|--- |NOTABUG CC||r...@post.cz Status|UNCONFIRMED |RESOLVED --- Comment #3 from raal --- Hello, you can select cell B2 and click on the "Freeze rows and columns" button on the toolbar. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 139050, which changed state. Bug 139050 Summary: LO crash when I type too soon after pressing Ctrl-K https://bugs.documentfoundation.org/show_bug.cgi?id=139050 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 112125] [META] Hyperlink dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112125 Bug 112125 depends on bug 139050, which changed state. Bug 139050 Summary: LO crash when I type too soon after pressing Ctrl-K https://bugs.documentfoundation.org/show_bug.cgi?id=139050 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139050] LO crash when I type too soon after pressing Ctrl-K
https://bugs.documentfoundation.org/show_bug.cgi?id=139050 raal changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED CC||r...@post.cz --- Comment #4 from raal --- (In reply to L Duperval from comment #3) > I tested with 7.1.0 beta 1 and I cannot reproduce. Thanks for testing, closing the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139059] The Validity list arrow don't apear when we have columns fixed and the next column is not visible. Thanks.
https://bugs.documentfoundation.org/show_bug.cgi?id=139059 raal changed: What|Removed |Added Ever confirmed|0 |1 CC||r...@post.cz Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138995] FILEOPEN DOCX: A shape in front of textbox is position behind textbox (fine with DOC)
https://bugs.documentfoundation.org/show_bug.cgi?id=138995 raal changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||r...@post.cz, ||vmik...@collabora.com --- Comment #5 from raal --- This seems to have begun at the below commit. Adding Cc: to Miklos Vajna ; Could you possibly take a look at this one? Thanks bisected with bibisect-44max> 64c8b13f248fe7ea3808c7f8e62d0d656f170378 is the first bad commit commit 64c8b13f248fe7ea3808c7f8e62d0d656f170378 Author: Matthew Francis Date: Sat Mar 14 21:42:08 2015 +0800 source-hash-d379d18666aa42031359ca8eb34b0021960347ae commit d379d18666aa42031359ca8eb34b0021960347ae Author: Miklos Vajna AuthorDate: Wed Jun 18 11:57:31 2014 +0200 Commit: Miklos Vajna CommitDate: Wed Jun 18 12:09:15 2014 +0200 oox: import WPS shape with text as shape with textbox This allows having real shapes (like having rounded corners) and complex content (like containing a table) at the same time. WPS shapes are wrappers around drawingML markup in DOCX files, so this only affects the DOCX import. Change-Id: Iad1c1c61233be1c17efa1821e680927aa9587215 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/sidebar/UnoDeck.cxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 7206de4f3d9eecdcbdd98294fa50f01c4c9ece9c Author: Ilhan Yesil AuthorDate: Thu Nov 12 15:33:24 2020 +0100 Commit: Thorsten Behrens CommitDate: Wed Dec 23 00:19:13 2020 +0100 tdf#138160 Set minimal width of sidebar tabpage after UNO call Call OpenThenToggleDeck in SidebarController instead SwitchToDeck to ensure the minimal width of the tabpage is considered and the width of the sidebar is set correctly. Change-Id: I27c21572b5c648b3ddbb4d908d40af686ac87a9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105758 Tested-by: Jenkins Reviewed-by: Heiko Tietze Reviewed-by: Thorsten Behrens diff --git a/sfx2/source/sidebar/UnoDeck.cxx b/sfx2/source/sidebar/UnoDeck.cxx index 122afbe018a2..0350ef1250c3 100644 --- a/sfx2/source/sidebar/UnoDeck.cxx +++ b/sfx2/source/sidebar/UnoDeck.cxx @@ -95,13 +95,16 @@ void SAL_CALL SfxUnoDeck::activate( const sal_Bool bActivate ) SidebarController* pSidebarController = getSidebarController(); +// tdf#138160: OpenThenToggleDeck takes care of minimal width if (bActivate) -pSidebarController->SwitchToDeck(mDeckId); +pSidebarController->OpenThenToggleDeck(mDeckId); else +{ pSidebarController->SwitchToDefaultDeck(); +// update the sidebar +pSidebarController->NotifyResize(); +} -// update the sidebar -pSidebarController->NotifyResize(); } uno::Reference SAL_CALL SfxUnoDeck::getPanels() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 139059] The Validity list arrow don't apear when we have columns fixed and the next column is not visible. Thanks.
https://bugs.documentfoundation.org/show_bug.cgi?id=139059 Peter S Anderson changed: What|Removed |Added CC||pe...@pza.net.au --- Comment #1 from Peter S Anderson --- Hi Luis, I have attempted to reproduce your bug in 6.2.4.7 and our DEV version without any luck. Would you please us an example spreadsheet. Thanks Peter. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138939] Shape gets deselected opening the animation sidebar's pane
https://bugs.documentfoundation.org/show_bug.cgi?id=138939 --- Comment #2 from Xisco Faulí --- Still reproducible in Version: 7.2.0.0.alpha0+ Build ID: 6156a419a2d3f09d91afd00f84c84ba717442f43 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Caolán, if you have a comment, could you please take a look at this issue ? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139137] Mac OSX Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 --- Comment #8 from rtpb...@gmail.com --- I don't expect anything, I realize the product is free, I was just highlighting a problem apologies for not knowing by heart all of the problem backlog in LO next time, I will keep my mouth shut, I got the point. thanks for the help -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114184] Replace non-single-quote apostrophes with Geresh when appropriate
https://bugs.documentfoundation.org/show_bug.cgi?id=114184 --- Comment #6 from Eyal Rozenberg --- Still a perfectly relevant bug with version 7.0.3.1 . -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134526] Update Firebird to latest upstream version
https://bugs.documentfoundation.org/show_bug.cgi?id=134526 --- Comment #14 from Julien Nabet --- (In reply to Popa Adrian Marius from comment #12) > patch can be created for 7.1 with firebird 3.0.7 , seems that builds and > works ok on master > > tested on my linux box Yes but no need to push this on 7.1 since Firebird has been put experimental and there are enough Firebird bugs which need to be fixed to ask people to test this part. > > ods 12.0 should be oppened ok by firebird 3.0.7 (minor ods changes), maybe > you have old version of firebird > > https://firebirdsql.org/file/documentation/release_notes/html/en/3_0/ > rlsnotes30.html#rnfb30-apiods-ods-12-2 I don't know at all this part so can't tell. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Fwd: ESC meeting agenda: 2020-12-17 16:00 Berlin time
I seem to have replied to the wrong list... Sent from my iPhone Begin forwarded message: > From: Chris Sherlock > Date: 23 December 2020 at 8:38:27 am AEDT > To: Miklos Vajna > Cc: libreoffice@lists.freedesktop.org, libreoffice...@lists.freedesktop.org > Subject: Re: ESC meeting agenda: 2020-12-17 16:00 Berlin time > > >> * Graphics architecture (Thorsten) >> * https://pad.documentfoundation.org/p/ESC_graphics_architecture >> * skia / vulkan metabug: >> https://bugs.documentfoundation.org/show_bug.cgi?id=129062 >> + 13 (+1) open bugs, 141 total (+1) >> >> * QA update (Xisco) >> + Please help flesh out the monthly reports: >> https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief > > I hope I am not speaking out of turn, but one thing that might help in > untangling VCL would be to ensure that the actual drawing work be done in > SalGraphics, and not in OutputDevice. > > I recently logged a bug here: > > https://bugs.documentfoundation.org/show_bug.cgi?id=139170 > > The example given is that code that actually determines a polyline needs to > be “emulated”. What this means is that the polyline and polygon rendering is > ing done in OutputDevice and not in the various SalGraphics backends. In > particular, the genpsp and X11 backends are the backends that don’t seem to > handle things fully. > > OutputDevice also seems to handle things that other classes should be > handling - for example it seems to do more handling of bitmaps where I would > have thought that the Bitmap class could handle the functionality. > > Just a general comment. I have recently taken a stab at shifting some > functionality out of OutputDevice and into Bitmap, but there is a lot I can > see we could cull from OutputDevice. > > Chris ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 139137] Mac OSX Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 Julien Nabet changed: What|Removed |Added Keywords||wantBacktrace --- Comment #7 from Julien Nabet --- Just for information, there are thousands of bugs in LO and most of devs use Linux. So indeed, if there's a Mac Accessibility bug, yes it should be fixed but don't expect it soon (some bugs are years old). Now hope the stacktrace will provide some hints. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139157] Crash in: mergedlo.dll Right-click in text string in textbox in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=139157 Julien Nabet changed: What|Removed |Added Ever confirmed|0 |1 Keywords||haveBacktrace Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139157] Crash in: mergedlo.dll Right-click in text string in textbox in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=139157 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet --- Created attachment 168440 --> https://bugs.documentfoundation.org/attachment.cgi?id=168440=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this by using last comment. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/elementary icon-themes/elementary_svg
dev/null|binary icon-themes/elementary/cmd/32/addprintarea.png |binary icon-themes/elementary/cmd/32/alignbottom.png |binary icon-themes/elementary/cmd/32/aligntop.png |binary icon-themes/elementary/cmd/32/alignverticalcenter.png |binary icon-themes/elementary/cmd/32/assignmacro.png |binary icon-themes/elementary/cmd/32/choosemacro.png |binary icon-themes/elementary/cmd/32/datadatapilotrun.png |binary icon-themes/elementary/cmd/32/dbviewforms.png |binary icon-themes/elementary/cmd/32/dbviewreports.png |binary icon-themes/elementary/cmd/32/defineprintarea.png |binary icon-themes/elementary/cmd/32/deletepivottable.png |binary icon-themes/elementary/cmd/32/deleteprintarea.png |binary icon-themes/elementary/cmd/32/extrusion3dcolor.png |binary icon-themes/elementary/cmd/32/graphicfilterrelief.png |binary icon-themes/elementary/cmd/32/insertdraw.png|binary icon-themes/elementary/cmd/32/moduledialog.png |binary icon-themes/elementary/cmd/32/pasteonlyformula.png |binary icon-themes/elementary/cmd/32/pasteonlytext.png |binary icon-themes/elementary/cmd/32/pasteonlyvalue.png|binary icon-themes/elementary/cmd/32/pasteunformatted.png |binary icon-themes/elementary/cmd/32/runbasic.png |binary icon-themes/elementary/cmd/32/runmacro.png |binary icon-themes/elementary/cmd/32/selectbackground.png |binary icon-themes/elementary/cmd/32/sendfax.png |binary icon-themes/elementary/cmd/lc_addprintarea.png |binary icon-themes/elementary/cmd/lc_alignbottom.png |binary icon-themes/elementary/cmd/lc_aligntop.png |binary icon-themes/elementary/cmd/lc_alignverticalcenter.png |binary icon-themes/elementary/cmd/lc_assignmacro.png |binary icon-themes/elementary/cmd/lc_choosemacro.png |binary icon-themes/elementary/cmd/lc_compilebasic.png |binary icon-themes/elementary/cmd/lc_datadatapilotrun.png |binary icon-themes/elementary/cmd/lc_dbviewtables.png |binary icon-themes/elementary/cmd/lc_defineprintarea.png |binary icon-themes/elementary/cmd/lc_deletepivottable.png |binary icon-themes/elementary/cmd/lc_deleteprintarea.png |binary icon-themes/elementary/cmd/lc_extrusion3dcolor.png |binary icon-themes/elementary/cmd/lc_graphicfilterrelief.png |binary icon-themes/elementary/cmd/lc_insertdraw.png|binary icon-themes/elementary/cmd/lc_moduledialog.png |binary icon-themes/elementary/cmd/lc_openremote.png|binary icon-themes/elementary/cmd/lc_pasteonlyformula.png |binary icon-themes/elementary/cmd/lc_pasteonlytext.png |binary icon-themes/elementary/cmd/lc_pasteonlyvalue.png|binary icon-themes/elementary/cmd/lc_pasteunformatted.png |binary icon-themes/elementary/cmd/lc_runbasic.png |binary icon-themes/elementary/cmd/lc_runmacro.png |binary icon-themes/elementary/cmd/lc_sendfax.png |binary icon-themes/elementary/cmd/lc_showsinglepage.png|binary icon-themes/elementary/cmd/lc_trackchanges.png |binary icon-themes/elementary/cmd/sc_addprintarea.png |binary icon-themes/elementary/cmd/sc_alignbottom.png |binary icon-themes/elementary/cmd/sc_aligntop.png |binary icon-themes/elementary/cmd/sc_alignverticalcenter.png |binary icon-themes/elementary/cmd/sc_assignmacro.png |binary icon-themes/elementary/cmd/sc_choosemacro.png |binary icon-themes/elementary/cmd/sc_datadatapilotrun.png |binary icon-themes/elementary/cmd/sc_defineprintarea.png |binary icon-themes/elementary/cmd/sc_deletepivottable.png |binary icon-themes/elementary/cmd/sc_deleteprintarea.png |binary icon-themes/elementary/cmd/sc_extrusion3dcolor.png |binary icon-themes/elementary/cmd/sc_footnotedialog.png|binary icon-themes/elementary/cmd/sc_graphicfilterrelief.png |binary icon-themes/elementary/cmd/sc_insertdraw.png
[Libreoffice-bugs] [Bug 139164] Edited page of labels must be closed and saved before edits will be printed
https://bugs.documentfoundation.org/show_bug.cgi?id=139164 BogdanB changed: What|Removed |Added Keywords||needsUXEval --- Comment #5 from BogdanB --- We need an opinion form UX Team with this question: On the image in comment 2 you can see there is a "Print selection only" - the conclusion is that this will print what I select. But also, on the last raw we have again "Selection". What are the differences between this 2 Selections? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139103] Rotated image crossing page borders is moved down on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=139103 Gabor Kelemen changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||kelem...@ubuntu.com --- Comment #2 from Gabor Kelemen --- *** This bug has been marked as a duplicate of bug 123569 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123569] FILESAVE DOCX: Rotated image is saved with wrong size/position
https://bugs.documentfoundation.org/show_bug.cgi?id=123569 Gabor Kelemen changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #7 from Gabor Kelemen --- *** Bug 139103 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139103] Rotated image crossing page borders is moved down on DOCX export
https://bugs.documentfoundation.org/show_bug.cgi?id=139103 --- Comment #1 from Gabor Kelemen --- Created attachment 168439 --> https://bugs.documentfoundation.org/attachment.cgi?id=168439=edit The example file and its docx version in current master Confirming in: Version: 7.2.0.0.alpha0+ Build ID: e57665ea6f812aff9fc87073ce947f40a8b26e9d CPU threads: 8; OS: Linux 5.0; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded This is a rotated and resized image saved to docx. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139164] Edited page of labels must be closed and saved before edits will be printed
https://bugs.documentfoundation.org/show_bug.cgi?id=139164 --- Comment #4 from Michael Hendry --- OK, that deals with the immediate problem (of getting the whole page printed), which I now know could be avoided by removing the selection on the pasted-in graphic at the top. I'm left wondering why the "LibreOffice Writer" panel has "Print Selection Only" disabled at the top and then under "Pages" has the "Selection" radio-button active. Is this the intended behaviour? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139172] Transparent objects placed on bitmaps appear solid when exported as PNG using "Selection" option
https://bugs.documentfoundation.org/show_bug.cgi?id=139172 --- Comment #3 from mwtjunkm...@gmail.com --- Also note that an imported transparent object renders fine, as no work is done on it upon export. It's only objects in LO Draw with a transparency property set other than the default (no transparency) encountering an issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] translations.git: Changes to 'distro/nisz/libreoffice-7-0'
New branch 'distro/nisz/libreoffice-7-0' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: ESC meeting agenda: 2020-12-17 16:00 Berlin time
> * Graphics architecture (Thorsten) > * https://pad.documentfoundation.org/p/ESC_graphics_architecture > * skia / vulkan metabug: > https://bugs.documentfoundation.org/show_bug.cgi?id=129062 > + 13 (+1) open bugs, 141 total (+1) > > * QA update (Xisco) > + Please help flesh out the monthly reports: > https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief I hope I am not speaking out of turn, but one thing that might help in untangling VCL would be to ensure that the actual drawing work be done in SalGraphics, and not in OutputDevice. I recently logged a bug here: https://bugs.documentfoundation.org/show_bug.cgi?id=139170 The example given is that code that actually determines a polyline needs to be “emulated”. What this means is that the polyline and polygon rendering is ing done in OutputDevice and not in the various SalGraphics backends. In particular, the genpsp and X11 backends are the backends that don’t seem to handle things fully. OutputDevice also seems to handle things that other classes should be handling - for example it seems to do more handling of bitmaps where I would have thought that the Bitmap class could handle the functionality. Just a general comment. I have recently taken a stab at shifting some functionality out of OutputDevice and into Bitmap, but there is a lot I can see we could cull from OutputDevice. Chris___ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] dictionaries.git: Changes to 'distro/nisz/libreoffice-7-0'
New branch 'distro/nisz/libreoffice-7-0' available with the following commits: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits