[Libreoffice-bugs] [Bug 113213] "Resume numbering" does not cancel "restart numbering" on enumerated list
https://bugs.documentfoundation.org/show_bug.cgi?id=113213 Dieter changed: What|Removed |Added Blocks||103369 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103369 [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sw/source
sw/source/uibase/uno/unotxdoc.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 70f778657d90fa974281233628e1006740d4d698
Author: Aron Budea
AuthorDate: Mon Feb 15 21:46:45 2021 +0100
Commit: Aron Budea
CommitDate: Sun Feb 21 22:33:34 2021 +0100
Avoid crash in online on a document with comments
Crashed on a specific doc with the following backtrace:
Thread 1 "kitbroker_001" received signal SIGSEGV, Segmentation fault.
0x7f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField
(this=0x0)
at /.../libreoffice/sw/inc/AnnotationWin.hxx:71
71 const SwPostItField* GetPostItField() const { return
mpField; }
0 0x7f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField()
const (this=0x0)
at /.../libreoffice/sw/inc/AnnotationWin.hxx:71
1 0x7f4807f0641b in SwXTextDocument::getPostIts(tools::JsonWriter&)
(this=0x557e1d985a10, rJsonWriter=...)
at /.../libreoffice/sw/source/uibase/uno/unotxdoc.cxx:3337
2 0x7f4823216534 in getPostIts(LibreOfficeKitDocument*)
(pThis=0x557e1d93c890)
at /.../libreoffice/desktop/source/lib/init.cxx:3425
...
Change-Id: Ib97fd33fda936cad0c9ed3a29564fc0a49ff20c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110917
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
(cherry picked from commit 934ed8d888abe231c014ce179e5256933b0562ed)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/79
Reviewed-by: Aron Budea
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index 3ab7e4a8c8d8..1a746f65f7d1 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -3368,6 +3368,11 @@ OUString SwXTextDocument::getPostIts()
{
sw::annotation::SwAnnotationWin* pWin = sidebarItem->pPostIt.get();
+if (!pWin)
+{
+continue;
+}
+
const SwPostItField* pField = pWin->GetPostItField();
const SwRect& aRect = pWin->GetAnchorRect();
tools::Rectangle aSVRect(aRect.Pos().getX(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140585] Libre Office Freeze when I try start it.
https://bugs.documentfoundation.org/show_bug.cgi?id=140585 --- Comment #1 from Marcos --- Created attachment 169949 --> https://bugs.documentfoundation.org/attachment.cgi?id=169949=edit Frozen screen, Libre Office does not start. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140585] New: Libre Office Freeze when I try start it.
https://bugs.documentfoundation.org/show_bug.cgi?id=140585 Bug ID: 140585 Summary: Libre Office Freeze when I try start it. Product: LibreOffice Version: 7.0.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mlab...@gmail.com Description: When I click in Libre Office icon, a new windows white window open. In the window title bar is displayed: Libre Office Not Responding (in portuguese: Libre Office Não Está Respondendo). I live in Brazil and installed Libre office em portuguese. Hardware: HP Pro 3410 SFF CPU, Intel Core i3 processor, 64, 8 Gb of RAM. Formatted HD, rsisntalado Windows 7 Professional Original, upgraded to Windows 10 Pro (windows Center Media creation). Updated drivers, Java 8 version 281 installed, Norton 360 Antivirus installed Steps to Reproduce: 1.Every time 2.Ctrl+Alt+Del 3.Ende the task (Libre Office) Actual Results: In the Safe Mode, I can open the aplications (Calc, Write) Expected Results: I would like to get help using Libre Office in normal mode. Reproducible: Always User Profile Reset: Yes Additional Info: I would like to get help using Libre Office in normal mode. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134940] --> does not replace automatically to → in AutoCorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=134940 raal changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||nem...@numbertext.org, ||r...@post.cz --- Comment #19 from raal --- This seems to have begun at the below commit. Adding Cc: to László Németh ; Could you possibly take a look at this one? Thanks linux-64-7.1$ 9eef37502e2a0de4eda3958eb11ca35a80c7211c is the first bad commit commit 9eef37502e2a0de4eda3958eb11ca35a80c7211c Author: Jenkins Build User Date: Tue Jun 2 04:00:58 2020 +0200 source sha:57f07b1d7378d218648667c5b1315cc8ad905875 commit 57f07b1d7378d218648667c5b1315cc8ad905875[log] author László NémethThu May 28 08:50:39 2020 +0200 committer László NémethSun May 31 23:13:23 2020 +0200 tree5637c6bb18c61d960c1d1771a1f7d887649d8ba2 parent c87c7ddca46ae093a703ca673a204e4593402c38 [diff] tdf#133524 AutoCorrect: support double angle quotes -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113213] "Resume numbering" does not cancel "restart numbering" on enumerated list
https://bugs.documentfoundation.org/show_bug.cgi?id=113213 Timur changed: What|Removed |Added CC||tor...@yahoo.com --- Comment #8 from Timur --- *** Bug 139912 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 Bug 103369 depends on bug 139912, which changed state. Bug 139912 Summary: ContinuePreviousNumbering fails https://bugs.documentfoundation.org/show_bug.cgi?id=139912 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139912] ContinuePreviousNumbering fails
https://bugs.documentfoundation.org/show_bug.cgi?id=139912 Timur changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Timur --- *** This bug has been marked as a duplicate of bug 113213 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139843] Crash swlo!SwNumRule::MakeNumString
https://bugs.documentfoundation.org/show_bug.cgi?id=139843 raal changed: What|Removed |Added CC||michael.st...@allotropia.de ||, r...@post.cz Keywords|bibisectRequest |bibisected, bisected --- Comment #7 from raal --- This seems to have begun at the below commit. Adding Cc: to Michael Stahl ; Could you possibly take a look at this one? Thanks bibisect-linux-64-6.3$ 63dec39f2e1dab30a4c3ea8bdcea290600cf6983 is the first bad commit commit 63dec39f2e1dab30a4c3ea8bdcea290600cf6983 Author: Jenkins Build User Date: Tue Dec 18 22:07:56 2018 +0100 source sha:32902f66e7749b2d06d13f50416be5323a0c0ea9 commit 32902f66e7749b2d06d13f50416be5323a0c0ea9[log] author Michael Stahl Fri Nov 30 17:54:41 2018 +0100 committer Michael Stahl Tue Dec 18 17:55:30 2018 +0100 tree901ab6577d25102c0a855d2a63964dfef67b34c4 parent b310378e874bc8fa7005352fcd85fa64eb075f54 [diff] sw_redlinehide: make layout based Show/Hide mode the default -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113213] "Resume numbering" does not cancel "restart numbering" on enumerated list
https://bugs.documentfoundation.org/show_bug.cgi?id=113213 Timur changed: What|Removed |Added Version|5.3.6.1 release |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140583] x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=140583 --- Comment #4 from Hans Meyer --- Desktop environment is Xfce, no Wayland installed (only X.Org) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140583] x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=140583 --- Comment #3 from Hans Meyer --- Created attachment 169948 --> https://bugs.documentfoundation.org/attachment.cgi?id=169948=edit Options pane "View" -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 Bug 103369 depends on bug 122027, which changed state. Bug 122027 Summary: Continue Previous Numbering Does Not Find Previous Number and Starts at 1. Again https://bugs.documentfoundation.org/show_bug.cgi?id=122027 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122027] Continue Previous Numbering Does Not Find Previous Number and Starts at 1. Again
https://bugs.documentfoundation.org/show_bug.cgi?id=122027 Timur changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Timur --- I revisited this bug and now I think it can be closed. attachment 147447 is messy document with unnamed numberings, not list styles. Somehow and who knows how, last number that's reported as a bug, has style P7. Single line (before "What is the maximum value for ") has it also, so it's continuing that numbering. Makes no sense, but also makes no sense to investigate how document was created. Seems like LO cannot nicely put all numberings without some plan or usage of list styles. I.e. do not just click Nubbering icon or paste from somewhere if you have more levels of numbering. Dieter's example is something different, should have searched for Continue after Restart, bug 113213. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67943] ACCESSIBILITY: Issues with tabbed dialogs on Mac OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=67943 --- Comment #15 from eisa01 --- Not really sure if this is present or not. Yes, the items in e.g., paragraph formatting are still buttons, but I'm able to move the focus between them with the Voiceover cursor Version: 7.1.0.3 / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111423] Page format not changing to "User" upon small change in page width
https://bugs.documentfoundation.org/show_bug.cgi?id=111423 eisa01 changed: What|Removed |Added Keywords||needsUXEval CC||eis...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #16 from eisa01 --- Let's get the opinion of the UX team given comment #15 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 111423] Page format not changing to "User" upon small change in page width
https://bugs.documentfoundation.org/show_bug.cgi?id=111423 eisa01 changed: What|Removed |Added Keywords||needsUXEval CC||eis...@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org --- Comment #16 from eisa01 --- Let's get the opinion of the UX team given comment #15 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - sfx2/source
sfx2/source/view/viewsh.cxx |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
New commits:
commit c17748472edb005a30a71cfafd24f705591113fd
Author: Andras Timar
AuthorDate: Sun Feb 21 20:59:52 2021 +0100
Commit: Andras Timar
CommitDate: Sun Feb 21 21:03:17 2021 +0100
[cp-6.2 only] Fix SfxViewShell::SetLOKLanguageTag, as in cp-6.4 and higher
Change-Id: I93dcd4d540350262c687164edb4e32ea43165102
diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index cae5f15fe4b7..144be3acfbca 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -1541,22 +1541,17 @@ vcl::Window*
SfxViewShell::GetEditWindowForActiveOLEObj() const
void SfxViewShell::SetLOKLanguageTag(const OUString& rBcp47LanguageTag)
{
-#ifdef IOS
-LanguageTag aTag = LanguageTag(rBcp47LanguageTag, true);
+LanguageTag aTag(rBcp47LanguageTag, true);
css::uno::Sequence
inst(officecfg::Setup::Office::InstalledLocales::get()->getElementNames());
LanguageTag aFallbackTag =
LanguageTag(getInstalledLocaleForSystemUILanguage(inst, /*
bRequestInstallIfMissing */ false, rBcp47LanguageTag), true).makeFallback();
// If we want de-CH, and the de localisation is available, we don't want
to use de-DE as then
// the magic in Translate::get() won't turn ess-zet into double s.
Possibly other similar cases?
-if (aTag.getLanguage() == aFallbackTag.getLanguage())
+if (comphelper::LibreOfficeKit::isActive() && aTag.getLanguage() ==
aFallbackTag.getLanguage())
maLOKLanguageTag = aTag;
else
maLOKLanguageTag = aFallbackTag;
-#else
-css::uno::Sequence
inst(officecfg::Setup::Office::InstalledLocales::get()->getElementNames());
-maLOKLanguageTag = LanguageTag(getInstalledLocaleForSystemUILanguage(inst,
/* bRequestInstallIfMissing */ false, rBcp47LanguageTag), true).makeFallback();
-#endif
}
void SfxViewShell::SetLOKLocale(const OUString& rBcp47LanguageTag)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140077] Fatal Error after insert a new line by Enter (std::bad_array_new_length)
https://bugs.documentfoundation.org/show_bug.cgi?id=140077 --- Comment #12 from Dave Gilbert --- I've just done two small hacks; https://gerrit.libreoffice.org/c/core/+/111291 OutputDevice::ImplLayout don't trust nLen https://gerrit.libreoffice.org/c/core/+/111292 CountCJKCharacters: Don't get caught at end of string which stops it actually crashing; however I don't think it's actually happy - for example, when you hit return it now splits that line OK; but then moving down from the upper line doesn't move, and I'm also seeing some redraw artifacts there of the old line. So I'm guessing it still needs to figure out where the odd lengths come from -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 111319] defining a picture as background makes extremely difficult to select a table, text or object and to change its properties
https://bugs.documentfoundation.org/show_bug.cgi?id=111319 --- Comment #7 from Cristiano Duarte --- Bug is partially present on last released LO: What works: 2. If you have a text written on the document, over the picture, it is not extremely difficult anymore to place the cursor over it, or even to select it with the left button. 3. It is not impossible to place the cursor on an empty paragraph (ex: for adding text), the focus is not placed at the background picture anymore. What partially works: 4. Right-clicking over paragraphs almost always brings the background picture context menu It still happens with empty paragraps, table/cell borders and objects (Ex: math formula). What still not work: b) Also, there is no way to make a cell's or table's background to render when there is a background image (watermark) configured at the page. Expected Results: a) When left-cliking anywhere in the document over a watermark, the background image (watermark) placed at the header/footer, should only get selected when the header/footer is active (editable). b) The background for tables or cells which are placed over the watermark (background image) should be rendered normally. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.3 (x64) / LibreOffice Community Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c CPU threads: 16; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win Locale: pt-BR (pt_BR); UI: pt-BR Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104597] Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 --- Comment #43 from shmuel.glo...@gmail.com --- I am just waiting for this issue to be resolved. It's top priority for many users. It really handicaps the use of LibreOffice in Israel and the whole Middle East. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #8 from Timur --- Fix seems worse than the original issue. I'm in favor of revert. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 Timur changed: What|Removed |Added CC||mart.c...@gmail.com --- Comment #7 from Timur --- *** Bug 140521 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source svx/source sw/source
dbaccess/source/ui/inc/JoinTableView.hxx |4 +-
dbaccess/source/ui/inc/QueryTableView.hxx |2 -
dbaccess/source/ui/querydesign/JoinTableView.cxx |8 ++---
dbaccess/source/ui/querydesign/QueryTableView.cxx |2 -
svx/source/dialog/framelinkarray.cxx |6 ++--
sw/source/filter/ww8/ww8scan.cxx | 32 +++---
sw/source/filter/ww8/ww8scan.hxx |8 ++---
7 files changed, 31 insertions(+), 31 deletions(-)
New commits:
commit 385808a2dff7300ec0120fdd5e8acfad8f86e50d
Author: Tor Lillqvist
AuthorDate: Sun Feb 21 12:46:27 2021 +0200
Commit: Tor Lillqvist
CommitDate: Sun Feb 21 20:25:48 2021 +0100
Typo fix: supress -> suppress
Change-Id: I72aeaff1bc8ac67253265ea99de91b9b9906e5d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111275
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist
diff --git a/dbaccess/source/ui/inc/JoinTableView.hxx
b/dbaccess/source/ui/inc/JoinTableView.hxx
index 5c7c6e91fcf1..ec2c6e420080 100644
--- a/dbaccess/source/ui/inc/JoinTableView.hxx
+++ b/dbaccess/source/ui/inc/JoinTableView.hxx
@@ -196,7 +196,7 @@ namespace dbaui
*/
sal_Int32 getConnectionCount(const OTableWindow* _pFromWin) const;
-OTableConnection* GetTabConn(const OTableWindow* pLhs,const
OTableWindow* pRhs,bool _bSupressCrossOrNaturalJoin = false) const;
+OTableConnection* GetTabConn(const OTableWindow* pLhs,const
OTableWindow* pRhs,bool _bSuppressCrossOrNaturalJoin = false) const;
/** clear the window map and connection vector without destroying it
@@ -299,7 +299,7 @@ namespace dbaui
Expected to throw. */
virtual void onNoColumns_throw();
-virtual bool supressCrossNaturalJoin(const
TTableConnectionData::value_type& _pData) const;
+virtual bool suppressCrossNaturalJoin(const
TTableConnectionData::value_type& _pData) const;
private:
void InitColors();
diff --git a/dbaccess/source/ui/inc/QueryTableView.hxx
b/dbaccess/source/ui/inc/QueryTableView.hxx
index c192c5fac664..26133d2cca42 100644
--- a/dbaccess/source/ui/inc/QueryTableView.hxx
+++ b/dbaccess/source/ui/inc/QueryTableView.hxx
@@ -40,7 +40,7 @@ namespace dbaui
Expected to throw. */
virtual voidonNoColumns_throw() override;
-virtual bool supressCrossNaturalJoin(const
TTableConnectionData::value_type& _pData) const override;
+virtual bool suppressCrossNaturalJoin(const
TTableConnectionData::value_type& _pData) const override;
public:
OQueryTableView(vcl::Window* pParent,OQueryDesignView* pView);
diff --git a/dbaccess/source/ui/querydesign/JoinTableView.cxx
b/dbaccess/source/ui/querydesign/JoinTableView.cxx
index 0190b36c7c77..84a4f1549e34 100644
--- a/dbaccess/source/ui/querydesign/JoinTableView.cxx
+++ b/dbaccess/source/ui/querydesign/JoinTableView.cxx
@@ -1179,7 +1179,7 @@ void OJoinTableView::Command(const CommandEvent& rEvt)
Window::Command(rEvt);
}
-OTableConnection* OJoinTableView::GetTabConn(const OTableWindow* pLhs,const
OTableWindow* pRhs,bool _bSupressCrossOrNaturalJoin) const
+OTableConnection* OJoinTableView::GetTabConn(const OTableWindow* pLhs,const
OTableWindow* pRhs,bool _bSuppressCrossOrNaturalJoin) const
{
OTableConnection* pConn = nullptr;
OSL_ENSURE(pRhs || pLhs, "OJoinTableView::GetTabConn : invalid args !");
@@ -1201,9 +1201,9 @@ OTableConnection* OJoinTableView::GetTabConn(const
OTableWindow* pLhs,const OTab
)
)
{
-if ( _bSupressCrossOrNaturalJoin )
+if ( _bSuppressCrossOrNaturalJoin )
{
-if ( supressCrossNaturalJoin(pData->GetData()) )
+if ( suppressCrossNaturalJoin(pData->GetData()) )
continue;
}
pConn = pData;
@@ -1560,7 +1560,7 @@ void OJoinTableView::onNoColumns_throw()
throw SQLException();
}
-bool OJoinTableView::supressCrossNaturalJoin(const
TTableConnectionData::value_type& ) const
+bool OJoinTableView::suppressCrossNaturalJoin(const
TTableConnectionData::value_type& ) const
{
return false;
}
diff --git a/dbaccess/source/ui/querydesign/QueryTableView.cxx
b/dbaccess/source/ui/querydesign/QueryTableView.cxx
index 77ca793e5077..9b252dbf8b1e 100644
--- a/dbaccess/source/ui/querydesign/QueryTableView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryTableView.cxx
@@ -880,7 +880,7 @@ void OQueryTableView::onNoColumns_throw()
::dbtools::throwSQLException( sError,
::dbtools::StandardSQLState::GENERAL_ERROR, nullptr );
}
-bool OQueryTableView::supressCrossNaturalJoin(const
TTableConnectionData::value_type& _pData) const
+bool OQueryTableView::suppressCrossNaturalJoin(const
TTableConnectionData::value_type& _pData) const
{
OQueryTableConnectionData* pQueryData =
static_cast(_pData.get());
[Libreoffice-bugs] [Bug 132688] Display of diacritics added to existing files is broken in lines with punctuation or footnotes/endnotes
https://bugs.documentfoundation.org/show_bug.cgi?id=132688 Yotam Benshalom changed: What|Removed |Added CC||bensha...@gmail.com --- Comment #25 from Yotam Benshalom --- Created attachment 169947 --> https://bugs.documentfoundation.org/attachment.cgi?id=169947=edit Adding diacritics places them to the left of their intended place This is not completely fixed. I attach a file which demonstrates the same bugged behaviour on LibreOffice 7.1. Please help - this makes my day job significantly harder :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140583] x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=140583 --- Comment #2 from Hans Meyer --- I'm using ArchLinux https://archlinux.org/packages/extra/x86_64/libreoffice-fresh/ == Info == Version: 7.1.0.3 / LibreOffice Community Build ID: 10(Build:3) CPU threads: 12; OS: Linux 5.11; UI render: Skia/Vulkan; VCL: x11 Locale: en-US (de_DE.UTF-8); UI: en-US 7.1.0-1 Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140077] Fatal Error after insert a new line by Enter (std::bad_array_new_length)
https://bugs.documentfoundation.org/show_bug.cgi?id=140077
--- Comment #11 from Dave Gilbert ---
My bad array for me is coming from:
#2 0x7fa24d923317 in OutputDevice::ImplLayout (this=0x841d980,
rOrigStr=..., nMinIndex=26, nLen=-3,
rLogicalPos=..., nLogicalWidth=, pDXArray=0x6df5ed0,
flags=SalLayoutFlags::NONE,
pLayoutCache=0x0, pGlyphs=0x0) at
/discs/fast/core/vcl/source/outdev/text.cxx:1289
1289xDXPixelArray.reset(new DeviceCoordinate[nLen]);
(gdb) list
1284if( pDXArray)
1285{
1286if(mbMap)
1287{
1288// convert from logical units to font units using a
temporary array
1289xDXPixelArray.reset(new DeviceCoordinate[nLen]);
'nLen' is -3 here. (hmm, difference between nEnd nPos previously?)
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 106556] Add functionality that highlights all directly formatted text
https://bugs.documentfoundation.org/show_bug.cgi?id=106556 --- Comment #20 from Timur --- Would be convenient if it worked in Style Inspector. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 106556] Add functionality that highlights all directly formatted text
https://bugs.documentfoundation.org/show_bug.cgi?id=106556 --- Comment #20 from Timur --- Would be convenient if it worked in Style Inspector. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35913] EDITING - vertical & horizontal flipping text / image / Object is inconsistent and wrong in Impress, Writer, Calc, Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=35913 --- Comment #25 from Wolfgang Jäger --- (In reply to Regina Henschel from comment #24) > The current behavior is the same as in MS Office and as it has been since > years. So I would not change it. > The current behaviour of the >Flipp Horizontally< (do nothing) and >Flipp Vertically< (mirror centrally) is so obviouly absurd that we cannot expect anybody to rely on these effects. "Better wrong than incompatible" isn't an option in this case. If there are inconquerable technical reasons thwarting an actual solution, graphical objects containing text must either refuse completely to flip or ask for an affirmation. (Behaviour unchanged in V7.1.1.1) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 109329] [META] VLookup function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109329 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||140365 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140365 [Bug 140365] VLOOKUP slow on accessing search matrix in other files -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140365] VLOOKUP slow on accessing search matrix in other files
https://bugs.documentfoundation.org/show_bug.cgi?id=140365 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||109329 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109329 [Bug 109329] [META] VLookup function bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140543] Alphanumeric input anomalies in Calc cells
https://bugs.documentfoundation.org/show_bug.cgi?id=140543 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Hardware|Other |ARM -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=129062 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||140583 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140583 [Bug 140583] x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140583] x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=140583 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||l.lu...@collabora.com Blocks||129062 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Lubos, skia shouldn't work on Linux or I missed something? Hans, where you do it "2. Enable Skia / Vulkan renderer (classic renderer is very laggy)"? In LibreOffice's Options dialog? Which Linux distro do you use? Do you use LibreOffice from your distro packages or from official site? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=129062 [Bug 129062] [META] Skia library bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #8 from Colin --- Perhaps I should also clarify that if you hover your mouse over A8 or A9 it is quite clear that I typed 17:21 everywhere and LO calc autoformatted but when the Col A source is cut and pasted to Col C & E the format is again autochanged from the time representations to decimal 0,722917 which is not an accurate rendition of the data in the source cells. OR is it now treating the typed data as a formula and copying the result of that "formula" in the "new" numerical format it assigned? C8 is neither the original source data nor is it presented according to the DATE/TIME format I predefined for it and would expect to see with "paste special" The jury is out on C9 - I no longer know what to expect. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: package/source pyuno/source reportdesign/source sax/source
package/source/manifest/ManifestExport.cxx | 31
package/source/xstor/owriteablestream.cxx | 30 ---
package/source/xstor/xstorage.cxx | 12 +---
package/source/xstor/xstorage.hxx |2
package/source/zippackage/ZipPackage.cxx| 16 ++
package/source/zippackage/ZipPackageStream.cxx |7 --
pyuno/source/module/pyuno_runtime.cxx |3 -
reportdesign/source/core/api/ReportDefinition.cxx |8 +--
reportdesign/source/core/api/Section.cxx|4 -
reportdesign/source/core/sdr/ReportDrawPage.cxx | 13 ++---
reportdesign/source/filter/xml/xmlColumn.cxx|4 -
reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx | 20 +++
reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx |3 -
reportdesign/source/ui/misc/statusbarcontroller.cxx |2
sax/source/expatwrap/sax_expat.cxx |4 -
15 files changed, 66 insertions(+), 93 deletions(-)
New commits:
commit e150c78cdfbe112bd880107b476ac42e72d4643c
Author: Noel
AuthorDate: Sun Feb 21 12:34:46 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Feb 21 19:00:26 2021 +0100
loplugin:refcounting in package..sax
Change-Id: I83618f54a4117cd81d8626307716129a761e14c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111274
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/package/source/manifest/ManifestExport.cxx
b/package/source/manifest/ManifestExport.cxx
index 2f6f1ea0d913..c3c4be339646 100644
--- a/package/source/manifest/ManifestExport.cxx
+++ b/package/source/manifest/ManifestExport.cxx
@@ -32,6 +32,7 @@
#include
#include
+#include
#include
#include
#include
@@ -119,7 +120,7 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
const OUString sPBKDF2_Name ( PBKDF2_NAME );
const OUString sPGP_Name( PGP_NAME );
-::comphelper::AttributeList * pRootAttrList = new
::comphelper::AttributeList;
+rtl::Reference<::comphelper::AttributeList> pRootAttrList = new
::comphelper::AttributeList;
// find the mediatype of the document if any
OUString aDocMediaType;
@@ -211,8 +212,6 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
}
}
-uno::Reference < xml::sax::XAttributeList > xRootAttrList (pRootAttrList);
-
xHandler->startDocument();
uno::Reference < xml::sax::XExtendedDocumentHandler > xExtHandler (
xHandler, uno::UNO_QUERY );
if ( xExtHandler.is() && bProvideDTD )
@@ -220,7 +219,7 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
xExtHandler->unknown ( MANIFEST_DOCTYPE );
xHandler->ignorableWhitespace ( sWhiteSpace );
}
-xHandler->startElement( sManifestElement, xRootAttrList );
+xHandler->startElement( sManifestElement, pRootAttrList );
const uno::Any *pKeyInfoProperty = nullptr;
if ( pRootFolderPropSeq )
@@ -271,14 +270,13 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
xHandler->startElement(isODF13 ? sEncryptedKeyElement13 :
sEncryptedKeyElement, nullptr);
xHandler->ignorableWhitespace ( sWhiteSpace );
-::comphelper::AttributeList * pNewAttrList = new
::comphelper::AttributeList;
-uno::Reference < xml::sax::XAttributeList > xNewAttrList
(pNewAttrList);
+rtl::Reference<::comphelper::AttributeList> pNewAttrList =
new ::comphelper::AttributeList;
// TODO: the algorithm should rather be configurable
pNewAttrList->AddAttribute(
isODF13 ? sAlgorithmAttribute13 : sAlgorithmAttribute,
sCdataAttribute,
"http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1p; );
-xHandler->startElement(isODF13 ?
sEncryptionMethodElement13 : sEncryptionMethodElement, xNewAttrList);
+xHandler->startElement(isODF13 ?
sEncryptionMethodElement13 : sEncryptionMethodElement, pNewAttrList);
xHandler->endElement(isODF13 ? sEncryptionMethodElement13
: sEncryptionMethodElement);
xHandler->ignorableWhitespace ( sWhiteSpace );
@@ -339,7 +337,7 @@ ManifestExport::ManifestExport( uno::Reference<
xml::sax::XDocumentHandler > con
// now write individual file entries
for (const uno::Sequence& rSequence : rManList)
{
-::comphelper::AttributeList *pAttrList = new
::comphelper::AttributeList;
+rtl::Reference<::comphelper::AttributeList> pAttrList = new
::comphelper::AttributeList;
OUString aString;
const uno::Any *pVector
[Libreoffice-bugs] [Bug 140584] [Feature Request] Provide a UI to specify the only parameter of ScPreview::SetPageNo (and hopefully SID_ thingy would be nicer)
https://bugs.documentfoundation.org/show_bug.cgi?id=140584 himajin100...@gmail.com changed: What|Removed |Added Summary|[Feature Request] Provide a |[Feature Request] Provide a |UI to specify the only |UI to specify the only |parameter of|parameter of |ScPreview::SetPageNo (and |ScPreview::SetPageNo (and |hopefully SID_ thingy would |hopefully SID_ thingy would |be nicer)) |be nicer) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140584] New: [Feature Request] Provide a UI to specify the only parameter of ScPreview::SetPageNo (and hopefully SID_ thingy would be nicer))
https://bugs.documentfoundation.org/show_bug.cgi?id=140584 Bug ID: 140584 Summary: [Feature Request] Provide a UI to specify the only parameter of ScPreview::SetPageNo (and hopefully SID_ thingy would be nicer)) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: himajin100...@gmail.com Description: see steps to reproduce I noticed this issue, per a report on https://ask.libreoffice.org/ja/question/290710/ Steps to Reproduce: (Just for Comparison purpose) W-1. Launch Writer W-2. [File] - [Print Preview] W-3. There is a text box with a tooptip saying "Jump To Specific Page" (Now, the main steps follow) C-1. Launch Calc C-2. [File] - [Print Preview] C-3. try to find a textbox similar to what is described in W-3 Actual Results: you will NOT find such a textbox Expected Results: even in Calc, we can find a textbox to specify which page to preview Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 62dff2844b0bf1d1bcb8eb4d6db529ef4a31bee4 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: ja-JP (ja_JP); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #7 from Colin --- Perhaps I should mention that the message text is the only data not manipulated in my process. I take the other data elements and convert them to real dates and times. evaluate the sender and recipient, and then select seven of the twelve columns. The paste special unformatted text is defined as "ignore blanks". The destination is a large autofiltered array from which I can "mix n' match" whatever I choose. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139070] LISTBOX: Values, which are in different rows, where not shown right separated in preview
https://bugs.documentfoundation.org/show_bug.cgi?id=139070 raal changed: What|Removed |Added Keywords|bibisectRequest |bibisected, bisected CC||caol...@redhat.com, ||r...@post.cz --- Comment #2 from raal --- This seems to have begun at the below commit. Adding Cc: to Caolán McNamara ; Could you possibly take a look at this one? Thanks e7cb5671ab586f618b3a45c5e9241f3d1988226c is the first bad commit commit e7cb5671ab586f618b3a45c5e9241f3d1988226c Author: Jenkins Build User Date: Mon Dec 9 14:28:14 2019 +0100 source sha:1efeb17837c22499f00299c033ae59ba3910f7d7 commit 1efeb17837c22499f00299c033ae59ba3910f7d7[log] author Caolán McNamara Mon Nov 04 13:06:04 2019 + committer Caolán McNamara Mon Dec 09 13:28:35 2019 +0100 treea8db0b758e942b3b14fba26129dc51a95ff5c10c parent 4da3e0a0e5b2260c26186890724978bfd00f796c [diff] weld Property Browser -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: lotuswordpro/README
lotuswordpro/README | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) New commits: commit bb8fb3237c9d1b9516f5803d476c1db09570c2dc Author: David Tardon AuthorDate: Sun Feb 21 18:24:21 2021 +0100 Commit: David Tardon CommitDate: Sun Feb 21 18:26:04 2021 +0100 expand lotuswordpro README a bit Change-Id: Ibe5e5b1bef43049065915f80aae5037a782ed698 diff --git a/lotuswordpro/README b/lotuswordpro/README index 4ec710488b31..a1e3c20e0167 100644 --- a/lotuswordpro/README +++ b/lotuswordpro/README @@ -1 +1,31 @@ -Filter for file format of Lotus Word Pro. +Import filter for file format of Lotus Word Pro. + +== Description == + +The import is not direct, but via an intermediate format: StarOffice +XML, the predecessor of ODF (yes, the code is old). The entry point to +the filter is class LotusWordProImportFilter (refer to Source code +section), but that just hooks up the necessary machinery for processing +StarOffice XML produced by the filter. The real fun starts in function +ReadWordproFile() (source/filter/lwpfilter.cxx); this function +initializes the parser (class Lwp9Reader) and the SAX XML handler that +produces the output (class XFSaxStream). The Lwp9Reader class then does +the actual parsing. + +If the module is built with debug level greater than 0, it is possible +to examine the intermediate XML: set environment variable +DBG_LWPIMPORT_DIR= to an existing directory and, on opening an lwp +document, a file named lwpimport.xml will be created in that directory. + +== Source code == + +=== Module contents === +* inc: module-global headers (can be included by any file in source) +* qa: cppunit tests +* source: the filter itself +* util: UNO passive registration config + +=== Source contents === +* filter: lwp document format parser +* filter/LotusWordProImportFilter.cxx: the entry point to the filter +* filter/xfilter: export to StarOffice XML ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #6 from Colin --- Created attachment 169945 --> https://bugs.documentfoundation.org/attachment.cgi?id=169945=edit Screen Grab of the source text format -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #5 from Colin --- (In reply to m.a.riosv from comment #4) > Have you seen that 17:21 it's a text not a true time in the spreadsheet. > > Use Menu/View/Value Highlighting > > Text is in black, numeric/date-time values in blue. Precisely, It was text in the SMS, it was text in the SMSBackup XLS file in Dropbox, it was text in the view XML file at https://synctech.com.au/sms-backup-restore/view-backup/ using Firefox and it appeared as a formatted time when pasted special to the Lo Calc - see attached screen grab and compare it with the cut & paste herewith from the first stage of my processing; Sent2021-02-17 2:35:43 PM Bus? Received2021-02-17 2:36:00 PM 05:21 PM Sent2021-02-17 2:36:43 PM Food? Note: As can be seen in the attached screen grab, the entire date & Time is one text string which I then chop and rationalise. The subsequent treatment in the sample calc can be verified as "unexpected" and "inconsistent". It's a two-stage operation. I select and copy the browser screen and then ALT CTRL SHFT V to the LO Calc which simply forces unformatted - NO dialogue box * to the first sheet and that is the representation above where the source 17:21 is autoformatted 05:21PM. I then manipulate some of the data but NEVER the text message which is then simply selected and copied with CTRL SHFT V to the destination and the dialogue box is confirmed "text, numbers, date and time". All the rationalised dates and times present as formatted but the 17:21 or 05:21PM which is sourced from a "numerically formatted? text" cell becomes decimal 0,72291666* within the target cell. It was only noticed by chance and I don't really conceive of vetting 7500 lines on the calc to ascertain if perhaps 10-20 could contain the same anomaly -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139734] Drop redundant asserts after MacrosTest::loadFromDesktop
https://bugs.documentfoundation.org/show_bug.cgi?id=139734 --- Comment #7 from Mike Kaganski --- (In reply to Moaz El-defrawy from comment #6) > > > I am not sure how style the comments to make them more readable. I tried > > > html and readme files styling but neither worked. > > > > Are you talking about commit message, or about some comments in code? It's > > best to discuss in Gerrit change, where you post some proposed change, and > > then comment on parts that you are unsure with, and get responses from > > reviewers. > > I am sorry for not being clear enough. I was asking if there is a way to > style the comments here (in this page) in case I wanted to insert some code. > it seems like '>' character is the only way to do that? No problem; so the answer is: Bugzilla is *not* the place to discuss code. Gerrit is :-) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139734] Drop redundant asserts after MacrosTest::loadFromDesktop
https://bugs.documentfoundation.org/show_bug.cgi?id=139734 --- Comment #6 from Moaz El-defrawy --- (In reply to Mike Kaganski from comment #5) > (In reply to Moaz El-defrawy from comment #4) > > Update: I am removed 99% of the redundant asserts and I will submit a patch > > very soon. > > Very good! > > > I had a question though: > > There is a pattern of asserting the return values of many functions not just > > "loadFromDesktop". Why don't we assert their return values instead just like > > "loadFromDesktop" and remove the extra ones? > > This needs discussing case-by-case. In this form, I can't answer this. Which > specific change(s) you propose? I was thinking about it as a general principle and not about specific changes. but, I just realized you I am incorrect. For example, what if we want the function to return 0 or null at some cases. > > > another question: > > I am not sure how style the comments to make them more readable. I tried > > html and readme files styling but neither worked. > > Are you talking about commit message, or about some comments in code? It's > best to discuss in Gerrit change, where you post some proposed change, and > then comment on parts that you are unsure with, and get responses from > reviewers. I am sorry for not being clear enough. I was asking if there is a way to style the comments here (in this page) in case I wanted to insert some code. it seems like '>' character is the only way to do that? > > Looking forward to see the change on Gerrit. Thanks for working on this! Thanks a lot. I am excited to finish it and move on to the next issue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140535] equation sign '=' is not printed
https://bugs.documentfoundation.org/show_bug.cgi?id=140535 --- Comment #4 from Timur --- I also don't reproduce printing to PDF. User Profile Reset: indicates reporter should always try to reset/delete. Also you need to test print to PDF and export to PDF. And if problem continues, you should test daily master from https://dev-builds.libreoffice.org/daily/master/current.html. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #4 from m.a.riosv --- Have you seen that 17:21 it's a text not a true time in the spreadsheet. Use Menu/View/Value Highlighting Text is in black, numeric/date-time values in blue. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33713] FORMATTING, FILEOPEN: Spacing above and below paragraph (.lwp)
https://bugs.documentfoundation.org/show_bug.cgi?id=33713 Buovjaga changed: What|Removed |Added CC|ilmari.lauhakangas@libreoff |adityapratapsingh51@gmail.c |ice.org |om --- Comment #20 from Buovjaga --- (In reply to David Tardon from comment #19) > (In reply to adityapratapsingh51 from comment #17) > > I'm quite new, so, apologies in advance if it's an obvious answer, but, Is > > there a way to view the ODF that's created internally? > > There is a way now: > https://git.libreoffice.org/core/+/ > 301b09f0c4fef6fca52fa0b28827a6576b39%5E%21 FYI, Aditya -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140038] FILEOPEN PPTX on Android: can't open specific pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=140038 --- Comment #5 from LE GARREC Vincent --- I restricted the log at the time I pressed on the screen to open the document from the FileViewer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140038] FILEOPEN PPTX on Android: can't open specific pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=140038 --- Comment #4 from LE GARREC Vincent --- Created attachment 169944 --> https://bugs.documentfoundation.org/attachment.cgi?id=169944=edit bad_open_pptx.log -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140038] FILEOPEN PPTX on Android: can't open specific pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=140038 --- Comment #3 from LE GARREC Vincent --- Created attachment 169943 --> https://bugs.documentfoundation.org/attachment.cgi?id=169943=edit good_open_doc.log -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140038] FILEOPEN PPTX on Android: can't open specific pptx
https://bugs.documentfoundation.org/show_bug.cgi?id=140038 --- Comment #2 from LE GARREC Vincent --- >From a custom build (not a daily build), I managed to get log from a successful load with a doc and a failed load with a pptx. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140077] Fatal Error after insert a new line by Enter (std::bad_array_new_length)
https://bugs.documentfoundation.org/show_bug.cgi?id=140077
--- Comment #10 from Dave Gilbert ---
Ah, so if I add:
+++ b/sw/source/core/text/porlay.cxx
@@ -2648,17 +2648,24 @@ TextFrameIndex SwScriptInfo::CountCJKCharacters(const
OUString ,
TextFrameIndex nPos, TextFrameIndex const nEnd, LanguageType aLang)
{
TextFrameIndex nCount(0);
if (nEnd > nPos)
{
sal_Int32 nDone = 0;
const lang::Locale = g_pBreakIt->GetLocale( aLang );
while ( nPos < nEnd )
{
+TextFrameIndex nOldPos = nPos;
nPos = TextFrameIndex(g_pBreakIt->GetBreakIter()->nextCharacters(
rText, sal_Int32(nPos),
rLocale,
i18n::CharacterIteratorMode::SKIPCELL, 1, nDone));
+if (nPos == nOldPos) {
+SAL_WARN("sw.core", "CountCJKCharacters not moving" );
+break;
+}
nCount++;
}
then I get the bad_array_new_length back.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140583] New: x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed.
https://bugs.documentfoundation.org/show_bug.cgi?id=140583 Bug ID: 140583 Summary: x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed. Product: LibreOffice Version: 7.1.0.3 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hovahe7...@bulkbye.com Description: mesa: for the --simplifycfg-sink-common option: may only occur zero or one times! mesa: for the --global-isel-abort option: may only occur zero or one times! mesa: for the --amdgpu-atomic-optimizations option: may only occur zero or one times! mesa: for the --structurizecfg-skip-uniform-regions option: may only occur zero or one times! ../mesa/src/vulkan/wsi/wsi_common_x11.c:1089: Swapchain status changed to VK_ERROR_OUT_OF_DATE_KHR ../mesa/src/vulkan/wsi/wsi_common_x11.c:1089: Swapchain status changed to VK_ERROR_OUT_OF_DATE_KHR ../mesa/src/vulkan/wsi/wsi_common_x11.c:1089: Swapchain status changed to VK_ERROR_OUT_OF_DATE_KHR soffice.bin: ../mesa/src/vulkan/wsi/wsi_common_x11.c:1096: x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed. Fatal exception: Signal 6 Stack: /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3ebc4)[0x7fbdfa21dbc4] /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3ed4c)[0x7fbdfa21dd4c] /usr/lib/libc.so.6(+0x3cf80)[0x7fbdf9f14f80] /usr/lib/libc.so.6(gsignal+0x145)[0x7fbdf9f14ef5] /usr/lib/libc.so.6(abort+0x116)[0x7fbdf9efe862] /usr/lib/libc.so.6(+0x26747)[0x7fbdf9efe747] /usr/lib/libc.so.6(+0x35646)[0x7fbdf9f0d646] /usr/lib/libvulkan_radeon.so(+0x20385f)[0x7fbdd9b8985f] /usr/lib/libvulkan_radeon.so(+0x203b05)[0x7fbdd9b89b05] /usr/lib/libpthread.so.0(+0x9299)[0x7fbdf9b7b299] /usr/lib/libc.so.6(clone+0x43)[0x7fbdf9fd7053] Steps to Reproduce: 1. Have Linux, mesa and radeonsi driver 2. Enable Skia / Vulkan renderer (classic renderer is very laggy) 3. crash Actual Results: dlerror: libclang-cpp.so.11: cannot open shared object file: No such file or directory mesa: for the --simplifycfg-sink-common option: may only occur zero or one times! mesa: for the --global-isel-abort option: may only occur zero or one times! mesa: for the --amdgpu-atomic-optimizations option: may only occur zero or one times! mesa: for the --structurizecfg-skip-uniform-regions option: may only occur zero or one times! ../mesa/src/vulkan/wsi/wsi_common_x11.c:1089: Swapchain status changed to VK_ERROR_OUT_OF_DATE_KHR ../mesa/src/vulkan/wsi/wsi_common_x11.c:1089: Swapchain status changed to VK_ERROR_OUT_OF_DATE_KHR ../mesa/src/vulkan/wsi/wsi_common_x11.c:1089: Swapchain status changed to VK_ERROR_OUT_OF_DATE_KHR soffice.bin: ../mesa/src/vulkan/wsi/wsi_common_x11.c:1096: x11_present_to_x11_dri3: Assertion `chain->sent_image_count <= chain->base.image_count' failed. Fatal exception: Signal 6 Stack: /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3ebc4)[0x7fbdfa21dbc4] /usr/lib/libreoffice/program/libuno_sal.so.3(+0x3ed4c)[0x7fbdfa21dd4c] /usr/lib/libc.so.6(+0x3cf80)[0x7fbdf9f14f80] /usr/lib/libc.so.6(gsignal+0x145)[0x7fbdf9f14ef5] /usr/lib/libc.so.6(abort+0x116)[0x7fbdf9efe862] /usr/lib/libc.so.6(+0x26747)[0x7fbdf9efe747] /usr/lib/libc.so.6(+0x35646)[0x7fbdf9f0d646] /usr/lib/libvulkan_radeon.so(+0x20385f)[0x7fbdd9b8985f] /usr/lib/libvulkan_radeon.so(+0x203b05)[0x7fbdd9b89b05] /usr/lib/libpthread.so.0(+0x9299)[0x7fbdf9b7b299] /usr/lib/libc.so.6(clone+0x43)[0x7fbdf9fd7053] Expected Results: no crash Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: vulkaninfo log needed? https://pastebin.com/mByEuaV1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: wizards/source
wizards/source/scriptforge/SF_Platform.xba | 24 - wizards/source/scriptforge/python/ScriptForgeHelper.py |5 +++ 2 files changed, 28 insertions(+), 1 deletion(-) New commits: commit 4b448758a98670efe259965829e5ce0861392caf Author: Jean-Pierre Ledure AuthorDate: Sun Feb 21 15:48:01 2021 +0100 Commit: Jean-Pierre Ledure CommitDate: Sun Feb 21 17:06:18 2021 +0100 ScriptForge - (SF_Platform) new Locale and PythonVersion properties - 'Locale' returns a la-CO (language-COUNTRY) string derived from com.sun.star.lang.Locale - 'PythonVersion' returns Python major.minor.patchlevel supplied by ScriptForgeHelper.py platform class Change-Id: I2b8495c03253b17c5e4ba14765b1f359eee67813 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111284 Tested-by: Jean-Pierre Ledure Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure diff --git a/wizards/source/scriptforge/SF_Platform.xba b/wizards/source/scriptforge/SF_Platform.xba index 80f3ab97a182..69045404b5ba 100644 --- a/wizards/source/scriptforge/SF_Platform.xba +++ b/wizards/source/scriptforge/SF_Platform.xba @@ -70,6 +70,14 @@ Property Get CurrentUser() As String CurrentUser = _PropertyGet(CurrentUser) End Property ScriptForge.SF_Platform.CurrentUser (get) +REM - +Property Get Locale() As String + Returns the locale combining language-COUNTRY (la-CO) + Example: + MsgBox platform.Locale + Locale = _PropertyGet(Locale) +End Property ScriptForge.SF_Platform.Locale (get) + REM - Property Get Machine() As String Returns the machine type like i386 or x86_64 @@ -138,6 +146,14 @@ Property Get Processor() As String Processor = _PropertyGet(Processor) End Property ScriptForge.SF_Platform.Processor (get) +REM - +Property Get PythonVersion() As String + Returns the Python version as string Python major.minor.patchlevel + Example: + MsgBox platform.PythonVersion Python 3.7.7 + PythonVersion = _PropertyGet(PythonVersion) +End Property ScriptForge.SF_Platform.PythonVersion (get) + REM = METHODS REM - @@ -190,6 +206,7 @@ Public Function Properties() As Variant , ComputerName _ , CPUCount _ , CurrentUser _ + , Locale _ , Machine _ , OfficeVersion _ , OSName _ @@ -197,6 +214,7 @@ Public Function Properties() As Variant , OSRelease _ , OSVersion _ , Processor _ + , PythonVersion _ ) End Function ScriptForge.SF_Platform.Properties @@ -238,6 +256,7 @@ Private Function _PropertyGet(Optional ByVal psProperty As String) As Variant psProperty: the name of the property Dim sOSName As StringOperating system +Dim oLocale As Objectcom.sun.star.lang.Locale Const cstPyHelper = $ _SF_Platform Dim cstThisSub As String @@ -248,10 +267,13 @@ Const cstSubArgs = Select Case psProperty Case Architecture, ComputerName, CPUCount, CurrentUser, Machine _ - , OSPlatform, OSRelease, OSVersion, Processor + , OSPlatform, OSRelease, OSVersion, Processor, PythonVersion With ScriptForge.SF_Session _PropertyGet = .ExecutePythonScript(.SCRIPTISSHARED, _SF_.PythonHelper cstPyHelper, psProperty) End With + Case Locale + Set oLocale = SF_Utils._GetUNOService(Locale) + _PropertyGet = oLocale.Language - oLocale.Country Case OfficeVersion _PropertyGet = _GetProductName() Case OSName diff --git a/wizards/source/scriptforge/python/ScriptForgeHelper.py b/wizards/source/scriptforge/python/ScriptForgeHelper.py index ca520434a2a9..aec9311a3f3f 100644 --- a/wizards/source/scriptforge/python/ScriptForgeHelper.py +++ b/wizards/source/scriptforge/python/ScriptForgeHelper.py @@ -171,6 +171,8 @@ def _SF_Platform(propertyname: str): # used by SF_Platform Basic module return pf.OSVersion elif propertyname ==
[Libreoffice-bugs] [Bug 139140] KDE: Notebookbar Styles Preview doesn't show correct font colour for paragraph styles that are automatic
https://bugs.documentfoundation.org/show_bug.cgi?id=139140 --- Comment #2 from Sebastiaan Veld --- Created attachment 169942 --> https://bugs.documentfoundation.org/attachment.cgi?id=169942=edit Screenshot styles preview Have the same issue running LO on openSUSE Tumbleweed; Version: 7.1.0.3 / LibreOffice Community Build ID: 10(Build:3) CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: kf5 Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140077] Fatal Error after insert a new line by Enter (std::bad_array_new_length)
https://bugs.documentfoundation.org/show_bug.cgi?id=140077 --- Comment #9 from Dave Gilbert --- and: SwScriptInfo::CountCJKCharacters '承包人(全称)： 重庆钢铁集团建设工程有限公司' nPos: 23 nEnd: 26 BreakIterator_Unicode::nextCharacters '承包人(全称)： 重庆钢铁集团建设工程有限公司' oldStartPos:23 nStartPos: -1 nDone: 0 nCount: 1 so the nextCharacters is immediately exiting. I count 23 actual characters in that string. I think the 26 is coming from lcl_AddSpace in portxt.cxx: nPos = rInf.GetIdx(); nEnd = rInf.GetIdx() + rPor.GetLen(); -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33713] FORMATTING, FILEOPEN: Spacing above and below paragraph (.lwp)
https://bugs.documentfoundation.org/show_bug.cgi?id=33713 --- Comment #19 from David Tardon --- (In reply to adityapratapsingh51 from comment #17) > I'm quite new, so, apologies in advance if it's an obvious answer, but, Is > there a way to view the ODF that's created internally? There is a way now: https://git.libreoffice.org/core/+/301b09f0c4fef6fca52fa0b28827a6576b39%5E%21 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46184] [Calc] [AutoFilter] Option "Copy results to ..." remains activated in AutoFilter
https://bugs.documentfoundation.org/show_bug.cgi?id=46184 --- Comment #14 from Jean-Baptiste Faure --- Still reproducible in LO 7.1.2.0.0+ : Version: 7.1.2.0.0+ / LibreOffice Community Build ID: a1f5d08fbaed7d1f7acf14227a9d28d12bba8ef2 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Ubuntu_18.04_x86-64 Calc: threaded Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/LotusWordProImportFilter.cxx | 131
1 file changed, 131 insertions(+)
New commits:
commit 301b09f0c4fef6fca52fa0b28827a6576b39
Author: David Tardon
AuthorDate: Sat Feb 13 15:51:20 2021 +0100
Commit: David Tardon
CommitDate: Sun Feb 21 16:23:39 2021 +0100
lotuswordpro: allow to dump intermediate XML into file
If env. variable DBG_LWPIMPORT_DIR= is set to an existing directory, a
formatted representation of the intermediate XML format is dumped into a
file named lwpimport.xml in that directory. This makes debugging of
Lotus Word Pro import a lot easier.
Change-Id: I872c388c2b378d55f476973890a073ec932e1b4b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111283
Tested-by: Jenkins
Reviewed-by: David Tardon
diff --git a/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
b/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
index 73335e0bab88..296561bcc375 100644
--- a/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
+++ b/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
@@ -30,6 +30,19 @@
#include "LotusWordProImportFilter.hxx"
#include "lwpfilter.hxx"
+#if OSL_DEBUG_LEVEL > 0
+#include
+
+#include
+#include
+
+#include
+
+#include
+
+#include
+#endif
+
using namespace com::sun::star;
using com::sun::star::uno::Sequence;
using com::sun::star::uno::Any;
@@ -41,6 +54,100 @@ using com::sun::star::ucb::XCommandEnvironment;
using com::sun::star::document::XImporter;
using com::sun::star::xml::sax::XDocumentHandler;
+#if OSL_DEBUG_LEVEL > 0
+namespace
+{
+
+class DebugDocumentHandler final : public cppu::WeakImplHelper<
XDocumentHandler >
+{
+public:
+DebugDocumentHandler(const uno::Reference< XDocumentHandler >& handler,
const uno::Reference< XDocumentHandler >& debug)
+: m_handler(handler)
+, m_debug(debug)
+{
+}
+
+// XDocumentHandler
+
+virtual void SAL_CALL
+startDocument() override
+{
+m_handler->startDocument();
+m_debug->startDocument();
+}
+
+virtual void SAL_CALL
+endDocument() override
+{
+m_handler->endDocument();
+m_debug->endDocument();
+}
+
+virtual void SAL_CALL
+startElement(
+const OUString& aName,
+const uno::Reference< xml::sax::XAttributeList > & xAttribs)
override
+{
+m_handler->startElement(aName, xAttribs);
+m_debug->ignorableWhitespace(" "); // NOTE: needed for pretty-printing
+m_debug->startElement(aName, xAttribs);
+}
+
+virtual void SAL_CALL
+endElement(const OUString& aName) override
+{
+m_handler->endElement(aName);
+m_debug->ignorableWhitespace(" "); // NOTE: needed for pretty-printing
+m_debug->endElement(aName);
+}
+
+virtual void SAL_CALL
+characters(const OUString& aChars) override
+{
+m_handler->characters(aChars);
+m_debug->characters(aChars);
+}
+
+virtual void SAL_CALL
+ignorableWhitespace(const OUString& aWhitespaces) override
+{
+m_handler->ignorableWhitespace(aWhitespaces);
+m_debug->ignorableWhitespace(aWhitespaces);
+}
+
+virtual void SAL_CALL
+processingInstruction(const OUString& aTarget, const OUString& aData)
override
+{
+m_handler->processingInstruction(aTarget, aData);
+m_debug->processingInstruction(aTarget, aData);
+}
+
+virtual void SAL_CALL
+setDocumentLocator(const uno::Reference< xml::sax::XLocator >& xLocator)
override
+{
+m_handler->setDocumentLocator(xLocator);
+m_debug->setDocumentLocator(xLocator);
+}
+
+// XInterface
+
+virtual uno::Any SAL_CALL queryInterface(const uno::Type & rType) override
+{
+uno::Any aIface = cppu::WeakImplHelper< XDocumentHandler
>::queryInterface(rType);
+// delegate all queries we cannot satisfy ourselves to the real handler
+if (!aIface.has< uno::Reference< uno::XInterface > >())
+aIface = m_handler->queryInterface(rType);
+return aIface;
+}
+
+private:
+uno::Reference< XDocumentHandler > m_handler;
+uno::Reference< XDocumentHandler > m_debug;
+};
+
+}
+#endif
+
// W o r d P r o
const sal_Int8 header[] = { 0x57, 0x6f, 0x72, 0x64, 0x50, 0x72, 0x6f };
@@ -61,6 +168,30 @@ bool LotusWordProImportFilter::importImpl( const Sequence<
css::beans::PropertyV
// An XML import service: what we push sax messages to...
uno::Reference< XDocumentHandler > xInternalHandler(
mxContext->getServiceManager()->createInstanceWithContext(
"com.sun.star.comp.Writer.XMLImporter", mxContext ), UNO_QUERY );
+
+#if OSL_DEBUG_LEVEL > 0
+std::unique_ptr pDebugFile;
+const char* pDir = getenv("DBG_LWPIMPORT_DIR");
+if (pDir)
+{
+OUString aStr(OStringToOUString(pDir, RTL_TEXTENCODING_UTF8));
+OUString
[Libreoffice-bugs] [Bug 140566] Bug in Impress on Plasma Deskop with 2 monitors
https://bugs.documentfoundation.org/show_bug.cgi?id=140566 --- Comment #3 from giors...@yahoo.it --- Sorry I'm on wayland -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140582] New: Impress goes to background
https://bugs.documentfoundation.org/show_bug.cgi?id=140582 Bug ID: 140582 Summary: Impress goes to background Product: LibreOffice Version: 7.1.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: giors...@yahoo.it Description: Nautilus in background, moving through a presentation (clicking on a sheet on the left pannel) makes randomly go impress on background (and nautilus on foreground Steps to Reproduce: 1. Open impress with a nautilus wineries in background 2.move randomly from a sheet to another using left panel. 3.randomly you will find yourself navigating through your folder with nautilus: impress passed to background Actual Results: Impress goes to background Expected Results: It shouldn't go to background. I'm just moving from a sheet to another Reproducible: Sometimes User Profile Reset: No OpenGL enabled: Yes Additional Info: On arch linux, gnome 3.38 on wayland -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/unotools sc/inc sc/source
include/unotools/weakref.hxx | 132 +++
sc/inc/cellsuno.hxx |4
sc/source/core/data/dpobject.cxx |3
sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx | 15 -
sc/source/filter/xml/XMLChangeTrackingExportHelper.hxx |4
sc/source/filter/xml/xmlexprt.cxx|8
sc/source/ui/Accessibility/AccessibleCell.cxx|8
sc/source/ui/Accessibility/AccessibleCsvControl.cxx | 14 -
sc/source/ui/Accessibility/AccessibleDocument.cxx| 15 -
sc/source/ui/Accessibility/AccessibleDocumentPagePreview.cxx |2
sc/source/ui/Accessibility/AccessibleEditObject.cxx |7
sc/source/ui/Accessibility/AccessiblePageHeader.cxx |2
sc/source/ui/Accessibility/AccessiblePageHeaderArea.cxx |2
sc/source/ui/Accessibility/AccessiblePreviewCell.cxx |2
sc/source/ui/Accessibility/AccessiblePreviewHeaderCell.cxx |2
sc/source/ui/Accessibility/AccessiblePreviewTable.cxx|2
sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx | 10
sc/source/ui/app/drwtrans.cxx|2
sc/source/ui/app/inputwin.cxx|1
sc/source/ui/app/seltrans.cxx|4
sc/source/ui/drawfunc/fuins2.cxx |5
sc/source/ui/inc/AccessibleCsvControl.hxx|2
sc/source/ui/inc/AccessibleDocument.hxx |4
sc/source/ui/inc/inputwin.hxx|2
sc/source/ui/inc/seltrans.hxx|2
sc/source/ui/inc/tphfedit.hxx|4
sc/source/ui/inc/viewfunc.hxx|2
sc/source/ui/pagedlg/tphfedit.cxx| 39 +--
sc/source/ui/unoobj/cellsuno.cxx | 17 -
sc/source/ui/unoobj/chart2uno.cxx|2
sc/source/ui/unoobj/docuno.cxx |9
sc/source/ui/unoobj/fmtuno.cxx |2
sc/source/ui/unoobj/shapeuno.cxx |7
sc/source/ui/unoobj/textuno.cxx | 30 +-
sc/source/ui/unoobj/viewuno.cxx | 10
sc/source/ui/vba/vbaworkbooks.cxx|4
sc/source/ui/view/drawvie4.cxx |5
sc/source/ui/view/gridwin5.cxx |2
sc/source/ui/view/hintwin.cxx| 11
sc/source/ui/view/preview.cxx|2
sc/source/ui/view/viewfun3.cxx |5
41 files changed, 247 insertions(+), 158 deletions(-)
New commits:
commit 78040af9acea0ab681aa54ff23844b647bc9b4f3
Author: Noel
AuthorDate: Sun Feb 21 12:33:10 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Feb 21 16:13:31 2021 +0100
loplugin:refcounting in sc
Change-Id: Id0ba24985aab36b931fa74b266dc5bf0bef62bb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111273
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/unotools/weakref.hxx b/include/unotools/weakref.hxx
new file mode 100644
index ..7fdf5acba698
--- /dev/null
+++ b/include/unotools/weakref.hxx
@@ -0,0 +1,132 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+/*
+ * This file is part of LibreOffice published API.
+ */
+#pragma once
+
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+
+namespace cppu
+{
+class OWeakObject;
+}
+
+namespace unotools
+{
+/** The WeakReference<> holds a weak reference to an object.
+
+That object must implement the css::uno::XWeak interface.
+
+The WeakReference itself is *not* thread safe, just as
+Reference itself isn't, but the implementation of the listeners etc.
+behind it *is* thread-safe, so multiple threads can
[Libreoffice-commits] core.git: sdext/source sd/source
sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx |2
sd/source/ui/accessibility/AccessibleSlideSorterView.cxx|2
sd/source/ui/framework/configuration/Configuration.cxx |4 -
sd/source/ui/slidesorter/controller/SlsClipboard.cxx|8 +--
sd/source/ui/slidesorter/controller/SlsTransferableData.cxx |4 -
sd/source/ui/slidesorter/inc/controller/SlsTransferableData.hxx |2
sd/source/ui/slidesorter/shell/SlideSorterViewShell.cxx |6 --
sd/source/ui/unoidl/unopage.cxx | 16 +++---
sd/source/ui/unoidl/unosrch.cxx |2
sd/source/ui/view/drviews5.cxx |6 --
sd/source/ui/view/outlnvsh.cxx |6 --
sd/source/ui/view/sdview2.cxx | 23
--
sdext/source/pdfimport/pdfiadaptor.cxx | 13 +++--
13 files changed, 41 insertions(+), 53 deletions(-)
New commits:
commit 8f231fc5df201c45d16bce0b4b17f727842b2121
Author: Noel
AuthorDate: Sun Feb 21 12:32:12 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Feb 21 16:13:06 2021 +0100
loplugin:refcounting in sd
Change-Id: Ic95aa7a3c1fdab1baef744ec85ffc9c98dee5f1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111272
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx
b/sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx
index a8c81225130b..fde0cd953677 100644
--- a/sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx
+++ b/sd/source/ui/accessibility/AccessibleSlideSorterObject.cxx
@@ -188,7 +188,7 @@ Reference SAL_CALL
{
ThrowIfDisposed();
const SolarMutexGuard aSolarGuard;
-::utl::AccessibleStateSetHelper* pStateSet = new
::utl::AccessibleStateSetHelper();
+rtl::Reference<::utl::AccessibleStateSetHelper> pStateSet = new
::utl::AccessibleStateSetHelper();
if (mxParent.is())
{
diff --git a/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
b/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
index ee663f2fbb1a..3ce13b899ef9 100644
--- a/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
+++ b/sd/source/ui/accessibility/AccessibleSlideSorterView.cxx
@@ -285,7 +285,7 @@ Reference SAL_CALL
{
ThrowIfDisposed();
const SolarMutexGuard aSolarGuard;
-::utl::AccessibleStateSetHelper* pStateSet = new
::utl::AccessibleStateSetHelper();
+rtl::Reference<::utl::AccessibleStateSetHelper> pStateSet = new
::utl::AccessibleStateSetHelper();
pStateSet->AddState(AccessibleStateType::FOCUSABLE);
pStateSet->AddState(AccessibleStateType::SELECTABLE);
diff --git a/sd/source/ui/framework/configuration/Configuration.cxx
b/sd/source/ui/framework/configuration/Configuration.cxx
index 53bbaa339316..f155e0992e68 100644
--- a/sd/source/ui/framework/configuration/Configuration.cxx
+++ b/sd/source/ui/framework/configuration/Configuration.cxx
@@ -182,12 +182,10 @@ Reference SAL_CALL
Configuration::createClone()
::osl::MutexGuard aGuard (maMutex);
ThrowIfDisposed();
-Configuration* pConfiguration = new Configuration(
+return new Configuration(
mxBroadcaster,
mbBroadcastRequestEvents,
*mpResourceContainer);
-
-return Reference(pConfiguration);
}
//- XNamed
diff --git a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
index 25e2aaea7b56..c7f333a5f0b9 100644
--- a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
@@ -429,17 +429,17 @@ void Clipboard::CreateSlideTransferable (
return;
mrSlideSorter.GetView().BrkAction();
-SdTransferable* pTransferable = TransferableData::CreateTransferable (
+rtl::Reference pTransferable =
TransferableData::CreateTransferable (
pDocument,
dynamic_cast(mrSlideSorter.GetViewShell()),
aRepresentatives);
if (bDrag)
-SD_MOD()->pTransferDrag = pTransferable;
+SD_MOD()->pTransferDrag = pTransferable.get();
else
-SD_MOD()->pTransferClip = pTransferable;
+SD_MOD()->pTransferClip = pTransferable.get();
-pDocument->CreatingDataObj (pTransferable);
+pDocument->CreatingDataObj (pTransferable.get());
pTransferable->SetWorkDocument(pDocument->AllocSdDrawDocument());
std::unique_ptr pObjDesc(new
TransferableObjectDescriptor);
pTransferable->GetWorkDocument()->GetDocSh()
diff --git a/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx
b/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx
index b340642553cc..2aac76fe0600 100644
--- a/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx
+++
[Libreoffice-commits] core.git: include/oox oox/source
include/oox/ppt/timenodelistcontext.hxx |2 +-
oox/source/drawingml/shape.cxx |2 +-
oox/source/ppt/timenodelistcontext.cxx |6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 98173f6222cec22170b53c7d9c94c6ce5b08b4d9
Author: Noel
AuthorDate: Sun Feb 21 13:30:45 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Feb 21 16:12:44 2021 +0100
loplugin:refcounting in oox..i18npool
Change-Id: Iff904a7ac887fa9b77bea87dbb1012281848a540
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111278
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/oox/ppt/timenodelistcontext.hxx
b/include/oox/ppt/timenodelistcontext.hxx
index 8bc76b3c185d..cd98d06b15fd 100644
--- a/include/oox/ppt/timenodelistcontext.hxx
+++ b/include/oox/ppt/timenodelistcontext.hxx
@@ -40,7 +40,7 @@ namespace oox::ppt {
public:
virtual ~TimeNodeContext() throw() override;
-static TimeNodeContext * makeContext( ::oox::core::FragmentHandler2
const & rParent, sal_Int32 aElement, const css::uno::Reference<
css::xml::sax::XFastAttributeList >& xAttribs, const TimeNodePtr & pNode );
+static rtl::Reference makeContext(
::oox::core::FragmentHandler2 const & rParent, sal_Int32 aElement, const
css::uno::Reference< css::xml::sax::XFastAttributeList >& xAttribs, const
TimeNodePtr & pNode );
protected:
TimeNodeContext( ::oox::core::FragmentHandler2 const & rParent,
sal_Int32 aElement, const TimeNodePtr & pNode ) throw();
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 22cacec6eaa6..469dc7c30c17 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1840,7 +1840,7 @@ void Shape::finalizeXShape( XmlFilterBase& rFilter, const
Reference< XShapes >&
// load the chart data from the XML fragment
bool bMSO2007Doc = rFilter.isMSO2007Document();
chart::ChartSpaceModel aModel(bMSO2007Doc);
-chart::ChartSpaceFragment *pChartSpaceFragment = new
chart::ChartSpaceFragment(
+rtl::Reference pChartSpaceFragment
= new chart::ChartSpaceFragment(
rFilter, mxChartShapeInfo->maFragmentPath, aModel );
const OUString aThemeOverrideFragmentPath(
pChartSpaceFragment->
getFragmentPathFromFirstTypeFromOfficeDoc(u"themeOverride") );
diff --git a/oox/source/ppt/timenodelistcontext.cxx
b/oox/source/ppt/timenodelistcontext.cxx
index 6ecd0985cd0a..93525ae4879a 100644
--- a/oox/source/ppt/timenodelistcontext.cxx
+++ b/oox/source/ppt/timenodelistcontext.cxx
@@ -909,12 +909,12 @@ namespace oox::ppt {
}
-TimeNodeContext * TimeNodeContext::makeContext(
+rtl::Reference TimeNodeContext::makeContext(
FragmentHandler2 const & rParent, sal_Int32 aElement,
const Reference< XFastAttributeList >& xAttribs,
const TimeNodePtr & pNode )
{
-TimeNodeContext *pCtx = nullptr;
+rtl::Reference pCtx;
switch( aElement )
{
case PPT_TOKEN( animClr ):
@@ -1039,7 +1039,7 @@ namespace oox::ppt {
TimeNodePtr pNode = std::make_shared(nNodeType);
maList.push_back( pNode );
-FragmentHandler2 * pContext = TimeNodeContext::makeContext( *this,
aElementToken, rAttribs.getFastAttributeList(), pNode );
+rtl::Reference pContext =
TimeNodeContext::makeContext( *this, aElementToken,
rAttribs.getFastAttributeList(), pNode );
return pContext ? pContext : this;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/uielement/toolbarmerger.hxx |2 framework/source/accelerators/acceleratorconfiguration.cxx |8 -- framework/source/accelerators/documentacceleratorconfiguration.cxx |4 - framework/source/accelerators/moduleacceleratorconfiguration.cxx |4 - framework/source/dispatch/dispatchinformationprovider.cxx |6 - framework/source/dispatch/dispatchprovider.cxx | 30 +--- framework/source/fwe/xml/menudocumenthandler.cxx | 13 +-- framework/source/fwe/xml/saxnamespacefilter.cxx|3 framework/source/fwe/xml/statusbardocumenthandler.cxx |8 -- framework/source/fwe/xml/toolboxdocumenthandler.cxx|8 -- framework/source/fwi/uielement/constitemcontainer.cxx |5 - framework/source/fwi/uielement/itemcontainer.cxx |5 - framework/source/fwi/uielement/rootitemcontainer.cxx |5 - framework/source/helper/ocomponentaccess.cxx |3 framework/source/helper/statusindicatorfactory.cxx |8 -- framework/source/layoutmanager/layoutmanager.cxx |4 - framework/source/loadenv/loadenv.cxx | 16 +--- framework/source/services/desktop.cxx | 17 +--- framework/source/services/frame.cxx| 27 ++- framework/source/services/modulemanager.cxx|5 - framework/source/services/taskcreatorsrv.cxx | 15 +--- framework/source/uiconfiguration/globalsettings.cxx|5 - framework/source/uiconfiguration/imagemanagerimpl.cxx | 35 -- framework/source/uiconfiguration/windowstateconfiguration.cxx |4 - framework/source/uielement/addonstoolbarwrapper.cxx|4 - framework/source/uielement/menubarmanager.cxx |8 +- framework/source/uielement/menubarwrapper.cxx |8 -- framework/source/uielement/progressbarwrapper.cxx |4 - framework/source/uielement/statusbarmanager.cxx| 10 +- framework/source/uielement/statusbarwrapper.cxx|6 - framework/source/uielement/toolbarmanager.cxx |2 framework/source/uielement/toolbarmerger.cxx |4 - framework/source/uielement/toolbarwrapper.cxx |4 - framework/source/uielement/uicommanddescription.cxx|8 -- framework/source/uifactory/addonstoolbarfactory.cxx|7 -- framework/source/xml/acceleratorconfigurationwriter.cxx| 11 +-- framework/source/xml/imagesdocumenthandler.cxx | 13 +-- 37 files changed, 128 insertions(+), 201 deletions(-) New commits: commit 897970cd0b9709258b6b5b5fc05dba2e74a72b7c Author: Noel AuthorDate: Sun Feb 21 13:32:15 2021 +0200 Commit: Noel Grandin CommitDate: Sun Feb 21 16:11:48 2021 +0100 loplugin:refcounting in framework Change-Id: I2d7d14fe0335689e4a338c70587bf33137ed1ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111279 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/framework/inc/uielement/toolbarmerger.hxx b/framework/inc/uielement/toolbarmerger.hxx index b62e3be6972c..bd07bb17e7e4 100644 --- a/framework/inc/uielement/toolbarmerger.hxx +++ b/framework/inc/uielement/toolbarmerger.hxx @@ -115,7 +115,7 @@ class ToolBarMerger ToolBox::ImplToolItems::size_type nPos, const OUString& rMergeCommandParameter ); -static ::cppu::OWeakObject* CreateController( +static rtl::Reference<::cppu::OWeakObject> CreateController( const css::uno::Reference< css::uno::XComponentContext > & rxContext, const css::uno::Reference< css::frame::XFrame > & xFrame, ToolBox*pToolbar, diff --git a/framework/source/accelerators/acceleratorconfiguration.cxx b/framework/source/accelerators/acceleratorconfiguration.cxx index 96c0056d35c0..821b1137259c 100644 --- a/framework/source/accelerators/acceleratorconfiguration.cxx +++ b/framework/source/accelerators/acceleratorconfiguration.cxx @@ -384,14 +384,12 @@ void XMLBasedAcceleratorConfiguration::impl_ts_load(const css::uno::Reference< c // Note: Use special filter object between parser and reader // to get filtered xml with right namespaces ... // Use further a temp cache for reading! -AcceleratorConfigurationReader*pReader = new AcceleratorConfigurationReader(m_aReadCache); -css::uno::Reference< css::xml::sax::XDocumentHandler > xReader (static_cast< ::cppu::OWeakObject* >(pReader), css::uno::UNO_QUERY_THROW); -SaxNamespaceFilter*
[Libreoffice-commits] core.git: filter/source
filter/source/config/cache/basecontainer.cxx |6 +--
filter/source/config/cache/filterfactory.cxx |3 -
filter/source/msfilter/eschesdo.cxx |2 -
filter/source/svg/svgexport.cxx | 10 -
filter/source/svg/svgfilter.cxx |1
filter/source/svg/svgfilter.hxx |2 -
filter/source/t602/t602filter.cxx|2 -
filter/source/t602/t602filter.hxx|3 +
filter/source/xsltdialog/typedetectionexport.cxx | 39 ++-
filter/source/xsltdialog/typedetectionimport.cxx |6 +--
filter/source/xsltfilter/XSLTFilter.cxx | 19 +--
11 files changed, 38 insertions(+), 55 deletions(-)
New commits:
commit 6b6f9fb71fa1bfcb438b89596e6f19529cfe1eba
Author: Noel
AuthorDate: Sun Feb 21 13:33:30 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Feb 21 16:11:14 2021 +0100
loplugin:refcounting in filter
Change-Id: I77323376b7a2b04e50bf3017c00a0eea566da37d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111281
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/filter/source/config/cache/basecontainer.cxx
b/filter/source/config/cache/basecontainer.cxx
index 4f7b4f04ca49..71eb4f931399 100644
--- a/filter/source/config/cache/basecontainer.cxx
+++ b/filter/source/config/cache/basecontainer.cxx
@@ -353,8 +353,7 @@ css::uno::Reference< css::container::XEnumeration >
SAL_CALL BaseContainer::crea
{
OSL_FAIL("not pure virtual ... but not really implemented .-)");
-::comphelper::OEnumerationByName* pEnum = new
::comphelper::OEnumerationByName(this, css::uno::Sequence< OUString >());
-return css::uno::Reference< css::container::XEnumeration >(static_cast<
css::container::XEnumeration* >(pEnum), css::uno::UNO_QUERY);
+return new ::comphelper::OEnumerationByName(this, css::uno::Sequence<
OUString >());
}
@@ -398,8 +397,7 @@ css::uno::Reference< css::container::XEnumeration >
SAL_CALL BaseContainer::crea
instead of checking of NULL returns! */
css::uno::Sequence< OUString > lSubSet =
comphelper::containerToSequence(lKeys);
-::comphelper::OEnumerationByName* pEnum = new
::comphelper::OEnumerationByName(this, lSubSet);
-return css::uno::Reference< css::container::XEnumeration >(static_cast<
css::container::XEnumeration* >(pEnum), css::uno::UNO_QUERY);
+return new ::comphelper::OEnumerationByName(this, lSubSet);
}
diff --git a/filter/source/config/cache/filterfactory.cxx
b/filter/source/config/cache/filterfactory.cxx
index fa26ee7ba580..e499b4bad633 100644
--- a/filter/source/config/cache/filterfactory.cxx
+++ b/filter/source/config/cache/filterfactory.cxx
@@ -182,8 +182,7 @@ css::uno::Reference< css::container::XEnumeration >
SAL_CALL FilterFactory::crea
// Attention: Do not return empty reference for empty list!
// The outside check "hasMoreElements()" should be enough, to detect this
state :-)
css::uno::Sequence< OUString > lSet =
comphelper::containerToSequence(lEnumSet);
-::comphelper::OEnumerationByName* pEnum = new
::comphelper::OEnumerationByName(this, lSet);
-return css::uno::Reference< css::container::XEnumeration >(static_cast<
css::container::XEnumeration* >(pEnum), css::uno::UNO_QUERY);
+return new ::comphelper::OEnumerationByName(this, lSet);
}
diff --git a/filter/source/msfilter/eschesdo.cxx
b/filter/source/msfilter/eschesdo.cxx
index d2c85672ca05..7df0a58f7aa4 100644
--- a/filter/source/msfilter/eschesdo.cxx
+++ b/filter/source/msfilter/eschesdo.cxx
@@ -861,7 +861,7 @@ ImplEESdrWriter::~ImplEESdrWriter()
bool ImplEESdrWriter::ImplInitPage( const SdrPage& rPage )
{
-SvxDrawPage* pSvxDrawPage;
+rtl::Reference pSvxDrawPage;
if ( mpSdrPage != || !mXDrawPage.is() )
{
// eventually write SolverContainer of current page, deletes the Solver
diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index a33fb46f1980..e35a42746216 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -575,10 +575,6 @@ bool SVGFilter::implExportImpressOrDraw( const Reference<
XOutputStream >& rxOSt
// mpSVGExport = new SVGExport( xDocHandler );
mpSVGExport = new SVGExport( xContext, xDocHandler,
maFilterData );
-// xKeepAlive is set up only to manage the life-time of the
object pointed by mpSVGExport,
-// and in order to prevent that it is destroyed when passed to
AnimationExporter.
-Reference< XInterface > xKeepAlive = static_cast<
css::document::XFilter* >( mpSVGExport );
-
// create an id for each draw page
for( const auto& rPage : mSelectedPages )
implRegisterInterface( rPage );
@@ -664,10 +660,6 @@ bool SVGFilter::implExportWriterOrCalc( const Reference<
XOutputStream >& rxOStm
// mpSVGExport =
[Libreoffice-commits] core.git: forms/source
forms/source/component/DatabaseForm.cxx |4 +---
forms/source/component/FormComponent.cxx |4
forms/source/component/FormattedField.cxx |9 -
forms/source/component/FormattedField.hxx |1 +
forms/source/component/FormattedFieldWrapper.cxx | 19 +++
forms/source/component/FormsCollection.cxx|7 +++
forms/source/component/Grid.cxx |6 ++
forms/source/component/clickableimage.cxx |2 +-
forms/source/component/navigationbar.hxx |1 -
forms/source/inc/FormComponent.hxx|4 ++--
forms/source/richtext/richtextcontrol.cxx |6 +++---
forms/source/richtext/richtextmodel.cxx |2 +-
forms/source/richtext/richtextmodel.hxx |2 --
forms/source/xforms/binding.cxx |5 ++---
forms/source/xforms/model_ui.cxx |6 +++---
forms/source/xforms/submission.cxx| 15 ++-
forms/source/xforms/submission/replace.cxx|5 +++--
forms/source/xforms/submission/submission_get.cxx |4 ++--
18 files changed, 41 insertions(+), 61 deletions(-)
New commits:
commit 7ffb71e759e5d29a505188d1cbf506dd57383a4a
Author: Noel
AuthorDate: Sun Feb 21 13:33:00 2021 +0200
Commit: Noel Grandin
CommitDate: Sun Feb 21 16:10:51 2021 +0100
loplugin:refcounting in forms
Change-Id: I19d67e54f77e354eaddaaa7de1f3e22c2b7cdbf6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111280
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/DatabaseForm.cxx
b/forms/source/component/DatabaseForm.cxx
index 066eeb45e293..7411abf90351 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -1373,10 +1373,8 @@ void SAL_CALL ODatabaseForm::clearWarnings( )
Reference< XCloneable > SAL_CALL ODatabaseForm::createClone( )
{
-ODatabaseForm* pClone = new ODatabaseForm( *this );
-osl_atomic_increment( >m_refCount );
+rtl::Reference pClone = new ODatabaseForm( *this );
pClone->clonedFrom( *this );
-osl_atomic_decrement( >m_refCount );
return pClone;
}
diff --git a/forms/source/component/FormComponent.cxx
b/forms/source/component/FormComponent.cxx
index 8b3047cc176b..e2a6a582ed31 100644
--- a/forms/source/component/FormComponent.cxx
+++ b/forms/source/component/FormComponent.cxx
@@ -1137,7 +1137,6 @@ OBoundControlModel::OBoundControlModel(
,m_aUpdateListeners(m_aMutex)
,m_aFormComponentListeners( m_aMutex )
,m_bInputRequired( false )
-,m_pAggPropMultiplexer( nullptr )
,m_bFormListening( false )
,m_bLoaded(false)
,m_bRequired(false)
@@ -1170,7 +1169,6 @@ OBoundControlModel::OBoundControlModel(
,m_aFormComponentListeners( m_aMutex )
,m_xValidator( _pOriginal->m_xValidator )
,m_bInputRequired( false )
-,m_pAggPropMultiplexer( nullptr )
,m_bFormListening( false )
,m_bLoaded( false )
,m_bRequired( false )
@@ -1214,7 +1212,6 @@ OBoundControlModel::~OBoundControlModel()
if ( m_pAggPropMultiplexer )
{
m_pAggPropMultiplexer->dispose();
-m_pAggPropMultiplexer->release();
m_pAggPropMultiplexer = nullptr;
}
}
@@ -1244,7 +1241,6 @@ void OBoundControlModel::implInitAggMultiplexer( )
if ( m_xAggregateSet.is() )
{
m_pAggPropMultiplexer = new OPropertyChangeMultiplexer( this,
m_xAggregateSet, false );
-m_pAggPropMultiplexer->acquire();
}
osl_atomic_decrement( _refCount );
diff --git a/forms/source/component/FormattedField.cxx
b/forms/source/component/FormattedField.cxx
index ed2f748fb7cd..74e6aaf08e01 100644
--- a/forms/source/component/FormattedField.cxx
+++ b/forms/source/component/FormattedField.cxx
@@ -72,7 +72,7 @@ namespace frm
{
namespace {
-class StandardFormatsSupplier : protected SvNumberFormatsSupplierObj, public
::utl::ITerminationListener
+class StandardFormatsSupplier : public SvNumberFormatsSupplierObj, public
::utl::ITerminationListener
{
protected:
std::unique_ptr m_pMyPrivateFormatter;
@@ -113,8 +113,7 @@ Reference< XNumberFormatsSupplier >
StandardFormatsSupplier::get( const Referenc
// get the Office's locale
eSysLanguage = SvtSysLocale().GetLanguageTag().getLanguageType( false);
}
-StandardFormatsSupplier* pSupplier = new StandardFormatsSupplier( _rxORB,
eSysLanguage );
-Reference< XNumberFormatsSupplier > xNewlyCreatedSupplier( pSupplier );
+rtl::Reference pSupplier = new
StandardFormatsSupplier( _rxORB, eSysLanguage );
{
::osl::MutexGuard aGuard( ::osl::Mutex::getGlobalMutex() );
Reference< XNumberFormatsSupplier > xSupplier =
s_xDefaultFormatsSupplier;
@@ -122,9 +121,9 @@ Reference< XNumberFormatsSupplier >
StandardFormatsSupplier::get( const Referenc
// somebody used the small time frame
[Libreoffice-bugs] [Bug 140566] Bug in Impress on Plasma Deskop with 2 monitors
https://bugs.documentfoundation.org/show_bug.cgi?id=140566 --- Comment #2 from giors...@yahoo.it --- LibreOffice fresh from arch repo. Today also noted some unpleasant interaction between writer (opened on screen 1) and impress (screen 2) on gnome 3.38. It's something minor but I cannot explain myself why touching screen 1 should affect what happends on screen 2 (and viceversa). Tried with and without hardware acceleration (switched on and off). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140077] Fatal Error after insert a new line by Enter (std::bad_array_new_length)
https://bugs.documentfoundation.org/show_bug.cgi?id=140077
--- Comment #8 from Dave Gilbert ---
for me in 7.x head 130a866a2e289d78a680a57c0cdf84e7dd17d285
it's hanging rather than crashing as such; it's getting stuck in
CountCJKCharacters:
while ( nPos < nEnd )
{
nPos = TextFrameIndex(g_pBreakIt->GetBreakIter()->nextCharacters(
rText, sal_Int32(nPos),
rLocale,
i18n::CharacterIteratorMode::SKIPCELL, 1, nDone));
nCount++;
}
SwTextPaintInfo::DrawBackBrush entry: 0x577cc10
lcl_AddSpace: (!pStr) nPos=23 nEnd=26
SwScriptInfo::CountCJKCharacters '承包人(全称)： 重庆钢铁集团建设工程有限公司' nPos: 23 nEnd: 26
SwScriptInfo::CountCJKCharacters loop bottom: nPos: 23 nEnd: 26 nDone: 0
nCount: 1
SwScriptInfo::CountCJKCharacters loop bottom: nPos: 23 nEnd: 26 nDone: 0
nCount: 2
SwScriptInfo::CountCJKCharacters loop bottom: nPos: 23 nEnd: 26 nDone: 0
nCount: 3
SwScriptInfo::CountCJKCharacters loop bottom: nPos: 23 nEnd: 26 nDone: 0
nCount: 4
so nextCharacters is always giving the same answer
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||140566 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140566 [Bug 140566] Bug in Impress on Plasma Deskop with 2 monitors -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140566] Bug in Impress on Plasma Deskop with 2 monitors
https://bugs.documentfoundation.org/show_bug.cgi?id=140566 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||79045_79...@mail.ru Blocks||102495 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Do you use LibreOffice from Arch repo or from LibreOffice official site? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102495 [Bug 102495] [META] KDE VCL backend bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35033] Allow inline graphics, formulas in impress (and draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=35033 --- Comment #30 from dante19031...@gmail.com --- > @rafael lima, @dante19031...@gmail.com > > > Wouldn't it be easier to allow users to add a "Writer" text object into the > > presentation? It won't work. You can't insert an OLE inside an OLE. It won't let you. Even inserting symbols doesn't work in OLE mode (at least until 7, have no checked after). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140535] equation sign '=' is not printed
https://bugs.documentfoundation.org/show_bug.cgi?id=140535 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #3 from m.a.riosv --- Can't reproduce with: Version: 6.4.7.2 (x64) Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: default; VCL: win; Locale: es-ES (es_ES); UI-Language: en-US Calc: CL Version: 7.1.2.0.0+ (x64) / LibreOffice Community Build ID: e8a598aae891a4789e770566b87e11a47015c530 CPU threads: 4; OS: Windows 10.0 Build 21296; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL Please test with a clean profile Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/transobj.cxx|9 +
sc/source/ui/docshell/docsh2.cxx |7 +--
sc/source/ui/docshell/docsh3.cxx |8
3 files changed, 14 insertions(+), 10 deletions(-)
New commits:
commit 6dccc6b54e4bb13f765d494bcdcdd782fa11fe38
Author: Mike Kaganski
AuthorDate: Sun Feb 21 12:03:49 2021 +0300
Commit: Mike Kaganski
CommitDate: Sun Feb 21 15:01:50 2021 +0100
Some more unit conversion unification
Change-Id: Id000613426eb5a0159f44419446cad1f3d7f1845
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111282
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index b83a085d5c08..ad6e01df42e1 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -23,6 +23,7 @@
#include
#include
+#include
#include
#include
#include
@@ -769,8 +770,8 @@ void ScTransferObj::InitDocShell(bool bLimitToPageSize)
for (nCol=0; nCol( nPosX * HMM_PER_TWIPS );
-nPosY = static_cast( nPosY * HMM_PER_TWIPS );
+nPosX = o3tl::convert(nPosX, o3tl::Length::twip, o3tl::Length::mm100);
+nPosY = o3tl::convert(nPosY, o3tl::Length::twip, o3tl::Length::mm100);
aPaperSize.setWidth( aPaperSize.Width() * 2 ); // limit OLE object
to double of page size
aPaperSize.setHeight( aPaperSize.Height() * 2 );
@@ -791,8 +792,8 @@ void ScTransferObj::InitDocShell(bool bLimitToPageSize)
break;
nSizeY += nAdd;
}
-nSizeX = static_cast( nSizeX * HMM_PER_TWIPS );
-nSizeY = static_cast( nSizeY * HMM_PER_TWIPS );
+nSizeX = o3tl::convert(nSizeX, o3tl::Length::twip, o3tl::Length::mm100);
+nSizeY = o3tl::convert(nSizeY, o3tl::Length::twip, o3tl::Length::mm100);
// pDocSh->SetVisAreaSize( Size(nSizeX,nSizeY) );
diff --git a/sc/source/ui/docshell/docsh2.cxx b/sc/source/ui/docshell/docsh2.cxx
index 0c8da05362b0..e02b815d2181 100644
--- a/sc/source/ui/docshell/docsh2.cxx
+++ b/sc/source/ui/docshell/docsh2.cxx
@@ -26,6 +26,7 @@
#include
#include
#include
+#include
#include
#include
@@ -46,8 +47,10 @@ bool ScDocShell::InitNew( const uno::Reference <
embed::XStorage >& xStor )
// Additional tables are created by the first View, if bIsEmpty is still
sal_True
if( bRet )
{
-Size aSize( tools::Long( STD_COL_WIDTH * HMM_PER_TWIPS *
OLE_STD_CELLS_X ),
-static_cast( ScGlobal::nStdRowHeight *
HMM_PER_TWIPS * OLE_STD_CELLS_Y ) );
+Size aSize(
+o3tl::convert(STD_COL_WIDTH * OLE_STD_CELLS_X, o3tl::Length::twip,
o3tl::Length::mm100),
+o3tl::convert(ScGlobal::nStdRowHeight * OLE_STD_CELLS_Y,
o3tl::Length::twip,
+ o3tl::Length::mm100));
// Also adjust start here
SetVisAreaOrSize( tools::Rectangle( Point(), aSize ) );
}
diff --git a/sc/source/ui/docshell/docsh3.cxx b/sc/source/ui/docshell/docsh3.cxx
index a31d73e5802c..37e1bc773859 100644
--- a/sc/source/ui/docshell/docsh3.cxx
+++ b/sc/source/ui/docshell/docsh3.cxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -367,7 +368,6 @@ void ScDocShell::CalcOutputFactor()
OUString aTestString(
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz01234567890123456789");
tools::Long nPrinterWidth = 0;
-tools::Long nWindowWidth = 0;
const ScPatternAttr* pPattern =
_aDocument.GetPool()->GetDefaultItem(ATTR_PATTERN);
vcl::Font aDefFont;
@@ -386,11 +386,11 @@ void ScDocShell::CalcOutputFactor()
pVirtWindow->SetMapMode(MapMode(MapUnit::MapPixel));
pPattern->GetFont(aDefFont, SC_AUTOCOL_BLACK, pVirtWindow);// font
color doesn't matter here
pVirtWindow->SetFont(aDefFont);
-nWindowWidth = pVirtWindow->GetTextWidth(aTestString);
-nWindowWidth = static_cast( nWindowWidth /
ScGlobal::nScreenPPTX * HMM_PER_TWIPS );
+double nWindowWidth = pVirtWindow->GetTextWidth(aTestString) /
ScGlobal::nScreenPPTX;
+nWindowWidth = o3tl::convert(nWindowWidth, o3tl::Length::twip,
o3tl::Length::mm100);
if (nPrinterWidth && nWindowWidth)
-m_nPrtToScreenFactor = nPrinterWidth /
static_cast(nWindowWidth);
+m_nPrtToScreenFactor = nPrinterWidth / nWindowWidth;
else
{
OSL_FAIL("GetTextSize returns 0 ??");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140581] Mark the page gutter area in the preview in the page layout dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=140581 Regina Henschel changed: What|Removed |Added Blocks||140575 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140575 [Bug 140575] [META] Gutter margin bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140575] [META] Gutter margin bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=140575 Regina Henschel changed: What|Removed |Added Depends on||140581 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140581 [Bug 140581] Mark the page gutter area in the preview in the page layout dialog -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140581] New: Mark the page gutter area in the preview in the page layout dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=140581 Bug ID: 140581 Summary: Mark the page gutter area in the preview in the page layout dialog Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 169941 --> https://bugs.documentfoundation.org/attachment.cgi?id=169941=edit Screenshot of page layout dialog in Word Word indicates the page gutter area in the preview on the page layout dialog, see attached screenshot. I think, that is a good idea and LibreOffice should show the page gutter margin area in a similar way in the preview. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 114783] Display size of document on a HDMI attached Monitor is more than twice the expected size
https://bugs.documentfoundation.org/show_bug.cgi?id=114783 --- Comment #11 from Uwe Altmann --- Still present on 7.0.4 (7.1 not working properly on recent MacOS, c.f. Bug 128233). What has changed is that by now also the internal monitor of a MacBook Air is affected (setting as described earlier): Internal Monitor: 10 cm line gets 15,6 cm external HDMI Monitor: 10 cm line gets 22,0 cm -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1473244: Error handling issues (CHECKED_RETURN)
/extensions/source/bibliography/general.cxx: 347 in
BibGeneralPage::LastElementKeyInputHdl(const KeyEvent &)()
*** CID 1473244: Error handling issues (CHECKED_RETURN)
/extensions/source/bibliography/general.cxx: 347 in
BibGeneralPage::LastElementKeyInputHdl(const KeyEvent &)()
341 {
342 uno::Reference
xUpdateCursor(xRowSet, UNO_QUERY);
343 if (xUpdateCursor.is())
344 xUpdateCursor->moveToInsertRow();
345 }
346 else
>>> CID 1473244: Error handling issues (CHECKED_RETURN)
>>> Calling "next" without checking return value (as is done elsewhere 182
>>> out of 188 times).
347 xRowSet->next();
348 }
349 xIdentifierED->grab_focus();
350 xIdentifierED->select_region(0, -1);
351 GainFocusHdl(*xIdentifierED);
352 return true;
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DUP7T_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi7IwFZ9-2FtTEHkQyuINYc-2FK4zOK-2FFWFtZ3o4NfdIX92Sp1q9FbCPaZjCxTXRsVwk97ka-2B3nUwd-2FNSKqS1HIPGuxPj4caymQz0IM-2FK1PSYl00iTbP7P14TaZOmpM-2Fp4GfxhowNsoRyuWZ1FFYxFte4eCxNFEp9lqyAB44dKTrSunhXmxMsx83Ua-2FopBRRW2Ket-2F
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 140561] wrong term for gutter position in mirrored page layout
https://bugs.documentfoundation.org/show_bug.cgi?id=140561 --- Comment #1 from Regina Henschel --- Besides the wrong term, it should be considered to disable the position field at all in case of "Mirrored" page layout. A position "Top" makes no sense. A "Mirrored" page layout is designed to have the gutter always in the middle, at the inside margins. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35033] Allow inline graphics, formulas in impress (and draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=35033 Jean-Baptiste Faure changed: What|Removed |Added CC||jbfa...@libreoffice.org Version|unspecified |Inherited From OOo Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140206] Inconsistent layout changes when changing anchoring and undo part of them
https://bugs.documentfoundation.org/show_bug.cgi?id=140206 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #3 from Dieter --- (In reply to Telesto from comment #0) > Steps to Reproduce: > 1. Open attachment 163564 [details] > 2. Change anchor from figure 2 to 'to character' -> Figure 3 goes to page 2 I confirm that. A new paragraph is added. I would consider this as a bug, but that might be a different one. > 3. Select figure 3 and change anchor to 'to paragraph' -> figure moves up to > page 1 I can't confirm that > 4. Undo -> Figure 2 still on page 1 Undo works as expected. Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 28555fc345ac2ccdda0e4e0f3c812c646befe68b CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83670] color gradient (cell background) not displayed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=83670 --- Comment #13 from ao thuat --- When life gives you a hundred reasons to cry, show life that you have a thousand reasons to smile https://nytimes-spellingbee.com/;>nytimes spelling bee -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83670] color gradient (cell background) not displayed correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=83670 --- Comment #12 from ao thuat --- don't be sad or don't rush to sleep, come with us https://nytimes-spellingbee.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108911] Cannot toggle cursor focus between formula and worksheet
https://bugs.documentfoundation.org/show_bug.cgi?id=108911 Noah Glenn changed: What|Removed |Added Version|5.3.4.2 release |7.1.0.3 release --- Comment #9 from Noah Glenn --- This problem is still present. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #3 from Colin --- (In reply to Colin from comment #0) > Copy A7:A9 > PasteSpecial to G7:G9 > PasteSpecial to H7:H9 < Should of course say Paste to H7:H9 as it's supposed to be a comparison between paste and pastespecial -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140251] Unable to insert character using Unicode code with Ctrl-Shift-U (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=140251 --- Comment #7 from Petr Valach --- (In reply to Buovjaga from comment #6) > Ok, let's close. Also, this works just fine with kf5: > > 1. Type the code > 2. Press Alt-X > > The name of the function is "Toggle Unicode Notation", > .uno:UnicodeNotationToggle Fantastic, it works! It's not so comfort as using standard input way (user must install fcitx) but it works. If there problem to support Unicode input in LO, I understand and close this bug. Thank you very much. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102495] [META] KDE VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 140251, which changed state. Bug 140251 Summary: Unable to insert character using Unicode code with Ctrl-Shift-U (kf5) https://bugs.documentfoundation.org/show_bug.cgi?id=140251 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140251] Unable to insert character using Unicode code with Ctrl-Shift-U (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=140251 Buovjaga changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #6 from Buovjaga --- (In reply to Petr Valach from comment #5) > (In reply to Buovjaga from comment #4) > > (In reply to Jan-Marek Glogowski from comment #3) > > > I'm not sure this is a good idea to be implemented in the VCL / qt5 > > > backend. > > > You can install fcitx or ibus, which both support unicode input (fcitx via > > > Ctrl+Alt+Shift+u / configurable shortcut). Then it will work with all Qt > > > applications, not just LO. > > > > Petr: what do you think about this? Do you still want to keep this open? > > If there is workaround using fcitx then it's ok for me. Anyway, I spent many > times yesterday and didn't understand how it works. But there is my problem > (rather bad documentation), not LO. Ok, let's close. Also, this works just fine with kf5: 1. Type the code 2. Press Alt-X The name of the function is "Toggle Unicode Notation", .uno:UnicodeNotationToggle -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140251] Unable to insert character using Unicode code with Ctrl-Shift-U (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=140251 --- Comment #5 from Petr Valach --- (In reply to Buovjaga from comment #4) > (In reply to Jan-Marek Glogowski from comment #3) > > I'm not sure this is a good idea to be implemented in the VCL / qt5 backend. > > You can install fcitx or ibus, which both support unicode input (fcitx via > > Ctrl+Alt+Shift+u / configurable shortcut). Then it will work with all Qt > > applications, not just LO. > > Petr: what do you think about this? Do you still want to keep this open? If there is workaround using fcitx then it's ok for me. Anyway, I spent many times yesterday and didn't understand how it works. But there is my problem (rather bad documentation), not LO. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140117] EDITING Retain turned off first/left/right headers
https://bugs.documentfoundation.org/show_bug.cgi?id=140117 Dieter changed: What|Removed |Added Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| --- Comment #5 from Dieter --- I confirm the described behaviour, but for me this is also the expectd behaviour. So I agree, that this is an enhancement request. CC: Design-Team for further input and decision -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140117] EDITING Retain turned off first/left/right headers
https://bugs.documentfoundation.org/show_bug.cgi?id=140117 Dieter changed: What|Removed |Added Keywords||needsUXEval CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| --- Comment #5 from Dieter --- I confirm the described behaviour, but for me this is also the expectd behaviour. So I agree, that this is an enhancement request. CC: Design-Team for further input and decision -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #2 from Colin --- I should also mention that the original data - 17:21 - was pasted in a batch of 250 records with [ALT][CTRL][SHFT]"V" to force the copying of unformatted text into all the cells of the target sheet. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 --- Comment #1 from Colin --- Created attachment 169940 --> https://bugs.documentfoundation.org/attachment.cgi?id=169940=edit Simple .ods with examples -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140580] New: Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG
https://bugs.documentfoundation.org/show_bug.cgi?id=140580 Bug ID: 140580 Summary: Calc Editing Paste Special Values changes the pasted data to the assigned Autoformat NOT WYSIWYG Product: LibreOffice Version: 7.0.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: Sample file attached. If text signifying a time (17:21) is copied and pasted special into a cell with either a time or number format then the pasted data becomes 0.722916*. If the same clipboard contents are simply pasted into non-formatted cells then it pastes the format which is automatically assigned by the editor to the original cells. >From sample:- Observe the values in A7:A9 Observe the format of C7:C9 Observe the format of E7:E9 If you wish to test the reality then simply:- format say G7:G9 and H7:H9 in identical formats to C7:C9 & E7:E9 - NOTE: E7:E9 were originally formatted as text but paste reformats them according to its own autoformat criteria Copy A7:A9 PasteSpecial to G7:G9 PasteSpecial to H7:H9 This issue became apparent after pasting a simple text message stating 17:21 - which was a bus departure time - into a spreadsheet register of SMSs. Message dates and times were correctly interpreted but the conversion of 17:21 in a predefined text field to 0,72291666* was a bit of a surprise. Steps to Reproduce: If you wish to test the reality then simply:- format say G7:G9 and H7:H9 in identical formats to C7:C9 & E7:E9 - NOTE: E7:E9 were originally formatted as text but paste reformats them according to its own autoformat criteria Copy A7:A9 PasteSpecial to G7:G9 PasteSpecial to H7:H9 Actual Results: Original text first converted to a time format in the opening cells (A7:A9) and then reformatted to decimal formats in the paste special cells C8:C9) and autoformatted in paste cells Expected Results: In old money WYSIWYG BUT in many - NOT ALL - circumstances the autoformatting to realistic date and time formats would not be amiss. It may be considered that C9 should indeed be a decimal representation but arguably, only when the user had defined the source cell as a number, NOT when it was originally defined as text. I feel it's potentially a catch 22 situation. Is the anticipation of the time formats generally more acceptable than a true representation of the underlying data? Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125768] Can't move paragraph with Ctrl+Alt+Arrow
https://bugs.documentfoundation.org/show_bug.cgi?id=125768 --- Comment #12 from Dieter --- (In reply to Jukka from comment #11) > Created attachment 169926 [details] > Simple test-file > > I want to reorder first lines with shortcut keys. Works fine for me with Strg+ALT+ARROW (just put cursor inside the paragraph. It's not necessary to mark them. If that doesn't work, please have a look at Tools => Customise => Keyboard and search for "Move Down" and "Move up" For further questions please use ask.libreoffice.org, because Bugzilla is a tool for QA and not for individual support. Thank you. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139912] ContinuePreviousNumbering fails
https://bugs.documentfoundation.org/show_bug.cgi?id=139912 Dieter changed: What|Removed |Added Blocks||103369 --- Comment #5 from Dieter --- (In reply to TorrAB from comment #4) > Yes. But, why does Continue previous numbering not work? Good question. It's not clear to me, how this command should work at all. Therefore I've opened bug 140579. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103369 [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103369 Dieter changed: What|Removed |Added Depends on||139912 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139912 [Bug 139912] ContinuePreviousNumbering fails -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
