[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - desktop/source
desktop/source/lib/init.cxx | 13 +
1 file changed, 13 insertions(+)
New commits:
commit 91aaa36286208791327aaa28460374942a237dc6
Author: Henry Castro
AuthorDate: Fri Mar 5 19:53:51 2021 -0400
Commit: Szymon Kłos
CommitDate: Tue Mar 9 11:12:25 2021 +0100
lok: add "MacroSecurityLevel" option
Change-Id: I1cf4e6d4495c552b94c6fe80333291fc4ab20936
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112043
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Szymon Kłos
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 81b15d4b4fa4..a3ea934e9ebf 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -143,6 +143,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -2274,6 +2275,18 @@ static LibreOfficeKitDocument*
lo_documentLoadWithOptions(LibreOfficeKit* pThis,
aFilterOptions[1].Name = "InteractionHandler";
aFilterOptions[1].Value <<= xInteraction;
+int nMacroSecurityLevel = 1;
+const OUString aMacroSecurityLevel = extractParameter(aOptions,
"MacroSecurityLevel");
+if (!aMacroSecurityLevel.isEmpty())
+{
+double nNumber;
+sal_uInt32 nFormat = 1;
+SvNumberFormatter
aFormatter(::comphelper::getProcessComponentContext(), LANGUAGE_ENGLISH_US);
+if (aFormatter.IsNumberFormat(aMacroSecurityLevel, nFormat,
nNumber))
+nMacroSecurityLevel = static_cast(nNumber);
+}
+SvtSecurityOptions().SetMacroSecurityLevel(nMacroSecurityLevel);
+
const OUString aEnableMacrosExecution = extractParameter(aOptions,
"EnableMacrosExecution");
sal_Int16 nMacroExecMode = aEnableMacrosExecution == "true" ?
document::MacroExecMode::USE_CONFIG :
document::MacroExecMode::NEVER_EXECUTE;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/inc sc/source
sc/inc/segmenttree.hxx |9 +
sc/source/core/data/segmenttree.cxx | 32
sc/source/core/data/table1.cxx |5 +
3 files changed, 46 insertions(+)
New commits:
commit 2fb274950e5207ca55f4f52325fb522bd44024e1
Author: Luboš Luňák
AuthorDate: Mon Mar 8 22:50:58 2021 +0100
Commit: Luboš Luňák
CommitDate: Tue Mar 9 11:12:25 2021 +0100
fix ScFlatBoolSegmentsImpl delayed setup with threads (tdf#140754)
Change-Id: I258263f6a15e7098a2292ba7f3336fcaaf5224ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112184
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/segmenttree.hxx b/sc/inc/segmenttree.hxx
index 58e59e60cd84..7e25d232a03f 100644
--- a/sc/inc/segmenttree.hxx
+++ b/sc/inc/segmenttree.hxx
@@ -77,6 +77,9 @@ public:
SCROW findLastTrue() const;
+// Builds internal data (so that it doesn't build them while used in
threads).
+void makeReady();
+
OString dumpAsString();
private:
@@ -102,6 +105,9 @@ public:
void removeSegment(SCCOL nCol1, SCCOL nCol2);
void insertSegment(SCCOL nCol, SCCOL nSize);
+// Builds internal data (so that it doesn't build them while used in
threads).
+void makeReady();
+
OString dumpAsString();
private:
@@ -153,6 +159,9 @@ public:
void enableTreeSearch(bool bEnable);
+// Builds internal data (so that it doesn't build them while used in
threads).
+void makeReady();
+
OString dumpAsString();
private:
diff --git a/sc/source/core/data/segmenttree.cxx
b/sc/source/core/data/segmenttree.cxx
index 4ccf146a01c3..d73d233d894c 100644
--- a/sc/source/core/data/segmenttree.cxx
+++ b/sc/source/core/data/segmenttree.cxx
@@ -23,6 +23,7 @@
#include
#include
#include
+#include
using ::std::numeric_limits;
@@ -65,6 +66,8 @@ public:
mbTreeSearchEnabled = b;
}
+void makeReady();
+
private:
typedef ::mdds::flat_segment_tree fst_type;
fst_type maSegments;
@@ -130,7 +133,10 @@ typename ScFlatSegmentsImpl::ValueType ScFlatSegments
}
if (!maSegments.is_tree_valid())
+{
+assert(!ScGlobal::bThreadedGroupCalcInProgress);
maSegments.build_tree();
+}
maSegments.search_tree(nPos, nValue);
return nValue;
@@ -184,7 +190,10 @@ bool ScFlatSegmentsImpl::getRangeData(SCCOLROW nPos,
return getRangeDataLeaf(nPos, rData);
if (!maSegments.is_tree_valid())
+{
+assert(!ScGlobal::bThreadedGroupCalcInProgress);
maSegments.build_tree();
+}
if (!maSegments.search_tree(nPos, rData.mnValue, ,
).second)
return false;
@@ -266,6 +275,14 @@ bool ScFlatSegmentsImpl::getNext(RangeData& rData)
return true;
}
+template
+void ScFlatSegmentsImpl::makeReady()
+{
+assert(!ScGlobal::bThreadedGroupCalcInProgress);
+if (!maSegments.is_tree_valid())
+maSegments.build_tree();
+}
+
class ScFlatUInt16SegmentsImpl : public ScFlatSegmentsImpl
{
public:
@@ -415,6 +432,11 @@ SCROW ScFlatBoolRowSegments::findLastTrue() const
return mpImpl->findLastTrue(false);
}
+void ScFlatBoolRowSegments::makeReady()
+{
+mpImpl->makeReady();
+}
+
OString ScFlatBoolRowSegments::dumpAsString()
{
OString aOutput;
@@ -482,6 +504,11 @@ void ScFlatBoolColSegments::insertSegment(SCCOL nCol,
SCCOL nSize)
mpImpl->insertSegment(static_cast(nCol),
static_cast(nSize), true/*bSkipStartBoundary*/);
}
+void ScFlatBoolColSegments::makeReady()
+{
+mpImpl->makeReady();
+}
+
OString ScFlatBoolColSegments::dumpAsString()
{
OString aOutput;
@@ -595,6 +622,11 @@ void ScFlatUInt16RowSegments::setValueIf(SCROW nRow1,
SCROW nRow2, sal_uInt16 nV
mpImpl->setValueIf(static_cast(nRow1),
static_cast(nRow2), nValue, rPredicate);
}
+void ScFlatUInt16RowSegments::makeReady()
+{
+mpImpl->makeReady();
+}
+
OString ScFlatUInt16RowSegments::dumpAsString()
{
OString aOutput;
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index 459f804984ed..f018bfc03d4d 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -2484,6 +2484,11 @@ bool ScTable::HandleRefArrayForParallelism( SCCOL nCol,
SCROW nRow1, SCROW nRow2
if ( !IsColValid( nCol ) || !ValidRow( nRow1 ) || !ValidRow( nRow2 ) )
return false;
+mpHiddenCols->makeReady();
+mpHiddenRows->makeReady();
+mpFilteredCols->makeReady();
+mpFilteredRows->makeReady();
+
return aCol[nCol].HandleRefArrayForParallelism(nRow1, nRow2, mxGroup);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - desktop/source
desktop/source/lib/init.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit d7aa69d3b3418f388518a726a44b6433b0586de9 Author: Henry Castro AuthorDate: Fri Mar 5 16:28:57 2021 -0400 Commit: Szymon Kłos CommitDate: Tue Mar 9 11:12:08 2021 +0100 lok: add "EnableMacrosExecution" option Change-Id: I2ad31e2e7f66fdfca1eee07622a4a9fec8b62861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112030 Reviewed-by: Szymon Kłos Tested-by: Szymon Kłos diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index af9c9ed1c41b..81b15d4b4fa4 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -2274,7 +2274,9 @@ static LibreOfficeKitDocument* lo_documentLoadWithOptions(LibreOfficeKit* pThis, aFilterOptions[1].Name = "InteractionHandler"; aFilterOptions[1].Value <<= xInteraction; -sal_Int16 nMacroExecMode = document::MacroExecMode::NEVER_EXECUTE; +const OUString aEnableMacrosExecution = extractParameter(aOptions, "EnableMacrosExecution"); +sal_Int16 nMacroExecMode = aEnableMacrosExecution == "true" ? document::MacroExecMode::USE_CONFIG : +document::MacroExecMode::NEVER_EXECUTE; aFilterOptions[2].Name = "MacroExecutionMode"; aFilterOptions[2].Value <<= nMacroExecMode; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 40427] Sections in Navigator are not listed in order of occurrence in document
https://bugs.documentfoundation.org/show_bug.cgi?id=40427 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #15 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/112197 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140910] Blank XLSX file generated with OpenXML SDK
https://bugs.documentfoundation.org/show_bug.cgi?id=140910 --- Comment #1 from JohnR --- Created attachment 170364 --> https://bugs.documentfoundation.org/attachment.cgi?id=170364=edit its a xlsx file with 5 rows File has 5 rows not readable by libre -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40427] Sections in Navigator are not listed in order of occurrence in document
https://bugs.documentfoundation.org/show_bug.cgi?id=40427 Mike Kaganski changed: What|Removed |Added OS|Linux (All) |All Hardware|x86-64 (AMD64) |All Ever confirmed|0 |1 Resolution|WORKSFORME |--- Status|RESOLVED|NEW --- Comment #14 from Mike Kaganski --- It is still here, and - as shown on the screenshot in attachment 50624 - depends on using multi-page view, having the position of the section in the Navigator dependent on its vertical position on screen. Tested with Version: 7.1.1.2 (x64) / LibreOffice Community Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676 CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140896] OpenOffice cannot read LO
https://bugs.documentfoundation.org/show_bug.cgi?id=140896 --- Comment #2 from Timur --- Bugzilla is for reporting bugs, please use ask.libreoffice.org for questions. This is for Aoo bug report, not Lo bug. Note that if you are testing Aoo, you should also check OO 3.3 to see if it worked there. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140896] OpenOffice cannot read LO
https://bugs.documentfoundation.org/show_bug.cgi?id=140896 Timur changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140145] Calc stops responding to keyboard
https://bugs.documentfoundation.org/show_bug.cgi?id=140145 --- Comment #8 from clearstar --- > Buovjaga: you have "VCL: x11", so you are using the fallback GUI backend That is a very keen observation - I was not aware of that. > You don't have the libreoffice-gtk3 package installed? Which desktop > environment are you running? I did not know that I do not have libreoffice-gtk3 installed. I am using the Cinnamon desktop environment, which is the default in the Debian distribution variant I am using. I have not customized this Debian much at all. The Debian package is: Debian package version: 1:7.0.4-3+gl0 I installed only Libreoffice calc, as: sudo apt-get install libreoffice-calc When I list what would be installed by the full libreoffice suite, it still does not include libreoffice-gtk3. I don't know why it is not included. I now manually installed libreoffice-gtk3, (via $ sudo apt-get install libreoffice-gtk3 ) and Libreoffice Calc correctly uses gtk3 and looks nicer. This probably bypasses the issue with the x11 back end. Maybe further investigations should look at: 1) Why does this version of Debian not include or suggest the libreoffice-gtk3 package (I am using a Debian variant, but it may hold in regular testing Debian) 2) The x11 fallback backend appears to have the issue; but maybe it is not used much? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108518] FILEOPEN: DOC file list numbers incorrectly italicized
https://bugs.documentfoundation.org/show_bug.cgi?id=108518 --- Comment #14 from Justin L --- (In reply to Justin L from comment #13) > and possibly even for DOC). Yes, in 2018 Mike K set this compatibility flag for DOC for bug 117923 source/filter/ww8/ww8par.cxx-m_rDoc.getIDocumentSettingAccess().set( DocumentSettingId::APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING, true); -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140911] New: Standard (Set to Parent) button in Styles dialog should only be active when it is possible to apply on a tab
https://bugs.documentfoundation.org/show_bug.cgi?id=140911 Bug ID: 140911 Summary: Standard (Set to Parent) button in Styles dialog should only be active when it is possible to apply on a tab Product: LibreOffice Version: 7.2.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Standard/Set to Parent button appears in three styles dialog (Paragraph, Character, Frame). It should only be active when there are actually values in a tab that can be changed by this button. Relevant values are listed in "Contains". If nothing in Contains is found on the current tab, then the Standard(Set to Parent) button should be greyed out. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108518] FILEOPEN: DOC file list numbers incorrectly italicized
https://bugs.documentfoundation.org/show_bug.cgi?id=108518 --- Comment #13 from Justin L --- (In reply to Justin L from comment #5) > bibisect41max points to commit 1c22545edf9085b9f2656ca92781158b6b123db3 > Author: Jian Hong Cheng > CommitDate: Thu Mar 14 10:08:38 2013 +0100 > Fix issue #i119405 [https://bz.apache.org/ooo/show_bug.cgi?id=119405]: > Numbering text style changed after importing the *.doc I think the premise of this entire commit is wrong. From what I can see, it is affecting the entire numbering style when one of the paragraphs has CR formatting. Well, that might be fine to affect the numbering for THAT PARAGRAPH based on the CR, but it shouldn't affect the numbering attributes as a whole. Even worse for "9037 - italics-in-para-causes-italic-numbered-list.doc", it appears that the italics definition is coming from "[Option 1: New Zealand Customs Service, paragraphs 2.1 – 2.7]". But this isn't even defined in the CR. And yet it seems to be applying the italics to the character style WW8Num1z0 - and so it affects every numbering on level one. But quite honestly, I can't follow the code at all - even in a debugger. So I have little confidence that I understand what is really happening. But my impression is that this commit is almost entirely wrong, and should be completely reverted (except for the two Ignore functions that are being re-used for layout - which is where this is being handled for DOCX anyway, and possibly even for DOC). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90244] SIDEBAR: Enhancing Navigator in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=90244 Heiko Tietze changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #23 from Heiko Tietze --- *** Bug 140880 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140880] UI: Indicator to navigator if an item based group of items
https://bugs.documentfoundation.org/show_bug.cgi?id=140880 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Heiko Tietze --- Even better when the DrawingObject node contains the grouped objects as childrens. But improvement ideas to the Navigator are not new. *** This bug has been marked as a duplicate of bug 90244 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135310] [META] Writer outline content visibility bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=135310 Heiko Tietze changed: What|Removed |Added Depends on||140569 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140569 [Bug 140569] Feature requeast: Collapsible objects in Normal view -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140569] Feature requeast: Collapsible objects in Normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=140569 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Blocks||135310 Ever confirmed|0 |1 --- Comment #1 from Heiko Tietze --- Is the new outline mode a viable solution for you? For example advertised here http://libreoffice-dev.blogspot.com/2020/08/a-new-writer-outline-folding-mode-in.html and requested in bug 38093. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135310 [Bug 135310] [META] Writer outline content visibility bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140569] Feature requeast: Collapsible objects in Normal view
https://bugs.documentfoundation.org/show_bug.cgi?id=140569 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Blocks||135310 Ever confirmed|0 |1 --- Comment #1 from Heiko Tietze --- Is the new outline mode a viable solution for you? For example advertised here http://libreoffice-dev.blogspot.com/2020/08/a-new-writer-outline-folding-mode-in.html and requested in bug 38093. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135310 [Bug 135310] [META] Writer outline content visibility bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140910] New: Blank XLSX file generated with OpenXML SDK
https://bugs.documentfoundation.org/show_bug.cgi?id=140910 Bug ID: 140910 Summary: Blank XLSX file generated with OpenXML SDK Product: LibreOffice Version: 7.1.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: emi...@ymail.com Description: I have generated xlsx file using Open XML SDK structure and file is loaded blank. If you try to open it in Microsoft Excel it shows data, and if you just save it, it can be also read by LibreOffice. Seems like structure of generated XML is not readable by Libre, but im not sure. Steps to Reproduce: 1. Open XLSX file Actual Results: Blank file Expected Results: Loaded file with 5 rows of data Reproducible: Always User Profile Reset: No Additional Info: I can send example of docs if needed. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48951] PRINTING: bulk letter print gives the letter page and a second empty page
https://bugs.documentfoundation.org/show_bug.cgi?id=48951 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=76 ||226 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76226] enhance documentation on mail merge fields
https://bugs.documentfoundation.org/show_bug.cgi?id=76226 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=48 ||951 --- Comment #10 from Timur --- I'd also add a note to explain that empty pages can be turned off in Options-Writer-Print or File-Printer Settings-Options. Bug 48951. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140880] UI: Indicator to navigator if an item based group of items
https://bugs.documentfoundation.org/show_bug.cgi?id=140880 Heiko Tietze changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #1 from Heiko Tietze --- Even better when the DrawingObject node contains the grouped objects as childrens. But improvement ideas to the Navigator are not new. *** This bug has been marked as a duplicate of bug 90244 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - vcl/inc vcl/source
vcl/inc/impfont.hxx |4 -
vcl/source/font/font.cxx | 115 ---
2 files changed, 112 insertions(+), 7 deletions(-)
New commits:
commit a5cecd2ea50dc930cfc0d90be69c08ddd144d3db
Author: Armin Le Grand (Allotropia)
AuthorDate: Tue Feb 2 17:57:12 2021 +0100
Commit: Armin Le Grand
CommitDate: Tue Mar 9 10:20:22 2021 +0100
tdf#127471 improve SVM FontScaling im/export
Due to svg::Font Width and it's expression of
FontScaling being system-dependent the FontScaling
when exchanging beween win-based SVM creators and
others was creating errors.
Corrected this to work now with newly created SVM
files in both directions. For more aspects see
discussion in task.
Change-Id: I326e4e7e895a9dfc3cdfc5323174ca81e22795e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110330
Tested-by: Jenkins
Reviewed-by: Armin Le Grand
(cherry picked from commit 40b56cd8da8c38582dc4660b486993d1b4711535)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112088
diff --git a/vcl/inc/impfont.hxx b/vcl/inc/impfont.hxx
index caa917a751f0..ba1ea3683926 100644
--- a/vcl/inc/impfont.hxx
+++ b/vcl/inc/impfont.hxx
@@ -84,8 +84,8 @@ public:
private:
friend class vcl::Font;
-friend SvStream&ReadImplFont( SvStream& rIStm, ImplFont& );
-friend SvStream&WriteImplFont( SvStream& rOStm, const ImplFont& );
+friend SvStream&ReadImplFont( SvStream& rIStm, ImplFont&, tools::Long&
);
+friend SvStream&WriteImplFont( SvStream& rOStm, const ImplFont&, const
tools::Long& );
voidAskConfig();
diff --git a/vcl/source/font/font.cxx b/vcl/source/font/font.cxx
index 2818e71e00ea..180f5bbf122b 100644
--- a/vcl/source/font/font.cxx
+++ b/vcl/source/font/font.cxx
@@ -34,6 +34,10 @@
#include
#include
+#ifdef _WIN32
+#include
+#endif
+
using namespace vcl;
namespace
@@ -357,7 +361,7 @@ void Font::GetFontAttributes( FontAttributes& rAttrs ) const
rAttrs.SetSymbolFlag( mpImplFont->GetCharSet() == RTL_TEXTENCODING_SYMBOL
);
}
-SvStream& ReadImplFont( SvStream& rIStm, ImplFont& rImplFont )
+SvStream& ReadImplFont( SvStream& rIStm, ImplFont& rImplFont, tools::Long&
rnNormedFontScaling )
{
VersionCompat aCompat( rIStm, StreamMode::READ );
sal_uInt16 nTmp16(0);
@@ -400,15 +404,25 @@ SvStream& ReadImplFont( SvStream& rIStm, ImplFont&
rImplFont )
rIStm.ReadUInt16( nTmp16 ); rImplFont.meOverline =
static_cast(nTmp16);
}
+// tdf#127471 read NormedFontScaling
+if( aCompat.GetVersion() >= 4 )
+{
+sal_Int32 nNormedFontScaling(0);
+rIStm.ReadInt32(nNormedFontScaling);
+rnNormedFontScaling = nNormedFontScaling;
+}
+
// Relief
// CJKContextLanguage
return rIStm;
}
-SvStream& WriteImplFont( SvStream& rOStm, const ImplFont& rImplFont )
+SvStream& WriteImplFont( SvStream& rOStm, const ImplFont& rImplFont, const
tools::Long& rnNormedFontScaling )
{
-VersionCompat aCompat( rOStm, StreamMode::WRITE, 3 );
+// tdf#127471 increase to version 4
+VersionCompat aCompat( rOStm, StreamMode::WRITE, 4 );
+
TypeSerializer aSerializer(rOStm);
rOStm.WriteUniOrByteString( rImplFont.GetFamilyName(),
rOStm.GetStreamCharSet() );
rOStm.WriteUniOrByteString( rImplFont.GetStyleName(),
rOStm.GetStreamCharSet() );
@@ -440,17 +454,108 @@ SvStream& WriteImplFont( SvStream& rOStm, const
ImplFont& rImplFont )
// new in version 3
rOStm.WriteUInt16( rImplFont.meOverline );
+// new in version 4, NormedFontScaling
+rOStm.WriteInt32(rnNormedFontScaling);
+
return rOStm;
}
SvStream& ReadFont( SvStream& rIStm, vcl::Font& rFont )
{
-return ReadImplFont( rIStm, *rFont.mpImplFont );
+// tdf#127471 try to read NormedFontScaling
+tools::Long nNormedFontScaling(0);
+SvStream& rRetval(ReadImplFont( rIStm, *rFont.mpImplFont,
nNormedFontScaling ));
+
+if (nNormedFontScaling > 0)
+{
+#ifdef _WIN32
+// we run on windows and a NormedFontScaling was written
+if(rFont.GetFontSize().getWidth() == nNormedFontScaling)
+{
+// the writing producer was running on a non-windows system, adapt
to needed windows
+// system-specific pre-multiply
+const tools::Long
nHeight(std::max(rFont.GetFontSize().getHeight(), 0));
+sal_uInt32 nScaledWidth(0);
+
+if(nHeight > 0)
+{
+vcl::Font aUnscaledFont(rFont);
+aUnscaledFont.SetAverageFontWidth(0);
+const FontMetric
aUnscaledFontMetric(Application::GetDefaultDevice()->GetFontMetric(aUnscaledFont));
+
+if (aUnscaledFontMetric.GetAverageFontWidth() > 0)
+{
+const double
fScaleFactor(static_cast(nNormedFontScaling) /
static_cast(nHeight));
+nScaledWidth =
[Libreoffice-bugs] [Bug 140478] Basic fonts option for List does not have any effect
https://bugs.documentfoundation.org/show_bug.cgi?id=140478 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Heiko Tietze --- My take: remove the List option from basic fonts. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140478] Basic fonts option for List does not have any effect
https://bugs.documentfoundation.org/show_bug.cgi?id=140478 Heiko Tietze changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Heiko Tietze --- My take: remove the List option from basic fonts. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 140892] If a headline is centered, its distance from its "outline view" icon may make the icon awkward to access
https://bugs.documentfoundation.org/show_bug.cgi?id=140892 --- Comment #2 from Jim Raykowski --- Holding the Ctrl key while the mouse is positioned on the heading will change the pointer to a hand pointer. Then left-click to toggle visibility of content from selected heading to next heading. Right-click to hide or show all content from selected heading (and all its subheadings) to next heading at same outline level. Here is a link to the help page for this: https://help.libreoffice.org/latest/en-US/text/swriter/01/outlinecontent_visibility.html?DbPAR=WRITER#bm_id861604659229058b >Expected Results: >The icon should stay steadily visible long enough to be reached and acted upon. The icon is removed when the mouse goes out of the heading frame. It is not a timer that determines this. The mouse does not need to be over the text. The frame extends the width of the page. Moving the mouse near where the icon appears will reveal it. >Alternatively, perhaps the icon should be placed adjacent to the headline, >just >to its left. Or to the right for RTL users. >This may be the more elegant solution. Thanks for the suggestion. I will look into doing it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140818] Default Character Style should be renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=140818 Heiko Tietze changed: What|Removed |Added Summary|Default Character Style |Default Character Style |should be renamed "No |should be renamed |Character Style"| CC||so...@libreoffice.org --- Comment #8 from Heiko Tietze --- We have the proposals "No Character Style" and "Set to Paragraph Default" (quite a challenge for translators to pick up all the implicit thinking). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 140818] Default Character Style should be renamed
https://bugs.documentfoundation.org/show_bug.cgi?id=140818 Heiko Tietze changed: What|Removed |Added Summary|Default Character Style |Default Character Style |should be renamed "No |should be renamed |Character Style"| CC||so...@libreoffice.org --- Comment #8 from Heiko Tietze --- We have the proposals "No Character Style" and "Set to Paragraph Default" (quite a challenge for translators to pick up all the implicit thinking). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 135048] Notebookbar Extension support with label
https://bugs.documentfoundation.org/show_bug.cgi?id=135048 --- Comment #7 from Szymon Kłos --- I don't think 'MergeNotebookBarInstruction' was implemented (if I remember correctly). -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source cui/source extensions/source include/svx reportdesign/source sc/source sd/source svx/source sw/source
chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx |4 -
cui/source/options/optcolor.cxx |2
cui/source/tabpages/border.cxx |6 +-
cui/source/tabpages/chardlg.cxx |9 ++-
cui/source/tabpages/numpages.cxx |3 -
cui/source/tabpages/tpgradnt.cxx |6 +-
cui/source/tabpages/tphatch.cxx |6 +-
cui/source/tabpages/tpline.cxx |3 -
cui/source/tabpages/tppattern.cxx|6 +-
cui/source/tabpages/tpshadow.cxx |3 -
extensions/source/propctrlr/propcontroller.cxx |4 -
include/svx/colorbox.hxx |7 +-
include/svx/colorwindow.hxx | 13 ++--
include/svx/tbcontrl.hxx |2
reportdesign/source/ui/dlg/Condition.cxx |4 -
sc/source/ui/condformat/colorformat.cxx |6 +-
sc/source/ui/condformat/condformatdlgentry.cxx | 10 +--
sc/source/ui/dbgui/scendlg.cxx |2
sc/source/ui/optdlg/opredlin.cxx | 12 ++--
sc/source/ui/optdlg/tpview.cxx |3 -
sd/source/ui/animations/CustomAnimationDialog.cxx|4 -
sd/source/ui/dlg/BulletAndPositionDlg.cxx|3 -
sd/source/ui/dlg/copydlg.cxx |4 -
sd/source/ui/sidebar/SlideBackground.cxx |6 +-
svx/source/dialog/_bmpmask.cxx | 10 +--
svx/source/dialog/fontwork.cxx |2
svx/source/engine3d/float3d.cxx | 24
svx/source/sidebar/area/AreaPropertyPanelBase.cxx|4 -
svx/source/sidebar/effect/EffectPropertyPanel.cxx|3 -
svx/source/sidebar/shadow/ShadowPropertyPanel.cxx|2
svx/source/tbxctrls/tbcontrl.cxx | 32 +--
sw/source/ui/config/optpage.cxx | 12 ++--
sw/source/ui/frmdlg/column.cxx |3 -
sw/source/ui/misc/pgfnote.cxx|3 -
sw/source/ui/misc/pggrid.cxx |3 -
sw/source/uibase/dialog/watermarkdialog.cxx |2
sw/source/uibase/sidebar/PageStylesPanel.cxx |4 -
37 files changed, 133 insertions(+), 99 deletions(-)
New commits:
commit 862fd2fa19b64972247bde9b171ec828a30e1676
Author: Caolán McNamara
AuthorDate: Mon Mar 8 17:18:06 2021 +
Commit: Caolán McNamara
CommitDate: Tue Mar 9 10:08:45 2021 +0100
defer getting toplevel for color picker until we need it
Change-Id: I60f4ded47f7d80b397647ea3344e83a5dfd1b11e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112183
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
index 16fd2d2c9f56..c4b28162d08c 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneIllumination.cxx
@@ -201,9 +201,9 @@
ThreeD_SceneIllumination_TabPage::ThreeD_SceneIllumination_TabPage(weld::Contain
, m_xBtn_Light6(new
LightButton(m_xBuilder->weld_toggle_button("BTN_LIGHT_6")))
, m_xBtn_Light7(new
LightButton(m_xBuilder->weld_toggle_button("BTN_LIGHT_7")))
, m_xBtn_Light8(new
LightButton(m_xBuilder->weld_toggle_button("BTN_LIGHT_8")))
-, m_xLB_LightSource(new
ColorListBox(m_xBuilder->weld_menu_button("LB_LIGHTSOURCE"), pTopLevel))
+, m_xLB_LightSource(new
ColorListBox(m_xBuilder->weld_menu_button("LB_LIGHTSOURCE"), [this]{ return
m_pTopLevel; }))
,
m_xBtn_LightSource_Color(m_xBuilder->weld_button("BTN_LIGHTSOURCE_COLOR"))
-, m_xLB_AmbientLight(new
ColorListBox(m_xBuilder->weld_menu_button("LB_AMBIENTLIGHT"), pTopLevel))
+, m_xLB_AmbientLight(new
ColorListBox(m_xBuilder->weld_menu_button("LB_AMBIENTLIGHT"), [this]{ return
m_pTopLevel; }))
, m_xBtn_AmbientLight_Color(m_xBuilder->weld_button("BTN_AMBIENT_COLOR"))
, m_xHoriScale(m_xBuilder->weld_scale("hori"))
, m_xVertScale(m_xBuilder->weld_scale("vert"))
diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index c17e9a1ce5c0..8567189e6cc4 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -281,7 +281,7 @@ ColorConfigWindow_Impl::Entry::Entry(weld::Window*
pTopLevel, weld::Builder& rBu
const char* pTextWidget, const char*
pColorWidget,
const Color&
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/uitest/navigator/tdf114724.py | 23 +++-
sw/source/uibase/inc/navipi.hxx |3 --
sw/source/uibase/inc/uiobject.hxx| 20 -
sw/source/uibase/uitest/uiobject.cxx | 40 ---
sw/source/uibase/utlui/navipi.cxx|5
5 files changed, 13 insertions(+), 78 deletions(-)
New commits:
commit 2befe5c56c29fec45c898c00773e906d2d2d9f19
Author: Caolán McNamara
AuthorDate: Sun Mar 7 20:17:27 2021 +
Commit: Caolán McNamara
CommitDate: Tue Mar 9 10:07:49 2021 +0100
decompose SwNavigationPIUIObject and use sub components directly
Change-Id: Ia4722972fe579646b4c3f06de339d72a931b05d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112146
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/uitest/navigator/tdf114724.py
b/sw/qa/uitest/navigator/tdf114724.py
index a84bab60da60..ee39921a3285 100644
--- a/sw/qa/uitest/navigator/tdf114724.py
+++ b/sw/qa/uitest/navigator/tdf114724.py
@@ -18,26 +18,29 @@ class tdf114724(UITestCase):
xWriterEdit.executeAction("SIDEBAR", mkPropertyValues({"PANEL":
"SwNavigatorPanel"}))
xNavigatorPanel = xWriterEdit.getChild("NavigatorPanelParent")
-xNavigatorPanel.executeAction("ROOT", tuple())
+xToolBar = xNavigatorPanel.getChild("content5")
+xToolBar.executeAction("CLICK", mkPropertyValues({"POS": "0"})) #
'root' button
xWriterEdit.executeAction("FOCUS", tuple())
-self.ui_test.wait_until_property_is_updated(xNavigatorPanel,
"selectedtext", "HEADING 1")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectedtext"],
"HEADING 1")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectioncount"],
"1")
+xContentTree = xNavigatorPanel.getChild("contenttree")
+
+self.ui_test.wait_until_property_is_updated(xContentTree,
"SelectEntryText", "HEADING 1")
+self.assertEqual(get_state_as_dict(xContentTree)["SelectEntryText"],
"HEADING 1")
+self.assertEqual(get_state_as_dict(xContentTree)["SelectionCount"],
"1")
for _ in range(0,3):
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"DOWN"}))
-self.ui_test.wait_until_property_is_updated(xNavigatorPanel,
"selectedtext", "HEADING 4")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectedtext"],
"HEADING 4")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectioncount"],
"1")
+self.ui_test.wait_until_property_is_updated(xContentTree,
"SelectEntryText", "HEADING 4")
+self.assertEqual(get_state_as_dict(xContentTree)["SelectEntryText"],
"HEADING 4")
+self.assertEqual(get_state_as_dict(xContentTree)["SelectionCount"],
"1")
for _ in range(0,3):
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"UP"}))
-self.ui_test.wait_until_property_is_updated(xNavigatorPanel,
"selectedtext", "HEADING 1")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectedtext"],
"HEADING 1")
-self.assertEqual(get_state_as_dict(xNavigatorPanel)["selectioncount"],
"1")
+self.ui_test.wait_until_property_is_updated(xContentTree,
"SelectEntryText", "HEADING 1")
+self.assertEqual(get_state_as_dict(xContentTree)["SelectEntryText"],
"HEADING 1")
+self.assertEqual(get_state_as_dict(xContentTree)["SelectionCount"],
"1")
self.xUITest.executeCommand(".uno:Sidebar")
self.ui_test.close_doc()
diff --git a/sw/source/uibase/inc/navipi.hxx b/sw/source/uibase/inc/navipi.hxx
index bdcd7acde296..8f0dd968f37f 100644
--- a/sw/source/uibase/inc/navipi.hxx
+++ b/sw/source/uibase/inc/navipi.hxx
@@ -46,7 +46,6 @@ class SwNavigationPI : public PanelLayout
friend class SwNavigationChild;
friend class SwContentTree;
friend class SwGlobalTree;
-friend class SwNavigationPIUIObject;
::sfx2::sidebar::ControllerItem m_aDocFullName;
::sfx2::sidebar::ControllerItem m_aPageStats;
@@ -156,8 +155,6 @@ public:
boolIsGlobalMode() const {returnm_bGlobalMode;}
SwView* GetCreateView() const;
-
-FactoryFunction GetUITestFactory() const override;
};
class SwNavigationChild : public SfxChildWindowContext
diff --git a/sw/source/uibase/inc/uiobject.hxx
b/sw/source/uibase/inc/uiobject.hxx
index b671365c3403..7f6ff239be6b 100644
--- a/sw/source/uibase/inc/uiobject.hxx
+++ b/sw/source/uibase/inc/uiobject.hxx
@@ -42,26 +42,6 @@ private:
};
-class SwNavigationPIUIObject : public WindowUIObject
-{
-VclPtr mxSwNavigationPI;
-
-public:
-
-SwNavigationPIUIObject(const VclPtr& xSwNavigationPI);
-
-virtual StringMap get_state() override;
-
-virtual void execute(const OUString& rAction,
-const StringMap& rParameters) override;
-
-static std::unique_ptr create(vcl::Window* pWindow);
-
-protected:
-
-OUString get_name() const override;
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/uitest/calc_tests8/navigator.py |7 +--
sc/source/ui/inc/navipi.hxx |3 ---
sc/source/ui/inc/uiobject.hxx | 17 -
sc/source/ui/navipi/navipi.cxx|5 -
sc/source/ui/uitest/uiobject.cxx | 28
5 files changed, 5 insertions(+), 55 deletions(-)
New commits:
commit 6b0e1986a7c446cb6862f645e45c377c2a309065
Author: Caolán McNamara
AuthorDate: Sun Mar 7 20:46:20 2021 +
Commit: Caolán McNamara
CommitDate: Tue Mar 9 10:07:24 2021 +0100
decompose ScNavigatorDlgUIObject and use sub components directly
Change-Id: I817d0e201804dce3e83d204702ff236f5689ebb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112148
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sc/qa/uitest/calc_tests8/navigator.py
b/sc/qa/uitest/calc_tests8/navigator.py
index abbb8ce1cf73..5e8cb99e01e3 100644
--- a/sc/qa/uitest/calc_tests8/navigator.py
+++ b/sc/qa/uitest/calc_tests8/navigator.py
@@ -91,7 +91,9 @@ class navigator(UITestCase):
xCalcDoc = self.xUITest.getTopFocusWindow()
xNavigatorPanel = xCalcDoc.getChild("NavigatorPanelParent")
-xNavigatorPanel.executeAction("ROOT", tuple())
+xToolBar = xNavigatorPanel.getChild("toolbox2")
+xToolBar.executeAction("CLICK", mkPropertyValues({"POS": "0"})) #
'toggle' button
+
xContentBox = xNavigatorPanel.getChild('contentbox')
# tdf#133079, without the fix in place, it would be 8
@@ -123,7 +125,8 @@ class navigator(UITestCase):
xCalcDoc = self.xUITest.getTopFocusWindow()
xNavigatorPanel = xCalcDoc.getChild("NavigatorPanelParent")
-xNavigatorPanel.executeAction("ROOT", tuple())
+xToolBar = xNavigatorPanel.getChild("toolbox2")
+xToolBar.executeAction("CLICK", mkPropertyValues({"POS": "0"})) #
'toggle' button
xRow = xNavigatorPanel.getChild('row')
xColumn = xNavigatorPanel.getChild('column')
diff --git a/sc/source/ui/inc/navipi.hxx b/sc/source/ui/inc/navipi.hxx
index 988822a69ee8..fae782112f7c 100644
--- a/sc/source/ui/inc/navipi.hxx
+++ b/sc/source/ui/inc/navipi.hxx
@@ -88,7 +88,6 @@ class ScNavigatorDlg : public PanelLayout, public SfxListener
friend class ScNavigatorControllerItem;
friend class ScNavigatorDialogWrapper;
friend class ScContentTree;
-friend class ScNavigatorDlgUIObject;
private:
static constexpr int CTRL_ITEMS = 4;
@@ -178,8 +177,6 @@ public:
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
virtual void StateChanged(StateChangedType nStateChange) override;
-
-FactoryFunction GetUITestFactory() const override;
};
class ScNavigatorDialogWrapper: public SfxChildWindowContext
diff --git a/sc/source/ui/inc/uiobject.hxx b/sc/source/ui/inc/uiobject.hxx
index ae3583fff154..01ebdcdc6e89 100644
--- a/sc/source/ui/inc/uiobject.hxx
+++ b/sc/source/ui/inc/uiobject.hxx
@@ -45,21 +45,4 @@ private:
ScViewFunc* getViewFunc();
};
-class ScNavigatorDlg;
-
-class ScNavigatorDlgUIObject : public WindowUIObject
-{
-VclPtr mxScNavigatorDlg;
-
-public:
-ScNavigatorDlgUIObject(const VclPtr& xScNavigatorDlg);
-
-virtual void execute(const OUString& rAction, const StringMap&
rParameters) override;
-
-static std::unique_ptr create(vcl::Window* pWindow);
-
-protected:
-virtual OUString get_name() const override;
-};
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/navipi/navipi.cxx b/sc/source/ui/navipi/navipi.cxx
index 6fea222a7938..d8fa920f2385 100644
--- a/sc/source/ui/navipi/navipi.cxx
+++ b/sc/source/ui/navipi/navipi.cxx
@@ -442,11 +442,6 @@ void ScNavigatorDlg::StateChanged(StateChangedType
nStateChange)
}
}
-FactoryFunction ScNavigatorDlg::GetUITestFactory() const
-{
-return ScNavigatorDlgUIObject::create;
-}
-
ScNavigatorDlg::~ScNavigatorDlg()
{
disposeOnce();
diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 1e17f9301a58..d93da2619a77 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -381,32 +381,4 @@ OUString ScGridWinUIObject::get_name() const
return "ScGridWinUIObject";
}
-ScNavigatorDlgUIObject::ScNavigatorDlgUIObject(const VclPtr&
xScNavigatorDlg):
-WindowUIObject(xScNavigatorDlg),
-mxScNavigatorDlg(xScNavigatorDlg)
-{
-}
-
-void ScNavigatorDlgUIObject::execute(const OUString& rAction,
-const StringMap& rParameters)
-{
-if (rAction == "ROOT")
-{
-mxScNavigatorDlg->ToolBoxSelectHdl("toggle");
-}
-else
-WindowUIObject::execute(rAction, rParameters);
-}
-
-std::unique_ptr ScNavigatorDlgUIObject::create(vcl::Window* pWindow)
-{
-ScNavigatorDlg* pScNavigatorDlg = dynamic_cast(pWindow);
-assert(pScNavigatorDlg);
-return std::unique_ptr(new
ScNavigatorDlgUIObject(pScNavigatorDlg));
-}
-
-OUString ScNavigatorDlgUIObject::get_name() const
[Libreoffice-bugs] [Bug 128703] Find & Replace Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128703 --- Comment #7 from Heiko Tietze --- (In reply to andreas_k from comment #6) > Should I add some kind of label for the buttons... The space above the buttons is taken by the frame's label. And left-hand it makes no sense. So IMHO no. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa vcl/source
sw/qa/uitest/findBar/findbar.py | 10 +-
sw/qa/uitest/findBar/tdf136941.py |8
sw/qa/uitest/findBar/tdf138232.py |4 ++--
sw/qa/uitest/findBar/tdf88608.py |4 ++--
sw/qa/uitest/sidebar/stylesSidebar.py |2 +-
vcl/source/uitest/uiobject.cxx|2 +-
6 files changed, 15 insertions(+), 15 deletions(-)
New commits:
commit a2d0741eed98db9c8b3509153a77d2e56b423d06
Author: Caolán McNamara
AuthorDate: Sun Mar 7 20:43:13 2021 +
Commit: Caolán McNamara
CommitDate: Tue Mar 9 10:06:21 2021 +0100
SetCurItemId takes an ItemId not a Position
Change-Id: Id0b34364cf45b9305f865d46cf8c3c0f838ce630
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112147
Tested-by: Jenkins
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/uitest/findBar/findbar.py b/sw/qa/uitest/findBar/findbar.py
index df973dc8e162..2620d39a0a98 100644
--- a/sw/qa/uitest/findBar/findbar.py
+++ b/sw/qa/uitest/findBar/findbar.py
@@ -43,28 +43,28 @@ class FindBar(UITestCase):
self.assertEqual(get_state_as_dict(xfind_bar)["ItemCount"], "14")
# Press on FindAll in the Find Bar
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "5"})) # 5
is FindAll id
-self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemID"],
"5")
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "4"}))
+self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemID"],
"5") # 5 is FindAll id for Pos 4
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemText"],
"Find All")
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemCommand"],
".uno:FindAll")
self.assertEqual(get_state_as_dict(xWriterEdit)["SelectedText"],
"LibreLibreLibre")
# Press on Find Next in the Find Bar
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "4"})) # 4
is Find Next id
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "3"})) # 3
is Find Next pos
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemID"],
"4")
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemText"],
"Find Next")
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemCommand"],
".uno:DownSearch")
self.assertEqual(get_state_as_dict(xWriterEdit)["SelectedText"],
"Libre")
# Press on Find Previous in the Find Bar
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "3"})) # 3
is Find Previous id
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "2"})) # 2
is Find Previous pos
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemID"],
"3")
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemText"],
"Find Previous")
self.assertEqual(get_state_as_dict(xfind_bar)["CurrSelectedItemCommand"],
".uno:UpSearch")
self.assertEqual(get_state_as_dict(xWriterEdit)["SelectedText"],
"Libre")
# Close the Find Bar
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "1"})) # 1
is for close
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "0"})) # 0
is pos for close
self.ui_test.close_doc()
diff --git a/sw/qa/uitest/findBar/tdf136941.py
b/sw/qa/uitest/findBar/tdf136941.py
index a96964a2fb79..ab94449aefed 100644
--- a/sw/qa/uitest/findBar/tdf136941.py
+++ b/sw/qa/uitest/findBar/tdf136941.py
@@ -28,10 +28,10 @@ class tdf136941(UITestCase):
xfind_bar = xWriterDoc.getChild("FindBar")
# Search Next
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "4"}))
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "3"}))
# Close button
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "1"}))
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "0"}))
# Check the toolbar is closed
self.assertTrue("find" not in xWriterDoc.getChildren())
@@ -49,10 +49,10 @@ class tdf136941(UITestCase):
xfind_bar = xWriterDoc.getChild("FindBar")
# Search Next
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "4"}))
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "3"}))
# Close button
-xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "1"}))
+xfind_bar.executeAction("CLICK", mkPropertyValues({"POS": "0"}))
# Check the toolbar is closed
self.assertTrue("find" not in xWriterDoc.getChildren())
diff --git a/sw/qa/uitest/findBar/tdf138232.py
b/sw/qa/uitest/findBar/tdf138232.py
index 037296c8d0d6..93f859bc7521 100644
--- a/sw/qa/uitest/findBar/tdf138232.py
+++ b/sw/qa/uitest/findBar/tdf138232.py
@@ -29,7 +29,7 @@ class tdf138232(UITestCase):
xfind_bar = xWriterDoc.getChild("FindBar")
# Click on Find All
-
[Libreoffice-commits] core.git: include/sfx2 sc/source sd/source svx/source sw/inc sw/source
include/sfx2/viewsh.hxx |2 +
sc/source/ui/inc/tabvwsh.hxx|2 +
sc/source/ui/view/tabvwsh4.cxx |5 +++
sd/source/ui/inc/ViewShellBase.hxx |4 ++
sd/source/ui/inc/unomodel.hxx |2 +
sd/source/ui/unoidl/unomodel.cxx| 11 +++
svx/source/tbxctrls/fontworkgallery.cxx | 49 +---
sw/inc/view.hxx |2 +
sw/source/uibase/uiview/view.cxx|9 +
sw/source/uibase/uiview/viewdraw.cxx| 14 -
10 files changed, 83 insertions(+), 17 deletions(-)
New commits:
commit 878e8fe7ffeada3d6154fe4750079deb38e1ce94
Author: Szymon Kłos
AuthorDate: Tue Jan 26 16:35:10 2021 +0100
Commit: Szymon Kłos
CommitDate: Tue Mar 9 09:55:04 2021 +0100
fontwork: insert in the center of LOK view
Change-Id: Iabde4ee927546b0e396c4fbd6d0099fa82240166
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109968
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Jan Holesovsky
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112163
Tested-by: Jenkins
Reviewed-by: Szymon Kłos
diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index a25da48c39d4..8742820dde51 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -382,6 +382,8 @@ public:
bool isLOKTablet() const { return maLOKDeviceFormFactor ==
LOKDeviceFormFactor::TABLET; }
/// Check if the lok client is running on a mobile device.
bool isLOKMobilePhone() const { return maLOKDeviceFormFactor ==
LOKDeviceFormFactor::MOBILE; }
+
+virtual tools::Rectangle getLOKVisibleArea() const { return
tools::Rectangle(); }
};
diff --git a/sc/source/ui/inc/tabvwsh.hxx b/sc/source/ui/inc/tabvwsh.hxx
index 351c9e2cbeee..94f8e14ebb91 100644
--- a/sc/source/ui/inc/tabvwsh.hxx
+++ b/sc/source/ui/inc/tabvwsh.hxx
@@ -399,6 +399,8 @@ public:
void InitFormEditData();
void ClearFormEditData();
ScFormEditData* GetFormEditData() { return mpFormEditData.get(); }
+
+virtual tools::Rectangle getLOKVisibleArea() const override;
};
#endif
diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx
index cb13072d0edc..0707b7038409 100644
--- a/sc/source/ui/view/tabvwsh4.cxx
+++ b/sc/source/ui/view/tabvwsh4.cxx
@@ -1855,4 +1855,9 @@ ScNavigatorSettings*
ScTabViewShell::GetNavigatorSettings()
return pNavSettings.get();
}
+tools::Rectangle ScTabViewShell::getLOKVisibleArea() const
+{
+return GetViewData().getLOKVisibleArea();
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/inc/ViewShellBase.hxx
b/sd/source/ui/inc/ViewShellBase.hxx
index d80e6113fdd3..f61cab75661b 100644
--- a/sd/source/ui/inc/ViewShellBase.hxx
+++ b/sd/source/ui/inc/ViewShellBase.hxx
@@ -217,6 +217,9 @@ public:
/// See SfxViewShell::NotifyCursor().
void NotifyCursor(SfxViewShell* pViewShell) const override;
+void setLOKVisibleArea(const ::tools::Rectangle& rArea) { maLOKVisibleArea
= rArea; }
+virtual ::tools::Rectangle getLOKVisibleArea() const override { return
maLOKVisibleArea; }
+
protected:
virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override;
@@ -228,6 +231,7 @@ private:
std::unique_ptr mpImpl;
DrawDocShell* mpDocShell;
SdDrawDocument* mpDocument;
+::tools::Rectangle maLOKVisibleArea;
/** Determine from the properties of the document shell the initial type
of the view shell in the center pane. We use this method to avoid
diff --git a/sd/source/ui/inc/unomodel.hxx b/sd/source/ui/inc/unomodel.hxx
index 7856e46aa33f..747ce4e585cb 100644
--- a/sd/source/ui/inc/unomodel.hxx
+++ b/sd/source/ui/inc/unomodel.hxx
@@ -255,6 +255,8 @@ public:
virtual void setGraphicSelection(int nType, int nX, int nY) override;
/// @see lok::Document::resetSelection().
virtual void resetSelection() override;
+/// @see vcl::ITiledRenderable::setClientVisibleArea().
+virtual void setClientVisibleArea(const tools::Rectangle& rRectangle)
override;
/// @see vcl::ITiledRenderable::setClipboard().
virtual void setClipboard(const
css::uno::Reference& xClipboard)
override;
/// @see vcl::ITiledRenderable::isMimeTypeSupported().
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 411af888513f..62b35a5cbfe9 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -2607,6 +2607,17 @@ void SdXImpressDocument::resetSelection()
pSdrView->UnmarkAll();
}
+void SdXImpressDocument::setClientVisibleArea(const ::tools::Rectangle&
rRectangle)
+{
+SolarMutexGuard aGuard;
+
+DrawViewShell* pViewShell = GetViewShell();
+if (!pViewShell)
+return;
+
+pViewShell->GetViewShellBase().setLOKVisibleArea(rRectangle);
+}
+
void SdXImpressDocument::setClipboard(const
uno::Reference& xClipboard)
{
SolarMutexGuard aGuard;
diff --git
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/uiview/viewdraw.cxx | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) New commits: commit d5eeca9bf3811b8c83d497dab5edb3ee2ba79a84 Author: Szymon Kłos AuthorDate: Wed Feb 10 07:21:30 2021 +0100 Commit: Szymon Kłos CommitDate: Tue Mar 9 09:55:25 2021 +0100 fontwork: center in online in writer Avoid unnecessary position change Change-Id: I338b9a28653569e1b7c19ba3a1f590363fb2f94c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110664 Tested-by: Jenkins CollaboraOffice Reviewed-by: Jan Holesovsky Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112164 Tested-by: Jenkins Reviewed-by: Szymon Kłos diff --git a/sw/source/uibase/uiview/viewdraw.cxx b/sw/source/uibase/uiview/viewdraw.cxx index 680d7ba788e7..80c42872c29b 100644 --- a/sw/source/uibase/uiview/viewdraw.cxx +++ b/sw/source/uibase/uiview/viewdraw.cxx @@ -162,18 +162,17 @@ void SwView::ExecDraw(SfxRequest& rReq) const SwRect& rVisArea = comphelper::LibreOfficeKit::isActive() ? m_pWrtShell->getLOKVisibleArea() : m_pWrtShell->VisArea(); Point aPos( rVisArea.Center() ); +tools::Rectangle aObjRect( pObj->GetLogicRect() ); -if( rVisArea.Width() > aDocSize.Width()) +if ( rVisArea.Width() > aDocSize.Width()) aPos.setX( aDocSize.Width() / 2 + rVisArea.Left() ); +else if (aPos.getX() > aObjRect.GetWidth() / 2) + aPos.AdjustX( -(aObjRect.GetWidth() / 2) ); -if(rVisArea.Height() > aDocSize.Height()) +if (rVisArea.Height() > aDocSize.Height()) aPos.setY( aDocSize.Height() / 2 + rVisArea.Top() ); - -tools::Rectangle aObjRect( pObj->GetLogicRect() ); -if (aPos.getX() > aObjRect.GetWidth() / 2) -aPos.AdjustX( -(aObjRect.GetWidth() / 2) ); -if (aPos.getY() > aObjRect.GetHeight() / 2) -aPos.AdjustY( -(aObjRect.GetHeight() / 2) ); +else if (aPos.getY() > aObjRect.GetHeight() / 2) + aPos.AdjustY( -(aObjRect.GetHeight() / 2) ); m_pWrtShell->EnterStdMode(); m_pWrtShell->SwFEShell::InsertDrawObj( *pObj, aPos ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140909] New: calc: calculation: basic macro: wrapping function (rawsubtract) wrong result - different than use in sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=140909 Bug ID: 140909 Summary: calc: calculation: basic macro: wrapping function (rawsubtract) wrong result - different than use in sheet Product: LibreOffice Version: 6.2.8.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: newbie...@gmx.de Description: hello, i'm trying to do some 'exact' calculations with calc, and 'rawsubtract' sometimes helps me to avoid idiosyncratic 'rounding' of calc, now i wanted to automate something like this the other day, and 'rawsubtract' is unfortunately not available in basic macros, but you can 'wrap' it in a 'unoservice-function-access-call' like in the example below, and then use it in basic macros (i'd read somewhere and it works fine so far, for other functions as well as for rawsubtract), but for certain values e.g. '=RAWSUBTRACT_A(33,1;3,1)' delivers 29,9000 as result, while '=RAWSUBTRACT_A(33,1;3,1)' correctly calculates to 30, so there is a worm in there somewhere, but i can't find where :-( since it's an elementary worm - elementary functions don't work - i think it's important to get rid of it and would be happy if a dev would look for it ... function rawsubtract_a (ByVal darg1 as Double, darg2 as Double) 'bs: 2021-03-09 'make "RAWSUBTRACT" functionality accessible from basic macros, oFunctionAccess = createUnoService( "com.sun.star.sheet.FunctionAccess") result = oFunctionAccess.callFunction( "RAWSUBTRACT", array(darg1, darg2)) rawsubtract_a = result end function 'rawsubtract_a yet investigated: args look well in basic, result is wrong in already in macro, thus less likely a 'handover problem'? result is exactly 1E-13 off while having capa (granularity) to store values with 1E-14 precision (in the bits / digits not shown in the sheet but accessible with appr. 'rawsubtract'), Steps to Reproduce: 1. place the macro in your macro collection, 2. key '=RAWSUBTRACT(33,1;3,1)' in a cell, 3. observe result: 30,, correct 4. key '=RAWSUBTRACT_A(33,1;3,1)' in a cell, 5. observe result: 29,9000, wrong Actual Results: 29,9000 Expected Results: 30, Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 722ec600e85cca2e94e82e69f8d13773061172b9 CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source vcl/win
vcl/source/app/svmain.cxx |2 +-
vcl/win/dtrans/WinClipboard.cxx | 37 +
vcl/win/dtrans/WinClipboard.hxx | 19 ---
3 files changed, 26 insertions(+), 32 deletions(-)
New commits:
commit 5d658689dd2994fd1cb7c2fc722b86befd78dcba
Author: Mike Kaganski
AuthorDate: Tue Mar 9 10:10:25 2021 +0300
Commit: Mike Kaganski
CommitDate: Tue Mar 9 10:00:41 2021 +0100
Simplify CWinClipboard mutexes
This replaces a home-grown ancestor class with use of cppu::BaseMutex,
and moves/renames mutexes to better reflect their use.
Change-Id: I6a9dd2e19ff7db524dc753d42e2027c4d5b2bb6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112188
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 449199ef7472..7eb83ab10ecf 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -489,7 +489,7 @@ void DeInitVCL()
pSVData->m_xSystemClipboard, css::uno::UNO_QUERY))
{
SolarMutexReleaser r; // unblock pending "clipboard content changed"
notifications
-comp->dispose(); // will use CWinClipbImpl::s_aMutex
+comp->dispose(); // will use s_aClipboardSingletonMutex for
CWinClipboard
}
pSVData->m_xSystemClipboard.clear();
#endif
diff --git a/vcl/win/dtrans/WinClipboard.cxx b/vcl/win/dtrans/WinClipboard.cxx
index 407325b14280..23b20449e0c5 100644
--- a/vcl/win/dtrans/WinClipboard.cxx
+++ b/vcl/win/dtrans/WinClipboard.cxx
@@ -49,29 +49,34 @@
using namespace com::sun::star;
-// definition of static members
-CWinClipboard* CWinClipboard::s_pCWinClipbImpl = nullptr;
-osl::Mutex CWinClipboard::s_aMutex;
+namespace
+{
+CWinClipboard* s_pCWinClipbImpl = nullptr;
+osl::Mutex s_aClipboardSingletonMutex;
+}
/*XEventListener,*/
CWinClipboard::CWinClipboard(const uno::Reference&
rxContext,
const OUString& aClipboardName)
-: WeakComponentImplHelper(
- m_aCbListenerMutex)
+: WeakComponentImplHelper(m_aMutex)
, m_xContext(rxContext)
, m_itsName(aClipboardName)
, m_pCurrentClipContent(nullptr)
{
// necessary to reassociate from
// the static callback function
-s_pCWinClipbImpl = this;
+{
+osl::MutexGuard aGuard(s_aClipboardSingletonMutex);
+s_pCWinClipbImpl = this;
+}
+
registerClipboardViewer();
}
CWinClipboard::~CWinClipboard()
{
{
-osl::MutexGuard aGuard(s_aMutex);
+osl::MutexGuard aGuard(s_aClipboardSingletonMutex);
s_pCWinClipbImpl = nullptr;
}
@@ -88,7 +93,7 @@ CWinClipboard::~CWinClipboard()
uno::Reference SAL_CALL
CWinClipboard::getContents()
{
-osl::MutexGuard aGuard(m_aMutex);
+osl::MutexGuard aGuard(m_aContentMutex);
if (rBHelper.bDisposed)
throw lang::DisposedException("object is already disposed",
@@ -97,7 +102,7 @@ uno::Reference SAL_CALL
CWinClipboard::getContents(
// use the shortcut or create a transferable from
// system clipboard
{
-osl::MutexGuard aGuard2(m_ClipContentMutex);
+osl::MutexGuard aGuard2(m_aContentCacheMutex);
if (nullptr != m_pCurrentClipContent)
return m_pCurrentClipContent->m_XTransferable;
@@ -122,7 +127,7 @@ uno::Reference SAL_CALL
CWinClipboard::getContents(
std::vector aFormats(aUINTFormats.begin(),
aUINTFormats.end());
rClipContent = new CDOTransferable(m_xContext, this, aFormats);
-osl::MutexGuard aGuard2(m_ClipContentMutex);
+osl::MutexGuard aGuard2(m_aContentCacheMutex);
m_foreignContent = rClipContent;
}
}
@@ -132,7 +137,7 @@ uno::Reference SAL_CALL
CWinClipboard::getContents(
IDataObjectPtr CWinClipboard::getIDataObject()
{
-osl::MutexGuard aGuard(m_aMutex);
+osl::MutexGuard aGuard(m_aContentMutex);
if (rBHelper.bDisposed)
throw lang::DisposedException("object is already disposed",
@@ -156,7 +161,7 @@ void SAL_CALL CWinClipboard::setContents(
const uno::Reference& xTransferable,
const uno::Reference&
xClipboardOwner)
{
-osl::MutexGuard aGuard(m_aMutex);
+osl::MutexGuard aGuard(m_aContentMutex);
if (rBHelper.bDisposed)
throw lang::DisposedException("object is already disposed",
@@ -167,7 +172,7 @@ void SAL_CALL CWinClipboard::setContents(
if (xTransferable.is())
{
{
-osl::MutexGuard aGuard2(m_ClipContentMutex);
+osl::MutexGuard aGuard2(m_aContentCacheMutex);
m_foreignContent.clear();
@@ -195,7 +200,7 @@ OUString SAL_CALL CWinClipboard::getName()
void SAL_CALL CWinClipboard::flushClipboard()
{
-osl::MutexGuard aGuard(m_aMutex);
+osl::MutexGuard aGuard(m_aContentMutex);
if (rBHelper.bDisposed)
throw lang::DisposedException("object is already disposed",
@@ -353,7 +358,7 @@ void
[Libreoffice-bugs] [Bug 128703] Find & Replace Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128703 --- Comment #6 from andreas_k --- (In reply to Heiko Tietze from comment #5) > Created attachment 170363 [details] > First patch applied > > Commented on Gerrit Should I add some kind of label for the buttons Attributes, Format and No Format? Space is available and maybe it's than more clear. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128703] Find & Replace Dialog update
https://bugs.documentfoundation.org/show_bug.cgi?id=128703 --- Comment #5 from Heiko Tietze --- Created attachment 170363 --> https://bugs.documentfoundation.org/attachment.cgi?id=170363=edit First patch applied Commented on Gerrit -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - include/svx sd/source svx/source
include/svx/svdedtv.hxx|6 +-
sd/source/ui/func/futransf.cxx | 13 -
svx/source/svdraw/svdedtv1.cxx |8 +++-
3 files changed, 20 insertions(+), 7 deletions(-)
New commits:
commit 206c5b374eb56ef1674bb0dbd0d199d2761ea469
Author: mert
AuthorDate: Thu Mar 4 12:17:27 2021 +0300
Commit: Mert Tumer
CommitDate: Tue Mar 9 09:37:31 2021 +0100
Fix wrong position on move when page has margin
Change-Id: I9ac2d9914b86210ca2148b44488c2c70cc5870d4
Signed-off-by: mert
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111949
Reviewed-by: Miklos Vajna
Tested-by: Jenkins CollaboraOffice
diff --git a/include/svx/svdedtv.hxx b/include/svx/svdedtv.hxx
index 973a28cd1b9e..4351ccee2764 100644
--- a/include/svx/svdedtv.hxx
+++ b/include/svx/svdedtv.hxx
@@ -305,7 +305,11 @@ public:
// geometrical attribute (position, size, rotation angle)
// A PageOrigin set at a position is taken into account.
SfxItemSet GetGeoAttrFromMarked() const;
-void SetGeoAttrToMarked(const SfxItemSet& rAttr);
+// In LOK, interactive shape movement uses this function
+// in that case, margin is not taken into account
+// and the final position of the shape becomes incorrect
+// However, "Position and Size" dialog and other cases already add the
margins.
+void SetGeoAttrToMarked(const SfxItemSet& rAttr, bool addPageMargin =
false);
// Returns NULL if:
// - nothing is marked,
diff --git a/sd/source/ui/func/futransf.cxx b/sd/source/ui/func/futransf.cxx
index 96a805040cb9..a0dc99664c3f 100644
--- a/sd/source/ui/func/futransf.cxx
+++ b/sd/source/ui/func/futransf.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
@@ -48,14 +49,13 @@ rtl::Reference FuTransform::Create( ViewShell*
pViewSh, ::sd::Window* pW
namespace {
-void setUndo(::sd::View* pView, const SfxItemSet* pArgs)
+void setUndo(::sd::View* pView, const SfxItemSet* pArgs, bool addPageMargin)
{
// Undo
OUString aString = pView->GetDescriptionOfMarkedObjects() +
" " + SdResId(STR_TRANSFORM);
pView->BegUndo(aString);
-
-pView->SetGeoAttrToMarked(*pArgs);
+pView->SetGeoAttrToMarked(*pArgs, addPageMargin);
pView->SetAttributes(*pArgs);
pView->EndUndo();
}
@@ -71,7 +71,9 @@ void FuTransform::DoExecute( SfxRequest& rReq )
if (pArgs)
{
-setUndo(mpView, pArgs);
+// If this comes from LOK, that means the shape is moved by mouse
+// only then pArgs is pre-set.
+setUndo(mpView, pArgs, comphelper::LibreOfficeKit::isActive());
return;
}
@@ -116,7 +118,8 @@ void FuTransform::DoExecute( SfxRequest& rReq )
if (nResult == RET_OK)
{
pRequest->Done(*(pDlg->GetOutputItemSet()));
-setUndo(mpView, pRequest->GetArgs());
+// Page margin is already calculated at this point.
+setUndo(mpView, pRequest->GetArgs(), false);
}
// deferred until the dialog ends
diff --git a/svx/source/svdraw/svdedtv1.cxx b/svx/source/svdraw/svdedtv1.cxx
index cf29f4a268df..830ef238c590 100644
--- a/svx/source/svdraw/svdedtv1.cxx
+++ b/svx/source/svdraw/svdedtv1.cxx
@@ -1534,7 +1534,7 @@ static Point ImpGetPoint(const tools::Rectangle& rRect,
RectPoint eRP)
return Point(); // Should not happen!
}
-void SdrEditView::SetGeoAttrToMarked(const SfxItemSet& rAttr)
+void SdrEditView::SetGeoAttrToMarked(const SfxItemSet& rAttr, bool
addPageMargin)
{
const bool bTiledRendering = comphelper::LibreOfficeKit::isActive();
@@ -1542,6 +1542,12 @@ void SdrEditView::SetGeoAttrToMarked(const SfxItemSet&
rAttr)
if(GetSdrPageView())
{
+if (addPageMargin)
+{
+SdrPage * pPage = GetSdrPageView()->GetPage();
+Point upperLeft(pPage->GetLeftBorder(), pPage->GetUpperBorder());
+aRect.Move(upperLeft.getX(), upperLeft.getY());
+}
GetSdrPageView()->LogicToPagePos(aRect);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140866] Cell comments disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=140866 --- Comment #4 from Juan Aspeitiagoitia --- This is the file where disapperar comments en some cells: https://drive.google.com/file/d/1ukEYv6orQQcawPBC_uwJCW8IVyjm_DIl/view?usp=sharing and three images in which you can see the cells with comments and most of them disappear when opening the file with version 7.1.1: https://drive.google.com/file/d/1cIeqA0GGGn2eZQA_4NIy6pROPFaR2xpq/view?usp=sharing https://drive.google.com/file/d/11bxJ4tnviCM9BTnuDJCRbBEt2ZT89NNt/view?usp=sharing https://drive.google.com/file/d/12Ozv4X4MTlo0IZaCl_ijvtnzqCs9fO88/view?usp=sharing -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140852] FILEOPEN PPTX: text box shows as half the width (and with an extra bullet)
https://bugs.documentfoundation.org/show_bug.cgi?id=140852 Timur changed: What|Removed |Added CC||vmik...@collabora.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0028 Priority|medium |high --- Comment #7 from Timur --- Bisect 6.2: from all good text to nothing (master text) commit e775b2f2dc93b3cefecae169623c0d4b2afc1160 Date: Fri Sep 21 13:51:26 2018 +0200 source sha:aef569ed83a3ccc02639e5b2a1c7cc131ba262fc prev source sha:356db87a6b622722d0d04ee3e17730a96865770a https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=356db87a6b622722d0d04ee3e17730a96865770a..aef569ed83a3ccc02639e5b2a1c7cc131ba262fc author Miklos Vajna 2018-09-21 11:50:57 +0200 committer Miklos Vajna 2018-09-21 13:30:20 +0200 commit aef569ed83a3ccc02639e5b2a1c7cc131ba262fc (patch) tree90bf85cdf5359ec5e30d396cd13d33e924fb parent 356db87a6b622722d0d04ee3e17730a96865770a (diff) tdf#120028 PPTX import: map shapes with multiple columns to table shapes Longer term the core Impress shape has to be improved so that it can have text in multiple columns. Shorter term, map text with multiple columns to table shapes, that gives correct layout in many cases and requires changes to the import filter only. Bisect 6.3: from nothing to text with bullet and master text commit e00da6fa3b75565ddcbdb995774101bbd0c373cb Date: Wed May 8 14:47:04 2019 +0200 source sha:d0119ff7f2c68aa05286bd303128f3a69c6bbd6a prev source sha:5218ca22b472a80969a715e38d7cb8d052be4b6a https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=5218ca22b472a80969a715e38d7cb8d052be4b6a..d0119ff7f2c68aa05286bd303128f3a69c6bbd6a author Noel Grandin 2019-05-06 11:33:41 +0200 committer Thorsten Behrens 2019-05-08 12:42:53 +0200 commit d0119ff7f2c68aa05286bd303128f3a69c6bbd6a (patch) tree80fc2e52ceb8446997348eda9186cbdfcd247298 parent 5218ca22b472a80969a715e38d7cb8d052be4b6a (diff) improve tools::Rectangle->basegfx::B2?Rectangle conversion Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Bisect 7.0: from text with bullet and master text to half-size text with bullet commit 240b633f8831d18e8a4df2beb2a6704246e21e76 Date: Wed Sep 2 03:53:36 2020 +0200 source sha:8faf8f173fe75bfa27b615db0ea177941a775724 prev source sha:30646d9db67cca8902a1a456f57dfdc9c30b https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=30646d9db67cca8902a1a456f57dfdc9c30b..8faf8f173fe75bfa27b615db0ea177941a775724 author Gülşah Köse 2020-08-08 00:34:37 +0300 committer Xisco Fauli 2020-09-01 18:00:44 +0200 commit 8faf8f173fe75bfa27b615db0ea177941a775724 (patch) treea2a366a9f213aa27c2af8dd0129ea68e472a852b parent 30646d9db67cca8902a1a456f57dfdc9c30b (diff) tdf#133015 Inherit numCol from placeholder. I raise importance because this is not a single document but a series of changes that didn't fix the first regression. Adding Miklos to CC, please see. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/win
vcl/win/dtrans/WinClipboard.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 067b22aeff5ff256be393dc2aa14acdf0300427a
Author: Stephan Bergmann
AuthorDate: Mon Mar 8 17:39:58 2021 +0100
Commit: Stephan Bergmann
CommitDate: Tue Mar 9 09:30:34 2021 +0100
loplugin:redundantstatic (clang-cl)
Change-Id: Ieb4d3a008d84a16de490413b92b506a59dee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112178
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/vcl/win/dtrans/WinClipboard.cxx b/vcl/win/dtrans/WinClipboard.cxx
index 2100510b5d34..407325b14280 100644
--- a/vcl/win/dtrans/WinClipboard.cxx
+++ b/vcl/win/dtrans/WinClipboard.cxx
@@ -324,7 +324,7 @@ uno::Sequence SAL_CALL
CWinClipboard::getSupportedServiceNames()
// We run unit tests in parallel, which is a problem when touching a shared
resource
// the system clipboard, so rather use the dummy GenericClipboard.
-static const bool bRunningUnitTest = getenv("LO_TESTNAME");
+const bool bRunningUnitTest = getenv("LO_TESTNAME");
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
dtrans_CWinClipboard_get_implementation(css::uno::XComponentContext* context,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: fpicker/source
fpicker/source/win32/VistaFilePickerImpl.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit bb5900acfe6e250c75c34cd37e752bae3a80
Author: Stephan Bergmann
AuthorDate: Mon Mar 8 17:23:05 2021 +0100
Commit: Stephan Bergmann
CommitDate: Tue Mar 9 09:30:07 2021 +0100
-Werror,-Wshadow (clang-cl)
Change-Id: I8b39e510266404a28acb380f449862366c647b87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112173
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/fpicker/source/win32/VistaFilePickerImpl.cxx
b/fpicker/source/win32/VistaFilePickerImpl.cxx
index 29eb33409e80..5e275e4657c8 100644
--- a/fpicker/source/win32/VistaFilePickerImpl.cxx
+++ b/fpicker/source/win32/VistaFilePickerImpl.cxx
@@ -537,7 +537,7 @@ void VistaFilePickerImpl::impl_sta_InitDialog(const
RequestRef& rRequest, DWORD
aAny >>= tmp;
if(tmp != 0)
{
-osl::MutexGuard aLock(m_aMutex);
+osl::MutexGuard aLock2(m_aMutex);
m_hParentWindow = reinterpret_cast(tmp);
}
}
@@ -1018,7 +1018,7 @@ void VistaFilePickerImpl::impl_sta_ShowDialogModal(const
RequestRef& rRequest)
HRESULT hResult = E_FAIL;
HWND hParentWindow;
{
-osl::MutexGuard aLock(m_aMutex);
+osl::MutexGuard aLock2(m_aMutex);
// Note that there is a potential race between retrieving and
// using parent window (window might get destroyed)
hParentWindow = m_hParentWindow ? m_hParentWindow :
choose_parent_window();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: fpicker/source
fpicker/source/win32/VistaFilePickerImpl.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 351b2382465087d18a3ad44509c2a3a66ca08aa6
Author: Stephan Bergmann
AuthorDate: Mon Mar 8 17:24:59 2021 +0100
Commit: Stephan Bergmann
CommitDate: Tue Mar 9 09:29:48 2021 +0100
-Werror,-Wnon-virtual-dtor (clang-cl)
Change-Id: I1f02e154e090ad89ca2e664467d7514f1cbdcb2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112174
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/fpicker/source/win32/VistaFilePickerImpl.cxx
b/fpicker/source/win32/VistaFilePickerImpl.cxx
index dbbe72e18ee4..29eb33409e80 100644
--- a/fpicker/source/win32/VistaFilePickerImpl.cxx
+++ b/fpicker/source/win32/VistaFilePickerImpl.cxx
@@ -106,6 +106,8 @@ public:
{
}
+virtual ~TDialogImplBase() = default;
+
TFileDialog getComPtr() { return m_iDialog; }
virtual sal::systools::COMReference getResult(bool
bInExecute)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 140852] FILEOPEN PPTX: text box shows as half the width (and with an extra bullet)
https://bugs.documentfoundation.org/show_bug.cgi?id=140852 --- Comment #6 from Timur --- As for bullet, it's also a regression, looks the same one and even cause of all this, so be kept here. Bullet wasn't three in 6.2 oldest and all was correct, but 6.2 master has no proper text at all, just text from master slide. Change in 6.3 bibisect wasn't quite correct for this bug example, text appeared but with bullet and master text. Seems that it wasn't bug report related fix, but general fix by Noel. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140908] New: shlxthdl.dll Libre Office Column Handler crashes explorer.exe while previewing TIFFs first time
https://bugs.documentfoundation.org/show_bug.cgi?id=140908 Bug ID: 140908 Summary: shlxthdl.dll Libre Office Column Handler crashes explorer.exe while previewing TIFFs first time Product: LibreOffice Version: 7.0.4.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jwl...@web.de Description: If I use explorer.exe to preview TIFF files for the first time, explorer.exe crashes after appr. 10 files. I tested the shell extensions with shexiew.exe and found out, that the issue is caused by the LibreOffice Column Handler (Vers. 7.0.4.2). After disabling it, everything works fine again. Steps to Reproduce: 1. Open explorer.exe 2. Change to directory with TIFFs 3. Preview TIFFs (large symbols) Actual Results: explorer.exe crashes. It closes and reopens again. The preview generation is stopped and has to start again. Expected Results: All the previews in the directory should be generated normally. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.0.4.2 (x64) Build ID: dcf040e67528d9187c66b2379df5ea4407429775 CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140907] New: EDITING: copying of a text strings into a text field fails
https://bugs.documentfoundation.org/show_bug.cgi?id=140907 Bug ID: 140907 Summary: EDITING: copying of a text strings into a text field fails Product: LibreOffice Version: 7.0.1.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d.sbrag...@neomerica.it Hello, it looks like pasting of text fields no longer works in the latest LO Base release version. If some text is pasted into a text field it gets delete as soon as the focus is moved to a different field. It looks like LO doesn't see the field as modified and reloads the previous value. If some char is added by keypress just after pasting the pasted text is retained, even if the added char is deleted immediately after adding it. This happens only with text fields, numeric fields work as expected. Bye, Denis Sbragion -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e3feffe94ae3b1ab6cc68fadc7dc5aa19363941b Author: Ayhan Yalçınsoy AuthorDate: Wed Mar 3 16:14:02 2021 +0300 Commit: Heiko Tietze CommitDate: Tue Mar 9 09:19:02 2021 +0100 tdf#139683: Specified PDF functions in customise dialog Change-Id: Ic3ae51219391c8fe4e66640b5c7769fed39e149c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111904 Tested-by: Jenkins Reviewed-by: Heiko Tietze diff --git a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu index 6165cd8d0b61..fe562574ef86 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu @@ -5098,7 +5098,7 @@ bit 3 (0x8): #define UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8 - PDF + Export as PDF ~Export as PDF... @@ -5112,7 +5112,7 @@ bit 3 (0x8): #define UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8 - PDF + Export Directly as PDF Export Directly as PDF ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 41560] [META] Keyboard shortcuts tab of Customization dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=41560 Bug 41560 depends on bug 139683, which changed state. Bug 139683 Summary: Shortcuts: Specify PDF functions in customise dialog https://bugs.documentfoundation.org/show_bug.cgi?id=139683 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: proposition for patch in CommonSalLayout.cxx
Hi Stan,
On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz
wrote:
> Dear all,
>
> I noticed that LibreOffice is using the hard coded harfbuzz shapers list in
> CommonSalLayout.cxx file (line 470).
> I recommend the patch attached to be more flexible.
> This take all possible shapers in a given HarfBuzz implementation.
> This also allows the use of newly created shapers.
>
> Just repleces line:
> - const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot",
> "fallback", nullptr };
>
> with:
> + const char **pHbShapers = hb_shape_list_shapers();
Are you more or less reverting 7854d35cd8172b201f1f3ad247860f242e5cb06b?
Can you describe what is the practical benefit of doing so?
Regards,
Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 139606] On Writer's standard TB and Insert menu: replace current "Text Box" a draw shape (.uno:DrawText) with the interactive frame with column (.uno:InsertFrameInteract) contr
https://bugs.documentfoundation.org/show_bug.cgi?id=139606 Heiko Tietze changed: What|Removed |Added Keywords||difficultyBeginner, ||easyHack, skillDesign, ||topicUI --- Comment #12 from Heiko Tietze --- (In reply to sdc.blanco from comment #11) > Are the points in comment 4 considered part of this ticket? It is the essence of the solution. See also comment 3 for code pointer. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 140883] textcvt.cxx is "Missing rtl_TextToUnicodeConverter" on startup
https://bugs.documentfoundation.org/show_bug.cgi?id=140883 --- Comment #3 from Stephan Bergmann --- (In reply to Eyal Rozenberg from comment #0) > 1. The message should say _what_ is missing that rtl_TextToUnicodeConverter. > 2. The message should say what kind of entity is missing: Is it a section in > a file? A function which should have been available to LO via a dynamic > library? A configuration setting? These warning messages are targeting a developer audience (similar to C/C++ asserts). And the information they provide needs to take into account the cost of obtaining that information. For example, in this specific case, the given SAL_WARN is already presenting all the relevant information that is available locally (i.e., close to zero). If you are uncomfortable with seeing such warning messages on stderr, you should probably not be running "a recent daily build". > I would probably have another complaint or two if I knew the answer to these > questions. This isn't a venue to air complaints. If you see an issue besides the stderr output itself that you want to report, then please state that issue, as clearly and as thoroughly as possible. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
