[Libreoffice-bugs] [Bug 127208] Tilde displays like macron (Linux-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=127208 Buovjaga changed: What|Removed |Added Version|6.0.7.3 release |3.5.0 release Status|UNCONFIRMED |NEW CC||ilmari.lauhakangas@libreoff ||ice.org Ever confirmed|0 |1 Summary|tilde displays like macron |Tilde displays like macron ||(Linux-only) --- Comment #9 from Buovjaga --- Confirmed with all Linux VCL backends. Already seen in oldest of Linux 43all bibisect repo. Not seen on Windows. Arch Linux 64-bit Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 77419c6f3aba1fd5b1660795923c22a39bdb1bad CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: kf5 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 14 April 2021 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 101803] Loss of hide with condition for a section when having a (second?) section at the end of the document
https://bugs.documentfoundation.org/show_bug.cgi?id=101803 Gabriele Ponzo changed: What|Removed |Added CC||gpo...@gmail.com --- Comment #6 from Gabriele Ponzo --- I can confirm that the bug is still present in version 7.1.2.2. Moreover it behaves the same wrong way regardless of setting a condition or not: as far as a section becomes hidden, for whatever reason, it won't be visible anymore in any way. Should I open a different bug for this? Version: 7.1.2.2 / LibreOffice Community Build ID: 10(Build:2) CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: it-IT (it_IT.UTF-8); UI: en-GB Ubuntu package version: 1:7.1.2~rc2-0ubuntu0.20.04.1~lo3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136410] LibreOffice download page download incorrect OS file
https://bugs.documentfoundation.org/show_bug.cgi?id=136410 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Buovjaga --- It works for me. Can you try again? Btw. website issues do not normally go into Bugzilla: https://wiki.documentfoundation.org/QA/BugReport#Not_all_bugs_go_to_Bugzilla -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/fontmanager/fontconfig.cxx | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
New commits:
commit b7a38c1dfeab7c5eebb7fd5bc571e68b343bffb7
Author: Caolán McNamara
AuthorDate: Tue Apr 13 20:45:24 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Apr 14 09:46:21 2021 +0200
hintstyle is unused
left behind after...
commit 561a02ec72cf963d7cd59cfb9a183c1032f0861b
Date: Thu Jun 15 15:28:46 2017 +0200
loplugin:unusedfields in vcl part3
Change-Id: Iaf76a02a6f85e5bb3e72d0f4804d3cf4601dca64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114068
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index 48428aa4be36..855868a022e4 100644
--- a/vcl/unx/generic/fontmanager/fontconfig.cxx
+++ b/vcl/unx/generic/fontmanager/fontconfig.cxx
@@ -1116,22 +1116,14 @@ std::unique_ptr
PrintFontManager::getFontOptions(const Fa
addtopattern(pPattern, rInfo.m_eItalic, rInfo.m_eWeight, rInfo.m_eWidth,
rInfo.m_ePitch);
FcPatternAddDouble(pPattern, FC_PIXEL_SIZE, nSize);
-int hintstyle = FC_HINT_FULL;
-
FcConfigSubstitute(pConfig, pPattern, FcMatchPattern);
FontConfigFontOptions::cairo_font_options_substitute(pPattern);
FcDefaultSubstitute(pPattern);
FcResult eResult = FcResultNoMatch;
FcFontSet* pFontSet = rWrapper.getFontSet();
-FcPattern* pResult = FcFontSetMatch( pConfig, , 1, pPattern,
);
-if( pResult )
-{
-(void) FcPatternGetInteger(pResult,
-FC_HINT_STYLE, 0, );
-
+if (FcPattern* pResult = FcFontSetMatch(pConfig, , 1, pPattern,
))
pOptions.reset(new FontConfigFontOptions(pResult));
-}
// cleanup
FcPatternDestroy( pPattern );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141680] SEVERE graphical tearing occurs when scrolling down Draw after introduction of new SKIA component, just Vulkan rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=141680 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org --- Comment #8 from Xisco Faulí --- I can't reproduce it in Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: da6c70efbc991f1fc61aace267dd4f972dedce6c CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141678] UNO Object Inspector: Class name unser inspection too far away (gen)
https://bugs.documentfoundation.org/show_bug.cgi?id=141678 Xisco Faulí changed: What|Removed |Added Summary|UNO Object Inspector: Class |UNO Object Inspector: Class |name unser inspection too |name unser inspection too |far away|far away (gen) CC||xiscofa...@libreoffice.org Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Xisco Faulí --- Another problem reproduced only in gen but not in GTK3 Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 77419c6f3aba1fd5b1660795923c22a39bdb1bad CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gen Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141474] Documentation specifies incorrect parameter names for Basic functions
https://bugs.documentfoundation.org/show_bug.cgi?id=141474 --- Comment #5 from Commit Notification --- Alain Romedenne committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/a26e51cc4e5af7eae340fcf20e31e991239def2d tdf#141474 MsgBox function signature -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141474] Documentation specifies incorrect parameter names for Basic functions
https://bugs.documentfoundation.org/show_bug.cgi?id=141474 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2465a0f3b83fcbcdfa9cdda459ffc62bef08e4ee Author: Alain Romedenne AuthorDate: Wed Apr 14 09:34:31 2021 +0200 Commit: Gerrit Code Review CommitDate: Wed Apr 14 09:34:31 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to a26e51cc4e5af7eae340fcf20e31e991239def2d - tdf#141474 MsgBox function signature Change-Id: I4a9a49a3af3379f96ae95c19135a44e7ae5fd29a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113998 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 7f3528e4c87f..a26e51cc4e5a 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 7f3528e4c87fb7bea49c715733abb041d4e0bd52 +Subproject commit a26e51cc4e5af7eae340fcf20e31e991239def2d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: source/text
source/text/sbasic/shared/03010101.xhp | 21 +-- source/text/sbasic/shared/03010102.xhp | 176 + 2 files changed, 16 insertions(+), 181 deletions(-) New commits: commit a26e51cc4e5af7eae340fcf20e31e991239def2d Author: Alain Romedenne AuthorDate: Tue Apr 13 11:59:28 2021 +0200 Commit: Alain Romedenne CommitDate: Wed Apr 14 09:34:31 2021 +0200 tdf#141474 MsgBox function signature Change-Id: I4a9a49a3af3379f96ae95c19135a44e7ae5fd29a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113998 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/sbasic/shared/03010101.xhp b/source/text/sbasic/shared/03010101.xhp index 095976844..c87987c70 100644 --- a/source/text/sbasic/shared/03010101.xhp +++ b/source/text/sbasic/shared/03010101.xhp @@ -26,27 +26,25 @@ - - MsgBox statement - -MsgBox Statement +MsgBox Statement Displays a dialog box containing a message. -Syntax: + -MsgBox Text As String [,Type As Integer [,Dialogtitle As String]] (As Statement) or MsgBox (Text As String [,Type As Integer [,Dialogtitle As String]]) (As Function) +MsgBox Prompt As String [,Buttons = MB_OK [,Title As String]] -Parameter: - Text: String expression displayed as a message in the dialog box. Line breaks can be inserted with Chr$(13). - DialogTitle: String expression displayed in the title bar of the dialog. If omitted, the title bar displays the name of the respective application. - Type: Any integer expression that specifies the dialog type, as well as the number and type of buttons to display, and the icon type. Type represents a combination of bit patterns, that is, a combination of elements can be defined by adding their respective values: + + + Prompt: String expression displayed as a message in the dialog box. Line breaks can be inserted with Chr$(13). + Title: String expression displayed in the title bar of the dialog. If omitted, the title bar displays the name of the respective application. + Buttons: Any integer expression that specifies the dialog type, as well as the number and type of buttons to display, and the icon type. Buttons represents a combination of bit patterns, that is, a combination of elements can be defined by adding their respective values: @@ -204,11 +202,12 @@ + -Example: + Sub ExampleMsgBox Const sText1 = "An unexpected error occurred." diff --git a/source/text/sbasic/shared/03010102.xhp b/source/text/sbasic/shared/03010102.xhp index 68eeba306..54ea9ad0f 100644 --- a/source/text/sbasic/shared/03010102.xhp +++ b/source/text/sbasic/shared/03010102.xhp @@ -34,183 +34,19 @@ -MsgBox Function +MsgBox Function Displays a dialog box containing a message and returns a value. -Syntax: + -MsgBox (Text As String [,Type As Integer [,Dialogtitle As String]]) +MsgBox (Prompt As String [,Buttons = MB_OK [,Title As String]]) As Integer -Return value: -Integer - -Parameter: - Text: String expression displayed as a message in the dialog box. Line breaks can be inserted with Chr$(13). - DialogTitle: String expression displayed in the title bar of the dialog. If omitted, the name of the respective application is displayed. - Type: Any integer expression that specifies the dialog type and defines the number and type of buttons or icons displayed. Type represents a combination of bit patterns (dialog elements defined by adding the respective values): - Values - - - - - Named constant - - - Integer value - - - Definition - - - - - MB_OK - - - 0 - - - Display OK button only. - - - - - MB_OKCANCEL - - - 1 - - - Display OK and Cancel buttons. - - - - - MB_ABORTRETRYCANCEL - - - 2 - - - Display Abort, Retry, and Ignore buttons. - - - - - MB_YESNOCANCEL - - - 3 - - - Display Yes, No, and Cancel buttons. - - - - - MB_YESNO - - - 4 - - - Display Yes and No buttons. - - - - - MB_RETRYCANCEL - - - 5 - - - Display Retry and Cancel buttons. - - - - - MB_ICONSTOP - - - 16 - - - Add the Stop icon to the dialog. - - - - - MB_ICONQUESTION - - - 32 - - - Add the Question icon to the dialog. - - - - - MB_ICONEXCLAMATION - - - 48 - - - Add the Exclamation Point icon to the dialog. - - - - - MB_ICONINFORMATION - - - 64 - - - Add the Information icon to the dialog. - - - - - - - - 128 - - - First button in the dialog as default button. - - - - - MB_DEFBUTTON2 - - - 256 - - -
[Libreoffice-bugs] [Bug 141622] Can't install LO language pack under macOS 10.13.6 and 10.14.6
https://bugs.documentfoundation.org/show_bug.cgi?id=141622 --- Comment #15 from Emanuel --- Correction: The MacBook Air is on Mac OS 10.14 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputwin.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 4f92acefe024a323c0a31ee991eff45eaf24029f
Author: Tor Lillqvist
AuthorDate: Tue Apr 13 17:14:57 2021 +0300
Commit: Tor Lillqvist
CommitDate: Wed Apr 14 09:15:26 2021 +0200
Early return from ScInputWindow::setPosSizePixel() if no-op
This seems to fix https://github.com/CollaboraOnline/online/issues/1988
Change-Id: I5fd826647ce85b7ad2d93085fb0c2fa9db69e745
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114056
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114070
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist
diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 2da8fd62746f..67c12839a4ac 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -478,6 +478,10 @@ void ScInputWindow::SetSizePixel( const Size& rNewSize )
void ScInputWindow::setPosSizePixel(tools::Long nX, tools::Long nY,
tools::Long nWidth, tools::Long nHeight, PosSizeFlags nFlags)
{
+if ((!(nFlags & PosSizeFlags::Size) || GetSizePixel() == Size(nWidth,
nHeight)) &&
+(!(nFlags & PosSizeFlags::Pos) || GetPosPixel() == Point(nX, nY)))
+return;
+
ToolBox::setPosSizePixel(nX, nY, nWidth, nHeight, nFlags);
if (const vcl::ILibreOfficeKitNotifier* pNotifier = GetLOKNotifier())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 141685] New: Formatting a table-row
https://bugs.documentfoundation.org/show_bug.cgi?id=141685 Bug ID: 141685 Summary: Formatting a table-row Product: LibreOffice Version: 7.0.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: daniel.rohde-k...@tu-dortmund.de Description: Trying to apply a format to a whole table-row doesn't work. Steps to Reproduce: You select a table row and choose 'no space' below a paragraph (for example to format a header). The formatting isn't applied to all columns. Actual Results: The formatting is applied only to the first column. Expected Results: The formatting should be applied to whole selection. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.5.2 (x64) Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137330] Autocorrect Exceptions tab's empty for all languages.
https://bugs.documentfoundation.org/show_bug.cgi?id=137330 Julien Nabet changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #8 from Julien Nabet --- Thank you for your feedback. Let's rather put WFM since there was no specific fix about this one. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135494] Pressed state mouse motion bug on Combo Box
https://bugs.documentfoundation.org/show_bug.cgi?id=135494 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| Resolution|FIXED |WORKSFORME --- Comment #6 from Dieter --- (In reply to UltraBurstXD from comment #5) > No, it appears fixed on latest version. Tested on LibreOffice 7.1, Ubuntu > 21.04 beta. Thanks for retesting! -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141674] writer: problem in conversion to .pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=141674 Timur changed: What|Removed |Added Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141674] writer: problem in conversion to .pdf
https://bugs.documentfoundation.org/show_bug.cgi?id=141674 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #7 from Timur --- Reporter, you need to reset user profile, as explained. Do not reply until you do it. Help-About is menu Help and About there, copy from it and paste. Attached pp.pdf doesn't have fonts. This is not normally reproducible, I tried both Linux and Windows. Reporter needs to Export as PDF with different options, until reason is found. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137330] Autocorrect Exceptions tab's empty for all languages.
https://bugs.documentfoundation.org/show_bug.cgi?id=137330 UltraBurstXD changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137799] LibreOffice's Writer slow when handling images
https://bugs.documentfoundation.org/show_bug.cgi?id=137799 UltraBurstXD changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108386] [META] Calc sorting related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108386 Bug 108386 depends on bug 126678, which changed state. Bug 126678 Summary: Empty cells with formatting not included in sort even though "Include formats" option is checked (see comment 6) https://bugs.documentfoundation.org/show_bug.cgi?id=126678 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/column.hxx | 18 sc/inc/document.hxx|5 +- sc/inc/table.hxx |7 +-- sc/qa/uitest/sort/tdf126678.py | 75 + sc/source/core/data/column2.cxx| 22 -- sc/source/core/data/document.cxx |7 +-- sc/source/core/data/table1.cxx | 24 +++ sc/source/ui/docshell/dbdocfun.cxx |7 +-- 8 files changed, 135 insertions(+), 30 deletions(-) New commits: commit 774a61afa9fc281290e7bfad4e28c05978b82d73 Author: Andreas Heinisch AuthorDate: Fri Feb 19 16:55:31 2021 +0100 Commit: Andreas Heinisch CommitDate: Wed Apr 14 08:46:03 2021 +0200 tdf#126678 - Consider "Include formats" option during sort Change-Id: Ib972ad6c5042bde6b0c79bf10bace6baab1e935e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111234 Tested-by: Jenkins Reviewed-by: Andreas Heinisch diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 4f88f556e9eb..56791cfd5f61 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -218,17 +218,19 @@ public: // data only: boolIsEmptyBlock(SCROW nStartRow, SCROW nEndRow) const; SCSIZE GetEmptyLinesInBlock( SCROW nStartRow, SCROW nEndRow, ScDirection eDir ) const; -boolHasDataAt(SCROW nRow, bool bConsiderCellNotes=false, - bool bConsiderCellDrawObjects=false) const; -boolHasDataAt(sc::ColumnBlockConstPosition& rBlockPos, SCROW nRow, bool bConsiderCellNotes=false, - bool bConsiderCellDrawObjects=false) const; -boolHasDataAt(sc::ColumnBlockPosition& rBlockPos, SCROW nRow, bool bConsiderCellNotes=false, - bool bConsiderCellDrawObjects=false); +boolHasDataAt(SCROW nRow, bool bConsiderCellNotes = false, + bool bConsiderCellDrawObjects = false, bool bConsiderCellFormats = false) const; +boolHasDataAt(sc::ColumnBlockConstPosition& rBlockPos, SCROW nRow, + bool bConsiderCellNotes = false, bool bConsiderCellDrawObjects = false, + bool bConsiderCellFormats = false) const; +boolHasDataAt(sc::ColumnBlockPosition& rBlockPos, SCROW nRow, bool bConsiderCellNotes = false, + bool bConsiderCellDrawObjects = false, bool bConsiderCellFormats = false); boolHasVisibleDataAt(SCROW nRow) const; SCROW GetFirstDataPos() const; SCROW GetLastDataPos() const; -SCROW GetLastDataPos( SCROW nLastRow, bool bConsiderCellNotes=false, -bool bConsiderCellDrawObjects=false ) const; +SCROW GetLastDataPos(SCROW nLastRow, bool bConsiderCellNotes = false, + bool bConsiderCellDrawObjects = false, + bool bConsiderCellFormats = false) const; boolGetPrevDataPos(SCROW& rRow) const; boolGetNextDataPos(SCROW& rRow) const; boolTrimEmptyBlocks(SCROW& rRowStart, SCROW& rRowEnd) const; diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index f9582dc4837b..96d7ec940059 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -1407,6 +1407,8 @@ public: If TRUE, consider the presence of cell notes besides data. @param bConsiderCellDrawObjects If TRUE, consider the presence of draw objects anchored to the cell. +@param bConsiderCellFormats +If TRUE, consider the presence of cell formats. @returns true if there is any data, false if not. */ @@ -1415,7 +1417,8 @@ public: SCCOL& rEndCol, SCROW& rEndRow, bool bColumnsOnly, bool bStickyTopRow = false, bool bStickyLeftCol = false, bool bConsiderCellNotes = false, - bool bConsiderCellDrawObjects = false ) const; + bool bConsiderCellDrawObjects = false, + bool bConsiderCellFormats = false ) const; /** * Return the last non-empty row position in given columns that's no diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx index ddc859715b8e..211e317cb06d 100644 --- a/sc/inc/table.hxx +++ b/sc/inc/table.hxx @@ -589,10 +589,11 @@ public: boolShrinkToUsedDataArea( bool& o_bShrunk, SCCOL& rStartCol, SCROW& rStartRow, SCCOL& rEndCol, SCROW& rEndRow, bool bColumnsOnly, bool bStickyTopRow, bool bStickyLeftCol, bool bConsiderCellNotes, - bool bConsiderCellDrawObjects ) const; + bool
[Libreoffice-bugs] [Bug 135494] Pressed state mouse motion bug on Combo Box
https://bugs.documentfoundation.org/show_bug.cgi?id=135494 UltraBurstXD changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135494] Pressed state mouse motion bug on Combo Box
https://bugs.documentfoundation.org/show_bug.cgi?id=135494 --- Comment #5 from UltraBurstXD --- No, it appears fixed on latest version. Tested on LibreOffice 7.1, Ubuntu 21.04 beta. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/inc/layact.hxx| 24 +--
sw/source/core/layout/layact.cxx | 60 +--
sw/source/core/view/viewsh.cxx |1
3 files changed, 49 insertions(+), 36 deletions(-)
New commits:
commit 0fedac18214a6025401c4c426466a5166553e8ec
Author: Luke Deller
AuthorDate: Fri Apr 9 09:08:37 2021 +1000
Commit: Miklos Vajna
CommitDate: Wed Apr 14 08:25:05 2021 +0200
tdf#141556 Fix 100% CPU usage in Writer idle loop
Do not interrupt the idle layout processing unnecessarily, because if it
is continually interrupted before making enough progress then it will
keep resuming at the same page, never finishing, constantly using CPU.
This is achieved with two changes:
- Revert "tdf#123583 use TaskStopwatch for Writer Idle loop"
(commit 383032c50a3e3354f04200ce984a47ab9d2c5c67) which
introduced a stopwatch timer to interrupt idle processing every 50ms.
This reversion restores the previous behaviour where idle processing
is interrupted only when there is an input event.
- Filter out TIMER events so that they do not interrupt the idle loop;
this fixes both tdf#123583 and tdf#141556
Conflicts:
sw/source/core/inc/layact.hxx
sw/source/core/layout/layact.cxx
Change-Id: Ic989631e5f32199209d64b66b72059253fc0167a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113825
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
Reviewed-by: Miklos Vajna
diff --git a/sw/source/core/inc/layact.hxx b/sw/source/core/inc/layact.hxx
index 4729ea85ebff..f46c090dbb20 100644
--- a/sw/source/core/inc/layact.hxx
+++ b/sw/source/core/inc/layact.hxx
@@ -21,7 +21,7 @@
#include
-#include
+#include
#include
#include
@@ -56,7 +56,6 @@ class SwLayAction
{
SwRootFrame *m_pRoot;
SwViewShellImp *m_pImp; // here the action logs in and off
-TaskStopwatch* m_pWatch;
// For the sake of optimization, so that the tables stick a bit better to
// the Cursor when hitting return/backspace in front of one.
@@ -75,6 +74,7 @@ class SwLayAction
std::clock_t m_nStartTicks; // The Action's starting time; if too
much time passes the
// WaitCursor can be enabled via
CheckWaitCursor()
+VclInputFlags m_nInputType; // Which input should terminate processing
sal_uInt16 m_nEndPage;// StatBar control
sal_uInt16 m_nCheckPageNum; // CheckPageDesc() was delayed if !=
USHRT_MAX
// check from this page onwards
@@ -84,8 +84,9 @@ class SwLayAction
bool m_bCalcLayout;// Complete reformatting?
bool m_bAgain; // For the automatically repeated Action if Pages
are deleted
bool m_bNextCycle; // Reset on the first invalid Page
+bool m_bInput; // For terminating processing on input
+bool m_bIdle; // True if the LayAction was triggered by the Idler
bool m_bReschedule;// Call Reschedule depending on Progress?
-bool m_bInterrupt; // For termination the layouting
bool m_bCheckPages;// Run CheckPageDescs() or delay it
bool m_bUpdateExpFields; // Is set if, after Formatting, we need to do
another round for ExpField
bool m_bBrowseActionStop; // Terminate Action early (as per bInput) and
leave the rest to the Idler
@@ -123,26 +124,33 @@ class SwLayAction
bool RemoveEmptyBrowserPages();
+inline void CheckIdleEnd();
+
public:
-SwLayAction(SwRootFrame *pRt, SwViewShellImp *pImp, TaskStopwatch* pWatch
= nullptr);
+SwLayAction( SwRootFrame *pRt, SwViewShellImp *pImp );
~SwLayAction();
+void SetIdle( bool bNew ) { m_bIdle = bNew; }
void SetCheckPages ( bool bNew ) { m_bCheckPages = bNew; }
void SetBrowseActionStop( bool bNew ) { m_bBrowseActionStop = bNew; }
void SetNextCycle ( bool bNew ) { m_bNextCycle = bNew; }
bool IsWaitAllowed()const { return m_bWaitAllowed; }
bool IsNextCycle() const { return m_bNextCycle; }
+bool IsInput() const { return m_bInput; }
bool IsPaint() const { return m_bPaint; }
+bool IsIdle() const { return m_bIdle; }
bool IsReschedule() const { return m_bReschedule; }
-bool IsIdle() const { return m_pWatch != nullptr; }
-bool IsPaintExtraData() const { return m_bPaintExtraData; }
-bool IsInterrupt();
+bool IsPaintExtraData() const { return m_bPaintExtraData;}
+bool IsInterrupt() const { return IsInput(); }
+
+VclInputFlags GetInputType()const { return m_nInputType; }
// adjusting Action to the wanted behaviour
void SetPaint ( bool bNew ) { m_bPaint = bNew; }
void SetComplete( bool bNew ) { m_bComplete = bNew; }
[Libreoffice-bugs] [Bug 135494] Pressed state mouse motion bug on Combo Box
https://bugs.documentfoundation.org/show_bug.cgi?id=135494 Dieter changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||dgp-m...@gmx.de --- Comment #4 from Dieter --- UltraBurstXD, unfortunately could confirm this bug report during the last months. So I'd like to ask, if it is still valid. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137054] EDITING: Auto complete gave unexpected results while typing the word 'sleep'.
https://bugs.documentfoundation.org/show_bug.cgi?id=137054 Dieter changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- M Perkins, unfortunately could confirm this bug report during the last months. So I'd like to ask, if it is still valid. Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/CppunitTest_vcl_graphic_test.mk vcl/qa
vcl/CppunitTest_vcl_graphic_test.mk|2 +- vcl/qa/cppunit/VectorGraphicSearchTest.cxx |4 2 files changed, 1 insertion(+), 5 deletions(-) New commits: commit a4836c01a94454ae52aa97b29a7ec26fb26aa03c Author: Miklos Vajna AuthorDate: Tue Apr 13 20:44:50 2021 +0200 Commit: Miklos Vajna CommitDate: Wed Apr 14 08:19:23 2021 +0200 vcl VectorGraphicSearchTest: avoid HAVE_FEATURE_PDFIUM ifdef This is entirely specific to pdfium, so don't build it in the no-pdfium case. Towards completely avoiding the HAVE_FEATURE_PDFIUM ifdef forest. Change-Id: I127fce64d4ba1fffe529daf927311ed4d42d745f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114067 Tested-by: Jenkins Reviewed-by: Miklos Vajna diff --git a/vcl/CppunitTest_vcl_graphic_test.mk b/vcl/CppunitTest_vcl_graphic_test.mk index 901714eb820f..6089512f5b5b 100644 --- a/vcl/CppunitTest_vcl_graphic_test.mk +++ b/vcl/CppunitTest_vcl_graphic_test.mk @@ -14,7 +14,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,vcl_graphic_test, \ vcl/qa/cppunit/GraphicDescriptorTest \ vcl/qa/cppunit/GraphicFormatDetectorTest \ vcl/qa/cppunit/GraphicNativeMetadataTest \ -vcl/qa/cppunit/VectorGraphicSearchTest \ +$(if $(filter PDFIUM,$(BUILD_TYPE)),vcl/qa/cppunit/VectorGraphicSearchTest) \ vcl/qa/cppunit/BinaryDataContainerTest \ )) diff --git a/vcl/qa/cppunit/VectorGraphicSearchTest.cxx b/vcl/qa/cppunit/VectorGraphicSearchTest.cxx index e539c5a81636..684493e9cd0c 100644 --- a/vcl/qa/cppunit/VectorGraphicSearchTest.cxx +++ b/vcl/qa/cppunit/VectorGraphicSearchTest.cxx @@ -9,8 +9,6 @@ #include -#if HAVE_FEATURE_PDFIUM - #include #include @@ -287,6 +285,4 @@ void VectorGraphicSearchTest::testSearchMatchCase() CPPUNIT_TEST_SUITE_REGISTRATION(VectorGraphicSearchTest); -#endif - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=98259 Dieter changed: What|Removed |Added Depends on||141317 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141317 [Bug 141317] Shift+F4 Function or designation incorrect -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141317] Shift+F4 Function or designation incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=141317 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| Blocks||98259 CC||dgp-m...@gmx.de --- Comment #1 from Dieter --- Shift+F4 does nothing (also in SafeMode) Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=98259 [Bug 98259] [META] Keyboard shortcuts and accelerators bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138386] WMF: LO Writer does not display .emf files properly
https://bugs.documentfoundation.org/show_bug.cgi?id=138386 --- Comment #17 from Timur --- I don't see value in previous comments. Apart that it's 2 instead of 1 comparison screenshot, again not clear where image Congress from. All this is very unclear. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141351] Selection switched from caption frame to embedded image when dragging frame inwards (shrinking) as character anchoring
https://bugs.documentfoundation.org/show_bug.cgi?id=141351 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| --- Comment #3 from Dieter --- I can't confirm it with Version: 7.1.2.2 (x64) / LibreOffice Community Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
