[Libreoffice-bugs] [Bug 141715] incorrect horizontal scaling of glyphs in sm formula nodes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141715

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0 target:7.1.4   |target:7.2.0 target:7.1.4
   ||target:7.1.3

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141715] incorrect horizontal scaling of glyphs in sm formula nodes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141715

--- Comment #17 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "libreoffice-7-1-3":

https://git.libreoffice.org/core/commit/b40e3555d7dc2a18c2fce1387d179bcdfc897d24

fix too wide glyphs with Skia/GDI if horizontal scale is used (tdf#141715)

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1-3' - vcl/skia

[Luboš Luňák (via logerrit)]

 vcl/skia/win/gdiimpl.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit b40e3555d7dc2a18c2fce1387d179bcdfc897d24
Author: Luboš Luňák 
AuthorDate: Tue Apr 20 09:48:25 2021 +
Commit: Michael Stahl 
CommitDate: Thu Apr 22 11:05:12 2021 +0200

fix too wide glyphs with Skia/GDI if horizontal scale is used (tdf#141715)

Change-Id: I7b06b64e04313493f48b7224fbc4883356feda95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114327
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 
(cherry picked from commit 764360df78535befcc4806736fcbaedbe0e34ea1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114285
Reviewed-by: Adolfo Jayme Barrientos 
Reviewed-by: V, Stuart Foote 
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index b609581e1e84..d35cf91232ac 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -213,6 +213,12 @@ bool WinSkiaSalGraphicsImpl::DrawTextLayout(const 
GenericSalLayout& rLayout)
 GlyphOrientation glyphOrientation = GlyphOrientation::Apply;
 if (!typeface) // fall back to GDI text rendering
 {
+// If lfWidth is kept, then with fHScale != 1 characters get too wide, 
presumably
+// because the horizontal scaling gets applied twice if GDI is used 
for drawing (tdf#141715).
+// Using lfWidth /= fHScale gives slightly incorrect sizes, for a 
reason I don't understand.
+// LOGFONT docs say that 0 means GDI will find out the right value on 
its own somehow,
+// and it apparently works.
+logFont.lfWidth = 0;
 typeface.reset(SkCreateTypefaceFromLOGFONT(logFont));
 glyphOrientation = GlyphOrientation::Ignore;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 141826] New: EDITING: Can't change object color in inserted Drawing OLE object using Properties window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141826

Bug ID: 141826
   Summary: EDITING: Can't change object color in inserted Drawing
OLE object using Properties window
   Product: LibreOffice
   Version: 7.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jan.jakubo...@gmail.com

Steps to reproduce:
1. Insert a new drawing into the document using Insert -> Object -> OLE Object
-> Drawing.
2. Draw a rectangle.
3. In the Properties window change the Fill Color or Line Color.
4. Result: Color is not changed.

Notes:
- Color can be changed using the Fill Color or Line Color buttons on the
toolbar.
- Changing of other properties (e.g. line width, line style) in the Properties
window works.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141819] Don't remove icons from toolbar when updating

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141819

Julien Nabet  changed:

   What|Removed |Added

Summary|Don't remove icons from |Don't remove icons from
   |toollbar when updating  |toolbar when updating

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141825] Port LibreOffice to ARM architecture on Microsoft Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141825

Julien Nabet  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #1 from Julien Nabet  ---
Chrome and Firefox have not the same size as LO and have not the financial and
human resources so don't expect an ARM version for Windows for the next months.
Anyway, it's still a reasonable request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source vcl/source

[Caolán McNamara (via logerrit)]

 sw/source/ui/dbui/addresslistdialog.cxx |6 +-
 vcl/source/app/salvtables.cxx   |2 +-
 2 files changed, 2 insertions(+), 6 deletions(-)

New commits:
commit 9be6795255f7348ca002b141310a2bd458e91b0e
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 20:27:25 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 22 11:00:12 2021 +0200

tdf#141538 default to returning contents of first text column

which is what we're doing in the gtk version

Change-Id: Ia04ce3d62342c143b1e62dfd0ecf579ef0279b02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114456
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/ui/dbui/addresslistdialog.cxx 
b/sw/source/ui/dbui/addresslistdialog.cxx
index f57e5a2b01e4..f30a39a26080 100644
--- a/sw/source/ui/dbui/addresslistdialog.cxx
+++ b/sw/source/ui/dbui/addresslistdialog.cxx
@@ -52,7 +52,6 @@
 #include 
 #include 
 #include 
-#include 
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
@@ -305,11 +304,8 @@ IMPL_LINK_NOARG(SwAddressListDialog, RemoveHdl_Impl, 
weld::Button&, void)
 if (xQuery->run() != RET_YES)
 return;
 
-// tdf#141538: Split content of TreeView row to make removal work on 
non-GTK vclplugs
-std::vector aSplitColumns = 
comphelper::string::split(m_xListLB->get_selected_text(), '\t');
-
 // Remove data source connection
-SwDBManager::RevokeDataSource(aSplitColumns.front());
+SwDBManager::RevokeDataSource(m_xListLB->get_selected_text());
 // Remove item from the list
 m_xListLB->remove(nEntry);
 // If this was the last item, disable the Remove & Edit buttons and enable 
Create
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index bdb45fe9ad45..e381aeb2e64d 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -4358,7 +4358,7 @@ OUString SalInstanceTreeView::get_selected_text() const
 {
 assert(m_xTreeView->IsUpdateMode() && "don't request selection when 
frozen");
 if (SvTreeListEntry* pEntry = m_xTreeView->FirstSelected())
-return m_xTreeView->GetEntryText(pEntry);
+return SvTabListBox::GetEntryText(pEntry, 0);
 return OUString();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 141794] calc-autofilter box doesn't stay open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141794

--- Comment #6 from bornolb...@gmail.com  ---
Maybe I didn't I tried to record it on a clean environment and it had
another opinion..

First time tested: it happened immediately.

Second time tested: in the beginning everything was fine. A little before I
quit, it happened again (at 1:22 on second video).

Here are my tests: https://we.tl/t-iebKQqmh81

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/source svx/source sw/qa

[Caolán McNamara (via logerrit)]

 cui/source/options/optaboutconfig.cxx   |2 -
 svx/source/sidebar/inspector/InspectorTextPanel.cxx |5 ++
 sw/qa/uitest/styleInspector/styleInspector.py   |   38 ++--
 sw/qa/uitest/styleInspector/tdf137513.py|4 +-
 4 files changed, 27 insertions(+), 22 deletions(-)

New commits:
commit 78df8f9dc1d28f5390aedb634b07817a22ce989c
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 14:46:17 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 22 10:57:02 2021 +0200

Resolves: tdf#141721 text from 1st col not clipped if 2nd col is empty

Change-Id: I07257c59c20c3a2aeb789bbb370955e9e70226ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114433
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/source/options/optaboutconfig.cxx 
b/cui/source/options/optaboutconfig.cxx
index 4c8d3d8118a4..6a15fb3a1411 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -290,7 +290,7 @@ void CuiAboutConfigTabPage::FillItems(const Reference< 
XNameAccess >& xNameAcces
 OUString 
sId(OUString::number(reinterpret_cast(m_vectorUserData.back().get(;
 
 m_xPrefBox->insert(pParentEntry, -1, , , nullptr, 
nullptr, true, m_xScratchIter.get());
-//It is needed, without this the selection line will be 
truncated.
+// Necessary, without this the selection line will be 
truncated.
 m_xPrefBox->set_text(*m_xScratchIter, "", 1);
 m_xPrefBox->set_text(*m_xScratchIter, "", 2);
 m_xPrefBox->set_text(*m_xScratchIter, "", 3);
diff --git a/svx/source/sidebar/inspector/InspectorTextPanel.cxx 
b/svx/source/sidebar/inspector/InspectorTextPanel.cxx
index fefc42727470..b1d2641335b9 100644
--- a/svx/source/sidebar/inspector/InspectorTextPanel.cxx
+++ b/svx/source/sidebar/inspector/InspectorTextPanel.cxx
@@ -120,6 +120,11 @@ static void FillBox_Impl(weld::TreeView& rListBoxStyles, 
const TreeNode& rCurren
 rListBoxStyles.set_sensitive(*pResult, !rCurrent.isGrey, 1);
 rListBoxStyles.set_text_emphasis(*pResult, false, 1);
 }
+else
+{
+// Necessary, without this the selection line will be truncated.
+rListBoxStyles.set_text(*pResult, "", 1);
+}
 
 for (const TreeNode& rChildNode : rCurrent.children)
 FillBox_Impl(rListBoxStyles, rChildNode, pResult.get());
diff --git a/sw/qa/uitest/styleInspector/styleInspector.py 
b/sw/qa/uitest/styleInspector/styleInspector.py
index 6d531e96793e..6afc4483e911 100644
--- a/sw/qa/uitest/styleInspector/styleInspector.py
+++ b/sw/qa/uitest/styleInspector/styleInspector.py
@@ -22,7 +22,7 @@ class styleNavigator(UITestCase):
 
 # The cursor is on text without formatting and default style
 self.assertEqual(1, len(xListBox.getChild('0').getChildren()))
-self.assertEqual("Default Paragraph Style", 
get_state_as_dict(xListBox.getChild('0').getChild('0'))['Text'])
+self.assertEqual("Default Paragraph Style\t", 
get_state_as_dict(xListBox.getChild('0').getChild('0'))['Text'])
 self.assertEqual(136, 
len(xListBox.getChild('0').getChild('0').getChildren()))
 self.assertEqual(0, len(xListBox.getChild('1').getChildren()))
 self.assertEqual(0, len(xListBox.getChild('2').getChildren()))
@@ -32,7 +32,7 @@ class styleNavigator(UITestCase):
 
 # The cursor is on text with direct formatting
 self.assertEqual(1, len(xListBox.getChild('0').getChildren()))
-self.assertEqual("Default Paragraph Style", 
get_state_as_dict(xListBox.getChild('0').getChild('0'))['Text'])
+self.assertEqual("Default Paragraph Style\t", 
get_state_as_dict(xListBox.getChild('0').getChild('0'))['Text'])
 self.assertEqual(136, 
len(xListBox.getChild('0').getChild('0').getChildren()))
 self.assertEqual(0, len(xListBox.getChild('1').getChildren()))
 self.assertEqual(0, len(xListBox.getChild('2').getChildren()))
@@ -50,7 +50,7 @@ class styleNavigator(UITestCase):
 
 # The cursor is on text with paragraph direct formatting
 self.assertEqual(1, len(xListBox.getChild('0').getChildren()))
-self.assertEqual("Default Paragraph Style", 
get_state_as_dict(xListBox.getChild('0').getChild('0'))['Text'])
+self.assertEqual("Default Paragraph Style\t", 
get_state_as_dict(xListBox.getChild('0').getChild('0'))['Text'])
 self.assertEqual(136, 
len(xListBox.getChild('0').getChild('0').getChildren()))
 
 xParDirFormatting = xListBox.getChild('1')
@@ -71,13 +71,13 @@ class styleNavigator(UITestCase):
 # The cursor is on text with 'Title' style
 xParStyle = xListBox.getChild('0')
 self.assertEqual(3, len(xParStyle.getChildren()))
-self.assertEqual("Default Paragraph Style", 
get_state_as_dict(xParStyle.getChild('0'))['Text'])
+self.assertEqual("Default Paragraph Style\t", 

[Libreoffice-bugs] [Bug 141825] New: Port LibreOffice to ARM architecture on Microsoft Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141825

Bug ID: 141825
   Summary: Port LibreOffice to ARM architecture on Microsoft
Windows
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: shanshandehongx...@outlook.com

Description:
For long times, both Chrome and Firefox provides separate releases for Windows
10 ARM, so it's resonable to make LibreOffice running on ARM architecture
natively on Windows.

Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No



Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141420] [META] UNO Object Inspector - Development tools

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141420
Bug 141420 depends on bug 141537, which changed state.

Bug 141537 Summary: UNO Object Inspector: Crash while inspecting file
https://bugs.documentfoundation.org/show_bug.cgi?id=141537

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141773] Autocorrection for all languages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141773

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||787

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure (via logerrit)]

 wizards/source/scriptforge/SF_PythonHelper.xba   |3 
 wizards/source/scriptforge/python/scriptforge.py |  126 ++-
 2 files changed, 79 insertions(+), 50 deletions(-)

New commits:
commit 32dda25037c01567cf97115fe4ee8ab06489d214
Author: Jean-Pierre Ledure 
AuthorDate: Wed Apr 21 16:39:44 2021 +0200
Commit: Jean-Pierre Ledure 
CommitDate: Thu Apr 22 10:48:35 2021 +0200

ScriptForge - (scriptforge.py) @classmethods

A number of methods were defined implicitly as
instance methods.

Where apropriate they are replaced by class methods:
- insertion of the @classmethod decorator
- self replaced with cls

1 line in SF_PythonHelper.xba uncommented:
it was so far commented in for debugging

Change-Id: Ie8c3dd740f0129511295877ef947b1db35475c48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114440
Tested-by: Jean-Pierre Ledure 
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure 

diff --git a/wizards/source/scriptforge/SF_PythonHelper.xba 
b/wizards/source/scriptforge/SF_PythonHelper.xba
index b083e86b1db4..46c28293415b 100644
--- a/wizards/source/scriptforge/SF_PythonHelper.xba
+++ b/wizards/source/scriptforge/SF_PythonHelper.xba
@@ -569,7 +569,7 @@ Const cstObject = 20481st argument is 
a Basic object when numeric
 Const objMODULE = 1, objCLASS = 2, objUNO = 3
 
 Check:
-   If SF_Utils._ErrorHandling() Then On Local Error GoTo Catch
+   If SF_Utils._ErrorHandling() Then On Local Error GoTo Catch
_PythonDispatcher = Null
 
  Ignore Null basic objects (Null = Null or Nothing)
@@ -628,6 +628,7 @@ Try:
  Requires Python and Basic update in the concerned 
library but is transparent for this dispatcher
 
  Initialize Python persistent storage at 1st call
+   
If IsEmpty(_SF_.PythonStorage) Then _SF_._InitPythonStorage()
  Reset any error
_SF_._Stackreset()
diff --git a/wizards/source/scriptforge/python/scriptforge.py 
b/wizards/source/scriptforge/python/scriptforge.py
index 94fe0fe5a7bd..dfca66cb0b89 100644
--- a/wizards/source/scriptforge/python/scriptforge.py
+++ b/wizards/source/scriptforge/python/scriptforge.py
@@ -96,6 +96,7 @@ class ScriptForge(object, metaclass = _Singleton):
 port = 0
 componentcontext = None
 scriptprovider = None
+SCRIPTFORGEINITDONE = False
 
 # #
 # Class constants
@@ -146,6 +147,8 @@ class ScriptForge(object, metaclass = _Singleton):
 # All properties and methods of the ScriptForge API are ProperCased
 # Compute their synonyms as lowercased and camelCased names
 ScriptForge.SetAttributeSynonyms()
+#
+ScriptForge.SCRIPTFORGEINITDONE = True
 
 @classmethod
 def ConnectToLOProcess(cls, hostname = '', port = 0):
@@ -450,6 +453,9 @@ class SFServices(object):
 # enumerate all types of properties and adapt __getattr__() and 
__setattr__() according to their type
 internal_attributes = ('objectreference', 'objecttype', 'name', 
'internal', 'servicename',
'serviceimplementation', 'classmodule', 'EXEC', 
'SIMPLEEXEC')
+# Shortcuts to script provider interfaces
+SIMPLEEXEC = ScriptForge.InvokeSimpleScript
+EXEC = ScriptForge.InvokeBasicService
 
 def __init__(self, reference = -1, objtype = None, classmodule = 0, name = 
''):
 """
@@ -463,8 +469,6 @@ class SFServices(object):
 self.name = name  # '' when no name
 self.internal = False  # True to exceptionally allow assigning a new 
value to a read-only property
 self.localProperties = []  # the properties reserved for internal use 
(often empty)
-self.SIMPLEEXEC = ScriptForge.InvokeSimpleScript  # Shortcuts to 
script provider interfaces
-self.EXEC = ScriptForge.InvokeBasicService
 
 def __getattr__(self, name):
 """
@@ -618,53 +622,63 @@ class SFScriptForge:
 MB_OK, MB_OKCANCEL, MB_RETRYCANCEL, MB_YESNO, MB_YESNOCANCEL = 0, 1, 
5, 4, 3
 IDABORT, IDCANCEL, IDIGNORE, IDNO, IDOK, IDRETRY, IDYES = 3, 2, 5, 7, 
1, 4, 6
 
-def ConvertFromUrl(self, url):
-return self.SIMPLEEXEC(self.module + '.PyConvertFromUrl', url)
+@classmethod
+def ConvertFromUrl(cls, url):
+return cls.SIMPLEEXEC(cls.module + '.PyConvertFromUrl', url)
 
-def ConvertToUrl(self, systempath):
-return self.SIMPLEEXEC(self.module + '.PyConvertToUrl', systempath)
+@classmethod
+def ConvertToUrl(cls, systempath):
+return cls.SIMPLEEXEC(cls.module + '.PyConvertToUrl', systempath)
 
-def CreateUnoService(self, servicename):
-return self.SIMPLEEXEC(self.module + '.PyCreateUnoService', 
servicename)
+@classmethod
+def CreateUnoService(cls, servicename):
+return cls.SIMPLEEXEC(cls.module + 

[Libreoffice-bugs] [Bug 141815] doc error in DG6402

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141815

Xisco Faulí  changed:

   What|Removed |Added

  Component|Draw|Documentation
 CC||olivier.hallot@libreoffice.
   ||org,
   ||xiscofa...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141794] calc-autofilter box doesn't stay open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141794

--- Comment #5 from bornolb...@gmail.com  ---
I found it! You have to have two different lirbeoffice calc windows opened for
that to happen!

On both you should have at least a column with data an on the first line the
"auto-filter" option enabled.

After create them both, on the first that you use the auto-filter option, it
stays correct. On the other one, it pops out immediately after clicking and
moving the mouse.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 116133] Crash when exporting a presentation to PDF with Export notes pages enabled for a second time (32-bit only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=116133

Timur  changed:

   What|Removed |Added

   Priority|medium  |high

--- Comment #16 from Timur  ---
I see this in Windows 7 with 7.2+.
32-bit 7.2+ (2 weeks old) Skia crashes on step 2. of Comment 2. Memory waa just
650 MB. 

64-bit 7.2+ with Skia few days old used to crash already on fileopen. No crash
for Gdi, much less memory usage. But no crash with today's 64-bit.
I noticed that Comment 2 steps in 7.1 Skia use 1.4 GB of memory, while Gdi
doesn't reach 1 GB.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141794] calc-autofilter box doesn't stay open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141794

--- Comment #4 from bornolb...@gmail.com  ---
https://we.tl/t-VAyjJ7XCUB

It doesn't happen all the times, but it is not a new one. I remember this
coming often also in previous editions of libreoffice calc (I use very much the
auto-filter option). But I haven't figure out when it happens, so I hadn't
reported this earlier. I thought it happens when not saved, but this isn't the
case. I do not know exactly a way to reproduce it at once.

Yesterday, before reporting here, I made a new calc to reproduce it (so I can
write the steps). These were the steps I wrote. It happened at once.
Although I tried again after your messages I also couldn't reproduce it for
some reason. After a while yesterday, as I was using again libreoffice calc for
another purpose, it happened again and I record the above video in a new sheet
to show you. I had two different calc windows opened and was just filling cells
on both of them. I was also using the auto-filter option on both of them. After
a 3-5 times it happened.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140659] Formula editor not operable with screenreaders NVDA or Orca

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140659

--- Comment #9 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/6b4d475b9377dba504a08c4317210bf3f8bc1859

Related: tdf#140659 on control get/lose focus call update custom a11y

It will be available in 7.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140659] Formula editor not operable with screenreaders NVDA or Orca

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140659

--- Comment #8 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/b45629418d91c7452245ae4c6894fa3c1becf237

Related: tdf#140659 off by one indexes because scrollbar is now outside

It will be available in 7.1.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140659] Formula editor not operable with screenreaders NVDA or Orca

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140659

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.2.0|target:7.2.0 target:7.1.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - 2 commits - starmath/source

[Caolán McNamara (via logerrit)]

 starmath/source/ElementsDockingWindow.cxx |   12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

New commits:
commit 6b4d475b9377dba504a08c4317210bf3f8bc1859
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 17:09:59 2021 +0100
Commit: Xisco Fauli 
CommitDate: Thu Apr 22 10:28:15 2021 +0200

Related: tdf#140659 on control get/lose focus call update custom a11y

Change-Id: Iab7df2c657da3386dc38db8a9d6427c60d8c1cc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114452
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/starmath/source/ElementsDockingWindow.cxx 
b/starmath/source/ElementsDockingWindow.cxx
index e8365df87f01..e6835a4b8034 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -651,10 +651,14 @@ void SmElementsControl::GetFocus()
 {
 CustomWidgetController::GetFocus();
 Invalidate();
+if (m_xAccessible.is() && m_nCurrentElement != SAL_MAX_UINT16)
+m_xAccessible->AcquireFocus();
 }
 
 void SmElementsControl::LoseFocus()
 {
+if (m_xAccessible.is() && m_nCurrentElement != SAL_MAX_UINT16)
+m_xAccessible->ReleaseFocus(m_nCurrentElement);
 CustomWidgetController::LoseFocus();
 Invalidate();
 }
commit b45629418d91c7452245ae4c6894fa3c1becf237
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 16:57:32 2021 +0100
Commit: Xisco Fauli 
CommitDate: Thu Apr 22 10:28:00 2021 +0200

Related: tdf#140659 off by one indexes because scrollbar is now outside

and not inside the control so it doesn't need to be accounted for
as a child

Change-Id: I77b55ec8d9b515850817417664df8944b4e44204
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114451
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/starmath/source/ElementsDockingWindow.cxx 
b/starmath/source/ElementsDockingWindow.cxx
index 0ee85b49eab8..e8365df87f01 100644
--- a/starmath/source/ElementsDockingWindow.cxx
+++ b/starmath/source/ElementsDockingWindow.cxx
@@ -288,7 +288,7 @@ 
SmElementsControl::SmElementsControl(std::unique_ptr xScro
 : mpDocShell(new SmDocShell(SfxModelFlags::EMBEDDED_OBJECT))
 , m_nCurrentElement(SAL_MAX_UINT16)
 , m_nCurrentRolloverElement(SAL_MAX_UINT16)
-, m_nCurrentOffset(1) // Default offset of 1 due to the ScrollBar child
+, m_nCurrentOffset(0)
 , mbVerticalMode(true)
 , mxScroll(std::move(xScrolledWindow))
 , m_bFirstPaintAfterLayout(false)
@@ -1018,7 +1018,7 @@ void SmElementsControl::addElements(const SmElementDescr 
aElementsArray[], sal_u
 void SmElementsControl::build()
 {
 // The order is important!
-// 1. Ensure there are no items left, including the default scrollbar!
+// 1. Ensure there are no items left
 // 2. Release all the current accessible items.
 //This will check for new items after releasing them!
 // 3. Set the cursor element
@@ -1033,9 +1033,7 @@ void SmElementsControl::build()
 
 setCurrentElement(SAL_MAX_UINT16);
 
-// The first element is the scrollbar. We can't change its indexInParent
-// value, as this is set by being a child of the SmElementsControl.
-m_nCurrentOffset = 1;
+m_nCurrentOffset = 0;
 for (sal_uInt16 n = 0; n < SAL_N_ELEMENTS(m_aCategories); ++n)
 {
 if (msCurrentSetId == std::get<0>(m_aCategories[n]))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 137074] Accessibility No announcement of distance fromborder when tab is pressed and ruler is active

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137074

--- Comment #2 from juergenkohle...@gmail.com ---
The problem also occurs when using the vertical ruler.

NVDA 2020.4

Windows
Edition Windows 10 Home
Version 1909
Installed on17.02.2020
Operating system build  18363.1016

LibreOffice
Version: 7.1.2.2 (x64) / LibreOffice Community
Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sc/source

[Julien Nabet (via logerrit)]

 sc/source/ui/unoobj/chartuno.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 613a80b855406d180a663a4aec974c40be195395
Author: Julien Nabet 
AuthorDate: Wed Apr 7 22:26:30 2021 +0200
Commit: Xisco Fauli 
CommitDate: Thu Apr 22 10:19:55 2021 +0200

tdf#141537: UNO Object Inspector: Crash while inspecting file

See bt:
6  0x7f276e146773 in ScChartsObj::getByName(rtl::OUString const&) 
(this=0x7738e00, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:345
7  0x7f276e146865 in non-virtual thunk to 
ScChartsObj::getByName(rtl::OUString const&) () at 
sc/source/ui/unoobj/chartuno.cxx:348
8  0x7f27a1d87b7f in (anonymous 
namespace)::NameAccessTreeEntry::fill(std::unique_ptr >&, weld::TreeIter const&)
   (this=0x6d463e0, pDocumentModelTree=std::unique_ptr = {...}, rParent=...) at 
sfx2/source/devtools/DocumentModelTreeHandler.cxx:139
9  0x7f27a1d87905 in (anonymous 
namespace)::ChartsEntry::fill(std::unique_ptr >&, weld::TreeIter const&)
   (this=0x6d463e0, pDocumentModelTree=std::unique_ptr = {...}, rParent=...) at 
sfx2/source/devtools/DocumentModelTreeHandler.cxx:596
10 0x7f27a1d842e5 in 
DocumentModelTreeHandler::ExpandingHandler(weld::TreeIter const&) 
(this=0x76e3850, rParent=...) at sfx2/source/devtools/DocumentModelTreeHandl

chart isn't retrieved from there:
0  sc::tools::findChartsByName(ScDocShell*, short, 
std::basic_string_view >, 
sc::tools::ChartSourceType)
   (pDocShell=0x351baa0, nTab=0, rName=u"Object 1", 
eChartSourceType=sc::tools::ChartSourceType::CELL_RANGE) at 
sc/source/ui/unoobj/ChartTools.cxx:106
1  0x7f6297305323 in ScChartsObj::GetObjectByName_Impl(rtl::OUString 
const&) const (this=0x77ce370, aName="Object 1") at 
sc/source/ui/unoobj/chartuno.cxx:126
2  0x7f62973076b4 in ScChartsObj::getByName(rtl::OUString const&) 
(this=0x77ce370, aName="Object 1") at sc/source/ui/unoobj/chartuno.cxx:343

Indeed, if graph hasn't type ChartSourceType::CELL_RANGE, it could be 
ChartSourceType::PIVOT_TABLE

Change-Id: Id5a248535b214ad5f114671c52e4592d87c9f54a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113777
Reviewed-by: Julien Nabet 
(cherry picked from commit 42e0ea0a6e4f48967d58fa95081c8ba5a6b08bc6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114361
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/source/ui/unoobj/chartuno.cxx b/sc/source/ui/unoobj/chartuno.cxx
index 638d517b4083..ac10a2ad35ef 100644
--- a/sc/source/ui/unoobj/chartuno.cxx
+++ b/sc/source/ui/unoobj/chartuno.cxx
@@ -125,6 +125,8 @@ ScChartObj* ScChartsObj::GetObjectByName_Impl(const 
OUString& aName) const
 {
 if (sc::tools::findChartsByName(pDocShell, nTab, aName, 
sc::tools::ChartSourceType::CELL_RANGE))
 return new ScChartObj( pDocShell, nTab, aName );
+if (sc::tools::findChartsByName(pDocShell, nTab, aName, 
sc::tools::ChartSourceType::PIVOT_TABLE))
+return new ScChartObj( pDocShell, nTab, aName );
 return nullptr;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 141823] elementary: Please unify the design of the "function" icon in different sizes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141823

Rizal Muttaqin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Assignee|libreoffice-b...@lists.free |riz...@libreoffice.org
   |desktop.org |
 Ever confirmed|0   |1
 CC||riz...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: reportdesign/uiconfig sc/uiconfig sd/uiconfig sw/uiconfig

[haru-02 (via logerrit)]

 reportdesign/uiconfig/dbreport/toolbar/Formatting.xml |2 +-
 sc/uiconfig/scalc/toolbar/formatobjectbar.xml |2 +-
 sc/uiconfig/scalc/toolbar/singlemode.xml  |2 +-
 sc/uiconfig/scalc/toolbar/textobjectbar.xml   |2 +-
 sd/uiconfig/sdraw/toolbar/textobjectbar.xml   |2 +-
 sd/uiconfig/simpress/toolbar/textobjectbar.xml|2 +-
 sw/uiconfig/sglobal/toolbar/drawtextobjectbar.xml |2 +-
 sw/uiconfig/sglobal/toolbar/textobjectbar.xml |2 +-
 sw/uiconfig/sglobal/toolbar/textstylebar.xml  |2 +-
 sw/uiconfig/sweb/toolbar/drawtextobjectbar.xml|2 +-
 sw/uiconfig/sweb/toolbar/textobjectbar.xml|2 +-
 sw/uiconfig/swform/toolbar/drawtextobjectbar.xml  |2 +-
 sw/uiconfig/swform/toolbar/textobjectbar.xml  |2 +-
 sw/uiconfig/swreport/toolbar/drawtextobjectbar.xml|2 +-
 sw/uiconfig/swreport/toolbar/textobjectbar.xml|2 +-
 sw/uiconfig/swriter/toolbar/drawtextobjectbar.xml |2 +-
 sw/uiconfig/swriter/toolbar/singlemode.xml|2 +-
 sw/uiconfig/swriter/toolbar/textobjectbar.xml |2 +-
 sw/uiconfig/swriter/toolbar/textstylebar.xml  |2 +-
 sw/uiconfig/swxform/toolbar/drawtextobjectbar.xml |2 +-
 sw/uiconfig/swxform/toolbar/textobjectbar.xml |2 +-
 21 files changed, 21 insertions(+), 21 deletions(-)

New commits:
commit aac980adda37cde886e43f12dc06d6a73cb6daa6
Author: haru-02 
AuthorDate: Wed Apr 21 21:55:20 2021 +0400
Commit: Heiko Tietze 
CommitDate: Thu Apr 22 10:14:42 2021 +0200

tdf#139701 change uno:UnderlineSimple to uno:Underline

Change-Id: Ideb436dbbef1c6fb36cae93e5dd55ef2d00698c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114454
Tested-by: Heiko Tietze 
Reviewed-by: Heiko Tietze 

diff --git a/reportdesign/uiconfig/dbreport/toolbar/Formatting.xml 
b/reportdesign/uiconfig/dbreport/toolbar/Formatting.xml
index 7fdf1b3473c7..461bda940f01 100644
--- a/reportdesign/uiconfig/dbreport/toolbar/Formatting.xml
+++ b/reportdesign/uiconfig/dbreport/toolbar/Formatting.xml
@@ -26,7 +26,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sc/uiconfig/scalc/toolbar/formatobjectbar.xml 
b/sc/uiconfig/scalc/toolbar/formatobjectbar.xml
index 39edc3981fb7..8798afe6637a 100644
--- a/sc/uiconfig/scalc/toolbar/formatobjectbar.xml
+++ b/sc/uiconfig/scalc/toolbar/formatobjectbar.xml
@@ -29,7 +29,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sc/uiconfig/scalc/toolbar/singlemode.xml 
b/sc/uiconfig/scalc/toolbar/singlemode.xml
index afee24d0f806..8c1fc2091c60 100644
--- a/sc/uiconfig/scalc/toolbar/singlemode.xml
+++ b/sc/uiconfig/scalc/toolbar/singlemode.xml
@@ -50,7 +50,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sc/uiconfig/scalc/toolbar/textobjectbar.xml 
b/sc/uiconfig/scalc/toolbar/textobjectbar.xml
index a9b3047581ca..5aa6555d1d85 100644
--- a/sc/uiconfig/scalc/toolbar/textobjectbar.xml
+++ b/sc/uiconfig/scalc/toolbar/textobjectbar.xml
@@ -26,7 +26,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sd/uiconfig/sdraw/toolbar/textobjectbar.xml 
b/sd/uiconfig/sdraw/toolbar/textobjectbar.xml
index 10b98785227c..1131052a2065 100644
--- a/sd/uiconfig/sdraw/toolbar/textobjectbar.xml
+++ b/sd/uiconfig/sdraw/toolbar/textobjectbar.xml
@@ -26,7 +26,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sd/uiconfig/simpress/toolbar/textobjectbar.xml 
b/sd/uiconfig/simpress/toolbar/textobjectbar.xml
index 10b98785227c..1131052a2065 100644
--- a/sd/uiconfig/simpress/toolbar/textobjectbar.xml
+++ b/sd/uiconfig/simpress/toolbar/textobjectbar.xml
@@ -26,7 +26,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sw/uiconfig/sglobal/toolbar/drawtextobjectbar.xml 
b/sw/uiconfig/sglobal/toolbar/drawtextobjectbar.xml
index dc190e4836fe..42eb77d2b8dc 100644
--- a/sw/uiconfig/sglobal/toolbar/drawtextobjectbar.xml
+++ b/sw/uiconfig/sglobal/toolbar/drawtextobjectbar.xml
@@ -26,7 +26,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sw/uiconfig/sglobal/toolbar/textobjectbar.xml 
b/sw/uiconfig/sglobal/toolbar/textobjectbar.xml
index 49056f22580e..aac0785fd003 100644
--- a/sw/uiconfig/sglobal/toolbar/textobjectbar.xml
+++ b/sw/uiconfig/sglobal/toolbar/textobjectbar.xml
@@ -33,7 +33,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sw/uiconfig/sglobal/toolbar/textstylebar.xml 
b/sw/uiconfig/sglobal/toolbar/textstylebar.xml
index e3886e115a0d..e5dc9410bf7c 100644
--- a/sw/uiconfig/sglobal/toolbar/textstylebar.xml
+++ b/sw/uiconfig/sglobal/toolbar/textstylebar.xml
@@ -59,7 +59,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sw/uiconfig/sweb/toolbar/drawtextobjectbar.xml 
b/sw/uiconfig/sweb/toolbar/drawtextobjectbar.xml
index dc190e4836fe..42eb77d2b8dc 100644
--- a/sw/uiconfig/sweb/toolbar/drawtextobjectbar.xml
+++ b/sw/uiconfig/sweb/toolbar/drawtextobjectbar.xml
@@ -26,7 +26,7 @@
  
  
  
- 
+ 
  
  
  
diff --git a/sw/uiconfig/sweb/toolbar/textobjectbar.xml 
b/sw/uiconfig/sweb/toolbar/textobjectbar.xml
index 49056f22580e..aac0785fd003 100644
--- 

[Libreoffice-bugs] [Bug 141317] Shift+F4 Function or designation incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141317

--- Comment #3 from juergenkohle...@gmail.com ---
If I stand on a frame with Shift+F4, I can navigate between the frames with
Shift+Tab, but NVDA only plays the first frame; I can navigate to the others,
but they are no longer announced to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: oox/source sw/qa writerfilter/qa writerfilter/source

[Regina Henschel (via logerrit)]

 oox/source/drawingml/shape.cxx   |
4 
 sw/qa/extras/ooxmlexport/ooxmlexport4.cxx|
3 
 sw/qa/extras/ooxmlexport/ooxmlexport6.cxx|
8 
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |
3 
 sw/qa/extras/ooxmlimport/ooxmlimport2.cxx|   
15 -
 writerfilter/qa/cppunittests/dmapper/GraphicImport.cxx   |   
65 +
 writerfilter/qa/cppunittests/dmapper/data/tdf141540ChildRotation.docx
|binary
 writerfilter/qa/cppunittests/dmapper/data/tdf141540GroupLinePosSize.docx 
|binary
 writerfilter/qa/cppunittests/dmapper/data/tdf141540GroupRotation.docx
|binary
 writerfilter/source/dmapper/GraphicImport.cxx|  
121 +-
 10 files changed, 203 insertions(+), 16 deletions(-)

New commits:
commit 2a70cfb09c4d89154d229b6a95cf076e8bd76798
Author: Regina Henschel 
AuthorDate: Sun Apr 11 13:03:27 2021 +0200
Commit: Miklos Vajna 
CommitDate: Thu Apr 22 10:12:32 2021 +0200

tdf#141540 fix docx import of group or line with rotation

... and fix case wrap 'Square' and 'in Line' with them.
Non-uniform scaling of a rotated shape might produce skew. Such had
happened, when setting group or line to the size contained in
GraphicImport. Avoid it.
Writer has special rules for shape position and marging in case of wrap
'Square' and 'in Line', depending on rotation angle. The patch adds
the needed margins.
The patch changes some unit tests where we now get slightly different
values.
The patch fixes the wrong skew in sample document of tdf#73022.

Change-Id: Ic743790c3fc8b8b10a4324d9e0184ad945cdceb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114193
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 729fb3c3712f..49f82a6fd137 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -982,6 +982,10 @@ Reference< XShape > const & Shape::createAndInsert(
 // TODO: use ph color when applying effect properties
 //sal_Int32 nEffectPhClr = -1;
 
+// dmapper needs the original rotation angle for calculating square 
wrap. This angle is not
+// available as property there, so store it in InteropGrabBag.
+putPropertyToGrabBag("mso-rotation-angle", Any(mnRotation));
+
 if( pTheme )
 {
 if( const ShapeStyleRef* pLineRef = getShapeStyleRef( XML_lnRef ) )
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
index 03eff3c65513..603b1010b59a 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
@@ -77,6 +77,9 @@ DECLARE_OOXMLEXPORT_TEST(testRelorientation, 
"relorientation.docx")
 uno::Reference 
xShapeDescriptor(xGroup->getByIndex(0), uno::UNO_QUERY);
 CPPUNIT_ASSERT_EQUAL(OUString("com.sun.star.drawing.GroupShape"), 
xShapeDescriptor->getShapeType());
 
+// 'actual child size' = 'group ext' * 'child ext' / 'chExt from group', 
see section 'chExt' in
+// [MS-OI29500]. Here for width from file 3108960 * 4896 / 4911 = 3099464 
EMU. That corresponds to
+// width 8.61cm and 325px in UI in Word and rounds down to 8609 Hmm. 
FIXME: Expected value is wrong.
 // Right after import we get a rounding error: 8662 vs 8664.
 if (mbExported)
 {
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
index 7639e995b86a..0a71b2535587 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport6.cxx
@@ -125,12 +125,14 @@ DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testDmlTextshapeB, 
"dml-textshapeB.docx")
 uno::Reference xGroup(getShape(1), 
uno::UNO_QUERY);
 uno::Reference xShape(xGroup->getByIndex(3), 
uno::UNO_QUERY);
 // Connector was incorrectly shifted towards the top left corner, X was 
192, Y was -5743.
-CPPUNIT_ASSERT_EQUAL(sal_Int32(3778), xShape->getPosition().X);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(-5066), xShape->getPosition().Y);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3776), xShape->getPosition().X);
+// Value as of LO7.2. Whole group is still shifted 3mm to rigth and 5mm 
down.
+CPPUNIT_ASSERT_EQUAL(sal_Int32(-5063), xShape->getPosition().Y);
 
 xShape.set(xGroup->getByIndex(5), uno::UNO_QUERY);
 // This was incorrectly shifted towards the top of the page, Y was -5011.
-CPPUNIT_ASSERT_EQUAL(sal_Int32(-4715), xShape->getPosition().Y);
+// Value as of LO 7.2
+CPPUNIT_ASSERT_EQUAL(sal_Int32(-4712), xShape->getPosition().Y);
 }
 
 DECLARE_OOXMLEXPORT_TEST(testDMLSolidfillAlpha, "dml-solidfill-alpha.docx")
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index fe15ef8d94de..84183572cefd 100644

[Libreoffice-bugs] [Bug 141540] FILEOPEN DOCX rotated group has wrong size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141540

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141540] FILEOPEN DOCX rotated group has wrong size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141540

--- Comment #5 from Commit Notification 
 ---
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2a70cfb09c4d89154d229b6a95cf076e8bd76798

tdf#141540 fix docx import of group or line with rotation

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141820] Image->Properties->Type->Position drop down list changes in an inconsistent way when anchor is changed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141820

Telesto  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #4 from Telesto  ---
@Caolan
You might take an interest in this. Would say welding changed something (but
being broken before)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 124176] Use pragma once instead of include guards

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124176

--- Comment #218 from Baltasar  ---
I'd like to do something in this issue. Can I take over it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141824] Navigator: Incorrect Width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141824

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||caol...@redhat.com,
   ||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW
   Keywords||bibisected, bisected,
   ||regression

--- Comment #1 from Xisco Faulí  ---
The issue is happening since

https://cgit.freedesktop.org/libreoffice/core/commit/?id=3dfb8552eb84eaf831c4c3eb59c398afc87e9174

author  Caolán McNamara 2021-03-11 09:26:10 +
committer   Caolán McNamara 2021-03-11 18:34:35
+0100
commit  3dfb8552eb84eaf831c4c3eb59c398afc87e9174 (patch)
tree63c0b06f6d2e127291f156735673ba0678397645
parent  071df4770dfe421d96d3df748af751eaae6982c3 (diff)
check current floating state of DockingWindow

Bisected with: bibisect-linux64-7.2

Adding Cc: to Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141824] New: Navigator: Incorrect Width

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141824

Bug ID: 141824
   Summary: Navigator: Incorrect Width
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 171349
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171349=edit
screenshot

Steps to reproduce:
1. Remove the user profile
2. Launch Calc
3. Launch the Navigator

-> Some elements are not completely displayed. See screenshot

Reproduced in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 41145efffe9d5af358a52b9e114bb01b98b3d7c2
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141820] Image->Properties->Type->Position drop down list changes in an inconsistent way when anchor is changed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141820

Telesto  changed:

   What|Removed |Added

Version|7.0.2.2 release |6.3.0.4 release

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141820] Image->Properties->Type->Position drop down list changes in an inconsistent way when anchor is changed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141820

--- Comment #3 from Telesto  ---
Working differently, but broken too in 6.2

Currently behaviour also found in
Version: 6.3.7.0.0+ (x86)
Build ID: 726535ec30f12697ceccd2f0640d9371a64dc5bd
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141820] Image->Properties->Type->Position drop down list changes in an inconsistent way when anchor is changed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141820

--- Comment #2 from Telesto  ---
Created attachment 171348
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171348=edit
Example file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141820] Image->Properties->Type->Position drop down list changes in an inconsistent way when anchor is changed.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141820

Telesto  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||heiko.tietze@documentfounda
   ||tion.org
 Status|UNCONFIRMED |NEW

--- Comment #1 from Telesto  ---
Took reasonable time to understand. Repro
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a809b2ab2553e946431699d9d7ac3f6209cbdd6b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

STR
1. Open the attached file
2. Click the drop down at 'Vertical' containing 'Margin' Notice 4 entry's
3. Switch anchor to 'as character'
4. Switch anchor to 'to character' again -> 6 entry's

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - include/vcl vcl/source

[Caolán McNamara (via logerrit)]

 include/vcl/weldutils.hxx|   10 ++
 vcl/source/app/weldutils.cxx |   17 +
 2 files changed, 27 insertions(+)

New commits:
commit ec97d25ed63e0db98cc13d090c1d8830e2132a44
Author: Caolán McNamara 
AuthorDate: Mon Dec 14 15:08:33 2020 +
Commit: Szymon Kłos 
CommitDate: Thu Apr 22 10:01:06 2021 +0200

add a way to correctly position a weld::Menu given a vcl::Window

Change-Id: I7fc6a1bb6cfca40a4a97568f957d127445b4d31c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107727
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114408
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/include/vcl/weldutils.hxx b/include/vcl/weldutils.hxx
index 9a29e89d7b5f..ecfe2c7e7dbb 100644
--- a/include/vcl/weldutils.hxx
+++ b/include/vcl/weldutils.hxx
@@ -24,6 +24,11 @@
 
 class CalendarWrapper;
 
+namespace vcl
+{
+class Window;
+}
+
 namespace weld
 {
 typedef cppu::WeakComponentImplHelper 
TransportAsXWindow_Base;
@@ -401,6 +406,11 @@ VCL_DLLPUBLIC void 
RemoveParentKeepChildren(weld::TreeView& rTreeView, weld::Tre
 
 // return the min height of a weld::Entry
 VCL_DLLPUBLIC int GetMinimumEditHeight();
+
+// return the weld::Window of the SalFrame rOutWin is in, and convert rRect
+// from relative to rOutWin to relative to that weld::Window suitable for use
+// with popup_at_rect
+VCL_DLLPUBLIC weld::Window* GetPopupParent(vcl::Window& rOutWin, 
tools::Rectangle& rRect);
 }
 
 #endif
diff --git a/vcl/source/app/weldutils.cxx b/vcl/source/app/weldutils.cxx
index 237645076330..a4c3de5097b6 100644
--- a/vcl/source/app/weldutils.cxx
+++ b/vcl/source/app/weldutils.cxx
@@ -14,6 +14,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -546,6 +548,21 @@ void WidgetStatusListener::dispose()
 mxFrame.clear();
 mWidget = nullptr;
 }
+
+weld::Window* GetPopupParent(vcl::Window& rOutWin, tools::Rectangle& rRect)
+{
+rRect.SetPos(rOutWin.OutputToScreenPixel(rRect.TopLeft()));
+rRect = FloatingWindow::ImplConvertToAbsPos(, rRect);
+
+vcl::Window* pWin = 
+while (!pWin->IsTopWindow())
+pWin = pWin->GetParent();
+
+rRect = FloatingWindow::ImplConvertToRelPos(pWin, rRect);
+rRect.SetPos(pWin->ScreenToOutputPixel(rRect.TopLeft()));
+
+return rOutWin.GetFrameWeld();
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - include/vcl vcl/source vcl/unx

[Caolán McNamara (via logerrit)]

 include/vcl/floatwin.hxx   |1 +
 include/vcl/window.hxx |1 +
 vcl/source/window/floatwin.cxx |   23 +++
 vcl/source/window/window.cxx   |   25 +++--
 vcl/unx/gtk3/gtk3gtkinst.cxx   |1 +
 5 files changed, 49 insertions(+), 2 deletions(-)

New commits:
commit a4addb0f51123b1c043f8178d6917116d4fb6597
Author: Caolán McNamara 
AuthorDate: Mon Dec 14 11:27:57 2020 +
Commit: Szymon Kłos 
CommitDate: Thu Apr 22 10:00:36 2021 +0200

add a way to undo ImplConvertToAbsPos

Change-Id: Ia739c93c91f512c570d38a385d36bcce76e6fdcd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107684
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114407
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/include/vcl/floatwin.hxx b/include/vcl/floatwin.hxx
index 91a6ae3c8c0e..ef3c38c6bd72 100644
--- a/include/vcl/floatwin.hxx
+++ b/include/vcl/floatwin.hxx
@@ -117,6 +117,7 @@ public:
 sal_uInt16& rArrangeIndex, 
Point* pLOKTwipsPos = nullptr);
static Point ImplConvertToAbsPos(vcl::Window* 
pReference, const Point& rPos);
static tools::Rectangle ImplConvertToAbsPos(vcl::Window* 
pReference, const tools::Rectangle& rRect);
+   static tools::Rectangle ImplConvertToRelPos(vcl::Window* 
pReference, const tools::Rectangle& rRect);
 SAL_DLLPRIVATE void ImplEndPopupMode( FloatWinPopupEndFlags 
nFlags, const VclPtr& xFocusId );
 SAL_DLLPRIVATE tools::Rectangle&   ImplGetItemEdgeClipRect();
 SAL_DLLPRIVATE bool ImplIsInPrivatePopupMode() const { return 
mbInPopupMode; }
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index 0a378a11f65e..ae5886b9b07d 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -718,6 +718,7 @@ private:
 SAL_DLLPRIVATE static void  ImplHandleScroll(ScrollBar* pHScrl, 
double nX, ScrollBar* pVScrl, double nY);
 
 SAL_DLLPRIVATE tools::Rectangle 
ImplOutputToUnmirroredAbsoluteScreenPixel( const tools::Rectangle& rRect ) 
const;
+SAL_DLLPRIVATE tools::Rectangle 
ImplUnmirroredAbsoluteScreenToOutputPixel( const tools::Rectangle& rRect ) 
const;
 SAL_DLLPRIVATE tools::Long ImplGetUnmirroredOutOffX();
 
 // retrieves the list of owner draw decorated windows for this window 
hierarchy
diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index 53f9349e565f..1d9bac8c427c 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -524,6 +524,29 @@ tools::Rectangle 
FloatingWindow::ImplConvertToAbsPos(vcl::Window* pReference, co
 }
 else
 
aFloatRect.SetPos(pReference->OutputToAbsoluteScreenPixel(pReference->ScreenToOutputPixel(rRect.TopLeft(;
+
+return aFloatRect;
+}
+
+tools::Rectangle FloatingWindow::ImplConvertToRelPos(vcl::Window* pReference, 
const tools::Rectangle& rRect)
+{
+tools::Rectangle aFloatRect = rRect;
+
+const OutputDevice *pParentWinOutDev = pReference->GetOutDev();
+
+// compare coordinates in absolute screen coordinates
+// Keep in sync with FloatingWindow::ImplFloatHitTest, e.g. fdo#33509
+if( pReference->HasMirroredGraphics()  )
+{
+aFloatRect = 
pReference->ImplUnmirroredAbsoluteScreenToOutputPixel(aFloatRect);
+
aFloatRect.SetPos(pReference->OutputToScreenPixel(aFloatRect.TopLeft()));
+
+if(!pReference->IsRTLEnabled() )
+pParentWinOutDev->ReMirror(aFloatRect);
+}
+else
+
aFloatRect.SetPos(pReference->OutputToScreenPixel(pReference->AbsoluteScreenToOutputPixel(rRect.TopLeft(;
+
 return aFloatRect;
 }
 
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 5e6d92b47ef9..85746b11f07c 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -2870,17 +2870,38 @@ tools::Rectangle 
Window::ImplOutputToUnmirroredAbsoluteScreenPixel( const tools:
 // and is used for positioning of RTL popup windows correctly on the screen
 SalFrameGeometry g = mpWindowImpl->mpFrame->GetUnmirroredGeometry();
 
-Point p1 = OutputToScreenPixel( rRect.TopRight() );
+Point p1 = rRect.TopRight();
+p1 = OutputToScreenPixel(p1);
 p1.setX( g.nX+g.nWidth-p1.X() );
 p1.AdjustY(g.nY );
 
-Point p2 = OutputToScreenPixel( rRect.BottomLeft() );
+Point p2 = rRect.BottomLeft();
+p2 = OutputToScreenPixel(p2);
 p2.setX( g.nX+g.nWidth-p2.X() );
 p2.AdjustY(g.nY );
 
 return tools::Rectangle( p1, p2 );
 }
 
+tools::Rectangle Window::ImplUnmirroredAbsoluteScreenToOutputPixel( const 
tools::Rectangle  ) const
+{
+// undo ImplOutputToUnmirroredAbsoluteScreenPixel
+SalFrameGeometry g = mpWindowImpl->mpFrame->GetUnmirroredGeometry();
+
+Point p1 = rRect.TopRight();
+

[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - svx/source

[Caolán McNamara (via logerrit)]

 svx/source/dialog/fntctrl.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 40868f520f9da24d3eaa5e0489da8657bc8383b4
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 15:53:13 2021 +0100
Commit: Xisco Fauli 
CommitDate: Thu Apr 22 09:57:32 2021 +0200

tdf#141419 restore use any explicitly set background color in previews

regression since...

commit 6f3899b27156591e65f62649a92c727eb6f5dd03
Date:   Thu Oct 29 15:03:44 2020 +0100

Resolves tdf#137059 - Use application colors for font preview

but continue to use the doc-color setting when there isn't an explicit
bg setting in the input propertyset

Change-Id: I531b5ddea7700fcd4a731f32d4830b4d0b767d7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114418
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/svx/source/dialog/fntctrl.cxx b/svx/source/dialog/fntctrl.cxx
index 1b2eb421aad3..26e44a29939a 100644
--- a/svx/source/dialog/fntctrl.cxx
+++ b/svx/source/dialog/fntctrl.cxx
@@ -1008,6 +1008,16 @@ void SvxFontPrevWindow::SetFromItemSet(const SfxItemSet 
, bool bPreviewBack
 rCJKFont.SetTransparent( bTransparent );
 rCTLFont.SetTransparent( bTransparent );
 
+if( !bPreviewBackgroundToCharacter )
+{
+if( GetWhich( rSet, SID_ATTR_BRUSH, nWhich ) )
+{
+const SvxBrushItem& rBrush = static_cast( 
rSet.Get( nWhich ) );
+if( GPOS_NONE == rBrush.GetGraphicPos() )
+pImpl->mxBackColor = rBrush.GetColor();
+}
+}
+
 // Font
 SetPrevFont( rSet, SID_ATTR_CHAR_FONT, rFont );
 SetPrevFont( rSet, SID_ATTR_CHAR_CJK_FONT, rCJKFont );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 140007] UNDO Find and Replace leads to errors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140007

Telesto  changed:

   What|Removed |Added

 CC||michael.st...@allotropia.de

--- Comment #5 from Telesto  ---
(In reply to pavlog from comment #3)
> Bisected it in win64-6.4
> 
> 1263e46cce67d5a3e00360c11fec4dbe1cf87bff is the first bad commit
> commit 1263e46cce67d5a3e00360c11fec4dbe1cf87bff
> Author: Norbert Thiebaud 
> Date:   Sun Jun 14 13:07:41 2020 -0700
> 
> source sha:d6b0e84b236b78f4b21bd16e46dda3fa0876096d
> 
> source sha:d6b0e84b236b78f4b21bd16e46dda3fa0876096d
> 
> https://git.libreoffice.org/core/+/d6b0e84b236b78f4b21bd16e46dda3fa0876096d
> 
> commitd6b0e84b236b78f4b21bd16e46dda3fa0876096d[log]
> authorMichael Stahl Fri Jun 12 14:17:20 
> 2020 +0200
> committer Caolán McNamara Sun Jun 14 21:56:25 
> 2020 +0200
> tree  58f1f6c91777fff8c10df2f0d9b24d327c661c74
> parent2c2820b98c62e8de0806fd79c34b5fcf37f00c7e [diff]
> 
> Adding Cc: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 119793] Crash on redo of rectangle movement and text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119793

--- Comment #11 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1b1a9c6c12ebe4cac19e34ff5e4818998bbb2537

tdf#119793: sc_uicalc: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Xisco Fauli (via logerrit)]

 sc/qa/unit/uicalc/data/tdf119793.ods |binary
 sc/qa/unit/uicalc/uicalc.cxx |   41 +++
 2 files changed, 41 insertions(+)

New commits:
commit 1b1a9c6c12ebe4cac19e34ff5e4818998bbb2537
Author: Xisco Fauli 
AuthorDate: Wed Apr 21 22:09:27 2021 +0200
Commit: Xisco Fauli 
CommitDate: Thu Apr 22 09:50:48 2021 +0200

tdf#119793: sc_uicalc: Add unittest

Change-Id: Ie676a88546bd7ee1a077aba4c3322307b14319a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114457
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/unit/uicalc/data/tdf119793.ods 
b/sc/qa/unit/uicalc/data/tdf119793.ods
new file mode 100644
index ..e303bed01891
Binary files /dev/null and b/sc/qa/unit/uicalc/data/tdf119793.ods differ
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index 90a412d4588e..e42465402749 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -658,6 +658,47 @@ CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf133326)
 CPPUNIT_ASSERT_EQUAL(static_cast(2), pDoc->GetTableCount());
 }
 
+CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf119793)
+{
+ScModelObj* pModelObj = createDoc("tdf119793.ods");
+
+uno::Reference 
xPage(pModelObj->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY_THROW);
+uno::Reference xShape(xPage->getByIndex(0), 
uno::UNO_QUERY_THROW);
+
+CPPUNIT_ASSERT_EQUAL(static_cast(4984), 
xShape->getPosition().X);
+CPPUNIT_ASSERT_EQUAL(static_cast(1381), 
xShape->getPosition().Y);
+
+// Move the shape to the right
+lcl_SelectObjectByName(u"Shape 1");
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_RIGHT);
+Scheduler::ProcessEventsToIdle();
+
+//position has changed
+CPPUNIT_ASSERT_EQUAL(static_cast(5084), 
xShape->getPosition().X);
+CPPUNIT_ASSERT_EQUAL(static_cast(1381), 
xShape->getPosition().Y);
+
+// Type into the shape
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 'x', 0);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 'x', 0);
+Scheduler::ProcessEventsToIdle();
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(static_cast(5084), 
xShape->getPosition().X);
+CPPUNIT_ASSERT_EQUAL(static_cast(1381), 
xShape->getPosition().Y);
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+Scheduler::ProcessEventsToIdle();
+
+// Without the fix in place, this test would have failed with
+// - Expected: 4984
+// - Actual  : 5084
+CPPUNIT_ASSERT_EQUAL(static_cast(4984), 
xShape->getPosition().X);
+CPPUNIT_ASSERT_EQUAL(static_cast(1381), 
xShape->getPosition().Y);
+}
+
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf131455)
 {
 ScModelObj* pModelObj = createDoc("tdf131455.ods");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 119793] Crash on redo of rectangle movement and text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=119793

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:6.2.0 target:6.1.2   |target:6.2.0 target:6.1.2
   ||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140007] UNDO Find and Replace leads to errors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140007

Telesto  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1912

--- Comment #4 from Telesto  ---
Bisected to:

tdf#131912 sw: fix spell check correct deleting flys

* SwEditShell::ApplyChangedSentence() should not call
  DeleteAndJoin() + InsertString() but ReplaceRange()

* ReplaceRange() and SwUndoReplace need to set a new flag
  DelContentType::Replace to tell SwUndoSaveContent::DelContentIndex()
  not to delete flys but instead record the previous anchor positions

* SwUndoReplace::UndoImpl() should also not call DeleteAndJoin()
  + InsertString(); instead call ReplaceRange() for the start node
  and then DeleteAndJoin() for any regex "\n" that were inserted

(regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5)

Change-Id: I485d79510ae233213cb4b208533871934c5e5ec6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96201
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit e1629c210ad78310e3d48c0756723134a27b89df)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96204
Reviewed-by: Caolán McNamara 

https://git.libreoffice.org/core/+/d6b0e84b236b78f4b21bd16e46dda3fa0876096d

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 130326] XLSX: Long time for file opens and using 100% of one core of CPU after opening

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=130326

Noel Grandin  changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #28 from Noel Grandin  ---
So I had this improved down to around 17s, but since the
ScNavigatorDlg/ScContentTree welding, it is back to around 24s on my machine,

Caolan, perhaps you have some ideas about reducing how often the navigator
updates?

(The navigator also rebuilds the tree every time the cursor changes cells,
which makes clicking around the lower parts of this spreadsheet - around row
1000 - very very slow)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svx/source

[Caolán McNamara (via logerrit)]

 svx/source/sidebar/inspector/InspectorTextPanel.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cdbf09681b7c66c3d3c1d5c8086bd57e23f7939c
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 14:50:49 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 22 09:44:18 2021 +0200

if only the first col width is set, the 2nd will take the remaining space

which looks neater than having the gen headerbar have a blank area to
the right of the last col indicator

Change-Id: Ia5ffab425e1c4983db941722d118a954aae1d113
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114435
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/sidebar/inspector/InspectorTextPanel.cxx 
b/svx/source/sidebar/inspector/InspectorTextPanel.cxx
index 84a681055abf..fefc42727470 100644
--- a/svx/source/sidebar/inspector/InspectorTextPanel.cxx
+++ b/svx/source/sidebar/inspector/InspectorTextPanel.cxx
@@ -51,7 +51,7 @@ InspectorTextPanel::InspectorTextPanel(weld::Widget* pParent)
 float fWidth = mpListBoxStyles->get_approximate_digit_width();
 std::vector aWidths;
 aWidths.push_back(fWidth * 29);
-aWidths.push_back(fWidth * 10);
+// 2nd column will fill remaining space
 mpListBoxStyles->set_column_fixed_widths(aWidths);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/source

[Caolán McNamara (via logerrit)]

 include/vcl/toolkit/svtabbx.hxx |2 +-
 vcl/source/treelist/svtabbx.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 0f52706d8f1aef8b48236c60065f6ef0714987c0
Author: Caolán McNamara 
AuthorDate: Wed Apr 21 20:14:42 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 22 09:42:11 2021 +0200

pEntry argument can be const

Change-Id: I57357fabbbc2e10a6a82031320e2a65d78383507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114455
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/vcl/toolkit/svtabbx.hxx b/include/vcl/toolkit/svtabbx.hxx
index 480221ce0b09..e85fd85a61f1 100644
--- a/include/vcl/toolkit/svtabbx.hxx
+++ b/include/vcl/toolkit/svtabbx.hxx
@@ -81,7 +81,7 @@ public:
  sal_uLong nPos = TREELIST_APPEND, sal_uInt16 
nCol = 0x, void* pUserData = nullptr );
 
 virtual OUString GetEntryText( SvTreeListEntry* pEntry ) const override;
-static OUString  GetEntryText( SvTreeListEntry*, sal_uInt16 nCol );
+static OUString  GetEntryText( const SvTreeListEntry*, sal_uInt16 nCol );
 OUString GetEntryText( sal_uLong nPos, sal_uInt16 nCol = 0x ) 
const;
 using SvTreeListBox::SetEntryText;
 OUString GetCellText( sal_uLong nPos, sal_uInt16 nCol ) const;
diff --git a/vcl/source/treelist/svtabbx.cxx b/vcl/source/treelist/svtabbx.cxx
index ab1736f32120..c7fd080b68f9 100644
--- a/vcl/source/treelist/svtabbx.cxx
+++ b/vcl/source/treelist/svtabbx.cxx
@@ -291,7 +291,7 @@ OUString SvTabListBox::GetEntryText( SvTreeListEntry* 
pEntry ) const
 return GetEntryText( pEntry, 0x );
 }
 
-OUString SvTabListBox::GetEntryText( SvTreeListEntry* pEntry, sal_uInt16 nCol )
+OUString SvTabListBox::GetEntryText( const SvTreeListEntry* pEntry, sal_uInt16 
nCol )
 {
 DBG_ASSERT(pEntry,"GetEntryText:Invalid Entry");
 OUStringBuffer aResult;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/nisz/libreoffice-7-0' - solenv/clang-format sw/CppunitTest_sw_ooxmlexport16.mk sw/Module_sw.mk sw/qa writerfilter/source

[Justin Luth (via logerrit)]

 solenv/clang-format/blacklist|1 
 sw/CppunitTest_sw_ooxmlexport16.mk   |   14 
 sw/Module_sw.mk  |1 
 sw/qa/extras/ooxmlexport/data/tdf138892_noNumbering.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport16.cxx   |   43 +++
 writerfilter/source/dmapper/DomainMapper.cxx |6 +-
 writerfilter/source/dmapper/DomainMapper.hxx |2 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx|8 +-
 writerfilter/source/dmapper/DomainMapper_Impl.hxx|2 
 9 files changed, 69 insertions(+), 8 deletions(-)

New commits:
commit fe856843c29e22a73c5218db97db5210cf959720
Author: Justin Luth 
AuthorDate: Tue Dec 15 10:01:03 2020 +0300
Commit: Gabor Kelemen 
CommitDate: Thu Apr 22 09:28:56 2021 +0200

tdf#138892 writerfilter: cancel style list if bNoNumbering

This fixes 6.1 regression from tdf#95377's
commit e24e2d2fb02239753c1520a0458b44683ea4cc2e.

Starting in 7.0 (tdf#131321), paragraph styles kept their
numbering property. But even before that, non-paragraphs
marked by bNoNumbering were having their direct numbering
removed, and then finishParagraph applied para-style
numbering since there was no direct numbering.

So, we need to pass the bNoNumbering to finishParagraph
so that it can cancel out a style-assigned numbering.

Change-Id: I0c24af4e9bd0ea3712179a47ed3550f91c8f44b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107738
Tested-by: Jenkins
Reviewed-by: Justin Luth 
(cherry picked from commit bfcd952dc7820c4cf8761c4222d29ede039391dc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107795
(cherry picked from commit e901ffcb93d217f2cc09021a3b2fecb36f9884f6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107796
Reviewed-by: Miklos Vajna 
Tested-by: Justin Luth 
(cherry picked from commit 88aa8f5343705008b86ef41512993a00d331a668)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114423
Tested-by: Gabor Kelemen 
Reviewed-by: Gabor Kelemen 

diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist
index 5a1512485d53..b01ce8d1f15a 100644
--- a/solenv/clang-format/blacklist
+++ b/solenv/clang-format/blacklist
@@ -14200,6 +14200,7 @@ sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
 sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
 sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
 sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
+sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
 sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
 sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
 sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
diff --git a/sw/CppunitTest_sw_ooxmlexport16.mk 
b/sw/CppunitTest_sw_ooxmlexport16.mk
new file mode 100644
index ..4e78cef57760
--- /dev/null
+++ b/sw/CppunitTest_sw_ooxmlexport16.mk
@@ -0,0 +1,14 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call sw_ooxmlexport_test,16))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index be2e7e8d86c7..c1dff1df5c5a 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -81,6 +81,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\
 CppunitTest_sw_ooxmlexport13 \
 CppunitTest_sw_ooxmlexport14 \
 CppunitTest_sw_ooxmlexport15 \
+CppunitTest_sw_ooxmlexport16 \
 CppunitTest_sw_ooxmlexport_template \
 CppunitTest_sw_ooxmlfieldexport \
 CppunitTest_sw_ooxmllinks \
diff --git a/sw/qa/extras/ooxmlexport/data/tdf138892_noNumbering.docx 
b/sw/qa/extras/ooxmlexport/data/tdf138892_noNumbering.docx
new file mode 100644
index ..5c0a0176e37c
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf138892_noNumbering.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
new file mode 100644
index ..174f2f0f7330
--- /dev/null
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
@@ -0,0 +1,43 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+char const DATA_DIRECTORY[] = "/sw/qa/extras/ooxmlexport/data/";
+
+class Test : public SwModelTestBase
+{
+public:
+

[Libreoffice-bugs] [Bug 141805] Option "Gutter on right side of page" does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141805

--- Comment #4 from Miklos Vajna  ---
Complete removal of the checkbox would break the following workflow:

1) Open a docx file which has a section which has rtlGutter

2) Use the UI to remove the rtl gutter

3) save

4) The rtlGutter setting is gone.

So if we do what you suggest here, the next person can file a regression bug,
saying that it is no longer to interact with the rtl gutter feature of page
styles, and this used to work in the past.

Perhaps we can think about an existing Writer compatibility flag that indicates
that this is a Word document, and hide the checkbox in case that compatibility
flag is not set?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86321] EDITING, FORMATTING: diagram didn't automatic update when change variable (steps in comment 28)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86321

--- Comment #105 from VLB  ---
(In reply to Xisco Faulí from comment #96)
> Hi,
> My patch in comment 95 fixes the steps in comment 28. For other issues,
> please, fill a new report. Closing as RESOLVED FIXED

It is also possible to look at bug 141799 as it is very related to this fixed
bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - svx/source

[merttumer (via logerrit)]

 svx/source/svdraw/svdview.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit e7ef006f2f3d27904618adf59dd8b2f2c403f30a
Author: merttumer 
AuthorDate: Wed Apr 21 12:05:07 2021 +0300
Commit: Mert Tumer 
CommitDate: Thu Apr 22 09:17:34 2021 +0200

lok: Edit the click selected cell on table selection

for LOK case, it should start editing when table is selected
from the cell that is under the cursor instead of selecting the
table object.

Change-Id: Ibb3fa41377b76edcdcc2be7419838a151ff765fe
Signed-off-by: merttumer 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114386
Tested-by: Jenkins CollaboraOffice 

diff --git a/svx/source/svdraw/svdview.cxx b/svx/source/svdraw/svdview.cxx
index bb677b7707e6..2c784b6a6e2e 100644
--- a/svx/source/svdraw/svdview.cxx
+++ b/svx/source/svdraw/svdview.cxx
@@ -56,6 +56,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 SdrViewEvent::SdrViewEvent()
@@ -385,7 +386,9 @@ SdrHitKind SdrView::PickAnything(const Point& rLogicPos, 
SdrViewEvent& rVEvt) co
 // for e.g. URL links when hoovering and clicking
 // them will not work. Tried several other changes,
 // but this one safely keeps existing behaviour as-is.
-eHit = SdrHitKind::UnmarkedObject;
+// Except for the LOK. LOK doesn't have hoovering popup
+// feature.
+eHit = comphelper::LibreOfficeKit::isActive() ? 
SdrHitKind::TextEditObj : SdrHitKind::UnmarkedObject;
 break;
 default:
 break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: CppCheck Report on vm140 Not Running

[Miklos Vajna]

Hi Luke,

On Wed, Apr 21, 2021 at 02:16:21PM +, Luke Benes  
wrote:
> I spoke to the author of the cppcheck script, Maarten Hoes, about this
> issue. We would like to know why no one has responded to our emails
> about the cppcheck service being down. Are devs not interested in
> cppcheck's results, is it the high false positives, or is it that no
> one knows how to help get it back online?

I'm more interested in running such tools locally, so whenever I fix an
error/warning from such a tool, I can do have these steps:

1) run the tool -> see the result

2) attempt to fix it

3) run the tool again -> see the result disappearing

If the tool is not running locally, 2) will be a blind fix, which is not
ideal.

E.g. IWYU has a wrapper in core.git, so you can run:

bin/find-unneeded-includes path/to/test.cxx

and it'll show you the IWYU result for that .cxx file.

It is possible that such a wrapper for cppcheck would be also useful,
and would require less maintenance that a full service.

The other problem with cppcheck is that it doesn't build on an existing
c++ parser from a compiler (not based on e.g. gcc or clang), so its
signal/noise ratio is lower than e.g. coverity or clang-tidy. This is of
course not your fault, but it explains if the interest is lower than
what you expect.

Regards,

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, Must be activated with F9 or scroll in 7.2.0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141799

VLB  changed:

   What|Removed |Added

Summary|Editing: Charts didn't  |Editing: Charts didn't
   |automatic update when   |automatic update when
   |change variable in multiple |change variable in multiple
   |sheets, Must be activated   |sheets, Must be activated
   |with F9 |with F9 or scroll in 7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/core/layout/wsfrm.cxx |   18 +++---
 1 file changed, 11 insertions(+), 7 deletions(-)

New commits:
commit 92d026269df0d6eb7a2aaa5502c0bf2b495e
Author: Miklos Vajna 
AuthorDate: Wed Apr 21 21:01:20 2021 +0200
Commit: Miklos Vajna 
CommitDate: Thu Apr 22 09:05:33 2021 +0200

Replace magic numbers in SwFrame::UpdateAttrFrame()

By using the same SwFrameInvFlags constants that
SwFrame::SwClientNotify() already does.

Change-Id: I029006f95758bd91515ecc59ae02b28396a57d0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114453
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index 579ed1f5df47..ca8cc3c8ef9b 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -538,29 +538,32 @@ void SwFrame::UpdateAttrFrame( const SfxPoolItem *pOld, 
const SfxPoolItem *pNew,
 case RES_LR_SPACE:
 case RES_UL_SPACE:
 case RES_RTL_GUTTER:
-rInvFlags |= static_cast(0x0B);
+rInvFlags |= SwFrameInvFlags::InvalidatePrt | 
SwFrameInvFlags::InvalidateSize
+ | SwFrameInvFlags::SetCompletePaint;
 break;
 
 case RES_HEADER_FOOTER_EAT_SPACING:
-rInvFlags |= static_cast(0x03);
+rInvFlags |= SwFrameInvFlags::InvalidatePrt | 
SwFrameInvFlags::InvalidateSize;
 break;
 
 case RES_BACKGROUND:
 case RES_BACKGROUND_FULL_SIZE:
-rInvFlags |= static_cast(0x28);
+rInvFlags |= SwFrameInvFlags::SetCompletePaint | 
SwFrameInvFlags::NextSetCompletePaint;
 break;
 
 case RES_KEEP:
-rInvFlags |= static_cast(0x04);
+rInvFlags |= SwFrameInvFlags::InvalidatePos;
 break;
 
 case RES_FRM_SIZE:
 ReinitializeFrameSizeAttrFlags();
-rInvFlags |= static_cast(0x13);
+rInvFlags |= SwFrameInvFlags::InvalidatePrt | 
SwFrameInvFlags::InvalidateSize
+ | SwFrameInvFlags::NextInvalidatePos;
 break;
 
 case RES_FMT_CHG:
-rInvFlags |= static_cast(0x0F);
+rInvFlags |= SwFrameInvFlags::InvalidatePrt | 
SwFrameInvFlags::InvalidateSize
+ | SwFrameInvFlags::InvalidatePos | 
SwFrameInvFlags::SetCompletePaint;
 break;
 
 case RES_ROW_SPLIT:
@@ -586,7 +589,8 @@ void SwFrame::UpdateAttrFrame( const SfxPoolItem *pOld, 
const SfxPoolItem *pNew,
 // the new FillStyle has to do the same as previous RES_BACKGROUND
 if(nWhich >= XATTR_FILL_FIRST && nWhich <= XATTR_FILL_LAST)
 {
-rInvFlags |= static_cast(0x28);
+rInvFlags
+|= SwFrameInvFlags::SetCompletePaint | 
SwFrameInvFlags::NextSetCompletePaint;
 }
 /* do Nothing */;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, Must be activated with F9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #8 from VLB  ---
(In reply to Lars Jødal from comment #6)
> Testing with old versions, standard setup (no change in cache sizes), I find
> that the bug appears on 6.0.0.0.beta1, but NOT in 6.0.0.0.alpha1.
> 
> I.e., the bug seems to be caused by some commit between 6.0.0.0.alpha1 and
> 6.0.0.0.beta1. Changing earliest affected version to the closest available
> version number.
> 
> Version: 6.0.0.0.beta1 (x64)
> Build ID: 97471ab4eb4db4c487195658631696bb3238656c
> CPU threads: 4; OS: Windows 10.0; UI render: GL; 
> Locale: da-DK (da_DK); Calc: CL
> 
> PS: The number of charts updated or not was different in this test than what
> I found in comment 2, but the important point remains: Not all charts were
> updated from version 6.0.0.0.beta1 and later versions; and 7.2.0.0.alpha0+
> helps (you only need to scroll for update) but does not completely solve the
> problem.

I have also tested it and can confirm that the bug is occurring here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, Must be activated with F9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141799

--- Comment #7 from VLB  ---
To prevent the issue from occurring, you can do the following:

Go to Tools-> Options-> LibreOffice → Advanced → Open Expert Configuration →
Search for "cache" → Change org.openoffice.Office.Common → Cache → Drawing
Engine (OLE_Objects) to e.g. 40 (default value 20).

When I set this value back to the default value it is reproduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, Must be activated with F9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141799

VLB  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141799] Editing: Charts didn't automatic update when change variable in multiple sheets, Must be activated with F9

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141799

Lars Jødal  changed:

   What|Removed |Added

Version|7.2.0.0.alpha0+ Master  |6.0.0.3 release

--- Comment #6 from Lars Jødal  ---
Testing with old versions, standard setup (no change in cache sizes), I find
that the bug appears on 6.0.0.0.beta1, but NOT in 6.0.0.0.alpha1.

I.e., the bug seems to be caused by some commit between 6.0.0.0.alpha1 and
6.0.0.0.beta1. Changing earliest affected version to the closest available
version number.

Version: 6.0.0.0.beta1 (x64)
Build ID: 97471ab4eb4db4c487195658631696bb3238656c
CPU threads: 4; OS: Windows 10.0; UI render: GL; 
Locale: da-DK (da_DK); Calc: CL

PS: The number of charts updated or not was different in this test than what I
found in comment 2, but the important point remains: Not all charts were
updated from version 6.0.0.0.beta1 and later versions; and 7.2.0.0.alpha0+
helps (you only need to scroll for update) but does not completely solve the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 120949] [META] Elementary icons

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=120949

Ming Hua  changed:

   What|Removed |Added

 Depends on||141823


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141823
[Bug 141823] elementary: Please unify the design of the "function" icon in
different sizes
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141823] New: elementary: Please unify the design of the "function" icon in different sizes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141823

Bug ID: 141823
   Summary: elementary: Please unify the design of the "function"
icon in different sizes
   Product: LibreOffice
   Version: 7.0.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ming.v@qq.com
Blocks: 120949

Created attachment 171347
  --> https://bugs.documentfoundation.org/attachment.cgi?id=171347=edit
Screenshot of the function icon used in various places in Calc

The Calc module uses a "math function" icon in many places on its UI, such as
formula bar and sidebar.  The image of this function icon is usually some
variation of "f(x)".

In the elementary theme, it seems that the different sizes of this icon have
rather distinctive designs.  As shown in the screenshot, the larger icon used
as the sidebar selector is "f(x)", with parentheses, while the smaller icon
used by the formula bar and inside the functions panel of sidebar is just "fx",
without the parentheses.

This looks inconsistent and distracting IMHO, without much benefit.  It would
be nice if their design can be unified, presumably by making the larger icon
also "fx", because parentheses would make the image too busy on smaller size.

Screenshot is made with 7.0.5 on Windows 10:
Version: 7.0.5.2 (x64)
Build ID: 64390860c6cd0aca4beafafcfd84613dd9dfb63a
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: zh-CN (zh_CN); UI: en-US
Calc: threaded

...but also reproducible on 7.1.3 RC1 and 7.2.0 alpha0+ daily build.  Also
should be reproducible for all platforms.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120949
[Bug 120949] [META] Elementary icons
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140702] It disappeared "To page" item from Anchor drop-down widget on Frame toolbar in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140702

--- Comment #17 from Mike Kaganski  ---
(In reply to Mike Kaganski from comment #16)
> which is exactly the misconception which caused this bug

Please ignore the "which caused this bug", it was a thinko (I was thinking
about a different bug - tdf#89477 - when wrote this).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 87622] Placing a large number of Charts in a sheet causes then not to update (crash)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87622

--- Comment #4 from Lars Jødal  ---
Just in case anybody should pass this bug: Bug 86321 has been fixed (effective
from 7.1.4 and 7.2.0), which helps a lot on chart update problems. Not all
problems are completely gone, though, and the test case from this bug is
continued in bug 141799.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 135310] [META] Writer outline folding bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=135310

Dieter  changed:

   What|Removed |Added

 Depends on||140130


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=140130
[Bug 140130] Checkbox "Show outline content visibility button" not visible on
MacOSX
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140130] Checkbox "Show outline content visibility button" not visible on MacOSX

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140130

Dieter  changed:

   What|Removed |Added

 Blocks||135310


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=135310
[Bug 135310] [META] Writer outline folding bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Slow fetching of https://gerrit.libreoffice.org/core?

[Stephan Bergmann]

On 19/04/2021 11:17, Stephan Bergmann wrote:
More often than not, trying to do a LibreOffice Flatpak build on Flathub 
fails because the step that fetches the 
 git repo times out.  See e.g. 
 and 
, with the 
relevant log output being


]2;flatpak-builder: Downloading gvfs]2;flatpak-builder: 
Downloading krb5]2;flatpak-builder: Downloading libreofficeFetching 
full git repo https://gerrit.libreoffice.org/core?
command timed out: 3600 seconds without output running 
[b'flatpak-builder', b'--download-only', b'--no-shallow-clone', 
b'--allow-missing-runtimes', b'--state-dir=/srv/buildbot/sources', 
b'/srv/buildbot/sources/.builddir', 
b'org.libreoffice.LibreOffice.json'], attempting to kill


I'm not sure whether the best place to do something about this would be 
the serving libreoffice.org side, or the receiving flathub.org side, or 
even my choice of  git repo URL at 
 
"solenv/flatpak-manifest.in: Merge 'Switch git repo URL from git: to 
https:'"?


So this has apparently been discussed at 
 
"[libreoffice-website] Minutes from the Tue Apr 20 infra call".


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 140564] Give user a guide about the position of the page gutter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140564

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I added keyword "needsUXEval", because it's an enhancement request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 140564] Give user a guide about the position of the page gutter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140564

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I added keyword "needsUXEval", because it's an enhancement request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 140565] Add a view option for 'Book view' to suppress page gutter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140565

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I added keyword "needsUXEval", because it's an enhancement request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 140565] Add a view option for 'Book view' to suppress page gutter

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140565

Dieter  changed:

   What|Removed |Added

   Keywords||needsUXEval
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I added keyword "needsUXEval", because it's an enhancement request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 140568] Allow page gutter position 'Right' for left pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140568

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I Added keyword "needsUXEval, because it's an enhancement request.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 140568] Allow page gutter position 'Right' for left pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140568

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
I Added keyword "needsUXEval, because it's an enhancement request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 141797] Bugs during Installation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141797

Timur  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #4 from Timur  ---
Simple search on Internet would show what's written, this is not about LO. 
So this is invalid report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141434] First line of paragraphs in .docx files disappear when I use hanging indents, even though text is still there

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141434

Dieter  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Dieter  ---
(In reply to Drew Heiderscheidt from comment #0)
> Steps to Reproduce:
> I could not reproduce this on command, but it has happened multiple times.
> 
> Actual Results:
> The first line of every paragraph disappears.

First step for QA in Bugzilla is to reproduce this problem. But if you don't
can describe some steps and if you can't reproduce it on your own, it won't be
possible for anybody else.

So please try to describe some steps. You also can add a sample document.
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 140702] It disappeared "To page" item from Anchor drop-down widget on Frame toolbar in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140702

--- Comment #16 from Mike Kaganski  ---
(In reply to Tomasz Sztejka from comment #15)

Thanks for the post!
Basically, I wanted to say that your post is not a contradiction to mine, but
rather a clarification of some points there. E.g., I write "... Users do not
realize what it does, and how could *what they really need* be achieved ..."
and "... users misused (misunderstood) the "to page" anchoring ...", and you
describe how *some* (minority of ;-P) users *could* discover that. I mostly
agree with you (well, except for "Object anchored to page stays in it's
relative position to page corner. This is in fact a bit problematic because it
is hard to guess to "which page corner". This, as far as I remember from an old
OpenOffice, used to work fine with manual page breaks, but now it seems to
ignore it what is confusing" - no, it worked this way from the beginning, e.g.
in OOo 1.0.3; and except for "if You add or remove a MANUAL PAGE BREAK. In my
opinion it should move then", which is exactly the misconception which caused
this bug).

But would you like to implement what you rightfully mention as missing? It's as
easy as:
1. Creating an account at TDF;
2. Logging in to https://gerrit.libreoffice.org/;
3. Browsing to "help" repository;
4. Creating a new change for it;
5. Opening the xhp file named like the related help page (e.g., for
https://help.libreoffice.org/7.0/en-US/text/shared/01/05260100.html it would be
"text/shared/01/05260100.xhp");
making the required changes in plain text in the Web UI, and starting a review.

More on that at https://wiki.documentfoundation.org/Documentation.

> Maybe it is a problem because it never worked as it should work?

Note that "work" is an ambiguous. In this discussion, it's important to
disambiguate the two aspects:
1. How anchored objects behave when layouting (i.e., how they behave when the
anchored-to object moves, when the anchor settings do not change);
2. How the anchoring UI behaves (i.e., how the tools work that define the
anchor settings).

And #1 generally works as it should. But #2 needs much improvements (my bugs
mentioned in comment 12, and largely your comment, are focused on this).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103309] [META] Print dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103309

Dieter  changed:

   What|Removed |Added

 Depends on||141536


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=141536
[Bug 141536] Print Dialog: Dialog page is too big for screen
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 141536] Print Dialog: Dialog page is too big for screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141536

Dieter  changed:

   What|Removed |Added

 Blocks||103309
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de
Summary|Print Option|Print Dialog: Dialog page
   ||is too big for screen
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
Tim, thank you for reporting the bug. Could you please try to reproduce it with
the latest version of LibreOffice from
https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's
status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is
still present in the latest version. Change to RESOLVED WORKSFORME, if the
problem went away.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103309
[Bug 103309] [META] Print dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sc/source

[Dennis Francis (via logerrit)]

 sc/source/ui/view/viewdata.cxx |   23 +++
 1 file changed, 19 insertions(+), 4 deletions(-)

New commits:
commit 88f5b8b924ef38e7ff20316e7ddc3cfe66b378d0
Author: Dennis Francis 
AuthorDate: Wed Apr 14 13:26:26 2021 +0530
Commit: Dennis Francis 
CommitDate: Thu Apr 22 08:05:39 2021 +0200

lok: fix incomplete/wrong tiles after zoom change and sheet switch

Fix:
Reset position cache for all sheets on zoom change.

Change-Id: I58264d4674d2cb736c702096ffd52faffb603ec6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114227
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
(cherry picked from commit fe52c79323f9ac4b5ea61e7d7e5f038552e9a247)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114362
Reviewed-by: Dennis Francis 

diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 0ad17c2ace93..91f5fc6062af 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -3143,10 +3143,25 @@ void ScViewData::CalcPPT()
 }
 }
 
-if (nPPTX != nOldPPTX)
-GetLOKWidthHelper().invalidateByPosition(0L);
-if (nPPTY != nOldPPTY)
-GetLOKHeightHelper().invalidateByPosition(0L);
+if (comphelper::LibreOfficeKit::isActive())
+{
+SCTAB nTabCount = maTabData.size();
+bool bResetWidths = (nPPTX != nOldPPTX);
+bool bResetHeights = (nPPTY != nOldPPTY);
+for (SCTAB nTabIdx = 0; nTabIdx < nTabCount; ++nTabIdx)
+{
+if (!maTabData[nTabIdx])
+continue;
+
+if (bResetWidths)
+if (auto* pWHelper = GetLOKWidthHelper(nTabIdx))
+pWHelper->invalidateByPosition(0L);
+
+if (bResetHeights)
+if (auto* pHHelper = GetLOKHeightHelper(nTabIdx))
+pHHelper->invalidateByPosition(0L);
+}
+}
 }
 
 #define SC_OLD_TABSEP   '/'
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits