[Libreoffice-commits] core.git: emfio/qa emfio/source tools/source

2021-05-20 Thread Bartosz Kosiorek (via logerrit)
 emfio/qa/cppunit/emf/EmfImportTest.cxx   |   47 ---
 emfio/qa/cppunit/emf/data/TestArcStartPointEqualEndPoint.emf |binary
 emfio/source/reader/emfreader.cxx|   19 
 tools/source/generic/poly.cxx|6 -
 4 files changed, 40 insertions(+), 32 deletions(-)

New commits:
commit fb5247bf587518eaa01cf5d54dceddf73827d740
Author: Bartosz Kosiorek 
AuthorDate: Thu May 20 23:27:45 2021 +0200
Commit: Bartosz Kosiorek 
CommitDate: Fri May 21 07:30:28 2021 +0200

tdf#55007 tdf#142263 tdf#142268 EMF ARC, PIE, CHORD allow to draw circle

In Metafile specification, if Start Point is the same as End Point,
then the full circle should be drawn.

Unfortunately with previous implementation, if Start Point is the same
as End Point, nothing is drawn.

This patch fixes that and removed EDGES optimizations, which causes
display issues.

Change-Id: I16a1b98f10378d57bed59696db6cc9f228044292
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115891
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/emfio/qa/cppunit/emf/EmfImportTest.cxx 
b/emfio/qa/cppunit/emf/EmfImportTest.cxx
index 64c7effa1baa..bca5cbc161e3 100644
--- a/emfio/qa/cppunit/emf/EmfImportTest.cxx
+++ b/emfio/qa/cppunit/emf/EmfImportTest.cxx
@@ -53,6 +53,7 @@ class Test : public test::BootstrapFixture, public 
XmlTestTools, public unotest:
 void TestTextMapMode();
 void TestEnglishMapMode();
 void TestRectangleWithModifyWorldTransform();
+void TestArcStartPointEqualEndPoint();
 void TestArcInsideWronglyDefinedRectangle();
 void TestChordWithModifyWorldTransform();
 void TestEllipseWithSelectClipPath();
@@ -82,6 +83,7 @@ public:
 CPPUNIT_TEST(TestTextMapMode);
 CPPUNIT_TEST(TestEnglishMapMode);
 CPPUNIT_TEST(TestRectangleWithModifyWorldTransform);
+CPPUNIT_TEST(TestArcStartPointEqualEndPoint);
 CPPUNIT_TEST(TestArcInsideWronglyDefinedRectangle);
 CPPUNIT_TEST(TestChordWithModifyWorldTransform);
 CPPUNIT_TEST(TestEllipseWithSelectClipPath);
@@ -357,9 +359,28 @@ void Test::TestChordWithModifyWorldTransform()
 xmlDocUniquePtr pDocument = 
dumper.dumpAndParse(comphelper::sequenceToContainer(aSequence));
 CPPUNIT_ASSERT (pDocument);
 
-assertXPath(pDocument, "/primitive2D/metafile/transform/polypolygoncolor", 
"color", "#ff");
-assertXPath(pDocument, 
"/primitive2D/metafile/transform/polypolygoncolor/polypolygon", "path", "m590 
448-154 93-54 57-21 45 24 67 45 21 224-6 265-97z");
-assertXPathContent(pDocument, 
"/primitive2D/metafile/transform/polygonstroke/polygon", "590,448 436,541 
382,598 361,643 385,710 430,731 654,725 919,628");
+assertXPath(pDocument, "/primitive2D/metafile/transform/polypolygoncolor",
+"color", "#ff");
+assertXPath(pDocument, 
"/primitive2D/metafile/transform/polypolygoncolor/polypolygon",
+"path", "m590 448-21 45-66 24-34 12-33 12-21 45-33 12 12 33-33 
12 12 33 12 34 33-12 12 33 34-12 33-12 45 21 33-12 33-12 46 21 66-25 33-12 
66-24 34-12 66-24z");
+assertXPathContent(pDocument, 
"/primitive2D/metafile/transform/polygonstroke/polygon",
+   "590,448 569,493 503,517 469,529 436,541 415,586 
382,598 394,631 361,643 361,643 373,676 373,676 385,710 418,698 430,731 464,719 
497,707 542,728 575,716 608,704 654,725 720,700 753,688 819,664 853,652 
919,628");
+}
+
+void Test::TestArcStartPointEqualEndPoint()
+{
+// i73608 EMF import test where StartPoint == EndPoint. It should draw 
full circle
+// Records: SETMAPMODE, SETWINDOWEXTEX, SETWINDOWORGEX, EXTSELECTCLIPRGN, 
INTERSECTCLIPRECT, MOVETOEX, ARC
+Primitive2DSequence aSequence = 
parseEmf(u"/emfio/qa/cppunit/emf/data/TestArcStartPointEqualEndPoint.emf");
+CPPUNIT_ASSERT_EQUAL(1, static_cast(aSequence.getLength()));
+drawinglayer::Primitive2dXmlDump dumper;
+xmlDocUniquePtr pDocument = 
dumper.dumpAndParse(comphelper::sequenceToContainer(aSequence));
+CPPUNIT_ASSERT (pDocument);
+
+assertXPath(pDocument, 
"/primitive2D/metafile/transform/mask/group/mask/polygonhairline",
+"color", "#00");
+assertXPathContent(pDocument, 
"/primitive2D/metafile/transform/mask/group/mask/polygonhairline/polygon",
+   "11886,23133 11970,23223 12051,23316 12131,23410 
12208,23506 12282,23604 12354,23704 12424,23805 12491,23909 12556,24014 
12618,24120 12677,24228 12734,24337 12788,24448 12839,24560 12888,24673 
12933,24788 12976,24903 13016,25020 13053,25137 13087,25256 13119,25375 
13147,25495 13172,25615 13195,25736 13214,25858 13230,25980 13244,26103 
13254,26225 13261,26348 13266,26472 13267,26595 13265,26718 13260,26841 
13253,26964 13242,27087 13228,27209 13211,27331 13191,27453 13168,27574 
13142,27694 13113,27814 13082,27933 13047,28051 13009,28169 12969,28285 
12926,28400 12879,28514 12830,28628 12779,28739 12724,28850 

[Libreoffice-bugs] [Bug 142122] Applying changes to application color must not save it

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142122

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142118] Application color AutoSpellcheck not applied immediately

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142118

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142116] Application color Field Shading not respected

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142116

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142123] Charts/Graph in Calc don't allow full Text Formating of Legends and Axes Titles.

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142123

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142129] Exported PDF of master document with hidden sections containing headings shows headings anyway

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142129

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142120] Application color for CalcText not respected for cells with line breaks

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142120

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142114] Wrong page numbers in TOC when printed / saved as PDF due to hidden text

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142114

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141972] Fileopen and filesave Hyperlinks from and to PPT

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141972

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137609] When I click any inputed cell, Calc erase the inputed characters. The occurrence of this phenomenon is random.

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137609

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141851] Extension Manager 'Check For Updates' crash

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141851

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 141851] Extension Manager 'Check For Updates' crash

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141851

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137609] When I click any inputed cell, Calc erase the inputed characters. The occurrence of this phenomenon is random.

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137609

--- Comment #3 from QA Administrators  ---
Dear MARINA-SODA,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137416] Crash in: libc-2.25.so

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137416

--- Comment #3 from QA Administrators  ---
Dear evgeny.semus,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137416] Crash in: libc-2.25.so

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137416

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138390] Charts from very big tables spoil the system - no more work an LO possible till restart

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138390

--- Comment #2 from QA Administrators  ---
Dear Doaro,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 138019] LibreOffice programmers make little executable to repair xls imprisoned in filters

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138019

--- Comment #2 from QA Administrators  ---
Dear PacaGarse5,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137910] Calc: mouse snapping on top row

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137910

--- Comment #2 from QA Administrators  ---
Dear Moltensen,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 124798] Headless Writer conversion to PDF consumes is stuck at 100% CPU usage

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=124798

--- Comment #5 from QA Administrators  ---
Dear Nicolas Göddel,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 135086] Cell containing unwanted hyperlink cannot be edited

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135086

--- Comment #3 from QA Administrators  ---
Dear Bernard,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 123992] [l10n] Use separate strings for menu items and icon tooltips

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=123992

--- Comment #7 from QA Administrators  ---
Dear Ming Hua,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source

2021-05-20 Thread Miklos Vajna (via logerrit)
 sw/qa/core/txtnode/data/title-field-invalidate.fodt |4 +++-
 sw/source/core/txtnode/atrfld.cxx   |   14 +++---
 2 files changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 50d58a15b548044e637b22c290ea52b4741a775a
Author: Miklos Vajna 
AuthorDate: Wed May 19 10:24:32 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 21 06:22:59 2021 +0200

sw: fix not needed invalidation of custom field on each keypress

And do the same for modification fields (e.g. modification date) and
subject fields as well. In all cases the layout already reacts to the
doc model change via normal notifications, no need to force anything.
(Confirmed with manual testing.)

This builds on top of commit 0a32630d11ebdb8b8218faa066c72582ef2f300d
(sw: fix not needed invalidation of title field on each keypress,
2021-05-18).

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115784
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 1dcd3f1b9fc0d888e047e854a20e9ab2e0afd544)

Change-Id: I8015b33a6680d75cd5b6446eb9275bb018ea7613
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115875
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/core/txtnode/data/title-field-invalidate.fodt 
b/sw/qa/core/txtnode/data/title-field-invalidate.fodt
index e47129538fa9..e7d07cab7b63 100644
--- a/sw/qa/core/txtnode/data/title-field-invalidate.fodt
+++ b/sw/qa/core/txtnode/data/title-field-invalidate.fodt
@@ -1,7 +1,9 @@
 
 http://purl.org/dc/elements/1.1/; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
office:mimetype="application/vnd.oasis.opendocument.text">
   
+mysubject
 mytitle
+1.1
   
   
 
@@ -11,7 +13,7 @@
   
 
   
-mytitle
+mysubject 
mytitle 1.1 May 18, 
2021
   
 
   
diff --git a/sw/source/core/txtnode/atrfld.cxx 
b/sw/source/core/txtnode/atrfld.cxx
index d5f76f7ce4bd..ffb7aed2c5e0 100644
--- a/sw/source/core/txtnode/atrfld.cxx
+++ b/sw/source/core/txtnode/atrfld.cxx
@@ -317,16 +317,24 @@ void SwFormatField::Modify( const SfxPoolItem* pOld, 
const SfxPoolItem* pNew )
 bool bForceNotify = (pOld == nullptr) && (pNew == nullptr);
 if (bForceNotify)
 {
-// Force notify was added for conditional text fields, at least the 
title fields needs
+// Force notify was added for conditional text fields, at least the 
below fields need
 // no forced notify.
 const SwField* pField = mpTextField->GetFormatField().GetField();
 const SwFieldIds nWhich = pField->GetTyp()->Which();
 if (nWhich == SwFieldIds::DocInfo)
 {
 auto pDocInfoField = static_cast(pField);
-if (pDocInfoField->GetSubType() == nsSwDocInfoSubType::DI_TITLE)
+sal_uInt16 nSubType = pDocInfoField->GetSubType();
+// Do not consider extended SubTypes.
+nSubType &= 0xff;
+switch (nSubType)
 {
-bForceNotify = false;
+case nsSwDocInfoSubType::DI_TITLE:
+case nsSwDocInfoSubType::DI_THEMA:
+case nsSwDocInfoSubType::DI_CHANGE:
+case nsSwDocInfoSubType::DI_CUSTOM:
+bForceNotify = false;
+break;
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/qa sw/source

2021-05-20 Thread Miklos Vajna (via logerrit)
 sw/qa/core/txtnode/data/title-field-invalidate.fodt |4 +++-
 sw/source/core/txtnode/atrfld.cxx   |   14 +++---
 2 files changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 93d6b09c33ae9f17e26266c3b8f7122a60a4ae0b
Author: Miklos Vajna 
AuthorDate: Wed May 19 10:24:32 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 21 06:19:23 2021 +0200

sw: fix not needed invalidation of custom field on each keypress

And do the same for modification fields (e.g. modification date) and
subject fields as well. In all cases the layout already reacts to the
doc model change via normal notifications, no need to force anything.
(Confirmed with manual testing.)

This builds on top of commit 0a32630d11ebdb8b8218faa066c72582ef2f300d
(sw: fix not needed invalidation of title field on each keypress,
2021-05-18).

(cherry picked from commit 1dcd3f1b9fc0d888e047e854a20e9ab2e0afd544)

Change-Id: I8015b33a6680d75cd5b6446eb9275bb018ea7613
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115874
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Mike Kaganski 

diff --git a/sw/qa/core/txtnode/data/title-field-invalidate.fodt 
b/sw/qa/core/txtnode/data/title-field-invalidate.fodt
index e47129538fa9..e7d07cab7b63 100644
--- a/sw/qa/core/txtnode/data/title-field-invalidate.fodt
+++ b/sw/qa/core/txtnode/data/title-field-invalidate.fodt
@@ -1,7 +1,9 @@
 
 http://purl.org/dc/elements/1.1/; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
office:mimetype="application/vnd.oasis.opendocument.text">
   
+mysubject
 mytitle
+1.1
   
   
 
@@ -11,7 +13,7 @@
   
 
   
-mytitle
+mysubject 
mytitle 1.1 May 18, 
2021
   
 
   
diff --git a/sw/source/core/txtnode/atrfld.cxx 
b/sw/source/core/txtnode/atrfld.cxx
index bb95a8799081..98d4b235220f 100644
--- a/sw/source/core/txtnode/atrfld.cxx
+++ b/sw/source/core/txtnode/atrfld.cxx
@@ -380,16 +380,24 @@ void SwFormatField::UpdateTextNode(const SfxPoolItem* 
pOld, const SfxPoolItem* p
 bool bForceNotify = pOld == nullptr && pNew == nullptr;
 if (bForceNotify)
 {
-// Force notify was added for conditional text fields, at least 
the title fields needs
+// Force notify was added for conditional text fields, at least 
the below fields need
 // no forced notify.
 const SwField* pField = mpTextField->GetFormatField().GetField();
 const SwFieldIds nWhich = pField->GetTyp()->Which();
 if (nWhich == SwFieldIds::DocInfo)
 {
 auto pDocInfoField = static_cast(pField);
-if (pDocInfoField->GetSubType() == 
nsSwDocInfoSubType::DI_TITLE)
+sal_uInt16 nSubType = pDocInfoField->GetSubType();
+// Do not consider extended SubTypes.
+nSubType &= 0xff;
+switch (nSubType)
 {
-bForceNotify = false;
+case nsSwDocInfoSubType::DI_TITLE:
+case nsSwDocInfoSubType::DI_SUBJECT:
+case nsSwDocInfoSubType::DI_CHANGE:
+case nsSwDocInfoSubType::DI_CUSTOM:
+bForceNotify = false;
+break;
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2021-05-20 Thread Mike Kaganski (via logerrit)
 sc/source/ui/docshell/impex.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 6155689bb6f1d72f29b43ac5ae94b32522ef9b42
Author: Mike Kaganski 
AuthorDate: Fri May 21 00:03:43 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri May 21 06:11:23 2021 +0200

tdf#142395: properly handle "no string delimiter" case

In this case, the delimiter character value would be '\0'.

Change-Id: Idb0f01756991b3ea35a92f11b78fddd56c25265a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115839
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 3e58a9767cbe..b1a553a2ac10 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -1592,7 +1592,7 @@ const sal_Unicode* 
ScImportExport::ScanNextFieldFromString( const sal_Unicode* p
 rbIsQuoted = false;
 rField.clear();
 const sal_Unicode cBlank = ' ';
-if (!ScGlobal::UnicodeStrChr( pSeps, cBlank))
+if (cStr && !ScGlobal::UnicodeStrChr(pSeps, cBlank))
 {
 // Cope with broken generators that put leading blanks before a quoted
 // field, like "field1", "field2", "..."
@@ -1603,7 +1603,7 @@ const sal_Unicode* 
ScImportExport::ScanNextFieldFromString( const sal_Unicode* p
 if (*pb == cStr)
 p = pb;
 }
-if ( *p == cStr )   // String in quotes
+if (cStr && *p == cStr) // String in quotes
 {
 rbIsQuoted = true;
 const sal_Unicode* p1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 132042] TEMPLATE MANAGER: Errors when deleting a category in templates

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132042

--- Comment #11 from BogdanB  ---
VertD, I retested. It's the same, on Linux and Windows.
Please take a look at the video from comment 2.


Retested.
Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: b238522ca121ca8f863fe4d3394ade088a65ad01
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142401] New: LibreOffice writer: stucks forever when collapsing between pages on Windows 7

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142401

Bug ID: 142401
   Summary: LibreOffice writer: stucks forever when collapsing
between pages on Windows 7
   Product: LibreOffice
   Version: 7.1.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ferrumc...@sina.com

Description:
Tested on the latest release of LibreOffice on Windows 7.
When I click the blank between pages, trying to collapse it, the application
stucks forever with no response.

Steps to Reproduce:
1.Open a word file with LibreOffice Writer on Windows 7 with a touchscreen
device
2.Doubleclick the blank between pages on the screen


Actual Results:
Writer freezes and appeared no response

Expected Results:
Collapsing the blank between pages, 


Reproducible: Always


User Profile Reset: Yes



Additional Info:
s

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142398] FILESAVE DOCX Several Writer shapes textbox saved incorrectly

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142398

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||rb.hensc...@t-online.de

--- Comment #5 from Regina Henschel  ---
The example shapes do not have a text box, but a simple label text. The segment
is not a custom shape at all.

In case a custGeom is written, a  has to be generated. For to get
the correct rectangle, it is needed to get the property "TextFrames" from
"Path" in CustomGeomety. But currently only the preset shape types l, t, r, b
are written:
https://opengrok.libreoffice.org/xref/core/oox/source/export/drawingml.cxx?r=af16aa62#3768
https://opengrok.libreoffice.org/xref/core/oox/source/export/drawingml.cxx?r=af16aa62=WriteCustomGeometry#3557

In case of prstGeom there is no need for a  element. So writing a
shape as ooxml-foo (if possible), would solve the  problem. But it
has the downside, that reload and export to binary MS formats will loose the
shape. And some of our mso-foo shapes do not have a directly corresponding
ooxml-shape.

It might help to sort the shapes currently in the floater in the UI in
categories
a) work with l, t, r, b
b) do not work with l, t, r, b, but have exactly corresponding ooxml preset
shape
c) do not work with l, t, r, b and need ooxml custGeom.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142365] Mouse pointer disappears over cells EDITING

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142365

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #6 from m.a.riosv  ---
Repro now with:
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 05366b8e6683363688de8708a3d88cf144c7a2bf
CPU threads: 4; OS: Windows 10.0 Build 21382; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142390] calc 7.2.0.0.a0+ >2021-05-19, no mouse cursor in cell area

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142390

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #10 from m.a.riosv  ---
Repro with
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 05366b8e6683363688de8708a3d88cf144c7a2bf
CPU threads: 4; OS: Windows 10.0 Build 21382; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2021-05-20 Thread Steve Fanning (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit eda109d5d91e82adb675ebf6db952bf6d82b3391
Author: Steve Fanning 
AuthorDate: Fri May 21 01:17:43 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Fri May 21 01:17:43 2021 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to ab50f2ccc57ebe577cbdad4afa29b66317b87bcc
  - Fix text in 2nd example given in help description of Calc's EOMONTH 
function.

The statement that the date MUST be in ISO format is not quite correct.

Also add link to updated wiki page.

Change-Id: I20158373f8a67ae90cd1bfccb9fbe1d7c011077f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115838
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 44bd3d8205dd..ab50f2ccc57e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 44bd3d8205dd9020b9725a03518cb1316d3062fa
+Subproject commit ab50f2ccc57ebe577cbdad4afa29b66317b87bcc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2021-05-20 Thread Steve Fanning (via logerrit)
 source/text/scalc/01/func_eomonth.xhp |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ab50f2ccc57ebe577cbdad4afa29b66317b87bcc
Author: Steve Fanning 
AuthorDate: Thu May 20 21:43:42 2021 +0200
Commit: Olivier Hallot 
CommitDate: Fri May 21 01:17:43 2021 +0200

Fix text in 2nd example given in help description of Calc's EOMONTH 
function.

The statement that the date MUST be in ISO format is not quite correct.

Also add link to updated wiki page.

Change-Id: I20158373f8a67ae90cd1bfccb9fbe1d7c011077f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115838
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/func_eomonth.xhp 
b/source/text/scalc/01/func_eomonth.xhp
index 186c4e948..74d3af592 100644
--- a/source/text/scalc/01/func_eomonth.xhp
+++ b/source/text/scalc/01/func_eomonth.xhp
@@ -40,8 +40,9 @@
 What is the 
last day of the month that falls 6 months after September 14 2001?
 
 =EOMONTH(DATE(2001;9;14);6) returns the serial number 
37346. Formatted as a date, this is 2002-03-31.
-=EOMONTH("2001-09-14";6) works as well. If the date is 
given as string, it has to be in ISO format.
+=EOMONTH("2001-09-14";6) works as well. If you specify the 
date directly, we recommend using the standard ISO 8601 format because this 
should be independent of your selected locale settings.
 
+https://wiki.documentfoundation.org/Documentation/Calc_Functions/EOMONTH;>EOMONTH
 wiki page  
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

2021-05-20 Thread Steve Fanning (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 235f570cdc9e57d32257b5c1e599eec24f89836f
Author: Steve Fanning 
AuthorDate: Fri May 21 01:15:09 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Fri May 21 01:15:09 2021 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 44bd3d8205dd9020b9725a03518cb1316d3062fa
  - Add example to help description for Calc's CLEAN function.

Change-Id: Iae7a1f0b8b84be33f5f54a9a7116c0c48670f917
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115833
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 774b852c14a4..44bd3d8205dd 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 774b852c14a4a8df49c9ad35e609d8060b9b46a1
+Subproject commit 44bd3d8205dd9020b9725a03518cb1316d3062fa
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: source/text

2021-05-20 Thread Steve Fanning (via logerrit)
 source/text/scalc/01/04060110.xhp |4 
 1 file changed, 4 insertions(+)

New commits:
commit 44bd3d8205dd9020b9725a03518cb1316d3062fa
Author: Steve Fanning 
AuthorDate: Wed May 19 22:21:04 2021 +0200
Commit: Olivier Hallot 
CommitDate: Fri May 21 01:15:09 2021 +0200

Add example to help description for Calc's CLEAN function.

Change-Id: Iae7a1f0b8b84be33f5f54a9a7116c0c48670f917
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115833
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060110.xhp 
b/source/text/scalc/01/04060110.xhp
index 59ded0137..3a4ab2306 100644
--- a/source/text/scalc/01/04060110.xhp
+++ b/source/text/scalc/01/04060110.xhp
@@ -163,6 +163,10 @@
 
 CLEAN("Text")
  
Text refers to the text from which to remove all non-printable 
characters.
+  
+
+=LEN(CLEAN(CHAR(7)  "LibreOffice Calc" 
 CHAR(8))) returns 16, showing that the CLEAN function removes the 
non-printable Unicode U+0007 ("BEL") and U+0008 ("BS") characters at the 
beginning and end of the string argument. CLEAN does not remove 
spaces.
+  
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: helpcontent2

2021-05-20 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e503761df294f7a33eeba99a15f03125be97906
Author: Rafael Lima 
AuthorDate: Fri May 21 01:12:12 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Fri May 21 01:12:12 2021 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 774b852c14a4a8df49c9ad35e609d8060b9b46a1
  - tdf#141929 Improve CONVERT help and move to a separate file

Updates the content of the CONVERT help page to better match the 
description in the wiki, focusing in unit measurement and prefix tables.

Also moves the CONVERT help page to a separate file and removes it from 
the original location 04060116.xhp.

Change-Id: I591ce3d2cd36e224daf5d00593418cba7832e574
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115209
Tested-by: Jenkins
Reviewed-by: Steve Fanning 
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 975230c5cd94..774b852c14a4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 975230c5cd9402e1da8ef50ce31a4682306bfbf8
+Subproject commit 774b852c14a4a8df49c9ad35e609d8060b9b46a1
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] help.git: AllLangHelp_scalc.mk source/text

2021-05-20 Thread Rafael Lima (via logerrit)
 AllLangHelp_scalc.mk  |1 
 source/text/scalc/01/04060116.xhp |  332 --
 source/text/scalc/01/ful_func.xhp |   68 -
 source/text/scalc/01/func_convert.xhp | 1741 ++
 4 files changed, 1792 insertions(+), 350 deletions(-)

New commits:
commit 774b852c14a4a8df49c9ad35e609d8060b9b46a1
Author: Rafael Lima 
AuthorDate: Sat May 8 15:56:59 2021 +0200
Commit: Olivier Hallot 
CommitDate: Fri May 21 01:12:12 2021 +0200

tdf#141929 Improve CONVERT help and move to a separate file

Updates the content of the CONVERT help page to better match the 
description in the wiki, focusing in unit measurement and prefix tables.

Also moves the CONVERT help page to a separate file and removes it from the 
original location 04060116.xhp.

Change-Id: I591ce3d2cd36e224daf5d00593418cba7832e574
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115209
Tested-by: Jenkins
Reviewed-by: Steve Fanning 
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 0535a0ca2..3cca39631 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -196,6 +196,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/func_countifs \
 helpcontent2/source/text/scalc/01/func_color \
 helpcontent2/source/text/scalc/01/func_concat \
+helpcontent2/source/text/scalc/01/func_convert \
 helpcontent2/source/text/scalc/01/func_date \
 helpcontent2/source/text/scalc/01/func_datedif \
 helpcontent2/source/text/scalc/01/func_datevalue \
diff --git a/source/text/scalc/01/04060116.xhp 
b/source/text/scalc/01/04060116.xhp
index 9d554aa81..06141e181 100644
--- a/source/text/scalc/01/04060116.xhp
+++ b/source/text/scalc/01/04060116.xhp
@@ -383,329 +383,17 @@
  
 =OCT2HEX(144;4) returns 0064.
   
-  
-CONVERT function
-
-
-CONVERT
- Converts a value from one 
unit of measure to the corresponding value in another unit of measure. 
Enter the units of measures directly as text in quotation marks or as a 
reference. If you enter the units of measure in cells, they must correspond 
exactly with the following list which is case sensitive: For example, in order 
to enter a lower case l (for liter) in a cell, enter the apostrophe ' 
immediately followed by l.
- 
-
-   
-  Property
-   
-   
-  Units
-   
-
-
-   
-  Weight
-   
-   
-   g, sg, lbm, u, ozm, stone, ton, 
grain, pweight, hweight, shweight, brton
-   
-
-
-   
-  Length
-   
-   
-   m, mi, Nmi, in, ft, yd, ang, Pica, ell, 
parsec, lightyear, survey_mi
-   
-
-
-   
-  Time
-   
-   
-   yr, day, hr, mn, sec, 
s
-   
-
-
-   
-  Pressure
-   
-   
-   Pa, atm, at, 
mmHg, Torr, psi
-   
-
-
-   
-  Force
-   
-   
-   N, dyn, dy, lbf, 
pond
-   
-
-
-   
-  Energy
-   
-   
-   J, e, c, 
cal, eV, ev, HPh, Wh, 
wh, flb, BTU, btu
-   
-
-
-   
-  Power
-   
-   
-   W, w, HP, PS
-   
-
-
-   
-  Field strength
-   
-   
-   T, ga
-   
-
-
-   
-  Temperature
-   
-   
-   C, F, K, kel, Reau, 
Rank
-   
-
-
-   
-  Volume
-   
-   
-   l, L, lt, tsp, tbs, 
oz, cup, pt, us_pt, qt, gal, m3, mi3, Nmi3, in3, ft3, yd3, ang3, 
Pica3, barrel, bushel, regton, Schooner, Middy, Glass
-   
-
-
-   
-  Area
-   
-   
-   m2, mi2, Nmi2, in2, ft2, yd2, 
ang2, Pica2, Morgen, ar, acre, ha
-   
-
-
-   
-  Speed
-   
-   
-   m/s, m/sec, m/h, mph, kn, 
admkn
-   
-
-
-   
-  Information
-   
-   
-   bit, byte
-   

[Libreoffice-bugs] [Bug 142389] Help for AutoFilter

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142389

--- Comment #2 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/975230c5cd9402e1da8ef50ce31a4682306bfbf8

tdf#142389 (part) Fix link to autofilter help

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2021-05-20 Thread Olivier Hallot (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ccbadd6c90c63b06534602eccdbb339f4f574217
Author: Olivier Hallot 
AuthorDate: Thu May 20 20:06:54 2021 -0300
Commit: Gerrit Code Review 
CommitDate: Fri May 21 01:06:54 2021 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 975230c5cd9402e1da8ef50ce31a4682306bfbf8
  - tdf#142389 (part) Fix link to autofilter help

Change-Id: I689ab1d93242a74da72f1792965399f74fbb2f5a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115885
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index bd3e4888b2b4..975230c5cd94 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit bd3e4888b2b47d022871218f210b290b7d046288
+Subproject commit 975230c5cd9402e1da8ef50ce31a4682306bfbf8
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 142389] Help for AutoFilter

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142389

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: source/text

2021-05-20 Thread Olivier Hallot (via logerrit)
 source/text/scalc/01/12040100.xhp |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 975230c5cd9402e1da8ef50ce31a4682306bfbf8
Author: Olivier Hallot 
AuthorDate: Thu May 20 14:29:24 2021 -0300
Commit: Olivier Hallot 
CommitDate: Fri May 21 01:06:54 2021 +0200

tdf#142389 (part) Fix link to autofilter help

Change-Id: I689ab1d93242a74da72f1792965399f74fbb2f5a
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115885
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/12040100.xhp 
b/source/text/scalc/01/12040100.xhp
index 81e11c3b4..94d48c48b 100644
--- a/source/text/scalc/01/12040100.xhp
+++ b/source/text/scalc/01/12040100.xhp
@@ -26,6 +26,8 @@
 
 
 
+
+
 AutoFilter
 Automatically filters the selected cell range, 
and creates one-row list boxes where you can choose the items that you want to 
display.
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sw/qa

2021-05-20 Thread Xisco Fauli (via logerrit)
 sw/qa/extras/uiwriter/data/tdf142157.odt |binary
 sw/qa/extras/uiwriter/uiwriter.cxx   |   19 +++
 2 files changed, 19 insertions(+)

New commits:
commit aa6e9cceddfb154c2207ab316cb7625655452953
Author: Xisco Fauli 
AuthorDate: Thu May 20 14:37:10 2021 +0200
Commit: Xisco Fauli 
CommitDate: Fri May 21 00:34:30 2021 +0200

tdf#142157: sw_uiwriter: Add unittest

Change-Id: I2dbc2f09d61220100fb616c28a8f2557c84f460f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115871
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/uiwriter/data/tdf142157.odt 
b/sw/qa/extras/uiwriter/data/tdf142157.odt
new file mode 100644
index ..072c86889335
Binary files /dev/null and b/sw/qa/extras/uiwriter/data/tdf142157.odt differ
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx 
b/sw/qa/extras/uiwriter/uiwriter.cxx
index e7d9e38153ab..8ef3de9d6a60 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -346,6 +346,7 @@ public:
 void testMsWordCompTrailingBlanks();
 void testCreateDocxAnnotation();
 void testTdf107976();
+void testTdf142157();
 void testTdf108524();
 void testRhbz1810732();
 void testTableInSection();
@@ -577,6 +578,7 @@ public:
 CPPUNIT_TEST(testMsWordCompTrailingBlanks);
 CPPUNIT_TEST(testCreateDocxAnnotation);
 CPPUNIT_TEST(testTdf107976);
+CPPUNIT_TEST(testTdf142157);
 CPPUNIT_TEST(testTdf108524);
 CPPUNIT_TEST(testRhbz1810732);
 CPPUNIT_TEST(testTableInSection);
@@ -6739,6 +6741,23 @@ void SwUiWriterTest::testRhbz1810732()
 }
 }
 
+void SwUiWriterTest::testTdf142157()
+{
+mxComponent = loadFromDesktop("private:factory/swriter", 
"com.sun.star.text.TextDocument");
+
+const OUString insertFileid = m_directories.getURLFromSrc(DATA_DIRECTORY) 
+ "tdf142157.odt";
+uno::Sequence 
aPropertyValues(comphelper::InitPropertySequence({ { "Name", 
uno::makeAny(insertFileid) } }));
+dispatchCommand(mxComponent, ".uno:InsertDoc", aPropertyValues);
+
+uno::Reference 
xTextSectionsSupplier(mxComponent, uno::UNO_QUERY);
+uno::Reference 
xSections(xTextSectionsSupplier->getTextSections(), uno::UNO_QUERY);
+
+// Without the fix in place, this test would have failed with
+// - Expected: 1
+// - Actual  : 0
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xSections->getCount());
+}
+
 void SwUiWriterTest::testTdf108524()
 {
 createDoc("tdf108524.odt");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 142157] "Insert text from file" removes imported section if section lower border is at the end of imported ODT.

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142157

--- Comment #5 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/aa6e9cceddfb154c2207ab316cb7625655452953

tdf#142157: sw_uiwriter: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 132042] TEMPLATE MANAGER: Errors when deleting a category in templates

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132042

--- Comment #10 from VertD  ---
looks good to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142395] FILEOPEN CSV: Space trailing values imported as garbage

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142395

Mike Kaganski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #8 from Mike Kaganski  ---
https://gerrit.libreoffice.org/c/core/+/115839

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142376] Links from table of content in generated PDF not accessible for screen reader

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142376

--- Comment #1 from Mikael  ---
Hello,

We start to suspect there may be an issue with the Orca screen reader
and possibly not with the generated document.
We will get back to you when we have done some more experimenting to verify.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] (Vanilla MacOS release only) Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

--- Comment #6 from V Stuart Foote  ---
Is there a Tools -> Options -> Personalization 'Preinstalled themes' radio
button selected?  If so it is a dupe of bug 131023

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133311] [HiPDI] Icon bar not filled when using Theme from Personalization option - background should always span across full width of top icon bar

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #12 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 131023 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 125823] [META] Personalization (LibreOffice Themes) bugs and Improvements

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125823
Bug 125823 depends on bug 133311, which changed state.

Bug 133311 Summary: [HiPDI] Icon bar not filled when using Theme from 
Personalization option - background should always span across full width of top 
icon bar
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90796
Bug 90796 depends on bug 133311, which changed state.

Bug 133311 Summary: [HiPDI] Icon bar not filled when using Theme from 
Personalization option - background should always span across full width of top 
icon bar
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131023] Preinstalled theme graphics not extending full width of UI elements

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131023

V Stuart Foote  changed:

   What|Removed |Added

 CC||l...@disr.it

--- Comment #7 from V Stuart Foote  ---
*** Bug 133311 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133311] [HiPDI] Icon bar not filled when using Theme from Personalization option - background should always span across full width of top icon bar

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

--- Comment #11 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #10)

that was on Version: 7.1.3.2 (x64) / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133311] [HiPDI] Icon bar not filled when using Theme from Personalization option - background should always span across full width of top icon bar

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

--- Comment #10 from V Stuart Foote  ---
It affects Windows builds as well, the PNG theme graphics max out at 3000px
filled from right side to left. Initial controls of the top bar do not have a
background.

Testing on dual headed 1920 x 1200px so desktop is 3840px. Dragging LO (any
module or startcenter) out past 3000px width exhibits issue with a Tools ->
Options -> Personalization 'Preinstalled Themes' selected active.

To me this is a dupe of bug 131023, which is marked Linux--difference is the
Linux builds seem to fill from the left to right, while Windows and macOS fill
from right to left.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133311] [HiPDI] Icon bar not filled when using Theme from Personalization option - background should always span across full width of top icon bar

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

V Stuart Foote  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 100584] If original sheet direction is RTL, keep new added sheets as RTL not LTR

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100584

--- Comment #7 from Hossein  ---
(In reply to Heiko Tietze from comment #6)
> Hossein, what do you think? Making the sheet direction depending on first
> sheet sounds weird to me since first (or initial) sheet settings can change
> later. My take is WF and let Tools > Options > Locale Settings control
> LTR/RTL.

(In reply to Heiko Tietze from comment #6)
> Hossein, what do you think? Making the sheet direction depending on first
> sheet sounds weird to me since first (or initial) sheet settings can change
> later. My take is WF and let Tools > Options > Locale Settings control
> LTR/RTL.

I think it is better to consider instead the UI direction (e.g. using
SAL_RTL_ENABLED=1 or using RTL language for the UI).

This is also the default behavior in MS Excel. For example, if you use Persian
or Arabic for the UI language, the spreadsheet default direction would be RTL
unless you change the default direction in the options.

https://answers.microsoft.com/en-us/msoffice/forum/msoffice_excel-mso_win10-mso_o365b/excel-direction-and-language/0b3913a8-872a-44bb-ba81-333fbd3aaabc

This behavior becomes easier for the user, with the help of the visible button
in the toolbar which enables the user to see the sheet direction and change it
easily. I couldn't find a comparable button in LibreOffice.

There are rare situations where a user uses different languages for the
creation of several mixed RTL/LTR sheet spreadsheets, and in fact these use
cases can be handled with the help of a visible toolbar button, as described
before.

And at last, a dedicated option for the sheet direction in the settings can
help users who work with the sheet direction other than the UI language default
direction. This is specially helpful for the languages with incomplete LO UI
translation.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 100584] If original sheet direction is RTL, keep new added sheets as RTL not LTR

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=100584

--- Comment #7 from Hossein  ---
(In reply to Heiko Tietze from comment #6)
> Hossein, what do you think? Making the sheet direction depending on first
> sheet sounds weird to me since first (or initial) sheet settings can change
> later. My take is WF and let Tools > Options > Locale Settings control
> LTR/RTL.

(In reply to Heiko Tietze from comment #6)
> Hossein, what do you think? Making the sheet direction depending on first
> sheet sounds weird to me since first (or initial) sheet settings can change
> later. My take is WF and let Tools > Options > Locale Settings control
> LTR/RTL.

I think it is better to consider instead the UI direction (e.g. using
SAL_RTL_ENABLED=1 or using RTL language for the UI).

This is also the default behavior in MS Excel. For example, if you use Persian
or Arabic for the UI language, the spreadsheet default direction would be RTL
unless you change the default direction in the options.

https://answers.microsoft.com/en-us/msoffice/forum/msoffice_excel-mso_win10-mso_o365b/excel-direction-and-language/0b3913a8-872a-44bb-ba81-333fbd3aaabc

This behavior becomes easier for the user, with the help of the visible button
in the toolbar which enables the user to see the sheet direction and change it
easily. I couldn't find a comparable button in LibreOffice.

There are rare situations where a user uses different languages for the
creation of several mixed RTL/LTR sheet spreadsheets, and in fact these use
cases can be handled with the help of a visible toolbar button, as described
before.

And at last, a dedicated option for the sheet direction in the settings can
help users who work with the sheet direction other than the UI language default
direction. This is specially helpful for the languages with incomplete LO UI
translation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: sw/qa sw/source

2021-05-20 Thread Miklos Vajna (via logerrit)
 sw/qa/core/text/data/line-height.fodt |   32 
 sw/qa/core/text/text.cxx  |   16 
 sw/source/core/inc/txtfrm.hxx |2 +-
 sw/source/core/text/frmcrsr.cxx   |2 +-
 sw/source/core/text/frmform.cxx   |8 
 sw/source/core/text/frmpaint.cxx  |4 ++--
 sw/source/core/text/inftxt.cxx|4 ++--
 sw/source/core/text/itrcrsr.cxx   |   10 +-
 sw/source/core/text/itrform2.cxx  |   26 +-
 sw/source/core/text/itrpaint.cxx  |   12 ++--
 sw/source/core/text/itrtxt.cxx|   10 +-
 sw/source/core/text/itrtxt.hxx|8 
 sw/source/core/text/porfld.cxx|8 
 sw/source/core/text/porfly.cxx|2 +-
 sw/source/core/text/porlay.cxx|8 
 sw/source/core/text/porlay.hxx|   10 +-
 sw/source/core/text/porlin.hxx|8 
 sw/source/core/text/pormulti.cxx  |   10 +-
 sw/source/core/text/porrst.cxx|2 +-
 sw/source/core/text/possiz.hxx|   30 +++---
 sw/source/core/text/txtdrop.cxx   |   10 +-
 sw/source/core/text/txtfrm.cxx|4 ++--
 22 files changed, 137 insertions(+), 89 deletions(-)

New commits:
commit 301278b656e76b6f42af5cf8a6f5c6c02acfffeb
Author: Miklos Vajna 
AuthorDate: Thu May 20 18:02:12 2021 +0200
Commit: Miklos Vajna 
CommitDate: Thu May 20 22:38:03 2021 +0200

sw: allow the height of a line to be larger than 65536 twips

The line height can be quite large if the line contains an as-char
image.

Found by temporarily changing static_cast() in sw/ to a
template function to make these conversions implicit (excluding cases
where the input and output types can't convert implicitly), then asking
-fsanitize=implicit-unsigned-integer-truncation
-fsanitize=implicit-signed-integer-truncation to flag the problematic
conversions.

The first hit was in SwFlyCntPortion::SetBase() (that's where 67408
turns into 1872), then the same pattern at many other places.

Change-Id: Ie12f490ed8dd5c531f11506c97598ce4f7610e2e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115873
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/core/text/data/line-height.fodt 
b/sw/qa/core/text/data/line-height.fodt
new file mode 100644
index ..d784ec241bed
--- /dev/null
+++ b/sw/qa/core/text/data/line-height.fodt
@@ -0,0 +1,32 @@
+
+
+  
+
+
+  
+
+  
+  
+
+  
+  
+
+  iVBORw0KGgoNSUhEUgAAAEBACAQAYLlVBGdBTUEAALGPC/xhBQFz
+   UkdCAK7OHOkgY0hSTQAAeiYAAICEAAD6gOgAAHUwAADqYAAAOpgAABdwnLpRPAAA
+   AAJiS0dEAACqjSMyCW9GRnMGAAAMc1XTCXBIWXMAAA3XAAAN1wFCKJt4
+   CXZwQWcAAABMQACdMTgbAAABzUlEQVRo3u3ZPU/CQBjA8X+Jxs3ESUDj4iK+LA5+
+   BBfjqBE1cXB2MlFAEqMgxvhNNL4sLsK3UPQL6ObkoAETz+FKW2mxCPRYnucWUu76/OC59C49
+   cGOCKqrD9kHRc6ddPv7oW2WCwMh0nF63Myz7Tm8hPTNu0pgHMER3scepTbgK6enJNND83RLn
+   /878yRaPmgBZFDuMsNLeWB9gmFQHP77MIg9gsYciR50NFKvtjIy10yk84pSZA7DYpwR8scmF
+   QQCMuoQMpzbh0iAARrlnVn90CWHTsZcAiHPPdINQAuqsc2MQAAnKDUKWEhZ10twaBEDSJWQo
+   YlFj7S9CzwEegkXWIbQsRAQASFJhpplwbRAACS+hANRJBxMiAkDcJeQ4sQkBhYgMoJ+Ozlwo
+   2YQ7AJ6CRxyiUGnVy3hVKb0Af9v7hUG2Wy9TEQCUelFTDULB2S+YKYGOMcpM6UIccOQnRA6A
+   cSp6ibfI+wkGADBGpTEd8xz1AaAfTQ7huA8AvUw5hVjuA0D/C5OaMN8XACRZ8F0zCggKAQhA
+   AAIQgAAEIAABCEAAAhCAAAQgAAH4zg3feY4w3Xs44M5+oW0qvCWoGcvaIlM3x/f/ab+O738A
+   hOCNQr34oD4ldEVYdGNyZWF0ZS1kYXRlADIwMTAtMTItMjBUMTc6MDg6MzYrMDE6MDB6
+   5RscJXRFWHRtb2RpZnktZGF0ZQAyMDEwLTEyLTIwVDE3OjA4OjM3KzAxOjAwgyNmnAAA
+   AABJRU5ErkJggg==
+  
+
+  
+
diff --git a/sw/qa/core/text/text.cxx b/sw/qa/core/text/text.cxx
index 4db880e687f4..d38b6a3e62cc 100644
--- a/sw/qa/core/text/text.cxx
+++ b/sw/qa/core/text/text.cxx
@@ -135,6 +135,22 @@ CPPUNIT_TEST_FIXTURE(SwCoreTextTest, 
testTabOverMarginSection)
 CPPUNIT_ASSERT_LESS(static_cast(5000), nWidth);
 }
 
+CPPUNIT_TEST_FIXTURE(SwCoreTextTest, testLineHeight)
+{
+// Given a document with an as-char image, height in twips not fitting 
into sal_uInt16:
+createSwDoc(DATA_DIRECTORY, "line-height.fodt");
+
+// When laying out that document:
+xmlDocUniquePtr pXmlDoc = parseLayoutDump();
+
+// Then make sure its top is the top of the page:
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 284
+// - Actual  : -65252
+// due to various unsigned integer truncations.
+assertXPath(pXmlDoc, "//fly/infos/bounds", "top", 
OUString::number(DOCUMENTBORDER));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/txtfrm.hxx b/sw/source/core/inc/txtfrm.hxx
index abef52f448aa..0a2f4fbbd2bc 100644
--- a/sw/source/core/inc/txtfrm.hxx
+++ 

[Libreoffice-bugs] [Bug 142325] Error read rtf created Gnostice eDocEngine V5.0.0.548

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142325

--- Comment #4 from Julien Nabet  ---
Created attachment 172212
  --> https://bugs.documentfoundation.org/attachment.cgi?id=172212=edit
new rtf

I noticed that after unicode character, there's \'3

For example in the first line, you got:
author Miloslava H\u345\'3?

If you remove all the "\'3" so we'll have here:
author Miloslava H\u345?

It'll work.

I attached the file with this pattern removed.

>From https://en.wikipedia.org/wiki/Rich_Text_Format, it tells:
"For a Unicode escape, the control word \u is used, followed by a 16-bit signed
integer which corresponds to the Unicode UTF-16 code unit number. For the
benefit of programs without Unicode support, this must be followed by the
nearest representation of this character in the specified code page. For
example, \u1576? would give the Arabic letter bāʼ ب, but indicates that older
programs which do not support Unicode should render it as a question mark
instead. "

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 129674] Add "Goto sheet" dialog to Calc

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129674

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #8 from Regina Henschel  ---
We have already .uno::SelectTables. In older versions is was integrated in the
'Sheet' menu, nowadays you need to add it. It is command "Select Sheets...". It
opens a dialog with a list of all sheets. It is up to the user to assign a
shortcut to this dialog.

Unfortunately the dialog has no other way to select a sheet then click on its
name in the list or -for keyboard users- to navigate in the list with up and
down arrow. I think additional ways to select a list item would be good. This
might be a search field. Only the additional way needs to improve
accessibility.

And we have the list of sheets in the Navigator and the Navigator can be uses
separate from the side bar, so is parallel available. But here too a method is
missing to comfortable select a sheet, in case there is a huge number of
sheets.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 30731] Cursor behaviour with Graphite fonts

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=30731

--- Comment #22 from RGB  ---
Problem still present on 7.1.3.2. Comment 17 is still valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/commonfuzzer.mk

2021-05-20 Thread Caolán McNamara (via logerrit)
 vcl/commonfuzzer.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 6cc4750f36fb505e1d7b8d1406f170807fa55644
Author: Caolán McNamara 
AuthorDate: Thu May 20 19:42:40 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu May 20 21:08:33 2021 +0200

ofz: fix build

Change-Id: I2875536139397070f7e99f1f621d8212687dee47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115886
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/commonfuzzer.mk b/vcl/commonfuzzer.mk
index 3e0891ac3b0f..6541d9ec7360 100644
--- a/vcl/commonfuzzer.mk
+++ b/vcl/commonfuzzer.mk
@@ -146,6 +146,7 @@ fuzzer_calc_libraries = \
 scfilt \
 scd \
 vbaevents \
+vbahelper \
 vbaobj \
 sc \
 for \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 138432] EDITING: Regression in handling of the group separator in formula context

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138432

--- Comment #5 from Jouni Kosonen  ---
Is this possibly being worked on? The code tree has changed enough between
7.0.5.2 and 7.1.3.2 that the patch I've used locally to revert the breaking
change in 30d3ae0268290 no longer applies to sc/source/core/tool/compiler.cxx
after all.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: desktop/source extensions/source fpicker/source sw/source uui/source

2021-05-20 Thread Caolán McNamara (via logerrit)
 desktop/source/deployment/gui/dp_gui_dialog2.cxx |8 +++---
 desktop/source/deployment/gui/dp_gui_dialog2.hxx |2 -
 extensions/source/abpilot/abpfinalpage.cxx   |8 +++---
 extensions/source/abpilot/abpfinalpage.hxx   |4 +--
 extensions/source/scanner/sanedlg.cxx|   29 ++-
 extensions/source/scanner/sanedlg.hxx|1 
 fpicker/source/office/iodlg.cxx  |   21 +++-
 fpicker/source/office/iodlg.hxx  |4 +--
 sw/source/ui/table/convert.cxx   |8 +++---
 sw/source/uibase/inc/convert.hxx |4 +--
 uui/source/logindlg.cxx  |4 +--
 uui/source/logindlg.hxx  |2 -
 uui/source/secmacrowarnings.cxx  |4 +--
 uui/source/secmacrowarnings.hxx  |2 -
 14 files changed, 54 insertions(+), 47 deletions(-)

New commits:
commit bb166403ef1026e3665b2d60810c71955d7402c0
Author: Caolán McNamara 
AuthorDate: Thu May 20 15:30:35 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu May 20 20:27:38 2021 +0200

use toggle instead of click for CheckButton

Change-Id: I7196581a8b7c307d531f6995e1c24db746afdb26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115883
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx 
b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index 730854127ac2..00d2603e529d 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -448,9 +448,9 @@ ExtMgrDialog::ExtMgrDialog(weld::Window *pParent, 
TheExtensionManager *pManager)
 
 m_xCancelBtn->connect_clicked( LINK( this, ExtMgrDialog, HandleCancelBtn ) 
);
 
-m_xBundledCbx->connect_clicked( LINK( this, ExtMgrDialog, HandleExtTypeCbx 
) );
-m_xSharedCbx->connect_clicked( LINK( this, ExtMgrDialog, HandleExtTypeCbx 
) );
-m_xUserCbx->connect_clicked( LINK( this, ExtMgrDialog, HandleExtTypeCbx ) 
);
+m_xBundledCbx->connect_toggled( LINK( this, ExtMgrDialog, HandleExtTypeCbx 
) );
+m_xSharedCbx->connect_toggled( LINK( this, ExtMgrDialog, HandleExtTypeCbx 
) );
+m_xUserCbx->connect_toggled( LINK( this, ExtMgrDialog, HandleExtTypeCbx ) 
);
 
 m_xBundledCbx->set_active(true);
 m_xSharedCbx->set_active(true);
@@ -905,7 +905,7 @@ IMPL_LINK_NOARG(ExtMgrDialog, HandleEnableBtn, 
weld::Button&, void)
 }
 }
 
-IMPL_LINK_NOARG(ExtMgrDialog, HandleExtTypeCbx, weld::Button&, void)
+IMPL_LINK_NOARG(ExtMgrDialog, HandleExtTypeCbx, weld::ToggleButton&, void)
 {
 // re-creates the list of packages with addEntry selecting the packages
 prepareChecking();
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.hxx 
b/desktop/source/deployment/gui/dp_gui_dialog2.hxx
index 40faf4548313..424ad607f7fa 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.hxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.hxx
@@ -132,7 +132,7 @@ class ExtMgrDialog : public weld::GenericDialogController
 DECL_LINK( HandleUpdateBtn, weld::Button&, void );
 DECL_LINK( HandleCancelBtn, weld::Button&, void );
 DECL_LINK( HandleCloseBtn, weld::Button&, void );
-DECL_LINK( HandleExtTypeCbx, weld::Button&, void );
+DECL_LINK( HandleExtTypeCbx, weld::ToggleButton&, void );
 DECL_LINK( TimeOutHdl, Timer *, void );
 DECL_LINK( startProgress, void *, void );
 
diff --git a/extensions/source/abpilot/abpfinalpage.cxx 
b/extensions/source/abpilot/abpfinalpage.cxx
index 802b0d853b52..609918899e0b 100644
--- a/extensions/source/abpilot/abpfinalpage.cxx
+++ b/extensions/source/abpilot/abpfinalpage.cxx
@@ -61,9 +61,9 @@ namespace abp
 
 m_xName->connect_changed( LINK(this, FinalPage, OnEntryNameModified) );
 m_xLocation->connect_changed( LINK(this, FinalPage, 
OnComboNameModified) );
-m_xRegisterName->connect_clicked( LINK( this, FinalPage, OnRegister ) 
);
+m_xRegisterName->connect_toggled( LINK( this, FinalPage, OnRegister ) 
);
 m_xRegisterName->set_active(true);
-m_xEmbed->connect_clicked( LINK( this, FinalPage, OnEmbed ) );
+m_xEmbed->connect_toggled( LINK( this, FinalPage, OnEmbed ) );
 m_xEmbed->set_active(true);
 }
 
@@ -204,7 +204,7 @@ namespace abp
 implCheckName();
 }
 
-IMPL_LINK_NOARG(FinalPage, OnRegister, weld::Button&, void)
+IMPL_LINK_NOARG(FinalPage, OnRegister, weld::ToggleButton&, void)
 {
 bool bEnable = m_xRegisterName->get_active();
 m_xNameLabel->set_sensitive(bEnable);
@@ -212,7 +212,7 @@ namespace abp
 implCheckName();
 }
 
-IMPL_LINK_NOARG(FinalPage, OnEmbed, weld::Button&, void)
+IMPL_LINK_NOARG(FinalPage, OnEmbed, weld::ToggleButton&, void)
 {
 bool bEmbed = m_xEmbed->get_active();
 m_xLocationLabel->set_sensitive(!bEmbed);
diff --git 

Re: Introducing myself and question

2021-05-20 Thread Kevin Dombeu mboudi
Bonsoir Mr,
J'espère que vous allez bien.
Je me permet de vous écrire car j'ai postuler pour la bourse Tek-up
university et en effectuant des recherches sur cette université, je suis
tombé sur votre nom. J'aimerais svp que vous partagez votre expérience avec
moi afin que je sache à quoi m'attendre.

J'ai eu des difficultés à trouver un moyen de vous joindre si ce n'est
celui-ci.

Merci d'avance
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 121715] FILEOPEN XLSX First page header changes to default header

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=121715

Dániel Arató (NISZ)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |arato.dan...@nisz.hu
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] (Vanilla MacOS release only) Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

--- Comment #5 from Julien Nabet  ---
(In reply to V Stuart Foote from comment #3)
> Seems a dupe of bug 133311 for rendering on displays wider than 3000px

I'm not sure since it seems specific to Vanilla here.


Just some time ago when people talk about LO community release, I thought it
was always from TDF, now I know it might also be from LO Vanilla Community
release.

What a mess Apple brought here by using in the name of their release:
- "Vanilla" => it normally means an unpatched release from official sources
- "Community" => this word should apply only to community contributing to TDF
version, not "Apple Community" or something

What just a plain Apple LibreOffice release. It'd be clear for everyone.

Just my personal opinion but I consider this like kindda of deception from
AppleStore.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] (Vanilla MacOS release only) Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

Julien Nabet  changed:

   What|Removed |Added

Summary|[macOS] Tabbed UI broken on |(Vanilla MacOS release
   |very large 4k screen (21:9  |only) Tabbed UI broken on
   |aspect ratio. 3440x1440)|very large 4k screen (21:9
   ||aspect ratio. 3440x1440)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] [macOS] Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

--- Comment #4 from Julien Nabet  ---
(In reply to Bertrand Presles from comment #2)
> Indeed with 7.1.3 x86_64 release from
> https://www.libreoffice.org/download/download/ it works.

Great!

> 
> As I mentionned in the Hardware settings, I'm using an Apple Silicon mac
> (Macbook Air). And I can't find any arm64/Apple Silicon/universal build on
> www.libreoffice.org.
There's no Arm64 Mac OS LO release yet and don't know if there'll be one soon.

> 
> But I tried to launch the Vanilla (AppStore) version using Rosetta (x86_64
> translator) to see if it's related to the ARM64 build specifically. And I
> still reproduce it with Rosetta.
...
Ok seems specific to Vanilla (AppStore) release then

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: Branch 'feature/wasm' - config_host.mk.in cui/Library_cui.mk cui/source editeng/source external/hunspell external/hyphen external/mythes include/editeng lingucomponent/

2021-05-20 Thread Armin Le Grand (Allotropia) (via logerrit)
 Repository.mk   |   17 +++--
 RepositoryExternal.mk   |2 ++
 config_host.mk.in   |1 +
 cui/Library_cui.mk  |7 ++-
 cui/source/factory/dlgfact.cxx  |4 
 cui/source/factory/dlgfact.hxx  |4 
 editeng/source/misc/splwrap.cxx |4 
 external/hunspell/StaticLibrary_hunspell.mk |7 ++-
 external/hyphen/ExternalProject_hyphen.mk   |2 ++
 external/mythes/ExternalProject_mythes.mk   |2 ++
 include/editeng/edtdlg.hxx  |2 ++
 lingucomponent/Module_lingucomponent.mk |7 ++-
 postprocess/Rdb_services.mk |   11 ---
 solenv/bin/native-code.py   |   16 
 solenv/gbuild/gbuild.mk |1 +
 15 files changed, 67 insertions(+), 20 deletions(-)

New commits:
commit ec9e2c81b4ec6a1efce632a7fbc47683219582bf
Author: Armin Le Grand (Allotropia) 
AuthorDate: Thu May 20 18:56:25 2021 +0200
Commit: Armin Le Grand (Allotropia) 
CommitDate: Thu May 20 18:56:25 2021 +0200

Wasm remove hunspell/hyphen optionally

Change-Id: I104264202e147f7a037647b84f07647ae28f3e60

diff --git a/Repository.mk b/Repository.mk
index 700d61a2e55a..613fe92f1892 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -365,6 +365,17 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
 ))
 endif
 
+ifneq ($(ENABLE_WASM_STRIP_HUNSPELL),TRUE)
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
+   hyphen \
+   lnth \
+   spell \
+   $(if $(filter iOS MACOSX,$(OS)), \
+   MacOSXSpell \
+   ) \
+))
+endif
+
 $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
$(call gb_Helper_optional,AVMEDIA,avmedia) \
$(if $(filter MACOSX,$(OS)),\
@@ -409,7 +420,6 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
fwk \
i18npool \
i18nsearch \
-   hyphen \
 icg \
$(if $(ENABLE_JAVA),jdbc) \
$(if $(ENABLE_LDAP),ldapbe2) \
@@ -417,7 +427,6 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
localebe1 \
log \
lng \
-   lnth \
$(if $(filter $(OS),MACOSX),macbe1) \
$(if $(MERGELIBS),merged) \
migrationoo2 \
@@ -448,7 +457,6 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
sfx \
slideshow \
sot \
-   spell \
$(if $(or $(DISABLE_GUI),$(ENABLE_WASM_STRIP_SPLASH)),,spl) \
storagefd \
$(call gb_Helper_optional,SCRIPTING,stringresource) \
@@ -499,9 +507,6 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \
) \
fps_aqua \
) \
-   $(if $(filter iOS MACOSX,$(OS)), \
-   MacOSXSpell \
-   ) \
 ))
 
 $(eval $(call gb_Helper_register_plugins_for_install,OOOLIBS,ooo, \
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index c7c530294aa9..7fe8b624d4ef 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -549,6 +549,7 @@ endef
 gb_ExternalProject__use_hunspell :=
 
 else # !SYSTEM_HUNSPELL
+ifneq ($(ENABLE_WASM_STRIP_HUNSPELL),TRUE)
 
 define gb_LinkTarget__use_hunspell
 $(call gb_LinkTarget_add_defs,$(1),\
@@ -576,6 +577,7 @@ $(call 
gb_ExternalProject_use_external_project,$(1),hunspell)
 
 endef
 
+endif # ENABLE_WASM_STRIP_EXTRA
 endif # SYSTEM_HUNSPELL
 
 
diff --git a/config_host.mk.in b/config_host.mk.in
index f723a6559a1e..b7075e473c60 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -215,6 +215,7 @@ export ENABLE_WASM_STRIP_UCPHELP=@ENABLE_WASM_STRIP@
 export ENABLE_WASM_STRIP_EPUB=@ENABLE_WASM_STRIP@
 export ENABLE_WASM_STRIP_LOCALES=@ENABLE_WASM_STRIP@
 export ENABLE_WASM_STRIP_GUESSLANG=@ENABLE_WASM_STRIP@
+export ENABLE_WASM_STRIP_HUNSPELL=@ENABLE_WASM_STRIP@
 export ENABLE_WERROR=@ENABLE_WERROR@
 export ENDIANNESS=@ENDIANNESS@
 export EPM=@EPM@
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 075085e659e4..dda524c97c41 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -99,6 +99,12 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 ))
 endif
 
+ifneq ($(ENABLE_WASM_STRIP_EXTRA),TRUE)
+$(eval $(call gb_Library_add_exception_objects,cui,\
+cui/source/dialogs/hyphen \
+))
+endif
+
 $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/customize/acccfg \
 cui/source/customize/cfg \
@@ -132,7 +138,6 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/dialogs/hlmailtp \
 cui/source/dialogs/hlmarkwn \
 cui/source/dialogs/hltpbase \
-cui/source/dialogs/hyphen \
 cui/source/dialogs/iconcdlg \
 cui/source/dialogs/insdlg \
 cui/source/dialogs/insrc \
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 4b3fa290fbeb..7c1dce6e2e35 

[Libreoffice-bugs] [Bug 142390] calc 7.2.0.0.a0+ >2021-05-19, no mouse cursor in cell area

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142390

--- Comment #9 from Sarabjot Singh  ---
For the time being, here's a temporary workaround to make the cursor visible

Open "sc/source/ui/drawfunc/fudraw.cxx "
In line 62
Replace (PointerStyle::FatCross) with (PointerStyle::Arrow)
This will show the arrow cursor majority of times, except for a few situations
of mouse clicks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90796

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||131023


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=131023
[Bug 131023] Preinstalled theme graphics not extending full width of UI
elements
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131023] Preinstalled theme graphics not extending full width of UI elements

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131023

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||90796


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 131023] Preinstalled theme graphics not extending full width of UI elements

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131023

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3311

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133311] [HiPDI] Icon bar not filled when using Theme from Personalization option - background should always span across full width of top icon bar

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||1023

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=90796

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||142400


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142400
[Bug 142400] [macOS] Tabbed UI broken on very large 4k screen (21:9 aspect
ratio. 3440x1440)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] [macOS] Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||90796


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142390] calc 7.2.0.0.a0+ >2021-05-19, no mouse cursor in cell area

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142390

--- Comment #8 from Sarabjot Singh  ---
(In reply to Xisco Faulí from comment #6)
> I can't reproduce it in ... OS: Linux 5.7;
Its because the bug is only on windows. All other OS are okay.
I couldn't check this on windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] [macOS] Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||3311
 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0
 CC||vstuart.fo...@utsa.edu

--- Comment #3 from V Stuart Foote  ---
Seems a dupe of bug 133311 for rendering on displays wider than 3000px

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 133311] [HiPDI] Icon bar not filled when using Theme from Personalization option - background should always span across full width of top icon bar

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133311

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2400

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 137418] DRAW - ODG fails to save after switching sheet and editing selected sheet

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137418

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #3 from Buovjaga  ---
Alex: regarding confidentiality, could you try unzipping the ODG, replacing the
images with some dummy ones and then re-zipping the thing again? Hopefully the
saving failure would be preserved in the sanitised one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142390] calc 7.2.0.0.a0+ >2021-05-19, no mouse cursor in cell area

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142390

--- Comment #7 from Sarabjot Singh  ---
Could anyone confirm 2 things on windows? I cannot test this on windows.

1. Select the clone formatting tool in calc and report if you can see the paint
bucket cursor.
Press escape while still in copy formatting mode and cursor over
spreadsheet(cell area) and report if and what cursor you see.

2. Go to "vcl/win/src".
Remove "fatcross.cur".
In the same directory, copy and paste (duplicate) any cursor (that is visible
in its normal use case, eg, "fill.cur" used in above point).Rename it to
"fatcross.cur".
Build.
Report what you see.
(Not to forget, do this in a new branch)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] help.git: source/text

2021-05-20 Thread Rafael Lima (via logerrit)
 source/text/sbasic/shared/0302.xhp |   25 +++--
 source/text/sbasic/shared/03020401.xhp |   32 
 source/text/sbasic/shared/03020402.xhp |   17 +++--
 source/text/sbasic/shared/03020403.xhp |   27 ---
 4 files changed, 62 insertions(+), 39 deletions(-)

New commits:
commit bd3e4888b2b47d022871218f210b290b7d046288
Author: Rafael Lima 
AuthorDate: Thu May 13 01:00:26 2021 +0200
Commit: Alain Romedenne 
CommitDate: Thu May 20 18:24:15 2021 +0200

Related tdf#128784 X-ref ChDir, ChDrive and CurDir with SF_FileSystem

The Basic functions ChDir, ChDrive and CurDir are DOS-specific and have 
limited functionality.

Hence, it's important to introduce the FileSystem service (from 
ScriptForge) for users that wish to write scripts that need to handle folders 
and files.

Change-Id: I33e24669083887b540cf44711ec5114e6ae5c521
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115513
Tested-by: Jenkins
Reviewed-by: Alain Romedenne 

diff --git a/source/text/sbasic/shared/0302.xhp 
b/source/text/sbasic/shared/0302.xhp
index 38336c7fa..e036d774f 100644
--- a/source/text/sbasic/shared/0302.xhp
+++ b/source/text/sbasic/shared/0302.xhp
@@ -18,25 +18,30 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  -->
-   
+
 
 
-
-File I/O Functions
-/text/sbasic/shared/0302.xhp
-
-
-Sun Microsystems, Inc.
-
+  
+File I/O Functions
+/text/sbasic/shared/0302.xhp
+  
+  
+Sun Microsystems, Inc.
+  
 
 
 
-File I/O 
Functions
-Use File I/O 
functions to create and manage user-defined (data) files.
+  File I/O 
Functions
+  Use File I/O 
functions to create and manage user-defined (data) files.
 
 You can use 
these functions to support the creation of "relative" files, so that you can 
save and reload certain records by specifying their record number. File I/O 
functions can also help you manage your files by providing you with information 
such as file size, current path settings, or the creation date of a file or a 
directory.
+
 
 
 
+
+  
+  
+
 
 
diff --git a/source/text/sbasic/shared/03020401.xhp 
b/source/text/sbasic/shared/03020401.xhp
index 220fb4d8d..42f721d4d 100644
--- a/source/text/sbasic/shared/03020401.xhp
+++ b/source/text/sbasic/shared/03020401.xhp
@@ -37,7 +37,11 @@
 
 
 
-Some DOS-specific file 
and directory functions are no longer provided in %PRODUCTNAME, or their 
function is only limited. For example, support for the 
ChDir, ChDrive and 
CurDir functions is not provided. Some DOS-specific 
properties are no longer used in functions that expect file properties as 
parameters (for example, to differentiate from concealed files and system 
files). This ensures the greatest possible level of platform independence for 
%PRODUCTNAME. Therefore this feature is subject to removal in a future 
release.
+  Some DOS-specific file 
and directory functions are no longer provided in %PRODUCTNAME, or their 
function is only limited. For example, support for the 
ChDir, ChDrive and 
CurDir functions is not provided. Some DOS-specific 
properties are no longer used in functions that expect file properties as 
parameters (for example, to differentiate from concealed files and system 
files). This ensures the greatest possible level of platform independence for 
%PRODUCTNAME. Therefore this feature is subject to removal in a future 
release.
+
+
+
+  The ScriptForge library in %PRODUCTNAME 7.1 introduces the 
FileSystem service with methods to handle 
files and folders in user scripts.
 
 
 
@@ -51,19 +55,23 @@
 
 
 
-  
+
 
 
-Sub 
ExampleChDir
-Dim sDir1 As 
String , sDir2 As String
-sDir1 = 
"c:\Test"
-sDir2 = 
"d:\Private"
-ChDir( 
sDir1 )
-MsgBox 
CurDir
-ChDir( 
sDir2 )
-MsgBox 
CurDir
-End 
Sub
+  Sub 
ExampleChDir
+  Dim 
sDir1 As String, sDir2 As String
+  sDir1 
= "C:\Test"
+  sDir2 
= "D:\Private"
+  ChDir( 
sDir1 )
+  MsgBox 
CurDir
+  ChDir( 
sDir2 )
+  MsgBox 
CurDir
+  End 
Sub
 
-
 
+
+  
+  
+
+
 
diff --git a/source/text/sbasic/shared/03020402.xhp 
b/source/text/sbasic/shared/03020402.xhp
index 59f89e055..780f9e204 100644
--- a/source/text/sbasic/shared/03020402.xhp
+++ b/source/text/sbasic/shared/03020402.xhp
@@ -36,10 +36,11 @@
 Changes the 
current drive.
 
 
+
 
 
 
-ChDrive Text As 
String
+  ChDrive Text As String
 
 
 
@@ -52,10 +53,14 @@
 
 
 
-Sub ExampleChDrive
-ChDrive "D" 
' Only possible if a drive 'D' exists.
-End Sub
+  Sub ExampleChDrive
+  ChDrive 
"D" ' Only possible if a drive 'D' exists.
+  End Sub
 
-
 
-
\ No newline at end of file
+
+  
+  
+
+
+
diff --git a/source/text/sbasic/shared/03020403.xhp 
b/source/text/sbasic/shared/03020403.xhp
index af7c1b381..0929218d7 100644
--- a/source/text/sbasic/shared/03020403.xhp
+++ b/source/text/sbasic/shared/03020403.xhp
@@ 

[Libreoffice-bugs] [Bug 128784] Basic documentation - Files & Directories outdated content

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128784

--- Comment #2 from Commit Notification 
 ---
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/bd3e4888b2b47d022871218f210b290b7d046288

Related tdf#128784 X-ref ChDir, ChDrive and CurDir with SF_FileSystem

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: helpcontent2

2021-05-20 Thread Rafael Lima (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 27c89d6db49855ffad5ec38bb4842f5d30b42a05
Author: Rafael Lima 
AuthorDate: Thu May 20 18:24:15 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Thu May 20 18:24:15 2021 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to bd3e4888b2b47d022871218f210b290b7d046288
  - Related tdf#128784 X-ref ChDir, ChDrive and CurDir with SF_FileSystem

The Basic functions ChDir, ChDrive and CurDir are DOS-specific and have 
limited functionality.

Hence, it's important to introduce the FileSystem service (from 
ScriptForge) for users that wish to write scripts that need to handle folders 
and files.

Change-Id: I33e24669083887b540cf44711ec5114e6ae5c521
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/115513
Tested-by: Jenkins
Reviewed-by: Alain Romedenne 

diff --git a/helpcontent2 b/helpcontent2
index 6eca503da7d0..bd3e4888b2b4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6eca503da7d03e8446f2ea9477fd6cdca735f6f1
+Subproject commit bd3e4888b2b47d022871218f210b290b7d046288
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 128784] Basic documentation - Files & Directories outdated content

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=128784

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source

2021-05-20 Thread Tünde Tóth (via logerrit)
 sc/source/ui/view/cellsh.cxx   |3 ++-
 sc/source/ui/view/viewfunc.cxx |3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

New commits:
commit a2c4a033d49c23d20761b2881135ec3a72f25b01
Author: Tünde Tóth 
AuthorDate: Tue May 11 11:21:35 2021 +0200
Commit: László Németh 
CommitDate: Thu May 20 18:08:31 2021 +0200

tdf#57351 sc UI: fix disabled Insert Columns options

In a sheet with active autofilter or standard filter,
Insert Columns Before/After weren't available in the
context menu of the column header and in Sheet->Insert
Columns...

Change-Id: I746d7d5a451848306d67d57e42d3981c471c66f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115400
Tested-by: László Németh 
Reviewed-by: László Németh 

diff --git a/sc/source/ui/view/cellsh.cxx b/sc/source/ui/view/cellsh.cxx
index 256cab898a35..9bf5286c8d7c 100644
--- a/sc/source/ui/view/cellsh.cxx
+++ b/sc/source/ui/view/cellsh.cxx
@@ -256,7 +256,8 @@ void ScCellShell::GetBlockState( SfxItemSet& rSet )
 if (nWhich == FID_INS_COLUMNS_AFTER)
 eAction = sc::ColRowEditAction::InsertColumnsAfter;
 
-bDisable = (!bSimpleArea) || GetViewData().SimpleRowMarked();
+bDisable = (!bSimpleArea && eMarkType != 
SC_MARK_SIMPLE_FILTERED)
+   || GetViewData().SimpleRowMarked();
 if (!bEditable && nRow1 == 0 && nRow2 == rDoc.MaxRow())
 {
 // See if row insertions are allowed.
diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index 73363238a85a..a4c5c6db55a7 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -1599,7 +1599,8 @@ void ScViewFunc::OnLOKSetWidthOrHeight(SCCOLROW nStart, 
bool bWidth)
 bool ScViewFunc::InsertCells( InsCellCmd eCmd, bool bRecord, bool bPartOfPaste 
)
 {
 ScRange aRange;
-if (GetViewData().GetSimpleArea(aRange) == SC_MARK_SIMPLE)
+ScMarkType eMarkType = GetViewData().GetSimpleArea(aRange);
+if (eMarkType == SC_MARK_SIMPLE || eMarkType == SC_MARK_SIMPLE_FILTERED)
 {
 ScDocShell* pDocSh = GetViewData().GetDocShell();
 const ScMarkData& rMark = GetViewData().GetMarkData();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 136401] Remove TSCP Classification toolbar and use a dialog instead

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136401

--- Comment #6 from Miklos Vajna  ---
I don't mind either way; Cor: please speak up if you have strong opinions. :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142150] Application crashes when EDITING line end styles (arrows)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142150

Buovjaga  changed:

   What|Removed |Added

   Severity|normal  |critical
   Keywords||possibleRegression,
   ||wantBacktrace
   Priority|medium  |highest

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142325] Error read rtf created Gnostice eDocEngine V5.0.0.548

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142325

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr,
   ||vmik...@collabora.com

--- Comment #3 from Julien Nabet  ---
I gave a try with https://products.aspose.app/words/viewer, the file seems
quite ok. (at least I saw nothing obviously wrong).

With master sources updated today, I can reproduce the pb too with this
message:
File format error found at 1,180
//writerfilter/source/rtfok/rtfdocumentimpl.cxx:827(row,col)

Miklos: since it concerns rtf, thought you might be interested in this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142395] FILEOPEN CSV: Space trailing values imported as garbage

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142395

--- Comment #7 from fabio  ---
(In reply to Mike Kaganski from comment #6)
> (A sidenote: when replying to a NEEDINFO, please set status back to
> UNCONFIRMED, not to REOPENED :-))

Thanks for the tip. It's the first time I'm using Bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 112856] FILEOPEN DOCX Bad header display / rels with image from header2.xml but should display header3.xml

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112856

Timur  changed:

   What|Removed |Added

   Keywords||filter:docx

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2021-05-20 Thread Caolán McNamara (via logerrit)
 sw/source/ui/dbui/dbinsdlg.cxx|   16 +---
 sw/source/uibase/inc/dbinsdlg.hxx |2 +-
 2 files changed, 6 insertions(+), 12 deletions(-)

New commits:
commit f7aca9ed4533f202e87141ca7a65d9949a36c9a1
Author: Caolán McNamara 
AuthorDate: Thu May 20 14:39:56 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu May 20 17:31:26 2021 +0200

HeaderHdl only does something for the m_xCbTableHeadon case

drop the others

Change-Id: Ibc07996ada54437c44201cb32f70bd594dd4a202
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115878
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/ui/dbui/dbinsdlg.cxx b/sw/source/ui/dbui/dbinsdlg.cxx
index a48dfeea4726..1f19a0884273 100644
--- a/sw/source/ui/dbui/dbinsdlg.cxx
+++ b/sw/source/ui/dbui/dbinsdlg.cxx
@@ -354,9 +354,7 @@ SwInsertDBColAutoPilot::SwInsertDBColAutoPilot( SwView& 
rView,
 m_xIbDbcolAllFrom->connect_clicked( LINK(this, SwInsertDBColAutoPilot, 
TableToFromHdl ));
 m_xIbDbcolToEdit->connect_clicked( LINK(this, SwInsertDBColAutoPilot, 
TableToFromHdl ));
 
-m_xCbTableHeadon->connect_clicked( LINK(this, SwInsertDBColAutoPilot, 
HeaderHdl ));
-m_xRbHeadlColnms->connect_clicked( LINK(this, SwInsertDBColAutoPilot, 
HeaderHdl ));
-m_xRbHeadlEmpty->connect_clicked( LINK(this, SwInsertDBColAutoPilot, 
HeaderHdl ));
+m_xCbTableHeadon->connect_toggled( LINK(this, SwInsertDBColAutoPilot, 
HeaderHdl ));
 
 m_xLbTextDbColumn->connect_changed( LINK( this, SwInsertDBColAutoPilot, 
TVSelectHdl ));
 m_xLbTableDbColumn->connect_changed( LINK( this, SwInsertDBColAutoPilot, 
TVSelectHdl ));
@@ -797,15 +795,11 @@ IMPL_LINK_NOARG(SwInsertDBColAutoPilot, CBSelectHdl, 
weld::ComboBox&, void)
 }
 }
 
-IMPL_LINK( SwInsertDBColAutoPilot, HeaderHdl, weld::Button&, rButton, void )
+IMPL_LINK_NOARG(SwInsertDBColAutoPilot, HeaderHdl, weld::ToggleButton&, void)
 {
-if ( == m_xCbTableHeadon.get())
-{
-bool bEnable = m_xCbTableHeadon->get_active();
-
-m_xRbHeadlColnms->set_sensitive( bEnable );
-m_xRbHeadlEmpty->set_sensitive( bEnable );
-}
+bool bEnable = m_xCbTableHeadon->get_active();
+m_xRbHeadlColnms->set_sensitive( bEnable );
+m_xRbHeadlEmpty->set_sensitive( bEnable );
 }
 
 static void lcl_InsTextInArr( const OUString& rText, DB_Columns& rColArr )
diff --git a/sw/source/uibase/inc/dbinsdlg.hxx 
b/sw/source/uibase/inc/dbinsdlg.hxx
index 0dc715d1c6fd..2d3206331e2f 100644
--- a/sw/source/uibase/inc/dbinsdlg.hxx
+++ b/sw/source/uibase/inc/dbinsdlg.hxx
@@ -131,7 +131,7 @@ class SwInsertDBColAutoPilot : public SfxDialogController, 
public utl::ConfigIte
 DECL_LINK( TVSelectHdl, weld::TreeView&, void );
 DECL_LINK( CBSelectHdl, weld::ComboBox&, void );
 DECL_LINK( DblClickHdl, weld::TreeView&, bool );
-DECL_LINK( HeaderHdl, weld::Button&, void );
+DECL_LINK( HeaderHdl, weld::ToggleButton&, void );
 
 bool SplitTextToColArr( const OUString& rText, DB_Columns& rColArr, bool 
bInsField );
 virtual void Notify( const css::uno::Sequence< OUString >& aPropertyNames 
) override;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 142395] FILEOPEN CSV: Space trailing values imported as garbage

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142395

Mike Kaganski  changed:

   What|Removed |Added

 Status|REOPENED|NEW

--- Comment #6 from Mike Kaganski  ---
(In reply to fabio from comment #5)

Repro.

(A sidenote: when replying to a NEEDINFO, please set status back to
UNCONFIRMED, not to REOPENED :-))

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 140506] REGRESSION Setting to repeat heading in writer tables no longer works

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140506

Timur  changed:

   What|Removed |Added

   Severity|critical|major

--- Comment #12 from Timur  ---
As a regression that's visible to users, it's highest, but it's not critical
because save and reopen will fix it, or header can be created with table.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142338] Crash in: SkPixelRef::notifyPixelsChanged()

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142338

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Could you give a try at https://wiki.documentfoundation.org/QA/FirstSteps ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] [macOS] Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

Bertrand Presles  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #2 from Bertrand Presles  ---
Indeed with 7.1.3 x86_64 release from
https://www.libreoffice.org/download/download/ it works.

As I mentionned in the Hardware settings, I'm using an Apple Silicon mac
(Macbook Air). And I can't find any arm64/Apple Silicon/universal build on
www.libreoffice.org.

But I tried to launch the Vanilla (AppStore) version using Rosetta (x86_64
translator) to see if it's related to the ARM64 build specifically. And I still
reproduce it with Rosetta.

So it may be a bug only reproduces in (non exclusive or):

- 7.1.2.3 release (version of the current LibreOffice Vanilla on AppStore)
- LibreOffice Vanilla specific changes.

Btw I used same exact icon set on LibreOffice 7.1.3 from libreoffice.org and on
LibreOffice Vanilla 7.1.2.3 from the AppStore, which is Sukapura.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142342] General Error. General input/output error.

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142342

--- Comment #6 from Julien Nabet  ---
I could reproduce this with LO Debian package 7.0.4 so perhaps already fixed in
7.1 branch.
Could someone give a try with LO 7.1.3 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142342] General Error. General input/output error.

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142342

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
Created attachment 172211
  --> https://bugs.documentfoundation.org/attachment.cgi?id=172211=edit
export test with master sources updated today

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 142400] [macOS] Tabbed UI broken on very large 4k screen (21:9 aspect ratio. 3440x1440)

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142400

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Julien Nabet  ---
Could you give a try at official LO 7.1.3 from
https://www.libreoffice.org/download/download/ ?
Vanilla is from MacStore so not sure if there are some changes compared with
official version.

Also you can take a look at https://wiki.documentfoundation.org/QA/FirstSteps

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source sd/source sw/source

2021-05-20 Thread Caolán McNamara (via logerrit)
 sc/source/ui/dbgui/scuiasciiopt.cxx |   24 
 sc/source/ui/dbgui/tpsubt.cxx   |   10 +-
 sc/source/ui/inc/delcodlg.hxx   |2 +-
 sc/source/ui/inc/linkarea.hxx   |2 +-
 sc/source/ui/inc/mtrindlg.hxx   |2 +-
 sc/source/ui/inc/scuiasciiopt.hxx   |2 +-
 sc/source/ui/inc/tpsubt.hxx |4 ++--
 sc/source/ui/miscdlgs/delcodlg.cxx  |4 ++--
 sc/source/ui/miscdlgs/linkarea.cxx  |4 ++--
 sc/source/ui/miscdlgs/mtrindlg.cxx  |4 ++--
 sd/source/filter/html/pubdlg.cxx|4 ++--
 sd/source/ui/inc/pubdlg.hxx |2 +-
 sw/source/ui/config/optpage.cxx |   32 
 sw/source/ui/misc/linenum.cxx   |4 ++--
 sw/source/uibase/inc/linenum.hxx|2 +-
 sw/source/uibase/inc/optpage.hxx|4 ++--
 16 files changed, 53 insertions(+), 53 deletions(-)

New commits:
commit 48182506886230a70cfa2ce3c61470701cb1138e
Author: Caolán McNamara 
AuthorDate: Thu May 20 13:00:44 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu May 20 17:01:53 2021 +0200

use toggle instead of click for CheckButton

Change-Id: Ic8957a59addbf08f2b2e4e84167991f00048c6a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115876
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/dbgui/scuiasciiopt.cxx 
b/sc/source/ui/dbgui/scuiasciiopt.cxx
index 40d86b908de0..34cedba0824c 100644
--- a/sc/source/ui/dbgui/scuiasciiopt.cxx
+++ b/sc/source/ui/dbgui/scuiasciiopt.cxx
@@ -431,18 +431,18 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent, 
const OUString& aDatNa
 lcl_FillCombo( *mxCbTextSep, gaTextSepList, mcTextSep );
 mxCbTextSep->set_entry_text(sTextSeparators);
 
-Link aSeparatorClickHdl =LINK( this, ScImportAsciiDlg, 
SeparatorClickHdl );
+Link aSeparatorClickHdl =LINK( this, 
ScImportAsciiDlg, SeparatorClickHdl );
 mxCbTextSep->connect_changed( LINK( this, ScImportAsciiDlg, 
SeparatorComboBoxHdl ) );
-mxCkbTab->connect_clicked( aSeparatorClickHdl );
-mxCkbSemicolon->connect_clicked( aSeparatorClickHdl );
-mxCkbComma->connect_clicked( aSeparatorClickHdl );
-mxCkbAsOnce->connect_clicked( aSeparatorClickHdl );
-mxCkbQuotedAsText->connect_clicked( aSeparatorClickHdl );
-mxCkbDetectNumber->connect_clicked( aSeparatorClickHdl );
-mxCkbSkipEmptyCells->connect_clicked( aSeparatorClickHdl );
-mxCkbSpace->connect_clicked( aSeparatorClickHdl );
-mxCkbRemoveSpace->connect_clicked( aSeparatorClickHdl );
-mxCkbOther->connect_clicked( aSeparatorClickHdl );
+mxCkbTab->connect_toggled( aSeparatorClickHdl );
+mxCkbSemicolon->connect_toggled( aSeparatorClickHdl );
+mxCkbComma->connect_toggled( aSeparatorClickHdl );
+mxCkbAsOnce->connect_toggled( aSeparatorClickHdl );
+mxCkbQuotedAsText->connect_toggled( aSeparatorClickHdl );
+mxCkbDetectNumber->connect_toggled( aSeparatorClickHdl );
+mxCkbSkipEmptyCells->connect_toggled( aSeparatorClickHdl );
+mxCkbSpace->connect_toggled( aSeparatorClickHdl );
+mxCkbRemoveSpace->connect_toggled( aSeparatorClickHdl );
+mxCkbOther->connect_toggled( aSeparatorClickHdl );
 mxEdOther->connect_changed(LINK(this, ScImportAsciiDlg, SeparatorEditHdl));
 
 // *** text encoding ListBox ***
@@ -709,7 +709,7 @@ IMPL_LINK(ScImportAsciiDlg, RbSepFixHdl, weld::Button&, 
rButton, void)
 }
 }
 
-IMPL_LINK(ScImportAsciiDlg, SeparatorClickHdl, weld::Button&, rCtrl, void)
+IMPL_LINK(ScImportAsciiDlg, SeparatorClickHdl, weld::ToggleButton&, rCtrl, 
void)
 {
 SeparatorHdl();
 }
diff --git a/sc/source/ui/dbgui/tpsubt.cxx b/sc/source/ui/dbgui/tpsubt.cxx
index 9ece3597bb50..57b34a9b09f9 100644
--- a/sc/source/ui/dbgui/tpsubt.cxx
+++ b/sc/source/ui/dbgui/tpsubt.cxx
@@ -82,7 +82,7 @@ void ScTpSubTotalGroup::Init()
 mxLbColumns->connect_changed( LINK( this, ScTpSubTotalGroup, 
SelectTreeListBoxHdl ) );
 mxLbColumns->connect_toggled( LINK( this, ScTpSubTotalGroup, CheckHdl ) );
 mxLbFunctions->connect_changed( LINK( this, ScTpSubTotalGroup, 
SelectTreeListBoxHdl) );
-mxLbSelectAllColumns->connect_clicked( LINK( this, ScTpSubTotalGroup, 
CheckBoxHdl ) );
+mxLbSelectAllColumns->connect_toggled( LINK( this, ScTpSubTotalGroup, 
CheckBoxHdl ) );
 
 mnFieldArr.resize(SC_MAXFIELDS(pDoc->GetSheetLimits()));
 mnFieldArr[0] = 0;
@@ -470,8 +470,8 @@ void ScTpSubTotalOptions::Init()
 pDoc = >GetDocument();
 assert(pDoc && "Document not found!");
 
-m_xBtnSort->connect_clicked( LINK( this, ScTpSubTotalOptions, CheckHdl ) );
-m_xBtnUserDef->connect_clicked( LINK( this, ScTpSubTotalOptions, CheckHdl 
) );
+m_xBtnSort->connect_toggled( LINK( this, ScTpSubTotalOptions, CheckHdl ) );
+m_xBtnUserDef->connect_toggled( LINK( this, ScTpSubTotalOptions, CheckHdl 
) );
 
 FillUserSortListBox();
 }
@@ -551,7 +551,7 @@ void ScTpSubTotalOptions::FillUserSortListBox()
 
 // Handler:
 
-IMPL_LINK(ScTpSubTotalOptions, 

[Libreoffice-bugs] [Bug 125458] TEMPLATES: Useless message when using a specific template

2021-05-20 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=125458

--- Comment #17 from Dieter  ---
Looking again on this bug and attachment 151821 I think the problem is that
examen.ott depends on iself. And therefor it is logic, that you will be asked
again and again.

Workaround:
1. Open examen.ott and accept changes
2. Save with a new name (for example examen2.ott)

You can open examen2.ott without the message.

So it's not a problem, if a template depends on another template, but if it
depends on itself. But I failed on creating such a template. Can you provide
some steps? I would expect a warning during the process: "You can't create a
template that is its own template" (or something similar).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sc/source sw/source

2021-05-20 Thread Caolán McNamara (via logerrit)
 sc/source/ui/dbgui/dpgroupdlg.cxx   |   16 +---
 sc/source/ui/dbgui/pvfundlg.cxx |   25 +++--
 sc/source/ui/dbgui/scuiasciiopt.cxx |   30 +-
 sc/source/ui/inc/dpgroupdlg.hxx |2 +-
 sc/source/ui/inc/instbdlg.hxx   |2 +-
 sc/source/ui/inc/pvfundlg.hxx   |4 ++--
 sc/source/ui/inc/scuiasciiopt.hxx   |3 ++-
 sc/source/ui/inc/tpcalc.hxx |2 +-
 sc/source/ui/inc/tpformula.hxx  |1 +
 sc/source/ui/miscdlgs/instbdlg.cxx  |9 ++---
 sc/source/ui/optdlg/tpcalc.cxx  |   16 +---
 sc/source/ui/optdlg/tpformula.cxx   |   20 ++--
 sw/source/ui/config/optpage.cxx |   13 -
 sw/source/ui/fldui/javaedit.cxx |   21 ++---
 sw/source/uibase/inc/javaedit.hxx   |3 ++-
 sw/source/uibase/inc/optpage.hxx|2 +-
 16 files changed, 103 insertions(+), 66 deletions(-)

New commits:
commit 253f7af7bcd2337a06c027852286616ff91d2e3f
Author: Caolán McNamara 
AuthorDate: Thu May 20 12:56:31 2021 +0100
Commit: Caolán McNamara 
CommitDate: Thu May 20 17:02:12 2021 +0200

use toggle instead of click for RadioButton

Change-Id: Ia43c3ccae0dcbfb0c522a8c13db6fbfb72bfa4f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115877
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/ui/dbgui/dpgroupdlg.cxx 
b/sc/source/ui/dbgui/dpgroupdlg.cxx
index f86199f1acc2..d260b4337680 100644
--- a/sc/source/ui/dbgui/dpgroupdlg.cxx
+++ b/sc/source/ui/dbgui/dpgroupdlg.cxx
@@ -233,7 +233,7 @@ ScDPDateGroupDlg::ScDPDateGroupDlg(weld::Window* pParent,
 if( rInfo.mbDateValues )
 {
 mxRbNumDays->set_active(true);
-ClickHdl(*mxRbNumDays );
+ToggleHdl(*mxRbNumDays );
 
 double fNumDays = rInfo.mfStep;
 if( fNumDays < 1.0 )
@@ -245,7 +245,7 @@ ScDPDateGroupDlg::ScDPDateGroupDlg(weld::Window* pParent,
 else
 {
 mxRbUnits->set_active(true);
-ClickHdl(*mxRbUnits);
+ToggleHdl(*mxRbUnits);
 }
 
 /*  Set the initial focus, currently it is somewhere after calling all the 
radio
@@ -259,8 +259,8 @@ ScDPDateGroupDlg::ScDPDateGroupDlg(weld::Window* pParent,
 else if( mxLbUnits->get_sensitive() )
 mxLbUnits->grab_focus();
 
-mxRbNumDays->connect_clicked( LINK( this, ScDPDateGroupDlg, ClickHdl ) );
-mxRbUnits->connect_clicked( LINK( this, ScDPDateGroupDlg, ClickHdl ) );
+mxRbNumDays->connect_toggled( LINK( this, ScDPDateGroupDlg, ToggleHdl ) );
+mxRbUnits->connect_toggled( LINK( this, ScDPDateGroupDlg, ToggleHdl ) );
 mxLbUnits->connect_toggled( LINK( this, ScDPDateGroupDlg, CheckHdl ) );
 }
 
@@ -302,9 +302,11 @@ sal_Int32 ScDPDateGroupDlg::GetDatePart() const
 return nDatePart;
 }
 
-IMPL_LINK(ScDPDateGroupDlg, ClickHdl, weld::Button&, rButton, void)
+IMPL_LINK(ScDPDateGroupDlg, ToggleHdl, weld::ToggleButton&, rButton, void)
 {
-if ( == mxRbNumDays.get())
+if (!rButton.get_active())
+return;
+if (mxRbNumDays->get_active())
 {
 mxLbUnits->set_sensitive(false);
 // enable and set focus to edit field on clicking "num of days" radio 
button
@@ -312,7 +314,7 @@ IMPL_LINK(ScDPDateGroupDlg, ClickHdl, weld::Button&, 
rButton, void)
 mxEdNumDays->grab_focus();
 mxBtnOk->set_sensitive(true);
 }
-else if ( == mxRbUnits.get())
+else if (mxRbUnits->get_active())
 {
 mxEdNumDays->set_sensitive(false);
 // enable and set focus to listbox on clicking "units" radio button
diff --git a/sc/source/ui/dbgui/pvfundlg.cxx b/sc/source/ui/dbgui/pvfundlg.cxx
index 43f4e33274a1..6c1e006ecbc5 100644
--- a/sc/source/ui/dbgui/pvfundlg.cxx
+++ b/sc/source/ui/dbgui/pvfundlg.cxx
@@ -527,9 +527,9 @@ void ScDPSubtotalDlg::Init( const ScDPLabelData& 
rLabelData, const ScPivotFuncDa
 mxFtName->set_label(rLabelData.getDisplayName());
 
 // radio buttons
-mxRbNone->connect_clicked( LINK( this, ScDPSubtotalDlg, RadioClickHdl ) );
-mxRbAuto->connect_clicked( LINK( this, ScDPSubtotalDlg, RadioClickHdl ) );
-mxRbUser->connect_clicked( LINK( this, ScDPSubtotalDlg, RadioClickHdl ) );
+mxRbNone->connect_toggled( LINK( this, ScDPSubtotalDlg, RadioClickHdl ) );
+mxRbAuto->connect_toggled( LINK( this, ScDPSubtotalDlg, RadioClickHdl ) );
+mxRbUser->connect_toggled( LINK( this, ScDPSubtotalDlg, RadioClickHdl ) );
 
 weld::RadioButton* pRBtn = nullptr;
 switch( rFuncData.mnFuncMask )
@@ -562,9 +562,11 @@ IMPL_LINK(ScDPSubtotalDlg, ButtonClicked, weld::Button&, 
rButton, void)
 response(RET_CANCEL);
 }
 
-IMPL_LINK(ScDPSubtotalDlg, RadioClickHdl, weld::Button&, rBtn, void)
+IMPL_LINK(ScDPSubtotalDlg, RadioClickHdl, weld::ToggleButton&, rBtn, void)
 {
-mxLbFunc->set_sensitive( == mxRbUser.get());
+if (!rBtn.get_active())
+return;
+mxLbFunc->set_sensitive(mxRbUser->get_active());
 }
 
 

  1   2   3   4   >