[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 31 +-
writerfilter/source/dmapper/NumberingManager.cxx |5 +++
2 files changed, 18 insertions(+), 18 deletions(-)
New commits:
commit 11211f2ff0a4d894f889874d46c6ba8be4d3dc39
Author: Justin Luth
AuthorDate: Fri Apr 30 13:42:58 2021 +0200
Commit: Justin Luth
CommitDate: Sat Jul 10 07:24:54 2021 +0200
tdf#141964 writerfilter CN: why ignore paragraph's listId?
This seems bizarre. nListId was only set when the style
defined it? What about the directly applied rule?
Surely that has more relevance in all the
subsequent code that used the value in nListId,
as borne out in all of the code that re-calculated nlistId2.
Change-Id: I188e812388c706cf0e785fdede29a6d21be12867
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115260
Tested-by: Justin Luth
Reviewed-by: Justin Luth
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 40602ee0d40d..c3d6e4efbe6d 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1533,13 +1533,14 @@ void DomainMapper_Impl::finishParagraph( const
PropertyMapPtr& pPropertyMap, con
const StyleSheetEntryPtr pEntry =
GetStyleSheetTable()->FindStyleSheetByConvertedStyleName(
GetCurrentParaStyleName() );
OSL_ENSURE( pEntry, "no style sheet found" );
const StyleSheetPropertyMap* pStyleSheetProperties = dynamic_cast(pEntry ? pEntry->pProperties.get() : nullptr);
+sal_Int32 nListId = pParaContext ? pParaContext->GetListId() : -1;
bool isNumberingViaStyle(false);
-bool isNumberingViaRule = pParaContext && pParaContext->GetListId() > -1;
-sal_Int32 nListId = -1;
+bool isNumberingViaRule = nListId > -1;
if ( !bRemove && pStyleSheetProperties && pParaContext )
{
bool bNumberingFromBaseStyle = false;
-nListId = lcl_getListId(pEntry, GetStyleSheetTable(),
bNumberingFromBaseStyle);
+if (!isNumberingViaRule)
+nListId = lcl_getListId(pEntry, GetStyleSheetTable(),
bNumberingFromBaseStyle);
//apply numbering level/style to paragraph if it was set at the style,
but only if the paragraph itself
//does not specify the numbering
@@ -1552,10 +1553,10 @@ void DomainMapper_Impl::finishParagraph( const
PropertyMapPtr& pPropertyMap, con
pParaContext->Insert( PROP_NUMBERING_LEVEL,
uno::makeAny(nListLevel), false );
auto const pList(GetListTable()->GetList(nListId));
-if (pList && nListId >= 0 &&
!pParaContext->isSet(PROP_NUMBERING_STYLE_NAME))
+if (pList && nListId > 0 &&
!pParaContext->isSet(PROP_NUMBERING_STYLE_NAME))
{
// ListLevel 9 means Body Level/no numbering. numId 0 means no
numbering.
-if (bNoNumbering || nListLevel == 9 || (!isNumberingViaRule &&
!nListId))
+if (bNoNumbering || nListLevel == 9)
pParaContext->Insert(PROP_NUMBERING_STYLE_NAME,
uno::makeAny(OUString()), true);
else if ( !isNumberingViaRule )
{
@@ -1570,7 +1571,8 @@ void DomainMapper_Impl::finishParagraph( const
PropertyMapPtr& pPropertyMap, con
// Apply the style if it uses the same list as the direct
numbering,
// otherwise the directly-applied-to-paragraph status will be
lost,
// and the priority of the numbering-style-indents will be
lowered. tdf#133000
-if ( nListId == pParaContext->GetListId() )
+bool bDummy;
+if (nListId == lcl_getListId(pEntry, GetStyleSheetTable(),
bDummy))
pParaContext->Insert( PROP_NUMBERING_STYLE_NAME,
uno::makeAny(pList->GetStyleName()), true );
}
}
@@ -1621,10 +1623,8 @@ void DomainMapper_Impl::finishParagraph( const
PropertyMapPtr& pPropertyMap, con
{
pParaContext->Insert(PROP_PARA_RIGHT_MARGIN, aRightMargin,
/*bOverwrite=*/false);
-sal_Int32 nListId2(pParaContext->GetListId());
-
-const sal_Int32 nFirstLineIndent =
getNumberingProperty(nListId2, nListLevel, "FirstLineIndent");
-const sal_Int32 nParaLeftMargin =
getNumberingProperty(nListId2, nListLevel, "IndentAt");
+const sal_Int32 nFirstLineIndent =
getNumberingProperty(nListId, nListLevel, "FirstLineIndent");
+const sal_Int32 nParaLeftMargin =
getNumberingProperty(nListId, nListLevel, "IndentAt");
if (nFirstLineIndent != 0)
pParaContext->Insert(PROP_PARA_FIRST_LINE_INDENT,
uno::makeAny(nFirstLineIndent), /*bOverwrite=*/false);
if (nParaLeftMargin != 0)
@@ -1948,12 +1948,7 @@ void DomainMapper_Impl::finishParagraph( const
PropertyMapPtr& pPropertyMap, con
(isNumberingViaStyle ||
[Libreoffice-bugs] [Bug 141964] FILEOPEN DOCX: Outline numbering not imported well.
https://bugs.documentfoundation.org/show_bug.cgi?id=141964 --- Comment #14 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/11211f2ff0a4d894f889874d46c6ba8be4d3dc39 tdf#141964 writerfilter CN: why ignore paragraph's listId? It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143288] (spam)
https://bugs.documentfoundation.org/show_bug.cgi?id=143288 Ming Hua changed: What|Removed |Added Product|Document Liberation Project |LibreOffice Resolution|--- |INVALID Summary|How to contact Robinhood|(spam) |customer service| |professionals? | Component|General |deletionRequest Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107381] Default cell style colors shouldnt be included as document colors
https://bugs.documentfoundation.org/show_bug.cgi?id=107381 --- Comment #9 from Ming Hua --- (In reply to Mike Kaganski from comment #8) > IMO NOTABUG. > > How do you define "used"? Suppose you assign a color to a style used in a > conditional format (Calc), or make it a conditional style (writer), and the > condition is not satisfied - is it used, or not? Suppose it's used in > another style - like in a header of a page style: is it used or not? And > e.g., the page style using the colored style might not be assigned manually, > but be part of a page style sequence defined by "Next style" machinery - and > then its appearance depends on current page count, which may depend on a > huge number of variables - e.g., on the length of dynamic fields, or content > of linked frames, etc. > > In general, I'd suggest to keep it simple: it is used in style defined in > the document = it is used in the document. There are two counter-argument to this: 1. Calc differentiates "all styles" and "applied styles" in the Style sidebar. I think it would be much closer to the user's expectation that applied styles count as "document colors", while the others don't. AFAIK it's not possible to define a conditional format without applying it to some cell range, so conditional formats can all be considered applied. 2. Currently Writer's default paragraph styles don't seem to use any colors, but the character styles do, e.g. the "Internet Link" style. The color used by these character styles don't show up as document colors unless said character style is applied to some text. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143289] New: Crash in: google_breakpad::ExceptionHandler::HandlePureVirtualCall()
https://bugs.documentfoundation.org/show_bug.cgi?id=143289 Bug ID: 143289 Summary: Crash in: google_breakpad::ExceptionHandler::HandlePureVirtualCa ll() Product: LibreOffice Version: 7.1.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rbige...@pcisys.net This bug was filed from the crash reporting server and is br-c3aa3d2e-61f9-433d-b485-a43ccd11ff8b. = 7.1.4.2 Calc crashes on closing. No query about saving file. Display remains on screen. Restart offers to recover file. OS is WIN 10 with current updates (09July2021). LO was removed from the system and reinstalled; no help. Tried rolling back (uninstall and fresh install) from 7.1.4.2 to 7.0.4.2. That works properly at least sometimes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 Ming Hua changed: What|Removed |Added Keywords|needsDevEval|needsUXEval -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 Ming Hua changed: What|Removed |Added Keywords|needsDevEval|needsUXEval -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 Ming Hua changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| OS|Linux (All) |All Keywords||needsDevEval --- Comment #4 from Ming Hua --- Unfortunately there don't seem to be LO developers actively working on text rendering right now. Let's see if the UX team want to have a look at this and discuss the possibility of turning off pair kerning by default. The advantage seems not clear-cut to me, and I don't think it's possible to turning it off only for certain fonts. For people not familiar with pair kerning: The option to turn it on/off is located at the "Position" tab of the character formatting or paragraph style dialog. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 Ming Hua changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Whiteboard| QA:needsComment| OS|Linux (All) |All Keywords||needsDevEval --- Comment #4 from Ming Hua --- Unfortunately there don't seem to be LO developers actively working on text rendering right now. Let's see if the UX team want to have a look at this and discuss the possibility of turning off pair kerning by default. The advantage seems not clear-cut to me, and I don't think it's possible to turning it off only for certain fonts. For people not familiar with pair kerning: The option to turn it on/off is located at the "Position" tab of the character formatting or paragraph style dialog. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 --- Comment #3 from Ming Hua --- Created attachment 173480 --> https://bugs.documentfoundation.org/attachment.cgi?id=173480=edit Screenshot of similar comparison under Windows (In reply to adam.m.fontenot+docfo from comment #0) > This might be the cause of > https://bugs.documentfoundation.org/show_bug.cgi?id=128987 but I can't tell > because I don't use Windows. I don't know much about text rendering so all I can add is a screenshot with 7.2.0 Beta1 on Windows 10, showing similar differences with or without pair kerning. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143288] New: How to contact Robinhood customer service professionals?
https://bugs.documentfoundation.org/show_bug.cgi?id=143288 Bug ID: 143288 Summary: How to contact Robinhood customer service professionals? Product: Document Liberation Project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: juliamayan...@gmail.com Initiatives through the correct path are essential factors. These days, many people are indulged in trading online with the help of the Robinhood platform. On the other hand, tech issues never leave the internet-based application free from its impact. A similar thing can be observed with Robinhood and thus consulting the Robinhood customer service team becomes essential for a solution eventually. Robinhood customers may initiate to have words with experts as per their needs. https://www.robinhoodphonenumber.com/ -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143075] Libreoffice Writer - Paste special, DDE cannot be deleted
https://bugs.documentfoundation.org/show_bug.cgi?id=143075 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143070] eyedropper tool offset by several hundred pixels
https://bugs.documentfoundation.org/show_bug.cgi?id=143070 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143066] Paragraph styles for all kinds of headlines should be without spell checking
https://bugs.documentfoundation.org/show_bug.cgi?id=143066 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143064] selecting multiple slides and changing colour or animation, changes happens to only first slide
https://bugs.documentfoundation.org/show_bug.cgi?id=143064 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143060] Some texts don't adapt to theme color
https://bugs.documentfoundation.org/show_bug.cgi?id=143060 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143056] [EMF+] StringFormat Tracking is not supported
https://bugs.documentfoundation.org/show_bug.cgi?id=143056 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143271] LibreOffice suite: Crash on startup if "Lohit" fonts are not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=143271 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143271] LibreOffice suite: Crash on startup if "Lohit" fonts are not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=143271 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138796] slowness
https://bugs.documentfoundation.org/show_bug.cgi?id=138796 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 138796] slowness
https://bugs.documentfoundation.org/show_bug.cgi?id=138796 --- Comment #3 from QA Administrators --- Dear Heriaud, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137437] Writer, spell check: a boggling offer to 'continue' (among a welter of related problems)
https://bugs.documentfoundation.org/show_bug.cgi?id=137437 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137437] Writer, spell check: a boggling offer to 'continue' (among a welter of related problems)
https://bugs.documentfoundation.org/show_bug.cgi?id=137437 --- Comment #4 from QA Administrators --- Dear nicholasjoll, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136622] Tab does not toggle text in the column
https://bugs.documentfoundation.org/show_bug.cgi?id=136622 --- Comment #5 from QA Administrators --- Dear Jonas Eek, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 136110] Does not appear to create LibreOffice Writer documents in the context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=136110 --- Comment #3 from QA Administrators --- Dear João Paulo, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108757] PDF Export of a particular spreadsheet is slower than it has been before
https://bugs.documentfoundation.org/show_bug.cgi?id=108757 --- Comment #7 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143271] LibreOffice suite: Crash on startup if "Lohit" fonts are not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=143271 --- Comment #6 from Aidan K --- (In reply to Uwe Auer from comment #4) > (In reply to Aidan K from comment #0) > > > CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 > > Kubuntu 21.04 > > I'm wondering why you see "VCL: gtk3" while you are on Kubuntu, which is the > KDE flavor of Ubuntu and you should have "VCL: kf5" (KDE Frameworks 5). > Could you please try following command in a terminal: > > SAL_USE_VCLPLUGIN=kf5 libreoffice > > Does it work this way? Though I have gotten the program working, this command still opens LO with gtk3. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143271] LibreOffice suite: Crash on startup if "Lohit" fonts are not installed
https://bugs.documentfoundation.org/show_bug.cgi?id=143271 --- Comment #5 from Aidan K --- No matter what I do, I'm now (thankfully?) unable to reproduce the issue. LibreOffice opens every time, with or without the Lohit fonts. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143287] New: Spelling - Correct and Correct All is inappropriate.
https://bugs.documentfoundation.org/show_bug.cgi?id=143287 Bug ID: 143287 Summary: Spelling - Correct and Correct All is inappropriate. Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: keepitsimplestu...@yahoo.com The old actions of "Change" and "Change all" from Ubuntu 12 ERA is more appropriate than Correct and Correct All from the Ubuntu 18 ERA. Correct has the same confusion as right. e.g.Turn right here. Right, That's were "correct" is appropriate. Correct has Two meanings. One is "Don;t do anything". it;s the right way. or Make a correction. "Change" and "Change all" is not ambiguous. "Correct" and "Correct All" is. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143286] New: Spelling - No "Back" button
https://bugs.documentfoundation.org/show_bug.cgi?id=143286 Bug ID: 143286 Summary: Spelling - No "Back" button Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: keepitsimplestu...@yahoo.com if you accidentally not correct something and you want to "go back", you can't. It's not really undo. Going back does not have to be undo a correction. It could be go back to the last supposedly unspelled word. Present since Ubuntu 12.04 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143285] New: Spelling - Contractions
https://bugs.documentfoundation.org/show_bug.cgi?id=143285 Bug ID: 143285 Summary: Spelling - Contractions Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: keepitsimplestu...@yahoo.com Contractions like would;nt will not get caught correctly. Bug has been present since Ubuntu 12.04 LTS -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143284] VIEWING : LibreOffice Writer has great difficulty reading some documents.
https://bugs.documentfoundation.org/show_bug.cgi?id=143284 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from m.a.riosv --- With Version: 7.1.5.1 (x64) / LibreOffice Community Build ID: 2ca94649fd6dbdcab938c55c28b6a950a9634a34 CPU threads: 4; OS: Windows 10.0 Build 21390; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL No slowness opening and editing. Seems there is a little difference on margins, word show left:0.3 right:1 and in writer 0.4 and 1.2 change it in writer and everything looks fine. BTW on the second and third paragraph the align is done with space, right tab seems the right way. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmReader.hxx|1 +
include/vcl/metaact.hxx |5 +
vcl/source/filter/svm/SvmReader.cxx | 28 +++-
3 files changed, 33 insertions(+), 1 deletion(-)
New commits:
commit 4146be28450c77159ae8c7f8d4d7f471756ec14c
Author: panoskorovesis
AuthorDate: Fri Jul 9 14:17:38 2021 +0300
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:41:31 2021 +0200
Add Handler for BmpExScalePart Read
The handler separates MetaBmpExScalePartAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I22f7cec1873dedfce16ec6ea597b5113089e8ec0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118677
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/filter/SvmReader.hxx b/include/vcl/filter/SvmReader.hxx
index 853a52a8ae3d..9ce071448dca 100644
--- a/include/vcl/filter/SvmReader.hxx
+++ b/include/vcl/filter/SvmReader.hxx
@@ -61,6 +61,7 @@ public:
rtl::Reference BmpScalePartHandler();
rtl::Reference BmpExHandler();
rtl::Reference BmpExScaleHandler();
+rtl::Reference BmpExScalePartHandler();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index b71c59b5144f..c59257433daa 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -909,6 +909,11 @@ public:
const Size& GetDestSize() const { return maDstSz; }
const Point&GetSrcPoint() const { return maSrcPt; }
const Size& GetSrcSize() const { return maSrcSz; }
+voidSetBitmapEx(BitmapEx& rBmpEx) { maBmpEx = rBmpEx; }
+voidSetDestPoint(Point& rDstPt) { maDstPt = rDstPt; }
+voidSetDestSize(Size& rDstSz) { maDstSz = rDstSz; }
+voidSetSrcPoint(Point& rSrcPt) { maSrcPt = rSrcPt; }
+voidSetSrcSize(Size& rSrcSz) { maSrcSz = rSrcSz; }
boolIsTransparent() const override { return
GetBitmapEx().IsAlpha(); }
};
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index 303e280e8680..679a6185c503 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -226,7 +226,7 @@ rtl::Reference
SvmReader::MetaActionHandler(ImplMetaReadData* pData)
return BmpExScaleHandler();
break;
case MetaActionType::BMPEXSCALEPART:
-pAction = new MetaBmpExScalePartAction;
+return BmpExScalePartHandler();
break;
case MetaActionType::MASK:
pAction = new MetaMaskAction;
@@ -935,4 +935,30 @@ rtl::Reference SvmReader::BmpExScaleHandler()
return pAction;
}
+
+rtl::Reference SvmReader::BmpExScalePartHandler()
+{
+auto pAction = new MetaBmpExScalePartAction();
+
+VersionCompatRead aCompat(mrStream);
+BitmapEx aBmpEx;
+ReadDIBBitmapEx(aBmpEx, mrStream);
+TypeSerializer aSerializer(mrStream);
+Point aDstPoint;
+aSerializer.readPoint(aDstPoint);
+Size aDstSize;
+aSerializer.readSize(aDstSize);
+Point aSrcPoint;
+aSerializer.readPoint(aSrcPoint);
+Size aSrcSize;
+aSerializer.readSize(aSrcSize);
+
+pAction->SetBitmapEx(aBmpEx);
+pAction->SetDestPoint(aDstPoint);
+pAction->SetDestSize(aDstSize);
+pAction->SetSrcPoint(aSrcPoint);
+pAction->SetSrcSize(aSrcSize);
+
+return pAction;
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmReader.hxx|1 +
include/vcl/metaact.hxx |3 +++
vcl/source/filter/svm/SvmReader.cxx | 22 +-
3 files changed, 25 insertions(+), 1 deletion(-)
New commits:
commit fa17410b7cad394254818ca0dfcd92673fb642d0
Author: panoskorovesis
AuthorDate: Fri Jul 9 14:10:13 2021 +0300
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:41:09 2021 +0200
Add Handler for BmpExScale Read
The hanlder separates MetaBmpExScaleAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I2736e259955f2610ee6acd4a36be5d362df57b74
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118674
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/filter/SvmReader.hxx b/include/vcl/filter/SvmReader.hxx
index fc82e47268bc..853a52a8ae3d 100644
--- a/include/vcl/filter/SvmReader.hxx
+++ b/include/vcl/filter/SvmReader.hxx
@@ -60,6 +60,7 @@ public:
rtl::Reference BmpScaleHandler();
rtl::Reference BmpScalePartHandler();
rtl::Reference BmpExHandler();
+rtl::Reference BmpExScaleHandler();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index b3cd5e0b5e87..b71c59b5144f 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -867,6 +867,9 @@ public:
const BitmapEx& GetBitmapEx() const { return maBmpEx; }
const Point&GetPoint() const { return maPt; }
const Size& GetSize() const { return maSz; }
+voidSetBitmapEx(BitmapEx& rBmpEx) { maBmpEx = rBmpEx; }
+voidSetPoint(Point& rPt) { maPt = rPt; }
+voidSetSize(Size& rSz) { maSz = rSz; }
boolIsTransparent() const override { return
GetBitmapEx().IsAlpha(); }
};
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index e53dbefeb45e..303e280e8680 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -223,7 +223,7 @@ rtl::Reference
SvmReader::MetaActionHandler(ImplMetaReadData* pData)
return BmpExHandler();
break;
case MetaActionType::BMPEXSCALE:
-pAction = new MetaBmpExScaleAction;
+return BmpExScaleHandler();
break;
case MetaActionType::BMPEXSCALEPART:
pAction = new MetaBmpExScalePartAction;
@@ -915,4 +915,24 @@ rtl::Reference SvmReader::BmpExHandler()
return pAction;
}
+
+rtl::Reference SvmReader::BmpExScaleHandler()
+{
+auto pAction = new MetaBmpExScaleAction();
+
+VersionCompatRead aCompat(mrStream);
+BitmapEx aBmpEx;
+ReadDIBBitmapEx(aBmpEx, mrStream);
+TypeSerializer aSerializer(mrStream);
+Point aPoint;
+aSerializer.readPoint(aPoint);
+Size aSize;
+aSerializer.readSize(aSize);
+
+pAction->SetBitmapEx(aBmpEx);
+pAction->SetPoint(aPoint);
+pAction->SetSize(aSize);
+
+return pAction;
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmReader.hxx|1 +
include/vcl/metaact.hxx |2 ++
vcl/source/filter/svm/SvmReader.cxx | 19 ++-
3 files changed, 21 insertions(+), 1 deletion(-)
New commits:
commit 7c85ebbc1aa81f54351f82566d25a11125eaeaa1
Author: panoskorovesis
AuthorDate: Fri Jul 9 14:01:01 2021 +0300
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:40:53 2021 +0200
Add Handler for BmpEx Read
The handler separates MetaBmpExAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: Ia5175e824716e08df2ac42e354b337b9e15050e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118673
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/filter/SvmReader.hxx b/include/vcl/filter/SvmReader.hxx
index fedaf58b9692..fc82e47268bc 100644
--- a/include/vcl/filter/SvmReader.hxx
+++ b/include/vcl/filter/SvmReader.hxx
@@ -59,6 +59,7 @@ public:
rtl::Reference BmpHandler();
rtl::Reference BmpScaleHandler();
rtl::Reference BmpScalePartHandler();
+rtl::Reference BmpExHandler();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index 4c531977100f..b3cd5e0b5e87 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -831,6 +831,8 @@ public:
const BitmapEx& GetBitmapEx() const { return maBmpEx; }
const Point&GetPoint() const { return maPt; }
+voidSetBitmapEx(BitmapEx rBmpEx) { maBmpEx = rBmpEx; }
+voidSetPoint(Point& rPt) { maPt = rPt; }
boolIsTransparent() const override { return
GetBitmapEx().IsAlpha(); }
};
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index ed75eb27893e..e53dbefeb45e 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -220,7 +220,7 @@ rtl::Reference
SvmReader::MetaActionHandler(ImplMetaReadData* pData)
return BmpScalePartHandler();
break;
case MetaActionType::BMPEX:
-pAction = new MetaBmpExAction;
+return BmpExHandler();
break;
case MetaActionType::BMPEXSCALE:
pAction = new MetaBmpExScaleAction;
@@ -898,4 +898,21 @@ rtl::Reference SvmReader::BmpScalePartHandler()
return pAction;
}
+
+rtl::Reference SvmReader::BmpExHandler()
+{
+auto pAction = new MetaBmpExAction();
+
+VersionCompatRead aCompat(mrStream);
+BitmapEx aBmpEx;
+ReadDIBBitmapEx(aBmpEx, mrStream);
+TypeSerializer aSerializer(mrStream);
+Point aPoint;
+aSerializer.readPoint(aPoint);
+
+pAction->SetPoint(aPoint);
+pAction->SetBitmapEx(aBmpEx);
+
+return pAction;
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/filter/SvmReader.hxx|1 +
include/vcl/metaact.hxx |5 +
vcl/source/filter/svm/SvmReader.cxx | 28 +++-
3 files changed, 33 insertions(+), 1 deletion(-)
New commits:
commit 83b3c793144a1ef39edb72e8d4c438dbec13c179
Author: panoskorovesis
AuthorDate: Fri Jul 9 13:55:14 2021 +0300
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:40:11 2021 +0200
Add Handler for BmpScalePart Read
The handler separates MetaBmpScalePartAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I0c8585ca18f3904a798a51081257c238b27297e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118672
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/filter/SvmReader.hxx b/include/vcl/filter/SvmReader.hxx
index 5757abe1c30c..fedaf58b9692 100644
--- a/include/vcl/filter/SvmReader.hxx
+++ b/include/vcl/filter/SvmReader.hxx
@@ -58,6 +58,7 @@ public:
rtl::Reference TextLineHandler();
rtl::Reference BmpHandler();
rtl::Reference BmpScaleHandler();
+rtl::Reference BmpScalePartHandler();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index f025ae6fac87..4c531977100f 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -796,6 +796,11 @@ public:
const Size& GetDestSize() const { return maDstSz; }
const Point&GetSrcPoint() const { return maSrcPt; }
const Size& GetSrcSize() const { return maSrcSz; }
+voidSetBitmap(Bitmap& rBmp) { maBmp = rBmp; }
+voidSetDestPoint(Point& rPt) { maDstPt = rPt; }
+voidSetDestSize(Size& rSz) { maDstSz = rSz; }
+voidSetSrcPoint(Point& rPt) { maSrcPt = rPt; }
+voidSetSrcSize(Size& rSz) { maSrcSz = rSz; }
};
class VCL_DLLPUBLIC MetaBmpExAction final : public MetaAction
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index 91e4052dab33..ed75eb27893e 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -217,7 +217,7 @@ rtl::Reference
SvmReader::MetaActionHandler(ImplMetaReadData* pData)
return BmpScaleHandler();
break;
case MetaActionType::BMPSCALEPART:
-pAction = new MetaBmpScalePartAction;
+return BmpScalePartHandler();
break;
case MetaActionType::BMPEX:
pAction = new MetaBmpExAction;
@@ -872,4 +872,30 @@ rtl::Reference SvmReader::BmpScaleHandler()
return pAction;
}
+
+rtl::Reference SvmReader::BmpScalePartHandler()
+{
+auto pAction = new MetaBmpScalePartAction();
+
+VersionCompatRead aCompat(mrStream);
+Bitmap aBmp;
+ReadDIB(aBmp, mrStream, true);
+TypeSerializer aSerializer(mrStream);
+Point aDestPoint;
+aSerializer.readPoint(aDestPoint);
+Size aDestSize;
+aSerializer.readSize(aDestSize);
+Point aSrcPoint;
+aSerializer.readPoint(aSrcPoint);
+Size aSrcSize;
+aSerializer.readSize(aSrcSize);
+
+pAction->SetBitmap(aBmp);
+pAction->SetDestPoint(aDestPoint);
+pAction->SetDestSize(aDestSize);
+pAction->SetSrcPoint(aSrcPoint);
+pAction->SetSrcSize(aSrcSize);
+
+return pAction;
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/source
include/vcl/filter/SvmReader.hxx|2 +
include/vcl/metaact.hxx |5
vcl/source/filter/svm/SvmReader.cxx | 42 ++--
3 files changed, 47 insertions(+), 2 deletions(-)
New commits:
commit 19441313b37eb5d0a11c8a929a38c079fa7ef291
Author: panoskorovesis
AuthorDate: Fri Jul 9 13:36:54 2021 +0300
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:39:47 2021 +0200
Add Handler for BmpScale Read
The handler separates MetaBmpScaleAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I1641d11d6fbe49d023b758d7e6aaeabbc667030b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118667
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/filter/SvmReader.hxx b/include/vcl/filter/SvmReader.hxx
index c34c7db1df4e..5757abe1c30c 100644
--- a/include/vcl/filter/SvmReader.hxx
+++ b/include/vcl/filter/SvmReader.hxx
@@ -57,6 +57,7 @@ public:
rtl::Reference TextRectHandler(ImplMetaReadData* pData);
rtl::Reference TextLineHandler();
rtl::Reference BmpHandler();
+rtl::Reference BmpScaleHandler();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index 464f2b32777e..f025ae6fac87 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -755,6 +755,9 @@ public:
const Bitmap& GetBitmap() const { return maBmp; }
const Point&GetPoint() const { return maPt; }
const Size& GetSize() const { return maSz; }
+voidSetBitmap(Bitmap& rBmp) { maBmp = rBmp; }
+voidSetPoint(Point& rPt) { maPt = rPt; }
+voidSetSize(Size& rSz) { maSz = rSz; }
};
class UNLESS_MERGELIBS(VCL_DLLPUBLIC) MetaBmpScalePartAction final : public
MetaAction
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index 8f2c503ffc7b..91e4052dab33 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -214,7 +214,7 @@ rtl::Reference
SvmReader::MetaActionHandler(ImplMetaReadData* pData)
return BmpHandler();
break;
case MetaActionType::BMPSCALE:
-pAction = new MetaBmpScaleAction;
+return BmpScaleHandler();
break;
case MetaActionType::BMPSCALEPART:
pAction = new MetaBmpScalePartAction;
@@ -852,4 +852,24 @@ rtl::Reference SvmReader::BmpHandler()
return pAction;
}
+
+rtl::Reference SvmReader::BmpScaleHandler()
+{
+auto pAction = new MetaBmpScaleAction();
+
+VersionCompatRead aCompat(mrStream);
+Bitmap aBmp;
+ReadDIB(aBmp, mrStream, true);
+TypeSerializer aSerializer(mrStream);
+Point aPoint;
+aSerializer.readPoint(aPoint);
+Size aSz;
+aSerializer.readSize(aSz);
+
+pAction->SetBitmap(aBmp);
+pAction->SetPoint(aPoint);
+pAction->SetSize(aSz);
+
+return pAction;
+}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 10d983f57f0bc1ec665d6e2bbfa1d9038446e7f9
Author: panoskorovesis
AuthorDate: Fri Jul 9 13:28:47 2021 +0300
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:39:32 2021 +0200
Add Handler for Bmp Read
The handler separates MetaBmpAction::Read from metaact.hxx
Read implementation is now in SvmReader.hxx
Change-Id: I60b9c2fbe9c5e23e0f1a05c4aa96565e3d14c403
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118665
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/filter/SvmReader.hxx b/include/vcl/filter/SvmReader.hxx
index fd8d81ce7295..c34c7db1df4e 100644
--- a/include/vcl/filter/SvmReader.hxx
+++ b/include/vcl/filter/SvmReader.hxx
@@ -56,6 +56,7 @@ public:
rtl::Reference StretchTextHandler(ImplMetaReadData* pData);
rtl::Reference TextRectHandler(ImplMetaReadData* pData);
rtl::Reference TextLineHandler();
+rtl::Reference BmpHandler();
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/include/vcl/metaact.hxx b/include/vcl/metaact.hxx
index 731e901bd622..464f2b32777e 100644
--- a/include/vcl/metaact.hxx
+++ b/include/vcl/metaact.hxx
@@ -720,6 +720,8 @@ public:
const Bitmap& GetBitmap() const { return maBmp; }
const Point&GetPoint() const { return maPt; }
+voidSetBitmap(Bitmap& rBmp) { maBmp = rBmp; }
+voidSetPoint(Point& rPt) { maPt = rPt; }
};
class VCL_DLLPUBLIC MetaBmpScaleAction final : public MetaAction
diff --git a/vcl/source/filter/svm/SvmReader.cxx
b/vcl/source/filter/svm/SvmReader.cxx
index 43cd2e0e354a..8f2c503ffc7b 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -210,7 +211,7 @@ rtl::Reference
SvmReader::MetaActionHandler(ImplMetaReadData* pData)
[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk include/vcl vcl/backendtest
cui/Library_cui.mk|1
cui/UIConfig_cui.mk |2
cui/source/dialogs/GraphicTestsDialog.cxx | 78 +++--
cui/source/dialogs/ImageViewerDialog.cxx | 24 +
cui/source/inc/GraphicsTestsDialog.hxx| 34 ++
cui/source/inc/ImageViewerDialog.hxx | 20 +
cui/uiconfig/ui/graphictestdlg.ui | 101 +-
cui/uiconfig/ui/graphictestentry.ui | 43 ++
cui/uiconfig/ui/imageviewer.ui| 44 ++
include/vcl/test/GraphicsRenderTests.hxx | 39 +-
vcl/backendtest/GraphicsRenderTests.cxx | 455 --
11 files changed, 625 insertions(+), 216 deletions(-)
New commits:
commit 3057ee8ba01535324f57978569526988664eb53a
Author: homeboy445
AuthorDate: Tue Jun 22 16:54:34 2021 +0530
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 10 00:34:38 2021 +0200
Added support for viewing results in the VCL tests UI box
The user can now easily view the result of any VCL test
by just clicking on it - which would show them the resultant
bitmap of that corresponding test.
Change-Id: I57c0c2ab3662a9abec45ba7fc230c9299dcd9279
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117657
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 345f84b7f008..bc4f1e50c139 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -139,6 +139,7 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
cui/source/dialogs/postdlg \
cui/source/dialogs/QrCodeGenDialog \
cui/source/dialogs/GraphicTestsDialog \
+cui/source/dialogs/ImageViewerDialog \
cui/source/dialogs/scriptdlg \
cui/source/dialogs/SignatureLineDialogBase \
cui/source/dialogs/SignatureLineDialog \
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index 73da8e159f09..3af5d8e698e7 100644
--- a/cui/UIConfig_cui.mk
+++ b/cui/UIConfig_cui.mk
@@ -83,6 +83,8 @@ $(eval $(call gb_UIConfig_add_uifiles,cui,\
cui/uiconfig/ui/gallerytitledialog \
cui/uiconfig/ui/galleryupdateprogress \
cui/uiconfig/ui/graphictestdlg \
+ cui/uiconfig/ui/graphictestentry \
+ cui/uiconfig/ui/imageviewer \
cui/uiconfig/ui/hangulhanjaadddialog \
cui/uiconfig/ui/hangulhanjaeditdictdialog \
cui/uiconfig/ui/hangulhanjaconversiondialog \
diff --git a/cui/source/dialogs/GraphicTestsDialog.cxx
b/cui/source/dialogs/GraphicTestsDialog.cxx
index 275d33d75886..000129444cd5 100644
--- a/cui/source/dialogs/GraphicTestsDialog.cxx
+++ b/cui/source/dialogs/GraphicTestsDialog.cxx
@@ -8,48 +8,70 @@
*/
#include
+#include
+
+GraphicTestEntry::GraphicTestEntry(weld::Container* pParent, weld::Dialog*
pDialog,
+ OUString aTestName, OUString aTestStatus,
Bitmap aTestBitmap)
+: m_xBuilder(Application::CreateBuilder(pParent,
"cui/ui/graphictestentry.ui"))
+, m_xContainer(m_xBuilder->weld_container("gptestbox"))
+, m_xTestLabel(m_xBuilder->weld_label("gptestlabel"))
+, m_xTestButton(m_xBuilder->weld_button("gptestbutton"))
+, m_xResultBitmap(aTestBitmap)
+{
+m_xParentDialog = pDialog;
+m_xTestLabel->set_label(aTestName);
+m_xTestButton->set_label(aTestStatus);
+m_xTestButton->set_tooltip_text(aTestName);
+m_xTestButton->set_background(
+aTestStatus == "PASSED"
+? COL_LIGHTGREEN
+: aTestStatus == "QUIRKY" ? COL_YELLOW
+ : aTestStatus == "FAILED" ? COL_LIGHTRED
: COL_LIGHTGRAY);
+m_xTestButton->connect_clicked(LINK(this, GraphicTestEntry,
HandleResultViewRequest));
+m_xContainer->show();
+}
+
+IMPL_LINK(GraphicTestEntry, HandleResultViewRequest, weld::Button&, rButton,
void)
+{
+if (rButton.get_label() == "SKIPPED")
+{
+return;
+}
+ImageViewerDialog m_ImgVwDialog(m_xParentDialog, BitmapEx(m_xResultBitmap),
+rButton.get_tooltip_text());
+m_ImgVwDialog.run();
+}
GraphicsTestsDialog::GraphicsTestsDialog(weld::Window* pParent)
: GenericDialogController(pParent, "cui/ui/graphictestdlg.ui",
"GraphicTestsDialog")
-, m_xResultLog(m_xBuilder->weld_text_view("gptestresults"))
+, m_xResultLog(m_xBuilder->weld_text_view("gptest_txtVW"))
, m_xDownloadResults(m_xBuilder->weld_button("gptest_downld"))
+, m_xContainerBox(m_xBuilder->weld_box("gptest_box"))
{
-m_xResultLog->set_text("Running tests...");
m_xDownloadResults->connect_clicked(LINK(this, GraphicsTestsDialog,
HandleDownloadRequest));
-runGraphicsTestandUpdateLog();
}
-void GraphicsTestsDialog::runGraphicsTestandUpdateLog()
+short GraphicsTestsDialog::run()
{
-GraphicsRenderTests TestObject;
-TestObject.run();
-OUString atemp = "--General Info--\nGraphics Backend used : " +
TestObject.m_aCurGraphicsBackend
- + "\nPassed Tests : " +
OUString::number(TestObject.m_aPassed.size())
-
[Libreoffice-bugs] [Bug 143282] Wrong label "Border" for transparency limits
https://bugs.documentfoundation.org/show_bug.cgi?id=143282 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #2 from Regina Henschel --- The same problem is with color gradient and the same term should should be used. So I set this to duplicate although the positions of the string might be different. *** This bug has been marked as a duplicate of bug 101731 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101731] Rename gradient 'border' label to something more meaningful
https://bugs.documentfoundation.org/show_bug.cgi?id=101731 --- Comment #8 from Regina Henschel --- *** Bug 143282 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 101731] Rename gradient 'border' label to something more meaningful
https://bugs.documentfoundation.org/show_bug.cgi?id=101731 --- Comment #8 from Regina Henschel --- *** Bug 143282 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 101731] Rename gradient 'border' label to something more meaningful
https://bugs.documentfoundation.org/show_bug.cgi?id=101731 Regina Henschel changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #7 from Regina Henschel --- There is still no new wording. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 101731] Rename gradient 'border' label to something more meaningful
https://bugs.documentfoundation.org/show_bug.cgi?id=101731 Regina Henschel changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval --- Comment #7 from Regina Henschel --- There is still no new wording. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143282] Wrong label "Border" for transparency limits
https://bugs.documentfoundation.org/show_bug.cgi?id=143282 Julien Nabet changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org, ||serval2...@yahoo.fr, ||xiscofa...@libreoffice.org --- Comment #1 from Julien Nabet --- Xisco/Heiko: any thoughts here? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143269] FILESAVE DOCX saved file with chart cannot be opened by Word
https://bugs.documentfoundation.org/show_bug.cgi?id=143269 Regina Henschel changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/hints.hxx |9
sw/source/core/layout/tabfrm.cxx | 25 +++-
sw/source/core/table/swtable.cxx | 40 +--
3 files changed, 39 insertions(+), 35 deletions(-)
New commits:
commit 56d7965b6c24915359f39f45f1696c6f1dc3d3c9
Author: Bjoern Michaelsen
AuthorDate: Mon Jul 5 02:34:18 2021 +0200
Commit: Bjoern Michaelsen
CommitDate: Fri Jul 9 23:28:43 2021 +0200
Remove some iterator abuse
Change-Id: I9279a1729e1715ac44c600c930f50c6e8704e676
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118393
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/inc/hints.hxx b/sw/inc/hints.hxx
index 8f978d886c2a..afaf1d9022d9 100644
--- a/sw/inc/hints.hxx
+++ b/sw/inc/hints.hxx
@@ -34,6 +34,8 @@ class SwHistory;
class SwTextNode;
class SwTextFormatColl;
class SwFrameFormat;
+class SwTableBox;
+class SwTableBoxFormat;
class SwTableLine;
class SwTableLineFormat;
class SwTableBox;
@@ -179,6 +181,13 @@ public:
const SwTableLine& m_rTabLine;
TableLineFormatChanged(const SwTableLineFormat& rNewFormat, const
SwTableLine& rTabLine) : m_rNewFormat(rNewFormat), m_rTabLine(rTabLine) {};
};
+class TableBoxFormatChanged final : public SfxHint
+{
+public:
+const SwTableBoxFormat& m_rNewFormat;
+const SwTableBox& m_rTableBox;
+TableBoxFormatChanged(const SwTableBoxFormat& rNewFormat, const
SwTableBox& rTableBox) : m_rNewFormat(rNewFormat), m_rTableBox(rTableBox) {};
+};
}
class SwUpdateAttr final : public SwMsgPoolItem
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index c50f4d4873eb..36c5ba5faf1e 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -5459,7 +5459,30 @@ void SwCellFrame::Format( vcl::RenderContext*
/*pRenderContext*/, const SwBorder
void SwCellFrame::SwClientNotify(const SwModify& rMod, const SfxHint& rHint)
{
-if(auto pMoveTableBoxHint = dynamic_cast())
+if(auto pNewFormatHint = dynamic_cast())
+{
+if(GetTabBox() != >m_rTableBox)
+return;
+
RegisterToFormat(const_cast(pNewFormatHint->m_rNewFormat));
+InvalidateSize();
+InvalidatePrt_();
+SetCompletePaint();
+SetDerivedVert(false);
+CheckDirChange();
+
+// #i47489#
+// make sure that the row will be formatted, in order
+// to have the correct Get(Top|Bottom)MarginForLowers values
+// set at the row.
+const SwTabFrame* pTab = FindTabFrame();
+if(pTab && pTab->IsCollapsingBorders())
+{
+SwFrame* pRow = GetUpper();
+pRow->InvalidateSize_();
+pRow->InvalidatePrt_();
+}
+}
+else if(auto pMoveTableBoxHint = dynamic_cast())
{
if(GetTabBox() != >m_rTableBox)
return;
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index fe6a221daa0c..1da79f960545 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -1689,45 +1689,17 @@ SwFrameFormat* SwTableBox::ClaimFrameFormat()
return pRet;
}
-void SwTableBox::ChgFrameFormat( SwTableBoxFormat* pNewFormat, bool
bNeedToReregister )
+void SwTableBox::ChgFrameFormat(SwTableBoxFormat* pNewFormat, bool
bNeedToReregister)
{
-SwFrameFormat *pOld = GetFrameFormat();
-SwIterator aIter( *pOld );
-
+SwFrameFormat* pOld = GetFrameFormat();
// tdf#84635 We set bNeedToReregister=false to avoid a quadratic slowdown
on loading large tables,
// and since we are creating the table for the first time, no
re-registration is necessary.
-
// First, re-register the Frames.
-if (bNeedToReregister)
-for( SwCellFrame* pCell = aIter.First(); pCell; pCell = aIter.Next() )
-{
-if( pCell->GetTabBox() == this )
-{
-pCell->RegisterToFormat( *pNewFormat );
-pCell->InvalidateSize();
-pCell->InvalidatePrt_();
-pCell->SetCompletePaint();
-pCell->SetDerivedVert( false );
-pCell->CheckDirChange();
-
-// #i47489#
-// make sure that the row will be formatted, in order
-// to have the correct Get(Top|Bottom)MarginForLowers values
-// set at the row.
-const SwTabFrame* pTab = pCell->FindTabFrame();
-if ( pTab && pTab->IsCollapsingBorders() )
-{
-SwFrame* pRow = pCell->GetUpper();
-pRow->InvalidateSize_();
-pRow->InvalidatePrt_();
-}
-}
-}
-
+if(bNeedToReregister)
+pOld->CallSwClientNotify(sw::TableBoxFormatChanged(*pNewFormat,
*this));
// Now, re-register self.
-pNewFormat->Add( this );
-
-if( !pOld->HasWriterListeners() )
+pNewFormat->Add(this);
+
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/hints.hxx |9 +++
sw/source/core/layout/tabfrm.cxx | 29 -
sw/source/core/table/swtable.cxx | 44 ---
3 files changed, 42 insertions(+), 40 deletions(-)
New commits:
commit 0c8f364421014486c4e35a78a6dabca5b6a5dd26
Author: Bjoern Michaelsen
AuthorDate: Mon Jul 5 01:53:48 2021 +0200
Commit: Bjoern Michaelsen
CommitDate: Fri Jul 9 23:28:08 2021 +0200
remove some SwIterator abuse
Change-Id: Ic95562ebb57106c733d919059ff9d042fef28f3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118392
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/inc/hints.hxx b/sw/inc/hints.hxx
index e83d42251882..8f978d886c2a 100644
--- a/sw/inc/hints.hxx
+++ b/sw/inc/hints.hxx
@@ -35,6 +35,7 @@ class SwTextNode;
class SwTextFormatColl;
class SwFrameFormat;
class SwTableLine;
+class SwTableLineFormat;
class SwTableBox;
// Base class for all Message-Hints:
@@ -170,6 +171,14 @@ public:
class DocumentDyingHint final : public SfxHint
{
};
+
+class TableLineFormatChanged final : public SfxHint
+{
+public:
+const SwTableLineFormat& m_rNewFormat;
+const SwTableLine& m_rTabLine;
+TableLineFormatChanged(const SwTableLineFormat& rNewFormat, const
SwTableLine& rTabLine) : m_rNewFormat(rNewFormat), m_rTabLine(rTabLine) {};
+};
}
class SwUpdateAttr final : public SwMsgPoolItem
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index c54b24d59e3d..c50f4d4873eb 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -3919,7 +3919,34 @@ void SwRowFrame::OnFrameSize(const SfxPoolItem& rSize)
void SwRowFrame::SwClientNotify(const SwModify& rModify, const SfxHint& rHint)
{
-if(auto pMoveTableLineHint = dynamic_cast())
+if(auto pNewFormatHint = dynamic_cast())
+{
+if(GetTabLine() != >m_rTabLine)
+return;
+
RegisterToFormat(const_cast(pNewFormatHint->m_rNewFormat));
+InvalidateSize();
+InvalidatePrt_();
+SetCompletePaint();
+ReinitializeFrameSizeAttrFlags();
+
+// #i35063#
+// consider 'split row allowed' attribute
+SwTabFrame* pTab = FindTabFrame();
+bool bInFollowFlowRow = false;
+const bool bInFirstNonHeadlineRow = pTab->IsFollow() && this ==
pTab->GetFirstNonHeadlineRow();
+if(bInFirstNonHeadlineRow ||
+ !GetNext() ||
+ (bInFollowFlowRow = IsInFollowFlowRow()) ||
+ nullptr != IsInSplitTableRow() )
+{
+if(bInFirstNonHeadlineRow || bInFollowFlowRow)
+pTab = pTab->FindMaster();
+
+pTab->SetRemoveFollowFlowLinePending(true);
+pTab->InvalidatePos();
+}
+}
+else if(auto pMoveTableLineHint = dynamic_cast())
{
if(GetTabLine() != >m_rTableLine)
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index c2f3b3bd9764..fe6a221daa0c 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -1496,47 +1496,13 @@ SwFrameFormat* SwTableLine::ClaimFrameFormat()
return pRet;
}
-void SwTableLine::ChgFrameFormat( SwTableLineFormat *pNewFormat )
+void SwTableLine::ChgFrameFormat(SwTableLineFormat* pNewFormat)
{
-SwFrameFormat *pOld = GetFrameFormat();
-SwIterator aIter( *pOld );
-
-// First, re-register the Frames.
-for( SwRowFrame* pRow = aIter.First(); pRow; pRow = aIter.Next() )
-{
-if( pRow->GetTabLine() == this )
-{
-pRow->RegisterToFormat( *pNewFormat );
-
-pRow->InvalidateSize();
-pRow->InvalidatePrt_();
-pRow->SetCompletePaint();
-pRow->ReinitializeFrameSizeAttrFlags();
-
-// #i35063#
-// consider 'split row allowed' attribute
-SwTabFrame* pTab = pRow->FindTabFrame();
-bool bInFollowFlowRow = false;
-const bool bInFirstNonHeadlineRow = pTab->IsFollow() &&
-pRow ==
pTab->GetFirstNonHeadlineRow();
-if ( bInFirstNonHeadlineRow ||
- !pRow->GetNext() ||
- ( bInFollowFlowRow = pRow->IsInFollowFlowRow() ) ||
- nullptr != pRow->IsInSplitTableRow() )
-{
-if ( bInFirstNonHeadlineRow || bInFollowFlowRow )
-pTab = pTab->FindMaster();
-
-pTab->SetRemoveFollowFlowLinePending( true );
-pTab->InvalidatePos();
-}
-}
-}
-
+auto pOld = GetFrameFormat();
+pOld->CallSwClientNotify(sw::TableLineFormatChanged(*pNewFormat, *this));
// Now, re-register self.
-pNewFormat->Add( this );
-
-if ( !pOld->HasWriterListeners() )
+pNewFormat->Add(this);
+if(!pOld->HasWriterListeners())
delete pOld;
}
[Libreoffice-commits] core.git: sw/source
sw/source/core/inc/frmtool.hxx | 14 --
sw/source/core/layout/frmtool.cxx | 27 ++-
sw/source/core/layout/laycache.cxx |5 +
sw/source/core/layout/tabfrm.cxx | 21 -
sw/source/core/layout/wsfrm.cxx|8
5 files changed, 47 insertions(+), 28 deletions(-)
New commits:
commit debfdcfc0b2c07319e4a754decab18a292dc227c
Author: Bjoern Michaelsen
AuthorDate: Sun Jul 4 13:00:03 2021 +0200
Commit: Bjoern Michaelsen
CommitDate: Fri Jul 9 23:27:26 2021 +0200
remove global bDontCreateObjects bit
Wrapping this in a scope based helper is mostly lipstick on a pig, but
at least one cant forget toggling back this way. Apparently, this flag
was already toggled in recursive calls without checking previous state,
which is likely buggy.
In the long run, this should a/ never be used recursively or better b/
not be a global flag at all.
Change-Id: Id3554d2acb94d565611701c046ca4d8669594cea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118371
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen
diff --git a/sw/source/core/inc/frmtool.hxx b/sw/source/core/inc/frmtool.hxx
index 1974338f7936..4e328ca32af9 100644
--- a/sw/source/core/inc/frmtool.hxx
+++ b/sw/source/core/inc/frmtool.hxx
@@ -150,9 +150,6 @@ void MakeFrames( SwDoc *pDoc, const SwNodeIndex ,
extern bool bObjsDirect;
-// prevent creation of Flys in InsertCnt_, e.g. for table headlines
-extern bool bDontCreateObjects;
-
// for FlyCnts, see SwFlyAtContentFrame::MakeAll()
extern bool bSetCompletePaintOnInvalidate;
@@ -161,9 +158,14 @@ SwTwips CalcRowRstHeight( SwLayoutFrame *pRow );
tools::Long CalcHeightWithFlys( const SwFrame *pFrame );
namespace sw {
-
-bool IsRightPageByNumber(SwRootFrame const& rLayout, sal_uInt16 nPageNum);
-
+bool IsRightPageByNumber(SwRootFrame const& rLayout, sal_uInt16 nPageNum);
+class FlyCreationSuppressor
+{
+const bool m_wasAlreadySuppressed;
+public:
+FlyCreationSuppressor(bool isAlreadySuppressedAllowed = true);
+~FlyCreationSuppressor();
+};
} // namespace sw
SwPageFrame *InsertNewPage( SwPageDesc , SwFrame *pUpper,
diff --git a/sw/source/core/layout/frmtool.cxx
b/sw/source/core/layout/frmtool.cxx
index c50061bcf68e..59429f55ddf2 100644
--- a/sw/source/core/layout/frmtool.cxx
+++ b/sw/source/core/layout/frmtool.cxx
@@ -79,8 +79,25 @@
using namespace ::com::sun::star;
+namespace {
+// FIXME: would likely better be a member of SwRootFrame instead of a
global flag
+bool isFlyCreationSuppressed = false;
+}
+namespace sw {
+FlyCreationSuppressor::FlyCreationSuppressor(bool
wasAlreadySuppressedAllowed)
+: m_wasAlreadySuppressed(isFlyCreationSuppressed)
+{
+(void)wasAlreadySuppressedAllowed;
+assert(wasAlreadySuppressedAllowed || !isFlyCreationSuppressed);
+isFlyCreationSuppressed = true;
+}
+FlyCreationSuppressor::~FlyCreationSuppressor()
+{
+isFlyCreationSuppressed = m_wasAlreadySuppressed;
+}
+}
+
bool bObjsDirect = true;
-bool bDontCreateObjects = false;
bool bSetCompletePaintOnInvalidate = false;
sal_uInt8 StackHack::s_nCnt = 0;
@@ -1588,7 +1605,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
lcl_SetPos( *pFrame, *pLay );
pPrv = pFrame;
-if ( !pTable->empty() && bObjsDirect && !bDontCreateObjects )
+if ( !pTable->empty() && bObjsDirect && !isFlyCreationSuppressed )
AppendObjs( pTable, nIndex, pFrame, pPage, pDoc );
}
else if ( pNd->IsTableNode() )
@@ -1893,7 +1910,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
assert(false); // actually a fly-section can't be deleted?
continue; // skip it
}
-if ( !pTable->empty() && bObjsDirect && !bDontCreateObjects )
+if ( !pTable->empty() && bObjsDirect && !isFlyCreationSuppressed )
{
SwFlyFrame* pFly = pLay->FindFlyFrame();
if( pFly )
@@ -1922,7 +1939,7 @@ void InsertCnt_( SwLayoutFrame *pLay, SwDoc *pDoc,
if ( bPages ) // let the Flys connect to each other
{
-if ( !bDontCreateObjects )
+if ( !isFlyCreationSuppressed )
AppendAllObjs( pTable, pLayout );
bObjsDirect = true;
}
@@ -2110,7 +2127,7 @@ void MakeFrames( SwDoc *pDoc, const SwNodeIndex ,
nEndIdx, pPrv, eMode );
// OD 23.06.2003 #108784# - correction: append objects doesn't
// depend on value of
-if( !bDontCreateObjects )
+if( !isFlyCreationSuppressed )
{
const SwFrameFormats *pTable = pDoc->GetSpzFrameFormats();
if( !pTable->empty() )
diff --git a/sw/source/core/layout/laycache.cxx
[Libreoffice-bugs] [Bug 139388] Upgrade Dutch dictionary for spelling checker to version 2.20.21
https://bugs.documentfoundation.org/show_bug.cgi?id=139388 --- Comment #10 from Cor Nouws --- (In reply to Pander from comment #9) > Non-upgraded thesaurus cannot be added at this moment. It contains some > potentially offensive words or relations which we have to fix first. Thanks for your good work. But serious "potentially offensive words ..."that could be many, depending on changing cultural context, people's background, habits.. Of course it is your (teams) choice, but I would not take that too hard. Cheers - Cor -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 Bug 102593 depends on bug 65458, which changed state. Bug 65458 Summary: FORMATTING: Font information not transferred when copying/pasting text from Writer to Calc https://bugs.documentfoundation.org/show_bug.cgi?id=65458 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65458] FORMATTING: Font information not transferred when copying/pasting text from Writer to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=65458 Cor Nouws changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTABUG --- Comment #16 from Cor Nouws --- Work fine (now) in Version: 7.2.0.0.alpha1+ / LibreOffice Community Build ID: 162f5a20095c6937030d23ee03fb8f72c51eefa1 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: nl-NL (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-06_16:55:45 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126533] FILESAVE DOCX: bitmap background image not saved with document
https://bugs.documentfoundation.org/show_bug.cgi?id=126533 --- Comment #5 from Gerald Pfeifer --- I saw a related report by an openSUSE user. Their report does not require using a style, simply - right click - Page Style - Area - Bitmap and the same observations: completely lost with DOCX, stretched with DOC. (Cf. https://bugzilla.suse.com/show_bug.cgi?id=1133169 ) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143281] Crash in: ScColumn::SetPattern(long, ScPatternAttr const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=143281 --- Comment #2 from Julien Nabet --- Please respond on bugtracker instead of sending an email in private. Have in mind that an old version won't be fixed, eg there won't be a 7.0.4.3 version. If you reproduce this on 7.0.6, you'll have to try 7.1.4 since there won't be 7.0.7 according to https://wiki.documentfoundation.org/ReleasePlan/7.0. If you reproduce this on 7.1.4, it could be fixed for 7.1.5 or 7.1.6. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123321] FILEOPEN | DOC, missing longer line when saved in LO (shorter line remains)
https://bugs.documentfoundation.org/show_bug.cgi?id=123321 --- Comment #9 from Hossein --- The attachment 165080 consists of 3 vertical lines, overlapped (the overlap is not important). First one on the top with the length 0.17" Second one in the middle with the length of 1" Third one at the bottom with the length of 2.77" When you save it in LibreOffice and reload it, the first and the third vertical lines disappear, but if you select the second one (the only visible after save and reload), you can select the two other lines by pressing 'tab' button. If you look at the size of these two lines, you will see that both have the length of 0". The nice thing here is that if you load the file in MS Word and save it after a bit change, then LibreOffice loads it properly. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8scan.cxx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
New commits:
commit af2d477a30c197be5fbfa54022343f7a559b35cf
Author: Caolán McNamara
AuthorDate: Fri Jul 9 14:51:23 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jul 9 21:43:34 2021 +0200
ofz: OOM
these old ww7- font names are supposed to be limited to maxStrSize
Change-Id: Ide316a09d97d535b6cbc2911466df12f37e703cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118689
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 657cf60026c9..b8ea323e434d 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -7206,16 +7206,17 @@ namespace
return true;
}
-sal_Int32 getStringLength(
-sal_uInt8 const * p, std::size_t offset, sal_uInt8 const * pEnd)
+sal_Int32 getStringLengthWithMax(
+sal_uInt8 const * p, std::size_t offset, sal_uInt8 const * pEnd,
std::size_t maxchars)
{
assert(p <= pEnd);
assert(pEnd - p <= SAL_MAX_INT32);
if (offset >= o3tl::make_unsigned(pEnd - p)) {
return -1;
}
-void const * p2 = std::memchr(
-p + offset, 0, static_cast(pEnd - p) - offset);
+std::size_t nbytes = static_cast(pEnd - p) - offset;
+std::size_t nsearch = std::min(nbytes, maxchars + 1);
+void const * p2 = std::memchr(p + offset, 0, nsearch);
if (p2 == nullptr) {
return -1;
}
@@ -7315,7 +7316,7 @@ WW8Fonts::WW8Fonts( SvStream& rSt, WW8Fib const & rFib )
eEnc = RTL_TEXTENCODING_MS_1252;
const size_t nStringOffset = 1 + 2;
-sal_Int32 n = getStringLength(pVer2, nStringOffset, pEnd);
+sal_Int32 n = getStringLengthWithMax(pVer2, nStringOffset,
pEnd, maxStrSize);
if (n == -1) {
break;
}
@@ -7367,7 +7368,7 @@ WW8Fonts::WW8Fonts( SvStream& rSt, WW8Fib const & rFib )
if ((eEnc == RTL_TEXTENCODING_SYMBOL) || (eEnc ==
RTL_TEXTENCODING_DONTKNOW))
eEnc = RTL_TEXTENCODING_MS_1252;
const size_t nStringOffset = offsetof(WW8_FFN_Ver6, szFfn);
-sal_Int32 n = getStringLength(pVer6, nStringOffset, pEnd);
+sal_Int32 n = getStringLengthWithMax(pVer6, nStringOffset,
pEnd, maxStrSize);
if (n == -1) {
break;
}
@@ -7375,7 +7376,7 @@ WW8Fonts::WW8Fonts( SvStream& rSt, WW8Fib const & rFib )
if (p->aFFNBase.ibszAlt && p->aFFNBase.ibszAlt < maxStrSize)
//don't start after end of string
{
const size_t nAltStringOffset = offsetof(WW8_FFN_Ver6,
szFfn) + p->aFFNBase.ibszAlt;
-n = getStringLength(pVer6, nAltStringOffset, pEnd);
+n = getStringLengthWithMax(pVer6, nAltStringOffset, pEnd,
maxStrSize);
if (n == -1) {
break;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 137869] Crash after undo they modifications made by track & changes (document comparison)
https://bugs.documentfoundation.org/show_bug.cgi?id=137869 Terrence Enger changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords|bibisectRequest |bibisected, bisected Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137869] Crash after undo they modifications made by track & changes (document comparison)
https://bugs.documentfoundation.org/show_bug.cgi?id=137869
--- Comment #12 from Terrence Enger ---
Created attachment 173479
--> https://bugs.documentfoundation.org/attachment.cgi?id=173479=edit
bibisect in linux-64-6.1, tail of terminal output
Working in bibisect-linux-64-6.1 on debian buster, I see:
commits-h date
---
good e3c3da3d 6aa9f098 2019-01-15 17:13:04
bad 8e8eab51 736a3841 2019-01-15 18:01:57
and commit message starting :
commit 736a38419f49d4b96bd845f5767a028df59e4cff
Author: Serge Krot
AuthorDate: Thu Dec 6 19:11:58 2018 +0100
Commit: Michael Stahl
CommitDate: Tue Jan 15 19:01:57 2019 +0100
sw: DOCX: recognize TOC title during import
I am removing keyword bibsectRequest and add keywords bibisected,
bisected.
--
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/uitest/uiobject.cxx | 16
1 file changed, 8 insertions(+), 8 deletions(-)
New commits:
commit 43f17336db888bd5d4671325e679dc12e693b1d0
Author: Caolán McNamara
AuthorDate: Fri Jul 9 15:53:35 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jul 9 21:00:07 2021 +0200
split out duplicated condition and test it once
Change-Id: I6b64ffc85123600046355cd5c4c8830f0d8e44c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118695
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index 14ff3f5d7690..fe9791c83aba 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -411,16 +411,16 @@ vcl::Window* findChild(vcl::Window* pParent, const
OUString& rID, bool bRequireV
for (size_t i = 0; i < nCount; ++i)
{
vcl::Window* pChild = pParent->GetChild(i);
-if (pChild->get_id() == rID
-&& (!bRequireVisible || pChild->IsVisible()))
+bool bCandidate = !bRequireVisible || pChild->IsVisible();
+if (!bCandidate)
+continue;
+
+if (pChild->get_id() == rID)
return pChild;
-if (!bRequireVisible || pChild->IsVisible())
-{
-vcl::Window* pResult = findChild(pChild, rID);
-if (pResult)
-return pResult;
-}
+vcl::Window* pResult = findChild(pChild, rID);
+if (pResult)
+return pResult;
}
return nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
New commits:
commit e875df09fc230639455a7084919bacd81c18c61e
Author: Caolán McNamara
AuthorDate: Fri Jul 9 16:35:02 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jul 9 20:58:35 2021 +0200
gtk4: use m_bPopupActive rather than repeatedly call
toggle_button_get_active
Change-Id: Ia6b2df875da5af6bfb2198df503d59f34a762262
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118697
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 47be0fd7ed25..1ee5072aed7f 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17482,7 +17482,7 @@ private:
void fire_signal_changed()
{
m_bUserSelectEntry = true;
-m_bChangedByMenu = toggle_button_get_active();
+m_bChangedByMenu = m_bPopupActive;
signal_changed();
m_bChangedByMenu = false;
}
@@ -17545,7 +17545,7 @@ private:
void menu_toggled()
{
-if (!toggle_button_get_active())
+if (!m_bPopupActive)
{
#if 0
if (m_bHoverSelection)
@@ -17584,12 +17584,13 @@ private:
{
m_aQuickSelectionEngine.Reset();
+bool bOldPopupActive = m_bPopupActive;
+m_bPopupActive = toggle_button_get_active();
+
menu_toggled();
-bool bIsShown = toggle_button_get_active();
-if (m_bPopupActive != bIsShown)
+if (bOldPopupActive != m_bPopupActive)
{
-m_bPopupActive = bIsShown;
ComboBox::signal_popup_toggled();
// restore focus to the GtkEntry when the popup is gone, which
// is what the vcl case does, to ease the transition a little,
commit 8c9588cceaad5a9155c8d22a44a2e7dc54a56aa0
Author: Caolán McNamara
AuthorDate: Fri Jul 9 16:26:12 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jul 9 20:58:20 2021 +0200
gtk[3|4] rename toggle_menu -> menu_toggled
Change-Id: Ieee73ae5ccfe625e2aedb9c44521e1c9222be6d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118696
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index cd61f4e683d2..47be0fd7ed25 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -9496,12 +9496,12 @@ private:
{
GtkInstanceMenuButton* pThis =
static_cast(widget);
SolarMutexGuard aGuard;
-pThis->toggle_menu();
+pThis->menu_toggled();
}
#endif
#if !GTK_CHECK_VERSION(4, 0, 0)
-void toggle_menu()
+void menu_toggled()
{
if (!m_pMenuHack)
return;
@@ -17543,7 +17543,7 @@ private:
return g_value_get_boolean();
}
-void toggle_menu()
+void menu_toggled()
{
if (!toggle_button_get_active())
{
@@ -17584,7 +17584,7 @@ private:
{
m_aQuickSelectionEngine.Reset();
-toggle_menu();
+menu_toggled();
bool bIsShown = toggle_button_get_active();
if (m_bPopupActive != bIsShown)
@@ -19268,7 +19268,7 @@ private:
return nHeight;
}
-void toggle_menu()
+void menu_toggled()
{
if (!gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(m_pToggleButton)))
{
@@ -19328,7 +19328,7 @@ private:
{
m_aQuickSelectionEngine.Reset();
-toggle_menu();
+menu_toggled();
bool bIsShown =
gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(m_pToggleButton));
if (m_bPopupActive != bIsShown)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit caae3b77b23c382f58c1b0dd47ce8ed5d4ccad3b
Author: Caolán McNamara
AuthorDate: Fri Jul 9 16:21:37 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Jul 9 20:57:29 2021 +0200
gtk4: disregard insert-text signal if it happens while the popup is shown
otherwise we lose our selection
Change-Id: I2be572262528e9bcd12fcb0bc35bf9094f91b990
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118694
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index cd3fd1b5bc84..cd61f4e683d2 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17445,6 +17445,9 @@ private:
void signal_entry_insert_text(GtkEntry* pEntry, const gchar* pNewText,
gint nNewTextLength, gint* position)
{
+if (m_bPopupActive) // not entered by the user
+return;
+
// first filter inserted text
if (m_aEntryInsertTextHdl.IsSet())
{
@@ -17459,6 +17462,7 @@ private:
}
g_signal_stop_emission_by_name(pEntry, "insert-text");
}
+
if (m_bAutoComplete)
{
// now check for autocompletes
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96980] Border width can only be entered in pt units
https://bugs.documentfoundation.org/show_bug.cgi?id=96980 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3249 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||980 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||980 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 51665] Support diagonal borders in TABLEs
https://bugs.documentfoundation.org/show_bug.cgi?id=51665 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3249 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=51 ||665 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=51 ||665 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 118158] in high contrast mode the preview of table borders shows no colors
https://bugs.documentfoundation.org/show_bug.cgi?id=118158 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3249 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8158 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||8158 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 54266] UI: Table border tool (dialog Table, tab Border) too easily picks two borders near conjunction
https://bugs.documentfoundation.org/show_bug.cgi?id=54266 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3249 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 54266] UI: Table border tool (dialog Table, tab Border) too easily picks two borders near conjunction
https://bugs.documentfoundation.org/show_bug.cgi?id=54266 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3249 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=54 ||266 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=54 ||266 -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 139837] The area to select the inner border is to small (or the dialog)
https://bugs.documentfoundation.org/show_bug.cgi?id=139837 Telesto changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #9 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #12 from Telesto --- *** Bug 139837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #12 from Telesto --- *** Bug 139837 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137869] Crash after undo they modifications made by track & changes (document comparison)
https://bugs.documentfoundation.org/show_bug.cgi?id=137869 --- Comment #11 from Terrence Enger --- Created attachment 173478 --> https://bugs.documentfoundation.org/attachment.cgi?id=173478=edit backtrace on linux The interesting part of the backtrace starts at frame #18, where idx==778, m_nSize==778. In a local --enable-debug --enable-dbgutil build of commit d95e400b (2021-06-18), built and running on debian-buster, using the STR from the bug description, I see a crash in step 5 after the second +Z. Final terminal messages are (rewrapped): warn:legacy.osl:22417:22417:sw/source/core/access/acccontext.cxx:445: fire event for disposed frame? warn:legacy.osl:22417:22417:sw/source/core/layout/anchoredobject.cxx:569: - cache for object rectangle inclusive spaces marked as valid, but it couldn't be. Missing invalidation of cache. warn:sw.core:22417:22417:sw/source/core/docnode/node.cxx:1980: Wrong cond collection, skipping check of Cond Colls. warn:sw.core:22417:22417:sw/source/core/docnode/node.cxx:1980: Wrong cond collection, skipping check of Cond Colls. warn:legacy.osl:22417:22417:sw/source/core/access/acccontext.cxx:445: fire event for disposed frame? warn:legacy.osl:22417:22417:sw/source/core/access/acccontext.cxx:445: fire event for disposed frame? soffice.bin: /home/terry/lo_hacking/git/libo6/sw/source/core/bastyp/bparr.cxx:84: BigPtrEntry* BigPtrArray::operator[](sal_uLong) const: Assertion `idx < m_nSize' failed. Unspecified Application Error I am setting status NEW. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #11 from Telesto --- *** Bug 139838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139838] The behavior of the border picker is sometimes off
https://bugs.documentfoundation.org/show_bug.cgi?id=139838 Telesto changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #11 from Telesto --- *** Bug 139838 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #10 from Telesto --- *** Bug 143252 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143252] UI: Change in table border color is directly applied to selected border (should be disconnected)
https://bugs.documentfoundation.org/show_bug.cgi?id=143252 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #10 from Telesto --- *** Bug 143252 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 143252] UI: Change in table border color is directly applied to selected border (should be disconnected)
https://bugs.documentfoundation.org/show_bug.cgi?id=143252 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 113088] [META] Writer table properties dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113088 Bug 113088 depends on bug 106044, which changed state. Bug 106044 Summary: EDITING: The table borders dialog doesn't preview/show the top border of the selected table row https://bugs.documentfoundation.org/show_bug.cgi?id=106044 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #9 from Telesto --- *** Bug 106044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #9 from Telesto --- *** Bug 106044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 106044] EDITING: The table borders dialog doesn't preview/show the top border of the selected table row
https://bugs.documentfoundation.org/show_bug.cgi?id=106044 Telesto changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Bug 103100 depends on bug 107675, which changed state. Bug 107675 Summary: EDITING: Partially removing the border formatting of table row isn't working (steps to reproduce in comment 3) https://bugs.documentfoundation.org/show_bug.cgi?id=107675 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #8 from Telesto --- *** Bug 107675 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107675] EDITING: Partially removing the border formatting of table row isn't working (steps to reproduce in comment 3)
https://bugs.documentfoundation.org/show_bug.cgi?id=107675 Telesto changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #8 from Telesto --- *** Bug 107675 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added Summary|UI: Buttons to toggle |UI: Improve handling of |border lines on/off in |configuring table borders |table properties border |in table properties dialog |dialog |(to make it work for ||multiple workflows) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Improve handling of configuring table borders in table properties dialog (to make it work for multiple workflows)
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 Telesto changed: What|Removed |Added Summary|UI: Buttons to toggle |UI: Improve handling of |border lines on/off in |configuring table borders |table properties border |in table properties dialog |dialog |(to make it work for ||multiple workflows) -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 35287] feature request: smooth scroll
https://bugs.documentfoundation.org/show_bug.cgi?id=35287 --- Comment #42 from gust...@angulosolido.pt --- In my experience (Kubuntu 20.04) Libreoffice always scrolls vertically by 3 cells which is OK when the cells are not tall but makes it very hard to work if the cells are tall. It probably needs to scroll based on nr of pixels not on number of cells. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143249] UI: Buttons to toggle border lines on/off in table properties border dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #7 from Telesto --- *** Bug 143251 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143251] UI: The table properties table border tool is counter-intuitive (lacking feedback)
https://bugs.documentfoundation.org/show_bug.cgi?id=143251 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143250] UI: Make all borders being selected if a part of the table is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=143250 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143249] UI: Buttons to toggle border lines on/off in table properties border dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=143249 --- Comment #7 from Telesto --- *** Bug 143251 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-ux-advise] [Bug 143251] UI: The table properties table border tool is counter-intuitive (lacking feedback)
https://bugs.documentfoundation.org/show_bug.cgi?id=143251 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Telesto --- *** This bug has been marked as a duplicate of bug 143249 *** -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
