[Libreoffice-bugs] [Bug 140910] Blank XLSX file generated with OpenXML SDK
https://bugs.documentfoundation.org/show_bug.cgi?id=140910 himajin100...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||1575 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 131575] FILEOPEN: LO can't open generated XLSX (without docsProps) that MSO opens - opens if [content_types].xml caps changed
https://bugs.documentfoundation.org/show_bug.cgi?id=131575 himajin100...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0910 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98114] Printing does not honor the orientation in page properties in Linux/Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=98114 adamdekker changed: What|Removed |Added URL||https://www.canonijetsetup. ||com/ --- Comment #54 from adamdekker --- We had this "portrait printing in landscape" problem using OSX but it was resolved with an update some time ago. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104597] Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 --- Comment #61 from Kevin Suo --- The failing to concatenate "Tim" and "e" may due to the issue as discussed here: https://gitlab.freedesktop.org/poppler/poppler/-/issues/418 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120883] [META] Hyphenation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120883 Ming Hua changed: What|Removed |Added Depends on||143422 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143422 [Bug 143422] "Missing hyphenation data" is displayed in info bar in Japanese documents -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143422] "Missing hyphenation data" is displayed in info bar in Japanese documents
https://bugs.documentfoundation.org/show_bug.cgi?id=143422 Ming Hua changed: What|Removed |Added CC||so...@libreoffice.org Blocks||120883 Version|7.2.0.1 rc |7.0.6.2 release Component|Writer |Linguistic Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120883 [Bug 120883] [META] Hyphenation bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143422] "Missing hyphenation data" is displayed in info bar in Japanese documents
https://bugs.documentfoundation.org/show_bug.cgi?id=143422 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2396 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Ming Hua --- (In reply to Jun Nogata from comment #3) > (In reply to Ming Hua from comment #2) > > But why would you want to do this for Japanese text? It seems it's disabled > > by default, at least for me with zh-CN locale (which also doesn't have > > hyphenation). > > Hyphenation is not necessary for Japanese. However, when English and > Japanese are mixed, it is required for English. Fair enough. Reproduced also from empty document using steps in commen #0. Setting to NEW. I previously thought that bug 132396 is due to non-MS software creating ambiguous "zh" language tag in the documents, now I see that LibreOffice can also create ODT documents with the same problem. Some additional details: For mixed English and Chinese/Japanese text, this only happens when there are consecutive C/J characters across a line break (i.e., the first line ends with C/J characters, the next line also starts with C/J characters). For mostly English list text with only a few C/J words that don't cross lines, there is no warning infobar. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 132396] "Missing hyphenation info" pop-up banner displayed for Chinese which has no concept of hyphenation
https://bugs.documentfoundation.org/show_bug.cgi?id=132396 Ming Hua changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3422 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143417] Shift + Click doesn't work to select image object
https://bugs.documentfoundation.org/show_bug.cgi?id=143417 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote --- Seems a dupe of bug 122179 which is NAB; images on Writer canvas (SVM or BMP) held in Frames are simply not multi-selectable... -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143159] Box too short
https://bugs.documentfoundation.org/show_bug.cgi?id=143159 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143313] FILEOPEN Large PDF's take too long to load in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=143313 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143314] FILEOPEN LibreOffice draw asks for PDF password, but PDF is not protected by password
https://bugs.documentfoundation.org/show_bug.cgi?id=143314 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143313] FILEOPEN Large PDF's take too long to load in LibreOffice Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=143313 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143314] FILEOPEN LibreOffice draw asks for PDF password, but PDF is not protected by password
https://bugs.documentfoundation.org/show_bug.cgi?id=143314 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 98063] EDITING read-only mode allows cut and paste with mouse in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=98063 --- Comment #9 from QA Administrators --- Dear Ryan Hankins, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 139137] macOS Catalina 10.15.7 VoiceControl feature causes LibreOffice (at least Calc) to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=139137 --- Comment #14 from QA Administrators --- Dear rtpbs20, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68703] EDITING: Selecting the cells with keyboard is broken if the cell one starts from is already selected after Paste
https://bugs.documentfoundation.org/show_bug.cgi?id=68703 --- Comment #11 from QA Administrators --- Dear Mikko Vedru, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 118695] Table number recognition not immediately disabled for cells where replacing took place previously
https://bugs.documentfoundation.org/show_bug.cgi?id=118695 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126454] MS Office Word 'Toggle Numbered List' start with 0 , but in LibreOffice it became from 1
https://bugs.documentfoundation.org/show_bug.cgi?id=126454 --- Comment #4 from QA Administrators --- Dear xyli9, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123819] ScVbaCommandBars is inconsistent, and other issues with it in a COLEAT context
https://bugs.documentfoundation.org/show_bug.cgi?id=123819 --- Comment #8 from QA Administrators --- Dear Tor Lillqvist, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 105579] After certain actions comments in Calc point to the wrong cell
https://bugs.documentfoundation.org/show_bug.cgi?id=105579 --- Comment #15 from QA Administrators --- Dear Aron Budea, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143415] Sheet navigation right click needs two clicks to close (Windows-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=143415 --- Comment #2 from Jaise James --- Tested in windows only. Earlier I am using 7.0.4. There was no issue. Now I change to 7.2 rc1 for testing bugs. I use this navigation method to link formula. Now two click required to link a last sheet[say 35th sheet] cell to formula. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 104597] Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving
https://bugs.documentfoundation.org/show_bug.cgi?id=104597 --- Comment #60 from Kevin Suo --- (In reply to Armin Le Grand from comment #59) Thank you for your suggested patch. I checked, but it does not work for some chars. For instance: On The current master there is a test file named "testFontFeatures.pdf" in sdext/source/pdfimport/test/testdocs. This file is used in the CppunitTest_sdext_pdfimport (test case file is in sdext/source/pdfimport/test/tests.cxx, the test name is testFontFeatures). If you run 'make CppunitTest_sdext_pdfimport', you can see the output in workdir/CppunitTest/sdext_pdfimport.test.log. >From the log, you can see in line 384 that, for the line "Times New Roman Normal" as shown in the PDF, the chars "Tim" are concatenated, but "e" and "s" (as in "Times" are not; the chars "Ne" (as in "New) are concatenated, but "w" is not. (please note that in the log file the concatenated "Tim" are shown in three different lines because there is another problem in the code which added new-line characters in the output, but this does not have impact on this RTL bug, thus can be addressed separately) Also, from the log file you can also see from line 691 that all those Chinese characters are not concatenated. Could you please take a look and revise your patch? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119942] Mail Merge contains wrong body: data sent is off by one (wrong record index in merged result)
https://bugs.documentfoundation.org/show_bug.cgi?id=119942 --- Comment #11 from Kevin Suo --- Currently there is no one working on this. Yes, of course you can try to fix this by yourself. You can search the code on https://opengrok.libreoffice.org/, then set breakpoints to where you are interested, then it will not be difficult to find the reason, if you know some cpp. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 119942] Mail Merge contains wrong body: data sent is off by one (wrong record index in merged result)
https://bugs.documentfoundation.org/show_bug.cgi?id=119942 --- Comment #10 from marjan --- @Kevin Suo : Thank you for your effectively minimized error report. I am suffering the same bug for many years. In good old days this used to work. I am very sad that we don't have enough resources to kill this bug: Mail Merge fields in an array of an odt- document. I have always used a header of all my letters with the 2x2 table with specific dimension to fit the envelope with the transparent "address-window". I am suffering this bug for years. I am forced to write a bash script each time I make a significantly different Mail-Merge document to cut resulting one-PDF to individual letters, where I am forced to keep all copies of the same number of pages, ... Unfortunately, I am a "complete newbie" in LibreOffice source code, but if I could get enough support, I might be able attack this bug myself or preferably in a group of co-sufferers. @documentfoundation.org: Assignee: Not Assigned, really? Kevin Suo , thanks again that I do not have to repeat the report, just quote it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143135] Impress crashes when switching to another application then back
https://bugs.documentfoundation.org/show_bug.cgi?id=143135 --- Comment #3 from JimR --- (In reply to Buovjaga from comment #1) > Does it also happen if you launch from the command line with > > SAL_USE_VCLPLUGIN=gtk3 libreoffice No, it does not happen when starting with this option -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142973] English texts in start center in German LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=142973 Julien Nabet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr |desktop.org | --- Comment #6 from Julien Nabet --- I gave a try with https://gerrit.libreoffice.org/c/core/+/119117 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 --- Comment #7 from adam.m.fontenot+do...@gmail.com --- (In reply to Ming Hua from comment #3) > I don't know much about text rendering so all I can add is a screenshot with > 7.2.0 Beta1 on Windows 10, showing similar differences with or without pair > kerning. Thanks for your effort to get this looked at. The issue with using Windows as a comparison is that by default Windows hints so strongly that much of the subpixel nuance is lost anyway. I actually find the screenshot you posted very difficult to read because of the amount of distortion to the glyph shapes. IIRC, the developers of Microsoft Word agree with me, and they actually wrote their own text rendering engine for Word so that they don't have to use ClearType. (It's been a long time since I looked at anything Windows related, I could be misremembering.) (In reply to V Stuart Foote from comment #5) > Cross platform we went to harfbuzz at 5.3.0.3; any improvement to sub-pixel > rendereing needed to improve font provided hinting for kerning will only > come with resolution of bug 103322 This was indeed what I was worried about. My thinking, though, is that this bug shouldn't depend on that one. If LibreOffice doesn't support rendering at arbitrary subpixel offsets, then pair kerning (which depends heavily on being able to render at precise offsets) is sort of useless / broken. As far as I can tell, in LibreOffice's present state, pair kerning is effectively adding or subtracting a small random value from the desired glyph offset, which then gets rounded by the renderer into whole pixels. It's really not surprising that the result is frequently worse than no pair kerning at all. For that reason, it seems to make sense to consider disabling it until bug 103322 is fixed. Can anyone show that having it enabled confers any definite advantage to font rendering under Linux at present? My screenshots of LibreOffice's rendering would seem to suggest that the results of having it enabled are uniformly worse. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 142940] Enabling pair kerning breaks rendering of many common fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=142940 --- Comment #7 from adam.m.fontenot+do...@gmail.com --- (In reply to Ming Hua from comment #3) > I don't know much about text rendering so all I can add is a screenshot with > 7.2.0 Beta1 on Windows 10, showing similar differences with or without pair > kerning. Thanks for your effort to get this looked at. The issue with using Windows as a comparison is that by default Windows hints so strongly that much of the subpixel nuance is lost anyway. I actually find the screenshot you posted very difficult to read because of the amount of distortion to the glyph shapes. IIRC, the developers of Microsoft Word agree with me, and they actually wrote their own text rendering engine for Word so that they don't have to use ClearType. (It's been a long time since I looked at anything Windows related, I could be misremembering.) (In reply to V Stuart Foote from comment #5) > Cross platform we went to harfbuzz at 5.3.0.3; any improvement to sub-pixel > rendereing needed to improve font provided hinting for kerning will only > come with resolution of bug 103322 This was indeed what I was worried about. My thinking, though, is that this bug shouldn't depend on that one. If LibreOffice doesn't support rendering at arbitrary subpixel offsets, then pair kerning (which depends heavily on being able to render at precise offsets) is sort of useless / broken. As far as I can tell, in LibreOffice's present state, pair kerning is effectively adding or subtracting a small random value from the desired glyph offset, which then gets rounded by the renderer into whole pixels. It's really not surprising that the result is frequently worse than no pair kerning at all. For that reason, it seems to make sense to consider disabling it until bug 103322 is fixed. Can anyone show that having it enabled confers any definite advantage to font rendering under Linux at present? My screenshots of LibreOffice's rendering would seem to suggest that the results of having it enabled are uniformly worse. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 122966] FILESAVE DOCX Shape positioned incorrectly after RT (see comment 15)
https://bugs.documentfoundation.org/show_bug.cgi?id=122966 Hossein changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |hoss...@libreoffice.org |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33201] UI: Highlight (not select) current row and column in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=33201 --- Comment #45 from Eike Rathke --- (In reply to Heiko Tietze from comment #42) > Sounds like a good enhancement. We should make it optional in both on/off > and color. Tools > Options > Calc > View: "[x] Highlight col/row " > (default color ideally taken from the system theme). Marked selection is already blue, so that should be something different. > shortcut. Perhaps alt+space No, because Alt+Space opens the window menu in at least GNOME and other window managers. (In reply to Heiko Tietze from comment #44) > Was looking into the code but it seems to be a tricky thing. We could use > either ScOutputData::DrawBackground() or ScOutputData::DrawGrid() Anything ScOutputData would be wrong because it's not related to data at all, nor styles. It also wouldn't be a background. Take a look at ScTabView::MarkRows() and ScTabView::MarkColumns(), which are called for .uno:SelectRow and .uno:SelectColumn, it would be almost the same (without the actual mark and selection of course) and should be a HighlightOverlay added to the OverlayManager, similar to the SelectionOverlay that is updated from InitBlockMode() as ScGridWindow::UpdateSelectionOverlay(), e.g. like UpdateHighlightOverlay() and so on. They could share a great portion of code. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143425] New: Comments in Calc.
https://bugs.documentfoundation.org/show_bug.cgi?id=143425 Bug ID: 143425 Summary: Comments in Calc. Product: LibreOffice Version: 7.1.4.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pcpr...@ymail.com Description: I've noticed that when creating a comment in Calc from within one of the cells, it displays the red dot(which shows that there is a comment in that cell) right on top of the last digit or letter displayed in that cell, which in turn prevents you from seeing the full text. Not complaining, just thought I would bring it to the attention of those involved in maintaining this awesome program. Steps to Reproduce: 1.Write anything inside of any cell. 2.Create a comment. 3.Click enter or on another cell. Actual Results: Red dot is displayed on top of the last digit or letter making it difficult to know that is fully displayed. Expected Results: Red dot displayed slightly to the right of the last digit or letter. Reproducible: Always User Profile Reset: No Additional Info: [Information automatically included from LibreOffice] Locale: en-US Module: SpreadsheetDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: no -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 121786] LO Draw: Empty .htm page if to Preview draw document in Web browser
https://bugs.documentfoundation.org/show_bug.cgi?id=121786 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||3620 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 117084] Preview in Web browser displays mangled document
https://bugs.documentfoundation.org/show_bug.cgi?id=117084 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||3620 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 113620] Conversion of Draw documents to html fails with command line.
https://bugs.documentfoundation.org/show_bug.cgi?id=113620 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||7084, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||1786 CC||ba...@caesar.elte.hu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 129204] Impress File rendered only white
https://bugs.documentfoundation.org/show_bug.cgi?id=129204 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Status|NEW |NEEDINFO --- Comment #7 from Aron Budea --- Let's wait for an answer from Jean-Sebastien. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 123983] Read Error if embedded images are not into the Pictures directory
https://bugs.documentfoundation.org/show_bug.cgi?id=123983 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Summary|REad Error if embedded |Read Error if embedded |images are not into the |images are not into the |Pictures directory |Pictures directory -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74124] Pictures in Writer look ugly on the screen
https://bugs.documentfoundation.org/show_bug.cgi?id=74124 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||7409 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 107409] FILESAVE DOC: Formula's seem to be (badly) rendered EMF+ images
https://bugs.documentfoundation.org/show_bug.cgi?id=107409 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=74 ||124 CC||ba...@caesar.elte.hu -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: svtools/uiconfig
svtools/uiconfig/ui/thineditcontrol.ui |3 +++ 1 file changed, 3 insertions(+) New commits: commit e6597ab3db99b70ea35ab071bc8634db63890224 Author: Caolán McNamara AuthorDate: Fri Jul 16 17:16:14 2021 +0100 Commit: Caolán McNamara CommitDate: Sat Jul 17 22:37:56 2021 +0200 make calendar button small-button style so it fits in limited height Change-Id: I1997ae2a3916372ded3d4120e4510144c6700777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119081 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svtools/uiconfig/ui/thineditcontrol.ui b/svtools/uiconfig/ui/thineditcontrol.ui index ba32ab7cc5ce..e2258743f381 100644 --- a/svtools/uiconfig/ui/thineditcontrol.ui +++ b/svtools/uiconfig/ui/thineditcontrol.ui @@ -69,6 +69,9 @@ Pick Date + ++ 1 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: nlpsolver/src nlpsolver/ThirdParty
nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java | 33 +++--- nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java |4 - 2 files changed, 14 insertions(+), 23 deletions(-) New commits: commit 7b93bae224c7c2c49b105ef97304bb46f8b68da5 Author: Todor Balabanov AuthorDate: Sat Jul 17 18:27:27 2021 +0300 Commit: Noel Grandin CommitDate: Sat Jul 17 22:22:17 2021 +0200 Some lower objects coupling. Change-Id: I0a7c658d830f82d627d20b9ed7000f3c5b8f1f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119105 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java b/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java index b3e5f310031f..7a6077a725c4 100644 --- a/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java +++ b/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java @@ -38,7 +38,6 @@ import net.adaptivebox.deps.behavior.PSGTBehavior; import net.adaptivebox.global.RandomGenerator; import net.adaptivebox.goodness.IGoodnessCompareEngine; import net.adaptivebox.knowledge.ILibEngine; -import net.adaptivebox.knowledge.Library; import net.adaptivebox.knowledge.SearchPoint; import net.adaptivebox.problem.ProblemEncoder; import net.adaptivebox.space.BasicPoint; @@ -72,31 +71,21 @@ public class DEPSAgent implements ILibEngine { private double switchP = 0.5; - public DEPSAgent(ProblemEncoder encoder, DEGTBehavior deGTBehavior, PSGTBehavior psGTBehavior, double switchP, IGoodnessCompareEngine comparer, Library lib) { - setProblemEncoder(encoder); - - this.switchP = switchP; - - deGTBehavior.setLibrary(lib); - psGTBehavior.setLibrary(lib); - setGTBehavior(deGTBehavior); - setGTBehavior(psGTBehavior); - this.deGTBehavior = deGTBehavior; - this.psGTBehavior = psGTBehavior; - - qualityComparator = comparer; - } - - public void setLibrary(Library lib) { -deGTBehavior.setLibrary(lib); -psGTBehavior.setLibrary(lib); - } - - public void setProblemEncoder(ProblemEncoder encoder) { + public DEPSAgent(ProblemEncoder encoder, DEGTBehavior deGTBehavior, PSGTBehavior psGTBehavior, double switchP, IGoodnessCompareEngine comparer) { problemEncoder = encoder; + trailPoint = problemEncoder.getFreshSearchPoint(); pold_t = problemEncoder.getFreshSearchPoint(); pcurrent_t = problemEncoder.getFreshSearchPoint(); + +this.switchP = switchP; + +setGTBehavior(deGTBehavior); +setGTBehavior(psGTBehavior); +this.deGTBehavior = deGTBehavior; +this.psGTBehavior = psGTBehavior; + +qualityComparator = comparer; } public void setSpecComparator(IGoodnessCompareEngine comparer) { diff --git a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java index 20cf9286e91a..edba08936d39 100644 --- a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java +++ b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java @@ -131,14 +131,16 @@ public final class DEPSSolverImpl extends BaseEvolutionarySolver deGTBehavior.MIN_FACTOR = Math.min(m_minFactor.getValue(), m_maxFactor.getValue()); deGTBehavior.MAX_FACTOR = Math.max(m_minFactor.getValue(), m_maxFactor.getValue()); deGTBehavior.CR = m_CR.getValue(); +deGTBehavior.setLibrary(m_library); PSGTBehavior psGTBehavior = new PSGTBehavior(); psGTBehavior.c1 = m_c1.getValue(); psGTBehavior.c2 = m_c2.getValue(); psGTBehavior.CL = m_CL.getValue(); psGTBehavior.weight = m_weight.getValue(); +psGTBehavior.setLibrary(m_library); -agents[i] = new DEPSAgent(m_problemEncoder, deGTBehavior, psGTBehavior, m_agentSwitchRate.getValue(), m_specCompareEngine, m_library); +agents[i] = new DEPSAgent(m_problemEncoder, deGTBehavior, psGTBehavior, m_agentSwitchRate.getValue(), m_specCompareEngine); agents[i].setPbest(m_library.getSelectedPoint(i)); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/streaming/seqoutputstreamserv.cxx | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit 5be9e0760ed74906c27b484e0d3235e70ea6f1c8 Author: Noel Grandin AuthorDate: Sat Jul 17 19:05:12 2021 +0200 Commit: Noel Grandin CommitDate: Sat Jul 17 22:17:15 2021 +0200 osl::Mutex->std::mutex in SequenceOutputStreamService Change-Id: I1aaa9ebd76e2376be82b25f2659d4b0f22dc14e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119113 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/comphelper/source/streaming/seqoutputstreamserv.cxx b/comphelper/source/streaming/seqoutputstreamserv.cxx index 477961397413..e19ea1001ae8 100644 --- a/comphelper/source/streaming/seqoutputstreamserv.cxx +++ b/comphelper/source/streaming/seqoutputstreamserv.cxx @@ -26,6 +26,7 @@ #include #include #include +#include namespace com::sun::star::uno { class XComponentContext; } @@ -61,7 +62,7 @@ private: virtual ~SequenceOutputStreamService() override {}; -::osl::Mutex m_aMutex; +std::mutex m_aMutex; uno::Reference< io::XOutputStream > m_xOutputStream; uno::Sequence< ::sal_Int8 > m_aSequence; }; @@ -89,7 +90,7 @@ uno::Sequence< OUString > SAL_CALL SequenceOutputStreamService::getSupportedServ // css::io::XOutputStream: void SAL_CALL SequenceOutputStreamService::writeBytes( const uno::Sequence< ::sal_Int8 > & aData ) { -::osl::MutexGuard aGuard( m_aMutex ); +std::lock_guard aGuard( m_aMutex ); if ( !m_xOutputStream.is() ) throw io::NotConnectedException(); @@ -98,7 +99,7 @@ void SAL_CALL SequenceOutputStreamService::writeBytes( const uno::Sequence< ::sa void SAL_CALL SequenceOutputStreamService::flush() { -::osl::MutexGuard aGuard( m_aMutex ); +std::lock_guard aGuard( m_aMutex ); if ( !m_xOutputStream.is() ) throw io::NotConnectedException(); @@ -107,7 +108,7 @@ void SAL_CALL SequenceOutputStreamService::flush() void SAL_CALL SequenceOutputStreamService::closeOutput() { -::osl::MutexGuard aGuard( m_aMutex ); +std::lock_guard aGuard( m_aMutex ); if ( !m_xOutputStream.is() ) throw io::NotConnectedException(); @@ -118,7 +119,7 @@ void SAL_CALL SequenceOutputStreamService::closeOutput() // css::io::XSequenceOutputStream: uno::Sequence< ::sal_Int8 > SAL_CALL SequenceOutputStreamService::getWrittenBytes() { -::osl::MutexGuard aGuard( m_aMutex ); +std::lock_guard aGuard( m_aMutex ); if ( !m_xOutputStream.is() ) throw io::NotConnectedException(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: unotools/source
unotools/source/ucbhelper/ucblockbytes.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 2f8635fc919906fe8238fa5ef9e77cfe2f23df83 Author: Noel Grandin AuthorDate: Sat Jul 17 18:56:54 2021 +0200 Commit: Noel Grandin CommitDate: Sat Jul 17 22:16:55 2021 +0200 osl::Mutex->std::mutex in ModeratorsActiveDataSink Change-Id: If1e4af0d9acf75bd0f2744f134a42c29e41d56f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119110 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/unotools/source/ucbhelper/ucblockbytes.cxx b/unotools/source/ucbhelper/ucblockbytes.cxx index d3e090cae679..4ed6dec1a236 100644 --- a/unotools/source/ucbhelper/ucblockbytes.cxx +++ b/unotools/source/ucbhelper/ucblockbytes.cxx @@ -57,6 +57,7 @@ #include #include +#include using namespace ::com::sun::star::uno; using namespace ::com::sun::star::io; @@ -333,13 +334,13 @@ public: virtual Reference SAL_CALL getInputStream() override { -osl::MutexGuard aGuard(m_aMutex); +std::lock_guard aGuard(m_aMutex); return m_xStream; } private: Moderator& m_aModerator; -osl::Mutex m_aMutex; +std::mutex m_aMutex; Reference m_xStream; }; @@ -357,7 +358,7 @@ ModeratorsActiveDataSink::setInputStream ( ) { m_aModerator.setInputStream(rxInputStream); -osl::MutexGuard aGuard(m_aMutex); +std::lock_guard aGuard(m_aMutex); m_xStream = rxInputStream; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/propertysetmixin.cxx | 16 1 file changed, 8 insertions(+), 8 deletions(-) New commits: commit 5962431c3d380f97f76c31869a1098e3efaa8b43 Author: Noel Grandin AuthorDate: Sat Jul 17 18:41:48 2021 +0200 Commit: Noel Grandin CommitDate: Sat Jul 17 22:16:28 2021 +0200 osl::Mutex->std::mutex in PropertySetMixinImpl Change-Id: I45ae292e95efc57a125807d15c6c259533dd5f92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119106 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/cppuhelper/source/propertysetmixin.cxx b/cppuhelper/source/propertysetmixin.cxx index c7c8154896a4..0a270db6f17e 100644 --- a/cppuhelper/source/propertysetmixin.cxx +++ b/cppuhelper/source/propertysetmixin.cxx @@ -22,6 +22,7 @@ #include #include #include +#include #include #include @@ -67,7 +68,6 @@ #include #include #include -#include #include #include #include @@ -381,7 +381,7 @@ public: typedef std::map< OUString, VetoListenerBag > VetoListenerMap; -mutable osl::Mutex mutex; +mutable std::mutex mutex; BoundListenerMap boundListeners; VetoListenerMap vetoListeners; bool disposed; @@ -853,7 +853,7 @@ void PropertySetMixinImpl::prepareSet( Impl::VetoListenerBag specificVeto; Impl::VetoListenerBag unspecificVeto; { -osl::MutexGuard g(m_impl->mutex); +std::lock_guard g(m_impl->mutex); if (m_impl->disposed) { throw css::lang::DisposedException( "disposed", static_cast< css::beans::XPropertySet * >(this)); @@ -922,7 +922,7 @@ void PropertySetMixinImpl::dispose() { Impl::BoundListenerMap boundListeners; Impl::VetoListenerMap vetoListeners; { -osl::MutexGuard g(m_impl->mutex); +std::lock_guard g(m_impl->mutex); boundListeners.swap(m_impl->boundListeners); vetoListeners.swap(m_impl->vetoListeners); m_impl->disposed = true; @@ -1001,7 +1001,7 @@ void PropertySetMixinImpl::addPropertyChangeListener( checkUnknown(propertyName); bool disposed; { -osl::MutexGuard g(m_impl->mutex); +std::lock_guard g(m_impl->mutex); disposed = m_impl->disposed; if (!disposed) { m_impl->boundListeners[propertyName].insert(listener); @@ -1020,7 +1020,7 @@ void PropertySetMixinImpl::removePropertyChangeListener( { assert(listener.is()); checkUnknown(propertyName); -osl::MutexGuard g(m_impl->mutex); +std::lock_guard g(m_impl->mutex); Impl::BoundListenerMap::iterator i( m_impl->boundListeners.find(propertyName)); if (i != m_impl->boundListeners.end()) { @@ -1040,7 +1040,7 @@ void PropertySetMixinImpl::addVetoableChangeListener( checkUnknown(propertyName); bool disposed; { -osl::MutexGuard g(m_impl->mutex); +std::lock_guard g(m_impl->mutex); disposed = m_impl->disposed; if (!disposed) { m_impl->vetoListeners[propertyName].insert(listener); @@ -1059,7 +1059,7 @@ void PropertySetMixinImpl::removeVetoableChangeListener( { assert(listener.is()); checkUnknown(propertyName); -osl::MutexGuard g(m_impl->mutex); +std::lock_guard g(m_impl->mutex); Impl::VetoListenerMap::iterator i(m_impl->vetoListeners.find(propertyName)); if (i != m_impl->vetoListeners.end()) { Impl::VetoListenerBag::iterator j(i->second.find(listener)); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||137310 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=137310 [Bug 137310] FILEOPEN: 3D object is not visible -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 137310] FILEOPEN: 3D object is not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=137310 Aron Budea changed: What|Removed |Added Blocks||116280 CC||ba...@caesar.elte.hu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108734] [META] Character dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108734 Bug 108734 depends on bug 139654, which changed state. Bug 139654 Summary: Enhancement request for sensitive 'Features...' buttons in Character Font tab page https://bugs.documentfoundation.org/show_bug.cgi?id=139654 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||126920 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=126920 [Bug 126920] LibreOffice Calc is oversensitive to pasting overlapping images -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 126920] LibreOffice Calc is oversensitive to pasting overlapping images
https://bugs.documentfoundation.org/show_bug.cgi?id=126920 Aron Budea changed: What|Removed |Added Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||135390 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=135390 [Bug 135390] Linked Graphic on localhost slows freezes application for several seconds when not available -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 135390] Linked Graphic on localhost slows freezes application for several seconds when not available
https://bugs.documentfoundation.org/show_bug.cgi?id=135390 Aron Budea changed: What|Removed |Added Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||125743 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=125743 [Bug 125743] Writer no longer displays odt external bullet graphics -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 125743] Writer no longer displays odt external bullet graphics
https://bugs.documentfoundation.org/show_bug.cgi?id=125743 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||131185 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131185 [Bug 131185] LO Writer "hangs" on scrolling/saving of a document where embedded image doesn't exist -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||142436 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142436 [Bug 142436] Linked background image is not read -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142436] Linked background image is not read
https://bugs.documentfoundation.org/show_bug.cgi?id=142436 Aron Budea changed: What|Removed |Added Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 116280] [META] Regressions introduced by the image handling refactoring
https://bugs.documentfoundation.org/show_bug.cgi?id=116280 Aron Budea changed: What|Removed |Added Depends on||141297 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141297 [Bug 141297] Removing links for external images doesn't work -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 141297] Removing links for external images doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=141297 Aron Budea changed: What|Removed |Added Blocks||116280 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116280 [Bug 116280] [META] Regressions introduced by the image handling refactoring -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: extensions/source
extensions/source/propctrlr/standardcontrol.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit ecf901685ac0c6c7b27b81096bea96cdc3d2c2ca Author: Caolán McNamara AuthorDate: Fri Jul 16 15:53:00 2021 +0100 Commit: Caolán McNamara CommitDate: Sat Jul 17 21:17:03 2021 +0200 Related: tdf#143357 set blank label for no date instead of current system date Change-Id: Ic504b34990a8ea5151ec653de2db860c1cd4b8ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119079 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/extensions/source/propctrlr/standardcontrol.cxx b/extensions/source/propctrlr/standardcontrol.cxx index 2307d0bf01f4..7cbca1c276b4 100644 --- a/extensions/source/propctrlr/standardcontrol.cxx +++ b/extensions/source/propctrlr/standardcontrol.cxx @@ -97,15 +97,18 @@ namespace pcr void SAL_CALL ODateControl::setValue( const Any& _rValue ) { +SvtCalendarBox* pCalendarBox = getTypedControlWindow(); + util::Date aUNODate; if ( !( _rValue >>= aUNODate ) ) { -getTypedControlWindow()->set_date(::Date(::Date::SYSTEM)); +pCalendarBox->set_date(::Date(::Date::SYSTEM)); +pCalendarBox->set_label(""); } else { ::Date aDate( aUNODate.Day, aUNODate.Month, aUNODate.Year ); -getTypedControlWindow()->set_date(aDate); +pCalendarBox->set_date(aDate); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143298] Writer: CTRL-TAB to cycle through suggestions for word completion does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=143298 --- Comment #8 from al F --- (In reply to Buovjaga from comment #7) > (In reply to al F from comment #6) > > (In reply to Buovjaga from comment #5) > > > Please launch from the command line with > > > > > > SAL_USE_VCLPLUGIN=gen libreoffice > > > > This launhces libreoffice in a style that looks like windows 2000 :-) > > > > But yes! CTRL-TAB works as expected. > > > > I tried launching SAL_USE_VCLPLUGIN=gtk3 and kf5 and qt and X11. All of them > > looks the same and all them misbehave on CTRL-TAB. > > > > Does this mean we know where the problem is? > > Hmm, if you mean you launched with SAL_USE_VCLPLUGIN=x11, that will have no > effect as such an alias does not exist. I don't know what you mean by "all > of them look the same". gtk3 and kf5 certainly don't look the same. You can > check from Help - About VCL: what you are actually running at a given moment. > > Can you confirm that it misbehaves when you see VCL: gtk3 in Help - About? No. Help > About says > UI render: default; VCL: kf5 regardless which command (SAL_USE_VCLPLUGIN=gtk3/qt/kf5 libreoffice) I use to launch. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143419] Allow user to easily copy all properties from one (sidebar) Paragraph Style to another
https://bugs.documentfoundation.org/show_bug.cgi?id=143419 Dave Barton changed: What|Removed |Added Keywords|needsUXEval | --- Comment #4 from Dave Barton --- What you are proposing is an extremely convoluted mechanism for creating a separate (other) style loosely based on an existing style. We already have a relatively simple mechanism to do this, by clicking on the sidebar "Styles Action" button and selecting "New Style from Selection" option, to create a a separate (other) style based on an existing style. As someone who has trained users in the use of this software since 2001 and contributed to it's documentation, I can justifiably claim that the most difficult aspect of Writer is to explain to new/inexperienced users is "Styles", what they are and how to use them. We already have numerous complex all singing/dancing sidebars and toolbars and another Styles creation mechanism would only add more unnecessary complications. The software has many other important issues the devs need to address, before looking into fanciful suggestions like this. My take, the existing mechanism WFM. So -1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143419] Allow user to easily copy all properties from one (sidebar) Paragraph Style to another
https://bugs.documentfoundation.org/show_bug.cgi?id=143419 Dave Barton changed: What|Removed |Added Keywords|needsUXEval | --- Comment #4 from Dave Barton --- What you are proposing is an extremely convoluted mechanism for creating a separate (other) style loosely based on an existing style. We already have a relatively simple mechanism to do this, by clicking on the sidebar "Styles Action" button and selecting "New Style from Selection" option, to create a a separate (other) style based on an existing style. As someone who has trained users in the use of this software since 2001 and contributed to it's documentation, I can justifiably claim that the most difficult aspect of Writer is to explain to new/inexperienced users is "Styles", what they are and how to use them. We already have numerous complex all singing/dancing sidebars and toolbars and another Styles creation mechanism would only add more unnecessary complications. The software has many other important issues the devs need to address, before looking into fanciful suggestions like this. My take, the existing mechanism WFM. So -1. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - svx/uiconfig
svx/uiconfig/ui/dockingfontwork.ui | 910 ++--- 1 file changed, 461 insertions(+), 449 deletions(-) New commits: commit 591d49a1711d5e23b3237c96517a9ec2dafee660 Author: Julien Nabet AuthorDate: Wed Jul 14 21:13:26 2021 +0200 Commit: Caolán McNamara CommitDate: Sat Jul 17 20:52:02 2021 +0200 tdf#143355: fix crash with .uno:FontWork with gen rendering part of bt: 2 0x7fbfb39f440f in __assert_fail_base (fmt=0x7fbfb3b5d128 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=0x7fbfac2531b0 "!w || dynamic_cast(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=) at assert.c:92 3 0x7fbfb3a03662 in __GI___assert_fail (assertion=0x7fbfac2531b0 "!w || dynamic_cast(w)", file=0x7fbfac2531ca "/home/julien/lo/libreoffice/include/vcl/builder.hxx", line=438, function=0x7fbfac3ad73e "T *VclBuilder::get(const rtl::OString &) [T = VclBox]") at assert.c:101 4 0x7fbfabb27ace in VclBuilder::get(rtl::OString const&) (this=0x6e07e70, sID="DockingFontwork") at include/vcl/builder.hxx:438 5 0x7fbfabb065e5 in SalInstanceBuilder::weld_box(rtl::OString const&) (this=0x6ce97c0, id="DockingFontwork") at vcl/source/app/salvtables.cxx:6811 6 0x7fbfb07d3fe9 in SfxDockingWindow::SfxDockingWindow(SfxBindings*, SfxChildWindow*, vcl::Window*, rtl::OString const&, rtl::OUString const&) (this= 0x6e37c90, vtt=0x7fbfafd55730 , pBindinx=0x34f62b0, pCW=0x6e39c00, pParent=0x34f6f40, rID="DockingFontwork", rUIXMLDescription="svx/ui/dockingfontwork.ui") at sfx2/source/dialog/dockwin.cxx:774 7 0x7fbfaf7c3be8 in SvxFontWorkDialog::SvxFontWorkDialog(SfxBindings*, SfxChildWindow*, vcl::Window*) (this=0x6e37c90, pBindinx=0x34f62b0, pCW=0x6e39c00, _pParent=0x34f6f40) at svx/source/dialog/fontwork.cxx:179 8 0x7fbfaf7c728c in VclPtrInstance::VclPtrInstance(SfxBindings*&, SvxFontWorkChildWindow*&&, vcl::Window*&) (this=0x7ffc6e31bf70, arg=@0x7ffc6e31bf78: 0x34f62b0, arg=@0x7ffc6e31bf68: 0x6e39c00, arg=@0x7ffc6e31bf80: 0x34f6f40) at include/vcl/vclptr.hxx:279 9 0x7fbfaf7c1dcc in SvxFontWorkChildWindow::SvxFontWorkChildWindow(vcl::Window*, unsigned short, SfxBindings*, SfxChildWinInfo*) (this=0x6e39c00, _pParent=0x34f6f40, nId=10256, pBindings=0x34f62b0, pInfo=0x7ffc6e31c230) at svx/source/dialog/fontwork.cxx:169 See full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173585 with gtk3 rendering, no crash but: (soffice:33916): GLib-GObject-WARNING **: 20:40:33.018: invalid cast from 'GtkGrid' to 'GtkBox' put grid into a toplevel box (git show -w to see minimal diff) Change-Id: I05f9a295cd839f782467b85d6bafd652a405b14d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118919 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svx/uiconfig/ui/dockingfontwork.ui b/svx/uiconfig/ui/dockingfontwork.ui index 2dac88a05e37..9c6d3de07293 100644 --- a/svx/uiconfig/ui/dockingfontwork.ui +++ b/svx/uiconfig/ui/dockingfontwork.ui @@ -26,557 +26,569 @@ 0.1 1 - - + True -False -12 +False +vertical - + + True False -False +12 - + True False -Off -True -svx/res/fw01.png -True - - -Removes baseline formatting. +False + + +True +False +Off +True +svx/res/fw01.png +True + + +Removes baseline formatting. + + + +False +True + - - -False -True - - - - -True -False - - -False -True - - - - -True -False -Rotate -True -svx/res/fw02.png -off - - -Uses the top or the bottom edge of the selected object as the text baseline. + + +True +False + +False +True + - - -False -True - - - - -True -False -Upright -True -svx/res/fw03.png -off - - -Uses the top or the bottom edge of the selected
[Libreoffice-commits] core.git: Branch 'libreoffice-7-1' - sw/source
sw/source/core/text/inftxt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e9014226d5ef3db2e2b40ab86f50e41256142641 Author: Eike Rathke AuthorDate: Fri Jul 16 11:50:39 2021 +0200 Commit: Caolán McNamara CommitDate: Sat Jul 17 20:48:01 2021 +0200 Fix lang::Locale.Language usage, tdf#128191 follow-up Using plain lang::Locale.Language is always wrong, it may even be 'qlt' for a more complex language tag. As the InfoBar message is "Please install the hyphenation package for locale “%1”." actually use the BCP 47 language tag of that character/paragraph attribution. Spotted in https://ask.libreoffice.org/en/question/280102/install-the-hyphenation-package-for-locale-ka/ https://ask.libreoffice.org/en/question/238764/error-message-reads-install-the-hyphenation-package-for-locale-zh/ Change-Id: I5805d4d711989a9d0260940666d3eb33eae830af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119020 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit 64f885a6c9d51999b737c0f61bc3a7fa311a5a94) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119032 Reviewed-by: Caolán McNamara diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx index ac0b61f29a79..20120767266c 100644 --- a/sw/source/core/text/inftxt.cxx +++ b/sw/source/core/text/inftxt.cxx @@ -1501,7 +1501,7 @@ bool SwTextFormatInfo::IsHyphenate() const pShell->AppendInfoBarWhenReady( "hyphenationmissing", SwResId(STR_HYPH_MISSING), SwResId(STR_HYPH_MISSING_DETAIL) -.replaceFirst("%1", g_pBreakIt->GetLocale(eTmp).Language), +.replaceFirst("%1", LanguageTag::convertToBcp47( g_pBreakIt->GetLocale(eTmp))), InfobarType::WARNING); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 128191] Show Infobar when hyphenation info is missing for current locale
https://bugs.documentfoundation.org/show_bug.cgi?id=128191 --- Comment #9 from Commit Notification --- Eike Rathke committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/e9014226d5ef3db2e2b40ab86f50e41256142641 Fix lang::Locale.Language usage, tdf#128191 follow-up It will be available in 7.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 128191] Show Infobar when hyphenation info is missing for current locale
https://bugs.documentfoundation.org/show_bug.cgi?id=128191 Commit Notification changed: What|Removed |Added Whiteboard|target:7.0.0 target:6.4.0.1 |target:7.0.0 target:6.4.0.1 |target:7.3.0 target:7.2.0.2 |target:7.3.0 target:7.2.0.2 ||target:7.1.6 -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source
editeng/source/misc/txtrange.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 9e626a6d2a55a7159e4fd05d72275c7fe8bb0380 Author: Noel Grandin AuthorDate: Sat Jul 17 11:05:56 2021 +0200 Commit: Noel Grandin CommitDate: Sat Jul 17 20:38:55 2021 +0200 blind fix for ubsan div/0 Change-Id: I0ee929c79d5ac94299adc84ba91d6b0683a8193d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119095 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/editeng/source/misc/txtrange.cxx b/editeng/source/misc/txtrange.cxx index b8c46e0cdcba..dadc4fc6f315 100644 --- a/editeng/source/misc/txtrange.cxx +++ b/editeng/source/misc/txtrange.cxx @@ -194,7 +194,10 @@ tools::Long SvxBoundArgs::CalcMax( const Point& rPt1, const Point& rPt2, nB = nStart; nB *= nB; nB += nDa * nDa; -nB = nRange + nDa * ( nFarRange - nRange ) / sqrt( nB ); +nB = sqrt( nB ); +if (nB == 0) // avoid div / 0 +return 0; +nB = nRange + nDa * ( nFarRange - nRange ) / nB; bool bNote; if( nB < B(rPt2) ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143420] Can't print
https://bugs.documentfoundation.org/show_bug.cgi?id=143420 --- Comment #6 from Sheldon Glickler --- Yes, and yes. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143135] Impress crashes when switching to another application then back
https://bugs.documentfoundation.org/show_bug.cgi?id=143135 --- Comment #2 from Caolán McNamara --- If this was the stock fedora build, which it sounds like, was there an offer to report the bug from fedora itself ? If there was, and you approved it, there might have been a link to the fedora retrace shown (something like https://retrace.fedoraproject.org/faf/reports/206623/). A link like that would provide possibly useful backtrace info to give a hint as to the nature of the bug -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143420] Can't print
https://bugs.documentfoundation.org/show_bug.cgi?id=143420 Buovjaga changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from Buovjaga --- Ok, the inability to print PDFs does sound like you have a wider problem than just some LibreOffice issue. Did you try removing the printer driver and letting Windows install it again? Is it Windows 10? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143298] Writer: CTRL-TAB to cycle through suggestions for word completion does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=143298 --- Comment #7 from Buovjaga --- (In reply to al F from comment #6) > (In reply to Buovjaga from comment #5) > > Please launch from the command line with > > > > SAL_USE_VCLPLUGIN=gen libreoffice > > This launhces libreoffice in a style that looks like windows 2000 :-) > > But yes! CTRL-TAB works as expected. > > I tried launching SAL_USE_VCLPLUGIN=gtk3 and kf5 and qt and X11. All of them > looks the same and all them misbehave on CTRL-TAB. > > Does this mean we know where the problem is? Hmm, if you mean you launched with SAL_USE_VCLPLUGIN=x11, that will have no effect as such an alias does not exist. I don't know what you mean by "all of them look the same". gtk3 and kf5 certainly don't look the same. You can check from Help - About VCL: what you are actually running at a given moment. Can you confirm that it misbehaves when you see VCL: gtk3 in Help - About? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 142973] English texts in start center in German LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=142973 --- Comment #5 from Caolán McNamara --- normally this is missing translations, not sure if that is the case here though -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143420] Can't print
https://bugs.documentfoundation.org/show_bug.cgi?id=143420 --- Comment #4 from Sheldon Glickler --- I can print .doc files from Microsoft Worn, but I can't print anything from Libre Office. I also can't print any .pdf from my computer but I can from my android cellphone. I also cannot print any file created from Libre and saved and trying to print the saved with or without opening it. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143298] Writer: CTRL-TAB to cycle through suggestions for word completion does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=143298 --- Comment #6 from al F --- (In reply to Buovjaga from comment #5) > Please launch from the command line with > > SAL_USE_VCLPLUGIN=gen libreoffice This launhces libreoffice in a style that looks like windows 2000 :-) But yes! CTRL-TAB works as expected. I tried launching SAL_USE_VCLPLUGIN=gtk3 and kf5 and qt and X11. All of them looks the same and all them misbehave on CTRL-TAB. Does this mean we know where the problem is? -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143424] New: Field "Chapter number without separator" is using the separators
https://bugs.documentfoundation.org/show_bug.cgi?id=143424 Bug ID: 143424 Summary: Field "Chapter number without separator" is using the separators Product: LibreOffice Version: 7.2.0.1 rc Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: libreoffice@phv.email Description: This bug is breaking the field I've added in a document footer: the reference to the chapters are displayed with the separators when I specified Libreoffice Writer not to do it. It looks like the field keeps adding the separators before and after the field reference. Steps to Reproduce: 1. Create a new chapter numbering with numbering and separators (ex.: Chapter 1 -) 2. Write a new heading that refers to this chapter numbering (ex.: Heading 1) 3. Insert a new document field and choose "Chapter number without separator" Actual Results: The field shows the chapter number WITH the separators. Expected Results: The field should show the chapter number WITHOUT the separators. Reproducible: Always User Profile Reset: No Additional Info: This bug has been introduced in version 7.2.0.1. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143423] LibreOffice is out/dead
https://bugs.documentfoundation.org/show_bug.cgi?id=143423 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg Resolution|--- |INVALID Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143419] Allow user to easily copy all properties from one (sidebar) Paragraph Style to another
https://bugs.documentfoundation.org/show_bug.cgi?id=143419 --- Comment #3 from R. Green --- Here is an example of how it might work: Suppose that Writer had a dialogue with a list of existing paragraph styles in the left-hand column, and an identical list in the right-hand column. You select a "donor" style in the LH column, then a "recipient" style in the RH column, then press the "Apply" button. All properties, except those in the "Organizer" tab, are transferred from the donor to the recipient. The dialogue stays open, allowing further substitutions, until the user presses "Close". -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 143419] Allow user to easily copy all properties from one (sidebar) Paragraph Style to another
https://bugs.documentfoundation.org/show_bug.cgi?id=143419 --- Comment #3 from R. Green --- Here is an example of how it might work: Suppose that Writer had a dialogue with a list of existing paragraph styles in the left-hand column, and an identical list in the right-hand column. You select a "donor" style in the LH column, then a "recipient" style in the RH column, then press the "Apply" button. All properties, except those in the "Organizer" tab, are transferred from the donor to the recipient. The dialogue stays open, allowing further substitutions, until the user presses "Close". -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 143423] New: LibreOffice is out/dead
https://bugs.documentfoundation.org/show_bug.cgi?id=143423 Bug ID: 143423 Summary: LibreOffice is out/dead Product: LibreOffice Version: 7.0.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mickpf...@gmail.com Description: Dear Sirs, I would like to report a very small bug. You may think it's a joke, but it is by no means! I have a degree in computer science and have been using OpenOffice for many years, which later became LibreOffice. I can't tell you exactly which version it started with, but with each new version it got worse and worse, both on Windows and Linux. Functions such as printing on envelopes no longer works at all. It has so many bugs now that I couldn't even list them anymore. I recently removed LibreOffice from all of my computers and from my parents' computer because it is no longer good, and temporarily replaced it with "Apache OpenOffice" until I'l find something else! But I would also like to comfort you a little at this point: This devastating development is not only taking place in the area of "OpenSource Software", but also almost everywhere in the commercial market, where you have to pay a lot of money for software and only get garbage for it. I hope this will comfort you ... You may ask what could be improved: nothing and everything. Carry on like this, and in a short time nobody will use LibreOffice anymore. Incidentally, this miserable assessment of LibreOffice is now very widespread. I defended the program for a while, but now I don't want to do it either! Steps to Reproduce: 1. Download 2. Install 3. Use it Actual Results: Deinstallation ist the best solution Expected Results: No hope any more Reproducible: Always User Profile Reset: Yes Additional Info: Nothing to say anymore -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cppu/source
cppu/source/threadpool/threadpool.cxx |7 +++ cppu/source/threadpool/threadpool.hxx |2 +- 2 files changed, 4 insertions(+), 5 deletions(-) New commits: commit bd4ee5ea9b0b79cfb8c03aa1f1d6008565b71bff Author: Arnaud Versini AuthorDate: Sun Jun 27 17:05:35 2021 +0200 Commit: Arnaud Versini CommitDate: Sat Jul 17 19:02:18 2021 +0200 cppu : use std::mutex in DisposedCallerAdmin Change-Id: I3db567a9aed42167ea24eebcf673f19106595f83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117948 Tested-by: Jenkins Reviewed-by: Arnaud Versini diff --git a/cppu/source/threadpool/threadpool.cxx b/cppu/source/threadpool/threadpool.cxx index 257155027955..86c280b4b352 100644 --- a/cppu/source/threadpool/threadpool.cxx +++ b/cppu/source/threadpool/threadpool.cxx @@ -25,7 +25,6 @@ #include #include -#include #include #include @@ -68,19 +67,19 @@ namespace cppu_threadpool void DisposedCallerAdmin::dispose( void const * nDisposeId ) { -MutexGuard guard( m_mutex ); +std::scoped_lock guard( m_mutex ); m_vector.push_back( nDisposeId ); } void DisposedCallerAdmin::destroy( void const * nDisposeId ) { -MutexGuard guard( m_mutex ); +std::scoped_lock guard( m_mutex ); m_vector.erase(std::remove(m_vector.begin(), m_vector.end(), nDisposeId), m_vector.end()); } bool DisposedCallerAdmin::isDisposed( void const * nDisposeId ) { -MutexGuard guard( m_mutex ); +std::scoped_lock guard( m_mutex ); return (std::find(m_vector.begin(), m_vector.end(), nDisposeId) != m_vector.end()); } diff --git a/cppu/source/threadpool/threadpool.hxx b/cppu/source/threadpool/threadpool.hxx index 5b758703579a..15d092a21062 100644 --- a/cppu/source/threadpool/threadpool.hxx +++ b/cppu/source/threadpool/threadpool.hxx @@ -89,7 +89,7 @@ namespace cppu_threadpool { bool isDisposed( void const * nDisposeId ); private: -::osl::Mutex m_mutex; +std::mutex m_mutex; std::vector< void const * > m_vector; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 143381] Calc hangs if properties panel is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=143381 --- Comment #6 from Tim Anderson --- Uncheck Use Skia for all rendering -> No difference Uncheck Use hardware acceleration -> No difference Problem remains in both cases. Tim -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143381] Calc hangs if properties panel is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=143381 --- Comment #5 from Buovjaga --- Try unchecking Tools - Options - LibreOffice - View - Use Skia for all rendering -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108440] [META] Database form bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108440 Buovjaga changed: What|Removed |Added Depends on||143389 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143389 [Bug 143389] PDF-Export: Content of a date field in a form won't be shown in exported document -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143389] PDF-Export: Content of a date field in a form won't be shown in exported document
https://bugs.documentfoundation.org/show_bug.cgi?id=143389 Buovjaga changed: What|Removed |Added Ever confirmed|0 |1 Blocks||108440 Status|UNCONFIRMED |NEW CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #2 from Buovjaga --- Repro with db NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108440 [Bug 108440] [META] Database form bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143130] FILESAVE DOCX Shapes placed on chart not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=143130 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from Buovjaga --- Repro NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 100156] [META] Wayland-related bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=100156 Buovjaga changed: What|Removed |Added Depends on||143135 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143135 [Bug 143135] Impress crashes when switching to another application then back -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143135] Impress crashes when switching to another application then back
https://bugs.documentfoundation.org/show_bug.cgi?id=143135 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Whiteboard| QA:needsComment| Blocks||100156 --- Comment #1 from Buovjaga --- Does it also happen if you launch from the command line with SAL_USE_VCLPLUGIN=gtk3 libreoffice Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=100156 [Bug 100156] [META] Wayland-related bugs -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143140] ODT: Bibliography index duplicated
https://bugs.documentfoundation.org/show_bug.cgi?id=143140 Buovjaga changed: What|Removed |Added Whiteboard| QA:needsComment| Status|UNCONFIRMED |RESOLVED CC||ilmari.lauhakangas@libreoff ||ice.org Resolution|--- |DUPLICATE --- Comment #2 from Buovjaga --- Repro with document. However, I found an older report (In reply to Mihai Vasiliu from comment #0) > 6. Between any two existing bibliography references from the text, enther a > new one. Let's say between [1] and [2], create and insert a new reference. Exact steps: 6a. Insert - Table of contents and index - Bibliography entry 6b. Click New in the dialog 6c. Input a unique short name and pick some random type NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded *** This bug has been marked as a duplicate of bug 95285 *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95285] Numbered bibliography entries duplicate when inserted above previous entry
https://bugs.documentfoundation.org/show_bug.cgi?id=95285 Buovjaga changed: What|Removed |Added CC||mihai.vasiliu...@gmail.com --- Comment #4 from Buovjaga --- *** Bug 143140 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source include/svl svl/source svx/source
dbaccess/source/ui/misc/UITools.cxx |8 +++- include/svl/itemset.hxx |2 -- svl/source/items/itemset.cxx| 11 --- svx/source/unodraw/unoshape.cxx |6 ++ 4 files changed, 5 insertions(+), 22 deletions(-) New commits: commit 3581de4d1d7dc3910b4642a2baef534dcd882597 Author: Noel Grandin AuthorDate: Fri Jul 16 08:51:01 2021 +0200 Commit: Noel Grandin CommitDate: Sat Jul 17 17:45:09 2021 +0200 drop sal_uInt16* constructor in SfxItemSet Change-Id: Ifb283a49b01c9c6421e385f697e749439db6a53f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119008 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/dbaccess/source/ui/misc/UITools.cxx b/dbaccess/source/ui/misc/UITools.cxx index c590bf993915..2903b7a66ec4 100644 --- a/dbaccess/source/ui/misc/UITools.cxx +++ b/dbaccess/source/ui/misc/UITools.cxx @@ -768,13 +768,11 @@ bool callColumnFormatDialog(weld::Widget* _pParent, { SID_ATTR_NUMBERFORMAT_INFO, true }, { SID_ATTR_NUMBERFORMAT_ONE_AREA, true } }; -static const sal_uInt16 aAttrMap[] = -{ +static const auto aAttrMap = svl::Items< SBA_DEF_RANGEFORMAT, SBA_ATTR_ALIGN_HOR_JUSTIFY, SID_ATTR_NUMBERFORMAT_INFO, SID_ATTR_NUMBERFORMAT_INFO, -SID_ATTR_NUMBERFORMAT_ONE_AREA, SID_ATTR_NUMBERFORMAT_ONE_AREA, -0 -}; +SID_ATTR_NUMBERFORMAT_ONE_AREA, SID_ATTR_NUMBERFORMAT_ONE_AREA +>{}; std::vector pDefaults { diff --git a/include/svl/itemset.hxx b/include/svl/itemset.hxx index befae1012990..0471dfd3603a 100644 --- a/include/svl/itemset.hxx +++ b/include/svl/itemset.hxx @@ -141,8 +141,6 @@ public: SfxItemSet(SfxItemPool& pool, svl::Items) : SfxItemSet(pool, WhichRangesContainer(svl::Items::value)) {} -SfxItemSet( SfxItemPool&, const sal_uInt16* nWhichPairTable ); - virtual ~SfxItemSet(); virtual std::unique_ptr Clone(bool bItems = true, SfxItemPool *pToPool = nullptr) const; diff --git a/svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx index 324cf6da69f0..55804cdfe723 100644 --- a/svl/source/items/itemset.cxx +++ b/svl/source/items/itemset.cxx @@ -119,17 +119,6 @@ SfxItemSet::SfxItemSet( m_pItems.reset( new SfxPoolItem const *[size]{} ); } -SfxItemSet::SfxItemSet( SfxItemPool& rPool, const sal_uInt16* pWhichPairTable ) -: m_pPool() -, m_pParent(nullptr) -, m_nCount(0) -{ -const auto& [nCnt, nCap] = svl::detail::CountRangesOld(pWhichPairTable); -m_pItems.reset(new const SfxPoolItem* [nCap] {}); -m_pWhichRanges = WhichRangesContainer(reinterpret_cast(pWhichPairTable), (nCnt-1)/2); -assert(svl::detail::validRanges2(m_pWhichRanges)); -} - SfxItemSet::SfxItemSet( const SfxItemSet& rASet ) : m_pPool( rASet.m_pPool ) , m_pParent( rASet.m_pParent ) diff --git a/svx/source/unodraw/unoshape.cxx b/svx/source/unodraw/unoshape.cxx index 6974ce0f11fd..ad3aefa4d88c 100644 --- a/svx/source/unodraw/unoshape.cxx +++ b/svx/source/unodraw/unoshape.cxx @@ -1646,8 +1646,7 @@ void SvxShape::_setPropertyValue( const OUString& rPropertyName, const uno::Any& { if( !mpImpl->mxItemSet ) { -sal_uInt16 aWhichPairTable[] = { pMap->nWID, pMap->nWID, 0, 0 }; -mpImpl->mxItemSet.emplace( GetSdrObject()->getSdrModelFromSdrObject().GetItemPool(), aWhichPairTable); +mpImpl->mxItemSet.emplace( GetSdrObject()->getSdrModelFromSdrObject().GetItemPool(), pMap->nWID, pMap->nWID ); } else { @@ -1657,8 +1656,7 @@ void SvxShape::_setPropertyValue( const OUString& rPropertyName, const uno::Any& } else { -sal_uInt16 aWhichPairTable[] = { pMap->nWID, pMap->nWID, 0, 0 }; -xLocalSet.emplace( GetSdrObject()->getSdrModelFromSdrObject().GetItemPool(), aWhichPairTable); +xLocalSet.emplace( GetSdrObject()->getSdrModelFromSdrObject().GetItemPool(), pMap->nWID, pMap->nWID); pSet = &*xLocalSet; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/charfmt.hxx |2 sw/inc/fmtcol.hxx | 12 +-- sw/inc/format.hxx |4 - sw/inc/frmfmt.hxx |4 - sw/inc/hintids.hxx | 27 --- sw/inc/swatrset.hxx |1 sw/inc/swtblfmt.hxx |6 - sw/source/core/attr/format.cxx |8 +- sw/source/core/attr/swatrset.cxx| 15 +--- sw/source/core/bastyp/init.cxx | 84 ++-- sw/source/core/doc/DocumentStylePoolManager.cxx |8 +- sw/source/core/doc/docedt.cxx | 11 --- sw/source/core/doc/docfmt.cxx | 12 +-- sw/source/core/doc/docnew.cxx | 14 +--- sw/source/core/fields/expfld.cxx|8 -- sw/source/core/layout/atrfrm.cxx|8 +- sw/source/core/undo/untbl.cxx | 13 +-- sw/source/core/unocore/unocrsrhelper.cxx|2 sw/source/core/unocore/unoframe.cxx | 14 +--- sw/source/core/unocore/unoobj.cxx |3 sw/source/core/unocore/unostyle.cxx |8 +- sw/source/filter/html/htmldrawreader.cxx|8 +- sw/source/filter/html/htmltab.cxx |8 -- sw/source/uibase/app/docshini.cxx | 19 +++-- sw/source/uibase/frmdlg/frmmgr.cxx |6 - sw/source/uibase/inc/tabsh.hxx |2 sw/source/uibase/lingu/hhcwrp.cxx |6 - sw/source/uibase/shells/tabsh.cxx | 10 +- sw/source/uibase/uiview/viewsrch.cxx| 14 +--- 29 files changed, 147 insertions(+), 190 deletions(-) New commits: commit 3fec689480644c274501740013ff83388cb24245 Author: Noel Grandin AuthorDate: Fri Jul 16 08:50:39 2021 +0200 Commit: Noel Grandin CommitDate: Sat Jul 17 17:44:50 2021 +0200 use WhichRangesContainer in sw Change-Id: I8662b2e03b0dbe3a7206d8b59ae3556e3b2e75a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119007 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/sw/inc/charfmt.hxx b/sw/inc/charfmt.hxx index 27d6e5c0f896..b42dd303e953 100644 --- a/sw/inc/charfmt.hxx +++ b/sw/inc/charfmt.hxx @@ -29,7 +29,7 @@ class SwCharFormat final : public SwFormat SwCharFormat( SwAttrPool& rPool, const OUString , SwCharFormat *pDerivedFrom ) - : SwFormat( rPool, rFormatName, aCharFormatSetRange, pDerivedFrom, RES_CHRFMT ) + : SwFormat( rPool, rFormatName, , pDerivedFrom, RES_CHRFMT ) {} public: diff --git a/sw/inc/fmtcol.hxx b/sw/inc/fmtcol.hxx index 10a41b9d9b78..2ea13c159cae 100644 --- a/sw/inc/fmtcol.hxx +++ b/sw/inc/fmtcol.hxx @@ -36,13 +36,13 @@ class SAL_DLLPUBLIC_RTTI SwFormatColl: public SwFormat { protected: SwFormatColl( SwAttrPool& rPool, const char* pFormatName, -const sal_uInt16* pWhichRanges, SwFormatColl* pDerFrom, +const WhichRangesContainer* pWhichRanges, SwFormatColl* pDerFrom, sal_uInt16 nFormatWhich ) : SwFormat( rPool, pFormatName, pWhichRanges, pDerFrom, nFormatWhich ) { SetAuto(false); } SwFormatColl( SwAttrPool& rPool, const OUString , -const sal_uInt16* pWhichRanges, SwFormatColl* pDerFrom, +const WhichRangesContainer* pWhichRanges, SwFormatColl* pDerFrom, sal_uInt16 nFormatWhich ) : SwFormat( rPool, rFormatName, pWhichRanges, pDerFrom, nFormatWhich ) { SetAuto(false); } @@ -74,7 +74,7 @@ protected: SwTextFormatColl( SwAttrPool& rPool, const char* pFormatCollName, SwTextFormatColl* pDerFrom = nullptr, sal_uInt16 nFormatWh = RES_TXTFMTCOLL ) -: SwFormatColl(rPool, pFormatCollName, aTextFormatCollSetRange, pDerFrom, nFormatWh) +: SwFormatColl(rPool, pFormatCollName, , pDerFrom, nFormatWh) , mbStayAssignedToListLevelOfOutlineStyle(false) , mbAssignedToOutlineStyle(false) , m_bInSwFntCache(false) @@ -85,7 +85,7 @@ protected: SwTextFormatColl( SwAttrPool& rPool, const OUString , SwTextFormatColl* pDerFrom, sal_uInt16 nFormatWh = RES_TXTFMTCOLL ) -: SwFormatColl(rPool, rFormatCollName, aTextFormatCollSetRange, pDerFrom, nFormatWh) +: SwFormatColl(rPool, rFormatCollName, , pDerFrom, nFormatWh) , mbStayAssignedToListLevelOfOutlineStyle(false) , mbAssignedToOutlineStyle(false) , m_bInSwFntCache(false) @@ -170,13 +170,13 @@ class SwGrfFormatColl final : public SwFormatColl SwGrfFormatColl( SwAttrPool& rPool, const char* pFormatCollName, SwGrfFormatColl* pDerFrom = nullptr ) -: SwFormatColl( rPool, pFormatCollName, aGrfFormatCollSetRange, +: SwFormatColl( rPool,
[Libreoffice-bugs] [Bug 143298] Writer: CTRL-TAB to cycle through suggestions for word completion does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=143298 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #5 from Buovjaga --- Please launch from the command line with SAL_USE_VCLPLUGIN=gen libreoffice -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143383] FILEOPEN DOC: wrap is tight in Writer but not in Word
https://bugs.documentfoundation.org/show_bug.cgi?id=143383 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Blocks||120468 CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #1 from Buovjaga --- There is 3 char margin on the left and 2 char on the right, so it is not as bad in the screenshot. Still not fully tight. NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=120468 [Bug 120468] [META] DOC (binary) anchor and text wrapping bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 120468] [META] DOC (binary) anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120468 Buovjaga changed: What|Removed |Added Depends on||143383 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143383 [Bug 143383] FILEOPEN DOC: wrap is tight in Writer but not in Word -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143381] Calc hangs if properties panel is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=143381 --- Comment #4 from Tim Anderson --- Version: 7.2.0.1 (x64) / LibreOffice Community Build ID: 32efc3b7f3a71cfa6a7fa3f6c208333df48656cc CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_GB); UI: en-GB Calc: CL -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 108382] [META] Borders bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108382 Buovjaga changed: What|Removed |Added Depends on||143338 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143338 [Bug 143338] Dotted text box border lines showing as continuous line on certain zoom-levels for some or all borders on DOCX file (fine with ODT/DOC) -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143338] Dotted text box border lines showing as continuous line on certain zoom-levels for some or all borders on DOCX file (fine with ODT/DOC)
https://bugs.documentfoundation.org/show_bug.cgi?id=143338 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEW Keywords||filter:docx Blocks||108382 Ever confirmed|0 |1 CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #6 from Buovjaga --- Confirmed NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108382 [Bug 108382] [META] Borders bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 143381] Calc hangs if properties panel is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=143381 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #3 from Buovjaga --- Created attachment 173650 --> https://bugs.documentfoundation.org/attachment.cgi?id=173650=edit Video showing the problem Tim: please paste here your version information from LibreOffice's Help - About dialog, clicking the button next to Version Information. -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/notebookbar/SfxNotebookBar.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 18387b547ffbab2d19ab4968ea8194f7aee07192 Author: Szymon Kłos AuthorDate: Mon Jul 12 12:24:09 2021 +0200 Commit: Szymon Kłos CommitDate: Sat Jul 17 17:33:11 2021 +0200 Revert "Notebookbar: skip early init in all apps" This reverts commit 6af0a488a059982a8b5d72fe399c7e8841a2e9b4. Delayed notebookbar init in Calc causes "number format" combobox to not work. (it works after some number is typed into document only). Original problem fixed by reverted change doesn't exist anymore because new shortcuts for paste special and paste unformatted text were introduced Change-Id: Ie112ae0df7b6d3782916b98c96f1a17b15396115 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118771 Tested-by: Jenkins CollaboraOffice Reviewed-by: Pranam Lashkari Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119101 Tested-by: Jenkins Reviewed-by: Szymon Kłos diff --git a/sfx2/source/notebookbar/SfxNotebookBar.cxx b/sfx2/source/notebookbar/SfxNotebookBar.cxx index fb90113f9f05..ce7c416a8c39 100644 --- a/sfx2/source/notebookbar/SfxNotebookBar.cxx +++ b/sfx2/source/notebookbar/SfxNotebookBar.cxx @@ -353,7 +353,8 @@ bool SfxNotebookBar::StateMethod(SystemWindow* pSysWindow, // * in LOK: Paste Special feature was incorrectly initialized // Skip first request so Notebookbar will be initialized after document was loaded static std::map bSkippedFirstInit; -if (comphelper::LibreOfficeKit::isActive() && bSkippedFirstInit.find(pViewShell) == bSkippedFirstInit.end()) +if (comphelper::LibreOfficeKit::isActive() && eApp == vcl::EnumContext::Application::Writer +&& bSkippedFirstInit.find(pViewShell) == bSkippedFirstInit.end()) { bSkippedFirstInit[pViewShell] = true; return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 142750] Text area loses focus when pressing the Format Painter button
https://bugs.documentfoundation.org/show_bug.cgi?id=142750 Buovjaga changed: What|Removed |Added Whiteboard| QA:needsComment| --- Comment #2 from Buovjaga --- Repro. Leaving unconfirmed as UX team was summoned NixOS Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: b1df9c67349cf4cc5be4128d797aefb87f50e38f CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: x11 Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs