[Libreoffice-bugs] [Bug 142779] PRINTING from Draw is missing objects
https://bugs.documentfoundation.org/show_bug.cgi?id=142779 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140578] Programs lose styles when run as different user
https://bugs.documentfoundation.org/show_bug.cgi?id=140578 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142587] 7.1.3.2:: Build fails with boost.75.0
https://bugs.documentfoundation.org/show_bug.cgi?id=142587 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142706] Shift+Ctrl+S (Special Characters) not working in Find & Replace in Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=142706 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142705] [DOCUMENTATION] Shortcut Keys shifted
https://bugs.documentfoundation.org/show_bug.cgi?id=142705 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142577] VIEWING: missing graphic linked object from excel
https://bugs.documentfoundation.org/show_bug.cgi?id=142577 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141694] Cursor flicks and return to base state when selecting text
https://bugs.documentfoundation.org/show_bug.cgi?id=141694 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142575] Libreoffice impress right-ckeck menu disappears
https://bugs.documentfoundation.org/show_bug.cgi?id=142575 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141711] LO Writer creates Turkish alphabetical index in wrong sort order
https://bugs.documentfoundation.org/show_bug.cgi?id=141711 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139885] Modify button sometimes not available when trying to assign a shortcut to a macro in CALC
https://bugs.documentfoundation.org/show_bug.cgi?id=139885 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141656] Problems with synced Google drive folder while using LibreOffice.
https://bugs.documentfoundation.org/show_bug.cgi?id=141656 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141888] Crash on undo while in IM pre-selection in Calc, Impress and Math
https://bugs.documentfoundation.org/show_bug.cgi?id=141888 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142545] Unreadable animation sequence
https://bugs.documentfoundation.org/show_bug.cgi?id=142545 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139872] Page style printing paper is not reflected
https://bugs.documentfoundation.org/show_bug.cgi?id=139872 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139673] EDITING: Selection of words by double click and mouse move in Calc comments
https://bugs.documentfoundation.org/show_bug.cgi?id=139673 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143015] Calc Issue with the [Text Language] section of the status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=143015 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139300] Button OK isn't active when you try load content from external source
https://bugs.documentfoundation.org/show_bug.cgi?id=139300 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138495] Removed duplicate lines from spelling dictionaries
https://bugs.documentfoundation.org/show_bug.cgi?id=138495 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139025] FILEOPEN. Unable to access file as writeable on local share
https://bugs.documentfoundation.org/show_bug.cgi?id=139025 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143015] Calc Issue with the [Text Language] section of the status bar
https://bugs.documentfoundation.org/show_bug.cgi?id=143015 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143380] Polish language: Avoid putting conjunctions like "i" "a" "o" at the end of a line
https://bugs.documentfoundation.org/show_bug.cgi?id=143380 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143014] Issue with Icon Sizing
https://bugs.documentfoundation.org/show_bug.cgi?id=143014 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143014] Issue with Icon Sizing
https://bugs.documentfoundation.org/show_bug.cgi?id=143014 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141485] Flashing UI of sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=141485 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141485] Flashing UI of sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=141485 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139138] [UI] The format cell dialog shows 7 line styles, the Border Style button shows 14
https://bugs.documentfoundation.org/show_bug.cgi?id=139138 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139112] libreoffice does not remember the dimensions of the settings window
https://bugs.documentfoundation.org/show_bug.cgi?id=139112 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139138] [UI] The format cell dialog shows 7 line styles, the Border Style button shows 14
https://bugs.documentfoundation.org/show_bug.cgi?id=139138 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138468] Cell background color selection widget UI in side-bar now extra step of palette selection droplist
https://bugs.documentfoundation.org/show_bug.cgi?id=138468 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139112] libreoffice does not remember the dimensions of the settings window
https://bugs.documentfoundation.org/show_bug.cgi?id=139112 --- Comment #6 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138468] Cell background color selection widget UI in side-bar now extra step of palette selection droplist
https://bugs.documentfoundation.org/show_bug.cgi?id=138468 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135961] Screen corruption when changing screen DPI
https://bugs.documentfoundation.org/show_bug.cgi?id=135961 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135961] Screen corruption when changing screen DPI
https://bugs.documentfoundation.org/show_bug.cgi?id=135961 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 45947] EDITING: Autoincrement in external HSQLDB could not be created in GUI - wrong SQL-Code
https://bugs.documentfoundation.org/show_bug.cgi?id=45947 --- Comment #15 from QA Administrators --- Dear Robert Großkopf, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42905] Wizard table: Remove autovalue from step2 which doesn't work since there's already autovalue in step3 which works.
https://bugs.documentfoundation.org/show_bug.cgi?id=42905 --- Comment #18 from QA Administrators --- Dear Jurgen, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118640] Editing a Base file results in unreadable total record count.
https://bugs.documentfoundation.org/show_bug.cgi?id=118640 --- Comment #10 from QA Administrators --- Dear mitchell93210, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114194] RTL: Keyboard navigation between textboxes not in logical order in various slide layouts
https://bugs.documentfoundation.org/show_bug.cgi?id=114194 --- Comment #7 from QA Administrators --- Dear Yousuf Philips (jay) (retired), To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140322] Calc subtotals: can't only show the last line (grand sum)
https://bugs.documentfoundation.org/show_bug.cgi?id=140322 BogdanB changed: What|Removed |Added OS|Windows (All) |All Blocks||109330 --- Comment #10 from BogdanB --- Wrong also in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14 Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=109330 [Bug 109330] [META] Subtotal function bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109330] [META] Subtotal function bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109330 BogdanB changed: What|Removed |Added Depends on||140322 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140322 [Bug 140322] Calc subtotals: can't only show the last line (grand sum) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/inc drawinglayer/qa drawinglayer/source include/drawinglayer include/svx sc/source sd/source sfx2/source svgio/source
Rebased ref, commits from common ancestor: commit d6647423200494727b7a09c2c92c9d8ba504592b Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 20:52:36 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Sat Jul 31 14:43:11 2021 +0900 make BasePrimitive2D easier extensible with VisitingParameters BasePrimitive2D virtual methods get2DDecomposition and getB2DRange are used in many subclasses of BasePrimitive2D. If we want to extend the parameters that we want to pass to those classes (and we will need to in the future changes) we need to change all the subclasses too. So this commit intoduces VisitingParameters class, which holds the parameters that we want to pass, which avoids the need to extend the BasePrimitive2D API. The only member of VisitingParameters is ViewInformation2D, which was previously a parameter for both methods. Change-Id: I39afc28707f1511aafce4e8a84dbc45b84fc8cd5 diff --git a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx index 86297687ad5f..b0135ffb25e7 100644 --- a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx @@ -82,7 +82,7 @@ namespace drawinglayer::primitive2d virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; /// local decomposition -virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, VisitingParameters const & rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; diff --git a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx index ce62b3110199..59d0bb954d25 100644 --- a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx @@ -57,9 +57,8 @@ private: basegfx::B2DHomMatrix maLastObjectToViewTransformation; /// create local decomposition -virtual void -create2DDecomposition(Primitive2DContainer& rContainer, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, + VisitingParameters const& rParameters) const override; public: /// constructor @@ -80,16 +79,14 @@ public: by a fixed discrete unit, thus the contained geometry needs only once be asked for its own basegfx::B2DRange */ -virtual basegfx::B2DRange -getB2DRange(const geometry::ViewInformation2D& rViewInformation) const override; +virtual basegfx::B2DRange getB2DRange(VisitingParameters const& rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; /// Override standard getDecomposition to be view-dependent here -virtual void -get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, +VisitingParameters const& rParameters) const override; }; } // end of namespace primitive2d::drawinglayer diff --git a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx index 423be7995879..a8818fab6675 100644 --- a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer::primitive2d basegfx::BColor maLineColor; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, VisitingParameters const & rParameters) const override; public: /// constructor diff --git a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx index 9b93e28dbe0d..381e130f6d9d 100644 --- a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx @@ -68,7 +68,7 @@ namespace drawinglayer::primitive2d css::lang::Locale maLocale; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void
[Libreoffice-bugs] [Bug 112976] [META] DOCX (OOXML) OLE object-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112976 Bug 112976 depends on bug 142970, which changed state. Bug 142970 Summary: This OLE object looks blurry https://bugs.documentfoundation.org/show_bug.cgi?id=142970 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135999] Formula resolution is too low
https://bugs.documentfoundation.org/show_bug.cgi?id=135999 BogdanB changed: What|Removed |Added CC||bbo...@gmail.com --- Comment #12 from BogdanB --- *** Bug 142970 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142970] This OLE object looks blurry
https://bugs.documentfoundation.org/show_bug.cgi?id=142970 BogdanB changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from BogdanB --- *** This bug has been marked as a duplicate of bug 135999 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 BogdanB changed: What|Removed |Added Depends on||142805 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142805 [Bug 142805] DOCX image lost on roundtrip -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142805] DOCX image lost on roundtrip
https://bugs.documentfoundation.org/show_bug.cgi?id=142805 BogdanB changed: What|Removed |Added Blocks||108741 Keywords||filter:docx CC||buzea.bog...@libreoffice.or ||g --- Comment #4 from BogdanB --- Also in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14 Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143135] Impress crashes when switching to another application then back (kf5 on Wayland)
https://bugs.documentfoundation.org/show_bug.cgi?id=143135 --- Comment #12 from Buovjaga --- (In reply to dennis.bayrock from comment #11) > I realize that we are making an assignment of SAL_USE_VCLPLUGIN to gtk3 in > the environment prior to running libreoffice. Curious, can someone explain > what SAL_USE_VCLPLUGIN actually is? It is forcing a certain VCL UI backend: https://docs.libreoffice.org/vcl.html -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141773] Autocorrection for all languages
https://bugs.documentfoundation.org/show_bug.cgi?id=141773 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||103341 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 BogdanB changed: What|Removed |Added Depends on||141773 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141773 [Bug 141773] Autocorrection for all languages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/inc drawinglayer/qa drawinglayer/source include/drawinglayer include/svx sc/source sd/source sfx2/source svgio/source
Rebased ref, commits from common ancestor: commit 00d010d4a31683c419b71a15e228ae98042f6456 Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 20:52:36 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Sat Jul 31 14:26:17 2021 +0900 make BasePrimitive2D easier extensible with VisitingParameters BasePrimitive2D virtual methods get2DDecomposition and getB2DRange are used in many subclasses of BasePrimitive2D. If we want to extend the parameters that we want to pass to those classes (and we will need to in the future changes) we need to change all the subclasses too. So this commit intoduces VisitingParameters class, which holds the parameters that we want to pass, which avoids the need to extend the BasePrimitive2D API. The only member of VisitingParameters is ViewInformation2D, which was previously a parameter for both methods. Change-Id: I39afc28707f1511aafce4e8a84dbc45b84fc8cd5 diff --git a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx index 86297687ad5f..b0135ffb25e7 100644 --- a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx @@ -82,7 +82,7 @@ namespace drawinglayer::primitive2d virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; /// local decomposition -virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, VisitingParameters const & rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; diff --git a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx index ce62b3110199..59d0bb954d25 100644 --- a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx @@ -57,9 +57,8 @@ private: basegfx::B2DHomMatrix maLastObjectToViewTransformation; /// create local decomposition -virtual void -create2DDecomposition(Primitive2DContainer& rContainer, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, + VisitingParameters const& rParameters) const override; public: /// constructor @@ -80,16 +79,14 @@ public: by a fixed discrete unit, thus the contained geometry needs only once be asked for its own basegfx::B2DRange */ -virtual basegfx::B2DRange -getB2DRange(const geometry::ViewInformation2D& rViewInformation) const override; +virtual basegfx::B2DRange getB2DRange(VisitingParameters const& rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; /// Override standard getDecomposition to be view-dependent here -virtual void -get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, +VisitingParameters const& rParameters) const override; }; } // end of namespace primitive2d::drawinglayer diff --git a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx index 423be7995879..a8818fab6675 100644 --- a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer::primitive2d basegfx::BColor maLineColor; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, VisitingParameters const & rParameters) const override; public: /// constructor diff --git a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx index 9b93e28dbe0d..381e130f6d9d 100644 --- a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx @@ -68,7 +68,7 @@ namespace drawinglayer::primitive2d css::lang::Locale maLocale; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void
[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 BogdanB changed: What|Removed |Added Depends on||136787 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=136787 [Bug 136787] FILEOPEN: Incorrect Shadow shape -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136787] FILEOPEN: Incorrect Shadow shape
https://bugs.documentfoundation.org/show_bug.cgi?id=136787 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||108741 --- Comment #2 from BogdanB --- Also in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14 Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108741 [Bug 108741] [META] Shapes bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/inc drawinglayer/qa drawinglayer/source include/drawinglayer include/svx sc/source sd/source sfx2/source svgio/source
Rebased ref, commits from common ancestor: commit 4a256dd4c413cc3f4b97013f3f19aeae04ab0522 Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 20:52:36 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Sat Jul 31 14:23:47 2021 +0900 make BasePrimitive2D easier extensible with VisitingParameters BasePrimitive2D virtual methods get2DDecomposition and getB2DRange are used in many subclasses of BasePrimitive2D. If we want to extend the parameters that we want to pass to those classes (and we will need to in the future changes) we need to change all the subclasses too. So this commit intoduces VisitingParameters class, which holds the parameters that we want to pass, which avoids the need to extend the BasePrimitive2D API. The only member of VisitingParameters is ViewInformation2D, which was previously a parameter for both methods. Change-Id: I39afc28707f1511aafce4e8a84dbc45b84fc8cd5 diff --git a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx index 86297687ad5f..b0135ffb25e7 100644 --- a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx @@ -82,7 +82,7 @@ namespace drawinglayer::primitive2d virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; /// local decomposition -virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, VisitingParameters const & rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; diff --git a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx index ce62b3110199..59d0bb954d25 100644 --- a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx @@ -57,9 +57,8 @@ private: basegfx::B2DHomMatrix maLastObjectToViewTransformation; /// create local decomposition -virtual void -create2DDecomposition(Primitive2DContainer& rContainer, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, + VisitingParameters const& rParameters) const override; public: /// constructor @@ -80,16 +79,14 @@ public: by a fixed discrete unit, thus the contained geometry needs only once be asked for its own basegfx::B2DRange */ -virtual basegfx::B2DRange -getB2DRange(const geometry::ViewInformation2D& rViewInformation) const override; +virtual basegfx::B2DRange getB2DRange(VisitingParameters const& rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; /// Override standard getDecomposition to be view-dependent here -virtual void -get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, +VisitingParameters const& rParameters) const override; }; } // end of namespace primitive2d::drawinglayer diff --git a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx index 423be7995879..a8818fab6675 100644 --- a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer::primitive2d basegfx::BColor maLineColor; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, VisitingParameters const & rParameters) const override; public: /// constructor diff --git a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx index 9b93e28dbe0d..381e130f6d9d 100644 --- a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx @@ -68,7 +68,7 @@ namespace drawinglayer::primitive2d css::lang::Locale maLocale; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void
[Libreoffice-bugs] [Bug 108288] [META] Bookmark bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108288 BogdanB changed: What|Removed |Added Depends on||140645 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140645 [Bug 140645] Undo breaks bookmark fields -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 BogdanB changed: What|Removed |Added Depends on||140645 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140645 [Bug 140645] Undo breaks bookmark fields -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140645] Undo breaks bookmark fields
https://bugs.documentfoundation.org/show_bug.cgi?id=140645 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||105948, 108288 --- Comment #6 from BogdanB --- Repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14 Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=108288 [Bug 108288] [META] Bookmark bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/inc drawinglayer/qa drawinglayer/source include/drawinglayer include/svx sc/source sd/source sfx2/source svgio/source
Rebased ref, commits from common ancestor: commit d5b7f03756a38dd39ad5e300f0db4eb84948598c Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 20:52:36 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Sat Jul 31 14:19:45 2021 +0900 make BasePrimitive2D easier extensible with VisitingParameters BasePrimitive2D virtual methods get2DDecomposition and getB2DRange are used in many subclasses of BasePrimitive2D. If we want to extend the parameters that we want to pass to those classes (and we will need to in the future changes) we need to change all the subclasses too. So this commit intoduces VisitingParameters class, which holds the parameters that we want to pass, which avoids the need to extend the BasePrimitive2D API. The only member of VisitingParameters is ViewInformation2D, which was previously a parameter for both methods. Change-Id: I39afc28707f1511aafce4e8a84dbc45b84fc8cd5 diff --git a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx index 86297687ad5f..b0135ffb25e7 100644 --- a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx @@ -82,7 +82,7 @@ namespace drawinglayer::primitive2d virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; /// local decomposition -virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, VisitingParameters const & rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; diff --git a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx index ce62b3110199..59d0bb954d25 100644 --- a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx @@ -57,9 +57,8 @@ private: basegfx::B2DHomMatrix maLastObjectToViewTransformation; /// create local decomposition -virtual void -create2DDecomposition(Primitive2DContainer& rContainer, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, + VisitingParameters const& rParameters) const override; public: /// constructor @@ -80,16 +79,14 @@ public: by a fixed discrete unit, thus the contained geometry needs only once be asked for its own basegfx::B2DRange */ -virtual basegfx::B2DRange -getB2DRange(const geometry::ViewInformation2D& rViewInformation) const override; +virtual basegfx::B2DRange getB2DRange(VisitingParameters const& rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; /// Override standard getDecomposition to be view-dependent here -virtual void -get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, +VisitingParameters const& rParameters) const override; }; } // end of namespace primitive2d::drawinglayer diff --git a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx index 423be7995879..a8818fab6675 100644 --- a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer::primitive2d basegfx::BColor maLineColor; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, VisitingParameters const & rParameters) const override; public: /// constructor diff --git a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx index 9b93e28dbe0d..381e130f6d9d 100644 --- a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx @@ -68,7 +68,7 @@ namespace drawinglayer::primitive2d css::lang::Locale maLocale; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void
[Libreoffice-bugs] [Bug 142966] File->New text doc, Format->Page Style->Text direction Right to Left + Right margin set to 0, Inserted text box will disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=142966 BogdanB changed: What|Removed |Added Blocks||113064 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=113064 [Bug 113064] [META] RTL/CTL textbox related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113064] [META] RTL/CTL textbox related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113064 BogdanB changed: What|Removed |Added Depends on||142966 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=142966 [Bug 142966] File->New text doc, Format->Page Style->Text direction Right to Left + Right margin set to 0, Inserted text box will disappear -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117084] Preview in Web browser displays mangled document
https://bugs.documentfoundation.org/show_bug.cgi?id=117084 --- Comment #6 from BogdanB --- Also in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64314] [META] Macro recording issues
https://bugs.documentfoundation.org/show_bug.cgi?id=64314 BogdanB changed: What|Removed |Added Depends on||139404 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=139404 [Bug 139404] Cannot record Basic macros in Calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139404] Cannot record Basic macros in Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=139404 BogdanB changed: What|Removed |Added Blocks||64314 OS|All |Windows (All) CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=64314 [Bug 64314] [META] Macro recording issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107923] [META] Zoom issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107923 BogdanB changed: What|Removed |Added Depends on||138560 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138560 [Bug 138560] Unwanted partial border showing around inserted images. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138560] Unwanted partial border showing around inserted images.
https://bugs.documentfoundation.org/show_bug.cgi?id=138560 BogdanB changed: What|Removed |Added Blocks||107923 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107923 [Bug 107923] [META] Zoom issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114005] [META] Gradient fill bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114005 BogdanB changed: What|Removed |Added Depends on||140349 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140349 [Bug 140349] Ellipsoid Gradient fill for a paragraph not resulting in nice straight borders -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140349] Ellipsoid Gradient fill for a paragraph not resulting in nice straight borders
https://bugs.documentfoundation.org/show_bug.cgi?id=140349 BogdanB changed: What|Removed |Added Blocks||114005 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114005 [Bug 114005] [META] Gradient fill bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119620] [EDITING] Create sheet during active cell editing puts content on newly created sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=119620 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #13 from BogdanB --- Repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 5aa74aa1e6fac571f99146ebcb6adc9feb1459ad CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-28_19:35:14 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/inc drawinglayer/qa drawinglayer/source include/drawinglayer include/svx sc/source sd/source sfx2/source svgio/source
Rebased ref, commits from common ancestor: commit 60b0dd037659b59ddaecf88a117ef4e46fc659bb Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 20:52:36 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Sat Jul 31 14:05:08 2021 +0900 make BasePrimitive2D easier extensible with VisitingParameters BasePrimitive2D virtual methods get2DDecomposition and getB2DRange are used in many subclasses of BasePrimitive2D. If we want to extend the parameters that we want to pass to those classes (and we will need to in the future changes) we need to change all the subclasses too. So this commit intoduces VisitingParameters class, which holds the parameters that we want to pass, which avoids the need to extend the BasePrimitive2D API. The only member of VisitingParameters is ViewInformation2D, which was previously a parameter for both methods. Change-Id: I39afc28707f1511aafce4e8a84dbc45b84fc8cd5 diff --git a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx index 86297687ad5f..b0135ffb25e7 100644 --- a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx @@ -82,7 +82,7 @@ namespace drawinglayer::primitive2d virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; /// local decomposition -virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, VisitingParameters const & rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; diff --git a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx index ce62b3110199..59d0bb954d25 100644 --- a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx @@ -57,9 +57,8 @@ private: basegfx::B2DHomMatrix maLastObjectToViewTransformation; /// create local decomposition -virtual void -create2DDecomposition(Primitive2DContainer& rContainer, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, + VisitingParameters const& rParameters) const override; public: /// constructor @@ -80,16 +79,14 @@ public: by a fixed discrete unit, thus the contained geometry needs only once be asked for its own basegfx::B2DRange */ -virtual basegfx::B2DRange -getB2DRange(const geometry::ViewInformation2D& rViewInformation) const override; +virtual basegfx::B2DRange getB2DRange(VisitingParameters const& rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; /// Override standard getDecomposition to be view-dependent here -virtual void -get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, +VisitingParameters const& rParameters) const override; }; } // end of namespace primitive2d::drawinglayer diff --git a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx index 423be7995879..a8818fab6675 100644 --- a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer::primitive2d basegfx::BColor maLineColor; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, VisitingParameters const & rParameters) const override; public: /// constructor diff --git a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx index 9b93e28dbe0d..381e130f6d9d 100644 --- a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx @@ -68,7 +68,7 @@ namespace drawinglayer::primitive2d css::lang::Locale maLocale; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void
[Libreoffice-bugs] [Bug 133764] [META] Very large spreadsheets problem
https://bugs.documentfoundation.org/show_bug.cgi?id=133764 Aron Budea changed: What|Removed |Added Depends on|140607 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140607 [Bug 140607] LibreOffice with enabled Jumbo table feature crashes when I try open XLS file from bug 122092 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133619] [META] Regressions from increasing column limit in Calc (mainly bug 50916)
https://bugs.documentfoundation.org/show_bug.cgi?id=133619 Aron Budea changed: What|Removed |Added Depends on||140607 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=140607 [Bug 140607] LibreOffice with enabled Jumbo table feature crashes when I try open XLS file from bug 122092 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140607] LibreOffice with enabled Jumbo table feature crashes when I try open XLS file from bug 122092
https://bugs.documentfoundation.org/show_bug.cgi?id=140607 Aron Budea changed: What|Removed |Added Blocks|133764 |133619 Version|7.2.0.0.alpha0+ |7.0.4.2 release CC||ba...@caesar.elte.hu Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133619 [Bug 133619] [META] Regressions from increasing column limit in Calc (mainly bug 50916) https://bugs.documentfoundation.org/show_bug.cgi?id=133764 [Bug 133764] [META] Very large spreadsheets problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104468] [META] DOCX (OOXML) image-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104468 BogdanB changed: What|Removed |Added Depends on||138653 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=138653 [Bug 138653] SVG images look extremely bad after DOCX export or compress -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138653] SVG images look extremely bad after DOCX export or compress
https://bugs.documentfoundation.org/show_bug.cgi?id=138653 BogdanB changed: What|Removed |Added Blocks||104468 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104468 [Bug 104468] [META] DOCX (OOXML) image-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142875] FILEOPEN DOCX Shapes vertically aligned to line imported incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=142875 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Version|7.2.0.0 alpha1+ |Inherited From OOo --- Comment #3 from Aron Budea --- This was never fine, though before 7.1 the positioning of the squares were a bit closer to Word's, from left to right, vertical positions were: mid, below, above; except in LO the differences were much larger. Probably not useful information. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130503] Hard to choose a style via ctrl-f11
https://bugs.documentfoundation.org/show_bug.cgi?id=130503 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #2 from BogdanB --- Works for me in Version: 7.1.5.2 / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded Please retest this bug again. I select a paragraf. F11. And I can change with up and down arrows from keyboard to change the style from the one I used recently. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/inc drawinglayer/qa drawinglayer/source include/drawinglayer include/svx sc/source sd/source sfx2/source svgio/source
Rebased ref, commits from common ancestor: commit 7004f8c11020b692ffaa646409dbe1c514501a61 Author: Tomaž Vajngerl AuthorDate: Sat Jan 2 20:52:36 2021 +0900 Commit: Tomaž Vajngerl CommitDate: Sat Jul 31 13:47:25 2021 +0900 make BasePrimitive2D easier extensible with VisitingParameters BasePrimitive2D virtual methods get2DDecomposition and getB2DRange are used in many subclasses of BasePrimitive2D. If we want to extend the parameters that we want to pass to those classes (and we will need to in the future changes) we need to change all the subclasses too. So this commit intoduces VisitingParameters class, which holds the parameters that we want to pass, which avoids the need to extend the BasePrimitive2D API. The only member of VisitingParameters is ViewInformation2D, which was previously a parameter for both methods. Change-Id: I39afc28707f1511aafce4e8a84dbc45b84fc8cd5 diff --git a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx index 86297687ad5f..b0135ffb25e7 100644 --- a/drawinglayer/inc/primitive2d/cropprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/cropprimitive2d.hxx @@ -82,7 +82,7 @@ namespace drawinglayer::primitive2d virtual bool operator==(const BasePrimitive2D& rPrimitive) const override; /// local decomposition -virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, VisitingParameters const & rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; diff --git a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx index ce62b3110199..59d0bb954d25 100644 --- a/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx @@ -57,9 +57,8 @@ private: basegfx::B2DHomMatrix maLastObjectToViewTransformation; /// create local decomposition -virtual void -create2DDecomposition(Primitive2DContainer& rContainer, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, + VisitingParameters const& rParameters) const override; public: /// constructor @@ -80,16 +79,14 @@ public: by a fixed discrete unit, thus the contained geometry needs only once be asked for its own basegfx::B2DRange */ -virtual basegfx::B2DRange -getB2DRange(const geometry::ViewInformation2D& rViewInformation) const override; +virtual basegfx::B2DRange getB2DRange(VisitingParameters const& rParameters) const override; /// provide unique ID virtual sal_uInt32 getPrimitive2DID() const override; /// Override standard getDecomposition to be view-dependent here -virtual void -get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, - const geometry::ViewInformation2D& rViewInformation) const override; +virtual void get2DDecomposition(Primitive2DDecompositionVisitor& rVisitor, +VisitingParameters const& rParameters) const override; }; } // end of namespace primitive2d::drawinglayer diff --git a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx index 423be7995879..a8818fab6675 100644 --- a/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textlineprimitive2d.hxx @@ -41,7 +41,7 @@ namespace drawinglayer::primitive2d basegfx::BColor maLineColor; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void create2DDecomposition(Primitive2DContainer& rContainer, VisitingParameters const & rParameters) const override; public: /// constructor diff --git a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx index 9b93e28dbe0d..381e130f6d9d 100644 --- a/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx +++ b/drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx @@ -68,7 +68,7 @@ namespace drawinglayer::primitive2d css::lang::Locale maLocale; /// local decomposition. -virtual void create2DDecomposition(Primitive2DContainer& rContainer, const geometry::ViewInformation2D& rViewInformation) const override; +virtual void
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - drawinglayer/qa drawinglayer/source include/drawinglayer sc/source sfx2/source svgio/source svx/source sw/source
Rebased ref, commits from common ancestor:
commit acd7a57c335a0230c21d6c2bafaf69b3ee32a653
Author: Tomaž Vajngerl
AuthorDate: Tue Feb 23 13:23:32 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 31 13:45:38 2021 +0900
drawinglayer: make VisitingParameters constructor explicit
This discovers a bunch of cases where previously the
ViewInformation was implicitly converted into a VisitingParameter.
Change-Id: Ice233e9d3c9d12c5da284e190281a1d94059f49f
diff --git a/drawinglayer/qa/unit/border.cxx b/drawinglayer/qa/unit/border.cxx
index a3f7029b7350..801912f75825 100644
--- a/drawinglayer/qa/unit/border.cxx
+++ b/drawinglayer/qa/unit/border.cxx
@@ -66,9 +66,10 @@ CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest,
testDoubleDecompositionSolid)
aStrokeAttribute));
// Decompose it into polygons.
-drawinglayer::geometry::ViewInformation2D aView;
+const drawinglayer::geometry::ViewInformation2D aView;
+const drawinglayer::primitive2d::VisitingParameters
aVisitingParameters(aView);
drawinglayer::primitive2d::Primitive2DContainer aContainer;
-aBorder->get2DDecomposition(aContainer, aView);
+aBorder->get2DDecomposition(aContainer, aVisitingParameters);
// Make sure it results in two borders as it's a double one.
CPPUNIT_ASSERT_EQUAL(static_cast(2), aContainer.size());
@@ -91,8 +92,9 @@ CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest,
testDoublePixelProcessing)
// Create a pixel processor.
ScopedVclPtrInstance pDev;
drawinglayer::geometry::ViewInformation2D aView;
-std::unique_ptr pProcessor(
-
drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(*pDev, aView));
+const drawinglayer::primitive2d::VisitingParameters
aVisitingParameters(aView);
+auto pProcessor =
drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(
+*pDev, aVisitingParameters);
CPPUNIT_ASSERT(pProcessor);
GDIMetaFile aMetaFile;
// Start recording after the processor is created, so we can test the
pixel processor.
diff --git a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
index 98ca81433f12..59c934b88d17 100644
--- a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
+++ b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
@@ -118,6 +118,7 @@ namespace drawinglayer::unorenderer
}
const auto aViewInformation2D =
geometry::createViewInformation2D(aViewInformationSequence);
+primitive2d::VisitingParameters
aVisitingParameters(aViewInformation2D);
const sal_uInt32
nDiscreteWidth(basegfx::fround(o3tl::convert(fWidth, eRangeUnit,
o3tl::Length::in) * DPI_X));
const sal_uInt32
nDiscreteHeight(basegfx::fround(o3tl::convert(fHeight, eRangeUnit,
o3tl::Length::in) * DPI_Y));
@@ -139,7 +140,7 @@ namespace drawinglayer::unorenderer
BitmapEx aBitmapEx(
convertToBitmapEx(
xEmbedSeq,
-aViewInformation2D,
+aVisitingParameters,
nDiscreteWidth,
nDiscreteHeight,
MaximumQuadraticPixels));
diff --git a/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
b/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
index 42559bfd4390..0cfa014bb13e 100644
--- a/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
@@ -100,17 +100,19 @@ namespace drawinglayer::primitive2d
// see if buffering is wanted. If so, create buffered content in
given resolution
if(0 != mnDiscreteWidth && 0 != mnDiscreteHeight)
{
-const geometry::ViewInformation2D aViewInformation2D;
const primitive2d::Primitive2DReference xEmbedRef(
new primitive2d::TransformPrimitive2D(
basegfx::utils::createScaleB2DHomMatrix(mnDiscreteWidth, mnDiscreteHeight),
getChildren()));
const primitive2d::Primitive2DContainer xEmbedSeq { xEmbedRef
};
+const geometry::ViewInformation2D aViewInformation2D;
+primitive2d::VisitingParameters
aVisitingParameters(aViewInformation2D);
+
const BitmapEx aBitmapEx(
convertToBitmapEx(
xEmbedSeq,
-aViewInformation2D,
+aVisitingParameters,
mnDiscreteWidth,
mnDiscreteHeight,
mnDiscreteWidth * mnDiscreteHeight));
diff --git a/drawinglayer/source/primitive2d/unifiedtransparenceprimitive2d.cxx
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - 19 commits - basctl/source bridges/source canvas/source cppcanvas/source cui/source desktop/source dictionaries drawinglayer/Cppuni
Rebased ref, commits from common ancestor:
commit 6422706f1513fcffcc1d8be4957db42c1f26abe8
Author: Tomaž Vajngerl
AuthorDate: Tue Feb 23 13:23:32 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 31 13:38:34 2021 +0900
drawinglayer: make VisitingParameters constructor explicit
This discovers a bunch of cases where previously the
ViewInformation was implicitly converted into a VisitingParameter.
Change-Id: Ice233e9d3c9d12c5da284e190281a1d94059f49f
diff --git a/drawinglayer/qa/unit/border.cxx b/drawinglayer/qa/unit/border.cxx
index a3f7029b7350..801912f75825 100644
--- a/drawinglayer/qa/unit/border.cxx
+++ b/drawinglayer/qa/unit/border.cxx
@@ -66,9 +66,10 @@ CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest,
testDoubleDecompositionSolid)
aStrokeAttribute));
// Decompose it into polygons.
-drawinglayer::geometry::ViewInformation2D aView;
+const drawinglayer::geometry::ViewInformation2D aView;
+const drawinglayer::primitive2d::VisitingParameters
aVisitingParameters(aView);
drawinglayer::primitive2d::Primitive2DContainer aContainer;
-aBorder->get2DDecomposition(aContainer, aView);
+aBorder->get2DDecomposition(aContainer, aVisitingParameters);
// Make sure it results in two borders as it's a double one.
CPPUNIT_ASSERT_EQUAL(static_cast(2), aContainer.size());
@@ -91,8 +92,9 @@ CPPUNIT_TEST_FIXTURE(DrawinglayerBorderTest,
testDoublePixelProcessing)
// Create a pixel processor.
ScopedVclPtrInstance pDev;
drawinglayer::geometry::ViewInformation2D aView;
-std::unique_ptr pProcessor(
-
drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(*pDev, aView));
+const drawinglayer::primitive2d::VisitingParameters
aVisitingParameters(aView);
+auto pProcessor =
drawinglayer::processor2d::createBaseProcessor2DFromOutputDevice(
+*pDev, aVisitingParameters);
CPPUNIT_ASSERT(pProcessor);
GDIMetaFile aMetaFile;
// Start recording after the processor is created, so we can test the
pixel processor.
diff --git a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
index 98ca81433f12..59c934b88d17 100644
--- a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
+++ b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
@@ -118,6 +118,7 @@ namespace drawinglayer::unorenderer
}
const auto aViewInformation2D =
geometry::createViewInformation2D(aViewInformationSequence);
+primitive2d::VisitingParameters
aVisitingParameters(aViewInformation2D);
const sal_uInt32
nDiscreteWidth(basegfx::fround(o3tl::convert(fWidth, eRangeUnit,
o3tl::Length::in) * DPI_X));
const sal_uInt32
nDiscreteHeight(basegfx::fround(o3tl::convert(fHeight, eRangeUnit,
o3tl::Length::in) * DPI_Y));
@@ -139,7 +140,7 @@ namespace drawinglayer::unorenderer
BitmapEx aBitmapEx(
convertToBitmapEx(
xEmbedSeq,
-aViewInformation2D,
+aVisitingParameters,
nDiscreteWidth,
nDiscreteHeight,
MaximumQuadraticPixels));
diff --git a/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
b/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
index 42559bfd4390..0cfa014bb13e 100644
--- a/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx
@@ -100,17 +100,19 @@ namespace drawinglayer::primitive2d
// see if buffering is wanted. If so, create buffered content in
given resolution
if(0 != mnDiscreteWidth && 0 != mnDiscreteHeight)
{
-const geometry::ViewInformation2D aViewInformation2D;
const primitive2d::Primitive2DReference xEmbedRef(
new primitive2d::TransformPrimitive2D(
basegfx::utils::createScaleB2DHomMatrix(mnDiscreteWidth, mnDiscreteHeight),
getChildren()));
const primitive2d::Primitive2DContainer xEmbedSeq { xEmbedRef
};
+const geometry::ViewInformation2D aViewInformation2D;
+primitive2d::VisitingParameters
aVisitingParameters(aViewInformation2D);
+
const BitmapEx aBitmapEx(
convertToBitmapEx(
xEmbedSeq,
-aViewInformation2D,
+aVisitingParameters,
mnDiscreteWidth,
mnDiscreteHeight,
mnDiscreteWidth * mnDiscreteHeight));
diff --git a/drawinglayer/source/primitive2d/unifiedtransparenceprimitive2d.cxx
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - 3 commits - drawinglayer/CppunitTest_drawinglayer_border.mk drawinglayer/inc drawinglayer/Library_drawinglayercore.mk drawinglayer/
Repository.mk |1 drawinglayer/CppunitTest_drawinglayer_border.mk |1 drawinglayer/Library_drawinglayer.mk |5 drawinglayer/Library_drawinglayercore.mk | 49 drawinglayer/Module_drawinglayer.mk |1 drawinglayer/inc/pch/precompiled_drawinglayer.hxx |7 drawinglayer/inc/pch/precompiled_drawinglayercore.cxx | 12 drawinglayer/inc/pch/precompiled_drawinglayercore.hxx | 46 drawinglayer/inc/primitive2d/cropprimitive2d.hxx |2 drawinglayer/inc/primitive2d/texteffectprimitive2d.hxx| 13 drawinglayer/inc/primitive2d/textlineprimitive2d.hxx |2 drawinglayer/inc/primitive2d/textstrikeoutprimitive2d.hxx |4 drawinglayer/inc/primitive2d/wallpaperprimitive2d.hxx |4 drawinglayer/qa/unit/border.cxx | 10 drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx |3 drawinglayer/source/primitive2d/BufferedDecompositionPrimitive2D.cxx |9 drawinglayer/source/primitive2d/PolyPolygonColorPrimitive2D.cxx |4 drawinglayer/source/primitive2d/PolyPolygonGradientPrimitive2D.cxx|2 drawinglayer/source/primitive2d/PolyPolygonGraphicPrimitive2D.cxx |2 drawinglayer/source/primitive2d/PolyPolygonHairlinePrimitive2D.cxx|6 drawinglayer/source/primitive2d/PolyPolygonHatchPrimitive2D.cxx |2 drawinglayer/source/primitive2d/PolyPolygonMarkerPrimitive2D.cxx |6 drawinglayer/source/primitive2d/PolyPolygonSelectionPrimitive2D.cxx |9 drawinglayer/source/primitive2d/PolyPolygonStrokePrimitive2D.cxx |6 drawinglayer/source/primitive2d/Primitive2DContainer.cxx |5 drawinglayer/source/primitive2d/Tools.cxx |7 drawinglayer/source/primitive2d/animatedprimitive2d.cxx | 12 drawinglayer/source/primitive2d/backgroundcolorprimitive2d.cxx| 16 drawinglayer/source/primitive2d/baseprimitive2d.cxx | 40 drawinglayer/source/primitive2d/bitmapprimitive2d.cxx |3 drawinglayer/source/primitive2d/borderlineprimitive2d.cxx |2 drawinglayer/source/primitive2d/controlprimitive2d.cxx| 16 drawinglayer/source/primitive2d/cropprimitive2d.cxx |2 drawinglayer/source/primitive2d/discretebitmapprimitive2d.cxx |2 drawinglayer/source/primitive2d/discreteshadowprimitive2d.cxx |6 drawinglayer/source/primitive2d/embedded3dprimitive2d.cxx |8 drawinglayer/source/primitive2d/epsprimitive2d.cxx|4 drawinglayer/source/primitive2d/fillgradientprimitive2d.cxx |4 drawinglayer/source/primitive2d/fillgraphicprimitive2d.cxx|4 drawinglayer/source/primitive2d/fillhatchprimitive2d.cxx | 10 drawinglayer/source/primitive2d/glowprimitive2d.cxx |5 drawinglayer/source/primitive2d/graphicprimitive2d.cxx|5 drawinglayer/source/primitive2d/graphicprimitivehelper2d.cxx |6 drawinglayer/source/primitive2d/gridprimitive2d.cxx | 16 drawinglayer/source/primitive2d/groupprimitive2d.cxx |2 drawinglayer/source/primitive2d/helplineprimitive2d.cxx |9 drawinglayer/source/primitive2d/hiddengeometryprimitive2d.cxx |7 drawinglayer/source/primitive2d/markerarrayprimitive2d.cxx|8 drawinglayer/source/primitive2d/maskprimitive2d.cxx |2 drawinglayer/source/primitive2d/mediaprimitive2d.cxx |8 drawinglayer/source/primitive2d/metafileprimitive2d.cxx |8 drawinglayer/source/primitive2d/pagepreviewprimitive2d.cxx|6 drawinglayer/source/primitive2d/patternfillprimitive2d.cxx| 22 drawinglayer/source/primitive2d/pointarrayprimitive2d.cxx |2 drawinglayer/source/primitive2d/polygonprimitive2d.cxx| 56 drawinglayer/source/primitive2d/primitivetools2d.cxx | 26 drawinglayer/source/primitive2d/sceneprimitive2d.cxx | 23 drawinglayer/source/primitive2d/shadowprimitive2d.cxx |6 drawinglayer/source/primitive2d/softedgeprimitive2d.cxx |7 drawinglayer/source/primitive2d/svggradientprimitive2d.cxx| 12 drawinglayer/source/primitive2d/textdecoratedprimitive2d.cxx |8 drawinglayer/source/primitive2d/texteffectprimitive2d.cxx | 26 drawinglayer/source/primitive2d/textlineprimitive2d.cxx |2
[Libreoffice-commits] core.git: drawinglayer/source include/drawinglayer svx/source
drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx |2
drawinglayer/source/geometry/viewinformation2d.cxx | 284 ---
drawinglayer/source/primitive2d/Tools.cxx|6
drawinglayer/source/primitive2d/baseprimitive2d.cxx |4
drawinglayer/source/processor2d/baseprocessor2d.cxx |4
include/drawinglayer/geometry/viewinformation2d.hxx | 38 -
svx/source/sdr/contact/objectcontact.cxx |2
svx/source/sdr/overlay/overlaymanager.cxx|2
svx/source/sdr/primitive2d/sdrdecompositiontools.cxx |3
9 files changed, 141 insertions(+), 204 deletions(-)
New commits:
commit d5765ae2f9236c8ce32d61f05f46d9d76b991544
Author: Tomaž Vajngerl
AuthorDate: Fri Jul 23 16:31:02 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 31 06:35:49 2021 +0200
drawinglayer: extract Prop. Value conversion from ViewInformation2D
ViewInformation2D doesn't need to know anything about the Sequence
of PropertyValue that is used for parameters when constructing it
through UNO API. This can be done outside of ViewInfromation2D and
it doesn't need to be responsible for that internally inside the
ViewInformation2D. With this we get ViewInformation2D, which is much
simpler and isn't prone to YAGNI.
Change-Id: I3836237a1d26e38145b52136c3204931ae7c6b79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119721
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
index 63b4ffd6986d..98ca81433f12 100644
--- a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
+++ b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
@@ -117,7 +117,7 @@ namespace drawinglayer::unorenderer
MaximumQuadraticPixels = 50;
}
-const geometry::ViewInformation2D
aViewInformation2D(aViewInformationSequence);
+const auto aViewInformation2D =
geometry::createViewInformation2D(aViewInformationSequence);
const sal_uInt32
nDiscreteWidth(basegfx::fround(o3tl::convert(fWidth, eRangeUnit,
o3tl::Length::in) * DPI_X));
const sal_uInt32
nDiscreteHeight(basegfx::fround(o3tl::convert(fHeight, eRangeUnit,
o3tl::Length::in) * DPI_Y));
diff --git a/drawinglayer/source/geometry/viewinformation2d.cxx
b/drawinglayer/source/geometry/viewinformation2d.cxx
index 5b276cf52a59..94def8eda93c 100644
--- a/drawinglayer/source/geometry/viewinformation2d.cxx
+++ b/drawinglayer/source/geometry/viewinformation2d.cxx
@@ -84,162 +84,24 @@ protected:
// Viewport, VisualizedPage or ViewTime
uno::Sequence mxExtendedInformation;
-void impInterpretPropertyValues(const uno::Sequence&
rViewParameters)
-{
-if (!rViewParameters.hasElements())
-return;
-
-const sal_Int32 nCount(rViewParameters.getLength());
-sal_Int32 nExtendedInsert(0);
-
-// prepare extended information for filtering. Maximum size is nCount
-mxExtendedInformation.realloc(nCount);
-
-for (sal_Int32 a(0); a < nCount; a++)
-{
-const beans::PropertyValue& rProp = rViewParameters[a];
-
-if (rProp.Name == g_PropertyName_ReducedDisplayQuality)
-{
-// extra information; add to filtered information
-mxExtendedInformation[nExtendedInsert++] = rProp;
-
-// for performance reasons, also cache content locally
-bool bSalBool(false);
-rProp.Value >>= bSalBool;
-mbReducedDisplayQuality = bSalBool;
-}
-else if (rProp.Name == g_PropertyName_ObjectTransformation)
-{
-css::geometry::AffineMatrix2D aAffineMatrix2D;
-rProp.Value >>= aAffineMatrix2D;
-
basegfx::unotools::homMatrixFromAffineMatrix(maObjectTransformation,
- aAffineMatrix2D);
-}
-else if (rProp.Name == g_PropertyName_ViewTransformation)
-{
-css::geometry::AffineMatrix2D aAffineMatrix2D;
-rProp.Value >>= aAffineMatrix2D;
-
basegfx::unotools::homMatrixFromAffineMatrix(maViewTransformation,
aAffineMatrix2D);
-}
-else if (rProp.Name == g_PropertyName_Viewport)
-{
-css::geometry::RealRectangle2D aViewport;
-rProp.Value >>= aViewport;
-maViewport =
basegfx::unotools::b2DRectangleFromRealRectangle2D(aViewport);
-}
-else if (rProp.Name == g_PropertyName_Time)
-{
-rProp.Value >>= mfViewTime;
-}
-else if
[Libreoffice-bugs] [Bug 142762] Charts in Gnumeric spreadsheet are not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=142762 Aron Budea changed: What|Removed |Added OS|Windows (All) |All Hardware|x86-64 (AMD64) |All Version|7.2.0.0 alpha1+ |Inherited From OOo --- Comment #4 from Aron Budea --- The file only started getting imported with LO 5.1.0.3, and there the charts were already missing, so we can safely assume this never worked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142762] Charts in Gnumeric spreadsheet are not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=142762 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Attachment #172766|application/gzip|application/x-gnumeric mime type|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143490] COVID-119 & Covid-119 should fail spell-check
https://bugs.documentfoundation.org/show_bug.cgi?id=143490 Shantanu changed: What|Removed |Added CC||shantanu@gmail.com --- Comment #5 from Shantanu --- Or you can add an entry in auto-correct: COVID-119 >> COVID-19 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: drawinglayer/source include/drawinglayer sc/source svx/source sw/source
drawinglayer/source/geometry/viewinformation2d.cxx | 51 +--
drawinglayer/source/processor2d/contourextractor2d.cxx |3
drawinglayer/source/processor2d/hittestprocessor2d.cxx |3
drawinglayer/source/processor2d/linegeometryextractor2d.cxx |3
drawinglayer/source/processor2d/textaspolygonextractor2d.cxx |3
drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx |6 -
drawinglayer/source/processor2d/vclprocessor2d.cxx |6 -
include/drawinglayer/geometry/viewinformation2d.hxx | 13 --
sc/source/ui/view/output.cxx |3
svx/source/dialog/pagectrl.cxx |3
svx/source/dialog/weldeditview.cxx |3
svx/source/sdr/contact/objectcontactofobjlistpainter.cxx |3
svx/source/sdr/contact/objectcontactofpageview.cxx |3
svx/source/sdr/contact/viewobjectcontactofpageobj.cxx|3
svx/source/sdr/overlay/overlaymanager.cxx|3
sw/source/core/doc/notxtfrm.cxx |3
sw/source/core/layout/paintfrm.cxx |6 -
17 files changed, 25 insertions(+), 93 deletions(-)
New commits:
commit 13efd364c046b8064f03cb23bb232f42a892d601
Author: Tomaž Vajngerl
AuthorDate: Thu Jul 22 18:06:30 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 31 06:23:54 2021 +0200
drawinglayer: remove extendedInformation from ViewInformation2D
We actually never use extended information when normally using
the ViewInformation2D. The exception here is when we construct it
from property values, where the unknown property values are then
stored into the extended information sequence and then later
reconstructed when we convert it back to a sequence of property
values. Just for that case we don't neeed to expose the extended
information to the outside and create it, as that is then a
implementation detail for the UNO use case.
I am also not convinced we need it when creating ViewInformation2D
with the sequence of property values - it certantly not expected
that we need to preserve the property values at all, but that is
something that needs to be checked.
Change-Id: I3b8d533cd412aac8b89ca2921738d6487be5cf45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119720
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/drawinglayer/source/geometry/viewinformation2d.cxx
b/drawinglayer/source/geometry/viewinformation2d.cxx
index 5067a33f2f75..5b276cf52a59 100644
--- a/drawinglayer/source/geometry/viewinformation2d.cxx
+++ b/drawinglayer/source/geometry/viewinformation2d.cxx
@@ -221,51 +221,25 @@ public:
ImpViewInformation2D(const basegfx::B2DHomMatrix& rObjectTransformation,
const basegfx::B2DHomMatrix& rViewTransformation,
const basegfx::B2DRange& rViewport,
- const uno::Reference& rxDrawPage,
double fViewTime,
- const uno::Sequence&
rExtendedParameters)
+ const uno::Reference& rxDrawPage,
double fViewTime)
: maObjectTransformation(rObjectTransformation)
, maViewTransformation(rViewTransformation)
-, maObjectToViewTransformation()
-, maInverseObjectToViewTransformation()
, maViewport(rViewport)
-, maDiscreteViewport()
, mxVisualizedPage(rxDrawPage)
, mfViewTime(fViewTime)
, mbReducedDisplayQuality(false)
-, mxViewInformation()
-, mxExtendedInformation()
{
-impInterpretPropertyValues(rExtendedParameters);
}
explicit ImpViewInformation2D(const uno::Sequence&
rViewParameters)
-: maObjectTransformation()
-, maViewTransformation()
-, maObjectToViewTransformation()
-, maInverseObjectToViewTransformation()
-, maViewport()
-, maDiscreteViewport()
-, mxVisualizedPage()
-, mfViewTime()
-, mbReducedDisplayQuality(false)
+: mbReducedDisplayQuality(false)
, mxViewInformation(rViewParameters)
-, mxExtendedInformation()
{
impInterpretPropertyValues(rViewParameters);
}
ImpViewInformation2D()
-: maObjectTransformation()
-, maViewTransformation()
-, maObjectToViewTransformation()
-, maInverseObjectToViewTransformation()
-, maViewport()
-, maDiscreteViewport()
-, mxVisualizedPage()
-, mfViewTime()
-, mbReducedDisplayQuality(false)
-, mxViewInformation()
-, mxExtendedInformation()
+: mbReducedDisplayQuality(false)
{
}
@@ -330,19 +304,13 @@ public:
return mxViewInformation;
}
-const uno::Sequence&
getExtendedInformationSequence() const
-{
-return mxExtendedInformation;
-}
[Libreoffice-bugs] [Bug 108843] [META] Clipboard bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108843 Aron Budea changed: What|Removed |Added Depends on||115783 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=115783 [Bug 115783] Copy and paste in table: lost character formatting of original text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142845] Caret misplaced after Paste+Undo
https://bugs.documentfoundation.org/show_bug.cgi?id=142845 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu, ||vmik...@collabora.com See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||5783 Version|7.2.0.0.alpha0+ |6.0.2.1 release Keywords||bibisected, bisected, ||regression --- Comment #2 from Aron Budea --- This is a regression from the following commit, bibisected to its 6.0 backport using repo bibisect-linux-64-6.0. Adding CC: to Miklos Vajna. https://cgit.freedesktop.org/libreoffice/core/commit/?id=f0c25c751cf8e166a84b289746bce6202a40391d author Miklos Vajna 2018-02-16 18:08:46 +0100 committer Miklos Vajna 2018-02-16 23:44:27 +0100 tdf#115783 sd: fix lost char attributes during in-table copy -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138653] SVG images look extremely bad after DOCX export or compress
https://bugs.documentfoundation.org/show_bug.cgi?id=138653 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9077 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139077] SVG image pasted with RTF paste looks off
https://bugs.documentfoundation.org/show_bug.cgi?id=139077 Aron Budea changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=119601, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||8653, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||1483 Version|7.2.0.0.alpha0+ |4.1.0.4 release Keywords||bibisected, bisected, ||regression CC||ba...@caesar.elte.hu --- Comment #3 from Aron Budea --- This is interesting, because the results are different in Linux with GTK3 VCL plugin, and with gen VCL plugin. With gtk3 the image looks inverted, and with gen the colors are fine, but the quality is bad (it's probably bad in the other case, too). It also isn't an RTF paste bug, after exporting to RTF and reloading the document, the image exhibits the same quality loss. When using RTF export/import, the issue started in 4.1.0.4, and could be bibisected to the following range for when the inverted image started, using bibisect-41max: https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=5bdba378d6fc9f18f618967ec37d07efed2afee4..f47c3906ee0fc35f4b219fb24a0e270956821369 Suspecting the following commit (uneducated guess): https://cgit.freedesktop.org/libreoffice/core/commit/?id=4fa8df7320f6bdc8333f5936537d2ed93e8892ce author Armin Le Grand 2012-06-11 08:38:23 + committer Caolán McNamara 2013-04-14 21:33:59 +0100 "Resolves: #i119735# missing css.svg.SVGWriter when using GraphicProvider" Before that, the quality loss started with the following commit, same as in bug 138653: https://cgit.freedesktop.org/libreoffice/core/commit/?id=a1a0830d1ac3ffabbe35bd8a0264b64f1f7a9d67 author Armin Le Grand 2012-05-30 13:44:19 + committer Caolán McNamara 2013-03-16 01:57:53 + "Resolves: #i119601# support for transparency in PNG export dialog" Much later, the commit that fixed the inverted color with both VCL plugins was the following (though the background color is slightly different), bibisected using bibisect-linux-64-6.0: https://cgit.freedesktop.org/libreoffice/core/commit/?id=ebc11ae0b132eefd3b1b1a837a8d0ad3ba73b460 author Thorsten Behrens 2017-08-21 22:44:30 +0200 committer Thorsten Behrens 2017-08-22 12:28:57 +0200 "emfplus: cut over to new EMF+ renderer" Then the following commit brought back the inverted colors with gtk3 VCL plugin, in the same version/repo: https://cgit.freedesktop.org/libreoffice/core/commit/?id=3cb59bff332b02f607d15b5ed41b4438e8102980 author Caolán McNamara 2017-09-04 13:34:09 +0100 committer Caolán McNamara 2017-09-04 17:22:27 +0200 "Resolves: tdf#111483 1 bit bitmaps with non-standard black/white indexes" -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138653] SVG images look extremely bad after DOCX export or compress
https://bugs.documentfoundation.org/show_bug.cgi?id=138653 Aron Budea changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=119601 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105868] FILESAVE DOC: TNR with style 12 and direct format font size 11 saved as font size 12 (also 12 in Word)
https://bugs.documentfoundation.org/show_bug.cgi?id=105868 Aron Budea changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=120140 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/svx
include/svx/svdograf.hxx | 13 ++---
include/svx/svdpage.hxx |2 +-
include/svx/svdpagv.hxx | 16 +---
3 files changed, 8 insertions(+), 23 deletions(-)
New commits:
commit ea269c0a04ede8206ba15fd77d26bbd99ec44c75
Author: Tomaž Vajngerl
AuthorDate: Tue Jul 20 21:39:02 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 31 04:10:49 2021 +0200
svx: cleanup some forward decls, unneeded pragma once, whitespace
Change-Id: I26cd723e0ffe907a7aa8cb4f73ba6bfbd6db5fbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119719
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/svx/svdograf.hxx b/include/svx/svdograf.hxx
index bf7e329d5442..69ce11533caa 100644
--- a/include/svx/svdograf.hxx
+++ b/include/svx/svdograf.hxx
@@ -29,17 +29,8 @@
#include
#include
-namespace sdr
-{
-namespace properties
-{
-class GraphicProperties;
-} // end of namespace properties
-namespace contact
-{
-class ViewObjectContactOfGraphic;
-} // end of namespace contact
-} // end of namespace sdr
+namespace sdr::properties { class GraphicProperties; }
+namespace sdr::contact { class ViewObjectContactOfGraphic; }
/**
* Options for GetTransformedGraphic()
diff --git a/include/svx/svdpage.hxx b/include/svx/svdpage.hxx
index d5552a7c72a4..fc6936a95282 100644
--- a/include/svx/svdpage.hxx
+++ b/include/svx/svdpage.hxx
@@ -64,7 +64,7 @@ private:
SdrObjList(const SdrObjList& rSrcList) = delete;
SdrObjList =(const SdrObjList& rSrcList) = delete;
-::std::vector maList;
+std::vector maList;
tools::RectanglemaSdrObjListOutRect;
tools::RectanglemaSdrObjListSnapRect;
diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx
index ab9bfa5625ae..3aceb48d1d4b 100644
--- a/include/svx/svdpagv.hxx
+++ b/include/svx/svdpagv.hxx
@@ -42,20 +42,16 @@ class SdrView;
class SdrPageObj;
class SdrPageView;
-namespace sdr
+namespace sdr::contact
{
-namespace contact
-{
-class ViewObjectContactRedirector;
-class DisplayInfo;
-class ViewObjectContactRedirector;
-} // end of namespace contact
-} // end of namespace sdr
+class ViewObjectContactRedirector;
+class DisplayInfo;
+class ViewObjectContactRedirector;
+}
// typedefs for a list of SdrPageWindow
class SdrPageWindow;
-
class SVXCORE_DLLPUBLIC SdrPageView
{
private:
@@ -255,6 +251,4 @@ public:
const Color& GetApplicationDocumentColor() const { return maDocumentColor;}
};
-#pragma once
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: Branch 'feature/drawinglayercore2' - 3 commits - drawinglayer/source include/drawinglayer include/svx sc/source svx/source sw/source
Rebased ref, commits from common ancestor:
commit 41f181585835b6e697a7bccd9d0cb92b7f739298
Author: Tomaž Vajngerl
AuthorDate: Fri Jul 23 16:31:02 2021 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Jul 31 10:16:49 2021 +0900
drawinglayer: extract Prop. Value conversion from ViewInformation2D
ViewInformation2D doesn't need to know anything about the Sequence
of PropertyValue that is used for parameters when constructing it
through UNO API. This can be done outside of ViewInfromation2D and
it doesn't need to be responsible for that internally inside the
ViewInformation2D. With this we get ViewInformation2D, which is much
simpler and isn't prone to YAGNI.
Change-Id: I3836237a1d26e38145b52136c3204931ae7c6b79
diff --git a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
index 63b4ffd6986d..98ca81433f12 100644
--- a/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
+++ b/drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx
@@ -117,7 +117,7 @@ namespace drawinglayer::unorenderer
MaximumQuadraticPixels = 50;
}
-const geometry::ViewInformation2D
aViewInformation2D(aViewInformationSequence);
+const auto aViewInformation2D =
geometry::createViewInformation2D(aViewInformationSequence);
const sal_uInt32
nDiscreteWidth(basegfx::fround(o3tl::convert(fWidth, eRangeUnit,
o3tl::Length::in) * DPI_X));
const sal_uInt32
nDiscreteHeight(basegfx::fround(o3tl::convert(fHeight, eRangeUnit,
o3tl::Length::in) * DPI_Y));
diff --git a/drawinglayer/source/geometry/viewinformation2d.cxx
b/drawinglayer/source/geometry/viewinformation2d.cxx
index 5b276cf52a59..6698f3b38b1f 100644
--- a/drawinglayer/source/geometry/viewinformation2d.cxx
+++ b/drawinglayer/source/geometry/viewinformation2d.cxx
@@ -84,162 +84,24 @@ protected:
// Viewport, VisualizedPage or ViewTime
uno::Sequence mxExtendedInformation;
-void impInterpretPropertyValues(const uno::Sequence&
rViewParameters)
-{
-if (!rViewParameters.hasElements())
-return;
-
-const sal_Int32 nCount(rViewParameters.getLength());
-sal_Int32 nExtendedInsert(0);
-
-// prepare extended information for filtering. Maximum size is nCount
-mxExtendedInformation.realloc(nCount);
-
-for (sal_Int32 a(0); a < nCount; a++)
-{
-const beans::PropertyValue& rProp = rViewParameters[a];
-
-if (rProp.Name == g_PropertyName_ReducedDisplayQuality)
-{
-// extra information; add to filtered information
-mxExtendedInformation[nExtendedInsert++] = rProp;
-
-// for performance reasons, also cache content locally
-bool bSalBool(false);
-rProp.Value >>= bSalBool;
-mbReducedDisplayQuality = bSalBool;
-}
-else if (rProp.Name == g_PropertyName_ObjectTransformation)
-{
-css::geometry::AffineMatrix2D aAffineMatrix2D;
-rProp.Value >>= aAffineMatrix2D;
-
basegfx::unotools::homMatrixFromAffineMatrix(maObjectTransformation,
- aAffineMatrix2D);
-}
-else if (rProp.Name == g_PropertyName_ViewTransformation)
-{
-css::geometry::AffineMatrix2D aAffineMatrix2D;
-rProp.Value >>= aAffineMatrix2D;
-
basegfx::unotools::homMatrixFromAffineMatrix(maViewTransformation,
aAffineMatrix2D);
-}
-else if (rProp.Name == g_PropertyName_Viewport)
-{
-css::geometry::RealRectangle2D aViewport;
-rProp.Value >>= aViewport;
-maViewport =
basegfx::unotools::b2DRectangleFromRealRectangle2D(aViewport);
-}
-else if (rProp.Name == g_PropertyName_Time)
-{
-rProp.Value >>= mfViewTime;
-}
-else if (rProp.Name == g_PropertyName_VisualizedPage)
-{
-rProp.Value >>= mxVisualizedPage;
-}
-else
-{
-// extra information; add to filtered information
-mxExtendedInformation[nExtendedInsert++] = rProp;
-}
-}
-
-// extra information size is now known; realloc to final size
-mxExtendedInformation.realloc(nExtendedInsert);
-}
-
-void impFillViewInformationFromContent()
-{
-const bool
bObjectTransformationUsed(!maObjectTransformation.isIdentity());
-const bool bViewTransformationUsed(!maViewTransformation.isIdentity());
-const bool bViewportUsed(!maViewport.isEmpty());
-const bool bTimeUsed(0.0 < mfViewTime);
-const
[Libreoffice-bugs] [Bug 34828] Navigator item "Draw objects" in Calc does not show Draw objects without name (Writer fixed in the mean time..)
https://bugs.documentfoundation.org/show_bug.cgi?id=34828 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3572 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Aron Budea changed: What|Removed |Added Depends on||143572 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143572 [Bug 143572] Crash clicking Shape 2 Text Frame -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143572] Crash clicking Shape 2 Text Frame
https://bugs.documentfoundation.org/show_bug.cgi?id=143572 Aron Budea changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Blocks||103030 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=34 ||828 CC||ba...@caesar.elte.hu --- Comment #7 from Aron Budea --- This is actually a regression from the following commit, bibisected using repo bibisect-linux-64-7.2. https://cgit.freedesktop.org/libreoffice/core/commit/?id=f0878173e1963cf8db5f60ced6d19da24e18bc41 author Jim Raykowski2020-12-01 00:25:52 -0900 committer Jim Raykowski2020-12-03 21:38:48 +0100 "tdf#34828 sd navigator: make unnamed shape select select shape object" For the record, the shapes started showing up in the navigator from the commit below, which precedes the previous one by 2 or so commits. https://cgit.freedesktop.org/libreoffice/core/commit/?id=70fd160ea0c2a2afeee520f450f1ed4f81fa88f3 author Jim Raykowski2020-12-01 00:02:25 -0900 committer Jim Raykowski2020-12-03 21:36:33 +0100 "tdf#34828 sd navigator: make 'All shapes' the default" Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103030 [Bug 103030] [META] Navigator sidebar deck and floating window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143603] Opening a simple presentation has UNDO active
https://bugs.documentfoundation.org/show_bug.cgi?id=143603 Aron Budea changed: What|Removed |Added See Also||https://bz.apache.org/ooo/s ||how_bug.cgi?id=74651 Version|7.2.0.1 rc |4.4.0.3 release CC||ba...@caesar.elte.hu Blocks||105948 Keywords||bibisected, bisected, ||regression --- Comment #2 from Aron Budea --- This is a regression from the following commit, bibisected using repo bibisect-44max. https://cgit.freedesktop.org/libreoffice/core/commit/?id=32c28a6d131284c1602f57a8220d1b736b538288 author Maxime de Roucy 2014-01-07 09:31:11 +0100 committer Caolán McNamara 2014-06-25 10:00:50 + Resolves: #i74651# remove image via should change document state Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Aron Budea changed: What|Removed |Added Depends on||143603 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143603 [Bug 143603] Opening a simple presentation has UNDO active -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143602] Read only from DropBox
https://bugs.documentfoundation.org/show_bug.cgi?id=143602 Aron Budea changed: What|Removed |Added Ever confirmed|1 |0 Status|NEW |UNCONFIRMED CC||ba...@caesar.elte.hu --- Comment #4 from Aron Budea --- Please wait for someone else to confirm your bug report. Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143600] Opening Excel XLS spreadsheet which contains XML fails with "General Error. General input/output error."
https://bugs.documentfoundation.org/show_bug.cgi?id=143600 --- Comment #13 from Kohei Yoshida --- I can see Mike's argument. But changing this behavior would not be a quick overnight step. I'll look into that here: https://gitlab.com/orcus/orcus/-/issues/138 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143351] Conditional format rule "range" part couldn't be imported.
https://bugs.documentfoundation.org/show_bug.cgi?id=143351 Aron Budea changed: What|Removed |Added Keywords||filter:xlsx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143351] Conditional format rule "range" part couldn't be imported.
https://bugs.documentfoundation.org/show_bug.cgi?id=143351 Aron Budea changed: What|Removed |Added Version|7.3.0.0 alpha0+ Master |4.0.0.3 release CC||ba...@caesar.elte.hu --- Comment #3 from Aron Budea --- Already in 4.0.0.3. -- You are receiving this mail because: You are the assignee for the bug.
