[Libreoffice-bugs] [Bug 143480] Writer: In Navigator, promotion or demotion of a level should change heading level in document
https://bugs.documentfoundation.org/show_bug.cgi?id=143480 Eleonora Govallo changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||elya.gova...@gmail.com --- Comment #1 from Eleonora Govallo --- Could you please attach the example of document, i'm not sure, that understood the problem correctly. For the moment no repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ru-RU (ru_RU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-26_22:41:19 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112581] [META] Linked (non-embedded) external files bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=112581 Bug 112581 depends on bug 88481, which changed state. Bug 88481 Summary: Editing : Value become zero on DDE Link Break on reopen https://bugs.documentfoundation.org/show_bug.cgi?id=88481 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 88481] Editing : Value become zero on DDE Link Break on reopen
https://bugs.documentfoundation.org/show_bug.cgi?id=88481 Jaise James changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #10 from Jaise James --- No issue in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143415] Sheet navigation right click needs two clicks to close (Windows-only)
https://bugs.documentfoundation.org/show_bug.cgi?id=143415 Jaise James changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #10 from Jaise James --- No issue in latest version Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-IN (en_IN); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143497] SLIDESHOW: Much slower going to previous slide than to next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=143497 Eleonora Govallo changed: What|Removed |Added CC||elya.gova...@gmail.com --- Comment #1 from Eleonora Govallo --- No repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857 CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: ru-RU (ru_RU.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-26_22:41:19 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108908] [META] Visual Basic for Applications (VBA) macro issues
https://bugs.documentfoundation.org/show_bug.cgi?id=108908 Bug 108908 depends on bug 142922, which changed state. Bug 142922 Summary: Basic: Round VBA compatibility function implements wrong rounding mode https://bugs.documentfoundation.org/show_bug.cgi?id=142922 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 106040] [META] Help bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106040 Aron Budea changed: What|Removed |Added Depends on||143756 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143756 [Bug 143756] Basic: Round VBA compatibility function needs documenting its rounding mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143756] Basic: Round VBA compatibility function needs documenting its rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=143756 Aron Budea changed: What|Removed |Added Blocks||106040 Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106040 [Bug 106040] [META] Help bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142213] FILESAVE PPTX Animation trigger roundtripped incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=142213 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143497] SLIDESHOW: Much slower going to previous slide than to next slide
https://bugs.documentfoundation.org/show_bug.cgi?id=143497 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143496] misplaced smartTags with XRangeBasedSmartTagRecognizer / commitTextRangeMarkup
https://bugs.documentfoundation.org/show_bug.cgi?id=143496 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139440] Calc 'Sort Ascending' does not properly sort when the field is date by mm/dd/yyyy
https://bugs.documentfoundation.org/show_bug.cgi?id=139440 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139440] Calc 'Sort Ascending' does not properly sort when the field is date by mm/dd/yyyy
https://bugs.documentfoundation.org/show_bug.cgi?id=139440 --- Comment #4 from QA Administrators --- Dear john.oliver.3, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139439] Fatal error: bad allocation
https://bugs.documentfoundation.org/show_bug.cgi?id=139439 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139439] Fatal error: bad allocation
https://bugs.documentfoundation.org/show_bug.cgi?id=139439 --- Comment #4 from QA Administrators --- Dear francois.jourdain, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138717] Formatting issues when applying text body style
https://bugs.documentfoundation.org/show_bug.cgi?id=138717 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138717] Formatting issues when applying text body style
https://bugs.documentfoundation.org/show_bug.cgi?id=138717 --- Comment #6 from QA Administrators --- Dear Ruth, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137457] When opening a csv file with Calc, the decimal point is removed, changing the value of the cell
https://bugs.documentfoundation.org/show_bug.cgi?id=137457 --- Comment #4 from QA Administrators --- Dear Carlos Brys, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143756] New: Basic: Round VBA compatibility function needs documenting its rounding mode
https://bugs.documentfoundation.org/show_bug.cgi?id=143756 Bug ID: 143756 Summary: Basic: Round VBA compatibility function needs documenting its rounding mode Product: LibreOffice Version: 7.2.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Documentation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mikekagan...@hotmail.com CC: olivier.hal...@libreoffice.org Since fixing bug 142922, the Basic compatibility function Round implements proper half-to-even rounding mode. That needs documenting in the relevant help page [1], with some examples (see e.g. unit tests implemented in the fix). [1] https://help.libreoffice.org/7.3/en-US/text/sbasic/shared/0317.html?DbPAR=BASIC -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137639] Copying and pasting English text converts it to Chinese
https://bugs.documentfoundation.org/show_bug.cgi?id=137639 --- Comment #12 from Munzir Taha --- @himajin: Nice catch! I just tested by copying ww and I got 睷 w (U+0077) 睷 (U+) Now, I know why copying single characters was not working sometimes randomly. It's also worth mentioning that LO after this get sluggish, unresponsive with many crashes and 100% CPU usage. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103704] [META] Slide transition bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103704 Aron Budea changed: What|Removed |Added Depends on||143527 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143527 [Bug 143527] Impress slide transition sounds do not loop (64-bit Win only) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143527] Impress slide transition sounds do not loop (64-bit Win only)
https://bugs.documentfoundation.org/show_bug.cgi?id=143527 Aron Budea changed: What|Removed |Added Blocks||103704 Summary|Impress slide transition|Impress slide transition |sounds do not loop |sounds do not loop (64-bit ||Win only) Severity|major |normal Keywords|bibisectRequest |notBibisectable CC||ba...@caesar.elte.hu Version|5.4.7.2 release |5.2.0.4 release Priority|high|medium --- Comment #6 from Aron Budea --- Based on comment 4, this is fine in current 32-bit Windows builds. I can confirm the bug already exists in LO 5.2.0.4 64-bit Win build, but is fine in a 5.0.0.5 64-bit Win build. The oldest 64-bit bibisect repo is 6.4, therefore this is not bibisectable. I don't see the rationale behind the high/major importance either, resetting it to medium/normal, if anyone wants to raise it, please give a reason. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103704 [Bug 103704] [META] Slide transition bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131809] Save fails to save sound loop attribute
https://bugs.documentfoundation.org/show_bug.cgi?id=131809 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Resolution|DUPLICATE |WORKSFORME Blocks||103704 --- Comment #6 from Aron Budea --- This is actually not a duplicate of bug 143527, this one is about saving the details to a file, while that one is about what is played. For this you only need to reload the saved presentation, and check slide transition properties. What I can see that this was indeed buggy in 6.0.0.3, but looks fixed in 7.1.0.3, therefore marking as WORKSFORME. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103704 [Bug 103704] [META] Slide transition bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103704] [META] Slide transition bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103704 Aron Budea changed: What|Removed |Added Depends on||131809 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=131809 [Bug 131809] Save fails to save sound loop attribute -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142264] charts lost by calc export to xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=142264 --- Comment #9 from paulyste...@web.de --- still, repro in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 70710] [WMF/EMF/EMF+] FILEOPEN Filled areas are not filled for WMF images
https://bugs.documentfoundation.org/show_bug.cgi?id=70710 --- Comment #29 from paulyste...@web.de --- updated WMF is also ok in 7.2.0.2 win64 workaround WMF to EMF in Irfanview is also ok. original WMF also in 7.2.0.2 with the same limitations as before. -- You are receiving this mail because: You are the assignee for the bug.
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1489780:(FORWARD_NULL)
*** CID 1489780:(FORWARD_NULL)
/formula/source/core/api/FormulaCompiler.cxx: 185 in
formulaOpCodeList::OpCodeList(const std::pair
*, const std::shared_ptr &,
formula::FormulaCompiler::SeparatorType)()
179 std::unique_ptr xCharClass( xMap->isEnglish() ? nullptr
: createCharClassIfNonEnglishUI());
180 const CharClass* pCharClass = xCharClass.get();
181 if (meSepType == FormulaCompiler::SeparatorType::RESOURCE_BASE)
182 {
183 for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i)
184 {
>>> CID 1489780:(FORWARD_NULL)
>>> "putDefaultOpCode" dereferences null "this->mpSymbols2".
185 putDefaultOpCode( xMap, i, pCharClass);
186 }
187 }
188 else
189 {
190 for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i)
/formula/source/core/api/FormulaCompiler.cxx: 196 in
formulaOpCodeList::OpCodeList(const std::pair
*, const std::shared_ptr &,
formula::FormulaCompiler::SeparatorType)()
190 for (sal_uInt16 i = 0; i <= SC_OPCODE_LAST_OPCODE_ID; ++i)
191 {
192 OUString aOpStr;
193 if ( getOpCodeString( aOpStr, i) )
194 xMap->putOpCode( aOpStr, OpCode(i), pCharClass);
195 else
>>> CID 1489780:(FORWARD_NULL)
>>> "putDefaultOpCode" dereferences null "this->mpSymbols2".
196 putDefaultOpCode( xMap, i, pCharClass);
197 }
198 }
199 }
200
201 OpCodeList::OpCodeList(const std::pair* pSymbols,
const FormulaCompiler::NonConstOpCodeMapPtr& xMap,
** CID 1489779: Uninitialized members (UNINIT_CTOR)
/cppu/source/threadpool/current.cxx: 88 in cppu::IdContainer::IdContainer()()
*** CID 1489779: Uninitialized members (UNINIT_CTOR)
/cppu/source/threadpool/current.cxx: 88 in cppu::IdContainer::IdContainer()()
82
83 IdContainer::IdContainer()
84 {
85 pCurrentContext = nullptr;
86 pCurrentContextEnv = nullptr;
87 bInit = false;
>>> CID 1489779: Uninitialized members (UNINIT_CTOR)
>>> Non-static class member "pCurrentId" is not initialized in this
>>> constructor nor in any functions that it calls.
88 }
89
90 IdContainer::~IdContainer()
91 {
92 if (pCurrentContext)
93 {
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D40zJ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi-2Baefm4BIHP4WMnGJFzx4MRUhOndRgt-2B94NY3pPPgGSHdMvUjmQ-2BQMC8Cd-2Fx4yzfUhq4y8Iyhj-2BCxKaCMpnj-2F3lysjoU5Dx5nWrNDpC-2FZ8nh6YeVKKtYcW8LgZoMUAeFTA8JfoZ0GncXnqFXui1iGiSwJciI2tKG9k3qEVLPNkCg-3D
[Libreoffice-bugs] [Bug 120708] Error rendering different page sizes and orientation when importing PDF files
https://bugs.documentfoundation.org/show_bug.cgi?id=120708 --- Comment #10 from paulyste...@web.de --- repro in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101083] Insert SVG with too small scaling causes LibreOffice to hang, consuming 100% cpu
https://bugs.documentfoundation.org/show_bug.cgi?id=101083 --- Comment #22 from paulyste...@web.de --- still, repro in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96143] Writer unresponsive large amount of animating gif images in table
https://bugs.documentfoundation.org/show_bug.cgi?id=96143 --- Comment #21 from paulyste...@web.de --- ok in LO 7202 the small test file is now ok from 131 kb to 136 kb with saving in 7.2.0.2 win64 with open document format 1.3. In the big test file, it is only 1 kb more to 1.701 kb. With enabled animations, my notebook air cooler goes high. So it is well solved. In MSO is the animation not started in work mode. So there is no performance and heat-making problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143738] feature request: support for double line display shapes such as excel
https://bugs.documentfoundation.org/show_bug.cgi?id=143738 --- Comment #5 from Regina Henschel --- (In reply to Julien Nabet from comment #4) > Regina: any thoughts here? The relevant ODF attribute is draw:stroke and that has only "none", "dash" and "solid". The double-lines which you notice on table cells are fo:border in ODF, and fo:border can have more line styles. It is formally possible to use fo:border instead of draw:stroke or in addition to it. Writer frames use fo:border. I think, it would be a large effort to support it for shapes too. Similar request is in https://bugs.documentfoundation.org/show_bug.cgi?id=124186. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)
https://bugs.documentfoundation.org/show_bug.cgi?id=143148 --- Comment #6 from Commit Notification --- Zeynep Yavuz committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e642179f466c899365fc9539a8aca66b39fea39a tdf#143148: Use pragma once instead of include guards (Episode 2: Endgame) It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/osx/salinst.h |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit e642179f466c899365fc9539a8aca66b39fea39a Author: Zeynep Yavuz AuthorDate: Mon Aug 2 20:05:38 2021 +0300 Commit: Roman Kuznetsov CommitDate: Thu Aug 5 23:41:54 2021 +0200 tdf#143148: Use pragma once instead of include guards (Episode 2: Endgame) Change-Id: I049bd94eaaa771584d18859903ef75e4319494b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119893 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h index e143f970db0d..c94d5871a1df 100644 --- a/vcl/inc/osx/salinst.h +++ b/vcl/inc/osx/salinst.h @@ -18,8 +18,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_INC_OSX_SALINST_H -#define INCLUDED_VCL_INC_OSX_SALINST_H +#pragma once #include @@ -158,6 +157,5 @@ public: CGImageRef CreateCGImage( const Image& ); NSImage* CreateNSImage( const Image& ); -#endif // INCLUDED_VCL_INC_OSX_SALINST_H /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-bugs] [Bug 91265] MSO2013 Template - D Business Verification - Chart Size Too Large
https://bugs.documentfoundation.org/show_bug.cgi?id=91265 --- Comment #11 from paulyste...@web.de --- repro in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL circle again too large row 11 without green color -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91265] MSO2013 Template - D Business Verification - Chart Size Too Large
https://bugs.documentfoundation.org/show_bug.cgi?id=91265 --- Comment #10 from paulyste...@web.de --- repro in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL circle again too large row 11 without green color -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80219] FILESAVE: SVG loss some color after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=80219 --- Comment #22 from paulyste...@web.de --- still, reproduce in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 76260] FILEOPEN: slow loading and dump of .docx with lots of footnotes (see Comment 27 and Comment 43)
https://bugs.documentfoundation.org/show_bug.cgi?id=76260 --- Comment #59 from paulyste...@web.de --- in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL also fast great work. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 75209] FILEOPEN: Impress grouped pictures not displayed in slideshow (see comment 21)
https://bugs.documentfoundation.org/show_bug.cgi?id=75209 --- Comment #33 from paulyste...@web.de --- see no improvement in LO 7202 Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 67583] FILEOPEN: File with 40 images long opening, not responding and RAM increasing - both DOC, DOCX (win only)
https://bugs.documentfoundation.org/show_bug.cgi?id=67583 --- Comment #32 from paulyste...@web.de --- See no signifikant improvement in LO 7202 Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL A partial workaround: new saving in MSO201x. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 66525] IMPORT specific formula in a MS Word document is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=66525 --- Comment #17 from paulyste...@web.de --- no positive change for this problem in Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62178] Wrong in to MSWord2003 exported formula when it contains only one parenthesis
https://bugs.documentfoundation.org/show_bug.cgi?id=62178 --- Comment #18 from paulyste...@web.de --- see no positive change in LO7202 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143755] Wireless Security Cameras Kelowna
https://bugs.documentfoundation.org/show_bug.cgi?id=143755 Macker Tek changed: What|Removed |Added URL||https://mackertek.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143755] New: Wireless Security Cameras Kelowna
https://bugs.documentfoundation.org/show_bug.cgi?id=143755 Bug ID: 143755 Summary: Wireless Security Cameras Kelowna Product: Document Liberation Project Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sinzesin...@gmail.com Buy Wireless Security Cameras in Houston, San Antonio, Vancouver, Toronto, Kelowna, Los Angeles, San Diego, San Francisco, Boston and Ottawa. Visit us today to learn more at https://mackertek.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 32249] When importing PDF with text in it , it will be better to have a easy and fluent option to edit the imported Text
https://bugs.documentfoundation.org/show_bug.cgi?id=32249 --- Comment #24 from paulyste...@web.de --- Shapes - consolidate text changes the position of the text. mostly the text needs more place in height and width. also with LO 7.2.0.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit f376d68736d9a0f08b2a6ae5c126b0bb5570ff4b
Author: Noel Grandin
AuthorDate: Thu Aug 5 20:29:45 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 22:29:23 2021 +0200
osl::Mutex->std::mutex in InteractionSupplyPassword
Change-Id: I98d54c8ab1c193a3eb43898a7be68986dd581447
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120085
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
b/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
index a5a8f742b41d..fe853d84c45b 100644
--- a/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_passwordrequest.cxx
@@ -18,8 +18,6 @@
*/
-#include
-
#include
#include
#include
@@ -30,6 +28,8 @@
#include "tdoc_passwordrequest.hxx"
+#include
+
using namespace com::sun::star;
using namespace tdoc_ucp;
@@ -65,7 +65,7 @@ namespace tdoc_ucp
virtual OUString SAL_CALL getPassword() override;
private:
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
OUString m_aPassword;
};
@@ -148,14 +148,14 @@ void SAL_CALL InteractionSupplyPassword::select()
void SAL_CALL
InteractionSupplyPassword::setPassword( const OUString& aPasswd )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
m_aPassword = aPasswd;
}
// virtual
OUString SAL_CALL InteractionSupplyPassword::getPassword()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
return m_aPassword;
}
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/tdoc/tdoc_docmgr.cxx | 26 +-
ucb/source/ucp/tdoc/tdoc_docmgr.hxx |8
2 files changed, 17 insertions(+), 17 deletions(-)
New commits:
commit dfed833ff3ef1532b18745df5ac0909d4e09028e
Author: Noel Grandin
AuthorDate: Thu Aug 5 20:28:45 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 22:29:06 2021 +0200
osl::Mutex->std::mutex in OfficeDocumentsManager
Change-Id: I4de3e5ea25614bb032d68476c76f32d03d6e40b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120084
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
b/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
index af66cb8a4b25..2f0602d23dc4 100644
--- a/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
+++ b/ucb/source/ucp/tdoc/tdoc_docmgr.cxx
@@ -178,7 +178,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
bool found(false);
{
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
found = std::any_of(m_aDocs.begin(), m_aDocs.end(),
[](const DocumentList::value_type& rEntry) { return
rEntry.second.xModel == xModel; });
@@ -204,7 +204,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
uno::Reference< frame::XModel >( Event.Source,
uno::UNO_QUERY ) );
{
-osl::MutexGuard g(m_aMtx);
+std::scoped_lock g(m_aMtx);
m_aDocs[ aDocId ] = StorageInfo( aTitle, xStorage, xModel
);
}
@@ -245,7 +245,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
OUString aDocId;
{
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
auto it = std::find_if(m_aDocs.begin(), m_aDocs.end(),
[](const DocumentList::value_type& rEntry) { return
rEntry.second.xModel == xModel; });
@@ -295,7 +295,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
xModel( Event.Source, uno::UNO_QUERY );
OSL_ENSURE( xModel.is(), "Got no frame::XModel!" );
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
DocumentList::iterator it = std::find_if(m_aDocs.begin(),
m_aDocs.end(),
[](const DocumentList::value_type& rEntry) { return
rEntry.second.xModel == xModel; });
@@ -327,7 +327,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
OUString const
title(comphelper::DocumentInfo::getDocumentTitle(xModel));
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
DocumentList::iterator it = std::find_if(m_aDocs.begin(),
m_aDocs.end(),
[](const DocumentList::value_type& rEntry) { return
rEntry.second.xModel == xModel; });
@@ -365,7 +365,7 @@ void SAL_CALL OfficeDocumentsManager::documentEventOccured(
OUString const aDocId(getDocumentId(Event.Source));
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
DocumentList::iterator it = std::find_if(m_aDocs.begin(),
m_aDocs.end(),
[](const DocumentList::value_type& rEntry) { return
rEntry.second.xModel == xModel; });
@@ -424,7 +424,7 @@ void OfficeDocumentsManager::buildDocumentsList()
bool found(false);
{
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
found = std::any_of(m_aDocs.begin(), m_aDocs.end(),
[](const DocumentList::value_type& rEntry)
{ return rEntry.second.xModel == xModel; });
@@ -446,7 +446,7 @@ void OfficeDocumentsManager::buildDocumentsList()
OSL_ENSURE( xStorage.is(), "Got no document storage!"
);
{
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
m_aDocs[ aDocId ]
= StorageInfo( aTitle, xStorage, xModel );
}
@@ -478,7 +478,7 @@ void OfficeDocumentsManager::buildDocumentsList()
uno::Reference< embed::XStorage >
OfficeDocumentsManager::queryStorage( const OUString & rDocId )
{
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
DocumentList::const_iterator it = m_aDocs.find( rDocId );
if ( it == m_aDocs.end() )
@@ -498,7 +498,7 @@ OUString OfficeDocumentsManager::queryDocumentId(
uno::Reference< frame::XModel >
OfficeDocumentsManager::queryDocumentModel( const OUString & rDocId )
{
-osl::MutexGuard aGuard( m_aMtx );
+std::scoped_lock aGuard( m_aMtx );
DocumentList::const_iterator it =
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/prov.cxx |2 +-
ucb/source/ucp/file/prov.hxx |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 949e6d0a6f2024a9d864fe1ed2d0d1d34838bde6
Author: Noel Grandin
AuthorDate: Wed Aug 4 21:44:18 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 22:28:18 2021 +0200
osl::Mutex->std::mutex in fileaccess::FileProvider
Change-Id: Ie110938cc7673739cc31588508987ca18617e5c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120026
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/file/prov.cxx b/ucb/source/ucp/file/prov.cxx
index 9fa76da40c1a..dfc4e373d7b8 100644
--- a/ucb/source/ucp/file/prov.cxx
+++ b/ucb/source/ucp/file/prov.cxx
@@ -307,7 +307,7 @@ XPropertySetInfoImpl2::hasPropertyByName(
void FileProvider::initProperties()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if( m_xPropertySetInfo.is() )
return;
diff --git a/ucb/source/ucp/file/prov.hxx b/ucb/source/ucp/file/prov.hxx
index 84aeb43505ee..c12a87867224 100644
--- a/ucb/source/ucp/file/prov.hxx
+++ b/ucb/source/ucp/file/prov.hxx
@@ -19,7 +19,6 @@
#pragma once
-#include
#include
#include
#include
@@ -32,6 +31,7 @@
#include
#include
#include
+#include
// FileProvider
@@ -145,7 +145,7 @@ namespace fileaccess {
css::uno::Reference< css::uno::XComponentContext > m_xContext;
void initProperties();
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
OUString m_HostName;
OUString m_HomeDirectory;
sal_Int32 m_FileSystemNotation;
[Libreoffice-bugs] [Bug 34058] Translation feature through external services
https://bugs.documentfoundation.org/show_bug.cgi?id=34058 --- Comment #16 from paulyste...@web.de --- the alternative in beta mode page translate https://extensions.libreoffice.org/en/extensions/show/pagetranslate So this is perhaps partly or fully resolved. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143738] feature request: support for double line display shapes such as excel
https://bugs.documentfoundation.org/show_bug.cgi?id=143738 Julien Nabet changed: What|Removed |Added Summary|future request:Support for |feature request: support |double line display shapes |for double line display |such as excel |shapes such as excel CC||rb.hensc...@t-online.de, ||serval2...@yahoo.fr --- Comment #4 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. xl/drawings/drawing1.xml contains this (after having "beautified" it: 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 Regina: any thoughts here? I mean, we indeed can't do it even when trying modifying line once the file is opened. So perhaps not even in odf specs and completely exclusive to Excel? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source desktop/inc include/sfx2 sc/source sd/source sfx2/source svx/source sw/source tools/source
chart2/source/controller/main/ChartWindow.cxx |8
desktop/inc/lib/init.hxx |7 +++
include/sfx2/lokhelper.hxx|3 ++-
sc/source/ui/view/gridwin4.cxx| 11 ++-
sc/source/ui/view/tabview.cxx |2 +-
sc/source/ui/view/tabview3.cxx|4 ++--
sd/source/ui/view/sdwindow.cxx| 11 ++-
sfx2/source/view/lokhelper.cxx| 10 ++
svx/source/svdraw/sdrpagewindow.cxx |2 +-
svx/source/svdraw/svdmrkv.cxx |8
sw/source/uibase/docvw/edtwin.cxx |8 +---
tools/source/generic/gen.cxx |8 ++--
12 files changed, 38 insertions(+), 44 deletions(-)
New commits:
commit 417f881d20cafe88a02b64894ba4483875fb9460
Author: Noel Grandin
AuthorDate: Wed Aug 4 11:37:34 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 22:20:13 2021 +0200
improve LOK notifyInvalidation
(*) tweak buffer in SfxLokHelper::notifyInvalidation to be a bit larger,
so we avoid the cost of a resize
(*) use our optimised OString concatentation instead of going via
std::stringstream
(*) pass down a pointer to rectangle, instead of a string. later we will
use this to avoid doing the stringify until later
Change-Id: Ia3e3042bc919d9b9cb80e47a93704eb236438605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119994
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Michael Meeks
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120072
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/controller/main/ChartWindow.cxx
b/chart2/source/controller/main/ChartWindow.cxx
index 73e642446be1..ad5afd131b96 100644
--- a/chart2/source/controller/main/ChartWindow.cxx
+++ b/chart2/source/controller/main/ChartWindow.cxx
@@ -283,11 +283,11 @@ void ChartWindow::LogicInvalidate(const tools::Rectangle*
pRectangle)
SfxViewShell* pCurrentShell = SfxViewShell::Current();
if ( nullptr == pCurrentShell )
return;
-OString sRectangle;
+tools::Rectangle aResultRectangle;
if (!pRectangle)
{
// we have to invalidate the whole chart area not the whole document
-sRectangle = GetBoundingBox().toString();
+aResultRectangle = GetBoundingBox();
}
else
{
@@ -325,9 +325,9 @@ void ChartWindow::LogicInvalidate(const tools::Rectangle*
pRectangle)
aRectangle = tools::Rectangle(aRectangle.TopLeft() + aOffset,
aRectangle.GetSize());
}
-sRectangle = aRectangle.toString();
+aResultRectangle = aRectangle;
}
-SfxLokHelper::notifyInvalidation(pCurrentShell, sRectangle);
+SfxLokHelper::notifyInvalidation(pCurrentShell, );
}
FactoryFunction ChartWindow::GetUITestFactory() const
diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index e47c92cc5c0a..e27f0563cd58 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -47,11 +47,10 @@ namespace desktop {
OString toString() const
{
-std::stringstream ss;
-ss << m_aRectangle.toString();
if (m_nPart >= -1)
-ss << ", " << m_nPart;
-return ss.str().c_str();
+return m_aRectangle.toString() + ", " +
OString::number(m_nPart);
+else
+return m_aRectangle.toString();
}
/// Infinite Rectangle is both sides are
diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx
index f10bac147933..a806f022fa19 100644
--- a/include/sfx2/lokhelper.hxx
+++ b/include/sfx2/lokhelper.hxx
@@ -15,6 +15,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -105,7 +106,7 @@ public:
/// Emits a LOK_CALLBACK_DOCUMENT_SIZE_CHANGED for all views of the same
document - if @bInvalidateAll - first invalidates all parts
static void notifyDocumentSizeChangedAllViews(vcl::ITiledRenderable* pDoc,
bool bInvalidateAll = true);
/// Emits a LOK_CALLBACK_INVALIDATE_TILES, but tweaks it according to
setOptionalFeatures() if needed.
-static void notifyInvalidation(SfxViewShell const* pThisView,
std::string_view rPayload);
+static void notifyInvalidation(SfxViewShell const* pThisView,
tools::Rectangle const *);
/// Emits a LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, but tweaks it
according to setOptionalFeatures() if needed.
static void notifyVisCursorInvalidation(OutlinerViewShell const*
pThisView, const OString& rRectangle, bool bMispelledWord = false, const
OString& rHyperlink = "");
/// Notifies all views with the given type and payload.
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index a6ca5defcfa6..dab88b11717f 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1543,12 +1543,13 @@ void
[Libreoffice-bugs] [Bug 143753] Fontwork insert on the wrong page (before page break instead of after)
https://bugs.documentfoundation.org/show_bug.cgi?id=143753 Telesto changed: What|Removed |Added Version|7.3.0.0 alpha0+ Master |Inherited From OOo --- Comment #1 from Telesto --- Also in LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143754] New: No Help page for Tools>Options…>Language settings>English Sentence Checking in 7.2.0.2.
https://bugs.documentfoundation.org/show_bug.cgi?id=143754 Bug ID: 143754 Summary: No Help page for Tools>Options…>Language settings>English Sentence Checking in 7.2.0.2. Product: LibreOffice Version: 7.2.0.2 rc Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tarotf...@protonmail.com Description: In version 7.2.0.2 in Writer… There is no Help page for Tools>Options…>Language settings>English Sentence Checking. Steps to Reproduce: 1. Open Tools>Options…>Language settings>English Sentence Checking 2. Press Help button 3. Note that there is no help page displayed Actual Results: Pressing the Help button displays the following error message: Could not find Help page (404). That is an error. Possible causes are: The page does not exist and must be created. The page exists, but the Help ID is wrong or missing. Use the Module, Contents, Index and Search selectors to find the right page. The following data could be helpful in locating the error: Help ID: cui/ui/optionsdialog/dialog-action_area1 Expected Results: Help page information pertaining to the English Sentence Checking. Reproducible: Always User Profile Reset: Yes Additional Info: The error message portion that states "Use the Module, Contents, Index and Search selectors to find the right page." is unclear because there is no module, contents, index, or search tabs in that dialog or in the Tools drop-down menu. Version: 7.2.0.2 (x64) / LibreOffice Community Build ID: 614be4f5c67816389257027dc5e56c801a547089 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143753] New: Fontwork insert on the wrong page (before page break instead of after)
https://bugs.documentfoundation.org/show_bug.cgi?id=143753 Bug ID: 143753 Summary: Fontwork insert on the wrong page (before page break instead of after) Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Fontwork insert on the wrong page (before page break instead of after) Steps to Reproduce: 1. Open Writer 2. CTRL+Enter 3. Insert -> Fontwork -> Press OK Actual Results: On page 1 Expected Results: On page 2 Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143752] New: DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0
https://bugs.documentfoundation.org/show_bug.cgi?id=143752 Bug ID: 143752 Summary: DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0 Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0 Steps to Reproduce: 1. Open Writer 2. Insert -> Footwork 3. CTRL+Z Actual Results: DeckLayouter.cxx:489: OSL_ASSERT: nRemainingHeightToDistribute==0 passes by Expected Results: Not sure what the quality of the assert is. Lacking true debug build.. so maybe something spurious. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143750] Missing or extra parentheses and/or quotation marks function no longer works in version 7.2.0.2.
https://bugs.documentfoundation.org/show_bug.cgi?id=143750 Eek! A Bug. Kill it! changed: What|Removed |Added CC||tarotf...@protonmail.com OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sw/source
sw/source/core/draw/dview.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit fd7ac9010aabc89286e6e7d7ee5b565c8c5b22cb
Author: Vasily Melenchuk
AuthorDate: Thu Aug 5 11:16:58 2021 +0300
Commit: Thorsten Behrens
CommitDate: Thu Aug 5 21:48:01 2021 +0200
tdf#99932: sw: fix for invalid anchor location for FLY_AT_CHAR mode
In such case anchor position depends on LastCharRect which can be
invalid because of happened frame movement, resize, etc.
Change-Id: I3d3c6318ee1ce5f4043e21ab091417d283c4260c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120059
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
(cherry picked from commit 6e879d5f142766c941d1c3bafd17f67b78c1c9f4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119989
Tested-by: Thorsten Behrens
diff --git a/sw/source/core/draw/dview.cxx b/sw/source/core/draw/dview.cxx
index c1a7b6a8cbbc..b20ae1031382 100644
--- a/sw/source/core/draw/dview.cxx
+++ b/sw/source/core/draw/dview.cxx
@@ -231,6 +231,11 @@ void SwDrawView::AddCustomHdl()
// #i28701# - use last character rectangle saved at object
// in order to avoid a format of the anchor frame
SwAnchoredObject* pAnchoredObj = ::GetUserCall( pObj
)->GetAnchoredObj( pObj );
+
+// Invalidate/recalc LastCharRect which can contain invalid frame
offset because
+// of later frame changes
+pAnchoredObj->CheckCharRectAndTopOfLine(false);
+
SwRect aAutoPos = pAnchoredObj->GetLastCharRect();
if ( aAutoPos.Height() )
{
[Libreoffice-bugs] [Bug 143751] New: Text AutoSave option doesn't save changes during the work with a document and after restoring.
https://bugs.documentfoundation.org/show_bug.cgi?id=143751 Bug ID: 143751 Summary: Text AutoSave option doesn't save changes during the work with a document and after restoring. Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ksui...@yandex.ru Description: Text AutoSave option doesn't save changes during the work with a document and after restoring. Steps to Reproduce: 1. Create (or open) a document in Writer and add a new text to it. In the parameters "Option" - "Load/Save" - "Save" set up Save AutoRecovery information, for example, every 1 minute. 2.Don't perform any more actions for the next 1 minute. After 60-70 seconds, force the app to terminate, for example, turn off the computer. 3. Open the document again, press "Start" to restore the document you edited and after the restore procedure check, if the added text is saved. 4. Then during the next 60-70 seconds start typing random text. After that, force the app to be shutted down again as in the p. 2. 5. Open this document again. After the restore procedure check, if the added text is saved. The steps also were reproduced for the time periods: 1. when enable option "Save AutoRecovery information" for 1 min (PC restarted after: more than in 1 min (e.g. 70 seconds ) and then in less than 1 min (e.g. 40 seconds)) 2. when enable option "Save AutoRecovery information" for 2 min (PC restarted after: more than in 2 min (e.g. 2 min 30 seconds) and then in less than 2 min (e.g. 1 min 30 seconds)) 3. when enable option "Save AutoRecovery information" for 5 min (PC restarted after more than in 5 min (e.g. 5 min 30 seconds) and then in less than 5 min (e.g. 4 min 30 seconds)). Actual Results: Text AutoSave option doesn't save changes during the work with a document and after restoring. Expected Results: Text AutoSave option always saves changes during the work with a document and after restoring. Reproducible: Always User Profile Reset: No Additional Info: Win 7 Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ac80ec817eb07c77a51bc0729985a473c734182e CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: en-US (ru_RU); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143750] New: Missing or extra parentheses and/or quotation marks function no longer works in version 7.2.0.2.
https://bugs.documentfoundation.org/show_bug.cgi?id=143750 Bug ID: 143750 Summary: Missing or extra parentheses and/or quotation marks function no longer works in version 7.2.0.2. Product: LibreOffice Version: 7.2.0.2 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tarotf...@protonmail.com Description: In version 7.2.0.2 in Writer… The following function only works intermittently (to the point you may as well say it does NOT work at all) in the Tools>Options…>Language settings>Grammar checking settings: The Parentheses function only works on very rare occasions (as indicated by a blue squiggly line), such that it is totally unreliable. It should detect missing or extra parentheses and/or quotation marks. It used to work fine, but NOT in the newest update. By very rare, I mean it has only worked for me once out of at least 30 tests of either missing or extra punctuation marks even after closing and restarting the application. Steps to Reproduce: 1. Tools>Options…>Language settings>Grammar checking 2. Make sure Parenthesis checkbox is checked 3. Open a Writer document and insert unpaired parentheses and quotation marks 4. Also insert extra parentheses and quotation marks 5. Note there are no blue squiggly lines indicating an error in punctuation. Actual Results: It does not detect missing or extra parentheses and/or quotation marks. Expected Results: It should detect missing or extra parentheses and/or quotation marks. Reproducible: Always User Profile Reset: Yes Additional Info: n/a -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749
--- Comment #4 from Julien Nabet ---
Just for the record because I wouldn't pretend it's the right fix, if I put
"pImpl->MouseButtonDown( rMEvt );" after "pImpl->m_pCursorOld =...", it doesn't
crash.
diff --git a/vcl/source/treelist/treelistbox.cxx
b/vcl/source/treelist/treelistbox.cxx
index ee4b01981007..19bff1f8ee7d 100644
--- a/vcl/source/treelist/treelistbox.cxx
+++ b/vcl/source/treelist/treelistbox.cxx
@@ -2286,12 +2286,12 @@ void SvTreeListBox::Paint(vcl::RenderContext&
rRenderContext, const tools::Recta
void SvTreeListBox::MouseButtonDown( const MouseEvent& rMEvt )
{
-pImpl->MouseButtonDown( rMEvt );
-
// tdf#143114 remember the *correct* starting entry
pImpl->m_pCursorOld = (rMEvt.IsLeft() && (nTreeFlags &
SvTreeFlags::CHKBTN) && mnClicksToToggle > 0)
? GetEntry(rMEvt.GetPosPixel())
: nullptr;
+
+pImpl->MouseButtonDown( rMEvt );
}
void SvTreeListBox::MouseButtonUp( const MouseEvent& rMEvt )
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749
--- Comment #3 from Julien Nabet ---
I wonder if there's not a mutex or something lacking.
Here's some gdb session:
Thread 1 "soffice.bin" hit Breakpoint 1, SvTreeListBox::MouseButtonDown
(this=0x7d35230, rMEvt=...) at vcl/source/treelist/treelistbox.cxx:2289
2289pImpl->MouseButtonDown( rMEvt );
(gdb) p pImpl
$4 = std::unique_ptr = {get() = 0x7d38450}
(gdb) n
[New Thread 0x7fb8804a5700 (LWP 36956)]
[Thread 0x7fb8804a5700 (LWP 36956) exited]
[New Thread 0x7fb8804a5700 (LWP 36957)]
[Thread 0x7fb8804a5700 (LWP 36957) exited]
2292pImpl->m_pCursorOld = (rMEvt.IsLeft() && (nTreeFlags &
SvTreeFlags::CHKBTN) && mnClicksToToggle > 0)
(gdb) p pImpl
$5 = std::unique_ptr = {get() = 0x0}
It seems something in // emptied pImpl
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749 --- Comment #2 from Julien Nabet --- I confirm I don't reproduce the crash by reverting locally https://git.libreoffice.org/core/commit/ca7dab5d96e73b7b4b045e2460e0b2ee150757db. (just for the record, still these: warn:legacy.osl:36257:36257:sfx2/source/doc/sfxbasemodel.cxx:2943: SfxBaseModel::IsInitialized: this should have been caught earlier! warn:xmloff.core:36257:36257:xmloff/source/core/xmlimp.cxx:928: DBG_UNHANDLED_EXCEPTION in setTargetDocument exception: com.sun.star.lang.NotInitializedException message: /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2955 even without reverting and with gtk3 rendering) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749 Julien Nabet changed: What|Removed |Added Keywords||haveBacktrace -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Created attachment 174108 --> https://bugs.documentfoundation.org/attachment.cgi?id=174108=edit bt with debug symbols On pc Debian x86-64 with master sources updated today, I could reproduce this (from Writer) with gen or kf5 renderings (not with gtk3). I also noticed this on console: warn:legacy.osl:35470:35470:sfx2/source/doc/sfxbasemodel.cxx:2943: SfxBaseModel::IsInitialized: this should have been caught earlier! warn:xmloff.core:35470:35470:xmloff/source/core/xmlimp.cxx:928: DBG_UNHANDLED_EXCEPTION in setTargetDocument exception: com.sun.star.lang.NotInitializedException message: /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2955 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143728] Certain presentation crashes Impress after starting slideshow (Win crashes, Linux hangs)
https://bugs.documentfoundation.org/show_bug.cgi?id=143728 --- Comment #8 from Buovjaga --- (In reply to Buovjaga from comment #7) > (In reply to Telesto from comment #6) > > Only mentioning: Insert -> Fontwork -> Double click any fontwork does crash > > too. Not sure if it's still the case after comment 4 (have to wait a day for > > a pre-build master) > > Still crashes, I will investigate it Created bug 143749 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749 Buovjaga changed: What|Removed |Added CC||armin.le.gr...@me.com, ||tele...@surfxs.nl Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143749] New: Inserting fontwork causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=143749 Bug ID: 143749 Summary: Inserting fontwork causes crash Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Keywords: bibisected, bisected, regression Severity: critical Priority: high Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ilmari.lauhakan...@libreoffice.org 1. Insert -> Fontwork -> Double click any fontwork -> crash Bibisected with linux-64-7.3 to https://git.libreoffice.org/core/commit/ca7dab5d96e73b7b4b045e2460e0b2ee150757db tdf#143114 Avoid StartDrag on TreeListBox when CaptureOnButton First reported by Telesto in bug 143728 comment 6 Adding Cc: to Armin Le Grand -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143114] Libclplug: kf5 support errors
https://bugs.documentfoundation.org/show_bug.cgi?id=143114 Buovjaga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3749 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/cmis/std_inputstream.cxx | 10 +-
ucb/source/ucp/cmis/std_inputstream.hxx |4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit 466d464a7f31f10475c14260c6b0f11f1cb5a931
Author: Noel Grandin
AuthorDate: Wed Aug 4 21:07:40 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 20:39:57 2021 +0200
osl::Mutex->std::mutex in StdInputStream
Change-Id: I85f7a67732d7739baa8b20d8e5df884080d31467
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120019
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/cmis/std_inputstream.cxx
b/ucb/source/ucp/cmis/std_inputstream.cxx
index 9ec4f6034f95..6ab970d327f3 100644
--- a/ucb/source/ucp/cmis/std_inputstream.cxx
+++ b/ucb/source/ucp/cmis/std_inputstream.cxx
@@ -61,7 +61,7 @@ namespace cmis
sal_Int32 SAL_CALL StdInputStream::readBytes( uno::Sequence< sal_Int8 >&
aData, sal_Int32 nBytesToRead )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if ( 0 <= nBytesToRead && aData.getLength() < nBytesToRead )
aData.realloc( nBytesToRead );
@@ -87,7 +87,7 @@ namespace cmis
sal_Int32 SAL_CALL StdInputStream::readSomeBytes( uno::Sequence< sal_Int8
>& aData,
sal_Int32 nMaxBytesToRead )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if ( 0 <= nMaxBytesToRead && aData.getLength() < nMaxBytesToRead )
aData.realloc( nMaxBytesToRead );
@@ -110,7 +110,7 @@ namespace cmis
void SAL_CALL StdInputStream::skipBytes( sal_Int32 nBytesToSkip )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if (!m_pStream)
throw io::IOException( );
@@ -138,7 +138,7 @@ namespace cmis
void SAL_CALL StdInputStream::seek( sal_Int64 location )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if ( location < 0 || location > m_nLength )
throw lang::IllegalArgumentException(
@@ -162,7 +162,7 @@ namespace cmis
sal_Int64 SAL_CALL StdInputStream::getPosition( )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if (!m_pStream)
throw io::IOException( );
diff --git a/ucb/source/ucp/cmis/std_inputstream.hxx
b/ucb/source/ucp/cmis/std_inputstream.hxx
index 82bf5e39b568..7cfcf7a88901 100644
--- a/ucb/source/ucp/cmis/std_inputstream.hxx
+++ b/ucb/source/ucp/cmis/std_inputstream.hxx
@@ -12,7 +12,7 @@
#include
#include
-#include
+#include
#include
#include
#include
@@ -73,7 +73,7 @@ namespace cmis
private:
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
boost::shared_ptr< std::istream > m_pStream;
sal_Int64 m_nLength;
};
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/cmis/std_outputstream.cxx |6 +++---
ucb/source/ucp/cmis/std_outputstream.hxx |4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 85d8b2f34bbb50288217fae395f72e1d1df7f4d6
Author: Noel Grandin
AuthorDate: Wed Aug 4 21:08:59 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 20:37:44 2021 +0200
osl::Mutex->std::mutex in StdOutputStream
Change-Id: I32f9366eef17f213d6b3dc9b5c0b6ba7ff9e7d83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120020
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/cmis/std_outputstream.cxx
b/ucb/source/ucp/cmis/std_outputstream.cxx
index deb70fb65f95..c1a3087a1923 100644
--- a/ucb/source/ucp/cmis/std_outputstream.cxx
+++ b/ucb/source/ucp/cmis/std_outputstream.cxx
@@ -50,7 +50,7 @@ namespace cmis
void SAL_CALL StdOutputStream::writeBytes ( const uno::Sequence< sal_Int8
>& aData )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if (!m_pStream)
throw io::IOException( );
@@ -68,7 +68,7 @@ namespace cmis
void SAL_CALL StdOutputStream::flush ( )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if (!m_pStream)
throw io::IOException( );
@@ -86,7 +86,7 @@ namespace cmis
void SAL_CALL StdOutputStream::closeOutput ( )
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if (!m_pStream)
throw io::IOException( );
diff --git a/ucb/source/ucp/cmis/std_outputstream.hxx
b/ucb/source/ucp/cmis/std_outputstream.hxx
index 4cf10646e7b9..74eb4681e912 100644
--- a/ucb/source/ucp/cmis/std_outputstream.hxx
+++ b/ucb/source/ucp/cmis/std_outputstream.hxx
@@ -12,7 +12,7 @@
#include
#include
-#include
+#include
#include
#include
@@ -45,7 +45,7 @@ namespace cmis
private:
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
boost::shared_ptr< std::ostream > m_pStream;
};
}
[Libreoffice-bugs] [Bug 143576] Red hatch has faded colors in Skia/GTK3 for a sphere (3D object). Anti-aliasing involved
https://bugs.documentfoundation.org/show_bug.cgi?id=143576 Telesto changed: What|Removed |Added Keywords|bibisectRequest, regression | Version|7.3.0.0 alpha0+ Master |Inherited From OOo --- Comment #5 from Telesto --- (In reply to Buovjaga from comment #4) > So is it really a regression or a case of the setting with different > versions you tried? I didn't see any difference when aliasing was on in 7.0 > repo oldest Well you're right.. Also seen in LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)
https://bugs.documentfoundation.org/show_bug.cgi?id=143148 --- Comment #5 from Commit Notification --- oguzbalkaya committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ae1ac7eaf14a78bff050b90daaf7a9996cfc2f9a tdf#143148: Use pragma once instead of include guards It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - include/vcl vcl/inc
include/vcl/toolkit/dialog.hxx |6 +++--- vcl/inc/osx/vclnsapp.h |5 + 2 files changed, 4 insertions(+), 7 deletions(-) New commits: commit ae1ac7eaf14a78bff050b90daaf7a9996cfc2f9a Author: oguzbalkaya AuthorDate: Wed Aug 4 00:08:12 2021 +0300 Commit: Ilmari Lauhakangas CommitDate: Thu Aug 5 20:22:37 2021 +0200 tdf#143148: Use pragma once instead of include guards Change-Id: I036dd26b2e70c12896afcef2ce25586e8db3098c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119959 Tested-by: Ilmari Lauhakangas Reviewed-by: Ilmari Lauhakangas diff --git a/vcl/inc/osx/vclnsapp.h b/vcl/inc/osx/vclnsapp.h index 82f0229a9f93..5cf8582c3771 100644 --- a/vcl/inc/osx/vclnsapp.h +++ b/vcl/inc/osx/vclnsapp.h @@ -17,8 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef INCLUDED_VCL_INC_OSX_VCLNSAPP_H -#define INCLUDED_VCL_INC_OSX_VCLNSAPP_H +#pragma once #include @@ -63,6 +62,4 @@ class AquaSalFrame; -(void)setDockIconClickHandler: (NSObject*)pHandler; @end -#endif // INCLUDED_VCL_INC_OSX_VCLNSAPP_H - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit c4127ca194a20aa81da6fb09d765f353cadd6eb8 Author: Caolán McNamara AuthorDate: Thu Aug 5 16:49:18 2021 +0100 Commit: Caolán McNamara CommitDate: Thu Aug 5 20:22:22 2021 +0200 make Dialog::GetDefaultParent private Change-Id: I47d8e125646ee72aa6a9c12bbfdf09a784769d85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120080 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/include/vcl/toolkit/dialog.hxx b/include/vcl/toolkit/dialog.hxx index 377ae37cc66d..52f58957bc5a 100644 --- a/include/vcl/toolkit/dialog.hxx +++ b/include/vcl/toolkit/dialog.hxx @@ -74,6 +74,9 @@ private: DECL_DLLPRIVATE_LINK(ImplAsyncCloseHdl, void*, void); DECL_DLLPRIVATE_LINK(ResponseHdl, Button*, void); +// get the default parent for a dialog as is done in standard initialization +SAL_DLLPRIVATE static vcl::Window* GetDefaultParent(WinBits nStyle); + protected: voidImplInitDialog( vcl::Window* pParent, WinBits nStyle, InitFlag eFlag = InitFlag::Default ); @@ -102,9 +105,6 @@ public: virtual ~Dialog() override; virtual voiddispose() override; -// get the default parent for a dialog as is done in standard initialization -static vcl::Window* GetDefaultParent(WinBits nStyle); - virtual boolEventNotify( NotifyEvent& rNEvt ) override; virtual voidStateChanged( StateChangedType nStateChange ) override; virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
[Libreoffice-bugs] [Bug 77061] ACCESSIBILITY: Java 8 JRE 1.8u0 and Java Acces Bridge 2.0.4 incompatible for UAA bridge on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=77061 Caolán McNamara changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143748] Redo of pattern fill to a sphere isn't working
https://bugs.documentfoundation.org/show_bug.cgi?id=143748 Telesto changed: What|Removed |Added Version|7.3.0.0 alpha0+ Master |Inherited From OOo --- Comment #1 from Telesto --- Also in 4.4.7.2 and in LibreOffice 3.5.7.2 Build ID: 3215f89-f603614-ab984f2-7348103-1225a5b -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143728] Certain presentation crashes Impress after starting slideshow (Win crashes, Linux hangs)
https://bugs.documentfoundation.org/show_bug.cgi?id=143728 --- Comment #7 from Buovjaga --- (In reply to Telesto from comment #6) > Only mentioning: Insert -> Fontwork -> Double click any fontwork does crash > too. Not sure if it's still the case after comment 4 (have to wait a day for > a pre-build master) Still crashes, I will investigate it -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143576] Red hatch has faded colors in Skia/GTK3 for a sphere (3D object). Anti-aliasing involved
https://bugs.documentfoundation.org/show_bug.cgi?id=143576 --- Comment #4 from Buovjaga --- (In reply to Telesto from comment #3) > Hmm.. apparently anti-aliasing being responsible for the color shift. Turned > off it's OK. Turned on it's getting bad So is it really a regression or a case of the setting with different versions you tried? I didn't see any difference when aliasing was on in 7.0 repo oldest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143748] New: Redo of pattern fill to a sphere isn't working
https://bugs.documentfoundation.org/show_bug.cgi?id=143748 Bug ID: 143748 Summary: Redo of pattern fill to a sphere isn't working Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Redo of pattern fill to a sphere isn't working Steps to Reproduce: 1. Open Impress 2. Insert a 3d object from the toolbar 3. Format -> Object & shape -> Area -> Pattern tab -> pick a pattern & press OK 4. CTRL+Z 5. CTRL+Y Actual Results: CTRL+Y doesn't do anything Expected Results: Should be so Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: setup_native/Package_packinfo.mk setup_native/source
setup_native/Package_packinfo.mk | 11 +-- setup_native/source/packinfo/package.txt |1 - 2 files changed, 9 insertions(+), 3 deletions(-) New commits: commit f267340d300da6318435ed1b2ae48b9f4275e2c4 Author: Stephan Bergmann AuthorDate: Thu Aug 5 18:18:26 2021 +0200 Commit: Stephan Bergmann CommitDate: Thu Aug 5 20:05:43 2021 +0200 Remove unused $(LIBO_SHARE_FOLDER)/extensions/package.txt There had originally been some back-and-forth among 134ae5da1cc6a5dfa4432063f930235c1a872bc0 "jl154 #162868# remove basis/presets/bundled/bundled.ini, and create always share/extensions folder", 4c333e8ac7f6135fb4e62e4960c826b278e8cc63 "jl154 #162868# removing the package.txt from the extensions folder. Extensions folder will be created in a different way than installing a dummy file", and 8f4cf9a16eb9936ef1e862ecdec7d30c9e240987 "jl154 #162868# guarantee existence of extensions folder" whether or not that dummy file was necessary to ensure creation of the (otherwise potentially empty) $(LIBO_SHARE_FOLDER)/extensions/ directory. That is no longer necessary with gb_Package_add_empty_directory (though the logic that had to be added to setup_native/Package_packinfo.mk now is a bit unfortunate, and will need to be updated whenever the list of potential bundled extensions changes). (And that dummy package.txt file is apparently not used to track whether per- user extension information needs to be updated when the contents of $(LIBO_SHARE_FOLDER)/extensions/ changes. That is rather done by comparing the status of the $(LIBO_SHARE_FOLDER)/extensions/ directory itself against user/extensions/bundled/lastsynchronized in the UserInstallation, see needToSyncRepository in desktop/source/deployment/misc/dp_misc.cxx.) Change-Id: I5b9956c508288945f32a88afaef57ac0b63dc27f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120081 Tested-by: Jenkins Reviewed-by: Stephan Bergmann diff --git a/setup_native/Package_packinfo.mk b/setup_native/Package_packinfo.mk index 2519ead95165..18560b2f0694 100644 --- a/setup_native/Package_packinfo.mk +++ b/setup_native/Package_packinfo.mk @@ -7,8 +7,15 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -$(eval $(call gb_Package_Package,setup_native_packinfo,$(SRCDIR)/setup_native/source/packinfo)) +$(eval $(call gb_Package_Package,setup_native_packinfo)) -$(eval $(call gb_Package_add_file,setup_native_packinfo,$(LIBO_SHARE_FOLDER)/extensions/package.txt,package.txt)) +# Check if any bundled extensions are installed (where ENABLE_JAVA covers Extension_nlpsolver, cf. +# nlpsolver/Module_nlpsolver.mk); if none are installed, then gb_Package_add_empty_directory is +# needed to create the empty extensions directory (but if any are installed, then +# gb_Package_add_empty_directory would cause errors during CustomTarget_instsetoo_native/install, as +# the directory is not empty in that case): +ifeq ($(filter CT2N DICTIONARIES LANGUAGETOOL,$(BUILD_TYPE))$(ENABLE_MEDIAWIKI)$(NUMBERTEXT_EXTENSION_PACK)$(ENABLE_JAVA),) +$(eval $(call gb_Package_add_empty_directory,setup_native_packinfo,$(LIBO_SHARE_FOLDER)/extensions)) +endif # vim: set noet sw=4 ts=4: diff --git a/setup_native/source/packinfo/package.txt b/setup_native/source/packinfo/package.txt deleted file mode 100644 index 4ec319646932.. --- a/setup_native/source/packinfo/package.txt +++ /dev/null @@ -1 +0,0 @@ -DO NOT DELETE THIS FILE \ No newline at end of file
[Libreoffice-bugs] [Bug 138558] Impress: Residual grey bar at bottom of black 4:3 presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=138558 --- Comment #3 from Tom --- Reproduced in: Version: 7.1.5.2 / LibreOffice Community Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5 CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: de-DE (en_US.UTF-8); UI: en-US Calc: threaded Maybe, this is in fact a UI issue? This would explain the missing reproduction found by AnnaV under Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143728] Certain presentation crashes Impress after starting slideshow (Win crashes, Linux hangs)
https://bugs.documentfoundation.org/show_bug.cgi?id=143728 --- Comment #6 from Telesto --- Only mentioning: Insert -> Fontwork -> Double click any fontwork does crash too. Not sure if it's still the case after comment 4 (have to wait a day for a pre-build master) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143576] Red hatch has faded colors in Skia/GTK3 for a sphere (3D object). Anti-aliasing involved
https://bugs.documentfoundation.org/show_bug.cgi?id=143576 Telesto changed: What|Removed |Added Summary|Red hatch has faded colors |Red hatch has faded colors |in Skia/GTK3 compared to|in Skia/GTK3 for a sphere |GDI for a sphere (3D|(3D object). Anti-aliasing |object). GDI matches my |involved |expectations| --- Comment #3 from Telesto --- Hmm.. apparently anti-aliasing being responsible for the color shift. Turned off it's OK. Turned on it's getting bad -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 77061] ACCESSIBILITY: Java 8 JRE 1.8u0 and Java Acces Bridge 2.0.4 incompatible for UAA bridge on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=77061 --- Comment #6 from DonaldCahoon --- Here the tool updates are quite updated and these are working great. The designing tools are very efficient and we can do our work fast and easily. I admire your great effort https://assignmentmasters.org/ about the graphic designing tools really wise thanks for having them here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 77061] ACCESSIBILITY: Java 8 JRE 1.8u0 and Java Acces Bridge 2.0.4 incompatible for UAA bridge on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=77061 --- Comment #5 from DonaldCahoon --- thanks for the bug fixing error. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - jvmfwk/source
Rebased ref, commits from common ancestor:
commit e62c3976023efc233cbefe47bee0ff514286bcf4
Author: Samuel Mehrbrodt
AuthorDate: Mon Aug 2 12:21:17 2021 +0200
Commit: Thorsten Behrens
CommitDate: Thu Aug 5 19:18:48 2021 +0200
Fix alternate JREs missing bin/ directory on java.library.path
Exception looks like this:
java stack trace:
java.lang.UnsatisfiedLinkError: zulu11\bin\fontmanager.dll: Can't find
depende
nt libraries
at java.base/java.lang.ClassLoader$NativeLibrary.load0(Native
Method)
at
java.base/java.lang.ClassLoader$NativeLibrary.load(ClassLoader.java:2442)
at
java.base/java.lang.ClassLoader$NativeLibrary.loadLibrary(ClassLoader.java:2498)
at
java.base/java.lang.ClassLoader.loadLibrary0(ClassLoader.java:2694)
at
java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2648)
at java.base/java.lang.Runtime.loadLibrary0(Runtime.java:830)
at java.base/java.lang.System.loadLibrary(System.java:1873)
at
java.desktop/sun.font.FontManagerNativeLibrary$1.run(FontManagerNativeLibrary.java:57)
at java.base/java.security.AccessController.doPrivileged(Native
Method)
at
java.desktop/sun.font.FontManagerNativeLibrary.(FontManagerNativeLibrary.java:32)
at
java.desktop/sun.font.SunFontManager$1.run(SunFontManager.java:279)
at java.base/java.security.AccessController.doPrivileged(Native
Method)
at
java.desktop/sun.font.SunFontManager.(SunFontManager.java:275)
at java.base/java.lang.Class.forName0(Native Method)
at java.base/java.lang.Class.forName(Class.java:398)
at
java.desktop/sun.font.FontManagerFactory$1.run(FontManagerFactory.java:82)
at java.base/java.security.AccessController.doPrivileged(Native
Method)
at
java.desktop/sun.font.FontManagerFactory.getInstance(FontManagerFactory.java:74)
at
java.desktop/sun.java2d.SunGraphicsEnvironment.getFontManagerForSGE(SunGraphicsEnvironment.ja
va:189)
at
java.desktop/sun.java2d.SunGraphicsEnvironment.getAvailableFontFamilyNames(SunGraphicsEnviron
ment.java:223)
at
java.desktop/sun.java2d.SunGraphicsEnvironment.getAvailableFontFamilyNames(SunGraphicsEnviron
ment.java:251)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119880
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 48c5ba19e4f4a1ad5a88b5e6f0816c080e1253ec)
Change-Id: I7a16bb5813d4c089ddb4de34a250280cf6fee137
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119969
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/jvmfwk/source/framework.cxx b/jvmfwk/source/framework.cxx
index f0f04b8f733e..9f97d8dd876f 100644
--- a/jvmfwk/source/framework.cxx
+++ b/jvmfwk/source/framework.cxx
@@ -25,6 +25,8 @@
#include
#include
+#include
+#include
#include
#include
#include
@@ -219,6 +221,22 @@ javaFrameworkError jfw_startVM(
}
assert(pInfo != nullptr);
+#ifdef _WIN32
+// Alternative JREs (AdoptOpenJDK, Azul Zulu) are missing the bin/
folder in
+// java.library.path. Somehow setting java.library.path accordingly
doesn't work,
+// but the PATH gets picked up, so add it there.
+// Without this hack, some features don't work in alternative JREs.
+OUString sPATH;
+osl_getEnvironment(OUString("PATH").pData, );
+OUString sJRELocation;
+osl::FileBase::getSystemPathFromFileURL(pInfo->sLocation + "/bin",
sJRELocation);
+if (sPATH.isEmpty())
+sPATH = sJRELocation;
+else
+sPATH = sJRELocation + OUStringLiteral1(SAL_PATHSEPARATOR) + sPATH;
+osl_setEnvironment(OUString("PATH").pData, sPATH.pData);
+#endif // _WIN32
+
// create JavaVMOptions array that is passed to the plugin
// it contains the classpath and all options set in the
//options dialog
[Libreoffice-bugs] [Bug 143605] Unnumbered Heading1 is numbered
https://bugs.documentfoundation.org/show_bug.cgi?id=143605 NISZ LibreOffice Team changed: What|Removed |Added Status|NEEDINFO|NEW CC||libreoff...@nisz.hu, ||vasily.melenc...@cib.de Keywords||bibisected, bisected, ||regression --- Comment #8 from NISZ LibreOffice Team --- This seems to have started with: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9987b518fca1476bd0ce8c86bcf6ac7c81f7b580 author Vasily Melenchuk 2021-06-14 14:27:56 +0300 committer Thorsten Behrens 2021-06-29 19:02:20 +0200 new ODF numbered list parameter loext:num-list-format Adding CC to: Vasily Melenchuk -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143573] Sphere is with hatch fill is pretty pixelated in presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=143573 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #5 from Buovjaga --- Not seen Version: 7.1.3.2 (x64) / LibreOffice Community Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1 CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: fi-FI (fi_FI); UI: fi-FI Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107923] [META] Zoom issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107923 Bug 107923 depends on bug 99932, which changed state. Bug 99932 Summary: Anchor "to Character": Anchor changes position to the document when zoom-in or out https://bugs.documentfoundation.org/show_bug.cgi?id=99932 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87740 Bug 87740 depends on bug 99932, which changed state. Bug 99932 Summary: Anchor "to Character": Anchor changes position to the document when zoom-in or out https://bugs.documentfoundation.org/show_bug.cgi?id=99932 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143728] Certain presentation crashes Impress after starting slideshow (Win crashes, Linux hangs)
https://bugs.documentfoundation.org/show_bug.cgi?id=143728 Buovjaga changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #5 from Buovjaga --- Verified, thanks! Arch Linux 64-bit Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: d43c1b9b88eeb800eaff4d63605892dc859d4f72 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 5 August 2021 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source
sw/inc/strings.hrc |1 +
sw/inc/swundo.hxx |3 ++-
sw/source/core/doc/docnum.cxx | 15 +++
sw/source/core/draw/dview.cxx |5 +
sw/source/core/inc/UndoCore.hxx | 14 ++
sw/source/core/undo/undobj.cxx |3 +++
sw/source/core/undo/unoutl.cxx | 24
7 files changed, 64 insertions(+), 1 deletion(-)
New commits:
commit 6e879d5f142766c941d1c3bafd17f67b78c1c9f4
Author: Vasily Melenchuk
AuthorDate: Thu Aug 5 11:16:58 2021 +0300
Commit: Thorsten Behrens
CommitDate: Thu Aug 5 18:34:09 2021 +0200
tdf#99932: sw: fix for invalid anchor location for FLY_AT_CHAR mode
In such case anchor position depends on LastCharRect which can be
invalid because of happened frame movement, resize, etc.
Change-Id: I3d3c6318ee1ce5f4043e21ab091417d283c4260c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120059
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sw/source/core/draw/dview.cxx b/sw/source/core/draw/dview.cxx
index 276fbf922c9a..aa116d3d7bb7 100644
--- a/sw/source/core/draw/dview.cxx
+++ b/sw/source/core/draw/dview.cxx
@@ -236,6 +236,11 @@ void SwDrawView::AddCustomHdl()
// #i28701# - use last character rectangle saved at object
// in order to avoid a format of the anchor frame
SwAnchoredObject* pAnchoredObj = ::GetUserCall( pObj
)->GetAnchoredObj( pObj );
+
+// Invalidate/recalc LastCharRect which can contain invalid frame
offset because
+// of later frame changes
+pAnchoredObj->CheckCharRectAndTopOfLine(false);
+
SwRect aAutoPos = pAnchoredObj->GetLastCharRect();
if ( aAutoPos.Height() )
{
commit 4edf3a964e764dcc40be729b8305476c5b968f1c
Author: Vasily Melenchuk
AuthorDate: Fri Jul 23 14:28:04 2021 +0300
Commit: Thorsten Behrens
CommitDate: Thu Aug 5 18:33:54 2021 +0200
sw: undo/redo for outline modification
Outline changes done via "Tools"->"Chapter Numbering" were
not tracked by undo/redo before.
Change-Id: I764dda526d2b17ecbb62eca0d6a9fb0b368c4a69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119405
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sw/inc/strings.hrc b/sw/inc/strings.hrc
index 4d374a5591f5..a6b502742989 100644
--- a/sw/inc/strings.hrc
+++ b/sw/inc/strings.hrc
@@ -453,6 +453,7 @@
#define STR_TEXT_CORRECTION NC_("STR_TEXT_CORRECTION",
"Text Correction")
#define STR_OUTLINE_LR NC_("STR_OUTLINE_LR",
"Promote/demote outline")
#define STR_OUTLINE_UD NC_("STR_OUTLINE_UD", "Move
outline")
+#define STR_OUTLINE_EDITNC_("STR_OUTLINE_EDIT",
"Modify outline")
#define STR_INSNUM NC_("STR_INSNUM", "Insert
numbering")
#define STR_NUMUP NC_("STR_NUMUP", "Promote
level")
#define STR_NUMDOWN NC_("STR_NUMDOWN", "Demote
level")
diff --git a/sw/inc/swundo.hxx b/sw/inc/swundo.hxx
index 90fa6c51d055..cda4ec02c49f 100644
--- a/sw/inc/swundo.hxx
+++ b/sw/inc/swundo.hxx
@@ -164,7 +164,8 @@ enum class SwUndoId
UI_TABLE_DELETE, // 133
CONFLICT, // 134
-INSERT_FORM_FIELD // 135
+INSERT_FORM_FIELD, // 135
+OUTLINE_EDIT, // 136
};
OUString GetUndoComment(SwUndoId eId);
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index fad2322f07d9..430d19220329 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -114,6 +114,16 @@ static sal_uInt8 GetUpperLvlChg( sal_uInt8 nCurLvl,
sal_uInt8 nLevel, sal_uInt16
void SwDoc::SetOutlineNumRule( const SwNumRule& rRule )
{
+if (GetIDocumentUndoRedo().DoesUndo())
+{
+GetIDocumentUndoRedo().StartUndo(SwUndoId::OUTLINE_EDIT, nullptr);
+if (mpOutlineRule)
+{
+GetIDocumentUndoRedo().AppendUndo(
+std::make_unique(*mpOutlineRule, rRule,
*this));
+}
+}
+
if( mpOutlineRule )
(*mpOutlineRule) = rRule;
else
@@ -158,6 +168,11 @@ void SwDoc::SetOutlineNumRule( const SwNumRule& rRule )
getIDocumentFieldsAccess().UpdateExpFields(nullptr, true);
+if (GetIDocumentUndoRedo().DoesUndo())
+{
+GetIDocumentUndoRedo().EndUndo(SwUndoId::OUTLINE_EDIT, nullptr);
+}
+
getIDocumentState().SetModified();
}
diff --git a/sw/source/core/inc/UndoCore.hxx b/sw/source/core/inc/UndoCore.hxx
index 1fcfae22f6e2..62fcccd0231c 100644
--- a/sw/source/core/inc/UndoCore.hxx
+++ b/sw/source/core/inc/UndoCore.hxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#include
@@ -221,6 +222,19 @@ public:
virtual void RepeatImpl( ::sw::RepeatContext & ) override;
};
+class SwUndoOutlineEdit final :
[Libreoffice-bugs] [Bug 134007] EDITING: Image anchored to paragraph gets removed when removing the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=134007 Buovjaga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||9514 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139514] Delete one of both paragraph below a table deletes the table
https://bugs.documentfoundation.org/show_bug.cgi?id=139514 Buovjaga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4007 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/filstr.cxx |8
ucb/source/ucp/file/filstr.hxx |4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 3487d85ea384f74c096499cfea8e565e778f8408
Author: Noel Grandin
AuthorDate: Wed Aug 4 21:36:25 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 18:24:07 2021 +0200
osl::Mutex->std::mutex in fileaccess::XStream_impl
Change-Id: I0cf23f83ae9c4bbd17f68992126143756b27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120025
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/file/filstr.cxx b/ucb/source/ucp/file/filstr.cxx
index 3031510a6b7f..8b4274cb60e0 100644
--- a/ucb/source/ucp/file/filstr.cxx
+++ b/ucb/source/ucp/file/filstr.cxx
@@ -88,7 +88,7 @@ uno::Reference< io::XInputStream > SAL_CALL
XStream_impl::getInputStream( )
{
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
m_bInputStreamCalled = true;
}
return uno::Reference< io::XInputStream >( this );
@@ -99,7 +99,7 @@ uno::Reference< io::XOutputStream > SAL_CALL
XStream_impl::getOutputStream( )
{
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
m_bOutputStreamCalled = true;
}
return uno::Reference< io::XOutputStream >( this );
@@ -208,7 +208,7 @@ XStream_impl::closeStream()
void SAL_CALL
XStream_impl::closeInput()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
m_bInputStreamCalled = false;
if( ! m_bOutputStreamCalled )
@@ -219,7 +219,7 @@ XStream_impl::closeInput()
void SAL_CALL
XStream_impl::closeOutput()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
m_bOutputStreamCalled = false;
if( ! m_bInputStreamCalled )
diff --git a/ucb/source/ucp/file/filstr.hxx b/ucb/source/ucp/file/filstr.hxx
index 13f963a9b751..e448f17052ab 100644
--- a/ucb/source/ucp/file/filstr.hxx
+++ b/ucb/source/ucp/file/filstr.hxx
@@ -18,7 +18,6 @@
*/
#pragma once
-#include
#include
#include
#include
@@ -27,6 +26,7 @@
#include
#include
#include
+#include
#include "filrec.hxx"
@@ -122,7 +122,7 @@ class XStream_impl : public cppu::WeakImplHelper<
private:
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
bool m_bInputStreamCalled,m_bOutputStreamCalled;
bool m_nIsOpen;
[Libreoffice-bugs] [Bug 87740] [META] Anchor and text wrapping bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=87740 Bug 87740 depends on bug 135629, which changed state. Bug 135629 Summary: Character can be deleted without image deletion if a second paragraph if present, else image deleted with character https://bugs.documentfoundation.org/show_bug.cgi?id=135629 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134007] EDITING: Image anchored to paragraph gets removed when removing the paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=134007 Buovjaga changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #5 from Buovjaga --- *** Bug 135629 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135629] Character can be deleted without image deletion if a second paragraph if present, else image deleted with character
https://bugs.documentfoundation.org/show_bug.cgi?id=135629 Buovjaga changed: What|Removed |Added Status|NEW |RESOLVED Keywords|bibisectRequest |bibisected, bisected CC||ilmari.lauhakangas@libreoff ||ice.org Version|7.1.0.0.alpha0+ |7.0.0.0.alpha0+ Resolution|--- |DUPLICATE --- Comment #7 from Buovjaga --- Bibisected to https://git.libreoffice.org/core/commit/91b2325808a75174f284c48c8b8afc118fad74e4 But another report exists, so duping to it *** This bug has been marked as a duplicate of bug 134007 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/hierarchy/hierarchydatasource.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit c0ab666edcd3507961eda47d80efaba4f4da129d
Author: Noel Grandin
AuthorDate: Wed Aug 4 21:47:49 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 18:23:49 2021 +0200
osl::Mutex->std::mutex in HierarchyDataAccess
Change-Id: I267c4efcedba5904b3b373f0b9ff3460731b7011
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120027
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
b/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
index 5970ba178a7d..a74524e70f35 100644
--- a/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
+++ b/ucb/source/ucp/hierarchy/hierarchydatasource.cxx
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
using namespace com::sun::star;
using namespace hierarchy_ucp;
@@ -72,7 +73,7 @@ class HierarchyDataAccess : public cppu::OWeakObject,
public util::XChangesNotifier,
public util::XChangesBatch
{
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
uno::Reference< uno::XInterface > m_xConfigAccess;
uno::Reference< lang::XComponent > m_xCfgC;
uno::Reference< lang::XSingleServiceFactory >m_xCfgSSF;
@@ -478,7 +479,7 @@ css::uno::Reference
HierarchyDataAccess::ensureOrigInterface(css::uno::Refere
{
if ( x.is() )
return x;
-osl::Guard< osl::Mutex > aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
if ( !x.is() )
x.set( m_xConfigAccess, uno::UNO_QUERY );
return x;
[Libreoffice-bugs] [Bug 108988] [META] Validity-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108988 Bug 108988 depends on bug 143699, which changed state. Bug 143699 Summary: Data -> Validity [Cell range] doesn't save "Sort entries" in xlsx format https://bugs.documentfoundation.org/show_bug.cgi?id=143699 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143699] Data -> Validity [Cell range] doesn't save "Sort entries" in xlsx format
https://bugs.documentfoundation.org/show_bug.cgi?id=143699 m.a.riosv changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED CC||miguelangelrv@libreoffice.o ||rg --- Comment #7 from m.a.riosv --- Then you are asking for a different thing, not duplicates even not sorted. Please open a new bug - enhancement for that. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/SidebarWinAcc.cxx |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit 0494ad3495efe9f72809f18abe3ca95d49d7412f
Author: Noel Grandin
AuthorDate: Wed Aug 4 19:11:04 2021 +0200
Commit: Noel Grandin
CommitDate: Thu Aug 5 18:22:40 2021 +0200
osl::Mutex->std::mutex in SidebarWinAccessibleContext
Change-Id: Ic8cba9d900f74511ad721085f9d728b43c1be3c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120018
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/uibase/docvw/SidebarWinAcc.cxx
b/sw/source/uibase/docvw/SidebarWinAcc.cxx
index 82046d7426dd..5859ebc83199 100644
--- a/sw/source/uibase/docvw/SidebarWinAcc.cxx
+++ b/sw/source/uibase/docvw/SidebarWinAcc.cxx
@@ -25,6 +25,7 @@
#include
#include
+#include
namespace sw::sidebarwindows {
@@ -47,7 +48,7 @@ class SidebarWinAccessibleContext : public
VCLXAccessibleComponent
void ChangeAnchor( const SwFrame* pAnchorFrame )
{
-osl::MutexGuard aGuard(maMutex);
+std::scoped_lock aGuard(maMutex);
mpAnchorFrame = pAnchorFrame;
}
@@ -55,7 +56,7 @@ class SidebarWinAccessibleContext : public
VCLXAccessibleComponent
virtual css::uno::Reference< css::accessibility::XAccessible > SAL_CALL
getAccessibleParent() override
{
-osl::MutexGuard aGuard(maMutex);
+std::scoped_lock aGuard(maMutex);
css::uno::Reference< css::accessibility::XAccessible > xAccParent;
@@ -70,7 +71,7 @@ class SidebarWinAccessibleContext : public
VCLXAccessibleComponent
virtual sal_Int32 SAL_CALL getAccessibleIndexInParent() override
{
-osl::MutexGuard aGuard(maMutex);
+std::scoped_lock aGuard(maMutex);
sal_Int32 nIndex( -1 );
@@ -88,7 +89,7 @@ class SidebarWinAccessibleContext : public
VCLXAccessibleComponent
SwViewShell& mrViewShell;
const SwFrame* mpAnchorFrame;
-::osl::Mutex maMutex;
+std::mutex maMutex;
};
}
