[Libreoffice-bugs] [Bug 134441] default settings for printing notes

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=134441

ffs  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139106] Only first slide's background is updated in Windows 10 LO Draw when all slides are selected

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=139106

--- Comment #7 from mwtjunkm...@gmail.com ---
Still a problem in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136844] Undo / Control-Z does not undo slide background choice in Draw

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=136844

--- Comment #10 from mwtjunkm...@gmail.com ---
Still a problem in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139851] Windows LibreOffice Draw - Selecting various align text options leaves all options selected all the time

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=139851

--- Comment #6 from mwtjunkm...@gmail.com ---
Still a problem in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134237] Soft edge feature produces lag when scrolling (and mouse-scrolling to zoom) multiple high-resolution images in Draw

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=134237

--- Comment #26 from mwtjunkm...@gmail.com ---
Still happening in 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143760] FILESAVE DOCX user change from contour wrap to "wrap off" is not respected

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143760

Regina Henschel  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rb.hensc...@t-online.de
   |desktop.org |

--- Comment #1 from Regina Henschel  ---
I'm currently working on improving the export of wrap settings to docx. I will
fix it together with the other problems. I have reported it to have a bug
number for this error.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138468] Cell background color selection widget UI in side-bar now extra step of palette selection droplist

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=138468

--- Comment #13 from R. Bingham  ---
Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Un-installed then re-installed extensions in use with no apparent effect on
color picker. None of the extensions I use would be expected to have a color
picker palette component in any case.

Regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143760] New: FILESAVE DOCX user change from contour wrap to "wrap off" is not respected

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143760

Bug ID: 143760
   Summary: FILESAVE DOCX user change from contour wrap to "wrap
off" is not respected
   Product: LibreOffice
   Version: 7.3.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 174112
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174112=edit
File to reproduce the problem

Open attached file. It has a contour wrap on the shape in Word and shows
contour wrap in LO too.
Click the shape and change its wrap type to "wrap off".
Save the document in docx format.
Reopen.
Error: The wrap is a contour wrap as in the beginning. The new wrap type "wrap
off" has not been saved.

Reason is a wrong order in the implementation. It currently first checks for a
wrap polygon in the InteropGrabBag before evaluating the current wrap type.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139811] Sidebar Draw Properties deck -> Page -> Background 'Gradient' control needs additional height, the Insert Image dialog button is being clipped

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=139811

--- Comment #16 from mwtjunkm...@gmail.com ---
Still a problem in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139108] Windows LO Draw cuts off the controls in the properties sidebar.

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=139108

mwtjunkm...@gmail.com changed:

   What|Removed |Added

Summary|Selecting a gradient for a  |Windows LO Draw cuts off
   |background in Windows LO|the controls in the
   |Draw cuts off the controls  |properties sidebar.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139108] Selecting a gradient for a background in Windows LO Draw cuts off the controls

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=139108

--- Comment #6 from mwtjunkm...@gmail.com ---
Still a problem in 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: e642179f466c899365fc9539a8aca66b39fea39a
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

but it's not just gradient that causes it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143759] Inaccurate results when searching for empty cells with regex ^$

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143759

--- Comment #2 from stragu  ---
Created attachment 174111
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174111=edit
resulting selection after following steps to reproduce in LO 7.3 alpha0+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143759] Inaccurate results when searching for empty cells with regex ^$

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143759

--- Comment #1 from stragu  ---
Created attachment 174110
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174110=edit
sample ODS for following steps to reproduce

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 57523] EDITING No way to find and select empty cells in range

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=57523

stragu  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||3759

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102847] [META] Quick Find, Search and Replace

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=102847

stragu  changed:

   What|Removed |Added

 Depends on||143759


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143759
[Bug 143759] Inaccurate results when searching for empty cells with regex ^$
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143759] Inaccurate results when searching for empty cells with regex ^$

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143759

stragu  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=57
   ||523
 Blocks||102847


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102847
[Bug 102847] [META] Quick Find, Search and Replace
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143759] New: Inaccurate results when searching for empty cells with regex ^$

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143759

Bug ID: 143759
   Summary: Inaccurate results when searching for empty cells with
regex ^$
   Product: LibreOffice
   Version: 6.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: stephane.guil...@member.fsf.org

Description:
Searching for empty cells with a regular expression (inside a selection)
results in inaccurate results:
- empty cells that are part of the selection are not matched
- empty cells that are not part of the selection are matched

Steps to Reproduce:
1. Open attachment
2. Select range that goes beyond all cells with data, on all sides. For this
example, use the range A1:F6
3. Open Search & Replace dialog
4. Tick "Regular Expression" and "Current selection only"
5. Use the regular expression "^$" in the "Find" field (without quotes)
6. Click "Find All"

Actual Results:
In the resulting selection:
- empty cells that are part of the selection are not matched (e.g. in row 1 and
column A)
- empty cells that are not part of the selection are matched (e.g. in column D)

Expected Results:
All cells that are empty in the selected range are matched. Nothing more,
nothing less.


Reproducible: Always


User Profile Reset: No



Additional Info:
Observed in:

Version: 6.2.5.2
Build ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

and

Version: 7.0.6.2
Build ID: 00(Build:2)
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Ubuntu package version: 1:7.0.6-0ubuntu0.20.04.1_lo1
Calc: threaded

and

Version: 7.2.0.2 / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time:
2021-07-26_22:41:19
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sfx2/source

2021-08-06 Thread Mert Tumer (via logerrit) 
 sfx2/source/sidebar/SidebarController.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit b606764ce2a042f2a38c98820d7236661149d20c
Author: Mert Tumer 
AuthorDate: Fri Aug 6 12:42:16 2021 +0300
Commit: Michael Meeks 
CommitDate: Fri Aug 6 15:26:03 2021 +0200

lok: Avoid redundant call to UpdateConfigurations

We call doc_setView each time we send an event to LOK such as keystroke
and SidebarController::notifyContextChange event is triggered after that
UpdateConfigurations() call causes layout reallocating for whole sidebar
and we end up keep doing it. It takes significant amount of cpu time for
lok case for no reason.

Signed-off-by: Mert Tumer 
Change-Id: I8f456156af841fdeaba1934498863a07a7d4554e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120112
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index 266a69f5dcbe..db4f9679e34a 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -333,7 +333,8 @@ void SAL_CALL SidebarController::notifyContextChangeEvent 
(const css::ui::Contex
  // calling with held
  // solarmutex
 // TODO: this call is redundant but mandatory for unit test to update 
context on document loading
-UpdateConfigurations();
+if (!comphelper::LibreOfficeKit::isActive())
+UpdateConfigurations();
 }
 }

[Libreoffice-commits] core.git: nlpsolver/src nlpsolver/ThirdParty

2021-08-06 Thread Caolán McNamara (via logerrit) 
 
nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java 
 |   10 +++---
 
nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/behavior/AbsGTBehavior.java
 |4 
 nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java 
  |5 +++--
 3 files changed, 6 insertions(+), 13 deletions(-)

New commits:
commit 5c299f0112441ca095276376a9973cb4ff0fda02
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 12:22:43 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 15:22:37 2021 +0200

cid#1489772 UR: Uninitialized read of field in constructor

pass in SearchPoint to initialize pbest_t before it is then
passed to setMemPoints

setMemPoints sets the pbest_t variable of AbsGTBehavior so
calling setPbest on AbsGTBehavior subclasses after calling
that doesn't do anything so drop it, and then DEPSAgent.setPbest
isn't needed anymore

Change-Id: Id4fdc770cefc0f801218dc9bf51a6dc5b1e25d5a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120115
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git 
a/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java
 
b/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java
index ae718e63519b..3a08df39f5e7 100644
--- 
a/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java
+++ 
b/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/DEPSAgent.java
@@ -72,7 +72,8 @@ public class DEPSAgent {
 
   private double switchP = 0.5;
 
-  public DEPSAgent(ProblemEncoder encoder, DEGTBehavior deGTBehavior, 
PSGTBehavior psGTBehavior, double switchP, IGoodnessCompareEngine comparer) {
+  public DEPSAgent(ProblemEncoder encoder, DEGTBehavior deGTBehavior, 
PSGTBehavior psGTBehavior,
+   double switchP, IGoodnessCompareEngine comparer, 
SearchPoint pbest) {
   this.switchP = switchP;
 
   problemEncoder = encoder;
@@ -82,6 +83,7 @@ public class DEPSAgent {
   trailPoint = problemEncoder.getFreshSearchPoint();
   pold_t = problemEncoder.getFreshSearchPoint();
   pcurrent_t = problemEncoder.getFreshSearchPoint();
+  pbest_t = pbest;
 
   this.deGTBehavior = deGTBehavior;
   this.deGTBehavior.setMemPoints(pbest_t, pcurrent_t, pold_t);
@@ -94,12 +96,6 @@ public class DEPSAgent {
 qualityComparator = comparer;
   }
 
-  public void setPbest(SearchPoint pbest) {
-pbest_t = pbest;
-deGTBehavior.setPbest(pbest_t);
-psGTBehavior.setPbest(pbest_t);
-  }
-
   private AbsGTBehavior getGTBehavior() {
 if (RandomGenerator.doubleZeroOneRandom() < switchP) {
   return deGTBehavior;
diff --git 
a/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/behavior/AbsGTBehavior.java
 
b/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/behavior/AbsGTBehavior.java
index 09110581659c..2701c9dee9f0 100644
--- 
a/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/behavior/AbsGTBehavior.java
+++ 
b/nlpsolver/ThirdParty/EvolutionarySolver/src/net/adaptivebox/deps/behavior/AbsGTBehavior.java
@@ -35,10 +35,6 @@ abstract public class AbsGTBehavior implements ILibEngine {
 socialLib = lib;
   }
 
-  public void setPbest(SearchPoint pbest) {
-pbest_t = pbest;
-  }
-
   abstract public void setMemPoints(SearchPoint pbest, BasicPoint pcurrent, 
BasicPoint pold);
 
   abstract public void generateBehavior(SearchPoint trailPoint, ProblemEncoder 
problemEncoder);
diff --git a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java 
b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java
index 7a4c552d9e60..2b6c1ce36c73 100644
--- a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java
+++ b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/DEPSSolverImpl.java
@@ -141,8 +141,9 @@ public final class DEPSSolverImpl extends 
BaseEvolutionarySolver
 psGTBehavior.weight = m_weight.getValue();
 psGTBehavior.setLibrary(m_library);
 
-agents[i] = new DEPSAgent(m_problemEncoder, deGTBehavior, 
psGTBehavior, m_agentSwitchRate.getValue(), m_specCompareEngine);
-agents[i].setPbest(m_library.getSelectedPoint(i));
+agents[i] = new DEPSAgent(m_problemEncoder, deGTBehavior, 
psGTBehavior,
+  m_agentSwitchRate.getValue(), 
m_specCompareEngine,
+  m_library.getSelectedPoint(i));
 }
 
 //Learn:

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #15 from Telesto  ---
(In reply to Jan-Marek Glogowski from comment #13)
> So this should have been just a quick look and turned into some hours
> analysis with multiple problems unveiled...

Thanks for the 'quick' look (and insights). Me wondering how often logo being
truly c.q. how much engineering time should be spent on this. It's kind of a
trivial feature to me (personal opinion).

Or is there some overall benefit, bigger compared to logo (like harmonizing
system loops cross platform)

Not saying that economics theory being the only perspective.. The challenge or
fun might maybe a reason for looking into this..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/sfx2 sfx2/source

2021-08-06 Thread Vert D (via logerrit) 
 include/sfx2/templatedlg.hxx  |1 
 include/sfx2/templatelocalview.hxx|2 
 sfx2/source/control/templatelocalview.cxx |   36 -
 sfx2/source/doc/templatedlg.cxx   |   83 +++---
 4 files changed, 59 insertions(+), 63 deletions(-)

New commits:
commit 8d8450f0c14db26fb8eb44677c2887e619200904
Author: Vert D 
AuthorDate: Mon May 24 23:01:38 2021 -0500
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 15:15:20 2021 +0200

tdf#139647 refresh renamed items

*Update templates names after rename (faster than reload).
*Fix some warnings.

Change-Id: I47387af91964afae8de8753289d49d19e6080863
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119919
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/sfx2/templatedlg.hxx b/include/sfx2/templatedlg.hxx
index 588a307af139..940973f84f05 100644
--- a/include/sfx2/templatedlg.hxx
+++ b/include/sfx2/templatedlg.hxx
@@ -78,7 +78,6 @@ protected:
 DECL_LINK(ExportTemplateHdl, void*, void);
 
 void SearchUpdate();
-void FilterSearch();
 
 DECL_LINK(SearchUpdateHdl, weld::Entry&, void);
 DECL_LINK(GetFocusHdl, weld::Widget&, void);
diff --git a/include/sfx2/templatelocalview.hxx 
b/include/sfx2/templatelocalview.hxx
index fbf730af6b81..2ad81391e97d 100644
--- a/include/sfx2/templatelocalview.hxx
+++ b/include/sfx2/templatelocalview.hxx
@@ -126,6 +126,8 @@ public:
 
 sal_uInt16 getCurRegionId () const { return mnCurRegionId;}
 
+void setCurRegionId (sal_uInt16 nCurRegionId) { mnCurRegionId = 
nCurRegionId;}
+
 void setOpenRegionHdl(const Link );
 
 void setCreateContextMenuHdl(const Link );
diff --git a/sfx2/source/control/templatelocalview.cxx 
b/sfx2/source/control/templatelocalview.cxx
index 0ba60c0d758b..4d0571eeaca1 100644
--- a/sfx2/source/control/templatelocalview.cxx
+++ b/sfx2/source/control/templatelocalview.cxx
@@ -613,7 +613,41 @@ bool TemplateLocalView::renameItem(ThumbnailViewItem* 
pItem, const OUString& sNe
 nDocId = pDocItem->mnDocId;
 }
 
-return mpDocTemplates->SetName( sNewTitle, nRegionId, nDocId );
+bool bRes = mpDocTemplates->SetName( sNewTitle, nRegionId, nDocId );
+if(bRes)
+{
+for (auto & pRegion : maRegions)
+{
+if (pRegion->mnId == nRegionId + 1 )
+{
+for(auto & aTemplate : pRegion->maTemplates)
+{
+if(aTemplate.nId == nDocId + 1)
+{
+aTemplate.aName = sNewTitle;
+break;
+}
+}
+break;
+}
+}
+OUString sRegionName;
+for (auto & aTemplate : maAllTemplates)
+{
+if (aTemplate.nRegionId == nRegionId && aTemplate.nDocId == nDocId)
+{
+aTemplate.aName = sNewTitle;
+sRegionName = aTemplate.aRegionName;
+break;
+}
+}
+
+OUString sHelpText = SfxResId(STR_TEMPLATE_TOOLTIP);
+sHelpText = (sHelpText.replaceFirst("$1", 
sNewTitle)).replaceFirst("$2", sRegionName);
+pItem->setHelpText(sHelpText);
+pItem->maTitle = sNewTitle;
+}
+return bRes;
 }
 
 void TemplateLocalView::insertItems(const std::vector 
, bool isRegionSelected, bool bShowCategoryInTooltip)
diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index c4dbc7c51fff..5f5760ca6f43 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -68,9 +68,7 @@ constexpr OUStringLiteral TM_SETTING_VIEWMODE = u"ViewMode";
 #define MNI_ACTION_DEFAULT_CALC   "default calc"
 #define MNI_ACTION_DEFAULT_IMPRESS   "default impress"
 #define MNI_ACTION_DEFAULT_DRAW   "default draw"
-#define MNI_ACTION_MOVE   "move template"
 #define MNI_ACTION_IMPORT   "import template"
-#define MNI_ACTION_EXPORT   "export template"
 #define MNI_ACTION_EXTENSIONS   "extensions"
 #define MNI_ALL_APPLICATIONS 0
 #define MNI_WRITER   1
@@ -231,10 +229,8 @@ SfxTemplateManagerDlg::SfxTemplateManagerDlg(weld::Window 
*pParent)
 fillFolderComboBox();
 
 mxActionBar->set_item_visible(MNI_ACTION_EXTENSIONS, true);
-mxActionBar->set_item_visible(MNI_ACTION_EXPORT, true);
-mxActionBar->set_item_visible(MNI_ACTION_MOVE, true);
-mxActionBar->set_item_visible(MNI_ACTION_RENAME_FOLDER, true);
-mxActionBar->set_item_visible(MNI_ACTION_DELETE_FOLDER, true);
+mxActionBar->set_item_visible(MNI_ACTION_IMPORT, true);
+mxActionBar->set_item_visible(MNI_ACTION_NEW_FOLDER, true);
 
 mxOKButton->set_label(SfxResId(STR_OPEN));
 
@@ -493,18 +489,16 @@ IMPL_LINK_NOARG(SfxTemplateManagerDlg, SelectRegionHdl, 
weld::ComboBox&, void)
 
 if(mxCBFolder->get_active() == 0)
 {
-mxLocalView->showAllTemplates();
 mxActionBar->set_item_sensitive(MNI_ACTION_RENAME_FOLDER, false);

[Libreoffice-bugs] [Bug 135846] Images disappearing of page (or becoming transparent) after moving image

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=135846

Gabor Kelemen  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=91
   ||260
 CC||kelem...@ubuntu.com,
   ||michael.st...@allotropia.de
   Keywords|bibisectRequest |bibisected, bisected

--- Comment #6 from Gabor Kelemen  ---
Bibisected on Linux-5.4 to:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=689cead9e0837dc932e3a4cd765f7d319b529018

author  Michael Stahl2016-12-06 22:59:40 +0100
committer   Michael Stahl2016-12-07 14:46:07
+0100

tdf#91260 svx, sw: don't paint off-page part of drawing object

Adding CC to: Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91260] DOCX frames can extend beyond the page bottom, but not in Writer

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=91260

Gabor Kelemen  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||5846

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131025] Writer document with tables lost data in cells (apparently) replacing with 0

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=131025

--- Comment #47 from Geoff  ---
I encountered the lost data in cells bug on a Windows 10 machine. Wordpad,
provided with earlier versions of Windows, is still available in Windows 10.

I opened the file in Wordpad, which displayed a message "Wordpad does not
support all the features of this document's format. Some content might be
missing or displayed improperly." It worked in my case. I then saved the file
to a new name as open document text, opened the new file in LibreOffice Writer,
saved it then reopened it.  It seems to have recovered.  In technical terms I
would not like to say what is going on.

LibreOffice Version: 7.0.6.2 (x64)
Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: CL

For systems other than Windows, there may be an alternative to Wordpad that can
provide recovery. Otherwise the file could be transferred to a Windows 10
machine and hopefully recovered there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 134802] [ENHANCEMENT] Proposal of a new "Paste Special" dialog box

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=134802

--- Comment #16 from stragu  ---
Added to 7.2 release notes:

https://wiki.documentfoundation.org/index.php?title=ReleaseNotes/7.2=376048=375916

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #14 from Jan-Marek Glogowski  ---
std:: should have been std::function.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105575] Slow rendering when using a Logo command

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=105575

--- Comment #13 from Jan-Marek Glogowski  ---
So this should have been just a quick look and turned into some hours analysis
with multiple problems unveiled...

Just for the "fun" of it, I did throw the example into callgrind. In my
symbol+assert build, I found that the primary problem is dynamic_cast's strcmp
from the assert in "SwContact* GetUserCall(const SdrObject* pObj)". Commenting
that, and running callgrind again, I found dynamic_cast still to be a problem,
but much less ;-) Now 10% of the time is spend in
__gnu_cxx::__normal_iterator...

SwObjectFormatter::FormatObjsAtFrame_
SwSortedObjs::ListPosOf
__gnu_cxx::__normal_iterator

That's one reason why the progress gets slower. The LO code iterates over the
graphics objects vector to find the matching SwAnchoredObject. Normally that
code is no problem, since we don't have 400 draw objects and "everytime" add a
new one causing a relayout with several of these lookup.

And the display was never refreshed in callrind, until LibreLogo was finished.

But back to the original problem:

!! 1. Make sure the document language is English !!

I had my master build with en UI, but German system, resulting in an error
message about braces and whitespace. I originally didn't even realize the error
message was German; took me, while trying to fix the logo program ;-)

master kf5 (symbols + asserts, no debug): ~40s
5.0.6.2 gtk2 (from git releases; I like that repo): ~120s to finish with
several "hiccups", i.e. the turtle speed differed (different from the general
slowdown already described above)
master gtk3: ~150s
master gen: ~4s (really; just does a single paint refresh, and I guess no
intermediate layouts; not yet analyzed...)

FWIW the "svx::SdrPaintView aComeBackIdle" has TaskPriority::REPAINT, but it
probably should be TaskPriority::RESIZE AKA just above repaint (and maybe
RESIZE should be rename PREPAINT, and REPAINT just PAINT...). It feels a bit
faster, but with kf5 at 40s + manual timing...

There are two main difference between Qt and the other system loops:
1. Qt can't process single events. You can just decide between "process all
events" and "wait for events and then process all". And it has a bit different
painting semantics, so a refresh most times get queued in the system event
loop. I'm for that approach generally...
2. gtk and win process LO events via system loop. All other process them always
before system events. That is nothing new, but it might interfere here and they
should probably get converted to the general processing via SalUserEventList
(don't ask me why it's called UserEvent...; I just introduced SalUserEventList,
not SalUserEvent).

This needs much more work; maybe we should just switch to GMainLoop, but that
would be a mayor change for all backends again...) and we have the UI in main
problem, bust that might be solvable generally with std::

And then there is the headless locking problem with UI tests too, where we
don't want to run the main loop via yield "out of order", with non-releasing
SolarMutex m_bNoYieldLock hack.

And nothing obvious and quick to fix this. I guess at least a month to convert
all VCL backends after finishing headless (which should work; it has some focus
handling problem, which are hacked around by ignoring visibility...).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/source

2021-08-06 Thread Mike Kaganski (via logerrit) 
 oox/source/drawingml/shape.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b791974837a99ead793b4ead6760b2f4e5237de2
Author: Mike Kaganski 
AuthorDate: Fri Aug 6 11:35:49 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri Aug 6 14:14:20 2021 +0200

Move ActionLockGuard up a bit

Change-Id: Iaa1f3a5e2b9ad0605c53efa6a17d467159597927
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119991
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index b0e2ddef30e7..64878fc772f4 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -978,6 +978,8 @@ Reference< XShape > const & Shape::createAndInsert(
 Reference< XPropertySet > xSet( mxShape, UNO_QUERY );
 if (xSet.is())
 {
+ActionLockGuard const alg(mxShape);
+
 if( !msName.isEmpty() )
 {
 Reference< container::XNamed > xNamed( mxShape, UNO_QUERY );
@@ -1005,8 +1007,6 @@ Reference< XShape > const & Shape::createAndInsert(
 xSet->setPropertyValue("SizeProtect", Any(true));
 }
 
-ActionLockGuard const alg(mxShape);
-
 // sj: removing default text of placeholder objects such as 
SlideNumberShape or HeaderShape
 if ( bClearText )
 {

[Libreoffice-bugs] [Bug 143268] Slow response in document with many tables

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143268

--- Comment #22 from Buovjaga  ---
(In reply to David from comment #21)
> According to what I understand from the instructions, LibreOffice needs to
> be built using -debug-symbols but that it shouldn't be the debug build.  Is
> there a pre-compiled version of such a build that can be downloaded and used
> for testing?

Unfortunately not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143268] Slow response in document with many tables

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143268

--- Comment #21 from David  ---
According to what I understand from the instructions, LibreOffice needs to be
built using -debug-symbols but that it shouldn't be the debug build.  Is there
a pre-compiled version of such a build that can be downloaded and used for
testing?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: setup_native/Package_packinfo.mk

2021-08-06 Thread Stephan Bergmann (via logerrit) 
 setup_native/Package_packinfo.mk |   11 +--
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 6c487d2d7e8aa5cdef55cbd7bc78058184671d82
Author: Stephan Bergmann 
AuthorDate: Fri Aug 6 09:17:37 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Aug 6 13:18:25 2021 +0200

Fix and simplify "any bundled extensions installed" check

First, Extension_nlpsolver is not unconditionally covered by --with-java, 
but by
a dedicated --enable-ext-nlpsolver (which requires --with-java).  (I had
overlooked that the whole Module_nlpsolver is conditional in
RepositoryModule_host.mk.)  So the check for Extension_nlpsolver should 
instead
check for NLPSOLVER in BUILD_TYPE.

Second, the check for --enable-ext-numbertext could check for NUMBERTEXT in
BUILD_TYPE instead of checking for NUMBERTEXT_EXTENSION_PACK, as
--enable-ext-numbertext sets both (cf. m4/libo_check_extension.m4).

And third, any --enable-ext-* will set WITH_EXTRA_EXTENSIONS (cf.
m4/libo_check_extension.m4), so all those various BUILD_TYPE checks can all 
be
subsumed by a single WITH_EXTRA_EXTENSIONS check.  (Which nicely reduces the
maintenance burden mentioned in the commit message of
f267340d300da6318435ed1b2ae48b9f4275e2c4 "Remove unused
$(LIBO_SHARE_FOLDER)/extensions/package.txt.")

Change-Id: Ifdf8b59febd49661500292ab2003c792d8cb60a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120104
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/setup_native/Package_packinfo.mk b/setup_native/Package_packinfo.mk
index b2064c46c36b..d958a2631d18 100644
--- a/setup_native/Package_packinfo.mk
+++ b/setup_native/Package_packinfo.mk
@@ -9,12 +9,11 @@
 
 $(eval $(call gb_Package_Package,setup_native_packinfo,$(SRCDIR)))
 
-# Check if any bundled extensions are installed (where ENABLE_JAVA covers 
Extension_nlpsolver, cf.
-# nlpsolver/Module_nlpsolver.mk); if none are installed, then 
gb_Package_add_empty_directory is
-# needed to create the empty extensions directory (but if any are installed, 
then
-# gb_Package_add_empty_directory would cause errors during 
CustomTarget_instsetoo_native/install, as
-# the directory is not empty in that case):
-ifeq ($(filter CT2N DICTIONARIES 
LANGUAGETOOL,$(BUILD_TYPE))$(ENABLE_MEDIAWIKI)$(NUMBERTEXT_EXTENSION_PACK)$(ENABLE_JAVA),)
+# Check if any bundled extensions are installed; if none are installed, then
+# gb_Package_add_empty_directory is needed to create the empty extensions 
directory (but if any are
+# installed, then gb_Package_add_empty_directory would cause errors during
+# CustomTarget_instsetoo_native/install, as the directory is not empty in that 
case):
+ifeq ($(filter 
DICTIONARIES,$(BUILD_TYPE))$(WITH_EXTRA_EXTENSIONS)$(ENABLE_MEDIAWIKI),)
 $(eval $(call 
gb_Package_add_empty_directory,setup_native_packinfo,$(LIBO_SHARE_FOLDER)/extensions))
 endif

[Libreoffice-bugs] [Bug 143268] Slow response in document with many tables

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143268

--- Comment #20 from Buovjaga  ---
(In reply to David from comment #19)
> The issue with the headings has been fixed (bug 143499).  Would a similar
> fix resolve the issue for this bug?

I think this might benefit from profiling data using a build with symbols:
https://wiki.documentfoundation.org/Development/How_to_debug#Performance_debugging_.28perf.29

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143268] Slow response in document with many tables

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143268

--- Comment #19 from David  ---
The issue with the headings has been fixed (bug 143499).  Would a similar fix
resolve the issue for this bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141793] Insert of 3 images via smb share in writer crashes the desktop environment

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=141793

Denys Prokhorov  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Denys Prokhorov  ---
Describe in detail all the steps starting with the installation of the virtual
machine.

The network problems around LO are the most difficult to reproduce and require
accurate data.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: distro-configs/LibreOfficeOssFuzz.conf

2021-08-06 Thread Caolán McNamara (via logerrit) 
 distro-configs/LibreOfficeOssFuzz.conf |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit 5ba792bdda1db0561d6bdbb5deea37a1954cf257
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 11:42:17 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 13:01:09 2021 +0200

oss-fuzz: disable some more features we don't need

trying to squeek this build under the unknown upstream TIMEOUT

Change-Id: I77e65f2124ae09ff11209c2631437f3b77013290
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120114
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/distro-configs/LibreOfficeOssFuzz.conf 
b/distro-configs/LibreOfficeOssFuzz.conf
index 70e4db8e4b23..8b7039786584 100644
--- a/distro-configs/LibreOfficeOssFuzz.conf
+++ b/distro-configs/LibreOfficeOssFuzz.conf
@@ -1,11 +1,12 @@
 --enable-fuzzers
+--enable-ld=gold
 --disable-dynamic-loading
---with-locales=en
 --disable-runtime-optimizations
 --disable-database-connectivity
 --disable-gui
 --disable-gtk3
 --disable-pdfium
+--disable-pdfimport
 --disable-skia
 --disable-postgresql-sdbc
 --disable-firebird-sdbc
@@ -16,7 +17,9 @@
 --disable-dbus
 --disable-cups
 --disable-odk
+--disable-sdremote
 --disable-xmlhelp
 --disable-zxing
+--without-fonts
 --without-java
---enable-ld=gold
+--with-locales=en

[Libreoffice-commits] core.git: formula/source

2021-08-06 Thread Caolán McNamara (via logerrit) 
 formula/source/core/api/FormulaCompiler.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 105b3756d88944172d241be316a2207028f2cf20
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 09:11:55 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 12:49:39 2021 +0200

cid#1489780 Explicit null dereferenced

Change-Id: Ia6e34b48cdcc4b011c46c576269cdeffab4821ef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120100
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/formula/source/core/api/FormulaCompiler.cxx 
b/formula/source/core/api/FormulaCompiler.cxx
index 39a62ebdc1e4..af9d19f68191 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -281,7 +281,7 @@ void OpCodeList::putDefaultOpCode( const 
FormulaCompiler::NonConstOpCodeMapPtr&
 return;
 sKey = OUString::createFromAscii(pKey);
 }
-else
+else if (mpSymbols2)
 {
 TranslateId pKey;
 for (const std::pair* pSymbol = mpSymbols2; 
pSymbol->first; ++pSymbol)

[Libreoffice-bugs] [Bug 143758] New: Content of listbox in table control will disappear when listbox is refreshed by macro.

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143758

Bug ID: 143758
   Summary: Content of listbox in table control will disappear
when listbox is refreshed by macro.
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Created attachment 174109
  --> https://bugs.documentfoundation.org/attachment.cgi?id=174109=edit
Database with form to test the described behavior

Don't know if this is a bug for Base or Basic or UI. 

Open the attached database.
Allow executing macros.
Open the form.
There is a table control with a list box for "Position". This list box will be
refreshed every time the row has been changed. (There shouldn't a "Position" be
available for a "Thing", which is used by another "Thing".)
Click in first row on "Position".
Click in second row on "Postion".
"Position" in first row will disappear.
Click in third row on "Position".
"Position" in second row won't disappear, because the whole content of the
table control has been moved above while refreshing the list box.
Now move by scrollbar to the see first and second row. 
No "Position" would be shown for first row and second row …

Tested with
Version: 7.2.0.2 / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threadedTest for this bug 

on OpenSUSE 15.2 64bit rpm Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143757] New: Unfilled circle appears filled

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143757

Bug ID: 143757
   Summary: Unfilled circle appears filled
   Product: LibreOffice
   Version: 6.4.7.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: marco.wis...@gmail.com

Description:
When I draw a circle using the 'unfilled circle' tool, I get a blue disc.

Steps to Reproduce:
1.Select the 'unfilled circle' tool and draw a circle.
2.
3.

Actual Results:
A blue disc appears.

Expected Results:
A transparent circle should have appeared.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.1
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cppu/source

2021-08-06 Thread Caolán McNamara (via logerrit) 
 cppu/source/threadpool/current.cxx |   39 +
 cppu/source/threadpool/current.hxx |2 -
 cppu/source/threadpool/threadident.cxx |   61 +++--
 3 files changed, 47 insertions(+), 55 deletions(-)

New commits:
commit 413b80ed1a9d29f394d0746106f5698e65fe23dc
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 09:59:52 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 12:14:58 2021 +0200

return a reference instead of a pointer

and remove redundant nullptr OSL_ENSURE check

Change-Id: I19e202c3786386ed6f094504a0e1eb6928aa423a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cppu/source/threadpool/current.cxx 
b/cppu/source/threadpool/current.cxx
index e163a20be2ec..6a992c6af541 100644
--- a/cppu/source/threadpool/current.cxx
+++ b/cppu/source/threadpool/current.cxx
@@ -106,33 +106,31 @@ IdContainer::~IdContainer()
 }
 }
 
-IdContainer * getIdContainer()
+IdContainer& getIdContainer()
 {
 static thread_local IdContainer aId;
-return 
+return aId;
 }
 
 }
 
-
 extern "C" sal_Bool SAL_CALL uno_setCurrentContext(
 void * pCurrentContext,
 rtl_uString * pEnvTypeName, void * pEnvContext )
 SAL_THROW_EXTERN_C()
 {
-IdContainer * pId = getIdContainer();
-OSL_ASSERT( pId );
+IdContainer& id = getIdContainer();
 
 // free old one
-if (pId->pCurrentContext)
+if (id.pCurrentContext)
 {
-(*pId->pCurrentContextEnv->releaseInterface)(
-pId->pCurrentContextEnv, pId->pCurrentContext );
-(*pId->pCurrentContextEnv->aBase.release)(
->pCurrentContextEnv->aBase );
-pId->pCurrentContextEnv = nullptr;
+(*id.pCurrentContextEnv->releaseInterface)(
+id.pCurrentContextEnv, id.pCurrentContext );
+(*id.pCurrentContextEnv->aBase.release)(
+>aBase );
+id.pCurrentContextEnv = nullptr;
 
-pId->pCurrentContext = nullptr;
+id.pCurrentContext = nullptr;
 }
 
 if (pCurrentContext)
@@ -144,10 +142,10 @@ extern "C" sal_Bool SAL_CALL uno_setCurrentContext(
 {
 if (pEnv->pExtEnv)
 {
-pId->pCurrentContextEnv = pEnv->pExtEnv;
-(*pId->pCurrentContextEnv->acquireInterface)(
-pId->pCurrentContextEnv, pCurrentContext );
-pId->pCurrentContext = pCurrentContext;
+id.pCurrentContextEnv = pEnv->pExtEnv;
+(*id.pCurrentContextEnv->acquireInterface)(
+id.pCurrentContextEnv, pCurrentContext );
+id.pCurrentContext = pCurrentContext;
 }
 else
 {
@@ -167,8 +165,7 @@ extern "C" sal_Bool SAL_CALL uno_getCurrentContext(
 void ** ppCurrentContext, rtl_uString * pEnvTypeName, void * pEnvContext )
 SAL_THROW_EXTERN_C()
 {
-IdContainer * pId = getIdContainer();
-OSL_ASSERT( pId );
+IdContainer& id = getIdContainer();
 
 Environment target_env;
 
@@ -189,7 +186,7 @@ extern "C" sal_Bool SAL_CALL uno_getCurrentContext(
 }
 
 // case: null-ref
-if (nullptr == pId->pCurrentContext)
+if (nullptr == id.pCurrentContext)
 return true;
 
 if (! target_env.is())
@@ -200,12 +197,12 @@ extern "C" sal_Bool SAL_CALL uno_getCurrentContext(
 return false;
 }
 
-Mapping mapping(>pCurrentContextEnv->aBase, target_env.get());
+Mapping mapping(>aBase, target_env.get());
 OSL_ASSERT( mapping.is() );
 if (! mapping.is())
 return false;
 
-mapping.mapInterface(ppCurrentContext, pId->pCurrentContext, 
::cppu::get_type_XCurrentContext() );
+mapping.mapInterface(ppCurrentContext, id.pCurrentContext, 
::cppu::get_type_XCurrentContext());
 
 return true;
 }
diff --git a/cppu/source/threadpool/current.hxx 
b/cppu/source/threadpool/current.hxx
index 8ab4e3acf43a..cb0094413d66 100644
--- a/cppu/source/threadpool/current.hxx
+++ b/cppu/source/threadpool/current.hxx
@@ -41,7 +41,7 @@ struct IdContainer
 ~IdContainer();
 };
 
-IdContainer * getIdContainer();
+IdContainer& getIdContainer();
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cppu/source/threadpool/threadident.cxx 
b/cppu/source/threadpool/threadident.cxx
index 544acc7af520..16b7c0b2700a 100644
--- a/cppu/source/threadpool/threadident.cxx
+++ b/cppu/source/threadpool/threadident.cxx
@@ -27,12 +27,10 @@
 
 #include "current.hxx"
 
-
 using namespace ::std;
 using namespace ::osl;
 using namespace ::cppu;
 
-
 static void createLocalId( sal_Sequence **ppThreadId )
 {
 rtl_byte_sequence_constructNoDefault( ppThreadId , 4 + 16 );
@@ -44,74 +42,71 @@ static void createLocalId( sal_Sequence **ppThreadId )
 rtl_getGlobalProcessId( reinterpret_cast(&(*ppThreadId)->elements[4]) );
 }
 
-
 extern "C" void SAL_CALL
 uno_getIdOfCurrentThread( sal_Sequence **ppThreadId )

[Libreoffice-commits] core.git: vcl/source

2021-08-06 Thread Caolán McNamara (via logerrit) 
 vcl/source/filter/svm/SvmReader.cxx |   12 
 1 file changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 6189a79cd3a589a403415d288389780167133797
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 09:45:51 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 11:54:59 2021 +0200

elide some ctors

Change-Id: I1cf5260ec57442e7c82b92db89227c08c943f689
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120103
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/filter/svm/SvmReader.cxx 
b/vcl/source/filter/svm/SvmReader.cxx
index 311a43fc8f50..ca1ab891cedf 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -647,8 +647,7 @@ rtl::Reference 
SvmReader::TextHandler(ImplMetaReadData* pData)
 
 Point aPoint;
 aSerializer.readPoint(aPoint);
-OUString aStr;
-aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
+OUString aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
 sal_uInt16 nTmpIndex(0);
 mrStream.ReadUInt16(nTmpIndex);
 sal_uInt16 nTmpLen(0);
@@ -692,8 +691,7 @@ rtl::Reference 
SvmReader::TextArrayHandler(ImplMetaReadData* pData)
 aSerializer.readPoint(aPoint);
 pAction->SetPoint(aPoint);
 
-OUString aStr;
-aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
+OUString aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
 pAction->SetText(aStr);
 
 sal_uInt16 nTmpIndex(0);
@@ -769,8 +767,7 @@ rtl::Reference 
SvmReader::StretchTextHandler(ImplMetaReadData* pData
 
 Point aPoint;
 aSerializer.readPoint(aPoint);
-OUString aStr;
-aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
+OUString aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
 sal_uInt32 nTmpWidth;
 mrStream.ReadUInt32(nTmpWidth);
 sal_uInt16 nTmpIndex(0);
@@ -800,8 +797,7 @@ rtl::Reference 
SvmReader::TextRectHandler(ImplMetaReadData* pData)
 
 tools::Rectangle aRect;
 aSerializer.readRectangle(aRect);
-OUString aStr;
-aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
+OUString aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
 sal_uInt16 nTmp(0);
 mrStream.ReadUInt16(nTmp);

[Libreoffice-commits] core.git: vcl/source

2021-08-06 Thread Caolán McNamara (via logerrit) 
 vcl/source/filter/svm/SvmReader.cxx |   38 
 1 file changed, 22 insertions(+), 16 deletions(-)

New commits:
commit fb41deb8b86a48d9dbfbd2e65ee342e39a94f4d9
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 09:24:06 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 11:54:43 2021 +0200

cid#1487034 Untrusted value as argument

Change-Id: I7f50e8b1676d36a3675657d160c10196c08c26d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120102
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/filter/svm/SvmReader.cxx 
b/vcl/source/filter/svm/SvmReader.cxx
index bee25f2f1e43..311a43fc8f50 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -655,19 +655,25 @@ rtl::Reference 
SvmReader::TextHandler(ImplMetaReadData* pData)
 mrStream.ReadUInt16(nTmpLen);
 
 pAction->SetPoint(aPoint);
-pAction->SetIndex(nTmpIndex);
-pAction->SetLen(nTmpLen);
 
 if (aCompat.GetVersion() >= 2) // Version 2
 aStr = read_uInt16_lenPrefixed_uInt16s_ToOUString(mrStream);
 
-if (nTmpIndex + nTmpLen > aStr.getLength())
+if (nTmpIndex > aStr.getLength())
 {
-SAL_WARN("vcl.gdi", "inconsistent offset and len");
-pAction->SetIndex(0);
-pAction->SetLen(aStr.getLength());
+SAL_WARN("vcl.gdi", "inconsistent offset");
+nTmpIndex = aStr.getLength();
 }
 
+if (nTmpLen > aStr.getLength() - nTmpIndex)
+{
+SAL_WARN("vcl.gdi", "inconsistent len");
+nTmpLen = aStr.getLength() - nTmpIndex;
+}
+
+pAction->SetIndex(nTmpIndex);
+pAction->SetLen(nTmpLen);
+
 pAction->SetText(aStr);
 
 return pAction;
@@ -692,16 +698,14 @@ rtl::Reference 
SvmReader::TextArrayHandler(ImplMetaReadData* pData)
 
 sal_uInt16 nTmpIndex(0);
 mrStream.ReadUInt16(nTmpIndex);
-pAction->SetIndex(nTmpIndex);
 
 sal_uInt16 nTmpLen(0);
 mrStream.ReadUInt16(nTmpLen);
-pAction->SetLen(nTmpLen);
 
 sal_Int32 nAryLen(0);
 mrStream.ReadInt32(nAryLen);
 
-if (nTmpIndex + nTmpLen > aStr.getLength())
+if (nTmpLen > aStr.getLength() - nTmpIndex)
 {
 SAL_WARN("vcl.gdi", "inconsistent offset and len");
 pAction->SetIndex(0);
@@ -709,6 +713,9 @@ rtl::Reference 
SvmReader::TextArrayHandler(ImplMetaReadData* pData)
 return pAction;
 }
 
+pAction->SetIndex(nTmpIndex);
+pAction->SetLen(nTmpLen);
+
 if (nAryLen)
 {
 // #i9762#, #106172# Ensure that DX array is at least mnLen entries 
long
@@ -740,7 +747,7 @@ rtl::Reference 
SvmReader::TextArrayHandler(ImplMetaReadData* pData)
 aStr = read_uInt16_lenPrefixed_uInt16s_ToOUString(mrStream);
 pAction->SetText(aStr);
 
-if (nTmpIndex + nTmpLen > aStr.getLength())
+if (nTmpLen > aStr.getLength() - nTmpIndex)
 {
 SAL_WARN("vcl.gdi", "inconsistent offset and len");
 pAction->SetIndex(0);
@@ -795,7 +802,7 @@ rtl::Reference 
SvmReader::TextRectHandler(ImplMetaReadData* pData)
 aSerializer.readRectangle(aRect);
 OUString aStr;
 aStr = mrStream.ReadUniOrByteString(pData->meActualCharSet);
-sal_uInt16 nTmp;
+sal_uInt16 nTmp(0);
 mrStream.ReadUInt16(nTmp);
 
 pAction->SetRect(aRect);
@@ -1219,9 +1226,8 @@ rtl::Reference SvmReader::TextAlignHandler()
 {
 rtl::Reference pAction(new MetaTextAlignAction);
 
-sal_uInt16 nTmp16(0);
-
 VersionCompatRead aCompat(mrStream);
+sal_uInt16 nTmp16(0);
 mrStream.ReadUInt16(nTmp16);
 
 pAction->SetTextAlign(static_cast(nTmp16));
@@ -1264,10 +1270,10 @@ rtl::Reference SvmReader::PushHandler()
 rtl::Reference pAction(new MetaPushAction);
 
 VersionCompatRead aCompat(mrStream);
-sal_uInt16 tmp;
-mrStream.ReadUInt16(tmp);
+sal_uInt16 nTmp(0);
+mrStream.ReadUInt16(nTmp);
 
-pAction->SetPushFlags(static_cast(tmp));
+pAction->SetPushFlags(static_cast(nTmp));
 
 return pAction;
 }

[Libreoffice-bugs] [Bug 143497] SLIDESHOW: Much slower going to previous slide than to next slide

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143497

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||79045_79...@mail.ru
 Ever confirmed|0   |1

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
Please attach your presentation here, we can't repro it without example

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140418] Sheet-tab drag destination guide triangles repainting broken

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=140418

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140418] Sheet-tab drag destination guide triangles repainting broken

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=140418

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

  Component|Calc|graphics stack
 CC||79045_79...@mail.ru
 Whiteboard| QA:needsComment|
 OS|Linux (All) |All

--- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> ---
confirm in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ac80ec817eb07c77a51bc0729985a473c734182e
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

2021-08-06 Thread Caolán McNamara (via logerrit) 
 vcl/source/filter/svm/SvmReader.cxx |  110 +---
 1 file changed, 54 insertions(+), 56 deletions(-)

New commits:
commit 1ee8da1d118fcb12752ba10e4bc58737fddeac64
Author: Caolán McNamara 
AuthorDate: Tue Aug 3 09:44:05 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 11:29:52 2021 +0200

cid#1487034 use rtl::Reference from the start

Change-Id: I8db3aa83f02941bc630203383b2e05d3b6471e8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120101
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/filter/svm/SvmReader.cxx 
b/vcl/source/filter/svm/SvmReader.cxx
index d63e5878411c..bee25f2f1e43 100644
--- a/vcl/source/filter/svm/SvmReader.cxx
+++ b/vcl/source/filter/svm/SvmReader.cxx
@@ -339,7 +339,7 @@ void SvmReader::ReadColor(Color& rColor)
 
 rtl::Reference SvmReader::LineColorHandler()
 {
-auto pAction = new MetaLineColorAction();
+rtl::Reference pAction(new MetaLineColorAction);
 
 VersionCompatRead aCompat(mrStream);
 Color aColor;
@@ -355,7 +355,7 @@ rtl::Reference SvmReader::LineColorHandler()
 
 rtl::Reference SvmReader::FillColorHandler()
 {
-auto pAction = new MetaFillColorAction();
+rtl::Reference pAction(new MetaFillColorAction);
 
 VersionCompatRead aCompat(mrStream);
 
@@ -372,7 +372,7 @@ rtl::Reference SvmReader::FillColorHandler()
 
 rtl::Reference SvmReader::RectHandler()
 {
-auto pAction = new MetaRectAction();
+rtl::Reference pAction(new MetaRectAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -386,7 +386,7 @@ rtl::Reference SvmReader::RectHandler()
 
 rtl::Reference SvmReader::PointHandler()
 {
-auto pAction = new MetaPointAction();
+rtl::Reference pAction(new MetaPointAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -400,7 +400,7 @@ rtl::Reference SvmReader::PointHandler()
 
 rtl::Reference SvmReader::PixelHandler()
 {
-auto pAction = new MetaPixelAction();
+rtl::Reference pAction(new MetaPixelAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -418,7 +418,7 @@ rtl::Reference SvmReader::PixelHandler()
 
 rtl::Reference SvmReader::LineHandler()
 {
-auto pAction = new MetaLineAction();
+rtl::Reference pAction(new MetaLineAction);
 
 VersionCompatRead aCompat(mrStream);
 
@@ -445,7 +445,7 @@ rtl::Reference SvmReader::LineHandler()
 
 rtl::Reference SvmReader::RoundRectHandler()
 {
-auto pAction = new MetaRoundRectAction();
+rtl::Reference pAction(new MetaRoundRectAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -465,7 +465,7 @@ rtl::Reference SvmReader::RoundRectHandler()
 
 rtl::Reference SvmReader::EllipseHandler()
 {
-auto pAction = new MetaEllipseAction();
+rtl::Reference pAction(new MetaEllipseAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -480,7 +480,7 @@ rtl::Reference SvmReader::EllipseHandler()
 
 rtl::Reference SvmReader::ArcHandler()
 {
-auto pAction = new MetaArcAction();
+rtl::Reference pAction(new MetaArcAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -501,7 +501,7 @@ rtl::Reference SvmReader::ArcHandler()
 
 rtl::Reference SvmReader::PieHandler()
 {
-auto pAction = new MetaPieAction();
+rtl::Reference pAction(new MetaPieAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -522,7 +522,7 @@ rtl::Reference SvmReader::PieHandler()
 
 rtl::Reference SvmReader::ChordHandler()
 {
-auto pAction = new MetaChordAction();
+rtl::Reference pAction(new MetaChordAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer aSerializer(mrStream);
@@ -543,7 +543,7 @@ rtl::Reference SvmReader::ChordHandler()
 
 rtl::Reference SvmReader::PolyLineHandler()
 {
-auto pAction = new MetaPolyLineAction();
+rtl::Reference pAction(new MetaPolyLineAction);
 
 VersionCompatRead aCompat(mrStream);
 
@@ -572,7 +572,7 @@ rtl::Reference SvmReader::PolyLineHandler()
 
 rtl::Reference SvmReader::PolygonHandler()
 {
-auto pAction = new MetaPolygonAction();
+rtl::Reference pAction(new MetaPolygonAction);
 
 VersionCompatRead aCompat(mrStream);
 
@@ -594,7 +594,7 @@ rtl::Reference SvmReader::PolygonHandler()
 
 rtl::Reference SvmReader::PolyPolygonHandler()
 {
-auto pAction = new MetaPolyPolygonAction();
+rtl::Reference pAction(new MetaPolyPolygonAction);
 
 VersionCompatRead aCompat(mrStream);
 tools::PolyPolygon aPolyPolygon;
@@ -640,7 +640,7 @@ rtl::Reference SvmReader::PolyPolygonHandler()
 
 rtl::Reference SvmReader::TextHandler(ImplMetaReadData* pData)
 {
-auto pAction = new MetaTextAction();
+rtl::Reference pAction(new MetaTextAction);
 
 VersionCompatRead aCompat(mrStream);
 TypeSerializer

[Libreoffice-bugs] [Bug 134441] default settings for printing notes

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=134441

--- Comment #3 from ffs  ---
Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.1
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: kf5; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/CppunitTest_sw_core_edit.mk sw/qa

2021-08-06 Thread Miklos Vajna (via logerrit) 
 sw/CppunitTest_sw_core_edit.mk |2 +-
 sw/qa/core/edit/edit.cxx   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 068be2699e992a571f8851e7db6362dee8746ee3
Author: Miklos Vajna 
AuthorDate: Fri Aug 6 09:32:18 2021 +0200
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:57:21 2021 +0200

sw: fix footer for new file

And a tab in makefile where surrounding code uses spaces.

Addresses

.

Change-Id: I4a4e5fd5c989cbce5fa0602484eb6bba21c19851
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120096
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/CppunitTest_sw_core_edit.mk b/sw/CppunitTest_sw_core_edit.mk
index 21afd9ec538f..b364e9813e35 100644
--- a/sw/CppunitTest_sw_core_edit.mk
+++ b/sw/CppunitTest_sw_core_edit.mk
@@ -26,7 +26,7 @@ $(eval $(call gb_CppunitTest_use_libraries,sw_core_edit, \
 sfx \
 svxcore \
 sw \
-   swqahelper \
+swqahelper \
 test \
 unotest \
 utl \
diff --git a/sw/qa/core/edit/edit.cxx b/sw/qa/core/edit/edit.cxx
index f049c5b4751d..9f0b3d4dd62b 100644
--- a/sw/qa/core/edit/edit.cxx
+++ b/sw/qa/core/edit/edit.cxx
@@ -40,4 +40,4 @@ CPPUNIT_TEST_FIXTURE(Test, testRedlineHidden)
 
 CPPUNIT_PLUGIN_IMPLEMENT();
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */

[Libreoffice-commits] core.git: basctl/source basic/source include/vcl sc/source sd/qa svx/source sw/source vcl/source vcl/unx

2021-08-06 Thread Caolán McNamara (via logerrit) 
 basctl/source/basicide/IDEComboBox.cxx |   16 +++
 basctl/source/basicide/basides1.cxx|2 -
 basctl/source/basicide/basobj3.cxx |6 ++--
 basic/source/runtime/inputbox.cxx  |3 --
 basic/source/runtime/iosys.cxx |6 +---
 basic/source/runtime/methods.cxx   |3 --
 include/vcl/svapp.hxx  |   14 ++---
 include/vcl/toolkit/dialog.hxx |2 +
 sc/source/ui/docshell/docsh.cxx|3 --
 sd/qa/unit/dialogs-test.cxx|   36 -
 svx/source/dialog/SafeModeUI.cxx   |3 --
 sw/source/ui/dbui/mmresultdialogs.cxx  |3 --
 vcl/source/app/svapp.cxx   |8 -
 vcl/source/window/dialog.cxx   |2 -
 vcl/unx/generic/print/genprnpsp.cxx|3 --
 vcl/unx/generic/printer/cupsmgr.cxx|6 +---
 vcl/unx/gtk3/gtkinst.cxx   |7 +++-
 vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx |   17 ---
 18 files changed, 68 insertions(+), 72 deletions(-)

New commits:
commit 1aee8678c83c637a2d5c1e0a716528b0bcf11de0
Author: Caolán McNamara 
AuthorDate: Thu Aug 5 19:46:35 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 10:55:18 2021 +0200

drop intermediate vcl::Window from Application::GetDefDialogParent

Change-Id: I96be984cbefeb8e45bf49de4c50a225a46fbefb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120089
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/basctl/source/basicide/IDEComboBox.cxx 
b/basctl/source/basicide/IDEComboBox.cxx
index 87a45e5a9c22..e295e44ff1ed 100644
--- a/basctl/source/basicide/IDEComboBox.cxx
+++ b/basctl/source/basicide/IDEComboBox.cxx
@@ -194,14 +194,20 @@ void LibBox::ReleaseFocus()
 SfxViewShell* pCurSh = SfxViewShell::Current();
 DBG_ASSERT(pCurSh, "Current ViewShell not found!");
 
-if (pCurSh)
-{
-vcl::Window* pShellWin = pCurSh->GetWindow();
-if (!pShellWin)
-pShellWin = Application::GetDefDialogParent();
+if (!pCurSh)
+return;
 
+vcl::Window* pShellWin = pCurSh->GetWindow();
+if (pShellWin)
+{
 pShellWin->GrabFocus();
+return;
 }
+
+weld::Window* pWin = Application::GetDefDialogParent();
+if (!pWin)
+return;
+pWin->grab_focus();
 }
 
 void LibBox::FillBox()
diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
index 8942d87f4ae0..70991525331a 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -1295,7 +1295,7 @@ BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC const 
* pBasic )
 if ( StarBASIC::IsRunning() )   // if cancelled...
 {
 if ( bAppWindowDisabled )
-Application::GetDefDialogParent()->Enable(false);
+Application::GetDefDialogParent()->set_sensitive(false);
 
 if ( nWaitCount )
 {
diff --git a/basctl/source/basicide/basobj3.cxx 
b/basctl/source/basicide/basobj3.cxx
index fa7c2fc3d220..06f7c6a9e08c 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -332,10 +332,10 @@ void BasicStopped(
 *pnWaitCount = nWait;
 }
 
-vcl::Window* pDefParent = Application::GetDefDialogParent();
-if ( pDefParent && !pDefParent->IsEnabled() )
+weld::Window* pDefParent = Application::GetDefDialogParent();
+if (pDefParent && !pDefParent->get_sensitive())
 {
-pDefParent->Enable();
+pDefParent->set_sensitive(true);
 if ( pbAppWindowDisabled )
 *pbAppWindowDisabled = true;
 }
diff --git a/basic/source/runtime/inputbox.cxx 
b/basic/source/runtime/inputbox.cxx
index 50b19ee51273..e409b1352bfd 100644
--- a/basic/source/runtime/inputbox.cxx
+++ b/basic/source/runtime/inputbox.cxx
@@ -133,8 +133,7 @@ void SbRtl_InputBox(StarBASIC *, SbxArray & rPar, bool)
 nX = rPar.Get(4)->GetLong();
 nY = rPar.Get(5)->GetLong();
 }
-vcl::Window* pParent = Application::GetDefDialogParent();
-SvRTLInputBox aDlg(pParent ? pParent->GetFrameWeld() : 
nullptr,rPrompt,aTitle,aDefault,nX,nY);
+SvRTLInputBox aDlg(Application::GetDefDialogParent(), rPrompt, aTitle, 
aDefault, nX, nY);
 aDlg.run();
 rPar.Get(0)->PutString(aDlg.GetText());
 }
diff --git a/basic/source/runtime/iosys.cxx b/basic/source/runtime/iosys.cxx
index 5b177b906d2d..43ee1c4d6856 100644
--- a/basic/source/runtime/iosys.cxx
+++ b/basic/source/runtime/iosys.cxx
@@ -691,8 +691,7 @@ void SbiIoSystem::Shutdown()
 // anything left to PRINT?
 if( !aOut.isEmpty() )
 {
-vcl::Window* pParent = Application::GetDefDialogParent();
-std::unique_ptr 
xBox(Application::CreateMessageDialog(pParent ? pParent->GetFrameWeld() : 
nullptr,

[Libreoffice-commits] core.git: cppu/source

2021-08-06 Thread Caolán McNamara (via logerrit) 
 cppu/source/threadpool/current.cxx |9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 373da7a00986ea95ce959242c0876a5eaf18a1b6
Author: Caolán McNamara 
AuthorDate: Fri Aug 6 08:56:52 2021 +0100
Commit: Caolán McNamara 
CommitDate: Fri Aug 6 10:54:46 2021 +0200

cid#1489779 Uninitialized pointer field

Change-Id: I3a9405ff1ed161a02b590d2ac996d88b5fb1978d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cppu/source/threadpool/current.cxx 
b/cppu/source/threadpool/current.cxx
index 64b9923286c2..e163a20be2ec 100644
--- a/cppu/source/threadpool/current.cxx
+++ b/cppu/source/threadpool/current.cxx
@@ -81,10 +81,13 @@ static typelib_InterfaceTypeDescription * 
get_type_XCurrentContext()
 }
 
 IdContainer::IdContainer()
+: pCurrentContext(nullptr)
+, pCurrentContextEnv(nullptr)
+, bInit(false)
+, pLocalThreadId(nullptr)
+, nRefCountOfCurrentId(0)
+, pCurrentId(nullptr)
 {
-pCurrentContext = nullptr;
-pCurrentContextEnv = nullptr;
-bInit = false;
 }
 
 IdContainer::~IdContainer()

[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit) 
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   22 ++
 2 files changed, 23 insertions(+)

New commits:
commit 1f4986d178e9bab1be48e0c0a393271598e31eee
Author: panoskorovesis 
AuthorDate: Wed Aug 4 10:44:28 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:54:05 2021 +0200

Add Handler for EPS Write

The handler separates MetaEPSAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: Ib9866966ba067223860ddfd2b48880f6e83fe537
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119968
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index d1edf5fd27a3..014b59afbec5 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -65,4 +65,5 @@ public:
 void RasterOpHandler(MetaRasterOpAction* pAction);
 void TransparentHandler(MetaTransparentAction* pAction);
 void FloatTransparentHandler(MetaFloatTransparentAction* pAction);
+void EPSHandler(MetaEPSAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index fb7b9c425495..057a5e7c1bc0 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -262,6 +262,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::EPS:
+{
+auto* pMetaAction = static_cast(pAction);
+EPSHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -601,4 +608,19 @@ void 
SvmWriter::FloatTransparentHandler(MetaFloatTransparentAction* pAction)
 aSerializer.writeSize(pAction->GetSize());
 aSerializer.writeGradient(pAction->GetGradient());
 }
+
+void SvmWriter::EPSHandler(MetaEPSAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+
+TypeSerializer aSerializer(mrStream);
+aSerializer.writeGfxLink(pAction->GetLink());
+aSerializer.writePoint(pAction->GetPoint());
+aSerializer.writeSize(pAction->GetSize());
+
+SvmWriter aWriter(mrStream);
+GDIMetaFile aMtf = pAction->GetSubstitute();
+aWriter.Write(aMtf);
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit) 
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   21 +
 2 files changed, 22 insertions(+)

New commits:
commit 49a2a16c6186d372afd66b6630c813e33448b3e4
Author: panoskorovesis 
AuthorDate: Wed Aug 4 10:28:24 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:52:45 2021 +0200

Add Handler for FloatTransparent Write

The handler separates MetaFloatTransparentAction::Write from
metaact.hxx. Read implementation is now in SvmWriter.hxx

Change-Id: I77755cc6c9337903808ade7b367d32d89f35a6a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119967
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index ff26899cfaa5..d1edf5fd27a3 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -64,4 +64,5 @@ public:
 void PopHandler(MetaPopAction* pAction);
 void RasterOpHandler(MetaRasterOpAction* pAction);
 void TransparentHandler(MetaTransparentAction* pAction);
+void FloatTransparentHandler(MetaFloatTransparentAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index f6e4ad425e24..fb7b9c425495 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -255,6 +255,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::FLOATTRANSPARENT:
+{
+auto* pMetaAction = 
static_cast(pAction);
+FloatTransparentHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -580,4 +587,18 @@ void SvmWriter::TransparentHandler(MetaTransparentAction* 
pAction)
 WritePolyPolygon(mrStream, aNoCurvePolyPolygon);
 mrStream.WriteUInt16(pAction->GetTransparence());
 }
+
+void SvmWriter::FloatTransparentHandler(MetaFloatTransparentAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+
+SvmWriter aWriter(mrStream);
+GDIMetaFile aMtf = pAction->GetGDIMetaFile();
+aWriter.Write(aMtf);
+TypeSerializer aSerializer(mrStream);
+aSerializer.writePoint(pAction->GetPoint());
+aSerializer.writeSize(pAction->GetSize());
+aSerializer.writeGradient(pAction->GetGradient());
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit) 
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   28 
 2 files changed, 29 insertions(+)

New commits:
commit 9eae429060cd968026834943f26f04a567f33e04
Author: panoskorovesis 
AuthorDate: Wed Aug 4 10:21:39 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:49:23 2021 +0200

Add Handler for Transparent Write

The handler separates MetaTransparentAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: I8ae0e9341f2319126afc64cb633a0199d2496976
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119966
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index 79c0eec8c94c..ff26899cfaa5 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -63,4 +63,5 @@ public:
 void PushHandler(MetaPushAction* pAction);
 void PopHandler(MetaPopAction* pAction);
 void RasterOpHandler(MetaRasterOpAction* pAction);
+void TransparentHandler(MetaTransparentAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index 3648e5672c73..f6e4ad425e24 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -248,6 +248,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::Transparent:
+{
+auto* pMetaAction = static_cast(pAction);
+TransparentHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -552,4 +559,25 @@ void SvmWriter::RasterOpHandler(MetaRasterOpAction* 
pAction)
 VersionCompatWrite aCompat(mrStream, 1);
 mrStream.WriteUInt16(static_cast(pAction->GetRasterOp()));
 }
+
+void SvmWriter::TransparentHandler(MetaTransparentAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+
+// #i105373# The tools::PolyPolygon in this action may be a curve; this
+// was ignored until now what is an error. To make older office
+// versions work with MetaFiles, i opt for applying AdaptiveSubdivide
+// to the PolyPolygon.
+// The alternative would be to really write the curve information
+// like in MetaPolyPolygonAction::Write (where someone extended it
+// correctly, but not here :-( ).
+// The golden solution would be to combine both, but i think it's
+// not necessary; a good subdivision will be sufficient.
+tools::PolyPolygon aNoCurvePolyPolygon;
+pAction->GetPolyPolygon().AdaptiveSubdivide(aNoCurvePolyPolygon);
+
+WritePolyPolygon(mrStream, aNoCurvePolyPolygon);
+mrStream.WriteUInt16(pAction->GetTransparence());
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: include/vcl vcl/source

2021-08-06 Thread panoskorovesis (via logerrit) 
 include/vcl/filter/SvmWriter.hxx|1 +
 vcl/source/filter/svm/SvmWriter.cxx |   14 ++
 2 files changed, 15 insertions(+)

New commits:
commit fba03519001f606f5ed5e7ae892dd76f004931b2
Author: panoskorovesis 
AuthorDate: Wed Aug 4 10:12:09 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:48:08 2021 +0200

Add Handler for RasterOp Write

The handler separates MetaRasterOpAction::Write from metaact.hxx
Write implementation is now in SvmWriter.hxx

Change-Id: I80647d924f978b15682c18f8a27eff5e58b0fdd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119965
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/filter/SvmWriter.hxx b/include/vcl/filter/SvmWriter.hxx
index 5c83bfd8913c..79c0eec8c94c 100644
--- a/include/vcl/filter/SvmWriter.hxx
+++ b/include/vcl/filter/SvmWriter.hxx
@@ -62,4 +62,5 @@ public:
 void FontHandler(MetaFontAction* pAction, ImplMetaWriteData* pData);
 void PushHandler(MetaPushAction* pAction);
 void PopHandler(MetaPopAction* pAction);
+void RasterOpHandler(MetaRasterOpAction* pAction);
 };
\ No newline at end of file
diff --git a/vcl/source/filter/svm/SvmWriter.cxx 
b/vcl/source/filter/svm/SvmWriter.cxx
index 375cda5218fd..3648e5672c73 100644
--- a/vcl/source/filter/svm/SvmWriter.cxx
+++ b/vcl/source/filter/svm/SvmWriter.cxx
@@ -241,6 +241,13 @@ void SvmWriter::MetaActionHandler(MetaAction* pAction, 
ImplMetaWriteData* pData)
 }
 break;
 
+case MetaActionType::RASTEROP:
+{
+auto* pMetaAction = static_cast(pAction);
+RasterOpHandler(pMetaAction);
+}
+break;
+
 /* default case prevents test failure and will be
 removed once all the handlers are completed */
 default:
@@ -538,4 +545,11 @@ void SvmWriter::PopHandler(MetaPopAction* pAction)
 mrStream.WriteUInt16(static_cast(pAction->GetType()));
 VersionCompatWrite aCompat(mrStream, 1);
 }
+
+void SvmWriter::RasterOpHandler(MetaRasterOpAction* pAction)
+{
+mrStream.WriteUInt16(static_cast(pAction->GetType()));
+VersionCompatWrite aCompat(mrStream, 1);
+mrStream.WriteUInt16(static_cast(pAction->GetRasterOp()));
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

[Libreoffice-commits] core.git: sfx2/source

2021-08-06 Thread panoskorovesis (via logerrit) 
 sfx2/source/appl/linkmgr2.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit bb2828cebf05467d2c301a476b2d485467de0c51
Author: panoskorovesis 
AuthorDate: Tue Aug 3 12:26:35 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:46:25 2021 +0200

Replace GDIMetaFile::Read with SvmReader::Read in linkmgr2.cxx

Use the new read functionality in sfx2/source/appl/linkmgr2.cxx

Change-Id: I25632dc11f50c0d16b2505acf2b4c271ef0a8775
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119964
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sfx2/source/appl/linkmgr2.cxx b/sfx2/source/appl/linkmgr2.cxx
index 062450c3d0c3..4b77bcf90fb6 100644
--- a/sfx2/source/appl/linkmgr2.cxx
+++ b/sfx2/source/appl/linkmgr2.cxx
@@ -28,6 +28,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -552,7 +553,8 @@ bool LinkManager::GetGraphicFromAny(const OUString& 
rMimeType,
 case SotClipboardFormatId::GDIMETAFILE:
 {
 GDIMetaFile aMtf;
-aMtf.Read( aMemStm );
+SvmReader aReader( aMemStm );
+aReader.Read( aMtf );
 rGraphic = aMtf;
 bRet = true;
 }

[Libreoffice-commits] core.git: filter/source

2021-08-06 Thread panoskorovesis (via logerrit) 
 filter/source/svg/svgexport.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 478a1ca5b169889cea0c09c2e18970223312ea2e
Author: panoskorovesis 
AuthorDate: Tue Aug 3 12:24:16 2021 +0300
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 10:45:13 2021 +0200

Replace GDIMetaFile::Read with SvmReader::Read in svgexport.cxx

Use the new read functionality in filter/source/svg/svgexport.cxx

Change-Id: I798bd35df9f7f15c5f802b8a6b2f5af2136ce0d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119963
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index fdad0ba6dd37..e1d2fcba2376 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -53,6 +53,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -2466,7 +2467,8 @@ void SVGFilter::implCreateObjectsFromBackground( const 
Reference< css::drawing::
 
 xExporter->setSourceDocument( Reference< XComponent >( rxDrawPage, 
UNO_QUERY ) );
 xExporter->filter( aDescriptor );
-aMtf.Read( *aFile.GetStream( StreamMode::READ ) );
+SvmReader aReader( *aFile.GetStream( StreamMode::READ ) );
+aReader.Read( aMtf );
 
 bool bIsBitmap = false;
 bool bIsTiled = false;

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/qa

2021-08-06 Thread Dennis Francis (via logerrit) 
 sc/qa/unit/tiledrendering/tiledrendering.cxx |   44 ++-
 1 file changed, 43 insertions(+), 1 deletion(-)

New commits:
commit 06f993fa3175cc237d16d47fd811c9b4491f
Author: Dennis Francis 
AuthorDate: Fri Jul 2 19:10:31 2021 +0530
Commit: Dennis Francis 
CommitDate: Fri Aug 6 10:25:04 2021 +0200

lok: sc: unit test for non existent tab view data fix

Conflicts:
sc/qa/unit/tiledrendering/tiledrendering.cxx

Change-Id: I7c0ea95118448a49288ff70c8e7bcddc379df5ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119602
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jan Holesovsky 

diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx 
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index fc3d675ba79a..b9f24ed20afd 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -121,7 +121,7 @@ public:
 void testMoveShapeHandle();
 void testEditCursorBounds();
 void testTextSelectionBounds();
-
+void testSheetViewDataCrash();
 
 CPPUNIT_TEST_SUITE(ScTiledRenderingTest);
 CPPUNIT_TEST(testRowColumnHeaders);
@@ -175,6 +175,7 @@ public:
 CPPUNIT_TEST(testMoveShapeHandle);
 CPPUNIT_TEST(testEditCursorBounds);
 CPPUNIT_TEST(testTextSelectionBounds);
+CPPUNIT_TEST(testSheetViewDataCrash);
 CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -2818,6 +2819,47 @@ void ScTiledRenderingTest::testTextSelectionBounds()
 SfxViewShell::Current()->registerLibreOfficeKitViewCallback(nullptr, 
nullptr);
 }
 
+void ScTiledRenderingTest::testSheetViewDataCrash()
+{
+comphelper::LibreOfficeKit::setActive();
+
+ScModelObj* pModelObj = createDoc("empty.ods");
+
+// view #1
+int nView1 = SfxLokHelper::getView();
+SfxLokHelper::setView(nView1);
+
+// Imitate online while creating a new sheet on empty.ods.
+uno::Sequence aArgs(
+comphelper::InitPropertySequence({
+{ "Name",  uno::Any(OUString("NewSheet")) },
+{ "Index", uno::Any(sal_Int32(2)) }
+}));
+comphelper::dispatchCommand(".uno:Insert", aArgs);
+Scheduler::ProcessEventsToIdle();
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::PAGEDOWN | 
KEY_MOD1);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::PAGEDOWN | 
KEY_MOD1);
+Scheduler::ProcessEventsToIdle();
+ScTabViewShell* pView1 = 
dynamic_cast(SfxViewShell::Current());
+CPPUNIT_ASSERT(pView1);
+
+// view #2
+SfxLokHelper::createView();
+ScTabViewShell* pView2 = 
dynamic_cast(SfxViewShell::Current());
+CPPUNIT_ASSERT(pView2);
+Scheduler::ProcessEventsToIdle();
+
+SfxLokHelper::setView(nView1);
+// Delete a range.
+pView1->SetCursor(1, 1);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::DOWN | 
KEY_SHIFT);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::DOWN | KEY_SHIFT);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::DELETE);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::DELETE);
+// It will crash at this point without the fix.
+Scheduler::ProcessEventsToIdle();
+}
+
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(ScTiledRenderingTest);

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sc/source

2021-08-06 Thread Dennis Francis (via logerrit) 
 sc/source/ui/docshell/docfunc.cxx |3 ++-
 sc/source/ui/view/dbfunc3.cxx |   10 --
 sc/source/ui/view/viewdata.cxx|6 --
 sc/source/ui/view/viewfunc.cxx|   16 
 4 files changed, 26 insertions(+), 9 deletions(-)

New commits:
commit 4f80254855f05fc95829b841f09a39f6aa613248
Author: Dennis Francis 
AuthorDate: Fri Jul 2 19:01:47 2021 +0530
Commit: Dennis Francis 
CommitDate: Fri Aug 6 10:24:19 2021 +0200

lok: sc: avoid crash on non existent tab view data

... when accessing position helpers.

Change-Id: Ia627a8c4ed30ad1f1c2333df00b656fe041f111e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119601
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Jan Holesovsky 

diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index 3a135d9d0042..40a19baecaa5 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -167,7 +167,8 @@ bool ScDocFunc::AdjustRowHeight( const ScRange& rRange, 
bool bPaint, bool bApi )
 ScTabViewShell* pTabViewShell = 
dynamic_cast(pViewShell);
 if (pTabViewShell && pTabViewShell->GetDocId() == 
pSomeViewForThisDoc->GetDocId())
 {
-
pTabViewShell->GetViewData().GetLOKHeightHelper(nTab)->invalidateByIndex(nStartRow);
+if (ScPositionHelper* pPosHelper = 
pTabViewShell->GetViewData().GetLOKHeightHelper(nTab))
+pPosHelper->invalidateByIndex(nStartRow);
 }
 pViewShell = SfxViewShell::GetNext(*pViewShell);
 }
diff --git a/sc/source/ui/view/dbfunc3.cxx b/sc/source/ui/view/dbfunc3.cxx
index 52942816c138..424d416fdd4f 100644
--- a/sc/source/ui/view/dbfunc3.cxx
+++ b/sc/source/ui/view/dbfunc3.cxx
@@ -2274,9 +2274,15 @@ void ScDBFunc::OnLOKShowHideColRow(bool bColumns, 
SCCOLROW nStart)
 if (pTabViewShell && pTabViewShell->GetDocId() == 
pThisViewShell->GetDocId())
 {
 if (bColumns)
-
pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)->invalidateByIndex(nStart);
+{
+if (ScPositionHelper* pPosHelper = 
pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex))
+pPosHelper->invalidateByIndex(nStart);
+}
 else
-
pTabViewShell->GetViewData().GetLOKHeightHelper(nCurrentTabIndex)->invalidateByIndex(nStart);
+{
+if (ScPositionHelper* pPosHelper = 
pTabViewShell->GetViewData().GetLOKHeightHelper(nCurrentTabIndex))
+pPosHelper->invalidateByIndex(nStart);
+}
 
 if (pTabViewShell->getPart() == nCurrentTabIndex)
 {
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 6b735e21130c..e4b0af86df85 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -2273,7 +2273,8 @@ void ScViewData::SetTabNo( SCTAB nNewTab )
 
 ScPositionHelper* ScViewData::GetLOKWidthHelper(SCTAB nTabIndex)
 {
-if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size(
+if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size())) ||
+!maTabData[nTabIndex])
 {
 return nullptr;
 }
@@ -2282,7 +2283,8 @@ ScPositionHelper* ScViewData::GetLOKWidthHelper(SCTAB 
nTabIndex)
 
 ScPositionHelper* ScViewData::GetLOKHeightHelper(SCTAB nTabIndex)
 {
-if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size(
+if (!ValidTab(nTabIndex) || (nTabIndex >= 
static_cast(maTabData.size())) ||
+!maTabData[nTabIndex])
 {
 return nullptr;
 }
diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index 774f3a27aa26..08f8ac2f8ce2 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -1479,7 +1479,8 @@ void ScViewFunc::OnLOKInsertDeleteColumn(SCCOL nStartCol, 
long nOffset)
 ScTabViewShell* pTabViewShell = 
dynamic_cast(pViewShell);
 if (pTabViewShell && pTabViewShell->GetDocId() == 
pCurrentViewShell->GetDocId())
 {
-
pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex)->invalidateByIndex(nStartCol);
+if (ScPositionHelper* pPosHelper = 
pTabViewShell->GetViewData().GetLOKWidthHelper(nCurrentTabIndex))
+pPosHelper->invalidateByIndex(nStartCol);
 
 // if we remove a column the cursor position  and the current 
selection
 // in other views could need to be moved on the left by one column.
@@ -1535,7 +1536,8 @@ void ScViewFunc::OnLOKInsertDeleteRow(SCROW nStartRow, 
long nOffset)
 ScTabViewShell* pTabViewShell = 
dynamic_cast(pViewShell);
 if (pTabViewShell && pTabViewShell->GetDocId() == 
pCurrentViewShell->GetDocId())
 {
-

[Libreoffice-bugs] [Bug 73593] add more formula items to Elements pane, provide LibreOffice with more complete coverage of MathML and LaTex symbol definitions

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=73593
Bug 73593 depends on bug 134214, which changed state.

Bug 134214 Summary: Missing symbols on opensymbol font
https://bugs.documentfoundation.org/show_bug.cgi?id=134214

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113305] [META] Bundled fonts bugs and enhancements

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=113305
Bug 113305 depends on bug 134214, which changed state.

Bug 134214 Summary: Missing symbols on opensymbol font
https://bugs.documentfoundation.org/show_bug.cgi?id=134214

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTOURBUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134214] Missing symbols on opensymbol font

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=134214

dante19031...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 134214] Missing symbols on opensymbol font

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=134214

--- Comment #6 from dante19031...@gmail.com ---
(In reply to Buovjaga from comment #5)
> Dante: would you like to close this as fixed? :)

Yes, we can. That will avoid this issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141435] Cropped images +75PPP lost her aspect ratio after have been compressed

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=141435

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||734

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83734] EDITING: Cropped image gets distorted when Compress Graphic is used

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=83734

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||1435

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143388] New "Search Commands" feature: Ctrl + F1 shortcut not working

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143388

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #10 from BogdanB  ---
Tomaz, please mark this bug as resolved.

I have verified and it is working well in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143527] Impress slide transition sounds do not loop (64-bit Win only)

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143527

Timur  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)

--- Comment #7 from Timur  ---
Good catch for 64-bit. No repro 5.1 alpha 64-bit Win so properly mark from 5.2.

As for importance, 2 reasons:
- this is a general LO feature, which doesn't work for any user (and all are on
64-bit now), not a problem with single document, so may be considered major,
and more important:
- this is a regression, and all regressions should have one step higher
importance, i.e. high and not medium.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: setup_native/Package_packinfo.mk

2021-08-06 Thread Stephan Bergmann (via logerrit) 
 setup_native/Package_packinfo.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 626050e86b7d5ca0c3bfc265cc33ce8e9d1bf195
Author: Stephan Bergmann 
AuthorDate: Fri Aug 6 08:10:39 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Aug 6 09:16:54 2021 +0200

gb_Package_Package must specify a directory

...even if unused, as otherwise a minimal --without-java build (i.e., where 
the
ifeq in setup_native/Package_packinfo.mk actually triggers) failed with

> setup_native/Package_packinfo.mk:18: *** gb_Package__check: Package 
setup_native_packinfo has not been defined.  Stop.

Change-Id: I0fa3640448da333294ee2ab25183df1ffee22533
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120094
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/setup_native/Package_packinfo.mk b/setup_native/Package_packinfo.mk
index 18560b2f0694..b2064c46c36b 100644
--- a/setup_native/Package_packinfo.mk
+++ b/setup_native/Package_packinfo.mk
@@ -7,7 +7,7 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Package_Package,setup_native_packinfo))
+$(eval $(call gb_Package_Package,setup_native_packinfo,$(SRCDIR)))
 
 # Check if any bundled extensions are installed (where ENABLE_JAVA covers 
Extension_nlpsolver, cf.
 # nlpsolver/Module_nlpsolver.mk); if none are installed, then 
gb_Package_add_empty_directory is

[Libreoffice-bugs] [Bug 143605] Unnumbered Heading1 is numbered

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143605

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vasily.melenc...@cib.de
   |desktop.org |
 CC||t...@libreoffice.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 88481] Editing : Value become zero on DDE Link Break on reopen

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=88481

Buovjaga  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - ucb/source

2021-08-06 Thread Noel Grandin (via logerrit) 
 ucb/source/ucp/tdoc/tdoc_stgelems.hxx|   20 +---
 ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx |4 ++--
 ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx |4 ++--
 3 files changed, 13 insertions(+), 15 deletions(-)

New commits:
commit 43d6a33339b0bc8d42fece9e22dc44c9da57
Author: Noel Grandin 
AuthorDate: Thu Aug 5 20:36:28 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Aug 6 08:58:44 2021 +0200

osl::Mutex->std::mutex in DAVSessionFactory

Change-Id: I1fa55f09e3a9d398a61856986cb0a91e225c7b79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120087
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx 
b/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx
index fd6fca081e80..d58171bdef6e 100644
--- a/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx
+++ b/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx
@@ -44,7 +44,7 @@ rtl::Reference< DAVSession > 
DAVSessionFactory::createDAVSession(
 const uno::Sequence< beans::NamedValue >& rFlags,
 const uno::Reference< uno::XComponentContext > & rxContext )
 {
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
 
 m_xContext = rxContext;
 
@@ -91,7 +91,7 @@ rtl::Reference< DAVSession > 
DAVSessionFactory::createDAVSession(
 void DAVSessionFactory::releaseElement( DAVSession const * pElement )
 {
 OSL_ASSERT( pElement );
-osl::MutexGuard aGuard( m_aMutex );
+std::scoped_lock aGuard( m_aMutex );
 if ( pElement->m_aContainerIt != m_aMap.end() )
 m_aMap.erase( pElement->m_aContainerIt );
 }
diff --git a/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx 
b/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx
index eac25471e826..fd185d11ae8a 100644
--- a/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx
+++ b/ucb/source/ucp/webdav-neon/DAVSessionFactory.hxx
@@ -33,7 +33,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -70,7 +70,7 @@ private:
 typedef std::map< OUString, DAVSession * > Map;
 
 Map m_aMap;
-osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 std::unique_ptr< ucbhelper::InternetProxyDecider > m_xProxyDecider;
 
 ::uno::Reference< ::uno::XComponentContext > m_xContext;
commit cc6701f9e58f4b655313fa75da8980bb93ae545e
Author: Noel Grandin 
AuthorDate: Thu Aug 5 20:31:31 2021 +0200
Commit: Noel Grandin 
CommitDate: Fri Aug 6 08:58:34 2021 +0200

osl::Mutex->std::mutex in ParentStorageHolder

Change-Id: I01cd21cddc10b09ea8026e84fa64331067b38db0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120086
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx 
b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
index eda5390f07b6..f6e8f609e025 100644
--- a/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
+++ b/ucb/source/ucp/tdoc/tdoc_stgelems.hxx
@@ -19,9 +19,6 @@
 
 #pragma once
 
-#include 
-
-#include 
 #include 
 
 #include 
@@ -36,15 +33,12 @@
 
 #include "tdoc_storage.hxx"
 
-namespace tdoc_ucp {
-
-struct MutexHolder
-{
-osl::Mutex m_aMutex;
-};
+#include 
+#include 
 
+namespace tdoc_ucp {
 
-class ParentStorageHolder : public MutexHolder
+class ParentStorageHolder
 {
 public:
 ParentStorageHolder(
@@ -57,9 +51,13 @@ public:
 getParentStorage() const
 { return m_xParentStorage; }
 void setParentStorage( const css::uno::Reference< css::embed::XStorage > & 
xStg )
-{ osl::MutexGuard aGuard( m_aMutex ); m_xParentStorage = xStg; }
+{
+std::scoped_lock aGuard( m_aMutex );
+m_xParentStorage = xStg;
+}
 
 private:
+std::mutex m_aMutex;
 css::uno::Reference< css::embed::XStorage > m_xParentStorage;
 bool  m_bParentIsRootStorage;
 };

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/CppunitTest_sw_core_edit.mk sw/Module_sw.mk sw/qa sw/source

2021-08-06 Thread Miklos Vajna (via logerrit) 
 sw/CppunitTest_sw_core_edit.mk   |   75 +++
 sw/Module_sw.mk  |1 
 sw/qa/core/edit/data/redline-hidden.fodt |   32 +
 sw/qa/core/edit/edit.cxx |   45 ++
 sw/source/core/edit/edatmisc.cxx |2 
 5 files changed, 154 insertions(+), 1 deletion(-)

New commits:
commit a03892e818736b98d5d3699fdf20ad461f2fb70b
Author: Miklos Vajna 
AuthorDate: Thu Aug 5 13:43:50 2021 +0200
Commit: Mike Kaganski 
CommitDate: Fri Aug 6 08:51:09 2021 +0200

sw: fix assert fail with ShowRedlineChanges=false and para format

It fails like this:

loolforkit: sw/source/core/layout/wsfrm.cxx:4551: void 
UnHide(SwRootFrame&): Assertion `rLayout.GetCurrShell()->ActionPend()' failed.
#4  0x7f98e9f8c198 in UnHide(SwRootFrame&) (rLayout=...) at 
sw/source/core/layout/wsfrm.cxx:4551
#5  0x7f98e9f8c839 in SwRootFrame::SetHideRedlines(bool) 
(this=0x7f98c40f7bd0, bHideRedlines=false) at 
sw/source/core/layout/wsfrm.cxx:4664
#6  0x7f98e9b18afd in 
sw::DocumentRedlineManager::SetRedlineFlags(RedlineFlags) (this=0x80a4120, 
eMode=49) at sw/source/core/doc/DocumentRedlineManager.cxx:1097
#7  0x7f98e9cfa503 in SwEditShell::SetAttrSet(SfxItemSet 
const&, SetAttrMode, SwPaM*, bool) (this=0x8885840, rSet=
SfxItemSet of pool 0x808fd10 with parent 0x0 and Which ranges: 
[(63, 64), (120, 120)] = {...}, nFlags=SetAttrMode::DEFAULT, pPaM=0x0, 
bParagraphSetting=true)
at sw/source/core/edit/edatmisc.cxx:187
#8  0x7f98ea995f07 in SwTextShell::ExecParaAttr(SfxRequest&) 
(this=0x8bd0820, rReq=...) at sw/source/uibase/shells/txtattr.cxx:451

Fix it the same way commit dd489bc01adc22fc5015ea56b61d66104af184a8
(tdf#125754 sw_redlinehide: avoid recursive layout in SetHideRedlines(),
2019-06-19) did: make sure that SetHideRedlines() is called before
EndAllAction().

(cherry picked from commit 39392ee94c78692a9179f7face15af0c9e74e492)

Conflicts:
sw/Module_sw.mk

Change-Id: I6304abec2e2e2967a8369b0219492bebcd606d03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120077
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Mike Kaganski 

diff --git a/sw/CppunitTest_sw_core_edit.mk b/sw/CppunitTest_sw_core_edit.mk
new file mode 100644
index ..21afd9ec538f
--- /dev/null
+++ b/sw/CppunitTest_sw_core_edit.mk
@@ -0,0 +1,75 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sw_core_edit))
+
+$(eval $(call gb_CppunitTest_use_common_precompiled_header,sw_core_edit))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sw_core_edit, \
+sw/qa/core/edit/edit \
+))
+
+$(eval $(call gb_CppunitTest_use_libraries,sw_core_edit, \
+editeng \
+comphelper \
+cppu \
+cppuhelper \
+sal \
+sfx \
+svxcore \
+sw \
+   swqahelper \
+test \
+unotest \
+utl \
+vcl \
+svt \
+tl \
+svl \
+))
+
+$(eval $(call gb_CppunitTest_use_externals,sw_core_edit,\
+boost_headers \
+libxml2 \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sw_core_edit,\
+-I$(SRCDIR)/sw/inc \
+-I$(SRCDIR)/sw/source/core/inc \
+-I$(SRCDIR)/sw/source/uibase/inc \
+-I$(SRCDIR)/sw/qa/inc \
+$$(INCLUDE) \
+))
+
+$(eval $(call gb_CppunitTest_use_api,sw_core_edit,\
+   udkapi \
+   offapi \
+   oovbaapi \
+))
+
+$(eval $(call gb_CppunitTest_use_ure,sw_core_edit))
+$(eval $(call gb_CppunitTest_use_vcl,sw_core_edit))
+
+$(eval $(call gb_CppunitTest_use_rdb,sw_core_edit,services))
+
+$(eval $(call gb_CppunitTest_use_custom_headers,sw_core_edit,\
+officecfg/registry \
+))
+
+$(eval $(call gb_CppunitTest_use_configuration,sw_core_edit))
+
+$(eval $(call gb_CppunitTest_use_uiconfigs,sw_core_edit, \
+modules/swriter \
+))
+
+$(eval $(call gb_CppunitTest_use_more_fonts,sw_core_edit))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index 947d3293aa51..26f8bd797206 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -126,6 +126,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\
 CppunitTest_sw_core_undo \
 CppunitTest_sw_uibase_uiview \
 CppunitTest_sw_core_draw \
+CppunitTest_sw_core_edit \
 ))
 
 ifneq ($(DISABLE_GUI),TRUE)
diff --git a/sw/qa/core/edit/data/redline-hidden.fodt 
b/sw/qa/core/edit/data/redline-hidden.fodt
new file mode 100644
index

[Libreoffice-commits] core.git: sw/source

2021-08-06 Thread Miklos Vajna (via logerrit) 
 sw/source/core/doc/DocumentSettingManager.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1dd1cf97392f336c05ea76ccda273bb15f2e0b4e
Author: Miklos Vajna 
AuthorDate: Thu Aug 5 20:12:59 2021 +0200
Commit: Miklos Vajna 
CommitDate: Fri Aug 6 08:40:47 2021 +0200

sw: handle mbMathBaselineAlignment when replacing compat options

This is on for new documents and off for old ones.

Change-Id: Ia96fd1901ddb5872730716824096509a80b0b9c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120083
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/doc/DocumentSettingManager.cxx 
b/sw/source/core/doc/DocumentSettingManager.cxx
index d786b9e52be5..ce5ec89f182c 100644
--- a/sw/source/core/doc/DocumentSettingManager.cxx
+++ b/sw/source/core/doc/DocumentSettingManager.cxx
@@ -640,7 +640,7 @@ void 
sw::DocumentSettingManager::ReplaceCompatibilityOptions(const DocumentSetti
 mbUseFormerObjectPos = rSource.mbUseFormerObjectPos;
 mbUseFormerTextWrapping = rSource.mbUseFormerTextWrapping;
 mbConsiderWrapOnObjPos = rSource.mbConsiderWrapOnObjPos;
-// No mbMathBaselineAlignment
+mbMathBaselineAlignment = rSource.mbMathBaselineAlignment;
 mbStylesNoDefault = rSource.mbStylesNoDefault;
 mbFloattableNomargins = rSource.mbFloattableNomargins;
 mbOldNumbering = rSource.mbOldNumbering;

[Libreoffice-bugs] [Bug 138668] support image format AVIF import

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=138668

Roland Kurmann  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||4532

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114532] add support for WEBP image format (image import and inside .ods/.odt)

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=114532

Roland Kurmann  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||8668

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143572] Crash clicking Shape 2 Text Frame

2021-08-06 Thread bugzilla-daemon 
https://bugs.documentfoundation.org/show_bug.cgi?id=143572

Jim Raykowski  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |rayk...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

<    1   2