[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/source
vcl/source/filter/png/PngImageReader.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 9ebceed2e50c111655dd64dde6e8306afe1cae84
Author: Caolán McNamara
AuthorDate: Mon Aug 23 20:17:42 2021 +0100
Commit: Michael Stahl
CommitDate: Wed Aug 25 14:51:11 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I768cec434ee20e6e46eb3993c873bed05b3c9cc3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120925
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit a0e92a64a9a6069ee21336888f3781ffe144b2df)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120974
Reviewed-by: Michael Stahl
diff --git a/vcl/source/filter/png/PngImageReader.cxx
b/vcl/source/filter/png/PngImageReader.cxx
index 56945e9d9c4b..80fcf7e99df3 100644
--- a/vcl/source/filter/png/PngImageReader.cxx
+++ b/vcl/source/filter/png/PngImageReader.cxx
@@ -55,8 +55,8 @@ bool isPng(SvStream& rStream)
{
// Check signature bytes
sal_uInt8 aHeader[PNG_SIGNATURE_SIZE];
-rStream.ReadBytes(aHeader, PNG_SIGNATURE_SIZE);
-
+if (rStream.ReadBytes(aHeader, PNG_SIGNATURE_SIZE) != PNG_SIGNATURE_SIZE)
+return false;
return png_sig_cmp(aHeader, 0, PNG_SIGNATURE_SIZE) == 0;
}
[Libreoffice-bugs] [Bug 143956] Writer Templates are in Format Size A4 instead of Letter for Default - English (USA)
https://bugs.documentfoundation.org/show_bug.cgi?id=143956 --- Comment #4 from Heiko Tietze --- (In reply to Laurent BP from comment #3) > One solution would be... How about cleaning up the templates as we do for Impress and remove the page size entry? > Content of these templates are outdated, and English only. Fully signed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143956] Writer Templates are in Format Size A4 instead of Letter for Default - English (USA)
https://bugs.documentfoundation.org/show_bug.cgi?id=143956 --- Comment #4 from Heiko Tietze --- (In reply to Laurent BP from comment #3) > One solution would be... How about cleaning up the templates as we do for Impress and remove the page size entry? > Content of these templates are outdated, and English only. Fully signed. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144030] "Use OpenGL" under 3D View option in readme
https://bugs.documentfoundation.org/show_bug.cgi?id=144030 sophie changed: What|Removed |Added CC||so...@libreoffice.org --- Comment #3 from sophie --- (In reply to Adolfo Jayme from comment #2) > @Roman: You can simply remove the string with no need for any replacement. Agreed with Adolfo. And I only pointed this string, but I think the readme may need a full review. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144065] add RTF \page control as an option for inserting page breaks in RTF documents
https://bugs.documentfoundation.org/show_bug.cgi?id=144065 Michael Warner changed: What|Removed |Added Severity|minor |enhancement --- Comment #1 from Michael Warner --- Based on what you have written, it sounds like recognizing \pagebb is a problem for other word processors to solve, not LO. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144030] "Use OpenGL" under 3D View option in readme
https://bugs.documentfoundation.org/show_bug.cgi?id=144030 Adolfo Jayme changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from Adolfo Jayme --- @Roman: You can simply remove the string with no need for any replacement. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64216] Writer takes several minutes of 100% CPU to open or display a simple ODT with frames
https://bugs.documentfoundation.org/show_bug.cgi?id=64216 --- Comment #22 from Noel Grandin --- On current master, this file opens in seconds -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - external/openssl
external/openssl/UnpackedTarball_openssl.mk |1
external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 | 56
++
2 files changed, 57 insertions(+)
New commits:
commit fa6848f5aa5f2f2361d3969515d836ec96fd82c2
Author: Michael Stahl
AuthorDate: Wed Aug 25 11:32:11 2021 +0200
Commit: Michael Stahl
CommitDate: Wed Aug 25 14:11:16 2021 +0200
openssl: add patch for CVE-2021-3712
Change-Id: I4061cbac18ddf9c7f932a27bf2b54a2b1c2f9d99
diff --git a/external/openssl/UnpackedTarball_openssl.mk
b/external/openssl/UnpackedTarball_openssl.mk
index ad600cce1412..e7fca1116545 100644
--- a/external/openssl/UnpackedTarball_openssl.mk
+++ b/external/openssl/UnpackedTarball_openssl.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,openssl,\
external/openssl/openssl-3650-masm.patch.1 \
external/openssl/openssl-fixbuild.patch.1 \
external/openssl/openssl-1.0.2k-cve-2020-1971.patch.1 \
+ external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
new file mode 100644
index ..cf809750ecfb
--- /dev/null
+++ b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
@@ -0,0 +1,56 @@
+From ccb0a11145ee72b042d10593a64eaf9e8a55ec12 Mon Sep 17 00:00:00 2001
+From: Matt Caswell
+Date: Tue, 17 Aug 2021 14:41:48 +0100
+Subject: [PATCH] Fix a read buffer overrun in X509_CERT_AUX_print()
+
+This is a backport of commit c5dc9ab965f to 1.0.2. That commit fixed
+the same bug but in master/1.1.1 it is in the function X509_aux_print().
+The original commit had the following description:
+
+Fix a read buffer overrun in X509_aux_print().
+
+The ASN1_STRING_get0_data(3) manual explitely cautions the reader
+that the data is not necessarily NUL-terminated, and the function
+X509_alias_set1(3) does not sanitize the data passed into it in any
+way either, so we must assume the return value from X509_alias_get0(3)
+is merely a byte array and not necessarily a string in the sense
+of the C language.
+
+I found this bug while writing manual pages for X509_print_ex(3)
+and related functions. Theo Buehler checked my
+patch to fix the same bug in LibreSSL, see
+
+http://cvsweb.openbsd.org/src/lib/libcrypto/asn1/t_x509a.c#rev1.9
+
+As an aside, note that the function still produces incomplete and
+misleading results when the data contains a NUL byte in the middle
+and that error handling is consistently absent throughout, even
+though the function provides an "int" return value obviously intended
+to be 1 for success and 0 for failure, and even though this function
+is called by another function that also wants to return 1 for success
+and 0 for failure and even does so in many of its code paths, though
+not in others. But let's stay focussed. Many things would be nice
+to have in the wide wild world, but a buffer overflow must not be
+allowed to remain in our backyard.
+
+CVE-2021-3712
+
+Reviewed-by: Paul Dale
+---
+ crypto/asn1/t_x509a.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/crypto/asn1/t_x509a.c b/crypto/asn1/t_x509a.c
+index d1b897a469fd..b1bc9d0cd28b 100644
+--- a/crypto/asn1/t_x509a.c
b/crypto/asn1/t_x509a.c
+@@ -104,7 +104,8 @@ int X509_CERT_AUX_print(BIO *out, X509_CERT_AUX *aux, int
indent)
+ } else
+ BIO_printf(out, "%*sNo Rejected Uses.\n", indent, "");
+ if (aux->alias)
+-BIO_printf(out, "%*sAlias: %s\n", indent, "", aux->alias->data);
++BIO_printf(out, "%*sAlias: %.*s\n", indent, "", aux->alias->length,
++ aux->alias->data);
+ if (aux->keyid) {
+ BIO_printf(out, "%*sKey Id: ", indent, "");
+ for (i = 0; i < aux->keyid->length; i++)
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - external/openssl
external/openssl/UnpackedTarball_openssl.mk |1
external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 | 56
++
2 files changed, 57 insertions(+)
New commits:
commit 0b10e2e36bfc807d0cdd42d2d9eaf4a8145d507c
Author: Michael Stahl
AuthorDate: Wed Aug 25 11:32:11 2021 +0200
Commit: Michael Stahl
CommitDate: Wed Aug 25 11:40:19 2021 +0200
openssl: add patch for CVE-2021-3712
Change-Id: I4061cbac18ddf9c7f932a27bf2b54a2b1c2f9d99
diff --git a/external/openssl/UnpackedTarball_openssl.mk
b/external/openssl/UnpackedTarball_openssl.mk
index ad600cce1412..e7fca1116545 100644
--- a/external/openssl/UnpackedTarball_openssl.mk
+++ b/external/openssl/UnpackedTarball_openssl.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,openssl,\
external/openssl/openssl-3650-masm.patch.1 \
external/openssl/openssl-fixbuild.patch.1 \
external/openssl/openssl-1.0.2k-cve-2020-1971.patch.1 \
+ external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
new file mode 100644
index ..cf809750ecfb
--- /dev/null
+++ b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
@@ -0,0 +1,56 @@
+From ccb0a11145ee72b042d10593a64eaf9e8a55ec12 Mon Sep 17 00:00:00 2001
+From: Matt Caswell
+Date: Tue, 17 Aug 2021 14:41:48 +0100
+Subject: [PATCH] Fix a read buffer overrun in X509_CERT_AUX_print()
+
+This is a backport of commit c5dc9ab965f to 1.0.2. That commit fixed
+the same bug but in master/1.1.1 it is in the function X509_aux_print().
+The original commit had the following description:
+
+Fix a read buffer overrun in X509_aux_print().
+
+The ASN1_STRING_get0_data(3) manual explitely cautions the reader
+that the data is not necessarily NUL-terminated, and the function
+X509_alias_set1(3) does not sanitize the data passed into it in any
+way either, so we must assume the return value from X509_alias_get0(3)
+is merely a byte array and not necessarily a string in the sense
+of the C language.
+
+I found this bug while writing manual pages for X509_print_ex(3)
+and related functions. Theo Buehler checked my
+patch to fix the same bug in LibreSSL, see
+
+http://cvsweb.openbsd.org/src/lib/libcrypto/asn1/t_x509a.c#rev1.9
+
+As an aside, note that the function still produces incomplete and
+misleading results when the data contains a NUL byte in the middle
+and that error handling is consistently absent throughout, even
+though the function provides an "int" return value obviously intended
+to be 1 for success and 0 for failure, and even though this function
+is called by another function that also wants to return 1 for success
+and 0 for failure and even does so in many of its code paths, though
+not in others. But let's stay focussed. Many things would be nice
+to have in the wide wild world, but a buffer overflow must not be
+allowed to remain in our backyard.
+
+CVE-2021-3712
+
+Reviewed-by: Paul Dale
+---
+ crypto/asn1/t_x509a.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/crypto/asn1/t_x509a.c b/crypto/asn1/t_x509a.c
+index d1b897a469fd..b1bc9d0cd28b 100644
+--- a/crypto/asn1/t_x509a.c
b/crypto/asn1/t_x509a.c
+@@ -104,7 +104,8 @@ int X509_CERT_AUX_print(BIO *out, X509_CERT_AUX *aux, int
indent)
+ } else
+ BIO_printf(out, "%*sNo Rejected Uses.\n", indent, "");
+ if (aux->alias)
+-BIO_printf(out, "%*sAlias: %s\n", indent, "", aux->alias->data);
++BIO_printf(out, "%*sAlias: %.*s\n", indent, "", aux->alias->length,
++ aux->alias->data);
+ if (aux->keyid) {
+ BIO_printf(out, "%*sKey Id: ", indent, "");
+ for (i = 0; i < aux->keyid->length; i++)
[Libreoffice-bugs] [Bug 144067] Cannot export a template
https://bugs.documentfoundation.org/show_bug.cgi?id=144067 Uwe Auer changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Uwe Auer --- (In reply to TorrAB from comment #0) > Manage templates (~f, m, m); select a template, Manage>Export; enter a name > for the file, get msg ‘File not found’. Why? Is not the system supposed to > create one? You don't **enter** a file name but **select** a folder, where to export the template to (or create a new folder. Please elaborate your bug report -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - external/openssl
external/openssl/UnpackedTarball_openssl.mk |1
external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 | 56
++
2 files changed, 57 insertions(+)
New commits:
commit 16b06275b9e47a034eeeabcde8dbc89b9c8cb8eb
Author: Michael Stahl
AuthorDate: Wed Aug 25 11:32:11 2021 +0200
Commit: Michael Stahl
CommitDate: Wed Aug 25 13:59:31 2021 +0200
openssl: add patch for CVE-2021-3712
Change-Id: I4061cbac18ddf9c7f932a27bf2b54a2b1c2f9d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121029
Tested-by: Michael Stahl
Reviewed-by: Michael Stahl
diff --git a/external/openssl/UnpackedTarball_openssl.mk
b/external/openssl/UnpackedTarball_openssl.mk
index ad600cce1412..e7fca1116545 100644
--- a/external/openssl/UnpackedTarball_openssl.mk
+++ b/external/openssl/UnpackedTarball_openssl.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,openssl,\
external/openssl/openssl-3650-masm.patch.1 \
external/openssl/openssl-fixbuild.patch.1 \
external/openssl/openssl-1.0.2k-cve-2020-1971.patch.1 \
+ external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
new file mode 100644
index ..cf809750ecfb
--- /dev/null
+++ b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
@@ -0,0 +1,56 @@
+From ccb0a11145ee72b042d10593a64eaf9e8a55ec12 Mon Sep 17 00:00:00 2001
+From: Matt Caswell
+Date: Tue, 17 Aug 2021 14:41:48 +0100
+Subject: [PATCH] Fix a read buffer overrun in X509_CERT_AUX_print()
+
+This is a backport of commit c5dc9ab965f to 1.0.2. That commit fixed
+the same bug but in master/1.1.1 it is in the function X509_aux_print().
+The original commit had the following description:
+
+Fix a read buffer overrun in X509_aux_print().
+
+The ASN1_STRING_get0_data(3) manual explitely cautions the reader
+that the data is not necessarily NUL-terminated, and the function
+X509_alias_set1(3) does not sanitize the data passed into it in any
+way either, so we must assume the return value from X509_alias_get0(3)
+is merely a byte array and not necessarily a string in the sense
+of the C language.
+
+I found this bug while writing manual pages for X509_print_ex(3)
+and related functions. Theo Buehler checked my
+patch to fix the same bug in LibreSSL, see
+
+http://cvsweb.openbsd.org/src/lib/libcrypto/asn1/t_x509a.c#rev1.9
+
+As an aside, note that the function still produces incomplete and
+misleading results when the data contains a NUL byte in the middle
+and that error handling is consistently absent throughout, even
+though the function provides an "int" return value obviously intended
+to be 1 for success and 0 for failure, and even though this function
+is called by another function that also wants to return 1 for success
+and 0 for failure and even does so in many of its code paths, though
+not in others. But let's stay focussed. Many things would be nice
+to have in the wide wild world, but a buffer overflow must not be
+allowed to remain in our backyard.
+
+CVE-2021-3712
+
+Reviewed-by: Paul Dale
+---
+ crypto/asn1/t_x509a.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/crypto/asn1/t_x509a.c b/crypto/asn1/t_x509a.c
+index d1b897a469fd..b1bc9d0cd28b 100644
+--- a/crypto/asn1/t_x509a.c
b/crypto/asn1/t_x509a.c
+@@ -104,7 +104,8 @@ int X509_CERT_AUX_print(BIO *out, X509_CERT_AUX *aux, int
indent)
+ } else
+ BIO_printf(out, "%*sNo Rejected Uses.\n", indent, "");
+ if (aux->alias)
+-BIO_printf(out, "%*sAlias: %s\n", indent, "", aux->alias->data);
++BIO_printf(out, "%*sAlias: %.*s\n", indent, "", aux->alias->length,
++ aux->alias->data);
+ if (aux->keyid) {
+ BIO_printf(out, "%*sKey Id: ", indent, "");
+ for (i = 0; i < aux->keyid->length; i++)
[Libreoffice-bugs] [Bug 144084] FilePicker service does not display Open and Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=144084 --- Comment #2 from Uwe Auer --- Repro on Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded => seems to be related to GTK3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143947] Function DATE yields wrong year if input is only "year"
https://bugs.documentfoundation.org/show_bug.cgi?id=143947 Eike Rathke changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143947] Function DATE yields wrong year if input is only "year"
https://bugs.documentfoundation.org/show_bug.cgi?id=143947 Eike Rathke changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #8 from Eike Rathke --- According to comment 2 Excel yields the same result for DATE(2006;;) (or DATE(2006,,) depending on function parameter separator), so nothing to change here. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source writerfilter/source
sw/inc/unotextbodyhf.hxx |
2
sw/inc/unotextrange.hxx |
3
sw/qa/extras/ooxmlexport/data/tdf143384_tableInFoot_negativeMargins.docx
|binary
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx |
7 +
sw/source/core/unocore/unoframe.cxx |
8 +
sw/source/core/unocore/unoobj2.cxx |
15 ++
sw/source/core/unocore/unotext.cxx |
56 +++---
writerfilter/source/dmapper/DomainMapper_Impl.cxx|
8 +
writerfilter/source/dmapper/PropertyIds.cxx |
1
writerfilter/source/dmapper/PropertyIds.hxx |
1
10 files changed, 83 insertions(+), 18 deletions(-)
New commits:
commit c1ad429d925855c1baacbdeca1ef42f4486eb9c2
Author: Attila Szűcs
AuthorDate: Tue Jul 27 11:45:58 2021 +0200
Commit: László Németh
CommitDate: Wed Aug 25 13:45:23 2021 +0200
tdf#143384 DOCX import: fix SAXException at header with table
Regression from commit d656191ec308d4280b93c7169372e543a255d108
"tdf#119952 DOCX import: fix negative page margins".
Add SwXHeadFootText::CreateTextCursor(bool bIgnoreTables = false)
(modeled after SwXBodyText::CreateTextCursor) to create text cursor
for copying the header/footer also started with table during
fly frame creation in convertoToTextFrame().
Note: add hidden property PROP_CURSOR_NOT_IGNORE_TABLES_IN_HF
to use the new feature in domainmapper (followed
commit af4e5ee0f93c1ff442d08caed5c875f2b2c1fd43
"tdf#97128 DOCX import: fix frame direction").
Co-authored-by: Tibor Nagy (NISZ)
Change-Id: I96e2cf2dddcecd146c53c12d7fdb44fc4d90fa0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119549
Tested-by: László Németh
Reviewed-by: László Németh
diff --git a/sw/inc/unotextbodyhf.hxx b/sw/inc/unotextbodyhf.hxx
index fbccc982ef04..99887c6beb5c 100644
--- a/sw/inc/unotextbodyhf.hxx
+++ b/sw/inc/unotextbodyhf.hxx
@@ -115,6 +115,8 @@ public:
static css::uno::Reference< css::text::XText >
CreateXHeadFootText(SwFrameFormat & rHeadFootFormat, const bool
bIsHeader);
+css::uno::Reference CreateTextCursor(const bool
bIgnoreTables = false);
+
// XInterface
virtual css::uno::Any SAL_CALL queryInterface(
const css::uno::Type& rType) override;
diff --git a/sw/inc/unotextrange.hxx b/sw/inc/unotextrange.hxx
index f3ed06fb4a06..4d8ed2df2c06 100644
--- a/sw/inc/unotextrange.hxx
+++ b/sw/inc/unotextrange.hxx
@@ -57,7 +57,8 @@ namespace sw {
enum class TextRangeMode {
RequireTextNode,
-AllowNonTextNode
+AllowNonTextNode,
+AllowTableNode
};
void DeepCopyPaM(SwPaM const & rSource, SwPaM & rTarget);
diff --git
a/sw/qa/extras/ooxmlexport/data/tdf143384_tableInFoot_negativeMargins.docx
b/sw/qa/extras/ooxmlexport/data/tdf143384_tableInFoot_negativeMargins.docx
new file mode 100644
index ..918c1029fb4a
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf143384_tableInFoot_negativeMargins.docx
differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index de3eea4c0659..08e0cbd9f8f7 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -1618,6 +1618,13 @@ DECLARE_OOXMLEXPORT_TEST(testTdf119952_negativeMargins,
"tdf119952_negativeMargi
CPPUNIT_ASSERT_EQUAL(OUString(" "),
parseDump("/root/page[3]/header/txt/anchored/fly"));
}
+DECLARE_OOXMLEXPORT_TEST(testTdf143384_tableInFoot_negativeMargins,
"tdf143384_tableInFoot_negativeMargins.docx")
+{
+// There should be no crash during loading of the document
+// so, let's check just how much pages we have
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/unocore/unoframe.cxx
b/sw/source/core/unocore/unoframe.cxx
index 74d366d9961d..8b9250671d78 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1418,7 +1418,13 @@ void SwXFrame::setPropertyValue(const OUString&
rPropertyName, const ::uno::Any&
const ::SfxItemPropertyMapEntry* pEntry =
m_pPropSet->getPropertyMap().getByName(rPropertyName);
if (!pEntry)
-throw beans::UnknownPropertyException( "Unknown property: " +
rPropertyName, static_cast < cppu::OWeakObject * > ( this ) );
+{
+// Hack to skip the dummy CursorNotIgnoreTables property
+if (rPropertyName == "CursorNotIgnoreTables")
+return;
+else
+throw beans::UnknownPropertyException("Unknown property: " +
rPropertyName, static_cast (this));
+}
[Libreoffice-bugs] [Bug 125739] Bullets and Numbering's Linked graphics no longer links to the external file, embeds it into odt instead
https://bugs.documentfoundation.org/show_bug.cgi?id=125739 Miklos Vajna changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |vmik...@collabora.com |desktop.org | Status|NEW |ASSIGNED --- Comment #2 from Miklos Vajna --- Let me see, perhaps this is similar to bug 142436. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144084] FilePicker service does not display Open and Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=144084 --- Comment #1 from Uwe Auer --- No repro Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137737] REPLACE not working if there is a footnote or endnote anchor at end of paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=137737 --- Comment #10 from R. Green --- Ah. I missed that. I'll retest when the updated AppImage is released. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143929] FILESAVE ODS Two column shape setting not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=143929 Mike Kaganski changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #6 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/120958 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137737] REPLACE not working if there is a footnote or endnote anchor at end of paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=137737 --- Comment #9 from Buovjaga --- (In reply to R. Green from comment #8) > Version: 7.3.0.0.alpha0+ / LibreOffice Community > Build ID: 008f28c9e01114e731f785e9e238236a1ed069d2 > CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 > Locale: en-GB (en_GB.UTF-8); UI: en-US > TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: > 2021-08-22_15:17:36 > Calc: threaded > > I have repeated the test described in my opening post and the result is > still the same;the selection moves to the next instance without replacing > anything. So not fixed. That is because you are testing with a build from 22 Aug while the fix was committed today. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137737] REPLACE not working if there is a footnote or endnote anchor at end of paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=137737 --- Comment #8 from R. Green --- Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 008f28c9e01114e731f785e9e238236a1ed069d2 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-22_15:17:36 Calc: threaded I have repeated the test described in my opening post and the result is still the same;the selection moves to the next instance without replacing anything. So not fixed. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144028] error strings in installation wizard still needed or not?
https://bugs.documentfoundation.org/show_bug.cgi?id=144028 sophie changed: What|Removed |Added CC||so...@libreoffice.org --- Comment #4 from sophie --- (In reply to Mike Kaganski from comment #2) > I do not see a harm in its existence, and maybe it just needs a notice that > it needs no translation. > Thanks Mike for your explanations, so in that case, it should be removed from translation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144084] New: FilePicker service does not display Open and Cancel button
https://bugs.documentfoundation.org/show_bug.cgi?id=144084
Bug ID: 144084
Summary: FilePicker service does not display Open and Cancel
button
Product: LibreOffice
Version: 7.2.0.4 release
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: BASIC
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: ddora...@dmaths.org
Description:
When I try too select a file, the Open and Cancel button do not appear.
I run a Linux Ubuntu.
Steps to Reproduce:
Try to select a file with the following code :
Option Explicit
Sub OuvrirUnFichier()
Dim FP As Object, lesFichiers() As String
FP = CreateUnoService("com.sun.star.ui.dialogs.FilePicker")
FP.DisplayDirectory = ConvertToURL("/home/didier/")
FP.appendFilter("Textes", "*.txt")
FP.appendFilter("Documents ODF", "*.odt;*.ods;*.odg,*.odp")
FP.appendFilter("Documents MS-Office", "*.doc;*.xls;*.ppt")
FP.CurrentFilter = "Documents ODF"
FP.Title = "Choisissez le fichier à traiter"
if FP.execute = com.sun.star.ui.dialogs.ExecutableDialogResults.OK then
lesFichiers() = FP.Files
MsgBox(FP.CurrentFilter, 0, "Filtre choisi")
MsgBox(FP.DisplayDirectory, 0, "Répertoire")
MsgBox(lesFichiers(0), 0, "Chemin complet")
end if
FP.dispose
End Sub
Actual Results:
Can't select the chosen file ...
It's a regression ...
Expected Results:
To be able to select the file ..
Reproducible: Always
User Profile Reset: No
Additional Info:
Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144028] error strings in installation wizard still needed or not?
https://bugs.documentfoundation.org/show_bug.cgi?id=144028 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG --- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> --- Let's close it then as NAB -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144083] FILEOPEN- FILESAVE: Freeze when importing txt files
https://bugs.documentfoundation.org/show_bug.cgi?id=144083 nouvo09 changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||zika...@yahoo.com Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144083] New: FILEOPEN- FILESAVE: Freeze when importing txt files
https://bugs.documentfoundation.org/show_bug.cgi?id=144083 Bug ID: 144083 Summary: FILEOPEN- FILESAVE: Freeze when importing txt files Product: LibreOffice Version: 7.2.0.4 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zika...@yahoo.com Calc often freezes the X server when importing txt or csv files. This bug appears since 7.xx version: I can open one or two or three small txt files without any issue and then when opening one more, the import window freezes the X server and I have to restart X. This behavior never happened before with the 6.xx version for years. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144066] Tangent function is returning a number to the order of 10^16 for PI/2
https://bugs.documentfoundation.org/show_bug.cgi?id=144066 --- Comment #2 from Uwe Auer --- (In reply to John R Sohn from comment #0) > Description: > the tangent function =tan(radians) is returning a value way out of range. > Expected Results: > 0.027422438 Your expectation is based on TAN(A1*PI()/180), which is converting a value, which is already in radians (rad), once more into radians. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - external/openssl
external/openssl/UnpackedTarball_openssl.mk |1
external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 | 56
++
2 files changed, 57 insertions(+)
New commits:
commit 3ab444202163700198d3b5435ed79bd77e34ee47
Author: Michael Stahl
AuthorDate: Wed Aug 25 11:32:11 2021 +0200
Commit: Thorsten Behrens
CommitDate: Wed Aug 25 12:38:10 2021 +0200
openssl: add patch for CVE-2021-3712
Change-Id: I4061cbac18ddf9c7f932a27bf2b54a2b1c2f9d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121027
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/external/openssl/UnpackedTarball_openssl.mk
b/external/openssl/UnpackedTarball_openssl.mk
index ad600cce1412..e7fca1116545 100644
--- a/external/openssl/UnpackedTarball_openssl.mk
+++ b/external/openssl/UnpackedTarball_openssl.mk
@@ -22,6 +22,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,openssl,\
external/openssl/openssl-3650-masm.patch.1 \
external/openssl/openssl-fixbuild.patch.1 \
external/openssl/openssl-1.0.2k-cve-2020-1971.patch.1 \
+ external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
new file mode 100644
index ..cf809750ecfb
--- /dev/null
+++ b/external/openssl/ccb0a11145ee72b042d10593a64eaf9e8a55ec12.patch.1
@@ -0,0 +1,56 @@
+From ccb0a11145ee72b042d10593a64eaf9e8a55ec12 Mon Sep 17 00:00:00 2001
+From: Matt Caswell
+Date: Tue, 17 Aug 2021 14:41:48 +0100
+Subject: [PATCH] Fix a read buffer overrun in X509_CERT_AUX_print()
+
+This is a backport of commit c5dc9ab965f to 1.0.2. That commit fixed
+the same bug but in master/1.1.1 it is in the function X509_aux_print().
+The original commit had the following description:
+
+Fix a read buffer overrun in X509_aux_print().
+
+The ASN1_STRING_get0_data(3) manual explitely cautions the reader
+that the data is not necessarily NUL-terminated, and the function
+X509_alias_set1(3) does not sanitize the data passed into it in any
+way either, so we must assume the return value from X509_alias_get0(3)
+is merely a byte array and not necessarily a string in the sense
+of the C language.
+
+I found this bug while writing manual pages for X509_print_ex(3)
+and related functions. Theo Buehler checked my
+patch to fix the same bug in LibreSSL, see
+
+http://cvsweb.openbsd.org/src/lib/libcrypto/asn1/t_x509a.c#rev1.9
+
+As an aside, note that the function still produces incomplete and
+misleading results when the data contains a NUL byte in the middle
+and that error handling is consistently absent throughout, even
+though the function provides an "int" return value obviously intended
+to be 1 for success and 0 for failure, and even though this function
+is called by another function that also wants to return 1 for success
+and 0 for failure and even does so in many of its code paths, though
+not in others. But let's stay focussed. Many things would be nice
+to have in the wide wild world, but a buffer overflow must not be
+allowed to remain in our backyard.
+
+CVE-2021-3712
+
+Reviewed-by: Paul Dale
+---
+ crypto/asn1/t_x509a.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/crypto/asn1/t_x509a.c b/crypto/asn1/t_x509a.c
+index d1b897a469fd..b1bc9d0cd28b 100644
+--- a/crypto/asn1/t_x509a.c
b/crypto/asn1/t_x509a.c
+@@ -104,7 +104,8 @@ int X509_CERT_AUX_print(BIO *out, X509_CERT_AUX *aux, int
indent)
+ } else
+ BIO_printf(out, "%*sNo Rejected Uses.\n", indent, "");
+ if (aux->alias)
+-BIO_printf(out, "%*sAlias: %s\n", indent, "", aux->alias->data);
++BIO_printf(out, "%*sAlias: %.*s\n", indent, "", aux->alias->length,
++ aux->alias->data);
+ if (aux->keyid) {
+ BIO_printf(out, "%*sKey Id: ", indent, "");
+ for (i = 0; i < aux->keyid->length; i++)
[Libreoffice-bugs] [Bug 134607] LO7RC1 - LANGPACK macOS language pack fails to recognize LibreOffice 7 installation as valid on Catalina and Big Sur
https://bugs.documentfoundation.org/show_bug.cgi?id=134607 --- Comment #99 from steve --- After discussing with cloph the remaining problem of mdls reporting no info or null value is a bug in macOS. That aspect can only be fixed on Apples side. Feel free to report the problem to Apple using macOS Feeback Assistant to make them aware of the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113108] [META] Dialog UI/UX bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113108 Bug 113108 depends on bug 120591, which changed state. Bug 120591 Summary: Add button to load or refresh the table and ranges in the external data dialog https://bugs.documentfoundation.org/show_bug.cgi?id=120591 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114994] Sheet -> Link to External Data doesn't have button to load the URL
https://bugs.documentfoundation.org/show_bug.cgi?id=114994 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #18 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 120591 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120591] Add button to load or refresh the table and ranges in the external data dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120591 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 114994 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113136] [META] Find & Replace Dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=113136 Bug 113136 depends on bug 100480, which changed state. Bug 100480 Summary: Improve the description of the "Match case" check box in the Find and Replace dialog https://bugs.documentfoundation.org/show_bug.cgi?id=100480 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139527] Keyboard shortcuts for spelling suggestions
https://bugs.documentfoundation.org/show_bug.cgi?id=139527 --- Comment #5 from Jordi --- (In reply to Jean-Baptiste Faure from comment #1) > Under Ubuntu with vclplugin GTK3, I have shortcuts for spelling suggestions. > I need only to hit Alt key to see the shortcuts which appear as an > underlined character in each suggestion. [snip] > Best regards. JBF Jean, I fired up my Ubuntu 21 and installed the default deb packages. I can see GTK3 integration is working, but I don't get shortcuts for the suggestions when I press ALT. Can you give me your OS/LO versions and packages installed (including source)? My Libreoffice was 7.1.5 Thanks. J. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137737] REPLACE not working if there is a footnote or endnote anchor at end of paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=137737 --- Comment #7 from Buovjaga --- Verified, thanks Arch Linux 64-bit Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c6883e7a031dec5fe3a365c4fd6adccff09696e5 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 25 August 2021 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=91874 Adolfo Jayme changed: What|Removed |Added Depends on||143817 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143817 [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143817] Search Commands deleting contents in Writer when command applied to selected text
https://bugs.documentfoundation.org/show_bug.cgi?id=143817 Adolfo Jayme changed: What|Removed |Added Blocks||91874 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=91874 [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144018] Character transparency is reset to 0% when set to 100%
https://bugs.documentfoundation.org/show_bug.cgi?id=144018 --- Comment #5 from Miklos Vajna --- Thanks, that would be indeed nice to fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144021] Character transparency should apply to objects anchored as character
https://bugs.documentfoundation.org/show_bug.cgi?id=144021 --- Comment #2 from Mike Kaganski --- Attachment 174530 from bug 144018 has 60% transparency over the image (and adjacent characters) in the last paragraph, which shows that Word doesn't have the proposed feature :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144018] Character transparency is reset to 0% when set to 100%
https://bugs.documentfoundation.org/show_bug.cgi?id=144018 --- Comment #4 from Mike Kaganski --- Created attachment 174530 --> https://bugs.documentfoundation.org/attachment.cgi?id=174530=edit Some transparency in text Word behaves as expected for transparency 100%. The attachment has "psu" in the first paragraph set to 100% transparency, which is blank in Word, and is not transparent in Writer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143956] Writer Templates are in Format Size A4 instead of Letter for Default - English (USA)
https://bugs.documentfoundation.org/show_bug.cgi?id=143956 Laurent BP changed: What|Removed |Added CC||jumbo4...@yahoo.fr --- Comment #3 from Laurent BP --- Page size of bundled templates are defined in XML code of each template: - CV: https://opengrok.libreoffice.org/xref/core/extras/source/templates/personal/CV/styles.xml#145 - Resume: https://opengrok.libreoffice.org/xref/core/extras/source/templates/personal/Resume1page/styles.xml#137 They are not language dependent. One solution would be to create 2 templates per template (one A4, one Letter). So user will see twice more templates as previously (18 instead of 9). Another solution would be to create two "Standard" page styles per template, and user would simply have to change its page style. Content of these templates are outdated, and English only. They may also be removed. Localization of each template would require a important work for l10n teams. To have language dependent templates, something similar to autotext should be done... In the old ages of OOo, it used to have language dependent templates. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 143956] Writer Templates are in Format Size A4 instead of Letter for Default - English (USA)
https://bugs.documentfoundation.org/show_bug.cgi?id=143956 Laurent BP changed: What|Removed |Added CC||jumbo4...@yahoo.fr --- Comment #3 from Laurent BP --- Page size of bundled templates are defined in XML code of each template: - CV: https://opengrok.libreoffice.org/xref/core/extras/source/templates/personal/CV/styles.xml#145 - Resume: https://opengrok.libreoffice.org/xref/core/extras/source/templates/personal/Resume1page/styles.xml#137 They are not language dependent. One solution would be to create 2 templates per template (one A4, one Letter). So user will see twice more templates as previously (18 instead of 9). Another solution would be to create two "Standard" page styles per template, and user would simply have to change its page style. Content of these templates are outdated, and English only. They may also be removed. Localization of each template would require a important work for l10n teams. To have language dependent templates, something similar to autotext should be done... In the old ages of OOo, it used to have language dependent templates. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/definedatabaserangedialog.ui | 189 ++ 1 file changed, 93 insertions(+), 96 deletions(-) New commits: commit a6ec99fd13ac5b60729925257e1e90453c9c Author: Olivier Hallot AuthorDate: Mon Aug 23 15:26:00 2021 -0300 Commit: Olivier Hallot CommitDate: Wed Aug 25 12:01:00 2021 +0200 Bump ui file to latest Glade release Change-Id: I1a22cecbcf193f0617b5490e6d22a8fc6d830158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120917 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui b/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui index 10b883da6194..2339ee21e55a 100644 --- a/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui +++ b/sc/uiconfig/scalc/ui/definedatabaserangedialog.ui @@ -1,5 +1,5 @@ - + @@ -11,33 +11,33 @@ -False +False True True -6 +6 Define Database Range -0 -0 -dialog +0 +0 +dialog -False +False True True vertical 12 -False -end +False +end _OK True -True -True -True -True +True +True +True +True True @@ -55,8 +55,8 @@ _Cancel True -True -True +True +True True @@ -74,8 +74,8 @@ _Help True -True -True +True +True True @@ -89,14 +89,14 @@ False True -end +end 1 True -False +False True True vertical @@ -104,40 +104,40 @@ True -False +False True True -0 -none +0 +none - + True -False -True -True -3 +False 12 6 +True +True +3 True -False +False True True -always -in +always +in True -True +True True True liststore1 -False -False -0 -False +False +False +0 +False @@ -155,16 +155,16 @@ -0 -1 +0 +1 True -True +True True -True +True True @@ -173,8 +173,8 @@ -0 -0 +0 +0 @@ -182,7 +182,7 @@ True -False +False Name @@ -199,24 +199,24 @@ True -False +False True -
[Libreoffice-commits] core.git: sc/uiconfig
sc/uiconfig/scalc/ui/regressiondialog.ui | 313 +++ 1 file changed, 155 insertions(+), 158 deletions(-) New commits: commit b125af5977f41ef0d5ea8673686f2cfae208ed41 Author: Olivier Hallot AuthorDate: Tue Aug 24 20:11:19 2021 -0300 Commit: Olivier Hallot CommitDate: Wed Aug 25 12:00:02 2021 +0200 tdf#118538 (part) bump regressiondialog.ui to latest Glade No change in contents Change-Id: I8b9d08f9560dbc3541df8dc75b4b01a7b5feb95f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120970 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/sc/uiconfig/scalc/ui/regressiondialog.ui b/sc/uiconfig/scalc/ui/regressiondialog.ui index 38771503dc8f..3cd49a7a68b5 100644 --- a/sc/uiconfig/scalc/ui/regressiondialog.ui +++ b/sc/uiconfig/scalc/ui/regressiondialog.ui @@ -1,37 +1,37 @@ - + 1 -0.95 -0.01 -0.1 +0.94996 +0.01 +0.10 -False -6 +False +6 Regression -0 -0 -dialog +0 +0 +dialog -False +False vertical 12 -False -end +False +end _OK True -True -True -True -True +True +True +True +True True @@ -44,9 +44,9 @@ _Cancel True -True -True -True +True +True +True True @@ -59,8 +59,8 @@ _Help True -True -True +True +True True @@ -74,160 +74,160 @@ False True -end +end 0 True -False -0 -none +False +0 +none - + True -False -6 -12 +False 12 +12 6 6 -12 +6 +12 True -False +False Independent variable(s) (X) range: -True -variable1-range-edit +True +variable1-range-edit 0 -0 -0 +0 +0 True -True +True center True -True +True +30 True -30 -1 -0 +1 +0 True -True -True +True +True -2 -0 +2 +0 True -False +False Dependent variable (Y) range: -True -variable2-range-edit +True +variable2-range-edit 0 -0 -1 +0 +1 True -True +True center True -True +True +30 True -30 -1 -1 +1 +1 True -True -
[Libreoffice-bugs] [Bug 144048] Calc: Define Range doesn't set selected range
https://bugs.documentfoundation.org/show_bug.cgi?id=144048 m.a.riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #4 from m.a.riosv --- Ok, I see now, but I'm not sure if it isn't done on purpose. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144021] Character transparency should apply to objects anchored as character
https://bugs.documentfoundation.org/show_bug.cgi?id=144021 --- Comment #1 from Miklos Vajna --- Can you please attach a sample document? It would be useful to also save it as DOCX and see how Word renders it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144018] Character transparency is reset to 0% when set to 100%
https://bugs.documentfoundation.org/show_bug.cgi?id=144018 --- Comment #3 from Miklos Vajna --- Just check what Word does, the intention is that the behavior is consistent with Word. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc vcl/skia
vcl/inc/skia/gdiimpl.hxx | 12 +++---
vcl/inc/skia/osx/gdiimpl.hxx |8 --
vcl/inc/skia/win/gdiimpl.hxx |7 --
vcl/inc/skia/x11/gdiimpl.hxx |5
vcl/skia/gdiimpl.cxx | 37 +--
vcl/skia/osx/gdiimpl.cxx | 50 ++-
vcl/skia/win/gdiimpl.cxx | 22 --
vcl/skia/x11/gdiimpl.cxx | 28
8 files changed, 67 insertions(+), 102 deletions(-)
New commits:
commit 148ac7de372d0af3c3d20a5c94c12ca0b9cfd4ab
Author: Luboš Luňák
AuthorDate: Tue Aug 24 21:32:20 2021 +0200
Commit: Luboš Luňák
CommitDate: Wed Aug 25 11:36:59 2021 +0200
use our own Skia surface when using GPU screen drawing
Previously the code called window context's getBackbufferSurface()
once, and the repeatedly used it for drawing and then did
swapBuffers(). This worked until version chrome/m91, now Skia
requires that a screen drawing pass is calling getBackbufferSurface(),
drawing to it and calling swapBuffers(). Since we do not always
draw full window content and instead keep previous content, use
a separate offscreen surface for that and for actual screen drawing
just blit that to the screen surface.
Change-Id: I36a5b3bb23a085936f4473a0e00d8e04c6b40dab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120966
Tested-by: Luboš Luňák
Reviewed-by: Luboš Luňák
diff --git a/vcl/inc/skia/gdiimpl.hxx b/vcl/inc/skia/gdiimpl.hxx
index a7ba10c3273b..c914c26752cc 100644
--- a/vcl/inc/skia/gdiimpl.hxx
+++ b/vcl/inc/skia/gdiimpl.hxx
@@ -25,13 +25,7 @@
#include
#include
-#include
-#include
-#include
-#include
-
-#include
-#include
+#include
class SkiaFlushIdle;
class GenericSalLayout;
@@ -240,8 +234,8 @@ protected:
virtual bool avoidRecreateByResize() const;
void createWindowSurface(bool forceRaster = false);
virtual void createWindowSurfaceInternal(bool forceRaster = false) = 0;
-virtual void destroyWindowSurfaceInternal() = 0;
void createOffscreenSurface();
+void flushSurfaceToWindowContext(const SkIRect& rect);
void privateDrawAlphaRect(tools::Long nX, tools::Long nY, tools::Long
nWidth,
tools::Long nHeight, double nTransparency, bool
blockAA = false);
@@ -321,6 +315,8 @@ protected:
SalGeometryProvider* mProvider;
// The Skia surface that is target of all the rendering.
sk_sp mSurface;
+// Note that mSurface may be a proxy surface and not the one from the
window context.
+std::unique_ptr mWindowContext;
bool mIsGPU; // whether the surface is GPU-backed
SkIRect mDirtyRect; // the area that has been changed since the last
performFlush()
vcl::Region mClipRegion;
diff --git a/vcl/inc/skia/osx/gdiimpl.hxx b/vcl/inc/skia/osx/gdiimpl.hxx
index b9adccb370ea..4ffac5985edb 100644
--- a/vcl/inc/skia/osx/gdiimpl.hxx
+++ b/vcl/inc/skia/osx/gdiimpl.hxx
@@ -26,9 +26,7 @@ public:
AquaSkiaSalGraphicsImpl(AquaSalGraphics& rParent, AquaSharedAttributes&
rShared);
virtual ~AquaSkiaSalGraphicsImpl() override;
-virtual void DeInit() override;
virtual void freeResources() override;
-//virtual void Flush() override;
virtual void UpdateGeometryProvider(SalGeometryProvider* provider) override
{
@@ -47,13 +45,9 @@ public:
private:
virtual void createWindowSurfaceInternal(bool forceRaster = false)
override;
-virtual void destroyWindowSurfaceInternal() override;
virtual void performFlush() override;
-void flushToScreenRaster(const SkIRect& rect);
-void flushToScreenMetal(const SkIRect& rect);
+void flushSurfaceToScreenCG(const SkIRect& rect);
static inline sk_sp fontManager;
-// This one is used only for Metal, and only indirectly.
-std::unique_ptr mWindowContext;
};
#endif // INCLUDED_VCL_INC_SKIA_OSX_GDIIMPL_HXX
diff --git a/vcl/inc/skia/win/gdiimpl.hxx b/vcl/inc/skia/win/gdiimpl.hxx
index 2f85a9e3cf66..7e3f37ce435c 100644
--- a/vcl/inc/skia/win/gdiimpl.hxx
+++ b/vcl/inc/skia/win/gdiimpl.hxx
@@ -43,10 +43,6 @@ private:
public:
WinSkiaSalGraphicsImpl(WinSalGraphics& rGraphics, SalGeometryProvider*
mpProvider);
-virtual ~WinSkiaSalGraphicsImpl() override;
-
-virtual void DeInit() override;
-virtual void freeResources() override;
virtual bool UseRenderNativeControl() const override { return true; }
virtual bool TryRenderCachedNativeControl(ControlCacheKey const&
rControlCacheKey, int nX,
@@ -57,13 +53,13 @@ public:
virtual bool DrawTextLayout(const GenericSalLayout& layout) override;
virtual void ClearDevFontCache() override;
+virtual void freeResources() override;
virtual void Flush() override;
static void prepareSkia();
protected:
virtual void createWindowSurfaceInternal(bool forceRaster = false)
override;
-virtual void destroyWindowSurfaceInternal() override;
[Libreoffice-commits] core.git: include/systools
include/systools/win32/comtools.hxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit d5ec688e4b0aa97eed72ed56d53a5d014b59eb63
Author: Luboš Luňák
AuthorDate: Wed Aug 25 08:26:06 2021 +0200
Commit: Luboš Luňák
CommitDate: Wed Aug 25 11:36:36 2021 +0200
use prewin.h/postwin.h around a win32 header
Change-Id: I45051b003defa7e48358abeff3944accf16849a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120995
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/include/systools/win32/comtools.hxx
b/include/systools/win32/comtools.hxx
index 252c581c5794..f6571975c0e7 100644
--- a/include/systools/win32/comtools.hxx
+++ b/include/systools/win32/comtools.hxx
@@ -22,7 +22,9 @@
#include
#include
#include
+#include
#include
+#include
namespace sal::systools
{
[Libreoffice-bugs] [Bug 135164] FILEOPEN DOCX: Heading get bullets (because num with no symbol doesn't block default style's number everything?)
https://bugs.documentfoundation.org/show_bug.cgi?id=135164 --- Comment #24 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/824a46920348451a483dd195bb6ca651cf1d4f4c tdf#135164 add unit test It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135164] FILEOPEN DOCX: Heading get bullets (because num with no symbol doesn't block default style's number everything?)
https://bugs.documentfoundation.org/show_bug.cgi?id=135164 Commit Notification changed: What|Removed |Added Whiteboard||target:7.2.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - solenv/clang-format sw/CppunitTest_sw_ooxmlexport17.mk sw/Module_sw.mk sw/qa
solenv/clang-format/excludelist |1
sw/CppunitTest_sw_ooxmlexport17.mk | 14 ++
sw/Module_sw.mk |1
sw/qa/extras/ooxmlexport/data/tdf135164_cancelledNumbering.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport17.cxx | 47
++
5 files changed, 63 insertions(+)
New commits:
commit 824a46920348451a483dd195bb6ca651cf1d4f4c
Author: Justin Luth
AuthorDate: Wed Aug 25 08:39:33 2021 +0200
Commit: Xisco Fauli
CommitDate: Wed Aug 25 11:33:43 2021 +0200
tdf#135164 add unit test
fixed by tdf#143605, but that was a bit different,
so adding a specific docx unit test.
Change-Id: I9f5a6b225277f1c1fdbfed7759919b3fd6e5dea5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121010
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 13a5f25ac5ff..6d6605c30c3a 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -12320,6 +12320,7 @@ sw/qa/extras/ooxmlexport/ooxmlexport13.cxx
sw/qa/extras/ooxmlexport/ooxmlexport14.cxx
sw/qa/extras/ooxmlexport/ooxmlexport15.cxx
sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
+sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
sw/qa/extras/ooxmlexport/ooxmlexport2.cxx
sw/qa/extras/ooxmlexport/ooxmlexport3.cxx
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
diff --git a/sw/CppunitTest_sw_ooxmlexport17.mk
b/sw/CppunitTest_sw_ooxmlexport17.mk
new file mode 100644
index ..80316e1c0ca4
--- /dev/null
+++ b/sw/CppunitTest_sw_ooxmlexport17.mk
@@ -0,0 +1,14 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call sw_ooxmlexport_test,17))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index f4530e2a139d..3f200348d0a3 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -88,6 +88,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\
CppunitTest_sw_ooxmlexport14 \
CppunitTest_sw_ooxmlexport15 \
CppunitTest_sw_ooxmlexport16 \
+CppunitTest_sw_ooxmlexport17 \
CppunitTest_sw_ooxmlexport_template \
CppunitTest_sw_ooxmlfieldexport \
CppunitTest_sw_ooxmllinks \
diff --git a/sw/qa/extras/ooxmlexport/data/tdf135164_cancelledNumbering.docx
b/sw/qa/extras/ooxmlexport/data/tdf135164_cancelledNumbering.docx
new file mode 100755
index ..47008b69d98f
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf135164_cancelledNumbering.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
new file mode 100644
index ..4eb9d0d6aa1b
--- /dev/null
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -0,0 +1,47 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+
+#include
+
+#include
+
+constexpr OUStringLiteral DATA_DIRECTORY = u"/sw/qa/extras/ooxmlexport/data/";
+
+class Test : public SwModelTestBase
+{
+public:
+Test() : SwModelTestBase(DATA_DIRECTORY, "Office Open XML Text") {}
+
+protected:
+/**
+ * Denylist handling
+ */
+bool mustTestImportOf(const char* filename) const override {
+// If the testcase is stored in some other format, it's pointless to
test.
+return OString(filename).endsWith(".docx");
+}
+};
+
+DECLARE_OOXMLEXPORT_TEST(testTdf135164_cancelledNumbering,
"tdf135164_cancelledNumbering.docx")
+{
+uno::Reference xPara(getParagraph(1, u"TBMM DÖNEMİ"),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(""), getProperty(xPara,
"ListLabelString"));
+
+xPara.set(getParagraph(2, "Numbering explicitly cancelled"),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString(""), getProperty(xPara,
"ListLabelString"));
+
+xPara.set(getParagraph(6, "Default style has roman numbering"),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("i"), getProperty(xPara,
"ListLabelString"));
+}
+
+CPPUNIT_PLUGIN_IMPLEMENT();
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit e73b2a8ff50829cbecb29b03aa513de5248aa8cc
Author: Caolán McNamara
AuthorDate: Mon Aug 23 21:12:46 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 25 11:32:36 2021 +0200
lcl_translateTwips only needs OutputDevices
Change-Id: I2c1536f062557f598aee0b0552044a7f41302b07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120948
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/editeng/impedit.cxx
b/editeng/source/editeng/impedit.cxx
index d1b00e478560..27d3f979655e 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -279,7 +279,7 @@ void ImpEditView::SetEditSelection( const EditSelection&
rEditSelection )
}
/// Translate absolute <-> relative twips: LOK wants absolute coordinates as
output and gives absolute coordinates as input.
-static void lcl_translateTwips(vcl::Window const & rParent, vcl::Window&
rChild)
+static void lcl_translateTwips(const OutputDevice& rParent, OutputDevice&
rChild)
{
// Don't translate if we already have a non-zero origin.
// This prevents multiple translate calls that negate
@@ -367,7 +367,7 @@ void ImpEditView::lokSelectionCallback(const
std::optional &
if (parent)
{
-lcl_translateTwips(*parent, *pOutWin);
+lcl_translateTwips(*parent->GetOutDev(),
*pOutWin->GetOutDev());
}
}
[Libreoffice-bugs] [Bug 75644] Better options to control LibO window resize of the Start Screen and last used window size of each document module (summary in comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=75644 --- Comment #48 from Colin --- Unsure of the current status (or interest in a solution) but I would be inclined to define it as a major presentation failure of LO. I have numerous files with different display characteristics. These characteristics are related to the areas of the spreadsheet that I need to be generally visible when the file is opened. I also have multiple monitors with the desktop "extended". I often have multiple files active with their own allocated "real estate". I am also aware that I can group columns and rows and hide "less pertinent" data as I, THE USER, DECIDE. I regularly access information from the internet which is often offered in eXcel format and set with the default - open "with Libre Office". If I'm being kind, I would identify re-opening all the files on a subsequent occasion as "Shambolic". Viewing prior comments where presumably non-users are defining the issue as unworthy of attention, prompts a far more caustic definition. Once we lose sight of what the user wants, we end up with a camel. I appreciate that all the effort is voluntary - even the users are volunteers. If you kill off all the "guinea pigs" the project is only worth abandoning. Would anybody disagree? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144053] Installation of German Language Pack for Version 7.x fails on OSX High Sierra
https://bugs.documentfoundation.org/show_bug.cgi?id=144053 Uwe Auer changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Uwe Auer --- (In reply to mwilde from comment #0) > 6. select the previously installed "LibreOffice.app" This step makes me ask: Do you have different installations / multiple versions of LibreOffice installed? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139527] Keyboard shortcuts for spelling suggestions
https://bugs.documentfoundation.org/show_bug.cgi?id=139527 --- Comment #4 from Jordi --- (In reply to Jean-Baptiste Faure from comment #3) > (In reply to Jordi from comment #2) > > [...] > > Regarding the difficulty you mention, why do I need a numeric keypad? Every > > standard keyboard comes with a row of numbers across the top. > > Indeed, but on azerty keyboards, you have to press the Shift key to produce > numbers with the top row. It does not work for shortcuts. > > Best regards. JBF Interesting. I wasn't aware of this layout. In any case, every other major layout has numbers on the top. Even for azerty users, I don't how it is a problem. It would still be quicker and more efficient than having to move to the arrow keys or the mouse to make a selection. Besides, I don't think it makes sense to ignore this simple but very useful feature request because it is not as efficient for a minority of users. Over and out. J. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144082] New: Stylist: Make styles family selection a dropdown (and remove the CS)
https://bugs.documentfoundation.org/show_bug.cgi?id=144082 Bug ID: 144082 Summary: Stylist: Make styles family selection a dropdown (and remove the CS) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: heiko.tie...@documentfoundation.org CC: anshukhar...@gmail.com, mikekagan...@hotmail.com, qui...@gmail.com We should clean up the family selection (icon-only buttons at the deck header) and remove CS since it's now in the text styles. But to educate users of this selection I suggest to make it a dropdown, which also improves a11y. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144081] New: Stylist: CS filter moves below canvas on resizing via the splitter (only gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144081 Bug ID: 144081 Summary: Stylist: CS filter moves below canvas on resizing via the splitter (only gtk3) Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: heiko.tie...@documentfoundation.org CC: anshukhar...@gmail.com, mikekagan...@hotmail.com, qui...@gmail.com For some reason Gtk3 has a minimum size for lists of 6 items or so. That makes the whole CS frame including the filter disappear before the list when I resize via the GtkPaned splitter. It's not a problem with gen/kf5 (no idea about win/macos). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144080] New: Stylist: Fill-mode button reverts to the actual PS in new Text Styles view
https://bugs.documentfoundation.org/show_bug.cgi?id=144080 Bug ID: 144080 Summary: Stylist: Fill-mode button reverts to the actual PS in new Text Styles view Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: heiko.tie...@documentfoundation.org CC: anshukhar...@gmail.com, mikekagan...@hotmail.com, qui...@gmail.com Clicking the fill mode button reverts to the current selection so I cannot pick another PS and apply at various paragraphs. We may ignore this issue until the context menu solution (CS don't have fill mode anymore), see bug 144079. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144079] New: Stylist: New Text Styles view misses interactions for CS
https://bugs.documentfoundation.org/show_bug.cgi?id=144079 Bug ID: 144079 Summary: Stylist: New Text Styles view misses interactions for CS Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: heiko.tie...@documentfoundation.org CC: anshukhar...@gmail.com, mikekagan...@hotmail.com, qui...@gmail.com We have some functions in the header area of the PS: fill mode, new from selection/template etc. After moving the CS list into a shared Text Styles view we don't have these controls for CS. I suggest to make all available in a context menu (which also cleans up the header). It's a bit ugly since we select a style per right click and showing then "new from selection" might read as this style will be overwritten. But the alternative to duplicate the header is worse. Could also imagine to kill the fill-mode and to have submenus in the hamburger for PS and CS. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: officecfg/registry
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu| 2 +- officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu | 8 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu | 8 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) New commits: commit 4ff568e9ec56ef3cefd9265459fa9fe979d3cdcc Author: Gabor Kelemen AuthorDate: Wed Aug 25 08:22:31 2021 +0200 Commit: Gabor Kelemen CommitDate: Wed Aug 25 11:11:44 2021 +0200 tdf#144029 Add user friendly names for UNO commands opening decks Added in tdf#84502 these commands show up in the Customize dialogs Keyboard tab so give them more descriptive names matching the deck they open Change-Id: I1fd9725e8e5fe9d97a4f33f175bf5e505b9ff211 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120994 Reviewed-by: Heiko Tietze Tested-by: Jenkins diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu index 10b6f370984a..d41df29586fd 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu @@ -2903,7 +2903,7 @@ - ScFunctionsDeck + Open the Functions Deck diff --git a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu index 7dbef3ceb655..1d73e546fcb9 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/DrawImpressCommands.xcu @@ -2534,22 +2534,22 @@ - ShapesDeck + Open the Shapes Deck - SdSlideTransitionDeck + Open the Slide Transition Deck - SdCustomAnimationDeck + Open the Custom Animation Deck - SdMasterPagesDeck + Open the Master Slides Deck diff --git a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu index 7015b06c306e..5edc952c9bdd 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu @@ -7380,22 +7380,22 @@ bit 3 (0x8): #define UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8 - PropertyDeck + Open the Properties Deck - StyleListDeck + Open the Styles Deck - GalleryDeck + Open the Gallery Deck - NavigatorDeck + Open the Navigator Deck diff --git a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu index fff26dd6a4fc..f67dc96ff9b4 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu @@ -3829,12 +3829,12 @@ - WriterPageDeck + Open the Page Deck - InspectorDeck + Open the Style Inspector Deck
[Libreoffice-bugs] [Bug 144076] libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 Xisco Faulí changed: What|Removed |Added Component|Calc|Documentation Resolution|--- |INVALID Status|NEEDINFO|RESOLVED CC||olivier.hallot@libreoffice. ||org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144053] Installation of German Language Pack for Version 7.x fails on OSX High Sierra
https://bugs.documentfoundation.org/show_bug.cgi?id=144053 --- Comment #1 from Uwe Auer --- Can't repro Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 4; OS: Mac OS X 10.13.6; UI render: default; VCL: osx Locale: en-US (de_DE.UTF-8); UI: de-DE Calc: threaded (regardless of Finder preference "Show all filename extension" is set to "on" or "off") See also bug report tdf#143601 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144076] libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 --- Comment #5 from RAJAGOPALAN --- LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144076] libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 --- Comment #4 from RAJAGOPALAN --- LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144076] libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 --- Comment #3 from RAJAGOPALAN --- Created attachment 174529 --> https://bugs.documentfoundation.org/attachment.cgi?id=174529=edit bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144077] New: Calc Full screen Zoom [CTRL]+[SHFT]+[J] corrupts the default background shading button
https://bugs.documentfoundation.org/show_bug.cgi?id=144077 Bug ID: 144077 Summary: Calc Full screen Zoom [CTRL]+[SHFT]+[J] corrupts the default background shading button Product: LibreOffice Version: 7.0.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: The cell shading button normally retains the last used background colour. If a new colour is applied to a cell then this button indication changes to present the latest colour. If the screen is expanded either by [CTRL]+[SHFT]+[J] or View>Full Screen and then reverted to the previous screen zoom characteristics [CTRL]+[SHFT]+[J] the colour display also reverts to the opening "default" colour - yellow in my case but I'm not sure even if this a user parameter. Steps to Reproduce: Highlight a cell with the default colour of the highlight button Observe the colour of the button Highlight a different cell with a new selection from the highlight button Observe the colour of the button Full screen zoom either [CTRL]+[SHFT]+[J] or View>Full Screen Revert to normal view [CTRL]+[SHFT]+[J] Observe that the colour in the button has reverted to the initial default colour Actual Results: Button presentation loses its integrity Expected Results: Button colour should retain its pre-zoom state Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.0.6.2 (x64) Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144076] libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 Xisco Faulí changed: What|Removed |Added Status|NEW |NEEDINFO CC||xiscofa...@libreoffice.org --- Comment #2 from Xisco Faulí --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137737] REPLACE not working if there is a footnote or endnote anchor at end of paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=137737 --- Comment #6 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/42a62ab46af52fae0592150ffe5e9ce8b39314b5 tdf#137737 i18n search: don't expand start/end with regex ^ or $ It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137737] REPLACE not working if there is a footnote or endnote anchor at end of paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=137737 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.2.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143119] Writer and Calc (v7.1.4 and v7.2.0) crash when copying content (cmd-C or menu) on macOS if Tamil UI installed
https://bugs.documentfoundation.org/show_bug.cgi?id=143119 steve changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #7 from steve --- Please reset your user profile: https://wiki.documentfoundation.org/UserProfile#Resolving_corruption and see if the problem then persists. Which version of macOS are you using? macOS crash logs are found in console app https://support.apple.com/en-en/guide/console/cnsl664be99a/mac please provide such a crash log. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - i18npool/source sw/qa
i18npool/source/search/textsearch.cxx |4 +-
sw/qa/extras/uiwriter/data/tdf137737_FindReplace.docx |binary
sw/qa/extras/uiwriter/uiwriter2.cxx | 32 ++
3 files changed, 34 insertions(+), 2 deletions(-)
New commits:
commit 42a62ab46af52fae0592150ffe5e9ce8b39314b5
Author: Justin Luth
AuthorDate: Thu Aug 12 21:29:42 2021 +0200
Commit: Xisco Fauli
CommitDate: Wed Aug 25 10:51:23 2021 +0200
tdf#137737 i18n search: don't expand start/end with regex ^ or $
If the regex starts with ^, that means that it
matches only at the beginning of the content.
So don't expand the beginning of the content
or else it won't match anymore.
Similarly, $ indicates matching at the end of the content.
For the unit test I just randomly guessed at SearchItem.AlgorithmType,
and it kinda worked. I love black boxes...
I hope I remember what i learned about TransformParameters()
which was parsed in sfx2/source/appl/appuno.cxx,
splitting the "variable" into Item.PropName = PropValue.
That is definite black magic.
Change-Id: Ie1640821a7a430e78dbe72c57a92aeaa9b5272a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120410
Tested-by: Jenkins
Reviewed-by: Justin Luth
(cherry picked from commit a511bffd67a9cebfdc878766581ac08c79d7ff51)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120981
Reviewed-by: Xisco Fauli
diff --git a/i18npool/source/search/textsearch.cxx
b/i18npool/source/search/textsearch.cxx
index dcb31762e6c2..e6ddd93c5be6 100644
--- a/i18npool/source/search/textsearch.cxx
+++ b/i18npool/source/search/textsearch.cxx
@@ -333,7 +333,7 @@ SearchResult TextSearch::searchForward( const OUString&
searchStr, sal_Int32 sta
// apply normal transliteration (1<->1, 1<->0)
sal_Int32 nInStartPos = startPos;
-if (pRegexMatcher && startPos > 0)
+if (pRegexMatcher && startPos > 0 &&
!aSrchPara.searchString.startsWith("^"))
{
// tdf#89665, tdf#75806: An optimization to avoid transliterating
the whole string, yet
// transliterate enough of the leading text to allow sensible
look-behind assertions.
@@ -345,7 +345,7 @@ SearchResult TextSearch::searchForward( const OUString&
searchStr, sal_Int32 sta
nInStartPos -= std::min(nMaxLeadingLen, startPos);
}
sal_Int32 nInEndPos = endPos;
-if (pRegexMatcher && endPos < searchStr.getLength())
+if (pRegexMatcher && endPos < searchStr.getLength() &&
!aSrchPara.searchString.endsWith("$"))
{
// tdf#65038: ditto for look-ahead assertions
const sal_Int32 nMaxTrailingLen =
aSrchPara.searchString.endsWith(")") ? 100 : 3;
diff --git a/sw/qa/extras/uiwriter/data/tdf137737_FindReplace.docx
b/sw/qa/extras/uiwriter/data/tdf137737_FindReplace.docx
new file mode 100644
index ..42914ce3feaa
Binary files /dev/null and
b/sw/qa/extras/uiwriter/data/tdf137737_FindReplace.docx differ
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index c6c205a1d759..b7d4f0242f31 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -46,6 +46,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -3996,6 +3997,37 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf118311)
assertXPath(pXmlDoc, "//page[1]//body/tab", 0);
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf137737_FindReplace)
+{
+createSwDoc(DATA_DIRECTORY, "tdf137737_FindReplace.docx");
+
+// Replace staight quotes with something (opening quotes in real life, but
X is adequate here)
+uno::Sequence
aArgs(comphelper::InitPropertySequence({
+{ "SearchItem.SearchString", uno::makeAny(OUString("^\"")) },
+{ "SearchItem.ReplaceString", uno::makeAny(OUString("X")) },
+{ "SearchItem.Command",
uno::makeAny(static_cast(SvxSearchCmd::REPLACE)) },
+{ "SearchItem.AlgorithmType", uno::makeAny(static_cast(1))
}, //REGEX
+{ "SearchItem.AlgorithmType2", uno::makeAny(static_cast(2))
}, //REGEX
+}));
+// Find the first match.
+dispatchCommand(mxComponent, ".uno:ExecuteSearch", aArgs);
+// Replace the first match.
+dispatchCommand(mxComponent, ".uno:ExecuteSearch", aArgs);
+
+// Replace staight quotes with something (closing quotes in real life)
+aArgs[0].Value <<= OUString("\"$");
+dispatchCommand(mxComponent, ".uno:ExecuteSearch", aArgs);
+dispatchCommand(mxComponent, ".uno:ExecuteSearch", aArgs);
+
+//Finding the searched string via XReplaceable
+uno::Reference xReplace(mxComponent, uno::UNO_QUERY);
+uno::Reference xReplaceDes =
xReplace->createReplaceDescriptor();
+xReplaceDes->setSearchString("\"");
+//There should not be any straight quotes left.
+uno::Reference
xIndex(xReplace->findAll(xReplaceDes));
+
[Libreoffice-bugs] [Bug 144076] libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 RAJAGOPALAN changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from RAJAGOPALAN --- LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144076] New: libre office 7.2 bug
https://bugs.documentfoundation.org/show_bug.cgi?id=144076 Bug ID: 144076 Summary: libre office 7.2 bug Product: LibreOffice Version: 7.2.0.4 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rajagopalan...@gmail.com Description: LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc Steps to Reproduce: LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc Actual Results: LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc Expected Results: LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc Reproducible: Always User Profile Reset: No Additional Info: LIBREOFFICE7.2 BUGS 1)Ranges containing merged cells can only be sorted without formats IN LIBRE OFFICE CALC.2)SOME PROGRAM CANNOT ABLE TO EXPORT DATA IN LIBRE CALC.3)The data could not be loaded completely because the maximum number of columns per sheet was exceeded.4)microsoft office compatibility issue is more. 5) libre office calc cannot open windows macro 6)microsoft vba compability issue with libre calc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64991] RTL: open RTL doc is extremely slow
https://bugs.documentfoundation.org/show_bug.cgi?id=64991 Commit Notification changed: What|Removed |Added Whiteboard|BSA interoperability|BSA interoperability ||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64991] RTL: open RTL doc is extremely slow
https://bugs.documentfoundation.org/show_bug.cgi?id=64991 --- Comment #14 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c6883e7a031dec5fe3a365c4fd6adccff09696e5 tdf#64991 speed up loading large RTL documents It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/core/txtnode/thints.cxx | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
New commits:
commit c6883e7a031dec5fe3a365c4fd6adccff09696e5
Author: Noel Grandin
AuthorDate: Wed Aug 25 09:20:49 2021 +0200
Commit: Noel Grandin
CommitDate: Wed Aug 25 10:47:17 2021 +0200
tdf#64991 speed up loading large RTL documents
takes load time from 3min49 to 2min59 for me
Use std::vector for RsidOnlyAutoFormatFlagMap, we
only add values to the end so it is easy to correctly size
this; and std::vectior is way more cache-dense
Change-Id: Ia607c6a4d80a49a25d487d9ddde5041c166e966c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121009
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/core/txtnode/thints.cxx
b/sw/source/core/txtnode/thints.cxx
index 1b88a49b498d..995d82606dab 100644
--- a/sw/source/core/txtnode/thints.cxx
+++ b/sw/source/core/txtnode/thints.cxx
@@ -2620,7 +2620,7 @@ static MergeResult lcl_Compare_Attributes(
int i, int j,
const std::pair< PortionMap::iterator, PortionMap::iterator >& aRange1,
const std::pair< PortionMap::iterator, PortionMap::iterator >& aRange2,
-std::unordered_map& RsidOnlyAutoFormatFlagMap);
+std::vector& RsidOnlyAutoFormatFlagMap);
bool SwpHints::MergePortions( SwTextNode& rNode )
{
@@ -2632,9 +2632,10 @@ bool SwpHints::MergePortions( SwTextNode& rNode )
bool bRet = false;
PortionMap aPortionMap;
-std::unordered_map RsidOnlyAutoFormatFlagMap;
+std::vector RsidOnlyAutoFormatFlagMap;
+RsidOnlyAutoFormatFlagMap.resize(Count() + 1);
sal_Int32 nLastPorStart = COMPLETE_STRING;
-int nKey = 0;
+sal_Int32 nKey = 0;
// get portions by start position:
for ( size_t i = 0; i < Count(); ++i )
@@ -2784,15 +2785,15 @@ static MergeResult lcl_Compare_Attributes(
int i, int j,
const std::pair< PortionMap::iterator, PortionMap::iterator >& aRange1,
const std::pair< PortionMap::iterator, PortionMap::iterator >& aRange2,
-std::unordered_map& RsidOnlyAutoFormatFlagMap)
+std::vector& RsidOnlyAutoFormatFlagMap)
{
PortionMap::iterator aIter1 = aRange1.first;
PortionMap::iterator aIter2 = aRange2.first;
size_t const nAttributesInPor1 = std::distance(aRange1.first,
aRange1.second);
size_t const nAttributesInPor2 = std::distance(aRange2.first,
aRange2.second);
-bool const isRsidOnlyAutoFormat1(RsidOnlyAutoFormatFlagMap[i]);
-bool const isRsidOnlyAutoFormat2(RsidOnlyAutoFormatFlagMap[j]);
+bool const isRsidOnlyAutoFormat1 = i <
sal_Int32(RsidOnlyAutoFormatFlagMap.size()) && RsidOnlyAutoFormatFlagMap[i];
+bool const isRsidOnlyAutoFormat2 = j <
sal_Int32(RsidOnlyAutoFormatFlagMap.size()) && RsidOnlyAutoFormatFlagMap[j];
// if both have one they could be equal, but not if only one has it
bool const bSkipRsidOnlyAutoFormat(nAttributesInPor1 != nAttributesInPor2);
[Libreoffice-bugs] [Bug 144060] Writer process hangs frequently on macOS 11.4 on MacBook Air M1 -- Apple Silicon
https://bugs.documentfoundation.org/show_bug.cgi?id=144060 steve changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from steve --- Thanks for the report. So the problem is isolated to this single writer file or are all writer files affected? If isolated to single file, providing a sanitized version of the file would be crucial to reproduce and fix the problem. Could be worth updating macOS to 11.5.2 as with Apples poor documentation or rather non-existing changelog it is really hard to tell which macOS bugs were fixed in the meantime and see if the problem is persisting then. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144047] Cut and Copy not working in Writer macOS with experimental functions enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=144047 steve changed: What|Removed |Added Summary|Cut and Copy not working in |Cut and Copy not working in |Writer macOS|Writer macOS with ||experimental functions ||enabled -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143813] Outline folding: copy, cut and paste do not work anymore
https://bugs.documentfoundation.org/show_bug.cgi?id=143813 steve changed: What|Removed |Added CC||stefan.kl...@email.de --- Comment #6 from steve --- *** Bug 144047 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144047] Cut and Copy not working in Writer macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=144047 steve changed: What|Removed |Added Summary|Cut and Copy not working in |Cut and Copy not working in |Writer Mac OS |Writer macOS Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED --- Comment #8 from steve --- Nice spotting @Timur. Thanks for confirming @Stefan. *** This bug has been marked as a duplicate of bug 143813 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143957] Crash when switching transitions (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=143957 --- Comment #4 from Commit Notification --- Jan-Marek Glogowski committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/83be3b84228a67315882b65dc51cc86dc9d9afcc tdf#143957 Qt5 always create an OpenGLContext It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143957] Crash when switching transitions (kf5)
https://bugs.documentfoundation.org/show_bug.cgi?id=143957 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.2.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/inc vcl/qt5
vcl/inc/qt5/Qt5Instance.hxx |3 +++
vcl/qt5/Qt5Instance.cxx |8 +++-
2 files changed, 10 insertions(+), 1 deletion(-)
New commits:
commit 83be3b84228a67315882b65dc51cc86dc9d9afcc
Author: Jan-Marek Glogowski
AuthorDate: Thu Aug 19 20:18:47 2021 +0200
Commit: Xisco Fauli
CommitDate: Wed Aug 25 10:30:03 2021 +0200
tdf#143957 Qt5 always create an OpenGLContext
Nothing checks the result and a lot of code just uses it.
Change-Id: I1a672e98d42673fd684538ead831622f6a14e9f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120761
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 0f7fed9249e988ca34c5401d746887822b4aa9ce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120776
Reviewed-by: Xisco Fauli
diff --git a/vcl/inc/qt5/Qt5Instance.hxx b/vcl/inc/qt5/Qt5Instance.hxx
index 41b9aca894d0..dc347021b9bb 100644
--- a/vcl/inc/qt5/Qt5Instance.hxx
+++ b/vcl/inc/qt5/Qt5Instance.hxx
@@ -133,7 +133,10 @@ public:
virtual bool DoYield(bool bWait, bool bHandleAllCurrentEvents) override;
virtual bool AnyInput(VclInputFlags nType) override;
+// so we fall back to the default abort, instead of duplicating it...
+#ifndef EMSCRIPTEN
virtual OpenGLContext* CreateOpenGLContext() override;
+#endif
virtual OUString GetConnectionIdentifier() override;
diff --git a/vcl/qt5/Qt5Instance.cxx b/vcl/qt5/Qt5Instance.cxx
index bf8d52961960..432af5e6f718 100644
--- a/vcl/qt5/Qt5Instance.cxx
+++ b/vcl/qt5/Qt5Instance.cxx
@@ -245,6 +245,10 @@ Qt5Instance::Qt5Instance(std::unique_ptr&
pQApp, bool bUseCairo)
connect(QGuiApplication::inputMethod(), ::localeChanged, this,
::localeChanged);
+
+#ifdef EMSCRIPTEN
+m_bSupportsOpenGL = false;
+#endif
}
Qt5Instance::~Qt5Instance()
@@ -432,7 +436,9 @@ OUString Qt5Instance::GetConnectionIdentifier() { return
OUString(); }
void Qt5Instance::AddToRecentDocumentList(const OUString&, const OUString&,
const OUString&) {}
-OpenGLContext* Qt5Instance::CreateOpenGLContext() { return nullptr; }
+#ifndef EMSCRIPTEN
+OpenGLContext* Qt5Instance::CreateOpenGLContext() { return new
Qt5OpenGLContext; }
+#endif
bool Qt5Instance::IsMainThread() const
{
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - compilerplugins/clang vcl/headless vcl/inc vcl/qa vcl/source vcl/unx vcl/win
compilerplugins/clang/singlevalfields.results|3 -
compilerplugins/clang/unnecessaryoverride.cxx|5 --
vcl/headless/svpinst.cxx | 51 ---
vcl/inc/backend/BackendCapabilities.hxx | 28
vcl/inc/headless/svpinst.hxx |4 -
vcl/inc/salinst.hxx | 16 +++
vcl/inc/unx/salinst.h|2
vcl/inc/win/salinst.h|1
vcl/qa/cppunit/BitmapExTest.cxx |3 -
vcl/qa/cppunit/BitmapTest.cxx|6 --
vcl/qa/cppunit/bitmaprender/BitmapRenderTest.cxx |3 -
vcl/source/app/salvtables.cxx|6 ++
vcl/source/bitmap/BitmapReadAccess.cxx |6 --
vcl/source/filter/png/PngImageReader.cxx |3 -
vcl/source/opengl/OpenGLHelper.cxx |4 +
vcl/unx/generic/app/salinst.cxx | 16 +--
vcl/win/app/salinst.cxx | 16 +--
17 files changed, 34 insertions(+), 139 deletions(-)
New commits:
commit e11bbf3c3ccd45c3c7adc75077c4f4cebf6892b2
Author: Jan-Marek Glogowski
AuthorDate: Thu Aug 19 21:45:42 2021 +0200
Commit: Xisco Fauli
CommitDate: Wed Aug 25 10:29:34 2021 +0200
VCL allow plugins to declare OpenGL support
... and get rid of the whole GetBackendCapabilities, which was
just overkill. Maybe this should even be some bitmap + enum
+ set/get function, but I'm too lazy...
In the end add a bool for the OpenGL support of the VCL plugin
(or maybe sticking it into ImplSVData, which is already some
catchall for common VCL data).
Change-Id: I9f0ececac482d8e2a94ef6024628e9631b49e773
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120760
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
(cherry picked from commit 9ca30cd1d04cf39411c3ede687805c28ebe2a980)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120775
Reviewed-by: Xisco Fauli
diff --git a/compilerplugins/clang/singlevalfields.results
b/compilerplugins/clang/singlevalfields.results
index b2f91d4d97a1..c426b4a42580 100644
--- a/compilerplugins/clang/singlevalfields.results
+++ b/compilerplugins/clang/singlevalfields.results
@@ -976,9 +976,6 @@ vcl/headless/svpgdi.cxx:598
vcl/headless/svpgdi.cxx:1641
SvpSalGraphics::drawPolyLine bDoDirectCairoStroke
1
-vcl/inc/backend/BackendCapabilities.hxx:18
-vcl::BackendCapabilities mbSupportsBitmap32
-0
vcl/inc/canvasbitmap.hxx:53
vcl::unotools::VclCanvasBitmap m_nEndianness
0
diff --git a/compilerplugins/clang/unnecessaryoverride.cxx
b/compilerplugins/clang/unnecessaryoverride.cxx
index 10ab158b7d8d..cae1220b0e23 100644
--- a/compilerplugins/clang/unnecessaryoverride.cxx
+++ b/compilerplugins/clang/unnecessaryoverride.cxx
@@ -246,11 +246,6 @@ bool UnnecessaryOverride::VisitCXXMethodDecl(const
CXXMethodDecl* methodDecl)
return true;
}
-auto fdc = loplugin::DeclCheck(methodDecl);
-// Has code only in #ifdef.
-if
(fdc.Function("GetBackendCapabilities").Class("X11SalInstance").GlobalNamespace())
-return true;
-
// If overriding more than one base member function, or one base member
// function that is available in multiple (non-virtual) base class
// instances, then this is a disambiguating override:
diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx
index 700c6b87f645..71efed967af3 100644
--- a/vcl/headless/svpinst.cxx
+++ b/vcl/headless/svpinst.cxx
@@ -35,9 +35,6 @@
#include
#include
#include
-#if HAVE_FEATURE_UI
-# include
-#endif
#include
#include
@@ -89,6 +86,8 @@ SvpSalInstance::SvpSalInstance(
std::unique_ptr pMutex )
#if !defined(ANDROID) && !defined(IOS)
pthread_atfork(nullptr, nullptr, atfork_child);
#endif
+
+m_bSupportsOpenGL = false;
}
SvpSalInstance::~SvpSalInstance()
@@ -591,52 +590,6 @@ void SvpSalInstance::AddToRecentDocumentList(const
OUString&, const OUString&, c
{
}
-std::shared_ptr
SvpSalInstance::GetBackendCapabilities()
-{
-auto pBackendCapabilities = SalInstance::GetBackendCapabilities();
-#if 0 // LO code is not yet bitmap32-ready.
-#ifndef IOS
-// Note: This code is used for iOS, too. Let's not use 32-bit bitmaps with
included alpha on iOS for now.
-pBackendCapabilities->mbSupportsBitmap32 = true;
-#endif
-#endif
-return pBackendCapabilities;
-}
-
-//obviously doesn't actually do anything, it's just a nonfunctional stub
-
-#if HAVE_FEATURE_UI
-
-namespace {
-
-class SvpOpenGLContext : public OpenGLContext
-{
-GLWindow m_aGLWin;
-private:
-virtual const GLWindow& getOpenGLWindow() const override { return
m_aGLWin; }
-virtual GLWindow& getModifiableOpenGLWindow() override { return m_aGLWin; }
-};
-
-}
-
-OpenGLContext* SvpSalInstance::CreateOpenGLContext()
-{
-return new SvpOpenGLContext;
-}
-
-#else
-
-class
[Libreoffice-bugs] [Bug 144066] Tangent function is returning a number to the order of 10^16 for PI/2
https://bugs.documentfoundation.org/show_bug.cgi?id=144066 Jean-Baptiste Faure changed: What|Removed |Added Resolution|--- |NOTABUG CC||jbfa...@libreoffice.org Status|UNCONFIRMED |RESOLVED --- Comment #1 from Jean-Baptiste Faure --- Hmmm, tan() = sin()/cos() sin(Pi/2) = 1 cos(Pi/2) = 0 then tan(Pi/2) = +infinity so the value provided by Calc is a relatively correct approximation. What is your source for your expected value? https://en.wikipedia.org/wiki/Trigonometric_functions#Simple_algebraic_values Closing as NotABug. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143732] Right/left arrow behaviour in presentations is unpredictable
https://bugs.documentfoundation.org/show_bug.cgi?id=143732 Henrik Palomäki changed: What|Removed |Added CC||henrik.palom...@yandex.com --- Comment #4 from Henrik Palomäki --- No repro in Version: 7.2.0.4 (x64) / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded and Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 0224d859b8a497779611cc15943c017ec42f9b90 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144051] Deadlock
https://bugs.documentfoundation.org/show_bug.cgi?id=144051 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'feature/themesupport2' - 5 commits - editeng/source include/editeng include/oox include/sfx2 include/svx oox/source sfx2/Library_sfx.mk sfx2/source svx/Library_
Rebased ref, commits from common ancestor:
commit 357221a85605722c41588f30d4c7ee875aafe99d
Author: Sarper Akdemir
AuthorDate: Wed Aug 25 02:24:42 2021 +0300
Commit: Sarper Akdemir
CommitDate: Wed Aug 25 02:36:59 2021 +0300
implement color tint or shade import for pptx
Change-Id: I38661afecec6d769bd41b8c3b71c9a4de5e69440
diff --git a/include/oox/drawingml/color.hxx b/include/oox/drawingml/color.hxx
index 00473cfe6f27..bd67982c6e92 100644
--- a/include/oox/drawingml/color.hxx
+++ b/include/oox/drawingml/color.hxx
@@ -99,6 +99,7 @@ public:
/** Returns the scheme name from the a:schemeClr element for
interoperability purposes */
const OUString& getSchemeColorName() const { return msSchemeName; }
sal_Int16 getSchemeColorIndex() const;
+sal_Int16 getTintOrShade();
/** Returns the unaltered list of transformations for interoperability
purposes */
const css::uno::Sequence< css::beans::PropertyValue >&
getTransformations() const { return maInteropTransformations;}
diff --git a/oox/source/drawingml/color.cxx b/oox/source/drawingml/color.cxx
index edb317eaac3d..1c1e9f7a110a 100644
--- a/oox/source/drawingml/color.cxx
+++ b/oox/source/drawingml/color.cxx
@@ -478,6 +478,22 @@ void Color::clearTransparence()
mnAlpha = MAX_PERCENT;
}
+sal_Int16 Color::getTintOrShade()
+{
+for(auto const& aTransform : maTransforms)
+{
+switch(aTransform.mnToken)
+{
+case XML_tint:
+// from 1000th percent to 100th percent...
+return aTransform.mnValue/10;
+case XML_shade:
+// from 1000th percent to 100th percent...
+return -aTransform.mnValue/10;
+}
+}
+return 0;
+}
::Color Color::getColor( const GraphicHelper& rGraphicHelper, ::Color nPhClr )
const
{
const sal_Int32 nTempC1 = mnC1;
diff --git a/oox/source/drawingml/textcharacterproperties.cxx
b/oox/source/drawingml/textcharacterproperties.cxx
index 90b0e38c1d3a..bd4d051a490b 100644
--- a/oox/source/drawingml/textcharacterproperties.cxx
+++ b/oox/source/drawingml/textcharacterproperties.cxx
@@ -113,6 +113,7 @@ void TextCharacterProperties::pushToPropMap( PropertyMap&
rPropMap, const XmlFil
rPropMap.setProperty(PROP_CharColor,
aColor.getColor(rFilter.getGraphicHelper()));
// set color theme index
rPropMap.setProperty(PROP_CharColorTheme,
aColor.getSchemeColorIndex());
+rPropMap.setProperty(PROP_CharColorTintOrShade,
aColor.getTintOrShade());
if (aColor.hasTransparency())
{
commit 9f4720bff45d867249d2762c01112eb500fcdf5c
Author: Sarper Akdemir
AuthorDate: Tue Aug 24 23:58:35 2021 +0300
Commit: Sarper Akdemir
CommitDate: Wed Aug 25 02:36:59 2021 +0300
rename getSchemeName getSchemeIndex to remove ambiguity
Change-Id: Ib1fa16b15c219b38754ffe5cbfc9d11ff2be0fcd
diff --git a/include/oox/drawingml/color.hxx b/include/oox/drawingml/color.hxx
index f213dba9a973..00473cfe6f27 100644
--- a/include/oox/drawingml/color.hxx
+++ b/include/oox/drawingml/color.hxx
@@ -97,8 +97,8 @@ public:
sal_Int16 getTransparency() const;
/** Returns the scheme name from the a:schemeClr element for
interoperability purposes */
-const OUString& getSchemeName() const { return msSchemeName; }
-sal_Int16 getSchemeIndex() const;
+const OUString& getSchemeColorName() const { return msSchemeName; }
+sal_Int16 getSchemeColorIndex() const;
/** Returns the unaltered list of transformations for interoperability
purposes */
const css::uno::Sequence< css::beans::PropertyValue >&
getTransformations() const { return maInteropTransformations;}
diff --git a/oox/source/drawingml/color.cxx b/oox/source/drawingml/color.cxx
index 5d3ea6cb8708..edb317eaac3d 100644
--- a/oox/source/drawingml/color.cxx
+++ b/oox/source/drawingml/color.cxx
@@ -660,7 +660,7 @@ sal_Int16 Color::getTransparency() const
return sal_Int16(std::round( (1.0 * (MAX_PERCENT - mnAlpha)) /
PER_PERCENT) );
}
-sal_Int16 Color::getSchemeIndex() const
+sal_Int16 Color::getSchemeColorIndex() const
{
static std::map const aSchemeColorNameToIndex{
{ "dk1", 0 }, { "lt1", 1 }, { "dk2", 2 }, { "lt2", 3 },
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index b0e2ddef30e7..78a482abd446 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -1060,7 +1060,7 @@ Reference< XShape > const & Shape::createAndInsert(
// Store style-related properties to InteropGrabBag to be able
to export them back
uno::Sequence aProperties =
comphelper::InitPropertySequence(
{
-{"SchemeClr",
uno::makeAny(pLineRef->maPhClr.getSchemeName())},
+{"SchemeClr",
uno::makeAny(pLineRef->maPhClr.getSchemeColorName())},
{"Idx",
[Libreoffice-bugs] [Bug 142959] Make selection color optional
https://bugs.documentfoundation.org/show_bug.cgi?id=142959 --- Comment #13 from Heiko Tietze --- (In reply to al.le from comment #12) > I'd close the ticket now. But please consider bug#143733. Would do both the larger border in- and outside the current selection and... (In reply to Timur from comment #11) > I'm in favor of new option "Selected cell grid" in Options-Application > Colors-Spreadsheet. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143733] Make selection border wider
https://bugs.documentfoundation.org/show_bug.cgi?id=143733 Heiko Tietze changed: What|Removed |Added CC||heiko.tietze@documentfounda ||tion.org Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - starmath/source
starmath/source/mathtype.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit e9a68832ada43d051ee90f453b82634543057077
Author: Caolán McNamara
AuthorDate: Tue Aug 24 20:42:53 2021 +0100
Commit: Xisco Fauli
CommitDate: Wed Aug 25 10:03:50 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I15d68391e20fba3a8ba46621aac0c831cd0900b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120890
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/starmath/source/mathtype.cxx b/starmath/source/mathtype.cxx
index cb46776cc618..acdeba5fcfb6 100644
--- a/starmath/source/mathtype.cxx
+++ b/starmath/source/mathtype.cxx
@@ -570,7 +570,7 @@ bool MathType::Parse(SvStream* pStream)
pS->ReadUChar( nProdVersion );
pS->ReadUChar( nProdSubVersion );
-if (nVersion > 3) // allow only supported versions of MathType to be
parsed
+if (!pS->good() || nVersion > 3) // allow only supported versions of
MathType to be parsed
return false;
bool bRet = HandleRecords(0);
@@ -637,7 +637,7 @@ bool MathType::HandleRecords(int nLevel, sal_uInt8
nSelector,
return false;
sal_uInt8 nTag,nRecord;
-sal_uInt8 nTabType,nTabStops;
+sal_uInt8 nTabType;
sal_uInt16 nTabOffset;
int i, newline=0;
bool bSilent=false;
@@ -1688,6 +1688,8 @@ bool MathType::HandleRecords(int nLevel, sal_uInt8
nSelector,
HandleEmblishments();
break;
case RULER:
+{
+sal_uInt8 nTabStops(0);
pS->ReadUChar( nTabStops );
for (i=0;i
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/source
vcl/source/filter/iras/iras.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9841853b8a4b4cac06f59269189f50f3f73d79ab Author: Caolán McNamara AuthorDate: Mon Aug 23 20:03:26 2021 +0100 Commit: Xisco Fauli CommitDate: Wed Aug 25 10:02:51 2021 +0200 ofz: MemorySanitizer: use-of-uninitialized-value Change-Id: I4e592de5ff830aa970b96993c79a5d957f57adfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120922 Tested-by: Jenkins Reviewed-by: Caolán McNamara (cherry picked from commit fe90f7fc34f8a6e354abbb48c21556d018fa768d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120977 Reviewed-by: Xisco Fauli diff --git a/vcl/source/filter/iras/iras.cxx b/vcl/source/filter/iras/iras.cxx index 128255fed025..49cfe2bef2cc 100644 --- a/vcl/source/filter/iras/iras.cxx +++ b/vcl/source/filter/iras/iras.cxx @@ -94,7 +94,7 @@ bool RASReader::ReadRAS(Graphic & rGraphic) m_rRAS.SetEndian( SvStreamEndian::BIG ); m_rRAS.ReadUInt32( nMagicNumber ); -if ( nMagicNumber != SUNRASTER_MAGICNUMBER ) +if (!m_rRAS.good() || nMagicNumber != SUNRASTER_MAGICNUMBER) return false; // Kopf einlesen:
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/source
vcl/source/filter/iras/iras.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d230a5caa7af87b9a2f5a642e7502f5b10cd952b
Author: Caolán McNamara
AuthorDate: Tue Aug 24 20:47:30 2021 +0100
Commit: Xisco Fauli
CommitDate: Wed Aug 25 10:00:51 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I8bac670cb289d7b8636535c1b1fb2f4fc9f03afe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120891
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/vcl/source/filter/iras/iras.cxx b/vcl/source/filter/iras/iras.cxx
index 415e3224d6fb..128255fed025 100644
--- a/vcl/source/filter/iras/iras.cxx
+++ b/vcl/source/filter/iras/iras.cxx
@@ -365,7 +365,7 @@ bool RASReader::ImplReadBody(vcl::bitmap::RawBitmap&
rBitmap, std::vector
sal_uInt8 RASReader::ImplGetByte()
{
-sal_uInt8 nRetVal;
+sal_uInt8 nRetVal(0);
if ( mnType != RAS_TYPE_BYTE_ENCODED )
{
m_rRAS.ReadUChar( nRetVal );
Re: Why is PolyPolygonShape excluded from DML export?
Hi Regina, On Tue, Aug 24, 2021 at 03:05:30PM +0200, Regina Henschel wrote: > Excluding polygon shapes from DML export (done as fix for tdf#75254) is no > longer needed. But I'm still unsure whether to remove this restriction. > > Pro: > Polygon shapes are already exported as DML in Impress and Calc. So the > behavior would become consistent. > Polygon shapes could use the same improvements in wrapping as made for > Bézier curves. > > Contra: > On reopening the polygon shape would be converted to a custom shape. That > means, that the user can no longer edit the points. Having only VML in the > file opens the shape as PolyPolygonShape which allows point editing. > > So what to you suggest? I would lean towards writing the polygon shape as a PolyPolygonShape to allow editing. We used to write just VML in the past, so some may see this as a regression if the drawingML output doesn't allow editing anymore. Regards, Miklos
[Libreoffice-commits] core.git: starmath/source
starmath/source/mathtype.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 5f11e921fb878cc6fd6a15181a416e0143e389f7
Author: Caolán McNamara
AuthorDate: Tue Aug 24 20:42:53 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 25 09:56:28 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I15d68391e20fba3a8ba46621aac0c831cd0900b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120964
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/starmath/source/mathtype.cxx b/starmath/source/mathtype.cxx
index cb46776cc618..acdeba5fcfb6 100644
--- a/starmath/source/mathtype.cxx
+++ b/starmath/source/mathtype.cxx
@@ -570,7 +570,7 @@ bool MathType::Parse(SvStream* pStream)
pS->ReadUChar( nProdVersion );
pS->ReadUChar( nProdSubVersion );
-if (nVersion > 3) // allow only supported versions of MathType to be
parsed
+if (!pS->good() || nVersion > 3) // allow only supported versions of
MathType to be parsed
return false;
bool bRet = HandleRecords(0);
@@ -637,7 +637,7 @@ bool MathType::HandleRecords(int nLevel, sal_uInt8
nSelector,
return false;
sal_uInt8 nTag,nRecord;
-sal_uInt8 nTabType,nTabStops;
+sal_uInt8 nTabType;
sal_uInt16 nTabOffset;
int i, newline=0;
bool bSilent=false;
@@ -1688,6 +1688,8 @@ bool MathType::HandleRecords(int nLevel, sal_uInt8
nSelector,
HandleEmblishments();
break;
case RULER:
+{
+sal_uInt8 nTabStops(0);
pS->ReadUChar( nTabStops );
for (i=0;i
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - include/xmloff xmloff/source
include/xmloff/xmlnumfe.hxx |3 ++-
include/xmloff/xmlnumfi.hxx |2 ++
xmloff/source/style/xmlnumfe.cxx | 16 +---
xmloff/source/style/xmlnumfi.cxx | 20
4 files changed, 37 insertions(+), 4 deletions(-)
New commits:
commit 5d6a91b8ea40ec79c746e5c1d486be6e25a2856d
Author: Eike Rathke
AuthorDate: Sun Aug 22 22:13:23 2021 +0200
Commit: Xisco Fauli
CommitDate: Wed Aug 25 09:54:38 2021 +0200
Resolves: tdf#143979 Write and read empty text element in number formats
... as they may be significant as separators between keywords of
same letters.
Also strip trailing empty text as meaningless, except if the only
element.
>General;General<
earlier both General were written as
for which now is not.
Change-Id: I4809b1c784667994303b49d8e4ab0e857367e2cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120856
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit c6f15d228489ccfd0628ca80b45a5c2faaacc7d3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120728
Reviewed-by: Xisco Fauli
diff --git a/include/xmloff/xmlnumfe.hxx b/include/xmloff/xmlnumfe.hxx
index 98584ac93873..28bfe8d1a2ad 100644
--- a/include/xmloff/xmlnumfe.hxx
+++ b/include/xmloff/xmlnumfe.hxx
@@ -50,7 +50,8 @@ private:
SvXMLExport&rExport;
OUStringsPrefix;
SvNumberFormatter* pFormatter;
-OUStringBuffer sTextContent;
+OUStringBuffer sTextContent;
+boolbHasText;
std::unique_ptr pUsedList;
std::unique_ptr pCharClass;
std::unique_ptr pLocaleData;
diff --git a/include/xmloff/xmlnumfi.hxx b/include/xmloff/xmlnumfi.hxx
index 0f6384f3b785..8026b4e1846b 100644
--- a/include/xmloff/xmlnumfi.hxx
+++ b/include/xmloff/xmlnumfi.hxx
@@ -145,6 +145,7 @@ private:
boolbAutoDec; // set in AddNumber
boolbAutoInt; // set in AddNumber
boolbHasExtraText;
+boolbHasTrailingEmptyText;
OUStringBuffer aFormatCode{64};
OUStringBuffer aConditions{32};
boolbHasLongDoW;
@@ -189,6 +190,7 @@ public:
bool HasLongDoW() const { return bHasLongDoW; }
void SetHasLongDoW(bool bSet) { bHasLongDoW = bSet; }
+void SetHasTrailingEmptyText(bool bSet) { bHasTrailingEmptyText =
bSet; }
void UpdateCalendar( const OUString& rNewCalendar );
ImplicitCalendar GetImplicitCalendarState() const { return
eImplicitCalendar; }
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 38c4d42d2986..59e6e8d9bf5c 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -209,7 +209,8 @@ SvXMLNumFmtExport::SvXMLNumFmtExport(
const uno::Reference< util::XNumberFormatsSupplier >& rSupp ) :
rExport( rExp ),
sPrefix( OUString("N") ),
-pFormatter( nullptr )
+pFormatter( nullptr ),
+bHasText( false )
{
// supplier must be SvNumberFormatsSupplierObj
SvNumberFormatsSupplierObj* pObj =
@@ -241,7 +242,8 @@ SvXMLNumFmtExport::SvXMLNumFmtExport(
const OUString& rPrefix ) :
rExport( rExp ),
sPrefix( rPrefix ),
-pFormatter( nullptr )
+pFormatter( nullptr ),
+bHasText( false )
{
// supplier must be SvNumberFormatsSupplierObj
SvNumberFormatsSupplierObj* pObj =
@@ -319,16 +321,21 @@ void SvXMLNumFmtExport::AddToTextElement_Impl(
std::u16string_view rString )
// to avoid several text elements following each other
sTextContent.append( rString );
+// Also empty string leads to a number:text element as it may separate
+// keywords of the same letter (e.g. MM""MMM) that otherwise would be
+// concatenated when reading back in.
+bHasText = true;
}
void SvXMLNumFmtExport::FinishTextElement_Impl(bool bUseExtensionNS)
{
-if ( !sTextContent.isEmpty() )
+if ( bHasText )
{
sal_uInt16 nNS = bUseExtensionNS ? XML_NAMESPACE_LO_EXT :
XML_NAMESPACE_NUMBER;
SvXMLElementExport aElem( rExport, nNS, XML_TEXT,
true, false );
rExport.Characters( sTextContent.makeStringAndClear() );
+bHasText = false;
}
}
@@ -1414,6 +1421,8 @@ void SvXMLNumFmtExport::ExportPart_Impl( const
SvNumberformat& rFormat, sal_uInt
{
case 0:
bEnd = true;// end of format reached
+if (bHasText && sTextContent.isEmpty())
+bHasText = false; // don't write trailing empty
text
break;
case NF_SYMBOLTYPE_STRING:
case NF_SYMBOLTYPE_DATESEP:
@@ -1462,6 +1471,7 @@ void
[Libreoffice-bugs] [Bug 114994] Sheet -> Link to External Data doesn't have button to load the URL
https://bugs.documentfoundation.org/show_bug.cgi?id=114994 Andreas Heinisch changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0591 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120591] Add button to load or refresh the table and ranges in the external data dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=120591 Andreas Heinisch changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||4994 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: editeng/source
editeng/source/rtf/svxrtf.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 71c4c0628570b960c9d6ba14222e1b1324447937
Author: Caolán McNamara
AuthorDate: Tue Aug 24 16:07:18 2021 +0100
Commit: Caolán McNamara
CommitDate: Wed Aug 25 09:39:25 2021 +0200
assert on calc rtf import at svl::detail::validRange(nFrom, nTo)
Change-Id: I4513be06ff70605db8b386dc261c5b82509759e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120953
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx
index 1d1c0993a5d1..6b878cca119c 100644
--- a/editeng/source/rtf/svxrtf.cxx
+++ b/editeng/source/rtf/svxrtf.cxx
@@ -921,6 +921,8 @@ void SvxRTFParser::BuildWhichTable()
{
sal_uInt16 nTrueWid = pAttrPool->GetTrueWhich(nWid, false);
aPardMap[nWid] = nTrueWid;
+if (nTrueWid == 0)
+continue;
aWhichMap = aWhichMap.MergeRange(nTrueWid, nTrueWid);
}
@@ -943,6 +945,8 @@ void SvxRTFParser::BuildWhichTable()
{
sal_uInt16 nTrueWid = pAttrPool->GetTrueWhich(nWid, false);
aPlainMap[nWid] = nTrueWid;
+if (nTrueWid == 0)
+continue;
aWhichMap = aWhichMap.MergeRange(nTrueWid, nTrueWid);
}
}
