[Libreoffice-bugs] [Bug 144284] Crash closing master document (dbgutil)
https://bugs.documentfoundation.org/show_bug.cgi?id=144284 --- Comment #2 from Buovjaga --- (In reply to Julien Nabet from comment #1) > Just for the record, on pc Debian x86-64 with master sources updated today > (e4b1ba9447a0a56aa56400f9f44d8eecb6c11e9c) + enable-dbgutil + kf5 rendering, > I don't reproduce this. > > I tried with responding No then a second time Yes to save the document when > closing. Hmm, do you mean you answered "Yes" to updating links the second time? Updating links is required for the crash. If you answer "No", it will not crash. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144273] Spell check fails on document template
https://bugs.documentfoundation.org/show_bug.cgi?id=144273
--- Comment #4 from Uwe Auer ---
(In reply to Uwe Auer from comment #3)
>
> - The document seems to have a history with Google Docs since its language
> settings is {en} (which is typical for Google Docs exported to .ots format)
Typo correction:
(which is typical for Google Docs exported to .odt format)
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144273] Spell check fails on document template
https://bugs.documentfoundation.org/show_bug.cgi?id=144273
--- Comment #3 from Uwe Auer ---
Principle: Spell checking appears based on the language settings of text
portions
- This document is not a template in the sense of LibreOffice template (.ott)
but an exemplar of a CV
- The document seems to have a history with Google Docs since its language
settings is {en} (which is typical for Google Docs exported to .ots format)
instead if "English (USA)" (or any other language variant of English, which is
supported by LibreOffice). In consequence there is no spell checking, since
{en} is not a supported language of LibreOffice
See also: bug report tdf#137742
Solution:
- Open the document
- In "Tools -> Options -> Language Settings -> Language" replace Western
Language (which is now {en}) by "English (USA)" (or any other variant of
English, which applies to your situation)
- Click button "Apply"
- Check wavy red lines appearing in sample document
>From my perspective not a bug, but an unsupported language setting of the
document (version 7.3 should contain a fix for this)
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 77141] leaks a fd on closed odb: locks file on Windows share
https://bugs.documentfoundation.org/show_bug.cgi?id=77141 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4256 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 57979] ODatabaseContext::dispose uses other services during shutdown
https://bugs.documentfoundation.org/show_bug.cgi?id=57979 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4256 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144256] Missing destruction of FirebirdDriver::~FirebirdDriver, OSDBCDriverManager::~OSDBCDriverManager, OPoolCollection::~OPoolCollection opening and closing an ODB
https://bugs.documentfoundation.org/show_bug.cgi?id=144256 Julien Nabet changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=57 ||979, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=77 ||141 CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet --- I don't know if it can help but since several years, I've got this when closing odb files: warn:dbaccess:68925:68925:dbaccess/source/core/dataaccess/ModelImpl.cxx:926: com.sun.star.container.NoSuchElementException message: /home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974: /home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974 warn:dbaccess:68925:68925:dbaccess/source/core/dataaccess/ModelImpl.cxx:926: com.sun.star.container.NoSuchElementException message: /home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974: /home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974 Also, perhaps a relation with tdf#57979 (or even tdf#77141)? I mean all these show a pb when closing odb files. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=62032 --- Comment #34 from Commit Notification --- Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f38406ba7905678a1cb703b8ff177e5f5008d3ee tdf#62032 ODT export: handle style:list-level="..." for para styles It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)
https://bugs.documentfoundation.org/show_bug.cgi?id=62032 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: xmloff/CppunitTest_xmloff_text.mk xmloff/qa xmloff/source
xmloff/CppunitTest_xmloff_text.mk |1
xmloff/qa/unit/data/para-style-list-level.fodt |2 -
xmloff/qa/unit/text.cxx| 39 -
xmloff/source/style/styleexp.cxx | 31 +++
4 files changed, 71 insertions(+), 2 deletions(-)
New commits:
commit f38406ba7905678a1cb703b8ff177e5f5008d3ee
Author: Miklos Vajna
AuthorDate: Fri Sep 3 16:42:46 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 3 19:01:08 2021 +0200
tdf#62032 ODT export: handle style:list-level="..." for para styles
ODT import was already working. The spec also says to only take this
into account when applying the style, so it seems only the UI remains
for the bug to be closed, the rest is done.
Change-Id: I27da4dc171b4ced75f143bbcecb3f8c748a26b02
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121607
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/xmloff/CppunitTest_xmloff_text.mk
b/xmloff/CppunitTest_xmloff_text.mk
index 14640cf8d7d7..ad6711a89101 100644
--- a/xmloff/CppunitTest_xmloff_text.mk
+++ b/xmloff/CppunitTest_xmloff_text.mk
@@ -13,6 +13,7 @@ $(eval $(call gb_CppunitTest_CppunitTest,xmloff_text))
$(eval $(call gb_CppunitTest_use_externals,xmloff_text,\
boost_headers \
+ libxml2 \
))
$(eval $(call gb_CppunitTest_add_exception_objects,xmloff_text, \
diff --git a/xmloff/qa/unit/data/para-style-list-level.fodt
b/xmloff/qa/unit/data/para-style-list-level.fodt
index 88f96e349ee2..3cf0fd6f5315 100644
--- a/xmloff/qa/unit/data/para-style-list-level.fodt
+++ b/xmloff/qa/unit/data/para-style-list-level.fodt
@@ -1,7 +1,7 @@
-
+
diff --git a/xmloff/qa/unit/text.cxx b/xmloff/qa/unit/text.cxx
index 79acb8cb08bf..78ebaf75e1bc 100644
--- a/xmloff/qa/unit/text.cxx
+++ b/xmloff/qa/unit/text.cxx
@@ -9,6 +9,7 @@
#include
#include
+#include
#include
#include
@@ -16,18 +17,22 @@
#include
#include
#include
+#include
#include
#include
#include
#include
+#include
using namespace ::com::sun::star;
constexpr OUStringLiteral DATA_DIRECTORY = u"/xmloff/qa/unit/data/";
/// Covers xmloff/source/text/ fixes.
-class XmloffStyleTest : public test::BootstrapFixture, public
unotest::MacrosTest
+class XmloffStyleTest : public test::BootstrapFixture,
+public unotest::MacrosTest,
+public XmlTestTools
{
private:
uno::Reference mxComponent;
@@ -35,9 +40,15 @@ private:
public:
void setUp() override;
void tearDown() override;
+void registerNamespaces(xmlXPathContextPtr& pXmlXpathCtx) override;
uno::Reference& getComponent() { return mxComponent; }
};
+void XmloffStyleTest::registerNamespaces(xmlXPathContextPtr& pXmlXpathCtx)
+{
+XmlTestTools::registerODFNamespaces(pXmlXpathCtx);
+}
+
void XmloffStyleTest::setUp()
{
test::BootstrapFixture::setUp();
@@ -181,6 +192,32 @@ CPPUNIT_TEST_FIXTURE(XmloffStyleTest,
testParaStyleListLevel)
sal_Int16 nNumberingLevel{};
CPPUNIT_ASSERT(xStyle->getPropertyValue("NumberingLevel") >>=
nNumberingLevel);
CPPUNIT_ASSERT_EQUAL(static_cast(2), nNumberingLevel);
+
+// Test the export as well:
+
+// Given a doc model that has a para style with NumberingLevel=2:
+uno::Reference xStorable(getComponent(), uno::UNO_QUERY);
+
+// When exporting that to ODT:
+uno::Sequence aStoreProps =
comphelper::InitPropertySequence({
+{ "FilterName", uno::makeAny(OUString("writer8")) },
+});
+utl::TempFile aTempFile;
+aTempFile.EnableKillingFile();
+xStorable->storeToURL(aTempFile.GetURL(), aStoreProps);
+
+// Then make sure we save the style's numbering level:
+uno::Reference xNameAccess
+= packages::zip::ZipFileAccess::createWithURL(mxComponentContext,
aTempFile.GetURL());
+uno::Reference
xInputStream(xNameAccess->getByName("styles.xml"),
+ uno::UNO_QUERY);
+std::unique_ptr
pStream(utl::UcbStreamHelper::CreateStream(xInputStream, true));
+xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
+// Without the accompanying fix in place, this failed with:
+// - XPath
'/office:document-styles/office:styles/style:style[@style:name='mystyle']' no
attribute 'list-level' exist
+// i.e. a custom NumberingLevel was lost on save.
+assertXPath(pXmlDoc,
"/office:document-styles/office:styles/style:style[@style:name='mystyle']",
+"list-level", "2");
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/xmloff/source/style/styleexp.cxx b/xmloff/source/style/styleexp.cxx
index 159d5b50e02e..2c628ffbda4d 100644
--- a/xmloff/source/style/styleexp.cxx
+++ b/xmloff/source/style/styleexp.cxx
@@ -41,6 +41,7 @@
#include
#include
#include
+#include
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
@@ -122,6 +123,34 @@ void
[Libreoffice-bugs] [Bug 144284] Crash closing master document (dbgutil)
https://bugs.documentfoundation.org/show_bug.cgi?id=144284 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet --- Just for the record, on pc Debian x86-64 with master sources updated today (e4b1ba9447a0a56aa56400f9f44d8eecb6c11e9c) + enable-dbgutil + kf5 rendering, I don't reproduce this. I tried with responding No then a second time Yes to save the document when closing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144286] My new version WRITER 7.2.0 no longer accepts the integration of a screenshot made with another software package (including a screenshot made in a document created with
https://bugs.documentfoundation.org/show_bug.cgi?id=144286 Julien Nabet changed: What|Removed |Added Summary|My new version WRTIER 7.2.0 |My new version WRITER 7.2.0 |no longer accepts the |no longer accepts the |integration of a screenshot |integration of a screenshot |made with another software |made with another software |package (including a|package (including a |screenshot made in a|screenshot made in a |document created with |document created with |WRITER 7.2.0) |WRITER 7.2.0) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144273] Spell check fails on document template
https://bugs.documentfoundation.org/show_bug.cgi?id=144273 Uwe Auer changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||144276 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144276 [Bug 144276] WEBSERVICE function to certain external URL results in #VALUE! error -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144276] WEBSERVICE function to certain external URL results in #VALUE! error
https://bugs.documentfoundation.org/show_bug.cgi?id=144276 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||108827 CC||79045_79...@mail.ru Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/plugin.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit cac7c02f52204eb3cea0a8594ed2d2c9313d4ede Author: Noel Grandin AuthorDate: Fri Sep 3 14:43:20 2021 +0200 Commit: Noel Grandin CommitDate: Fri Sep 3 18:18:09 2021 +0200 remove debugging leftover from commit 8a54339fc83fe9abaaace6f9f374697e6923d684 loplugin:referencecasting look through more clang Types Change-Id: I6a8a4bbce04d6f53d8e02961c0917bb57fb69a9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121601 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/compilerplugins/clang/plugin.cxx b/compilerplugins/clang/plugin.cxx index 6f7c464aa161..552f676735d3 100644 --- a/compilerplugins/clang/plugin.cxx +++ b/compilerplugins/clang/plugin.cxx @@ -11,7 +11,6 @@ #include "plugin.hxx" -#include #include #include #include
[Libreoffice-bugs] [Bug 144258] Left Area Header is not editable
https://bugs.documentfoundation.org/show_bug.cgi?id=144258 --- Comment #2 from Gabor Kelemen --- Created attachment 174763 --> https://bugs.documentfoundation.org/attachment.cgi?id=174763=edit Screenshot of the Headers/Footers dialog in current Calc master It can be edited on the Footer tab, but whatever you type there is mirrored on the Header tab when you switch back, but on the Footer tab the text can not be edited. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144258] Left Area Header is not editable
https://bugs.documentfoundation.org/show_bug.cgi?id=144258 Gabor Kelemen changed: What|Removed |Added Keywords||bibisected, bisected, ||regression Status|UNCONFIRMED |NEW CC||szymon.k...@collabora.com Ever confirmed|0 |1 --- Comment #1 from Gabor Kelemen --- Confirming with Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 34a9f93018804044b756e0e49c7ea759a65d3dc4 CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded GTK only, not gen/qt5. Not yet in 7.0. Bibisected with linux-64-7.1 to: https://git.libreoffice.org/core/+/f7b2e98bb76d2ce37ddc886ab503c6b160d8849d commit f7b2e98bb76d2ce37ddc886ab503c6b160d8849d[log] author Szymon Kłos Wed Jul 01 09:02:17 2020 +0200 committer Szymon Kłos Fri Jul 03 07:39:49 2020 +0200 gtk3: receive mouse events on drawing area Adding CC to: Szymon Kłos -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144286] My new version WRTIER 7.2.0 no longer accepts the integration of a screenshot made with another software package (including a screenshot made in a document created with
https://bugs.documentfoundation.org/show_bug.cgi?id=144286 André MAMAN changed: What|Removed |Added Summary|Mt new version WRTIER 7.2.0 |My new version WRTIER 7.2.0 |no longer accepts the |no longer accepts the |integration of a screenshot |integration of a screenshot |made with another software |made with another software |package (including a|package (including a |screenshot made in a|screenshot made in a |document created with |document created with |WRITER 7.2.0) |WRITER 7.2.0) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144286] New: Mt new version WRTIER 7.2.0 no longer accepts the integration of a screenshot made with another software package (including a screenshot made in a document created
https://bugs.documentfoundation.org/show_bug.cgi?id=144286 Bug ID: 144286 Summary: Mt new version WRTIER 7.2.0 no longer accepts the integration of a screenshot made with another software package (including a screenshot made in a document created with WRITER 7.2.0) Product: LibreOffice Version: 7.2.0.2 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: andre.mama...@gmail.com Subject: Difficulties creating a new Bug report Recipients: bugzilla-dae...@bugs.documentfoundation.org For over an hour I have been trying to communicate to you an anomaly that I noticed in your "LibreOfficeWriter" software package, and I am unable to do so because I do not understand your answer or your instructions. I therefore summarize my attempts and my explanations: 1- I have been using the version of WRITER (7.2.0) since August 19, 2021. 2- This new version no longer accepts the integration of a screenshot made with another software package (including a screenshot made in a document created with WRITER 7.2.0) 3- I logged into your site and viewed the list of already registered bugs. 4 - I have looked at the bug reports similar to the anomaly I found, referenced: 128583 5- I tried to summarize the above in an email, after opening an account with my email address in the Bugzilla app 6- I received an email from LibreOffice providing me with a link to be able to create my bug report 7- I tried to create a new bug report, but the answer was: ‘’The token you submitted does not exist, has expired, or has been canceled.’’ And an instruction was sent: Please press Back and try again. 8- I did not understand which [Back] key to use on a French keyboard and I therefore tried to ask you for an explanation using the link provided: bugzilla-dae...@bugs.documentfoundation.org 9- But an error response came back to me: ‘’Recipient address rejected: You replied to a Bugzilla notification email. However email replies are not added to bug reports. ’’ 10-I don't know what to do anymore! My question is very simple: What should I do to remedy the bug cited and already recorded in the bug list? I specify that I do not understand one of the instructions provided by consulting the Detail of the bug similar to the one I observed. This similar bug is referenced: 128583. The instruction in question is: Download the attachment. But what to do after downloading this attachment? Thank you for your response by return email, Best regards, -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9e3cacbe9616a14e1df66c31485e3bcbfdc8fd01 Author: Rafael Lima AuthorDate: Fri Sep 3 17:50:09 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Sep 3 17:50:09 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 9b8c44b49d1f732e51673804c28a8b606596630b - Create guide about Calc macros to format cell borders This patch is a follow-up to a previous revert: https://gerrit.libreoffice.org/c/help/+/121554 This patch uses the correct path for the new file "calc_borders.xhp". Change-Id: I4eb72db1ef8f5d964905be46dcb645dbd4e28e67 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121556 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 844431301fc0..9b8c44b49d1f 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 844431301fc078c697a22b332531369caa00612b +Subproject commit 9b8c44b49d1f732e51673804c28a8b606596630b
[Libreoffice-commits] help.git: AllLangHelp_sbasic.mk source/auxiliary source/text
AllLangHelp_sbasic.mk |1
source/auxiliary/sbasic.tree |1
source/text/sbasic/guide/calc_borders.xhp | 248 ++
3 files changed, 250 insertions(+)
New commits:
commit 9b8c44b49d1f732e51673804c28a8b606596630b
Author: Rafael Lima
AuthorDate: Fri Sep 3 17:01:52 2021 +0200
Commit: Olivier Hallot
CommitDate: Fri Sep 3 17:50:08 2021 +0200
Create guide about Calc macros to format cell borders
This patch is a follow-up to a previous revert:
https://gerrit.libreoffice.org/c/help/+/121554
This patch uses the correct path for the new file "calc_borders.xhp".
Change-Id: I4eb72db1ef8f5d964905be46dcb645dbd4e28e67
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/121556
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
diff --git a/AllLangHelp_sbasic.mk b/AllLangHelp_sbasic.mk
index fc3aca51c..dc978fef3 100644
--- a/AllLangHelp_sbasic.mk
+++ b/AllLangHelp_sbasic.mk
@@ -19,6 +19,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,sbasic,\
helpcontent2/source/text/sbasic/guide/access2base \
helpcontent2/source/text/sbasic/guide/basic_2_python \
helpcontent2/source/text/sbasic/guide/basic_examples \
+helpcontent2/source/text/sbasic/guide/calc_borders \
helpcontent2/source/text/sbasic/guide/control_properties \
helpcontent2/source/text/sbasic/guide/create_dialog \
helpcontent2/source/text/sbasic/guide/insert_control \
diff --git a/source/auxiliary/sbasic.tree b/source/auxiliary/sbasic.tree
index 9256c75d0..3902268c6 100644
--- a/source/auxiliary/sbasic.tree
+++ b/source/auxiliary/sbasic.tree
@@ -375,6 +375,7 @@
Event-Driven Macros
%PRODUCTNAME Basic Programming
Examples
Calling Python Scripts from
Basic
+Formatting Borders in Calc with
Macros
Access2Base, the API for Base
users
diff --git a/source/text/sbasic/guide/calc_borders.xhp
b/source/text/sbasic/guide/calc_borders.xhp
new file mode 100644
index 0..6ca63b619
--- /dev/null
+++ b/source/text/sbasic/guide/calc_borders.xhp
@@ -0,0 +1,248 @@
+
+
+
+
+
+
+Formatting Borders in Calc with
Macros
+/text/sbasic/guide/calc_borders.xhp
+
+
+
+
+
+macros;format borders
+
+ Formatting
Borders in Calc with Macros
+ By using Basic or
Python programming languages it is possible to write macros that apply formats
to ranges of cells in Calc.
+
+ Formatting Borders in Ranges of Cells
+ The code snippet
below creates a Sub called
FormatCellBorder that applies new border formats to a given
range address in the current Calc sheet.
+
+Sub
FormatCellBorder(cellAddress as String, newStyle as Byte, newWidth as Long,
Optional newColor as Long)
+' Creates the UNO
struct that will store the new line format
+
Dim lineFormat as New com.sun.star.table.BorderLine2
+
lineFormat.LineStyle = newStyle
+
lineFormat.LineWidth = newWidth
+
If Not IsMissing(newColor) Then lineFormat.Color = newColor
+' Gets the target
cell
+
Dim oCell as Object
+
Set oCell =
ThisComponent.CurrentController.ActiveSheet.getCellRangeByName(cellAddress)
+' Applies the new
format to all borders
+
oCell.TopBorder = lineFormat
+
oCell.RightBorder = lineFormat
+
oCell.LeftBorder = lineFormat
+
oCell.BottomBorder = lineFormat
+End
Sub
+
+ The
Sub described above takes in four arguments:
+
+
+cellAddress is a string such as denoting the range
to be formatted in the format "A1".
+
+
+newStyle is an integer value that corresponds to
the border line style (see Line Styles below).
+
+
+newWidth is an integer value that defines the line
width.
+
+
+newColor is an integer value corresponding to a
color defined using the RGB function.
+
+
+ To call
FormatCellBorder create a new macro and pass the desired
arguments, as shown below:
+
+Sub
MyMacro
+' Gives access to
the line style constants
+
Dim cStyle as Object
+
Set cStyle = com.sun.star.table.BorderLineStyle
+' Formats "B5"
with solid blue borders
+
FormatCellBorder("B5", cStyle.SOLID, 20, RGB(0, 0, 255))
+' Formats all
borders in the range "D2:F6" with red dotted borders
+
FormatCellBorder("D2:F6", cStyle.DOTTED, 20, RGB(255, 0, 0))
+End
Sub
+
+ It is possible to
implement the same functionality in Python:
+
+from
uno import createUnoStruct
+from
scriptforge import CreateScriptService
+
+def
formatCellBorder(cellAddress, newStyle, newWidth, newColor=0):
+# Defines the new
line format
+
line_format = createUnoStruct("com.sun.star.table.BorderLine2")
+
line_format.LineStyle = newStyle
+
line_format.LineWidth = newWidth
+
line_format.Color = newColor
+
[Libreoffice-bugs] [Bug 61242] Customise comments background color in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=61242 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Alias|Devium | Hardware|x86-64 (AMD64) |All OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/uiwriter2.cxx | 34 ++
1 file changed, 34 insertions(+)
New commits:
commit 1c0965148edb2a053e8e4a6762d917326fc332a2
Author: László Németh
AuthorDate: Fri Sep 3 09:51:05 2021 +0200
Commit: László Németh
CommitDate: Fri Sep 3 17:42:13 2021 +0200
tdf#143215 sw: test tracked deletion of empty table rows
Only the test document was added to the previous fix.
Follow-up of commit a483a44ca00f43a64ae51d62b8fbb4129a413f6d
"tdf#143215 DOCX import: fix tracked empty row insertion/deletion".
Change-Id: If39da56e16e56a9322a35259f5984726abe0da40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121549
Tested-by: Jenkins
Reviewed-by: László Németh
diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index 1b1a1f73be92..ee9039b8039b 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -4465,6 +4465,40 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2,
testRedlineDOCXTableMoveToFrame)
CPPUNIT_ASSERT(!xTableNames->hasByName("Table2"));
}
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf143215)
+{
+// load a table with tracked insertion of an empty row
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "TC-table-rowadd.docx");
+
+uno::Reference xTextTablesSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Reference
xTables(xTextTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+// check table count
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables->getCount());
+
+// check table row count
+uno::Reference xTable(xTables->getByIndex(0),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+
+// reject insertion of the empty table row
+IDocumentRedlineAccess& rIDRA(pDoc->getIDocumentRedlineAccess());
+rIDRA.AcceptAllRedline(false);
+// This was 4 (remained empty row)
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xTable->getRows()->getCount());
+
+// Undo and accept insertion of the table row
+dispatchCommand(mxComponent, ".uno:Undo", {});
+rIDRA.AcceptAllRedline(true);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+
+// delete it with change tracking, and accept the deletion
+dispatchCommand(mxComponent, ".uno:DeleteRows", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+rIDRA.AcceptAllRedline(true);
+// This was 4 (remained empty row)
+CPPUNIT_ASSERT_EQUAL(sal_Int32(3), xTable->getRows()->getCount());
+}
+
CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf128335)
{
// Load the bugdoc, which has 3 textboxes.
[Libreoffice-commits] core.git: include/vcl vcl/backendtest vcl/inc
include/vcl/test/GraphicsRenderTests.hxx | 16 +
vcl/backendtest/GraphicsRenderTests.cxx | 338 +++
vcl/backendtest/outputdevice/line.cxx| 26 +
vcl/backendtest/outputdevice/pixel.cxx | 26 +
vcl/backendtest/outputdevice/polygon.cxx | 27 +
vcl/backendtest/outputdevice/polyline.cxx| 27 +
vcl/backendtest/outputdevice/polyline_b2d.cxx| 26 +
vcl/backendtest/outputdevice/polypolygon.cxx | 32 ++
vcl/backendtest/outputdevice/polypolygon_b2d.cxx | 32 ++
vcl/backendtest/outputdevice/rectangle.cxx | 26 +
vcl/inc/test/outputdevice.hxx| 16 +
11 files changed, 592 insertions(+)
New commits:
commit a979f18254749acac4c71596c30dde9ad2908455
Author: homeboy445
AuthorDate: Fri Jul 23 16:06:51 2021 +0530
Commit: Tomaž Vajngerl
CommitDate: Fri Sep 3 17:35:53 2021 +0200
backendtest: Rectangle on wide surfaces Drawing test
This tests draws a rectangle using all possible drawing
methods for drawing a rectangle on a wide surface(1028x1028 and 4096x4096)
and check it the usual way.
Change-Id: I6fcf9c9b4b150cbe959b8151f327bcdce1b1139a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119464
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/include/vcl/test/GraphicsRenderTests.hxx
b/include/vcl/test/GraphicsRenderTests.hxx
index 41cbe561b483..7d44b538a948 100644
--- a/include/vcl/test/GraphicsRenderTests.hxx
+++ b/include/vcl/test/GraphicsRenderTests.hxx
@@ -127,6 +127,22 @@ class VCL_PLUGIN_PUBLIC GraphicsRenderTests
void testTextDrawing();
void testEvenOddRuleInIntersectingRectsWithPolyPolygon();
void testEvenOddRuleInIntersectingRectsWithPolyPolygonB2D();
+void testDrawRectangleOnSize1028WithRect();
+void testDrawRectangleOnSize4096WithRect();
+void testDrawRectangleOnSize1028WithPixel();
+void testDrawRectangleOnSize4096WithPixel();
+void testDrawRectangleOnSize1028WithLine();
+void testDrawRectangleOnSize4096WithLine();
+void testDrawRectangleOnSize1028WithPolygon();
+void testDrawRectangleOnSize4096WithPolygon();
+void testDrawRectangleOnSize1028WithPolyLine();
+void testDrawRectangleOnSize4096WithPolyLine();
+void testDrawRectangleOnSize1028WithPolyLineB2D();
+void testDrawRectangleOnSize4096WithPolyLineB2D();
+void testDrawRectangleOnSize1028WithPolyPolygon();
+void testDrawRectangleOnSize4096WithPolyPolygon();
+void testDrawRectangleOnSize1028WithPolyPolygonB2D();
+void testDrawRectangleOnSize4096WithPolygonPolygonB2D();
static OUString returnTestStatus(vcl::test::TestResult const result);
void runALLTests();
void appendTestResult(OUString aTestName, OUString aTestStatus, Bitmap
aTestBitmap = Bitmap());
diff --git a/vcl/backendtest/GraphicsRenderTests.cxx
b/vcl/backendtest/GraphicsRenderTests.cxx
index ad508ec6d975..7928c06e2fb0 100644
--- a/vcl/backendtest/GraphicsRenderTests.cxx
+++ b/vcl/backendtest/GraphicsRenderTests.cxx
@@ -1693,6 +1693,328 @@ void GraphicsRenderTests::testDrawBlend32bpp()
}
}
+void GraphicsRenderTests::testDrawRectangleOnSize1028WithRect()
+{
+vcl::test::OutputDeviceTestRect aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupRectangleOnSize1028();
+m_aCurGraphicsBackend = aOutDevTest.getRenderBackendName();
+OUString aTestName = "testDrawRectangleOnSize1028WithRect";
+if (!SHOULD_ASSERT)
+{
+appendTestResult(aTestName, "SKIPPED");
+return;
+}
+vcl::test::TestResult eResult =
vcl::test::OutputDeviceTestCommon::checkRectangle(aBitmap);
+appendTestResult(aTestName, returnTestStatus(eResult),
+ (m_aStoreResultantBitmap ? aBitmap : Bitmap()));
+if (m_aStoreResultantBitmap)
+{
+BitmapEx aBitmapEx(aBitmap);
+exportBitmapExToImage(m_aUserInstallPath + aTestName + ".png",
aBitmapEx);
+}
+}
+
+void GraphicsRenderTests::testDrawRectangleOnSize4096WithRect()
+{
+vcl::test::OutputDeviceTestRect aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupRectangleOnSize4096();
+m_aCurGraphicsBackend = aOutDevTest.getRenderBackendName();
+OUString aTestName = "testDrawRectangleOnSize4096WithRect";
+if (!SHOULD_ASSERT)
+{
+appendTestResult(aTestName, "SKIPPED");
+return;
+}
+vcl::test::TestResult eResult =
vcl::test::OutputDeviceTestCommon::checkRectangle(aBitmap);
+appendTestResult(aTestName, returnTestStatus(eResult),
+ (m_aStoreResultantBitmap ? aBitmap : Bitmap()));
+if (m_aStoreResultantBitmap)
+{
+BitmapEx aBitmapEx(aBitmap);
+exportBitmapExToImage(m_aUserInstallPath + aTestName + ".png",
aBitmapEx);
+}
+}
+
+void GraphicsRenderTests::testDrawRectangleOnSize1028WithPixel()
+{
+vcl::test::OutputDeviceTestPixel aOutDevTest;
+Bitmap aBitmap = aOutDevTest.setupRectangleOnSize1028();
+OUString aTestName =
[Libreoffice-bugs] [Bug 144285] LibreOffice 7.2.0.4 crash on macOS always after launching and work
https://bugs.documentfoundation.org/show_bug.cgi?id=144285 Alex Thurgood changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Alex Thurgood --- @Jan : could you provide us a little more information : - do you have any LibreOffice extensions installed, and if so, which ones ? - do you have any JDK installed, and if so, which one is declared/recognized by LO under the Preferences > Advanced dialog ? - do you have any macOS accessibility features activated, e.g. screen reader, screen magnifier, dictation, etc. Unfortunately, I can not reproduce the behaviour that you have reported on my Mac (OS 11.5.2 Arm M1) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/source
sw/source/uibase/uiview/view2.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 48beccf52413981d3d1c525a81a2c57048abe261
Author: Miklos Vajna
AuthorDate: Fri Sep 3 09:28:39 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 3 17:31:21 2021 +0200
sw: fix crash in SwView::Execute()
Crashreport:
program/../program/libswlo.so
SwView::Execute(SfxRequest&)
sw/source/uibase/uiview/view2.cxx:1312
program/libmergedlo.so
SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&,
SfxRequest&, bool)
sfx2/source/control/dispatch.cxx:263
/opt/collaboraoffice6.4/program/libmergedlo.so
SfxDispatcher::Execute_(SfxShell&, SfxSlot const&,
SfxRequest&, SfxCallMode)
sfx2/source/control/dispatch.cxx:760 (discriminator
3)
/opt/collaboraoffice6.4/program/libmergedlo.so
SfxDispatcher::Execute(unsigned short, SfxCallMode,
SfxItemSet const*, SfxItemSet const*, unsigned short)
sfx2/source/control/dispatch.cxx:819
Change-Id: I2e7b27f458971dbd33971589f71337c59981ee83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121547
Reviewed-by: Michael Meeks
Tested-by: Jenkins CollaboraOffice
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121604
Reviewed-by: Miklos Vajna
diff --git a/sw/source/uibase/uiview/view2.cxx
b/sw/source/uibase/uiview/view2.cxx
index a9dbb22b904a..7c342e761a69 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -1360,6 +1360,11 @@ void SwView::Execute(SfxRequest )
const sal_uLong newPosY = newPosYTwips->GetValue();
const Point mPoint(newPosX, newPosY);
const SdrHdl* handle =
pSdrView->GetHdlList().GetHdl(handleNum);
+if (!handle)
+{
+break;
+}
+
if (handle->GetKind() == SdrHdlKind::Anchor ||
handle->GetKind() == SdrHdlKind::Anchor_TR)
m_pWrtShell->FindAnchorPos(mPoint, /*bMoveIt=*/true);
else
[Libreoffice-ux-advise] [Bug 143956] Writer Templates are in Format Size A4 instead of Letter for Default - English (USA)
https://bugs.documentfoundation.org/show_bug.cgi?id=143956 --- Comment #8 from Laurent BP --- Created attachment 174762 --> https://bugs.documentfoundation.org/attachment.cgi?id=174762=edit New set for Styles templates without page size This second file contains 3 templates to replace "styles" Writer templates: Modern, Default and Simple. Could you test them to check if page size is correctly defined according to your locale settings? Check [4] for other updates [4] https://gerrit.libreoffice.org/c/core/+/121610 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144285] New: LibreOffice 7.2.0.4 crash on macOS always after launching and work
https://bugs.documentfoundation.org/show_bug.cgi?id=144285 Bug ID: 144285 Summary: LibreOffice 7.2.0.4 crash on macOS always after launching and work Product: LibreOffice Version: 7.2.0.4 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jan.ga...@web.de Description: After updating LibreOffice to version 7.2.0.4 i noticed that i cannot work with LibreOffice anymore. For example i creat a new document, type some letters and i get the beachball. I need to kill LibreOffice and restart. Type more letters, same affect. All about, LibreOffice is not usable with that symptoms. Freezing in every situation. i've used writer and calc. Steps to Reproduce: 1. start LibreOffice 2. create new document 3. type some letters or just wait until freezing Actual Results: LibreOffice is freezing, no reaction. Need to be killed. Expected Results: no freezing Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.4 / LibreOffice Community Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx Locale: de-DE (de_DE.UTF-8); UI: de-DE Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142129] Exported PDF of master document with hidden sections containing headings shows headings anyway
https://bugs.documentfoundation.org/show_bug.cgi?id=142129 Aron Budea changed: What|Removed |Added CC||ba...@caesar.elte.hu Whiteboard||target:7.2.0 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0863 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140863] Error hiding and unhiding sections
https://bugs.documentfoundation.org/show_bug.cgi?id=140863 Aron Budea changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2129 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144277] setting a hyperlink changes the character size
https://bugs.documentfoundation.org/show_bug.cgi?id=144277 --- Comment #2 from tor...@yahoo.com --- (In reply to V Stuart Foote from comment #1) > check settings for character styles -- 'Internet Link' and 'Visited Internet > Link' -- which you've applied by creating a Hyperlink pointing to the > bookmark. > > Adjust their size to match the formatting applied to default paragraph and > they won't resize. OK. But, this is weird and unexpected. ● Why apply InternetLink style where Internet is not involved? ● Adjusting by-hand the LinkStyle to match the local one (as to size or other parameters) is impractical and contrary to the style concept. Suggestion: if LinkStyle definition is Organizer>InheritFrom>None, then the Font tab should be absent from the characterStyle dialogue; only FontEffects should be available to characterize a link. (Similarly, under Tools>ChapterNumbering/numbering, setting characterStyle to None will match the corresponding heading characterStyle.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: emfio/source
emfio/source/reader/wmfreader.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e2dc002db806d76288c79c9acc30911456138289
Author: Caolán McNamara
AuthorDate: Fri Sep 3 09:35:55 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 16:50:35 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I6546ef38c6e84193c00ea5fcac621fdec93e0ab7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121593
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/emfio/source/reader/wmfreader.cxx
b/emfio/source/reader/wmfreader.cxx
index 5c8a4d095a39..7f664aaa63ec 100644
--- a/emfio/source/reader/wmfreader.cxx
+++ b/emfio/source/reader/wmfreader.cxx
@@ -826,7 +826,7 @@ namespace emfio
mpInputStream->ReadInt16( nBitmapType ).ReadInt16( nWidth
).ReadInt16( nHeight ).ReadInt16( nBytesPerScan ).ReadUChar( nPlanes
).ReadUChar( nBitCount );
SAL_INFO("emfio", "\t\t Bitmap type:" << nBitmapType << "
Width:" << nWidth << " Height:" << nHeight << " WidthBytes:" << nBytesPerScan
<< " Planes: " << static_cast< sal_uInt16 >( nPlanes ) << " BitCount: " <<
static_cast< sal_uInt16 >( nBitCount ) );
-if ( bNoSourceBitmap || ( nBitCount == 4 ) || ( nBitCount == 8
) || nPlanes != 1 )
+if (!mpInputStream->good() || bNoSourceBitmap || nBitCount ==
4 || nBitCount == 8 || nPlanes != 1)
{
SAL_WARN("emfio", "\t\t TODO The unsupported Bitmap
record. Please fill a bug.");
break;
[Libreoffice-commits] core.git: emfio/source
emfio/source/reader/emfreader.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit aeccf731466bc44ce750bbeb8a86ccf309a12027
Author: Caolán McNamara
AuthorDate: Fri Sep 3 09:50:57 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 16:49:27 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I626eb1847484f7bc6af7eed45b891307718c5263
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121596
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/emfio/source/reader/emfreader.cxx
b/emfio/source/reader/emfreader.cxx
index 68ff6752b69d..b5b86ef894a2 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -462,7 +462,7 @@ namespace emfio
{
tools::Rectangle aOutputRect = EmfReader::ReadRectangle();
-sal_uInt32 nCountFormats;
+sal_uInt32 nCountFormats(0);
mpInputStream->ReadUInt32(nCountFormats);
if (nCountFormats < 1)
{
@@ -2325,7 +2325,7 @@ namespace emfio
tools::Rectangle EmfReader::ReadRectangle()
{
-sal_Int32 nLeft, nTop, nRight, nBottom;
+sal_Int32 nLeft(0), nTop(0), nRight(0), nBottom(0);
mpInputStream->ReadInt32(nLeft);
mpInputStream->ReadInt32(nTop);
mpInputStream->ReadInt32(nRight);
[Libreoffice-commits] core.git: sd/source
sd/source/filter/ppt/pptinanimations.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit fae7e172e2f7585ed633c9c6328fd25e2f5dd6df
Author: Caolán McNamara
AuthorDate: Fri Sep 3 09:47:52 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 16:49:05 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I47934f5a6b34ef0f495098f78c53c088bf5152e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121595
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sd/source/filter/ppt/pptinanimations.cxx
b/sd/source/filter/ppt/pptinanimations.cxx
index d03efbc87980..cff1e2d898dd 100644
--- a/sd/source/filter/ppt/pptinanimations.cxx
+++ b/sd/source/filter/ppt/pptinanimations.cxx
@@ -2241,7 +2241,7 @@ bool AnimationImporter::importAttributeValue( const Atom*
pAtom, Any& rAny )
sal_uInt32 nRecLen = pAtom->getLength();
if ( nRecLen >= 1 )
{
-sal_Int8 nType;
+sal_Int8 nType(0);
mrStCtrl.ReadSChar( nType );
switch( nType )
{
[Libreoffice-bugs] [Bug 123959] Please bring back systray quickstarter for Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=123959 soltesz.and...@gmail.com changed: What|Removed |Added Resolution|WONTFIX |--- Status|RESOLVED|REOPENED Ever confirmed|0 |1 --- Comment #6 from soltesz.and...@gmail.com --- IMHO, removing the Quickstarter for Linux was a huge mistake and resulted in a big performance regression for LibreOffice 6.1+. It doesn't matter if the previous solution worked perfectly or not, it gave a pretty big performance boost for LibreOffice on Linux systems. Nobody cares if it wasn't visible as an tray icon, the performance boost was its main function and reason for existence. With the Quickstarter in LibreOffice 5.x, spreadsheet and text document opening operations were done in ~1 second on my 6 year old system (still fairly powerful, 8-core AMD FX8150, 24 GB RAM, nvme SSD...etc). The same operation now takes 3-4 seconds with LibreOffice v6.4.7 (doesn't seem better on v7.x either). It also doesn't get much better for second and third file openings. This makes day-to-day work with LibreOffice very bad on Linux desktops and makes it massively sub-par compared to the Windows version. Please, reconsider implementing a new Quickstarter for Linux or bring back the old one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 111928] [META] Quickstarter-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=111928 Bug 111928 depends on bug 123959, which changed state. Bug 123959 Summary: Please bring back systray quickstarter for Linux https://bugs.documentfoundation.org/show_bug.cgi?id=123959 What|Removed |Added Status|RESOLVED|REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa
vcl/qa/cppunit/complextext.cxx |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
New commits:
commit 3b6b93e40e079d0fc93c68fbb28da0be696c2566
Author: Hossein
AuthorDate: Sun Aug 29 19:55:09 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 3 16:28:54 2021 +0200
Fixing Unicode Arabic Literals
Some Unicode literals are now available inside the LibreOffice code,
so I think we can use Arabic Unicode literals directly inside
LibreOffice code. It is more intuitive, and gives better insight to
those who develop to understand what a foreign language script should
look like.
This patch consists of two things: First, converting a Unicode literal
that was consisting of \u characters into an Arabic Unicode
literal; Second, fixing an Arabic literal that was converted to shaped
characters instead of normal Arabic characters.
Change-Id: I11003cc471b2c83098cb0ebc4f4085771a132ecc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121164
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/vcl/qa/cppunit/complextext.cxx b/vcl/qa/cppunit/complextext.cxx
index 176fc1ea9df6..a578cb71acef 100644
--- a/vcl/qa/cppunit/complextext.cxx
+++ b/vcl/qa/cppunit/complextext.cxx
@@ -59,9 +59,7 @@ public:
void VclComplexTextTest::testArabic()
{
#if HAVE_MORE_FONTS
-OUString aOneTwoThree(
-u"\u0648\u0627\u062d\u0650\u062f\u0652
\u0625\u062b\u064d\u0646\u064a\u0646"
-" \u062b\u0644\u0627\u062b\u0629\u064c" );
+OUString aOneTwoThree(u"واحِدْ إثٍنين ثلاثةٌ");
ScopedVclPtrInstance pWin(static_cast(nullptr));
CPPUNIT_ASSERT( pWin );
@@ -123,7 +121,7 @@ void VclComplexTextTest::testKashida()
// Cache the glyph list of some Arabic text.
ScopedVclPtrInstance pOutputDevice;
auto aText
-= OUString(u"ﻊﻨﺻﺭ ﺎﻠﻓﻮﺴﻓﻭﺭ ﻊﻨﺻﺭ ﻒﻟﺰﻳ ﺺﻠﺑ. ﺖﺘﻛﻮﻧ ﺎﻟﺩﻭﺭﺓ ﺎﻟﺭﺎﺒﻋﺓ ﻢﻧ ١٥
ﻊﻨﺻﺭﺍ.");
+= OUString(u"عنصر الفوسفور عنصر فلزي صلب. تتكون الدورة الرابعة من 15
عنصرا.");
std::unique_ptr pLayout = pOutputDevice->ImplLayout(
aText, 0, aText.getLength(), Point(0, 0), 0, nullptr,
SalLayoutFlags::GlyphItemsOnly);
SalLayoutGlyphs aGlyphs = pLayout->GetGlyphs();
[Libreoffice-bugs] [Bug 144275] Updated to 7.2.0.4 and now cannot perform either a "Save As…" or "Save a Copy…"
https://bugs.documentfoundation.org/show_bug.cgi?id=144275 Uwe Auer changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from Uwe Auer --- Did you provide Full Disk Access to Libreoffice.app? See also: https://ask.libreoffice.org/t/unable-to-save-or-save-as-any-document-even-in-safe-mode/53456 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/GraphicFormatDetector.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5dff497309fe6034318c75efd40bb480e34f331a
Author: Caolán McNamara
AuthorDate: Thu Sep 2 10:35:24 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 16:20:02 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I3a45c8141b9f824c985dcf1aaac5d1aa45c0f70d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121575
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/GraphicFormatDetector.cxx
b/vcl/source/filter/GraphicFormatDetector.cxx
index 264e6d9136c6..dafe7f5222b4 100644
--- a/vcl/source/filter/GraphicFormatDetector.cxx
+++ b/vcl/source/filter/GraphicFormatDetector.cxx
@@ -535,7 +535,7 @@ bool GraphicFormatDetector::checkPCD()
return false;
char sBuffer[8];
mrStream.Seek(mnStreamPosition + 2048);
-mrStream.ReadBytes(sBuffer, 7);
+sBuffer[mrStream.ReadBytes(sBuffer, 7)] = 0;
if (strncmp(sBuffer, "PCD_IPI", 7) == 0)
{
[Libreoffice-bugs] [Bug 143950] xxxxIF functions taking care of cell format to calculate. (Calc conditional formatting based on formula misfunction)
https://bugs.documentfoundation.org/show_bug.cgi?id=143950 Eike Rathke changed: What|Removed |Added Whiteboard|target:7.3.0 target:7.2.2 |target:7.3.0 target:7.2.2 ||target:7.2.1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144155] CALC Row operations over 100 times slower in 7.2 compared to 7.1
https://bugs.documentfoundation.org/show_bug.cgi?id=144155 Xisco Faulí changed: What|Removed |Added Status|RESOLVED|VERIFIED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103512] [META] AutoFilter-related bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103512 Bug 103512 depends on bug 144155, which changed state. Bug 144155 Summary: CALC Row operations over 100 times slower in 7.2 compared to 7.1 https://bugs.documentfoundation.org/show_bug.cgi?id=144155 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144155] CALC Row operations over 100 times slower in 7.2 compared to 7.1
https://bugs.documentfoundation.org/show_bug.cgi?id=144155 Xisco Faulí changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #9 from Xisco Faulí --- Verified in Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: e4b1ba9447a0a56aa56400f9f44d8eecb6c11e9c CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Closing as VERIFIED FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/vector/vector-7.0-10.0' - sfx2/source
sfx2/source/doc/sfxbasemodel.cxx | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
New commits:
commit 1178a5d8a6ae65c9336c71f481e19505d901227a
Author: Miklos Vajna
AuthorDate: Tue Aug 31 17:18:59 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Sep 3 16:12:42 2021 +0200
sfx2: allow storeAsURL() on the main thread
This is similar to commit b030e83fccbff8d82a4c84462075baa8442cde54
(sfx2: allow storeToURL() on the main thread, 2019-02-05), just this
handles the 'export' case, not the 'save as' one.
Note that this already worked in some cases when impl_store() decided to
call storeSelf(), but vcl::solarthread::syncExecute() already avoids
dispatch when called on a non-main thread, so that is not a problem.
Change-Id: Ief09ba6c60923c7f16d86f61625c0faa9a5f829b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121385
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit 5d0860ed0600904a03459e8bf5a6792c671463a4)
(cherry picked from commit 1e7a4b148a384a408662015da7fc701a24917a2f)
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 533650751d75..adcea5aaf752 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -1680,7 +1680,16 @@ void SAL_CALL SfxBaseModel::storeAsURL( const
OUString& rURL
SfxSaveGuard aSaveGuard(this, m_pData.get());
-impl_store( rURL, rArgs, false );
+utl::MediaDescriptor aDescriptor(rArgs);
+bool bOnMainThread = aDescriptor.getUnpackedValueOrDefault("OnMainThread",
false);
+if (bOnMainThread)
+{
+vcl::solarthread::syncExecute([this, rURL, rArgs]() { impl_store(rURL,
rArgs, false); });
+}
+else
+{
+impl_store(rURL, rArgs, false);
+}
Sequence< beans::PropertyValue > aSequence ;
TransformItems( SID_OPENDOC,
*m_pData->m_pObjectShell->GetMedium()->GetItemSet(), aSequence );
[Libreoffice-commits] core.git: emfio/source
emfio/source/reader/emfreader.cxx | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
New commits:
commit 5efd4c0a78633da563468f60c36c34a375584393
Author: Caolán McNamara
AuthorDate: Thu Sep 2 10:31:56 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 16:11:13 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I6cd0e9b518bf6f40e0221fd2e9f3c5fb6199e14f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121574
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/emfio/source/reader/emfreader.cxx
b/emfio/source/reader/emfreader.cxx
index 758a3220d517..68ff6752b69d 100644
--- a/emfio/source/reader/emfreader.cxx
+++ b/emfio/source/reader/emfreader.cxx
@@ -2112,10 +2112,25 @@ namespace emfio
.WriteUInt16( 0 )
.WriteUInt16( 0 )
.WriteUInt32( cbBmi + 14 );
+
mpInputStream->Seek( nStart + offBmi );
-mpInputStream->ReadBytes(pBuf + 14, cbBmi);
+char* pWritePos = pBuf + 14;
+auto nRead =
mpInputStream->ReadBytes(pWritePos, cbBmi);
+if (nRead != cbBmi)
+{
+// zero remainder if short read
+memset(pWritePos + nRead, 0, cbBmi -
nRead);
+}
+
mpInputStream->Seek( nStart + offBits );
-mpInputStream->ReadBytes(pBuf + 14 +
cbBmi, cbBits);
+pWritePos = pBuf + 14 + cbBmi;
+nRead =
mpInputStream->ReadBytes(pWritePos, cbBits);
+if (nRead != cbBits)
+{
+// zero remainder if short read
+memset(pWritePos + nRead, 0, cbBits -
nRead);
+}
+
aTmp.Seek( 0 );
ReadDIB(aBitmap, aTmp, true);
}
[Libreoffice-bugs] [Bug 144273] Spell check fails on document template
https://bugs.documentfoundation.org/show_bug.cgi?id=144273 --- Comment #2 from Forrest Aldrich --- Created attachment 174761 --> https://bugs.documentfoundation.org/attachment.cgi?id=174761=edit This is the sample template that I used. This is the sample template that I used. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/bitmap/dibtools.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit aa9e05236b73067e34d34d9861fc394ba854399b Author: Caolán McNamara AuthorDate: Thu Sep 2 15:07:53 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Sep 3 16:09:27 2021 +0200 ofz: MemorySanitizer: use-of-uninitialized-value Change-Id: I9f67d463958e3b3ce88b771dd8ca0f71f7393e32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121537 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/vcl/source/bitmap/dibtools.cxx b/vcl/source/bitmap/dibtools.cxx index 6665d09daa41..296be1dc1def 100644 --- a/vcl/source/bitmap/dibtools.cxx +++ b/vcl/source/bitmap/dibtools.cxx @@ -256,7 +256,7 @@ bool ImplReadDIBInfoHeader(SvStream& rIStm, DIBV5Header& rHeader, bool& bTopDown return false; } -if (rHeader.nHeight == SAL_MIN_INT32) +if (!rIStm.good() || rHeader.nHeight == SAL_MIN_INT32) return false; if ( rHeader.nHeight < 0 )
[Libreoffice-bugs] [Bug 143601] French Langpack for 7.1.5 and 7.2.0.4 invalid causing installation to fail
https://bugs.documentfoundation.org/show_bug.cgi?id=143601 --- Comment #21 from MG --- (In reply to steve from comment #20) > @Roman: if you restart your mac, does the problem persist? Yes, i have done it several times. I have tried whith an old system version --> Yosemite 10.10.5 and it works I am now under High Sierra --> 10.13.6 and it does not work at all I just regret the LibreOffice 7.1.1 whicj was working in French under 10.13.6 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144155] CALC Row operations over 100 times slower in 7.2 compared to 7.1
https://bugs.documentfoundation.org/show_bug.cgi?id=144155 --- Comment #8 from Commit Notification --- Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/91eb9e16cd73df2249a24f949ea8bef62bbe2d09 tdf#144155: Revert "tdf#36383 sc AutoFilter: fix changing row height" It will be available in 7.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144155] CALC Row operations over 100 times slower in 7.2 compared to 7.1
https://bugs.documentfoundation.org/show_bug.cgi?id=144155 Commit Notification changed: What|Removed |Added Whiteboard|target:7.3.0|target:7.3.0 target:7.2.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sc/qa sc/source
sc/qa/uitest/autofilter/tdf36383.py | 68
sc/source/ui/view/viewfunc.cxx | 22 +--
2 files changed, 2 insertions(+), 88 deletions(-)
New commits:
commit 91eb9e16cd73df2249a24f949ea8bef62bbe2d09
Author: Xisco Fauli
AuthorDate: Thu Sep 2 15:29:21 2021 +0200
Commit: Xisco Fauli
CommitDate: Fri Sep 3 16:06:14 2021 +0200
tdf#144155: Revert "tdf#36383 sc AutoFilter: fix changing row height"
This reverts commit 3678e0efcb8bedc58dd329a430da0ac3b1572df8.
Conflicts: sc/qa/uitest/autofilter/tdf36383.py
Change-Id: Ie1abd0cdea013571a27b187ffcb20125a0656442
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121512
Reviewed-by: László Németh
Tested-by: Jenkins
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121550
diff --git a/sc/qa/uitest/autofilter/tdf36383.py
b/sc/qa/uitest/autofilter/tdf36383.py
deleted file mode 100644
index d55db21837b3..
--- a/sc/qa/uitest/autofilter/tdf36383.py
+++ /dev/null
@@ -1,68 +0,0 @@
-# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-from uitest.framework import UITestCase
-from uitest.uihelper.calc import enter_text_to_cell
-from libreoffice.uno.propertyvalue import mkPropertyValues
-from libreoffice.calc.document import get_row
-
-#Bug 36383 - EDITING auto row height or change row height removes AutoFilter
result
-
-class tdf36383(UITestCase):
-def test_tdf36383_row_height(self):
-self.ui_test.create_doc_in_start_center("calc")
-document = self.ui_test.get_component()
-calcDoc = self.xUITest.getTopFocusWindow()
-gridwin = calcDoc.getChild("grid_window")
-document = self.ui_test.get_component()
-
-enter_text_to_cell(gridwin, "A1", "A")
-enter_text_to_cell(gridwin, "A2", "1")
-enter_text_to_cell(gridwin, "A3", "2")
-enter_text_to_cell(gridwin, "A4", "3")
-
-gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": "A1:A4"}))
-
-self.xUITest.executeCommand(".uno:DataFilterAutoFilter")
-
-gridwin.executeAction("LAUNCH", mkPropertyValues({"AUTOFILTER": "",
"COL": "0", "ROW": "0"}))
-xFloatWindow = self.xUITest.getFloatWindow()
-xCheckListMenu = xFloatWindow.getChild("check_list_menu")
-xList = xCheckListMenu.getChild("check_list_box")
-xEntry = xList.getChild("1")
-xEntry.executeAction("CLICK", tuple())
-
-xOkButton = xFloatWindow.getChild("ok")
-xOkButton.executeAction("CLICK", tuple())
-
-row = get_row(document, 2)
-self.assertFalse(row.getPropertyValue("IsVisible"))
-
-#row height
-self.ui_test.execute_dialog_through_command(".uno:RowHeight")
-xDialog = self.xUITest.getTopFocusWindow()
-xvalue = xDialog.getChild("value")
-xvalue.executeAction("TYPE", mkPropertyValues({"KEYCODE":"CTRL+A"}))
-xvalue.executeAction("TYPE", mkPropertyValues({"KEYCODE":"BACKSPACE"}))
-xvalue.executeAction("TYPE", mkPropertyValues({"TEXT":"1 cm"}))
-
-xOk = xDialog.getChild("ok")
-self.ui_test.close_dialog_through_button(xOk)
-
-self.assertFalse(row.getPropertyValue("IsVisible"))
-
-#optimal row height
-self.ui_test.execute_dialog_through_command(".uno:SetOptimalRowHeight")
-xDialog = self.xUITest.getTopFocusWindow()
-
-xOk = xDialog.getChild("ok")
-self.ui_test.close_dialog_through_button(xOk)
-
-self.assertFalse(row.getPropertyValue("IsVisible"))
-
-self.ui_test.close_doc()
-
-# vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index 718d8cd0e8c7..50606d80ad39 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -2177,17 +2177,7 @@ void ScViewFunc::SetWidthOrHeight(
aCxt.setExtraHeight(nSizeTwips);
rDoc.SetOptimalHeight(aCxt, nStartNo, nEndNo, nTab, true);
if (bAll)
-{
-for (SCROW nRow = nStartNo; nRow <= nEndNo; ++nRow)
-{
-SCROW nLastRow = nRow;
-// tdf#36383 skip consecutive rows hidden by
AutoFilter
-if (rDoc.RowFiltered(nRow, nTab, nullptr,
))
-nRow = nLastRow;
-else
-rDoc.ShowRow(nRow, nTab, true);
-}
-}
+rDoc.ShowRows( nStartNo, nEndNo, nTab, true );
// Manual-Flag already (re)set in SetOptimalHeight in
case of
[Libreoffice-commits] core.git: Branch 'libreoffice-7-2-1' - include/svl sc/source svl/source
include/svl/zformat.hxx | 11 ---
sc/source/core/data/documen4.cxx | 17 +
svl/source/numbers/zformat.cxx | 16
3 files changed, 37 insertions(+), 7 deletions(-)
New commits:
commit eedfa91e777423cb3cd025c8eafd7e031c98f6b9
Author: Eike Rathke
AuthorDate: Wed Sep 1 15:35:11 2021 +0200
Commit: Caolán McNamara
CommitDate: Fri Sep 3 16:05:49 2021 +0200
Resolves: tdf#144209 Handle General containing formats in
RoundValueAsShown()
Calling SvNumberformat::GetThousandDivisorPrecision() for a
"AA "General
format resulted in 3000 as that was implemented for tdf#106253
without taking into account that ImpSvNumberformatInfo::nThousand
may be abused under some conditions, which here is having
FLAG_STANDARD_IN_FORMAT = 1000 as nThousand, multiplied by 3 gives
3000. Subtracted from the 0 precision gave -3000 decimals for
which of course the new rounding produced 0 where it previously
simply ignored the decimals and returned the original value.
Change-Id: I66afaf1e2d8b2654d9f7cc8cfb66389357fb742d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121447
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 71b003a12f8afdff42a25786ad0a12ddd6609d59)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121460
Reviewed-by: Xisco Fauli
Reviewed-by: Michael Stahl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index 976488257218..abbf92e92af8 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -271,10 +271,15 @@ public:
{ return NumFor[nIx].Info().nCntPre; }
/** Count of hidden integer digits with thousands divisor:
- * formats like "0," to show only thousands
+formats like "0," to show only thousands.
+
+Works only with SvNumFormatType::NUMBER and SvNumFormatType::CURRENCY,
+returns 0 otherwise.
+
+Returns SvNumberFormatter::UNLIMITED_PRECISION for formats that contain
+the General keyword.
*/
-sal_uInt16 GetThousandDivisorPrecision( sal_uInt16 nIx = 0 ) const
-{ return NumFor[nIx].Info().nThousand * 3; }
+sal_uInt16 GetThousandDivisorPrecision( sal_uInt16 nIx = 0 ) const;
//! Read/write access on a special sal_uInt16 component, may only be used
on the
//! standard format 0, 1, ... and only by the number formatter!
diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index aee431660d0a..9d124f5acc2f 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -640,8 +640,12 @@ double ScDocument::RoundValueAsShown( double fVal,
sal_uInt32 nFormat, const ScI
SvNumFormatType nType = pFormat->GetMaskedType();
if (nType != SvNumFormatType::DATE && nType != SvNumFormatType::TIME &&
nType != SvNumFormatType::DATETIME )
{
-short nPrecision;
-if ((nFormat % SV_COUNTRY_LANGUAGE_OFFSET) != 0)
+// MSVC doesn't recognize all paths init nPrecision and wails about
+// "potentially uninitialized local variable 'nPrecision' used"
+// so init to some random sensible value preserving all decimals.
+short nPrecision = 20;
+bool bStdPrecision = ((nFormat % SV_COUNTRY_LANGUAGE_OFFSET) == 0);
+if (!bStdPrecision)
{
sal_uInt16 nIdx = pFormat->GetSubformatIndex( fVal );
nPrecision = static_cast(pFormat->GetFormatPrecision( nIdx
));
@@ -678,13 +682,18 @@ double ScDocument::RoundValueAsShown( double fVal,
sal_uInt32 nFormat, const ScI
case SvNumFormatType::NUMBER:
case SvNumFormatType::CURRENCY:
{ // tdf#106253 Thousands divisors for format "0,"
-nPrecision -= pFormat->GetThousandDivisorPrecision( nIdx
);
+const sal_uInt16 nTD =
pFormat->GetThousandDivisorPrecision( nIdx );
+if (nTD == SvNumberFormatter::UNLIMITED_PRECISION)
+// Format contains General keyword, handled below.
+bStdPrecision = true;
+else
+nPrecision -= nTD;
break;
}
default: break;
}
}
-else
+if (bStdPrecision)
{
nPrecision = static_cast(GetDocOptions().GetStdPrecision());
// #i115512# no rounding for automatic decimals
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 255bfb09b5f7..bf95fd717cb1 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -5946,6 +5946,22 @@ OUString
SvNumberformat::GetFormatStringForTimePrecision( int nPrecision ) const
return sString.makeStringAndClear();
}
+sal_uInt16
[Libreoffice-bugs] [Bug 144273] Spell check fails on document template
https://bugs.documentfoundation.org/show_bug.cgi?id=144273 Uwe Auer changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Uwe Auer --- (In reply to Forrest Aldrich from comment #0) > > I have the template here that I can send to someone for analysis upon > request. There is no method to attach it here. There is a method - please use "Add an attachment". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Buovjaga changed: What|Removed |Added Depends on||144284 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144284 [Bug 144284] Crash closing master document (dbgutil) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144284] Crash closing master document (dbgutil)
https://bugs.documentfoundation.org/show_bug.cgi?id=144284 Buovjaga changed: What|Removed |Added Blocks||133092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144284] New: Crash closing master document (dbgutil)
https://bugs.documentfoundation.org/show_bug.cgi?id=144284 Bug ID: 144284 Summary: Crash closing master document (dbgutil) Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Keywords: haveBacktrace Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ilmari.lauhakan...@libreoffice.org Created attachment 174760 --> https://bugs.documentfoundation.org/attachment.cgi?id=174760=edit GDB trace of crash Only seen with a debug build it seems. 1. Download attachment 171695 and attachment 171696 and open master.odm 2. Yes to update links 3. Close document Arch Linux 64-bit Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 104847ed014e95a915d314de7091c7d572eade67 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 3 September 2021 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142129] Exported PDF of master document with hidden sections containing headings shows headings anyway
https://bugs.documentfoundation.org/show_bug.cgi?id=142129 Buovjaga changed: What|Removed |Added Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED --- Comment #11 from Buovjaga --- 7.2 repo says the fix is https://git.libreoffice.org/core/commit/5fc6a601d7a1978db291fd0f7dcec638a7c25651 section.cxx: Remove remaining SwClientNotifyCalls Did double-check the commit. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107805] [META] Writer master document issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107805 Bug 107805 depends on bug 142129, which changed state. Bug 142129 Summary: Exported PDF of master document with hidden sections containing headings shows headings anyway https://bugs.documentfoundation.org/show_bug.cgi?id=142129 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell contents (used in formulas) increased from 2 to 10 seconds if multi-threaded
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Telesto changed: What|Removed |Added CC||l.lu...@collabora.com, ||michael.me...@collabora.com --- Comment #9 from Telesto --- Adding CC: to Michael Meeks (based on comment 6) Adding CC: to Luboš Luňák (based on comment 2) & his work on the FormulaGroup code -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell contents (used in formulas) increased from 2 to 10 seconds if multi-threaded
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 --- Comment #8 from Telesto --- Would someone mind to verify my Windows bibisect result, please. There might well be a difference between Windows & Linux... I find it pretty particular that both bibisects point (Linux/Win) both point to "FormulaGroups" code, only different code.. Also the 'bug' at bug 144250 points to yet again the FormulaGroups code, but again different commit. It's my impression that for somehow a recalculation is trigger followed (or together with) a by row height recalculation. But well I could be totally wrong... -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/qpro/qpro.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit e4b1ba9447a0a56aa56400f9f44d8eecb6c11e9c
Author: Caolán McNamara
AuthorDate: Fri Sep 3 09:22:23 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 15:49:19 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Ib703febb7e632ec4ae18756065a1c60ffc75569e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121590
Tested-by: Caolán McNamara
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/qpro/qpro.cxx b/sc/source/filter/qpro/qpro.cxx
index 7bb6c82b5611..5ee451af9aef 100644
--- a/sc/source/filter/qpro/qpro.cxx
+++ b/sc/source/filter/qpro/qpro.cxx
@@ -51,7 +51,9 @@ ErrCode ScQProReader::readSheet( SCTAB nTab, ScDocument&
rDoc, ScQProStyle *pSty
case 0x000f:{ // Label cell
mpStream->ReadUChar( nCol ).ReadUChar( nDummy ).ReadUInt16(
nRow ).ReadUInt16( nStyle ).ReadUChar( nDummy );
sal_uInt16 nLen = getLength();
-if (nLen >= 7)
+if (!mpStream->good() || nLen < 7)
+eRet = SCERR_IMPORT_FORMAT;
+else
{
OUString aLabel(readString(nLen - 7));
nStyle = nStyle >> 3;
@@ -59,8 +61,6 @@ ErrCode ScQProReader::readSheet( SCTAB nTab, ScDocument&
rDoc, ScQProStyle *pSty
rDoc.EnsureTable(nTab);
rDoc.SetTextCell(ScAddress(nCol,nRow,nTab), aLabel);
}
-else
-eRet = SCERR_IMPORT_FORMAT;
}
break;
[Libreoffice-bugs] [Bug 126663] XLSX: LibreOffice is freezed when I try open Style list in Sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=126663 Buovjaga changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=53 ||698 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 53698] FILEOPEN particular large .xlsm takes 200 times longer than with EXCEL Viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=53698 Buovjaga changed: What|Removed |Added Resolution|WORKSFORME |FIXED See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||6663 --- Comment #28 from Buovjaga --- Bibisected the fix to https://git.libreoffice.org/core/commit/0702541b3d4661846dccde26efa9c2fb5ed65f35 tdf#126663: optimize style list display in sidebar Julien is in Cc here, so let's thank him of this 2019 fix :) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/lotus/lotimpop.cxx | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
New commits:
commit 00abfe06caa489559cbda0db082f5e118a324f6c
Author: Caolán McNamara
AuthorDate: Fri Sep 3 09:33:09 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 15:47:10 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: I3ea65a72567e934325e24ff658fc1b9c0468abcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/filter/lotus/lotimpop.cxx
b/sc/source/filter/lotus/lotimpop.cxx
index ca5a2f13edf8..ed06a7ab373f 100644
--- a/sc/source/filter/lotus/lotimpop.cxx
+++ b/sc/source/filter/lotus/lotimpop.cxx
@@ -318,18 +318,20 @@ void ImportLotus::RowPresentation( sal_uInt16 nRecLen )
{
SAL_WARN_IF( nRecLen < 5, "sc.filter", "*ImportLotus::RowPresentation():
Record too short!" );
-sal_uInt8nLTab, nFlags;
-sal_uInt16 nRow, nHeight;
-sal_uInt16nCnt = (nRecLen < 4) ? 0 : ( nRecLen - 4 ) / 8;
+sal_uInt16 nCnt = (nRecLen < 4) ? 0 : ( nRecLen - 4 ) / 8;
+sal_uInt8 nLTab(0);
Read( nLTab );
Skip( 1 );
-while( nCnt )
+while (nCnt && pIn->good())
{
+sal_uInt16 nRow(0);
Read( nRow );
+sal_uInt16 nHeight(0);
Read( nHeight );
Skip( 2 );
+sal_uInt8 nFlags(0);
Read( nFlags );
Skip( 1 );
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Bug 108827 depends on bug 131516, which changed state. Bug 131516 Summary: Use of WEBSERVICE function raises an "Illegal argument" exception https://bugs.documentfoundation.org/show_bug.cgi?id=131516 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception
https://bugs.documentfoundation.org/show_bug.cgi?id=131516 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96192] Add Personal Information Manager (PIM) core module to LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=96192 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2349 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 96192] Add Personal Information Manager (PIM) core module to LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=96192 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=11 ||2349 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 112349] OneNote Replacement
https://bugs.documentfoundation.org/show_bug.cgi?id=112349 V Stuart Foote changed: What|Removed |Added CC||vstuart.fo...@utsa.edu See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=96 ||192 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144283] New: Compilation of core error linking starmath/source/mathml/mathmlimport.o
https://bugs.documentfoundation.org/show_bug.cgi?id=144283 Bug ID: 144283 Summary: Compilation of core error linking starmath/source/mathml/mathmlimport.o Product: LibreOffice Version: unspecified Hardware: ARM OS: other Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mysaa@e.email Description: When compiling, i get a linker error. I get a linker error of type `undefined reference to 'non-virtual thunk to ...'` ``` bash-5.0$ make -j 1 -rs -f /sources/libreoffice/ext/core/Makefile.gbuild build [DEP] LNK:Library/libchartcontrollerlo.so [LNK] Library/libchartcontrollerlo.so [CMP] chart2/source/controller/chartcontroller [BIN] chart2 [MOD] chart2 [DEP] LNK:Library/libcuilo.so [LNK] Library/libcuilo.so [CMP] cui/util/cui [BIN] cui [MOD] cui [DEP] LNK:Library/libwriterfilterlo.so [LNK] Library/libwriterfilterlo.so /usr/bin/ld: /sources/libreoffice/ext/core/workdir/CxxObject/writerfilter/source/rtftok/rtfdocumentimpl.o: in function `writerfilter::rtftok::RTFDocumentImpl::handleEmbeddedObject()': rtfdocumentimpl.cxx:(.text+0x86bc): undefined reference to `non-virtual thunk to cppu::ImplInheritanceHelper::acquire()' collect2: error: ld returned 1 exit status make: *** [/sources/libreoffice/ext/core/writerfilter/Library_writerfilter.mk:10: /sources/libreoffice/ext/core/instdir/program/libwriterfilterlo.so] Error 1 ``` Steps to Reproduce: 1. clone the core repository of libreoffice 2. Autogen: ./autogen.sh --without-system-libxml --with-distro=LibreOfficeOnline 3. Make: make Actual Results: Linker error Expected Results: No linker error Reproducible: Didn't try User Profile Reset: No Additional Info: Head of config.log: ./configure --without-system-libxml --disable-cups --disable-dbus --disable-dconf --disable-epm --disable-evolution2 --disable-ext-nlpsolver --disable-ext-wiki-publisher --disable-firebird-sdbc --disable-gio --disable-gstreamer-1-0 --disable-gtk3 --disable-gui --disable-qt5 --disable-kf5 --disable-odk --disable-online-update --disable-skia --enable-pdfimport --disable-postgresql-sdbc --disable-report-builder --disable-scripting-beanshell --disable-scripting-javascript --disable-sdremote --disable-sdremote-bluetooth --enable-extension-integration --enable-mergelibs --enable-python=internal --enable-release-build --with-external-dict-dir=/usr/share/hunspell --with-external-hyph-dir=/usr/share/hyphen --with-external-thes-dir=/usr/share/mythes --with-fonts --with-galleries=no --with-lang=ALL --with-linker-hash-style=both --with-system-dicts --with-system-zlib --with-theme=colibre --without-branding --without-help --without-java --without-junit --with-myspell-dicts --without-package-format --without-system-cairo --without-system-jars --without-system-jpeg --without-system-libpng --without-system-libxml --without-system-openssl --disable-poppler --without-system-postgresql --srcdir=/sources/libreoffice/ext/core --enable-option-checking=fatal -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142129] Exported PDF of master document with hidden sections containing headings shows headings anyway
https://bugs.documentfoundation.org/show_bug.cgi?id=142129 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #10 from Buovjaga --- With attachment 171695 and attachment 171696: this appears in 7.1 repo and is not seen in newest of 7.2 repo. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 130496] Implement a PIM as a replacement for Outlook
https://bugs.documentfoundation.org/show_bug.cgi?id=130496 Michael Warner changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4280 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 130496] Implement a PIM as a replacement for Outlook
https://bugs.documentfoundation.org/show_bug.cgi?id=130496 Michael Warner changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4280 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144280] Note taking component
https://bugs.documentfoundation.org/show_bug.cgi?id=144280 Michael Warner changed: What|Removed |Added Resolution|--- |DUPLICATE See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||0496 Status|UNCONFIRMED |RESOLVED --- Comment #1 from Michael Warner --- Thanks for the suggestion. Adding more applications to compete with MS Office is an idea that has been raised before, see bug 112349 and bug 130496. Unfortunately, despite the huge user base of LibreOffice, there is only a relatively small number of people working on development of it. There is already more than enough work to keep the existing applications maintained. Adding another one is not likely to happen in the near future. *** This bug has been marked as a duplicate of bug 112349 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112349] OneNote Replacement
https://bugs.documentfoundation.org/show_bug.cgi?id=112349 Michael Warner changed: What|Removed |Added CC||penguinvitamins2@stoneypoin ||t.co.za --- Comment #2 from Michael Warner --- *** Bug 144280 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/ipict/ipict.cxx | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
New commits:
commit c4bc47a972383e6adc99ad1257c7a8ba207c57ba
Author: Caolán McNamara
AuthorDate: Thu Sep 2 10:23:37 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Sep 3 15:19:53 2021 +0200
ofz: MemorySanitizer: use-of-uninitialized-value
Change-Id: Ibd35c1aee4324620fb7ae17e20027057f1934c6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121573
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/source/filter/ipict/ipict.cxx
b/vcl/source/filter/ipict/ipict.cxx
index bcc61870726e..65e1f87221be 100644
--- a/vcl/source/filter/ipict/ipict.cxx
+++ b/vcl/source/filter/ipict/ipict.cxx
@@ -446,14 +446,11 @@ Color PictReader::ReadRGBColor()
return Color( static_cast( nR >> 8 ), static_cast(
nG >> 8 ), static_cast( nB >> 8 ) );
}
-
void PictReader::ReadRectangle(tools::Rectangle & rRect)
{
-Point aTopLeft, aBottomRight;
-
-aTopLeft=ReadPoint();
-aBottomRight=ReadPoint();
-if (aTopLeft.X() > aBottomRight.X() || aTopLeft.Y() > aBottomRight.Y())
+Point aTopLeft = ReadPoint();
+Point aBottomRight = ReadPoint();
+if (!pPict->good() || aTopLeft.X() > aBottomRight.X() || aTopLeft.Y() >
aBottomRight.Y())
{
SAL_WARN("filter.pict", "broken rectangle");
pPict->SetError( SVSTREAM_FILEFORMAT_ERROR );
@@ -595,10 +592,9 @@ sal_uInt8 PictReader::ReadAndDrawArc(PictDrawingMethod
eMethod)
sal_uInt8 PictReader::ReadAndDrawSameArc(PictDrawingMethod eMethod)
{
short nstartAngle, narcAngle;
-double fAng1, fAng2;
pPict->ReadInt16( nstartAngle ).ReadInt16( narcAngle );
-if (IsInvisible(eMethod)) return 4;
+if (!pPict->good() || IsInvisible(eMethod)) return 4;
DrawingMethod(eMethod);
if (narcAngle<0) {
@@ -606,8 +602,8 @@ sal_uInt8 PictReader::ReadAndDrawSameArc(PictDrawingMethod
eMethod)
narcAngle=-narcAngle;
}
const double pi = 2 * acos(0.0);
-fAng1 = static_cast(nstartAngle) * pi / 180.0;
-fAng2 = static_cast(nstartAngle + narcAngle) * pi / 180.0;
+double fAng1 = static_cast(nstartAngle) * pi / 180.0;
+double fAng2 = static_cast(nstartAngle + narcAngle) * pi / 180.0;
PictReaderShape::drawArc( pVirDev, eMethod == PictDrawingMethod::FRAME,
aLastArcRect, fAng1, fAng2, nActPenSize );
return 4;
}
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell contents (used in formulas) increased from 2 to 10 seconds if multi-threaded
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Timur changed: What|Removed |Added Keywords|regression | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell contents (used in formulas) increased from 2 to 10 seconds if multi-threaded
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Timur changed: What|Removed |Added Summary|Recalculating after |Recalculating after |deleting cell increased |deleting cell contents |from 2 to 10 seconds if |(used in formulas) |multi-threaded |increased from 2 to 10 ||seconds if multi-threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell increased from 2 to 10 seconds if multi-threaded
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 --- Comment #7 from Timur --- So multi-threaded calculation is a culprit, adding meta. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell increased from 2 to 10 seconds if multi-threaded
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Timur changed: What|Removed |Added Summary|Recalculating after |Recalculating after |deleting cell content |deleting cell increased |increased from 2 seconds|from 2 to 10 seconds if |(6.0) to 10 seconds with|multi-threaded |(7.3) | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102618] Fit height to text setting lost when creating a document with template
https://bugs.documentfoundation.org/show_bug.cgi?id=102618 Buovjaga changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|NEW --- Comment #6 from Buovjaga --- (In reply to Buovjaga from comment #2) > Repro from scratch. > > More detailed steps: > > 1. Create a new Impress document, cancel out of template selection > 2. View - Slide Master > 3. Right-click the content text box, select "Text" > 4. Untick "Fit to frame", OK > 5. Save as - Template > 6. Open your template and check the "Text" settings Still repro, just with "tick" in step 4 this time as it is unticked by default. Arch Linux 64-bit Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 104847ed014e95a915d314de7091c7d572eade67 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 3 September 2021 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144249] Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3
https://bugs.documentfoundation.org/show_bug.cgi?id=144249 Timur changed: What|Removed |Added Priority|medium |high Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=114159 Timur changed: What|Removed |Added Depends on||144257 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144257 [Bug 144257] Recalculating after deleting cell content increased from 2 seconds (6.0) to 10 seconds with (7.3) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell content increased from 2 seconds (6.0) to 10 seconds with (7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Timur changed: What|Removed |Added Blocks||114159 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114159 [Bug 114159] [META] Calc Threaded Calculation bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Bug 103314 depends on bug 118755, which changed state. Bug 118755 Summary: Save as template does not overwrite as required https://bugs.documentfoundation.org/show_bug.cgi?id=118755 What|Removed |Added Status|RESOLVED|NEW Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118755] Save as template does not overwrite as required
https://bugs.documentfoundation.org/show_bug.cgi?id=118755 Buovjaga changed: What|Removed |Added Resolution|WORKSFORME |--- Status|RESOLVED|NEW --- Comment #7 from Buovjaga --- Still repro Arch Linux 64-bit Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: 104847ed014e95a915d314de7091c7d572eade67 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: threaded Built on 3 September 2021 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell content increased from 2 seconds (6.0) to 10 seconds with (7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 --- Comment #6 from Timur --- Bibisect in 6.1: commit 38bd1dd9533307ca905cdf14b0842aacce61e7e1 Date: Sat May 26 03:13:32 2018 +0200 source sha:1360a86cc3ccbe228acf2428a5e230cdf030bfde pre sha:14257916b872103b0c8e998499d3e30c94c7b9bb author Michael Meeks 2018-05-24 Re-enable threading for formula groups for now. As agreed at the ESC - lets see how this goes for 6.1 This reverts commit 4696d3728f0aba1087001bc543fc0867dd0ebdda. commit 4696d3728f0aba1087001bc543fc0867dd0ebdda[log] author Michael Meeks Wed Jan 31 2018 Disable threading for formula groups for now. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103100 Buovjaga changed: What|Removed |Added Depends on||144255 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144255 [Bug 144255] Table inner border coloring not continued logically when inserting new row after last -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144255] Table inner border coloring not continued logically when inserting new row after last
https://bugs.documentfoundation.org/show_bug.cgi?id=144255 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Severity|normal |minor OS|Linux (All) |All Ever confirmed|0 |1 Summary|table formatting not|Table inner border coloring |working as expected |not continued logically ||when inserting new row ||after last Version|7.3.0.0 alpha0+ Master |Inherited From OOo Status|UNCONFIRMED |NEW Blocks||103100 --- Comment #5 from Buovjaga --- Seen on Windows as well and already in 3.3.0. Surprisingly, I could not find an earlier report. Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: a866d63e0ac9de4ff7e59b3928f09ec21877bef3 CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: fi-FI (fi_FI); UI: en-US Calc: threaded Jumbo Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103100 [Bug 103100] [META] Writer table bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 131516] Use of WEBSERVICE function raises an "Illegal argument" exception
https://bugs.documentfoundation.org/show_bug.cgi?id=131516
--- Comment #5 from Eike Rathke ---
Fwiw, works perfectly when entered in Calc:
=WEBSERVICE("https://www.lipsum.com/feed/xml?amount=2=paras=Yes;)
and also as macro as in comment 1, with http and https.
Both 7.1.5 and 7.2.z
Suggest closing this.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: wizards/source
wizards/source/scriptforge/SF_L10N.xba | 135 +-- wizards/source/scriptforge/SF_Root.xba |2 wizards/source/scriptforge/SF_Utils.xba |5 wizards/source/scriptforge/python/scriptforge.py |8 + wizards/source/sfdialogs/SF_Dialog.xba | 93 +++ wizards/source/sfdialogs/SF_DialogControl.xba|4 wizards/source/sfdialogs/SF_Register.xba |2 7 files changed, 232 insertions(+), 17 deletions(-) New commits: commit 552a1f30eca91eb647d10d77135b32a5729f11bd Author: Jean-Pierre Ledure AuthorDate: Thu Sep 2 16:08:44 2021 +0200 Commit: Jean-Pierre Ledure CommitDate: Fri Sep 3 14:53:27 2021 +0200 ScriptForge - add AddTextsFromDialog and GetTextsFromL10N methods The objective is to facilitate the automatic translation of all fixed texts in dialogs and dialog controls. Concerned items are: - the title of the dialog - the caption associated with next control types: Button, CheckBox, FixedLine, FixedText, GroupBox and RadioButton - the content of list- and comboboxes - the tip- or helptext displayed when the mouse is hovering the control ScriptForge.SF_L10N.AddTextsFromDialog(dialog) store all fixed texts of the dialog in the list of translatable strings of a L10N object to prepare a POT file SFDialogs.Dialog.GetTextsFromL10N(l10n) get the translated versions of all fixed texts in the dialog from a L10N object and apply them on the dialog before display Both methods are executable from Basic and Python user scripts Change-Id: I3dc9fbbce287d7af4040df713f9d11e0ff928b1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121514 Tested-by: Jean-Pierre Ledure Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure diff --git a/wizards/source/scriptforge/SF_L10N.xba b/wizards/source/scriptforge/SF_L10N.xba index 020dca541831..6aab1f7b4f14 100644 --- a/wizards/source/scriptforge/SF_L10N.xba +++ b/wizards/source/scriptforge/SF_L10N.xba @@ -34,11 +34,12 @@ Option Explicit Being independent text files, one per language to support, the programmer may give away pristine PO template files (known as POT-files) for a translator to process. - This class implements mainly 3 mechanisms: - - AddText: for the programmer to build a set of words or sentences + This class implements mainly 4 mechanisms: + 1. AddText: for the programmer to build a set of words or sentences meant for being translated later - - ExportToPOTFile: All the above texts are exported into a pristine POT-file - - GetText: At runtime get the text in the user language + 2. AddTextsFromDialog: to automatically execute AddText() on each fixed text of a dialog + 3. ExportToPOTFile: All the above texts are exported into a pristine POT-file + 4. GetText: At runtime get the text in the user language Note that the first two are optional: POT and PO-files may be built with a simple text editor Several instances of the L10N class may coexist @@ -52,7 +53,7 @@ Option Explicit Locale: in the form la-CO (language-COUNTRY) Service invocation examples: Dim myPO As Variant - myPO = CreateScriptService(L10N) AddText and ExportToPOTFile are allowed + myPO = CreateScriptService(L10N) AddText, AddTextsFromDialogt and ExportToPOTFile are allowed myPO = CreateScriptService(L10N, C:\myPOFiles\, fr-BE) All functionalities are available @@ -228,6 +229,91 @@ CatchDuplicate: GoTo Finally End Function ScriptForge.SF_L10N.AddText +REM - +Public Function AddTextsFromDialog(Optional ByRef Dialog As Variant) As Boolean + Add all fixed text strings of a dialog to the list of localizable text strings + Added texts are: + - the title of the dialog + - the caption associated with next control types: Button, CheckBox, FixedLine, FixedText, GroupBox and RadioButton + - the content of list- and comboboxes + - the tip- or helptext displayed when the mouse is hovering the control + The current method has method SFDialogs.SF_Dialog.GetTextsFromL10N as counterpart + The targeted dialog must not be open when the current method is run + Args: + Dialog: a SFDialogs.Dialog service instance + Returns: + True when successful + Examples: + Dim myDialog As Object + Set myDialog =
[Libreoffice-bugs] [Bug 144257] Recalculating after deleting cell content increased from 2 seconds (6.0) to 10 seconds with (7.3)
https://bugs.documentfoundation.org/show_bug.cgi?id=144257 Timur changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #5 from Timur --- Test Linux bibisect repos. I confirm the bug but not the bibisect result. Bug should be in 6.1. Before and after commit of Comment 2 is similar, slow. Maybe repos are not OK. 6.0 master: 2 sec 6.1 oldest:100+, frozen 6.1 master: 12 sec 6.2 before commit: 12 sec 7.3+ 8 sec -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103314] [META] Templates bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103314 Bug 103314 depends on bug 118755, which changed state. Bug 118755 Summary: Save as template does not overwrite as required https://bugs.documentfoundation.org/show_bug.cgi?id=118755 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118755] Save as template does not overwrite as required
https://bugs.documentfoundation.org/show_bug.cgi?id=118755 Elmar changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #6 from Elmar --- I do not believe this is a problem anymore -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102618] Fit height to text setting lost when creating a document with template
https://bugs.documentfoundation.org/show_bug.cgi?id=102618 Elmar changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Elmar --- This is an old report. I either have understood the complexities of the different options better (between app-level, menu, style, template, etc) or have not had the problem again. You can close. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 53698] FILEOPEN particular large .xlsm takes 200 times longer than with EXCEL Viewer
https://bugs.documentfoundation.org/show_bug.cgi?id=53698 Timur changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #27 from Timur --- (In reply to Timur from comment #26) > I wanted to find a commit, but my 6.2 master is NOK and 6.3 oldest is OK. Buovjaga, please see this. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144255] table formatting not working as expected
https://bugs.documentfoundation.org/show_bug.cgi?id=144255 --- Comment #4 from Buovjaga --- *** Bug 142977 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142977] table border format issue when adding a row after last row
https://bugs.documentfoundation.org/show_bug.cgi?id=142977 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Buovjaga --- *** This bug has been marked as a duplicate of bug 144255 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142977] table border format issue when adding a row after last row
https://bugs.documentfoundation.org/show_bug.cgi?id=142977 Elmar changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from Elmar --- Hi Dieter(In reply to Dieter from comment #2) > I can confirm it with the table from your example, but not with a table > created on my own (I treid with table picker as well as with Table => Insert > Table). So could you please specify steps 1 and 2? Thank you. > => NEEDINFO > > Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community > Build ID: 949658028e722e5d2657b503eb20e16e41dbd8cf > CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: > win > Locale: de-DE (de_DE); UI: en-GB > Calc: CL This may thus be a Linux problem. I inadvertently created a new bug: https://bugs.documentfoundation.org/show_bug.cgi?id=144255 but have more examples and a better(?) description -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144195] UI: PNG export dialog has radio button doesn't allow 'dimensions' or 'DPI' to be set both
https://bugs.documentfoundation.org/show_bug.cgi?id=144195 --- Comment #13 from xordevore...@gmail.com --- > Here is the answer: > https://design.blog.documentfoundation.org/2016/04/01/the-many-faced-god- > part-2-how-libreoffice-draw-is-expected-to-evolve/ > I'd like to add my 2 cents regarding that document that's more than half a decade old, times change, and the bugs I lodge against LO Draw probably would never have been issues, or even ever crossed the minds, of end-users in 2016. In 2016, LO draw didn't have fuzzy shadows, glowing effects, or several other features that it has today. Did anywhere in that half-decade document call for such? Can we put ancient documentation aside and the locked-in mentality that goes with it and look toward the future? Because I've a whole list of approved enhancements waiting in the wings for a programmer to pick up eventually, and I've love for one day for those to be incorporated DESPITE not being in that ancient document. Thank you. -- You are receiving this mail because: You are the assignee for the bug.
