[Libreoffice-bugs] [Bug 47773] EDITING embedded OLE EXCEL Spreadheet in particular .ppt moves view area after object has been left
https://bugs.documentfoundation.org/show_bug.cgi?id=47773 Rainer Bielefeld Retired changed: What|Removed |Added CC|LibreOffice@bielefeldundbus | |s.de| --- Comment #13 from Rainer Bielefeld Retired --- -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 64314] [META] Macro recording issues
https://bugs.documentfoundation.org/show_bug.cgi?id=64314 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1183 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141183] feature request: temporary macro
https://bugs.documentfoundation.org/show_bug.cgi?id=141183 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=64 ||314 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141183] feature request: temporary macro
https://bugs.documentfoundation.org/show_bug.cgi?id=141183 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de, ||michael.me...@collabora.com Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- Stephen, I don't know anything about macros, but there seem to be an experimental feature about macro recording (see bug 64314). Please have a look at this. cc: Michael Meeks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144558] Print Dialog Box does not have scrollbar so that users with small screens can click on the ok button to print.
https://bugs.documentfoundation.org/show_bug.cgi?id=144558 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Dieter --- George, you can reduce the size of the print dialog to the size you need. A scrollbar should appear then. does this information solve your problem? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144539] [UI] Confusing UI (or name?) for new page style Gutter feature
https://bugs.documentfoundation.org/show_bug.cgi?id=144539 Dieter changed: What|Removed |Added CC|libreoffice-ux-advise@lists | |.freedesktop.org, | |vmik...@collabora.com | -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #13 from Mike Kaganski --- (In reply to David from comment #12) David, it's great that you handle this. Do you need assistance to provide your patch to gerrit? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140561] wrong term for gutter position in mirrored page layout
https://bugs.documentfoundation.org/show_bug.cgi?id=140561 Dieter changed: What|Removed |Added CC||luke.kend...@gmail.com --- Comment #4 from Dieter --- *** Bug 144539 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140561] wrong term for gutter position in mirrored page layout
https://bugs.documentfoundation.org/show_bug.cgi?id=140561 Dieter changed: What|Removed |Added CC||luke.kend...@gmail.com --- Comment #4 from Dieter --- *** Bug 144539 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144539] [UI] Confusing UI (or name?) for new page style Gutter feature
https://bugs.documentfoundation.org/show_bug.cgi?id=144539 Dieter changed: What|Removed |Added Keywords||needsUXEval Status|UNCONFIRMED |RESOLVED CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vmik...@collabora.com Resolution|--- |DUPLICATE Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- *** This bug has been marked as a duplicate of bug 140561 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144539] [UI] Confusing UI (or name?) for new page style Gutter feature
https://bugs.documentfoundation.org/show_bug.cgi?id=144539 Dieter changed: What|Removed |Added Keywords||needsUXEval Status|UNCONFIRMED |RESOLVED CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||vmik...@collabora.com Resolution|--- |DUPLICATE Whiteboard| QA:needsComment| --- Comment #1 from Dieter --- *** This bug has been marked as a duplicate of bug 140561 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140561] wrong term for gutter position in mirrored page layout
https://bugs.documentfoundation.org/show_bug.cgi?id=140561 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vmik...@collabora.com --- Comment #3 from Dieter --- Bug 144539 gave some references to proof the wrong name https://www.abaa.org/glossary/entry/gutter or https://www.printivity.com/insights/2019/05/18/how-to-design-for-gutter-margins/ or any number of other sites, such as https://en.wikipedia.org/wiki/Bookbinding Reading LO Help [1] I also don't understand this feature at all, or some informations are missing. Gutter margin in LO is not the margin between left edge of a page and text area, but the margin between left margin and text area. Miklos, could you explain the idea behind a current behaviour (there is no definition of gutter margin in your blog https://vmiklos.hu/blog/sw-gutter-margin.html) and perhaps design-team has idea for a solution cc: Design Team cc: Miklos Vajna [1] https://help.libreoffice.org/7.2/en-GB/text/shared/01/05040200.html?System=WIN=WRITER=cui/ui/pageformatpage/PageFormatPage#bm_id3149877 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140561] wrong term for gutter position in mirrored page layout
https://bugs.documentfoundation.org/show_bug.cgi?id=140561 Dieter changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org, ||vmik...@collabora.com --- Comment #3 from Dieter --- Bug 144539 gave some references to proof the wrong name https://www.abaa.org/glossary/entry/gutter or https://www.printivity.com/insights/2019/05/18/how-to-design-for-gutter-margins/ or any number of other sites, such as https://en.wikipedia.org/wiki/Bookbinding Reading LO Help [1] I also don't understand this feature at all, or some informations are missing. Gutter margin in LO is not the margin between left edge of a page and text area, but the margin between left margin and text area. Miklos, could you explain the idea behind a current behaviour (there is no definition of gutter margin in your blog https://vmiklos.hu/blog/sw-gutter-margin.html) and perhaps design-team has idea for a solution cc: Design Team cc: Miklos Vajna [1] https://help.libreoffice.org/7.2/en-GB/text/shared/01/05040200.html?System=WIN=WRITER=cui/ui/pageformatpage/PageFormatPage#bm_id3149877 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 129808] Line height becomes extremely narrow while opening a specific DOC file
https://bugs.documentfoundation.org/show_bug.cgi?id=129808 --- Comment #7 from Volga --- This is still reproduced with Version: 7.2.2.1 (x64) / LibreOffice Community Build ID: 0e408af0b27894d652a87aa5f21fe17bf058124c CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107830] [META] DOCX (OOXML) paragraph-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107830 Volga changed: What|Removed |Added Depends on||144865 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144865 [Bug 144865] Writer is unable to custom line height for specific DOCX file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144865] Writer is unable to custom line height for specific DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=144865 Volga changed: What|Removed |Added Blocks||107830 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107830 [Bug 107830] [META] DOCX (OOXML) paragraph-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144865] Writer is unable to custom line height for specific DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=144865 --- Comment #1 from Volga --- Created attachment 175451 --> https://bugs.documentfoundation.org/attachment.cgi?id=175451=edit Sample file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144865] New: Writer is unable to custom line height for specific DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=144865 Bug ID: 144865 Summary: Writer is unable to custom line height for specific DOCX file Product: LibreOffice Version: 7.2.1.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: shanshandehongx...@outlook.com Description: While I opened a DOCX file, I saw the line spacing is so height so I attempt to midofy that, but Writer won't responce Steps to Reproduce: 1. Open attached document 2. Select a paragraph 3. Right click the paragraph, select Parageaph at the context menu 4. Set the line height as Fixed, modify the value as 20 pt Actual Results: After click OK button, the line height looks no change. Expected Results: LibreOffice should dealing with line height settings correctly in the DOCX document. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.2.1 (x64) / LibreOffice Community Build ID: 0e408af0b27894d652a87aa5f21fe17bf058124c CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144864] New: List Numbers Lose Formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=144864 Bug ID: 144864 Summary: List Numbers Lose Formatting Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: myoun...@gmail.com Description: I am a patent attorney. For years I have used Libre Office; although I keep a current copy of Microsoft Office too. Lately I have had a problem with paragraph numbering. The USPTO recommends numbering each paragraph using four digits between square braces, such as [0001], [0010] and so on. To accomplish that in Libre Office, I use a number list. Each paragraph is numbered. For the first 9 paragraphs, the number is preceded by [000 and followed by ]. For paragraphs 10 through 99, the number is preceded by [00 and followed by ]. It has worked fine, until recently. I save the document as a Word docx file. I'm not sure if that has anything to do with my problem. The problem occurs when I reopen the document in Libre Office (i.e., after the document has been saved and closed, I may reopen it for further editing). The number formatting changes. What was originally numbered [0001] becomes [1000], what was originally numbered [0002] becomes [2000] and so on. Any help will be appreciated. I'd like to get rid of Word, but cannot seem to do that. Steps to Reproduce: 1. Create a document with 10 paragraphs. 2. Precede each paragraph with a list number. For paragraphs 1-9, the format of the list number will be as follows: the number will be preceded by [000 and followed by ]. For paragraph 10, the format of the list number will be as follows: the number will be preceded by [00 and followed by ]. 3. Save the document as a docx document. 4. Close the document. 5. Open the document. Actual Results: When the document is opened in step 5, the numbering format has changed. Expected Results: When the document is opened in step 5, the numbering format should not change. Reproducible: Always User Profile Reset: Yes Additional Info: Version: 7.2.1.2 (x64) / LibreOffice Community Build ID: 87b77fad49947c1441b67c559c339af8f3517e22 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139119] libreoffice uno jars - maven artefact version is wrong @version@ instead of 7.0.4
https://bugs.documentfoundation.org/show_bug.cgi?id=139119 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144573] SDK - on ARM Mac Silicon - failure to build CPP examples - Reason: unsafe use of relative rpath - cppumaker with restricted binary
https://bugs.documentfoundation.org/show_bug.cgi?id=144573 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144561] UI: add quick links to column header context menu to sort a sheet based on that column.
https://bugs.documentfoundation.org/show_bug.cgi?id=144561 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144535] EDITING: Points and Glue Points toolbars - incorrect view toggling behaviour
https://bugs.documentfoundation.org/show_bug.cgi?id=144535 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144399] Impress: FILESAVE to ODP as read-only with additional password protection for editing not working
https://bugs.documentfoundation.org/show_bug.cgi?id=144399 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144801] Miss some data when I import calc files from GDrive
https://bugs.documentfoundation.org/show_bug.cgi?id=144801 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144801] Miss some data when I import calc files from GDrive
https://bugs.documentfoundation.org/show_bug.cgi?id=144801 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144693] Tip of the Day sticks on tip 24
https://bugs.documentfoundation.org/show_bug.cgi?id=144693 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144693] Tip of the Day sticks on tip 24
https://bugs.documentfoundation.org/show_bug.cgi?id=144693 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140801] https://crashreport.libreoffice.org/stats/crash_details/4a366984-06ba-47f4-bb13-916e3b1413cc
https://bugs.documentfoundation.org/show_bug.cgi?id=140801 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140801] https://crashreport.libreoffice.org/stats/crash_details/4a366984-06ba-47f4-bb13-916e3b1413cc
https://bugs.documentfoundation.org/show_bug.cgi?id=140801 --- Comment #3 from QA Administrators --- Dear sandy_lafave, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 96000] [META] Spelling and grammar checking bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=96000 Bug 96000 depends on bug 127178, which changed state. Bug 127178 Summary: spell checker lags, only underlines wrongly spelled words later, with a delay https://bugs.documentfoundation.org/show_bug.cgi?id=127178 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127178] spell checker lags, only underlines wrongly spelled words later, with a delay
https://bugs.documentfoundation.org/show_bug.cgi?id=127178 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127178] spell checker lags, only underlines wrongly spelled words later, with a delay
https://bugs.documentfoundation.org/show_bug.cgi?id=127178 --- Comment #11 from QA Administrators --- Dear peter josvai, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98863] FILEOPEN autoshapes: textboxes and text are missing
https://bugs.documentfoundation.org/show_bug.cgi?id=98863 --- Comment #7 from QA Administrators --- Dear dimitar tomov, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95232] EDITING: PPTX: Vertical text on editing
https://bugs.documentfoundation.org/show_bug.cgi?id=95232 --- Comment #7 from QA Administrators --- Dear beldmit, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98231] EDITING: the input line is not updated if moving between cells with similar content
https://bugs.documentfoundation.org/show_bug.cgi?id=98231 --- Comment #9 from QA Administrators --- Dear knulp79, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 92193] Window re-drawn at old position after opening file (un-doing user action to move it)
https://bugs.documentfoundation.org/show_bug.cgi?id=92193 --- Comment #15 from QA Administrators --- Dear Jim Avera, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 48213] EDITING: Number (ful context) references are rendered as plain "n", omitting the "after" data stablished in "Options" tab from "Bullets and Numbering" dialog.
https://bugs.documentfoundation.org/show_bug.cgi?id=48213 --- Comment #13 from QA Administrators --- Dear Rainer Hurtado Navarro, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 47773] EDITING embedded OLE EXCEL Spreadheet in particular .ppt moves view area after object has been left
https://bugs.documentfoundation.org/show_bug.cgi?id=47773 --- Comment #12 from QA Administrators --- Dear sasha.libreoffice, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 44946] Editing Microsoft Equation 3.0 equations imported from Word loses Greek characters ( steps in comment 4 )
https://bugs.documentfoundation.org/show_bug.cgi?id=44946 --- Comment #17 from QA Administrators --- Dear Orion Poplawski, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 119772] insert field always goes to layout layer, even if it is not the active layer and despite layout layer is locked
https://bugs.documentfoundation.org/show_bug.cgi?id=119772 --- Comment #3 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118200] frame of 100% relative height can't be set to 'wrap: none', switches to 'wrap: through' by itself
https://bugs.documentfoundation.org/show_bug.cgi?id=118200 --- Comment #4 from QA Administrators --- Dear Yury, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102338] shrink-to-fit text confuses printing, causing extra empty pages to print
https://bugs.documentfoundation.org/show_bug.cgi?id=102338 --- Comment #9 from QA Administrators --- Dear Jim Avera, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115040] Conditional formatting "between" - incorrect tab order
https://bugs.documentfoundation.org/show_bug.cgi?id=115040 --- Comment #7 from QA Administrators --- Dear Dan Dascalescu, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144863] New: Input components created in dark mode in Ubuntu retain dark mode properties when exported to PDF as a fillable form.
https://bugs.documentfoundation.org/show_bug.cgi?id=144863 Bug ID: 144863 Summary: Input components created in dark mode in Ubuntu retain dark mode properties when exported to PDF as a fillable form. Product: LibreOffice Version: unspecified Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ksc3.14...@gmail.com Description: (Don't know if this is technically a bug, but it certainly doesn't work as I would expect.) When operating LibreOffice draw in dark mode I created several text boxes, but by default they had a black background. I did not realize at the time that this was because I was in dark mode. As I wanted a white background for my text boxes, I manually changed the color. However, after exporting the PDF and attempting to fill out information, I found that the text entered turned a light gray that was impossible to read. In testing this bug, I experimented with checkboxes to see if the problem was purely related to text boxes and found that not only did the black background remain in the boxes, but an invisible, light gray label was created - invisible on the white page background until exported. Then the entire rectangular background of the checkbox component was filled in black, making the label legible. I have not tested radio buttons. This may also affect other operating systems; someone should check that. Steps to Reproduce: For text boxes: 1. Go into dark mode. 2. Click "Text Box" and create a text box. Note: Do NOT use F2 or use "Create Text Box"! That's the wrong kind. 3. Right click on text box and select "Control Properties..." 4. Change background color to white. 5. Select [...] next to "Font". 6. Change tab to "Font Effects". 7. Check that the font color is black (or whatever your "Automatic" color is). This bug only seems to occur if the font color is set by "Automatic". 8. Go to File -> Export As... -> Export as PDF Make sure "Create PDF Form" is checked and press Export. 9. (Optional) Return to standard or light mode. 10. Open PDF. 11. Type "Hi!" or some other input into the text box and press enter. For check boxes: 1. Go into dark mode. 2. Create a check box. 3. Expand component rectangle to the right. 4. Repeat steps 8-10 above. Actual Results: For text boxes: Light gray, nearly invisible text in white text box For check boxes: Dark gray background behind checkbox component in PDF which did not appear in Draw. Expected Results: For text boxes: Text in "Automatic" color (black, for me) in white text box. Ideally, I would not want Draw to default to dark gray backgrounds for new input components just because I'm working in dark mode. For check boxes: Dark gray background should have appeared in LibreOffice Draw, not only when exported. Label should be in the "Automatic" color as well. Alternatively, when exported, dark background should apply ONLY to the checkbox, not to the label. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: If one changes the background color of the check box component to white, the black background does not appear in the exported PDF. This is why the first expected result for check boxes is that the black background would appear in LibreOffice Draw, not that it would NOT appear at all upon export. However, the color of the checkbox itself does not change in Draw when its background color is set to white; it remains dark gray. So if it is desirable that only the checkbox change, not the label, then this latter issue is the problem. (Personally I think I'd prefer it only changing the checkbox and not the label, but that may not be how the program is intended to work.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #12 from David --- I think comment 11 can be disregarded. The issue mentioned in that comment seems to no longer be happening after another re-compile. The problem line seems to be 'aCharAttrSet, SetAttrMode::DEFAULT, );' in wrtsh1.cxx. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sal/qa
sal/qa/rtl/math/test-rtl-math.cxx | 12
1 file changed, 12 insertions(+)
New commits:
commit 7b31f7428a1469fa823538fe5cf9cf36bbe2df68
Author: Mike Kaganski
AuthorDate: Sat Oct 2 00:09:43 2021 +0200
Commit: Mike Kaganski
CommitDate: Sat Oct 2 01:44:38 2021 +0200
Some corner case unit tests
Change-Id: I43474265a9b3e1d07394c5f7e429e081d67f2eda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122935
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sal/qa/rtl/math/test-rtl-math.cxx
b/sal/qa/rtl/math/test-rtl-math.cxx
index 3067e11ac167..aaadccc8e97c 100644
--- a/sal/qa/rtl/math/test-rtl-math.cxx
+++ b/sal/qa/rtl/math/test-rtl-math.cxx
@@ -469,6 +469,18 @@ public:
fVal = 123456.789;
aRes = rtl::math::doubleToUString(fVal, rtl_math_StringFormat_E, 2,
'.', false);
CPPUNIT_ASSERT_EQUAL(OUString("1.23E+005"), aRes);
+
+// Testing "after-treatment of up-rounding to the next decade" branch
+// See void doubleToString in sal/rtl/math.cxx
+// 1. Yet empty buffer
+fVal = 9.9929;
+aRes = rtl::math::doubleToUString(fVal,
rtl_math_StringFormat_Automatic, rtl_math_DecimalPlaces_Max, '.', true);
+CPPUNIT_ASSERT_EQUAL(OUString("10"), aRes);
+
+// 2. Buffer with some content
+fVal = 0.99933;
+aRes = rtl::math::doubleToUString(fVal, rtl_math_StringFormat_F,
rtl_math_DecimalPlaces_Max, '.', true);
+CPPUNIT_ASSERT_EQUAL(OUString("1"), aRes);
}
void test_approx() {
[Libreoffice-commits] core.git: sc/qa sc/source test/source
sc/qa/unit/data/fods/tdf144758-dbdata-no-orientation.fods | 17 +++
sc/qa/unit/subsequent_filters_test.cxx| 21 ++
sc/source/filter/xml/xmldrani.cxx |2 -
test/source/sheet/xdatabaserange.cxx |2 -
4 files changed, 40 insertions(+), 2 deletions(-)
New commits:
commit d830179a072072f3cc3ea5d942189647bcb7e1c7
Author: Mike Kaganski
AuthorDate: Fri Oct 1 19:22:18 2021 +0300
Commit: Mike Kaganski
CommitDate: Sat Oct 2 01:43:31 2021 +0200
tdf#144758: default value for 'table:orientation' attribute is 'row'
See [OpenDocument-v1.3-part3] section 19.690.3 .
Regression after commit ed88b144ce24b9a733d4a9ab6614307c96537baa.
Also fixes relevant part of unit test first introduced in commit
6069ef7976c4455c1875afecf02c41c5731f6546, which was at that time
testing that IsSortColumns property returned false; then in commit
fc95d20500997a1a460be6f3553727299a5080eb, the correct value was
changed to true, reflecting the regression fixed here.
Change-Id: I6a12a0ad13405bc388efb7c2c3bbf31e89905620
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122955
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/sc/qa/unit/data/fods/tdf144758-dbdata-no-orientation.fods
b/sc/qa/unit/data/fods/tdf144758-dbdata-no-orientation.fods
new file mode 100644
index ..922fba5ab6cb
--- /dev/null
+++ b/sc/qa/unit/data/fods/tdf144758-dbdata-no-orientation.fods
@@ -0,0 +1,17 @@
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/sc/qa/unit/subsequent_filters_test.cxx
b/sc/qa/unit/subsequent_filters_test.cxx
index 1bdfceb446ba..de4cea5dc961 100644
--- a/sc/qa/unit/subsequent_filters_test.cxx
+++ b/sc/qa/unit/subsequent_filters_test.cxx
@@ -71,6 +71,7 @@
#include
#include
#include
+#include
#include
#include
@@ -217,6 +218,7 @@ public:
void testTdf129681();
void testTdf111974XLSM();
void testEscapedUnicodeXLSX();
+void testTdf144758_DBDataDefaultOrientation();
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testCondFormatOperatorsSameRangeXLSX);
@@ -320,6 +322,7 @@ public:
CPPUNIT_TEST(testTdf129681);
CPPUNIT_TEST(testTdf111974XLSM);
CPPUNIT_TEST(testEscapedUnicodeXLSX);
+CPPUNIT_TEST(testTdf144758_DBDataDefaultOrientation);
CPPUNIT_TEST_SUITE_END();
@@ -3123,6 +3126,24 @@ void ScFiltersTest::testEscapedUnicodeXLSX()
xDocSh->DoClose();
}
+void ScFiltersTest::testTdf144758_DBDataDefaultOrientation()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf144758-dbdata-no-orientation.",
FORMAT_FODS);
+CPPUNIT_ASSERT(xDocSh);
+ScDocument& rDoc = xDocSh->GetDocument();
+ScDBData* pAnonDBData = rDoc.GetAnonymousDBData(0);
+CPPUNIT_ASSERT(pAnonDBData);
+
+ScSortParam aSortParam;
+pAnonDBData->GetSortParam(aSortParam);
+
+// Without the fix, the default value for bByRow (in absence of
'table:orientation' attribute
+// in 'table:database-range' element) was false
+CPPUNIT_ASSERT(aSortParam.bByRow);
+
+xDocSh->DoClose();
+}
+
ScFiltersTest::ScFiltersTest()
: ScBootstrapFixture( "sc/qa/unit/data" )
{
diff --git a/sc/source/filter/xml/xmldrani.cxx
b/sc/source/filter/xml/xmldrani.cxx
index 820c42412b51..9d596740ef74 100644
--- a/sc/source/filter/xml/xmldrani.cxx
+++ b/sc/source/filter/xml/xmldrani.cxx
@@ -103,7 +103,7 @@ ScXMLDatabaseRangeContext::ScXMLDatabaseRangeContext(
ScXMLImport& rImport,
bSubTotalsAscending(true),
bFilterConditionSourceRange(false),
bHasHeader(true),
-bByRow(false),
+bByRow(true),
meRangeType(ScDBCollection::GlobalNamed)
{
if( rAttrList.is() )
diff --git a/test/source/sheet/xdatabaserange.cxx
b/test/source/sheet/xdatabaserange.cxx
index 2c45ba0fbf0a..f1133ac00f5d 100644
--- a/test/source/sheet/xdatabaserange.cxx
+++ b/test/source/sheet/xdatabaserange.cxx
@@ -69,7 +69,7 @@ void XDatabaseRange::testGetSortDescriptor()
{
bool bIsSortColumns = true;
aProp.Value >>= bIsSortColumns;
-CPPUNIT_ASSERT(bIsSortColumns);
+CPPUNIT_ASSERT(!bIsSortColumns);
}
else if (aProp.Name == "ContainsHeader")
{
[Libreoffice-bugs] [Bug 105601] CALC menu for DATA: discrepancies between scalc menu and help guides
https://bugs.documentfoundation.org/show_bug.cgi?id=105601 Rafael Lima changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | --- Comment #5 from Rafael Lima --- Just for the record, the "Data provider" feature was removed from the menu after this patch: https://gerrit.libreoffice.org/c/core/+/85541 Hence, I'll remove it from the menu documentation as well. BTW, this command still needs to be removed from the Tabbed interface, which will be done in a separate patch. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/qa sw/source
sw/inc/swrect.hxx|2 +-
sw/qa/core/test_rect.cxx | 18 ++
sw/source/core/bastyp/swrect.cxx |7 +++
3 files changed, 26 insertions(+), 1 deletion(-)
New commits:
commit 01807ad5e04966abeb396b7599cbbbf822de6a03
Author: Luboš Luňák
AuthorDate: Fri Oct 1 12:30:15 2021 +0200
Commit: Luboš Luňák
CommitDate: Sat Oct 2 00:36:00 2021 +0200
fix SwRect::Union() with empty SwRect
Empty SwRect is technically located at (0,0), so make sure
the position of the union is not moved to include that.
Change-Id: I4905c11c3d9f989d4448704e3cb8b297e45bc569
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122914
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sw/inc/swrect.hxx b/sw/inc/swrect.hxx
index 83416cf3969f..f6d8430b9d11 100644
--- a/sw/inc/swrect.hxx
+++ b/sw/inc/swrect.hxx
@@ -364,7 +364,7 @@ inline bool SwRect::Overlaps( const SwRect& rRect ) const
inline SwRect SwRect::GetUnion( const SwRect& rRect ) const
{
-return SwRect(
+return IsEmpty() ? rRect : rRect.IsEmpty() ? *this : SwRect(
Point( std::min( Left(), rRect.Left()),
std::min( Top(), rRect.Top())),
Point( std::max( Right(), rRect.Right()),
diff --git a/sw/qa/core/test_rect.cxx b/sw/qa/core/test_rect.cxx
index 3c6a47907915..755dbb91bb6e 100644
--- a/sw/qa/core/test_rect.cxx
+++ b/sw/qa/core/test_rect.cxx
@@ -42,6 +42,15 @@ void RectUnittest::testUnion()
tmp.Union(rect3);
CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(30, 30)), tmp);
CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(30, 30)),
rect1.GetUnion(rect3));
+
+tmp = rect1;
+tmp.Union(SwRect());
+CPPUNIT_ASSERT_EQUAL(rect1, tmp);
+CPPUNIT_ASSERT_EQUAL(rect1, rect1.GetUnion(SwRect()));
+tmp = SwRect();
+tmp.Union(rect1);
+CPPUNIT_ASSERT_EQUAL(rect1, tmp);
+CPPUNIT_ASSERT_EQUAL(rect1, SwRect().GetUnion(rect1));
}
void RectUnittest::testIntersection()
@@ -60,6 +69,15 @@ void RectUnittest::testIntersection()
tmp.Intersection(rect3);
CPPUNIT_ASSERT(tmp.IsEmpty());
CPPUNIT_ASSERT(rect1.GetIntersection(rect3).IsEmpty());
+
+tmp = rect1;
+tmp.Intersection(SwRect());
+CPPUNIT_ASSERT(tmp.IsEmpty());
+CPPUNIT_ASSERT(rect1.GetIntersection(SwRect()).IsEmpty());
+tmp = SwRect();
+tmp.Intersection(rect1);
+CPPUNIT_ASSERT(tmp.IsEmpty());
+CPPUNIT_ASSERT(SwRect().GetIntersection(rect1).IsEmpty());
}
CPPUNIT_TEST_SUITE_REGISTRATION(RectUnittest);
diff --git a/sw/source/core/bastyp/swrect.cxx b/sw/source/core/bastyp/swrect.cxx
index 0825696f45c6..8f7131aae47c 100644
--- a/sw/source/core/bastyp/swrect.cxx
+++ b/sw/source/core/bastyp/swrect.cxx
@@ -34,6 +34,13 @@ SwRect::SwRect( const tools::Rectangle ) :
SwRect& SwRect::Union( const SwRect& rRect )
{
+if( rRect.IsEmpty())
+return *this;
+if( IsEmpty())
+{
+*this = rRect;
+return *this;
+}
if ( Top() > rRect.Top() )
Top( rRect.Top() );
if ( Left() > rRect.Left() )
[Libreoffice-commits] core.git: 2 commits - sw/CppunitTest_sw_uwriter.mk sw/inc sw/qa sw/source
sw/CppunitTest_sw_uwriter.mk |1
sw/inc/swrect.hxx | 68 +
sw/qa/core/test_rect.cxx | 67
sw/source/core/bastyp/swrect.cxx | 44 ---
sw/source/core/bastyp/swregion.cxx |6 +--
5 files changed, 138 insertions(+), 48 deletions(-)
New commits:
commit 6702e8a93243c4807c80b53965a4397cdbfde8b5
Author: Luboš Luňák
AuthorDate: Fri Oct 1 10:59:44 2021 +0200
Commit: Luboš Luňák
CommitDate: Sat Oct 2 00:35:47 2021 +0200
add GetUnion/Intersection() to SwRect
This is a more readable and efficient way of first constructing
a copy SwRect and then using Union/Intersection() on it. Named
Get* because that's how tools::Rectangle names them.
Change-Id: Ib3033f1900c48792b23526771a941b4d4c1c07bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122913
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sw/CppunitTest_sw_uwriter.mk b/sw/CppunitTest_sw_uwriter.mk
index 7626039ca23e..aad626119569 100644
--- a/sw/CppunitTest_sw_uwriter.mk
+++ b/sw/CppunitTest_sw_uwriter.mk
@@ -20,6 +20,7 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,sw_uwriter, \
sw/qa/core/test_ToxLinkProcessor \
sw/qa/core/test_ToxTextGenerator \
sw/qa/core/test_ToxMiscTest \
+sw/qa/core/test_rect \
sw/qa/core/test_region \
))
diff --git a/sw/inc/swrect.hxx b/sw/inc/swrect.hxx
index 039d2b414704..83416cf3969f 100644
--- a/sw/inc/swrect.hxx
+++ b/sw/inc/swrect.hxx
@@ -79,6 +79,9 @@ public:
SwRect ( const SwRect& rRect );
SwRect ( const SwRect& rRect );
+SwRect GetUnion( const SwRect& rRect ) const;
+SwRect GetIntersection( const SwRect& rRect ) const;
+
// Same as Intersection, only assume that Rects are overlapping!
SwRect _( const SwRect );
@@ -359,6 +362,26 @@ inline bool SwRect::Overlaps( const SwRect& rRect ) const
(Bottom()>= rRect.Top());
}
+inline SwRect SwRect::GetUnion( const SwRect& rRect ) const
+{
+return SwRect(
+Point( std::min( Left(), rRect.Left()),
+ std::min( Top(), rRect.Top())),
+Point( std::max( Right(), rRect.Right()),
+ std::max( Bottom(), rRect.Bottom(;
+}
+
+inline SwRect SwRect::GetIntersection( const SwRect& rRect ) const
+{
+return Overlaps( rRect )
+? SwRect(
+Point( std::max( Left(), rRect.Left()),
+ std::max( Top(), rRect.Top())),
+Point( std::min( Right(), rRect.Right()),
+ std::min( Bottom(), rRect.Bottom(
+: SwRect();
+}
+
template< typename charT, typename traits >
inline std::basic_ostream & operator <<(
diff --git a/sw/qa/core/test_rect.cxx b/sw/qa/core/test_rect.cxx
new file mode 100644
index ..3c6a47907915
--- /dev/null
+++ b/sw/qa/core/test_rect.cxx
@@ -0,0 +1,67 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ */
+
+#include
+#include
+#include
+
+#include
+
+class RectUnittest : public CppUnit::TestFixture
+{
+public:
+void testUnion();
+void testIntersection();
+
+CPPUNIT_TEST_SUITE(RectUnittest);
+CPPUNIT_TEST(testUnion);
+CPPUNIT_TEST(testIntersection);
+CPPUNIT_TEST_SUITE_END();
+};
+
+void RectUnittest::testUnion()
+{
+SwRect rect1(Point(10, 10), Size(10, 10));
+SwRect rect2(Point(15, 15), Size(10, 10));
+SwRect rect3(Point(30, 30), Size(10, 10));
+SwRect tmp;
+
+tmp = rect1;
+tmp.Union(rect2);
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(15, 15)), tmp);
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(15, 15)),
rect1.GetUnion(rect2));
+
+tmp = rect1;
+tmp.Union(rect3);
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(30, 30)), tmp);
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(10, 10), Size(30, 30)),
rect1.GetUnion(rect3));
+}
+
+void RectUnittest::testIntersection()
+{
+SwRect rect1(Point(10, 10), Size(10, 10));
+SwRect rect2(Point(15, 15), Size(10, 10));
+SwRect rect3(Point(30, 30), Size(10, 10));
+SwRect tmp;
+
+tmp = rect1;
+tmp.Intersection(rect2);
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(15, 15), Size(5, 5)), tmp);
+CPPUNIT_ASSERT_EQUAL(SwRect(Point(15, 15), Size(5, 5)),
rect1.GetIntersection(rect2));
+
+tmp = rect1;
+tmp.Intersection(rect3);
+CPPUNIT_ASSERT(tmp.IsEmpty());
+CPPUNIT_ASSERT(rect1.GetIntersection(rect3).IsEmpty());
+}
+
+CPPUNIT_TEST_SUITE_REGISTRATION(RectUnittest);
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/bastyp/swregion.cxx
b/sw/source/core/bastyp/swregion.cxx
index 5b928a1ab9b0..b790bf14764f 100644
[Libreoffice-bugs] [Bug 144848] SVG Export in DRAW does not export layers
https://bugs.documentfoundation.org/show_bug.cgi?id=144848 Regina Henschel changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||rb.hensc...@t-online.de --- Comment #3 from Regina Henschel --- Inkscape produces non-standard SVG. The SVG standard has no concept of layers. Inkscape uses the idea to put all shapes from one layer into a group element. I first thought too, that would work, but in LibreOffice grouping is orthogonal to layers. If you have an idea how to handle layers in a way conform to SVG standard, please add it to bug 95717. *** This bug has been marked as a duplicate of bug 95717 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95717] DRAW: Manage layers in SVG export
https://bugs.documentfoundation.org/show_bug.cgi?id=95717 Regina Henschel changed: What|Removed |Added CC||1820204_1@ebbinghaus.world --- Comment #10 from Regina Henschel --- *** Bug 144848 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49787] Formatting: Allow different slide / page styles (orientation, size) in a single Drawing document
https://bugs.documentfoundation.org/show_bug.cgi?id=49787 --- Comment #35 from koze --- I would really love this feature. The same behaviour happens when you try to load a pdf with pages that have multipl orientations and everything is displayed as A4 cropping all the Landscape or A3 pages Open office has the same behaviour. Please correct it Thanks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49787] Formatting: Allow different slide / page styles (orientation, size) in a single Drawing document
https://bugs.documentfoundation.org/show_bug.cgi?id=49787 --- Comment #34 from koze --- I would really love this feature. The same behaviour happens when you try to load a pdf with pages that have multipl orientations and everything is displayed as A4 cropping all the Landscape or A3 pages Open office has the same behaviour. Please correct it Thanks -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144862] Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?)
https://bugs.documentfoundation.org/show_bug.cgi?id=144862 Telesto changed: What|Removed |Added Version|7.3.0.0 alpha0+ Master |7.1.0.1 rc --- Comment #3 from Telesto --- Also in 7.3 with safe-mode Also in Version: 7.0.0.0.alpha1+ (x64) (oldest bibisect 7.1 repro) Build ID: 574c57090642347980d2395e1e183cc7b5c171ad CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: nl-NL Calc: CL but not in Version: 7.0.0.0.beta1+ (x64) (bibisect 7.0 repro) Build ID: 2891e91a513520d68ea2b8c59c14335861a15253 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134426] Changing Paragraph format, editing Text and changing back leaves edited text's format unchanged
https://bugs.documentfoundation.org/show_bug.cgi?id=134426 --- Comment #11 from David --- It seems like the line #248 (GetPaMAttr(, aCharAttrSet);) also needs to be executed only if no character styles are used, otherwise if a whole word is replaced it still won't use the automatic character style. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/fmcomp/gridcell.cxx | 18 --
svx/source/inc/gridcell.hxx| 15 +--
2 files changed, 9 insertions(+), 24 deletions(-)
New commits:
commit d7397d36b3c801681a802f4f2f16aec0c01a76db
Author: Caolán McNamara
AuthorDate: Fri Oct 1 16:12:37 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 1 22:53:07 2021 +0200
tdf#141633 use OutputDevice::DrawText for multiline text too
m_bFastPaint is only false for the multiline text, where it then tries
to use a textview widget to render the text onto the OutputDevice while
for simpleline text it just uses OutputDevice::DrawText.
This isn't working particuarly well anymore for print output and
DrawText can be used with flags of DrawTextFlags::Top |
DrawTextFlags::MultiLine | DrawTextFlags::WordBreak to render text
equivalently to the multiple line textview which seems a saner approach.
Change-Id: I3c96f837aaeba82ebf5956ab2ba35210c978f255
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122953
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index 45362a0e7140..a513784d35f9 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -3562,7 +3562,7 @@ void FmXDataCell::UpdateFromColumn()
FmXTextCell::FmXTextCell( DbGridColumn* pColumn,
std::unique_ptr pControl )
:FmXDataCell( pColumn, std::move(pControl) )
-,m_bFastPaint( true )
+,m_bIsMultiLineText(false)
{
}
@@ -3572,13 +3572,7 @@ void FmXTextCell::PaintFieldToCell(OutputDevice& rDev,
const Reference< css::sdb::XColumn >& _rxField,
const Reference< XNumberFormatter >& xFormatter)
{
-if ( !m_bFastPaint )
-{
-FmXDataCell::PaintFieldToCell( rDev, rRect, _rxField, xFormatter );
-return;
-}
-
-DrawTextFlags nStyle = DrawTextFlags::Clip | DrawTextFlags::VCenter;
+DrawTextFlags nStyle = DrawTextFlags::Clip;
if ( ( rDev.GetOutDevType() == OUTDEV_WINDOW ) &&
!rDev.GetOwnerWindow()->IsEnabled() )
nStyle |= DrawTextFlags::Disable;
@@ -3594,6 +3588,11 @@ void FmXTextCell::PaintFieldToCell(OutputDevice& rDev,
nStyle |= DrawTextFlags::Left;
}
+if (!m_bIsMultiLineText)
+nStyle |= DrawTextFlags::VCenter;
+else
+nStyle |= DrawTextFlags::Top | DrawTextFlags::MultiLine |
DrawTextFlags::WordBreak;
+
try
{
const Color* pColor = nullptr;
@@ -3627,8 +3626,7 @@ FmXEditCell::FmXEditCell( DbGridColumn* pColumn,
std::unique_ptr
{
m_pEditImplementation = pTextField->GetEditImplementation();
-if (pTextField->IsMultiLineEdit())
-m_bFastPaint = false;
+m_bIsMultiLineText = pTextField->IsMultiLineEdit();
}
else
{
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 081f7a4bc684..b2aa1140006f 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -816,20 +816,7 @@ protected:
class FmXTextCell : public FmXDataCell
{
protected:
-/** determines whether the text of this cell can be painted directly,
without
-using the painter control
-
-If this is , the PaintCell method will simply
use the text as returned
-by GetText, and draw it onto the device passed to
PaintFieldToCell,
-while respecting the current alignment settings.
-
-If this is , the PaintFieldToCell request
will be forwarded to the painter
-control (m_pPainter). This is more expensive, but the
only option
-if your painting involves more that a simple DrawText.
-
-This member is by default, and can be modified by derived
classes.
-*/
-boolm_bFastPaint;
+boolm_bIsMultiLineText;
public:
FmXTextCell( DbGridColumn* pColumn, std::unique_ptr
pControl );
[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Bug 103182 depends on bug 144846, which changed state. Bug 144846 Summary: Opening File menu a second time in Impress doesn't work https://bugs.documentfoundation.org/show_bug.cgi?id=144846 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144846] Opening File menu a second time in Impress doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=144846 Caolán McNamara changed: What|Removed |Added Resolution|--- |FIXED Status|ASSIGNED|RESOLVED --- Comment #7 from Caolán McNamara --- done in trunk, backport to 7-2 in gerrit -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |2 ++
vcl/inc/unx/gtk/gtksalmenu.hxx |1 +
vcl/unx/gtk3/gtkframe.cxx | 41 +
3 files changed, 44 insertions(+)
New commits:
commit 7abf811bcbb92562a8da965d2ff03b9d53853e09
Author: Caolán McNamara
AuthorDate: Fri Oct 1 12:42:26 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 1 22:51:24 2021 +0200
tdf#144846 launch gtk3 menubar menus from LibreOffice code
rather than using the builtin gtk mechanism so we can avoid
duplicate mnemonics in the sidebar getting used instead.
Change-Id: I6c761ae63ae25d835de9444b0e298c63996a83a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122926
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index b71d40785200..ced3613ad0ca 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -410,6 +410,8 @@ class GtkSalFrame final : public SalFrame
void SetIcon(const char* pIcon);
+bool HandleMenubarMnemonic(guint eState, guint nKeyval);
+
public:
cairo_surface_t*m_pSurface;
basegfx::B2IVector m_aFrameSize;
diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx
index 36b695a2ccc9..8b68391b1fc9 100644
--- a/vcl/inc/unx/gtk/gtksalmenu.hxx
+++ b/vcl/inc/unx/gtk/gtksalmenu.hxx
@@ -121,6 +121,7 @@ public:
GtkSalMenu* GetTopLevel();
voidSetNeedsUpdate();
+GtkWidget* GetMenuBarWidget() const { return
mpMenuBarWidget; }
GtkWidget* GetMenuBarContainerWidget() const { return
mpMenuBarContainerWidget; }
void CreateMenuBarWidget();
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index a62bdd67162b..aa1d5b600187 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -24,6 +24,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -3847,6 +3848,40 @@ static bool key_forward(GdkEventKey* pEvent, GtkWindow*
pDest)
return bHandled;
}
+static bool activate_menubar_mnemonic(GtkWidget* pWidget, guint nKeyval)
+{
+const char* pLabel = gtk_menu_item_get_label(GTK_MENU_ITEM(pWidget));
+gunichar cAccelChar = 0;
+if (!pango_parse_markup(pLabel, -1, '_', nullptr, nullptr, ,
nullptr))
+return false;
+if (!cAccelChar)
+return false;
+auto nMnemonicKeyval =
gdk_keyval_to_lower(gdk_unicode_to_keyval(cAccelChar));
+if (nKeyval == nMnemonicKeyval)
+return gtk_widget_mnemonic_activate(pWidget, false);
+return false;
+}
+
+bool GtkSalFrame::HandleMenubarMnemonic(guint eState, guint nKeyval)
+{
+bool bUsedInMenuBar = false;
+if (eState & GDK_ALT_MASK)
+{
+if (GtkWidget* pMenuBar = m_pSalMenu ? m_pSalMenu->GetMenuBarWidget()
: nullptr)
+{
+GList* pChildren =
gtk_container_get_children(GTK_CONTAINER(pMenuBar));
+for (GList* pChild = g_list_first(pChildren); pChild; pChild =
g_list_next(pChild))
+{
+bUsedInMenuBar =
activate_menubar_mnemonic(static_cast(pChild->data), nKeyval);
+if (bUsedInMenuBar)
+break;
+}
+g_list_free(pChildren);
+}
+}
+return bUsedInMenuBar;
+}
+
gboolean GtkSalFrame::signalKey(GtkWidget* pWidget, GdkEventKey* pEvent,
gpointer frame)
{
UpdateLastInputEventTime(pEvent->time);
@@ -3859,6 +3894,12 @@ gboolean GtkSalFrame::signalKey(GtkWidget* pWidget,
GdkEventKey* pEvent, gpointe
if (GTK_IS_WINDOW(pThis->m_pWindow))
{
+// tdf#144846 If this is registered as a menubar mnemonic then ensure
+// that any other widget won't be considered as a candidate by taking
+// over the task of launch the menubar menu outself
+if (pThis->HandleMenubarMnemonic(pEvent->state, pEvent->keyval))
+return true;
+
GtkWidget* pFocusWindow =
gtk_window_get_focus(GTK_WINDOW(pThis->m_pWindow));
bFocusInAnotherGtkWidget = pFocusWindow && pFocusWindow !=
GTK_WIDGET(pThis->m_pFixedContainer);
if (bFocusInAnotherGtkWidget)
[Libreoffice-bugs] [Bug 144846] Opening File menu a second time in Impress doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=144846 --- Comment #6 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7abf811bcbb92562a8da965d2ff03b9d53853e09 tdf#144846 launch gtk3 menubar menus from LibreOffice code It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144846] Opening File menu a second time in Impress doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=144846 Commit Notification changed: What|Removed |Added Whiteboard||target:7.3.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144861] 44 malware mis en quarantaine par Immunet lors du téléchargement de LibreOffice 7.2.1.2 Win64
https://bugs.documentfoundation.org/show_bug.cgi?id=144861 JF Commes changed: What|Removed |Added CC||jfcom...@gmail.com --- Comment #1 from JF Commes --- Created attachment 175450 --> https://bugs.documentfoundation.org/attachment.cgi?id=175450=edit Fenêtre Immunet Je ne suis pas développeur mais il peut s’agir d’un faux malware, il faudrait parler avec Immunet mais je n’ai pas leurs coordonnées… -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144862] Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?)
https://bugs.documentfoundation.org/show_bug.cgi?id=144862 --- Comment #2 from Telesto --- Created attachment 175449 --> https://bugs.documentfoundation.org/attachment.cgi?id=175449=edit Screencast -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144862] Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?)
https://bugs.documentfoundation.org/show_bug.cgi?id=144862 --- Comment #1 from Telesto --- Created attachment 175448 --> https://bugs.documentfoundation.org/attachment.cgi?id=175448=edit Example file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144862] New: Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?)
https://bugs.documentfoundation.org/show_bug.cgi?id=144862 Bug ID: 144862 Summary: Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?) Product: LibreOffice Version: 7.3.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% Steps to Reproduce: 1. Open the attached file 2. Window size should be 1920 pixels width (possibly also at 72 dpi?) 3. Press "." after 'Bouw' 4. The 'w' spacing changes Actual Results: Spacing changes Expected Results: Same as prior to the point (.) Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: b60b6bfaafa1315e07108dba50f016975b619c59 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-US (nl_NL); UI: en-US Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144861] New: 44 malware mis en quarantaine par Immunet lors du téléchargement de LibreOffice 7.2.1.2 Win64
https://bugs.documentfoundation.org/show_bug.cgi?id=144861 Bug ID: 144861 Summary: 44 malware mis en quarantaine par Immunet lors du téléchargement de LibreOffice 7.2.1.2 Win64 Product: LibreOffice Version: 7.2.1.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jfcom...@gmail.com Description: Les exécutables de LibreOffice ne sont plus accessibles sur mon PC sous w10 après la mise en quarantaine par Immunet qui a découvert un Malware dans soffice.bin : Clam.Win.Malware.Dqan-9897603-0 Steps to Reproduce: 1.télécharger la version 7.2.1.2 w64 sur site LibreOffice.org 2.installer sur pc w10 avec Immunet 3.vérifier mise en quarantaine 44 fichiers, utilisation impossible Actual Results: Impossible de trouver l’es exécutable de l’ensemble des modules de LibreOffice : Draw, Writer, Cálc, Etc… Expected Results: Ouverture impossible des différentes applications comme c’était le cas depuis deux ans… Reproducible: Always User Profile Reset: No Additional Info: Ouverture normales des différentes applications comme c’était le cas depuis deux ans… -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143971] LibreOffice 7.2 introduced addition popup for read only file that shouldn't be showing
https://bugs.documentfoundation.org/show_bug.cgi?id=143971 Lant changed: What|Removed |Added OS|Windows (All) |Linux (All) --- Comment #6 from Lant --- (In reply to Roman Kuznetsov from comment #5) > *** Bug 144845 has been marked as a duplicate of this bug. *** In a Bug 144845 I offer change upper information string that appears if we open a read-only document. Button "Notify" could be move from popup to this string. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143971] LibreOffice 7.2 introduced addition popup for read only file that shouldn't be showing
https://bugs.documentfoundation.org/show_bug.cgi?id=143971 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||lantcod...@mail.ru --- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 144845 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144845] Pop-up dialog while opening a read-only file
https://bugs.documentfoundation.org/show_bug.cgi?id=144845 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC|libreoffice-ux-advise@lists |79045_79...@mail.ru |.freedesktop.org| Resolution|--- |DUPLICATE Status|NEW |RESOLVED Keywords|needsUXEval | --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 143971 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144845] Pop-up dialog while opening a read-only file
https://bugs.documentfoundation.org/show_bug.cgi?id=144845 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC|libreoffice-ux-advise@lists |79045_79...@mail.ru |.freedesktop.org| Resolution|--- |DUPLICATE Status|NEW |RESOLVED Keywords|needsUXEval | --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 143971 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0068583984c4ff7b33857cd5f351eb8a63e6a3e7 Author: Andras Timar AuthorDate: Fri Oct 1 21:59:28 2021 +0200 Commit: Gerrit Code Review CommitDate: Fri Oct 1 21:59:28 2021 +0200 Update git submodules * Update dictionaries from branch 'master' to 6176d3f2ce67c3f897f1507fe52680ad9d9fe7fc - add translations of pt_BR grammar checker dialog Change-Id: Ie091c2de7365ef4d980a06b017e8771e97feca82 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/122966 Tested-by: Andras Timar Reviewed-by: Andras Timar diff --git a/dictionaries b/dictionaries index bc821271e3bf..6176d3f2ce67 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit bc821271e3bf99a4228a29f25f066fd3bac307fb +Subproject commit 6176d3f2ce67c3f897f1507fe52680ad9d9fe7fc
[Libreoffice-commits] dictionaries.git: Dictionary_pt-BR.mk
Dictionary_pt-BR.mk |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 6176d3f2ce67c3f897f1507fe52680ad9d9fe7fc Author: Andras Timar AuthorDate: Fri Oct 1 21:47:28 2021 +0200 Commit: Andras Timar CommitDate: Fri Oct 1 21:59:27 2021 +0200 add translations of pt_BR grammar checker dialog Change-Id: Ie091c2de7365ef4d980a06b017e8771e97feca82 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/122966 Tested-by: Andras Timar Reviewed-by: Andras Timar diff --git a/Dictionary_pt-BR.mk b/Dictionary_pt-BR.mk index 153f058..178662d 100644 --- a/Dictionary_pt-BR.mk +++ b/Dictionary_pt-BR.mk @@ -28,7 +28,6 @@ $(eval $(call gb_Dictionary_add_files,dict-pt-BR,dialog,\ dictionaries/pt_BR/dialog/pt_BR.xdl \ dictionaries/pt_BR/dialog/pt_BR_pt_BR.default \ dictionaries/pt_BR/dialog/pt_BR_pt_BR.properties \ -dictionaries/pt_BR/dialog/pt_BR_en_US.properties \ )) $(eval $(call gb_Dictionary_add_files,dict-pt-BR,pythonpath,\ @@ -48,4 +47,9 @@ $(eval $(call gb_Dictionary_add_localized_xcu_file,dict-pt-BR,dialog,\ dictionaries/pt_BR/dialog/registry/data/org/openoffice/Office/OptionsDialog.xcu \ )) +$(eval $(call gb_Dictionary_add_propertyfiles,dict-pt-BR,dialog,\ +dictionaries/pt_BR/dialog/pt_BR_en_US.properties \ +)) + + # vim: set noet sw=4 ts=4:
[Libreoffice-bugs] [Bug 144845] Pop-up dialog while opening a read-only file
https://bugs.documentfoundation.org/show_bug.cgi?id=144845 Ezinne changed: What|Removed |Added Keywords||needsUXEval Ever confirmed|0 |1 CC||libreoffice-ux-advise@lists ||.freedesktop.org Status|UNCONFIRMED |NEW --- Comment #1 from Ezinne --- UX Team -- please take a look at this enhancement. Thanks! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 144845] Pop-up dialog while opening a read-only file
https://bugs.documentfoundation.org/show_bug.cgi?id=144845 Ezinne changed: What|Removed |Added Keywords||needsUXEval Ever confirmed|0 |1 CC||libreoffice-ux-advise@lists ||.freedesktop.org Status|UNCONFIRMED |NEW --- Comment #1 from Ezinne --- UX Team -- please take a look at this enhancement. Thanks! -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 144840] Special Paste RTF: Table with merged cells messed up
https://bugs.documentfoundation.org/show_bug.cgi?id=144840 Ezinne changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||bibisectRequest, regression --- Comment #2 from Ezinne --- Reproducible in: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-30_21:07:11 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144838] EDITING Align center on a paragraph is not recorded as tracked change
https://bugs.documentfoundation.org/show_bug.cgi?id=144838 Ezinne changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Ezinne --- Reproducible in: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-30_21:07:11 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144836] EDITING Coloring a paragraph’s area is not recorded as tracked change
https://bugs.documentfoundation.org/show_bug.cgi?id=144836 Ezinne changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Ezinne --- Reproducible in: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-30_21:07:11 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144827] EDITING Creating an ordered/unordered list is not recorded as tracked change
https://bugs.documentfoundation.org/show_bug.cgi?id=144827 Ezinne changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Ezinne --- Reproducible in: Version: 7.3.0.0.alpha0+ / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 8; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-09-30_21:07:11 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/fmcomp/gridcell.cxx |6 +++---
svx/source/inc/gridcell.hxx|4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit ea8e41710045a1e20f6cc1d210f3534c4f5fe9c9
Author: Caolán McNamara
AuthorDate: Fri Oct 1 15:49:45 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 1 21:34:45 2021 +0200
Related: tdf#141633 use IsMultiLineEdit instead of !IsSimpleEdit
seeing as the meaning of not simple is multi line editing instead
of something more exotic like more complex formatted text
Change-Id: Ic08834eed31b35ce16ba34bbbf8ff111d1a67da0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122952
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index da5a387ad187..45362a0e7140 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -1028,7 +1028,7 @@ void
DbLimitedLengthField::implSetEffectiveMaxTextLen(sal_Int32 nMaxLen)
DbTextField::DbTextField(DbGridColumn& _rColumn)
:DbLimitedLengthField(_rColumn)
-,m_bIsSimpleEdit( true )
+,m_bIsMultiLineEdit(false)
{
}
@@ -1061,7 +1061,7 @@ void DbTextField::Init(BrowserDataWin& rParent, const
Reference< XRowSet >& xCur
"caught an exception while determining the
multi-line capabilities!");
}
-m_bIsSimpleEdit = !bIsMultiLine;
+m_bIsMultiLineEdit = bIsMultiLine;
if ( bIsMultiLine )
{
auto xEditControl = VclPtr::Create();
@@ -3627,7 +3627,7 @@ FmXEditCell::FmXEditCell( DbGridColumn* pColumn,
std::unique_ptr
{
m_pEditImplementation = pTextField->GetEditImplementation();
-if ( !pTextField->IsSimpleEdit() )
+if (pTextField->IsMultiLineEdit())
m_bFastPaint = false;
}
else
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index ee2ddc061f28..081f7a4bc684 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -380,7 +380,7 @@ class DbTextField final : public DbLimitedLengthField
{
std::unique_ptr<::svt::IEditImplementation> m_pEdit;
std::unique_ptr<::svt::IEditImplementation> m_pPainterImplementation;
-boolm_bIsSimpleEdit;
+boolm_bIsMultiLineEdit;
virtual ~DbTextField( ) override;
@@ -388,7 +388,7 @@ public:
DbTextField(DbGridColumn& _rColumn);
::svt::IEditImplementation* GetEditImplementation() { return
m_pEdit.get(); }
-boolIsSimpleEdit() const { return m_bIsSimpleEdit; }
+bool IsMultiLineEdit() const { return m_bIsMultiLineEdit; }
virtual void Init( BrowserDataWin& rParent, const css::uno::Reference<
css::sdbc::XRowSet >& xCursor ) override;
virtual OUString GetFormatText(const css::uno::Reference<
css::sdb::XColumn >& _rxField, const css::uno::Reference<
css::util::XNumberFormatter >& xFormatter, const Color** ppColor = nullptr)
override;
[Libreoffice-commits] core.git: svtools/uiconfig
svtools/uiconfig/ui/textviewcontrol.ui |1 + 1 file changed, 1 insertion(+) New commits: commit 56665a7265b0acce2c1c4908f07604ad77c3680f Author: Caolán McNamara AuthorDate: Fri Oct 1 16:33:46 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Oct 1 21:34:12 2021 +0200 tdf#141633 table control expects the textview widget to word-char wrap at some point in the future https://gitlab.gnome.org/GNOME/gtk/-/issues/2530 becomes available to consider using Change-Id: I7221075093f3d1712f30a0e7454ed63ddbabae55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122931 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/svtools/uiconfig/ui/textviewcontrol.ui b/svtools/uiconfig/ui/textviewcontrol.ui index fa8ea541b8d2..be833f17acc4 100644 --- a/svtools/uiconfig/ui/textviewcontrol.ui +++ b/svtools/uiconfig/ui/textviewcontrol.ui @@ -24,6 +24,7 @@ True True True +word-char False
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkframe.cxx | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
New commits:
commit 96d078596c4621319b355b131b90fe1291e0445f
Author: Caolán McNamara
AuthorDate: Fri Oct 1 10:43:52 2021 +0100
Commit: Caolán McNamara
CommitDate: Fri Oct 1 21:32:32 2021 +0200
bundle key forward calls together as a function
Change-Id: I9f3fe4ea0ac3bd0313d76a04eb3c44ce2192aede
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122925
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkframe.cxx b/vcl/unx/gtk3/gtkframe.cxx
index 7375ca4e9d7c..a62bdd67162b 100644
--- a/vcl/unx/gtk3/gtkframe.cxx
+++ b/vcl/unx/gtk3/gtkframe.cxx
@@ -3835,6 +3835,18 @@ gboolean GtkSalFrame::signalUnmap(GtkWidget*, GdkEvent*,
gpointer frame)
#endif
#if !GTK_CHECK_VERSION(4, 0, 0)
+
+static bool key_forward(GdkEventKey* pEvent, GtkWindow* pDest)
+{
+gpointer pClass = g_type_class_ref(GTK_TYPE_WINDOW);
+GtkWidgetClass* pWindowClass = GTK_WIDGET_CLASS(pClass);
+bool bHandled = pEvent->type == GDK_KEY_PRESS
+? pWindowClass->key_press_event(GTK_WIDGET(pDest), pEvent)
+: pWindowClass->key_release_event(GTK_WIDGET(pDest), pEvent);
+g_type_class_unref(pClass);
+return bHandled;
+}
+
gboolean GtkSalFrame::signalKey(GtkWidget* pWidget, GdkEventKey* pEvent,
gpointer frame)
{
UpdateLastInputEventTime(pEvent->time);
@@ -3853,15 +3865,10 @@ gboolean GtkSalFrame::signalKey(GtkWidget* pWidget,
GdkEventKey* pEvent, gpointe
{
if (!gtk_widget_get_realized(pFocusWindow))
return true;
-gpointer pClass = g_type_class_ref(GTK_TYPE_WINDOW);
-GtkWidgetClass* pWindowClass = GTK_WIDGET_CLASS(pClass);
+
// if the focus is not in our main widget, see if there is a
handler
// for this key stroke in GtkWindow first
-bool bHandled = pEvent->type == GDK_KEY_PRESS
-? pWindowClass->key_press_event(pThis->m_pWindow, pEvent)
-: pWindowClass->key_release_event(pThis->m_pWindow, pEvent);
-g_type_class_unref(pClass);
-if (bHandled)
+if (key_forward(pEvent, GTK_WINDOW(pThis->m_pWindow)))
return true;
// Is focus inside an InterimItemWindow? In which case find that
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/pagefooterpanel.ui |2 ++ sw/uiconfig/swriter/ui/pageformatpanel.ui |5 + sw/uiconfig/swriter/ui/pageheaderpanel.ui |2 ++ 3 files changed, 9 insertions(+) New commits: commit aefff80c531d1fe9747157a7068b3d58b6e0349f Author: Caolán McNamara AuthorDate: Fri Oct 1 12:46:45 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Oct 1 21:32:17 2021 +0200 add missing use-underline for labels Change-Id: I0fceeb6d3f7111dbbf5ee5bb68cb512b24923e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122924 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/pagefooterpanel.ui b/sw/uiconfig/swriter/ui/pagefooterpanel.ui index ae4610ab000e..8956ab5ad5ea 100644 --- a/sw/uiconfig/swriter/ui/pagefooterpanel.ui +++ b/sw/uiconfig/swriter/ui/pagefooterpanel.ui @@ -34,6 +34,7 @@ False end Spacing: +True spacingpreset @@ -47,6 +48,7 @@ False end Same Content: +True samecontentLB diff --git a/sw/uiconfig/swriter/ui/pageformatpanel.ui b/sw/uiconfig/swriter/ui/pageformatpanel.ui index 277535d5cdae..8df447b22e9e 100644 --- a/sw/uiconfig/swriter/ui/pageformatpanel.ui +++ b/sw/uiconfig/swriter/ui/pageformatpanel.ui @@ -22,6 +22,7 @@ True False Size: +True papersize 1 @@ -35,6 +36,7 @@ True False Width: +True paperwidth 1 @@ -48,6 +50,7 @@ True False Height: +True paperheight 1 @@ -61,6 +64,7 @@ True False Orientation: +True paperorientation 1 @@ -128,6 +132,7 @@ True False Margins: +True marginLB 1 diff --git a/sw/uiconfig/swriter/ui/pageheaderpanel.ui b/sw/uiconfig/swriter/ui/pageheaderpanel.ui index 641c03fa90a5..24aa2832c4db 100644 --- a/sw/uiconfig/swriter/ui/pageheaderpanel.ui +++ b/sw/uiconfig/swriter/ui/pageheaderpanel.ui @@ -34,6 +34,7 @@ False end Spacing: +True spacingpreset @@ -47,6 +48,7 @@ False end Same Content: +True samecontentLB
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/pagefooterpanel.ui |2 sw/uiconfig/swriter/ui/pageformatpanel.ui | 104 +++--- sw/uiconfig/swriter/ui/pageheaderpanel.ui |2 3 files changed, 54 insertions(+), 54 deletions(-) New commits: commit 0109c2d08306b25f632030fcd1a719466eea48ef Author: Caolán McNamara AuthorDate: Fri Oct 1 12:45:57 2021 +0100 Commit: Caolán McNamara CommitDate: Fri Oct 1 21:31:51 2021 +0200 resave with latest glade Change-Id: Idcb357670a49b833950f475b483e590d166635b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122923 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/sw/uiconfig/swriter/ui/pagefooterpanel.ui b/sw/uiconfig/swriter/ui/pagefooterpanel.ui index c1ffc740cd22..ae4610ab000e 100644 --- a/sw/uiconfig/swriter/ui/pagefooterpanel.ui +++ b/sw/uiconfig/swriter/ui/pagefooterpanel.ui @@ -1,5 +1,5 @@ - + diff --git a/sw/uiconfig/swriter/ui/pageformatpanel.ui b/sw/uiconfig/swriter/ui/pageformatpanel.ui index 2eb7cdfe4f5d..277535d5cdae 100644 --- a/sw/uiconfig/swriter/ui/pageformatpanel.ui +++ b/sw/uiconfig/swriter/ui/pageformatpanel.ui @@ -1,106 +1,106 @@ - + True -False +False - + True -False +False end True True -6 -6 -6 +6 +6 +6 True -False +False Size: -papersize +papersize 1 -0 -0 +0 +0 True -False +False Width: -paperwidth +paperwidth 1 -0 -1 +0 +1 True -False +False Height: -paperheight +paperheight 1 -0 -2 +0 +2 True -False +False Orientation: -paperorientation +paperorientation 1 -0 -3 +0 +3 True -True -Paper Width +True +Paper Width True -True 0 +True -1 -1 +1 +1 True -True -Paper Height +True +Paper Height True -True 0 +True -1 -2 +1 +2 True -False +False True Portrait @@ -108,54 +108,54 @@ -1 -3 +1 +3 True -False +False True -1 -0 +1 +0 True -False +False Margins: -marginLB +marginLB 1 -0 -4 +0 +4 True -False +False True -1 -4 +1 +4 -False -True +False +True Custom -1 -5 +1 +5 @@ -163,8 +163,8 @@ -0 -0 +0 +0 diff --git a/sw/uiconfig/swriter/ui/pageheaderpanel.ui b/sw/uiconfig/swriter/ui/pageheaderpanel.ui index db9c6b2075f2..641c03fa90a5 100644 --- a/sw/uiconfig/swriter/ui/pageheaderpanel.ui +++ b/sw/uiconfig/swriter/ui/pageheaderpanel.ui @@ -1,5 +1,5 @@ - +
[Libreoffice-bugs] [Bug 144860] CALC Autoinput appears to have dual functionality
https://bugs.documentfoundation.org/show_bug.cgi?id=144860 Eike Rathke changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|7.2.1.2 release |5.3 all versions Ever confirmed|0 |1 OS|Windows (All) |All --- Comment #1 from Eike Rathke --- Confirmed, at least since release 5.3.z Easy check with typing =ABS( then the function syntax help bubble should appear. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - basic/source canvas/source compilerplugins/clang connectivity/source drawinglayer/source editeng/inc editeng/source i18npool/inc i18npool/source include/edi
basic/source/basmgr/basmgr.cxx|2 - basic/source/inc/scanner.hxx |2 - canvas/source/vcl/canvashelper_texturefill.cxx|2 - compilerplugins/clang/constparams.cxx |5 ++ connectivity/source/commontools/sqlerror.cxx |9 ++-- connectivity/source/resource/sharedresources.cxx |4 +- drawinglayer/source/processor2d/vclmetafileprocessor2d.cxx|2 - drawinglayer/source/processor2d/vclmetafileprocessor2d.hxx|2 - editeng/inc/editdoc.hxx |2 - editeng/source/editeng/editeng.cxx|4 +- editeng/source/editeng/impedit.hxx|8 ++-- editeng/source/outliner/outliner.cxx |8 ++-- editeng/source/uno/unoedprx.cxx |2 - i18npool/inc/cclass_unicode.hxx |2 - i18npool/inc/characterclassificationImpl.hxx |8 ++-- i18npool/inc/indexentrysupplier_common.hxx|2 - i18npool/inc/transliteration_Numeric.hxx |2 - i18npool/inc/xdictionary.hxx |6 +-- i18npool/source/breakiterator/xdictionary.cxx |6 +-- i18npool/source/characterclassification/cclass_unicode_parser.cxx |2 - i18npool/source/indexentry/indexentrysupplier_common.cxx |2 - i18npool/source/localedata/localedata.cxx |2 - i18npool/source/search/levdis.hxx |2 - i18npool/source/transliteration/transliteration_Numeric.cxx |2 - include/editeng/editeng.hxx |6 +-- include/editeng/outliner.hxx |8 ++-- include/editeng/unoedprx.hxx |2 - include/package/Inflater.hxx |4 +- include/sfx2/listview.hxx |8 ++-- include/sfx2/thumbnailview.hxx|4 +- include/svtools/brwbox.hxx|6 +-- include/svtools/ctrlbox.hxx | 14 +++ include/svtools/miscopt.hxx |2 - include/svtools/valueset.hxx |2 - include/svx/gallerybinaryengineentry.hxx |2 - include/svx/obj3d.hxx |2 - include/svx/svditer.hxx |2 - include/svx/svdpntv.hxx |2 - include/toolkit/awt/vclxwindows.hxx |2 - include/xmloff/xmlnumfi.hxx |2 - include/xmloff/xmluconv.hxx |6 +-- package/source/xstor/owriteablestream.hxx |2 - sc/source/ui/inc/anyrefdg.hxx |2 - sc/source/ui/inc/gridwin.hxx |2 - scripting/source/provider/ProviderCache.cxx |2 - scripting/source/provider/ProviderCache.hxx |2 - sd/source/ui/inc/View.hxx |2 - sd/source/ui/view/sdview3.cxx |2 - sfx2/source/control/listview.cxx |2 - sfx2/source/control/thumbnailview.cxx |4 +- svtools/source/brwbox/brwbox1.cxx |2 - svtools/source/brwbox/brwbox2.cxx |2 - svtools/source/brwbox/datwin.cxx |2 - svtools/source/brwbox/datwin.hxx |2 - svtools/source/config/colorcfg.cxx|2 - svtools/source/config/miscopt.cxx |4 +- svtools/source/control/ctrlbox.cxx|2 - svtools/source/control/valueset.cxx |2 - svtools/source/table/tablecontrol_impl.cxx|4 +- svtools/source/table/tablecontrol_impl.hxx|4 +- svx/source/engine3d/obj3d.cxx |2 - svx/source/gallery2/galini.cxx|2 - sw/source/uibase/dochdl/swdtflvr.cxx | 20 +- sw/source/uibase/inc/navicont.hxx |2 - sw/source/uibase/inc/navipi.hxx |2 -
[Libreoffice-bugs] [Bug 144860] New: CALC Autoinput appears to have dual functionality
https://bugs.documentfoundation.org/show_bug.cgi?id=144860 Bug ID: 144860 Summary: CALC Autoinput appears to have dual functionality Product: LibreOffice Version: 7.2.1.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: The setting Tools>Autoinput toggles two distinct actions. Firstly, if a text value occurs in a column then that value will be autoinserted into another cell upon a partial match viz C2 contains text "2+1" and immediately "2" is typed into say C4 it is automatically changed to "2+1". Seems like a reasonable interpretation of autoinsert. Secondly, if a cell containing a formula is double-clicked to enable editing and the cursor is placed anywhere in the formula, then a syntax "tooltip" is presented to the user. One might expect this to be a co-property of Tools>Options>General Help - Extended tips, which only impacts tool buttons and some popup panels. Steps to Reproduce: Defined in the description Actual Results: "Inconsistent" dual functionality Expected Results: Specific functionality from two toggles Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.2.1.2 (x64) / LibreOffice Community Build ID: 87b77fad49947c1441b67c559c339af8f3517e22 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 32485] Settings on the image frame style lost when caption is applied
https://bugs.documentfoundation.org/show_bug.cgi?id=32485 --- Comment #16 from RGB --- Problem still present in LibreOffice 7.2.1.2. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sc/source
sc/source/ui/view/gridwin.cxx | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
New commits:
commit 4529a8ce16ef791a4e572898149e831b2b537157
Author: Vasily Melenchuk
AuthorDate: Thu Sep 30 14:10:12 2021 +0200
Commit: Thorsten Behrens
CommitDate: Fri Oct 1 20:16:04 2021 +0200
sc: colorfilter dangling pointer fixed
Upper call to aParam.RemoveAllEntriesByField can invalidate
pEntry, making further calls to pEntry->SetQueryBy* illegal.
Anyway at this branch we are disabling color filter, so this
is not required.
Change-Id: Ia595649975b659d28056ba3f3658c306e63088f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122822
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122929
Tested-by: Thorsten Behrens
Reviewed-by: Thorsten Behrens
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 37f2ee4e9f72..99e5ca53eec1 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -934,6 +934,7 @@ void ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode
eMode)
if (nSelected == nActive)
{
aParam.RemoveAllEntriesByField(rPos.Col());
+pEntry = nullptr; // invalidated by
RemoveAllEntriesByField call
// tdf#46184 reset filter options to default values
aParam.eSearchType = utl::SearchParam::SearchType::Normal;
@@ -941,16 +942,18 @@ void
ScGridWindow::UpdateAutoFilterFromMenu(AutoFilterMode eMode)
aParam.bDuplicate = true;
aParam.bInplace = true;
}
-
-// Get selected color from set
-std::set::iterator it = aColors.begin();
-std::advance(it, nSelected - 1);
-Color selectedColor = *it;
-
-if (eMode == AutoFilterMode::TextColor)
-pEntry->SetQueryByTextColor(selectedColor);
else
-pEntry->SetQueryByBackgroundColor(selectedColor);
+{
+// Get selected color from set
+std::set::iterator it = aColors.begin();
+std::advance(it, nSelected - 1);
+Color selectedColor = *it;
+
+if (eMode == AutoFilterMode::TextColor)
+pEntry->SetQueryByTextColor(selectedColor);
+else
+pEntry->SetQueryByBackgroundColor(selectedColor);
+}
}
break;
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 397eb9155a4b3399e78374fc8561de29b3d2cee6 Author: Ross Johnson AuthorDate: Sat Oct 2 04:12:59 2021 +1000 Commit: Gerrit Code Review CommitDate: Fri Oct 1 20:12:59 2021 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 8b955ca1d2fa8132a22be12daeb416618277905c - tdf#123506 - focus search results to user's current module This change focuses the search results on the module the user initially called help from and in addition, in the same way that the initial index is presented, limits the results to that module plus GLOBAL results. Explanation: Currently, when a user arrives at a help page from a module they begin with a blank search term and by default the index is focused on the module they came from. As they enter a search term the results from ALL modules are presented, paginated and either, (7.3 current) grouped by modules but in a fixed order of modules that often pushes results relative to the user's module off the first page of the index or, (7.2 and earlier) pseudo randomly with incorrect grouping under modules. If a user wishes to explor other module results they can choose a module from the Modules drop down. Their search term remains and they can easily search again. Change-Id: Ib10dd55d1c68a839938842fe3607a7a7619b3538 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122903 Tested-by: Jenkins Reviewed-by: Olivier Hallot Reviewed-by: Rafael Lima diff --git a/helpcontent2 b/helpcontent2 index b81bdbf9511c..8b955ca1d2fa 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit b81bdbf9511ce46f4556582c0b971e35c509d468 +Subproject commit 8b955ca1d2fa8132a22be12daeb416618277905c
[Libreoffice-commits] help.git: help3xsl/help.js
help3xsl/help.js | 43 ---
1 file changed, 32 insertions(+), 11 deletions(-)
New commits:
commit 8b955ca1d2fa8132a22be12daeb416618277905c
Author: Ross Johnson
AuthorDate: Wed Sep 29 23:45:54 2021 +1000
Commit: Olivier Hallot
CommitDate: Fri Oct 1 20:12:57 2021 +0200
tdf#123506 - focus search results to user's current module
This change focuses the search results on the module the user initially
called help from and in addition, in the same way that the initial index
is presented, limits the results to that module plus GLOBAL results.
Explanation:
Currently, when a user arrives at a help page from a module they begin
with a blank search term and by default the index is focused on the module
they came from.
As they enter a search term the results from ALL modules are presented,
paginated and either, (7.3 current) grouped by modules but in a fixed
order of modules that often pushes results relative to the user's
module off the first page of the index or, (7.2 and earlier)
pseudo randomly with incorrect grouping under modules.
If a user wishes to explor other module results they can choose a module
from the Modules drop down. Their search term remains and they can
easily search again.
Change-Id: Ib10dd55d1c68a839938842fe3607a7a7619b3538
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/122903
Tested-by: Jenkins
Reviewed-by: Olivier Hallot
Reviewed-by: Rafael Lima
diff --git a/help3xsl/help.js b/help3xsl/help.js
index 1f767a9c1..c67581d7b 100644
--- a/help3xsl/help.js
+++ b/help3xsl/help.js
@@ -11,9 +11,10 @@
var url = window.location.pathname;
var moduleRegex = new RegExp('text\\/(\\w+)\\/');
var regexArray = moduleRegex.exec(url);
+var userModule = currentModule();
var modules = ['CALC', 'WRITER', 'IMPRESS', 'DRAW', 'BASE', 'MATH', 'CHART',
'BASIC', 'SHARED'];
var indexEl = document.getElementsByClassName("index")[0];
-var fullLinks = fullLinkify(indexEl, bookmarks, modules, currentModule());
+var fullLinks = fullLinkify(indexEl, bookmarks, modules, userModule);
var search = document.getElementById('search-bar');
search.addEventListener('keyup', debounce(filter, 100, indexEl));
var flexIndex = new FlexSearch.Document({ document: {
@@ -38,17 +39,29 @@ window.addEventListener('unload', function(event) {
sessionStorage.setItem('searchsave', search.value);
});
+function getQuery(q) {
+ var pattern = new RegExp('[?&]' + q + '=([^&]+)');
+ var param = window.location.search.match(pattern);
+ if (param) {
+ return param[1];
+ }
+ return null;
+}
+
function currentModule() {
-var module = '';
-// get the module name from the URL and remove the first character,
-// but first deal with snowflake Base
-if(url.indexOf('explorer/database/') !== -1) {
-module = 'BASE';
-} else {
-if (null === regexArray){// comes from search or elsewhere, no defined
module in URL
-module = 'HARED'
+// We need to know the module that the user is using when they call for
help
+var module = getQuery('DbPAR');
+if (module == null) {
+// get the module name from the URL and remove the first character,
+// but first deal with snowflake Base
+if(url.indexOf('explorer/database/') !== -1) {
+module = 'BASE';
} else {
-module = regexArray[1].toUpperCase().substring(1);
+if (null === regexArray){// comes from search or elsewhere, no
defined module in URL
+module = 'HARED'
+} else {
+module = regexArray[1].toUpperCase().substring(1);
+}
}
}
return module;
@@ -99,6 +112,14 @@ function filter(indexList) {
let regex = new RegExp(target.split(/\s+/).filter((i) =>
i?.length).join("|"), 'gi');
let results = flexIndex.search(target, { pluck: "text", enrich: true,
limit: 1000 });
+// Similarly to fullLinkify(), limit search results to the user's current
module + shared
+// unless they're somehow not coming from a module.
+if(userModule !== 'HARED') {
+resultModules = [userModule, 'SHARED'];
+} else {
+resultModules = modules;
+}
+
// tdf#123506 - Group the filtered list into module groups, keeping the
ordering
modules.forEach(function(module) {
group[module] = '';
@@ -106,7 +127,7 @@ function filter(indexList) {
results.forEach(function(result) {
group[result.doc.app] += '' + result.doc.text.replace(regex, (match) =>
`${match}`) + '';
});
-modules.forEach(function(module) {
+resultModules.forEach(function(module) {
if (group[module].length > 0) {
filtered += group[module];
}
[Libreoffice-bugs] [Bug 97629] [META] Help Content Modernization
https://bugs.documentfoundation.org/show_bug.cgi?id=97629 Olivier Hallot changed: What|Removed |Added Depends on||144859 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144859 [Bug 144859] mechanism misbehaves when embedded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144859] mechanism misbehaves when embedded
https://bugs.documentfoundation.org/show_bug.cgi?id=144859 Olivier Hallot changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Blocks||97629 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97629 [Bug 97629] [META] Help Content Modernization -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144215] MAILMERGE: if saved as individual documents - filenames should start from 1 (one), not 0 (zero), also for Print
https://bugs.documentfoundation.org/show_bug.cgi?id=144215 Justin L changed: What|Removed |Added Assignee|jl...@mail.com |libreoffice-b...@lists.free ||desktop.org --- Comment #8 from Justin L --- Based on review "Last time I did something like this, some people complained about failing scripts via UNO MM. You'll probably get new bugs as a regression." I abandoned https://gerrit.libreoffice.org/c/core/+/122489. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127543] FILESAVE: "Save a Copy" is missing in tabbed notebookbar
https://bugs.documentfoundation.org/show_bug.cgi?id=127543 --- Comment #14 from Commit Notification --- Justin Luth committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/57f8b90d46756c22f01961260241fd2ab4bc64c5 tdf#127543 add saveacopy to Save dropdown menu It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: framework/source
framework/source/uielement/resourcemenucontroller.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 57f8b90d46756c22f01961260241fd2ab4bc64c5 Author: Justin Luth AuthorDate: Sat Sep 25 15:06:58 2021 +0200 Commit: Adolfo Jayme Barrientos CommitDate: Fri Oct 1 19:55:46 2021 +0200 tdf#127543 add saveacopy to Save dropdown menu Why not? It usually doesn't exist in a nearby shortcut. Change-Id: I3f9f0070c05bb1ce05795cabe8db0f95593ab5cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122606 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos diff --git a/framework/source/uielement/resourcemenucontroller.cxx b/framework/source/uielement/resourcemenucontroller.cxx index 6e83ca846977..cebd11f03c19 100644 --- a/framework/source/uielement/resourcemenucontroller.cxx +++ b/framework/source/uielement/resourcemenucontroller.cxx @@ -400,6 +400,7 @@ void SaveAsMenuController::impl_setPopupMenu() pVCLPopupMenu->InsertItem( ".uno:SaveAs", nullptr ); pVCLPopupMenu->InsertItem( ".uno:ExportTo", nullptr ); +pVCLPopupMenu->InsertItem( ".uno:SaveACopy", nullptr ); pVCLPopupMenu->InsertItem( ".uno:SaveAsTemplate", nullptr ); pVCLPopupMenu->InsertSeparator(); pVCLPopupMenu->InsertItem( ".uno:SaveAsRemote", nullptr );
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/source
desktop/source/lib/init.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e3f45fdc1e6547b35ab69a01e57ee7c926b8b7e7
Author: Mert Tumer
AuthorDate: Fri Oct 1 15:34:33 2021 +0300
Commit: Mert Tumer
CommitDate: Fri Oct 1 19:45:46 2021 +0200
lok: Fix graphicselection INPLACE msg is filtered out
INPLACE message is not at the beginning,
search it instead
Signed-off-by: Mert Tumer
Change-Id: I2a09ac5a664c1ff26790aa776d871ac34c3d99dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122919
Reviewed-by: Szymon Kłos
Tested-by: Jenkins CollaboraOffice
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index dab77ee9aa8b..7e92549a7cb9 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1673,7 +1673,7 @@ void CallbackFlushHandler::queue(const int type, const
char* data)
// remove only selection ranges and 'EMPTY' messages
// always send 'INPLACE' and 'INPLACE EXIT' messages
removeAll(type, [payload] (const CallbackData& elemData)
-{ return (elemData.PayloadString[0] != 'I'); });
+{ return (elemData.PayloadString.find("INPLACE") ==
std::string::npos); });
}
break;
}
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/math.cxx | 64 ---
1 file changed, 24 insertions(+), 40 deletions(-)
New commits:
commit de80116e81a5b73215098cd0aa60ac9226905ae5
Author: Mike Kaganski
AuthorDate: Fri Oct 1 09:17:03 2021 +0200
Commit: Mike Kaganski
CommitDate: Fri Oct 1 19:36:41 2021 +0200
Simplify the code a bit to clarify the logic
Change-Id: I80201148684f6e297ff0c880c0dbbc346129a557
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122864
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 2d1c1257ef97..f6a2b15a21d4 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -580,64 +580,48 @@ void doubleToString(typename T::String ** pResult,
if (nDigit >= 10)
{ // after-treatment of up-rounding to the next decade
-sal_Int32 sLen = p - pBuf - 1;
-if (sLen == -1 || (sLen == 0 && bSign))
+typename T::Char* p1 = pBuf;
+// Assert that no one changed the logic we rely on.
+assert(!bSign || *p1 == '-');
+// Do not touch leading minus sign put earlier.
+if (bSign)
+++p1;
+assert(p1 <= p);
+if (p1 == p)
{
-// Assert that no one changed the logic we rely on.
-assert(!bSign || pBuf[0] == '-');
-p = pBuf;
-if (bSign)
-++p;
-if (eFormat == rtl_math_StringFormat_F)
+*p++ = '1';
+if (eFormat != rtl_math_StringFormat_F)
{
-*p++ = '1';
-*p++ = '0';
-}
-else
-{
-*p++ = '1';
*p++ = cDecSeparator;
-*p++ = '0';
nExp++;
bHasDec = true;
}
+*p++ = '0';
}
else
{
-for (sal_Int32 j = sLen; j >= 0; j--)
+for (typename T::Char* p2 = p - 1; p2 >= p1; --p2)
{
-typename T::Char* p2 = [j];
typename T::Char cS = *p2;
-if (j == 0 && bSign)
+if (cS == cDecSeparator)
+continue;
+if (cS != '9')
{
-// Do not touch leading minus sign put earlier.
-assert(cS == '-');
-break; // for, this is the last character
backwards.
+++*p2;
+break;
}
-if (cS != cDecSeparator)
+*p2 = '0';
+if (p2 == p1) // The number consisted of all 9s
replaced to all 0s
{
-if (cS != '9')
-{
-*p2 = ++cS;
-j = -1; // break loop
+if (eFormat == rtl_math_StringFormat_F)
+{ // move everything to the right before
inserting '1'
+std::memmove(p2 + 1, p2, (p++ - p2) *
sizeof(*p));
}
else
{
-*p2 = '0';
-if (j == 0 || (j == 1 && bSign))
-{
-if (eFormat == rtl_math_StringFormat_F)
-{ // insert '1'
-std::memmove(p2 + 1, p2, (p++ -
p2) * sizeof(*p));
-*p2 = '1';
-}
-else
-{
-*p2 = '1';
-nExp++;
-}
-}
+nExp++;
}
+*p2 = '1';
}
}
[Libreoffice-bugs] [Bug 144857] Cannot select options from drop down menu in 7.2.1.2 upgrade
https://bugs.documentfoundation.org/show_bug.cgi?id=144857 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4037 -- You are receiving this mail because: You are the assignee for the bug.
