[Libreoffice-commits] core.git: dbaccess/source

2021-11-10 Thread Julien Nabet (via logerrit)
 dbaccess/source/core/api/CRowSetColumn.cxx |   42 -
 dbaccess/source/core/api/CRowSetDataColumn.cxx |   42 -
 dbaccess/source/core/api/definitioncolumn.cxx  |   28 
 dbaccess/source/core/api/resultcolumn.cxx  |   42 -
 dbaccess/source/core/api/resultset.cxx |   12 +++
 dbaccess/source/core/api/statement.cxx |   20 +--
 dbaccess/source/core/dataaccess/datasource.cxx |   22 ++---
 dbaccess/source/inc/apitools.hxx   |   15 
 8 files changed, 104 insertions(+), 119 deletions(-)

New commits:
commit c9c9b8ec542d3c491159f23d0deb5358d4142486
Author: Julien Nabet 
AuthorDate: Wed Nov 10 23:10:01 2021 +0100
Commit: Julien Nabet 
CommitDate: Thu Nov 11 08:33:45 2021 +0100

Replace some macros in dbaccess part 4

Remove DECL_PROP0_BOOL + DECL_PROP1_BOOL + DECL_PROP0/1/2

Change-Id: I422d3dc4c09b5f8a88c8992de187458d74dc3d50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125015
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/core/api/CRowSetColumn.cxx 
b/dbaccess/source/core/api/CRowSetColumn.cxx
index cef90a8e8521..d8e2d18c0ff6 100644
--- a/dbaccess/source/core/api/CRowSetColumn.cxx
+++ b/dbaccess/source/core/api/CRowSetColumn.cxx
@@ -44,27 +44,27 @@ ORowSetColumn::ORowSetColumn( const Reference < 
XResultSetMetaData >& _xMetaData
 {
 BEGIN_PROPERTY_SEQUENCE(21)
 
-DECL_PROP1( CATALOGNAME,OUString,READONLY );
-DECL_PROP1( DISPLAYSIZE,sal_Int32,  READONLY );
-DECL_PROP1_BOOL( ISAUTOINCREMENT,   READONLY );
-DECL_PROP1_BOOL( ISCASESENSITIVE,   READONLY );
-DECL_PROP1_BOOL( ISCURRENCY,READONLY );
-DECL_PROP1_BOOL( ISDEFINITELYWRITABLE,  READONLY );
-DECL_PROP1( ISNULLABLE, sal_Int32,  READONLY );
-DECL_PROP1_BOOL( ISREADONLY,BOUND );
-DECL_PROP1_BOOL( ISROWVERSION,  READONLY );
-DECL_PROP1_BOOL( ISSEARCHABLE,  READONLY );
-DECL_PROP1_BOOL( ISSIGNED,  READONLY );
-DECL_PROP1_BOOL( ISWRITABLE,READONLY );
-DECL_PROP1( LABEL,  OUString,READONLY );
-DECL_PROP1( PRECISION,  sal_Int32,  READONLY );
-DECL_PROP1( SCALE,  sal_Int32,  READONLY );
-DECL_PROP1( SCHEMANAME, OUString,READONLY );
-DECL_PROP1( SERVICENAME,OUString,READONLY );
-DECL_PROP1( TABLENAME,  OUString,READONLY );
-DECL_PROP1( TYPE,   sal_Int32,  READONLY );
-DECL_PROP1( TYPENAME,   OUString,READONLY );
-DECL_PROP2( VALUE,  Any,READONLY, 
BOUND );
+DECL_PROP_IMPL(CATALOGNAME, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(DISPLAYSIZE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISAUTOINCREMENT, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISCASESENSITIVE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISCURRENCY, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISDEFINITELYWRITABLE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISNULLABLE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISREADONLY, cppu::UnoType::get()) 
css::beans::PropertyAttribute::BOUND );
+DECL_PROP_IMPL(ISROWVERSION, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISSEARCHABLE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISSIGNED, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(ISWRITABLE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(LABEL, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(PRECISION, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(SCALE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(SCHEMANAME, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(SERVICENAME, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(TABLENAME, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(TYPE, cppu::UnoType::get()) 
css::beans::PropertyAttribute::READONLY );
+DECL_PROP_IMPL(TYPENAME, cppu::UnoType::get(

[Libreoffice-commits] core.git: vcl/qt5

2021-11-10 Thread Michael Weghorn (via logerrit)
 vcl/qt5/QtFrame.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit f029fb6262b9a001e6cbfd60565b01a7b99ea627
Author: Michael Weghorn 
AuthorDate: Wed Nov 10 16:19:26 2021 +0100
Commit: Michael Weghorn 
CommitDate: Thu Nov 11 08:27:28 2021 +0100

qt (>=5.14): Don't create native window for QWidget in QtFrame::screen

For Qt >= 5.14, directly use 'QWidget::screen' (added in Qt 5.14)
to retrieve the screen that the widget is on, rather than first
retrieving a window handle, which forces a platform-native
window to be created.

Due to QTBUG-75766 [1], forcing the creation of
native windows also leads to mouseMoveEvents
not being reliably emitted by Qt, s.

commit 0e3c3b842e14b9646d3697cf1266be21359e0f13
Author: Michael Weghorn 
Date:   Sat May 11 21:31:33 2019 +0200

tdf#122293 qt5: Use "alien widgets" by default on Wayland

for more details.

The behaviour described in tdf#122293 started showing
up again after

commit b00a68a8e19370e106cd76258a3c1825f43613ee
Date:   Sun Oct 31 02:33:46 2021 +0200

tdf#145363 Qt reparent modal dialogs on show

but that just seems to have been a side-effect of
'QWidget::screen' now being called in different ways
than previously.

[1] https://bugreports.qt.io/browse/QTBUG-75766

Change-Id: Ic11923cef5e704c09494f96b19157372a869ae40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124997
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx
index 591e084edf38..db91e48a256c 100644
--- a/vcl/qt5/QtFrame.cxx
+++ b/vcl/qt5/QtFrame.cxx
@@ -363,8 +363,15 @@ QWindow* QtFrame::windowHandle() const
 
 QScreen* QtFrame::screen() const
 {
+#if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
+return asChild()->screen();
+#else
+// QWidget::screen only available from Qt 5.14 on, call windowHandle(),
+// with the indirect result that mouse move events on Wayland will not be
+// emitted reliably, s. QTBUG-75766
 QWindow* const pWindow = windowHandle();
 return pWindow ? pWindow->screen() : nullptr;
+#endif
 }
 
 bool QtFrame::isMinimized() const { return asChild()->isMinimized(); }


[Libreoffice-commits] core.git: download.lst

2021-11-10 Thread Miklos Vajna (via logerrit)
 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 84991e145c9e735240114e6ec4b94993060fb6c4
Author: Miklos Vajna 
AuthorDate: Wed Nov 10 20:26:23 2021 +0100
Commit: Miklos Vajna 
CommitDate: Thu Nov 11 08:14:06 2021 +0100

external: update libxmlsec to 1.2.33

Change-Id: I42c6ff24237614b2c0d5dc2aa0bcfd9bf7ee89e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125010
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/download.lst b/download.lst
index f0d5bfcdc2b9..0d48e0691625 100644
--- a/download.lst
+++ b/download.lst
@@ -164,8 +164,8 @@ export LIBNUMBERTEXT_SHA256SUM := 
17b8249cb89ae11ae15a85612d2665626c0e0e3e56b356
 export LIBNUMBERTEXT_TARBALL := libnumbertext-1.0.7.tar.xz
 export LIBTOMMATH_SHA256SUM := 
083daa92d8ee6f4af96a6143b12d7fc8fe1a547e14f862304f7281f8f7347483
 export LIBTOMMATH_TARBALL := ltm-1.0.zip
-export XMLSEC_SHA256SUM := 
e383702853236004e5b08e424b8afe9b53fe9f31aaa7a5382f39d9533eb7c043
-export XMLSEC_TARBALL := xmlsec1-1.2.32.tar.gz
+export XMLSEC_SHA256SUM := 
26041d35a20a245ed5a2fb9ee075f10825664d274220cb5190340fa87a4d0931
+export XMLSEC_TARBALL := xmlsec1-1.2.33.tar.gz
 export LIBXML_SHA256SUM := 
c8d6681e38c56f172892c85ddc0852e1fd4b53b4209e7f4ebf17f7e2eae71d92
 export LIBXML_VERSION_MICRO := 12
 export LIBXML_TARBALL := libxml2-2.9.$(LIBXML_VERSION_MICRO).tar.gz


[Libreoffice-commits] core.git: sw/source

2021-11-10 Thread Jim Raykowski (via logerrit)
 sw/source/uibase/utlui/content.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit cf636b3f5b033d1f1bf511958df96391d81b04df
Author: Jim Raykowski 
AuthorDate: Wed Nov 10 17:50:48 2021 -0900
Commit: Jim Raykowski 
CommitDate: Thu Nov 11 07:00:25 2021 +0100

SwNavigator: account for footnotes separator line in initial count

The separator line needs to be accounted for in the initial footnotes
members count to be shown without delay on first footnote insert and on
first display of the content tree when there are only footnotes, no
endnotes, in the document and also for the last endnote to be shown
without delay on first display of the content tree.

Change-Id: I09a5ad8a0cb4463518a91d680741b49b572cadc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125019
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index f877617e13a5..f938d8e2617a 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -417,12 +417,14 @@ void SwContentType::Init(bool* pbInvalidateWindow)
 break;
 case ContentTypeId::FOOTNOTE:
 {
-m_nMemberCount = 0;
 m_sTypeToken.clear();
 m_bEdit = true;
 m_bDelete = false;
 const SwFootnoteIdxs& rFootnoteIdxs = 
m_pWrtShell->GetDoc()->GetFootnoteIdxs();
 m_nMemberCount = rFootnoteIdxs.size();
+// account for the separator line
+if (m_nMemberCount > 0)
+m_nMemberCount++;
 }
 break;
 case ContentTypeId::BOOKMARK:


[Libreoffice-commits] core.git: sw/qa sw/source

2021-11-10 Thread Jim Raykowski (via logerrit)
 sw/qa/uitest/navigator/tdf114724.py |5 +
 sw/source/uibase/utlui/navipi.cxx   |   25 +
 2 files changed, 18 insertions(+), 12 deletions(-)

New commits:
commit 11d3ff1b64424d4f2c660539872f981ab3ed80c8
Author: Jim Raykowski 
AuthorDate: Wed Oct 27 21:43:10 2021 -0800
Commit: Jim Raykowski 
CommitDate: Thu Nov 11 06:59:56 2021 +0100

SwNavigator: use stored root-type setting for both Navigator types

Currently the RootType setting stored in Navigator configuration is
used only by the floating Navigator to restore the root type setting on
program start to the setting at the end of the previous session. This
patch makes the sidebar Navigator use this stored setting.

Change-Id: I654f4eb4890351196e64796e4a48031424259a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124456
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/qa/uitest/navigator/tdf114724.py 
b/sw/qa/uitest/navigator/tdf114724.py
index ebb354bf37b2..ee1f572d38ed 100644
--- a/sw/qa/uitest/navigator/tdf114724.py
+++ b/sw/qa/uitest/navigator/tdf114724.py
@@ -45,6 +45,11 @@ class tdf114724(UITestCase):
 
self.assertEqual(get_state_as_dict(xContentTree)["SelectEntryText"], "HEADING 
1")
 
self.assertEqual(get_state_as_dict(xContentTree)["SelectionCount"], "1")
 
+# tdf#124456 makes the sidebar navigator consistent with the 
floating navigator's use
+# of the stored root mode setting. This requires the root mode 
button to be clicked
+# here to change the content navigation view back to all 
categories view for subsequent
+# tests that expect the navigator tree to not be in root mode.
+xToolBar.executeAction("CLICK", mkPropertyValues({"POS": "0"})) # 
'root' button
 self.xUITest.executeCommand(".uno:Sidebar")
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sw/source/uibase/utlui/navipi.cxx 
b/sw/source/uibase/utlui/navipi.cxx
index feee92814c34..f964a86957c8 100644
--- a/sw/source/uibase/utlui/navipi.cxx
+++ b/sw/source/uibase/utlui/navipi.cxx
@@ -538,6 +538,19 @@ SwNavigationPI::SwNavigationPI(weld::Widget* pParent,
 m_xContentTree->SetFieldTracking(m_pConfig->IsFieldTracking());
 m_xContentTree->SetFootnoteTracking(m_pConfig->IsFootnoteTracking());
 
+if (const ContentTypeId nRootType = m_pConfig->GetRootType();
+nRootType != ContentTypeId::UNKNOWN)
+{
+m_xContentTree->SetRootType(nRootType);
+m_xContent5ToolBox->set_item_active("root", true);
+if (nRootType == ContentTypeId::OUTLINE || nRootType == 
ContentTypeId::DRAWOBJECT)
+m_xContentTree->set_selection_mode(SelectionMode::Multiple);
+else
+m_xContentTree->set_selection_mode(SelectionMode::Single);
+}
+else
+m_xContentTree->set_selection_mode(SelectionMode::Single);
+
 UpdateInitShow();
 
 GetCreateView();
@@ -592,7 +605,6 @@ SwNavigationPI::SwNavigationPI(weld::Widget* pParent,
 
 SetRegionDropMode(m_pConfig->GetRegionMode());
 
-m_xContentTree->set_selection_mode(SelectionMode::Single);
 m_xContentTree->ShowTree();
 m_xContent6ToolBox->set_item_active("listbox", true);
 m_xContent6ToolBox->set_item_sensitive("listbox", bFloatingNavigator);
@@ -1137,17 +1149,6 @@ SwNavigatorWin::SwNavigatorWin(SfxBindings* _pBindings, 
SfxChildWindow* _pMgr,
 
 SwNavigationConfig* pNaviConfig = SW_MOD()->GetNavigationConfig();
 
-const ContentTypeId nRootType = pNaviConfig->GetRootType();
-if( nRootType != ContentTypeId::UNKNOWN )
-{
-m_xNavi->m_xContentTree->SetRootType(nRootType);
-m_xNavi->m_xContent5ToolBox->set_item_active("root", true);
-if (nRootType == ContentTypeId::OUTLINE || nRootType == 
ContentTypeId::DRAWOBJECT)
-{
-
m_xNavi->m_xContentTree->set_selection_mode(SelectionMode::Multiple);
-}
-}
-
 SetMinOutputSizePixel(GetOptimalSize());
 if (pNaviConfig->IsSmall())
 m_xNavi->ZoomIn();


[Libreoffice-commits] core.git: sw/source

2021-11-10 Thread Jim Raykowski (via logerrit)
 sw/source/uibase/utlui/content.cxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 40fa74fc468ba18c75e8547faff41710ae6fbbef
Author: Jim Raykowski 
AuthorDate: Mon Nov 8 15:21:29 2021 -0900
Commit: Jim Raykowski 
CommitDate: Thu Nov 11 06:59:21 2021 +0100

SwNavigator: Don't include Postit fields in Fields member count

To determine if the Navigator content tree needs refreshed, content
type members arrays are filled with current document content and
compared with content in the Navigator content tree. If the member
count between the members in the content type array and the members in
the content type in the tree differs, the tree is updated and
redisplayed.

This patch fixes a bug that the Fields content members array count
includes Postit fields but Postit fields are not included in the tree
members for the Fields content type. This causes the count in the
Fields content type members array to always be different than the
number of members in the Fields content type in the tree when there are
Postit fields in the document.

Change-Id: I399619f78ee1fc91729a47d403ae403cda9f95cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124894
Tested-by: Jenkins
Reviewed-by: Jim Raykowski 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 313c123bd932..f877617e13a5 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -396,7 +396,6 @@ void SwContentType::Init(bool* pbInvalidateWindow)
 break;
 case ContentTypeId::TEXTFIELD:
 {
-m_nMemberCount = 0;
 m_sTypeToken.clear();
 m_bEdit = true;
 m_bDelete = true;
@@ -409,7 +408,8 @@ void SwContentType::Init(bool* pbInvalidateWindow)
 pFieldType->GatherFields(vFields);
 for (SwFormatField* pFormatField: vFields)
 {
-if (pFormatField->GetTextField())
+SwField* pField = pFormatField->GetField();
+if (pField && pField->GetTypeId() != 
SwFieldTypesEnum::Postit)
 m_nMemberCount++;
 }
 }
@@ -793,7 +793,9 @@ void SwContentType::FillMemberList(bool* 
pbLevelOrVisibilityChanged)
 pFieldType->GatherFields(vFields);
 for (SwFormatField* pFormatField: vFields)
 {
-if (SwTextField* pTextField = pFormatField->GetTextField())
+SwTextField* pTextField = pFormatField->GetTextField();
+SwField* pField = pFormatField->GetField();
+if (pTextField && pField && pField->GetTypeId() != 
SwFieldTypesEnum::Postit)
 {
 const SwTextNode& rTextNode = 
pTextField->GetTextNode();
 std::unique_ptr
@@ -807,8 +809,6 @@ void SwContentType::FillMemberList(bool* 
pbLevelOrVisibilityChanged)
 const SwTextField* pTextField = aSrtLst[i]->GetTextField();
 const SwFormatField& rFormatField = 
pTextField->GetFormatField();
 const SwField* pField = rFormatField.GetField();
-if (pField->GetTypeId() == SwFieldTypesEnum::Postit)
-continue;
 OUString sExpandedField(pField->ExpandField(true, 
m_pWrtShell->GetLayout()));
 if (!sExpandedField.isEmpty())
 sExpandedField = u" - " + sExpandedField;


Deadline for ESC budget voting proposals: 28th of November (2.5 weeks from now)

2021-11-10 Thread Thorsten Behrens
Hi *,

Miklos Vajna wrote:
> * Budget 2022 (Xisco)
> + https://wiki.documentfoundation.org/Development/Budget2022
> + ideas are welcome till the end of the year
> + earlier deadline? (Thorsten)
>   + take list if ideas with estimates by end Nov?
> AI: give a heads-up on the dev list about this (Thorsten)
>   + and give a heads-up when the deadline is approaching
>   + and have 2 weeks for the vote
> 
As discussed last week, lets finish the proposal period by the end of
the month. I suggest the following timeline:

* Sunday, 28th of November: end of proposal period
  (see wiki page above. valid proposals must include estimation by a
   certified developer, and reviewers available to the board)
* Thursday, 2nd of December: ESC voting starts
  (I'll prepare the usual budget voting spreadsheet. Eligible voters
   are the formal ESC members:
   
https://www.documentfoundation.org/governance/engineering-steering-committee/)
* Wednesday, 15th of December: ESC voting ends, ESC meeting on the
  16th signs-off on the list & passes on to TDF board

Cheers,

-- Thorsten


signature.asc
Description: PGP signature


[Libreoffice-commits] core.git: basic/qa i18nutil/source

2021-11-10 Thread Eike Rathke (via logerrit)
 basic/qa/vba_tests/collection.vb   |   10 ++
 i18nutil/source/utility/casefolding_data.h |   10 ++
 2 files changed, 12 insertions(+), 8 deletions(-)

New commits:
commit 07a2afa4904ac51c9c61aaf41a9d6c7d41126531
Author: Eike Rathke 
AuthorDate: Wed Nov 10 16:00:42 2021 +0100
Commit: Eike Rathke 
CommitDate: Thu Nov 11 01:27:47 2021 +0100

Resolves: tdf#110003 tdf#143128 handle lowercase ß vs uppercase ẞ folding

Change lowercase ß U+00DF LATIN SMALL LETTER SHARP S from
LowerToUpper, ToUpper: SS
ToTitle: Ss
FullFolding: ss
to
LowerToUpper, ToUpper: ẞ  U+1E9E
ToTitle: ẞ  U+1E9E
FullFolding: ss

Add uppercase ẞ U+1E9E LATIN CAPITAL LETTER SHARP S
UpperToLower, ToLower: ß  U+00DF
FullFolding: ss

Adjust BASIC Collection test to new reality.

Change-Id: I198e06985b81a71e5de94bf7fab7a0dbaf10baef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124988
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/basic/qa/vba_tests/collection.vb b/basic/qa/vba_tests/collection.vb
index 0f0c47a262d9..774f3c4c7904 100644
--- a/basic/qa/vba_tests/collection.vb
+++ b/basic/qa/vba_tests/collection.vb
@@ -56,16 +56,18 @@ Sub verify_testCollection()
 ' tdf#144245 - German Eszett is uppercased to a two-character 'SS'.
 ' This test should fail after tdf#110003 has been fixed since the 
lowercase and the uppercase
 ' German Eszett should be matched to the same index.
-TestUtil.AssertEqual(b.Count, 3, "b.Count")
+' Before the fix of tdf#110003
+'TestUtil.AssertEqual(b.Count, 3, "b.Count")
 ' After the fix of tdf#110003
-' TestUtil.AssertEqual(b.Count, 2, "b.Count")
+TestUtil.AssertEqual(b.Count, 2, "b.Count")
 
 TestUtil.AssertEqual(b.Item("SS"), 1, "b.Item(""SS"")")
 TestUtil.AssertEqual(b.Item("ss"), 1, "b.Item(""ss"")")
 TestUtil.AssertEqual(b.Item("ẞ"), 3, "b.Item(""ẞ"")")
-TestUtil.AssertEqual(b.Item("ß"), 4, "b.Item(""ß"")")
+' Before the fix of tdf#110003
+'TestUtil.AssertEqual(b.Item("ß"), 4, "b.Item(""ß"")")
 ' After the fix of tdf#110003
-' TestUtil.AssertEqual(b.Item("ß"), 3, "b.Item(""ß"")")
+TestUtil.AssertEqual(b.Item("ß"), 3, "b.Item(""ß"")")
 
 Exit Sub
 errorHandler:
diff --git a/i18nutil/source/utility/casefolding_data.h 
b/i18nutil/source/utility/casefolding_data.h
index debacdf8c40d..3ea677e83405 100644
--- a/i18nutil/source/utility/casefolding_data.h
+++ b/i18nutil/source/utility/casefolding_data.h
@@ -307,7 +307,7 @@ const Value CaseMappingValue[] = {
 {0x6a, 0x1E81}, {0x15, 0x1E80}, {0x6a, 0x1E83}, {0x15, 0x1E82}, {0x6a, 
0x1E85}, {0x15, 0x1E84}, {0x6a, 0x1E87}, {0x15, 0x1E86}, // 1e80 - 1e87
 {0x6a, 0x1E89}, {0x15, 0x1E88}, {0x6a, 0x1E8B}, {0x15, 0x1E8A}, {0x6a, 
0x1E8D}, {0x15, 0x1E8C}, {0x6a, 0x1E8F}, {0x15, 0x1E8E}, // 1e88 - 1e8f
 {0x6a, 0x1E91}, {0x15, 0x1E90}, {0x6a, 0x1E93}, {0x15, 0x1E92}, {0x6a, 
0x1E95}, {0x15, 0x1E94}, {0xd5, 0x004F}, {0xd5, 0x0051}, // 1e90 - 1e97
-{0xd5, 0x0053}, {0xd5, 0x0055}, {0xd5, 0x0057}, {0xf5, 0x0059}, {0x00, 
0x}, {0x00, 0x}, {0x00, 0x}, {0x00, 0x}, // 1e98 - 1e9f
+{0xd5, 0x0053}, {0xd5, 0x0055}, {0xd5, 0x0057}, {0xf5, 0x0059}, {0x00, 
0x}, {0x00, 0x}, {0xea, 0x015E}, {0x00, 0x}, // 1e98 - 1e9f
 {0x6a, 0x1EA1}, {0x15, 0x1EA0}, {0x6a, 0x1EA3}, {0x15, 0x1EA2}, {0x6a, 
0x1EA5}, {0x15, 0x1EA4}, {0x6a, 0x1EA7}, {0x15, 0x1EA6}, // 1ea0 - 1ea7
 {0x6a, 0x1EA9}, {0x15, 0x1EA8}, {0x6a, 0x1EAB}, {0x15, 0x1EAA}, {0x6a, 
0x1EAD}, {0x15, 0x1EAC}, {0x6a, 0x1EAF}, {0x15, 0x1EAE}, // 1ea8 - 1eaf
 {0x6a, 0x1EB1}, {0x15, 0x1EB0}, {0x6a, 0x1EB3}, {0x15, 0x1EB2}, {0x6a, 
0x1EB5}, {0x15, 0x1EB4}, {0x6a, 0x1EB7}, {0x15, 0x1EB6}, // 1eb0 - 1eb7
@@ -700,9 +700,9 @@ Mapping const CaseMappingExtra[] = {
 {0x8a, 0, {0x, 0x, 0x}}, // 0x00cc (8   0x0008)
 {0x60, 1, {0x00ED, 0x, 0x}}, // 0x00cd (9   0x0009)
 {0x8a, 0, {0x, 0x, 0x}}, // 0x00cd (10  0x000A)
-{0x05, 2, {0x0053, 0x0053, 0x}}, // 0x00df (11  0x000B)
-{0x10, 2, {0x0053, 0x0073, 0x}}, // 0x00df (12  0x000C)
-{0x40, 2, {0x0073, 0x0073, 0x}}, // 0x00df (13  0x000D)
+{0x15, 1, {0x1E9E, 0x, 0x}}, // 0x00df (11  0x000B)
+{0x40, 2, {0x0073, 0x0073, 0x}}, // 0x00df (12  0x000C)
+{0x20, 1, {0x00DF, 0x, 0x}}, // 0x00df (13  0x000D) not hit, 
CaseMappingValue.type is 0xd5=0x80+0x55 not 0xf5=0x80+0x75, but keep slot
 {0x60, 1, {0x0129, 0x, 0x}}, // 0x0128 (14  0x000E)
 {0x8a, 0, {0x, 0x, 0x}}, // 0x0128 (15  0x000F)
 {0x60, 1, {0x012F, 0x, 0x}}, // 0x012e (16  0x0010)
@@ -1039,6 +1039,8 @@ Mapping const CaseMappingExtra[] = {
 {0x05, 2, {0x0544, 0x053D, 0x}}, // 0xfb17 (347 0x015B)
 {0x10, 2, {0x0544, 0x056D, 0x}}, // 0xfb17 (348 0x015C)
 {0x40, 2, {0x0574, 0x056D, 0x}}, // 0xfb17 (349 0x015D)
+{0x2a, 1, {0x00DF, 0x, 0x}},

Contributing in your organization

2021-11-10 Thread ukdwiwedi1796
Respected Sir/madam,I am Ujjwal Kumar currently in my second year of Engineering , Computer Science. I am new to open source contributions but I would like to contribute to your organization. I have knowledge in c++, python and java which was some of your tech stack and I have done few projects related to it before as well. If you could guide me a bit on how to start contributing that would be helpful. Hoping to hear from you soon Regards Ujjwal Kumar Sent from Mail for Windows 


Re: Tests for improvement in rendering

2021-11-10 Thread Regina Henschel

Hi Tomaž,

I have put my tests to gerrit https://gerrit.libreoffice.org/c/core/+/125013

The test, where the light number is missing is testSurfaceMattePPT.

BTW, I have not yet changed your example 'testFontWorks'. I have read 
your answer too late.


Kind regards,
Regina


Tomaž Vajngerl schrieb am 10.11.2021 um 22:14:

Hi Regina,

On Tue, Nov 9, 2021 at 11:28 PM Regina Henschel > wrote:


Hi Tomaž,

your dump works in principle. I can read the xml-file and build the
assertXPath.

For example, I am able to write a test about the material properties
'specular' and 'specularIntensity' of an object. Such is needed to
verify correct values in case of material 'Metal'.

But while creating a test about material 'Matte', I have seen this
problem:
The method createNewSdrLightingAttribute() in
/core/svx/source/sdr/primitive2d/sdrattributecreator.cxx collects the
lights. But it does not record, which light it is. So in my case the
dump writes e.g.


       
       
       


I cannot see which lights they are.
The old wrong solution has used light 1, light 2 and light 3.
The new working solution uses light 2, light 3 and light 4.

I would need to test, that light 1 (which is always a spot light) is
not
used. Using light 1 had produced the error, that the appearance was not
'Matte'.

I could test, that the third color has the correct value, but that
would
only test indirectly, what the fix does. Shall I do it nevertheless?


Can you describe in the test what is missing and can't be tested and 
once you push it to gerrit I'll look how this can be solved.


Kind regards,
Regina

Regards, Tomaž




[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - svl/source svtools/source

2021-11-10 Thread Eike Rathke (via logerrit)
 svl/source/config/languageoptions.cxx |2 +-
 svtools/source/misc/langtab.cxx   |   13 +++--
 2 files changed, 8 insertions(+), 7 deletions(-)

New commits:
commit 6cc10c4492f59c6ab56c31a80712f604608d7f0d
Author: Eike Rathke 
AuthorDate: Sun Nov 7 19:00:41 2021 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 10 23:23:35 2021 +0100

Resolves: tdf#145386 Use "Default" for LANGUAGE_PROCESS_OR_USER_DEFAULT

There's no, specifically not in Writer, handling of the LCID
0x0400 LANGUAGE_PROCESS_OR_USER_DEFAULT language/locale concept
other than the number formatter mapping it to LANGUAGE_SYSTEM.

Use the LANGUAGE_SYSTEM "Default" string in UI (status bar, status
menu, language list) but keep the LCID, and don't append the
resolved locale string as it is also displayed both in the Font
Western and CJK listboxes.

This ends up as two list entries, like
* Default - English (UK)first entry
* Default   last entry
of which the second would be selected.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124449
Reviewed-by: Eike Rathke 
Tested-by: Jenkins
(cherry picked from commit 0f3c19ee61ec371aa32d9f51c3555d3ea8ae9eeb)

 Conflicts:
svtools/source/misc/langtab.cxx

Change-Id: I8d9e4171bee6bbe9d1c9dcfb7a5fa8fc92ea1a2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124204
Tested-by: Jenkins
Tested-by: Michael Meeks 
Reviewed-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124450
Reviewed-by: Eike Rathke 
Reviewed-by: Andras Timar 
Tested-by: Jenkins CollaboraOffice 

diff --git a/svl/source/config/languageoptions.cxx 
b/svl/source/config/languageoptions.cxx
index f00812b30b8d..3b490c6ac1fe 100644
--- a/svl/source/config/languageoptions.cxx
+++ b/svl/source/config/languageoptions.cxx
@@ -142,7 +142,7 @@ SvtScriptType SvtLanguageOptions::GetScriptTypeOfLanguage( 
LanguageType nLang )
 {
 if( LANGUAGE_DONTKNOW == nLang )
 nLang = LANGUAGE_ENGLISH_US;
-else if( LANGUAGE_SYSTEM == nLang  )
+else if (LANGUAGE_SYSTEM == nLang || LANGUAGE_PROCESS_OR_USER_DEFAULT == 
nLang)
 nLang = SvtSysLocale().GetLanguageTag().getLanguageType();
 
 sal_Int16 nScriptType = MsLangId::getScriptType( nLang );
diff --git a/svtools/source/misc/langtab.cxx b/svtools/source/misc/langtab.cxx
index c5df133b1daf..efd993805ca1 100644
--- a/svtools/source/misc/langtab.cxx
+++ b/svtools/source/misc/langtab.cxx
@@ -209,23 +209,24 @@ bool SvtLanguageTable::HasLanguageType( const 
LanguageType eType )
 
 OUString SvtLanguageTableImpl::GetString( const LanguageType eType ) const
 {
-LanguageType eLang = MsLangId::getReplacementForObsoleteLanguage( eType );
-sal_uInt32 nPos = FindIndex(eLang);
+const LanguageType nLang = MsLangId::getReplacementForObsoleteLanguage( 
eType);
+const sal_uInt32 nPos = (eType == LANGUAGE_PROCESS_OR_USER_DEFAULT ?
+FindIndex(LANGUAGE_SYSTEM) : FindIndex( nLang));
 
 if ( RESARRAY_INDEX_NOTFOUND != nPos && nPos < GetEntryCount() )
 return m_aStrings[nPos].first;
 
 //Rather than return a fairly useless "Unknown" name, return a geeky but 
usable-in-a-pinch lang-tag
-OUString sLangTag( lcl_getDescription( 
LanguageTag::convertToBcp47(eType)));
+OUString sLangTag( lcl_getDescription( 
LanguageTag::convertToBcp47(nLang)));
 SAL_WARN("svtools.misc", "Language: 0x"
-<< std::hex << eType
+<< std::hex << nLang
 << " with unknown name, so returning lang-tag of: "
 << sLangTag);
 
 // And add it to the table if it is an on-the-fly-id, which it usually is,
 // so it is available in all subsequent language boxes.
-if (LanguageTag::isOnTheFlyID( eType))
-const_cast(this)->AddItem( sLangTag, eType);
+if (LanguageTag::isOnTheFlyID( nLang))
+const_cast(this)->AddItem( sLangTag, nLang);
 
 return sLangTag;
 }


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - config_host.mk.in configure.ac solenv/gbuild

2021-11-10 Thread Stephan Bergmann (via logerrit)
 config_host.mk.in  |1 
 configure.ac   |   49 +
 solenv/gbuild/platform/com_GCC_defs.mk |7 ++--
 3 files changed, 54 insertions(+), 3 deletions(-)

New commits:
commit dc2a8c509507dffa28e4c356418207e9b9bb0ca5
Author: Stephan Bergmann 
AuthorDate: Wed Feb 17 08:21:50 2021 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 10 22:17:03 2021 +0100

More targeted suppression of bogus GCC -Werror=stringop-overflow=

...given that 
"[8/9/10/11 Regression] -Wstringop-overflow false positive due to using 
MEM_REF
type of &MEM" is declared fixed now on GCC 11 trunk.

(Moving -Wno-stringop-overflow from gb_CFLAGS_WERROR to gb_CXXFLAGS_COMMON 
is
done for no other reason than to harmonize this with the code for the 
similar
HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED.)

Change-Id: I3468138c9bbda28f754d4162cb9c059796bd3932
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111029
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/config_host.mk.in b/config_host.mk.in
index d6edba704b21..f0bf804474f7 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -261,6 +261,7 @@ export GTK3_LIBS=$(gb_SPACE)@GTK3_LIBS@
 export USING_X11=@USING_X11@
 export HAMCREST_JAR=@HAMCREST_JAR@
 export 
HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED=@HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED@
+export HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW=@HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW@
 export 
HAVE_CLANG_DEBUG_INFO_KIND_CONSTRUCTOR=@HAVE_CLANG_DEBUG_INFO_KIND_CONSTRUCTOR@
 export HAVE_LO_CLANG_DLLEXPORTINLINES=@HAVE_LO_CLANG_DLLEXPORTINLINES@
 export HAVE_GCC_AVX=@HAVE_GCC_AVX@
diff --git a/configure.ac b/configure.ac
index 38953def3252..d96bc28576be 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7379,6 +7379,55 @@ if test "$GCC" = yes && test "$COM_IS_CLANG" != TRUE; 
then
 fi
 AC_SUBST([HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED])
 
+dnl Check for  
"[8/9/10/11 Regression]
+dnl -Wstringop-overflow false positive due to using MEM_REF type of &MEM" 
(fixed in GCC 11), which
+dnl hits us e.g. with GCC 10 and --enable-optimized at
+dnl
+dnl   In file included from include/rtl/string.hxx:49,
+dnlfrom include/rtl/ustring.hxx:43,
+dnlfrom include/osl/file.hxx:35,
+dnlfrom include/codemaker/global.hxx:28,
+dnlfrom include/codemaker/options.hxx:23,
+dnlfrom codemaker/source/commoncpp/commoncpp.cxx:24:
+dnl   In function ‘char* rtl::addDataHelper(char*, const char*, std::size_t)’,
+dnl   inlined from ‘static char* rtl::ToStringHelper::addData(char*, const char*) [with long unsigned int N = 3]’ at 
include/rtl/stringconcat.hxx:147:85,
+dnl   inlined from ‘char* rtl::OStringConcat::addData(char*) const 
[with T1 = const char [3]; T2 = rtl::OString]’ at 
include/rtl/stringconcat.hxx:226:103,
+dnl   inlined from ‘rtl::OStringBuffer& 
rtl::OStringBuffer::append(rtl::OStringConcat&&) [with T1 = const char 
[3]; T2 = rtl::OString]’ at include/rtl/strbuf.hxx:599:30,
+dnl   inlined from ‘rtl::OString codemaker::cpp::scopedCppName(const 
rtl::OString&, bool)’ at codemaker/source/commoncpp/commoncpp.cxx:53:55:
+dnl   include/rtl/stringconcat.hxx:78:15: error: writing 2 bytes into a region 
of size 1 [-Werror=stringop-overflow=]
+dnl  78 | memcpy( buffer, data, length );
+dnl | ~~^~~~
+HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW=
+if test "$GCC" = yes && test "$COM_IS_CLANG" != TRUE; then
+AC_MSG_CHECKING([whether $CXX_BASE might report false 
-Werror=stringop-overflow=])
+AC_LANG_PUSH([C++])
+save_CXXFLAGS=$CXXFLAGS
+CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11 -Werror -Wstringop-overflow"
+if test "$ENABLE_OPTIMIZED" = TRUE; then
+CXXFLAGS="$CXXFLAGS -O2"
+else
+CXXFLAGS="$CXXFLAGS -O0"
+fi
+dnl Test code taken from 
:
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([[
+void fill(char const * begin, char const * end, char c);
+struct q {
+char ids[4];
+char username[6];
+};
+void test(q & c) {
+fill(c.ids, c.ids + sizeof(c.ids), '\0');
+__builtin_strncpy(c.username, "root", sizeof(c.username));
+}
+]])], [AC_MSG_RESULT([no])], [
+HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW=TRUE
+AC_MSG_RESULT([yes])
+])
+CXXFLAGS=$save_CXXFLAGS
+AC_LANG_POP([C++])
+fi
+AC_SUBST([HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW])
+
 dnl ===
 dnl CPU Intrinsics support - SSE, AVX
 dnl ===
diff --git a/solenv/gbuild/platform/com_GCC_def

Re: Tests for improvement in rendering

2021-11-10 Thread Tomaž Vajngerl
Hi Regina,

On Tue, Nov 9, 2021 at 11:28 PM Regina Henschel 
wrote:

> Hi Tomaž,
>
> your dump works in principle. I can read the xml-file and build the
> assertXPath.
>
> For example, I am able to write a test about the material properties
> 'specular' and 'specularIntensity' of an object. Such is needed to
> verify correct values in case of material 'Metal'.
>
> But while creating a test about material 'Matte', I have seen this problem:
> The method createNewSdrLightingAttribute() in
> /core/svx/source/sdr/primitive2d/sdrattributecreator.cxx collects the
> lights. But it does not record, which light it is. So in my case the
> dump writes e.g.
>
> 
>specular="1"/>
>specular="0"/>
>specular="0"/>
> 
>
> I cannot see which lights they are.
> The old wrong solution has used light 1, light 2 and light 3.
> The new working solution uses light 2, light 3 and light 4.
>
> I would need to test, that light 1 (which is always a spot light) is not
> used. Using light 1 had produced the error, that the appearance was not
> 'Matte'.
>
> I could test, that the third color has the correct value, but that would
> only test indirectly, what the fix does. Shall I do it nevertheless?
>

Can you describe in the test what is missing and can't be tested and once
you push it to gerrit I'll look how this can be solved.

Kind regards,
> Regina
>
> Regards, Tomaž


[Libreoffice-commits] core.git: dbaccess/source

2021-11-10 Thread Julien Nabet (via logerrit)
 dbaccess/source/core/api/SingleSelectQueryComposer.cxx |   24 +++-
 dbaccess/source/core/api/TableDeco.cxx |8 ++
 dbaccess/source/core/api/querycontainer.cxx|7 ++
 dbaccess/source/core/api/table.cxx |8 ++
 dbaccess/source/core/api/tablecontainer.cxx|8 ++
 dbaccess/source/core/api/viewcontainer.cxx |8 ++
 dbaccess/source/core/dataaccess/ContentHelper.cxx  |8 ++
 dbaccess/source/core/dataaccess/commanddefinition.cxx  |   17 +
 dbaccess/source/core/dataaccess/datasource.cxx |4 -
 dbaccess/source/core/dataaccess/documentcontainer.cxx  |   17 +
 dbaccess/source/core/inc/SingleSelectQueryComposer.hxx |5 +
 dbaccess/source/inc/apitools.hxx   |   50 -
 dbaccess/source/ui/uno/ColumnModel.cxx |   17 +
 dbaccess/source/ui/uno/ColumnModel.hxx |5 +
 dbaccess/source/ui/uno/composerdialogs.cxx |   16 +
 dbaccess/source/ui/uno/composerdialogs.hxx |4 +
 dbaccess/source/ui/uno/textconnectionsettings_uno.cxx  |5 +
 dbaccess/source/ui/uno/unoDirectSql.cxx|   17 +
 dbaccess/source/ui/uno/unoDirectSql.hxx|4 +
 19 files changed, 162 insertions(+), 70 deletions(-)

New commits:
commit f47a91cc6f1678604c5694ca3987c2f848193b09
Author: Julien Nabet 
AuthorDate: Wed Nov 10 20:07:52 2021 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 10 22:02:52 2021 +0100

Replace some macros in dbaccess part 3

Remove IMPLEMENT_SERVICE_INFO1 + IMPLEMENT_SERVICE_INFO2
+ DECLARE_PROPERTYCONTAINER_DEFAULTS + DECLARE_PROPERTYCONTAINER_DEFAULTS
+ IMPLEMENT_PROPERTYCONTAINER_DEFAULTS2
+ DECL_PROP3 (unused)
+ DECL_PROP2_IFACE

Change-Id: Idf18179218b9b1f2da8e4354d8e4909edc925143
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125011
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx 
b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
index 94ddd8600a8a..04f233f893b4 100644
--- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
+++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
@@ -278,7 +278,12 @@ void SAL_CALL OSingleSelectQueryComposer::disposing()
 }
 
 
IMPLEMENT_FORWARD_XINTERFACE3(OSingleSelectQueryComposer,OSubComponent,OSingleSelectQueryComposer_BASE,OPropertyContainer)
-IMPLEMENT_SERVICE_INFO1(OSingleSelectQueryComposer,"org.openoffice.comp.dba.OSingleSelectQueryComposer",SERVICE_NAME_SINGLESELECTQUERYCOMPOSER)
+IMPLEMENT_SERVICE_INFO_IMPLNAME(OSingleSelectQueryComposer, 
"org.openoffice.comp.dba.OSingleSelectQueryComposer")
+IMPLEMENT_SERVICE_INFO_SUPPORTS(OSingleSelectQueryComposer)
+css::uno::Sequence< OUString > SAL_CALL 
OSingleSelectQueryComposer::getSupportedServiceNames()
+{
+return { SERVICE_NAME_SINGLESELECTQUERYCOMPOSER };
+}
 
 css::uno::Sequence OSingleSelectQueryComposer::getImplementationId()
 {
@@ -294,7 +299,22 @@ css::uno::Sequence< css::uno::Type > 
OSingleSelectQueryComposer::getTypes()
 );
 }
 
-IMPLEMENT_PROPERTYCONTAINER_DEFAULTS(OSingleSelectQueryComposer)
+css::uno::Reference< css::beans::XPropertySetInfo >  SAL_CALL 
OSingleSelectQueryComposer::getPropertySetInfo()
+{
+Reference< XPropertySetInfo > xInfo( createPropertySetInfo( 
getInfoHelper() ) );
+return xInfo;
+}
+::cppu::IPropertyArrayHelper& OSingleSelectQueryComposer::getInfoHelper()
+{
+return *OSingleSelectQueryComposer::getArrayHelper();
+}
+::cppu::IPropertyArrayHelper* OSingleSelectQueryComposer::createArrayHelper( ) 
const
+{
+css::uno::Sequence< css::beans::Property > aProps;
+describeProperties(aProps);
+return new ::cppu::OPropertyArrayHelper(aProps);
+}
+
 
 // XSingleSelectQueryAnalyzer
 OUString SAL_CALL OSingleSelectQueryComposer::getQuery(  )
diff --git a/dbaccess/source/core/api/TableDeco.cxx 
b/dbaccess/source/core/api/TableDeco.cxx
index 1448c657abd4..df93f0ad4cc0 100644
--- a/dbaccess/source/core/api/TableDeco.cxx
+++ b/dbaccess/source/core/api/TableDeco.cxx
@@ -350,7 +350,13 @@ void ODBTableDecorator::construct()
 }
 
 // XServiceInfo
-IMPLEMENT_SERVICE_INFO1(ODBTableDecorator, 
"com.sun.star.sdb.dbaccess.ODBTableDecorator", SERVICE_SDBCX_TABLE)
+IMPLEMENT_SERVICE_INFO_IMPLNAME(ODBTableDecorator, 
"com.sun.star.sdb.dbaccess.ODBTableDecorator")
+IMPLEMENT_SERVICE_INFO_SUPPORTS(ODBTableDecorator)
+css::uno::Sequence< OUString > SAL_CALL 
ODBTableDecorator::getSupportedServiceNames()
+{
+return { SERVICE_SDBCX_TABLE };
+}
+
 
 Any SAL_CALL ODBTableDecorator::queryInterface( const Type & rType )
 {
diff --git a/dbaccess/source/core/api/querycontainer.cxx 
b/dbaccess/source/core/api/querycontainer.cxx
index cebb70cf1cb2..96c01cf120c8 100644
--- a/dbaccess/source/core/api/querycontainer.cxx
+++ b/dbaccess/source/core/api/querycontainer.cxx
@@ -131,7 +131,12 @@ void OQueryContainer::disposing()
 }

[Libreoffice-commits] dev-tools.git: help3/xhpeditor

2021-11-10 Thread Olivier Hallot (via logerrit)
 help3/xhpeditor/index.php |1 +
 help3/xhpeditor/menu.php  |8 +++-
 help3/xhpeditor/snippets.js   |   16 +++-
 help3/xhpeditor/xhpeditor.css |4 
 4 files changed, 19 insertions(+), 10 deletions(-)

New commits:
commit 5bc05ecf10babbe3216443206078be482d2f5246
Author: Olivier Hallot 
AuthorDate: Wed Nov 10 17:48:33 2021 -0300
Commit: Olivier Hallot 
CommitDate: Wed Nov 10 21:53:29 2021 +0100

Add images and objects to xhpeditor menu

Change-Id: I78c81c378e26a862446befa6f6a1f46ad13bf08d
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/125012
Tested-by: Olivier Hallot 
Reviewed-by: Olivier Hallot 

diff --git a/help3/xhpeditor/index.php b/help3/xhpeditor/index.php
index 2e08fac..05457a5 100644
--- a/help3/xhpeditor/index.php
+++ b/help3/xhpeditor/index.php
@@ -14,6 +14,7 @@ $xhp = $_POST["xhpdoc"];
 
 
 
+
 LibreOffice XHP Editor
 
 
diff --git a/help3/xhpeditor/menu.php b/help3/xhpeditor/menu.php
index d14f8af..f915384 100644
--- a/help3/xhpeditor/menu.php
+++ b/help3/xhpeditor/menu.php
@@ -58,7 +58,6 @@
 
 bascode-par
 pycode-par
-image-par
 
   
   
@@ -109,6 +108,13 @@
   
 
   
+  
+Images
+
+  
+  
+
+  
   
 Tools
 
diff --git a/help3/xhpeditor/snippets.js b/help3/xhpeditor/snippets.js
index 82b3b4f..fa17cd0 100644
--- a/help3/xhpeditor/snippets.js
+++ b/help3/xhpeditor/snippets.js
@@ -67,11 +67,6 @@ function pycode_par() {
 editor.replaceSelection(a1 + editor.doc.getSelection() + a2,'');
 }
 
-function image_par() {
-var a1 = '';
-var a2 = '';
-editor.replaceSelection(a1 + editor.doc.getSelection() + a2,'');
-}
 // Tables
 // simple table cell
 function tCell (role,text){
@@ -229,6 +224,17 @@ function tEmbedvar(){
  editor.replaceSelection(a1 + editor.doc.getSelection() + a2,'');
 }
 
+// Images Objects
+function image_par() {
+var a1 = '';
+var a2 = '';
+editor.replaceSelection(a1 + editor.doc.getSelection() + a2,'');
+}
+function object_par() {
+var a1 = '';
+editor.replaceRange(a1, editor.doc.getCursor());
+}
+
 /* javascript code for snippets (originally for KDE kate)*/
 function fileName() { return document.fileName(); }
 function fileUrl() { return document.url(); }
diff --git a/help3/xhpeditor/xhpeditor.css b/help3/xhpeditor/xhpeditor.css
index 8fb2911..e792373 100644
--- a/help3/xhpeditor/xhpeditor.css
+++ b/help3/xhpeditor/xhpeditor.css
@@ -9,10 +9,6 @@
 
 /* css for the main editor  web page */
 
-
-
-
-
 .form_area{
 border:1px solid grey;
 height: auto;



[Libreoffice-commits] core.git: drawinglayer/source

 drawinglayer/source/tools/primitive2dxmldump.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 5ae675d3da0ec92ca3929c6078d8fd5c7d3167f1
Author: Andrea Gelmini 
AuthorDate: Wed Nov 10 05:31:19 2021 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 10 20:51:39 2021 +0100

Removed useless semicolons

Change-Id: I787150a7374ac116b3540788cbfa504ee0269a6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124942
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/drawinglayer/source/tools/primitive2dxmldump.cxx 
b/drawinglayer/source/tools/primitive2dxmldump.cxx
index b679465a69c2..2e2bb887a3d4 100644
--- a/drawinglayer/source/tools/primitive2dxmldump.cxx
+++ b/drawinglayer/source/tools/primitive2dxmldump.cxx
@@ -267,7 +267,7 @@ void writeSdrFillAttribute(::tools::XmlWriter& rWriter,
 case drawinglayer::attribute::GradientStyle::Rect:
 rWriter.attribute("style", "Rect");
 break;
-};
+}
 rWriter.attribute("border", rGradient.getBorder());
 rWriter.attribute("offsetX", rGradient.getOffsetX());
 rWriter.attribute("offsetY", rGradient.getOffsetY());
@@ -293,7 +293,7 @@ void writeSdrFillAttribute(::tools::XmlWriter& rWriter,
 case drawinglayer::attribute::HatchStyle::Triple:
 rWriter.attribute("style", "Triple");
 break;
-};
+}
 rWriter.attribute("distance", rHatch.getDistance());
 rWriter.attribute("angle", rHatch.getAngle());
 rWriter.attribute("color", convertColorToString(rHatch.getColor()));


[Libreoffice-commits] core.git: framework/inc

 framework/inc/helper/ocomponentenumeration.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c57865d249a7d9760f4147e3a2379c9ca5a82a96
Author: Andrea Gelmini 
AuthorDate: Wed Nov 10 05:41:43 2021 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 10 20:49:45 2021 +0100

Fix typos

Change-Id: I697591f867fee5332913ee534b9f0ba754239e58
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124943
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/framework/inc/helper/ocomponentenumeration.hxx 
b/framework/inc/helper/ocomponentenumeration.hxx
index af48cdfe042f..5791b38779e3 100644
--- a/framework/inc/helper/ocomponentenumeration.hxx
+++ b/framework/inc/helper/ocomponentenumeration.hxx
@@ -126,7 +126,7 @@ class OComponentEnumeration final : public 
::cppu::WeakImplHelper< css::containe
 @descr  There are two ways to delete an instance of this 
class.
 1) delete with destructor
 2) dispose from parent or factory or...
-This method do the same for both ways! It frees used 
memory and release references...
+This method does the same for both ways! It frees used 
memory and releases references...
 
 @seealsomethod dispose()
 @seealsodestructor ~TaskEnumeration()


[Libreoffice-commits] core.git: sw/source

 sw/source/core/undo/docundo.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0ab209bf29e2e6a250a2f65cf9ffe7e07e58eeaa
Author: Andrea Gelmini 
AuthorDate: Wed Nov 10 19:15:13 2021 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 10 20:48:40 2021 +0100

Fix typo

Change-Id: I907bf195997df7aab8679193512bc76d6be46cfc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125009
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sw/source/core/undo/docundo.cxx b/sw/source/core/undo/docundo.cxx
index 20c6c6c46c95..0a2b145362f4 100644
--- a/sw/source/core/undo/docundo.cxx
+++ b/sw/source/core/undo/docundo.cxx
@@ -362,7 +362,7 @@ bool UndoManager::IsViewUndoActionIndependent(const SwView* 
pView) const
 {
 if (GetUndoActionCount() <= 1 || SdrUndoManager::GetRedoActionCount() > 0)
 {
-// Single or less undo, owned by an other view; or redo actions that 
might depend on the
+// Single or less undo, owned by another view; or redo actions that 
might depend on the
 // current undo order.
 return false;
 }


[Libreoffice-commits] core.git: sw/source

 sw/source/core/docnode/nodes.cxx |6 +-
 1 file changed, 1 insertion(+), 5 deletions(-)

New commits:
commit c45ec648dc4cbb28643b4d80ad3361eea7234d6c
Author: Caolán McNamara 
AuthorDate: Wed Nov 10 17:23:01 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 10 20:40:42 2021 +0100

just call erase directly rather than look up index and delete via index

Change-Id: I93f7f43098544ba23a31a985e5b3c07286d8bc1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125008
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx
index 08e6de501918..5942ddb65569 100644
--- a/sw/source/core/docnode/nodes.cxx
+++ b/sw/source/core/docnode/nodes.cxx
@@ -1365,12 +1365,8 @@ void SwNodes::DelNodes( const SwNodeIndex & rStart, 
SwNodeOffset nCnt )
 if (pNd->IsTextNode() && pNd->GetTextNode()->IsOutline())
 {
 // remove the outline indices
-SwOutlineNodes::size_type nIdxPos;
-if( m_pOutlineNodes->Seek_Entry( pNd, &nIdxPos ))
-{
-m_pOutlineNodes->erase_at(nIdxPos);
+if (m_pOutlineNodes->erase(pNd))
 bUpdateNum = 1;
-}
 }
 if( pNd->IsContentNode() )
 {


[Libreoffice-commits] core.git: sc/qa

 dev/null  |binary
 sc/qa/uitest/textCase/textCase.py |   14 
 sc/qa/unit/uicalc/uicalc.cxx  |   65 +++---
 3 files changed, 54 insertions(+), 25 deletions(-)

New commits:
commit b9a04e8a2352d2e6290299fb6416f0bdc0c90756
Author: Xisco Fauli 
AuthorDate: Wed Nov 10 17:11:43 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 10 20:39:55 2021 +0100

tdf#119162: sc: move UItest to CppUnittest

Change-Id: I2e5467e92a4ebbaf2d028dd733d2f4a75eb03bb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125003
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/data/tdf119162.xls b/sc/qa/uitest/data/tdf119162.xls
deleted file mode 100644
index 42765fbe9000..
Binary files a/sc/qa/uitest/data/tdf119162.xls and /dev/null differ
diff --git a/sc/qa/uitest/textCase/textCase.py 
b/sc/qa/uitest/textCase/textCase.py
index 7dbb6d2a41d5..b2235a5f7ce0 100644
--- a/sc/qa/uitest/textCase/textCase.py
+++ b/sc/qa/uitest/textCase/textCase.py
@@ -123,18 +123,4 @@ class textCase(UITestCase):
 self.assertEqual(get_cell_by_position(document, 0, 0, 
4).getString(), "")
 self.assertEqual(get_cell_by_position(document, 0, 0, 
3).getString(), "Free suite")
 
-def test_tdf119162_Cycle_Case(self):
-#Bug 119162 - Format > Text > Cycle Case on attached example file 
hangs Calc reproducibly
-with self.ui_test.load_file(get_url_for_data_file("tdf119162.xls")) as 
calc_doc:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-#1.Open the attached .xls file
-#2. Select column A
-gridwin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
-#3. Select [Format] > [Text] > [Cycle Case]
-self.xUITest.executeCommand(".uno:ChangeCaseRotateCase")
-self.xUITest.executeCommand(".uno:ChangeCaseToLower")
-#Actual Results:Freezes LibreOffice
-self.assertEqual(get_cell_by_position(calc_doc, 0, 0, 
0).getString(), "test\n")
-
 # vim: set shiftwidth=4 softtabstop=4 expandtab:
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index ef3b8dd24959..ea44aaa3cd40 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -49,7 +49,8 @@ public:
   const OUString& rFilter);
 void goToCell(const OUString& rCell);
 void insertStringToCell(ScModelObj& rModelObj, const OUString& rCell, 
const std::string& rStr,
-bool bIsArray = false);
+bool bUseReturn = true);
+void insertArrayToCell(ScModelObj& rModelObj, const OUString& rCell, const 
std::string& rStr);
 void insertNewSheet(ScDocument& rDoc);
 
 protected:
@@ -98,7 +99,7 @@ void ScUiCalcTest::goToCell(const OUString& rCell)
 }
 
 void ScUiCalcTest::insertStringToCell(ScModelObj& rModelObj, const OUString& 
rCell,
-  const std::string& rStr, bool bIsArray)
+  const std::string& rStr, bool bUseReturn)
 {
 goToCell(rCell);
 
@@ -109,13 +110,7 @@ void ScUiCalcTest::insertStringToCell(ScModelObj& 
rModelObj, const OUString& rCe
 Scheduler::ProcessEventsToIdle();
 }
 
-if (bIsArray)
-{
-rModelObj.postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_MOD1 | KEY_SHIFT 
| awt::Key::RETURN);
-rModelObj.postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_MOD1 | KEY_SHIFT | 
awt::Key::RETURN);
-Scheduler::ProcessEventsToIdle();
-}
-else
+if (bUseReturn)
 {
 rModelObj.postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::RETURN);
 rModelObj.postKeyEvent(LOK_KEYEVENT_KEYUP, 0, awt::Key::RETURN);
@@ -123,6 +118,16 @@ void ScUiCalcTest::insertStringToCell(ScModelObj& 
rModelObj, const OUString& rCe
 }
 }
 
+void ScUiCalcTest::insertArrayToCell(ScModelObj& rModelObj, const OUString& 
rCell,
+ const std::string& rStr)
+{
+insertStringToCell(rModelObj, rCell, rStr, false);
+
+rModelObj.postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_MOD1 | KEY_SHIFT | 
awt::Key::RETURN);
+rModelObj.postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_MOD1 | KEY_SHIFT | 
awt::Key::RETURN);
+Scheduler::ProcessEventsToIdle();
+}
+
 void ScUiCalcTest::insertNewSheet(ScDocument& rDoc)
 {
 sal_Int32 nTabs = static_cast(rDoc.GetTableCount());
@@ -166,6 +171,44 @@ ScModelObj* 
ScUiCalcTest::saveAndReload(css::uno::Reference(mxComponent.get());
+CPPUNIT_ASSERT(pModelObj);
+ScDocument* pDoc = pModelObj->GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+insertStringToCell(*pModelObj, "A1", "Test", /*bUseReturn*/ false);
+
+// Insert Newline
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_MOD1 | 
awt::Key::RETURN);
+pModelObj->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_MOD1 | 
awt::Key::RETURN);
+Scheduler

[Libreoffice-commits] core.git: sc/qa

 sc/qa/uitest/textCase/textCase.py |   14 --
 sc/qa/unit/uicalc/uicalc.cxx  |   18 ++
 2 files changed, 18 insertions(+), 14 deletions(-)

New commits:
commit 7930ad202edb8e7af2946fc428268b000edae23e
Author: Xisco Fauli 
AuthorDate: Wed Nov 10 16:32:32 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 10 20:39:03 2021 +0100

tdf#119155: sc: move UItest to CppUnittest

Change-Id: Id6d162d4348caf512e78eb957034e79f0c2dbc6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125002
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/qa/uitest/textCase/textCase.py 
b/sc/qa/uitest/textCase/textCase.py
index fd208e67f607..7dbb6d2a41d5 100644
--- a/sc/qa/uitest/textCase/textCase.py
+++ b/sc/qa/uitest/textCase/textCase.py
@@ -123,20 +123,6 @@ class textCase(UITestCase):
 self.assertEqual(get_cell_by_position(document, 0, 0, 
4).getString(), "")
 self.assertEqual(get_cell_by_position(document, 0, 0, 
3).getString(), "Free suite")
 
-def test_tdf119155_Capitalize_Every_Word(self):
-#Bug 119155 - Freeze after command format->text->Capitalize Every Word
-with self.ui_test.load_file(get_url_for_data_file("tdf119155.xlsx")) 
as calc_doc:
-xCalcDoc = self.xUITest.getTopFocusWindow()
-gridwin = xCalcDoc.getChild("grid_window")
-#1. Open attached file
-#2. Select cells from C2 to C14
-gridwin.executeAction("SELECT", mkPropertyValues({"RANGE": 
"C2:C14"}))
-#3. Go to menu: Format->Text->Capitalize Every Word
-self.xUITest.executeCommand(".uno:ChangeCaseToTitleCase")
-#Actual Results:Freezes LibreOffice
-self.assertEqual(get_cell_by_position(calc_doc, 0, 2, 
1).getString(), "Collagene Expert Targeted Wrinkle Corrector Unboxed 10 Ml")
-self.assertEqual(get_cell_by_position(calc_doc, 0, 2, 
13).getString(), "Vitamina Suractivee Hand Cream 400 Ml")
-
 def test_tdf119162_Cycle_Case(self):
 #Bug 119162 - Format > Text > Cycle Case on attached example file 
hangs Calc reproducibly
 with self.ui_test.load_file(get_url_for_data_file("tdf119162.xls")) as 
calc_doc:
diff --git a/sc/qa/uitest/data/tdf119155.xlsx 
b/sc/qa/unit/uicalc/data/tdf119155.xlsx
similarity index 100%
rename from sc/qa/uitest/data/tdf119155.xlsx
rename to sc/qa/unit/uicalc/data/tdf119155.xlsx
diff --git a/sc/qa/unit/uicalc/uicalc.cxx b/sc/qa/unit/uicalc/uicalc.cxx
index fbcfb2f59511..ef3b8dd24959 100644
--- a/sc/qa/unit/uicalc/uicalc.cxx
+++ b/sc/qa/unit/uicalc/uicalc.cxx
@@ -166,6 +166,24 @@ ScModelObj* 
ScUiCalcTest::saveAndReload(css::uno::ReferenceGetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+goToCell("C2:C14");
+
+// Without the fix in place, this test would have hung here
+dispatchCommand(mxComponent, ".uno:ChangeCaseToTitleCase", {});
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(OUString("Collagene Expert Targeted Wrinkle Corrector 
Unboxed 10 Ml"),
+ pDoc->GetString(ScAddress(2, 1, 0)));
+CPPUNIT_ASSERT_EQUAL(OUString("Vitamina Suractivee Hand Cream 400 Ml"),
+ pDoc->GetString(ScAddress(2, 13, 0)));
+}
+
 CPPUNIT_TEST_FIXTURE(ScUiCalcTest, testTdf138432)
 {
 ScModelObj* pModelObj = createDoc("tdf138432.ods");


[Libreoffice-commits] core.git: sw/qa

 sw/qa/uitest/writer_tests7/forms.py |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 4185c33788926efe5514cca3ce64a3a8a5d89eac
Author: Xisco Fauli 
AuthorDate: Wed Nov 10 18:23:09 2021 +0100
Commit: Xisco Fauli 
CommitDate: Wed Nov 10 20:38:22 2021 +0100

uitest: blind fix for UITest_writer_tests7 failed

Change-Id: Ib49d1ccaa6ca8c42c0ef9caa6ad9acaf41babc3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125007
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests7/forms.py 
b/sw/qa/uitest/writer_tests7/forms.py
index 0d5c26703ae4..f8a9ee9db124 100644
--- a/sw/qa/uitest/writer_tests7/forms.py
+++ b/sw/qa/uitest/writer_tests7/forms.py
@@ -158,6 +158,9 @@ class Forms(UITestCase):
 xDialog = self.xUITest.getTopFocusWindow()
 
xDialog.getChild('numericfield-PositionY').executeAction("FOCUS", tuple())
 
+xToolkit = 
self.xContext.ServiceManager.createInstance('com.sun.star.awt.Toolkit')
+xToolkit.processEventsToIdle()
+
 # Without the fix in place, the size of the form wouldn't have 
changed
 self.assertEqual(20001, shape.getSize().Width)
 self.assertEqual(5001, shape.getSize().Height)


[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 25bc00b4d34edec90217a63904969f3d1943084d
Author: Alain Romedenne 
AuthorDate: Wed Nov 10 21:22:22 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 10 20:22:22 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to b902fbcc87b0baf76b3dd501f0feff40bb1f3711
  - tdf#141474 Atn, Cos, Sin, Tan function signatures

xxx(number As Double) As Double

Change-Id: Ibf1020ba6027d0f30b3c0a5609c407bbef6660d2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124967
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 858f7cac7f8f..b902fbcc87b0 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 858f7cac7f8fc3ec21c2273c21f7a4b34c608d62
+Subproject commit b902fbcc87b0baf76b3dd501f0feff40bb1f3711


[Libreoffice-commits] help.git: source/text

 source/text/sbasic/shared/03080101.xhp |   22 +
 source/text/sbasic/shared/03080102.xhp |   29 
 source/text/sbasic/shared/03080103.xhp |   34 +++--
 source/text/sbasic/shared/03080104.xhp |   32 ++-
 4 files changed, 70 insertions(+), 47 deletions(-)

New commits:
commit b902fbcc87b0baf76b3dd501f0feff40bb1f3711
Author: Alain Romedenne 
AuthorDate: Wed Nov 10 16:13:38 2021 +0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 10 20:22:21 2021 +0100

tdf#141474 Atn, Cos, Sin, Tan function signatures

xxx(number As Double) As Double

Change-Id: Ibf1020ba6027d0f30b3c0a5609c407bbef6660d2
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124967
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/sbasic/shared/03080101.xhp 
b/source/text/sbasic/shared/03080101.xhp
index af0a6db97..8a480a5e1 100644
--- a/source/text/sbasic/shared/03080101.xhp
+++ b/source/text/sbasic/shared/03080101.xhp
@@ -30,25 +30,25 @@
 
 Atn function
 
-Atn Function
-Trigonometric function that returns the arctangent of a 
numeric expression. The return value is in the range -Pi/2 to +Pi/2.
+Atn 
Function
+Trigonometric function 
that returns the arctangent of a numeric expression. The return value is in the 
range -Pi/2 to +Pi/2.
 
-The 
arctangent is the inverse of the tangent function. The Atn Function returns the 
angle "Alpha", expressed in radians, using the tangent of this angle. The 
function can also return the angle "Alpha" by comparing the ratio of the length 
of the side that is opposite of the angle to the length of the side that is 
adjacent to the angle in a right-angled triangle.
-Atn(side 
opposite the angle/side adjacent to angle)= Alpha
+The 
arctangent is the inverse of the tangent function. The Atn 
Function returns the angle "Alpha", expressed in radians, using the tangent of 
this angle. The function can also return the angle "Alpha" by comparing the 
ratio of the length of the side that is opposite of the angle to the length of 
the side that is adjacent to the angle in a right-angled triangle.
+Atn(side opposite the angle/side adjacent 
to angle)= Alpha
 
 
 
-Atn 
(Number)
+Atn 
(Number As Double) As Double
 
 
 Double
 
 
- 
Number: Any numerical expression that represents the ratio of two 
sides of a right triangle. The Atn function returns the corresponding angle in 
radians (arctangent).
+ 
Number: Any numerical expression that represents the ratio of two 
sides of a right triangle. The Atn function returns the 
corresponding angle in radians (arctangent).
 To convert 
radians to degrees, multiply radians by 180/pi.
 degree=(radian*180)/pi
 radian=(degree*pi)/180
-Pi is here 
the fixed circle constant with the rounded value 3.14159. Pi is a Basic 
mathematical constant.
+Pi is here the fixed circle constant with 
the rounded value 3.14159. Pi is a Basic 
mathematical constant.
 
 
 
@@ -65,6 +65,12 @@
 
Print "The Alpha angle is"; (atn (d2/d1) * 180 / Pi); " degrees"
 End 
Sub
 
-
 
+
+   
+   
+   
+
+
+
 
diff --git a/source/text/sbasic/shared/03080102.xhp 
b/source/text/sbasic/shared/03080102.xhp
index 908daeec3..ba199bf3b 100644
--- a/source/text/sbasic/shared/03080102.xhp
+++ b/source/text/sbasic/shared/03080102.xhp
@@ -34,30 +34,29 @@
 
 
 
-Cos 
Function
-Calculates the 
cosine of an angle. The angle is specified in radians. The result lies between 
-1 and 1.
+Cos 
Function
+Calculates the cosine of an 
angle. The angle is specified in radians. The result lies between -1 and 
1.
 
-Using the 
angle Alpha, the Cos-Function calculates the ratio of the length of the side 
that is adjacent to the angle, divided by the length of the hypotenuse in a 
right-angled triangle.
-Cos(Alpha) = 
Adjacent/Hypotenuse
+Using the 
angle Alpha, the Cos function calculates the ratio of the 
length of the side that is adjacent to the angle, divided by the length of the 
hypotenuse in a right-angled triangle.
+Cos(Alpha) = Adjacent/Hypotenuse
 
-Syntax:
-
-Cos 
(Number)
+
+Cos (Number As 
Double) As Double
 
 
-Return 
value:
+
 Double
 
-Parameters:
+
  
Number: Numeric expression that specifies an angle in radians that 
you want to calculate the cosine for.
 To convert 
degrees to radians, multiply degrees by pi/180. To convert radians to degrees, 
multiply radians by 180/pi.
 degree=(radian*180)/pi
 radian=(degree*pi)/180
-Pi is here the 
fixed circle constant with the rounded value 3.14159...
+Pi is here the fixed circle constant with 
the rounded value 3.14159...
 
 
 
-Example:
+
 
 ' The following 
example allows for a right-angled triangle the input of
 ' secant and 
angle (in degrees) and calculates the length of the hypotenuse:
@@ -69,6 +68,12 @@
 Print "The 
length of the hypothenuse 

Minutes from the UX/design meeting 2021-Nov-10


Present: Heiko
Comments: Sophie, Stuart, Dieter

Tickets/Topics

 * Add some tip about install process to LibreOffice's
   macOS installer window
   + https://bugs.documentfoundation.org/show_bug.cgi?id=145295
   + only when localizable (Sophie)
   + it should be expected from users to know how to manage software on
 their OS (Heiko)
   => WF

 * Enhancement: PLEASE revert location of RGB controls in Draw
   + https://bugs.documentfoundation.org/show_bug.cgi?id=143761
   + some 'More' control at the sidebar (Stuart) or NAB/WF (Heiko)
   => no further input so do it as suggested

 * Improve to exit LO, if some other document has a popup opened
   + https://bugs.documentfoundation.org/show_bug.cgi?id=144905
   => no further input; keep open

 * TEMPLATES: Improve confirmation dialog "Update styles /
   Keep Old Styles" dialog
   + https://bugs.documentfoundation.org/show_bug.cgi?id=145114
   + change the label to "Keep Old Styles (and detach template)"
   works better (Dieter)

 * Dynamic QR / Barcode creation using spreadsheet cell reference
   + https://bugs.documentfoundation.org/show_bug.cgi?id=145358
   + formula needs to be defined cross-application and the use case
 to generate many or variable QR codes is minor relevant; better
 run a macros for special cases (Heiko)
   => resolve WF


OpenPGP_signature
Description: OpenPGP digital signature


[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit eaeca6056c86b4072b49d8687aa44980860702a9
Author: Rafael Lima 
AuthorDate: Wed Nov 10 20:33:16 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 10 19:33:16 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 858f7cac7f8fc3ec21c2273c21f7a4b34c608d62
  - Fix caseinline in some Help pages

Change-Id: I67472c239abdb425ad5787bb854638566b29b4f6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124847
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 60560093b76d..858f7cac7f8f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 60560093b76da08195ad1b1dc7bbd17ee2cfb333
+Subproject commit 858f7cac7f8fc3ec21c2273c21f7a4b34c608d62


[Libreoffice-commits] help.git: source/text

 source/text/scalc/01/live_data_stream.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 858f7cac7f8fc3ec21c2273c21f7a4b34c608d62
Author: Rafael Lima 
AuthorDate: Mon Nov 8 14:11:05 2021 +0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 10 19:33:14 2021 +0100

Fix caseinline in some Help pages

Change-Id: I67472c239abdb425ad5787bb854638566b29b4f6
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124847
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/live_data_stream.xhp 
b/source/text/scalc/01/live_data_stream.xhp
index fa9fe9e2d..66c9531a6 100644
--- a/source/text/scalc/01/live_data_stream.xhp
+++ b/source/text/scalc/01/live_data_stream.xhp
@@ -37,7 +37,7 @@
   
 Menu 
Data – Streams...
   
-  This is an experimental feature and is 
disabled by default. To enable it, go to Tools - Options - 
Advanced  and check the option Enable experimental features 
(may be unstable).
+  This is an experimental feature and is 
disabled by default. To enable it, go to %PRODUCTNAME - 
PreferencesTools - 
Options – %PRODUCTNAME – 
Advanced and check the option Enable experimental features 
(may be unstable).
   
 
 


[Libreoffice-commits] core.git: avmedia/source compilerplugins/clang desktop/source i18npool/source l10ntools/source solenv/CompilerTest_compilerplugins_clang.mk svx/source testtools/source ucb/source

 avmedia/source/gstreamer/gstplayer.cxx |6 
 compilerplugins/clang/stringliteraldefine.cxx  |  172 +
 compilerplugins/clang/test/stringliteraldefine.cxx |   56 ++
 desktop/source/migration/services/jvmfwk.cxx   |2 
 i18npool/source/indexentry/indexentrysupplier.cxx  |2 
 l10ntools/source/xmlparse.cxx  |2 
 solenv/CompilerTest_compilerplugins_clang.mk   |1 
 svx/source/form/datanavi.cxx   |   48 ++---
 testtools/source/bridgetest/bridgetest.cxx |8 
 testtools/source/bridgetest/cppobj.cxx |6 
 ucb/source/ucp/ftp/ftpcontent.cxx  |4 
 unotools/source/config/cmdoptions.cxx  |2 
 unotools/source/config/compatibility.cxx   |2 
 unotools/source/config/fontcfg.cxx |   16 -
 unotools/source/config/moduleoptions.cxx   |2 
 15 files changed, 279 insertions(+), 50 deletions(-)

New commits:
commit 9444c925b254cca32c08c473cc294a5f0e90881a
Author: Noel Grandin 
AuthorDate: Wed Nov 10 12:28:26 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 10 19:10:31 2021 +0100

new loplugin:stringliteraldefine

look for
   #define FOO "foo"
that can be converted into OUStringLiteral.

This is the first pass of this plugin, only doing those #define which
are local to a single compilation unit.

Change-Id: Ic8610e29ec42c36d03db5014a93c244315d5bbea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124962
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/avmedia/source/gstreamer/gstplayer.cxx 
b/avmedia/source/gstreamer/gstplayer.cxx
index 2e723ce6efbc..4f12f80f5ded 100644
--- a/avmedia/source/gstreamer/gstplayer.cxx
+++ b/avmedia/source/gstreamer/gstplayer.cxx
@@ -42,12 +42,12 @@
 #include "gstwindow.hxx"
 
 #include 
-#define AVMEDIA_GST_PLAYER_IMPLEMENTATIONNAME 
"com.sun.star.comp.avmedia.Player_GStreamer"
-#define AVMEDIA_GST_PLAYER_SERVICENAME
"com.sun.star.media.Player_GStreamer"
-
 #include 
 #include 
 
+constexpr OUStringLiteral AVMEDIA_GST_PLAYER_IMPLEMENTATIONNAME = 
u"com.sun.star.comp.avmedia.Player_GStreamer";
+constexpr OUStringLiteral AVMEDIA_GST_PLAYER_SERVICENAME= 
u"com.sun.star.media.Player_GStreamer";
+
 #define AVVERSION "gst 1.0: "
 
 using namespace ::com::sun::star;
diff --git a/compilerplugins/clang/stringliteraldefine.cxx 
b/compilerplugins/clang/stringliteraldefine.cxx
new file mode 100644
index ..0eda65e7bea2
--- /dev/null
+++ b/compilerplugins/clang/stringliteraldefine.cxx
@@ -0,0 +1,172 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+// Find constant character array variables that are either
+//   (a) passed into O[U]String constructors
+//   (b) assigned to O[U]String
+// and are declared using macro names
+// and should thus be turned into O[U]StringLiteral variables.
+//
+
+#include 
+
+#include "check.hxx"
+#include "plugin.hxx"
+
+namespace
+{
+class StringLiteralDefine final : public 
loplugin::FilteringPlugin
+{
+public:
+explicit StringLiteralDefine(loplugin::InstantiationData const& data)
+: FilteringPlugin(data)
+{
+}
+
+bool TraverseInitListExpr(InitListExpr* expr, DataRecursionQueue* queue = 
nullptr)
+{
+return WalkUpFromInitListExpr(expr)
+   && TraverseSynOrSemInitListExpr(
+  expr->isSemanticForm() ? expr : expr->getSemanticForm(), 
queue);
+}
+
+bool VisitCXXConstructExpr(CXXConstructExpr const* expr)
+{
+if (ignoreLocation(expr))
+return true;
+loplugin::TypeCheck const tc(expr->getType());
+if (!(tc.Class("OString").Namespace("rtl").GlobalNamespace()
+  || tc.Class("OUString").Namespace("rtl").GlobalNamespace()))
+{
+return true;
+}
+auto const ctor = expr->getConstructor();
+if (ctor->getNumParams() != 2)
+return true;
+
+const Expr* arg0 = expr->getArg(0)->IgnoreParenImpCasts();
+auto const e1 = dyn_cast(arg0);
+if (!e1)
+return true;
+auto argLoc = compat::getBeginLoc(arg0);
+// check if the arg is a macro
+auto macroLoc = compiler.getSourceManager().getSpellingLoc(argLoc);
+if (argLoc == macroLoc)
+return true;
+// check if it is the right kind of macro (not particularly reliable 
checks)
+if (!macroLoc.isValid() || 
!compiler.getSourceManager().isInMainFile(macroLoc)
+|| compiler.getSourceManager().isInSystemHeader(macroLoc)
+// not sure when these became available
+

[Libreoffice-commits] core.git: sw/source

 sw/source/core/docnode/ndnum.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6610bfdd8c8923e85b30e364c6ea5c7abf218367
Author: Caolán McNamara 
AuthorDate: Wed Nov 10 15:55:07 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 10 18:17:56 2021 +0100

use a less tortured syntax for the check

Change-Id: If526f187d855760c0462f6573d1f2e42418d9094
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124996
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/source/core/docnode/ndnum.cxx b/sw/source/core/docnode/ndnum.cxx
index 9cce9a6b7780..e27755f9ed33 100644
--- a/sw/source/core/docnode/ndnum.cxx
+++ b/sw/source/core/docnode/ndnum.cxx
@@ -40,7 +40,7 @@ void SwNodes::UpdateOutlineNode(SwNode & rNd)
 {
 SwTextNode * pTextNd = rNd.GetTextNode();
 
-if (!(pTextNd && pTextNd->IsOutlineStateChanged()))
+if (!pTextNd || !pTextNd->IsOutlineStateChanged())
 return;
 
 bool bFound = m_pOutlineNodes->find(pTextNd) != m_pOutlineNodes->end();


[Libreoffice-commits] core.git: i18nlangtag/source

 i18nlangtag/source/languagetag/languagetag.cxx |  107 -
 1 file changed, 54 insertions(+), 53 deletions(-)

New commits:
commit 6334f7dc43f69ada4341d5f0dd1a0f1e13113b4f
Author: Stephan Bergmann 
AuthorDate: Wed Nov 10 17:02:52 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 10 18:15:22 2021 +0100

initialization-order-fiasco, again

...after b5758cb2729236d9eaf52bd25b1b113a3ff06b4e "rtl::Static to 
thread-safe
static" (which this partially reverts again), like
71d0c43fb4cf535239cb41baf7b6e03de765ce7a "initialization-order-fiasco" in 
the
past

Change-Id: Ie3f352a63ee3939b1727faf6cf11b2768173437c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124998
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/i18nlangtag/source/languagetag/languagetag.cxx 
b/i18nlangtag/source/languagetag/languagetag.cxx
index 83d730f5fc5f..6f6a766e861f 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -18,6 +18,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -49,32 +50,42 @@ struct myLtError
 };
 
 // "static" to be returned as const reference to an empty locale.
-const lang::Locale theEmptyLocale;
+struct theEmptyLocale : public rtl::Static< lang::Locale, theEmptyLocale > {};
+}
 
 typedef std::unordered_set< OUString > KnownTagSet;
+namespace {
+struct theKnowns : public rtl::Static< KnownTagSet, theKnowns > {};
+struct theMutex : public rtl::Static< osl::Mutex, theMutex > {};
+}
 
-const KnownTagSet & getKnowns()
+static const KnownTagSet & getKnowns()
 {
-static KnownTagSet theKnowns = []()
+KnownTagSet & rKnowns = theKnowns::get();
+if (rKnowns.empty())
 {
-KnownTagSet ret;
-::std::vector< MsLangId::LanguagetagMapping > aDefined( 
MsLangId::getDefinedLanguagetags());
-for (auto const& elemDefined : aDefined)
+osl::MutexGuard aGuard( theMutex::get());
+if (rKnowns.empty())
 {
-// Do not use the BCP47 string here to initialize the
-// LanguageTag because then canonicalize() would call this
-// getKnowns() again...
-::std::vector< OUString > aFallbacks( LanguageTag( 
elemDefined.mnLang).getFallbackStrings( true));
-for (auto const& fallback : aFallbacks)
+::std::vector< MsLangId::LanguagetagMapping > aDefined( 
MsLangId::getDefinedLanguagetags());
+for (auto const& elemDefined : aDefined)
 {
-ret.insert(fallback);
+// Do not use the BCP47 string here to initialize the
+// LanguageTag because then canonicalize() would call this
+// getKnowns() again...
+::std::vector< OUString > aFallbacks( LanguageTag( 
elemDefined.mnLang).getFallbackStrings( true));
+for (auto const& fallback : aFallbacks)
+{
+rKnowns.insert(fallback);
+}
 }
 }
-return ret;
-}();
-return theKnowns;
+}
+return rKnowns;
 }
 
+
+namespace {
 struct compareIgnoreAsciiCaseLess
 {
 bool operator()( const OUString& r1, std::u16string_view r2 ) const
@@ -84,23 +95,17 @@ struct compareIgnoreAsciiCaseLess
 };
 typedef ::std::map< OUString, LanguageTag::ImplPtr, compareIgnoreAsciiCaseLess 
> MapBcp47;
 typedef ::std::map< LanguageType, LanguageTag::ImplPtr > MapLangID;
-MapBcp47 theMapBcp47;
-MapLangID theMapLangID;
-LanguageTag::ImplPtr theDontKnow;
-LanguageTag::ImplPtr theSystemLocale;
-osl::Mutex& theMutex()
-{
-static osl::Mutex SINGLETON;
-return SINGLETON;
-}
-
+struct theMapBcp47 : public rtl::Static< MapBcp47, theMapBcp47 > {};
+struct theMapLangID : public rtl::Static< MapLangID, theMapLangID > {};
+struct theDontKnow : public rtl::Static< LanguageTag::ImplPtr, theDontKnow > 
{};
+struct theSystemLocale : public rtl::Static< LanguageTag::ImplPtr, 
theSystemLocale > {};
 }
 
 
 static LanguageType getNextOnTheFlyLanguage()
 {
 static LanguageType nOnTheFlyLanguage(0);
-osl::MutexGuard aGuard(theMutex());
+osl::MutexGuard aGuard( theMutex::get());
 if (!nOnTheFlyLanguage)
 nOnTheFlyLanguage = MsLangId::makeLangID( 
LANGUAGE_ON_THE_FLY_SUB_START, LANGUAGE_ON_THE_FLY_START);
 else
@@ -166,11 +171,7 @@ private:
 static void teardown();
 };
 
-LiblangtagDataRef& theDataRef()
-{
-static LiblangtagDataRef SINGLETON;
-return SINGLETON;
-}
+struct theDataRef : public rtl::Static< LiblangtagDataRef, theDataRef > {};
 }
 
 LiblangtagDataRef::LiblangtagDataRef()
@@ -428,7 +429,7 @@ LanguageTagImpl::LanguageTagImpl( const LanguageTagImpl & 
rLanguageTagImpl )
 mbCachedGlibcString( rLanguageTagImpl.mbCachedGlibcString)
 {
 if (mpImplLangtag)
-theDataRef().init();
+theDataRef::get().init();
 }
 
 
@@ -464,7 +465,7 @@ LanguageTagImpl& LanguageTagImpl::o

[Libreoffice-commits] core.git: compilerplugins/clang

 compilerplugins/clang/stringview.cxx  |   28 
 compilerplugins/clang/test/stringview.cxx |3 +++
 2 files changed, 19 insertions(+), 12 deletions(-)

New commits:
commit 0ac45af39c534ce17a4a76a370add4ffa4fa92f9
Author: Stephan Bergmann 
AuthorDate: Wed Nov 10 16:26:05 2021 +0100
Commit: Noel Grandin 
CommitDate: Wed Nov 10 17:58:24 2021 +0100

Avoid unhelpful loplugin:stringview from implicit conversions

> compilerplugins/clang/test/stringview.cxx Line 149: instead of an 
'rtl::OString' constructed from a 'const rtl::OStringLiteral<4>', pass a 
'std::string_view' [loplugin:stringview]
> compilerplugins/clang/test/stringview.cxx Line 150: instead of an 
'rtl::OUString' constructed from a 'const rtl::OUStringLiteral<4>', pass a 
'std::u16string_view' [loplugin:stringview]

(see the discussion at 
"operator==(OString, OStringLiteral)")

Change-Id: I5481bef8b8bad7bf9bdf4fff29161f0809051f2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124990
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/stringview.cxx 
b/compilerplugins/clang/stringview.cxx
index 4043d7a67e60..b3a0323d2923 100644
--- a/compilerplugins/clang/stringview.cxx
+++ b/compilerplugins/clang/stringview.cxx
@@ -75,18 +75,18 @@ bool 
StringView::VisitCXXOperatorCallExpr(CXXOperatorCallExpr const* cxxOperator
 auto op = cxxOperatorCallExpr->getOperator();
 if (op == OO_Plus && cxxOperatorCallExpr->getNumArgs() == 2)
 {
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(0)));
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(1)));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(0));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(1));
 }
 if (compat::isComparisonOp(cxxOperatorCallExpr))
 {
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(0)));
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(1)));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(0));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(1));
 }
 else if (op == OO_PlusEqual)
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(1)));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(1));
 else if (op == OO_Subscript)
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(0)));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(0));
 else if (op == OO_Equal)
 {
 if (loplugin::TypeCheck(cxxOperatorCallExpr->getType())
@@ -98,7 +98,7 @@ bool StringView::VisitCXXOperatorCallExpr(CXXOperatorCallExpr 
const* cxxOperator
.Namespace("rtl")
.GlobalNamespace())
 {
-
handleSubExprThatCouldBeView(compat::IgnoreImplicit(cxxOperatorCallExpr->getArg(1)));
+handleSubExprThatCouldBeView(cxxOperatorCallExpr->getArg(1));
 }
 }
 return true;
@@ -130,7 +130,8 @@ bool StringView::VisitImplicitCastExpr(ImplicitCastExpr 
const* expr)
 
 void StringView::handleSubExprThatCouldBeView(Expr const* subExpr)
 {
-auto const e = subExpr->IgnoreParens();
+auto const e0 = compat::IgnoreImplicit(subExpr);
+auto const e = e0->IgnoreParens();
 auto const tc = loplugin::TypeCheck(e->getType());
 if (!(tc.Class("OString").Namespace("rtl").GlobalNamespace()
   || tc.Class("OUString").Namespace("rtl").GlobalNamespace()))
@@ -139,7 +140,10 @@ void StringView::handleSubExprThatCouldBeView(Expr const* 
subExpr)
 }
 if (auto const e1 = dyn_cast(e))
 {
-handleCXXConstructExpr(e1);
+if (e0 == subExpr)
+{
+handleCXXConstructExpr(e1);
+}
 }
 else if (auto const e2 = dyn_cast(e))
 {
@@ -301,11 +305,11 @@ bool StringView::VisitCXXMemberCallExpr(CXXMemberCallExpr 
const* expr)
 auto const dc = loplugin::DeclCheck(expr->getMethodDecl());
 if (dc.Function("append") || dc.Function("indexOf") || 
dc.Function("lastIndexOf"))
 {
-handleSubExprThatCouldBeView(compat::IgnoreImplicit(expr->getArg(0)));
+handleSubExprThatCouldBeView(expr->getArg(0));
 }
 else if (dc.Function("insert"))
 {
-handleSubExprThatCouldBeView(compat::IgnoreImplicit(expr->getArg(1)));
+handleSubExprThatCouldBeView(expr->getArg(1));
 }
 return true;
 }
@@ -330,7 +334,7 @@ bool StringView::VisitCXXConstructExpr(CXXConstructExpr 
const* expr)
 return true;
 }
 if (expr->getNumArgs() > 0)
-handleSubExprThatCouldBeView(compat::IgnoreImplicit(expr->getArg(0)));
+handleSubExprThatCouldBeView(expr->getArg(0));
 return true;
 }
 
diff --git a/compilerplu

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sd/source

 sd/source/ui/sidebar/SlideBackground.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 4cb2e0eaf3731cef327d28d4692de68b4602adfb
Author: Szymon Kłos 
AuthorDate: Mon Nov 8 14:01:19 2021 +0100
Commit: Szymon Kłos 
CommitDate: Wed Nov 10 17:49:52 2021 +0100

lok: hide useless insert image button in sidebar

do this also in draw, not only in impress

Change-Id: Iaaf2349cfb98b801957b71bd4504f0e9efbfba4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124840
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124902
Reviewed-by: Szymon Kłos 

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index b372b25a2282..1df1099be972 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -334,14 +334,6 @@ void SlideBackground::HandleContextChange(
 mxInsertImage->show();
 }
 
-// The Insert Image button in the sidebar issues .uno:SelectBackground,
-// which when invoked without arguments will open the file-open-dialog
-// to prompt the user to select a file. This is useless in LOOL.
-// Hide for now so the user will only be able to use the menu to insert
-// background image, which prompts the user for file selection in the 
browser.
-if (comphelper::LibreOfficeKit::isActive())
-mxInsertImage->hide();
-
 // Need to do a relayouting, otherwise the panel size is not updated 
after show / hide controls
 if (m_pPanel)
 m_pPanel->TriggerDeckLayouting();
@@ -363,6 +355,14 @@ void SlideBackground::HandleContextChange(
 mxBackgroundLabel->hide();
 }
 }
+
+// The Insert Image button in the sidebar issues .uno:SelectBackground,
+// which when invoked without arguments will open the file-open-dialog
+// to prompt the user to select a file. This is useless in LOOL.
+// Hide for now so the user will only be able to use the menu to insert
+// background image, which prompts the user for file selection in the 
browser.
+if (comphelper::LibreOfficeKit::isActive())
+mxInsertImage->hide();
 }
 
 void SlideBackground::Update()


[Libreoffice-commits] core.git: bin/oss-fuzz-setup.sh

 bin/oss-fuzz-setup.sh |  121 +-
 1 file changed, 62 insertions(+), 59 deletions(-)

New commits:
commit 48ae3cc1af37271e3ad6ef15a603b1d1add6a69b
Author: Caolán McNamara 
AuthorDate: Wed Nov 10 16:38:39 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 10 17:49:23 2021 +0100

use tarball names from download.lst for oss-fuzz-setup.sh

Change-Id: I6534e8c81a6598e49de99b08bae80657e1355965
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125004
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/bin/oss-fuzz-setup.sh b/bin/oss-fuzz-setup.sh
index a321c1a079d2..18c3fcfb68d9 100755
--- a/bin/oss-fuzz-setup.sh
+++ b/bin/oss-fuzz-setup.sh
@@ -4,69 +4,72 @@ set -e
 
 echo start downloading dependencies at `date -u`
 
+# convert FOO := BAR$(MICRO) to FOO=BAR$MICRO
+source <(sed -e's# := #=#g' download.lst | sed -e 's#[)(]##g')
+
 cd $SRC
 
 #cache build dependencies
 curl --no-progress-meter -S \
--C - -O 
https://dev-www.libreoffice.org/src/liberation-fonts-ttf-2.1.4.tar.gz \
--C - -O 
https://dev-www.libreoffice.org/extern/f543e6e2d7275557a839a164941c0a86e5f2c3f2a0042bfc434c88c6dde9e140-opens___.ttf
 \
--C - -O 
https://dev-www.libreoffice.org/src/1f5def51ca0026cd192958ef07228b52-rasqal-0.9.33.tar.gz
 \
--C - -O 
https://dev-www.libreoffice.org/src/48d647fbd8ef8889e5a7f422c1bfda94-clucene-core-2.3.3.4.tar.gz
 \
--C - -O 
https://dev-www.libreoffice.org/src/5ade6ae2a99bc1e9e57031ca88d36dad-hyphen-2.8.8.tar.gz
 \
--C - -O 
https://dev-www.libreoffice.org/src/a39f6c07ddb20d7dd2ff1f95fa21e2cd-raptor2-2.0.15.tar.gz
 \
--C - -O 
https://dev-www.libreoffice.org/src/a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
 \
--C - -O 
https://dev-www.libreoffice.org/src/e5be03eda13ef68aabab6e42aa67715e-redland-1.0.17.tar.gz
 \
--C - -O https://dev-www.libreoffice.org/src/boost_1_77_0.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/box2d-2.3.1.tar.gz \
--C - -O https://dev-www.libreoffice.org/src/dtoa-20180411.tgz \
--C - -O https://dev-www.libreoffice.org/src/expat-2.4.1.tar.bz2 \
--C - -O 
https://dev-www.libreoffice.org/src/libcuckoo-93217f8d391718380c508a722ab9acd5e9081233.tar.gz
 \
--C - -O https://dev-www.libreoffice.org/src/libjpeg-turbo-2.1.1.tar.gz \
--C - -O https://dev-www.libreoffice.org/src/lcms2-2.12.tar.gz \
--C - -O https://dev-www.libreoffice.org/src/libexttextcat-3.4.6.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/cppunit-1.15.1.tar.gz \
--C - -O https://dev-www.libreoffice.org/src/cairo-1.17.4.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/curl-7.79.1.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/xmlsec1-1.2.32.tar.gz \
--C - -O https://dev-www.libreoffice.org/src/liblangtag-0.6.3.tar.bz2 \
--C - -O https://dev-www.libreoffice.org/src/libabw-0.1.3.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libcdr-0.1.7.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libcmis-0.5.2.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libe-book-0.1.3.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libetonyek-0.1.10.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libfreehand-0.1.2.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libmspub-0.1.4.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libmwaw-0.3.20.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libodfgen-0.1.8.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/liborcus-0.17.0.tar.bz2 \
--C - -O https://dev-www.libreoffice.org/src/libpagemaker-0.0.4.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libpng-1.6.37.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/librevenge-0.0.4.tar.bz2 \
--C - -O https://dev-www.libreoffice.org/src/libstaroffice-0.0.7.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libvisio-0.1.7.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libwpd-0.10.3.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libwpg-0.3.3.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libwps-0.4.12.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/libzmf-0.0.2.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/pixman-0.40.0.tar.gz \
--C - -O https://dev-www.libreoffice.org/src/zlib-1.2.11.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/mdds-2.0.0.tar.bz2 \
--C - -O https://dev-www.libreoffice.org/src/openssl-1.1.1l.tar.gz \
--C - -O 
https://dev-www.libreoffice.org/src/language-subtag-registry-2021-08-06.tar.bz2 
\
--C - -O https://dev-www.libreoffice.org/src/graphite2-minimal-1.3.14.tgz \
--C - -O https://dev-www.libreoffice.org/src/harfbuzz-2.8.2.tar.xz \
--C - -O https://dev-www.libreoffice.org/src/glm-0.9.9.8.zip \
--C - -O https://dev-www.libreoffice.org/src/icu4c-69_1-src.tgz \
--C - -O https://dev-www.libreoffice.org/src/icu4c-69_1-data.zip \

[Libreoffice-commits] core.git: bin/oss-fuzz-setup.sh

 bin/oss-fuzz-setup.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e03a30925e418db99f5c39920d8f8a1b6d49f20e
Author: Caolán McNamara 
AuthorDate: Wed Nov 10 16:10:21 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 10 17:49:04 2021 +0100

bump oss-fuzz-setup requirements

Change-Id: Ifda2cd08776a30c83cd1e52a4f0d6d1200d4cb95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125000
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/bin/oss-fuzz-setup.sh b/bin/oss-fuzz-setup.sh
index 114251de4418..a321c1a079d2 100755
--- a/bin/oss-fuzz-setup.sh
+++ b/bin/oss-fuzz-setup.sh
@@ -16,7 +16,7 @@ curl --no-progress-meter -S \
 -C - -O 
https://dev-www.libreoffice.org/src/a39f6c07ddb20d7dd2ff1f95fa21e2cd-raptor2-2.0.15.tar.gz
 \
 -C - -O 
https://dev-www.libreoffice.org/src/a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz
 \
 -C - -O 
https://dev-www.libreoffice.org/src/e5be03eda13ef68aabab6e42aa67715e-redland-1.0.17.tar.gz
 \
--C - -O https://dev-www.libreoffice.org/src/boost_1_76_0.tar.xz \
+-C - -O https://dev-www.libreoffice.org/src/boost_1_77_0.tar.xz \
 -C - -O https://dev-www.libreoffice.org/src/box2d-2.3.1.tar.gz \
 -C - -O https://dev-www.libreoffice.org/src/dtoa-20180411.tgz \
 -C - -O https://dev-www.libreoffice.org/src/expat-2.4.1.tar.bz2 \


[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - external/openldap

 external/openldap/openldap-2.4.44.patch.1 |   12 
 1 file changed, 12 insertions(+)

New commits:
commit e767ee33fe1ad0935b5293f215d5f55f6ef76943
Author: Tor Lillqvist 
AuthorDate: Wed Nov 10 13:36:43 2021 +0200
Commit: Michael Stahl 
CommitDate: Wed Nov 10 17:28:04 2021 +0100

Add forward declaration to openldap to fix compilation with current Xcode

For some reason the warning about this undeclared function is treated
as an error by the Clang version in current Xcode, at least for me,
even if openldap isn't compiled with -Werror.

Change-Id: Ic8479ca63031319ce55c6fb9d95132019ae82cae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124959
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 34b586dc84b810eece7ae08b4028caba78db319f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124968
Reviewed-by: Michael Stahl 

diff --git a/external/openldap/openldap-2.4.44.patch.1 
b/external/openldap/openldap-2.4.44.patch.1
index 0d3cf5b70c3f..317ef9a62e56 100644
--- a/external/openldap/openldap-2.4.44.patch.1
+++ b/external/openldap/openldap-2.4.44.patch.1
@@ -1,3 +1,4 @@
+-*- Mode: diff -*-
 --- openldap.org/configure
 +++ openldap/configure
 @@ -15735,7 +15735,7 @@
@@ -52,6 +53,17 @@
  
  #undef NSS_VERSION_INT
  #define   NSS_VERSION_INT ((NSS_VMAJOR << 24) | (NSS_VMINOR << 16) | \
+--- openldap.org/libraries/libldap/tls2.c
 openldap.org/libraries/libldap/tls2.c
+@@ -80,6 +80,8 @@
+   { BER_BVNULL, BER_BVNULL }
+ };
+ 
++int ldap_pvt_tls_check_hostname( LDAP *ld, void *s, const char *name_in );
++
+ #ifdef HAVE_TLS
+ 
+ void
 --- openldap.org/Makefile.in
 +++ openldap/Makefile.in
 @@ -13,7 +13,7 @@


[Libreoffice-commits] core.git: configure.ac

 configure.ac |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 0aea45001b73d76fa9b3185ad60df1ac6d2d9b12
Author: Stephan Bergmann 
AuthorDate: Wed Nov 10 13:30:53 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 10 17:11:38 2021 +0100

Only try -prerelease as a fallback

Otherwise, --with-visual-studio=2022 picked the Preview version for me when 
I
have both Preview and Current installed.

Change-Id: I1c53a28877a6de80db54ed9b17b1eee0eae923c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124963
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/configure.ac b/configure.ac
index a894323e2881..336c79925427 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3887,7 +3887,10 @@ find_msvc()
 PathFormat "$vswhere"
 vswhere=$formatted_path_unix
 for ver in $vsversions; do
-vswhereoutput=`$vswhere -prerelease -version "@<:@ $ver , $(expr $ver 
+ 1) @:}@" -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 
-property installationPath | head -1`
+vswhereoutput=`$vswhere -version "@<:@ $ver , $(expr $ver + 1) @:}@" 
-requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property 
installationPath | head -1`
+if test -z "$vswhereoutput"; then
+vswhereoutput=`$vswhere -prerelease -version "@<:@ $ver , $(expr 
$ver + 1) @:}@" -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 
-property installationPath | head -1`
+fi
 # Fall back to all MS products (this includes VC++ Build Tools)
 if ! test -n "$vswhereoutput"; then
 AC_MSG_CHECKING([VC++ Build Tools and similar])


[Libreoffice-commits] core.git: dbaccess/source

 dbaccess/source/core/api/SingleSelectQueryComposer.cxx  |   10 ++
 dbaccess/source/core/api/query.cxx  |   17 +++
 dbaccess/source/core/api/querydescriptor.cxx|9 +-
 dbaccess/source/core/dataaccess/ComponentDefinition.cxx |9 +-
 dbaccess/source/core/dataaccess/commandcontainer.cxx|8 +
 dbaccess/source/core/dataaccess/commanddefinition.cxx   |8 +
 dbaccess/source/core/dataaccess/definitioncontainer.cxx |9 +-
 dbaccess/source/core/dataaccess/documentcontainer.cxx   |9 +-
 dbaccess/source/core/dataaccess/documentdefinition.cxx  |9 +-
 dbaccess/source/filter/xml/xmlHelper.cxx|   71 +---
 dbaccess/source/inc/apitools.hxx|   31 --
 dbaccess/source/ui/uno/ColumnModel.cxx  |8 +
 12 files changed, 125 insertions(+), 73 deletions(-)

New commits:
commit 10649a5b3a3813915969ace07ac4ddaafe709718
Author: Julien Nabet 
AuthorDate: Tue Nov 9 22:01:26 2021 +0100
Commit: Julien Nabet 
CommitDate: Wed Nov 10 16:30:46 2021 +0100

Replace some macros in dbaccess part 2

Remove MAP_CONST_TEXT + MAP_CONST_ROW
+ IMPLEMENT_SERVICE_INFO3 + IMPLEMENT_GETTYPES3 + IMPLEMENT_GETTYPES2

Change-Id: I56e96a782eda1e570a43cb6bad3fa5e52bc08d2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124960
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx 
b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
index 31455e055727..94ddd8600a8a 100644
--- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
+++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
@@ -285,7 +285,15 @@ css::uno::Sequence 
OSingleSelectQueryComposer::getImplementationId()
 return css::uno::Sequence();
 }
 
-IMPLEMENT_GETTYPES3(OSingleSelectQueryComposer,OSubComponent,OSingleSelectQueryComposer_BASE,OPropertyContainer)
+css::uno::Sequence< css::uno::Type > OSingleSelectQueryComposer::getTypes()
+{
+return  ::comphelper::concatSequences(
+OSubComponent::getTypes( ),
+OSingleSelectQueryComposer_BASE::getTypes( ),
+OPropertyContainer::getTypes( )
+);
+}
+
 IMPLEMENT_PROPERTYCONTAINER_DEFAULTS(OSingleSelectQueryComposer)
 
 // XSingleSelectQueryAnalyzer
diff --git a/dbaccess/source/core/api/query.cxx 
b/dbaccess/source/core/api/query.cxx
index cc5e7753b262..ebaba24a2a9d 100644
--- a/dbaccess/source/core/api/query.cxx
+++ b/dbaccess/source/core/api/query.cxx
@@ -105,7 +105,15 @@ css::uno::Sequence OQuery::getImplementationId()
 return css::uno::Sequence();
 }
 
-IMPLEMENT_GETTYPES3(OQuery,OQueryDescriptor_Base,ODataSettings,OContentHelper);
+css::uno::Sequence< css::uno::Type > OQuery::getTypes()
+{
+return  ::comphelper::concatSequences(
+OQueryDescriptor_Base::getTypes( ),
+ODataSettings::getTypes( ),
+OContentHelper::getTypes( )
+);
+}
+
 IMPLEMENT_FORWARD_XINTERFACE3( 
OQuery,OContentHelper,OQueryDescriptor_Base,ODataSettings)
 
 void OQuery::rebuildColumns()
@@ -204,7 +212,12 @@ void OQuery::rebuildColumns()
 }
 
 // XServiceInfo
-IMPLEMENT_SERVICE_INFO3(OQuery, "com.sun.star.sdb.dbaccess.OQuery", 
SERVICE_SDB_DATASETTINGS, SERVICE_SDB_QUERY, "com.sun.star.sdb.QueryDefinition")
+IMPLEMENT_SERVICE_INFO_IMPLNAME(OQuery, "com.sun.star.sdb.dbaccess.OQuery")
+IMPLEMENT_SERVICE_INFO_SUPPORTS(OQuery)
+css::uno::Sequence< OUString > SAL_CALL OQuery::getSupportedServiceNames(  )
+{
+return { SERVICE_SDB_DATASETTINGS, SERVICE_SDB_QUERY, 
"com.sun.star.sdb.QueryDefinition" };
+}
 
 // css::beans::XPropertyChangeListener
 void SAL_CALL OQuery::propertyChange( const PropertyChangeEvent& _rSource )
diff --git a/dbaccess/source/core/api/querydescriptor.cxx 
b/dbaccess/source/core/api/querydescriptor.cxx
index 9a70092512e0..52948614519a 100644
--- a/dbaccess/source/core/api/querydescriptor.cxx
+++ b/dbaccess/source/core/api/querydescriptor.cxx
@@ -63,7 +63,14 @@ css::uno::Sequence 
OQueryDescriptor::getImplementationId()
 return css::uno::Sequence();
 }
 
-IMPLEMENT_GETTYPES2(OQueryDescriptor,OQueryDescriptor_Base,ODataSettings);
+css::uno::Sequence< css::uno::Type > OQueryDescriptor::getTypes()
+{
+return  ::comphelper::concatSequences(
+OQueryDescriptor_Base::getTypes( ),
+ODataSettings::getTypes( )
+);
+}
+
 IMPLEMENT_FORWARD_XINTERFACE3( 
OQueryDescriptor,OWeakObject,OQueryDescriptor_Base,ODataSettings)
 
 void OQueryDescriptor::registerProperties()
diff --git a/dbaccess/source/core/dataaccess/ComponentDefinition.cxx 
b/dbaccess/source/core/dataaccess/ComponentDefinition.cxx
index 629727930859..258cfc473a90 100644
--- a/dbaccess/source/core/dataaccess/ComponentDefinition.cxx
+++ b/dbaccess/source/core/dataaccess/ComponentDefinition.cxx
@@ -142,7 +142,14 @@ css::uno::Sequence 
OComponentDefinition::getImplementationId()
 return css::uno::Sequence();
 }
 
-IMPLEMENT_GETTYPES3(OComponentDefinition,ODataSettings,OContentH

[Libreoffice-commits] core.git: cui/uiconfig

 cui/uiconfig/ui/borderpage.ui |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit a9232ed3d76e98ca962217e8aff48b165a604188
Author: Caolán McNamara 
AuthorDate: Wed Nov 10 11:14:34 2021 +
Commit: Caolán McNamara 
CommitDate: Wed Nov 10 16:14:22 2021 +0100

add placeholder labels for gtk

Change-Id: I108816d264a973d12428cad135edbf8fd7c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124957
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/cui/uiconfig/ui/borderpage.ui b/cui/uiconfig/ui/borderpage.ui
index 91fd315ce14e..087b9cf1e46b 100644
--- a/cui/uiconfig/ui/borderpage.ui
+++ b/cui/uiconfig/ui/borderpage.ui
@@ -243,6 +243,7 @@
 False
 0
 True
+
 
   
 
@@ -259,6 +260,7 @@
 False
 0
 True
+
 
   
 
@@ -593,6 +595,7 @@
 False
 0
 True
+
 
   
 


[Libreoffice-commits] core.git: chart2/source

 chart2/source/inc/ChartTypeHelper.hxx   |1 +
 chart2/source/tools/ChartTypeHelper.cxx |   13 +
 chart2/source/view/main/ChartView.cxx   |9 +++--
 3 files changed, 21 insertions(+), 2 deletions(-)

New commits:
commit 453363ae1384a6d6f2c77052170b39a1ebf567a6
Author: Andras Timar 
AuthorDate: Tue Nov 9 23:36:32 2021 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 10 16:02:47 2021 +0100

tdf#136111 fix scaling problem on chart driven by a macro

Change-Id: I9a55bcfceb9259f0d5dc944c00a34b3e4a891e0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124940
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Dennis Francis 
(cherry picked from commit 0644f44daef7caa8a246221d762fbc0f6af3672c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124864
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/chart2/source/inc/ChartTypeHelper.hxx 
b/chart2/source/inc/ChartTypeHelper.hxx
index 1a6345321825..d4917be283fb 100644
--- a/chart2/source/inc/ChartTypeHelper.hxx
+++ b/chart2/source/inc/ChartTypeHelper.hxx
@@ -49,6 +49,7 @@ public:
 static bool isSupportingDateAxis( const css::uno::Reference< 
css::chart2::XChartType >& xChartType, sal_Int32 nDimensionIndex );
 static bool isSupportingComplexCategory( const css::uno::Reference< 
css::chart2::XChartType >& xChartType );
 static bool isSupportingCategoryPositioning( const css::uno::Reference< 
css::chart2::XChartType >& xChartType, sal_Int32 nDimensionCount );
+static bool shiftCategoryPosAtXAxisPerDefault( const 
css::uno::Reference< css::chart2::XChartType >& xChartType );
 
 //returns sequence of css::chart::DataLabelPlacement
 static css::uno::Sequence < sal_Int32 > getSupportedLabelPlacements(
diff --git a/chart2/source/tools/ChartTypeHelper.cxx 
b/chart2/source/tools/ChartTypeHelper.cxx
index bb8f965ee199..323e68197969 100644
--- a/chart2/source/tools/ChartTypeHelper.cxx
+++ b/chart2/source/tools/ChartTypeHelper.cxx
@@ -464,6 +464,19 @@ bool ChartTypeHelper::isSupportingCategoryPositioning( 
const uno::Reference< cha
 return false;
 }
 
+bool ChartTypeHelper::shiftCategoryPosAtXAxisPerDefault( const uno::Reference< 
chart2::XChartType >& xChartType )
+{
+if(xChartType.is())
+{
+OUString aChartTypeName = xChartType->getChartType();
+if( aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_COLUMN)
+|| aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_BAR)
+|| aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_CANDLESTICK) 
)
+return true;
+}
+return false;
+}
+
 bool ChartTypeHelper::noBordersForSimpleScheme( const uno::Reference< 
chart2::XChartType >& xChartType )
 {
 if(xChartType.is())
diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 698583e477aa..021853b6408f 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -325,7 +325,7 @@ public:
 
 void AdaptScaleOfYAxisWithoutAttachedSeries( ChartModel& rModel );
 
-static bool isCategoryPositionShifted(
+bool isCategoryPositionShifted(
 const chart2::ScaleData& rSourceScale, bool bHasComplexCategories );
 
 private:
@@ -350,12 +350,14 @@ private:
  */
 sal_Int32 m_nMaxAxisIndex;
 
+bool m_bChartTypeUsesShiftedCategoryPositionPerDefault;
 sal_Int32 m_nDefaultDateNumberFormat;
 };
 
 SeriesPlotterContainer::SeriesPlotterContainer( std::vector< 
std::unique_ptr >& rVCooSysList )
 : m_rVCooSysList( rVCooSysList )
 , m_nMaxAxisIndex(0)
+, m_bChartTypeUsesShiftedCategoryPositionPerDefault(false)
 , m_nDefaultDateNumberFormat(0)
 {
 }
@@ -519,6 +521,9 @@ void 
SeriesPlotterContainer::initializeCooSysAndSeriesPlotter(
 }
 }
 
+if(nT==0)
+m_bChartTypeUsesShiftedCategoryPositionPerDefault = 
ChartTypeHelper::shiftCategoryPosAtXAxisPerDefault( xChartType );
+
 bool bExcludingPositioning = 
DiagramHelper::getDiagramPositioningMode( xDiagram ) == 
DiagramPositioningMode_EXCLUDING;
 VSeriesPlotter* pPlotter = VSeriesPlotter::createSeriesPlotter( 
xChartType, nDimensionCount, bExcludingPositioning );
 if( !pPlotter )
@@ -630,7 +635,7 @@ bool SeriesPlotterContainer::isCategoryPositionShifted(
 const chart2::ScaleData& rSourceScale, bool bHasComplexCategories )
 {
 if (rSourceScale.AxisType == AxisType::CATEGORY)
-return bHasComplexCategories || rSourceScale.ShiftedCategoryPosition;
+return bHasComplexCategories || rSourceScale.ShiftedCategoryPosition 
|| m_bChartTypeUsesShiftedCategoryPositionPerDefault;
 
 if (rSourceScale.AxisType == AxisType::DATE)
 return rSourceScale.ShiftedCategoryPosition;


[Libreoffice-commits] dev-tools.git: flatpak/build.sh

 flatpak/build.sh |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit cd86424a47e358335e108f3aa26565e3a2e3143c
Author: Michael Stahl 
AuthorDate: Fri Nov 5 21:38:05 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 10 15:55:31 2021 +0100

flatpak: document that build.sh is obsolete

Change-Id: Ic60bef3cea601ee963100137245ba1041b959d2d
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/124781
Tested-by: Stephan Bergmann 
Reviewed-by: Stephan Bergmann 

diff --git a/flatpak/build.sh b/flatpak/build.sh
index da677e7..7beafb9 100755
--- a/flatpak/build.sh
+++ b/flatpak/build.sh
@@ -4,6 +4,13 @@
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
+###
+#   WARNING   #
+###
+# this script is obsolete - flatpak is built with #
+# https://github.com/flathub/org.libreoffice.LibreOffice/ #
+###
+
 # This shell script creates a LibreOffice.flatpak bundle from a given git
 # branch/tag.
 #


[Libreoffice-commits] core.git: external/openldap

 external/openldap/openldap-2.4.44.patch.1 |   12 
 1 file changed, 12 insertions(+)

New commits:
commit 34b586dc84b810eece7ae08b4028caba78db319f
Author: Tor Lillqvist 
AuthorDate: Wed Nov 10 13:36:43 2021 +0200
Commit: Stephan Bergmann 
CommitDate: Wed Nov 10 15:54:29 2021 +0100

Add forward declaration to openldap to fix compilation with current Xcode

For some reason the warning about this undeclared function is treated
as an error by the Clang version in current Xcode, at least for me,
even if openldap isn't compiled with -Werror.

Change-Id: Ic8479ca63031319ce55c6fb9d95132019ae82cae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124959
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/openldap/openldap-2.4.44.patch.1 
b/external/openldap/openldap-2.4.44.patch.1
index 0d3cf5b70c3f..317ef9a62e56 100644
--- a/external/openldap/openldap-2.4.44.patch.1
+++ b/external/openldap/openldap-2.4.44.patch.1
@@ -1,3 +1,4 @@
+-*- Mode: diff -*-
 --- openldap.org/configure
 +++ openldap/configure
 @@ -15735,7 +15735,7 @@
@@ -52,6 +53,17 @@
  
  #undef NSS_VERSION_INT
  #define   NSS_VERSION_INT ((NSS_VMAJOR << 24) | (NSS_VMINOR << 16) | \
+--- openldap.org/libraries/libldap/tls2.c
 openldap.org/libraries/libldap/tls2.c
+@@ -80,6 +80,8 @@
+   { BER_BVNULL, BER_BVNULL }
+ };
+ 
++int ldap_pvt_tls_check_hostname( LDAP *ld, void *s, const char *name_in );
++
+ #ifdef HAVE_TLS
+ 
+ void
 --- openldap.org/Makefile.in
 +++ openldap/Makefile.in
 @@ -13,7 +13,7 @@


[Libreoffice-commits] core.git: vcl/qt5

 vcl/qt5/QtFrame.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 373b27e7038cf4010a04163861ebec48984b4353
Author: Jan-Marek Glogowski 
AuthorDate: Wed Nov 10 12:18:39 2021 +0100
Commit: Jan-Marek Glogowski 
CommitDate: Wed Nov 10 15:35:12 2021 +0100

tdf#145508 Qt NONE-frames should still be windows

This drops the newly "&& (nStyle != SalFrameStyleFlags::NONE))"
introduced in the regressing commit
e4abf879f4a24258bcc560eb58ca78b147768d46 ("tdf#145363 Qt popups
actually are windows").

A GtkBox based UI snippet, like vcl/uiconfig/ui/combobox.ui, IMHO
shoulden't be represented as a Qt::Window, but a Qt::Widget. But
there is no real way to identify it, so lets keep the old, working
code.

Change-Id: Ic41ff15ab651b422ee95c906cac67e37be8d8a65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124958
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/qt5/QtFrame.cxx b/vcl/qt5/QtFrame.cxx
index 1ae4016d589d..591e084edf38 100644
--- a/vcl/qt5/QtFrame.cxx
+++ b/vcl/qt5/QtFrame.cxx
@@ -138,7 +138,7 @@ QtFrame::QtFrame(QtFrame* pParent, SalFrameStyleFlags 
nStyle, bool bUseCairo)
 m_pParent = pParent;
 
 Qt::WindowFlags aWinFlags(Qt::Widget);
-if (!(nStyle & SalFrameStyleFlags::SYSTEMCHILD) && (nStyle != 
SalFrameStyleFlags::NONE))
+if (!(nStyle & SalFrameStyleFlags::SYSTEMCHILD))
 {
 if (nStyle & SalFrameStyleFlags::INTRO)
 aWinFlags = Qt::SplashScreen;


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-1+backports' - download.lst

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3b9341561fb6f3f9fff0caa084db47698912
Author: Michael Stahl 
AuthorDate: Tue Nov 9 12:35:04 2021 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 10 15:20:25 2021 +0100

openldap: upgrade to release 2.4.59

Fixes CVE-2020-36230 and CVE-2020-36229 in libldap, plus lots of
other CVEs that affect only the server.

Unfortunately it looks like NSS support was removed in release 2.5.0.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124914
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 9393325c1db9fa25037d208607b71adb567a8bbc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124860
Reviewed-by: Caolán McNamara 
(cherry picked from commit b7c670984e4af1c73fa05731ca8029cec487bd52)

Change-Id: Ie43d7da1b9e92b5712f9cd22c4613648394c696f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124954
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index 70e9db0f6772..6b7ca934ab43 100644
--- a/download.lst
+++ b/download.lst
@@ -190,8 +190,8 @@ export ODFVALIDATOR_SHA256SUM := 
702413413a5d8076c17fe79c0808dfba145a7260020f6c8
 export ODFVALIDATOR_JAR := 
odfvalidator-1.2.0-incubating-SNAPSHOT-jar-with-dependencies+ODFTOOLKIT-460+ODFTOOLKIT-475.jar
 export OFFICEOTRON_SHA256SUM := 
f2443f27561af52324eee03a1892d9f569adc8db9e7bca55614898bc2a13a770
 export OFFICEOTRON_JAR := 
8249374c274932a21846fa7629c2aa9b-officeotron-0.7.4-master.jar
-export OPENLDAP_SHA256SUM := 
cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb897cd5626df3824
-export OPENLDAP_TARBALL := openldap-2.4.45.tgz
+export OPENLDAP_SHA256SUM := 
99f37d6747d88206c470067eda624d5e48c1011e943ec0ab217bae8712e22f34
+export OPENLDAP_TARBALL := openldap-2.4.59.tgz
 export OPENSSL_SHA256SUM := 
ae51d08bba8a83958e894946f15303ff894d75c2b8bbd44a852b64e3fe11d0d6
 export OPENSSL_TARBALL := openssl-1.0.2r.tar.gz
 export ORCUS_SHA256SUM := 
bc01b1b3e9091416f498840d3c19a1aa2704b448100e7f6b80eefe88aab06d5b


[Libreoffice-commits] core.git: libreofficekit/qa

 libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 8e08fb9476c1b13937ac6d1148b7f675a2e327ad
Author: Stephan Bergmann 
AuthorDate: Wed Nov 10 12:46:49 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 10 14:36:39 2021 +0100

Avoid -Werror=maybe-uninitialized

...with recent GCC 12 trunk,

> libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx:194:31: error: 
‘unoParam’ may be used uninitialized [-Werror=maybe-uninitialized]
>   194 | gchar* pPath = g_strconcat(unoParam[1], "/", "type", nullptr);
>   |~~~^~~

Change-Id: Ia7ac20ac63b995e8f4a8b4c79447799972639588
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124961
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx 
b/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx
index be7cd4445536..e7208e5860a3 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.cxx
@@ -16,6 +16,7 @@
 
 #include 
 
+#include 
 #include 
 #include 
 
@@ -186,8 +187,9 @@ static void iterateUnoParams(GtkWidget* pWidget, gpointer 
userdata)
 GList* pIt = nullptr;
 guint i = 0;
 const gchar* unoParam[3];
-for (pIt = pChildren.get(), i = 0; pIt != nullptr && i < 3; pIt = 
pIt->next, i++)
+for (pIt = pChildren.get(), i = 0; i < 3; pIt = pIt->next, i++)
 {
+assert(pIt != nullptr);
 unoParam[i] = gtk_entry_get_text(GTK_ENTRY(pIt->data));
 }
 


[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 358754cc5d36eaecda7c704d588b33a3fdf7803c
Author: Alain Romedenne 
AuthorDate: Wed Nov 10 15:24:42 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 10 14:24:42 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 60560093b76da08195ad1b1dc7bbd17ee2cfb333
  - New methods in sf_Base, (sf_Calc,) sf_Doc. and sf_Writer services

- PrintOut
- SetPrinter

Change-Id: I809797247ce50c9a74ec8c1c703722911c687993
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124194
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index a75eb717488b..60560093b76d 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit a75eb717488b9b5ca9612342e62e4af43aa50a4b
+Subproject commit 60560093b76da08195ad1b1dc7bbd17ee2cfb333


[Libreoffice-commits] help.git: source/text

 source/text/sbasic/shared/03/sf_base.xhp |   65 +++--
 source/text/sbasic/shared/03/sf_document.xhp |   70 +--
 source/text/sbasic/shared/03/sf_writer.xhp   |9 ++-
 3 files changed, 133 insertions(+), 11 deletions(-)

New commits:
commit 60560093b76da08195ad1b1dc7bbd17ee2cfb333
Author: Alain Romedenne 
AuthorDate: Wed Oct 27 10:33:15 2021 +0200
Commit: Rafael Lima 
CommitDate: Wed Nov 10 14:24:41 2021 +0100

New methods in sf_Base, (sf_Calc,) sf_Doc. and sf_Writer services

- PrintOut
- SetPrinter

Change-Id: I809797247ce50c9a74ec8c1c703722911c687993
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124194
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/source/text/sbasic/shared/03/sf_base.xhp 
b/source/text/sbasic/shared/03/sf_base.xhp
index d78a60854..16c0f61a1 100644
--- a/source/text/sbasic/shared/03/sf_base.xhp
+++ b/source/text/sbasic/shared/03/sf_base.xhp
@@ -36,7 +36,6 @@
 Check if a form 
document from a Base document is currently loaded.
 
 
-  
 
 
   Refer to the Document service to learn more about methods 
and properties that can be used to manage %PRODUCTNAME documents.
@@ -85,18 +84,20 @@

  CloseFormDocument
  FormDocuments
+ Forms




- Forms
  GetDatabase
+ IsLoaded
+ OpenFormDocument




- IsLoaded
- OpenFormDocument
+ PrintOut
+ SetPrinter



@@ -301,6 +302,62 @@
   
 
 
+
+   PrintOut 
 
+  
+Base service;PrintOut
+  
+  PrintOut
+  This method sends the 
content of the given form document to a default printer or a printer defined by 
the SetPrinter() method.
+  Returns 
True if the document was successfully printed.
+  
+  
+svc.PrintOut(opt formdocument: str, pages: str = "", copies: num = 
1): bool
+  
+  
+  formdocument: A valid document form 
name as a case-sensitive string. The form document must be open. It is 
activated by the method.
+  pages: 
The pages to print as a string, like in the user interface. Example: 
"1-4;10;15-18". Default is all pages.
+  copies: The number of 
copies. Default is 1.
+  
+  
+  
+If 
oDoc.PrintOut("myForm", "1-4;10;15-18", Copies := 2) Then
+
' ...
+End 
If
+  
+  
+  
+if 
doc.PrintOut('myForm', copies=3, pages='45-88'):
+# 
...
+  
+
+
+
+   SetPrinter 
--- 
+  
+Base service;SetPrinter
+  
+  SetPrinter
+  Define the printer 
options for a form document. The form document must be open.
+  Returns 
True when successful.
+  
+  
+svc.SetPrinter(opt formdocument: str, opt printer: str, opt 
orientation: str, paperformat: str): bool
+  
+  
+  formdocument: A valid document form 
name as a case-sensitive string.
+  
+  
+  
+  
+oDoc.SetPrinter("myForm", Orientation := 
"PORTRAIT")
+  
+  
+  
+doc.SetPrinter('myForm', 
paperformat='TABLOID')
+  
+
+
   
   
 
diff --git a/source/text/sbasic/shared/03/sf_document.xhp 
b/source/text/sbasic/shared/03/sf_document.xhp
index c4e0bafd2..778e612a8 100644
--- a/source/text/sbasic/shared/03/sf_document.xhp
+++ b/source/text/sbasic/shared/03/sf_document.xhp
@@ -294,18 +294,20 @@

  Activate
  CloseDocument
+ PrintOut




  RunCommand
- Save
+ Save
+ SaveAs




- SaveAs
- SaveCopyAs
+ SaveCopyAs
+ SetPrinter



@@ -349,7 +351,7 @@
   The method will also 
return False if the user declines to close it.
   Returns 
True if the document was successfully closed.
   
-  
+  
 svc.CloseDocument(saveask: bool = True): bool
   
   
@@ -357,7 +359,7 @@
   
   
   
-If 
oDoc.CloseDocument(True) Then
+If 
oDoc.CloseDocument(True) Then
 ' 
...
 End 
If
   
@@ -368,6 +370,35 @@
   
 
 
+
+   PrintOut 
 
+  
+Document service;PrintOut
+  
+  PrintOut
+  This method sends the 
content of the document to a default printer or a printer defined by the 
SetPrinter method.
+  Returns 
True if the document was successfully printed.
+  
+  
+svc.PrintOut(pages: str = "", copies: num = 1): bool
+  
+  
+  pages: 
The pages to print as a string, like in the user interface. Example: 
"1-4;10;15-18". Default is all pages.
+  copies: The number of 
copies. Default is 1.
+  
+  
+  
+If 
oDoc.PrintOut("1-4;10;15-18", Copies := 2) Then
+
' ...
+End 
If
+  
+  
+  
+if 
doc.PrintOut(copies=3, pages='45-88'):
+# 
...
+  
+
+
 

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e4496292f0d67709340879180393c573aeebf93
Author: Olivier Hallot 
AuthorDate: Wed Nov 10 14:39:25 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 10 13:39:25 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to a75eb717488b9b5ca9612342e62e4af43aa50a4b
  - Fix path in link for func_sum.xhp

Change-Id: I9ed44d1d28c8c437d5e20448fe0f389e6940b015
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124866
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 49c7e92b634f..a75eb717488b 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 49c7e92b634f2bb9d054bd791a1317b9699c093f
+Subproject commit a75eb717488b9b5ca9612342e62e4af43aa50a4b


[Libreoffice-commits] help.git: source/text

 source/text/scalc/01/func_sum.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a75eb717488b9b5ca9612342e62e4af43aa50a4b
Author: Olivier Hallot 
AuthorDate: Wed Nov 10 14:22:57 2021 +0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 10 13:39:23 2021 +0100

Fix path in link for func_sum.xhp

Change-Id: I9ed44d1d28c8c437d5e20448fe0f389e6940b015
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124866
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/func_sum.xhp 
b/source/text/scalc/01/func_sum.xhp
index 389c0bcc4..04003fb75 100644
--- a/source/text/scalc/01/func_sum.xhp
+++ b/source/text/scalc/01/func_sum.xhp
@@ -22,7 +22,7 @@
   SUM function
   adding;numbers in cell ranges
 
-SUM
+SUM
 Adds a set of 
numbers.
   
 


[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b3e3bcb49d7c378deb389e33d568bc3443810004
Author: Alain Romedenne 
AuthorDate: Wed Nov 10 14:37:05 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 10 13:37:05 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 49c7e92b634f2bb9d054bd791a1317b9699c093f
  - New method in sf_Calc service

- PrintOut()

Change-Id: Iff97f5fb8585b8c70d4837bdba5eb5ee30852b4d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124484
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index 99120cbfb9b5..49c7e92b634f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 99120cbfb9b5c0c75bc1b3317fa87ecab58d170a
+Subproject commit 49c7e92b634f2bb9d054bd791a1317b9699c093f


[Libreoffice-commits] help.git: source/text

 source/text/sbasic/shared/03/sf_calc.xhp |   31 +++
 1 file changed, 31 insertions(+)

New commits:
commit 49c7e92b634f2bb9d054bd791a1317b9699c093f
Author: Alain Romedenne 
AuthorDate: Wed Nov 3 17:29:08 2021 +0200
Commit: Rafael Lima 
CommitDate: Wed Nov 10 13:37:03 2021 +0100

New method in sf_Calc service

- PrintOut()

Change-Id: Iff97f5fb8585b8c70d4837bdba5eb5ee30852b4d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124484
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/source/text/sbasic/shared/03/sf_calc.xhp 
b/source/text/sbasic/shared/03/sf_calc.xhp
index 79c3060ae..7c7148cb4 100644
--- a/source/text/sbasic/shared/03/sf_calc.xhp
+++ b/source/text/sbasic/shared/03/sf_calc.xhp
@@ -482,6 +482,7 @@
  MoveRange
  MoveSheet
  Offset
+ PrintOut
  RemoveSheet
  RenameSheet
  SetArray
@@ -1238,6 +1239,36 @@
   
 
 
+
+   PrintOut 
 
+  
+Calc service;PrintOut
+  
+  PrintOut
+  This method sends the 
content of the given sheet to a default printer or a printer defined by the 
SetPrinter() method of the Document 
Service.
+  Returns 
True if the sheet was successfully printed.
+  
+  
+svc.PrintOut(opt sheetname: str, pages: str = "", copies: num = 1): 
bool
+  
+  
+  sheetname: The sheet to print, default 
is the active sheet.
+  pages: 
The pages to print as a string, like in the user interface. Example: 
"1-4;10;15-18". Default is all pages.
+  copies: The number of 
copies. Default is 1.
+  
+  
+  
+If 
oDoc.PrintOut("SheetX", "1-4;10;15-18", Copies := 2) Then
+
' ...
+End 
If
+  
+  
+  
+if 
doc.PrintOut('SheetX', copies=3, pages='45-88'):
+# 
...
+  
+
+
 
RemoveSheet 
--
 
   


[Libreoffice-commits] core.git: config_host.mk.in configure.ac download.lst external/boost

 config_host.mk.in  |1 
 configure.ac   |   17 +
 download.lst   |4 -
 external/boost/0001-Fix-include-inside-boost-namespace.patch.2 |   33 
--
 external/boost/StaticLibrary_boost_filesystem.mk   |5 +
 external/boost/UnpackedTarball_boost.mk|3 
 6 files changed, 25 insertions(+), 38 deletions(-)

New commits:
commit 13e0b122f100a17fa54757e40dd8b334559522a6
Author: Stephan Bergmann 
AuthorDate: Wed Nov 10 08:11:30 2021 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Nov 10 13:33:48 2021 +0100

Upgrade external/boost to latest Boost 1.77.0

 has been 
generated (on
Fedora 35) with

> $ wget 
https://boostorg.jfrog.io/artifactory/main/release/1.77.0/source/boost_1_77_0.tar.bz2
> $ printf 
'fc9f85fc030e233142908241af7a846e60630aa7388de9a5fafb1f3a26840854 
boost_1_77_0.tar.bz2' | sha256sum -c # cf. 

> boost_1_77_0.tar.bz2: OK
> $ external/boost/repack_tarball.sh boost_1_77_0.tar.bz2
> Unpacking boost_1_77_0.tar.bz2 ...
> Removing unnecessary files ...
> Creating boost_1_77_0.tar.xz ...
> Cleaning up ...
> 9b334d6c6d7af5a0687280788cd8398b8e0b472cd88e52bbc3c3ef11d98e  
boost_1_77_0.tar.xz
> Done.

Change-Id: I527cad7eb2f311d968da371f268644bdd31f6462
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124947
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/config_host.mk.in b/config_host.mk.in
index ab5cca977dd3..ec22f695d782 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -268,6 +268,7 @@ export HAMCREST_JAR=@HAMCREST_JAR@
 export 
HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED=@HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED@
 export HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW=@HAVE_BROKEN_GCC_WSTRINGOP_OVERFLOW@
 export 
HAVE_CLANG_DEBUG_INFO_KIND_CONSTRUCTOR=@HAVE_CLANG_DEBUG_INFO_KIND_CONSTRUCTOR@
+export HAVE_CXX20_ATOMIC_REF=@HAVE_CXX20_ATOMIC_REF@
 export HAVE_DLLEXPORTINLINES=@HAVE_DLLEXPORTINLINES@
 export HAVE_LO_CLANG_DLLEXPORTINLINES=@HAVE_LO_CLANG_DLLEXPORTINLINES@
 export HAVE_GCC_AVX=@HAVE_GCC_AVX@
diff --git a/configure.ac b/configure.ac
index c5b3a1ea116f..a894323e2881 100644
--- a/configure.ac
+++ b/configure.ac
@@ -7437,6 +7437,23 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([
 CXXFLAGS=$save_CXXFLAGS
 AC_LANG_POP([C++])
 
+AC_MSG_CHECKING([whether $CXX_BASE supports C++20 std::atomic_ref])
+HAVE_CXX20_ATOMIC_REF=
+AC_LANG_PUSH([C++])
+save_CXXFLAGS=$CXXFLAGS
+CXXFLAGS="$CXXFLAGS $CXXFLAGS_CXX11"
+AC_COMPILE_IFELSE([AC_LANG_SOURCE([
+#include 
+int x;
+std::atomic_ref y(x);
+])], [
+HAVE_CXX20_ATOMIC_REF=TRUE
+AC_MSG_RESULT([yes])
+], [AC_MSG_RESULT([no])])
+CXXFLAGS=$save_CXXFLAGS
+AC_LANG_POP([C++])
+AC_SUBST([HAVE_CXX20_ATOMIC_REF])
+
 dnl Supported since GCC 9 and Clang 10 (which each also started to support 
-Wdeprecated-copy, but
 dnl which is included in -Wextra anyway):
 HAVE_WDEPRECATED_COPY_DTOR=
diff --git a/download.lst b/download.lst
index ad912f844776..f0d5bfcdc2b9 100644
--- a/download.lst
+++ b/download.lst
@@ -10,8 +10,8 @@ export APR_TARBALL := apr-1.5.2.tar.gz
 export APR_UTIL_SHA256SUM := 
976a12a59bc286d634a21d7be0841cc74289ea9077aa1af46be19d1a6e844c19
 export APR_UTIL_TARBALL := apr-util-1.5.4.tar.gz
 # please repack the tarball using external/boost/repack_tarball.sh
-export BOOST_SHA256SUM := 
adfa0ca971c56006a8304b6146d1382e6369815d568f6e6a7440fe29995d51b8
-export BOOST_TARBALL := boost_1_76_0.tar.xz
+export BOOST_SHA256SUM := 
9b334d6c6d7af5a0687280788cd8398b8e0b472cd88e52bbc3c3ef11d98e
+export BOOST_TARBALL := boost_1_77_0.tar.xz
 export BOX2D_SHA256SUM := 
58ffc8475a8650aadc351345aef696937747b40501ab78d72c197c5ff5b3035c
 export BOX2D_TARBALL := box2d-2.3.1.tar.gz
 export BREAKPAD_SHA256SUM := 
c44a2e898895cfc13b42d2371ba4b88b0777d7782214d6cdc91c33720f3b0d91
diff --git a/external/boost/0001-Fix-include-inside-boost-namespace.patch.2 
b/external/boost/0001-Fix-include-inside-boost-namespace.patch.2
deleted file mode 100644
index ce123dbb4453..
--- a/external/boost/0001-Fix-include-inside-boost-namespace.patch.2
+++ /dev/null
@@ -1,33 +0,0 @@
-From 1ec5c98d80de97f9e962c5627e1a0e6096099894 Mon Sep 17 00:00:00 2001
-From: Daniel Scharrer 
-Date: Wed, 28 Jul 2021 19:56:31 +0200
-Subject: [PATCH] Fix #include inside boost namespace
-
-The existing code fails to build if  was not already included.

- include/boost/math/tools/mp.hpp | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/include/boost/math/tools/mp.hpp b/include/boost/math/tools/mp.hpp
-index 35565646f..dc8440988 100644
 a/include/boost/math/tools/mp.hpp
-+++ b/include/boost/math/tools/mp.hpp
-@@ -13,6 +13,7 @@
- 
- #include 
- #inc

[Libreoffice-commits] core.git: helpcontent2

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c88c22530eb2ef87986a7c3c8f0f21ac16e508fa
Author: Steve Fanning 
AuthorDate: Wed Nov 10 14:22:09 2021 +0200
Commit: Gerrit Code Review 
CommitDate: Wed Nov 10 13:22:09 2021 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 99120cbfb9b5c0c75bc1b3317fa87ecab58d170a
  - Update help page for Calc's Mathematical Functions to remove detail 
about SUM() function.

Leave just a link and a one line overview. This is a follow-up to 
change https://gerrit.libreoffice.org/c/help/+/124696.

Change-Id: I31898c9f8d1fc0dca83a7d3fc12d466a3d50928c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124865
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 9077a2887221..99120cbfb9b5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 9077a2887221677690282917c66c7af8e3e37121
+Subproject commit 99120cbfb9b5c0c75bc1b3317fa87ecab58d170a


[Libreoffice-commits] help.git: source/text

 source/text/scalc/01/04060106.xhp |   24 +++-
 1 file changed, 3 insertions(+), 21 deletions(-)

New commits:
commit 99120cbfb9b5c0c75bc1b3317fa87ecab58d170a
Author: Steve Fanning 
AuthorDate: Wed Nov 10 13:14:38 2021 +0200
Commit: Olivier Hallot 
CommitDate: Wed Nov 10 13:22:08 2021 +0100

Update help page for Calc's Mathematical Functions to remove detail about 
SUM() function.

Leave just a link and a one line overview. This is a follow-up to change 
https://gerrit.libreoffice.org/c/help/+/124696.

Change-Id: I31898c9f8d1fc0dca83a7d3fc12d466a3d50928c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124865
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/01/04060106.xhp 
b/source/text/scalc/01/04060106.xhp
index a245b9d28..c04614745 100644
--- a/source/text/scalc/01/04060106.xhp
+++ b/source/text/scalc/01/04060106.xhp
@@ -1017,27 +1017,9 @@
 
 
 
-
-
-  SUM function
-  adding;numbers in cell ranges
-
-mw added one entry
-
-
-SUM
-Adds a set of numbers.
-
-
-SUM()
-
-
-
-=SUM(2;3;4) returns 9.
-=SUM(A1;A3;B5) calculates the sum of the three 
cells.
-=SUM(A1:E10) calculates the sum of all cells in the A1 to 
E10 cell range.
-A formula such 
as =SUM((A1:A40>=C1)*(A1:A40SUM wiki page for more details about this function.
+
+  
+  
 
 
 


[Libreoffice-commits] core.git: Changes to 'refs/tags/cib-6.1-27'

Tag 'cib-6.1-27' created by Thorsten Behrens  
at 2021-11-10 12:12 +

Release LibreOffice powered by CIB 6.1-27
-BEGIN PGP SIGNATURE-

iQKTBAABCgB9FiEEF13c36gxow74AXmeM3dpmHHuF/gFAmGLtzRfFIAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE3
NUREQ0RGQTgzMUEzMEVGODAxNzk5RTMzNzc2OTk4NzFFRTE3RjgACgkQM3dpmHHu
F/gMsg/+IwS58wrKnfMFh7iJeT09TwGXRjVR1ILf4DZ0f+Bx4OKnPGjQSVDkLyO9
bWv+K+6Jd41R7DsdaCt6ML/yl+u6vrLhzQji9Dih3p65miY27BVTFLrA17gNMQZD
DL2Zj4LYW49QxNYwTwSHglmE0RUNAjwPHd6uP6JIysnlQFvPC1CDSw4TYsr8sN7g
FMvGvKpMttJpO2uHO6MiOrPYhVOCSg2NahSxteWi+IG0oB+BsetUIpCAi1SZVwhf
YtJsQOnuOeR0e2rRTDyuo8jxMOrc/+0uEuf92P8k9w2jKVftQoRKlzkAeOTG5Apw
qfHm6mixdpFZ7f2I2GLqem4u2s3DpYxTMjticq89DzQC8cdCZEdqATL/HHbbGDG5
/G+OFgJ11Yl1rf+hQg1YCs4CdKleMY9eomZMU8Pvu6WpQTbHT02l21ksrteh4jBW
+fOX13CCFK2WMB5L0FIVpe/VUH+SMLvvQ9FeXoWNN60upawHAeAdwxzO0ueQON8t
q7Sxic2xEQobfFsChEDl3/Fa5GNFr4bUP8YNKkTngB7/yBwUfHzxnpM1T7LXNePR
R7d7uXJzQcLV+KVVDQJ34q5KedpN3rZgblAFVXEJdGTpzaIxPyJxUw69FvxT/hqD
aMNsEGMbrp67NcHCDtQZJYP8ioswjzxF9Sp/QtKm+q0r3BcNKqQ=
=8K7y
-END PGP SIGNATURE-

Changes since cib-6.1-26-8:
---
 0 files changed
---


[Libreoffice-commits] core.git: editeng/source i18nlangtag/source

 editeng/source/uno/unotext2.cxx|1 
 i18nlangtag/source/languagetag/languagetag.cxx |  107 -
 2 files changed, 53 insertions(+), 55 deletions(-)

New commits:
commit b5758cb2729236d9eaf52bd25b1b113a3ff06b4e
Author: Noel Grandin 
AuthorDate: Tue Nov 9 19:06:53 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 10 12:23:30 2021 +0100

rtl::Static to thread-safe static

Change-Id: Ie4c26b0b2c0880bcf6ec6d786b219f142d715af5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124930
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/editeng/source/uno/unotext2.cxx b/editeng/source/uno/unotext2.cxx
index 12b56ca4c68e..00b123468a5a 100644
--- a/editeng/source/uno/unotext2.cxx
+++ b/editeng/source/uno/unotext2.cxx
@@ -24,7 +24,6 @@
 
 #include 
 #include 
-#include 
 
 #include 
 #include 
diff --git a/i18nlangtag/source/languagetag/languagetag.cxx 
b/i18nlangtag/source/languagetag/languagetag.cxx
index 6f6a766e861f..83d730f5fc5f 100644
--- a/i18nlangtag/source/languagetag/languagetag.cxx
+++ b/i18nlangtag/source/languagetag/languagetag.cxx
@@ -18,7 +18,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -50,42 +49,32 @@ struct myLtError
 };
 
 // "static" to be returned as const reference to an empty locale.
-struct theEmptyLocale : public rtl::Static< lang::Locale, theEmptyLocale > {};
-}
+const lang::Locale theEmptyLocale;
 
 typedef std::unordered_set< OUString > KnownTagSet;
-namespace {
-struct theKnowns : public rtl::Static< KnownTagSet, theKnowns > {};
-struct theMutex : public rtl::Static< osl::Mutex, theMutex > {};
-}
 
-static const KnownTagSet & getKnowns()
+const KnownTagSet & getKnowns()
 {
-KnownTagSet & rKnowns = theKnowns::get();
-if (rKnowns.empty())
+static KnownTagSet theKnowns = []()
 {
-osl::MutexGuard aGuard( theMutex::get());
-if (rKnowns.empty())
+KnownTagSet ret;
+::std::vector< MsLangId::LanguagetagMapping > aDefined( 
MsLangId::getDefinedLanguagetags());
+for (auto const& elemDefined : aDefined)
 {
-::std::vector< MsLangId::LanguagetagMapping > aDefined( 
MsLangId::getDefinedLanguagetags());
-for (auto const& elemDefined : aDefined)
+// Do not use the BCP47 string here to initialize the
+// LanguageTag because then canonicalize() would call this
+// getKnowns() again...
+::std::vector< OUString > aFallbacks( LanguageTag( 
elemDefined.mnLang).getFallbackStrings( true));
+for (auto const& fallback : aFallbacks)
 {
-// Do not use the BCP47 string here to initialize the
-// LanguageTag because then canonicalize() would call this
-// getKnowns() again...
-::std::vector< OUString > aFallbacks( LanguageTag( 
elemDefined.mnLang).getFallbackStrings( true));
-for (auto const& fallback : aFallbacks)
-{
-rKnowns.insert(fallback);
-}
+ret.insert(fallback);
 }
 }
-}
-return rKnowns;
+return ret;
+}();
+return theKnowns;
 }
 
-
-namespace {
 struct compareIgnoreAsciiCaseLess
 {
 bool operator()( const OUString& r1, std::u16string_view r2 ) const
@@ -95,17 +84,23 @@ struct compareIgnoreAsciiCaseLess
 };
 typedef ::std::map< OUString, LanguageTag::ImplPtr, compareIgnoreAsciiCaseLess 
> MapBcp47;
 typedef ::std::map< LanguageType, LanguageTag::ImplPtr > MapLangID;
-struct theMapBcp47 : public rtl::Static< MapBcp47, theMapBcp47 > {};
-struct theMapLangID : public rtl::Static< MapLangID, theMapLangID > {};
-struct theDontKnow : public rtl::Static< LanguageTag::ImplPtr, theDontKnow > 
{};
-struct theSystemLocale : public rtl::Static< LanguageTag::ImplPtr, 
theSystemLocale > {};
+MapBcp47 theMapBcp47;
+MapLangID theMapLangID;
+LanguageTag::ImplPtr theDontKnow;
+LanguageTag::ImplPtr theSystemLocale;
+osl::Mutex& theMutex()
+{
+static osl::Mutex SINGLETON;
+return SINGLETON;
+}
+
 }
 
 
 static LanguageType getNextOnTheFlyLanguage()
 {
 static LanguageType nOnTheFlyLanguage(0);
-osl::MutexGuard aGuard( theMutex::get());
+osl::MutexGuard aGuard(theMutex());
 if (!nOnTheFlyLanguage)
 nOnTheFlyLanguage = MsLangId::makeLangID( 
LANGUAGE_ON_THE_FLY_SUB_START, LANGUAGE_ON_THE_FLY_START);
 else
@@ -171,7 +166,11 @@ private:
 static void teardown();
 };
 
-struct theDataRef : public rtl::Static< LiblangtagDataRef, theDataRef > {};
+LiblangtagDataRef& theDataRef()
+{
+static LiblangtagDataRef SINGLETON;
+return SINGLETON;
+}
 }
 
 LiblangtagDataRef::LiblangtagDataRef()
@@ -429,7 +428,7 @@ LanguageTagImpl::LanguageTagImpl( const LanguageTagImpl & 
rLanguageTagImpl )
 mbCachedGlibcString( rLanguageTagImpl.mbCachedGlibcString)
 {
 if (mpImplLangtag)
-theDataRef::get().init();
+the

[Libreoffice-commits] core.git: drawinglayer/source

 drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx |   14 ++---
 1 file changed, 7 insertions(+), 7 deletions(-)

New commits:
commit c606d330864a10caba6e0f9600db56ae445999c1
Author: Noel Grandin 
AuthorDate: Tue Nov 9 18:50:02 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 10 12:23:00 2021 +0100

osl::Mutex->std::mutex in TubeBuffer

Change-Id: I3e2ef9f8b34cbc5befe8b19fa2d68dfd518090c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124929
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx 
b/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
index 645958ae6a29..8065ad73e54f 100644
--- a/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
+++ b/drawinglayer/source/primitive3d/polygontubeprimitive3d.cxx
@@ -25,7 +25,7 @@
 #include 
 #include 
 #include 
-
+#include 
 
 namespace drawinglayer::primitive3d
 {
@@ -38,7 +38,7 @@ namespace drawinglayer::primitive3d
 Primitive3DContainer m_aLineTubeList;
 sal_uInt32 m_nLineTubeSegments;
 attribute::MaterialAttribute3D m_aLineMaterial;
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 public:
 TubeBuffer()
 : m_nLineTubeSegments(0)
@@ -53,7 +53,7 @@ namespace drawinglayer::primitive3d
 const attribute::MaterialAttribute3D& rMaterial)
 {
 // may exclusively change cached data, use mutex
-::osl::MutexGuard aGuard(m_aMutex);
+std::unique_lock aGuard(m_aMutex);
 
 if (nSegments != m_nLineTubeSegments || !(rMaterial == 
m_aLineMaterial))
 {
@@ -120,7 +120,7 @@ namespace drawinglayer::primitive3d
 Primitive3DContainer m_aLineCapList;
 sal_uInt32 m_nLineCapSegments;
 attribute::MaterialAttribute3D m_aLineMaterial;
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 public:
 CapBuffer()
 : m_nLineCapSegments(0)
@@ -134,7 +134,7 @@ namespace drawinglayer::primitive3d
 const attribute::MaterialAttribute3D& rMaterial)
 {
 // may exclusively change cached data, use mutex
-::osl::MutexGuard aGuard(m_aMutex);
+std::unique_lock aGuard(m_aMutex);
 
 if (nSegments != m_nLineCapSegments || !(rMaterial == 
m_aLineMaterial))
 {
@@ -195,7 +195,7 @@ namespace drawinglayer::primitive3d
 Primitive3DContainer m_aLineCapRoundList;
 sal_uInt32 m_nLineCapRoundSegments;
 attribute::MaterialAttribute3D m_aLineMaterial;
-::osl::Mutex m_aMutex;
+std::mutex m_aMutex;
 public:
 CapRoundBuffer()
 : m_nLineCapRoundSegments(0)
@@ -209,7 +209,7 @@ namespace drawinglayer::primitive3d
 const attribute::MaterialAttribute3D& rMaterial)
 {
 // may exclusively change cached data, use mutex
-::osl::MutexGuard aGuard(m_aMutex);
+std::unique_lock aGuard(m_aMutex);
 
 if (nSegments != m_nLineCapRoundSegments || !(rMaterial == 
m_aLineMaterial))
 {


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - configure.ac

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 356e43b08d2b4872213fb31ea5a8138c58bf8038
Author: Andras Timar 
AuthorDate: Wed Nov 10 12:21:06 2021 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:21:06 2021 +0100

Bump version to 7.0.7.0.M7

Change-Id: I94e2a50e6ee2b2f8da30dc18566709af23f0bb00

diff --git a/configure.ac b/configure.ac
index 17b81ded2c63..36e39a8c5109 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([LibreOffice],[7.0.7.0.M6],[],[],[http://documentfoundation.org/])
+AC_INIT([LibreOffice],[7.0.7.0.M7],[],[],[http://documentfoundation.org/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - vcl/source

 vcl/source/window/printdlg.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit efff6686073c458864d807e72f733ac32ba8e817
Author: Tor Lillqvist 
AuthorDate: Tue Nov 9 13:37:33 2021 +0200
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:19:34 2021 +0100

tdf#145354: Don't let an arbitrary paper size match any other arbitrary size

Don't preselect whatever random paper size the printer driver offers
last if the document is asking for some other random paper size.

Change-Id: I57af245f28f0d61541da698844f2527be5ec004e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124911
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124926
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 413cf86a8bbc..9b7a7cebf793 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -850,6 +850,7 @@ void PrintDialog::setPaperSizes()
 
 VclPtr aPrt( maPController->getPrinter() );
 mePaper = aPrt->GetPaper();
+Size aSizeOfPaper = aPrt->GetSizeOfPaper();
 
 if ( isPrintToFile() )
 {
@@ -888,8 +889,9 @@ void PrintDialog::setPaperSizes()
 
 mxPaperSizeBox->append_text(aPaperName);
 
-if ( ePaper == mePaper )
-mxPaperSizeBox->set_active( nPaper );
+if ( (ePaper != PAPER_USER && ePaper == mePaper) ||
+ (ePaper == PAPER_USER && aInfo.sloppyEqual( 
PaperInfo(aSizeOfPaper.getWidth(), aSizeOfPaper.getHeight())) ) )
+ mxPaperSizeBox->set_active( nPaper );
 }
 
 mxPaperSizeBox->set_sensitive( true );


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - include/vcl vcl/source

 include/vcl/print.hxx|3 +++
 vcl/source/gdi/print.cxx |5 +
 2 files changed, 8 insertions(+)

New commits:
commit 724920d6074abdba210436c625329e395ae1b238
Author: Tor Lillqvist 
AuthorDate: Tue Nov 9 13:16:29 2021 +0200
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:19:10 2021 +0100

Add Printer::GetSizeOfPaper() with semantics to match GetPaper()

Will be used in follow-up commits.

Change-Id: I18b167a217a4f82d8b6605e2ba14f1ddc6e98324
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124910
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124925
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index 5ce81b9a9a27..c65009276a89 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -314,7 +314,10 @@ public:
 sal_uInt16  GetPaperBin() const;
 voidSetPaper( Paper ePaper );
 boolSetPaperSizeUser( const Size& rSize );
+/** @return The paper format of the printer's current "jobsetup". Note 
that if PAPER_USER the actual size can be anything. */
 Paper   GetPaper() const;
+/** @return Size of the paper of the printer's current "jobsetup". */
+SizeGetSizeOfPaper() const;
 static OUString GetPaperName( Paper ePaper );
 
 /** @return Number of available paper formats */
diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx
index e6386ef17048..35de14ee5a73 100644
--- a/vcl/source/gdi/print.cxx
+++ b/vcl/source/gdi/print.cxx
@@ -1462,6 +1462,11 @@ Paper Printer::GetPaper() const
 return maJobSetup.ImplGetConstData().GetPaperFormat();
 }
 
+Size Printer::GetSizeOfPaper() const
+{
+return Size(maJobSetup.ImplGetConstData().GetPaperWidth(), 
maJobSetup.ImplGetConstData().GetPaperHeight());
+}
+
 sal_uInt16 Printer::GetPaperBinCount() const
 {
 if ( IsDisplayPrinter() )


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - vcl/source

 vcl/source/window/printdlg.cxx |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

New commits:
commit bdb261c7076bbe32e390fc889e58acf756bb6576
Author: Tor Lillqvist 
AuthorDate: Wed Nov 3 14:58:45 2021 +0200
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:18:38 2021 +0100

tdf#145354: Don't claim random paper sizes from the system are "User 
Defined"

For instance, the driver for my printer (or maybe Windows itself, no
idea where the list of sizes comes from originally) says it supports
215 x 345 mm. Which apparently is an obscure paper size called "India
Legal". It is confusing if the Print dialog claims that it is "User
Defined" when I have never even heard of such a size, and the document
does not specify it either.

Change-Id: I44196fd21fd83a94d255ebb909e5d63e35c5d1e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124649
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124924
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 250df3916b78..413cf86a8bbc 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -877,7 +877,14 @@ void PrintDialog::setPaperSizes()
 OUString aWidth( rLocWrap.getNum( aLogicPaperSize.Width(), nDigits 
) );
 OUString aHeight( rLocWrap.getNum( aLogicPaperSize.Height(), 
nDigits ) );
 OUString aUnit = eUnit == MapUnit::MapMM ? OUString("mm") : 
OUString("in");
-OUString aPaperName = Printer::GetPaperName( ePaper ) + " " + 
aWidth + aUnit + " x " + aHeight + aUnit;
+OUString aPaperName;
+
+// Paper sizes that we don't know of but the system printer driver 
lists are not "User
+// Defined". Displaying them as such is just confusing.
+if (ePaper != PAPER_USER)
+aPaperName = Printer::GetPaperName( ePaper ) + " ";
+
+aPaperName += aWidth + aUnit + " x " + aHeight + aUnit;
 
 mxPaperSizeBox->append_text(aPaperName);
 


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - vcl/inc vcl/source

 vcl/inc/printdlg.hxx   |1 -
 vcl/source/window/printdlg.cxx |   13 -
 2 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 8d49b548ba2aabb799f879fc6daa7b1e09b09139
Author: Tor Lillqvist 
AuthorDate: Tue Nov 2 20:16:31 2021 +0200
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:18:05 2021 +0100

tdf#145354: Ensure displayed paper name matches displayed paper dimensions

I could not reproduce it now but at least in some slightly older
version of LibreOffice, it could happen that at the top of the print
preview image was displayed "143 mm (A4)" which is silly, as neither
side of an A4 paper is 143 mm.

Look up the matching paper size from the dimensions displayed. Use the
"sloppy" match function to allow for sub-millimeter rounding errors.

Change-Id: I6320798061246101c6fc78baf841b71b32b25833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124635
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx
index 64e127e43261..db041f1705fd 100644
--- a/vcl/inc/printdlg.hxx
+++ b/vcl/inc/printdlg.hxx
@@ -81,7 +81,6 @@ namespace vcl
 virtual void Resize() override;
 
 void setPreview( const GDIMetaFile&, const Size& i_rPaperSize,
- const OUString& i_rPaperName,
  const OUString& i_rNoPageString,
  sal_Int32 i_nDPIX, sal_Int32 i_nDPIY,
  bool i_bGreyscale
diff --git a/vcl/source/window/printdlg.cxx b/vcl/source/window/printdlg.cxx
index 120d6a5b6e1c..250df3916b78 100644
--- a/vcl/source/window/printdlg.cxx
+++ b/vcl/source/window/printdlg.cxx
@@ -248,7 +248,6 @@ bool PrintDialog::PrintPreviewWindow::Command( const 
CommandEvent& rEvt )
 
 void PrintDialog::PrintPreviewWindow::setPreview( const GDIMetaFile& 
i_rNewPreview,
   const Size& i_rOrigSize,
-  const OUString& i_rPaperName,
   const OUString& 
i_rReplacement,
   sal_Int32 i_nDPIX,
   sal_Int32 i_nDPIY,
@@ -277,12 +276,18 @@ void PrintDialog::PrintPreviewWindow::setPreview( const 
GDIMetaFile& i_rNewPrevi
 aBuf.append( aNumText )
 .append( u' ' );
 aBuf.appendAscii( eUnit == MapUnit::MapMM ? "mm" : "in" );
-if( !i_rPaperName.isEmpty() )
+
+// Look up the paper name from the dimensions
+PaperInfo aPaperInfoFromSize(i_rOrigSize.getWidth(), 
i_rOrigSize.getHeight());
+aPaperInfoFromSize.doSloppyFit();
+
+if (aPaperInfoFromSize.getPaper() != PAPER_USER)
 {
 aBuf.append( " (" );
-aBuf.append( i_rPaperName );
+aBuf.append( Printer::GetPaperName(aPaperInfoFromSize.getPaper()) );
 aBuf.append( ')' );
 }
+
 maHorzText = aBuf.makeStringAndClear();
 
 aNumText = rLocWrap.getNum( aLogicPaperSize.Height(), nDigits );
@@ -935,7 +940,6 @@ void PrintDialog::preparePreview( bool i_bMayUseCache )
 if ( !hasPreview() )
 {
 mxPreview->setPreview( aMtf, aCurPageSize,
-Printer::GetPaperName( mePaper ),
 maNoPreviewStr,
 aPrt->GetDPIX(), aPrt->GetDPIY(),
 aPrt->GetPrinterOptions().IsConvertToGreyscales()
@@ -970,7 +974,6 @@ void PrintDialog::preparePreview( bool i_bMayUseCache )
 }
 
 mxPreview->setPreview( aMtf, aCurPageSize,
-Printer::GetPaperName( mePaper ),
 nPages > 0 ? OUString() : maNoPageStr,
 aPrt->GetDPIX(), aPrt->GetDPIY(),
 
aPrt->GetPrinterOptions().IsConvertToGreyscales()


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - include/sal

 include/sal/log.hxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 9834b756d3a7bb6dc2eda2eb8c9501ee8dc04c4c
Author: Stephan Bergmann 
AuthorDate: Tue May 18 12:58:34 2021 +0200
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:16:56 2021 +0100

tdf#142326: Adapt to "libstdc++: Implement LWG 1203 for rvalue iostreams"

...for libstdc++ 11.2, similar to 1f36f21d91c429190ae314dadeec409f35f4
"Adapt to "libstdc++: Implement LWG 1203 for rvalue iostreams" for 
libstdc++ 12.
The libstdc++ change referenced there has been backported to the 
releases/gcc-11
branch past the releases/gcc-11.1.0 tag (i.e., only towards libstdc++ 11.2) 
as


"libstdc++: Implement LWG 1203 for rvalue iostreams".

According to
,

,
and , the right __GLIBCXX__ 
value for
libstdc++ 11.1 should be 20210427, but at least
libstdc++-devel-11.1.1-1.fc34.x86_64 defines it as 20210428 while not 
including
the above "libstdc++: Implement LWG 1203 for rvalue iostreams" commit, so 
use
that value here.

Change-Id: I4e2c6d6ad8156a83f5c4bc861e4a118271928a20
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115738
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124919
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/include/sal/log.hxx b/include/sal/log.hxx
index 87ffba65490b..f85c7d882134 100644
--- a/include/sal/log.hxx
+++ b/include/sal/log.hxx
@@ -161,7 +161,9 @@ inline char const * unwrapStream(SAL_UNUSED_PARAMETER 
StreamIgnore const &) {
 
 @since LibreOffice 3.5
 */
-#if defined _LIBCPP_VERSION || (defined _GLIBCXX_RELEASE && _GLIBCXX_RELEASE 
>= 12) \
+#if defined _LIBCPP_VERSION \
+|| (defined _GLIBCXX_RELEASE \
+&& (_GLIBCXX_RELEASE >= 12 || (_GLIBCXX_RELEASE == 11 && __GLIBCXX__ > 
20210428))) \
 || (defined _MSC_VER && _MSC_VER >= 1915)
 #define SAL_STREAM(stream) \
 (::std::ostringstream() << stream).str()


[Libreoffice-commits] core.git: Branch 'distro/mimo/mimo-7-0' - include/sal

 include/sal/log.hxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 7baa700c980b2b059e2ce2ee5f688de4f601a444
Author: Stephan Bergmann 
AuthorDate: Wed May 5 08:20:18 2021 +0200
Commit: Andras Timar 
CommitDate: Wed Nov 10 12:16:25 2021 +0100

Adapt to "libstdc++: Implement LWG 1203 for rvalue iostreams"



towards GCC 12, so that now "the return type is the original rvalue stream 
type
not its base class."  (And which would thus have caused issues like

> sfx2/source/control/bindings.cxx:1323:19: error: dynamic_cast from rvalue 
to reference type '::std::ostringstream &' (aka 'basic_ostringstream &')
> ? SAL_STREAM("File: " << pFile << " Line: " << nLine) : 
""));
> 
~~^~
> include/sal/log.hxx:198:6: note: expanded from macro 'SAL_STREAM'
> (dynamic_cast< ::std::ostringstream & >(::std::ostringstream() << 
stream).str())
>  ^
> include/sal/log.hxx:341:20: note: expanded from macro 'SAL_INFO'
> SAL_WHERE, stream)
> ~~~^~~
> include/sal/log.hxx:155:68: note: expanded from macro 
'SAL_DETAIL_LOG_STREAM'
> SAL_DETAIL_LOG_STREAM_PRIVATE_(level, area, where, 
stream); \
> ~~~^~~
> include/sal/log.hxx:133:45: note: expanded from macro 
'SAL_DETAIL_LOG_STREAM_PRIVATE_'
> ::sal::detail::StreamStart() << stream) == 1) \
> ^~

now.  While the issue with old libstdc++ that originally prompted the
dynamic_cast was

> sfx2/source/control/bindings.cxx:1323:19: error: no member named 'str' in 
'std::basic_ostream'
> ? SAL_STREAM("File: " << pFile << " Line: " << nLine) : 
""));
> 
~~^~
> include/sal/log.hxx:194:40: note: expanded from macro 'SAL_STREAM'
> (::std::ostringstream() << stream).str()
>^
> include/sal/log.hxx:336:20: note: expanded from macro 'SAL_INFO'
> SAL_WHERE, stream)
> ~~~^~~
> include/sal/log.hxx:155:68: note: expanded from macro 
'SAL_DETAIL_LOG_STREAM'
> SAL_DETAIL_LOG_STREAM_PRIVATE_(level, area, where, 
stream); \
> ~~~^~~
> include/sal/log.hxx:133:45: note: expanded from macro 
'SAL_DETAIL_LOG_STREAM_PRIVATE_'
> ::sal::detail::StreamStart() << stream) == 1) \
> ^~

.)

The libstdc++ macro _GLIBCXX_RELEASE is reportedly available since GCC 7.1.

Change-Id: I1ee6eabb66355c1f28b9d305cbd85bac50d6b0e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115121
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124918
Tested-by: Andras Timar 
Reviewed-by: Andras Timar 

diff --git a/include/sal/log.hxx b/include/sal/log.hxx
index 00d533ab5495..87ffba65490b 100644
--- a/include/sal/log.hxx
+++ b/include/sal/log.hxx
@@ -161,7 +161,8 @@ inline char const * unwrapStream(SAL_UNUSED_PARAMETER 
StreamIgnore const &) {
 
 @since LibreOffice 3.5
 */
-#if defined _LIBCPP_VERSION || (defined _MSC_VER && _MSC_VER >= 1915)
+#if defined _LIBCPP_VERSION || (defined _GLIBCXX_RELEASE && _GLIBCXX_RELEASE 
>= 12) \
+|| (defined _MSC_VER && _MSC_VER >= 1915)
 #define SAL_STREAM(stream) \
 (::std::ostringstream() << stream).str()
 #else


[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - download.lst

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 628a1e9ef973c7b6ef68dc672d3b747d0cca9dc8
Author: Michael Stahl 
AuthorDate: Tue Nov 9 12:35:04 2021 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 10 11:59:31 2021 +0100

openldap: upgrade to release 2.4.59

Fixes CVE-2020-36230 and CVE-2020-36229 in libldap, plus lots of
other CVEs that affect only the server.

Unfortunately it looks like NSS support was removed in release 2.5.0.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124914
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 9393325c1db9fa25037d208607b71adb567a8bbc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124860
Reviewed-by: Caolán McNamara 
(cherry picked from commit b7c670984e4af1c73fa05731ca8029cec487bd52)

Change-Id: Ie43d7da1b9e92b5712f9cd22c4613648394c696f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124953
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 

diff --git a/download.lst b/download.lst
index 481559e229a3..63df06fe41a5 100644
--- a/download.lst
+++ b/download.lst
@@ -192,8 +192,8 @@ export ODFVALIDATOR_SHA256SUM := 
984f2a479df79e27e7b01a5815ac53ae64e07746b882262
 export ODFVALIDATOR_JAR := 
odfvalidator-1.2.0-incubating-SNAPSHOT-jar-with-dependencies-971c54fd38a968f5860014b44301872706f9e540.jar
 export OFFICEOTRON_SHA256SUM := 
f2443f27561af52324eee03a1892d9f569adc8db9e7bca55614898bc2a13a770
 export OFFICEOTRON_JAR := 
8249374c274932a21846fa7629c2aa9b-officeotron-0.7.4-master.jar
-export OPENLDAP_SHA256SUM := 
cdd6cffdebcd95161a73305ec13fc7a78e9707b46ca9f84fb897cd5626df3824
-export OPENLDAP_TARBALL := openldap-2.4.45.tgz
+export OPENLDAP_SHA256SUM := 
99f37d6747d88206c470067eda624d5e48c1011e943ec0ab217bae8712e22f34
+export OPENLDAP_TARBALL := openldap-2.4.59.tgz
 export OPENSSL_SHA256SUM := 
14cb464efe7ac6b54799b34456bd69558a749a4931ecfd9cf9f71d7881cac7bc
 export OPENSSL_TARBALL := openssl-1.0.2t.tar.gz
 export ORCUS_SHA256SUM := 
0dd26f3f2e611c51df9ee02d6dbf08887989eaa417b73f6877cd0d94df795fc2


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/qa sw/source

 sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt  |  120 
 sw/qa/extras/odfimport/data/PageAnchorZIndexSecondPage.fodt |  120 
 sw/qa/extras/odfimport/odfimport.cxx|   28 ++
 sw/source/core/layout/newfrm.cxx|3 
 sw/source/core/layout/pagechg.cxx   |3 
 5 files changed, 272 insertions(+), 2 deletions(-)

New commits:
commit b3ca51fdaf51e7f1eb5e699d8964269bfd35f240
Author: Tomaž Vajngerl 
AuthorDate: Sat Oct 30 10:03:33 2021 +0200
Commit: Tomaž Vajngerl 
CommitDate: Wed Nov 10 11:59:10 2021 +0100

sw: Wrong ZOrder after import for images anchored to non-1nd page

Importing a document that has images anchored to the non-1st
page, can result in images having the wrong the wrong Z index
(ZOrder). If there are overlapping objects in the document,
this can become a problem.

The issue is with the call to SwRootFrame::RemoveMasterObjs,
which removed the "master objects" - SwFlyDrawObj* castable
objects. Normally the SwFlyDrawObj* objects on the page are wrapped
and replaced by SwVirtFlyDrawObj*, but when the call to the
RemoveMasterObjs was made, this hasn't happen yet to all the
objects (objects that were not on the 1st page).

The fix is to move the RemoveMasterObjs call to a different place,
where we processed all the pages, so we can safely remove the
remaining master objects on the page.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124597
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 8b7dbd220dbdfd286de2d770503dae8bf6d2e53e)

Change-Id: I7d2f31614d269c22a82e7e5dea960f3d0844a5d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124752
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 

diff --git a/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt 
b/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt
new file mode 100644
index ..6acb5e6d8256
--- /dev/null
+++ b/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt
@@ -0,0 +1,120 @@
+
+http://openoffice.org/2009/office"; 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns
 :config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink"; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="ur
 n:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:xforms="http://www.w3.org/2002/xforms"; office:version="1.3" 
office:mimetype="application/vnd.oasis.opendocument.text">
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+

[Libreoffice-commits] core.git: Changes to 'refs/tags/co-21.06.6-1'

Tag 'co-21.06.6-1' created by Andras Timar  at 
2021-11-10 10:43 +

co-21.06.6-1

Changes since cp-21.06.5-2-28:
---
 0 files changed
---


[Libreoffice-commits] translations.git: Changes to 'refs/tags/co-21.06.6-1'

Tag 'co-21.06.6-1' created by Andras Timar  at 
2021-11-10 10:43 +

co-21.06.6-1

Changes since co-21.06.5-1:
Christian Lohmaier (1):
  update templates for 7.1.7 rc2

---
 source/am/framework/messages.po  |
8 
 source/am/sfx2/messages.po   |
4 
 source/an/cui/messages.po|
9 
 source/an/desktop/messages.po|
9 
 source/an/officecfg/registry/data/org/openoffice/Office/UI.po|
5 
 source/an/sd/messages.po |
4 
 source/an/svx/messages.po|
6 
 source/ar/cui/messages.po|   
14 
 source/ast/cui/messages.po   |
6 
 source/ast/filter/source/config/fragments/filters.po |   
14 
 source/ast/helpcontent2/source/text/sdatabase.po |   
20 
 source/ast/helpcontent2/source/text/sdraw/guide.po   |   
16 
 source/ast/helpcontent2/source/text/shared/00.po |
6 
 source/ast/helpcontent2/source/text/shared/01.po |
8 
 source/ast/helpcontent2/source/text/simpress/00.po   |
8 
 source/ast/helpcontent2/source/text/simpress/01.po   |
6 
 source/ast/helpcontent2/source/text/swriter/01.po|   
10 
 source/ast/helpcontent2/source/text/swriter/02.po|
6 
 source/ast/helpcontent2/source/text/swriter/guide.po |
6 
 source/ast/officecfg/registry/data/org/openoffice/Office/UI.po   |
8 
 source/ast/sc/messages.po|
7 
 source/ast/scp2/source/ooo.po|   
33 
 source/ast/sd/messages.po|   
10 
 source/ast/svtools/messages.po   |   
20 
 source/ast/sw/messages.po|   
20 
 source/ast/vcl/messages.po   |
4 
 source/ast/wizards/source/resources.po   |
8 
 source/ca/cui/messages.po|   
16 
 source/ca/helpcontent2/source/text/sbasic/shared/01.po   |
8 
 source/ca/helpcontent2/source/text/scalc/01.po   |   
10 
 source/ca/helpcontent2/source/text/scalc/guide.po|
6 
 source/ca/helpcontent2/source/text/sdatabase.po  |
4 
 source/ca/helpcontent2/source/text/sdraw.po  |
4 
 source/ca/helpcontent2/source/text/shared/00.po  |   
10 
 source/ca/helpcontent2/source/text/shared/01.po  |   
32 
 source/ca/helpcontent2/source/text/shared/02.po  |
6 
 source/ca/helpcontent2/source/text/shared/guide.po   |   
22 
 source/ca/helpcontent2/source/text/shared/optionen.po|   
28 
 source/ca/helpcontent2/source/text/simpress/guide.po |   
22 
 source/ca/helpcontent2/source/text/smath/00.po   |   
10 
 source/ca/helpcontent2/source/text/smath/01.po   |   
16 
 source/ca/helpcontent2/source/text/swriter.po|
6 
 source/ca/helpcontent2/source/text/swriter/01.po |   
22 
 source/ca/helpcontent2/source/text/swriter/guide.po  |   
10 
 source/ca/sfx2/messages.po   |
8 
 source/ca/starmath/messages.po   |   
10 
 source/ca/svtools/messages.po|
8 
 source/ca/sw/messages.po |   
12 
 source/cs/helpcontent2/source/text/sbasic/shared/02.po   |   
12 
 source/cs/helpcontent2/source/text/scalc/04.po   |   
12 
 source/cs/helpcontent2/source/text/swriter/00.po |
8 
 source/cs/helpcontent2/source/text/swriter/guide.po  |   
16 
 source/cs/officecfg/registry/data/org/openoffice/Office/UI.po|
6 
 source/de/cui/messages.po|   
16 
 source/de/dictionaries/ca.po |   
15 
 source/de/dictionaries/cs_CZ.po  |   
15 
 source/de/dictionaries/da_DK.po  |
6 
 source/de/dictionaries/de.po |   
16 
 sour

[Libreoffice-commits] help.git: Changes to 'refs/tags/co-21.06.6-1'

Tag 'co-21.06.6-1' created by Andras Timar  at 
2021-11-10 10:43 +

co-21.06.6-1

Changes since co-2021-branch-point-10:
---
 0 files changed
---


[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/co-21.06.6-1'

Tag 'co-21.06.6-1' created by Andras Timar  at 
2021-11-10 10:43 +

co-21.06.6-1

Changes since libreoffice-7-1-branch-point-5:
---
 0 files changed
---


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - configure.ac

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8366dce02f68e6ddf5dc719663123f2502a36728
Author: Andras Timar 
AuthorDate: Wed Nov 10 11:42:31 2021 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 10 11:42:31 2021 +0100

Bump version to 21.06.6.1

Change-Id: Ic49366632debf2c7b603e6a81d6ae41316065bde

diff --git a/configure.ac b/configure.ac
index 151e6dc08954..38953def3252 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[21.06.5.2],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[21.06.6.1],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard


[Libreoffice-commits] core.git: include/sal vcl/win

 include/sal/log-areas.dox |1 +
 vcl/win/gdi/salprn.cxx|4 
 2 files changed, 5 insertions(+)

New commits:
commit b287e9bb4bf60fb49c2832eba0afd85102b84823
Author: Tor Lillqvist 
AuthorDate: Tue Nov 9 15:10:58 2021 +0200
Commit: Tor Lillqvist 
CommitDate: Wed Nov 10 11:34:26 2021 +0100

Add SAL_INFO of what paper sizes the printer (driver) advertises

Change-Id: I9598a829c22cc4d02244fff6616584aa6dbac68e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124916
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 

diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox
index 55f15022f340..8702656bbb18 100644
--- a/include/sal/log-areas.dox
+++ b/include/sal/log-areas.dox
@@ -491,6 +491,7 @@ certain functionality.
 @li @c vcl.osx.clipboard
 @li @c vcl.osx.print
 @li @c vcl.pdfwriter
+@li @c vcl.print
 @li @c vcl.plugadapt - the Unix/X11 backend plugin mechanism
 @li @c vcl.qt - Qt
 @li @c vcl.quartz
diff --git a/vcl/win/gdi/salprn.cxx b/vcl/win/gdi/salprn.cxx
index 332c7a8dfaae..835c571785a6 100644
--- a/vcl/win/gdi/salprn.cxx
+++ b/vcl/win/gdi/salprn.cxx
@@ -52,6 +52,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -1126,6 +1127,9 @@ void WinSalInfoPrinter::InitPaperFormats( const 
ImplJobSetup* pSetupData )
 
 sal_Unicode* pNamesBuffer = 
static_cast(std::malloc(nCount*64*sizeof(sal_Unicode)));
 ImplDeviceCaps( this, DC_PAPERNAMES, 
reinterpret_cast(pNamesBuffer), pSetupData );
+
+SAL_INFO("vcl.print", "DC_PAPERSIZE sizes (mm) from printer: " << 
DC_PAPERSIZE_array_to_string(pPaperSizes, nCount));
+
 for( DWORD i = 0; i < nCount; ++i )
 {
 PaperInfo aInfo(pPaperSizes[i].x * 10, pPaperSizes[i].y * 10);


[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - chart2/source

 chart2/source/inc/ChartTypeHelper.hxx   |1 +
 chart2/source/tools/ChartTypeHelper.cxx |   13 +
 chart2/source/view/main/ChartView.cxx   |9 +++--
 3 files changed, 21 insertions(+), 2 deletions(-)

New commits:
commit 0644f44daef7caa8a246221d762fbc0f6af3672c
Author: Andras Timar 
AuthorDate: Tue Nov 9 23:36:32 2021 +0100
Commit: Andras Timar 
CommitDate: Wed Nov 10 11:29:45 2021 +0100

tdf#136111 fix scaling problem on chart driven by a macro

Change-Id: I9a55bcfceb9259f0d5dc944c00a34b3e4a891e0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124940
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Dennis Francis 

diff --git a/chart2/source/inc/ChartTypeHelper.hxx 
b/chart2/source/inc/ChartTypeHelper.hxx
index 1a6345321825..d4917be283fb 100644
--- a/chart2/source/inc/ChartTypeHelper.hxx
+++ b/chart2/source/inc/ChartTypeHelper.hxx
@@ -49,6 +49,7 @@ public:
 static bool isSupportingDateAxis( const css::uno::Reference< 
css::chart2::XChartType >& xChartType, sal_Int32 nDimensionIndex );
 static bool isSupportingComplexCategory( const css::uno::Reference< 
css::chart2::XChartType >& xChartType );
 static bool isSupportingCategoryPositioning( const css::uno::Reference< 
css::chart2::XChartType >& xChartType, sal_Int32 nDimensionCount );
+static bool shiftCategoryPosAtXAxisPerDefault( const 
css::uno::Reference< css::chart2::XChartType >& xChartType );
 
 //returns sequence of css::chart::DataLabelPlacement
 static css::uno::Sequence < sal_Int32 > getSupportedLabelPlacements(
diff --git a/chart2/source/tools/ChartTypeHelper.cxx 
b/chart2/source/tools/ChartTypeHelper.cxx
index a4b8059ffb19..a260636a0604 100644
--- a/chart2/source/tools/ChartTypeHelper.cxx
+++ b/chart2/source/tools/ChartTypeHelper.cxx
@@ -464,6 +464,19 @@ bool ChartTypeHelper::isSupportingCategoryPositioning( 
const uno::Reference< cha
 return false;
 }
 
+bool ChartTypeHelper::shiftCategoryPosAtXAxisPerDefault( const uno::Reference< 
chart2::XChartType >& xChartType )
+{
+if(xChartType.is())
+{
+OUString aChartTypeName = xChartType->getChartType();
+if( aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_COLUMN)
+|| aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_BAR)
+|| aChartTypeName.match(CHART2_SERVICE_NAME_CHARTTYPE_CANDLESTICK) 
)
+return true;
+}
+return false;
+}
+
 bool ChartTypeHelper::noBordersForSimpleScheme( const uno::Reference< 
chart2::XChartType >& xChartType )
 {
 if(xChartType.is())
diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 56a64d349e6f..052e2f370f3f 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -325,7 +325,7 @@ public:
 
 void AdaptScaleOfYAxisWithoutAttachedSeries( ChartModel& rModel );
 
-static bool isCategoryPositionShifted(
+bool isCategoryPositionShifted(
 const chart2::ScaleData& rSourceScale, bool bHasComplexCategories );
 
 private:
@@ -350,12 +350,14 @@ private:
  */
 sal_Int32 m_nMaxAxisIndex;
 
+bool m_bChartTypeUsesShiftedCategoryPositionPerDefault;
 sal_Int32 m_nDefaultDateNumberFormat;
 };
 
 SeriesPlotterContainer::SeriesPlotterContainer( std::vector< 
std::unique_ptr >& rVCooSysList )
 : m_rVCooSysList( rVCooSysList )
 , m_nMaxAxisIndex(0)
+, m_bChartTypeUsesShiftedCategoryPositionPerDefault(false)
 , m_nDefaultDateNumberFormat(0)
 {
 }
@@ -519,6 +521,9 @@ void 
SeriesPlotterContainer::initializeCooSysAndSeriesPlotter(
 }
 }
 
+if(nT==0)
+m_bChartTypeUsesShiftedCategoryPositionPerDefault = 
ChartTypeHelper::shiftCategoryPosAtXAxisPerDefault( xChartType );
+
 bool bExcludingPositioning = 
DiagramHelper::getDiagramPositioningMode( xDiagram ) == 
DiagramPositioningMode_EXCLUDING;
 VSeriesPlotter* pPlotter = VSeriesPlotter::createSeriesPlotter( 
xChartType, nDimensionCount, bExcludingPositioning );
 if( !pPlotter )
@@ -630,7 +635,7 @@ bool SeriesPlotterContainer::isCategoryPositionShifted(
 const chart2::ScaleData& rSourceScale, bool bHasComplexCategories )
 {
 if (rSourceScale.AxisType == AxisType::CATEGORY)
-return bHasComplexCategories || rSourceScale.ShiftedCategoryPosition;
+return bHasComplexCategories || rSourceScale.ShiftedCategoryPosition 
|| m_bChartTypeUsesShiftedCategoryPositionPerDefault;
 
 if (rSourceScale.AxisType == AxisType::DATE)
 return rSourceScale.ShiftedCategoryPosition;


[Libreoffice-commits] core.git: svx/source

 svx/source/items/numinf.cxx |   50 ++--
 1 file changed, 25 insertions(+), 25 deletions(-)

New commits:
commit 8e65f21b286a7de1c459761243432e4bbbcd4713
Author: Noel Grandin 
AuthorDate: Wed Nov 10 10:57:07 2021 +0200
Commit: Noel Grandin 
CommitDate: Wed Nov 10 11:20:08 2021 +0100

inline INIT macro

which is not adding to readability at all

Change-Id: Ib52ff43790a72adb9229d648472a91ee1ef48563
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124951
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/svx/source/items/numinf.cxx b/svx/source/items/numinf.cxx
index 5df9470ce4b1..a59d00b42074 100644
--- a/svx/source/items/numinf.cxx
+++ b/svx/source/items/numinf.cxx
@@ -20,45 +20,45 @@
 #include 
 
 
-#define INIT(pNum,eVal,nDouble,rStr)\
-SfxPoolItem ( nId ),\
-\
-pFormatter  ( pNum ),   \
-eValueType  ( eVal ),   \
-aStringVal  ( rStr ),   \
-nDoubleVal  ( nDouble )\
-
 SvxNumberInfoItem::SvxNumberInfoItem( const sal_uInt16 nId ) :
-
-INIT( nullptr, SvxNumberValueType::Undefined, 0, "" )
-
+SfxPoolItem ( nId ),
+pFormatter  ( nullptr ),
+eValueType  ( SvxNumberValueType::Undefined ),
+aStringVal  ( "" ),
+nDoubleVal  ( 0 )
 {
 }
 
 
 SvxNumberInfoItem::SvxNumberInfoItem( SvNumberFormatter* pNumFormatter,
   const sal_uInt16 nId ) :
-
-INIT( pNumFormatter, SvxNumberValueType::Undefined, 0, "" )
-
+SfxPoolItem ( nId ),
+pFormatter  ( pNumFormatter ),
+eValueType  ( SvxNumberValueType::Undefined ),
+aStringVal  ( "" ),
+nDoubleVal  ( 0 )
 {
 }
 
 
 SvxNumberInfoItem::SvxNumberInfoItem( SvNumberFormatter* pNumFormatter,
   const OUString& rVal, const sal_uInt16 
nId ) :
-
-INIT( pNumFormatter, SvxNumberValueType::String, 0, rVal )
-
+SfxPoolItem ( nId ),
+pFormatter  ( pNumFormatter ),
+eValueType  ( SvxNumberValueType::String ),
+aStringVal  ( rVal ),
+nDoubleVal  ( 0 )
 {
 }
 
 
 SvxNumberInfoItem::SvxNumberInfoItem( SvNumberFormatter* pNumFormatter,
   const double& rVal, const sal_uInt16 nId 
) :
-
-INIT( pNumFormatter, SvxNumberValueType::Number, rVal, "" )
-
+SfxPoolItem ( nId ),
+pFormatter  ( pNumFormatter ),
+eValueType  ( SvxNumberValueType::Number ),
+aStringVal  ( "" ),
+nDoubleVal  ( rVal )
 {
 }
 
@@ -66,14 +66,14 @@ SvxNumberInfoItem::SvxNumberInfoItem( SvNumberFormatter* 
pNumFormatter,
 SvxNumberInfoItem::SvxNumberInfoItem( SvNumberFormatter* pNumFormatter,
   const double& rVal, const OUString& 
rValueStr,
   const sal_uInt16 nId ) :
-
-INIT( pNumFormatter, SvxNumberValueType::Number, rVal, rValueStr )
-
+SfxPoolItem ( nId ),
+pFormatter  ( pNumFormatter ),
+eValueType  ( SvxNumberValueType::Number ),
+aStringVal  ( rValueStr ),
+nDoubleVal  ( rVal )
 {
 }
 
-#undef INIT
-
 
 SvxNumberInfoItem::SvxNumberInfoItem( const SvxNumberInfoItem& rItem ) :
 SfxPoolItem  ( rItem ),


[Libreoffice-commits] core.git: download.lst Makefile.in solenv/bin solenv/flatpak-manifest.in

 Makefile.in |2 
 download.lst|6 
 solenv/bin/generate-flatpak-manifest.sh |   20 +
 solenv/flatpak-manifest.in  |  516 
 4 files changed, 282 insertions(+), 262 deletions(-)

New commits:
commit c5f620f9f6abae0213fdda17fae10f281b7bdf9f
Author: Michael Stahl 
AuthorDate: Mon Nov 8 21:29:05 2021 +0100
Commit: Michael Stahl 
CommitDate: Wed Nov 10 11:02:02 2021 +0100

add generate-flatpak-manifest.sh to generate FlatPak manifest

Duplication of external tarballs in flatpak-manifest.in is a maintenance
nightmare.

The only difference between the current flatpak-manifest.in and the one
generated from:
make -s cmd cmd='${SRCDIR}/solenv/bin/generate-flatpak-manifest.sh master' 
> org.libreoffice.LibreOffice.json

... is that the current one contains an outdated reference to
zxing-cpp-1.1.1.tar.gz which was upgraded to zxing-cpp-1.2.0.tar.gz
in download.lst.

Change-Id: I98ab9346244f2c0d788da391928fcb4ffebbe23f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124891
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/Makefile.in b/Makefile.in
index a20fa7cbd8dd..d74dba59344c 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -233,7 +233,7 @@ distclean : clean compilerplugins-clean
 # custom command
 #
 cmd:
-   echo "custom cmd" && ( $(cmd) )
+   $(if $(verbose),echo "custom cmd" &&) ( $(cmd) )
 
 #
 # Fetch
diff --git a/download.lst b/download.lst
index c7740b7e8294..ad912f844776 100644
--- a/download.lst
+++ b/download.lst
@@ -1,7 +1,7 @@
 # For the Flatpak build (which cannot execute `make fetch` from 
its---sandboxed---build
-# environment), some of the entries here are duplicated in 
solenv/flatpak-manifest.in.  When making
-# changes to such duplicated entries here, it is helpful when the changes are 
also made in
-# solenv/flatpak-manifest.in.
+# environment), there is a solenv/flatpak-manifest.in that references these 
variables.
+# There is a script solenv/bin/generate-flatpak-manifest.sh to substitute the 
variables,
+# so upgrading to a new version only requires changes in download.lst.
 
 export ABW_SHA256SUM := 
e763a9dc21c3d2667402d66e202e3f8ef4db51b34b79ef41f56cacb86dcd6eed
 export ABW_TARBALL := libabw-0.1.3.tar.xz
diff --git a/solenv/bin/generate-flatpak-manifest.sh 
b/solenv/bin/generate-flatpak-manifest.sh
new file mode 100755
index ..26359b4a464b
--- /dev/null
+++ b/solenv/bin/generate-flatpak-manifest.sh
@@ -0,0 +1,20 @@
+#!/bin/bash
+
+# usage:
+# make -s cmd cmd='${SRCDIR}/solenv/bin/generate-flatpak-manifest.sh master' > 
org.libreoffice.LibreOffice.json
+
+set -euo pipefail
+
+my_gitbranch="${1?}"
+subst="-e s!@BRANCH@!${my_gitbranch?}!"
+
+subst="${subst} $(
+< ${SRCDIR}/solenv/flatpak-manifest.in \
+sed ${subst} | \
+grep -o '@[A-Z0-9_]*@' | while read var; do
+temp=${var:1:-1}
+echo -n " -e s/${var}/${!temp}/"
+done
+)"
+
+exec sed ${subst} < "${SRCDIR}"/solenv/flatpak-manifest.in
diff --git a/solenv/flatpak-manifest.in b/solenv/flatpak-manifest.in
index d16555aec1df..87bb0b6c23fd 100644
--- a/solenv/flatpak-manifest.in
+++ b/solenv/flatpak-manifest.in
@@ -75,39 +75,39 @@
 "type": "shell"
 },
 {
-"url": 
"https://dev-www.libreoffice.org/src/pdfium-4643.tar.bz2";,
-"sha256": 
"eb98a77eaaab9e9e8de541cfd18b9438dd3c538bd5ef163820353179727f5dc9",
+"url": 
"https://dev-www.libreoffice.org/src/@PDFIUM_TARBALL@";,
+"sha256": "@PDFIUM_SHA256SUM@",
 "type": "file",
 "dest": "external/tarballs",
-"dest-filename": "pdfium-4643.tar.bz2"
+"dest-filename": "@PDFIUM_TARBALL@"
 },
 {
-"url": 
"https://dev-www.libreoffice.org/src/0168229624cfac409e766913506961a8-ucpp-1.3.2.tar.gz";,
-"sha256": 
"983941d31ee8d366085cadf28db75eb1f5cb03ba1e5853b98f12f7f51c63b776",
+"url": 
"https://dev-www.libreoffice.org/src/@UCPP_TARBALL@";,
+"sha256": "@UCPP_SHA256SUM@",
 "type": "file",
 "dest": "external/tarballs",
-"dest-filename": 
"0168229624cfac409e766913506961a8-ucpp-1.3.2.tar.gz"
+"dest-filename": "@UCPP_TARBALL@"
 },
 {
-"url": 
"https://dev-www.libreoffice.org/src/xmlsec1-1.2.32.tar.gz";,
-"sha256": 
"e383702853236004e5b08e424b8afe9b53fe9f31aaa7a5382f39d9533eb7c043",
+"url": 
"https://dev-www.libreoffice.org/src/@XMLSEC_TARBALL@";,
+"sha256": "@XMLSEC_SHA256SUM@",
 "type": "file",
 "dest": "external/tarballs",
-  

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - sw/qa sw/source

 sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt  |  120 
 sw/qa/extras/odfimport/data/PageAnchorZIndexSecondPage.fodt |  120 
 sw/qa/extras/odfimport/odfimport.cxx|   28 ++
 sw/source/core/layout/newfrm.cxx|3 
 sw/source/core/layout/pagechg.cxx   |3 
 5 files changed, 272 insertions(+), 2 deletions(-)

New commits:
commit 25551e51dbeda8cce45a6186f09be0cb9722232a
Author: Tomaž Vajngerl 
AuthorDate: Sat Oct 30 10:03:33 2021 +0200
Commit: Xisco Fauli 
CommitDate: Wed Nov 10 10:43:28 2021 +0100

sw: Wrong ZOrder after import for images anchored to non-1nd page

Importing a document that has images anchored to the non-1st
page, can result in images having the wrong the wrong Z index
(ZOrder). If there are overlapping objects in the document,
this can become a problem.

The issue is with the call to SwRootFrame::RemoveMasterObjs,
which removed the "master objects" - SwFlyDrawObj* castable
objects. Normally the SwFlyDrawObj* objects on the page are wrapped
and replaced by SwVirtFlyDrawObj*, but when the call to the
RemoveMasterObjs was made, this hasn't happen yet to all the
objects (objects that were not on the 1st page).

The fix is to move the RemoveMasterObjs call to a different place,
where we processed all the pages, so we can safely remove the
remaining master objects on the page.

Change-Id: I7d2f31614d269c22a82e7e5dea960f3d0844a5d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124597
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 8b7dbd220dbdfd286de2d770503dae8bf6d2e53e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124861
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt 
b/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt
new file mode 100644
index ..6acb5e6d8256
--- /dev/null
+++ b/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt
@@ -0,0 +1,120 @@
+
+http://openoffice.org/2009/office"; 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns
 :config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink"; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="ur
 n:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:xforms="http://www.w3.org/2002/xforms"; office:version="1.3" 
office:mimetype="application/vnd.oasis.opendocument.text">
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+  

[Libreoffice-commits] core.git: include/svl svl/source sw/inc sw/qa sw/source

 include/svl/undo.hxx   |6 ++
 svl/source/undo/undo.cxx   |   10 +++
 sw/inc/IDocumentUndoRedo.hxx   |3 +
 sw/inc/editsh.hxx  |2 
 sw/qa/extras/tiledrendering/tiledrendering.cxx |   47 
 sw/source/core/edit/edundo.cxx |5 -
 sw/source/core/inc/UndoCore.hxx|5 +
 sw/source/core/inc/UndoInsert.hxx  |2 
 sw/source/core/inc/UndoManager.hxx |9 ++-
 sw/source/core/undo/docundo.cxx|   71 +++--
 sw/source/core/undo/unins.cxx  |5 +
 sw/source/uibase/inc/wrtsh.hxx |2 
 sw/source/uibase/shells/basesh.cxx |   21 +++
 sw/source/uibase/wrtsh/wrtundo.cxx |4 -
 14 files changed, 178 insertions(+), 14 deletions(-)

New commits:
commit 8e8e72f08b01a284cf1a90b888d48acfb6a33d2e
Author: Miklos Vajna 
AuthorDate: Wed Nov 10 08:50:08 2021 +0100
Commit: Miklos Vajna 
CommitDate: Wed Nov 10 09:37:36 2021 +0100

sw: allow undo of typing in 2 views independent from each other

Undoing out of order is dangerous by default, so limit this to a very
specific case as a start, that allows growing in follow-up commits.

For now, allow out of order undo if:

1) redo stack is empty

2) we're in LOK mode (different views represent different users)

3) we undo a single action (count is 1)

4) the top undo action doesn't belong to the current view

5) the top and the previous undo actions are independent

Which only requires that SwUndoInsert::UndoImpl() is independent for two
different paragraphs, which seems to be the case.

Independent undo actions opt in for this, currently the only such
allowed undo action is SwUndoInsert ("typing"), which adds characters to
a single text node. Even those are only considered independent if they
operate on different text nodes.

On the positive side, this allows out of order undo in the frequent case
where two users collaborate on a long document and they just type some
new content into the document at different paragraphs.

Change-Id: Ibb4551e8f7046b4947491b8bf751eaa0cbb2d060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124949
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/include/svl/undo.hxx b/include/svl/undo.hxx
index 2757967aaee4..e0d064b27987 100644
--- a/include/svl/undo.hxx
+++ b/include/svl/undo.hxx
@@ -42,6 +42,12 @@ public:
 class SVL_DLLPUBLIC SfxUndoContext
 {
 public:
+/**
+ * Don't undo the top undo action, but an earlier one. It's the caller's 
responsibility to
+ * ensure that the earlier undo action is independent from the following 
ones.
+ */
+virtual size_t GetUndoOffset() { return 0; }
+
 virtual ~SfxUndoContext() = 0;
 };
 
diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx
index 630bb9deea5b..0c081b152c3a 100644
--- a/svl/source/undo/undo.cxx
+++ b/svl/source/undo/undo.cxx
@@ -683,6 +683,16 @@ bool SfxUndoManager::ImplUndo( SfxUndoContext* 
i_contextOrNull )
 return false;
 }
 
+if (i_contextOrNull && i_contextOrNull->GetUndoOffset() == 1)
+{
+if (m_xData->pActUndoArray->nCurUndoAction >= 2)
+{
+std::swap(
+
m_xData->pActUndoArray->maUndoActions[m_xData->pActUndoArray->nCurUndoAction - 
1],
+
m_xData->pActUndoArray->maUndoActions[m_xData->pActUndoArray->nCurUndoAction - 
2]);
+}
+}
+
 SfxUndoAction* pAction = m_xData->pActUndoArray->maUndoActions[ 
--m_xData->pActUndoArray->nCurUndoAction ].pAction.get();
 const OUString sActionComment = pAction->GetComment();
 try
diff --git a/sw/inc/IDocumentUndoRedo.hxx b/sw/inc/IDocumentUndoRedo.hxx
index b533a7e647c2..dae73a60 100644
--- a/sw/inc/IDocumentUndoRedo.hxx
+++ b/sw/inc/IDocumentUndoRedo.hxx
@@ -212,6 +212,9 @@ public:
  */
 virtual void SetView(SwView* pView) = 0;
 
+/// Zero offset means undoing the top undo action.
+virtual bool UndoWithOffset(size_t nUndoOffset) = 0;
+
 protected:
 virtual ~IDocumentUndoRedo() {};
 };
diff --git a/sw/inc/editsh.hxx b/sw/inc/editsh.hxx
index f3f645580135..076cbbf5b3bb 100644
--- a/sw/inc/editsh.hxx
+++ b/sw/inc/editsh.hxx
@@ -602,7 +602,7 @@ public:
 /// should only be called by sw::UndoManager!
 void HandleUndoRedoContext(::sw::UndoRedoContext & rContext);
 
-void Undo(sal_uInt16 const nCount = 1);
+void Undo(sal_uInt16 const nCount = 1, sal_uInt16 nOffset = 0);
 void Redo(sal_uInt16 const nCount = 1);
 void Repeat(sal_uInt16 const nCount);
 
diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx 
b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 4ad4159a295c..46f1c781be02 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/q

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - sw/inc sw/qa sw/source

 sw/inc/IDocumentContentOperations.hxx   |6 +++
 sw/qa/core/doc/doc.cxx  |   32 
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   10 +
 sw/source/core/doc/extinput.cxx |   12 +-
 sw/source/core/edit/editsh.cxx  |1 
 sw/source/core/inc/DocumentContentOperationsManager.hxx |6 +++
 6 files changed, 65 insertions(+), 2 deletions(-)

New commits:
commit 903deab52b26b820bf0d1bb660e2f19ada53df4b
Author: Miklos Vajna 
AuthorDate: Mon Nov 8 08:27:52 2021 +0100
Commit: Miklos Vajna 
CommitDate: Wed Nov 10 09:26:59 2021 +0100

sw: try grouping undo actions of IME-edited text

This is a problem since commit e7760d428bc82ccfcae14f1907b78f9f1013b88c
(Fix tdf#87500 - Freeze with English/Japanese mixture undo.,
2015-09-08), that started not grouping IME-edited text completely.

This means that in case you go via SwEditWin::Command() instead of
SwEditWin::KeyInput() to type a 4 characters word, then it'll create 4
undo actions.

Fix the problem by tracking who was the last caller of
sw::DocumentContentOperationsManager::InsertString(), so we can only
disable grouping switching between IME and non-IME, and we can have
grouping for a series of IME input.

(cherry picked from commit 6680e51716e383c68bb1ec9cc0a05d698d3b6a3d)

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124834
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Mike Kaganski 
(cherry picked from commit b8e0b887efb35b0afd85b81349d5f8e2f7d1c359)

Conflicts:
sw/qa/core/doc/doc.cxx
sw/source/core/doc/extinput.cxx

Change-Id: I31bd02db4fe653ab63e41a77c75b8bebfc749ff1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124921
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/IDocumentContentOperations.hxx 
b/sw/inc/IDocumentContentOperations.hxx
index b6857c346a33..5c7703d5e381 100644
--- a/sw/inc/IDocumentContentOperations.hxx
+++ b/sw/inc/IDocumentContentOperations.hxx
@@ -149,6 +149,12 @@ public:
 virtual bool InsertString(const SwPaM &rRg, const OUString&,
   const SwInsertFlags nInsertMode = SwInsertFlags::EMPTYEXPAND ) = 
0;
 
+/// States that the last inserted string came from IME.
+virtual void SetIME(bool bIME) = 0;
+
+/// Did the last inserted string come from IME?
+virtual bool GetIME() const = 0;
+
 /** change text to Upper/Lower/Hiragana/Katakana/...
  */
 virtual void TransliterateText(const SwPaM& rPaM, 
utl::TransliterationWrapper&) = 0;
diff --git a/sw/qa/core/doc/doc.cxx b/sw/qa/core/doc/doc.cxx
index d30cbe47cc3b..88fae0b0aab8 100644
--- a/sw/qa/core/doc/doc.cxx
+++ b/sw/qa/core/doc/doc.cxx
@@ -17,12 +17,14 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
 #include 
 #include 
 #include 
+#include 
 
 static char const DATA_DIRECTORY[] = "/sw/qa/core/doc/data/";
 
@@ -126,6 +128,36 @@ CPPUNIT_TEST_FIXTURE(SwCoreDocTest, 
testLocaleIndependentTemplate)
 ErrorRegistry::Reset();
 }
 
+CPPUNIT_TEST_FIXTURE(SwCoreDocTest, testIMEGrouping)
+{
+// TODO figure out why the ext text input in this test code reaches the wrong 
window on
+// non-headless.
+#if !defined MACOSX && !defined _WIN32
+// Given an empty document:
+SwDoc* pDoc = createDoc();
+// Make sure no idle is in action, so the ExtTextInput events go to 
SwEditWin.
+Scheduler::ProcessEventsToIdle();
+
+// When pressing two keys via IME:
+SwDocShell* pDocShell = pDoc->GetDocShell();
+SwEditWin& rEditWin = pDocShell->GetView()->GetEditWin();
+rEditWin.PostExtTextInputEvent(VclEventId::ExtTextInput, "a");
+rEditWin.PostExtTextInputEvent(VclEventId::EndExtTextInput, "");
+rEditWin.PostExtTextInputEvent(VclEventId::ExtTextInput, "b");
+rEditWin.PostExtTextInputEvent(VclEventId::EndExtTextInput, "");
+
+// Then make sure that gets grouped together to a single undo action:
+SwWrtShell* pWrtShell = pDocShell->GetWrtShell();
+SwTextNode* pTextNode = pWrtShell->GetCursor()->GetNode().GetTextNode();
+CPPUNIT_ASSERT_EQUAL(OUString("ab"), pTextNode->GetText());
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1
+// - Actual  : 2
+// i.e. 2 subsequent IME events got their own undo actions.
+CPPUNIT_ASSERT_EQUAL(static_cast(1), 
pDoc->GetUndoManager().GetUndoActionCount());
+#endif
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 909c88632f5e..99233fee6df8 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -2784,6 +2784,16 @@ bool DocumentContent

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/qa sw/source

 sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt  |  120 
 sw/qa/extras/odfimport/data/PageAnchorZIndexSecondPage.fodt |  120 
 sw/qa/extras/odfimport/odfimport.cxx|   28 ++
 sw/source/core/layout/newfrm.cxx|3 
 sw/source/core/layout/pagechg.cxx   |3 
 5 files changed, 272 insertions(+), 2 deletions(-)

New commits:
commit 5f90820949ed208b5b46bcb4ba3cd08d2783ae4f
Author: Tomaž Vajngerl 
AuthorDate: Sat Oct 30 10:03:33 2021 +0200
Commit: Tomaž Vajngerl 
CommitDate: Wed Nov 10 09:16:45 2021 +0100

sw: Wrong ZOrder after import for images anchored to non-1nd page

Importing a document that has images anchored to the non-1st
page, can result in images having the wrong the wrong Z index
(ZOrder). If there are overlapping objects in the document,
this can become a problem.

The issue is with the call to SwRootFrame::RemoveMasterObjs,
which removed the "master objects" - SwFlyDrawObj* castable
objects. Normally the SwFlyDrawObj* objects on the page are wrapped
and replaced by SwVirtFlyDrawObj*, but when the call to the
RemoveMasterObjs was made, this hasn't happen yet to all the
objects (objects that were not on the 1st page).

The fix is to move the RemoveMasterObjs call to a different place,
where we processed all the pages, so we can safely remove the
remaining master objects on the page.

Change-Id: I7d2f31614d269c22a82e7e5dea960f3d0844a5d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124597
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 8b7dbd220dbdfd286de2d770503dae8bf6d2e53e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124686
Tested-by: Jenkins CollaboraOffice 

diff --git a/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt 
b/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt
new file mode 100644
index ..6acb5e6d8256
--- /dev/null
+++ b/sw/qa/extras/odfimport/data/PageAnchorZIndexFirstPage.fodt
@@ -0,0 +1,120 @@
+
+http://openoffice.org/2009/office"; 
xmlns:css3t="http://www.w3.org/TR/css3-text/"; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#"; 
xmlns:xhtml="http://www.w3.org/1999/xhtml"; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema"; 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:oooc="http://openoffice.org/2004/calc"; 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer"; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:dc="http://purl.org/dc/elements/1.1/"; 
xmlns:rpt="http://openoffice.org/2005/report"; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns
 :config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink"; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:ooo="http://openoffice.org/2004/office"; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 xmlns:tableooo="http://openoffice.org/2009/table"; 
xmlns:drawooo="http://openoffice.org/2010/draw"; 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:dom="http://www.w3.org/2001/xml-events"; 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML"; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="ur
 n:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:xforms="http://www.w3.org/2002/xforms"; office:version="1.3" 
office:mimetype="application/vnd.oasis.opendocument.text">
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+