[Libreoffice-commits] core.git: include/unotools

2021-11-29 Thread Noel Grandin (via logerrit)
 include/unotools/linguprops.hxx |   68 
 1 file changed, 34 insertions(+), 34 deletions(-)

New commits:
commit 5bba732060a947541f07fc9c87df8ac7a1f8c4f7
Author: Noel Grandin 
AuthorDate: Mon Nov 29 13:27:07 2021 +0200
Commit: Noel Grandin 
CommitDate: Tue Nov 30 08:53:48 2021 +0100

loplugin:stringliteraldefine in unotools

Change-Id: If89dd3f6a81cac216fe2fafddf515ab4f3735726
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126045
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/unotools/linguprops.hxx b/include/unotools/linguprops.hxx
index 00400f05d31e..6beae72149ac 100644
--- a/include/unotools/linguprops.hxx
+++ b/include/unotools/linguprops.hxx
@@ -24,51 +24,51 @@
 #endif
 
 // UNO property names for general options
-constexpr OUStringLiteral UPN_IS_GERMAN_PRE_REFORM= 
u"IsGermanPreReform"; /*! deprecated #i91949 !*/
-constexpr OUStringLiteral UPN_IS_USE_DICTIONARY_LIST  = 
u"IsUseDictionaryList";
-constexpr OUStringLiteral UPN_IS_IGNORE_CONTROL_CHARACTERS= 
u"IsIgnoreControlCharacters";
-constexpr OUStringLiteral UPN_ACTIVE_DICTIONARIES = 
u"ActiveDictionaries";
+inline constexpr OUStringLiteral UPN_IS_GERMAN_PRE_REFORM= 
u"IsGermanPreReform"; /*! deprecated #i91949 !*/
+inline constexpr OUStringLiteral UPN_IS_USE_DICTIONARY_LIST  = 
u"IsUseDictionaryList";
+inline constexpr OUStringLiteral UPN_IS_IGNORE_CONTROL_CHARACTERS= 
u"IsIgnoreControlCharacters";
+inline constexpr OUStringLiteral UPN_ACTIVE_DICTIONARIES = 
u"ActiveDictionaries";
 
 // UNO property names for SpellChecker
-constexpr OUStringLiteral UPN_IS_SPELL_UPPER_CASE = 
u"IsSpellUpperCase";
-constexpr OUStringLiteral UPN_IS_SPELL_WITH_DIGITS= 
u"IsSpellWithDigits";
-constexpr OUStringLiteral UPN_IS_SPELL_CAPITALIZATION = 
u"IsSpellCapitalization";
+inline constexpr OUStringLiteral UPN_IS_SPELL_UPPER_CASE = 
u"IsSpellUpperCase";
+inline constexpr OUStringLiteral UPN_IS_SPELL_WITH_DIGITS= 
u"IsSpellWithDigits";
+inline constexpr OUStringLiteral UPN_IS_SPELL_CAPITALIZATION = 
u"IsSpellCapitalization";
 
 // UNO property names for Hyphenator
-constexpr OUStringLiteral UPN_HYPH_MIN_LEADING= 
u"HyphMinLeading";
-constexpr OUStringLiteral UPN_HYPH_MIN_TRAILING   = 
u"HyphMinTrailing";
-constexpr OUStringLiteral UPN_HYPH_MIN_WORD_LENGTH= 
u"HyphMinWordLength";
-constexpr OUStringLiteral UPN_HYPH_NO_CAPS= u"HyphNoCaps";
+inline constexpr OUStringLiteral UPN_HYPH_MIN_LEADING= 
u"HyphMinLeading";
+inline constexpr OUStringLiteral UPN_HYPH_MIN_TRAILING   = 
u"HyphMinTrailing";
+inline constexpr OUStringLiteral UPN_HYPH_MIN_WORD_LENGTH= 
u"HyphMinWordLength";
+inline constexpr OUStringLiteral UPN_HYPH_NO_CAPS= 
u"HyphNoCaps";
 
 // UNO property names for Lingu
 // (those not covered by the SpellChecker and Hyphenator
 // properties and more likely to be used in other modules only)
-constexpr OUStringLiteral UPN_DEFAULT_LANGUAGE= 
u"DefaultLanguage";
-constexpr OUStringLiteral UPN_DEFAULT_LOCALE  = 
u"DefaultLocale";
-constexpr OUStringLiteral UPN_DEFAULT_LOCALE_CJK  = 
u"DefaultLocale_CJK";
-constexpr OUStringLiteral UPN_DEFAULT_LOCALE_CTL  = 
u"DefaultLocale_CTL";
-constexpr OUStringLiteral UPN_IS_HYPH_AUTO= u"IsHyphAuto";
-constexpr OUStringLiteral UPN_IS_HYPH_SPECIAL = 
u"IsHyphSpecial";
-constexpr OUStringLiteral UPN_IS_SPELL_AUTO   = u"IsSpellAuto";
-constexpr OUStringLiteral UPN_IS_SPELL_HIDE   = 
u"IsSpellHide";   /*! deprecated #i91949 !*/
-constexpr OUStringLiteral UPN_IS_SPELL_IN_ALL_LANGUAGES   = 
u"IsSpellInAllLanguages"; /*! deprecated #i91949 !*/
-constexpr OUStringLiteral UPN_IS_SPELL_SPECIAL= 
u"IsSpellSpecial";
-constexpr OUStringLiteral UPN_IS_WRAP_REVERSE = 
u"IsWrapReverse";
-constexpr OUStringLiteral UPN_DATA_FILES_CHANGED_CHECK_VALUE  = 
u"DataFilesChangedCheckValue";
+inline constexpr OUStringLiteral UPN_DEFAULT_LANGUAGE= 
u"DefaultLanguage";
+inline constexpr OUStringLiteral UPN_DEFAULT_LOCALE  = 
u"DefaultLocale";
+inline constexpr OUStringLiteral UPN_DEFAULT_LOCALE_CJK  = 
u"DefaultLocale_CJK";
+inline constexpr OUStringLiteral UPN_DEFAULT_LOCALE_CTL  = 
u"DefaultLocale_CTL";
+inline constexpr OUStringLiteral UPN_IS_HYPH_AUTO= 
u"IsHyphAuto";
+inline constexpr OUStringLiteral UPN_IS_HYPH_SPECIAL = 
u"IsHyphSpecial";
+inline constexpr OUStringLiteral UPN_IS_SPELL_AUTO   = 
u"IsSpellAuto";
+inline constexpr OUStringLiteral UPN_IS_SPELL_HIDE   = 
u"IsSpellHide";   /*! deprecated 

[Libreoffice-bugs] [Bug 145959] New: Context menu in Math text window doesn't stay if not enough space below cursor

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145959

Bug ID: 145959
   Summary: Context menu in Math text window doesn't stay if not
enough space below cursor
   Product: LibreOffice
   Version: 7.3.0.0.alpha1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Formula Editor
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com

Created attachment 176585
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176585=edit
Screen cast of bringing context menu in two positions

In Math' formula editing window, right-click to bring context menu.

1. If there's enough room *below* mouse cursor to fit the pop-up menu, it
appears under the cursor, and stays after you release the right mouse button,
allowing you to do the following clicks in normal way.

2. If there's not enough room *below* mouse cursor (e.g., the click is close to
the bottom of the screen), then the pop-up menu appears above the cursor (as
expected), but stays *only* as long as the right mouse button is pressed, and
immediately disappears as soon as the button is released.

See the screencast for clarification.

Tested with Version: 7.2.3.2 (x64) / LibreOffice Community
Build ID: d166454616c1632304285822f9c83ce2e660fd92
CPU threads: 12; OS: Windows 10.0 Build 19043; UI render: default; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

and current master.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/README.vars.md

2021-11-29 Thread Samuel Mehrbrodt (via logerrit)
 vcl/README.vars.md |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit e983cb3508e3735b28a5985e62b97e3bdc64fa88
Author: Samuel Mehrbrodt 
AuthorDate: Thu Nov 25 11:39:13 2021 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Tue Nov 30 08:41:04 2021 +0100

Document SAL_NO_MOUSEGRABS

Change-Id: I8c94f358111be231ae96a81da264a999c18a0a3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126079
Tested-by: Samuel Mehrbrodt 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/vcl/README.vars.md b/vcl/README.vars.md
index 7e0c3c2db0ad..c7971b734be0 100644
--- a/vcl/README.vars.md
+++ b/vcl/README.vars.md
@@ -23,6 +23,8 @@ will be used to write the log under `instdir/uitest/`.
 
 * `SAL_DISABLE_WATCHDOG` - don't start the thread that watches for broken 
GL/Vulkan/OpenCL drivers
 
+* `SAL_NO_MOUSEGRABS` - for debugging - stop blocking UI if a breakpoint is hit
+
 ## Gtk+
 
 * `VCL_GTK3_PAINTDEBUG` - in debug builds, if set to `1` then holding down 
`shift+0` forces a redraw event, `shift+1` repaints everything, and


[Libreoffice-bugs] [Bug 145677] remote RTF document size reported as 0

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145677

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from Dieter  ---
(In reply to Christopher Yeleighton from comment #0)
> LibreOffice Writer reports that the document License.rtf [1] has size ‘0 B’
> when opened directly from the Web.
> ___
> [1]  https://raw.githubusercontent.com/EWSoftware/VSSpellChecker/master/Source/
> VSSpellChecker2017and2019/License.rtf >

Link gives error message 404:not found => Could you please check it?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/vcl

2021-11-29 Thread Miklos Vajna (via logerrit)
 include/vcl/toolbox.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 3944dba0700bfbd2eb6184c279fbeef73891c675
Author: Miklos Vajna 
AuthorDate: Mon Nov 29 20:26:00 2021 +0100
Commit: Miklos Vajna 
CommitDate: Tue Nov 30 08:28:58 2021 +0100

vcl: document ToolBox

ToolBox is what other toolkits call a toolbar, it seems to me.

Change-Id: I8230570c4275625d1515ec6bbde1121d40c5d33f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126066
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx
index fe15d3b978f7..bddea3b01484 100644
--- a/include/vcl/toolbox.hxx
+++ b/include/vcl/toolbox.hxx
@@ -79,6 +79,8 @@ namespace std {
 }
 
 class Idle;
+
+/// A toolbar: contains all those icons, typically below the menu bar.
 class VCL_DLLPUBLIC ToolBox : public DockingWindow
 {
 friend class FloatingWindow;


[Libreoffice-bugs] [Bug 107923] [META] Zoom issues

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107923

Dieter  changed:

   What|Removed |Added

 Depends on||145675


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145675
[Bug 145675] COMMENTS: Zoom should zoom into/ focus caret position, if caret is
in comment box; not left page corner
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145675] COMMENTS: Zoom should zoom into/ focus caret position, if caret is in comment box; not left page corner

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145675

Dieter  changed:

   What|Removed |Added

 Blocks||106179, 107923
Summary|Zoom should zoom into/  |COMMENTS: Zoom should zoom
   |focus caret position; not   |into/ focus caret position,
   |right page corner   |if caret is in comment box;
   ||not left page corner
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter  ---
I confirm it with

Version: 7.2.3.2 (x64) / LibreOffice Community
Build ID: d166454616c1632304285822f9c83ce2e660fd92
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

But focus in zoom is left corner

It is related to cursor in comment box.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=106179
[Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107923
[Bug 107923] [META] Zoom issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106179

Dieter  changed:

   What|Removed |Added

 Depends on||145675


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145675
[Bug 145675] COMMENTS: Zoom should zoom into/ focus caret position, if caret is
in comment box; not left page corner
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145859] Can not download from Thai Website

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145859

--- Comment #4 from Buovjaga  ---
(In reply to Stephane from comment #3)
> https://mirror.cyberbits.asia website has been down for over a week
> 
> We can't download libreoffice from Thailand

This works fine for me:
https://mirror.cyberbits.asia/tdf/libreoffice/stable/7.2.2/win/x86_64/

Like Christian asked, please provide a URL that is broken for you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120276] [META] Embedded Calc table bugs and enhancements

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120276

Dieter  changed:

   What|Removed |Added

 Depends on||145613


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145613
[Bug 145613] Insert OLE Object as link not possible
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145613] Insert OLE Object as link not possible

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145613

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||120276, 107810
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de
 Whiteboard| QA:needsComment|

--- Comment #4 from Dieter  ---
I confirm it with

Version: 7.2.3.2 (x64) / LibreOffice Community
Build ID: d166454616c1632304285822f9c83ce2e660fd92
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

This happens also in SafeMode and with different Calc-documents.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107810
[Bug 107810] [META] OLE/Embedded object bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120276
[Bug 120276] [META] Embedded Calc table bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107810] [META] OLE/Embedded object bugs and enhancements

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107810

Dieter  changed:

   What|Removed |Added

 Depends on||145613


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145613
[Bug 145613] Insert OLE Object as link not possible
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||97639

--- Comment #8 from Heiko Tietze  ---
Can we open bsh/js in the same editor as Basic? Would solve this issue as well
as your bug 97638.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97639
[Bug 97639] [META] Beanshell Editor bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 97639] [META] Beanshell Editor bugs and enhancements

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=97639

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||145848


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145848
[Bug 145848] Don't close macro selector when editing macros
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

Heiko Tietze  changed:

   What|Removed |Added

 Blocks||97639

--- Comment #8 from Heiko Tietze  ---
Can we open bsh/js in the same editor as Basic? Would solve this issue as well
as your bug 97638.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=97639
[Bug 97639] [META] Beanshell Editor bugs and enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: connectivity/qa

2021-11-29 Thread Noel Grandin (via logerrit)
 connectivity/qa/connectivity/mysql/mysql.cxx |   11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 7e79b8c933516daed62382d0d60c34653ebedc4d
Author: Noel Grandin 
AuthorDate: Mon Nov 29 15:49:38 2021 +0200
Commit: Mike Kaganski 
CommitDate: Tue Nov 30 08:12:14 2021 +0100

fix mysqlc test after Sequence::operator[] change

Change-Id: I247aeceaa4100295beec8107385d2ae28765dde8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126054
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/connectivity/qa/connectivity/mysql/mysql.cxx 
b/connectivity/qa/connectivity/mysql/mysql.cxx
index 7a4267b5e95b..4b1a9a4e4f08 100644
--- a/connectivity/qa/connectivity/mysql/mysql.cxx
+++ b/connectivity/qa/connectivity/mysql/mysql.cxx
@@ -22,6 +22,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
@@ -101,16 +102,16 @@ void MysqlTestDriver::setUp()
 CPPUNIT_ASSERT_MESSAGE("no mysqlc component!", m_xMysqlcComponent.is());
 
 // set user name and password
-m_infos = Sequence{ 2 };
-m_infos[0].Name = OUString{ "user" };
 sal_Int32 nPer = m_sUrl.indexOf("/");
-m_infos[0].Value = makeAny(m_sUrl.copy(0, nPer));
+OUString sUsername = m_sUrl.copy(0, nPer);
 m_sUrl = m_sUrl.copy(nPer + 1);
-m_infos[1].Name = OUString{ "password" };
 sal_Int32 nAt = m_sUrl.indexOf("@");
-m_infos[1].Value = makeAny(m_sUrl.copy(0, nAt));
+OUString sPassword = m_sUrl.copy(0, nAt);
 m_sUrl = m_sUrl.copy(nAt + 1);
 
+m_infos = comphelper::InitPropertySequence(
+{ { "user", makeAny(sUsername) }, { "password", makeAny(sPassword) } 
});
+
 m_xDriver.set(m_xMysqlcComponent, UNO_QUERY);
 if (!m_xDriver.is())
 {


Re: Not sure how to make Libreoffice support non-English documents

2021-11-29 Thread Jun 711
Thank you. We gave that a try and it solved font issue as in previously,
all the converted text had the same font.
However, it still doesn't work for these languages: Chinese, Japanese,
Korean and Punjabi out of the 8 languages that we tested.
This is what we had in our test.docx. The converted pdf doesn't contain the
font of Chinese, Japanese, Korean and Punjabi. It seems fine for the other
4 languages.

```
Chinese: 这是一个测试
Japanese: これはテストです
Korean : 이것은 시험이다
Arabic: هذا اختبار
Russian: это проверка
Hebrew: זה מבחן
Greek: αυτό είναι ένα τεστ
Punjabi: ਇਹ ਇੱਕ ਟੈਸਟ ਹੈ
```

Is there anything we can modify in `share/registry/main.xcd` file like what
this user wrote in this thread:
https://ask.libreoffice.org/t/how-to-set-default-fontsize-without-gui/22545
?






On Fri, Nov 26, 2021 at 10:35 PM Ilmari Lauhakangas <
ilmari.lauhakan...@libreoffice.org> wrote:

> On 27.11.2021 3.21, Jun 711 wrote:
> > Hi,
> >
> > I followed the steps written in this repo to try to compile a compact
> > version of libreoffice that can convert non-English documents to PDFs.
> >
> https://github.com/vladgolubev/serverless-libreoffice/blob/master/Dockerfile
> > <
> https://github.com/vladgolubev/serverless-libreoffice/blob/master/Dockerfile
> >
> >
> > The compiled Libreoffice provided by Vlad Holubiev through the repo
> > works for English documents but not for non-English documents. I posted
> > a question on the repo but haven't got any response.
> > https://github.com/vladgolubev/serverless-libreoffice/issues/39
> > 
> >
> > I am not sure what flags to change. I found autogen.sh flags that he
> > posted but none of them seems to be for supporting non-English
> > languages.
> >
> https://github.com/vladgolubev/serverless-libreoffice/blob/master/autogen-help-output-6.2.1.2.txt
> > <
> https://github.com/vladgolubev/serverless-libreoffice/blob/master/autogen-help-output-6.2.1.2.txt
> >
> >
> > I have also tried to change the default font to Noto Sans following the
> > step mentioned in the libreoffice thread as it seems to be able to
> > support all languages but that didn't help.
> >
> https://ask.libreoffice.org/t/how-to-set-default-fontsize-without-gui/22545
> > <
> https://ask.libreoffice.org/t/how-to-set-default-fontsize-without-gui/22545
> >
> >
> > I wonder if anyone can give me a pointer on what I can try next?
>
> Looks like this is the culprit:
>
> https://github.com/vladgolubev/serverless-libreoffice/blob/7927017e96531b042b70f0de24be40fd88b44b63/Dockerfile#L110
>
> --without-fonts LibreOffice includes some third-party fonts to
> provide a reliable basis for help content, templates, samples, etc. When
> these fonts are already known to be available on the system then you
> should use this option.
>
> Obviously done to save disk space.
>
> So drop that option from the Dockerfile.
>
> Ilmari
>


[Libreoffice-ux-advise] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

--- Comment #7 from Samuel Mehrbrodt (allotropia) 
 ---
(In reply to Heiko Tietze from comment #6)
> By default we show the Object Catalog left of the editor. Is this sufficient?

Works for Basic, but not for Beanshell for example :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

--- Comment #7 from Samuel Mehrbrodt (allotropia) 
 ---
(In reply to Heiko Tietze from comment #6)
> By default we show the Object Catalog left of the editor. Is this sufficient?

Works for Basic, but not for Beanshell for example :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

--- Comment #6 from Heiko Tietze  ---
By default we show the Object Catalog left of the editor. Is this sufficient?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

--- Comment #6 from Heiko Tietze  ---
By default we show the Object Catalog left of the editor. Is this sufficient?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

--- Comment #5 from Samuel Mehrbrodt (allotropia) 
 ---
(In reply to Heiko Tietze from comment #4)
> Tools > Macro > Organize > Basic shows the organizer with a large tree with
> shipped macros. Select for example Gimmicks > Autotext and Edit. Open the
> navigator again and you get the tree at the same position. Seems reasonable
> to me. Or am I wrong?

Opening the macro dialog is cumbersome, since you have to navigate 3 menu
levels: Tools->Macros->Organize Macros->Basic.

If you want to edit several macros, this is really annoying, that the macro
organizer dialog just doesn't stay there.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145848] Don't close macro selector when editing macros

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145848

--- Comment #5 from Samuel Mehrbrodt (allotropia) 
 ---
(In reply to Heiko Tietze from comment #4)
> Tools > Macro > Organize > Basic shows the organizer with a large tree with
> shipped macros. Select for example Gimmicks > Autotext and Edit. Open the
> navigator again and you get the tree at the same position. Seems reasonable
> to me. Or am I wrong?

Opening the macro dialog is cumbersome, since you have to navigate 3 menu
levels: Tools->Macros->Organize Macros->Basic.

If you want to edit several macros, this is really annoying, that the macro
organizer dialog just doesn't stay there.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #18 from Mike Kaganski  ---
FTR: The solution implemented in the abovementioned commits is to pass
com.sun.star.view.PrintableState [1] value in the
com.sun.star.document.DocumentEvent struct's Supplement, passed as event
handler's argument. So the event handler could look like this:


> Sub OnPrintHandler(e)
>   If (e.Supplement = com.sun.star.view.PrintableState.JOB_STARTED) Then
> MsgBox("JOB_STARTED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_COMPLETED) Then
> MsgBox("JOB_COMPLETED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_SPOOLED) Then
> MsgBox("JOB_SPOOLED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_ABORTED) Then
> MsgBox("JOB_ABORTED")
>   ElseIf (e.Supplement = com.sun.star.view.PrintableState.JOB_FAILED) Then
> MsgBox("JOB_FAILED")
>   ElseIf (e.Supplement = 
> com.sun.star.view.PrintableState.JOB_SPOOLING_FAILED) Then
> MsgBox("JOB_SPOOLING_FAILED")
>   Else
> MsgBox(e.Supplement)
  EndIf
End Sub

Julien has removed one likely unnecessary notification, so the event is
generated twice instead of three times, as was noticed in comment 3. The two
other invocations are legitimate, and typically reflect JOB_STARTED then
JOB_SPOOLED, or JOB_STARTED then JOB_ABORTED. The handler should handle the
kind of event that it needs, based on the PrintableState, as shown above.

Interesting, if this is an API change. Also, it likely needs documentation.
Also, it might be possible in the future to re-consider what is put into
Supplement field, so user code should be prepared that Supplement may be empty
(as prior to the change), or numeric (as now), or maybe something else (a
struct?).

[1]
https://api.libreoffice.org/docs/idl/ref/namespacecom_1_1sun_1_1star_1_1view.html#ad9b0afaffefc166344fd9575516b6626

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143256] FILEOPEN XLSX Shapes on chart lose background color in RT file

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143256

Heiko Tietze  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #4 from Heiko Tietze  ---
Off-topic: Stumbled over this ticket searching for a way to insert random text
into a chart. Thought it could be done via shapes but I see no way to export
chart + shape/text on top. Am I missing something?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145953] Image ratio broken on resize when size is defined relative to entire page

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145953

--- Comment #4 from Rainer Bielefeld Retired  
---
Problems from (10) and (11) still REPRODUCIBLE with Server Installation of
Version: 7.4.0.0.alpha0+ (x64)  Build ID
ae36ee4f3aa544e53e2edad93d6d79160b27bc9d
CPU threads: 12; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
| Special devUserProfile | Locale: de-DE (de_DE); UI: de-DE | Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145953] Image ratio broken on resize when size is defined relative to entire page

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145953

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #3 from Rainer Bielefeld Retired  
---
REPRODUCIBLE with Installation of Version:7.2.1.2 (x64); Build ID:
87b77fad49947c1441b67c559c339af8f3517e22; CPU threads: 12; OS: Windows 10.0
Build 19042; UI render: Skia/Raster; VCL: win; Locale: de-DE (de_DE); UI:
de-DE; Calc: threaded  |  my default User Profile

I did some resize operations, all with bottom right corner grip (all length in
mm):
width   height  ratio
100,81  92,08   1,09  (original size)
156,39  133,65  1,17
19,49   14,85   1,31
187,1   145,54  1,29
8,415,941,42

You see any operation changed ratio between shown dimensions in Element
properties. Which seem to be correct at least for original size in document. 

But:
If you 
10. switch anchor to page in drawing properties, 
   » the image jumps to the top of the page, and it's obvious that size
 increases, 
 but in properties, when I uncheck "relative to", 
 I still see width = 100,29 mm and height = 92,52 mm.
 What is more or less the original size. 
11. And when I confirm with [ok] 
 the image will shrink to that size. 
But Dimensions after step 10 are wrong, real size was 123,9 / 106,9 mm

What might be a completely different bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 116438] Calc, Draw, Impress should also ask whether to apply orientation when an image is inserted

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=116438

himajin100...@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5819

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #17 from Commit Notification 
 ---
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/28eef82cb16faef0b8ddc9912560efb779baa9f9

tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListener

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sfx2/source

2021-11-29 Thread Mike Kaganski (via logerrit)
 sfx2/source/inc/eventsupplier.hxx|   14 +++---
 sfx2/source/notify/eventsupplier.cxx |   10 +-
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 28eef82cb16faef0b8ddc9912560efb779baa9f9
Author: Mike Kaganski 
AuthorDate: Tue Nov 30 00:08:57 2021 +0200
Commit: Mike Kaganski 
CommitDate: Tue Nov 30 06:21:14 2021 +0100

tdf#117280: derive SfxEvents_Impl from css::document::XDocumentEventListener

It abused XEventListener, and created a DocumentEvent object from
the incomplete data passed to notifyEvent in EventObject. That way,
the data initially created for the document event (in Supplement)
was lost on the way.

Change-Id: I409611482ce2323a3192c68f3525f450a9395815
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126090
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/inc/eventsupplier.hxx 
b/sfx2/source/inc/eventsupplier.hxx
index af3d5bf357d5..0bbd11ef1773 100644
--- a/sfx2/source/inc/eventsupplier.hxx
+++ b/sfx2/source/inc/eventsupplier.hxx
@@ -24,8 +24,8 @@
 
 #include 
 #include 
-#include 
-#include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -40,17 +40,17 @@ class SfxObjectShell;
 class SvxMacro;
 
 
-class SfxEvents_Impl final : public ::cppu::WeakImplHelper< 
css::container::XNameReplace, css::document::XEventListener  >
+class SfxEvents_Impl final : public ::cppu::WeakImplHelper< 
css::container::XNameReplace, css::document::XDocumentEventListener >
 {
 css::uno::Sequence< OUString > maEventNames;
 std::vector< css::uno::Any >   maEventData;
-css::uno::Reference< css::document::XEventBroadcaster >  mxBroadcaster;
+css::uno::Reference< css::document::XDocumentEventBroadcaster >  
mxBroadcaster;
 ::osl::MutexmaMutex;
 SfxObjectShell *mpObjShell;
 
 public:
 SfxEvents_Impl( SfxObjectShell* pShell,
-css::uno::Reference< 
css::document::XEventBroadcaster > const & xBroadcaster );
+css::uno::Reference< 
css::document::XDocumentEventBroadcaster > const & xBroadcaster );
virtual ~SfxEvents_Impl() override;
 
 //  --- XNameReplace ---
@@ -65,8 +65,8 @@ public:
 virtual css::uno::Type SAL_CALLgetElementType() override;
 virtual sal_Bool SAL_CALL   hasElements() override;
 
-// --- ::document::XEventListener ---
-virtual void SAL_CALL   notifyEvent( const css::document::EventObject& 
aEvent ) override;
+// --- ::document::XDocumentEventListener ---
+virtual void SAL_CALL documentEventOccured(const 
css::document::DocumentEvent& aEvent) override;
 
 // --- ::lang::XEventListener ---
 virtual void SAL_CALL   disposing( const css::lang::EventObject& 
Source ) override;
diff --git a/sfx2/source/notify/eventsupplier.cxx 
b/sfx2/source/notify/eventsupplier.cxx
index 00135b2a0654..08699ca70185 100644
--- a/sfx2/source/notify/eventsupplier.cxx
+++ b/sfx2/source/notify/eventsupplier.cxx
@@ -280,7 +280,7 @@ void SfxEvents_Impl::Execute( uno::Any const & aEventData, 
const document::Docum
 
 // --- ::document::XEventListener ---
 
-void SAL_CALL SfxEvents_Impl::notifyEvent( const document::EventObject& aEvent 
)
+void SAL_CALL SfxEvents_Impl::documentEventOccured( const 
document::DocumentEvent& aEvent )
 {
 ::osl::ClearableMutexGuard aGuard( maMutex );
 
@@ -292,7 +292,7 @@ void SAL_CALL SfxEvents_Impl::notifyEvent( const 
document::EventObject& aEvent )
 
 uno::Any aEventData = maEventData[ nIndex ];
 aGuard.clear();
-Execute( aEventData, document::DocumentEvent(aEvent.Source, 
aEvent.EventName, nullptr, uno::Any()), mpObjShell );
+Execute( aEventData, aEvent, mpObjShell );
 }
 
 
@@ -304,14 +304,14 @@ void SAL_CALL SfxEvents_Impl::disposing( const 
lang::EventObject& /*Source*/ )
 
 if ( mxBroadcaster.is() )
 {
-mxBroadcaster->removeEventListener( this );
+mxBroadcaster->removeDocumentEventListener( this );
 mxBroadcaster = nullptr;
 }
 }
 
 
 SfxEvents_Impl::SfxEvents_Impl( SfxObjectShell* pShell,
-uno::Reference< document::XEventBroadcaster > 
const & xBroadcaster )
+uno::Reference< 
document::XDocumentEventBroadcaster > const & xBroadcaster )
 {
 // get the list of supported events and store it
 if ( pShell )
@@ -325,7 +325,7 @@ SfxEvents_Impl::SfxEvents_Impl( SfxObjectShell* pShell,
 mxBroadcaster   = xBroadcaster;
 
 if ( mxBroadcaster.is() )
-mxBroadcaster->addEventListener( this );
+mxBroadcaster->addDocumentEventListener( this );
 }
 
 


[Libreoffice-bugs] [Bug 145700] FiLEOPEN DOC lighting direction has inverted z-direction for extruded custom shapes

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145700

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145697] UI: Minimum size of the sidebar in Draw shows a horizontal scrollbar

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145697

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145693] Chr and ChrW argument name does not match that of VBA

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145693

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145690] One view for "Properties", Formatvorlagen, Galery, Navigator, Page, Vorlagenkontrolle

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145690

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145689] Page style reverts to default when inserting a nested table

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145689

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145685] Formula cut when printing a big ODF file through LibreOffice Math

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145685

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145676] Enhancement: Insert cross-references to Headings in other subdocuments

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145676

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145676] Enhancement: Insert cross-references to Headings in other subdocuments

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145676

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145285] Cannot export: Exporting Drawing Crashes EVERY time on macOS

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145285

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145285] Cannot export: Exporting Drawing Crashes EVERY time on macOS

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145285

--- Comment #13 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132448] The first options, in the 'Crop' tab dialog box for an image (JPG) inserted in a text file (LibreOffice Writer), are always covered by some black artefacts

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132448

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132448] The first options, in the 'Crop' tab dialog box for an image (JPG) inserted in a text file (LibreOffice Writer), are always covered by some black artefacts

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132448

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 141717, which changed state.

Bug 141717 Summary: Fonts with lots of ligatures display incorrectly at big 
sizes
https://bugs.documentfoundation.org/show_bug.cgi?id=141717

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141717] Fonts with lots of ligatures display incorrectly at big sizes

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141717

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141717] Fonts with lots of ligatures display incorrectly at big sizes

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141717

--- Comment #3 from QA Administrators  ---
Dear Katie &,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 98274] Insert - Text from file should actually filter the file list instead of showing all files

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=98274

--- Comment #13 from QA Administrators  ---
Dear Stanislav Horacek,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 93259] Cannot correctly read cell alignments on simple spreadsheet

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=93259

--- Comment #7 from QA Administrators  ---
Dear Eric West,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91894] Impress Cut & paste of a line selects the whole table

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=91894

--- Comment #7 from QA Administrators  ---
Dear Philippe Jung,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 68472] UNDO incomplete: alignment not restored in cells after UNDO cells merge

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=68472

--- Comment #10 from QA Administrators  ---
Dear Mike Kaganski,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 44934] Select row; maximize spreadsheet; only part of the row is highlighted

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=44934

--- Comment #13 from QA Administrators  ---
Dear B.J. Herbison,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 55425] PDF import: support encryption algorithm value 4

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55425

Michael Warner  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |michael.warner.ut+libreoffi
   |desktop.org |c...@gmail.com
 Status|NEW |ASSIGNED

--- Comment #8 from Michael Warner  ---
I'll give it a try.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135384] Writer hangs on inserting ToC if "Enable cursor" is unchecked

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135384

R. Bingham  changed:

   What|Removed |Added

 CC||rdbing...@verizon.net

--- Comment #10 from R. Bingham  ---
Reporting similar behavior:
Version: 7.2.3.2 (x64) / LibreOffice Community
Build ID: d166454616c1632304285822f9c83ce2e660fd92
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

Steps to reproduce:
1) Open any Writer doc that already has any automated index table object
created through Insert->Table of Contents and Index.

2) Tools->Options->LO Writer->Formatting Aids->Protected Areas->check 'Enable
cursor' if not already checked. Note this Option setting is only available when
a Writer doc is open.

3) Placing the cursor over an index table object should not generate any
unusual behavior. If the index table object was defined for hyperlink
functionality of its line entries then cntrl-click jump behavior should work.

4) Tools->Options->LO Writer->Formatting Aids->Protected Areas->UNcheck 'Enable
cursor'.

5) Placing the cursor over an index table object or attempting the previously
working cntrl-click hyperlink functionality will result in an LO spin hang that
can only be killed via the Windows Task Manager or banging on the close window
'X.' Sometimes, merely applying OK in step 4 will cause a spin.

Regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145957] Writer swap the view for my font "Liberation Sans" to "Liberation Serif" if the shapes is define to Bold or Italic

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145957

--- Comment #3 from estienne.bl...@laposte.net ---
I have to complete my statements because I missed something important.
I think it is a font substitution error, because the columns of my tables were
resized during the interversion (see my window capture in the attachements).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145859] Can not download from Thai Website

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145859

--- Comment #3 from Stephane  ---
https://mirror.cyberbits.asia website has been down for over a week

We can't download libreoffice from Thailand

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145958] New: LibreOffice start menu opens, but won't open any document, new or existing

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145958

Bug ID: 145958
   Summary: LibreOffice start menu opens, but won't open any
document, new or existing
   Product: LibreOffice
   Version: 7.3.0.0.alpha1+
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kara.l.anderso...@gmail.com

Description:
Hi, I'm stumped by an issue I'm having with LibreOffice. As of yesterday, I
can't open any document, new or saved. The start menu will open, but when I
click a document to open it does nothing. When I try to open the document
directly from the file, without going through the LibreOffice start menu, it
will flash onto the screen as if it's going to open, and then disappear. When I
look in the task manager, there's nothing there.

I just uninstalled and reinstalled the latest version (as of this morning, Nov.
28 2021), and I have no updates for my OS (Windows 10).

I can't find any articles on the LibreOffice help pages or their forum
describing this problem, it seems like the most common problem is that the
application won't open at all.

I've tried opening it in safe mode through the command line, and resetting to
factory settings, with no luck.


more info:

- yes I've restarted my computer multiple times

- I've tried to open .odt and .docx files, to no avail

- LibreOffice info:

Version: 7.2.3.2 (x64) / LibreOffice Community

Build ID: d166454616c1632304285822f9c83ce2e660fd92

CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win

Locale: en-CA (en_CA); UI: en-US

Calc: threaded

Steps to Reproduce:
1. open application from link on desktop 
2. try to open a new file (of any type, writer, calc, etc.)
OR
1. Click to open a file directly from file explorer (LibreOffice is set to
default app)


Actual Results:
1. open application from link on desktop 
2. try to open a new file (of any type, writer, calc, etc.)
3. Nothing happens
OR
1. Click to open a file directly from file explorer (LibreOffice is set to
default app)
2. The screen flashed as if opening
3. Disappears, no task running in background.

Expected Results:
documents should open


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 7.2.3.2 (x64) / LibreOffice Community

Build ID: d166454616c1632304285822f9c83ce2e660fd92

CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win

Locale: en-CA (en_CA); UI: en-US

Calc: threaded


Based on recommendations from a Reddit post I made on r/LibreOffice I've tried:

"Try excluding soffice.bin from any AV (especially Defender) scanning.
EDIT: Also try turning off Skia."
- no change

"Shutdown Quickstarter, in taskbar, if running. Enable Show hidden files and
folders in Windows Folder options. Browse to:

C:\Users\Your Username\AppData\Roaming\LibreOffice

Copy the 4 folder to your desktop, then delete the entire 4 folder from the
above location. Try opening Writer or a document. If this works, your profile
folder (extensions, toolbar layouts templates etc.), is corrupted."
 - no change

And opening through the command line gives me no information

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131063] Navigate document content when selection is made by single click in the Navigator

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131063

--- Comment #10 from golemus  ---
> 1. >95% of the time, I use the navigator to quickly jump between headings in
> a large document. So, single-click > double-click (for me, at
> least). It may not seem like much of a difference, but over the course of
> multiple clicks, the additional hassle of a double-click really becomes
> noticeable.

+1. I almost never use navigator for anything else than jumping between
headings and double clicking makes it really annoying.

In addition to MS World the "jump with single click" behavior is also present
in Adobe Acrobat Reader when navigating PDF documents and Foxit Reader. So you
could almost state that jumping is single click de facto behaviour in document
navigators. I believe also that if you made a survey/questionnaire for document
editor users majority would vote for single click behaviour. 

If single click creates issues which some writes here said there is a simple
solution: introduce two different modes for navigator: "1. navigation mode",
"2. edit mode". There could be a button in toolbar of navigator where you
switch between the modes so everybody gets what they want.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143209] Edge Scrolling no longer works properly on my touchpad beginning with version 6.2 and newer.

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143209

--- Comment #4 from jeyov45...@sinagalore.com ---
I can confirm this behavior (scrolling down and right work, but up and left are
slower or impossible, depending on scroll speed)--it seems to be tracked
downstream by Red Hat here: https://bugzilla.redhat.com/show_bug.cgi?id=1686593

Investigating the code, my guess is that the way `ScGridWindow::ScrollPixel`
works, it resets the intra-cell scroll offsets to 0,0 (I can't tell if this
happens in `ScGridWindow::GetDrawMapMode` or in `ScGridWindow::ScrollPixel`, or
just by merit of not tracking pixel offsets when not in
`MapMode(MapUnit::MapPixel)` map mode). But it seems that this bug is a side
effect of the known hackiness (see comments in `ScGridWindow::GetDrawMapMode`
and `ScGridWindow::DrawContent`) of the way `ScGridWindow` does scrolling. It
might be possible to fix the directional asymmetry by simply making
`ScGridWindow::ScrollPixel` initialize its pixel offsets to the center of a
cell rather than the top-left before applying the scroll dx/dy it gets.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132448] The first options, in the 'Crop' tab dialog box for an image (JPG) inserted in a text file (LibreOffice Writer), are always covered by some black artefacts

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132448

--- Comment #5 from estienne.bl...@laposte.net ---
I'm now using the LibreOffice 7.2.3 x64 version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132448] The first options, in the 'Crop' tab dialog box for an image (JPG) inserted in a text file (LibreOffice Writer), are always covered by some black artefacts

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132448

--- Comment #4 from estienne.bl...@laposte.net ---
Hello,

First, I'm very sorry for the delay.
Of course I have tested many updates and I could confirm that the bug is
vanished now (for my case).

Thank you very much.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145957] Writer swap the view for my font "Liberation Sans" to "Liberation Serif" if the shapes is define to Bold or Italic

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145957

--- Comment #2 from estienne.bl...@laposte.net ---
Created attachment 176584
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176584=edit
Liberation Serif_applied

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145957] Writer swap the view for my font "Liberation Sans" to "Liberation Serif" if the shapes is define to Bold or Italic

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145957

--- Comment #1 from estienne.bl...@laposte.net ---
Created attachment 176583
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176583=edit
Liberation Sans Bold Italic_view

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145957] New: Writer swap the view for my font "Liberation Sans" to "Liberation Serif" if the shapes is define to Bold or Italic

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145957

Bug ID: 145957
   Summary: Writer swap the view for my font "Liberation Sans" to
"Liberation Serif" if the shapes is define to Bold or
Italic
   Product: LibreOffice
   Version: 7.2.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: estienne.bl...@laposte.net

Description:
Since I updated LibreOffice 7.2.1 to 7.2.3, all the text in all my tables into
Writer show the "Liberation Serif" font instead of "Liberation Sans" when their
shapes are set to Bold or Italic.
I tried to swap manually to another one, then back to "Liberation Sans", but in
vain.
After that, I verified the presence of the file :
"LiberationSans-BoldItalic.ttf" in my system, because my tables titles uses
Bold and Italic shape, and it is effectively in the regular path
"C:\Windows\Font\".
Then, I compared the shape of the font showed in Writer to try to identify the
font it really show instead, and think that it is "Liberation Serif", if I'm
not wrong.
The text in the regular shape seems not affected, only the Bold, Italic, or
Bold and Italic ones.
The same error appeared even outside of the tables.
I haven't tried printing, yet...
It's very frustrating because I intend to begin a migration process to exclude
step by step the non-free fonts I used previously as many other people.

Steps to Reproduce:
1. Type a text and choose the "Liberation Sans" font to apply.
2. Apply the shape Bold, or Italic, or Bold and Italic.
3. 

Actual Results:
The visualization change immediately to "Liberation Serif" instead of the
selected one "Liberation Sans", wich is always displayed and selected in the
toolbar.

Expected Results:
No visualisation of another font which is not selected and applied.


Reproducible: Always


User Profile Reset: No



Additional Info:
I have no further usefull informations to add.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145956] New: X and Y of property Origin of extruded custom shape are relative to bounding box

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145956

Bug ID: 145956
   Summary: X and Y of property Origin of extruded custom shape
are relative to bounding box
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de

Created attachment 176582
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176582=edit
extruded custom shape with bounding rectangle different from logical rectangle

In RTF and DOC, the properties c3DOriginX and c3DOriginY are relative to the
bounding box of the shape (enclosing rectangle of the actual drawing).
LibreOffice uses the logical rectangle of the shape (roughly what you see as
handles if you click on the shape). This origin determines the position of the
viewpoint.

The attached file has an extruded shape - based on a block arc, and a
screenshot of the shape in Word. The extruded shape has a wireframe surface, so
that the viewpoint can be better determined. Because origin is (0 0) here,
viewpoint X and Y equal origin. The viewpoint is nearer  to the shape (smaller
Z-component) as in default settings. That emphasizes the perspective.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145955] New: Duplicate IDs in ScriptForge Help Files

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145955

Bug ID: 145955
   Summary: Duplicate IDs in ScriptForge Help Files
   Product: LibreOffice
   Version: 7.2.0.0.alpha0+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: flywi...@gmail.com
CC: olivier.hal...@libreoffice.org

Same IDs are used throughout ScriptForge Help documentation. IDs are useless
unless they are unique. The effect is can't link to specific code examples
(same reference for multiple locations). eg:

hd_id831620312769993

1)
https://help.libreoffice.org/7.3/en-US/text/sbasic/shared/03/sf_ui.html?=BASIC=WIN#hd_id831620312769993

2)
https://help.libreoffice.org/7.3/en-US/text/sbasic/shared/03/sf_database.html?DbPAR=BASIC#hd_id831620312769993

Same for Basic: 

id191620312698501

https://help.libreoffice.org/7.3/en-US/text/sbasic/shared/03/sf_database.html?DbPAR=BASIC#hd_id191620312698501

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145819] at insert a rotated image, yes and no are reversed

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145819

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kelem...@ubuntu.com
   |desktop.org |
 Status|NEW |ASSIGNED

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Proposed patch: https://gerrit.libreoffice.org/c/core/+/126070

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138636] Writer frame addition/deletion is not change tracked

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138636

--- Comment #3 from Gabor Kelemen (allotropia)  ---
*** Bug 145942 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145942] Track changes doesn't register deletion of a frame

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145942

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||kelem...@ubuntu.com
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Something very similar is already reported, let's mark this a duplicate for
now.

*** This bug has been marked as a duplicate of bug 138636 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82627

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||5949

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136358] [META] ODF to OOXML shape export related issues

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=136358

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||145949


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145949
[Bug 145949] FILESAVE DOCX: Text outside Explosion shape on DOCX  (fine with
DOC)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145949] FILESAVE DOCX: Text outside Explosion shape on DOCX (fine with DOC)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145949

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Blocks||136358
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||627


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=136358
[Bug 136358] [META] ODF to OOXML shape export related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145949] FILESAVE DOCX: Text outside Explosion shape on DOCX (fine with DOC)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145949

--- Comment #4 from Gabor Kelemen (allotropia)  ---
Created attachment 176581
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176581=edit
The modified example and its reloaded docx version in 7.3

The shapes rotation seems to roundtrip correctly, but the textbox inside does
not. 
See also the topic of rotated frames: bug 82627 - this case is also a
consequence of that.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145910] Half the Slide Transitions do not work any more - Configuration

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145910

--- Comment #10 from Alistair Saywell  ---
Thank you so much.

I deleted the blacklist line in opengl_denylist_windows.xml and saved. Now on
LO 7.2.3.2 Impress all transitions work correctly.

As a check for tdf#131221, I opened Draw and Line thickness in Sidebar and in
Line and Filling toolbar work as expected too for both presets and custom line
width.

I will leave setting in opengl_denylist_windows.xml with line removed and see
if any problems arise.

Cheers, Al

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145949] FILESAVE DOCX: Text outside Explosion shape on DOCX (fine with DOC)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145949

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Created attachment 176580
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176580=edit
Docx export of the modified example file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145949] FILESAVE DOCX: Text outside Explosion shape on DOCX (fine with DOC)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145949

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com

--- Comment #2 from Gabor Kelemen (allotropia)  ---
Created attachment 176579
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176579=edit
Modified example file

Confirmed in 
Version: 7.3.0.0.alpha1+ / LibreOffice Community
Build ID: 59e70256a358db136f5fd23651aea96d218b1a64
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

This is because the red shape is rotated a bit "to the right".
If it's not, then the docx export works, as demonstrated by this extended
example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: configure.ac

2021-11-29 Thread Luboš Luňák (via logerrit)
 configure.ac |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit e9332dcdc8f2ea268d1b17c73d43a8834cf75365
Author: Luboš Luňák 
AuthorDate: Mon Nov 29 16:07:52 2021 +0100
Commit: Luboš Luňák 
CommitDate: Mon Nov 29 22:54:01 2021 +0100

explicitly check also for -fno-pch-codegen

The catch is that clang-cl does not know it, it only understands
-Xclang -fpch-codegen. On Linux -fno-pch-codegen is handled by
the driver, but clang-cl doesn't know the options, so we pass
to the backend using -Xclang, but that one understands only
-fpch-codegen. So if not found, do not use that option, the cost
is only that compiling precompiled_skia.cxx will take longer.

Change-Id: Ie307f96b381b732517a5ab574c742a2ee0bfb687
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126067
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/configure.ac b/configure.ac
index 65a38d685c73..140ee52e675f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6014,10 +6014,11 @@ if test -n "$BUILDING_PCH_WITH_OBJ"; then
 save_CFLAGS=$CFLAGS
 CFLAGS="$CFLAGS -Werror ${fpch_prefix}-fpch-codegen"
 AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],
-[
-PCH_CODEGEN="${fpch_prefix}-fpch-codegen"
-PCH_NO_CODEGEN="${fpch_prefix}-fno-pch-codegen"
-],[])
+[ PCH_CODEGEN="${fpch_prefix}-fpch-codegen" ],[])
+CFLAGS=$save_CFLAGS
+CFLAGS="$CFLAGS -Werror ${fpch_prefix}-fno-pch-codegen"
+AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[ return 0; ]])],
+[ PCH_NO_CODEGEN="${fpch_prefix}-fno-pch-codegen" ],[])
 CFLAGS=$save_CFLAGS
 if test -n "$PCH_CODEGEN"; then
 AC_MSG_RESULT(yes)


[Libreoffice-commits] core.git: sfx2/source

2021-11-29 Thread Mike Kaganski (via logerrit)
 sfx2/source/doc/sfxbasemodel.cxx |   11 ---
 1 file changed, 4 insertions(+), 7 deletions(-)

New commits:
commit 84783cc90b504b114f9adc94955253a5cf382abb
Author: Mike Kaganski 
AuthorDate: Mon Nov 29 22:41:51 2021 +0200
Commit: Mike Kaganski 
CommitDate: Mon Nov 29 22:50:33 2021 +0100

A small simplification

Change-Id: I222cb2cfcbd9d82c78fc17936f35ced0b21691b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126089
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 44cd4216bece..a0587f9bb079 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -2895,14 +2895,11 @@ void SfxBaseModel::Notify(  SfxBroadcaster& rBC 
,
 default: break;
 }
 
+Any aSupplement;
+if (const SfxPrintingHint* pPrintingHint = dynamic_cast())
+aSupplement <<= pPrintingHint->GetWhich();
 const SfxViewEventHint* pViewHint = dynamic_cast();
-if (pViewHint)
-{
-const SfxPrintingHint* pPrintingHint = dynamic_cast();
-postEvent_Impl( pNamedHint->GetEventName(), 
pViewHint->GetController(), pPrintingHint? Any(pPrintingHint->GetWhich()) : 
Any() );
-}
-else
-postEvent_Impl( pNamedHint->GetEventName(), Reference< 
frame::XController2 >() );
+postEvent_Impl( pNamedHint->GetEventName(), pViewHint ? 
pViewHint->GetController() : Reference< frame::XController2 >(), aSupplement );
 }
 
 if ( rHint.GetId() == SfxHintId::TitleChanged )


[Libreoffice-bugs] [Bug 145928] Crash mergedlo!SdrUndoObj::ImpShowPageOfThisObject+33 (SwpHints::Check(bool) ndhints.cxx:359)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145928

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisected
Version|7.3.0.0 alpha0+ |7.2.0.4 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144811] Align color items with "No fill" item in Autofilter's background and text color submenus

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144811

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
Caolan, could you please look at it? 
Is it possibly to align those color icons with the label "No fill" in only one
column. 
I ask because you made some days ago a nice work around this Autofilter's area.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145928] Crash mergedlo!SdrUndoObj::ImpShowPageOfThisObject+33 (SwpHints::Check(bool) ndhints.cxx:359)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145928

Telesto  changed:

   What|Removed |Added

 CC||michael.st...@allotropia.de

--- Comment #7 from Telesto  ---
Adding CC: to Michael Stahl

author  Michael Stahl  2021-03-08 20:03:35
+0100
committer   Michael Stahl  2021-03-15
10:15:57 +0100
commit  9bc6160e0acbc78be998129ea55ed7e4529959fa (patch)
treed07f099dbf264a24c4d291997637fc49d5ebbf96
parent  bfa320ef2ac7ab9a84f86eee6dfa7f3ee67fa630 (diff)
tdf#133487 sw ODF export: reorder flys' ZOrder/z-index...
... so background shapes have lower z-index than foreground shapes,
as is recommended by ODF 1.3.

Also let SdrObjList::sort() record Undo actions, because earlier Undo
actions could expect the previous sort order.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9bc6160e0acbc78be998129ea55ed7e4529959fa

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145937] Image does NOT "Keep ratio" if BOTH "Relative to" check-boxes are selected

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145937

--- Comment #9 from Telesto  ---
(In reply to Julien Nabet from comment #8)
> (In reply to Telesto from comment #7)
> > 1. Open the attached file
> > 3. Copy the image
> > 4. Paste one below (as reference)
> > 5. Select top image
> > ...
> 
> why not but above all, do you reproduce the initial pb with "Select “Keep
> ratio” as well as BOTH “Relative to” check-boxes" ?

Yes AR is off (but needs side by side view to tell in certain cases)
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ddc57169ac8d1de00403dbb09fef5221beaa0f3d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Also found in
3.5.7.2

Looks like rounding issues; changing width percentage changes height, height
doesn't have decimal level (rounding). Scaling back up, and everything is off?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145952] CRASH: pressing any arrow key after displaying autofilter dropdown (gen)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145952

--- Comment #2 from Caolán McNamara  ---
I can't reproduce this yet, but the title says (gen) and the comment #1 says
VCL: gtk3. Was it gen or gtk that crashes (though I tried both)?

If I click in A1 and the autofilter appears, I expect the focus to be in the
entry, i.e. the blinking cursor is active in the entry in the middle of the
dropdown, is that the case for you too?

Though I've also tried moving the focus to the treeview above it without any
crash on pressing arrows there either. I am checking with a later version which
had some follow up fixes, but not ones I'd expect to have an effect of key
handling, but I can recheck with the exact mentioned commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141090] Direct Cursor causes instant slowdown in v7.xx of Writer

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141090

Luboš Luňák  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||l.lu...@collabora.com

--- Comment #8 from Luboš Luňák  ---
I will most probably not backport this to 7.3 or 7.2, but for those a
workaround should be enabling Tools->Options->LibreOffice->View->Force Skia
software rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129062
Bug 129062 depends on bug 141090, which changed state.

Bug 141090 Summary: Direct Cursor causes instant slowdown in v7.xx of Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=141090

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145763] Opening previously password-protected Calc document directly from Spotlight fails

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145763

David Ruggiero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #4 from David Ruggiero  ---
Not a bug / NTF after update.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141090] Direct Cursor causes instant slowdown in v7.xx of Writer

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141090

--- Comment #7 from Commit Notification 
 ---
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f7a628f8efe037c1fd7e594eb4b8fc6a44573384

implement xor drawing directly using Skia (tdf#141090)

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141090] Direct Cursor causes instant slowdown in v7.xx of Writer

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141090

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145928] Crash mergedlo!SdrUndoObj::ImpShowPageOfThisObject+33 (SwpHints::Check(bool) ndhints.cxx:359)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145928

psidiumcode  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/skia vcl/inc vcl/skia vcl/unx

2021-11-29 Thread Luboš Luňák (via logerrit)
 external/skia/UnpackedTarball_skia.mk  |1 
 external/skia/allow-no-es2restrictions.patch.1 |   13 ++
 vcl/inc/skia/gdiimpl.hxx   |  123 ++---
 vcl/inc/skia/utils.hxx |5 
 vcl/inc/skia/x11/gdiimpl.hxx   |4 
 vcl/skia/SkiaHelper.cxx|   64 +++
 vcl/skia/gdiimpl.cxx   |  143 -
 vcl/unx/generic/gdi/salgdi.cxx |2 
 8 files changed, 193 insertions(+), 162 deletions(-)

New commits:
commit f7a628f8efe037c1fd7e594eb4b8fc6a44573384
Author: Luboš Luňák 
AuthorDate: Fri Nov 26 09:10:57 2021 +0100
Commit: Luboš Luňák 
CommitDate: Mon Nov 29 21:49:10 2021 +0100

implement xor drawing directly using Skia (tdf#141090)

Up until now this has been implemented like in almost all other VCL
backends by manually xor-ing pixel values. But that required fetching
pixel values from the GPU in Vulkan mode, which is relatively slow.
Since some time Skia now has supported writing custom blending modes
using the SkBlender class, so it's now possible to drop the hack
and support xor drawing directly using a blender that does
the operation. This should be both faster and simpler.

Change-Id: Id751d0ed4034852ce68697ecf56cc6dfac95307f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126051
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/external/skia/UnpackedTarball_skia.mk 
b/external/skia/UnpackedTarball_skia.mk
index c6e27ecf4183..cbaa37895061 100644
--- a/external/skia/UnpackedTarball_skia.mk
+++ b/external/skia/UnpackedTarball_skia.mk
@@ -37,6 +37,7 @@ skia_patches := \
 disable-freetype-colrv1.1 \
 windows-libraries-system32.patch.1 \
 fix-graphite-ifdef.patch.1 \
+allow-no-es2restrictions.patch.1 \
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,skia,1))
 
diff --git a/external/skia/allow-no-es2restrictions.patch.1 
b/external/skia/allow-no-es2restrictions.patch.1
new file mode 100644
index ..0195ad3d2ac8
--- /dev/null
+++ b/external/skia/allow-no-es2restrictions.patch.1
@@ -0,0 +1,13 @@
+diff --git a/include/effects/SkRuntimeEffect.h 
b/include/effects/SkRuntimeEffect.h
+index b3f21b1d58..dddc8d16dc 100644
+--- a/include/effects/SkRuntimeEffect.h
 b/include/effects/SkRuntimeEffect.h
+@@ -97,7 +97,7 @@ public:
+ // run the inliner directly, but they still get an inlining pass once 
they are painted.)
+ bool forceNoInline = false;
+ 
+-private:
++//private:
+ friend class SkRuntimeEffect;
+ friend class SkRuntimeEffectPriv;
+ 
diff --git a/vcl/inc/skia/gdiimpl.hxx b/vcl/inc/skia/gdiimpl.hxx
index cc4cda4b2ebd..2473d0918284 100644
--- a/vcl/inc/skia/gdiimpl.hxx
+++ b/vcl/inc/skia/gdiimpl.hxx
@@ -221,8 +221,8 @@ protected:
 void preDraw();
 // To be called after any drawing.
 void postDraw();
-// The canvas to draw to. Will be diverted to a temporary for Xor mode.
-SkCanvas* getDrawCanvas() { return mXorMode ? getXorCanvas() : 
mSurface->getCanvas(); }
+// The canvas to draw to.
+SkCanvas* getDrawCanvas() { return mSurface->getCanvas(); }
 // Call before makeImageSnapshot(), ensures the content is up to date.
 void flushDrawing();
 
@@ -261,22 +261,10 @@ protected:
 // Get the global HiDPI scaling factor.
 virtual int getWindowScaling() const;
 
-SkCanvas* getXorCanvas();
-void applyXor();
-// NOTE: This must be called before the operation does any drawing.
 void addUpdateRegion(const SkRect& rect)
 {
 // Make slightly larger, just in case (rounding, antialiasing,...).
 SkIRect addedRect = rect.makeOutset(2, 2).round();
-if (mXorMode)
-{
-// Two xor operations should cancel each other out. We batch xor 
operations,
-// but if they can overlap, apply xor now, since applyXor() does 
the operation
-// just once.
-if (mXorRegion.intersects(addedRect))
-applyXor();
-mXorRegion.op(addedRect, SkRegion::kUnion_Op);
-}
 // Using SkIRect should be enough, SkRegion would be too slow with 
many operations
 // and swapping to the screen is not _that_slow.
 mDirtyRect.join(addedRect);
@@ -308,31 +296,22 @@ protected:
 void performDrawPolyPolygon(const basegfx::B2DPolyPolygon& polygon, double 
transparency,
 bool useAA);
 
+// Create SkPaint to use when drawing to the surface. It is not to be used
+// when doing internal drawing such as when merging two bitmaps together.
+// This may apply some default settings to the paint as necessary.
+SkPaint makePaintInternal() const;
 // Create SkPaint set up for drawing lines (using mLineColor etc.).
-SkPaint makeLinePaint(double transparency = 0) const
-{
-assert(mLineColor != SALCOLOR_NONE);

[Libreoffice-commits] core.git: vcl/inc vcl/skia

2021-11-29 Thread Luboš Luňák (via logerrit)
 vcl/inc/skia/utils.hxx  |3 ---
 vcl/skia/SkiaHelper.cxx |   34 --
 vcl/skia/gdiimpl.cxx|7 ---
 3 files changed, 4 insertions(+), 40 deletions(-)

New commits:
commit 4a11c85baeb4998e12bc2ab45b0c23d7203bd5b0
Author: Luboš Luňák 
AuthorDate: Thu Nov 25 22:38:55 2021 +0100
Commit: Luboš Luňák 
CommitDate: Mon Nov 29 21:48:53 2021 +0100

remove Skia kDifference workaround

I thought it was a driver problem, but now I'm actually not sure,
as I cannot reproduce it anymore and I don't know if it was a driver
update or Skia update. Either way, this works now.

Also switch to kExclusion, because the end result is the same,
but this formula is simpler (to understand primarily, the performance
is going to be probably the same).

Change-Id: I6ced098ca4a3361cf98d3f9b32968c128eb9f299
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126050
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/inc/skia/utils.hxx b/vcl/inc/skia/utils.hxx
index 0583e9ceb624..ac8a185e711e 100644
--- a/vcl/inc/skia/utils.hxx
+++ b/vcl/inc/skia/utils.hxx
@@ -103,9 +103,6 @@ enum DirectImage
 No
 };
 
-// Do 'paint->setBlendMode(SkBlendMode::kDifference)' (workaround for buggy 
drivers).
-void setBlendModeDifference(SkPaint* paint);
-
 // Must be called in any VCL backend before any Skia functionality is used.
 // If not set, Skia will be disabled.
 VCL_DLLPUBLIC void
diff --git a/vcl/skia/SkiaHelper.cxx b/vcl/skia/SkiaHelper.cxx
index 631e5b64fe52..d082b6799129 100644
--- a/vcl/skia/SkiaHelper.cxx
+++ b/vcl/skia/SkiaHelper.cxx
@@ -644,45 +644,11 @@ tools::Long maxImageCacheSize()
 return officecfg::Office::Common::Cache::Skia::ImageCacheSize::get();
 }
 
-static sk_sp differenceBlender;
-
-void setBlendModeDifference(SkPaint* paint)
-{
-// This should normally do 
'paint->setBlendMode(SkBlendMode::kDifference);'.
-// But some drivers have a problem with this, namely currently AMD on 
Windows
-// (e.g. 'Vulkan API version: 1.2.170, driver version: 2.0.179, vendor: 
0x1002 (AMD),
-// device: 0x15dd, type: integrated, name: AMD Radeon(TM) Vega 8 Graphics')
-// simply crashes when kDifference is used.
-// Intel also had repaint problems with kDifference (tdf#130430), but it 
seems
-// those do not(?) exist anymore.
-// Interestingly, explicitly writing a shader that does exactly the same 
works fine,
-// so do that.
-if (!differenceBlender)
-{
-const char* const diff = R"(
-vec4 main( vec4 src, vec4 dst )
-{
-return vec4(abs( src.r - dst.r ), abs( src.g - dst.g ), abs( 
src.b - dst.b ), dst.a );
-}
-)";
-auto effect = SkRuntimeEffect::MakeForBlender(SkString(diff));
-if (!effect.effect)
-{
-SAL_WARN("vcl.skia",
- "SKRuntimeEffect::MakeForBlender failed: " << 
effect.errorText.c_str());
-abort();
-}
-differenceBlender = effect.effect->makeBlender(nullptr);
-}
-paint->setBlender(differenceBlender);
-}
-
 void cleanup()
 {
 sharedWindowContext.reset();
 imageCache.clear();
 imageCacheSize = 0;
-differenceBlender.reset();
 }
 
 static SkSurfaceProps commonSurfaceProps;
diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 3d7697c4dcfa..63d588aa913e 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -1507,7 +1507,10 @@ void SkiaSalGraphicsImpl::invert(basegfx::B2DPolygon 
const& rPoly, SalInvert eFl
 addUpdateRegion(aPath.getBounds());
 SkAutoCanvasRestore autoRestore(getDrawCanvas(), true);
 SkPaint aPaint;
-setBlendModeDifference();
+// There's no blend mode for inverting as such, but kExclusion is 's + d - 
2*s*d',
+// so with d = 1.0 (all channels) it becomes effectively '1 - s', i.e. 
inverted color.
+aPaint.setBlendMode(SkBlendMode::kExclusion);
+aPaint.setColor(SkColorSetARGB(255, 255, 255, 255));
 // TrackFrame just inverts a dashed path around the polygon
 if (eFlags == SalInvert::TrackFrame)
 {
@@ -1519,11 +1522,9 @@ void SkiaSalGraphicsImpl::invert(basegfx::B2DPolygon 
const& rPoly, SalInvert eFl
 constexpr float intervals[] = { 4.0f, 4.0f };
 aPaint.setStyle(SkPaint::kStroke_Style);
 aPaint.setPathEffect(SkDashPathEffect::Make(intervals, 
SK_ARRAY_COUNT(intervals), 0));
-aPaint.setColor(SkColorSetARGB(255, 255, 255, 255));
 }
 else
 {
-aPaint.setColor(SkColorSetARGB(255, 255, 255, 255));
 aPaint.setStyle(SkPaint::kFill_Style);
 
 // N50 inverts in checker pattern


[Libreoffice-bugs] [Bug 145937] Image does NOT "Keep ratio" if BOTH "Relative to" check-boxes are selected

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145937

--- Comment #8 from Julien Nabet  ---
(In reply to Telesto from comment #7)
> 1. Open the attached file
> 3. Copy the image
> 4. Paste one below (as reference)
> 5. Select top image
> ...

why not but above all, do you reproduce the initial pb with "Select “Keep
ratio” as well as BOTH “Relative to” check-boxes" ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145928] Crash mergedlo!SdrUndoObj::ImpShowPageOfThisObject+33 (SwpHints::Check(bool) ndhints.cxx:359)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145928

--- Comment #6 from psidiumcode  ---
Bisect log

# bad: [20651168152192ab9e0f9d12a94228b24125b0d4] source
sha:3d311c6d63eafbe2f76d6f1768dc3f675970a55a
# good: [7ae9dc0eb055b3d88573a247cf3f756b06ad5cad] source
sha:738bcf5e9a8c443d60c29c3a8068e8c16c72638a
git bisect start 'master' 'oldest'
# good: [de3791b1403f4e466497581e5a49f06f94701dbb] source
sha:9279dce41152ed692c125edfed4c80a7c28c7a0b
git bisect good de3791b1403f4e466497581e5a49f06f94701dbb
# bad: [14ed0e5dd6bcbf3b576c3c90234fa74af8013f55] source
sha:c889431df7e77c68fe7ead9aa235a5b2f586a4c6
git bisect bad 14ed0e5dd6bcbf3b576c3c90234fa74af8013f55
# bad: [4434fb63c739c2649022898bd73706ca7021a802] source
sha:2e8d635f7908497898c2d90b45070a3467fd15a5
git bisect bad 4434fb63c739c2649022898bd73706ca7021a802
# bad: [f7406c75c89086dabc151a226ef694d244c73847] source
sha:c0d223f7036263d3e7012d497ea71d4722052927
git bisect bad f7406c75c89086dabc151a226ef694d244c73847
# good: [69bf0590b48a8ee55106f45c613e7fe635d47009] source
sha:6db71f70a3b200d4074f6cda8ce445e9861d3296
git bisect good 69bf0590b48a8ee55106f45c613e7fe635d47009
# bad: [f520b1b2285359fda6f8964c977d6b1c7f666cdf] source
sha:95bb2a4fe05fe94029047d3165af21b56b7cd3e5
git bisect bad f520b1b2285359fda6f8964c977d6b1c7f666cdf
# good: [2ad29bdf4242774541107ddbe15a684a293dd3a3] source
sha:0a900287cff32c7fd94f498f8077a3a2d162e131
git bisect good 2ad29bdf4242774541107ddbe15a684a293dd3a3
# bad: [5e61548e179e51c0bd64acbd9ababd9e88a79eed] source
sha:ac0b6fb3842201e438950ea99a55ad334f8521ab
git bisect bad 5e61548e179e51c0bd64acbd9ababd9e88a79eed
# bad: [3bc68e6f10995fc7b415ab38a70b61393e0b4532] source
sha:56269c2856190d8ea2db561e13831f14af2aa7d7
git bisect bad 3bc68e6f10995fc7b415ab38a70b61393e0b4532
# bad: [73c98ab360ef700d1c73d24ae8731cc9f5f95840] source
sha:10f8764ff9c3945e3e51c7d483dc7a07bdea29f9
git bisect bad 73c98ab360ef700d1c73d24ae8731cc9f5f95840
# good: [70219a2372ef00047c23416172cc3ae5e0dda278] source
sha:bfa320ef2ac7ab9a84f86eee6dfa7f3ee67fa630
git bisect good 70219a2372ef00047c23416172cc3ae5e0dda278
# bad: [cf6b378428e918b5f1b524597b25220e79117b3d] source
sha:b4f38c6b8bbc6ea6a5d9354bfd24e411fc5a51fc
git bisect bad cf6b378428e918b5f1b524597b25220e79117b3d
# bad: [8827bdad94fb5f23cdaf31692e880911e40bd27b] source
sha:9bc6160e0acbc78be998129ea55ed7e4529959fa
git bisect bad 8827bdad94fb5f23cdaf31692e880911e40bd27b
# first bad commit: [8827bdad94fb5f23cdaf31692e880911e40bd27b] source
sha:9bc6160e0acbc78be998129ea55ed7e4529959fa

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145928] Crash mergedlo!SdrUndoObj::ImpShowPageOfThisObject+33 (SwpHints::Check(bool) ndhints.cxx:359)

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145928

psidiumcode  changed:

   What|Removed |Added

 CC||lbrmk.510@rgn4d.neomailbox.
   ||ch

--- Comment #5 from psidiumcode  ---
Bisected with mac64-7.2 repo

8827bdad94fb5f23cdaf31692e880911e40bd27b is the first bad commit
commit 8827bdad94fb5f23cdaf31692e880911e40bd27b
Author: libreoffice 
Date:   Sat Apr 10 03:10:17 2021 +0200

source sha:9bc6160e0acbc78be998129ea55ed7e4529959fa

source sha:9bc6160e0acbc78be998129ea55ed7e4529959fa

 .../Contents/Frameworks/libsvxcorelo.dylib | Bin 9088316 -> 9088316
bytes
 LibreOffice.app/Contents/Frameworks/libswlo.dylib  | Bin 18413728 -> 18424104
bytes
 LibreOffice.app/Contents/Frameworks/libxolo.dylib  | Bin 4853172 -> 4858348
bytes
 LibreOffice.app/Contents/Resources/setuprc |   2 +-
 LibreOffice.app/Contents/Resources/versionrc   |   2 +-
 5 files changed, 2 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145937] Image does NOT "Keep ratio" if BOTH "Relative to" check-boxes are selected

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145937

--- Comment #7 from Telesto  ---
1. Open the attached file
3. Copy the image
4. Paste one below (as reference)
5. Select top image
6. Press F4 type tab
7. Remember the existing width (A) & replace it with say 15
8. Press OK
9. F4 again
10. Restore the width to (A)
11. Press OK
12. Drag copy image over the resized image and notice differences

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145763] Opening previously password-protected Calc document directly from Spotlight fails

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145763

--- Comment #3 from David Ruggiero  ---
Ignore any references to Google Drive above - can reproduce problem even with
local folder that is not in any related to Google Drive. Appears to be a
LibreOffice issue alone.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145763] Opening previously password-protected Calc document directly from Spotlight fails

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145763

David Ruggiero  changed:

   What|Removed |Added

Summary|Opening previously  |Opening previously
   |password-protected Calc |password-protected Calc
   |document with Spotlight |document directly from
   |fails if doc is in mirrored |Spotlight fails
   |Google Drive folder |

--- Comment #2 from David Ruggiero  ---
Ignore any references to Google Drive.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117280

--- Comment #16 from Commit Notification 
 ---
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/20f56c937c44a9cbe3c05fa7c510feaf9d2341df

tdf#117280: fix multiple Macro execution when triggered by Document print event

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117280] Duplicate Macro execution when triggered by Document print event.

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117280

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0
   ||target:7.3.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/sfx2 sfx2/source

2021-11-29 Thread Julien Nabet (via logerrit)
 include/sfx2/sfxbasemodel.hxx|2 +-
 sfx2/source/doc/sfxbasemodel.cxx |   12 +---
 sfx2/source/view/viewprn.cxx |1 -
 3 files changed, 10 insertions(+), 5 deletions(-)

New commits:
commit 20f56c937c44a9cbe3c05fa7c510feaf9d2341df
Author: Julien Nabet 
AuthorDate: Mon Nov 29 10:18:52 2021 +0100
Commit: Mike Kaganski 
CommitDate: Mon Nov 29 21:36:40 2021 +0100

tdf#117280: fix multiple Macro execution when triggered by Document print 
event

Change-Id: Ibfebcc1a31464b2610afea2035e3d723a0c79167
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126018
Reviewed-by: Mike Kaganski 
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 
(cherry picked from commit 774c6a6e1603bf3f12f1573b0778e0f0f9783169)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126006
Tested-by: Jenkins

diff --git a/include/sfx2/sfxbasemodel.hxx b/include/sfx2/sfxbasemodel.hxx
index b55705b57e1d..8ccd59292e58 100644
--- a/include/sfx2/sfxbasemodel.hxx
+++ b/include/sfx2/sfxbasemodel.hxx
@@ -721,7 +721,7 @@ private:
 SAL_DLLPRIVATE void ListenForStorage_Impl( const css::uno::Reference< 
css::embed::XStorage >& xStorage );
 SAL_DLLPRIVATE OUString GetMediumFilterName_Impl() const;
 
-SAL_DLLPRIVATE void postEvent_Impl( const OUString& aName, const 
css::uno::Reference< css::frame::XController2 >& xController = 
css::uno::Reference< css::frame::XController2 >() );
+SAL_DLLPRIVATE void postEvent_Impl( const OUString& aName, const 
css::uno::Reference< css::frame::XController2 >& xController = 
css::uno::Reference< css::frame::XController2 >(), const css::uno::Any& 
aSupplement = css::uno::Any());
 
 SAL_DLLPRIVATE css::uno::Reference< css::frame::XTitle > 
impl_getTitleHelper ();
 SAL_DLLPRIVATE css::uno::Reference< css::frame::XUntitledNumbers > 
impl_getUntitledHelper ();
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 28afbd7e5bad..44cd4216bece 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -2896,7 +2896,13 @@ void SfxBaseModel::Notify(  SfxBroadcaster& rBC  
   ,
 }
 
 const SfxViewEventHint* pViewHint = dynamic_cast();
-postEvent_Impl( pNamedHint->GetEventName(), pViewHint ? 
pViewHint->GetController() : Reference< frame::XController2 >() );
+if (pViewHint)
+{
+const SfxPrintingHint* pPrintingHint = dynamic_cast();
+postEvent_Impl( pNamedHint->GetEventName(), 
pViewHint->GetController(), pPrintingHint? Any(pPrintingHint->GetWhich()) : 
Any() );
+}
+else
+postEvent_Impl( pNamedHint->GetEventName(), Reference< 
frame::XController2 >() );
 }
 
 if ( rHint.GetId() == SfxHintId::TitleChanged )
@@ -3223,7 +3229,7 @@ public:
 };
 } // anonymous namespace
 
-void SfxBaseModel::postEvent_Impl( const OUString& aName, const Reference< 
frame::XController2 >& xController )
+void SfxBaseModel::postEvent_Impl( const OUString& aName, const Reference< 
frame::XController2 >& xController, const Any& supplement )
 {
 // object already disposed?
 if ( impl_isDisposed() )
@@ -3245,7 +3251,7 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName, 
const Reference< frame
 {
 SAL_INFO("sfx.doc", "SfxDocumentEvent: " + aName);
 
-document::DocumentEvent aDocumentEvent( 
static_cast(this), aName, xController, Any() );
+document::DocumentEvent aDocumentEvent( 
static_cast(this), aName, xController, supplement );
 
 pIC->forEach< document::XDocumentEventListener, 
NotifySingleListenerIgnoreRE< document::XDocumentEventListener, 
document::DocumentEvent > >(
 NotifySingleListenerIgnoreRE< document::XDocumentEventListener, 
document::DocumentEvent >(
diff --git a/sfx2/source/view/viewprn.cxx b/sfx2/source/view/viewprn.cxx
index dbf84dde0d3c..f6cd8936ee84 100644
--- a/sfx2/source/view/viewprn.cxx
+++ b/sfx2/source/view/viewprn.cxx
@@ -313,7 +313,6 @@ void SfxPrinterController::jobStarted()
 
 xDocProps->setPrintDate( now.GetUNODateTime() );
 
-SfxGetpApp()->NotifyEvent( SfxEventHint(SfxEventHintId::PrintDoc, 
GlobalEventConfig::GetEventName( GlobalEventId::PRINTDOC ), mpObjectShell ) );
 uno::Sequence < beans::PropertyValue > aOpts;
 aOpts = getJobProperties( aOpts );
 


[Libreoffice-bugs] [Bug 140675] Calc clone style to multiple columns

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140675

Peter Hagen  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Peter Hagen  ---
Tested it in 7.2.3.2 and the bug seems to be resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145937] Image does NOT "Keep ratio" if BOTH "Relative to" check-boxes are selected

2021-11-29 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145937

Telesto  changed:

   What|Removed |Added

 Attachment #176577|0   |1
is obsolete||

--- Comment #6 from Telesto  ---
Created attachment 176578
  --> https://bugs.documentfoundation.org/attachment.cgi?id=176578=edit
Example file

Next try
1. Open the attached file
2. Enlarge the image by dragging one of the corners
3. Copy the image
4. Paste one below (as reference)
5. Select top image
6. Press F4 type tab
7. Remember the existing width (A) & replace it with say 15
8. Press OK
9. F4 again
10. Restore the width to (A)
11. Press OK

Notice the size difference 

Worst when using width 1%

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >