[Libreoffice-bugs] [Bug 143326] Crash in: google_breakpad::ExceptionHandler::HandlePureVirtualCall() FILESAVE
https://bugs.documentfoundation.org/show_bug.cgi?id=143326 Timur changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/unotest oox/qa sd/qa unotest/Library_unotest.mk unotest/source
include/unotest/macros_test.hxx|9 +
oox/qa/unit/export.cxx | 26 --
sd/qa/unit/sdmodeltestbase.hxx | 11 ---
unotest/Library_unotest.mk |1 +
unotest/source/cpp/macros_test.cxx | 17 +
5 files changed, 31 insertions(+), 33 deletions(-)
New commits:
commit fedf5599d7aa80bd5b794a5ea85111f014b782f8
Author: Miklos Vajna
AuthorDate: Thu Dec 2 08:45:26 2021 +0100
Commit: Xisco Fauli
CommitDate: Tue Jan 11 08:52:09 2022 +0100
test: move parseExportStream() from SdModelTestBaseXML up to MacrosTest
Move parseExportStream() from SdModelTestBaseXML up to MacrosTest,
so oox/ test code can use it as well.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126215
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
(cherry picked from commit f36767fde87191258ea21f3faac0be6ad79328e0)
Change-Id: I8ba7d6f3b535456ddaa7cd0f0bb5d56fce7a7766
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128173
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128255
Tested-by: Jenkins
diff --git a/include/unotest/macros_test.hxx b/include/unotest/macros_test.hxx
index 14917794d38d..ed879b835a55 100644
--- a/include/unotest/macros_test.hxx
+++ b/include/unotest/macros_test.hxx
@@ -28,11 +28,16 @@ struct TestMacroInfo
};
class BasicDLL;
+class SvStream;
namespace test
{
class Directories;
}
+namespace utl
+{
+class TempFile;
+}
namespace unotest
{
@@ -76,6 +81,10 @@ public:
const OUString& rCommand,
const css::uno::Sequence&
rPropertyValues);
+/// Opens rStreamName from rTempFile, assuming it's a ZIP storage.
+static std::unique_ptr parseExportStream(const utl::TempFile&
rTempFile,
+ const OUString&
rStreamName);
+
void setUpNssGpg(const test::Directories& rDirectories, const OUString&
rTestName);
void tearDownNssGpg();
diff --git a/oox/qa/unit/export.cxx b/oox/qa/unit/export.cxx
index b649d546ead9..280e052d09af 100644
--- a/oox/qa/unit/export.cxx
+++ b/oox/qa/unit/export.cxx
@@ -13,11 +13,9 @@
#include
#include
-#include
#include
#include
-#include
using namespace ::com::sun::star;
@@ -86,11 +84,7 @@ CPPUNIT_TEST_FIXTURE(Test, testPolylineConnectorPosition)
loadAndSave(aURL, "Office Open XML Text");
// Then make sure polyline and connector have the correct position.
-uno::Reference xNameAccess
-= packages::zip::ZipFileAccess::createWithURL(mxComponentContext,
getTempFile().GetURL());
-uno::Reference
xInputStream(xNameAccess->getByName("word/document.xml"),
- uno::UNO_QUERY);
-std::unique_ptr
pStream(utl::UcbStreamHelper::CreateStream(xInputStream, true));
+std::unique_ptr pStream = parseExportStream(getTempFile(),
"word/document.xml");
xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
// For child elements of groups in Writer the position has to be adapted
to be relative
@@ -117,11 +111,7 @@ CPPUNIT_TEST_FIXTURE(Test, testRotatedShapePosition)
loadAndSave(aURL, "Office Open XML Text");
// Then make sure the rotated child shape has the correct position.
-uno::Reference xNameAccess
-= packages::zip::ZipFileAccess::createWithURL(mxComponentContext,
getTempFile().GetURL());
-uno::Reference
xInputStream(xNameAccess->getByName("word/document.xml"),
- uno::UNO_QUERY);
-std::unique_ptr
pStream(utl::UcbStreamHelper::CreateStream(xInputStream, true));
+std::unique_ptr pStream = parseExportStream(getTempFile(),
"word/document.xml");
xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
// For a group itself and for shapes outside of groups, the position
calculation is done in
@@ -142,11 +132,7 @@ CPPUNIT_TEST_FIXTURE(Test, testDmlGroupshapePolygon)
// Then make sure that the group shape, the group shape's child size and
the child shape's size
// match:
-uno::Reference xNameAccess
-= packages::zip::ZipFileAccess::createWithURL(mxComponentContext,
getTempFile().GetURL());
-uno::Reference
xInputStream(xNameAccess->getByName("word/document.xml"),
- uno::UNO_QUERY);
-std::unique_ptr
pStream(utl::UcbStreamHelper::CreateStream(xInputStream, true));
+std::unique_ptr pStream = parseExportStream(getTempFile(),
"word/document.xml");
xmlDocUniquePtr pXmlDoc = parseXmlStream(pStream.get());
assertXPath(pXmlDoc, "//wpg:grpSpPr/a:xfrm/a:ext", "cx", "5328360");
// Without the accompanying fix in place, this test would have failed, the
element was
@@ -163,11 +149,7 @@ CPPUNIT_TEST_FIXTURE(Test, testCustomShapeArrowExport)
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/pview.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 98538ea2155274b4cdb66a5d4e46d221aec564d3
Author: Miklos Vajna
AuthorDate: Mon Jan 10 20:01:01 2022 +0100
Commit: Miklos Vajna
CommitDate: Tue Jan 11 08:23:33 2022 +0100
sw: document SwPagePreviewWin
SwPagePreviewWin is just a widget, owned by SwPagePreview, which is a
view shell (more or less an opened window).
Change-Id: I8f93ef354412273f85e9d4a5b375a3e2b7412221
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128261
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/source/uibase/inc/pview.hxx b/sw/source/uibase/inc/pview.hxx
index ec573024d206..5d749564f5e5 100644
--- a/sw/source/uibase/inc/pview.hxx
+++ b/sw/source/uibase/inc/pview.hxx
@@ -42,7 +42,7 @@ class CommandEvent;
class SvtAccessibilityOptions;
class SwPagePreviewLayout;
-// Delete member and its accessor
+/// Provides the VCL widget that is used for the main area of the File ->
Print Preview window.
class SAL_DLLPUBLIC_RTTI SwPagePreviewWin final : public vcl::Window
{
SwViewShell* mpViewShell;
[Libreoffice-bugs] [Bug 140557] NB Tabbed interface not using whole width of the NB to show controls
https://bugs.documentfoundation.org/show_bug.cgi?id=140557 Mike Kaganski changed: What|Removed |Added Keywords|bibisectRequest |bisected --- Comment #13 from Mike Kaganski --- Reverting https://git.libreoffice.org/core/+/53d73d532281b6734a7d4614bb74fc6cc15510f0, the problem disappears. > authorSzymon Kłos Wed Jun 03 15:26:50 > 2020 +0200 > notebookbar: simplify custom widgets Szymon: I see you are already in CC :-) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: external/icu
external/icu/UnpackedTarball_icu.mk |1 external/icu/icu4c-use-pkgdata-single-ccode-file-mode.patch.1 | 12 ++ 2 files changed, 13 insertions(+) New commits: commit a8bbd66011da4d9996f28a6ed06db10ed026312b Author: Jan-Marek Glogowski AuthorDate: Tue Jan 11 06:11:10 2022 +0100 Commit: Thorsten Behrens CommitDate: Tue Jan 11 08:16:18 2022 +0100 icu: always use USE_SINGLE_CCODE_FILE pkgdata mode The pkgdata tool basically not only generates the data, but forces a non-parallel build for all data files for platforms, which can't use the (single file) assembler mode. This hits the WASM build, bringing down the parallel build to a crawl. But there is already the "hidden" optimization implemented in pkgdata to just write a single C source file, instead of one per locale. For some reason, that is just enabled on OS400. I don't think we have a platform, which would have a memory restriction doing this, so just uncondition this pkgdata build mode for everyone. Feel free to otherwise condition this patch for your platform in external/icu/UnpackedTarball_icu.mk. Change-Id: I482d80e853128d00faa43687e38f5b88fbf6958c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128266 Tested-by: Jenkins Reviewed-by: Thorsten Behrens diff --git a/external/icu/UnpackedTarball_icu.mk b/external/icu/UnpackedTarball_icu.mk index c0ffe47dad3e..58a05f1ee39b 100644 --- a/external/icu/UnpackedTarball_icu.mk +++ b/external/icu/UnpackedTarball_icu.mk @@ -40,6 +40,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,icu,\ external/icu/icu4c-windows-cygwin-cross.patch.1 \ external/icu/icu4c-emscripten-cross.patch.1 \ external/icu/icu4c-khmerbreakengine.patch.1 \ + external/icu/icu4c-use-pkgdata-single-ccode-file-mode.patch.1 \ external/icu/icu4c-$(if $(filter ANDROID,$(OS)),android,rpath).patch.1 \ $(if $(filter-out ANDROID,$(OS)),external/icu/icu4c-icudata-stdlibs.patch.1) \ )) diff --git a/external/icu/icu4c-use-pkgdata-single-ccode-file-mode.patch.1 b/external/icu/icu4c-use-pkgdata-single-ccode-file-mode.patch.1 new file mode 100644 index ..237e554b8a4b --- /dev/null +++ b/external/icu/icu4c-use-pkgdata-single-ccode-file-mode.patch.1 @@ -0,0 +1,12 @@ +--- icu/source/tools/toolutil/pkg_genc.h.orig 2022-01-11 06:02:29.694678787 +0100 icu/source/tools/toolutil/pkg_genc.h 2022-01-11 06:02:41.602640965 +0100 +@@ -48,9 +48,7 @@ + * the data to generate the final data library. This can + * increase the performance of the pkdata tool. + */ +-#if U_PLATFORM == U_PF_OS400 + #define USE_SINGLE_CCODE_FILE +-#endif + + /* Need to fix the file seperator character when using MinGW. */ + #if defined(WINDOWS_WITH_GNUC) || defined(USING_CYGWIN)
[Libreoffice-bugs] [Bug 146436] Short freeze when going to next line with record track changes hidden (not shown)
https://bugs.documentfoundation.org/show_bug.cgi?id=146436 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de Whiteboard| QA:needsComment| Severity|normal |trivial Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Dieter --- I confirm it with Version: 7.2.5.2 (x64) / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: en-GB Calc: CL Additional informations Can't reproduce with an empty or very small document, but could reproduce with a 68 pages document. If changes are no recorded, freeze is in middle of the line. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146693] New: Calc crashes when/after changing a note
https://bugs.documentfoundation.org/show_bug.cgi?id=146693 Bug ID: 146693 Summary: Calc crashes when/after changing a note Product: LibreOffice Version: 7.2.5.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: winfrieddonk...@libreoffice.org Description: After changing the contents of a note attached to a cell in Calc and when starting to resize the note, Calc crashed. Steps to Reproduce: 1.Existing Calc document with multiline comment attached to a cell 2.Doublle click on comment to edit contents 3.Remove last line of comment 4.Click in any cell to close editing of comment 5.click on comment to start resizing 6.start to drag border 7.Calc crashes after step 6 or at the start of step 7 Actual Results: LibreOffice Crashed (2 Calc documents, 1 Writer document). After generating crash report and recovery of documents, the comment contents were as the should be (last line removed) and the border was as before (too wide for the new contents). Expected Results: A resized comment border and an uninterrupted availability of LibreOffice Reproducible: Didn't try User Profile Reset: No Additional Info: Crash report: https://crashreport.libreoffice.org/stats/crash_details/70d745aa-65a7-436e-af2b-b5b549f60b64 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: desktop/source
desktop/source/lib/init.cxx | 47
1 file changed, 47 insertions(+)
New commits:
commit 8de8abc5d26bfd0b3d7006d33a2231001ed77161
Author: Noel Grandin
AuthorDate: Mon Jan 10 15:27:48 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 11 07:50:33 2022 +0100
preload configmgr data for COOL
touch all the config data we need during LOK pre-init.
This means that most of the keys we need should become cached by
ConfigurationWrapper in comphelper.
Which means that the child processes we fork should be able to use the
shared pages and not allocate their own.
Change-Id: Iea8b1c4beaba67b6310b20cc161061ccf9a0db89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128247
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 407c1c0ebf33..16b06bf0e61a 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -179,6 +179,23 @@
#include "lokclipboard.hxx"
#include
#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
using namespace css;
using namespace vcl;
@@ -6412,6 +6429,36 @@ static void preloadData()
OutputDevice::GetDefaultFont(DefaultFontType::CTL_SPREADSHEET, nLang,
GetDefaultFontFlags::OnlyOne);
}
+std::cerr << "Preload config\n";
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-variable"
+#endif
+static SvtOptionsDialogOptions aDialogOptions;
+static SvtCTLOptions aSvtCTLOptions;
+static SvtAccessibilityOptions aSvtAccessibilityOptions;
+static svtools::ColorConfig aColorConfig;
+static SvtMiscOptions aSvtMiscOptions;
+static SvtSlideSorterBarOptions aSvtSlideSorterBarOptions;
+static SvtCommandOptions aSvtCommandOptions;
+static SvtCompatibilityOptions aSvtCompatibilityOptions;
+static SvtFilterOptions aSvtFilterOptions;
+static SvtLinguConfig aSvtLinguConfig;
+static SvtModuleOptions aSvtModuleOptions;
+static SvtPathOptions aSvtPathOptions;
+static SvtSearchOptions aSvtSearchOptions;
+static SvtSysLocaleOptions aSvtSysLocaleOptions;
+static SvtUserOptions aSvtUserOptions;
+//static SvtViewOptions aSvtViewOptions;
+static MouseSettings aMouseSettings;
+static StyleSettings aStyleSettings;
+static MiscSettings aMiscSettings;
+static HelpSettings aHelpSettings;
+static AllSettings aAllSettings;
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
+
// Set user profile's path back to the original one
rtl::Bootstrap::set("UserInstallation", sUserPath);
}
[Libreoffice-bugs] [Bug 140557] NB Tabbed interface not using whole width of the NB to show controls
https://bugs.documentfoundation.org/show_bug.cgi?id=140557 Mike Kaganski changed: What|Removed |Added Keywords||bibisected, ||bibisectRequest, regression --- Comment #12 from Mike Kaganski --- Bibisected with win64-7.1 bibisect repo to the range https://git.libreoffice.org/core/+log/1aa9a2ac5341d457bbdc00b987285203d11333f1..b5cb211f80fd87c109633232cf340ac7969c8648 But that is rather large range, so I put bibisectRequest, in the hope that maybe on Linux it would be possible to bibisect finer. One commit in the range that mentions "tabbed UI" is https://git.libreoffice.org/core/+/4fcf45bd1fb014a07fb062fb3ad1bd92427be9d8. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140557] NB Tabbed interface not using whole width of the NB to show controls
https://bugs.documentfoundation.org/show_bug.cgi?id=140557 Mike Kaganski changed: What|Removed |Added OS|Linux (All) |All Hardware|x86-64 (AMD64) |All --- Comment #11 from Mike Kaganski --- It is reproducible on Windows as well - despite claimed otherwise, it's confirmed there in bug 141465 comment 3, and also independently at https://forumooo.ru/index.php/topic,8982 (Rus). To reproduce reliably, make the LO Start Center window between 1090 and 1200 pixel wide, and then load/create a Calc document. (To control window width, you may e.g. make screenshots, then paste them to an image editor and check the width there, or use a screen ruler.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: dbaccess/source solenv/clang-format
dbaccess/source/shared/registrationhelper.cxx | 152 --
solenv/clang-format/excludelist |1
2 files changed, 153 deletions(-)
New commits:
commit 4af29b3e75dc7bf50309be726d02ed82cf962813
Author: Gabor Kelemen
AuthorDate: Mon Jan 10 08:56:54 2022 +0100
Commit: Noel Grandin
CommitDate: Tue Jan 11 07:22:02 2022 +0100
Drop unused file dbaccess/source/shared/registrationhelper.cxx
since commit d29a314300d523d29ed894f187497fcb68f8
Change-Id: I16c76e0cc56fe06d92fe37e38a5a4549fa205f83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128203
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/dbaccess/source/shared/registrationhelper.cxx
b/dbaccess/source/shared/registrationhelper.cxx
deleted file mode 100644
index 2c9fbc1f1042..
--- a/dbaccess/source/shared/registrationhelper.cxx
+++ /dev/null
@@ -1,152 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the "License"); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-// be included in other cxx files
-
-#ifndef REGISTRATIONHELPER_CXX_INCLUDED_INDIRECTLY_
-#error "don't build this file directly! use dbu_reghelper.cxx instead!"
-#endif
-
-using namespace ::com::sun::star;
-using namespace ::comphelper;
-using namespace ::cppu;
-
-uno::Sequence< OUString >*
OModuleRegistration::s_pImplementationNames = nullptr;
-uno::Sequence< uno::Sequence< OUString > >*
OModuleRegistration::s_pSupportedServices = nullptr;
-uno::Sequence< sal_Int64 >*
OModuleRegistration::s_pCreationFunctionPointers = nullptr;
-uno::Sequence< sal_Int64 >*
OModuleRegistration::s_pFactoryFunctionPointers = nullptr;
-
-void OModuleRegistration::registerComponent(
-const OUString& _rImplementationName,
-const uno::Sequence< OUString >& _rServiceNames,
-ComponentInstantiation _pCreateFunction,
-FactoryInstantiation _pFactoryFunction)
-{
-if (!s_pImplementationNames)
-{
-OSL_ENSURE(!s_pSupportedServices && !s_pCreationFunctionPointers &&
!s_pFactoryFunctionPointers,
-"OModuleRegistration::registerComponent : inconsistent state (the
pointers (1)) !");
-s_pImplementationNames = new uno::Sequence< OUString >;
-s_pSupportedServices = new uno::Sequence< uno::Sequence< OUString > >;
-s_pCreationFunctionPointers = new uno::Sequence< sal_Int64 >;
-s_pFactoryFunctionPointers = new uno::Sequence< sal_Int64 >;
-}
-OSL_ENSURE(s_pImplementationNames && s_pSupportedServices &&
s_pCreationFunctionPointers && s_pFactoryFunctionPointers,
-"OModuleRegistration::registerComponent : inconsistent state (the
pointers (2)) !");
-
-OSL_ENSURE( (s_pImplementationNames->getLength() ==
s_pSupportedServices->getLength())
-&& (s_pImplementationNames->getLength() ==
s_pCreationFunctionPointers->getLength())
-&& (s_pImplementationNames->getLength() ==
s_pFactoryFunctionPointers->getLength()),
-"OModuleRegistration::registerComponent : inconsistent state !");
-
-sal_Int32 nOldLen = s_pImplementationNames->getLength();
-s_pImplementationNames->realloc(nOldLen + 1);
-s_pSupportedServices->realloc(nOldLen + 1);
-s_pCreationFunctionPointers->realloc(nOldLen + 1);
-s_pFactoryFunctionPointers->realloc(nOldLen + 1);
-
-s_pImplementationNames->getArray()[nOldLen] = _rImplementationName;
-s_pSupportedServices->getArray()[nOldLen] = _rServiceNames;
-s_pCreationFunctionPointers->getArray()[nOldLen] =
reinterpret_cast(_pCreateFunction);
-s_pFactoryFunctionPointers->getArray()[nOldLen] =
reinterpret_cast(_pFactoryFunction);
-}
-
-void OModuleRegistration::revokeComponent(const OUString& _rImplementationName)
-{
-if (!s_pImplementationNames)
-{
-OSL_FAIL("OModuleRegistration::revokeComponent : have no class infos !
Are you sure called this method at the right time ?");
-return;
-}
-OSL_ENSURE(s_pImplementationNames && s_pSupportedServices &&
s_pCreationFunctionPointers && s_pFactoryFunctionPointers,
-"OModuleRegistration::revokeComponent : inconsistent state (the
[Libreoffice-bugs] [Bug 101435] [META] Template manager bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101435 Bug 101435 depends on bug 146375, which changed state. Bug 146375 Summary: Cannot rename user-defined categories in template manager https://bugs.documentfoundation.org/show_bug.cgi?id=146375 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146375] Cannot rename user-defined categories in template manager
https://bugs.documentfoundation.org/show_bug.cgi?id=146375 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: package/inc package/source
package/inc/ZipOutputEntry.hxx |2 +-
package/source/zipapi/ZipOutputEntry.cxx | 21 +++--
2 files changed, 8 insertions(+), 15 deletions(-)
New commits:
commit 5c00fadcc94bdfaefb9bee81a9bc610838fb9615
Author: Noel Grandin
AuthorDate: Sun Jan 9 20:37:22 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 11 07:19:25 2022 +0100
optimise and simplify ZipOutputEntryInThread
by just using the tempfile service as intended, we can stay
on the "happy path" which means that, on Windows, if there is
sufficient system RAM, the temporary file never even hits
the disk.
Change-Id: I3b27cf09bd40a4cfee01c23273af05860708a16f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128258
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/package/inc/ZipOutputEntry.hxx b/package/inc/ZipOutputEntry.hxx
index 9ef4466ed742..078c07359de5 100644
--- a/package/inc/ZipOutputEntry.hxx
+++ b/package/inc/ZipOutputEntry.hxx
@@ -110,7 +110,7 @@ protected:
class ZipOutputEntryInThread final : public ZipOutputEntry
{
class Task;
-OUString m_aTempURL;
+css::uno::Reference m_xTempFile;
std::exception_ptr m_aParallelDeflateException;
std::atomic m_bFinished;
diff --git a/package/source/zipapi/ZipOutputEntry.cxx
b/package/source/zipapi/ZipOutputEntry.cxx
index a30eba7c981c..734840865a14 100644
--- a/package/source/zipapi/ZipOutputEntry.cxx
+++ b/package/source/zipapi/ZipOutputEntry.cxx
@@ -250,17 +250,12 @@ ZipOutputEntryInThread::ZipOutputEntryInThread(
void ZipOutputEntryInThread::createBufferFile()
{
-assert(!m_xOutStream.is() && m_aTempURL.isEmpty() &&
+assert(!m_xOutStream && !m_xTempFile &&
"should only be called in the threaded mode where there is no
existing stream yet");
-uno::Reference < io::XTempFile > xTempFile(
+m_xTempFile.set(
io::TempFile::create(m_xContext),
uno::UNO_SET_THROW );
-xTempFile->setRemoveFile(false);
-m_aTempURL = xTempFile->getUri();
-assert(!m_aTempURL.isEmpty());
-
-uno::Reference < ucb::XSimpleFileAccess3 >
xTempAccess(ucb::SimpleFileAccess::create(m_xContext));
-m_xOutStream = xTempAccess->openFileWrite(m_aTempURL);
+m_xOutStream = m_xTempFile->getOutputStream();
}
void ZipOutputEntryInThread::closeBufferFile()
@@ -271,15 +266,13 @@ void ZipOutputEntryInThread::closeBufferFile()
void ZipOutputEntryInThread::deleteBufferFile()
{
-assert(!m_xOutStream.is() && !m_aTempURL.isEmpty());
-uno::Reference < ucb::XSimpleFileAccess3 >
xAccess(ucb::SimpleFileAccess::create(m_xContext));
-xAccess->kill(m_aTempURL);
+assert(!m_xOutStream.is() && m_xTempFile);
+m_xTempFile.clear();
}
uno::Reference< io::XInputStream > ZipOutputEntryInThread::getData() const
{
-uno::Reference < ucb::XSimpleFileAccess3 >
xTempAccess(ucb::SimpleFileAccess::create(m_xContext));
-return xTempAccess->openFileRead(m_aTempURL);
+return m_xTempFile->getInputStream();
}
class ZipOutputEntryInThread::Task : public comphelper::ThreadTask
@@ -313,7 +306,7 @@ private:
{
if (mpEntry->m_xOutStream.is())
mpEntry->closeBufferFile();
-if (!mpEntry->m_aTempURL.isEmpty())
+if (mpEntry->m_xTempFile)
mpEntry->deleteBufferFile();
}
catch (uno::Exception const&)
[Libreoffice-commits] core.git: sfx2/source unotools/source
sfx2/source/doc/doctemplates.cxx| 21 -
unotools/source/ucbhelper/xtempfile.cxx |6 ++
2 files changed, 14 insertions(+), 13 deletions(-)
New commits:
commit dd42f133f604ee2f7e0ffbca6a8d94fb8f95dfe5
Author: Noel Grandin
AuthorDate: Mon Jan 10 19:37:05 2022 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 11 07:19:02 2022 +0100
tdf#146375 Cannot rename user-defined categories in template manager
Regression from
commit 3624a703361b108d22448bd60a97733f05e37820
tdf#135316 remove OTempFileService pessimisation
So fix two things here
(1) make it so the tempfile service flushes the SvStream buffer
and resets the file position, so we can read the data
after writing it.
(2) Simplify the UCB usage to just write the contents of the tempfile
via the tempfile InputStream, which is simpler and safer
Change-Id: I15ed3b02c2d6415d10a9579f66374e6268188d5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128195
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/doc/doctemplates.cxx b/sfx2/source/doc/doctemplates.cxx
index 9ac236b3b4f4..cbdbe676f6f1 100644
--- a/sfx2/source/doc/doctemplates.cxx
+++ b/sfx2/source/doc/doctemplates.cxx
@@ -40,6 +40,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -231,7 +232,7 @@ class SfxDocTplService_Impl
const
OUString& aNewGroupName );
voidRemoveUINamesForTemplateDir_Impl( const OUString&
aUserPath,
std::u16string_view aGroupName );
-boolWriteUINamesForTemplateDir_Impl( const OUString&
aUserPath,
+boolWriteUINamesForTemplateDir_Impl(
std::u16string_view aUserPath,
const
std::vector< beans::StringPair >& aUINames );
OUStringCreateNewGroupFsys( const OUString& rGroupName,
Content& aGroup );
@@ -1264,7 +1265,7 @@ void
SfxDocTplService_Impl::RemoveUINamesForTemplateDir_Impl( const OUString& aU
}
-bool SfxDocTplService_Impl::WriteUINamesForTemplateDir_Impl( const OUString&
aUserPath,
+bool SfxDocTplService_Impl::WriteUINamesForTemplateDir_Impl(
std::u16string_view aUserPath,
const
std::vector< beans::StringPair >& aUINames )
{
bool bResult = false;
@@ -1273,10 +1274,7 @@ bool
SfxDocTplService_Impl::WriteUINamesForTemplateDir_Impl( const OUString& aUs
io::TempFile::create(mxContext),
uno::UNO_SET_THROW );
-OUString aTempURL = xTempFile->getUri();
-
-uno::Reference< io::XStream > xStream( xTempFile );
-uno::Reference< io::XOutputStream > xOutStream =
xStream->getOutputStream();
+uno::Reference< io::XOutputStream > xOutStream =
xTempFile->getOutputStream();
if ( !xOutStream.is() )
throw uno::RuntimeException();
@@ -1287,17 +1285,14 @@ bool
SfxDocTplService_Impl::WriteUINamesForTemplateDir_Impl( const OUString& aUs
} catch( uno::Exception& )
{}
-Content aTargetContent( aUserPath, maCmdEnv,
comphelper::getProcessComponentContext() );
-Content aSourceContent( aTempURL, maCmdEnv,
comphelper::getProcessComponentContext() );
-aTargetContent.transferContent( aSourceContent,
-InsertOperation::Copy,
-"groupuinames.xml",
-ucb::NameClash::OVERWRITE,
-"text/xml" );
+uno::Reference < ucb::XSimpleFileAccess3 >
xAccess(ucb::SimpleFileAccess::create(mxContext));
+xAccess->writeFile(OUString::Concat(aUserPath) + "groupuinames.xml",
xTempFile->getInputStream());
+
bResult = true;
}
catch ( uno::Exception& )
{
+TOOLS_WARN_EXCEPTION("sfx.doc", "");
}
return bResult;
diff --git a/unotools/source/ucbhelper/xtempfile.cxx
b/unotools/source/ucbhelper/xtempfile.cxx
index a8ace5da6725..a5772d8ba0c7 100644
--- a/unotools/source/ucbhelper/xtempfile.cxx
+++ b/unotools/source/ucbhelper/xtempfile.cxx
@@ -218,6 +218,12 @@ void SAL_CALL OTempFileService::closeOutput( )
throw css::io::NotConnectedException ( OUString(), static_cast <
css::uno::XWeak * > (this ) );
mbOutClosed = true;
+if (mpStream)
+{
+// so that if you then open the InputStream, you can read the content
+mpStream->FlushBuffer();
+mpStream->Seek(0);
+}
if ( mbInClosed )
{
[Libreoffice-bugs] [Bug 146375] Cannot rename user-defined categories in template manager
https://bugs.documentfoundation.org/show_bug.cgi?id=146375 --- Comment #3 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dd42f133f604ee2f7e0ffbca6a8d94fb8f95dfe5 tdf#146375 Cannot rename user-defined categories in template manager It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146375] Cannot rename user-defined categories in template manager
https://bugs.documentfoundation.org/show_bug.cgi?id=146375 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125477] Tabbed Compact NB incorrect refresh after using the ">>" to show hidden controls
https://bugs.documentfoundation.org/show_bug.cgi?id=125477 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0557 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140557] NB Tabbed interface not using whole width of the NB to show controls
https://bugs.documentfoundation.org/show_bug.cgi?id=140557 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5477 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 Bug 107237 depends on bug 142480, which changed state. Bug 142480 Summary: NB Tabbed UI does not expose controls to fit available frame size so too much blank space, exposure chevrons will fill out temporarily https://bugs.documentfoundation.org/show_bug.cgi?id=142480 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142480] NB Tabbed UI does not expose controls to fit available frame size so too much blank space, exposure chevrons will fill out temporarily
https://bugs.documentfoundation.org/show_bug.cgi?id=142480 Mike Kaganski changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Mike Kaganski --- *** This bug has been marked as a duplicate of bug 140557 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140557] NB Tabbed interface not using whole width of the NB to show controls
https://bugs.documentfoundation.org/show_bug.cgi?id=140557 Mike Kaganski changed: What|Removed |Added CC||johnmaveric...@mail.com --- Comment #10 from Mike Kaganski --- *** Bug 142480 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140857] LibreOffice's Tabbed Ribbon UI on macOS is ugly
https://bugs.documentfoundation.org/show_bug.cgi?id=140857 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3214 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 133214] UI: Icons of the tabbed toolbar aren't positioned properly on MacOS
https://bugs.documentfoundation.org/show_bug.cgi?id=133214 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||2422, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0857 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132422] macOS: Tabbed bar: Quick access icons and hamburger menu button are cut off by light grey bar
https://bugs.documentfoundation.org/show_bug.cgi?id=132422 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||3214 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146626] Calc crashes every time on font size operation, in a specific document
https://bugs.documentfoundation.org/show_bug.cgi?id=146626 --- Comment #6 from Timur --- User Profile Reset: Yes Your you really delete / rename your user profile? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144092] FILEOPEN PPTX: Empty table rows appear with lower height
https://bugs.documentfoundation.org/show_bug.cgi?id=144092 Justin L changed: What|Removed |Added CC||jl...@mail.com --- Comment #3 from Justin L --- There must be some secret formula that determines when to honour the a:tr h="xxx" specified row height, and when to ignore it. The documentation doesn't give any clues. 21.1.3.18 tr (Table Row) h (Height) Defines the height of the row in the table. The possible values for this attribute are defined by the ST_Coordinate simple type (sal_Int32) The values used are huge - defined as an EMU. L.4.1.1 EMU Unit of Measurement Throughout ECMA-376, the EMU is used as a unit of measurement for length. An EMU is defined as follows: 1 emu == 1/914400 inch == 1/36 cm -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146683] FILEOPEN: table in DOC text box is not imported properly - groupshape support
https://bugs.documentfoundation.org/show_bug.cgi?id=146683 --- Comment #2 from Timur --- There are screenshots im report, the links. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 47523] Functionality request for PIVOTTABLE: Add option for Pivot table will count empty cells in single-column data source
https://bugs.documentfoundation.org/show_bug.cgi?id=47523 --- Comment #18 from Felipe Lema --- Hello there I've changed the "yes/no ignore empty rows" bool to a "list, ignore or count" enum in the code However I'm having trouble understanding where/how to count the empty rows. I believe it should be done in `ScDpfilteredCache::fillTable(…)`, but I could use some help understanding the tree structures there (see https://opengrok.libreoffice.org/xref/core/sc/source/core/data/dpfilteredcache.cxx?r=f528fff9#95 ) It doesn't seem documented, so it's feels like I'm rummaging too much around here. And it seems I get more questions than answers (Why trees? Are tree items cells, rows? do row-col represent original data or pivoted data? is "(empty)" added within this method?) Anyway,a some pointer around this code would me appreciated (mayme counting should me done elsewhere) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 132518] PIVOTTABLE: Filter by year in Drop-down filter window doesn't work
https://bugs.documentfoundation.org/show_bug.cgi?id=132518 --- Comment #6 from Zayed --- (In reply to Zayed from comment #4) > I find a workaround for this issue as follows: > 1- edit the pivot table by right click on it and choose Proprieties. > 2- Drag the Date field from Filter section to Row Fields. Then click on OK. > 3- left click on any cells of Date, then from menu bar select "Data ---> > Group and Outline ---> Group". > 4- On the "Group by" section select "Years" only. Then click on "OK" > button. > 5- repeat steps 1 to 2 but now return Date field to the Filter Section. Then > OK button. > > Now you can filter by year in Drop-down filter. one more step, make sure the cells are Date not text. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sal/osl
sal/osl/unx/nlsupport.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 46b6ddc000a12795af361062bce471fa6e997d9a
Author: Jan-Marek Glogowski
AuthorDate: Mon Jan 10 10:38:52 2022 +0100
Commit: Jan-Marek Glogowski
CommitDate: Tue Jan 11 05:23:45 2022 +0100
Fix ISO C++11 -Wwritable-strings
osl/unx/nlsupport.cxx:863:18: warning: ISO C++11 does not allow \
conversion from string literal to 'char *' [-Wwritable-strings]
Change-Id: I45da986ad8992716df9d1f9a0cc443fdb9cd46ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128213
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/sal/osl/unx/nlsupport.cxx b/sal/osl/unx/nlsupport.cxx
index b1b1af706491..cc07a13805ba 100644
--- a/sal/osl/unx/nlsupport.cxx
+++ b/sal/osl/unx/nlsupport.cxx
@@ -848,10 +848,10 @@ void imp_getProcessLocale( rtl_Locale ** ppLocale )
/* No locale environment variables on Android, so why even bother
* with getenv().
*/
- char const * locale = "en-US.UTF-8";
+const char* locale = "en-US.UTF-8";
#else
/* simulate behavior off setlocale */
-char * locale = getenv( "LC_ALL" );
+const char* locale = getenv("LC_ALL");
if( NULL == locale )
locale = getenv( "LC_CTYPE" );
[Libreoffice-commits] core.git: Changes to 'feature/lok-calc-rtl'
New branch 'feature/lok-calc-rtl' available with the following commits: commit f2cef4ac748deb0b62a87f947124e854dabce67f Author: Dennis Francis Date: Mon Jan 10 12:03:54 2022 +0530 lokCalcRTL: fix chart insertion position Change-Id: I573cb19643d7a048f3313aba90fa9b5514c9cc74 commit 3074e72b4bc41cffbc4103b58132f430e5b0cc81 Author: Dennis Francis Date: Thu Jan 6 15:12:16 2022 +0530 lokCalcRTL: trim invalidation rect to ensure +ve X Change-Id: Ifecb52167e3cddee036e1e1e9bd5782a1138b654 commit 1aaa4c9f69216d91c87618d713e4b4b28183264c Author: Dennis Francis Date: Thu Jan 6 14:52:56 2022 +0530 lok: setClientZoom: check PPTX/Y approx equality too This is needed because the initial PPTX/Y on document load does not match the implied PPTX/Y corresponding to the client requested zoomX/Y. For instance when document is loaded by LOK client and 100% zoom is requested, the correct PPTX/Y should be (1/15 = 0.067) but the initial PPTX/Y on the ScViewData is 0.0647702 Change-Id: I996e9f003abd269df0994f3d114e42f84bb2bb20 commit 584d8e6d72b1e193446dfb1ae6a27251f43a6888 Author: Dennis Francis Date: Thu Jan 6 10:54:49 2022 +0530 lokCalcRTL: fix rendering of charts in edit mode Inform Sfx2InPlaceClient and LokChartHelper when negated X coordinates are used. Ensure that invalidation rectangles have positive coordinates in all cases. Change-Id: I8f5440718e288d8f0d379c8da5f49a29e51f6940 commit 82d55fe89ade80615b2e627cd7f734bd90b1edc9 Author: Dennis Francis Date: Tue Jan 4 14:20:41 2022 +0530 lokCalcRTL: negate mouse event X for chart and controls Change-Id: I389047140d1a3d2c67a861a3e20f799206d937b6 commit e33dec265006217d135248caf7af11f62a89d785 Author: Dennis Francis Date: Tue Jan 4 12:55:45 2022 +0530 lokCalcRTL: fix editing of shape text Inform editeng that negated document x coordinates are used in this case and ensure that editeng generated invalidation rectangles always have positive X coordinates. Change-Id: I2e450707ce02f7bcd8e4d299f857c37ebbd5e2c6 commit d48713f1b7a19df348bc051625a3b1a05538c5b6 Author: Dennis Francis Date: Mon Dec 6 13:55:43 2021 +0530 lokCalcRTL: shapes: negate mouse-event x coordinate Change-Id: I153334940b41859e6fd9dee64217925627f0f292 commit c03d1fe23e636bbdb10a594896b04cbfb91dfb41 Author: Dennis Francis Date: Mon Dec 6 13:42:27 2021 +0530 lokCalcRTL: shapes: do not send negative(X) invalidations LOK client expects tile invalidations in positive document coordinates irrespective of RTL flags. For this introduce a flag mbNegativeX in svx class SdrMarkView to indicate the case when all x coordinates are negated (this happens only for the LOK + Calc + RTL mode). Use this flag to counter negate the x coordinates before sending invalidation rectangles. Change-Id: I35d8142718b538e55b668a8ee18f3dd1fe433951 commit 459d96ed9f2f33d66c0b9f294c0f675a45e33c6b Author: Dennis Francis Date: Tue Nov 30 16:06:51 2021 +0530 lokCalcRTL: negate the +ve shape handle X coordinate... ...from lok client as all shape X coordinates are negative in lok-RTL mode. Change-Id: Ic4ba064888901109c85760bb0afda609b5d5942c commit 6f52126a2c3ad5b0bfbd3fa837cb2e1899c9701b Author: Dennis Francis Date: Tue Nov 30 13:42:33 2021 +0530 lokCalcRTL: RTL negation for shape insertion Change-Id: I8e3bb21fadd05a7b67acce34bfdc354fefba076b commit 04573cd2bb1db208d148ad2dd15d6e24a3764c9d Author: Dennis Francis Date: Thu Nov 25 17:38:14 2021 +0530 lokCalcRTL: shape selection: negate mouse X... as in LOK RTL mode draw objects have negated document X coordinate. Change-Id: Ie4c00fc0d1aa458a0aa6dd502be227cd6f82be3e commit aa20bd392136d1b9750367a2f9bcd4b4844f4511 Author: Dennis Francis Date: Mon Dec 13 11:36:53 2021 +0530 lokCalcRTL: ensure +ve X coords in shape handles/selections msgs LOK client expects all coordinates to be in +ve document coordinates, so negate the negative X coordinates of LOK RTL shapes before sending the selection/handles messages. Change-Id: I683581370c5b115efbe315224d6218ec2e74c7f1 commit efe73d172f45756f043e5f6a2500d8ca7b17474a Author: Dennis Francis Date: Thu Nov 25 16:02:35 2021 +0530 lokCalcRTL: adjustments for shapes rendering In LOK-RTL mode GetScrPos() always returns document pixel coordinates and not something mirrored w.r.t gridwindow width. * Grid offset must have the opposite sign since the SdrObjects/ranges have negative coordinates with no offset. * Drawing area rectangle and the pixel-offset for tile rendering device also needs adjustments when painting the drawing layers. Change-Id: I987a6876983aee129c06b3577918dbc62d6e7c4c commit 0c53b4e0a65bab1cb72cc73ac85553f32ae90adb Author: Dennis Francis Date: Wed Nov
[Libreoffice-bugs] [Bug 146673] H2 database - PUBLIC schema tables no longer displayed in UI
https://bugs.documentfoundation.org/show_bug.cgi?id=146673 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146605] Cannot change section footnote/endnote position after section is initially created
https://bugs.documentfoundation.org/show_bug.cgi?id=146605 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146438] X-Y (Scatter) chart type not being formed correctly by the Insert Chart wizard
https://bugs.documentfoundation.org/show_bug.cgi?id=146438 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146440] UNO: Formula vs FormulaLocal: inconsistent cell formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=146440 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146436] Short freeze when going to next line with record track changes hidden (not shown)
https://bugs.documentfoundation.org/show_bug.cgi?id=146436 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146430] Cannot apply edited master slide to selected/all slides
https://bugs.documentfoundation.org/show_bug.cgi?id=146430 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146419] The order in which hyperlinks are listed in Navigator is strange
https://bugs.documentfoundation.org/show_bug.cgi?id=146419 --- Comment #5 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/3e224dc4e49b2a016bb7502031f002517237bea0 tdf#134960 tdf#146419 use sorted array to list hyperlinks in Navigator It will be available in 7.3.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146419] The order in which hyperlinks are listed in Navigator is strange
https://bugs.documentfoundation.org/show_bug.cgi?id=146419 Commit Notification changed: What|Removed |Added Whiteboard|target:7.4.0|target:7.4.0 target:7.3.0.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139613] Image effects: moving images/text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=139613 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139613] Image effects: moving images/text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=139613 --- Comment #11 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129062] [META] Skia library bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=129062 Bug 129062 depends on bug 142835, which changed state. Bug 142835 Summary: Icons corrupted (only) on full screen https://bugs.documentfoundation.org/show_bug.cgi?id=142835 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142835] Icons corrupted (only) on full screen
https://bugs.documentfoundation.org/show_bug.cgi?id=142835 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142835] Icons corrupted (only) on full screen
https://bugs.documentfoundation.org/show_bug.cgi?id=142835 --- Comment #3 from QA Administrators --- Dear NKT, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136154] valor de célula duplicado no libre office calc
https://bugs.documentfoundation.org/show_bug.cgi?id=136154 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136154] valor de célula duplicado no libre office calc
https://bugs.documentfoundation.org/show_bug.cgi?id=136154 --- Comment #7 from QA Administrators --- Dear Anderson Sirtolli, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143365] installing office in windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=143365 --- Comment #2 from QA Administrators --- Dear Shivpalsinh, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143337] I finished the F7 correction and upon finish it crashed
https://bugs.documentfoundation.org/show_bug.cgi?id=143337 --- Comment #3 from QA Administrators --- Dear nochnichtverwendetername2, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143336] Crash in: libc-2.31.so
https://bugs.documentfoundation.org/show_bug.cgi?id=143336 --- Comment #2 from QA Administrators --- Dear r01abi17, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source
sw/source/uibase/utlui/content.cxx | 37 ++---
1 file changed, 22 insertions(+), 15 deletions(-)
New commits:
commit 3e224dc4e49b2a016bb7502031f002517237bea0
Author: Jim Raykowski
AuthorDate: Sat Jan 1 16:46:00 2022 -0900
Commit: Adolfo Jayme Barrientos
CommitDate: Tue Jan 11 04:53:00 2022 +0100
tdf#134960 tdf#146419 use sorted array to list hyperlinks in Navigator
in document order
The current approach of using layout position to list hyperlinks in
document order works for single-page view but not for multiple-page or
book view. This patch makes the list order layout independent by using
SwPositions to sort the hyperlinks in document order.
Change-Id: Ie09ac362aa0e8db813430de50c7f06f3072179f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127856
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
(cherry picked from commit 1aa49bb9cf2b960312bf1e65ea1eee2521873a16)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128227
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 5cfa0b7bcadc..586f8c1bc615 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -186,23 +186,30 @@ namespace
{
SwGetINetAttrs aArr;
pWrtShell->GetINetAttrs( aArr );
-const SwGetINetAttrs::size_type nCount {aArr.size()};
-for( SwGetINetAttrs::size_type n = 0; n < nCount; ++n )
+
+// use stable sort array to list hyperlinks in document order
+std::vector aStableSortINetAttrsArray;
+for (SwGetINetAttr& r : aArr)
+aStableSortINetAttrsArray.emplace_back();
+std::stable_sort(aStableSortINetAttrsArray.begin(),
aStableSortINetAttrsArray.end(),
+ [](const SwGetINetAttr* a, const SwGetINetAttr* b){
+SwPosition
aSwPos(const_cast(a->rINetAttr.GetTextNode()),
+ a->rINetAttr.GetStart());
+SwPosition
bSwPos(const_cast(b->rINetAttr.GetTextNode()),
+ b->rINetAttr.GetStart());
+return aSwPos < bSwPos;});
+
+SwGetINetAttrs::size_type n = 0;
+for (auto p : aStableSortINetAttrsArray)
{
-SwGetINetAttr* p = [ n ];
-tools::Long nYPos =
p->rINetAttr.GetTextNode().FindLayoutRect().Top()
-+ p->rINetAttr.GetStart();
-std::unique_ptr pCnt(new SwURLFieldContent(
-pCntType,
-p->sText,
-INetURLObject::decode(
-p->rINetAttr.GetINetFormat().GetValue(),
-
INetURLObject::DecodeMechanism::Unambiguous ),
->rINetAttr,
-nYPos));
-pMember->insert( std::move(pCnt) );
+auto pCnt = make_unique(
+pCntType, p->sText,
+
INetURLObject::decode(p->rINetAttr.GetINetFormat().GetValue(),
+
INetURLObject::DecodeMechanism::Unambiguous),
+>rINetAttr, ++n);
+pMember->insert(std::move(pCnt));
}
-return nCount;
+return pMember->size();
}
}
[Libreoffice-bugs] [Bug 141996] Writer closing alone
https://bugs.documentfoundation.org/show_bug.cgi?id=141996 --- Comment #4 from QA Administrators --- Dear Renato, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146692] New: Problems related to pasted shapes in LibreOffice Witer
https://bugs.documentfoundation.org/show_bug.cgi?id=146692 Bug ID: 146692 Summary: Problems related to pasted shapes in LibreOffice Witer Product: LibreOffice Version: 6.4 all versions Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: haruco...@gmail.com Description: There is a shape pasted near the beginning of the page in LibreOffice Witer. Paste the shape created by Libre Office Draw on the page after that shape. Move the pasted shape. Press Ctrl + Z. Then, the shape pasted at the beginning of the page will move to the shape pasted in Libre Office Dwaw. * Creating with Libre Office Draw may not be relevant. It is a behavior that Ctrl + Z is related after selecting a figure. Actual Results: There is a shape pasted near the beginning of the page in LibreOffice Witer. Paste the shape created by Libre Office Draw on the page after that shape. Move the pasted shape. Press Ctrl + Z. Then, the shape pasted at the beginning of the page will move to the shape pasted in Libre Office Dwaw. * Creating with Libre Office Draw may not be relevant. It is a behavior that Ctrl + Z is related after selecting a figure. Expected Results: There is a shape pasted near the beginning of the page in LibreOffice Witer. Paste the shape created by Libre Office Draw on the page after that shape. Move the pasted shape. Press Ctrl + Z. Then, the shape pasted at the beginning of the page will move to the shape pasted in Libre Office Dwaw. * Creating with Libre Office Draw may not be relevant. It is a behavior that Ctrl + Z is related after selecting a figure. Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: There is a shape pasted near the beginning of the page in LibreOffice Witer. Paste the shape created by Libre Office Draw on the page after that shape. Move the pasted shape. Press Ctrl + Z. Then, the shape pasted at the beginning of the page will move to the shape pasted in Libre Office Dwaw. * Creating with Libre Office Draw may not be relevant. It is a behavior that Ctrl + Z is related after selecting a figure. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146691] New: :
https://bugs.documentfoundation.org/show_bug.cgi?id=146691 Bug ID: 146691 Summary: : Product: LibreOffice Version: 7.1.8.1 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: schira...@fastmail.com.au Version: 7.1.8.1 (x64) / LibreOffice Community Build ID: e1f30c802c3269a1d052614453f260e49458c82c CPU threads: 6; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: en-AU (en_AU); UI: en-US Calc: threaded Problem: Case where cannot create a Copy of an existing Sheet. Scenario: 1. Double-click on my existing abc.csv file s.t. Calc is launched. 2. Accept offered (csv) import settings. 2.1 See that the file has been imported okay. 3. Rename 'Sheet1' to "shortName". 4. Save file via "Save As..." to abc.ods (i.e. a new file is created). 5. Close Calc. 6. Double-click on abc.ods file to open in Calc. 7. Right-click on "shortName" sheet Tab and choose "Move or Copy Sheet..." item. 8. Problem is now visible!! It is not possible to select Move or Copy radio items! Remarks: Have discovered that the Move/Copy radio items WILL BECOME SELECTABLE after a New Sheet is added, via Insert Sheet..., to the workbook. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146673] H2 database - PUBLIC schema tables no longer displayed in UI
https://bugs.documentfoundation.org/show_bug.cgi?id=146673 --- Comment #7 from Evgenij Ryazanov --- Hello! This issue doesn't look like being related with schema name or something like it. Tables from INFORMATION_SCHEMA are also missing, as you can see on screenshot here: https://github.com/h2database/h2database/issues/3351 LibreOffice can see only views, but this schema also contains various tables, the complete list of tables and views in this schema is here: https://h2database.com/html/systemtables.html#information_schema_tables DatabaseMetaData.getTables() in H2 returns the same type of tables as listed in INFORMATION_SCHEMA.TABLES.TABLE_TYPE. H2 1.4 (incorrectly) returns TABLE, TABLE LINK, SYSTEM TABLE, or EXTERNAL for tables and VIEW for views in this table. H2 2.0 by default returns BASE TABLE, GLOBAL TEMPORARY, or LOCAL TEMPORARY for tables and VIEW for views as required by SQL/Schemata part of the SQL Standard (Standard also has SYSTEM VERSIONED, but H2 2.0 doesn't support these tables). DatabaseMetaData.getTableTypes() in both H2 1.4 and H2 2.0 correctly reports available table types. JDBC (unlike the SQL Standard) doesn't require any specific table types, it only provides some possible examples and they look like being collected from few database systems with their vendor-specific extensions like SYNONYM. I think LibreOffice should support tables of any types reported by getTableTypes(). Currently it somehow filters out tables with BASE TABLE type and possibly other valid types, but accepts TABLE and VIEW types. Such implementation doesn't look like being correct, because there are various possible compliant with JDBC types. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=146682
--- Comment #10 from Hossein ---
Created attachment 177451
--> https://bugs.documentfoundation.org/attachment.cgi?id=177451=edit
Minimal svg for the first example
http://www.w3.org/2000/svg;
xmlns="http://www.w3.org/2000/svg;
width="10cm"
height="6cm"
version="1.1">
text {font-weight: bold;}
.red {fill:red;}
.blue {font-style: italic; fill:blue; font-weight: normal;}
Wenn Unternehmen sich
übernehmen
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146673] H2 database - PUBLIC schema tables no longer displayed in UI
https://bugs.documentfoundation.org/show_bug.cgi?id=146673 --- Comment #6 from Maciej Morycinski --- How is this esoteric workaround communicated to novice-level users of Base like myself, without them having to google Libreoffice bugs specifically? I mean, I had no idea that "table types" are a thing, so how do I discover that they may not be allowed/be part of a regression/need an extra parameter added at H2 end etc.? I really would not bother to report this bug if it were just for my own benefit. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146684] Libvisio: imported images from vsdx are black
https://bugs.documentfoundation.org/show_bug.cgi?id=146684 Aron Budea changed: What|Removed |Added Resolution|--- |DUPLICATE Status|UNCONFIRMED |RESOLVED CC||ba...@caesar.elte.hu --- Comment #1 from Aron Budea --- This is a duplicate of bug 73523, and should be fine now in a recent LO daily build. *** This bug has been marked as a duplicate of bug 73523 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138418] Please improve the "color" attribute section of Math documentation
https://bugs.documentfoundation.org/show_bug.cgi?id=138418 Rafael Lima changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |rafael.palma.l...@gmail.com |desktop.org | --- Comment #2 from Rafael Lima --- Proposed patch is available for review: https://gerrit.libreoffice.org/c/help/+/128240 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146690] FILESAVE PPTX: Textbox with only newlines doesn't preserve text size on save
https://bugs.documentfoundation.org/show_bug.cgi?id=146690 Sarper Akdemir changed: What|Removed |Added Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |sarper.akde...@collabora.co |desktop.org |m Status|UNCONFIRMED |ASSIGNED --- Comment #1 from Sarper Akdemir --- Created attachment 177448 --> https://bugs.documentfoundation.org/attachment.cgi?id=177448=edit Reproducer from PowerPoint with textbox that changes size on roundtrip -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146690] New: FILESAVE PPTX: Textbox with only newlines doesn't preserve text size on save
https://bugs.documentfoundation.org/show_bug.cgi?id=146690 Bug ID: 146690 Summary: FILESAVE PPTX: Textbox with only newlines doesn't preserve text size on save Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sarper.akde...@collabora.com Description: Textbox made up from multiple newlines with font size 5 from PowerPoint, opens without a problem on Impress but on save appears with different size since font size isn't preserved and becomes 18 on save. Steps to Reproduce: 1. Open attached file with Impress 2. Observe textbox size and font size 3. Save to PPTX and reload on Impress Actual Results: The textbox size changes, since font size isn't preserved. Expected Results: The textbox should be observed the same, font size shouldn't change. Reproducible: Always User Profile Reset: Yes Additional Info: See attached file, and the screen captures attached. -- You are receiving this mail because: You are the assignee for the bug.
Dispatch commands list
I refer to next commit: https://gerrit.libreoffice.org/c/core/+/128254 This commit updates the script which generates the wiki page about the so-called "Dispatch" commands on https://wiki.documentfoundation.org/Development/DispatchCommands I propose a number of modifications on the layout and on the content of the wiki page to make, hopefully, life a bit easier for authors of scripts and extensions. Without loss of information vs. the past. The proposed benefits are: - A more complete list: as an example, commands that are executable from Base or while designing charts are now part of the list - The commands are re-classified, and a subclass (the "group") should help to know what type of action it is about - Each command has a pointer (opengrok file + line) to the source file(s) from which the information was extracted - Last but not least, when available, the reader will find the arguments to provide when invoking the DispatchHelper service. AFAIK this info was not centralized anywhere before. If you have comments, suggestions, objections, .. please reply to this mail or on gerrit. Thanks in advance. JP
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - basic/qa basic/source
basic/qa/basic_coverage/test_chr_method.bas | 30 +++
basic/qa/cppunit/test_vba.cxx |1
basic/qa/vba_tests/chr.vb |3 ++
basic/qa/vba_tests/chrw.vb | 31
basic/source/runtime/stdobj.cxx |4 +--
5 files changed, 67 insertions(+), 2 deletions(-)
New commits:
commit 80570766400df268ed069f81f3793055962144f6
Author: Andreas Heinisch
AuthorDate: Fri Jan 7 10:19:28 2022 +0100
Commit: Xisco Fauli
CommitDate: Mon Jan 10 22:25:02 2022 +0100
tdf#145693 - Argument name should be 'charcode' instead of 'string'
In addition, changed argument datatype from Int to Long.
Change-Id: I702e09b6b8061d7cf00dd403e4681a0ab348d4c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128100
Tested-by: Andreas Heinisch
Reviewed-by: Andreas Heinisch
Signed-off-by: Xisco Fauli
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128212
Tested-by: Jenkins
diff --git a/basic/qa/basic_coverage/test_chr_method.bas
b/basic/qa/basic_coverage/test_chr_method.bas
new file mode 100644
index ..96d6fe3d9968
--- /dev/null
+++ b/basic/qa/basic_coverage/test_chr_method.bas
@@ -0,0 +1,30 @@
+'
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+
+Option Explicit
+
+Function doUnitTest() As String
+TestUtil.TestInit
+verify_testCHR
+doUnitTest = TestUtil.GetResult()
+End Function
+
+Sub verify_testCHR()
+On Error GoTo errorHandler
+
+TestUtil.AssertEqual(Chr(87), "W", "Chr(87)")
+TestUtil.AssertEqual(Chr(105), "i", "Chr(105)")
+TestUtil.AssertEqual(Chr(35), "#", "Chr(35)")
+
+' tdf#145693 - argument name should be 'charcode' instead of 'string'
+TestUtil.AssertEqual(Chr(charcode:=35), "#", "Chr(charcode:=35)")
+
+Exit Sub
+errorHandler:
+TestUtil.ReportErrorHandler("verify_testCHR", Err, Error$, Erl)
+End Sub
diff --git a/basic/qa/cppunit/test_vba.cxx b/basic/qa/cppunit/test_vba.cxx
index 089da748addb..818ba1c5f4c0 100644
--- a/basic/qa/cppunit/test_vba.cxx
+++ b/basic/qa/cppunit/test_vba.cxx
@@ -63,6 +63,7 @@ void VBATest::testMiscVBAFunctions()
"replace.vb",
"stringplusdouble.vb",
"chr.vb",
+"chrw.vb",
"abs.vb",
"array.vb",
"asc.vb",
diff --git a/basic/qa/vba_tests/chr.vb b/basic/qa/vba_tests/chr.vb
index a561d7cd6545..5dc85a0c9157 100644
--- a/basic/qa/vba_tests/chr.vb
+++ b/basic/qa/vba_tests/chr.vb
@@ -21,6 +21,9 @@ Sub verify_testCHR()
TestUtil.AssertEqual(Chr(87), "W", "Chr(87)")
TestUtil.AssertEqual(Chr(105), "i", "Chr(105)")
TestUtil.AssertEqual(Chr(35), "#", "Chr(35)")
+
+' tdf#145693 - argument name should be 'charcode' instead of 'string'
+TestUtil.AssertEqual(Chr(charcode:=35), "#", "Chr(charcode:=35)")
Exit Sub
errorHandler:
diff --git a/basic/qa/vba_tests/chrw.vb b/basic/qa/vba_tests/chrw.vb
new file mode 100644
index ..47bd28d7e1e3
--- /dev/null
+++ b/basic/qa/vba_tests/chrw.vb
@@ -0,0 +1,31 @@
+'
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+
+Option VBASupport 1
+Option Explicit
+
+Function doUnitTest() As String
+TestUtil.TestInit
+verify_testCHRW
+doUnitTest = TestUtil.GetResult()
+End Function
+
+Sub verify_testCHRW()
+On Error GoTo errorHandler
+
+TestUtil.AssertEqual(ChrW(87), "W", "ChrW(87)")
+TestUtil.AssertEqual(ChrW(105), "i", "ChrW(105)")
+TestUtil.AssertEqual(ChrW(35), "#", "ChrW(35)")
+
+' tdf#145693 - argument name should be 'charcode' instead of 'string'
+TestUtil.AssertEqual(ChrW(charcode:=35), "#", "ChrW(charcode:=35)")
+
+Exit Sub
+errorHandler:
+TestUtil.ReportErrorHandler("verify_testCHRW", Err, Error$, Erl)
+End Sub
diff --git a/basic/source/runtime/stdobj.cxx b/basic/source/runtime/stdobj.cxx
index 1a2499cde2da..0bb572bbcd33 100644
--- a/basic/source/runtime/stdobj.cxx
+++ b/basic/source/runtime/stdobj.cxx
@@ -200,10 +200,10 @@ constexpr Method aMethods[] = {
arg(u"Expression", SbxVARIANT),
{ u"Chr", SbxSTRING, 1 | FUNCTION_,
SbRtl_Chr },
-arg(u"string", SbxINTEGER),
+arg(u"charcode", SbxLONG),
{ u"ChrW", SbxSTRING, 1 | FUNCTION_ | COMPATONLY_,
SbRtl_ChrW },
-arg(u"string", SbxINTEGER),
+arg(u"charcode", SbxLONG),
{ u"CInt", SbxINTEGER, 1 | FUNCTION_,
SbRtl_CInt },
arg(u"expression", SbxVARIANT),
[Libreoffice-bugs] [Bug 146689] calc formula to value (linkvalue, sheetlinkmode) changed by macro copies first sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=146689 debewerk...@kpnplanet.nl changed: What|Removed |Added Keywords||skillPython -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 85677] Dragging on a touchscreen display highlights instead of scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=85677 --- Comment #26 from n.rottga...@gmail.com --- Same with Win 11. Will Never be implemented even the amount of touch laptops is increasing…. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112700] [META] DOC (binary) table-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112700 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||146683 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146683 [Bug 146683] FILEOPEN: table in DOC text box is not imported properly - groupshape support -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146683] FILEOPEN: table in DOC text box is not imported properly - groupshape support
https://bugs.documentfoundation.org/show_bug.cgi?id=146683 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Blocks||112700 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Would be cool to have some screenshot with comparison Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112700 [Bug 112700] [META] DOC (binary) table-related issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139613] Image effects: moving images/text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=139613 --- Comment #10 from Arnaldo --- Created attachment 177447 --> https://bugs.documentfoundation.org/attachment.cgi?id=177447=edit Hope it helps. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146689] calc formula to value (linkvalue, sheetlinkmode) changed by macro copies first sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=146689 debewerk...@kpnplanet.nl changed: What|Removed |Added Attachment #177445|spreadsheet - two sheets - |spreadsheet - two sheets - description|embedden python |embedded python -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146689] calc formula to value (linkvalue, sheetlinkmode) changed by macro copies first sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=146689 --- Comment #1 from debewerk...@kpnplanet.nl --- Created attachment 177446 --> https://bugs.documentfoundation.org/attachment.cgi?id=177446=edit result of dpkg -l | grep libreoffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146689] New: calc formula to value (linkvalue, sheetlinkmode) changed by macro copies first sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=146689 Bug ID: 146689 Summary: calc formula to value (linkvalue, sheetlinkmode) changed by macro copies first sheet Product: LibreOffice Version: 6.4.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: debewerk...@kpnplanet.nl Created attachment 177445 --> https://bugs.documentfoundation.org/attachment.cgi?id=177445=edit spreadsheet - two sheets - embedden python I want to convert formulas to values in all spreadsheets of a document. To this end wrote a macro (embedded) to do so. Summary from com.sun.star.sheet.SheetLinkMode import VALUE as LINKVALUE for j in range(oSheets.Count): oSheet = oSheets.getByIndex(j) oSheet.LinkMode = LINKVALUE 1. reproduce result by running embedded macro. 2. expected result is a document with no formulas present in each sheet 3. produced are sheets with no formulas on it and sheet2 is now a copy of sheet1 used: linuxMint 20.2 with distributed LibO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 108827] [META] Calc functions bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108827 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Depends on||146686 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146686 [Bug 146686] LINEST with empty parameter for KnownX has different results in LibreOffice than in Excel -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146686] LINEST with empty parameter for KnownX has different results in LibreOffice than in Excel
https://bugs.documentfoundation.org/show_bug.cgi?id=146686 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Blocks||108827 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=108827 [Bug 108827] [META] Calc functions bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 --- Comment #10 from Roman Kuznetsov <79045_79...@mail.ru> --- no repro in Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 4; OS: Mac OS X 12.1; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #9 from Roman Kuznetsov <79045_79...@mail.ru> --- You can not change the status to NEW yourself. It should be someone another who can confirm your problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - svx/source
svx/source/svdraw/svdtrans.cxx | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
New commits:
commit 6273c0e0de093735396bf1b5a2151da943753eac
Author: Mike Kaganski
AuthorDate: Sun Jan 9 15:53:22 2022 +0300
Commit: Xisco Fauli
CommitDate: Mon Jan 10 21:52:42 2022 +0100
Slightly optimize code handling angles
Change-Id: I8bc10513f6cd704abc7a2bbb17d8d0d8d2628401
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128187
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 1bdb4ddfc516d62f482f83fc6191e9585aa4786b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128230
Reviewed-by: Xisco Fauli
diff --git a/svx/source/svdraw/svdtrans.cxx b/svx/source/svdraw/svdtrans.cxx
index 2e3b91d47a57..201e9f86d58c 100644
--- a/svx/source/svdraw/svdtrans.cxx
+++ b/svx/source/svdraw/svdtrans.cxx
@@ -407,19 +407,13 @@ Degree100 NormAngle18000(Degree100 a)
Degree100 NormAngle36000(Degree100 a)
{
-while (a < 0_deg100) a += 36000_deg100;
-while (a >= 36000_deg100) a -= 36000_deg100;
+a %= 36000_deg100;
+if (a < 0_deg100)
+a += 36000_deg100;
return a;
}
-sal_uInt16 GetAngleSector(Degree100 nAngle)
-{
-nAngle = NormAngle36000(nAngle);
-if (nAngle< 9000_deg100) return 0;
-if (nAngle<18000_deg100) return 1;
-if (nAngle<27000_deg100) return 2;
-return 3;
-}
+sal_uInt16 GetAngleSector(Degree100 nAngle) { return (NormAngle36000(nAngle) /
9000_deg100).get(); }
tools::Long GetLen(const Point& rPnt)
{
[Libreoffice-bugs] [Bug 146673] H2 database - PUBLIC schema tables no longer displayed in UI
https://bugs.documentfoundation.org/show_bug.cgi?id=146673 --- Comment #5 from Julien Nabet --- I don't know H2 database but since you use JDBC to connect, I search in this part on LO code. I noticed 2 parameters (in connectivity/source/drivers/jdbc/JDriver.cxx): 193 "ImplicitCatalogRestriction" 194 "The catalog which should be used in getTables calls, when the caller passed NULL." 200 "ImplicitSchemaRestriction" 201 "The schema which should be used in getTables calls, when the caller passed NULL." See https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/jdbc/JDriver.cxx?r=f790fb51#200 Also, reading http://www.h2database.com/html/features.html, perhaps it could be just a parameter to add in connection string? eg, I see in this website: jdbc:h2:;=[;=...] jdbc:h2:file:~/sample;TRACE_LEVEL_SYSTEM_OUT=3 So perhaps, using: jdbc:h2:;ImplicitSchemaRestriction=PUBLIC may help? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 --- Comment #8 from Habs <2018f...@gmail.com> --- didnt release it was updating at the bottom of the screen -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 Habs <2018f...@gmail.com> changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #7 from Habs <2018f...@gmail.com> --- i think it might be because i have Rectangle installed it is a window software to minimize and that -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 --- Comment #6 from Habs <2018f...@gmail.com> --- i think it might be because i have Rectangle installed it is a window software to minimize and that -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 --- Comment #5 from Habs <2018f...@gmail.com> --- i think it might be because i have Rectangle installed it is a window software to minimize and that -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 --- Comment #4 from Habs <2018f...@gmail.com> --- i have addedd an attachment in screenshot,, i think it is the rectangle window snap programm installed causing the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 --- Comment #3 from Habs <2018f...@gmail.com> --- Created attachment 177444 --> https://bugs.documentfoundation.org/attachment.cgi?id=177444=edit shadow window crash libreoffice this shows shows the shadow window ontop of libreoffice and the whole screen when trying to autosnap , it might be because rectangle program is installed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146688] New: wrong formatting of the hyperlink under mouse pointer
https://bugs.documentfoundation.org/show_bug.cgi?id=146688 Bug ID: 146688 Summary: wrong formatting of the hyperlink under mouse pointer Product: LibreOffice Version: 7.2.4.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hen...@onet.eu Description: Mouse pointing to a newly created hyperlink in an .odt file displays "%(Key)" instead of "(Ctrl)"; otherwise the hyperlink itself and its pdf export work fine. Can be a problem for unexperienced users. Steps to Reproduce: 1. Menu Insert/Hyperlink 2. inserting URL "adobe.com", inserting text "click here", OK 3. mouse pointing at the hyperlink Actual Results: %(Key) + click to open hyperlink: http://adobe.com/ Expected Results: Ctrl + click to open hyperlink: http://adobe.com/ Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.4.1 (x64) / LibreOffice Community Build ID: 27d75539669ac387bb498e35313b970b7fe9c4f9 CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: sk-SK (sk_SK); UI: sk-SK Calc: CL -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/cppuhelper
include/cppuhelper/TODO |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f1f2daefbe921d223079a50358527e1d35470850 Author: Andrea Gelmini AuthorDate: Mon Jan 10 10:59:35 2022 +0100 Commit: Julien Nabet CommitDate: Mon Jan 10 21:21:54 2022 +0100 Fix typo Change-Id: I04ded03b3dd16627959a6451696a2e3392c17f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128215 Tested-by: Jenkins Reviewed-by: Julien Nabet diff --git a/include/cppuhelper/TODO b/include/cppuhelper/TODO index 3499e525d441..e00fd0df5859 100644 --- a/include/cppuhelper/TODO +++ b/include/cppuhelper/TODO @@ -1,3 +1,3 @@ compbase1.hxx, compbase2.hxx, ... are just there because they are part of the published API. -In LO internals, we could just use compbase.hxx so it would allow us to make the compase.hxx deprecated +In LO internals, we could just use compbase.hxx so it would allow us to make the compbase.hxx deprecated See https://lists.freedesktop.org/archives/libreoffice/2022-January/088279.html
[Libreoffice-commits] core.git: sw/qa
sw/qa/uitest/writer_tests/trackedChanges.py |2 +-
sw/qa/uitest/writer_tests2/deleteAllComments.py |4 ++--
sw/qa/uitest/writer_tests3/sort.py |4 ++--
sw/qa/uitest/writer_tests3/tdf79236.py |2 +-
sw/qa/uitest/writer_tests7/tdf133348.py |2 +-
sw/qa/uitest/writer_tests7/tdf90401.py |4 ++--
6 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit 2925063f0bb85c7e4d1d9a956365fe87a91dab22
Author: Xisco Fauli
AuthorDate: Mon Jan 10 18:49:39 2022 +0100
Commit: Xisco Fauli
CommitDate: Mon Jan 10 21:10:56 2022 +0100
uitest: executeCommand doesn't return anything
Change-Id: Ie59ed6926c42b96471f3b74a9547f7f1f2cd175a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128259
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/uitest/writer_tests/trackedChanges.py
b/sw/qa/uitest/writer_tests/trackedChanges.py
index 96cd3a72ca87..eb6d5a9f6db6 100644
--- a/sw/qa/uitest/writer_tests/trackedChanges.py
+++ b/sw/qa/uitest/writer_tests/trackedChanges.py
@@ -23,7 +23,7 @@ class trackedchanges(UITestCase):
self.xUITest.executeCommand(".uno:TrackChanges")
-selection = self.xUITest.executeCommand(".uno:SelectAll") #select
whole text
+self.xUITest.executeCommand(".uno:SelectAll") #select whole text
self.xUITest.executeCommand(".uno:Cut") #cut text
with
self.ui_test.execute_modeless_dialog_through_command(".uno:AcceptTrackedChanges",
close_button="close"):
diff --git a/sw/qa/uitest/writer_tests2/deleteAllComments.py
b/sw/qa/uitest/writer_tests2/deleteAllComments.py
index bb723af2e0a5..e655a2f8a23d 100644
--- a/sw/qa/uitest/writer_tests2/deleteAllComments.py
+++ b/sw/qa/uitest/writer_tests2/deleteAllComments.py
@@ -23,7 +23,7 @@ class DeleteAllComments(UITestCase):
type_text(xWriterEdit, "Test LibreOffice")
-selection = self.xUITest.executeCommand(".uno:SelectAll")
+self.xUITest.executeCommand(".uno:SelectAll")
self.xUITest.executeCommand(".uno:InsertAnnotation")
cursor = document.getCurrentController().getViewCursor()
type_text(xWriterEdit, "E")
@@ -42,7 +42,7 @@ class DeleteAllComments(UITestCase):
type_text(xWriterEdit, "foo")
-selection = self.xUITest.executeCommand(".uno:SelectAll")
+self.xUITest.executeCommand(".uno:SelectAll")
self.xUITest.executeCommand(".uno:InsertAnnotation")
self.xUITest.executeCommand(".uno:TrackChanges")
self.xUITest.executeCommand(".uno:DeleteAllNotes")
diff --git a/sw/qa/uitest/writer_tests3/sort.py
b/sw/qa/uitest/writer_tests3/sort.py
index 3e5e779004d8..aafe7a00c6a5 100644
--- a/sw/qa/uitest/writer_tests3/sort.py
+++ b/sw/qa/uitest/writer_tests3/sort.py
@@ -25,7 +25,7 @@ class WriterSort(UITestCase):
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"RETURN"}))
type_text(xWriterEdit, "v")
-selection = self.xUITest.executeCommand(".uno:SelectAll") #select
whole text
+self.xUITest.executeCommand(".uno:SelectAll") #select whole text
#Tools - Sort
with
self.ui_test.execute_dialog_through_command(".uno:SortDialog") as xDialog:
xDown = xDialog.getChild("down1")
@@ -43,7 +43,7 @@ class WriterSort(UITestCase):
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"RETURN"}))
type_text(xWriterEdit, "2;8;3")
-selection = self.xUITest.executeCommand(".uno:SelectAll") #select
whole text
+self.xUITest.executeCommand(".uno:SelectAll") #select whole text
#Tools - Sort
with
self.ui_test.execute_dialog_through_command(".uno:SortDialog") as xDialog:
xDown = xDialog.getChild("down1")
diff --git a/sw/qa/uitest/writer_tests3/tdf79236.py
b/sw/qa/uitest/writer_tests3/tdf79236.py
index 23b53b855563..c8e857188c9c 100644
--- a/sw/qa/uitest/writer_tests3/tdf79236.py
+++ b/sw/qa/uitest/writer_tests3/tdf79236.py
@@ -22,7 +22,7 @@ class tdf79236(UITestCase):
type_text(xWriterEdit, "Test for tdf79236")
-selection = self.xUITest.executeCommand(".uno:SelectAll")
+self.xUITest.executeCommand(".uno:SelectAll")
self.assertEqual(document.CurrentSelection.getByIndex(0).ParaLeftMargin, 0)
self.assertEqual(document.CurrentSelection.getByIndex(0).ParaRightMargin, 0)
diff --git a/sw/qa/uitest/writer_tests7/tdf133348.py
b/sw/qa/uitest/writer_tests7/tdf133348.py
index e80b8230cf30..8f8ff94cf3b5 100644
--- a/sw/qa/uitest/writer_tests7/tdf133348.py
+++ b/sw/qa/uitest/writer_tests7/tdf133348.py
@@ -18,7 +18,7 @@ class tdf133348(UITestCase):
xWriterEdit = xWriterDoc.getChild("writer_edit")
-selection = self.xUITest.executeCommand(".uno:SelectAll")
+
[Libreoffice-bugs] [Bug 146687] Calc ... from a worksheet, with macro, open other worksheet and triplicate (copy) or more a sheet in it .. crash
https://bugs.documentfoundation.org/show_bug.cgi?id=146687 --- Comment #4 from Philippe Lévi --- tested on hp notebook windows 10 64bits no problem detected ! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142084] Order inversion of accented letters when typed in table cells (tracking changes makes it worse)
https://bugs.documentfoundation.org/show_bug.cgi?id=142084 psidiumcode changed: What|Removed |Added CC||lbrmk.510@rgn4d.neomailbox. ||ch --- Comment #5 from psidiumcode --- I could not reproduce it in ver: Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.1.7.2 / LibreOffice Community Build ID: c6a4e3954236145e2acb0b65f68614365aeee33f CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.0.6.2 Build ID: 144abb84a525d8e30c9dbbefa69cbbf2d8d4ae3b CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=146682 Hans-Werner changed: What|Removed |Added Attachment #177436|0 |1 is obsolete|| --- Comment #9 from Hans-Werner --- Created attachment 177443 --> https://bugs.documentfoundation.org/attachment.cgi?id=177443=edit CircuitDiagramNEW.svg -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=146682 Hans-Werner changed: What|Removed |Added Attachment #177435|0 |1 is obsolete|| --- Comment #8 from Hans-Werner --- Created attachment 177442 --> https://bugs.documentfoundation.org/attachment.cgi?id=177442=edit CircuitDiagramNEW.odg -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=146682 --- Comment #7 from Hans-Werner --- It seems to be that there are 2 problems. Please take a look at the updated files "CircuitDiagram.odg" and "CircuitDiagram.svg": [1] Blue circles = IMPORT problem NOT to be seen when using "Inkscape" "GIMP" "Firefox" "MicrosoftEdge". [2] Violett circles = EXPORT problem To be seen when using "Inkscape" "GIMP" "Firefox" "MicrosoftEdge". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137259] Misleading Help descriptions for the BETAINV and BETA.INV functions of Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=137259 --- Comment #1 from Rafael Lima --- Indeed, the Number parameter is actually the cumulative probability for which the X value is to be found. If Start and End are note defined, then default values are 0 and 1, respectively (see [1]). [1] https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/interpr3.cxx?r=37429f26#2213 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146559] libre office hangs and not usable (macOS Monterey only?)
https://bugs.documentfoundation.org/show_bug.cgi?id=146559 psidiumcode changed: What|Removed |Added CC||lbrmk.510@rgn4d.neomailbox. ||ch --- Comment #2 from psidiumcode --- I could not reproduce it in ver: Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: b4a281af53efa0c36ee1770e6cf4d800be77a6d2 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded macOS Catalina -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146563] Flickering text hint in color picker
https://bugs.documentfoundation.org/show_bug.cgi?id=146563 psidiumcode changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||lbrmk.510@rgn4d.neomailbox. ||ch --- Comment #2 from psidiumcode --- I could reproduce it in ver: Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: b4a281af53efa0c36ee1770e6cf4d800be77a6d2 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146687] Calc ... from a worksheet, with macro, open other worksheet and triplicate (copy) or more a sheet in it .. crash
https://bugs.documentfoundation.org/show_bug.cgi?id=146687 --- Comment #3 from Philippe Lévi --- forgot ... Windows 7 64bits -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=146682 Xisco Faulí changed: What|Removed |Added CC||hoss...@libreoffice.org --- Comment #6 from Xisco Faulí --- @Hossein, I thought you might be interested in this issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146601] Libre Calc does not display cell entries as they are typed
https://bugs.documentfoundation.org/show_bug.cgi?id=146601 psidiumcode changed: What|Removed |Added CC||lbrmk.510@rgn4d.neomailbox. ||ch --- Comment #5 from psidiumcode --- I could not reproduce it in ver: Version: 7.2.5.2 / LibreOffice Community Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: b4a281af53efa0c36ee1770e6cf4d800be77a6d2 CPU threads: 12; OS: Mac OS X 10.15.7; UI render: default; VCL: osx Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=146682 Xisco Faulí changed: What|Removed |Added CC||xiscofa...@libreoffice.org Keywords||filter:svg Version|7.3.0.1 rc |4.1 all versions --- Comment #5 from Xisco Faulí --- Reproduced in Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: bf883027ee62ece0844730572305094f53daa521 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Version: 6.1.0.0.alpha1+ Build ID: 3a801799536e6870f2fb111b1cc00b9575a35a39 CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group Version: 5.2.0.0.alpha1+ Build ID: 5b168b3fa568e48e795234dc5fa454bf24c9805e CPU Threads: 4; OS Version: Linux 5.10; UI Render: default; Locale: en-US (en_US.UTF-8) and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) maybe it's already reported in another issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142076] [META] Color filtering in Autofilter bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=142076 Bug 142076 depends on bug 145059, which changed state. Bug 145059 Summary: FILESAVE XLSX Changing the conditional formatting of autofiltered color loses the filter condtion https://bugs.documentfoundation.org/show_bug.cgi?id=145059 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146687] Calc ... from a worksheet, with macro, open other worksheet and triplicate (copy) or more a sheet in it .. crash
https://bugs.documentfoundation.org/show_bug.cgi?id=146687 --- Comment #2 from Philippe Lévi --- Created attachment 177441 --> https://bugs.documentfoundation.org/attachment.cgi?id=177441=edit see bug report description -- You are receiving this mail because: You are the assignee for the bug.
