[Libreoffice-bugs] [Bug 144717] ENDNOTES: I can't change endnote anchor to footnote anchor, if a table follows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144717

--- Comment #7 from Timur  ---
Created attachment 177457
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177457=edit
test ODT

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144717] ENDNOTES: I can't change endnote anchor to footnote anchor, if a table follows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144717

Timur  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||xiscofa...@libreoffice.org

--- Comment #6 from Timur  ---
Linux-43max
commit 52b45843f08974fe8a8995fa12619ceb30998626
Date:   Thu May 28 17:39:12 2015 +0800
   source-hash-3fc6fc2ff7304a0d1bc85bd2e03fb3fbab492c9a
   prev source-hash-f6f2ee5bdd9e0d44437bfbd6dd338adea956b2ab

author  Oliver-Rainer Wittmann  2013-12-10 
committer   Caolán McNamara 2013-12-10
commit  3fc6fc2ff7304a0d1bc85bd2e03fb3fbab492c9a (patch)
Related: #i33737# correction: assure the selections does not...
start/end inside a table while end/start of the selection is outside the table
(cherry picked from commit 382814ccb30bfe71f093e55e23802447caca235d)

So, bibisect is here, but no dev, we should get one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Stanislav Horacek (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a895ccb1032aa610055284bd3122cce623036464
Author: Stanislav Horacek 
AuthorDate: Tue Jan 11 13:01:43 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Jan 11 13:01:43 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 2a6cfde785b43b77c2accfa133e6aeac3fc22cf1
  - mark source code line as not localizable

Change-Id: Ia8481b52854f72a2af0b68eb7f644d77038b8d05
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128145
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index fb8d368b0df5..2a6cfde785b4 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit fb8d368b0df51add887d63e7ec866ac06d5102e3
+Subproject commit 2a6cfde785b43b77c2accfa133e6aeac3fc22cf1

[Libreoffice-commits] help.git: source/text

[Stanislav Horacek (via logerrit)]

 source/text/sbasic/shared/03/sf_dialogcontrol.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2a6cfde785b43b77c2accfa133e6aeac3fc22cf1
Author: Stanislav Horacek 
AuthorDate: Sat Jan 8 18:16:05 2022 +0100
Commit: Rafael Lima 
CommitDate: Tue Jan 11 13:01:41 2022 +0100

mark source code line as not localizable

Change-Id: Ia8481b52854f72a2af0b68eb7f644d77038b8d05
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128145
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/source/text/sbasic/shared/03/sf_dialogcontrol.xhp 
b/source/text/sbasic/shared/03/sf_dialogcontrol.xhp
index 57fabd184..eb97854d3 100644
--- a/source/text/sbasic/shared/03/sf_dialogcontrol.xhp
+++ b/source/text/sbasic/shared/03/sf_dialogcontrol.xhp
@@ -1209,7 +1209,7 @@



- dlg = 
CreateScriptService("Dialog", "GlobalScope", "Standard", "myDialog")
+ dlg 
= CreateScriptService("Dialog", "GlobalScope", "Standard", 
"myDialog")
  table_control = dlg.Controls("Grid1")
  table_data = (("Column A", "Column B", "Column 
C"),
   
 ("Row 1", 1, 2),

[Libreoffice-commits] core.git: framework/source

[Noel Grandin (via logerrit)]

 framework/source/fwe/xml/toolboxdocumenthandler.cxx |   12 
 1 file changed, 12 deletions(-)

New commits:
commit 72493fe922ffe91c6587f660f82f99a229e4d6fd
Author: Noel Grandin 
AuthorDate: Tue Jan 11 10:12:32 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 11 12:55:57 2022 +0100

OWriteToolBoxDocumentHandler doesnt need SolarMutex

it is only ever used from a single thread. This was there
since the beginning.

Change-Id: I580cf86457b2983cd7729bce32cbc0ccca601005
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128270
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/framework/source/fwe/xml/toolboxdocumenthandler.cxx 
b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
index 11385edd9b5c..57e28628273e 100644
--- a/framework/source/fwe/xml/toolboxdocumenthandler.cxx
+++ b/framework/source/fwe/xml/toolboxdocumenthandler.cxx
@@ -180,8 +180,6 @@ void SAL_CALL OReadToolBoxDocumentHandler::startDocument()
 
 void SAL_CALL OReadToolBoxDocumentHandler::endDocument()
 {
-SolarMutexGuard g;
-
 if ( m_bToolBarStartFound )
 {
 OUString aErrorMessage = getErrorLineString() + "No matching start or 
end element 'toolbar' found!";
@@ -192,8 +190,6 @@ void SAL_CALL OReadToolBoxDocumentHandler::endDocument()
 void SAL_CALL OReadToolBoxDocumentHandler::startElement(
 const OUString& aName, const Reference< XAttributeList >  )
 {
-SolarMutexGuard g;
-
 ToolBoxHashMap::const_iterator pToolBoxEntry = m_aToolBoxMap.find( aName );
 if ( pToolBoxEntry == m_aToolBoxMap.end() )
 return;
@@ -461,8 +457,6 @@ void SAL_CALL OReadToolBoxDocumentHandler::startElement(
 
 void SAL_CALL OReadToolBoxDocumentHandler::endElement(const OUString& aName)
 {
-SolarMutexGuard g;
-
 ToolBoxHashMap::const_iterator pToolBoxEntry = m_aToolBoxMap.find( aName );
 if ( pToolBoxEntry == m_aToolBoxMap.end() )
 return;
@@ -549,15 +543,11 @@ void SAL_CALL 
OReadToolBoxDocumentHandler::processingInstruction(
 void SAL_CALL OReadToolBoxDocumentHandler::setDocumentLocator(
 const Reference< XLocator > )
 {
-SolarMutexGuard g;
-
 m_xLocator = xLocator;
 }
 
 OUString OReadToolBoxDocumentHandler::getErrorLineString()
 {
-SolarMutexGuard g;
-
 if ( m_xLocator.is() )
 return "Line: " + OUString::number( m_xLocator->getLineNumber() ) + " 
- ";
 else
@@ -584,8 +574,6 @@ 
OWriteToolBoxDocumentHandler::~OWriteToolBoxDocumentHandler()
 
 void OWriteToolBoxDocumentHandler::WriteToolBoxDocument()
 {
-SolarMutexGuard g;
-
 m_xWriteDocumentHandler->startDocument();
 
 // write DOCTYPE line!

[Libreoffice-commits] core.git: 2 commits - framework/source

[Noel Grandin (via logerrit)]

 framework/source/xml/imagesdocumenthandler.cxx |   10 --
 1 file changed, 10 deletions(-)

New commits:
commit 934d246e77659ec91321f57e9a244dc39e917150
Author: Noel Grandin 
AuthorDate: Tue Jan 11 10:01:19 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 11 12:55:43 2022 +0100

OWriteImagesDocumentHandler doesnt need SolarMutex

it is only ever used from a single thread. This was there
since the beginning.

Change-Id: If6c2929677ea1231cbf3326974451c3c6d51486f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128269
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/framework/source/xml/imagesdocumenthandler.cxx 
b/framework/source/xml/imagesdocumenthandler.cxx
index 478a92f43b3c..2c0716d8eb47 100644
--- a/framework/source/xml/imagesdocumenthandler.cxx
+++ b/framework/source/xml/imagesdocumenthandler.cxx
@@ -300,8 +300,6 @@ OWriteImagesDocumentHandler::~OWriteImagesDocumentHandler()
 
 void OWriteImagesDocumentHandler::WriteImagesDocument()
 {
-SolarMutexGuard g;
-
 m_xWriteDocumentHandler->startDocument();
 
 // write DOCTYPE line!
commit c155710de15a400efa4b1bf33eabb549c2dafa25
Author: Noel Grandin 
AuthorDate: Tue Jan 11 10:00:01 2022 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 11 12:55:30 2022 +0100

OReadImagesDocumentHandler doesn't need SolarMutex

it is only ever used from a single thread. This was there
since the beginning.

Change-Id: I7a2629071a3b2f3d4ddb6c7758a24515cfd5cebc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128268
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/framework/source/xml/imagesdocumenthandler.cxx 
b/framework/source/xml/imagesdocumenthandler.cxx
index 7fcedae5134d..478a92f43b3c 100644
--- a/framework/source/xml/imagesdocumenthandler.cxx
+++ b/framework/source/xml/imagesdocumenthandler.cxx
@@ -129,8 +129,6 @@ void SAL_CALL OReadImagesDocumentHandler::startDocument()
 
 void SAL_CALL OReadImagesDocumentHandler::endDocument()
 {
-SolarMutexGuard g;
-
 if (m_bImageContainerStartFound != m_bImageContainerEndFound)
 {
 OUString aErrorMessage = getErrorLineString() + "No matching start or 
end element 'image:imagecontainer' found!";
@@ -141,8 +139,6 @@ void SAL_CALL OReadImagesDocumentHandler::endDocument()
 void SAL_CALL OReadImagesDocumentHandler::startElement(
 const OUString& aName, const Reference< XAttributeList >  )
 {
-SolarMutexGuard g;
-
 ImageHashMap::const_iterator pImageEntry = m_aImageMap.find( aName );
 if ( pImageEntry == m_aImageMap.end() )
 return;
@@ -230,8 +226,6 @@ void SAL_CALL OReadImagesDocumentHandler::startElement(
 
 void SAL_CALL OReadImagesDocumentHandler::endElement(const OUString& aName)
 {
-SolarMutexGuard g;
-
 ImageHashMap::const_iterator pImageEntry = m_aImageMap.find( aName );
 if ( pImageEntry == m_aImageMap.end() )
 return;
@@ -270,13 +264,11 @@ void SAL_CALL 
OReadImagesDocumentHandler::processingInstruction(
 void SAL_CALL OReadImagesDocumentHandler::setDocumentLocator(
 const Reference< XLocator > )
 {
-SolarMutexGuard g;
 m_xLocator = xLocator;
 }
 
 OUString OReadImagesDocumentHandler::getErrorLineString()
 {
-SolarMutexGuard g;
 if ( m_xLocator.is() )
 {
 return "Line: " +

[Libreoffice-bugs] [Bug 145773] Section endnotes not collected at end of section

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145773

David  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from David  ---
This now looks to be fixed after commit
https://git.libreoffice.org/core/commit/cb188ce336e434c2b7002b3d8a41a681e73ae51a.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144717] ENDNOTES: I can't change endnote anchor to footnote anchor, if a table follows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144717

Timur  changed:

   What|Removed |Added

   Hardware|x86 (IA32)  |All
 OS|Windows (All)   |All
   Keywords||bibisectRequest, regression
Version|7.1.5.2 release |4.2.8.2 release

--- Comment #5 from Timur  ---
No repro LO 4.2.0 Repro 4.2.8 and 7.4+. Regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/qa

[Xisco Fauli (via logerrit)]

 svx/qa/unit/classicshapes.cxx |  143 ++
 1 file changed, 64 insertions(+), 79 deletions(-)

New commits:
commit 91c6279dd60b07788c8015fb04ecd2d310de1623
Author: Xisco Fauli 
AuthorDate: Mon Jan 10 20:09:57 2022 +0100
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 12:40:09 2022 +0100

CppunitTest_svx_unit: simplify code

Just use CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE
or CPPUNIT_ASSERT_EQUAL_MESSAGE

Change-Id: Ibf399cc802e31c5265ba1301f38df79958bf9e1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128262
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/svx/qa/unit/classicshapes.cxx b/svx/qa/unit/classicshapes.cxx
index 3bba20f8ec73..0ef0722875a3 100644
--- a/svx/qa/unit/classicshapes.cxx
+++ b/svx/qa/unit/classicshapes.cxx
@@ -76,15 +76,7 @@ CPPUNIT_TEST_FIXTURE(ClassicshapesTest, 
testTdf98584ShearVertical)
 const OUString sURL(m_directories.getURLFromSrc(sDataDirectory) + 
"tdf98584_ShearVertical.odg");
 mxComponent = loadFromDesktop(sURL, 
"com.sun.star.comp.drawing.DrawingDocument");
 
-OUString sErrors; // sErrors collects the errors and should be empty in 
case all is OK.
-// All tests have a small tolerance for to avoid failing because of 
rounding errors.
-
 // Tests skewY
-sal_Int32 nShearE = -5313; // expected angle for horizontal shear
-sal_Int32 nRotE = 30687; // = -5313 expected angle for generated rotation
-// expected width of shape, should not change on vertical shearing
-sal_Int32 nWidthE = 5001;
-
 for (sal_uInt8 nPageIndex = 0; nPageIndex < 3; ++nPageIndex)
 {
 awt::Rectangle aFrameRect;
@@ -92,27 +84,28 @@ CPPUNIT_TEST_FIXTURE(ClassicshapesTest, 
testTdf98584ShearVertical)
 uno::Reference xShapeProps(xShape, 
uno::UNO_QUERY);
 CPPUNIT_ASSERT_MESSAGE("Could not get the shape properties", 
xShapeProps.is());
 xShapeProps->getPropertyValue(UNO_NAME_MISC_OBJ_FRAMERECT) >>= 
aFrameRect;
-const sal_Int32 nWidthA(aFrameRect.Width);
-if (abs(nWidthE - nWidthA) > 2)
-sErrors += "skewY page " + OUString::number(nPageIndex) + " width 
expected "
-   + OUString::number(nWidthE) + ", actual " + 
OUString::number(nWidthA) + "\n";
-sal_Int32 nShearA(0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE(
+OUString("Incorrect Width on skewY page " + 
OUString::number(nPageIndex))
+.toUtf8()
+.getStr(),
+5001.0, aFrameRect.Width, 2.0);
+double nShearA;
 xShapeProps->getPropertyValue(UNO_NAME_MISC_OBJ_SHEARANGLE) >>= 
nShearA;
-if (abs(nShearE - nShearA) > 2)
-sErrors += "skewY page" + OUString::number(nPageIndex) + " shear 
angle expected "
-   + OUString::number(nShearE) + ", actual " + 
OUString::number(nShearA) + "\n";
-sal_Int32 nRotA(0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE(
+OUString("Incorrect Share angle on skewY page " + 
OUString::number(nPageIndex))
+.toUtf8()
+.getStr(),
+-5313.0, nShearA, 2.0);
+double nRotA;
 xShapeProps->getPropertyValue(UNO_NAME_MISC_OBJ_ROTATEANGLE) >>= nRotA;
-if (abs(nRotE - nRotA) > 2)
-sErrors += "skewY page" + OUString::number(nPageIndex) + " rotate 
angle expected "
-   + OUString::number(nRotE) + ", actual " + 
OUString::number(nRotA) + "\n";
+CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE(
+OUString("Incorrect Rotate angle on skewY page " + 
OUString::number(nPageIndex))
+.toUtf8()
+.getStr(),
+30687.0, nRotA, 2.0);
 }
 
 // Tests matrix
-nShearE = -6343;
-nRotE = 29657;
-nWidthE = 5001;
-
 for (sal_uInt8 nPageIndex = 3; nPageIndex < 6; ++nPageIndex)
 {
 awt::Rectangle aFrameRect;
@@ -120,23 +113,26 @@ CPPUNIT_TEST_FIXTURE(ClassicshapesTest, 
testTdf98584ShearVertical)
 uno::Reference xShapeProps(xShape, 
uno::UNO_QUERY);
 CPPUNIT_ASSERT_MESSAGE("Could not get the shape properties", 
xShapeProps.is());
 xShapeProps->getPropertyValue(UNO_NAME_MISC_OBJ_FRAMERECT) >>= 
aFrameRect;
-const sal_Int32 nWidthA(aFrameRect.Width);
-if (abs(nWidthE - nWidthA) > 2)
-sErrors += "matrix page " + OUString::number(nPageIndex) + " width 
expected "
-   + OUString::number(nWidthE) + ", actual " + 
OUString::number(nWidthA) + "\n";
-sal_Int32 nShearA(0);
+CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE(
+OUString("Incorrect Width on matrix page " + 
OUString::number(nPageIndex))
+.toUtf8()
+.getStr(),
+5001.0, aFrameRect.Width, 2.0);
+double nShearA;
 xShapeProps->getPropertyValue(UNO_NAME_MISC_OBJ_SHEARANGLE) >>= 
nShearA;
-if (abs(nShearE - nShearA) > 2)
-sErrors += 

[Libreoffice-bugs] [Bug 144965] TopDown RTL on screen o, printing rotates characters wrongly and kerning messed up as well

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144965

Timur  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146629] Spreadsheet tabs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146629

Timur  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|REOPENED|RESOLVED

--- Comment #4 from Timur  ---
What you reported was changed in
https://bugs.documentfoundation.org/show_bug.cgi?id=124572. 
You are asking to revert? No, that's WontFix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146696] New: IMPRESS PRINTING: Only part of slide is rendered when trying to print from Screen 16:10 format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146696

Bug ID: 146696
   Summary: IMPRESS PRINTING: Only part of slide is rendered when
trying to print from Screen 16:10 format
   Product: LibreOffice
   Version: 7.0 all versions
  Hardware: Other
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@ianmacg.plus.com

Description:
Only a small part of the contents of Screen 16:10 format Impress slides are
rendered when printing.  I have noticed that the slide dimensions in this
format are not greater than those for A4 paper.

Steps to Reproduce:
1.Select 'Screen 16:10' as format for slide
2.Create slides and select Print
3.Preview image shows only part of slide content in print area (which is also
how it is printed).

Actual Results:
Only (a small) part of the slide content is printed.

Expected Results:
Complete slide(s) are printed. 


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: Presentation / IMPRESS
OS: Mac OS X 11.6
OS is 64bit: Yes

LibreOffice v 7.0.4.2

OpenGL Renderer: Intel HD Graphics 5000 OpenGL Engine
Vendor: Intel Inc.
Version: 4.1 INTEL-16.5.2
Device: MacBookAir6,2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146635] Spreadsheet crashes Calc when changing sheets or try to enable sheet protection under Linux, works fine under Windows 10

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146635

Timur  changed:

   What|Removed |Added

Summary|Spreadsheet crashes Calc|Spreadsheet crashes Calc
   |when changing sheets or try |when changing sheets or try
   |to enable sheet protection  |to enable sheet protection
   |under Manjaro Linux, works  |under Linux, works fine
   |fin under Windows 10|under Windows 10
 Status|NEW |NEEDINFO

--- Comment #4 from Timur  ---
Julien, I don't know why you didn't close. 
Bjoern, please test with LO master from
https://dev-builds.libreoffice.org/daily/master/current.html.
Those who could reproduce, write if it was with macros disabled or enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - editeng/source

[Miklos Vajna (via logerrit)]

 editeng/source/editeng/impedit3.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit f0a907a62af92ea067f4442979d2c2891e46781e
Author: Miklos Vajna 
AuthorDate: Mon Jan 10 13:38:46 2022 +0100
Commit: Mike Kaganski 
CommitDate: Tue Jan 11 12:16:54 2022 +0100

editeng: avoid writing past the end of of pLine->GetCharPosArray()

Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
0x76df4951 in ?? () from /usr/lib64/libstdc++.so.6
(gdb) bt 10
#0  0x76df4951 in  () at /usr/lib64/libstdc++.so.6
#1  0x76df5792 in __gnu_debug::_Error_formatter::_M_error() 
const () at /usr/lib64/libstdc++.so.6
#2  0x747384bf in std::__debug::vector >::operator[](unsigned long) (this=0x6b3dca0, __n=7) at 
/usr/include/c++/7/debug/vector:417
#3  0x747b5440 in ImpEditEngine::ImpBreakLine(ParaPortion*, 
EditLine*, TextPortion const*, int, long, bool) (this=
0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, 
pPortion=0x6b3e480, nPortionStart=0, nRemainingWidth=5093, bCanHyphenate=false)
at editeng/source/editeng/impedit3.cxx:2041
#4  0x747b1fb6 in ImpEditEngine::CreateLines(int, unsigned 
int) (this=0x1ce0040, nPara=0, nStartPosY=0)
at editeng/source/editeng/impedit3.cxx:1352
#5  0x747ad0c2 in ImpEditEngine::FormatDoc() 
(this=0x1ce0040) at editeng/source/editeng/impedit3.cxx:387
#6  0x747bf516 in ImpEditEngine::FormatAndLayout(EditView*, 
bool) (this=0x1ce0040, pCurView=0x0, bCalledFromUndo=false)
at editeng/source/editeng/impedit3.cxx:4190
#7  0x747be333 in ImpEditEngine::SetUpdateLayout(bool, 
EditView*, bool) (this=0x1ce0040, bUp=true, pCurView=0x0, bForceUpdate=false)
at editeng/source/editeng/impedit3.cxx:3927
#8  0x746f059e in EditEngine::SetUpdateLayout(bool, bool) 
(this=0x1ce2b20, bUpdate=true, bRestoring=false)
at editeng/source/editeng/editeng.cxx:1472
#9  0x748ce5e3 in Outliner::SetText(OutlinerParaObject 
const&) (this=0x1ce0cc0, rPObj=...) at editeng/source/outliner/outliner.cxx:586
(More stack frames follow...)
(gdb) frame 3
#3  0x747b5440 in ImpEditEngine::ImpBreakLine 
(this=0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, pPortion=0x6b3e480, 
nPortionStart=0, nRemainingWidth=5093,
bCanHyphenate=false) at editeng/source/editeng/impedit3.cxx:2041
2041pLine->GetCharPosArray()[ nPosInArray ] = 
rTP.GetSize().Width();
(gdb) print pLine->GetCharPosArray()
[Thread 0x7fffd2010700 (LWP 5008) exited]
$1 = std::__debug::vector of length 7, capacity 7 = {707, 1414, 
2121, 2828, 3535, 4242, 4949}
(gdb) print nPosInArray
$2 = 7

Change-Id: I3a8121c0c0a3b0949e91eb53c0468f7e629b146f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128224
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Mike Kaganski 

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index b905c4ab4f27..233391d8d8e7 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -1486,7 +1486,10 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 TextPortion& rTP = 
pParaPortion->GetTextPortions()[pLine->GetEndPortion()];
 sal_Int32 nPosInArray = pLine->GetEnd()-1-pLine->GetStart();
 tools::Long nNewValue = ( nPosInArray ? pLine->GetCharPosArray()[ 
nPosInArray-1 ] : 0 ) + n;
-pLine->GetCharPosArray()[ nPosInArray ] = nNewValue;
+if (o3tl::make_unsigned(nPosInArray) < 
pLine->GetCharPosArray().size())
+{
+pLine->GetCharPosArray()[ nPosInArray ] = nNewValue;
+}
 rTP.GetSize().AdjustWidth(n );
 }
 
@@ -2041,7 +2044,10 @@ void ImpEditEngine::ImpBreakLine( ParaPortion* 
pParaPortion, EditLine* pLine, Te
 DBG_ASSERT( nBreakPos > pLine->GetStart(), "SplitTextPortion at the 
beginning of the line?" );
 sal_Int32 nPosInArray = nBreakPos - 1 - pLine->GetStart();
 rTP.GetSize().setWidth( ( nPosInArray && ( rTP.GetLen() > 1 ) ) ? 
pLine->GetCharPosArray()[ nPosInArray-1 ] : 0 );
-pLine->GetCharPosArray()[ nPosInArray ] = rTP.GetSize().Width();
+if (o3tl::make_unsigned(nPosInArray) < pLine->GetCharPosArray().size())
+{
+pLine->GetCharPosArray()[ nPosInArray ] = rTP.GetSize().Width();
+}
 }
 else if ( bHyphenated )
 {

tdf#140286 - CALC formula =INFO("OSVERSION") gives wrong output

[Chris Sherlock]

Hi all, 

The output of =INFO(“OSVERSION”) currently gives the wrong version for MacOS 
(it says it is Windows). I have a proposed patch for this in 
https://gerrit.libreoffice.org/c/core/+/127921 


There are two issues:

1. What should the Linux version of this function provide? Given there is no 
Linux version of Excel, we are free to implement whatever we like. However, for 
MacOS Excel currently gives a string in the form "Macintosh (Intel) Version 
11.6.2 (Build 20G314)”, so it seems that we might want to produce the output of 
lsb_release. What should it show? A recent patch returns the kernel version, 
but it seems doubtful that for Excel this is what people expect. 

2. The function AquaSalInstance::getOSVersion() currently gives the MacOS 
release version. This is different from the kernel version on MacOS. Is this 
correct behaviour? My patch changes it to what Excel shows, which seems more 
likely to be what is expected. 

What should be returned here? If it should be the kernel version, then do we 
need to update this? 

If we need to redefine what is shown, do we need to introduce new functions 
into AquaSalInstance to get kernel versions?

Chris

[Libreoffice-bugs] [Bug 139613] Ability to configure motion path indicator colour

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139613

Buovjaga  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Summary|Image effects: moving   |Ability to configure motion
   |images/text boxes   |path indicator colour
   Keywords||needsUXEval

--- Comment #12 from Buovjaga  ---
Thanks, now I can lay out the steps:

1. Open Impress, insert an image or a shape
2. With the object selected, open the Animation Sidebar panel
3. Click Add, select category Motion Paths
4. From the bottom of the list, choose Up

I guess the colour option would belong to Tools - Options - LibreOffice -
Application Colors.

Adding UX team to hear their thoughts.

For your other proposal, please open a new report ("showing the end position or
capability to enter coordinates of final position would also facilitate the
operation")

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 139613] Ability to configure motion path indicator colour

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139613

Buovjaga  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org
Summary|Image effects: moving   |Ability to configure motion
   |images/text boxes   |path indicator colour
   Keywords||needsUXEval

--- Comment #12 from Buovjaga  ---
Thanks, now I can lay out the steps:

1. Open Impress, insert an image or a shape
2. With the object selected, open the Animation Sidebar panel
3. Click Add, select category Motion Paths
4. From the bottom of the list, choose Up

I guess the colour option would belong to Tools - Options - LibreOffice -
Application Colors.

Adding UX team to hear their thoughts.

For your other proposal, please open a new report ("showing the end position or
capability to enter coordinates of final position would also facilitate the
operation")

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 142296] Hyperlinks set on a graphic are not exported in PDF documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142296

Timur  changed:

   What|Removed |Added

 OS|macOS (All) |All
Version|7.1.1.2 release |3.3.0 release

--- Comment #5 from Timur  ---
Looks like ImplementationError from when links were added long ago in LO 3.3. 
OO didn't have those links.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146682

--- Comment #13 from Hans-Werner  ---
CircuitDiagram.svg

[1] svg IMPORT problem -> BLUE circles
+ additional blanks
+ caused by LibreOffice WRITER CALC IMPRESS DRAW

[2] svg EXPORT problem -> VIOLET circles
+ destroyed text areas
+ caused by LibreOffice DRAW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: lotuswordpro/source

[Caolán McNamara (via logerrit)]

 lotuswordpro/source/filter/lwpdrawobj.cxx   |   40 +---
 lotuswordpro/source/filter/lwpsdwdrawheader.hxx |4 +-
 2 files changed, 18 insertions(+), 26 deletions(-)

New commits:
commit 11eecc7dadbee933a1f1e77adb1e4724015d2310
Author: Caolán McNamara 
AuthorDate: Mon Jan 10 19:58:20 2022 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 11 11:59:59 2022 +0100

ofz#43509 use std::vector and at()

Change-Id: Id0c5e4ccc22b41caee95ca5f53f6ae7cf70490f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128263
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/lotuswordpro/source/filter/lwpdrawobj.cxx 
b/lotuswordpro/source/filter/lwpdrawobj.cxx
index 877cf4623872..dfaa84b02217 100644
--- a/lotuswordpro/source/filter/lwpdrawobj.cxx
+++ b/lotuswordpro/source/filter/lwpdrawobj.cxx
@@ -1129,16 +1129,8 @@ LwpDrawTextArt::LwpDrawTextArt(SvStream* pStream, 
DrawingOffsetAndScale* pTransD
 
 LwpDrawTextArt::~LwpDrawTextArt()
 {
-if (m_aTextArtRec.aPath[0].pPts)
-{
-delete [] m_aTextArtRec.aPath[0].pPts;
-m_aTextArtRec.aPath[0].pPts = nullptr;
-}
-if (m_aTextArtRec.aPath[1].pPts)
-{
-delete [] m_aTextArtRec.aPath[1].pPts;
-m_aTextArtRec.aPath[1].pPts = nullptr;
-}
+m_aTextArtRec.aPath[0].aPts.clear();
+m_aTextArtRec.aPath[1].aPts.clear();
 if (m_aTextArtRec.pTextString)
 {
 delete [] m_aTextArtRec.pTextString;
@@ -1150,8 +1142,8 @@ LwpDrawTextArt::~LwpDrawTextArt()
 void LwpDrawTextArt::CreateFWPath(XFDrawPath* pPath)
 {
 sal_Int16 nX, nY;
-nX = (m_aTextArtRec.aPath[0].pPts[0].x + m_aTextArtRec.aPath[1].pPts[0].x) 
/ 2;
-nY = (m_aTextArtRec.aPath[0].pPts[0].y + m_aTextArtRec.aPath[1].pPts[0].y) 
/ 2;
+nX = (m_aTextArtRec.aPath[0].aPts[0].x + m_aTextArtRec.aPath[1].aPts[0].x) 
/ 2;
+nY = (m_aTextArtRec.aPath[0].aPts[0].y + m_aTextArtRec.aPath[1].aPts[0].y) 
/ 2;
 XFPoint aStart(static_cast(nX)/TWIPS_PER_CM * 
m_pTransData->fScaleX,
 static_cast(nY)/TWIPS_PER_CM * m_pTransData->fScaleY);
 pPath->MoveTo(aStart);
@@ -1159,20 +1151,20 @@ void LwpDrawTextArt::CreateFWPath(XFDrawPath* pPath)
 sal_uInt8 nPtIndex = 1;
 for (sal_uInt16 nC = 1; nC <= m_aTextArtRec.aPath[0].n; nC++)
 {
-nX = (m_aTextArtRec.aPath[0].pPts[nPtIndex].x + 
m_aTextArtRec.aPath[1].pPts[nPtIndex].x) / 2;
-nY = (m_aTextArtRec.aPath[0].pPts[nPtIndex].y + 
m_aTextArtRec.aPath[1].pPts[nPtIndex].y) / 2;
+nX = (m_aTextArtRec.aPath[0].aPts.at(nPtIndex).x + 
m_aTextArtRec.aPath[1].aPts.at(nPtIndex).x) / 2;
+nY = (m_aTextArtRec.aPath[0].aPts.at(nPtIndex).y + 
m_aTextArtRec.aPath[1].aPts.at(nPtIndex).y) / 2;
 XFPoint aCtrl1(static_cast(nX)/TWIPS_PER_CM * 
m_pTransData->fScaleX,
 static_cast(nY)/TWIPS_PER_CM * m_pTransData->fScaleY);
 
 nPtIndex++;
-nX = (m_aTextArtRec.aPath[0].pPts[nPtIndex].x + 
m_aTextArtRec.aPath[1].pPts[nPtIndex].x) / 2;
-nY = (m_aTextArtRec.aPath[0].pPts[nPtIndex].y + 
m_aTextArtRec.aPath[1].pPts[nPtIndex].y) / 2;
+nX = (m_aTextArtRec.aPath[0].aPts.at(nPtIndex).x + 
m_aTextArtRec.aPath[1].aPts.at(nPtIndex).x) / 2;
+nY = (m_aTextArtRec.aPath[0].aPts.at(nPtIndex).y + 
m_aTextArtRec.aPath[1].aPts.at(nPtIndex).y) / 2;
 XFPoint aCtrl2(static_cast(nX)/TWIPS_PER_CM * 
m_pTransData->fScaleX,
 static_cast(nY)/TWIPS_PER_CM * m_pTransData->fScaleY);
 
 nPtIndex++;
-nX = (m_aTextArtRec.aPath[0].pPts[nPtIndex].x + 
m_aTextArtRec.aPath[1].pPts[nPtIndex].x) / 2;
-nY = (m_aTextArtRec.aPath[0].pPts[nPtIndex].y + 
m_aTextArtRec.aPath[1].pPts[nPtIndex].y) / 2;
+nX = (m_aTextArtRec.aPath[0].aPts.at(nPtIndex).x + 
m_aTextArtRec.aPath[1].aPts.at(nPtIndex).x) / 2;
+nY = (m_aTextArtRec.aPath[0].aPts.at(nPtIndex).y + 
m_aTextArtRec.aPath[1].aPts.at(nPtIndex).y) / 2;
 XFPoint aDest(static_cast(nX)/TWIPS_PER_CM * 
m_pTransData->fScaleX,
 static_cast(nY)/TWIPS_PER_CM * m_pTransData->fScaleY);
 
@@ -1203,13 +1195,13 @@ void LwpDrawTextArt::Read()
 throw BadRead();
 
 m_aTextArtRec.aPath[0].n = nPointNumber;
-m_aTextArtRec.aPath[0].pPts = new SdwPoint[nPoints];
+m_aTextArtRec.aPath[0].aPts.resize(nPoints);
 for (size_t nPt = 0; nPt < nPoints; ++nPt)
 {
 m_pStream->ReadInt16( nX );
 m_pStream->ReadInt16( nY );
-m_aTextArtRec.aPath[0].pPts[nPt].x = nX;
-m_aTextArtRec.aPath[0].pPts[nPt].y = nY;
+m_aTextArtRec.aPath[0].aPts[nPt].x = nX;
+m_aTextArtRec.aPath[0].aPts[nPt].y = nY;
 }
 
 m_pStream->ReadUInt16( nPointNumber );
@@ -1219,13 +1211,13 @@ void LwpDrawTextArt::Read()
 throw BadRead();
 
 m_aTextArtRec.aPath[1].n = nPointNumber;
-m_aTextArtRec.aPath[1].pPts = new SdwPoint[nPoints];
+m_aTextArtRec.aPath[1].aPts.resize(nPoints);
 for (size_t nPt = 0; nPt < nPoints; ++nPt)
 {
 

[Libreoffice-commits] core.git: emfio/qa

[Stephan Bergmann (via logerrit)]

 emfio/qa/cppunit/wmf/wmfimporttest.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 20a9b1ba01636b2b35b6cc2bc5c1c807055c5e8d
Author: Stephan Bergmann 
AuthorDate: Tue Jan 11 09:20:54 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 11 11:55:26 2022 +0100

Adapt test value intervals to my Linux --without-system-fontconfig build

Change-Id: Ie0867782b0925800cc094f43f8387fb9d1ff0c21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128272
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/emfio/qa/cppunit/wmf/wmfimporttest.cxx 
b/emfio/qa/cppunit/wmf/wmfimporttest.cxx
index a967930ae5ab..db84998523fa 100644
--- a/emfio/qa/cppunit/wmf/wmfimporttest.cxx
+++ b/emfio/qa/cppunit/wmf/wmfimporttest.cxx
@@ -123,7 +123,7 @@ void WmfTest::testTdf88163NonPlaceableWmf()
 // Mac: With fix: 3230, without fix: ~ 8000
 // Windows: With fix: 3303, without fix: ~ 8000
 auto x = getXPath(pDoc, "/metafile/push[2]/font[1]", "height");
-CPPUNIT_ASSERT_GREATER(sal_Int32(3000), x.toInt32());
+CPPUNIT_ASSERT_GREATEREQUAL(sal_Int32(3000), x.toInt32());
 CPPUNIT_ASSERT_LESS(sal_Int32(3500), x.toInt32());
 
 // Fails without the fix: Expected: 7359, Actual: 7336
@@ -161,7 +161,7 @@ void WmfTest::testTdf88163PlaceableWmf()
 // The fix does not affect the font size
 // Linux: 300 - Mac: 309 - Windows: 316
 auto x = getXPath(pDoc, "/metafile/push[2]/font[1]", "height");
-CPPUNIT_ASSERT_GREATER(sal_Int32(290), x.toInt32());
+CPPUNIT_ASSERT_GREATEREQUAL(sal_Int32(287), x.toInt32());
 CPPUNIT_ASSERT_LESS(sal_Int32(320), x.toInt32());
 
 // Fails without the fix: Expected: 1900, Actual: 19818

[Libreoffice-commits] core.git: helpcontent2

[Miklos Vajna (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit efc287877328d3193c23d3a1065b6f015d7d12ef
Author: Miklos Vajna 
AuthorDate: Tue Jan 11 11:53:06 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Jan 11 11:53:06 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to fb8d368b0df51add887d63e7ec866ac06d5102e3
  - Add initial help for the cui themetabpage

The OOXML spec does not say much about the purpose for the 12 colors,
but include some guesses based on what typical themes do.

Change-Id: I00d2b1e64e53c1eb3efe750fc1ebecbd6ff37e2f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128277
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/helpcontent2 b/helpcontent2
index 78e8b7920821..fb8d368b0df5 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 78e8b7920821848f56d081972a2875ed10bba299
+Subproject commit fb8d368b0df51add887d63e7ec866ac06d5102e3

[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146682

Hans-Werner  changed:

   What|Removed |Added

 Attachment #177443|0   |1
is obsolete||

--- Comment #12 from Hans-Werner  ---
Created attachment 177455
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177455=edit
CircuitDiagram.svg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: AllLangHelp_shared.mk source/text

[Miklos Vajna (via logerrit)]

 AllLangHelp_shared.mk  |1 
 source/text/shared/01/05320002.xhp |   64 +
 2 files changed, 65 insertions(+)

New commits:
commit fb8d368b0df51add887d63e7ec866ac06d5102e3
Author: Miklos Vajna 
AuthorDate: Tue Jan 11 11:41:20 2022 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 11 11:53:05 2022 +0100

Add initial help for the cui themetabpage

The OOXML spec does not say much about the purpose for the 12 colors,
but include some guesses based on what typical themes do.

Change-Id: I00d2b1e64e53c1eb3efe750fc1ebecbd6ff37e2f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128277
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/AllLangHelp_shared.mk b/AllLangHelp_shared.mk
index 1892ab417..d6687da3d 100644
--- a/AllLangHelp_shared.mk
+++ b/AllLangHelp_shared.mk
@@ -261,6 +261,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,shared,\
 helpcontent2/source/text/shared/01/05290400 \
 helpcontent2/source/text/shared/01/0532 \
 helpcontent2/source/text/shared/01/05320001 \
+helpcontent2/source/text/shared/01/05320002 \
 helpcontent2/source/text/shared/01/05340100 \
 helpcontent2/source/text/shared/01/05340200 \
 helpcontent2/source/text/shared/01/05340300 \
diff --git a/source/text/shared/01/05320002.xhp 
b/source/text/shared/01/05320002.xhp
new file mode 100644
index 0..92f010043
--- /dev/null
+++ b/source/text/shared/01/05320002.xhp
@@ -0,0 +1,64 @@
+
+
+
+
+
+Theme
+/text/shared/01/05320002.xhp
+
+
+
+
+
+
+Theme
+Adds colors to the selected master 
page.
+
+General
+Name
+Specifies a 
name for this master page theme.
+Color 
Set
+Name
+Specifies a 
name for this set of colors.
+Background - Dark 1
+Specifies the 
first dark color to be used as dark background, typically black.
+Text - 
Light 1
+Specifies the 
first light color to be used as light text, typically white.
+Background - Dark 2
+Specifies the 
second dark color to be used as dark background. This is typically dark, but 
not exactly black.
+Text - 
Light 2
+Specifies the 
second light color to be used as light text. This is typically light, but not 
exactly white.
+Accent 
1
+First custom 
color. This is typically dark enough that light text is readable when the 
custom color is used as a background color.
+Accent 
2
+Second custom 
color.
+Accent 
3
+Third custom 
color.
+Accent 
4
+Fourth custom 
color.
+Accent 
5
+Fifth custom 
color.
+Accent 
6
+Sixth custom 
color.
+Hyperlink
+Color used for 
non-followed hyperlinks.
+Followed Hyperlink
+Color used for 
followed hyperlinks.
+
+

[Libreoffice-bugs] [Bug 146682] Error when importing svg files into Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146682

Hans-Werner  changed:

   What|Removed |Added

 Attachment #177442|0   |1
is obsolete||

--- Comment #11 from Hans-Werner  ---
Created attachment 177454
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177454=edit
CircuitDiagram.odg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #53 from Buovjaga  ---
(In reply to Heiko Tietze from comment #52)
> (In reply to sdc.blanco from comment #51)
> > Result:  No artboards found on the page.
> 
> Use "Edit file" (although made public you might need an account; but it's
> FLOSS)

Can't you just upload a normal image?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #53 from Buovjaga  ---
(In reply to Heiko Tietze from comment #52)
> (In reply to sdc.blanco from comment #51)
> > Result:  No artboards found on the page.
> 
> Use "Edit file" (although made public you might need an account; but it's
> FLOSS)

Can't you just upload a normal image?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141340] Pdf export of pages range adds hyperlinks from previous pages

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141340

Timur  changed:

   What|Removed |Added

 OS|Windows (All)   |All
Summary|pdf export pages range  |Pdf export of pages range
   |hyperlinks  |adds hyperlinks from
   ||previous pages
Version|7.1.1.2 release |6.4.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #52 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #51)
> Result:  No artboards found on the page.

Use "Edit file" (although made public you might need an account; but it's
FLOSS)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #52 from Heiko Tietze  ---
(In reply to sdc.blanco from comment #51)
> Result:  No artboards found on the page.

Use "Edit file" (although made public you might need an account; but it's
FLOSS)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103266] [META] Command line bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103266

Timur  changed:

   What|Removed |Added

 Depends on||146695


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146695
[Bug 146695] Add range of pages in headless export
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146695] New: Add range of pages in headless export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146695

Bug ID: 146695
   Summary: Add range of pages in headless export
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gti...@gmail.com
Blocks: 103266

Lo has very! useful headless export aka convert-to. 
It would be nice to be able to choose page range.
Like: soffice --convert-to pdf pages 2-3


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103266
[Bug 103266] [META] Command line bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - 29 commits - editeng/source include/editeng include/sfx2 include/svx sc/source sfx2/source svx/source vcl/source

[Dennis Francis (via logerrit)]

 editeng/source/editeng/editview.cxx  |   27 ++-
 editeng/source/editeng/impedit.cxx   |   37 -
 editeng/source/editeng/impedit.hxx   |6 +
 include/editeng/editview.hxx |4 +
 include/sfx2/ipclient.hxx|4 +
 include/sfx2/lokcharthelper.hxx  |3 
 include/svx/svdmrkv.hxx  |6 +
 sc/source/core/tool/editutil.cxx |6 +
 sc/source/ui/cctrl/checklistmenu.cxx |   13 ++-
 sc/source/ui/cctrl/dpcontrol.cxx |7 +
 sc/source/ui/drawfunc/drawsh.cxx |5 +
 sc/source/ui/drawfunc/fusel.cxx  |   12 +++
 sc/source/ui/inc/gridwin.hxx |4 -
 sc/source/ui/unoobj/docuno.cxx   |   34 ++--
 sc/source/ui/view/drawvie3.cxx   |2 
 sc/source/ui/view/drawview.cxx   |   16 ++--
 sc/source/ui/view/gridwin2.cxx   |7 +
 sc/source/ui/view/gridwin4.cxx   |  135 ---
 sc/source/ui/view/tabview.cxx|   16 +++-
 sc/source/ui/view/tabview3.cxx   |7 +
 sc/source/ui/view/tabvwsh2.cxx   |3 
 sc/source/ui/view/tabvwshb.cxx   |   14 +++
 sc/source/ui/view/viewdata.cxx   |   32 
 sfx2/source/view/ipclient.cxx|   26 ++
 sfx2/source/view/lokcharthelper.cxx  |6 +
 svx/source/svdraw/sdrpagewindow.cxx  |   13 ++-
 svx/source/svdraw/svdedxv.cxx|3 
 svx/source/svdraw/svdmrkv.cxx|   36 -
 svx/source/svdraw/svdview.cxx|8 ++
 vcl/source/gdi/bmpacc2.cxx   |5 +
 30 files changed, 417 insertions(+), 80 deletions(-)

New commits:
commit f1ff0ec57914e8871f8563cd26ee1b87d562f1c8
Author: Dennis Francis 
AuthorDate: Mon Jan 10 12:03:54 2022 +0530
Commit: Andras Timar 
CommitDate: Tue Jan 11 11:18:10 2022 +0100

lokCalcRTL: fix chart insertion position

Change-Id: I573cb19643d7a048f3313aba90fa9b5514c9cc74

diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index f1aa58eabaf3..4dda1b46aa50 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -1703,9 +1703,12 @@ Point ScTabView::GetChartInsertPos( const Size& rSize, 
const ScRange& rCellRange
 ActivatePart( eUsedPart );
 
 //  get the visible rectangle in logic units
-
+bool bLOKActive = comphelper::LibreOfficeKit::isActive();
 MapMode aDrawMode = pWin->GetDrawMapMode();
-tools::Rectangle aVisible( pWin->PixelToLogic( tools::Rectangle( 
Point(0,0), pWin->GetOutputSizePixel() ), aDrawMode ) );
+tools::Rectangle aVisible(
+bLOKActive ?
+OutputDevice::LogicToLogic( aViewData.getLOKVisibleArea(), 
MapMode(MapUnit::MapTwip), MapMode(MapUnit::Map100thMM) )
+: pWin->PixelToLogic( tools::Rectangle( Point(0,0), 
pWin->GetOutputSizePixel() ), aDrawMode ) );
 
 ScDocument& rDoc = aViewData.GetDocument();
 SCTAB nTab = aViewData.GetTabNo();
@@ -1729,6 +1732,14 @@ Point ScTabView::GetChartInsertPos( const Size& rSize, 
const ScRange& rCellRange
 tools::Rectangle aSelection = rDoc.GetMMRect( rCellRange.aStart.Col(), 
rCellRange.aStart.Row(),
 rCellRange.aEnd.Col(), 
rCellRange.aEnd.Row(), nTab );
 
+if (bLOKActive && bLayoutRTL)
+{
+// In this case we operate in negative X coordinates. The 
rectangle aSelection already
+// has negative X coordinates. So the x coordinates in the 
rectangle aVisible(from getLOKVisibleArea)
+// need be negated to match.
+aVisible = tools::Rectangle(-aVisible.Right(), aVisible.Top(), 
-aVisible.Left(), aVisible.Bottom());
+}
+
 tools::Long nLeftSpace = aSelection.Left() - aVisible.Left();
 tools::Long nRightSpace = aVisible.Right() - aSelection.Right();
 tools::Long nTopSpace = aSelection.Top() - aVisible.Top();
@@ -1755,7 +1766,6 @@ Point ScTabView::GetChartInsertPos( const Size& rSize, 
const ScRange& rCellRange
 else if ( nTopSpace >= nNeededHeight || nBottomSpace >= nNeededHeight )
 {
 // second preference: completely above or below the selection
-
 if ( nBottomSpace > nNeededHeight ) // bottom is 
preferred
 aInsertPos.setY( aSelection.Bottom() + 1 );
 else
commit c2cbe0dbe4c9e4ce8014e881ba3663add77f7aca
Author: Dennis Francis 
AuthorDate: Thu Jan 6 15:12:16 2022 +0530
Commit: Andras Timar 
CommitDate: Tue Jan 11 11:18:10 2022 +0100

lokCalcRTL: trim invalidation rect to ensure +ve X

Change-Id: Ifecb52167e3cddee036e1e1e9bd5782a1138b654

diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index cb085fcc6e64..087f08271a5a 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1627,6 +1627,15 @@ void ScGridWindow::LogicInvalidate(const 
tools::Rectangle* pRectangle)
 pResultRectangle = 
 }
 
+// Trim invalidation rectangle overlapping negative X 

[Libreoffice-bugs] [Bug 141340] pdf export pages range hyperlinks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141340

Timur  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression

--- Comment #6 from Timur  ---
Most useful, although tedious, is to find if regression and worked before. 
No repro 6.4.0, repro 6.4.7 and 7.4+.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #51 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #50)
> Mockup is here:
> https://design.penpot.app/#/view/83184000-72be-11ec-8da6-c2b142838c8b?page-
> id=83184001-72be-11ec-8da6-c2b142838c8b=0=b40c0ac0-72c3-11ec-
> 8da6-c2b142838c8b
Result:  No artboards found on the page.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #51 from sdc.bla...@youmail.dk ---
(In reply to Heiko Tietze from comment #50)
> Mockup is here:
> https://design.penpot.app/#/view/83184000-72be-11ec-8da6-c2b142838c8b?page-
> id=83184001-72be-11ec-8da6-c2b142838c8b=0=b40c0ac0-72c3-11ec-
> 8da6-c2b142838c8b
Result:  No artboards found on the page.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - lotuswordpro/source

[Caolán McNamara (via logerrit)]

 lotuswordpro/source/filter/lwpdrawobj.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 35be5565c8e054a343954ee545df65c29384ff27
Author: Caolán McNamara 
AuthorDate: Sun Jan 9 16:16:39 2022 +
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 11:15:42 2022 +0100

ofz#43458 avoid OOM

Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit e28f4b6bccafb2b9f3c44dfabf36d1b822d85f84)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128236
Reviewed-by: Xisco Fauli 

diff --git a/lotuswordpro/source/filter/lwpdrawobj.cxx 
b/lotuswordpro/source/filter/lwpdrawobj.cxx
index 547017a68555..89eaf1c0a255 100644
--- a/lotuswordpro/source/filter/lwpdrawobj.cxx
+++ b/lotuswordpro/source/filter/lwpdrawobj.cxx
@@ -1046,6 +1046,8 @@ void LwpDrawTextBox::Read()
 
 // the 71 is the fixed length before text content in textbox record
 sal_Int16 TextLength = m_aObjHeader.nRecLen - 71;
+if (TextLength < 0)
+throw BadRead();
 m_aTextRec.pTextString = new sal_uInt8 [TextLength];
 
 m_pStream->ReadBytes(m_aTextRec.pTextString, TextLength);

[Libreoffice-bugs] [Bug 146687] Calc ... from a worksheet, with macro, open other worksheet and triplicate (copy) or more a sheet in it .. crash

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146687

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEEDINFO

--- Comment #5 from Xisco Faulí  ---
I can't reproduce it in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: bf883027ee62ece0844730572305094f53daa521
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

To be certain the reported issue is not related to corruption in the user
profile, could you please reset your Libreoffice profile (
https://wiki.documentfoundation.org/UserProfile ) and re-test?

I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' if the issue is still present

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146575] Writer won't export hyperlinks to pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146575

Timur  changed:

   What|Removed |Added

Version|7.2.4.1 release |5.4.0.3 release
 Ever confirmed|0   |1
 OS|Windows (All)   |All
 Status|UNCONFIRMED |NEW
   Keywords||bibisected, bisected,
   ||regression
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||7211

--- Comment #5 from Timur  ---
It worked long ago. No repro 5.3.0. Repro LO 5.4 and 7.4+.

Linux-54
commit 6f5d6484fd8ffcc41829cd5ccb5017e7c749fe02
Date:   Wed Apr 26 03:10:33 2017 +0200
source sha:157013219230f251346a5aa662c39d02f15420ec
pre 4e3d14deb74c57632db57663d2fc2ead9d8aa0f0

author  Michael Stahl2017-04-21
commit  157013219230f251346a5aa662c39d02f15420ec (patch)
tdf#107211 sw: ODF import: add a horrible hack to import "Default"
... character style for hyperlinks and index-entry-templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: external/fontconfig

[Stephan Bergmann (via logerrit)]

 external/fontconfig/ExternalProject_fontconfig.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit c1d1588ab6665403b9b35e3e85d915b9cfccffe8
Author: Stephan Bergmann 
AuthorDate: Tue Jan 11 09:14:43 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 11 11:00:14 2022 +0100

Make external/fontconfig use -fPIC

...to prevent Library_skia from failing to link with

> /usr/bin/ld.gold: error: 
workdir/UnpackedTarball/fontconfig/src/.libs/libfontconfig.a(fccfg.o): requires 
dynamic R_X86_64_32 reloc which may overflow at runtime; recompile with -fPIC

etc. in a --without-system-fontconfig build

Change-Id: Idd09785096d1a8be3f3086d6e565f307fa046a60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128267
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/fontconfig/ExternalProject_fontconfig.mk 
b/external/fontconfig/ExternalProject_fontconfig.mk
index 1d65173ce0f5..8cb9498fe763 100644
--- a/external/fontconfig/ExternalProject_fontconfig.mk
+++ b/external/fontconfig/ExternalProject_fontconfig.mk
@@ -25,6 +25,7 @@ $(call gb_ExternalProject_get_state_target,fontconfig,build) :
$(gb_RUN_CONFIGURE) ./configure \
--disable-shared \
--disable-silent-rules \
+   --with-pic \
$(if $(filter ANDROID,$(OS)),--with-arch=arm) \
--with-expat-includes=$(call 
gb_UnpackedTarball_get_dir,expat)/lib \
--with-expat-lib=$(gb_StaticLibrary_WORKDIR) \

[Libreoffice-bugs] [Bug 98596] Linux: Handling of fonts with more than 4 styles (R/B/I/BI) is suboptimal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98596

Thomas Linard  changed:

   What|Removed |Added

Summary|Incorrect handling of font  |Linux: Handling of fonts
   |families (weight, style,|with more than 4 styles
   |stretches) on Linux |(R/B/I/BI) is suboptimal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 69254] Mac: Handling of fonts with more than 4 styles (R/B/I/BI) is suboptimal

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69254

Thomas Linard  changed:

   What|Removed |Added

Summary|Incorrect handling of font  |Mac: Handling of fonts with
   |families (weight, style,|more than 4 styles
   |stretches) on Mac   |(R/B/I/BI) is suboptimal

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137915] Hyperlinks to a local document fail in exported PDFs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137915

--- Comment #7 from Timur  ---
Is this the same as bug 142707?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #50 from Heiko Tietze  ---
Created attachment 177453
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177453=edit
Mockup

(In reply to Heiko Tietze from comment #48)
> We could use an entry "Same as Outline Level" in the dropdown.

Like this?

In case Outline is set to Text Body the "same as" option should be hidden, of
course.

I wonder what happens on promote/demote. Sounds wrong to change the value in
this dialog. Perhaps we have to name it "Initial List Level", which adds some
confusion in first place.

Mockup is here:
https://design.penpot.app/#/view/83184000-72be-11ec-8da6-c2b142838c8b?page-id=83184001-72be-11ec-8da6-c2b142838c8b=0=b40c0ac0-72c3-11ec-8da6-c2b142838c8b

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 62032] Cannot specify a Paragraph Style to use a numbering level (over 1) for a chosen Numbering (List) style (See comment 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62032

--- Comment #50 from Heiko Tietze  ---
Created attachment 177453
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177453=edit
Mockup

(In reply to Heiko Tietze from comment #48)
> We could use an entry "Same as Outline Level" in the dropdown.

Like this?

In case Outline is set to Text Body the "same as" option should be hidden, of
course.

I wonder what happens on promote/demote. Sounds wrong to change the value in
this dialog. Perhaps we have to name it "Initial List Level", which adds some
confusion in first place.

Mockup is here:
https://design.penpot.app/#/view/83184000-72be-11ec-8da6-c2b142838c8b?page-id=83184001-72be-11ec-8da6-c2b142838c8b=0=b40c0ac0-72c3-11ec-8da6-c2b142838c8b

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 144488] HYPERLINKS: Hyperlink to target in external document doesn't work in exported PDF (steps in comment 4)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144488

--- Comment #8 from Timur  ---
Is this the same as bug 142707?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145621] Crash swlo!IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark+0x2681 at overwriting certain area

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145621

Xisco Faulí  changed:

   What|Removed |Added

 CC||vasudev.naraya...@aol.com

--- Comment #13 from Xisco Faulí  ---
*** Bug 145880 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145880] Crash in: sw::mark::MarkManager::renameMark(sw::mark::IMark *, rtl::OUString const &)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145880

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
it looks like a duplicate of bug 145621 and it should be fixed in LibreOffice
7.2.5.2

*** This bug has been marked as a duplicate of bug 145621 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144488] HYPERLINKS: Hyperlink to target in external document doesn't work in exported PDF (steps in comment 4)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144488

--- Comment #7 from Timur  ---
It's much easier to test if there are minimal sample documents created and
attached here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] dev-tools.git: test-bugzilla-files/zip.sh

[Caolán McNamara (via logerrit)]

 test-bugzilla-files/zip.sh |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit f8ff10fe45a61b7099e64a5998a36258c5328dd9
Author: Caolán McNamara 
AuthorDate: Tue Jan 11 09:33:47 2022 +
Commit: Caolán McNamara 
CommitDate: Tue Jan 11 10:36:52 2022 +0100

create zip files to transport logs fresh each time

don't let them grow without bound

Change-Id: I373ec1ccf18973dcfe4f96859cf20d3d01e8e867
Reviewed-on: https://gerrit.libreoffice.org/c/dev-tools/+/128276
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/test-bugzilla-files/zip.sh b/test-bugzilla-files/zip.sh
index b35117f..4808b43 100755
--- a/test-bugzilla-files/zip.sh
+++ b/test-bugzilla-files/zip.sh
@@ -19,8 +19,10 @@ num_of_excluded_file=$(< 
"/srv/crashtestdata/odfundiff_exclude_list.txt" wc -l)
 previous_hash="$(cat /srv/crashtestdata/previous/hash.txt)"
 rm -rf /srv/crashtestdata/logs/$SHA/odfundiff
 cd /srv/crashtestdata/current/srv/crashtestdata/files/
+rm -f odfundiff.zip
 zip -r -q odfundiff.zip */*.odfundiff
 mv odfundiff.zip /srv/crashtestdata/logs/$SHA/.
+rm -f validation.zip
 zip -r -q validation.zip */*.log
 mv validation.zip /srv/crashtestdata/logs/$SHA/.
 cd /srv/crashtestdata/logs/$SHA
@@ -33,6 +35,7 @@ cp ../exportCrashes.csv ../importCrash.csv ../odfundiff.csv 
../validationErrors.
 python analyze_logs.py
 cp exportCrashes.csv importCrash.csv odfundiff.csv validationErrors.csv ../.
 cd ..
+rm -f current.zip
 zip -r current.zip $SHA/*
 if [ -z "$CRASHTEST_NO_UPLOAD" ]; then
 scp current.zip 
upl...@gimli.documentfoundation.org:/srv/www/dev-builds.libreoffice.org/crashtest/.

[Libreoffice-bugs] [Bug 146605] Cannot change section footnote/endnote position after section is initially created

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146605

Michael Stahl (allotropia)  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
   Keywords|bibisectRequest |bisected
   Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de
   |desktop.org |

--- Comment #4 from Michael Stahl (allotropia)  ---
hope its fixed on master, maybe Bjoern wants to add a unit test...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145090] LO Calc Crash with drop-down-menu (GTK3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145090

--- Comment #24 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/02e7628f603959d15c0f1b8a8d2c17b1550479b3

tdf#145090 LO Calc Crash with drop-down-menu

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145090] LO Calc Crash with drop-down-menu (GTK3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145090

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.3.0.2 |target:7.4.0 target:7.3.0.2
   ||target:7.2.6

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - comphelper/source include/comphelper

[Noel Grandin (via logerrit)]

 comphelper/source/misc/accessiblewrapper.cxx |4 ++--
 include/comphelper/accessiblewrapper.hxx |2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 02e7628f603959d15c0f1b8a8d2c17b1550479b3
Author: Noel Grandin 
AuthorDate: Fri Dec 24 20:15:53 2021 +0200
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:29:38 2022 +0100

tdf#145090 LO Calc Crash with drop-down-menu

avoid attempting to call into widgets while in the middle of dispose

regression from
commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac
IsDisposed->isDisposed in vcl/../window

Change-Id: If346dc9dc8547f8da28d091bfa20eff39162a0b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127437
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 3454055d4da3326540905fc69626b934d5aa0744)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127483
Reviewed-by: Adolfo Jayme Barrientos 
(cherry picked from commit 0c183add008e3604711d1995716cdcffc0881dc6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127577
Reviewed-by: Xisco Fauli 

diff --git a/comphelper/source/misc/accessiblewrapper.cxx 
b/comphelper/source/misc/accessiblewrapper.cxx
index 9aa1b48e2f1e..1167f56403c3 100644
--- a/comphelper/source/misc/accessiblewrapper.cxx
+++ b/comphelper/source/misc/accessiblewrapper.cxx
@@ -86,7 +86,7 @@ namespace comphelper
 Reference< XAccessible > 
OWrappedAccessibleChildrenManager::getAccessibleWrapperFor(
 const Reference< XAccessible >& _rxKey )
 {
-Reference< XAccessible > xValue;
+rtl::Reference< OAccessibleWrapper > xValue;
 
 if( !_rxKey.is() )
 {
@@ -140,7 +140,7 @@ namespace comphelper
 
 Reference< XComponent > xContextComponent;
 if( rChild.second.is() )
-xContextComponent.set( rChild.second->getAccessibleContext(),
+xContextComponent.set( rChild.second->getContextNoCreate(),
::css::uno::UNO_QUERY );
 if( xContextComponent.is() )
 xContextComponent->dispose();
diff --git a/include/comphelper/accessiblewrapper.hxx 
b/include/comphelper/accessiblewrapper.hxx
index ea9a0af0209b..f73c312c3ab5 100644
--- a/include/comphelper/accessiblewrapper.hxx
+++ b/include/comphelper/accessiblewrapper.hxx
@@ -316,7 +316,7 @@ namespace comphelper
 
 
 typedef ::std::map  <   css::uno::Reference< 
css::accessibility::XAccessible >
-,   css::uno::Reference< 
css::accessibility::XAccessible >
+,   rtl::Reference< comphelper::OAccessibleWrapper >
 >   AccessibleMap;
 // TODO: think about if we should hold these objects 
weak
 

[Libreoffice-bugs] [Bug 145090] LO Calc Crash with drop-down-menu (GTK3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145090

Xisco Faulí  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #23 from Xisco Faulí  ---
Verified in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: bf883027ee62ece0844730572305094f53daa521
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146605] Cannot change section footnote/endnote position after section is initially created

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146605

--- Comment #3 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cb188ce336e434c2b7002b3d8a41a681e73ae51a

tdf#146605 sw: try to fix SwSectionFormat notifications

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146605] Cannot change section footnote/endnote position after section is initially created

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146605

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/source

[Michael Stahl (via logerrit)]

 sw/inc/section.hxx |3 +++
 sw/source/core/docnode/section.cxx |8 
 sw/source/core/inc/sectfrm.hxx |4 
 sw/source/core/layout/sectfrm.cxx  |   11 +++
 4 files changed, 26 insertions(+)

New commits:
commit cb188ce336e434c2b7002b3d8a41a681e73ae51a
Author: Michael Stahl 
AuthorDate: Mon Jan 10 16:45:33 2022 +0100
Commit: Michael Stahl 
CommitDate: Tue Jan 11 10:27:43 2022 +0100

tdf#146605 sw: try to fix SwSectionFormat notifications

SwSectionFormat no longer notifies via its SwModify to SwClient
listeners, but only via SvtBroadcaster, so SwSection and SwSectionFrame
need to be SvtListeners.

This can be seen when changing the footnote-at-end setting in the
section dialog, if the SwSection doesn't get the event the footnote
numbers aren't adapted to a new restart value, if the SwSectionFrame
doesn't get the event the footnote container isn't moved.

This is of course not pretty but hopefully it will be refactored further
in the future.

(regression from commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a)

Change-Id: I93c616e209a01fc5d4c8eba701a6ddce5d5b432e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128257
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/inc/section.hxx b/sw/inc/section.hxx
index 65591f216ee1..4350048f9700 100644
--- a/sw/inc/section.hxx
+++ b/sw/inc/section.hxx
@@ -24,6 +24,7 @@
 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -137,6 +138,7 @@ public:
 
 class SW_DLLPUBLIC SwSection
 : public SwClient
+, public SvtListener // needed for SwClientNotify to be called from 
SwSectionFormat
 {
 // In order to correctly maintain the flag when creating/deleting frames.
 friend class SwSectionNode;
@@ -153,6 +155,7 @@ private:
 bool const bHidden, bool const bCondition);
 
 protected:
+virtual void Notify(SfxHint const& rHint) override;
 virtual void SwClientNotify(const SwModify&, const SfxHint&) override;
 
 public:
diff --git a/sw/source/core/docnode/section.cxx 
b/sw/source/core/docnode/section.cxx
index 12feba3c3eb6..390600cfa3ba 100644
--- a/sw/source/core/docnode/section.cxx
+++ b/sw/source/core/docnode/section.cxx
@@ -198,6 +198,8 @@ SwSection::SwSection(
 : SwClient(& rFormat)
 , m_Data(eType, rName)
 {
+StartListening(rFormat.GetNotifier());
+
 SwSection *const pParentSect = GetParent();
 if( pParentSect )
 {
@@ -230,6 +232,7 @@ SwSection::~SwSection()
 else
 {
 pFormat->Remove( this ); // remove
+SvtListener::EndListeningAll();
 
 if (SectionType::Content != m_Data.GetType())
 {
@@ -400,6 +403,11 @@ void SwSection::SetEditInReadonly(bool const bFlag)
 }
 
 void SwSection::SwClientNotify(const SwModify&, const SfxHint& rHint)
+{
+Notify(rHint);
+}
+
+void SwSection::Notify(SfxHint const& rHint)
 {
 if (rHint.GetId() != SfxHintId::SwLegacyModify)
 return;
diff --git a/sw/source/core/inc/sectfrm.hxx b/sw/source/core/inc/sectfrm.hxx
index 276819dff7bf..09c742f8da79 100644
--- a/sw/source/core/inc/sectfrm.hxx
+++ b/sw/source/core/inc/sectfrm.hxx
@@ -22,6 +22,8 @@
 #include "layfrm.hxx"
 #include "flowfrm.hxx"
 
+#include 
+
 class SwSection;
 class SwSectionFormat;
 class SwAttrSetChg;
@@ -45,6 +47,7 @@ namespace o3tl {
 }
 
 class SwSectionFrame final: public SwLayoutFrame, public SwFlowFrame
+, public SvtListener // TODO?
 {
 SwSection* m_pSection;
 bool m_bFootnoteAtEnd; // footnotes at the end of section
@@ -70,6 +73,7 @@ class SwSectionFrame final: public SwLayoutFrame, public 
SwFlowFrame
 virtual void MakeAll(vcl::RenderContext* pRenderContext) override;
 virtual bool ShouldBwdMoved( SwLayoutFrame *pNewUpper, bool  ) 
override;
 virtual void Format( vcl::RenderContext* pRenderContext, const 
SwBorderAttrs *pAttrs = nullptr ) override;
+virtual void Notify(SfxHint const& rHint) override;
 virtual void SwClientNotify( const SwModify&, const SfxHint& ) override;
 
 public:
diff --git a/sw/source/core/layout/sectfrm.cxx 
b/sw/source/core/layout/sectfrm.cxx
index 7d1cb799be91..9b33ceeadd63 100644
--- a/sw/source/core/layout/sectfrm.cxx
+++ b/sw/source/core/layout/sectfrm.cxx
@@ -74,6 +74,8 @@ SwSectionFrame::SwSectionFrame( SwSection , SwFrame* 
pSib )
 , m_bOwnFootnoteNum(false)
 , m_bFootnoteLock(false)
 {
+StartListening(rSect.GetFormat()->GetNotifier());
+
 mnFrameType = SwFrameType::Section;
 
 CalcFootnoteAtEndFlag();
@@ -90,6 +92,8 @@ SwSectionFrame::SwSectionFrame( SwSectionFrame , bool 
bMaster ) :
 m_bOwnFootnoteNum( false ),
 m_bFootnoteLock( false )
 {
+StartListening(rSect.GetFormat()->GetNotifier());
+
 mnFrameType = SwFrameType::Section;
 
 PROTOCOL( this, PROT::Section, bMaster ? DbgAction::CreateMaster : 
DbgAction::CreateFollow,  )
@@ -2567,6 +2571,13 @@ void SwSectionFrame::CalcEndAtEndFlag()
 }
 }
 
+void 

[Libreoffice-bugs] [Bug 136186] vsdx import incorrectly render process boxes as white (making text unreadable)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136186

Xisco Faulí  changed:

   What|Removed |Added

 CC||tima...@gmail.com

--- Comment #16 from Xisco Faulí  ---
@Andras, since you fixed bug 73523, I thought you might be interested in this
issue as well

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47148] [META] Image handling problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47148
Bug 47148 depends on bug 127670, which changed state.

Bug 127670 Summary: LO --> insert .bmp file looks like black screen
https://bugs.documentfoundation.org/show_bug.cgi?id=127670

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127670] LO --> insert .bmp file looks like black screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127670

Xisco Faulí  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||xiscofa...@libreoffice.org

--- Comment #5 from Xisco Faulí  ---
Issue fixed by
https://cgit.freedesktop.org/libreoffice/core/commit/?id=3a0d539b3a8a76efc2cdac04c658645fe750bec4
Closing as duplicated of bug 73523

*** This bug has been marked as a duplicate of bug 73523 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136186] vsdx import incorrectly render process boxes as white (making text unreadable)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136186

--- Comment #15 from Xisco Faulí  ---
Still reproducible in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: bf883027ee62ece0844730572305094f53daa521
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146694] This is first post

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146694

Buovjaga  changed:

   What|Removed |Added

  Component|BASIC   |deletionRequest
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146684] Libvisio: imported images from vsdx are black

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146684

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #2 from Xisco Faulí  ---
Yes, I do confirm the issue is fixed in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: bf883027ee62ece0844730572305094f53daa521
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146693] Calc crashes when/after changing a note

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146693

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Xisco Faulí  ---
Thank you for reporting the bug. Please attach a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the requested document is provided.
(Please note that the attachment will be public, remove any sensitive
information before attaching it. 
See
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
for help on how to do so.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.4' - vcl/qa vcl/source

[Miklos Vajna (via logerrit)]

 vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg |binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx|   32 
 vcl/source/gdi/pdfwriter_impl.cxx |   35 ++
 3 files changed, 67 insertions(+)

New commits:
commit 33c9bc0225a92f26770f9ef20b252af47853e7b9
Author: Miklos Vajna 
AuthorDate: Fri Jan 7 12:23:34 2022 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 11 10:10:26 2022 +0100

PDF export of PDF images: preserve hyperlinks

The input file has a single page, with a full-page PDF image, which
contains a hyperlink. Similar to pdfcrop, we used to wrap this into a
form XObject, so page-level annotations like hyperlinks were lost.

Explicitly merge page-level annotations from the source page to the page
that contains the PDF image to preserve those annotations.

(cherry picked from commit 1984a5c140cc3c7c291047dacf3bddd7061d2047)

Conflicts:
vcl/qa/cppunit/pdfexport/pdfexport.cxx

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128127
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 
(cherry picked from commit 58e6fce28f7d3e1c1504f048be5766dc732af4e7)

Change-Id: I96e8bc9d33440b91f3514486d6a8bd75047546b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128253
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg 
b/vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg
new file mode 100644
index ..aa0f89300b2c
Binary files /dev/null and 
b/vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index aa96ee8a0f99..94248572c887 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -147,6 +147,7 @@ public:
 void testDefaultVersion();
 void testMultiPagePDF();
 void testPdfImageRotate180();
+void testPdfImageHyperlink();
 
 
 CPPUNIT_TEST_SUITE(PdfExportTest);
@@ -191,6 +192,7 @@ public:
 CPPUNIT_TEST(testDefaultVersion);
 CPPUNIT_TEST(testMultiPagePDF);
 CPPUNIT_TEST(testPdfImageRotate180);
+CPPUNIT_TEST(testPdfImageHyperlink);
 CPPUNIT_TEST_SUITE_END();
 };
 
@@ -2252,6 +2254,36 @@ void PdfExportTest::testPdfImageRotate180()
 CPPUNIT_ASSERT_DOUBLES_EQUAL(-1.0, aScale.getX(), 0.01);
 }
 
+void PdfExportTest::testPdfImageHyperlink()
+{
+// Given a Draw file, containing a PDF image, which has a hyperlink in it:
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"pdf-image-hyperlink.odg";
+mxComponent = loadFromDesktop(aURL);
+CPPUNIT_ASSERT(mxComponent.is());
+
+// When saving to PDF:
+uno::Reference xStorable(mxComponent, uno::UNO_QUERY);
+utl::MediaDescriptor aMediaDescriptor;
+aMediaDescriptor["FilterName"] <<= OUString("draw_pdf_Export");
+xStorable->storeToURL(maTempFile.GetURL(), 
aMediaDescriptor.getAsConstPropertyValueList());
+
+// Then make sure that link is preserved:
+SvFileStream aFile(maTempFile.GetURL(), StreamMode::READ);
+maMemory.WriteStream(aFile);
+std::shared_ptr pPDFium = vcl::pdf::PDFiumLibrary::get();
+std::unique_ptr pPdfDocument
+= pPDFium->openDocument(maMemory.GetData(), maMemory.GetSize());
+CPPUNIT_ASSERT(pPdfDocument);
+CPPUNIT_ASSERT_EQUAL(1, pPdfDocument->getPageCount());
+std::unique_ptr pPdfPage = 
pPdfDocument->openPage(/*nIndex=*/0);
+CPPUNIT_ASSERT(pPdfPage);
+int nStartPos = 0;
+FPDF_LINK pLinkAnnot = nullptr;
+// Without the accompanying fix in place, this test would have failed, the 
hyperlink of the PDF
+// image was lost.
+CPPUNIT_ASSERT(FPDFLink_Enumerate(pPdfPage->getPointer(), , 
));
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(PdfExportTest);
 
 }
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 8b435678f93d..b78ae731e8bd 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8738,6 +8738,41 @@ void 
PDFWriterImpl::writeReferenceXObject(ReferenceXObjectEmit& rEmit)
 return;
 }
 
+// Merge page annotations (links, etc) from pPage to our page.
+std::vector aAnnots;
+if (auto pArray = 
dynamic_cast(pPage->Lookup("Annots")))
+{
+for (const auto pElement : pArray->GetElements())
+{
+auto pReference = 
dynamic_cast(pElement);
+if (!pReference)
+{
+continue;
+}
+
+filter::PDFObjectElement* pObject = pReference->LookupObject();
+if (!pObject)
+{
+continue;
+}
+
+// Annotation refers to an object, remember it.
+aAnnots.push_back(pObject);
+}
+ 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - editeng/source

[Miklos Vajna (via logerrit)]

 editeng/source/editeng/impedit3.cxx |   10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

New commits:
commit e1449eaf3b2b0bf4ebed44bbcf54e5e01d356465
Author: Miklos Vajna 
AuthorDate: Mon Jan 10 13:38:46 2022 +0100
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:09:42 2022 +0100

editeng: avoid writing past the end of of pLine->GetCharPosArray()

Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
0x76df4951 in ?? () from /usr/lib64/libstdc++.so.6
(gdb) bt 10
#0  0x76df4951 in  () at /usr/lib64/libstdc++.so.6
#1  0x76df5792 in __gnu_debug::_Error_formatter::_M_error() 
const () at /usr/lib64/libstdc++.so.6
#2  0x747384bf in std::__debug::vector >::operator[](unsigned long) (this=0x6b3dca0, __n=7) at 
/usr/include/c++/7/debug/vector:417
#3  0x747b5440 in ImpEditEngine::ImpBreakLine(ParaPortion*, 
EditLine*, TextPortion const*, int, long, bool) (this=
0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, 
pPortion=0x6b3e480, nPortionStart=0, nRemainingWidth=5093, bCanHyphenate=false)
at editeng/source/editeng/impedit3.cxx:2041
#4  0x747b1fb6 in ImpEditEngine::CreateLines(int, unsigned 
int) (this=0x1ce0040, nPara=0, nStartPosY=0)
at editeng/source/editeng/impedit3.cxx:1352
#5  0x747ad0c2 in ImpEditEngine::FormatDoc() 
(this=0x1ce0040) at editeng/source/editeng/impedit3.cxx:387
#6  0x747bf516 in ImpEditEngine::FormatAndLayout(EditView*, 
bool) (this=0x1ce0040, pCurView=0x0, bCalledFromUndo=false)
at editeng/source/editeng/impedit3.cxx:4190
#7  0x747be333 in ImpEditEngine::SetUpdateLayout(bool, 
EditView*, bool) (this=0x1ce0040, bUp=true, pCurView=0x0, bForceUpdate=false)
at editeng/source/editeng/impedit3.cxx:3927
#8  0x746f059e in EditEngine::SetUpdateLayout(bool, bool) 
(this=0x1ce2b20, bUpdate=true, bRestoring=false)
at editeng/source/editeng/editeng.cxx:1472
#9  0x748ce5e3 in Outliner::SetText(OutlinerParaObject 
const&) (this=0x1ce0cc0, rPObj=...) at editeng/source/outliner/outliner.cxx:586
(More stack frames follow...)
(gdb) frame 3
#3  0x747b5440 in ImpEditEngine::ImpBreakLine 
(this=0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, pPortion=0x6b3e480, 
nPortionStart=0, nRemainingWidth=5093,
bCanHyphenate=false) at editeng/source/editeng/impedit3.cxx:2041
2041pLine->GetCharPosArray()[ nPosInArray ] = 
rTP.GetSize().Width();
(gdb) print pLine->GetCharPosArray()
[Thread 0x7fffd2010700 (LWP 5008) exited]
$1 = std::__debug::vector of length 7, capacity 7 = {707, 1414, 
2121, 2828, 3535, 4242, 4949}
(gdb) print nPosInArray
$2 = 7

Change-Id: I3a8121c0c0a3b0949e91eb53c0468f7e629b146f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128223
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 56ded398c9c72810f20b9da0aa98097739423180)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128231
Reviewed-by: Xisco Fauli 

diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index c28e1eab7b00..a0e4eb43b913 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -1485,7 +1485,10 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara, 
sal_uInt32 nStartPosY )
 TextPortion& rTP = 
rParaPortion.GetTextPortions()[pLine->GetEndPortion()];
 sal_Int32 nPosInArray = pLine->GetEnd()-1-pLine->GetStart();
 tools::Long nNewValue = ( nPosInArray ? pLine->GetCharPosArray()[ 
nPosInArray-1 ] : 0 ) + n;
-pLine->GetCharPosArray()[ nPosInArray ] = nNewValue;
+if (o3tl::make_unsigned(nPosInArray) < 
pLine->GetCharPosArray().size())
+{
+pLine->GetCharPosArray()[ nPosInArray ] = nNewValue;
+}
 rTP.GetSize().AdjustWidth(n );
 }
 
@@ -2038,7 +2041,10 @@ void ImpEditEngine::ImpBreakLine( ParaPortion* 
pParaPortion, EditLine* pLine, Te
 DBG_ASSERT( nBreakPos > pLine->GetStart(), "SplitTextPortion at the 
beginning of the line?" );
 sal_Int32 nPosInArray = nBreakPos - 1 - pLine->GetStart();
 rTP.GetSize().setWidth( ( nPosInArray && ( rTP.GetLen() > 1 ) ) ? 
pLine->GetCharPosArray()[ nPosInArray-1 ] : 0 );
-pLine->GetCharPosArray()[ nPosInArray ] = rTP.GetSize().Width();
+if (o3tl::make_unsigned(nPosInArray) < pLine->GetCharPosArray().size())
+{
+pLine->GetCharPosArray()[ nPosInArray ] = rTP.GetSize().Width();
+}
 }
 else if ( bHyphenated )
 {

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - lotuswordpro/source

[Caolán McNamara (via logerrit)]

 lotuswordpro/source/filter/lwpdrawobj.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1f7ae933a62742d7626859a00750f795551843f3
Author: Caolán McNamara 
AuthorDate: Sun Jan 9 16:16:39 2022 +
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:07:05 2022 +0100

ofz#43458 avoid OOM

Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 
(cherry picked from commit e28f4b6bccafb2b9f3c44dfabf36d1b822d85f84)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128235
Reviewed-by: Xisco Fauli 

diff --git a/lotuswordpro/source/filter/lwpdrawobj.cxx 
b/lotuswordpro/source/filter/lwpdrawobj.cxx
index 5245bfd93ddc..d6255b2e63d7 100644
--- a/lotuswordpro/source/filter/lwpdrawobj.cxx
+++ b/lotuswordpro/source/filter/lwpdrawobj.cxx
@@ -1047,6 +1047,8 @@ void LwpDrawTextBox::Read()
 
 // the 71 is the fixed length before text content in textbox record
 sal_Int16 TextLength = m_aObjHeader.nRecLen - 71;
+if (TextLength < 0)
+throw BadRead();
 m_aTextRec.pTextString = new sal_uInt8 [TextLength];
 
 m_pStream->ReadBytes(m_aTextRec.pTextString, TextLength);

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - include/oox oox/qa oox/source sd/source

[Sarper Akdemir (via logerrit)]

 include/oox/export/drawingml.hxx|6 ++-
 oox/qa/unit/data/camera-rotation-revolution-nonwps.pptx |binary
 oox/qa/unit/drawingml.cxx   |   26 ++
 oox/qa/unit/export.cxx  |   27 +++
 oox/source/drawingml/shape.cxx  |9 ++---
 oox/source/export/drawingml.cxx |   28 +++-
 oox/source/export/shapes.cxx|4 +-
 sd/source/filter/eppt/pptx-epptooxml.cxx|2 -
 8 files changed, 72 insertions(+), 30 deletions(-)

New commits:
commit ebc5d02a0d4a716fb4efb4ce17a622eb21cf7c9c
Author: Sarper Akdemir 
AuthorDate: Mon Jan 3 05:45:17 2022 +0300
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:05:15 2022 +0100

tdf#146534 pptx import: make Z rotation work with rotation transform

Expands previous idea from a9c5c0d814a266096483572b84c72875ef8efd77
(tdf#133037 OOXML shape import: camera rotation along Z)
and uses it also for shapes that have a true bUseRotationTransform flag

Also fixes same Z rotation exporting twice from InteropGrabBag to
both spPr and textBody causing text overrotating on roundtrip.

Change-Id: If0f192af029ca86b932a63613f961be1f5003c5b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127880
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128219

diff --git a/include/oox/export/drawingml.hxx b/include/oox/export/drawingml.hxx
index af0a84ff8e16..63a32225172b 100644
--- a/include/oox/export/drawingml.hxx
+++ b/include/oox/export/drawingml.hxx
@@ -320,7 +320,11 @@ public:
 void WriteShapeStyle( const css::uno::Reference< css::beans::XPropertySet 
>& rXPropSet );
 void WriteShapeEffects( const css::uno::Reference< 
css::beans::XPropertySet >& rXPropSet );
 void WriteShapeEffect( std::u16string_view sName, const 
css::uno::Sequence< css::beans::PropertyValue >& aEffectProps );
-void WriteShape3DEffects( const css::uno::Reference< 
css::beans::XPropertySet >& rXPropSet );
+/** Populates scene3d tag
+@param rXPropSet Prop set
+@param bIsText True if the 3D effects are for a text body, false if it 
is for a shape
+ */
+void Write3DEffects(const css::uno::Reference& 
rXPropSet, bool bIsText);
 void WriteArtisticEffect( const css::uno::Reference< 
css::beans::XPropertySet >& rXPropSet );
 OString WriteWdpPicture( const OUString& rFileId, const 
css::uno::Sequence< sal_Int8 >& rPictureData );
 void WriteDiagram(const css::uno::Reference& 
rXShape, int nDiagramId);
diff --git a/oox/qa/unit/data/camera-rotation-revolution-nonwps.pptx 
b/oox/qa/unit/data/camera-rotation-revolution-nonwps.pptx
new file mode 100755
index ..db26dc032caa
Binary files /dev/null and 
b/oox/qa/unit/data/camera-rotation-revolution-nonwps.pptx differ
diff --git a/oox/qa/unit/drawingml.cxx b/oox/qa/unit/drawingml.cxx
index 0d6f367f02c7..ccfa0fa80633 100644
--- a/oox/qa/unit/drawingml.cxx
+++ b/oox/qa/unit/drawingml.cxx
@@ -294,6 +294,32 @@ CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, 
testCameraRotationRevolution)
 CPPUNIT_ASSERT_EQUAL(static_cast(27000), nRotateAngle1);
 }
 
+CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, 
testTdf146534_CameraRotationRevolutionNonWpsShapes)
+{
+OUString aURL
+= m_directories.getURLFromSrc(DATA_DIRECTORY) + 
"camera-rotation-revolution-nonwps.pptx";
+load(aURL);
+
+uno::Reference 
xDrawPagesSupplier(getComponent(), uno::UNO_QUERY);
+uno::Reference 
xDrawPage(xDrawPagesSupplier->getDrawPages()->getByIndex(0),
+ uno::UNO_QUERY);
+uno::Reference xShape0(xDrawPage->getByIndex(0), 
uno::UNO_QUERY);
+uno::Reference xShape1(xDrawPage->getByIndex(1), 
uno::UNO_QUERY);
+uno::Reference xShapeProps0(xShape0, uno::UNO_QUERY);
+uno::Reference xShapeProps1(xShape1, uno::UNO_QUERY);
+sal_Int32 nRotateAngle0;
+sal_Int32 nRotateAngle1;
+xShapeProps0->getPropertyValue("RotateAngle") >>= nRotateAngle0;
+xShapeProps1->getPropertyValue("RotateAngle") >>= nRotateAngle1;
+
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 9000
+// - Actual  : 0
+// so the camera rotation would not have been factored into how the shape 
is displayed
+CPPUNIT_ASSERT_EQUAL(static_cast(9000), nRotateAngle0);
+CPPUNIT_ASSERT_EQUAL(static_cast(30500), nRotateAngle1);
+}
+
 CPPUNIT_TEST_FIXTURE(OoxDrawingmlTest, testTableShadow)
 {
 auto verify = [](const uno::Reference& xComponent) {
diff --git a/oox/qa/unit/export.cxx b/oox/qa/unit/export.cxx
index 280e052d09af..83bd05c6f286 100644
--- a/oox/qa/unit/export.cxx
+++ b/oox/qa/unit/export.cxx
@@ -326,6 +326,33 @@ CPPUNIT_TEST_FIXTURE(Test, testCustomShapeArrowExport)
 

[Libreoffice-bugs] [Bug 144092] FILEOPEN PPTX: Empty table rows appear with lower height

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144092

--- Comment #4 from Justin L  ---
I'm sure that the problem with bug 137949 is the calculation of the cell height
- since the cells have direct paragraph values which are probably being ignored
on the empty cells.

In bug 137949's tablescale.pptx, the cell height for text xxx(10.5pt) and
yyy(11pt) is calculated as size 412/433, while the empty cells are calculated
too large as size 712 (and in LO are indicated as size 18, while in MS
Powerpoint they are size 11). This seems to be specified by endParaRPr sz=1100.

In this bug's table-shadows.pptx, the sizes are all in the default style's
18pt, and so the empty cells are this time properly calculated as size 712, and
thus the cell content ought to override the smaller rowHeight.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146694] New: This is first post

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146694

Bug ID: 146694
   Summary: This is first post
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: futureprofilez...@gmail.com

Description:
https://krugerpower.com.au/;>krugerpower

https://www.vxchnge.com/blog/ways-system-downtime-could-impact-company.;>business
downtime

https://www.ablesales.com.au/diesel-generators-perth-melbourne-brisbane/;>https://www.ablesales.com.au/diesel-generators-perth-melbourne-brisbane/
[Diesel powered
solutions](https://www.ablesales.com.au/diesel-generators-perth-melbourne-brisbane/diesel-generator/)
[norm in Australia](https://microgridknowledge.com/blackouts-in-australia/)

[url=https://7news.com.au/technology/power-outage/queenslanders-have-been-told-to-brace-for-possible-power-outages-after-fire-at-callide-power-station-plant-c-2934165]power
blackouts[/url]

[https://garpen.com.au](https://garpen.com.au)

[url=https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6222844/]by using
biocides/url]
Industrial Cargo is one of the best Courier Services Near Delhi Airport, we
always aim to provide the fastest and most efficient transport Air, Rail and
Road shipping service in India to all our customers.

https://forum.heatinghelp.com/


Actual Results:
no bug

Expected Results:
no bug


Reproducible: Always


User Profile Reset: No



Additional Info:
no bug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - winaccessibility/inc winaccessibility/source

[Michael Weghorn (via logerrit)]

 winaccessibility/inc/AccObject.hxx  |2 
 winaccessibility/inc/AccObjectManagerAgent.hxx  |3 
 winaccessibility/inc/AccObjectWinManager.hxx|3 
 winaccessibility/source/UAccCOM/MAccessible.cxx |   43 
++
 winaccessibility/source/UAccCOM/MAccessible.h   |2 
 winaccessibility/source/UAccCOMIDL/UAccCOM.idl  |1 
 winaccessibility/source/service/AccContainerEventListener.cxx   |2 
 winaccessibility/source/service/AccEventListener.cxx|1 
 winaccessibility/source/service/AccObject.cxx   |   30 
--
 winaccessibility/source/service/AccObjectContainerEventListener.cxx |1 
 winaccessibility/source/service/AccObjectManagerAgent.cxx   |   18 
 winaccessibility/source/service/AccObjectWinManager.cxx |   20 
 12 files changed, 9 insertions(+), 117 deletions(-)

New commits:
commit f1fb66b02d72d4b2e6f3321fa5426c9f7c04c48c
Author: Michael Weghorn 
AuthorDate: Wed Jan 5 13:41:53 2022 +
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:02:31 2022 +0100

tdf#146306 wina11y: Retrieve accessible desc on demand

Adapt 'MAccessible::get_accDescription' to directly
retrieve the accessible description on demand via the
corresponding XAccessible, rather than keeping
track of it in a class member.

This simplifies the handling and makes it
unnecessary to "manually" update the description
on 'accessibility::AccessibleEventId::DESCRIPTION_CHANGED'
events, since the new value will
be queried next time it is needed anyway.

This also fixes the problem that a significant
amount of time was spent generating accessible
descriptions for all newly inserted a11y objects when
entering values into Calc cells with the NVDA
screen reader in use, resulting in several
seconds of delay.

Querying up-to-date values from the underlying
UNO interfaces on demand instead of doing extra
manual bookkeeping in the winaccessibility code
may be possible for more a11y attributes in addition
to the accessible description handled in this commit,
but each one will have to be looked at separately.

Change-Id: I57f4c523ca8b10afad3f9c347c8ff5e9420ad968
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128006
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
(cherry picked from commit fcf4a26275d7503835f9aa23cb94938809840300)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128165
Reviewed-by: Xisco Fauli 

diff --git a/winaccessibility/inc/AccObject.hxx 
b/winaccessibility/inc/AccObject.hxx
index 2a246ce43b29..6da9d6621c5e 100644
--- a/winaccessibility/inc/AccObject.hxx
+++ b/winaccessibility/inc/AccObject.hxx
@@ -114,7 +114,6 @@ public:
 
 void  SetName( css::uno::Any newName);
 void  SetValue( css::uno::Any pAny );
-void  SetDescription( css::uno::Any newDesc );
 void  SetRole( short Role );
 
 short GetRole() const;
@@ -123,7 +122,6 @@ public:
 void  UpdateName();
 void  UpdateValue();
 void  UpdateAction();
-void  UpdateDescription();
 void  UpdateValidWindow();
 void  UpdateLocation();
 
diff --git a/winaccessibility/inc/AccObjectManagerAgent.hxx 
b/winaccessibility/inc/AccObjectManagerAgent.hxx
index 579a785b41bb..a0f3daec579b 100644
--- a/winaccessibility/inc/AccObjectManagerAgent.hxx
+++ b/winaccessibility/inc/AccObjectManagerAgent.hxx
@@ -76,9 +76,6 @@ public:
 void  UpdateAccName( css::accessibility::XAccessible* pXAcc, css::uno::Any 
newName);
 void  UpdateAccName( css::accessibility::XAccessible* pXAcc);
 
-void  UpdateDescription( css::accessibility::XAccessible* pXAcc, 
css::uno::Any newDesc );
-void  UpdateDescription( css::accessibility::XAccessible* pXAcc );
-
 void NotifyDestroy(css::accessibility::XAccessible* pXAcc);
 
 css::accessibility::XAccessible* GetParentXAccessible( 
css::accessibility::XAccessible* pXAcc );
diff --git a/winaccessibility/inc/AccObjectWinManager.hxx 
b/winaccessibility/inc/AccObjectWinManager.hxx
index 4f35668c56ef..911c83ea2a8f 100644
--- a/winaccessibility/inc/AccObjectWinManager.hxx
+++ b/winaccessibility/inc/AccObjectWinManager.hxx
@@ -122,9 +122,6 @@ public:
 void  SetAccName( css::accessibility::XAccessible* pXAcc, css::uno::Any 
newName);
 void  UpdateAccName( css::accessibility::XAccessible* pXAcc );
 
-void  SetDescription( css::accessibility::XAccessible* pXAcc, 
css::uno::Any newDesc );
-void UpdateDescription( css::accessibility::XAccessible* pXAcc );
-
 void  SetRole( css::accessibility::XAccessible* pXAcc, long Role );
 
 void  UpdateAccFocus( css::accessibility::XAccessible* newFocus );
diff --git a/winaccessibility/source/UAccCOM/MAccessible.cxx 
b/winaccessibility/source/UAccCOM/MAccessible.cxx
index 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - winaccessibility/source

[Michael Weghorn (via logerrit)]

 winaccessibility/source/service/AccObject.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit d96eb0b381de5f87534215ef38e1af1b3bdfd0ab
Author: Michael Weghorn 
AuthorDate: Wed Jan 5 12:23:23 2022 +
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:01:48 2022 +0100

wina11y: Use existing method to update description

The accessible description and the accessibile *action*
description are two different things.

'AccObject::UpdateActionDesc' was (IMHO somewhat confusingly)
handling both.
Drop the handling of the accessible description from there
and call the already existing 'AccObject::UpdateDescription'
at the only call site of 'AccObject::UpdateActionDesc' in
addition, which does exactly the same thing.

Change-Id: I220df676f128a5db69ab4cebe7772d92f6b9b0ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128005
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128252

diff --git a/winaccessibility/source/service/AccObject.cxx 
b/winaccessibility/source/service/AccObject.cxx
index b69507486e25..e9ca101207fe 100644
--- a/winaccessibility/source/service/AccObject.cxx
+++ b/winaccessibility/source/service/AccObject.cxx
@@ -747,12 +747,8 @@ AccObject* AccObject::NextChild()
 void AccObject::UpdateActionDesc()
 {
 if (!m_pIMAcc)
-{
 return;
-}
 
-OUString pXString = m_xAccContextRef->getAccessibleDescription();
-m_pIMAcc->Put_XAccDescription(o3tl::toW(pXString.getStr()));
 long Role = m_accRole;
 
 if(  Role == PUSH_BUTTON || Role == RADIO_BUTTON || Role == MENU_ITEM ||
@@ -1027,6 +1023,8 @@ bool AccObject:: UpdateAccessibleInfoFromUnoToMSAA ( )
 
 UpdateValue();
 
+UpdateDescription();
+
 UpdateActionDesc();
 
 UpdateRole();

[Libreoffice-bugs] [Bug 146683] FILEOPEN: table in DOC text box is not imported properly - groupshape support (as in DOCX)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146683

Timur  changed:

   What|Removed |Added

Summary|FILEOPEN: table in DOC text |FILEOPEN: table in DOC text
   |box is not imported |box is not imported
   |properly - groupshape   |properly - groupshape
   |support |support (as in DOCX)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - winaccessibility/source

[Michael Weghorn (via logerrit)]

 winaccessibility/source/service/AccObject.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 6b32bda33bee7b56d43f34adb23bcd60d8a1b1b9
Author: Michael Weghorn 
AuthorDate: Wed Jan 5 12:05:50 2022 +
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 10:00:07 2022 +0100

wina11y: Use separate local variable for action description

Use a separate local variable for the accessible
*action* description here, which is independent of
the accessible description handled above.

While at it, use '!OUString::isEmpty' instead of
'OUString::getLength() > 0'.

Change-Id: I146d8603ed3decde68f8ce716ac13c04b0263040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128004
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128251

diff --git a/winaccessibility/source/service/AccObject.cxx 
b/winaccessibility/source/service/AccObject.cxx
index 9b6609666ee6..b69507486e25 100644
--- a/winaccessibility/source/service/AccObject.cxx
+++ b/winaccessibility/source/service/AccObject.cxx
@@ -771,10 +771,10 @@ void AccObject::UpdateActionDesc()
 if (!(Role == SPIN_BOX || Role == COMBO_BOX || Role == 
DATE_EDITOR ||
   Role == EDIT_BAR || Role == PASSWORD_TEXT || Role == 
TEXT))
 {
-pXString = 
m_xAccActionRef->getAccessibleActionDescription( 0 );
-//Solution: if string length is more than zero, action is 
set.
-if( pXString.getLength() > 0)
-m_pIMAcc->Put_ActionDescription( 
o3tl::toW(pXString.getStr()) );
+const OUString sActionDesc = 
m_xAccActionRef->getAccessibleActionDescription(0);
+// if string is non-empty, action is set.
+if (!sActionDesc.isEmpty())
+
m_pIMAcc->Put_ActionDescription(o3tl::toW(sActionDesc.getStr()));
 }
 }
 }

[Libreoffice-bugs] [Bug 85976] Feature Request - Add "Remove Duplicates" button to LibreOffice / filtering showing duplicates is too complicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85976

--- Comment #33 from Mike Kaganski  ---
Note that any feature request having a working extension with compatible
license is already an easy hack. Just use its source code as the template that
provides the required logic - it uses UNO commands, which may be easily
converted to a C++ code, and assign a new UNO command to that new function.

(Given that Remove Duplicates Fast is based on Remove Duplicates
(https://github.com/ACTom/lo-extension-removeduplicates) which is GPLv3, which
doesn't allow to use its code in LO directly because we need an MPL-compatible
license, interested parties may ask the author for changed license in a github
issue.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - svx/source

[Mike Kaganski (via logerrit)]

 svx/source/svdraw/svdtrans.cxx |   14 --
 1 file changed, 4 insertions(+), 10 deletions(-)

New commits:
commit b1e3f5d96b1093f42a4558a04ee607b2cde6f4bd
Author: Mike Kaganski 
AuthorDate: Sun Jan 9 15:53:22 2022 +0300
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 09:58:32 2022 +0100

Slightly optimize code handling angles

Change-Id: I8bc10513f6cd704abc7a2bbb17d8d0d8d2628401
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128187
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
(cherry picked from commit 1bdb4ddfc516d62f482f83fc6191e9585aa4786b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128230
Reviewed-by: Xisco Fauli 
(cherry picked from commit 6273c0e0de093735396bf1b5a2151da943753eac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128239

diff --git a/svx/source/svdraw/svdtrans.cxx b/svx/source/svdraw/svdtrans.cxx
index 39818941667d..0a00b9b44121 100644
--- a/svx/source/svdraw/svdtrans.cxx
+++ b/svx/source/svdraw/svdtrans.cxx
@@ -408,19 +408,13 @@ Degree100 NormAngle18000(Degree100 a)
 
 Degree100 NormAngle36000(Degree100 a)
 {
-while (a < 0_deg100) a += 36000_deg100;
-while (a >= 36000_deg100) a -= 36000_deg100;
+a %= 36000_deg100;
+if (a < 0_deg100)
+a += 36000_deg100;
 return a;
 }
 
-sal_uInt16 GetAngleSector(Degree100 nAngle)
-{
-nAngle = NormAngle36000(nAngle);
-if (nAngle< 9000_deg100) return 0;
-if (nAngle<18000_deg100) return 1;
-if (nAngle<27000_deg100) return 2;
-return 3;
-}
+sal_uInt16 GetAngleSector(Degree100 nAngle) { return (NormAngle36000(nAngle) / 
9000_deg100).get(); }
 
 tools::Long GetLen(const Point& rPnt)
 {

[Libreoffice-bugs] [Bug 146681] Shapes in 2007 DOCX worse since LO 7.3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146681

--- Comment #3 from Timur  ---
Created attachment 177452
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177452=edit
DOCX compared in MSO and LO

DOCX compared in MSO 2016, LO 7.2 as 2007 DOCX, LO 7.4+ as 2007 DOCX, LO 7.4+
as MSO saved DOCX

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/qa vcl/source

[Miklos Vajna (via logerrit)]

 vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg |binary
 vcl/qa/cppunit/pdfexport/pdfexport.cxx|   18 +
 vcl/source/gdi/pdfwriter_impl.cxx |   35 ++
 3 files changed, 53 insertions(+)

New commits:
commit 34d3315af070ce0278363c14a1d85cf4416985d1
Author: Miklos Vajna 
AuthorDate: Fri Jan 7 12:23:34 2022 +0100
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 09:57:47 2022 +0100

PDF export of PDF images: preserve hyperlinks

The input file has a single page, with a full-page PDF image, which
contains a hyperlink. Similar to pdfcrop, we used to wrap this into a
form XObject, so page-level annotations like hyperlinks were lost.

Explicitly merge page-level annotations from the source page to the page
that contains the PDF image to preserve those annotations.

Change-Id: I96e8bc9d33440b91f3514486d6a8bd75047546b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128108
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 1984a5c140cc3c7c291047dacf3bddd7061d2047)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128156
Reviewed-by: Xisco Fauli 

diff --git a/vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg 
b/vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg
new file mode 100644
index ..aa0f89300b2c
Binary files /dev/null and 
b/vcl/qa/cppunit/pdfexport/data/pdf-image-hyperlink.odg differ
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx 
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index f4b6031ea4c3..ee2a7938d0d4 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -2858,6 +2858,24 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf145873)
 CPPUNIT_ASSERT_DOUBLES_EQUAL(3.49, pObject->getBounds().getHeight(), 0.1);
 }
 
+CPPUNIT_TEST_FIXTURE(PdfExportTest, testPdfImageHyperlink)
+{
+// Given a Draw file, containing a PDF image, which has a hyperlink in it:
+aMediaDescriptor["FilterName"] <<= OUString("draw_pdf_Export");
+
+// When saving to PDF:
+saveAsPDF(u"pdf-image-hyperlink.odg");
+
+// Then make sure that link is preserved:
+std::unique_ptr pPdfDocument = parseExport();
+CPPUNIT_ASSERT(pPdfDocument);
+std::unique_ptr pPdfPage = 
pPdfDocument->openPage(/*nIndex=*/0);
+CPPUNIT_ASSERT(pPdfPage);
+// Without the accompanying fix in place, this test would have failed, the 
hyperlink of the PDF
+// image was lost.
+CPPUNIT_ASSERT(pPdfPage->hasLinks());
+}
+
 } // end anonymous namespace
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 3db1ca90f235..e9a61fab394c 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -8434,6 +8434,41 @@ void PDFWriterImpl::writeReferenceXObject(const 
ReferenceXObjectEmit& rEmit)
 return;
 }
 
+// Merge page annotations (links, etc) from pPage to our page.
+std::vector aAnnots;
+if (auto pArray = 
dynamic_cast(pPage->Lookup("Annots")))
+{
+for (const auto pElement : pArray->GetElements())
+{
+auto pReference = 
dynamic_cast(pElement);
+if (!pReference)
+{
+continue;
+}
+
+filter::PDFObjectElement* pObject = pReference->LookupObject();
+if (!pObject)
+{
+continue;
+}
+
+// Annotation refers to an object, remember it.
+aAnnots.push_back(pObject);
+}
+}
+if (!aAnnots.empty())
+{
+PDFObjectCopier aCopier(*this);
+SvMemoryStream& rDocBuffer = pPage->GetDocument().GetEditBuffer();
+std::map aMap;
+for (const auto& pAnnot : aAnnots)
+{
+// Copy over the annotation and refer to its new id.
+sal_Int32 nNewId = aCopier.copyExternalResource(rDocBuffer, 
*pAnnot, aMap);
+m_aPages.back().m_aAnnotations.push_back(nNewId);
+}
+}
+
 nWrappedFormObject = createObject();
 // Write the form XObject wrapped below. This is a separate object from
 // the wrapper, this way there is no need to alter the stream contents.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sd/qa svx/source

[Gülşah Köse (via logerrit)]

 sd/qa/unit/data/pptx/tdf135843.pptx|binary
 sd/qa/unit/import-tests.cxx|   27 ++-
 svx/source/table/viewcontactoftableobj.cxx |4 ++--
 3 files changed, 28 insertions(+), 3 deletions(-)

New commits:
commit 35b179b88330e1e94980192c598f23661e2757f9
Author: Gülşah Köse 
AuthorDate: Wed Jan 5 13:03:14 2022 +0300
Commit: Xisco Fauli 
CommitDate: Tue Jan 11 09:56:07 2022 +0100

tdf#135843 Fix the missing border handling

Adding +1 at that stage causes indexoutofbounds.
But never throws that exception and tries to pull
empty cell style instead. As a result we can not
see the border. Actually no idea why +1 used here.

Change-Id: Id54ba6445d022540173af3bbf5d679b7edefc55b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127990
Tested-by: Jenkins
Reviewed-by: Gülşah Köse 
(cherry picked from commit fa5ab8aa5d88e7128015127af75980a65f945cbb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128163
Reviewed-by: Xisco Fauli 

diff --git a/sd/qa/unit/data/pptx/tdf135843.pptx 
b/sd/qa/unit/data/pptx/tdf135843.pptx
new file mode 100644
index ..0a5dcb334b0c
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf135843.pptx differ
diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 303ab76bed7b..5035fa6cedb8 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -101,6 +101,7 @@
 #include 
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star;
 
@@ -117,7 +118,7 @@ static std::ostream& operator<<(std::ostream& rStrm, const 
uno::Reference& xR
 
 
 /// Impress import filters tests.
-class SdImportTest : public SdModelTestBase
+class SdImportTest : public SdModelTestBaseXML
 {
 public:
 virtual void setUp() override;
@@ -187,6 +188,7 @@ public:
 void testTdf93124();
 void testTdf99729();
 void testTdf89927();
+void testTdf135843();
 
 CPPUNIT_TEST_SUITE(SdImportTest);
 
@@ -255,6 +257,7 @@ public:
 CPPUNIT_TEST(testTdf93124);
 CPPUNIT_TEST(testTdf99729);
 CPPUNIT_TEST(testTdf89927);
+CPPUNIT_TEST(testTdf135843);
 
 CPPUNIT_TEST_SUITE_END();
 };
@@ -1958,6 +1961,28 @@ void SdImportTest::testTdf89927()
 xDocShRef->DoClose();
 }
 
+void SdImportTest::testTdf135843()
+{
+sd::DrawDocShellRef xDocShRef = loadURL( 
m_directories.getURLFromSrc(u"/sd/qa/unit/data/pptx/tdf135843.pptx"), PPTX );
+
+std::shared_ptr xMetaFile = xDocShRef->GetPreviewMetaFile();
+MetafileXmlDump dumper;
+
+xmlDocUniquePtr pXmlDoc = XmlTestTools::dumpAndParse(dumper, *xMetaFile);
+CPPUNIT_ASSERT(pXmlDoc);
+
+// Without the fix, the test fails with:
+// - Expected: 21165
+// - Actual  : 4218
+assertXPath(pXmlDoc, 
"/metafile/push[1]/push[1]/push[5]/polyline[1]/point[1]", "x", "21165");
+assertXPath(pXmlDoc, 
"/metafile/push[1]/push[1]/push[5]/polyline[1]/point[1]", "y", "3866");
+
+assertXPath(pXmlDoc, 
"/metafile/push[1]/push[1]/push[5]/polyline[1]/point[2]", "x", "21165");
+assertXPath(pXmlDoc, 
"/metafile/push[1]/push[1]/push[5]/polyline[1]/point[2]", "y", "5956");
+
+xDocShRef->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/svx/source/table/viewcontactoftableobj.cxx 
b/svx/source/table/viewcontactoftableobj.cxx
index a79882e03a52..cb2398585c63 100644
--- a/svx/source/table/viewcontactoftableobj.cxx
+++ b/svx/source/table/viewcontactoftableobj.cxx
@@ -259,9 +259,9 @@ namespace sdr::contact
 {
 // copy styles for current cell to 
CellBorderArray for primitive creation
 aArray.SetCellStyleLeft(aCellPos.mnCol, 
aCellPos.mnRow, impGetLineStyle(rTableLayouter, aCellPos.mnCol, aCellPos.mnRow, 
false, nColCount, nRowCount, bIsRTL));
-aArray.SetCellStyleRight(aCellPos.mnCol, 
aCellPos.mnRow, impGetLineStyle(rTableLayouter, aCellPos.mnCol + 1, 
aCellPos.mnRow, false, nColCount, nRowCount, bIsRTL));
+aArray.SetCellStyleRight(aCellPos.mnCol, 
aCellPos.mnRow, impGetLineStyle(rTableLayouter, aCellPos.mnCol, aCellPos.mnRow, 
false, nColCount, nRowCount, bIsRTL));
 aArray.SetCellStyleTop(aCellPos.mnCol, 
aCellPos.mnRow, impGetLineStyle(rTableLayouter, aCellPos.mnCol, aCellPos.mnRow, 
true, nColCount, nRowCount, bIsRTL));
-aArray.SetCellStyleBottom(aCellPos.mnCol, 
aCellPos.mnRow, impGetLineStyle(rTableLayouter, aCellPos.mnCol, aCellPos.mnRow 
+ 1, true, nColCount, nRowCount, bIsRTL));
+aArray.SetCellStyleBottom(aCellPos.mnCol, 
aCellPos.mnRow, impGetLineStyle(rTableLayouter, aCellPos.mnCol, aCellPos.mnRow, 
true, nColCount, nRowCount, bIsRTL));
 
 // ignore merged cells (all except the 
top-left of a merged cell)
 

[Libreoffice-bugs] [Bug 85976] Feature Request - Add "Remove Duplicates" button to LibreOffice / filtering showing duplicates is too complicated

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85976

Heiko Tietze  changed:

   What|Removed |Added

 CC||dongsh...@qq.com

--- Comment #32 from Heiko Tietze  ---
*** Bug 144744 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144744] Several practical function extensions hope to be integrated into the installation package by libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144744

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
First of all, to have actionable requests (resolve after submitting a patch)
it's advised to file one request per ticket.

Second, I disagree with bundling 3rd party extensions because responsibility of
maintenance goes towards LibreOffice and too many extensions bloats the
package. But I guess you can easily build your own package and pick all needed
content individually.

(In reply to dongshili from comment #0)
> 【remove-duplicates-fast】
> https://extensions.libreoffice.org/en/extensions/show/remove-duplicates-fast

Would be a duplicate of bug 85976

> 【clear-cell】
> https://extensions.libreoffice.org/en/extensions/show/clear-cell

Why not just use trim()?
https://help.libreoffice.org/latest/en-GB/text/sbasic/shared/03120311.html

> 【Copy only visible cells】
> https://extensions.libreoffice.org/en/extensions/show/copy-only-visible-cells

Seems fixed with bug 45958 for version 7.2


Resolving the ticket as duplicate of 85976 to draw more attention on this part.

*** This bug has been marked as a duplicate of bug 85976 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 144744] Several practical function extensions hope to be integrated into the installation package by libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144744

Heiko Tietze  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Heiko Tietze  ---
First of all, to have actionable requests (resolve after submitting a patch)
it's advised to file one request per ticket.

Second, I disagree with bundling 3rd party extensions because responsibility of
maintenance goes towards LibreOffice and too many extensions bloats the
package. But I guess you can easily build your own package and pick all needed
content individually.

(In reply to dongshili from comment #0)
> 【remove-duplicates-fast】
> https://extensions.libreoffice.org/en/extensions/show/remove-duplicates-fast

Would be a duplicate of bug 85976

> 【clear-cell】
> https://extensions.libreoffice.org/en/extensions/show/clear-cell

Why not just use trim()?
https://help.libreoffice.org/latest/en-GB/text/sbasic/shared/03120311.html

> 【Copy only visible cells】
> https://extensions.libreoffice.org/en/extensions/show/copy-only-visible-cells

Seems fixed with bug 45958 for version 7.2


Resolving the ticket as duplicate of 85976 to draw more attention on this part.

*** This bug has been marked as a duplicate of bug 85976 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 146626] Calc crashes every time on font size operation, in a specific document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146626

--- Comment #7 from Emil Prpic  ---
(In reply to Timur from comment #6)
> User Profile Reset: Yes
> 
> Your you really delete / rename your user profile?

You mean did I really delete my user profile? Yes, twice. I also completely
removed LibreOffice and installed it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/lhm/libreoffice-6-4+backports' - sc/qa sc/source

[Vasily Melenchuk (via logerrit)]

 sc/qa/unit/data/ods/tdf145059.ods |binary
 sc/qa/unit/subsequent_export-test.cxx |   41 ++
 sc/source/filter/excel/excrecds.cxx   |4 +++
 sc/source/filter/excel/xestyle.cxx|   16 +
 sc/source/filter/inc/xestyle.hxx  |5 ++--
 5 files changed, 60 insertions(+), 6 deletions(-)

New commits:
commit d4c9f299145635cb1cba3365dfe5533ba3636572
Author: Vasily Melenchuk 
AuthorDate: Thu Dec 30 15:32:37 2021 +0300
Commit: Thorsten Behrens 
CommitDate: Tue Jan 11 09:39:05 2022 +0100

tdf#145059: sc: always write dxf node for color filter for XLSX

If there is no dxf reference to color filter (for example if selected
color is not in range of available colors for current range) Excel
is not able to show color filter correctly: it is not marked as used
filter, no ability to reset, etc.

Change-Id: I65378ddd6f8f8233cda147ff9dcd28f455a58225
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127745
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128249
Tested-by: Thorsten Behrens 

diff --git a/sc/qa/unit/data/ods/tdf145059.ods 
b/sc/qa/unit/data/ods/tdf145059.ods
new file mode 100644
index ..a76da3b5cb4e
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf145059.ods differ
diff --git a/sc/qa/unit/subsequent_export-test.cxx 
b/sc/qa/unit/subsequent_export-test.cxx
index f54cb966bacc..74fce93a9296 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -244,6 +244,7 @@ public:
 void testTdf128976();
 void testTdf120502();
 void testTdf142578();
+void testTdf145059();
 
 CPPUNIT_TEST_SUITE(ScExportTest);
 CPPUNIT_TEST(test);
@@ -384,6 +385,7 @@ public:
 CPPUNIT_TEST(testTdf128976);
 CPPUNIT_TEST(testTdf120502);
 CPPUNIT_TEST(testTdf142578);
+CPPUNIT_TEST(testTdf145059);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -4875,6 +4877,45 @@ void ScExportTest::testTdf142578()
 xDocSh->DoClose();
 }
 
+void ScExportTest::testTdf145059()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf142578.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh);
+
+std::shared_ptr pXPathFile
+= ScBootstrapFixture::exportTo(&(*xDocSh), FORMAT_XLSX);
+xmlDocPtr pSheet
+= XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/worksheets/sheet1.xml");
+CPPUNIT_ASSERT(pSheet);
+
+// Get DxfId for color filter
+sal_Int32 nDxfIdColorFilter
+= getXPath(pSheet, 
"/x:worksheet/x:autoFilter/x:filterColumn/x:colorFilter", "dxfId")
+  .toInt32()
+  + 1;
+
+// Get DxfId for conditional formatting
+sal_Int32 nDxfIdCondFormat
+= getXPath(pSheet, "/x:worksheet/x:conditionalFormatting/x:cfRule", 
"dxfId").toInt32() + 1;
+
+// Ensure they are using different dxfs
+CPPUNIT_ASSERT_MESSAGE("dxfID's should be different!", nDxfIdColorFilter 
!= nDxfIdCondFormat);
+
+// Check colors used by these dxfs
+xmlDocPtr pStyles = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/styles.xml");
+CPPUNIT_ASSERT(pStyles);
+
+OString sDxfColorFilterXPath("/x:styleSheet/x:dxfs/x:dxf[" + 
OString::number(nDxfIdColorFilter)
+ + "]/x:fill/x:patternFill/x:fgColor");
+assertXPath(pStyles, sDxfColorFilterXPath, "rgb", "FF81D41A");
+
+OString sDxfCondFormatXPath("/x:styleSheet/x:dxfs/x:dxf[" + 
OString::number(nDxfIdCondFormat)
++ "]/x:fill/x:patternFill/x:bgColor");
+assertXPath(pStyles, sDxfCondFormatXPath, "rgb", "");
+
+xDocSh->DoClose();
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(ScExportTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/filter/excel/excrecds.cxx 
b/sc/source/filter/excel/excrecds.cxx
index 35a19585ba97..90d60dbce92d 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -788,6 +788,10 @@ void XclExpAutofilter::AddColorEntry(const ScQueryEntry& 
rEntry)
 {
 maColorValues.push_back(
 std::make_pair(rItem.maColor, rItem.meType == 
ScQueryEntry::ByBackgroundColor));
+// Ensure that selected color(s) will be added to dxf: selection can 
be not in list
+// of already added to dfx colors taken from filter range
+if (GetDxfs().GetDxfByColor(rItem.maColor) == -1)
+GetDxfs().AddColor(rItem.maColor);
 }
 }
 
diff --git a/sc/source/filter/excel/xestyle.cxx 
b/sc/source/filter/excel/xestyle.cxx
index 77a73ee19f57..bedf7d7f77d1 100644
--- a/sc/source/filter/excel/xestyle.cxx
+++ b/sc/source/filter/excel/xestyle.cxx
@@ -3159,22 +3159,30 @@ XclExpDxfs::XclExpDxfs( const XclExpRoot& rRoot )
 }
 }
 
-sal_Int32 XclExpDxfs::GetDxfId( const OUString& rStyleName )
+sal_Int32 XclExpDxfs::GetDxfId( const OUString& rStyleName ) const
 {
-std::map::iterator itr = 
maStyleNameToDxfId.find(rStyleName);
+std::map::const_iterator itr = 

[Libreoffice-commits] core.git: cui/inc cui/source include/svl include/vcl vcl/backendtest vcl/inc

[Gabor Kelemen (via logerrit)]

 cui/inc/strings.hrc   |3 +
 cui/source/dialogs/GraphicTestsDialog.cxx |   28 ---
 include/svl/svl.hrc   |6 +++
 include/vcl/test/GraphicsRenderTests.hxx  |4 +-
 vcl/backendtest/GraphicsRenderTests.cxx   |   56 ++
 vcl/inc/strings.hrc   |5 ++
 6 files changed, 81 insertions(+), 21 deletions(-)

New commits:
commit cf3840931454553ff25e488dc1ede2af65e0016b
Author: Gabor Kelemen 
AuthorDate: Thu Jan 6 12:38:13 2022 +0100
Commit: Thorsten Behrens 
CommitDate: Tue Jan 11 09:22:52 2022 +0100

tdf#145919 Localize strings in Graphics Test dialog

but not in the saved log file

Change-Id: I65c580e7b8762b654f1812c96bc53841b882a960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128087
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index fd91ae802b42..92e9cb7ed7ae 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -396,4 +396,7 @@
 
 #define RID_CUISTR_OLE_INSERT   
NC_("RID_SVXSTR_OLE_INSERT", "Inserting OLE object...")
 
+#define RID_CUISTR_CLICK_RESULT 
NC_("RID_CUISTR_CLICK_RESULT", "(Click on any test to view its resultant bitmap 
image)")
+#define RID_CUISTR_ZIPFAIL  NC_("RID_CUISTR_ZIPFAIL", 
"Creation of Zip file failed!")
+#define RID_CUISTR_SAVEDNC_("RID_CUISTR_SAVED", 
"The results have been successfully saved in the file 
'GraphicTestResults.zip'!")
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/dialogs/GraphicTestsDialog.cxx 
b/cui/source/dialogs/GraphicTestsDialog.cxx
index 555ef3bd888c..c6232c2e8868 100644
--- a/cui/source/dialogs/GraphicTestsDialog.cxx
+++ b/cui/source/dialogs/GraphicTestsDialog.cxx
@@ -14,6 +14,11 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+
+#include 
+#include 
 
 GraphicTestEntry::GraphicTestEntry(weld::Container* pParent, weld::Dialog* 
pDialog,
OUString aTestName, OUString aTestStatus, 
Bitmap aTestBitmap)
@@ -28,17 +33,18 @@ GraphicTestEntry::GraphicTestEntry(weld::Container* 
pParent, weld::Dialog* pDial
 m_xTestButton->set_label(aTestStatus);
 m_xTestButton->set_tooltip_text(aTestName);
 m_xTestButton->set_background(
-aTestStatus == "PASSED"
+aTestStatus == SvlResId(GRTSTR_PASSED)
 ? COL_LIGHTGREEN
-: aTestStatus == "QUIRKY" ? COL_YELLOW
-  : aTestStatus == "FAILED" ? COL_LIGHTRED 
: COL_LIGHTGRAY);
+: aTestStatus == SvlResId(GRTSTR_QUIRKY)
+  ? COL_YELLOW
+  : aTestStatus == SvlResId(GRTSTR_FAILED) ? COL_LIGHTRED : 
COL_LIGHTGRAY);
 m_xTestButton->connect_clicked(LINK(this, GraphicTestEntry, 
HandleResultViewRequest));
 m_xContainer->show();
 }
 
 IMPL_LINK(GraphicTestEntry, HandleResultViewRequest, weld::Button&, rButton, 
void)
 {
-if (rButton.get_label() == "SKIPPED")
+if (rButton.get_label() == SvlResId(GRTSTR_SKIPPED))
 {
 return;
 }
@@ -64,14 +70,14 @@ short GraphicsTestsDialog::run()
 {
 GraphicsRenderTests aTestObject;
 aTestObject.run(true);
-OUString aResultLog = aTestObject.getResultString()
-  + "\n(Click on any test to view its resultant bitmap 
image)";
+OUString aResultLog
+= aTestObject.getResultString(true) + "\n" + 
CuiResId(RID_CUISTR_CLICK_RESULT);
 m_xResultLog->set_text(aResultLog);
 sal_Int32 nTestNumber = 0;
-for (const VclTestResult& test : aTestObject.getTestResults())
+for (VclTestResult& test : aTestObject.getTestResults())
 {
 auto xGpTest = 
std::make_unique(m_xContainerBox.get(), m_xDialog.get(),
-  test.getTestName(), 
test.getStatus(),
+  test.getTestName(), 
test.getStatus(true),
   test.getBitmap());
 m_xContainerBox->reorder_child(xGpTest->get_widget(), nTestNumber++);
 m_xGraphicTestEntries.push_back(std::move(xGpTest));
@@ -92,13 +98,11 @@ IMPL_LINK_NOARG(GraphicsTestsDialog, HandleDownloadRequest, 
weld::Button&, void)
 {
 std::unique_ptr xBox(
 Application::CreateMessageDialog(m_xDialog.get(), 
VclMessageType::Warning,
- VclButtonsType::Ok, "Creation of 
Zip file failed!"));
+ VclButtonsType::Ok, 
CuiResId(RID_CUISTR_ZIPFAIL)));
 xBox->run();
 return;
 }
-FileExportedDialog aDialog(
-m_xDialog.get(),
-"The results have been successfully saved in the file 
'GraphicTestResults.zip' !");
+FileExportedDialog aDialog(m_xDialog.get(), CuiResId(RID_CUISTR_SAVED));
 

[Libreoffice-bugs] [Bug 136154] Conditional formatting for duplicate value lost after saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136154

Buovjaga  changed:

   What|Removed |Added

Summary|valor de célula duplicado   |Conditional formatting for
   |no libre office calc|duplicate value lost after
   ||saving
 CC||erick.men...@elude.in,
   ||jorgecarden...@hotmail.com,
   ||paulo...@hotmail.com

--- Comment #8 from Buovjaga  ---
For the record, I tried the steps from comment 1 from scratch and the condition
works fine and is not lost after saving and reloading. If someone is still
experiencing this, please give more details.

Arch Linux 64-bit
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 71be70b16b37fb3c1b6331ab3581300556ecc7aa
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 7 January 2022

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/qa sc/source

[Vasily Melenchuk (via logerrit)]

 sc/qa/unit/data/ods/tdf145059.ods  |binary
 sc/qa/unit/subsequent_export_test2.cxx |   31 +++
 sc/source/filter/excel/excrecds.cxx|4 
 sc/source/filter/excel/xestyle.cxx |   16 
 sc/source/filter/inc/xestyle.hxx   |5 +++--
 5 files changed, 50 insertions(+), 6 deletions(-)

New commits:
commit d73cf0abc3d1bfd7e3a1d3d1b41c63bbb17d61bb
Author: Vasily Melenchuk 
AuthorDate: Thu Dec 30 15:32:37 2021 +0300
Commit: Thorsten Behrens 
CommitDate: Tue Jan 11 09:11:54 2022 +0100

tdf#145059: sc: always write dxf node for color filter for XLSX

If there is no dxf reference to color filter (for example if selected
color is not in range of available colors for current range) Excel
is not able to show color filter correctly: it is not marked as used
filter, no ability to reset, etc.

Change-Id: I65378ddd6f8f8233cda147ff9dcd28f455a58225
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127745
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit f0ad6ec2a23a36ade407db8cda36655ba2f144c1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128159

diff --git a/sc/qa/unit/data/ods/tdf145059.ods 
b/sc/qa/unit/data/ods/tdf145059.ods
new file mode 100644
index ..a76da3b5cb4e
Binary files /dev/null and b/sc/qa/unit/data/ods/tdf145059.ods differ
diff --git a/sc/qa/unit/subsequent_export_test2.cxx 
b/sc/qa/unit/subsequent_export_test2.cxx
index 20be9da85bfb..f035efba1aac 100644
--- a/sc/qa/unit/subsequent_export_test2.cxx
+++ b/sc/qa/unit/subsequent_export_test2.cxx
@@ -214,6 +214,7 @@ public:
 void testTdf142264ManyChartsToXLSX();
 void testTdf143929MultiColumnToODS();
 void testTdf142578();
+void testTdf145059();
 void testTdf130104_XLSXIndent();
 
 CPPUNIT_TEST_SUITE(ScExportTest2);
@@ -328,6 +329,7 @@ public:
 CPPUNIT_TEST(testTdf142264ManyChartsToXLSX);
 CPPUNIT_TEST(testTdf143929MultiColumnToODS);
 CPPUNIT_TEST(testTdf142578);
+CPPUNIT_TEST(testTdf145059);
 CPPUNIT_TEST(testTdf130104_XLSXIndent);
 
 CPPUNIT_TEST_SUITE_END();
@@ -2993,6 +2995,35 @@ void ScExportTest2::testTdf142578()
 xDocSh->DoClose();
 }
 
+void ScExportTest2::testTdf145059()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf145059.", FORMAT_ODS);
+CPPUNIT_ASSERT(xDocSh);
+
+// Export to xlsx.
+std::shared_ptr pXPathFile
+= ScBootstrapFixture::exportTo(&(*xDocSh), FORMAT_XLSX);
+xmlDocUniquePtr pSheet
+= XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/worksheets/sheet1.xml");
+CPPUNIT_ASSERT(pSheet);
+xmlDocUniquePtr pStyle = XPathHelper::parseExport(pXPathFile, m_xSFactory, 
"xl/styles.xml");
+CPPUNIT_ASSERT(pStyle);
+
+sal_Int32 nColorFilterDxdId
+= getXPath(pSheet, 
"/x:worksheet/x:autoFilter/x:filterColumn/x:colorFilter", "dxfId")
+  .toInt32();
+
+// Ensure that dxf id is not -1
+CPPUNIT_ASSERT(nColorFilterDxdId >= 0);
+
+// Find color by this dxfid
+OString sDxfIdPath = "/x:styleSheet/x:dxfs/x:dxf[" + 
OString::number(nColorFilterDxdId + 1)
+ + "]/x:fill/x:patternFill/x:fgColor";
+assertXPath(pStyle, sDxfIdPath, "rgb", "FF4472C4");
+
+xDocSh->DoClose();
+}
+
 void ScExportTest2::testTdf130104_XLSXIndent()
 {
 ScDocShellRef xDocSh = loadDoc(u"tdf130104_indent.", FORMAT_XLSX);
diff --git a/sc/source/filter/excel/excrecds.cxx 
b/sc/source/filter/excel/excrecds.cxx
index 65edd87ee5bc..570167b8014b 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -796,6 +796,10 @@ void XclExpAutofilter::AddColorEntry(const ScQueryEntry& 
rEntry)
 {
 maColorValues.push_back(
 std::make_pair(rItem.maColor, rItem.meType == 
ScQueryEntry::ByBackgroundColor));
+// Ensure that selected color(s) will be added to dxf: selection can 
be not in list
+// of already added to dfx colors taken from filter range
+if (GetDxfs().GetDxfByColor(rItem.maColor) == -1)
+GetDxfs().AddColor(rItem.maColor);
 }
 }
 
diff --git a/sc/source/filter/excel/xestyle.cxx 
b/sc/source/filter/excel/xestyle.cxx
index 3898c5cad9b6..291b51c6c83e 100644
--- a/sc/source/filter/excel/xestyle.cxx
+++ b/sc/source/filter/excel/xestyle.cxx
@@ -3176,22 +3176,30 @@ XclExpDxfs::XclExpDxfs( const XclExpRoot& rRoot )
 }
 }
 
-sal_Int32 XclExpDxfs::GetDxfId( const OUString& rStyleName )
+sal_Int32 XclExpDxfs::GetDxfId( const OUString& rStyleName ) const
 {
-std::map::iterator itr = 
maStyleNameToDxfId.find(rStyleName);
+std::map::const_iterator itr = 
maStyleNameToDxfId.find(rStyleName);
 if(itr!= maStyleNameToDxfId.end())
 return itr->second;
 return -1;
 }
 
-sal_Int32 XclExpDxfs::GetDxfByColor(Color aColor)
+sal_Int32 XclExpDxfs::GetDxfByColor(Color aColor) const
 {
-std::map::iterator itr = maColorToDxfId.find(aColor);
+

[Libreoffice-bugs] [Bug 146588] The numbered list font changes when setting font for text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146588

Timur  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #3 from Timur  ---
Is this a duplicate of Bug 144920? If so, please mark, if you think not,
explain.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123318] Problems with new help's "Search in chosen module" function

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123318

--- Comment #8 from Buovjaga  ---
(In reply to Rafael Lima from comment #7)
> (In reply to Buovjaga from comment #6)
> > Sure, Rafael, and it is not difficult. Now that I think about it again, I
> > guess we would have to sacrifice the avoidance of repetition that
> > setupModules JS function provides and include the module links in every
> > generated HTML page.
> 
> How about add the following entry to setupModules:
> 
>  class="all-icon">All
> 
> This would land in the Shared home page without any DbPAR, causing all
> modules to be searched.

Yes, that is what I said a month ago in comment 4, but localisation is the
problem. That is why in comment 6 I proposed to get rid of the JavaScript for
creating these links on the fly.

-- 
You are receiving this mail because:
You are the assignee for the bug.