date:20220115

Re: How to get started with contribution

2022-01-15 Thread Ilmari Lauhakangas


On 15.1.2022 22.20, Shashwat Anand wrote:


Hello Sir/Ma'am,
I am Shashwat Anand, third-year Computer science and Economics major at 
Bits Pilani. I am new to open source, but I know python, Javascript, 
React and Node.js. I would love to contribute to your organisation, but 
could you please help me get started?

I am hoping to hear from you soon.


I don't see C++ in the list of langs, so not inviting to interview. If 
someone else has ideas, feel free.


Ilmari

How to get started with contribution

2022-01-15 Thread Shashwat Anand

Hello Sir/Ma'am,
I am Shashwat Anand, third-year Computer science and Economics major at
Bits Pilani. I am new to open source, but I know python, Javascript, React
and Node.js. I would love to contribute to your organisation, but could you
please help me get started?
I am hoping to hear from you soon.

Thanking you,
Shashwat







[image: Mailtrack]

Sender
notified by
Mailtrack

16/01/22,
01:50:33 am

Infra call on Tue, Jan 18 at 17:30 UTC

2022-01-15 Thread Guilhem Moulin

Hi there,

The next infra call will take place at `date -d "Tue, 18 Jan 2022 17:30 UTC"`
(18:30 Berlin time).

We'll meet at https://jitsi.documentfoundation.org/infra and write the minutes
to https://pad.documentfoundation.org/p/infra .  Agenda TBA.

See you there!
Cheers,
-- 
Guilhem.


signature.asc
Description: PGP signature

[Libreoffice-commits] core.git: extensions/source

2022-01-15 Thread Caolán McNamara (via logerrit)

 extensions/source/propctrlr/handlerhelper.hxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit dd497f18e5a5aaa5d1116e87b12ea23d619088e2
Author: Caolán McNamara 
AuthorDate: Sat Jan 15 16:35:33 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 15 20:43:45 2022 +0100

include memory for std::unique_ptr

Change-Id: I63aa82b45f3dfcfd89d5d655eae3b347c1092af4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128470
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/extensions/source/propctrlr/handlerhelper.hxx 
b/extensions/source/propctrlr/handlerhelper.hxx
index 761c1d03d250..555b8ee825e8 100644
--- a/extensions/source/propctrlr/handlerhelper.hxx
+++ b/extensions/source/propctrlr/handlerhelper.hxx
@@ -27,6 +27,7 @@
 #include 
 #include 
 
+#include 
 #include 
 
 namespace weld { class Builder; class Widget; class Window; }

[Libreoffice-commits] core.git: chart2/source

2022-01-15 Thread Noel Grandin (via logerrit)

 chart2/source/controller/chartapiwrapper/AreaWrapper.cxx   
|2 
 chart2/source/controller/chartapiwrapper/AxisWrapper.cxx   
|   12 -
 chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
|   74 +++-
 chart2/source/controller/chartapiwrapper/Chart2ModelContact.hxx
|   13 -
 chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx  
|   18 +-
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx  
|   89 --
 chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx
|   36 ++--
 chart2/source/controller/chartapiwrapper/TitleWrapper.cxx  
|6 
 
chart2/source/controller/chartapiwrapper/WrappedAxisAndGridExistenceProperties.cxx
 |6 
 chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
|4 
 chart2/source/controller/chartapiwrapper/WrappedStockProperties.cxx
|8 
 11 files changed, 126 insertions(+), 142 deletions(-)

New commits:
commit e1802876e0773d57631f6a8f773fafaf4cfc7926
Author: Noel Grandin 
AuthorDate: Sat Jan 15 17:21:12 2022 +0200
Commit: Noel Grandin 
CommitDate: Sat Jan 15 20:32:21 2022 +0100

use more concrete types in chart2, ChartModel

Change-Id: Iecbc92aa096ede1845936faa708d1a9e8747b658
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128467
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx
index 8920b1eda076..7cbef7d67e2c 100644
--- a/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/AreaWrapper.cxx
@@ -132,7 +132,7 @@ void SAL_CALL AreaWrapper::removeEventListener(
 // WrappedPropertySet
 Reference< beans::XPropertySet > AreaWrapper::getInnerPropertySet()
 {
-Reference< chart2::XChartDocument > xChartDoc( 
m_spChart2ModelContact->getChart2Document() );
+rtl::Reference< ChartModel > xChartDoc( 
m_spChart2ModelContact->getDocumentModel() );
 if( xChartDoc.is() )
 return xChartDoc->getPageBackground();
 OSL_FAIL("AreaWrapper::getInnerPropertySet() is NULL");
diff --git a/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx
index b15f33f1871a..37835448d14e 100644
--- a/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/AxisWrapper.cxx
@@ -490,18 +490,18 @@ OUString SAL_CALL AxisWrapper::getShapeType()
 //  XNumberFormatsSupplier 
 uno::Reference< beans::XPropertySet > SAL_CALL 
AxisWrapper::getNumberFormatSettings()
 {
-Reference< util::XNumberFormatsSupplier > xNumSuppl( 
m_spChart2ModelContact->getChartModel(), uno::UNO_QUERY );
-if( xNumSuppl.is() )
-return xNumSuppl->getNumberFormatSettings();
+rtl::Reference xChartModel( 
m_spChart2ModelContact->getDocumentModel() );
+if( xChartModel )
+return xChartModel->getNumberFormatSettings();
 
 return uno::Reference< beans::XPropertySet >();
 }
 
 uno::Reference< util::XNumberFormats > SAL_CALL AxisWrapper::getNumberFormats()
 {
-Reference< util::XNumberFormatsSupplier > xNumSuppl( 
m_spChart2ModelContact->getChartModel(), uno::UNO_QUERY );
-if( xNumSuppl.is() )
-return xNumSuppl->getNumberFormats();
+rtl::Reference xChartModel( 
m_spChart2ModelContact->getDocumentModel() );
+if( xChartModel )
+return xChartModel->getNumberFormats();
 
 return uno::Reference< util::XNumberFormats >();
 }
diff --git a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx 
b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
index 8f1f3ad23e9d..8759cc6f54b7 100644
--- a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
+++ b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
@@ -43,8 +43,7 @@ namespace chart::wrapper
 Chart2ModelContact::Chart2ModelContact(
 const Reference< uno::XComponentContext > & xContext ) :
 m_xContext( xContext ),
-m_xChartModel( nullptr ),
-mpModel( nullptr )
+m_xChartModel( nullptr )
 {
 }
 
@@ -53,20 +52,18 @@ Chart2ModelContact::~Chart2ModelContact()
 clear();
 }
 
-void Chart2ModelContact::setModel( const css::uno::Reference< 
css::frame::XModel >& xChartModel )
+void Chart2ModelContact::setDocumentModel( ChartModel* pChartModel )
 {
 clear();
-m_xChartModel = xChartModel;
-mpModel = dynamic_cast(xChartModel.get());
-uno::Reference< lang::XMultiServiceFactory > xTableFactory( xChartModel, 
uno::UNO_QUERY );
-if( !xTableFactory.is() )
+m_xChartModel = pChartModel;
+if( !pChartModel )
 return;
 
-uno::Reference< container::XNameContainer > xDashTable( 
xTableFactory->createInstance("com.sun.star.drawing.Dash

[Libreoffice-commits] core.git: connectivity/source

2022-01-15 Thread Julien Nabet (via logerrit)

 connectivity/source/drivers/mysqlc/mysqlc_table.cxx |   15 ---
 connectivity/source/drivers/mysqlc/mysqlc_table.hxx |6 --
 2 files changed, 21 deletions(-)

New commits:
commit cec7cce3798eb0961496d0f896d782aeb2fc0a5f
Author: Julien Nabet 
AuthorDate: Sat Jan 15 16:54:23 2022 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 15 18:22:22 2022 +0100

Mysql/MariaDB: make rename table work

by just letting general mechanism deal with it

Change-Id: Iac70137c94419b719266f3105d651d18b43b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128468
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_table.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_table.cxx
index ff5a3a8221d5..69b566bb3945 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_table.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_table.cxx
@@ -163,19 +163,4 @@ void SAL_CALL Table::alterColumnByIndex(
   descriptor);
 }
 
-// - XRename --
-void SAL_CALL Table::rename(const OUString&)
-{
-MutexGuard aGuard(m_rMutex);
-// TODO: implement
-}
-
-// - XInterface ---
-Any SAL_CALL Table::queryInterface(const Type& rType)
-{
-if (rType.getTypeName() == "com.sun.star.sdbcx.XRename")
-return Any();
-return OTableHelper::queryInterface(rType);
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_table.hxx 
b/connectivity/source/drivers/mysqlc/mysqlc_table.hxx
index 6c235806117c..78ba2c949960 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_table.hxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_table.hxx
@@ -59,12 +59,6 @@ public:
 
 virtual void SAL_CALL alterColumnByIndex(
 sal_Int32 index, const css::uno::Reference& 
descriptor) override;
-
-// XRename
-virtual void SAL_CALL rename(const OUString& sName) override;
-
-//XInterface
-virtual css::uno::Any SAL_CALL queryInterface(const css::uno::Type& rType) 
override;
 };
 
 } // namespace connectivity::mysqlc

[Libreoffice-commits] core.git: framework/inc

2022-01-15 Thread Caolán McNamara (via logerrit)

 framework/inc/uielement/toolbarwrapper.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 4342717dcd580d5aea4e35636d4e35a4ea055d36
Author: Caolán McNamara 
AuthorDate: Sat Jan 15 14:19:33 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 15 17:35:16 2022 +0100

include memory for std::unique_ptr

Change-Id: I15f78ecfc53e75403bb8edbcd6e5400e8ecaaa44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128465
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/framework/inc/uielement/toolbarwrapper.hxx 
b/framework/inc/uielement/toolbarwrapper.hxx
index 55142f98d500..da90455b21da 100644
--- a/framework/inc/uielement/toolbarwrapper.hxx
+++ b/framework/inc/uielement/toolbarwrapper.hxx
@@ -25,6 +25,8 @@
 #include 
 #include 
 
+#include 
+
 namespace weld
 {
 class Builder;

[Libreoffice-commits] core.git: sc/qa

2022-01-15 Thread Eike Rathke (via logerrit)

 sc/qa/unit/ucalc_formula.cxx |7 +++
 1 file changed, 7 insertions(+)

New commits:
commit 26b3fc1f31b682fcc7ac0c10af07e64cffbe86e7
Author: Eike Rathke 
AuthorDate: Sat Jan 15 15:41:17 2022 +0100
Commit: Eike Rathke 
CommitDate: Sat Jan 15 17:04:56 2022 +0100

A unit test for tdf#146367

Change-Id: Ie47f1525f387d019c7c1131a76faf3784ee99d4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128466
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 551834284f76..c0fb17bc1b59 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -4987,6 +4987,13 @@ void TestFormula::testFuncSUM()
 CPPUNIT_ASSERT_EQUAL_MESSAGE("A4 should have inherited the same error as 
A2.",
static_cast(nErr), 
static_cast(m_pDoc->GetErrCode(ScAddress(0,3,0;
 
+// Test the dreaded 0.1 + 0.2 - 0.3 != 0.0
+m_pDoc->SetString(ScAddress(1,0,0), "=SUM(0.1;0.2;-0.3)");
+CPPUNIT_ASSERT_EQUAL(0.0, m_pDoc->GetValue(ScAddress(1,0,0)));
+// Also for +/- operators
+m_pDoc->SetString(ScAddress(1,1,0), "=0.1+0.2-0.3");
+CPPUNIT_ASSERT_EQUAL(0.0, m_pDoc->GetValue(ScAddress(1,1,0)));
+
 m_pDoc->DeleteTab(0);
 }

[Libreoffice-commits] core.git: bridges/source compilerplugins/clang forms/source include/com include/comphelper include/cppu include/cppuhelper include/oox include/registry lotuswordpro/source oox/so

2022-01-15 Thread Stephan Bergmann (via logerrit)

 bridges/source/cpp_uno/shared/vtables.cxx |2 +-
 compilerplugins/clang/nullptr.cxx |5 -
 forms/source/xforms/propertysetbase.hxx   |2 +-
 include/com/sun/star/uno/Any.hxx  |2 +-
 include/com/sun/star/uno/Sequence.hxx |6 +++---
 include/comphelper/newarray.hxx   |2 +-
 include/cppu/unotype.hxx  |4 ++--
 include/cppuhelper/interfacecontainer.hxx |2 +-
 include/oox/drawingml/chart/modelbase.hxx |2 +-
 include/oox/helper/containerhelper.hxx|6 +++---
 include/oox/helper/refmap.hxx |2 +-
 include/oox/helper/refvector.hxx  |2 +-
 include/registry/registry.hxx |2 +-
 lotuswordpro/source/filter/clone.hxx  |4 ++--
 oox/source/drawingml/theme.cxx|2 +-
 stoc/source/security/lru_cache.h  |2 +-
 store/source/storbase.hxx |6 +++---
 store/source/store.cxx|2 +-
 sw/source/filter/ww8/sortedarray.hxx  |2 +-
 sw/source/filter/ww8/writerwordglue.cxx   |8 
 ucb/source/inc/regexpmap.hxx  |8 
 21 files changed, 38 insertions(+), 35 deletions(-)

New commits:
commit 29bc12777ceffd00ed0ae103b8f2affa26897b4e
Author: Stephan Bergmann 
AuthorDate: Sat Jan 15 13:50:26 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Sat Jan 15 15:58:07 2022 +0100

Let loplugin:nullptr look into template instantiations

It missed some occurrences of 0 when only looking into uninstantiated 
template
code, as Clang doesn't model them with an ImplicitCastExpr, even if the 
target
is known to be a (dependent) pointer type.

Looking into all template instantiations of course carries the risk that a 
given
use of 0 is meant to be interpreted as a pointer in some and as an integer 
in
other instantiations.  But the only case where that happened in the current 
code
base is RegistryValueList::getElement (include/registry/registry.hxx), 
where {}
is arguably a better choice anyway.  (And which would presumably also hold 
for
any future such cases.)

Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/bridges/source/cpp_uno/shared/vtables.cxx 
b/bridges/source/cpp_uno/shared/vtables.cxx
index beda5ad29d44..9a7d7b376882 100644
--- a/bridges/source/cpp_uno/shared/vtables.cxx
+++ b/bridges/source/cpp_uno/shared/vtables.cxx
@@ -82,7 +82,7 @@ template< typename T > bridges::cpp_uno::shared::VtableSlot 
doGetVtableSlot(
 bridges::cpp_uno::shared::VtableSlot slot;
 slot.offset = 0;
 T * member = const_cast< T * >(ifcMember);
-while (member->pBaseRef != 0) {
+while (member->pBaseRef != nullptr) {
 assert(member->nIndex < member->pInterface->nBaseTypes);
 for (sal_Int32 i = 0; i < member->nIndex; ++i) {
 slot.offset += getVtableCount(member->pInterface->ppBaseTypes[i]);
diff --git a/compilerplugins/clang/nullptr.cxx 
b/compilerplugins/clang/nullptr.cxx
index b4a40b408a6c..1ac09292 100644
--- a/compilerplugins/clang/nullptr.cxx
+++ b/compilerplugins/clang/nullptr.cxx
@@ -75,7 +75,7 @@ public:
 
 bool TraverseInitListExpr(InitListExpr * expr, DataRecursionQueue * queue 
= nullptr);
 
-// bool shouldVisitTemplateInstantiations() const { return true; }
+bool shouldVisitTemplateInstantiations() const { return true; }
 
 private:
 bool isInLokIncludeFile(SourceLocation spellingLocation) const;
@@ -209,6 +209,9 @@ bool Nullptr::VisitParmVarDecl(ParmVarDecl const * decl) {
 if (!isAnyKindOfPointerType(decl->getType())) {
 return true;
 }
+if (decl->hasUninstantiatedDefaultArg()) {
+return true; //TODO
+}
 auto e = decl->getDefaultArg();
 if (e == nullptr) {
 return true;
diff --git a/forms/source/xforms/propertysetbase.hxx 
b/forms/source/xforms/propertysetbase.hxx
index d4b4212c45c7..2ad685c66322 100644
--- a/forms/source/xforms/propertysetbase.hxx
+++ b/forms/source/xforms/propertysetbase.hxx
@@ -93,7 +93,7 @@ public:
 
 virtual bool isWriteable() const override
 {
-return m_pWriter != 0;
+return m_pWriter != nullptr;
 }
 };
 
diff --git a/include/com/sun/star/uno/Any.hxx b/include/com/sun/star/uno/Any.hxx
index 28d45f1ec21d..f1e5f86c8af2 100644
--- a/include/com/sun/star/uno/Any.hxx
+++ b/include/com/sun/star/uno/Any.hxx
@@ -202,7 +202,7 @@ inline bool Any::isExtractableTo( const Type & rType ) const
 template 
 inline bool Any::has() const
 {
-Type const & rType = ::cppu::getTypeFavourUnsigned(static_cast< T * >(0));
+Type const & rType = ::cppu::getTypeFavourUnsigned(static_cast< T * 
>(NULL));
 return ::uno_type_isAssignableFromData(
 rType.getTypeLibType(), pData, pType,
 cpp_queryInterface,
diff --git a/include/com/sun/star/uno/Sequence.hxx 
b/inclu

[Libreoffice-commits] core.git: chart2/inc chart2/source

2022-01-15 Thread Noel Grandin (via logerrit)

 chart2/inc/ChartModel.hxx |4 -
 chart2/inc/ChartView.hxx  |2 
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx |   21 
--
 chart2/source/controller/inc/ChartDocumentWrapper.hxx |3 -
 chart2/source/model/main/ChartModel.cxx   |6 +-
 5 files changed, 19 insertions(+), 17 deletions(-)

New commits:
commit fe37aa64ff79abcd3aeedeb03d8d74798225a367
Author: Noel Grandin 
AuthorDate: Sat Jan 15 13:45:44 2022 +0200
Commit: Noel Grandin 
CommitDate: Sat Jan 15 15:43:59 2022 +0100

use more concrete types in chart2, ChartView

Change-Id: I7316d01d08eb1d9d482937fdd87bd34e2ae7e3c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128461
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/inc/ChartModel.hxx b/chart2/inc/ChartModel.hxx
index 8f1defa197be..b3d1d3f42ce9 100644
--- a/chart2/inc/ChartModel.hxx
+++ b/chart2/inc/ChartModel.hxx
@@ -120,7 +120,7 @@ private:
 
 bool mbTimeBased;
 
-rtl::Reference mxChartView;
+mutable rtl::Reference mxChartView;
 
 OUString m_aResource;
 css::uno::Sequence< css::beans::PropertyValue >   m_aMediaDescriptor;
@@ -454,7 +454,7 @@ public:
 css::uno::Reference< css::util::XNumberFormatsSupplier > const &
 getNumberFormatsSupplier();
 
-css::uno::Reference< css::uno::XInterface > getChartView() const;
+ChartView* getChartView() const;
 
 bool isTimeBased() const { return mbTimeBased;}
 
diff --git a/chart2/inc/ChartView.hxx b/chart2/inc/ChartView.hxx
index 27408b53f844..46dd1da17975 100644
--- a/chart2/inc/ChartView.hxx
+++ b/chart2/inc/ChartView.hxx
@@ -114,7 +114,7 @@ public:
 virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames() 
override;
 
 // ___lang::XInitialization___
-virtual void SAL_CALL initialize( const css::uno::Sequence< css::uno::Any 
>& aArguments ) override;
+virtual OOO_DLLPUBLIC_CHARTVIEW void SAL_CALL initialize( const 
css::uno::Sequence< css::uno::Any >& aArguments ) override;
 
 // ___ExplicitValueProvider___
 virtual bool getExplicitValuesForAxis(
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index a4e494c9e5cb..aa5d09c2c99a 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -18,6 +18,7 @@
  */
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -1242,19 +1243,17 @@ uno::Reference< uno::XInterface > SAL_CALL 
ChartDocumentWrapper::createInstance(
 {
 if( !m_xChartView.is() )
 {
-Reference< lang::XMultiServiceFactory > xFact(
-m_spChart2ModelContact->m_xContext->getServiceManager(), 
uno::UNO_QUERY_THROW );
-Reference< lang::XInitialization > xViewInit( 
xFact->createInstance(
-CHART_VIEW_SERVICE_NAME ), uno::UNO_QUERY );
-if(xViewInit.is())
+ChartModel* pModel = m_spChart2ModelContact->getModel();
+ChartView* pChartView = pModel->getChartView();
+if(pChartView)
 {
 try
 {
-m_xChartView = xViewInit;
+m_xChartView = pChartView;
 
 Sequence< Any > aArguments{ 
Any(Reference(this)),
 Any(true) }; // bRefreshAddIn
-xViewInit->initialize(aArguments);
+pChartView->initialize(aArguments);
 }
 catch (const uno::Exception&)
 {
@@ -1262,7 +1261,7 @@ uno::Reference< uno::XInterface > SAL_CALL 
ChartDocumentWrapper::createInstance(
 }
 }
 }
-xResult.set( m_xChartView );
+xResult.set( static_cast(m_xChartView.get()) );
 bServiceFound = true;
 }
 else
@@ -1272,7 +1271,7 @@ uno::Reference< uno::XInterface > SAL_CALL 
ChartDocumentWrapper::createInstance(
 {
 if( !m_xShapeFactory.is() && m_xChartView.is() )
 {
-m_xShapeFactory = getShapeFactory( m_xChartView );
+m_xShapeFactory = getShapeFactory( 
static_cast(m_xChartView.get()) );
 }
 else
 {
@@ -1280,7 +1279,7 @@ uno::Reference< uno::XInterface > SAL_CALL 
ChartDocumentWrapper::createInstance(
 if(pModel)
 {
 m_xChartView = pModel->getChartView();
-m_xShapeFactory = getShapeFactory( m_xChartView );
+m_xShapeFactory = getShapeFactory( 
static_cast(m_xChartView.get()) );
 }
 }
 
@@ -1386,7 +1385,7 @@ void ChartDocumentWrapper::_disposing( const 
lang::EventObject& rSource )
 m

[Libreoffice-commits] core.git: chart2/inc chart2/IwyuFilter_chart2.yaml chart2/source offapi/com offapi/UnoApi_offapi.mk

2022-01-15 Thread Noel Grandin (via logerrit)

 chart2/IwyuFilter_chart2.yaml |6 -
 chart2/inc/pch/precompiled_chartcore.hxx  |1 
 chart2/source/view/axes/VCartesianGrid.cxx|1 
 chart2/source/view/charttypes/BarChart.cxx|1 
 chart2/source/view/inc/PlottingPositionHelper.hxx |1 
 offapi/UnoApi_offapi.mk   |1 
 offapi/com/sun/star/chart2/XChartShape.idl|1 
 offapi/com/sun/star/chart2/XTransformation.idl|   89 --
 8 files changed, 101 deletions(-)

New commits:
commit abb6978cabd3ef5d0bf086a388af7be6e144907e
Author: Noel Grandin 
AuthorDate: Fri Jan 14 18:42:47 2022 +0200
Commit: Noel Grandin 
CommitDate: Sat Jan 15 15:43:44 2022 +0100

remove XTransformation UNO API

unused after
commit 18bc9ea75daf4eb3520a4d0ef6649d92261012a6
Date:   Tue Jan 11 15:02:14 2022 +0200
replace XTransformation with more efficient class

Change-Id: I9e6bf80d8a8cdba8514ad0e94ce090bdbceab853
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128460
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/IwyuFilter_chart2.yaml b/chart2/IwyuFilter_chart2.yaml
index 158680ac2512..da282c91d93b 100644
--- a/chart2/IwyuFilter_chart2.yaml
+++ b/chart2/IwyuFilter_chart2.yaml
@@ -436,15 +436,9 @@ excludelist:
 # base class has to be a complete type
 - boost/shared_array.hpp
 - map
-chart2/source/view/inc/Linear3DTransformation.hxx:
-# base class has to be a complete type
-- com/sun/star/chart2/XTransformation.hpp
 chart2/source/view/inc/VLineProperties.hxx:
 # base class has to be a complete type
 - com/sun/star/uno/Reference.h
-chart2/source/view/inc/VPolarTransformation.hxx:
-# base class has to be a complete type
-- com/sun/star/chart2/XTransformation.hpp
 chart2/source/view/axes/DateScaling.hxx:
 # base class has to be a complete type
 - com/sun/star/chart2/XScaling.hpp
diff --git a/chart2/inc/pch/precompiled_chartcore.hxx 
b/chart2/inc/pch/precompiled_chartcore.hxx
index 15b5bd32bcf8..dd06c9bc8a90 100644
--- a/chart2/inc/pch/precompiled_chartcore.hxx
+++ b/chart2/inc/pch/precompiled_chartcore.hxx
@@ -147,7 +147,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/chart2/source/view/axes/VCartesianGrid.cxx 
b/chart2/source/view/axes/VCartesianGrid.cxx
index d681bf07874b..19e60b4ecabd 100644
--- a/chart2/source/view/axes/VCartesianGrid.cxx
+++ b/chart2/source/view/axes/VCartesianGrid.cxx
@@ -27,7 +27,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
diff --git a/chart2/source/view/charttypes/BarChart.cxx 
b/chart2/source/view/charttypes/BarChart.cxx
index 8ac955266e9c..938355192e35 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -32,7 +32,6 @@
 
 #include 
 
-#include 
 #include 
 #include 
 #include 
diff --git a/chart2/source/view/inc/PlottingPositionHelper.hxx 
b/chart2/source/view/inc/PlottingPositionHelper.hxx
index 81486bcdb669..c0480a4e3b2c 100644
--- a/chart2/source/view/inc/PlottingPositionHelper.hxx
+++ b/chart2/source/view/inc/PlottingPositionHelper.hxx
@@ -34,7 +34,6 @@
 #include 
 #include 
 
-namespace com::sun::star::chart2 { class XTransformation; }
 namespace com::sun::star::drawing { class XShapes; }
 namespace com::sun::star::drawing { struct HomogenMatrix; }
 namespace com::sun::star::drawing { struct PolyPolygonShape3D; }
diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk
index 3eb002520e42..68068ab4a864 100644
--- a/offapi/UnoApi_offapi.mk
+++ b/offapi/UnoApi_offapi.mk
@@ -2056,7 +2056,6 @@ $(eval $(call 
gb_UnoApi_add_idlfiles,offapi,com/sun/star/chart2,\
XTimeBased \
XTitle \
XTitled \
-   XTransformation \
 ))
 $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/chart2/data,\
DataSequenceRole \
diff --git a/offapi/com/sun/star/chart2/XChartShape.idl 
b/offapi/com/sun/star/chart2/XChartShape.idl
index 696c31609589..08bab11ce6e5 100644
--- a/offapi/com/sun/star/chart2/XChartShape.idl
+++ b/offapi/com/sun/star/chart2/XChartShape.idl
@@ -21,7 +21,6 @@
 #define com_sun_star_chart2_XChartShape_idl
 
 #include 
-#include 
 #include 
 #include 
 #include 
diff --git a/offapi/com/sun/star/chart2/XTransformation.idl 
b/offapi/com/sun/star/chart2/XTransformation.idl
deleted file mode 100644
index a19ce8839116..
--- a/offapi/com/sun/star/chart2/XTransformation.idl
+++ /dev/null
@@ -1,89 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed

[Libreoffice-commits] core.git: g

2022-01-15 Thread Arnaud VERSINI (via logerrit)

 g |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 5448ad57032df1113daf1c3899741febc069d8b3
Author: Arnaud VERSINI 
AuthorDate: Sun Jan 2 17:33:27 2022 +0100
Commit: Arnaud Versini 
CommitDate: Sat Jan 15 15:42:34 2022 +0100

Allow g to run git gc command

Change-Id: Ibca338cbd99839b20a2373075a2e544e7ab638e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127870
Tested-by: Jenkins
Reviewed-by: Arnaud Versini 

diff --git a/g b/g
index 8b733fc878c6..021ad6c41cde 100755
--- a/g
+++ b/g
@@ -24,7 +24,7 @@ usage()
 {
 git
 echo
-echo "Usage: g [options] [git (checkout|clone|fetch|grep|pull|push|reset) 
[git options/args..]]"
+echo "Usage: g [options] [git 
(checkout|clone|fetch|gc|grep|pull|push|reset) [git options/args..]]"
 echo ""
 echo " -z restore the git hooks and do other sanity checks"
 }
@@ -362,6 +362,9 @@ case "$COMMAND" in
 (git fetch "$@" && git submodule foreach git fetch "$@" ) && git 
submodule update --progress
 
 ;;
+gc)
+ (git gc "$@" && git submodule foreach git gc "$@" )
+;;
 grep)
 KEEP_GOING="||:"
 do_git_cmd "${COMMAND}" "$@"

[Libreoffice-commits] core.git: sw/qa

2022-01-15 Thread Caolán McNamara (via logerrit)

 sw/qa/extras/layout/layout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f005fe8e463695cb701f343c32777fe4d48159ed
Author: Caolán McNamara 
AuthorDate: Fri Jan 14 21:48:40 2022 +
Commit: Caolán McNamara 
CommitDate: Sat Jan 15 15:16:14 2022 +0100

request the 2nd rect explicitly instead of one with a particular 'top' value

Change-Id: I04caee2263e5e7345fb3fb0c07830d1bf504bf7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128448
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx
index ce2b8e7f2339..20158e3ae744 100644
--- a/sw/qa/extras/layout/layout.cxx
+++ b/sw/qa/extras/layout/layout.cxx
@@ -2704,7 +2704,7 @@ CPPUNIT_TEST_FIXTURE(SwLayoutWriter, testBtlrCell)
 // Without the accompanying fix in place, this test would have failed with 
'Expected: 1979;
 // Actual  : 2129', i.e. the gray background of the "AAA2." text was too 
close to the right edge
 // of the text portion. Now it's exactly behind the text portion.
-assertXPath(pXmlDoc, "//rect[@top='2159']", "left", "1979");
+assertXPath(pXmlDoc, "(//rect)[2]", "left", "1979");
 
 // Without the accompanying fix in place, this test would have failed with 
'Expected: 269;
 // Actual  : 0', i.e. the AAA2 frame was not visible due to 0 width.

[Libreoffice-commits] core.git: connectivity/source

2022-01-15 Thread Julien Nabet (via logerrit)

 connectivity/source/drivers/mysqlc/mysqlc_tables.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit bcc61497fc954efa7ebb8cef7ad3020d360a813f
Author: Julien Nabet 
AuthorDate: Sat Jan 15 12:40:06 2022 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 15 14:16:55 2022 +0100

Mysql/MariaDB: related:tdf#81430, fix regression refresh tables/views 
manually

Change-Id: Ia17a396a8d55e38ac8ad42fab90c50bfaf96809e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128459
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
index 55baa8bffd79..8bf019d9bb36 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
@@ -9,6 +9,7 @@
 
 #include "mysqlc_table.hxx"
 #include "mysqlc_tables.hxx"
+#include "mysqlc_catalog.hxx"
 
 #include 
 
@@ -34,10 +35,7 @@ using namespace ::com::sun::star::sdbcx;
 using namespace ::com::sun::star::uno;
 
 //- OCollection ---
-void Tables::impl_refresh()
-{
-// TODO implement
-}
+void Tables::impl_refresh() { 
static_cast(m_rParent).refreshTables(); }
 
 ObjectType Tables::createObject(const OUString& rName)
 {

Re: How to get started with contribution

2022-01-15 Thread Ilmari Lauhakangas


On 15.1.2022 12.01, Purvak Baliyan wrote:

Respected Sir/Madam

I am Purvak Baliyan, an Information Technology undergrad, I have entered 
my third year at DR. Akhilesh Das Gupta Institute of Technology & 
Management(ADGITM). I am new to open source contributions but i am well 
aware of C/C++, Data Structure and Algorithms, and HTML & CSS. I would 
love to contribute to your organisation but could you please tell me how 
to get started?


I have invited you to an interview.

Ilmari

Re: Want to contribute in your organisation

2022-01-15 Thread Ilmari Lauhakangas


On 15.1.2022 9.23, Geetansh Juneja wrote:

Respected Sir/Ma'am,

I am Geetansh Juneja a sophomore in IITD with computer science as major.
Can you help me in getting started?

Skills I am having : C,C++,Java,Flutter,SML,HTML,CSS


I have invited you to an interview.

Ilmari

[Libreoffice-commits] core.git: sc/inc

2022-01-15 Thread Eike Rathke (via logerrit)

 sc/inc/kahan.hxx |  126 ++-
 1 file changed, 80 insertions(+), 46 deletions(-)

New commits:
commit 730b8aba72356bb8ba0066a5517b1224a4f1e232
Author: Eike Rathke 
AuthorDate: Fri Jan 14 23:34:41 2022 +0100
Commit: Eike Rathke 
CommitDate: Sat Jan 15 13:51:24 2022 +0100

tdf#146367 reintroduce approxAdd() similar handling with last summand

... to tie result to 0 eliminating opposite sign small equalish
fractions.

This does not "fix" all interim values of the bug's sample document,
which repeatedly adds single values in sequence using SUM() and should
use the + operator instead to benefit from approxAdd() for each, but
maintains the better accuracy of Kahan summation in the not near equal
zero cases. And the dreaded SUM(0.1;0.2;-0.3) also works again resulting
in 0 with all permutations.

Change-Id: I67188a6abbdb98212f070166ad02319c3d477e28
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128451
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/inc/kahan.hxx b/sc/inc/kahan.hxx
index ded7bd78d70e..5418c8d23b35 100644
--- a/sc/inc/kahan.hxx
+++ b/sc/inc/kahan.hxx
@@ -9,6 +9,7 @@
 
 #pragma once
 
+#include 
 #include 
 
 #include "arraysumfunctorinternal.hxx"
@@ -17,7 +18,10 @@
   * This class provides LO with Kahan summation algorithm
   * About this algorithm: 
https://en.wikipedia.org/wiki/Kahan_summation_algorithm
   * For general purpose software we assume first order error is enough.
-  * This class could be made constexpr if needed.
+  *
+  * Additionally queue and remember the last recent non-zero value and add it
+  * similar to approxAdd() when obtaining the final result to further eliminate
+  * accuracy errors. (e.g. for the dreaded 0.1 + 0.2 - 0.3 != 0.0)
   */
 
 class KahanSum
@@ -51,12 +55,22 @@ public:
   */
 void add(double x_i)
 {
-double t = m_fSum + x_i;
-if (std::abs(m_fSum) >= std::abs(x_i))
-m_fError += (m_fSum - t) + x_i;
+if (x_i == 0.0)
+return;
+
+if (!m_fMem)
+{
+m_fMem = x_i;
+return;
+}
+
+double t = m_fSum + m_fMem;
+if (std::abs(m_fSum) >= std::abs(m_fMem))
+m_fError += (m_fSum - t) + m_fMem;
 else
-m_fError += (x_i - t) + m_fSum;
+m_fError += (m_fMem - t) + m_fSum;
 m_fSum = t;
+m_fMem = x_i;
 }
 
 /**
@@ -67,6 +81,7 @@ public:
 {
 add(fSum.m_fSum);
 add(fSum.m_fError);
+add(fSum.m_fMem);
 }
 
 /**
@@ -77,6 +92,7 @@ public:
 {
 add(-fSum.m_fSum);
 add(-fSum.m_fError);
+add(-fSum.m_fMem);
 }
 
 public:
@@ -85,6 +101,7 @@ public:
 KahanSum fKahanSum;
 fKahanSum.m_fSum = -m_fSum;
 fKahanSum.m_fError = -m_fError;
+fKahanSum.m_fMem = -m_fMem;
 return fKahanSum;
 }
 
@@ -92,6 +109,7 @@ public:
 {
 m_fSum = fSum;
 m_fError = 0;
+m_fMem = 0;
 return *this;
 }
 
@@ -139,76 +157,92 @@ public:
   */
 constexpr void operator*=(double fTimes)
 {
-m_fSum *= fTimes;
-m_fError *= fTimes;
+if (m_fMem)
+{
+m_fSum = get() * fTimes;
+m_fMem = 0.0;
+}
+else
+{
+m_fSum = (m_fSum + m_fError) * fTimes;
+}
+m_fError = 0.0;
 }
 
 constexpr void operator/=(double fDivides)
 {
-m_fSum /= fDivides;
-m_fError /= fDivides;
+if (m_fMem)
+{
+m_fSum = get() / fDivides;
+m_fMem = 0.0;
+}
+else
+{
+m_fSum = (m_fSum + m_fError) / fDivides;
+}
+m_fError = 0.0;
 }
 
-inline KahanSum operator*(const KahanSum& fTimes) const
-{
-return *this * fTimes.m_fSum + *this * fTimes.m_fError;
-}
+inline KahanSum operator*(const KahanSum& fTimes) const { return get() * 
fTimes.get(); }
 
-constexpr KahanSum operator*(double fTimes) const
-{
-KahanSum fSum(*this);
-fSum *= fTimes;
-return fSum;
-}
+inline KahanSum operator*(double fTimes) const { return get() * fTimes; }
 
-inline KahanSum operator/(const KahanSum& fDivides) const { return *this / 
fDivides.get(); }
+inline KahanSum operator/(const KahanSum& fDivides) const { return get() / 
fDivides.get(); }
 
-constexpr KahanSum operator/(double fTimes) const
-{
-KahanSum fSum(*this);
-fSum /= fTimes;
-return fSum;
-}
+inline KahanSum operator/(double fDivides) const { return get() / 
fDivides; }
 
-constexpr bool operator<(const KahanSum& fSum) const { return get() < 
fSum.get(); }
+inline bool operator<(const KahanSum& fSum) const { return get() < 
fSum.get(); }
 
-constexpr bool operator<(double fSum) const { return get() < fSum; }
+

[Libreoffice-commits] core.git: sc/uiconfig

2022-01-15 Thread Olivier Hallot (via logerrit)

 sc/uiconfig/scalc/ui/tpviewpage.ui |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 0c141900b49c2efeb0535dbcbea94f7b9b6aacd2
Author: Olivier Hallot 
AuthorDate: Fri Jan 14 17:50:52 2022 -0300
Commit: Olivier Hallot 
CommitDate: Sat Jan 15 13:32:58 2022 +0100

Change cursor -> pointer in spreadsheet option tip

Change-Id: I4fe40f321849846daaddd1c9374a0271689b5823
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128425
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/sc/uiconfig/scalc/ui/tpviewpage.ui 
b/sc/uiconfig/scalc/ui/tpviewpage.ui
index 8592a0968041..533e659d7fb2 100644
--- a/sc/uiconfig/scalc/ui/tpviewpage.ui
+++ b/sc/uiconfig/scalc/ui/tpviewpage.ui
@@ -465,7 +465,6 @@
 False
 0
 True
-
 
   
 
@@ -501,7 +500,7 @@
 True
 True
 False
-Show the cursor as defined in the 
icon theme, typically as fat cross.
+Show the pointer as defined in the 
icon theme, typically as fat cross.
 True
 True
 rbSystemCursor
@@ -517,7 +516,7 @@
 True
 True
 False
-Show the cursor as system default, 
typically an arrow pointer.
+Show the pointer as system default, 
typically an arrow pointer.
 True
 True
 True

[Libreoffice-commits] core.git: sc/uiconfig

2022-01-15 Thread Olivier Hallot (via logerrit)

 sc/uiconfig/scalc/ui/printeroptions.ui |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e19f4c1a1c24de32043c6d94394d048e1dc63dba
Author: Olivier Hallot 
AuthorDate: Fri Jan 14 17:55:17 2022 -0300
Commit: Olivier Hallot 
CommitDate: Sat Jan 15 13:32:25 2022 +0100

Fix extended tip on printer options for speradsheets

Change-Id: Iad153527e4ee4b74cb9d7bf6a57821a9f13f1f16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128426
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/sc/uiconfig/scalc/ui/printeroptions.ui 
b/sc/uiconfig/scalc/ui/printeroptions.ui
index 18e8a189ce4b..bdb8c568ef9e 100644
--- a/sc/uiconfig/scalc/ui/printeroptions.ui
+++ b/sc/uiconfig/scalc/ui/printeroptions.ui
@@ -26,7 +26,7 @@
 True
 
   
-If 
checked empty pages that have no cell contents or draw objects are not 
printed.
+If 
checked, empty pages that have no cell contents or drawing objects are not 
printed.

[Libreoffice-commits] core.git: cui/source cui/uiconfig sc/qa sw/qa sw/uiconfig

2022-01-15 Thread Heiko Tietze (via logerrit)

 cui/source/inc/chardlg.hxx|3 
 cui/source/tabpages/chardlg.cxx   |9 
 cui/uiconfig/ui/charnamepage.ui   | 1240 --
 cui/uiconfig/ui/effectspage.ui|   25 
 sc/qa/uitest/calc_tests/formatCells.py|4 
 sw/qa/uitest/writer_tests2/formatCharacter.py |5 
 sw/uiconfig/swriter/ui/characterproperties.ui |1 
 sw/uiconfig/swriter/ui/paradialog.ui  |1 
 sw/uiconfig/swriter/ui/templatedialog1.ui |1 
 sw/uiconfig/swriter/ui/templatedialog16.ui|1 
 sw/uiconfig/swriter/ui/templatedialog2.ui |1 
 sw/uiconfig/swriter/ui/templatedialog4.ui |1 
 sw/uiconfig/swriter/ui/templatedialog8.ui |1 
 13 files changed, 615 insertions(+), 678 deletions(-)

New commits:
commit d73602dc51aa8829fc88e5e67e2b0c4da6b8f715
Author: Heiko Tietze 
AuthorDate: Fri Nov 26 16:38:35 2021 +0100
Commit: Heiko Tietze 
CommitDate: Sat Jan 15 13:29:35 2022 +0100

Resolves tdf#139395 - Redesign of font name and effects pages

* Western/CJK/CTL selection placed into a GtkNotebook
* Font color and transparency in one line
* Alignment adjusted at font effects page
* Char-, para- & style dialogs made non-resizable according the guideline

Change-Id: I242c3886534a2696b4c2438ca17e6e778c2c3991
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125909
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/source/inc/chardlg.hxx b/cui/source/inc/chardlg.hxx
index be4db989b57d..70935a6eaaf6 100644
--- a/cui/source/inc/chardlg.hxx
+++ b/cui/source/inc/chardlg.hxx
@@ -76,8 +76,8 @@ private:
 std::unique_ptr m_xWestFontLanguageLB;
 std::unique_ptr m_xWestFontTypeFT;
 std::unique_ptr m_xWestFontFeaturesButton;
+std::unique_ptr m_xLangNotebook;
 
-std::unique_ptr m_xEastFrame;
 std::unique_ptr m_xEastFontNameFT;
 std::unique_ptr m_xEastFontNameLB;
 std::unique_ptr m_xEastFontStyleFT;
@@ -89,7 +89,6 @@ private:
 std::unique_ptr m_xEastFontTypeFT;
 std::unique_ptr m_xEastFontFeaturesButton;
 
-std::unique_ptr m_xCTLFrame;
 std::unique_ptr m_xCTLFontNameFT;
 std::unique_ptr m_xCTLFontNameLB;
 std::unique_ptr m_xCTLFontStyleFT;
diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index 4c190180e8c2..86e29f9d16c0 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -189,7 +189,7 @@ struct SvxCharNamePage_Impl
 SvxCharNamePage::SvxCharNamePage(weld::Container* pPage, 
weld::DialogController* pController, const SfxItemSet& rInSet)
 : SvxCharBasePage(pPage, pController, "cui/ui/charnamepage.ui", 
"CharNamePage", rInSet)
 , m_pImpl(new SvxCharNamePage_Impl)
-, m_xEastFrame(m_xBuilder->weld_widget("asian"))
+, m_xLangNotebook(m_xBuilder->weld_notebook("notebook"))
 , m_xEastFontNameFT(m_xBuilder->weld_label("eastfontnameft"))
 , m_xEastFontNameLB(m_xBuilder->weld_combo_box("eastfontnamelb"))
 , m_xEastFontStyleFT(m_xBuilder->weld_label("eaststyleft"))
@@ -200,7 +200,6 @@ SvxCharNamePage::SvxCharNamePage(weld::Container* pPage, 
weld::DialogController*
 , m_xEastFontLanguageLB(new 
SvxLanguageBox(m_xBuilder->weld_combo_box("eastlanglb")))
 , m_xEastFontTypeFT(m_xBuilder->weld_label("eastfontinfo"))
 , 
m_xEastFontFeaturesButton(m_xBuilder->weld_button("east_features_button"))
-, m_xCTLFrame(m_xBuilder->weld_widget("ctl"))
 , m_xCTLFontNameFT(m_xBuilder->weld_label("ctlfontnameft"))
 , m_xCTLFontNameLB(m_xBuilder->weld_combo_box("ctlfontnamelb"))
 , m_xCTLFontStyleFT(m_xBuilder->weld_label("ctlstyleft"))
@@ -293,8 +292,10 @@ SvxCharNamePage::SvxCharNamePage(weld::Container* pPage, 
weld::DialogController*
 m_xCTLFontStyleFT->set_label(sFontStyleString);
 
 m_xWestFrame->show();
-m_xEastFrame->set_visible(bShowCJK);
-m_xCTLFrame->set_visible(bShowCTL);
+if (!bShowCJK)
+m_xLangNotebook->remove_page("lbAsian");
+if (!bShowCTL)
+m_xLangNotebook->remove_page("lbComplex");
 
 m_xWestFontLanguageLB->SetLanguageList(SvxLanguageListFlags::WESTERN, 
true, false, true, true,
LANGUAGE_SYSTEM, 
css::i18n::ScriptType::LATIN);
diff --git a/cui/uiconfig/ui/charnamepage.ui b/cui/uiconfig/ui/charnamepage.ui
index 61f6a6be9289..27be5657a856 100644
--- a/cui/uiconfig/ui/charnamepage.ui
+++ b/cui/uiconfig/ui/charnamepage.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -68,69 +68,73 @@
   
   
 True
-False
+False
 True
 True
-6
+6
 vertical
 12
 
-  
+  
   
-False
-True
+False
+True
+6
+6
+6
+6
 True
 True
-6
-12
+6
+12
 
   
 True
-False
-6
+False
+6
 0
   
   
-

Want to contribute in your organisation

2022-01-15 Thread Geetansh Juneja

Respected Sir/Ma'am,

I am Geetansh Juneja a sophomore in IITD with computer science as major.
Can you help me in getting started?

Skills I am having : C,C++,Java,Flutter,SML,HTML,CSS

Regards
Geetansh Juneja

How to get started with contribution

2022-01-15 Thread Purvak Baliyan

Respected Sir/Madam

I am Purvak Baliyan, an Information Technology undergrad, I have entered my
third year at DR. Akhilesh Das Gupta Institute of Technology &
Management(ADGITM). I am new to open source contributions but i am well
aware of C/C++, Data Structure and Algorithms, and HTML & CSS. I would love
to contribute to your organisation but could you please tell me how to get
started?

Hoping to hear from you soon.

Regards

Purvak

[Libreoffice-commits] core.git: connectivity/source

2022-01-15 Thread Julien Nabet (via logerrit)

 connectivity/source/drivers/mysqlc/mysqlc_tables.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ff3720c4747b9b75e3886163bc61e2e58a5aabb5
Author: Julien Nabet 
AuthorDate: Sat Jan 15 09:58:28 2022 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 15 11:29:50 2022 +0100

Mysql/MariaDB: related:tdf#81430, fix regression create table

Change-Id: I8f2983c1d08026ad0cbe796f73e0ff44f917de17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128458
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
index 36fb744ee5cc..55baa8bffd79 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
@@ -188,7 +188,7 @@ ObjectType Tables::appendObject(const OUString& rName,
 
 m_xMetaData->getConnection()->createStatement()->execute(sSql);
 
-return createObject(rName);
+return createObject(sSchema + "." + rName);
 }
 
 //- XDrop -

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

2022-01-15 Thread Michael Stahl (via logerrit)

 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |3 +++
 sw/source/filter/ww8/wrtw8nds.cxx |3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

New commits:
commit eb88b41c15f6451e06b34e2ec0ef5ec4359c200c
Author: Michael Stahl 
AuthorDate: Thu Jan 13 14:14:44 2022 +0100
Commit: Thorsten Behrens 
CommitDate: Sat Jan 15 11:29:00 2022 +0100

tdf#143039 tdf#143106 sw: DOCX export: don't export duplicate flys

The problem is that at the end of the paragraph a second call to
OutFlys() is made in line 2730 and that causes the duplication; for
this call the value FLY_POSTPONED must be returned, not FLY_NONE.

(regression from 3eced2d52415abeac266804ab682bee022322a19)

Also revert commit deb892628a1501527c8c41b85a65282df95b81b1 because its
test fails now as 0 comments are exported; it was apparently another
problem introduced by the above commit, and apparently this fix helps
for duplication of comments too.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128386
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3)

Restore tdf#134951 docxexport: stop duplicating stuff in postponed text

Partially revert commit f261fae4af72b1328bc3e93fc52a9a24ce0975b3
to restore deb892628a1501527c8c41b85a65282df95b81b1 because as reported
by jluth the test case testfdo79008 that failed was apparently somewhat
misleading and the test case testTdf134951_duplicates that should test
comments erroneously failed to fail because it is doing a loadAndSave()
instead of a loadAndReload().

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128410
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 
(cherry picked from commit 4c4fb36222f6c624cfdea82ce266bf9d99073558)

Change-Id: Ib9706e4c24db38c15a0170ba2e8f08fba5327f98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128341
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 00b58a149ef4..17fe49c8f8aa 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -136,9 +136,12 @@ CPPUNIT_TEST_FIXTURE(Test, testfdo79008)
  */
 parseExport("word/document.xml");
 
+#if 0
+// TODO: jluth says this test case needs more work
 // tdf#134951: there is only one comment
 xmlDocUniquePtr pXmlSettings = parseExport("word/comments.xml");
 assertXPath(pXmlSettings, "/w:comments/w:comment", 1);
+#endif
 
 // Read-only is set, but it is not enforced, so it should be off...
 SwXTextDocument* pTextDoc = dynamic_cast(mxComponent.get());
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx 
b/sw/source/filter/ww8/wrtw8nds.cxx
index 4f3ca7f94305..6081ab30af1d 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -717,7 +717,8 @@ FlyProcessingState SwWW8AttrIter::OutFlys(sal_Int32 nSwPos)
 
 if (maFlyIter == maFlyFrames.end())
 {
-return FLY_NONE;
+// tdf#143039 postponed prevents fly duplication at end of paragraph
+return m_rExport.AttrOutput().IsFlyProcessingPostponed() ? 
FLY_POSTPONED : FLY_NONE;
 }
 
 /*

[Libreoffice-commits] core.git: cui/source framework/qa sw/qa tools/qa tools/source

2022-01-15 Thread Mike Kaganski (via logerrit)

 cui/source/dialogs/hlinettp.cxx   |8 --
 framework/qa/cppunit/services.cxx |   24 
 sw/qa/uitest/writer_tests3/hyperlinkdialog.py |   21 ++
 tools/qa/cppunit/test_urlobj.cxx  |   27 +++
 tools/source/fsys/urlobj.cxx  |   30 --
 5 files changed, 101 insertions(+), 9 deletions(-)

New commits:
commit 6b973753d407d66dfa5fda86547246c486ab7087
Author: Mike Kaganski 
AuthorDate: Sat Jan 15 11:33:10 2022 +0300
Commit: Mike Kaganski 
CommitDate: Sat Jan 15 10:52:56 2022 +0100

tdf#146754: consider xyz:123 as host:port when parsing URLs smart

... rather than scheme: and path.

Change-Id: I9a48310b585b8fa3e31635f877a91f1560b065f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128457
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/cui/source/dialogs/hlinettp.cxx b/cui/source/dialogs/hlinettp.cxx
index c26420d5703a..3a0f431acc17 100644
--- a/cui/source/dialogs/hlinettp.cxx
+++ b/cui/source/dialogs/hlinettp.cxx
@@ -158,13 +158,7 @@ OUString SvxHyperlinkInternetTp::CreateAbsoluteURL() const
 // erase leading and trailing whitespaces
 OUString aStrURL(m_xCbbTarget->get_active_text().trim());
 
-INetURLObject aURL(aStrURL);
-
-if( aURL.GetProtocol() == INetProtocol::NotValid )
-{
-aURL.SetSmartProtocol( GetSmartProtocolFromButtons() );
-aURL.SetSmartURL(aStrURL);
-}
+INetURLObject aURL(aStrURL, GetSmartProtocolFromButtons());
 
 // username and password for ftp-url
 if( aURL.GetProtocol() == INetProtocol::Ftp && 
!m_xEdLogin->get_text().isEmpty() )
diff --git a/framework/qa/cppunit/services.cxx 
b/framework/qa/cppunit/services.cxx
index c75ce9f65633..873ea5938e4c 100644
--- a/framework/qa/cppunit/services.cxx
+++ b/framework/qa/cppunit/services.cxx
@@ -14,6 +14,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -126,6 +127,29 @@ CPPUNIT_TEST_FIXTURE(Test, testLoadComponentFromURL)
 xThread->join();
 }
 }
+
+CPPUNIT_TEST_FIXTURE(Test, testURLTransformer_parseSmart)
+{
+// Without the accompanying fix in place, this test would have failed with
+// "www.example.com:" treated as scheme, "/8080/foo/" as path, "bar?q=baz"
+// as name, and "F" as fragment.
+
+css::util::URL aURL;
+aURL.Complete = "www.example.com:8080/foo/bar?q=baz#F";
+css::uno::Reference 
xParser(css::util::URLTransformer::create(mxComponentContext));
+CPPUNIT_ASSERT(xParser->parseSmart(aURL, "http:"));
+
CPPUNIT_ASSERT_EQUAL(OUString("http://www.example.com:8080/foo/bar?q=baz#F";), 
aURL.Complete);
+CPPUNIT_ASSERT_EQUAL(OUString("http://www.example.com:8080/foo/bar";), 
aURL.Main);
+CPPUNIT_ASSERT_EQUAL(OUString("http://";), aURL.Protocol);
+CPPUNIT_ASSERT(aURL.User.isEmpty());
+CPPUNIT_ASSERT(aURL.Password.isEmpty());
+CPPUNIT_ASSERT_EQUAL(OUString("www.example.com"), aURL.Server);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(8080), aURL.Port);
+CPPUNIT_ASSERT_EQUAL(OUString("/foo/"), aURL.Path);
+CPPUNIT_ASSERT_EQUAL(OUString("bar"), aURL.Name);
+CPPUNIT_ASSERT_EQUAL(OUString("q=baz"), aURL.Arguments);
+CPPUNIT_ASSERT_EQUAL(OUString("F"), aURL.Mark);
+}
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py 
b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
index c20a39b48f2a..c737f33ad1b8 100644
--- a/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
+++ b/sw/qa/uitest/writer_tests3/hyperlinkdialog.py
@@ -72,6 +72,27 @@ class HyperlinkDialog(UITestCase):
 self.assertEqual(get_state_as_dict(xedit)["SelectedText"], "link")
 
 
+def test_insert_hyperlink_without_scheme(self):
+
+with self.ui_test.create_doc_in_start_center("writer"):
+xMainWindow = self.xUITest.getTopFocusWindow()
+
+with 
self.ui_test.execute_dialog_through_command(".uno:HyperlinkDialog") as xDialog:
+
+# insert link
+xtab=xDialog.getChild("tabcontrol")
+select_pos(xtab, "0")
+
+xtarget = xDialog.getChild("target")
+xtarget.executeAction("TYPE", mkPropertyValues({"TEXT": 
"www.libreoffice.org:80"}))
+
+# Check that the link is added with http scheme
+xMainWindow = self.xUITest.getTopFocusWindow()
+xedit = xMainWindow.getChild("writer_edit")
+xedit.executeAction("SELECT", mkPropertyValues({"START_POS": "0", 
"END_POS": "29"}))
+self.assertEqual(get_state_as_dict(xedit)["SelectedText"], 
"http://www.libreoffice.org:80";)
+
+
 def test_tdf141166(self):
 # Skip this test for --with-help=html and --with-help=online, as that 
would fail with a
 # DialogNotExecutedException("did not execute a dialog for a blocking 
action") thrown from
diff --git a/tools/qa/cppunit/test_urlobj.cxx b/tools/qa/cppunit/test_urlobj.cxx
index

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/source

2022-01-15 Thread Noel Grandin (via logerrit)

 desktop/source/lib/init.cxx |   47 
 1 file changed, 47 insertions(+)

New commits:
commit 5cf9509a118e2daf9bf474bee8747d5d217f4f09
Author: Noel Grandin 
AuthorDate: Mon Jan 10 15:27:48 2022 +0200
Commit: Noel Grandin 
CommitDate: Sat Jan 15 10:48:53 2022 +0100

preload configmgr data for COOL

touch all the config data we need during LOK pre-init.
This means that most of the keys we need should become cached by
ConfigurationWrapper in comphelper.
Which means that the child processes we fork should be able to use the
shared pages and not allocate their own.

Change-Id: Iea8b1c4beaba67b6310b20cc161061ccf9a0db89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128247
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit 8de8abc5d26bfd0b3d7006d33a2231001ed77161)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128241
Tested-by: Jenkins CollaboraOffice 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 545e7182068e..dc3ff66ebd5c 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -177,6 +177,23 @@
 #include "lokclipboard.hxx"
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
 
 using namespace css;
 using namespace vcl;
@@ -6465,6 +6482,36 @@ static void preloadData()
 OutputDevice::GetDefaultFont(DefaultFontType::CTL_SPREADSHEET, nLang, 
GetDefaultFontFlags::OnlyOne);
 }
 
+std::cerr << "Preload config\n";
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-variable"
+#endif
+static SvtOptionsDialogOptions aDialogOptions;
+static SvtCTLOptions aSvtCTLOptions;
+static SvtAccessibilityOptions aSvtAccessibilityOptions;
+static svtools::ColorConfig aColorConfig;
+static SvtMiscOptions aSvtMiscOptions;
+static SvtSlideSorterBarOptions aSvtSlideSorterBarOptions;
+static SvtCommandOptions aSvtCommandOptions;
+static SvtCompatibilityOptions aSvtCompatibilityOptions;
+static SvtFilterOptions aSvtFilterOptions;
+static SvtLinguConfig aSvtLinguConfig;
+static SvtModuleOptions aSvtModuleOptions;
+static SvtPathOptions aSvtPathOptions;
+static SvtSearchOptions aSvtSearchOptions;
+static SvtSysLocaleOptions aSvtSysLocaleOptions;
+static SvtUserOptions aSvtUserOptions;
+//static SvtViewOptions aSvtViewOptions;
+static MouseSettings aMouseSettings;
+static StyleSettings aStyleSettings;
+static MiscSettings aMiscSettings;
+static HelpSettings aHelpSettings;
+static AllSettings aAllSettings;
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
+
 // Set user profile's path back to the original one
 rtl::Bootstrap::set("UserInstallation", sUserPath);
 }

[Libreoffice-commits] core.git: connectivity/source

2022-01-15 Thread Julien Nabet (via logerrit)

 connectivity/source/drivers/mysqlc/mysqlc_tables.cxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit be27b6f0bb73128ad4970fc5649c93d546822a84
Author: Julien Nabet 
AuthorDate: Sat Jan 15 09:29:12 2022 +0100
Commit: Julien Nabet 
CommitDate: Sat Jan 15 10:27:53 2022 +0100

Mysql/MariaDB: related:tdf#81430, fix regression drop table

Change-Id: I4b021847cfe855061b862006fbdc4ac36797ee09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128455
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx 
b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
index 9f150009baf0..36fb744ee5cc 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_tables.cxx
@@ -202,10 +202,7 @@ void Tables::dropObject(sal_Int32 nPosition, const 
OUString& sName)
 OUString sType;
 xTable->getPropertyValue("Type") >>= sType;
 
-const OUString sQuoteString = m_xMetaData->getIdentifierQuoteString();
-
-m_xMetaData->getConnection()->createStatement()->execute(
-"DROP " + sType + ::dbtools::quoteName(sQuoteString, sName));
+m_xMetaData->getConnection()->createStatement()->execute("DROP " + sType + 
" " + sName);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */

Re: How to get started with contribution

How to get started with contribution

Infra call on Tue, Jan 18 at 17:30 UTC

[Libreoffice-commits] core.git: extensions/source

[Libreoffice-commits] core.git: chart2/source

[Libreoffice-commits] core.git: connectivity/source

[Libreoffice-commits] core.git: framework/inc

[Libreoffice-commits] core.git: sc/qa

[Libreoffice-commits] core.git: bridges/source compilerplugins/clang forms/source include/com include/comphelper include/cppu include/cppuhelper include/oox include/registry lotuswordpro/source oox/so

[Libreoffice-commits] core.git: chart2/inc chart2/source

[Libreoffice-commits] core.git: chart2/inc chart2/IwyuFilter_chart2.yaml chart2/source offapi/com offapi/UnoApi_offapi.mk

[Libreoffice-commits] core.git: g

[Libreoffice-commits] core.git: sw/qa

[Libreoffice-commits] core.git: connectivity/source

Re: How to get started with contribution

Re: Want to contribute in your organisation

[Libreoffice-commits] core.git: sc/inc

[Libreoffice-commits] core.git: sc/uiconfig

[Libreoffice-commits] core.git: sc/uiconfig

[Libreoffice-commits] core.git: cui/source cui/uiconfig sc/qa sw/qa sw/uiconfig

Want to contribute in your organisation

How to get started with contribution

[Libreoffice-commits] core.git: connectivity/source

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

[Libreoffice-commits] core.git: cui/source framework/qa sw/qa tools/qa tools/source

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - desktop/source

[Libreoffice-commits] core.git: connectivity/source

27 matches

Site Navigation

Mail list logo

Footer information