[Libreoffice-commits] core.git: dbaccess/source

[Julien Nabet (via logerrit)]

 dbaccess/source/core/dataaccess/ModelImpl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5e80706dca6395dfac006cfc7009a2dfe388a46e
Author: Julien Nabet 
AuthorDate: Wed Jan 26 20:32:54 2022 +0100
Commit: Julien Nabet 
CommitDate: Thu Jan 27 08:36:54 2022 +0100

Avoid 
warn:dbaccess:828616:828616:dbaccess/source/core/dataaccess/ModelImpl.cxx

Just open an odb with embedded Firebird, browse tables panel and close LO
Full message:

warn:dbaccess:828616:828616:dbaccess/source/core/dataaccess/ModelImpl.cxx:923:
com.sun.star.container.NoSuchElementException message: 
"/home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974:
at /home/julien/lo/libreoffice/package/source/xstor/xstorage.cxx:2974"

Change-Id: Ibcea49b5ae28fd42cc1008c74f8cd5a9b7434068
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129009
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx 
b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index 49a74717e559..0a1ef938d53b 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -887,7 +887,7 @@ bool 
ODatabaseModelImpl::commitStorageIfWriteable_ignoreErrors( const Reference<
 
 uno::Reference xTargetMetaInf
 = _rxStorage->openStorageElement("META-INF", 
embed::ElementModes::READWRITE);
-if (xMetaInf.is() && xTargetMetaInf.is())
+if (xMetaInf.is() && xTargetMetaInf.is() && 
xMetaInf->hasByName(aScriptSignName))
 {
 xMetaInf->copyElementTo(aScriptSignName, xTargetMetaInf, 
aScriptSignName);
 

[Libreoffice-commits] core.git: sw/source

[Miklos Vajna (via logerrit)]

 sw/source/core/objectpositioning/anchoredobjectposition.cxx |6 
+-
 sw/source/core/objectpositioning/ascharanchoredobjectposition.cxx   |6 
+-
 sw/source/core/objectpositioning/environmentofanchoredobject.cxx|5 
-
 sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx  |4 +++-
 sw/source/core/objectpositioning/tolayoutanchoredobjectposition.cxx |5 
-
 5 files changed, 21 insertions(+), 5 deletions(-)

New commits:
commit 0a78f4dfb7889c3d4807c9320bc21d3d4f8dec6e
Author: Miklos Vajna 
AuthorDate: Wed Jan 26 20:21:15 2022 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 27 08:17:24 2022 +0100

sw: remove confusing 'using namespace objectpositioning' statements

The using namespace declaration implicitly put the
SwAnchoredObjectPosition definition into that namespace, but this is far
from obvious when reading the code.

Just put the definitions into the namespace, the way other code in sw/
does this.

Change-Id: I580c6bc5bb46a76364ddeeca021dd7b0e4369e42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129007
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/source/core/objectpositioning/anchoredobjectposition.cxx 
b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
index f8b153217455..e530e36df365 100644
--- a/sw/source/core/objectpositioning/anchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/anchoredobjectposition.cxx
@@ -40,7 +40,9 @@
 #include 
 
 using namespace ::com::sun::star;
-using namespace objectpositioning;
+
+namespace objectpositioning
+{
 
 SwAnchoredObjectPosition::SwAnchoredObjectPosition( SdrObject& _rDrawObj )
 : mrDrawObj( _rDrawObj ),
@@ -1139,4 +1141,6 @@ bool SwAnchoredObjectPosition::Minor_( sal_Int16 
_eRelOrient1,
 return bRetVal;
 }
 
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/objectpositioning/ascharanchoredobjectposition.cxx 
b/sw/source/core/objectpositioning/ascharanchoredobjectposition.cxx
index b78cadaf1549..e82659ccd59f 100644
--- a/sw/source/core/objectpositioning/ascharanchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/ascharanchoredobjectposition.cxx
@@ -32,7 +32,9 @@
 
 
 using namespace ::com::sun::star;
-using namespace objectpositioning;
+
+namespace objectpositioning
+{
 
 /** constructor */
 SwAsCharAnchoredObjectPosition::SwAsCharAnchoredObjectPosition(
@@ -391,4 +393,6 @@ SwTwips SwAsCharAnchoredObjectPosition::GetRelPosToBase(
 return nRelPosToBase;
 }
 
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/objectpositioning/environmentofanchoredobject.cxx 
b/sw/source/core/objectpositioning/environmentofanchoredobject.cxx
index 79cb7b14eef3..9588e2b4ac2d 100644
--- a/sw/source/core/objectpositioning/environmentofanchoredobject.cxx
+++ b/sw/source/core/objectpositioning/environmentofanchoredobject.cxx
@@ -22,7 +22,8 @@
 #include 
 #include 
 
-using namespace objectpositioning;
+namespace objectpositioning
+{
 
 SwEnvironmentOfAnchoredObject::SwEnvironmentOfAnchoredObject(
 const bool   _bFollowTextFlow )
@@ -96,4 +97,6 @@ const SwLayoutFrame& 
SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFram
 return static_cast(*pVertEnvironmentLayFrame);
 }
 
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx 
b/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx
index a5ea2bf7e43f..700b737b1689 100644
--- a/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/tocntntanchoredobjectposition.cxx
@@ -42,9 +42,10 @@
 #include 
 #include 
 
-using namespace objectpositioning;
 using namespace ::com::sun::star;
 
+namespace objectpositioning
+{
 SwToContentAnchoredObjectPosition::SwToContentAnchoredObjectPosition( 
SdrObject& _rDrawObj )
 : SwAnchoredObjectPosition ( _rDrawObj ),
   mpVertPosOrientFrame( nullptr ),
@@ -1211,5 +1212,6 @@ const SwFrame& 
SwToContentAnchoredObjectPosition::GetHoriVirtualAnchor(
 return *pHoriVirtAnchFrame;
 }
 
+}
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git 
a/sw/source/core/objectpositioning/tolayoutanchoredobjectposition.cxx 
b/sw/source/core/objectpositioning/tolayoutanchoredobjectposition.cxx
index 371a3b0536a1..3e7d98bf7aaa 100644
--- a/sw/source/core/objectpositioning/tolayoutanchoredobjectposition.cxx
+++ b/sw/source/core/objectpositioning/tolayoutanchoredobjectposition.cxx
@@ -33,9 +33,10 @@
 #include 
 #include 
 
-using namespace objectpositioning;
 using namespace ::com::sun::star;
 
+namespace objectpositioning
+{
 SwToLayoutAnchoredObjectPosition::SwToLayoutAnchoredObjectPosition( SdrObject& 
_rDrawObj )
 : SwAnchoredObjectPosition( _rDrawObj )
 {}
@@ -220,4 +221,6 @@ void SwToLayoutAnchoredObjectPosition::CalcPosition()
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter2.cxx  |   36 +++
 sw/source/uibase/dochdl/swdtflvr.cxx |7 +-
 2 files changed, 42 insertions(+), 1 deletion(-)

New commits:
commit 29233e10f00af0af132849485648664aadefd456
Author: László Németh 
AuthorDate: Wed Jan 26 13:44:39 2022 +0100
Commit: László Németh 
CommitDate: Thu Jan 27 08:15:41 2022 +0100

tdf#146966 sw: fix inserting empty rows at copying multiple rows

HTML expansion of the clipboard content is used to calculate the
row number of the table on the clipboard. Skip its empty 
elements here, similar to Paste As HTML in Edit->Paste Special->
Paste Special... to avoid inserting empty rows (e.g. selecting and
copying/moving 4 rows inserted 30 extra empty rows).

Note: likely this was a regression, related to the new empty
rows in the clipboard/expansion code.

Change-Id: I58b16c7869c08cda7e2a2c21c3c03bf38446d826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128986
Tested-by: Jenkins
Reviewed-by: László Németh 
(cherry picked from commit 6ad9a3d74ef6eae3e645df12dedbe059acc180c4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128959

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index fea93243bdc8..79aa517c66f4 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -5156,6 +5156,42 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, 
testPasteTrackedTableRowInHideChangesMode)
 CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable->getRows()->getCount());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf146966)
+{
+// load a 4-row table, select more than 1 row and copy them
+// to check insertion of unnecessary empty rows
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf144748.fodt");
+
+// check table row count
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTextTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables->getCount());
+uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+
+// copy table row and paste it by Paste Special->Rows Above
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Down(/*bSelect=*/false);
+dispatchCommand(mxComponent, ".uno:SelectTable", {});
+dispatchCommand(mxComponent, ".uno:Copy", {});
+dispatchCommand(mxComponent, ".uno:Escape", {});
+dispatchCommand(mxComponent, ".uno:PasteRowsBefore", {});
+
+// This was 35 (extra empty rows)
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), xTable->getRows()->getCount());
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+dispatchCommand(mxComponent, ".uno:Undo", {});
+dispatchCommand(mxComponent, ".uno:Undo", {}); // FIXME Why 3 Undos?
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+
+dispatchCommand(mxComponent, ".uno:Redo", {});
+dispatchCommand(mxComponent, ".uno:Redo", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), xTable->getRows()->getCount());
+// dispatchCommand(mxComponent, ".uno:Redo", {}); // FIXME assert
+}
+
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf145091)
 {
 // load a deleted table, reject them, and delete only its text and export 
to DOCX
diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx 
b/sw/source/uibase/dochdl/swdtflvr.cxx
index ea95471b8a59..ddc47cda43e4 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -1576,8 +1576,13 @@ bool SwTransferable::Paste(SwWrtShell& rSh, 
TransferableDataHelper& rData, RndSt
 while((nIdx = aExpand.indexOf(sSearchRowOrCol, nIdx)) > -1)
 {
 // skip rows/columns of nested tables, based on HTML 
indentation
-if (nIdx > 2 && (aExpand[nIdx-1] != '\t' || aExpand[nIdx-2] != 
'\t' || (bShifted && aExpand[nIdx-3] != '\t')))
+if ( nIdx > 3 && (aExpand[nIdx-1] != '\t' || aExpand[nIdx-2] 
!= '\t' ||
+( bShifted && aExpand[nIdx-3] != '\t') ) &&
+// skip also strange hidden empty rows 
+!aExpand.match("", nIdx - 4) )
+{
 ++nSelectedRowsOrCols;
+}
 ++nIdx;
 }
 // are we at the beginning of the cell?

[Libreoffice-commits] core.git: external/mdds

[Stephan Bergmann (via logerrit)]

 external/mdds/UnpackedTarball_mdds.mk |1 +
 external/mdds/use-after-free.patch|   12 
 2 files changed, 13 insertions(+)

New commits:
commit a6f21bc32e746fd89ce963b1567ef78315612669
Author: Stephan Bergmann 
AuthorDate: Wed Jan 26 20:16:02 2022 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 27 08:00:48 2022 +0100

external/mdds: Avoid -Werror=use-after-free (GCC 12 trunk)

> In file included from 
workdir/UnpackedTarball/mdds/include/mdds/flat_segment_tree.hpp:37,
>  from sc/inc/columnspanset.hxx:16,
>  from sc/source/core/data/columnspanset.cxx:10:
> In function ‘void mdds::__st::intrusive_ptr_add_ref(node*) [with T = 
mdds::flat_segment_tree]’,
> inlined from ‘boost::intrusive_ptr::intrusive_ptr(const 
boost::intrusive_ptr&) [with T = 
mdds::__st::node >]’ at 
workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:93:44,
> inlined from ‘boost::intrusive_ptr& 
boost::intrusive_ptr::operator=(const boost::intrusive_ptr&) [with T = 
mdds::__st::node >]’ at 
workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:154:9,
> inlined from ‘mdds::flat_segment_tree<_Key, 
_Value>::flat_segment_tree(const mdds::flat_segment_tree<_Key, _Value>&) [with 
_Key = int; _Value = bool]’ at 
workdir/UnpackedTarball/mdds/include/mdds/flat_segment_tree_def.inl:88:25:
> workdir/UnpackedTarball/mdds/include/mdds/node.hpp:244:10: error: pointer 
used after ‘void operator delete(void*, std::size_t)’ [-Werror=use-after-free]
>   244 | ++p->refcount;
>   |   ~~~^~~~
> In function ‘void mdds::__st::intrusive_ptr_release(node*) [with T = 
mdds::flat_segment_tree]’,
> inlined from ‘void mdds::__st::intrusive_ptr_release(node*) [with 
T = mdds::flat_segment_tree]’ at 
workdir/UnpackedTarball/mdds/include/mdds/node.hpp:248:13,
> inlined from ‘boost::intrusive_ptr::~intrusive_ptr() [with T = 
mdds::__st::node >]’ at 
workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:98:44,
> inlined from ‘boost::intrusive_ptr& 
boost::intrusive_ptr::operator=(const boost::intrusive_ptr&) [with T = 
mdds::__st::node >]’ at 
workdir/UnpackedTarball/boost/boost/smart_ptr/intrusive_ptr.hpp:154:9,
> inlined from ‘mdds::flat_segment_tree<_Key, 
_Value>::flat_segment_tree(const mdds::flat_segment_tree<_Key, _Value>&) [with 
_Key = int; _Value = bool]’ at 
workdir/UnpackedTarball/mdds/include/mdds/flat_segment_tree_def.inl:87:19:
> workdir/UnpackedTarball/mdds/include/mdds/node.hpp:252:9: note: call to 
‘void operator delete(void*, std::size_t)’ here
>   252 | delete p;
>   | ^~~~

etc.  The warning is apparently new in GCC 12 trunk (see


"Add -Wuse-after-free [PR80532]"), and I'm not entirely sure whether this
is a true or false positive, but the fix looks somewhat plausible, and at 
least
also my (Clang) ASan+UBSan build does a successful `make check` with (and
without) this change.

Change-Id: I63fafceba8d1b4e0ddd7cf2e58403a3bc763e53c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129008
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/mdds/UnpackedTarball_mdds.mk 
b/external/mdds/UnpackedTarball_mdds.mk
index c015f4c13f5a..271d20b0f4d1 100644
--- a/external/mdds/UnpackedTarball_mdds.mk
+++ b/external/mdds/UnpackedTarball_mdds.mk
@@ -14,6 +14,7 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,mdds,$(MDDS_TARBALL)))
 $(eval $(call gb_UnpackedTarball_set_patchlevel,mdds,0))
 
 $(eval $(call gb_UnpackedTarball_add_patches,mdds,\
+external/mdds/use-after-free.patch \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/mdds/use-after-free.patch 
b/external/mdds/use-after-free.patch
new file mode 100644
index ..981c945821a7
--- /dev/null
+++ b/external/mdds/use-after-free.patch
@@ -0,0 +1,12 @@
+--- include/mdds/flat_segment_tree_def.inl
 include/mdds/flat_segment_tree_def.inl
+@@ -84,8 +84,8 @@
+ // Move on to the next destination node, and have the next node point
+ // back to the previous node.
+ node_ptr old_node = dest_node;
++dest_node->next->prev = old_node;
+ dest_node = dest_node->next;
+-dest_node->prev = old_node;
+ 
+ if (src_node == r.m_right_leaf.get())
+ {

[Libreoffice-commits] core.git: chart2/source

[Noel Grandin (via logerrit)]

 chart2/source/inc/ObjectIdentifier.hxx   |3 ++-
 chart2/source/tools/ObjectIdentifier.cxx |   11 +--
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit e82192764485e7599af43c002d658b7b15c01f94
Author: Noel Grandin 
AuthorDate: Wed Jan 26 18:50:07 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Jan 27 07:41:05 2022 +0100

use more concrete types in chart2, BaseCoordinateSystem

Change-Id: Icc1579520ae98efdd4191530e5f046555baad99e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129001
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/inc/ObjectIdentifier.hxx 
b/chart2/source/inc/ObjectIdentifier.hxx
index f4ba59a2191c..3410476083d9 100644
--- a/chart2/source/inc/ObjectIdentifier.hxx
+++ b/chart2/source/inc/ObjectIdentifier.hxx
@@ -42,6 +42,7 @@ namespace com::sun::star::uno { class XInterface; }
 
 namespace chart
 {
+class BaseCoordinateSystem;
 class Diagram;
 
 enum ObjectType
@@ -124,7 +125,7 @@ public:
 SAL_DLLPRIVATE static OUString createParticleForDiagram();
 
 static OUString createParticleForCoordinateSystem(
-  const css::uno::Reference< css::chart2::XCoordinateSystem >& xCooSys
+  const rtl::Reference< ::chart::BaseCoordinateSystem >& xCooSys
 , const rtl::Reference<::chart::ChartModel>& xChartModel );
 
 static OUString createParticleForAxis(
diff --git a/chart2/source/tools/ObjectIdentifier.cxx 
b/chart2/source/tools/ObjectIdentifier.cxx
index 5d17de7ac5aa..691e7f475c26 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -327,7 +327,7 @@ OUString 
ObjectIdentifier::createClassifiedIdentifierForObject(
 Reference< XAxis > xAxis( xObject, uno::UNO_QUERY );
 if( xAxis.is() )
 {
-Reference< XCoordinateSystem > xCooSys( 
AxisHelper::getCoordinateSystemOfAxis( xAxis, ChartModelHelper::findDiagram( 
xChartModel ) ) );
+rtl::Reference< BaseCoordinateSystem > xCooSys( 
AxisHelper::getCoordinateSystemOfAxis( xAxis, ChartModelHelper::findDiagram( 
xChartModel ) ) );
 OUString aCooSysParticle( createParticleForCoordinateSystem( 
xCooSys, xChartModel ) );
 sal_Int32 nDimensionIndex=-1;
 sal_Int32 nAxisIndex=-1;
@@ -414,7 +414,7 @@ OUString ObjectIdentifier::createParticleForDiagram()
 }
 
 OUString ObjectIdentifier::createParticleForCoordinateSystem(
-  const Reference< XCoordinateSystem >& xCooSys
+  const rtl::Reference< BaseCoordinateSystem >& xCooSys
 , const rtl::Reference<::chart::ChartModel>& xChartModel )
 {
 OUString aRet;
@@ -423,11 +423,10 @@ OUString 
ObjectIdentifier::createParticleForCoordinateSystem(
 if( xDiagram.is() )
 {
 sal_Int32 nCooSysIndex = 0;
-uno::Sequence< Reference< XCoordinateSystem > > aCooSysList( 
xDiagram->getCoordinateSystems() );
-for( ; nCooSysIndex < aCooSysList.getLength(); ++nCooSysIndex )
+const std::vector< rtl::Reference< BaseCoordinateSystem > > & 
aCooSysList( xDiagram->getBaseCoordinateSystems() );
+for( ; nCooSysIndex < static_cast(aCooSysList.size()); 
++nCooSysIndex )
 {
-Reference< XCoordinateSystem > xCurrentCooSys( 
aCooSysList[nCooSysIndex] );
-if( xCooSys == xCurrentCooSys )
+if( xCooSys == aCooSysList[nCooSysIndex] )
 {
 aRet = ObjectIdentifier::createParticleForDiagram() + ":CS=" + 
OUString::number( nCooSysIndex );
 break;

[Libreoffice-commits] core.git: 2 commits - chart2/source

[Noel Grandin (via logerrit)]

 chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx |2 +-
 chart2/source/controller/inc/ObjectHierarchy.hxx|2 +-
 chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx   |8 
 chart2/source/controller/main/ObjectHierarchy.cxx   |8 +++-
 chart2/source/inc/chartview/ExplicitValueProvider.hxx   |5 +++--
 chart2/source/view/main/ChartView.cxx   |2 +-
 6 files changed, 13 insertions(+), 14 deletions(-)

New commits:
commit 93933e5f4ec1d8109717f89deb4029a8472d17ff
Author: Noel Grandin 
AuthorDate: Wed Jan 26 18:35:01 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Jan 27 07:40:50 2022 +0100

use more concrete types in chart2, BaseCoordinateSystem

Change-Id: I98890707708f2b6161e52ef5c1563cceb6e3e56a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129000
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx 
b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
index ea2b0413afd4..4d85f5c0c493 100644
--- a/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
+++ b/chart2/source/controller/chartapiwrapper/Chart2ModelContact.cxx
@@ -153,7 +153,7 @@ void Chart2ModelContact::getExplicitValuesForAxis(
 sal_Int32 Chart2ModelContact::getExplicitNumberFormatKeyForAxis(
 const Reference< chart2::XAxis >& xAxis )
 {
-Reference< chart2::XCoordinateSystem > xCooSys(
+rtl::Reference< BaseCoordinateSystem > xCooSys(
 AxisHelper::getCoordinateSystemOfAxis(
   xAxis, ChartModelHelper::findDiagram( m_xChartModel ) ) );
 
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx 
b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
index bc09b1bda1b9..878f3bc4f247 100644
--- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
@@ -404,7 +404,7 @@ void AxisItemConverter::FillSpecialItem( sal_uInt16 
nWhichId, SfxItemSet & rOutI
 {
 if( m_pExplicitScale )
 {
-Reference< chart2::XCoordinateSystem > xCooSys(
+rtl::Reference< BaseCoordinateSystem > xCooSys(
 AxisHelper::getCoordinateSystemOfAxis(
   m_xAxis, ChartModelHelper::findDiagram( 
m_xChartDoc ) ) );
 
@@ -941,9 +941,9 @@ bool AxisItemConverter::ApplySpecialItem( sal_uInt16 
nWhichId, const SfxItemSet
 }
 else
 {
-Reference< chart2::XCoordinateSystem > xCooSys(
-AxisHelper::getCoordinateSystemOfAxis(
-  m_xAxis, ChartModelHelper::findDiagram( 
m_xChartDoc ) ) );
+rtl::Reference< BaseCoordinateSystem > xCooSys =
+AxisHelper::getCoordinateSystemOfAxis(
+m_xAxis, ChartModelHelper::findDiagram( 
m_xChartDoc ) );
 
 sal_Int32 nFormatKey = 
ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
 m_xAxis, xCooSys, m_xChartDoc);
diff --git a/chart2/source/inc/chartview/ExplicitValueProvider.hxx 
b/chart2/source/inc/chartview/ExplicitValueProvider.hxx
index 174f060161ba..e77df0ddcf3d 100644
--- a/chart2/source/inc/chartview/ExplicitValueProvider.hxx
+++ b/chart2/source/inc/chartview/ExplicitValueProvider.hxx
@@ -41,8 +41,9 @@ namespace com::sun::star::util { class 
XNumberFormatsSupplier; }
 
 namespace chart
 {
-
+class BaseCoordinateSystem;
 class DrawModelWrapper;
+
 class OOO_DLLPUBLIC_CHARTVIEW ExplicitValueProvider
 {
 public:
@@ -78,7 +79,7 @@ public:
 
 static sal_Int32 getExplicitNumberFormatKeyForAxis(
   const css::uno::Reference< css::chart2::XAxis >& xAxis
-, const css::uno::Reference< css::chart2::XCoordinateSystem > & 
xCorrespondingCoordinateSystem
+, const rtl::Reference< ::chart::BaseCoordinateSystem > & 
xCorrespondingCoordinateSystem
 , const rtl::Reference<::chart::ChartModel>& xChartDoc);
 
 static sal_Int32 getExplicitNumberFormatKeyForDataLabel(
diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 2c4fc46ef62b..e9a8995fb6e0 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -1805,7 +1805,7 @@ bool lcl_getPropertySwapXAndYAxis( const rtl::Reference< 
Diagram >& xDiagram )
 
 sal_Int32 ExplicitValueProvider::getExplicitNumberFormatKeyForAxis(
   const Reference< chart2::XAxis >& xAxis
-, const Reference< chart2::XCoordinateSystem > & 
xCorrespondingCoordinateSystem
+, const rtl::Reference< ::chart::BaseCoordinateSystem > & 
xCorrespondingCoordinateSystem
 , const 

[Libreoffice-commits] core.git: sc/qa

[Tomaž Vajngerl (via logerrit)]

 sc/qa/extras/vba-macro-test.cxx |  166 
 1 file changed, 166 insertions(+)

New commits:
commit 9a46a203515779ae40b7cfac36dbc22990e23290
Author: Tomaž Vajngerl 
AuthorDate: Wed Jan 26 16:54:12 2022 +0900
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 27 07:38:21 2022 +0100

vba: add tests for scrolling, range selecting, print area

This adds various tests involving scrolling to a particular cell
in the document, selecting whole ranges or ranges o filled cells
and setting the print area.

VBA functions:
ActiveWindow.ScrollColumn
ActiveWindow.ScrollRow
Selection
Selection.End(xlToRight)
ActiveSheet.PageSetup.PrintArea

Change-Id: Iacde9c513b41571e98234c12cc3b42a16de4b833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129014
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/sc/qa/extras/vba-macro-test.cxx b/sc/qa/extras/vba-macro-test.cxx
index 51d8c36cbded..ac93cf181d0b 100644
--- a/sc/qa/extras/vba-macro-test.cxx
+++ b/sc/qa/extras/vba-macro-test.cxx
@@ -21,6 +21,8 @@
 #include 
 
 #include 
+#include 
+#include 
 
 using namespace css;
 
@@ -48,7 +50,11 @@ public:
 void testSimpleCopyAndPaste();
 void testMultiDocumentCopyAndPaste();
 void testSheetAndColumnSelectAndHide();
+void testPrintArea();
+void testSelectAllChaged();
+void testRangeSelect();
 void testWindowState();
+void testScroll();
 
 void testVba();
 void testTdf107885();
@@ -60,7 +66,11 @@ public:
 CPPUNIT_TEST(testSimpleCopyAndPaste);
 CPPUNIT_TEST(testMultiDocumentCopyAndPaste);
 CPPUNIT_TEST(testSheetAndColumnSelectAndHide);
+CPPUNIT_TEST(testPrintArea);
+CPPUNIT_TEST(testSelectAllChaged);
+CPPUNIT_TEST(testRangeSelect);
 CPPUNIT_TEST(testWindowState);
+CPPUNIT_TEST(testScroll);
 
 CPPUNIT_TEST(testVba);
 CPPUNIT_TEST(testTdf107885);
@@ -233,6 +243,126 @@ void VBAMacroTest::testSheetAndColumnSelectAndHide()
 CPPUNIT_ASSERT_EQUAL(SCTAB(0), rViewData.GetTabNo());
 }
 
+void VBAMacroTest::testPrintArea()
+{
+// Sets the print area to A1:B5
+// ActiveSheet.PageSetup.PrintArea = "$A$1:$B$5"
+
+OUString aFileName;
+createFileURL(u"VariousTestMacros.xlsm", aFileName);
+mxComponent = loadFromDesktop(aFileName, 
"com.sun.star.sheet.SpreadsheetDocument");
+
+SfxObjectShell* pFoundShell = 
SfxObjectShell::GetShellFromComponent(mxComponent);
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+
+uno::Reference xDoc(mxComponent, 
uno::UNO_QUERY_THROW);
+uno::Reference xIndex(xDoc->getSheets(), 
uno::UNO_QUERY_THROW);
+uno::Reference xSheet(xIndex->getByIndex(0), 
uno::UNO_QUERY_THROW);
+uno::Reference xPrintAreas(xSheet, 
uno::UNO_QUERY_THROW);
+
+{
+const uno::Sequence aSequence = 
xPrintAreas->getPrintAreas();
+CPPUNIT_ASSERT_EQUAL(false, aSequence.hasElements());
+}
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testPrintArea?"
+"language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+{
+const uno::Sequence aSequence = 
xPrintAreas->getPrintAreas();
+CPPUNIT_ASSERT_EQUAL(true, aSequence.hasElements());
+}
+}
+
+void VBAMacroTest::testSelectAllChaged()
+{
+// Columns("A:A").Select
+// Range(Selection, Selection.End(xlToRight)).Select
+
+OUString aFileName;
+createFileURL(u"VariousTestMacros.xlsm", aFileName);
+mxComponent = loadFromDesktop(aFileName, 
"com.sun.star.sheet.SpreadsheetDocument");
+
+SfxObjectShell* pFoundShell = 
SfxObjectShell::GetShellFromComponent(mxComponent);
+CPPUNIT_ASSERT_MESSAGE("Failed to access document shell", pFoundShell);
+
+ScDocShell* pDocSh = static_cast(pFoundShell);
+ScTabViewShell* pView = pDocSh->GetBestViewShell(false);
+CPPUNIT_ASSERT(pView != nullptr);
+auto const& pViewData = pView->GetViewData();
+
+{
+ScRange aRange;
+pViewData.GetMarkData().GetMarkArea(aRange);
+CPPUNIT_ASSERT_EQUAL(ScRange(), aRange);
+}
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testSelectAll?"
+"language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+{
+ScRange aRange;
+pViewData.GetMarkData().GetMarkArea(aRange);
+// A1:E1048576
+CPPUNIT_ASSERT_EQUAL(ScRange(0, 0, 0, 4, MAXROW, 0), aRange);
+}
+}
+
+void VBAMacroTest::testRangeSelect()
+{
+// 

[Libreoffice-commits] core.git: 2 commits - oovbaapi/ooo sc/qa sc/source

[Tomaž Vajngerl (via logerrit)]

 oovbaapi/ooo/vba/excel/XApplication.idl |1 
 sc/qa/extras/testdocuments/SheetAndColumnSelectAndHide.xlsm |binary
 sc/qa/extras/testdocuments/VariousTestMacros.xlsm   |binary
 sc/qa/extras/vba-macro-test.cxx |  101 
 sc/source/ui/vba/vbaapplication.cxx |   10 +
 sc/source/ui/vba/vbaapplication.hxx |2 
 6 files changed, 114 insertions(+)

New commits:
commit 93806a2831c93154981e3a6ef933270d0d5a6021
Author: Tomaž Vajngerl 
AuthorDate: Wed Jan 26 16:50:41 2022 +0900
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 27 07:38:09 2022 +0100

vba: add support for Application.WindowState + test

This just delegates the get/set calls to ActiveWindow.WindowState
which is already supported, but calling it directly on Application
is also possible.

Change-Id: Ibf6f55581a5c66a47ec4dd21cc8d0fe3558330ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129013
Tested-by: Tomaž Vajngerl 
Reviewed-by: Tomaž Vajngerl 

diff --git a/oovbaapi/ooo/vba/excel/XApplication.idl 
b/oovbaapi/ooo/vba/excel/XApplication.idl
index b1bcf46336be..ab6f79655696 100644
--- a/oovbaapi/ooo/vba/excel/XApplication.idl
+++ b/oovbaapi/ooo/vba/excel/XApplication.idl
@@ -47,6 +47,7 @@ interface XApplication
 [attribute] boolean DisplayFormulaBar;
 [attribute] any CutCopyMode;
 [attribute] any StatusBar;
+[attribute] any WindowState;
 [attribute] long Cursor;
 [attribute] boolean EnableEvents;
 [attribute] boolean EnableCancelKey;
diff --git a/sc/qa/extras/testdocuments/VariousTestMacros.xlsm 
b/sc/qa/extras/testdocuments/VariousTestMacros.xlsm
new file mode 100644
index ..455dad654eea
Binary files /dev/null and b/sc/qa/extras/testdocuments/VariousTestMacros.xlsm 
differ
diff --git a/sc/qa/extras/vba-macro-test.cxx b/sc/qa/extras/vba-macro-test.cxx
index 89639ceb1863..51d8c36cbded 100644
--- a/sc/qa/extras/vba-macro-test.cxx
+++ b/sc/qa/extras/vba-macro-test.cxx
@@ -48,6 +48,8 @@ public:
 void testSimpleCopyAndPaste();
 void testMultiDocumentCopyAndPaste();
 void testSheetAndColumnSelectAndHide();
+void testWindowState();
+
 void testVba();
 void testTdf107885();
 void testTdf131562();
@@ -58,6 +60,7 @@ public:
 CPPUNIT_TEST(testSimpleCopyAndPaste);
 CPPUNIT_TEST(testMultiDocumentCopyAndPaste);
 CPPUNIT_TEST(testSheetAndColumnSelectAndHide);
+CPPUNIT_TEST(testWindowState);
 
 CPPUNIT_TEST(testVba);
 CPPUNIT_TEST(testTdf107885);
@@ -230,6 +233,27 @@ void VBAMacroTest::testSheetAndColumnSelectAndHide()
 CPPUNIT_ASSERT_EQUAL(SCTAB(0), rViewData.GetTabNo());
 }
 
+void VBAMacroTest::testWindowState()
+{
+// Application.WindowState = xlMinimized
+// Application.WindowState = xlMaximized
+// Application.WindowState = xlNormal
+
+OUString aFileName;
+createFileURL(u"VariousTestMacros.xlsm", aFileName);
+mxComponent = loadFromDesktop(aFileName, 
"com.sun.star.sheet.SpreadsheetDocument");
+
+uno::Any aRet;
+uno::Sequence aOutParamIndex;
+uno::Sequence aOutParam;
+uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(mxComponent,
+
"vnd.sun.Star.script:VBAProject.ThisWorkbook.testWindowState?"
+"language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+}
+
 void VBAMacroTest::testVba()
 {
 TestMacroInfo testInfo[] = {
diff --git a/sc/source/ui/vba/vbaapplication.cxx 
b/sc/source/ui/vba/vbaapplication.cxx
index f518f4a82293..f11ee6f21bbe 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -488,6 +488,16 @@ ScVbaApplication::getStatusBar()
 return uno::makeAny( !getDisplayStatusBar() );
 }
 
+css::uno::Any SAL_CALL ScVbaApplication::getWindowState()
+{
+return getActiveWindow()->getWindowState();
+}
+
+void SAL_CALL ScVbaApplication::setWindowState(const css::uno::Any& 
rWindowState)
+{
+getActiveWindow()->setWindowState(rWindowState);
+}
+
 void SAL_CALL
 ScVbaApplication::setStatusBar( const uno::Any& _statusbar )
 {
diff --git a/sc/source/ui/vba/vbaapplication.hxx 
b/sc/source/ui/vba/vbaapplication.hxx
index 09d2b02d3b59..db9c91cdd677 100644
--- a/sc/source/ui/vba/vbaapplication.hxx
+++ b/sc/source/ui/vba/vbaapplication.hxx
@@ -109,6 +109,8 @@ public:
 virtual void SAL_CALL setCutCopyMode( const css::uno::Any& _cutcopymode ) 
override;
 virtual css::uno::Any SAL_CALL getStatusBar() override;
 virtual void SAL_CALL setStatusBar( const css::uno::Any& _statusbar ) 
override;
+virtual css::uno::Any SAL_CALL getWindowState() override;
+virtual void SAL_CALL setWindowState(const css::uno::Any& rWindowState) 
override;
 virtual ::sal_Int32 SAL_CALL getCursor() override;
 virtual void SAL_CALL setCursor( ::sal_Int32 _cursor ) override;
 virtual void SAL_CALL OnKey( 

[Libreoffice-commits] core.git: sc/inc sc/qa sc/source

[Samuel Mehrbrodt (via logerrit)]

 sc/inc/dbdata.hxx   |2 +
 sc/inc/document.hxx |2 -
 sc/qa/unit/data/xlsx/tdf145054.xlsx |binary
 sc/qa/unit/subsequent_filters_test2.cxx |   18 
 sc/source/core/data/documen2.cxx|1 
 sc/source/core/tool/dbdata.cxx  |   47 
 6 files changed, 69 insertions(+), 1 deletion(-)

New commits:
commit d9472a5284fde7bb96823655efcb6eb31f405493
Author: Samuel Mehrbrodt 
AuthorDate: Thu Dec 16 11:50:01 2021 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Thu Jan 27 07:32:39 2022 +0100

tdf#145054 Copy named DBs too when copying sheet

Change-Id: I5bf75a7188532776e70c7af64e88371638d76335
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126916
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index f12ba3fb976d..0e8d53830e53 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -256,6 +256,7 @@ public:
 ScDBData* findByIndex(sal_uInt16 nIndex);
 ScDBData* findByUpperName(const OUString& rName);
 iterator findByUpperName2(const OUString& rName);
+ScDBData* findByName(const OUString& rName);
 
 /** Takes ownership of p and attempts to insert it into the collection.
 Deletes p if it could not be inserted, i.e. duplicate name.
@@ -333,6 +334,7 @@ public:
 SCCOL nCol2, SCROW nRow2, SCTAB nTab2,
 SCCOL nDx, SCROW nDy, SCTAB nDz);
 voidUpdateMoveTab( SCTAB nOldPos, SCTAB nNewPos );
+voidCopyToTable(SCTAB nOldPos, SCTAB nNewPos);
 
 voidSetRefreshHandler( const Link& rLink )
 { aRefreshHandler = rLink; }
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index fa13b7b890e4..85c6829b4a54 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -957,7 +957,7 @@ public:
 SC_DLLPUBLIC bool   RenameTab( SCTAB nTab, const OUString& rName,
bool bExternalDocument = false );
 boolMoveTab( SCTAB nOldPos, SCTAB nNewPos, 
ScProgress* pProgress = nullptr );
-boolCopyTab( SCTAB nOldPos, SCTAB nNewPos,
+SC_DLLPUBLIC bool   CopyTab( SCTAB nOldPos, SCTAB nNewPos,
  const ScMarkData* pOnlyMarked = 
nullptr );
 SC_DLLPUBLIC sal_uLong  TransferTab(ScDocument& rSrcDoc, SCTAB 
nSrcPos, SCTAB nDestPos,
 bool bInsertNew = true,
diff --git a/sc/qa/unit/data/xlsx/tdf145054.xlsx 
b/sc/qa/unit/data/xlsx/tdf145054.xlsx
new file mode 100644
index ..8360ec7e92be
Binary files /dev/null and b/sc/qa/unit/data/xlsx/tdf145054.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters_test2.cxx 
b/sc/qa/unit/subsequent_filters_test2.cxx
index 4852c1006b13..90a6a11d36d8 100644
--- a/sc/qa/unit/subsequent_filters_test2.cxx
+++ b/sc/qa/unit/subsequent_filters_test2.cxx
@@ -131,6 +131,7 @@ public:
 void testVBAUserFunctionXLSM();
 void testEmbeddedImageXLS();
 void testErrorOnExternalReferences();
+void testTdf145054();
 void testTdf84762();
 void testTdf44076();
 void testEditEngStrikeThroughXLSX();
@@ -239,6 +240,7 @@ public:
 CPPUNIT_TEST(testVBAUserFunctionXLSM);
 CPPUNIT_TEST(testEmbeddedImageXLS);
 CPPUNIT_TEST(testErrorOnExternalReferences);
+CPPUNIT_TEST(testTdf145054);
 CPPUNIT_TEST(testTdf84762);
 CPPUNIT_TEST(testTdf44076);
 CPPUNIT_TEST(testEditEngStrikeThroughXLSX);
@@ -1047,6 +1049,22 @@ void ScFiltersTest2::testErrorOnExternalReferences()
 xDocSh->DoClose();
 }
 
+void ScFiltersTest2::testTdf145054()
+{
+ScDocShellRef xDocSh = loadDoc(u"tdf145054.", FORMAT_XLSX);
+CPPUNIT_ASSERT(xDocSh.is());
+
+ScDocument& rDoc = xDocSh->GetDocument();
+
+// Copy sheet
+rDoc.CopyTab(0, 1);
+CPPUNIT_ASSERT_EQUAL(SCTAB(2), rDoc.GetTableCount());
+
+// Make sure named DB was copied
+ScDBData* pDBData = 
rDoc.GetDBCollection()->getNamedDBs().findByName("__Anonymous_Sheet_DB__1");
+CPPUNIT_ASSERT(pDBData);
+}
+
 void ScFiltersTest2::testTdf84762()
 {
 ScDocShellRef xDocSh = loadDoc(u"blank.", FORMAT_ODS);
diff --git a/sc/source/core/data/documen2.cxx b/sc/source/core/data/documen2.cxx
index 67f6e9d7ca41..dc23b2c3209e 100644
--- a/sc/source/core/data/documen2.cxx
+++ b/sc/source/core/data/documen2.cxx
@@ -855,6 +855,7 @@ bool ScDocument::CopyTab( SCTAB nOldPos, SCTAB nNewPos, 
const ScMarkData* pOnlyM
 GetRangeName()->CopyUsedNames( -1, nRealOldPos, nNewPos, *this, *this, 
bGlobalNamesToLocal);
 
 sc::CopyToDocContext aCopyDocCxt(*this);
+pDBCollection->CopyToTable(nOldPos, nNewPos);
 maTabs[nOldPos]->CopyToTable(aCopyDocCxt, 0, 0, MaxCol(), MaxRow(), 
InsertDeleteFlags::ALL,
 (pOnlyMarked != 

Re: GSoC ideas wiki page gardening

[Tomaž Vajngerl]

Hi Ilmari,

On Tue, Jan 25, 2022 at 2:40 AM Ilmari Lauhakangas <
ilmari.lauhakan...@libreoffice.org> wrote:

> We need some medium ones as well, so please consider either adding new
> ideas or splitting old ones (can be 175 + 350 split, if you rethink the
> scope).
>

Any suggestions on how to present a splitted idea in the idea page? Would
it be good to just define "medium size" to include these goals, and "large
size" additionally includes those goals? And say under Size "medium or
large"?


> Ilmari
>

Tomaž

Peter K. Zacharias (Pennsylvania Dutch Education Corporation) license statement

[Peter K. Zacharias]

Per Eike Rathke’s comment at: 
https://bugs.documentfoundation.org/show_bug.cgi?id=146602#c3

I am providing the following license statement:

All of my past & future contributions to LibreOffice may be licensed under the 
MPLv2/LGPLv3+ dual license.

Thank you and best regards,

Peter K. Zacharias
Pennsylvania Dutch Education Corporation
Reading, PA
USA

[Libreoffice-bugs] [Bug 147013] Shapes containing arcs are not printed properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147013

Saburo  changed:

   What|Removed |Added

  Component|LibreOffice |Printing and PDF export

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - vcl/source

[Luboš Luňák (via logerrit)]

 vcl/source/filter/FilterConfigCache.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8ebded337746af384eca3318f76c696660c78c4d
Author: Luboš Luňák 
AuthorDate: Thu Jan 13 15:52:38 2022 +0100
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 27 04:59:19 2022 +0100

do not require that an image type has a 3-character extension

WebP does not (AFAIK) have any other extension other than .webp,
so do require that. It's probably some old idea from the times
when files were expected to have 3-character extensions.

Change-Id: I64db137e1f5345f12d27ad85d83b715f6e10167d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128977
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/filter/FilterConfigCache.cxx 
b/vcl/source/filter/FilterConfigCache.cxx
index a315c0279b69..478756ff17f0 100644
--- a/vcl/source/filter/FilterConfigCache.cxx
+++ b/vcl/source/filter/FilterConfigCache.cxx
@@ -201,7 +201,7 @@ void FilterConfigCache::ImplInit()
 // The first extension will be used
 // to generate our internal FilterType ( BMP, WMF ... )
 OUString aExtension( aEntry.GetShortName() );
-if (aExtension.getLength() != 3)
+if (aExtension.isEmpty())
 continue;
 
 if ( aEntry.nFlags & 1 )

[Libreoffice-commits] core.git: vcl/source

[Luboš Luňák (via logerrit)]

 vcl/source/filter/FilterConfigCache.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 35db43e328aca8290eda72806c52d757a8a5f579
Author: Luboš Luňák 
AuthorDate: Thu Jan 13 15:52:38 2022 +0100
Commit: Tomaž Vajngerl 
CommitDate: Thu Jan 27 04:58:53 2022 +0100

do not require that an image type has a 3-character extension

WebP does not (AFAIK) have any other extension other than .webp,
so do require that. It's probably some old idea from the times
when files were expected to have 3-character extensions.

Change-Id: I64db137e1f5345f12d27ad85d83b715f6e10167d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128925
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/vcl/source/filter/FilterConfigCache.cxx 
b/vcl/source/filter/FilterConfigCache.cxx
index a314a6ca1660..370e8cffed8b 100644
--- a/vcl/source/filter/FilterConfigCache.cxx
+++ b/vcl/source/filter/FilterConfigCache.cxx
@@ -175,7 +175,7 @@ void FilterConfigCache::ImplInit()
 // The first extension will be used
 // to generate our internal FilterType ( BMP, WMF ... )
 OUString aExtension( aEntry.GetShortName() );
-if (aExtension.getLength() != 3)
+if (aExtension.isEmpty())
 continue;
 
 if ( aEntry.nFlags & 1 )

[Libreoffice-bugs] [Bug 139321] [META] XLSX (OOXML) Image issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139321

Kevin Suo  changed:

   What|Removed |Added

 Depends on||147014


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147014
[Bug 147014] FILEOPEN XLSX: Images anchored to cells are missing
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147014] FILEOPEN XLSX: Images anchored to cells are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147014

Kevin Suo  changed:

   What|Removed |Added

 Blocks||139321


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=139321
[Bug 139321] [META] XLSX (OOXML) Image issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121074] Missing images in an XLSX on Linux and macOS (OK on Windows)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121074

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7014

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147014] FILEOPEN XLSX: Images anchored to cells are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147014

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||1074

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144661] Fileopen XLSX: PNG images missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144661

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7014

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147014] FILEOPEN XLSX: Images anchored to cells are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147014

Kevin Suo  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4661
   Keywords||filter:xlsx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147014] FILEOPEN XLSX: Images anchored to cells are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147014

--- Comment #1 from Kevin Suo  ---
Created attachment 177818
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177818=edit
MSO2010Screenshot.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147014] New: FILEOPEN XLSX: Images anchored to cells are missing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147014

Bug ID: 147014
   Summary: FILEOPEN XLSX: Images anchored to cells are missing
   Product: LibreOffice
   Version: 6.0.0.3 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: suokunl...@126.com

Created attachment 177817
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177817=edit
testImageAnchoredToCells.xlsx

The attached test document contains png images anchored to cells in column B.
When open with Calc, the images are missing. These images do show up when open
this file with MSO 2010.

Steps to Reproduce:
1. Open the attached test document.

Current Result:
Images anchored to cells in column B are missing.

Expected Result:
There should be three images anchored to cells in column B.

Terminal Output:
warn:xmloff:15203:15203:sax/source/fastparser/fastparser.cxx:1328: unknown
element xsi:type http://www.w3.org/2001/XMLSchema-instance
warn:xmloff:15203:15203:sax/source/fastparser/fastparser.cxx:1328: unknown
element xsi:type http://www.w3.org/2001/XMLSchema-instance
warn:xmloff:15203:15203:sax/source/fastparser/fastparser.cxx:1252: unknown
attribute defaultSlicerStyle=SlicerStyleLight1
warn:legacy.osl:15203:15203:sc/source/filter/oox/worksheethelper.cxx:535:
WorksheetGlobals::getDrawPageSize - called too early, size invalid
warn:legacy.osl:15203:15203:sc/source/filter/oox/worksheethelper.cxx:535:
WorksheetGlobals::getDrawPageSize - called too early, size invalid
warn:legacy.osl:15203:15203:sc/source/filter/oox/worksheethelper.cxx:535:
WorksheetGlobals::getDrawPageSize - called too early, size invalid

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: b9039e511ed103814dd3c2987c2e408aebb58058
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Build Platform: Fedora34@X64, Branch:master, bibisect-linux-64-7.4-CN
Calc: threaded
Fedora 34.

Also reproducible on the "oldest" of the linux-64-6.1 bibisect repo.

This problem was initially reported by a user in our LibreOffice Simplified
Chinese discussion QQ chat group. The user sent us a business proprietary file,
and the attached is the one I edited with MSO 2010 to simplify and to have
sensitive information removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144166] Pixel (or pixels) missing in the Calc Formula Bar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144166

Deep17  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||caol...@redhat.com
Version|7.2.0.4 release |7.1.0.0.alpha0+

--- Comment #11 from Deep17  ---
Regression introduced by:
https://git.libreoffice.org/core/commit/e087e25f05e689091cbf1c4f91b6e93878ac17ec

commit  e087e25f05e689091cbf1c4f91b6e93878ac17ec[log]
author  Caolán McNamara Mon Oct 05 14:19:05 2020 +0100
committer   Caolán McNamara Fri Oct 16 12:54:14
2020 +0200
tree8adb7ccbfa34e45e549a17bd9ee0a85067db1671
parent  d6b7cc3f7c07b98c90194e8b33cf44b94804b525 [diff]

Bisected with:bibisect-win64-7.1
Adding Cc: to   Caolán McNamara

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147011] DOCUMENTATION Area selection in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147011

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147011] DOCUMENTATION Area selection in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147011

--- Comment #1 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/714b152de6a39ced79cc88ef17e51ef7efec5abc

tdf#147011 Fix text on entering data in Calc

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Olivier Hallot (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fdf5411bfebd639ef284f505a69b8610a294628c
Author: Olivier Hallot 
AuthorDate: Thu Jan 27 04:09:19 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Thu Jan 27 04:09:19 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 714b152de6a39ced79cc88ef17e51ef7efec5abc
  - tdf#147011 Fix text on entering data in Calc

Change-Id: I713351de49059b643acceae8ce0f65f664829980
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128962
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 2f76d8e9280c..714b152de6a3 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 2f76d8e9280cbe1e726cfcf2d4a798c8cf418241
+Subproject commit 714b152de6a39ced79cc88ef17e51ef7efec5abc

[Libreoffice-commits] help.git: source/text

[Olivier Hallot (via logerrit)]

 source/text/scalc/guide/cell_enter.xhp |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 714b152de6a39ced79cc88ef17e51ef7efec5abc
Author: Olivier Hallot 
AuthorDate: Wed Jan 26 21:55:38 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Jan 27 04:09:18 2022 +0100

tdf#147011 Fix text on entering data in Calc

Change-Id: I713351de49059b643acceae8ce0f65f664829980
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128962
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/scalc/guide/cell_enter.xhp 
b/source/text/scalc/guide/cell_enter.xhp
index c7f81cab7..208653230 100644
--- a/source/text/scalc/guide/cell_enter.xhp
+++ b/source/text/scalc/guide/cell_enter.xhp
@@ -32,24 +32,24 @@
   cell ranges;selecting for data entries
   areas, see also cell ranges
 
-Entering Values
-
+Entering Values
+
   Calc can 
simplify entering data and values into multiple cells. You can change some 
settings to conform to your preferences.
-  To Enter Values Into a Range of Cells Manually
+  To Enter Values Into a Range of Cells Manually
   There 
are two features that assist you when you enter a block of data 
manually.
-  Area Detection for New Rows
+  Area Detection for New Rows
   In the 
row below a heading row, you can advance from one cell to the next with the Tab 
key. After you enter the value into the last cell in the current row, press 
Enter. Calc positions the cursor below the first cell of the current 
block.
   
 area detection

   In row 
3, press Tab to advance from cell B3 to C3, D3, and E3. Then press Enter to 
advance to B4.
-  Area Selection
-  Use 
drag-and-drop to select the area where you want to input values. But start 
dragging from the last cell of the area and release the mouse button when you 
have selected the first cell. Now you can start to input values. Always press 
the Tab key to advance to the next cell. You will not leave the selected 
area.
+  Area Selection
+  Select 
the area where you want to input values. Now you can start to input values from 
the cursor position in the selected area. Press the Tab key 
to advance to the next cell or Shift + 
Tab to move backward. At the edges of the selected area the 
tab key jumps inside the selected area. You will not leave the selected 
area.
   
 area selection

-  Select 
the area from E7 to B3. Now B3 is waiting for your input. Press Tab to advance 
to the next cell within the selected area.
-  To Enter Values to a Range of Cells Automatically
+  Select 
the area from B3 to E7. Now B3 is waiting for your input. Press 
Tab to advance to the next cell within the selected 
area.
+  To Enter Values to a Range of Cells 
Automatically
   See Automatically Filling in Data Based on 
Adjacent Cells.
   
  

[Libreoffice-bugs] [Bug 147013] New: Shapes containing arcs are not printed properly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147013

Bug ID: 147013
   Summary: Shapes containing arcs are not printed properly
   Product: LibreOffice
   Version: 7.3.0.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yosi3260+li...@gmail.com

Description:
Calc,Draw,Writer
Insert - Shape - Basic Shapes - [Rectangle,Rounded], [Square,Rounded],
[Ellipse], [Circle], [Circle Segment], [Arc], [Cylinder]

Line Properties
Style: Other than [Continuous]  exp:[Ultrafine Dashed]
Width: Greater than 0.00 cm

The orientation is reversed when printing

Steps to Reproduce:
1.[Insert]-[Shape]-[Basic Shapes]-[Circle]
2.Line Style:[Ultrafine Dashed],Width:[0.13cm]
3.Print

Actual Results:
A strange shape is printed


Expected Results:
Modifying the drawing process


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.2 (x64) / LibreOffice Community
Build ID: f1c9017ac60ecca268da7b1cf147b10e244b9b21
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

6 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 6 of 6 defect(s)


** CID 1497861:  Null pointer dereferences  (FORWARD_NULL)



*** CID 1497861:  Null pointer dereferences  (FORWARD_NULL)
/vcl/unx/gtk3/gtkinst.cxx: 6199 in 
::GtkInstanceWindow::change_default_widget(weld::Widget *, 
weld::Widget *)()
6193 GtkWidget* pWidgetOld = pGtkOld->getWidget();
6194 g_object_set(G_OBJECT(pWidgetOld), "has-default", false, 
nullptr);
6195 }
6196 if (pNew)
6197 {
6198 GtkInstanceWidget* pGtkNew = 
dynamic_cast(pNew);
>>> CID 1497861:  Null pointer dereferences  (FORWARD_NULL)
>>> Passing null pointer "pGtkNew" to "getWidget", which dereferences it.
6199 GtkWidget* pWidgetNew = pGtkNew->getWidget();
6200 g_object_set(G_OBJECT(pWidgetNew), "has-default", true, 
nullptr);
6201 }
6202 #endif
6203 }
6204 

** CID 1497860:  Null pointer dereferences  (FORWARD_NULL)



*** CID 1497860:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/app/salvtables.cxx: 1519 in 
SalInstanceWindow::change_default_widget(weld::Widget *, weld::Widget *)()
1513 SalInstanceWidget* pVclOld = 
dynamic_cast(pOld);
1514 pVclOld->getWidget()->set_property("has-default", 
OUString::boolean(false));
1515 }
1516 if (pNew)
1517 {
1518 SalInstanceWidget* pVclNew = 
dynamic_cast(pNew);
>>> CID 1497860:  Null pointer dereferences  (FORWARD_NULL)
>>> Passing null pointer "pVclNew" to "getWidget", which dereferences it.
1519 pVclNew->getWidget()->set_property("has-default", 
OUString::boolean(true));
1520 }
1521 }
1522 
1523 bool SalInstanceWindow::is_default_widget(const weld::Widget* 
pCandidate) const
1524 {

** CID 1497859:  Null pointer dereferences  (FORWARD_NULL)



*** CID 1497859:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/app/salvtables.cxx: 1526 in 
SalInstanceWindow::is_default_widget(const weld::Widget *) const()
1520 }
1521 }
1522 
1523 bool SalInstanceWindow::is_default_widget(const weld::Widget* 
pCandidate) const
1524 {
1525 const SalInstanceWidget* pVclCandidate = dynamic_cast(pCandidate);
>>> CID 1497859:  Null pointer dereferences  (FORWARD_NULL)
>>> Passing null pointer "pVclCandidate" to "getWidget", which dereferences 
>>> it.
1526 return pVclCandidate->getWidget()->GetStyle() & WB_DEFBUTTON;
1527 }
1528 
1529 void SalInstanceWindow::set_window_state(const OString& rStr)
1530 {
1531 SystemWindow* pSysWin = 
dynamic_cast(m_xWindow.get());

** CID 1497858:  Null pointer dereferences  (FORWARD_NULL)



*** CID 1497858:  Null pointer dereferences  (FORWARD_NULL)
/vcl/unx/gtk3/gtkinst.cxx: 6193 in 
::GtkInstanceWindow::change_default_widget(weld::Widget *, 
weld::Widget *)()
6187 #else
6188 if (!pOld)
6189 recursively_unset_default_buttons();
6190 else
6191 {
6192 GtkInstanceWidget* pGtkOld = 
dynamic_cast(pOld);
>>> CID 1497858:  Null pointer dereferences  (FORWARD_NULL)
>>> Passing null pointer "pGtkOld" to "getWidget", which dereferences it.
6193 GtkWidget* pWidgetOld = pGtkOld->getWidget();
6194 g_object_set(G_OBJECT(pWidgetOld), "has-default", false, 
nullptr);
6195 }
6196 if (pNew)
6197 {
6198 GtkInstanceWidget* pGtkNew = 
dynamic_cast(pNew);

** CID 1497857:  Null pointer dereferences  (FORWARD_NULL)



*** CID 1497857:  Null pointer dereferences  (FORWARD_NULL)
/vcl/source/app/salvtables.cxx: 1514 in 
SalInstanceWindow::change_default_widget(weld::Widget *, weld::Widget *)()
1508 {
1509 if (!pOld)
1510 recursively_unset_default_buttons();
1511 else
1512 {
1513 SalInstanceWidget* pVclOld = 
dynamic_cast(pOld);
>>> CID 1497857:  Null pointer dereferences  (FORWARD_NULL)
>>> Passing null pointer "pVclOld" to "getWidget", which dereferences it.
1514 

[Libreoffice-bugs] [Bug 146572] Wrapped RTL String Incorrectly Positioned in LTR Paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146572

--- Comment #5 from jcuenod  ---
I think my last reply may add clarification on what I expect. I think you
interpreted me correctly. But just to make another attempt at clarification in
case it's needed:

I would expect that, when a string of RTL text wraps across a line of left
aligned text (because the rest of the paragraph is LTR), the span of RTL text
that remains on the first line would left align with the rest of the paragraph.
I think that the same intuition is why I expect to see the span of RTL text
that continues on the second line to be on the *left* of that line with LTR
text continuing on the right.

If the unicode spec says this is not how it should be, I apologise.

Anecdotally, however, this is how I've seen other editors lay out such text
(e.g. Google docs) and this is how I've observed it in journal articles. If you
need a list of examples, I will try to dig some up. I don't have a formal basis
for this intuition but I'm not convinced that the unicode docs you are linking
specify preserving whitespace in two directions at the end of a wrapped line
either (which, I assume, is what is producing the [imo] buggy output).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147012] New: Table: Acute accent make jump to next cell

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147012

Bug ID: 147012
   Summary: Table: Acute accent make jump to next cell
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: cjdg_...@yahoo.com.mx

When you create a new Writer document, add a table, and start to write, adding
an acute accent makes it jump to next cell

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=43808

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||146572


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=146572
[Bug 146572] Wrapped RTL String Incorrectly Positioned in LTR Paragraph
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146572] Wrapped RTL String Incorrectly Positioned in LTR Paragraph

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146572

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||43808
 CC||eyalr...@gmx.com

--- Comment #4 from Eyal Rozenberg  ---
> the first line of RTL text is not left aligned as expected

Not sure what you mean exactly, going by this sentence:

> I would expect the leftmost portion of the Hebrew text to be adjacent to the 
> opening bracket.

Why? Why is it "better" to have the space on the next line, or nowhere, rather
than on the first line? It serves to indicated that the parenthesis doesn't
come right after the תהיה. 

But even ignoring the intuition above - what's the formal basis (here:
http://www.unicode.org/reports/tr9/tr9-23.html I would think) for your
expectation?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left and Complex Text Layout language issues
(RTL/CTL)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131330] Firebird/View-editor: Views aren't shown in table directly after creating a view

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131330

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #3 from Julien Nabet  ---
I gave a try here:
https://gerrit.libreoffice.org/c/core/+/129011

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126960] EDITING: Firebird: Table editor instead of view editor

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126960

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #9 from Julien Nabet  ---
I gave a try here:
https://gerrit.libreoffice.org/c/core/+/129011

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Andreas Heinisch (via logerrit)]

 sw/qa/uitest/writer_tests5/tdf106899.py |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 2fe5fcfec107be93793f77f868763ab58da3573a
Author: Andreas Heinisch 
AuthorDate: Mon Jan 24 20:54:26 2022 +0100
Commit: Andreas Heinisch 
CommitDate: Wed Jan 26 22:16:38 2022 +0100

Remove debug import of time

Change-Id: I847f7c1a641d85a9f0d74c04a94463c515337c7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128819
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch 

diff --git a/sw/qa/uitest/writer_tests5/tdf106899.py 
b/sw/qa/uitest/writer_tests5/tdf106899.py
index 389552e24a89..bd77c29457c8 100644
--- a/sw/qa/uitest/writer_tests5/tdf106899.py
+++ b/sw/qa/uitest/writer_tests5/tdf106899.py
@@ -10,7 +10,6 @@
 import org.libreoffice.unotest
 from uitest.framework import UITestCase
 from uitest.uihelper.common import get_url_for_data_file
-import time
 
 class tdf106899(UITestCase):
 
@@ -38,7 +37,7 @@ class tdf106899(UITestCase):
 xCursor.gotoRange(xDocumentIndex.getAnchor().getEnd(), False)
 xCursor.gotoStartOfParagraph(True)
 
-# Without the fix in place the index does not contain the ut8 
index entry
+# Without the fix in place the index does not contain the utf8 
index entry
 self.assertEqual("Nguyễn Khánh" in xCursor.getString(), True)
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-bugs] [Bug 140284] Collabora Office - no new embedded database can be created with database wizard (macOS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140284

Aron Budea  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |FIXED
 CC||aron.bu...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144163] LibreOffice 7.2 Firebird Embedded Base Error - field defined with 20 CHAR limit and containing more than 20 characters stored opens with 7.1, fails to open with 7.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144163

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #28 from Julien Nabet  ---
Since we're dependent on upstream, let's put this one to NOTOURBUG.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144256] Missing destruction of FirebirdDriver::~FirebirdDriver, OSDBCDriverManager::~OSDBCDriverManager, OPoolCollection::~OPoolCollection opening and closing an ODB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144256

Julien Nabet  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #4 from Julien Nabet  ---
Let's increase a bit importance since it seems to impact several types of
databases and not only Firebird which is experimental.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 80430] [META] Documentation gap for new features

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=80430

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||147011


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147011
[Bug 147011] DOCUMENTATION Area selection in Calc
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147011] DOCUMENTATION Area selection in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147011

Olivier Hallot  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||80430


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80430
[Bug 80430] [META] Documentation gap for new features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/headless vcl/quartz vcl/skia

[Luboš Luňák (via logerrit)]

 vcl/headless/CairoCommon.cxx   |2 +-
 vcl/quartz/AquaGraphicsBackend.cxx |2 +-
 vcl/skia/gdiimpl.cxx   |   29 +++--
 3 files changed, 13 insertions(+), 20 deletions(-)

New commits:
commit 534fc16a9f8cd01bb88485e2cf6b9cd33aed3745
Author: Luboš Luňák 
AuthorDate: Wed Jan 26 20:07:48 2022 +0100
Commit: Luboš Luňák 
CommitDate: Wed Jan 26 21:36:45 2022 +0100

make sure to not divide by zero when computing miter limit

The minimal angle is valid only if the line join style is miter,
and e.g. FileDefinitionWidgetDraw can call these with round join
style and 0 angle, which would divide by 0. So either clamp
the value or compute it only when needed.

Change-Id: I2a2c71481490c03ec6d01b8e33cab991400adb35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129006
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/headless/CairoCommon.cxx b/vcl/headless/CairoCommon.cxx
index d77b35d55781..b497e1716f8a 100644
--- a/vcl/headless/CairoCommon.cxx
+++ b/vcl/headless/CairoCommon.cxx
@@ -675,7 +675,7 @@ bool CairoCommon::drawPolyLine(cairo_t* cr, 
basegfx::B2DRange* pExtents, const C
 }
 
 // convert miter minimum angle to miter limit
-double fMiterLimit = 1.0 / sin(fMiterMinimumAngle / 2.0);
+double fMiterLimit = 1.0 / sin(std::min(fMiterMinimumAngle, 0.01 * M_PI) / 
2.0);
 
 // setup cap attribute
 cairo_line_cap_t eCairoLineCap(CAIRO_LINE_CAP_BUTT);
diff --git a/vcl/quartz/AquaGraphicsBackend.cxx 
b/vcl/quartz/AquaGraphicsBackend.cxx
index fdcbae1e3870..690cbf78ae9c 100644
--- a/vcl/quartz/AquaGraphicsBackend.cxx
+++ b/vcl/quartz/AquaGraphicsBackend.cxx
@@ -820,7 +820,7 @@ bool AquaGraphicsBackend::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectToDev
 break;
 }
 // convert miter minimum angle to miter limit
-CGFloat fCGMiterLimit = 1.0 / sin(fMiterMinimumAngle / 2.0);
+CGFloat fCGMiterLimit = 1.0 / sin(std::min(fMiterMinimumAngle, 0.01 * 
M_PI) / 2.0);
 // setup cap attribute
 CGLineCap aCGLineCap(kCGLineCapButt);
 
diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 930865591ac7..c2efb62f96dc 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -1045,45 +1045,38 @@ bool SkiaSalGraphicsImpl::drawPolyLine(const 
basegfx::B2DHomMatrix& rObjectToDev
 aPolyLine = 
basegfx::utils::snapPointsOfHorizontalOrVerticalEdges(aPolyLine);
 }
 
-// Setup Line Join
-SkPaint::Join eSkLineJoin = SkPaint::kMiter_Join;
+SkPaint aPaint = makeLinePaint(fTransparency);
+
 switch (eLineJoin)
 {
 case basegfx::B2DLineJoin::Bevel:
-eSkLineJoin = SkPaint::kBevel_Join;
+aPaint.setStrokeJoin(SkPaint::kBevel_Join);
 break;
 case basegfx::B2DLineJoin::Round:
-eSkLineJoin = SkPaint::kRound_Join;
+aPaint.setStrokeJoin(SkPaint::kRound_Join);
 break;
 case basegfx::B2DLineJoin::NONE:
+break;
 case basegfx::B2DLineJoin::Miter:
-eSkLineJoin = SkPaint::kMiter_Join;
+aPaint.setStrokeJoin(SkPaint::kMiter_Join);
+// convert miter minimum angle to miter limit
+aPaint.setStrokeMiter(1.0 / std::sin(fMiterMinimumAngle / 2.0));
 break;
 }
 
-// convert miter minimum angle to miter limit
-double fMiterLimit = 1.0 / std::sin(fMiterMinimumAngle / 2.0);
-
-// Setup Line Cap
-SkPaint::Cap eSkLineCap(SkPaint::kButt_Cap);
-
 switch (eLineCap)
 {
 case css::drawing::LineCap_ROUND:
-eSkLineCap = SkPaint::kRound_Cap;
+aPaint.setStrokeCap(SkPaint::kRound_Cap);
 break;
 case css::drawing::LineCap_SQUARE:
-eSkLineCap = SkPaint::kSquare_Cap;
+aPaint.setStrokeCap(SkPaint::kSquare_Cap);
 break;
 default: // css::drawing::LineCap_BUTT:
-eSkLineCap = SkPaint::kButt_Cap;
+aPaint.setStrokeCap(SkPaint::kButt_Cap);
 break;
 }
 
-SkPaint aPaint = makeLinePaint(fTransparency);
-aPaint.setStrokeCap(eSkLineCap);
-aPaint.setStrokeJoin(eSkLineJoin);
-aPaint.setStrokeMiter(fMiterLimit);
 aPaint.setStrokeWidth(fLineWidth);
 aPaint.setAntiAlias(mParent.getAntiAlias());
 // See the tdf#134346 comment above.

[Libreoffice-bugs] [Bug 141474] Documentation specifies incorrect parameter names for Basic functions

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141474

--- Comment #14 from Commit Notification 
 ---
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/2f76d8e9280cbe1e726cfcf2d4a798c8cf418241

tdf#145693 tdf#141474 Chr ChrW method signatures

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

[Alain Romedenne (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 60c30241ecb0caeab077a7fb7215442405c42506
Author: Alain Romedenne 
AuthorDate: Wed Jan 26 21:32:03 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Jan 26 21:32:03 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 2f76d8e9280cbe1e726cfcf2d4a798c8cf418241
  - tdf#145693 tdf#141474 Chr ChrW method signatures

Change-Id: If285713e1e76a661205f291f551cc988b194cd35
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128542
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index 1d6b5e9dd137..2f76d8e9280c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 1d6b5e9dd1371dd72703d271533bc08d2cef11ae
+Subproject commit 2f76d8e9280cbe1e726cfcf2d4a798c8cf418241

[Libreoffice-commits] help.git: source/text

[Alain Romedenne (via logerrit)]

 source/text/sbasic/shared/03120102.xhp |   16 ++--
 source/text/sbasic/shared/03120112.xhp |   17 -
 2 files changed, 18 insertions(+), 15 deletions(-)

New commits:
commit 2f76d8e9280cbe1e726cfcf2d4a798c8cf418241
Author: Alain Romedenne 
AuthorDate: Thu Jan 20 09:39:06 2022 +0100
Commit: Rafael Lima 
CommitDate: Wed Jan 26 21:32:01 2022 +0100

tdf#145693 tdf#141474 Chr ChrW method signatures

Change-Id: If285713e1e76a661205f291f551cc988b194cd35
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/128542
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/source/text/sbasic/shared/03120102.xhp 
b/source/text/sbasic/shared/03120102.xhp
index b03ddeb2c..e0329d570 100644
--- a/source/text/sbasic/shared/03120102.xhp
+++ b/source/text/sbasic/shared/03120102.xhp
@@ -35,15 +35,17 @@
   
 
 
-Chr[$](expression As Integer) As String
+
+  Chr[$](charcode As 
Integer) As String
+
 
 
 String
 
 
-Expression: a numeric expression that represents 
a valid 8-bit ASCII value (0-255) or a 16-bit Unicode value. (To support 
expressions with a nominally negative argument like 
Chr(H8000) in a backwards-compatible way, values in the range 
−32768 to −1 are internally mapped to the range 32768 to 65535.)
+charcode: a numeric expression that represents a 
valid 8-bit ASCII value (0-255) or a 16-bit Unicode value. (To support 
expressions with a nominally negative argument like 
Chr(H8000) in a backwards-compatible way, values in the range 
−32768 to −1 are internally mapped to the range 32768 to 65535.)
 
-When VBA compatibility mode is enabled 
(OPTION 
VBASUPPORT 1), Expression is a numeric expression 
that represents a valid 8-bit ASCII value (0-255) only.
+  When VBA compatibility mode is enabled 
(Option 
VBASupport 1), charcode is a numeric 
expression that represents a valid 8-bit ASCII value (0-255) only.
 
 Use the 
Chr$ function to send special control sequences to a printer or to 
another output source. You can also use it to insert quotation marks in a 
string expression.
 
@@ -53,11 +55,13 @@
 
 
 
-Sub ExampleChr
+Sub 
ExampleChr
 ' 
This example inserts quotation marks (ASCII value 34) in a string.
-
MsgBox "A "+ Chr$(34)+"short" + Chr(34)+" trip."
+
MsgBox "A " + Chr$(34) + "short" + Chr(34) + " trip."
 ' 
The printout appears in the dialog as: A "short" trip.
-End Sub
+ 
   MsgBox Chr(charcode := 64) ' "@" sign
+End 
Sub
+
 
 
 
diff --git a/source/text/sbasic/shared/03120112.xhp 
b/source/text/sbasic/shared/03120112.xhp
index 05d2b8297..e1eba0429 100644
--- a/source/text/sbasic/shared/03120112.xhp
+++ b/source/text/sbasic/shared/03120112.xhp
@@ -27,35 +27,34 @@
 
 
 
-
 
 
   ChrW function
 
 
-
 ChrW Function 
[VBA]
 Returns the Unicode character 
that corresponds to the specified character code.
 
 
 
 
-ChrW(Expression 
As Integer) As String
+ChrW(charcode As 
Integer) As String
 
 
 String
 
- 
Expression: Numeric variables that represent a valid 16 bit 
Unicode value (0-65535). (To support expressions with a nominally negative 
argument like ChrW(H8000) in a backwards-compatible way, 
values in the range −32768 to −1 are internally mapped to the range 32768 to 
65535.) An empty value returns error code 5. A value out of the range [0,65535] 
returns error code 6.
+ 
charcode: Numeric expression that represent a valid 16 bit Unicode 
value (0-65535). (To support expressions with a nominally negative argument 
like ChrW(H8000) in a backwards-compatible way, values in the 
range −32768 to −1 are internally mapped to the range 32768 to 65535.) An empty 
value returns error code 5. A value out of the range [0 to 65535] returns error 
code 6.
 
 
 
 
 
-Sub ExampleChrW
- ' This example 
inserts the Greek letters alpha and omega in a string.
- MsgBox "From "+ 
ChrW(913)+" to " + ChrW(937)
- ' The printout 
appears in the dialog as: From Α to Ω
-End Sub
+Sub 
ExampleChrW
+' This 
example inserts the Greek letters alpha and omega in a string.
+MsgBox "From 
" + ChrW(913) + " to " + ChrW(937)
+' The 
printout appears in the dialog as: From Α to Ω
+
MsgBox ChrW(charcode := 116) ' "t" lowercase T letter
+End 
Sub
 
 
 

[Libreoffice-bugs] [Bug 126604] Linux: Libreoffice doesn't use the keyring when printing to network printer that requires authentication

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126604

--- Comment #5 from John Williams  ---
This behaviour persists in 2022, AFAICT. and is extremely frustrating.

Or is there some solution? I've Googled for this many times over the years, to
no avail. Perhaps I've not looked hard enough?

LO Community 7.2.5.2 on Fedora 35.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 84542] can't open a Writer document at last modified page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84542

--- Comment #7 from Samantha  ---
(In reply to Tammy M. Alexander from comment #4)
> I do think that LibreOffice 4.3.2.2 has not been installed properly because
> I am unable to access some of its features. Visit https://studyclerk.com/
> for Professional Essay Writing Service, WY. There are also many bugs that
> are present in this newly introduced version that are making me
> uncomfortable.


Tammy, I have moments like this when I am writing my dissertation. There is an
inspiration and everything is written lightly. And then abruptly comes the
stupor. And that's it, I can't write. Each assignment has a due date. In such
cases, I turn to   https://www.bestessay.com/write-my-dissertation/   . Writers
can quickly follow up a thought. They read my work and understand my writing
style. Therefore, there is no difference in the chapters at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147011] New: DOCUMENTATION Area selection in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147011

Bug ID: 147011
   Summary: DOCUMENTATION Area selection in Calc
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: iavs.le...@gmail.com
CC: olivier.hal...@libreoffice.org

Description:
There is a wrong description.

Steps to Reproduce:
1.
https://help.libreoffice.org/7.2/en-US/text/scalc/guide/cell_enter.html#hd_id3583788

Actual Results:
Area Selection

Use drag-and-drop to select the area where you want to input values. But start
dragging from the last cell of the area and release the mouse button when you
have selected the first cell.



Expected Results:
Area Selection

Use drag (or Shift+[navigating keys?]) to select the area where you want to
input values. But start dragging from the first cell of the area and release
the mouse button (or Shift) when you have selected the last cell.


Reproducible: Always


User Profile Reset: No



Additional Info:
I think that there is no need of other information. Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144593] Keep active cell focused on col/row selection (if it is part of the resulting selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144593

LeroyG  changed:

   What|Removed |Added

Version|7.2.0.4 release |7.1.8.1 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144593] Keep active cell focused on col/row selection (if it is part of the resulting selection)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144593

--- Comment #6 from LeroyG  ---
Why it is needed that A4 remains as the active cell? What is the use?

When selecting with keyboard (Ctrl+A, Ctrl+Spacebar, Shift+Spacebar,
Shift+whatever), A4 remains as the active cell.

When selecting a cell range (no complete rows or columns), the resulting active
cell is the first (in time) selected of the last range selected; no matter if
it is done with mouse or keyboard, with standard selection, extending selection
or adding selection.

So why, when selecting rows/columns, the active cell is the leftmost/upper of
the last (in time) row/column selected? Why not the first row/column selected?

There is a official name for the corner-click "select all"? Header of headers?
:-) I can not find it just now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: bin/ui-rules-enforcer.py chart2/uiconfig

[Caolán McNamara (via logerrit)]

 bin/ui-rules-enforcer.py   |   16 
 chart2/uiconfig/ui/sidebartype.ui  |1 -
 chart2/uiconfig/ui/tp_ChartType.ui |1 -
 3 files changed, 16 insertions(+), 2 deletions(-)

New commits:
commit b9039e511ed103814dd3c2987c2e408aebb58058
Author: Caolán McNamara 
AuthorDate: Wed Jan 26 17:39:26 2022 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 26 20:56:36 2022 +0100

ensure no 'angle' is used in a GtkLabel

Change-Id: Id6231774fb1a8d12e771815023e661d5e0ac06a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129004
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/bin/ui-rules-enforcer.py b/bin/ui-rules-enforcer.py
index 6fec6293244e..5079d8e67ce1 100755
--- a/bin/ui-rules-enforcer.py
+++ b/bin/ui-rules-enforcer.py
@@ -294,6 +294,21 @@ def remove_label_pad(current):
   if ypad != None:
 current.remove(ypad)
 
+def remove_label_angle(current):
+  angle = None
+  islabel = current.get('class') == "GtkLabel"
+  for child in current:
+remove_label_angle(child)
+if not islabel:
+continue
+if child.tag == "property":
+  attributes = child.attrib
+  if attributes.get("name") == "angle":
+angle = child
+
+  if angle != None:
+current.remove(angle)
+
 def remove_track_visited_links(current):
   track_visited_links = None
   islabel = current.get('class') == "GtkLabel"
@@ -576,6 +591,7 @@ remove_spin_button_input_purpose(root)
 remove_spin_button_max_length(root)
 remove_track_visited_links(root)
 remove_label_pad(root)
+remove_label_angle(root)
 remove_expander_label_fill(root)
 remove_expander_spacing(root)
 enforce_menubutton_indicator_consistency(root)
diff --git a/chart2/uiconfig/ui/sidebartype.ui 
b/chart2/uiconfig/ui/sidebartype.ui
index ae410375d1c0..686feacea397 100644
--- a/chart2/uiconfig/ui/sidebartype.ui
+++ b/chart2/uiconfig/ui/sidebartype.ui
@@ -126,7 +126,6 @@
 Sh_ape
 True
 shape
-0.02
 0
   
   
diff --git a/chart2/uiconfig/ui/tp_ChartType.ui 
b/chart2/uiconfig/ui/tp_ChartType.ui
index a7cafb14e71b..68decb08f0d7 100644
--- a/chart2/uiconfig/ui/tp_ChartType.ui
+++ b/chart2/uiconfig/ui/tp_ChartType.ui
@@ -173,7 +173,6 @@
 Sh_ape
 True
 shape
-0.02
 0
   
   

[Libreoffice-bugs] [Bug 147010] New: Pasting data into Writer results in application hang for several seconds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147010

Bug ID: 147010
   Summary: Pasting data into Writer results in application hang
for several seconds
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lamber...@yahoo.com

Description:
When I paste data into Writer from my clipboard Writer will hang or lag for
many seconds, possibly 30 seconds or more. I've tried to determine the
parameters under which this happens but haven't been able to narrow it down.
Pasting unformatted text (which is what I wanted anyway) seems to avoid the
issue.

Data copied includes single email addresses in Yahoo email on Chrome and I
believe simple numbers copied from LibreOffice Calc, 

Steps to Reproduce:
1.Unable to reproduce reliably
2.
3.

Actual Results:
when pasting the program simply hangs and becomes unresponsive. no cursor
blinking or movement occurs no matter what. I can still move the mouse and
alt-tab to other applications of course.

Expected Results:
normal operation


Reproducible: Sometimes


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 7.2.5.2 (x64) / LibreOffice Community
Build ID: 499f9727c189e6ef3471021d6132d4c694f357e5
CPU threads: 8; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147009] New: EDITING:

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147009

Bug ID: 147009
   Summary: EDITING:
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 100...@elektropost.org

Created attachment 177816
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177816=edit
column D moved between column B an C - original D remains

I want to move a hole column between two others. While pressing ALT it will
move, but also keep the original column from where I wanted to move it.

This bug is there for long time already.

It is a major issue for me. Iwant to use Libre Office. But because of this bug
I keep switching back to Microsoft office a lot of times.

PLEASE!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117085] [META] Compress image dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117085

Jérôme  changed:

   What|Removed |Added

 Depends on||145161


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145161
[Bug 145161] Writer Impress : the image compression form should change the
image resolution only if it decreases
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145161] Writer Impress : the image compression form should change the image resolution only if it decreases

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145161

Jérôme  changed:

   What|Removed |Added

 Blocks||117085


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117085
[Bug 117085] [META] Compress image dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117085] [META] Compress image dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=117085

Jérôme  changed:

   What|Removed |Added

 Depends on||145160


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145160
[Bug 145160] Writer Impress : the image compression form should select by
default the former image format
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145160] Writer Impress : the image compression form should select by default the former image format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145160

Jérôme  changed:

   What|Removed |Added

 Blocks||117085


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117085
[Bug 117085] [META] Compress image dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sc/uiconfig

[Caolán McNamara (via logerrit)]

 sc/uiconfig/scalc/ui/warnautocorrect.ui |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 6dcda6ac592f062a68c029bfe26a47ad7160c930
Author: Caolán McNamara 
AuthorDate: Wed Jan 26 15:43:43 2022 +
Commit: Eike Rathke 
CommitDate: Wed Jan 26 19:54:02 2022 +0100

warning is a dialog not a popup

with the wrong setting it appears misplaced on a multi-monitor setup

Change-Id: I43faeb72f6678a653feef82e0f0deaf87c039e9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128958
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/uiconfig/scalc/ui/warnautocorrect.ui 
b/sc/uiconfig/scalc/ui/warnautocorrect.ui
index 632dbcc80360..2523d5a1fc87 100644
--- a/sc/uiconfig/scalc/ui/warnautocorrect.ui
+++ b/sc/uiconfig/scalc/ui/warnautocorrect.ui
@@ -5,7 +5,6 @@
   
 False
 6
-popup
 True
 dialog
 True

[Libreoffice-bugs] [Bug 146991] Insert chart -> crash (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146991

--- Comment #4 from Xisco Faulí  ---
*** Bug 147007 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147007] CRASH: undoing paste (GTK3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147007

Xisco Faulí  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #2 from Xisco Faulí  ---
it seems it got fixed in
https://git.libreoffice.org/core/commit/385bd85b20b9efff981e7e5cd063a01d39e1e45a
Closing as duplicated of bug 146991

*** This bug has been marked as a duplicate of bug 146991 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146991] Insert chart -> crash (gtk3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146991

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
Summary|Insert chart -> crash   |Insert chart -> crash
   ||(gtk3)

--- Comment #3 from Xisco Faulí  ---
it seems to be happening with gtk3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147008] CRASH: Inserting page break or newline

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147008

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|0   |1
   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||9638
 CC||michael.st...@allotropia.de
   ||,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ab6176e88f78d0b3aa2490fbc7858304c2d4a437

author  Michael Stahl  2022-01-19 12:10:35
+0100
committer   Michael Stahl  2022-01-19
16:05:49 +0100
commit  ab6176e88f78d0b3aa2490fbc7858304c2d4a437 (patch)
tree27b0b2d781c24c3beb445db2b1ccf75b98da453e
parent  2584950681b6485bb0772d2719cafee678cf7583 (diff)
tdf#139638 sw_fieldmarkhide: hide fieldmark command in ModelToViewHelper

Bisected with:bibisect-linux64-7.4

Adding Cc: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146999] Artifacts when scrolling up and down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146999

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #3 from BogdanB  ---
Confirm with
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4935bb372e3618eca105997c83101aa2b3d422e3
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147008] New: CRASH: Inserting page break or newline

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147008

Bug ID: 147008
   Summary: CRASH: Inserting page break or newline
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 47509 from bug 37912
2. Insert a new line or a page break

-> Crash

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4935bb372e3618eca105997c83101aa2b3d422e3
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152

BogdanB  changed:

   What|Removed |Added

 Depends on||142484


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142484
[Bug 142484] FILEOPEN: Images have incorrect position ( part 2 )
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/source

[Noel Grandin (via logerrit)]

 chart2/source/inc/ReferenceSizeProvider.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 47a863f09d1c1273dc0c00cc03719d322b00ddd4
Author: Noel Grandin 
AuthorDate: Wed Jan 26 10:39:07 2022 +0200
Commit: Noel Grandin 
CommitDate: Wed Jan 26 19:36:59 2022 +0100

whack ubsan with a bigger hammer

it seems to have trouble compiling code when it can't see
chart::ChartModel, so just include it from one of the central
headers.

Change-Id: I1c96e40b5b8e35b74dd80f44d8c3243af5ba2626
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128973
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/inc/ReferenceSizeProvider.hxx 
b/chart2/source/inc/ReferenceSizeProvider.hxx
index eb8fa534b472..dbacd093ff24 100644
--- a/chart2/source/inc/ReferenceSizeProvider.hxx
+++ b/chart2/source/inc/ReferenceSizeProvider.hxx
@@ -22,6 +22,7 @@
 #include 
 #include "charttoolsdllapi.hxx"
 #include 
+#include 
 
 namespace com::sun::star {
 namespace chart2 {
@@ -36,7 +37,6 @@ namespace com::sun::star {
 
 namespace chart
 {
-class ChartModel;
 
 class OOO_DLLPUBLIC_CHARTTOOLS ReferenceSizeProvider
 {

[Libreoffice-bugs] [Bug 147006] CRASH: deleting content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147006

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #2 from BogdanB  ---
Also repro in
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4935bb372e3618eca105997c83101aa2b3d422e3
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147007] CRASH: undoing paste (GTK3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147007

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||noelgran...@gmail.com,
   ||xiscofa...@libreoffice.org

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4304947164bbcd3fea758df491a730b01d578be2

author  Noel Grandin  2022-01-21 09:10:08
+0200
committer   Noel Grandin  2022-01-21
13:44:57 +0100
commit  4304947164bbcd3fea758df491a730b01d578be2 (patch)
tree996401cf2095022d79e2459fdc0cfc9168c674dd
parent  47f21d290087638b1986c291c969bf2997574ddd (diff)
fix opengl slide transition

Bisected with: bibisect-linux64-7.4

Adding Cc: to Noel Grandin

Since the bisection looked a bit suspicious, I reverted the patch locally and I
do confirm the crash is not happening when reverted

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147007] New: CRASH: undoing paste (GTK3)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147007

Bug ID: 147007
   Summary: CRASH: undoing paste (GTK3)
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 177815
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177815=edit
sample document

Steps to reproduce:
1. Open attached document
2. Go to 'Zestawienie montażowe'
3. Select All
4. Cut
5. Paste
6. Undo

terminate called after throwing an instance of 'std::system_error'
  what():  Resource deadlock avoided
Unspecified Application Error

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4935bb372e3618eca105997c83101aa2b3d422e3
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146857] Freeze after undoing accepting/rejecting changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146857

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Status|RESOLVED|VERIFIED

--- Comment #9 from BogdanB  ---
Verified. No freeze

Laszlo thanks for fixing this bug, and Telesto thanks for reporting.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4935bb372e3618eca105997c83101aa2b3d422e3
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147005] [Linux Flatpak] LibreOffice doesn't stop "saving" where it can't write to, then "deletes" the "file" that never existed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147005

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Resolution|--- |MOVED
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Buovjaga  ---
Please file it to flathub
https://github.com/flathub/org.libreoffice.LibreOffice/issues

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147006] CRASH: deleting content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147006

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 CC||michael.st...@allotropia.de
   ||,
   ||xiscofa...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=657de5fba12b0e9afcdee361654d2a2d0dbd7311

author  Michael Stahl  2021-11-19 16:08:57
+0100
committer   Michael Stahl  2021-12-23
09:11:59 +0100
commit  657de5fba12b0e9afcdee361654d2a2d0dbd7311 (patch)
tree5826d4081b90c4e55e262d203b0d3bbbc51d
parent  d11fb6cecaf72787973990e09cc7e8d03bdbf9d7 (diff)
Revert "Revert "sw_fieldmarkhide: init fieldmark mode from options""

Bisected with: bibisect-linux64-7.4

Adding Cc: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147006] New: CRASH: deleting content

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147006

Bug ID: 147006
   Summary: CRASH: deleting content
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Created attachment 177814
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177814=edit
sample file

Steps to reproduce:
1. Open attached document
2. Select All
3. Cut or Delete

-> Crash

Reproduced in

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 4935bb372e3618eca105997c83101aa2b3d422e3
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 89449] Line connectors become shape objects in Impress when opening Microsoft .PPTX file format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89449

Tibor Nagy (NISZ)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |nagy.tib...@nisz.hu
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140284] Collabora Office - no new embedded database can be created with database wizard (macOS)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140284

--- Comment #11 from Robert Großkopf  ---
(In reply to Andras Timar from comment #10)
> Collabora Office 21.06 is based on LibreOffice 7.1. Firebird database was
> marked as experimental feature in LibreOffice 7.1. Therefore you have to
> enable experimental features on Preferences - Colabora Office - Advanced
> tab. Then you have Firebird.

Seems a little bit confusing:
Alex wrote about any embedded database an MacOS.
Your answer is about Firebird, not about the default HSQLDB.
Why did you switch it as worksforme, while Alex still could confirm the bug
with the same version. Did you really test it with Mac OS X 11.4?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139737] EDITING: Undo deletes everything after Paste Special as RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139737

Michael Stahl (allotropia)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de
   |desktop.org |
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Michael Stahl (allotropia)  ---
this was a corner case where inserting a file created new header/footer, which
we can't undo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: ucb/README.md

[Michael Stahl (via logerrit)]

 ucb/README.md |   39 ---
 1 file changed, 32 insertions(+), 7 deletions(-)

New commits:
commit a3a6ef172927087d4d98f1e04f428de870db3c8c
Author: Michael Stahl 
AuthorDate: Fri Jan 14 19:08:44 2022 +0100
Commit: Michael Stahl 
CommitDate: Wed Jan 26 18:50:07 2022 +0100

ucb: add more webdav-curl doc to README

Change-Id: I50a56f9f5b0126c46133129d62464e0171dc40f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128422
Tested-by: Michael Stahl 
Reviewed-by: Michael Stahl 

diff --git a/ucb/README.md b/ucb/README.md
index bd451b4c9e8c..4d31280779a1 100644
--- a/ucb/README.md
+++ b/ucb/README.md
@@ -7,7 +7,7 @@ various DMS and fileshare systems like WebDAV, CMIS, or GIO.
 The UCPs implement the Universal Content Provider UNO interfaces in
 C++, in particular the `com.sun.star.ucb.ContentProvider` service.
 
-## WebDAV ucp
+## WebDAV UCP
 
 The WebDAV content provider is based on `libcurl` for much of the
 network and protocol stuff, including authentication.
@@ -36,18 +36,43 @@ server idiosyncrasies:
 * Nextcloud will reply to a PROPFIND request with "100 Continue" and
   then after the data is uploaded it will send a "401 Unauthorized" if
   the auth header is missing in the headers to which it replied with
-  "100 Continue". So we reuse that.
-* Sharepoint 16 responds to PROPFIND with "Transfer-Encoding: chunked"
+  "100 Continue".
+* Sharepoint 16 responds to PROPFIND, PROPPATCH and LOCK with
+  "Transfer-Encoding: chunked"
   with "HTTP/1.1 200 OK" and an actual error message in the response *body*.
   * apparently setting Content-Length works better, so we use that
-  * Sharepoint 16 has the same problem with PROPFIND.
-  * and for when using chunked encoding for LOCK
 * Sharepoint returns redirect urls that curl can't parse, so we encode
   them (check `WebDAVResponseParser` for the code)
+* Sharepoint may reply to HEAD with 200 OK but then 404 NOT FOUND to PROPFIND
+* Sharepoint does not appear to support Dead Properties
 * avoiding chunked encoding for PUT, since for Nextcloud:
   * Transfer-Encoding: chunked creates a 0 byte file with response
 "201 Created"
   * see upstream bug: https://github.com/nextcloud/server/issues/7995
-  * apparently this doesn't happen with header Content-Length: 8347,
-so we use that
+
+To a first approximation, there are 3 parts involved in the UCP:
+
+* The upper layer implements the UNO API which is called by LibreOffice, and
+  translates the calls from generic sequence-of-any stringly typed abstractness
+  into HTTP or WebDAV protocol calls, and does some high level protocol
+  handling to figure out what the server supports and so on. This is is
+  independent of the low-level library.
+* Then there is the lower layer of the UCP, which translates the generic HTTP
+  or WebDAV protocol calls to something that the particular third-party library
+  can understand, hook up its callbacks for data transfer and authentication,
+  and parse the reply XML documents.
+* At the bottom, there is the third-party library that implements the HTTP
+  protocol.
+
+The most important classes are:
+* ContentProvider: the UNO entry point/factory, creates Content instances
+* Content: the main UNO service, translates the UCP API to WebDAV methods,
+  one instance per URL
+* DAVResourceAccess: sits between Content and CurlSession
+* DAVSessionFactory: creates CurlSession for DAVResourceAccess
+* CurlSession: low-level interfacing with libcurl
+* SerfLockStore: singleton used by CurlSession to store DAV lock tokens, runs
+  a thread to refresh locks when they expire
+* WebDAVResponseParser: parse XML responses to LOCK, PROPFIND requests
+* DAVAuthListener_Impl: request credentials from UI via UNO
 

[Libreoffice-commits] core.git: sw/qa

[Michael Stahl (via logerrit)]

 sw/qa/extras/uiwriter/data/tdf139737.fodt |  306 ++
 sw/qa/extras/uiwriter/uiwriter3.cxx   |   24 ++
 2 files changed, 330 insertions(+)

New commits:
commit cd62fa66a7b57c1cdcbf7cdbdf155edf8e40c9fc
Author: Michael Stahl 
AuthorDate: Wed Jan 26 16:54:54 2022 +0100
Commit: Michael Stahl 
CommitDate: Wed Jan 26 18:49:16 2022 +0100

tdf#139737 sw_fieldmarkhide: add unit test

Change-Id: I4adfed97a00db71d42bbc4771221f5ebde43197c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128997
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/sw/qa/extras/uiwriter/data/tdf139737.fodt 
b/sw/qa/extras/uiwriter/data/tdf139737.fodt
new file mode 100644
index ..ff9fcfe2105e
--- /dev/null
+++ b/sw/qa/extras/uiwriter/data/tdf139737.fodt
@@ -0,0 +1,306 @@
+
+http://openoffice.org/2009/office; 
xmlns:css3t="http://www.w3.org/TR/css3-text/; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns
 :config:1.0" xmlns:xlink="http://www.w3.org/1999/xlink; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:script="ur
 n:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:xforms="http://www.w3.org/2002/xforms; office:version="1.3" 
office:mimetype="application/vnd.oasis.opendocument.text">
+ 
xiscoxisco112020-05-29T10:25:002020-05-29T10:32:00PT7MLibreOfficeDev/7.3.1.0.0$Linux_X86_64
 
LibreOffice_project/54cda94175f372695c55576817e3ae14655598ea14.
+ 
+  
+  
+  
+  
+  
+  
+ 
+ 
+  
+   
+   
+
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+ 
+
+   
+   
+  
+  
+   
+  
+  
+   
+
+ 
+ 
+
+   
+  
+  
+   
+  
+  
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+   
+
+ 
+
+   
+  
+  
+  
+  
+  
+   
+  
+ 
+ 
+  
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+  
+  
+   
+
+   
+  
+  
+   
+
+   
+   
+   
+
+   
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+
+   
+   
+   
+
+   
+  
+  
+   
+
+   
+   
+   
+  
+  
+   
+  
+ 
+ 
+  
+   
+
+   
+  
+  
+  
+   
+
+   
+  
+  
+ 
+  
+   
+
+
+
+
+
+   
+   
+   
+x
+
+x
+
+
+
+
+
+
+
+
+
+
+
+x
+
+
+
+
+
+
+
+
+
+
+
+
+
+x
+
+
+
+   
+  
+ 
+
\ No newline at end of file
diff --git a/sw/qa/extras/uiwriter/uiwriter3.cxx 
b/sw/qa/extras/uiwriter/uiwriter3.cxx
index 642dec7b812a..dc52dafe92ec 100644
--- a/sw/qa/extras/uiwriter/uiwriter3.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter3.cxx
@@ -592,6 +592,30 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest3, 

[Libreoffice-bugs] [Bug 139737] EDITING: Undo deletes everything after Paste Special as RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139737

--- Comment #4 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cd62fa66a7b57c1cdcbf7cdbdf155edf8e40c9fc

tdf#139737 sw_fieldmarkhide: add unit test

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139737] EDITING: Undo deletes everything after Paste Special as RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139737

--- Comment #3 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/94ef342679629c76eff2686243b423e926bbf680

tdf#139737 sw_fieldmarkhide: writerfilter: don't copy header/footer

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139737] EDITING: Undo deletes everything after Paste Special as RTF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139737

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: writerfilter/source

[Michael Stahl (via logerrit)]

 writerfilter/source/dmapper/PropertyMap.cxx |   13 +
 writerfilter/source/dmapper/PropertyMap.hxx |3 ++-
 2 files changed, 11 insertions(+), 5 deletions(-)

New commits:
commit 94ef342679629c76eff2686243b423e926bbf680
Author: Michael Stahl 
AuthorDate: Wed Jan 19 19:35:15 2022 +0100
Commit: Michael Stahl 
CommitDate: Wed Jan 26 18:48:48 2022 +0100

tdf#139737 sw_fieldmarkhide: writerfilter: don't copy header/footer

... when inserting into an existing document.

The header/footer will not be removed by SwUndoInserts::UndoImpl() and
thus the extra nodes will screw up subsequent Undo actions.

Inserting a header from a file is already disabled, but there is a
function that copies from a preceding page style that was missing a
check.

This never worked and reportedly crashes since commit
4dc1615c80e8e66d339dc86fa95bbc76e884d988

Change-Id: I895d867ee9fd30a936144492f3ee1633d045fe8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128635
Tested-by: Jenkins
Reviewed-by: Michael Stahl 

diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 58871cc04538..dabdff851a9c 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -882,13 +882,18 @@ void SectionPropertyMap::CopyHeaderFooterTextProperty( 
const uno::Reference< bea
 }
 
 // Copy headers and footers from the previous page style.
-void SectionPropertyMap::CopyHeaderFooter( const uno::Reference< 
beans::XPropertySet >& xPrevStyle,
+void SectionPropertyMap::CopyHeaderFooter( DomainMapper_Impl& rDM_Impl,
+   const uno::Reference< 
beans::XPropertySet >& xPrevStyle,
const uno::Reference< 
beans::XPropertySet >& xStyle,
bool bOmitRightHeader,
bool bOmitLeftHeader,
bool bOmitRightFooter,
bool bOmitLeftFooter )
 {
+if (!rDM_Impl.IsNewDoc())
+{   // see also DomainMapper_Impl::PushPageHeaderFooter()
+return; // tdf#139737 SwUndoInserts cannot deal with new header/footer
+}
 bool bHasPrevHeader = false;
 bool bHeaderIsShared = true;
 OUString sHeaderIsOn = getPropertyName( PROP_HEADER_IS_ON );
@@ -966,13 +971,13 @@ void SectionPropertyMap::CopyLastHeaderFooter( bool 
bFirstPage, DomainMapper_Imp
 
 if ( bFirstPage )
 {
-CopyHeaderFooter( xPrevStyle, xStyle,
+CopyHeaderFooter(rDM_Impl, xPrevStyle, xStyle,
 !m_bFirstPageHeaderLinkToPrevious, true,
 !m_bFirstPageFooterLinkToPrevious, true );
 }
 else
 {
-CopyHeaderFooter( xPrevStyle, xStyle,
+CopyHeaderFooter(rDM_Impl, xPrevStyle, xStyle,
  !m_bDefaultHeaderLinkToPrevious,
  !(m_bEvenPageHeaderLinkToPrevious && 
bUseEvenPages),
  !m_bDefaultFooterLinkToPrevious,
@@ -1851,7 +1856,7 @@ void SectionPropertyMap::CloseSectionGroup( 
DomainMapper_Impl& rDM_Impl )
 rDM_Impl.GetPageStyles()->insertByName( evenOddStyleName, 
uno::makeAny( evenOddStyle ) );
 evenOddStyle->setPropertyValue( "HeaderIsOn", uno::makeAny( 
false ) );
 evenOddStyle->setPropertyValue( "FooterIsOn", uno::makeAny( 
false ) );
-CopyHeaderFooter( pageProperties, evenOddStyle );
+CopyHeaderFooter(rDM_Impl, pageProperties, evenOddStyle);
 *pageStyle = evenOddStyleName; // And use it instead of the 
original one (which is set as follow of this one).
 if ( m_nBreakType == 
static_cast(NS_ooxml::LN_Value_ST_SectionMark_evenPage) )
 evenOddStyle->setPropertyValue( getPropertyName( 
PROP_PAGE_STYLE_LAYOUT ), uno::makeAny( style::PageStyleLayout_LEFT ) );
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx 
b/writerfilter/source/dmapper/PropertyMap.hxx
index 3314ce7451ae..b03ef7bd664c 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -299,7 +299,8 @@ private:
 
 void CopyLastHeaderFooter( bool bFirstPage, DomainMapper_Impl& rDM_Impl );
 
-static void CopyHeaderFooter( const css::uno::Reference< 
css::beans::XPropertySet >& xPrevStyle,
+static void CopyHeaderFooter( DomainMapper_Impl& rDM_Impl,
+  const css::uno::Reference< 
css::beans::XPropertySet >& xPrevStyle,
   const css::uno::Reference< 
css::beans::XPropertySet >& xStyle,
   bool bOmitRightHeader = false, bool 
bOmitLeftHeader = false,
   bool bOmitRightFooter = false, bool 

[Libreoffice-bugs] [Bug 147005] New: [Linux Flatpak] LibreOffice doesn't stop "saving" where it can't write to, then "deletes" the "file" that never existed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147005

Bug ID: 147005
   Summary: [Linux Flatpak] LibreOffice doesn't stop "saving"
where it can't write to, then "deletes" the "file"
that never existed
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: barrett...@owageskuo.com

Description:
Currently LibreOffice flatpak does not provide an error/warning prompt when it
is not able to save to a location it does not have access to view
flatseal/bubblewrap.

What occurs, is the user is able to use File menu Save as and pick any location
(even if LibreOffice flatpak does not have access) to save in the file picker
window that appears. Even if you use that file picker to do another save as or
open you can see the file that was created along with the .lock file.

However, if the user looks with their own integrated file explorer which is
Dolphin for me they will see the files were never actually created. Neither the
regular file or .lock.

This makes me curious if this is a bug in:
1) LibreOffice Flatpak
2) Integrated file picker/explorer
3) Bubblewrap/Flatseal
4) Flatpak itself

It is concerning that LibreOffice flatpak "creates" a file that can be seen in
the file picker/explorer pop up but not outside of it.


Steps to Reproduce:
1. Create a document in LibreOffice Calc flatpak
2. Write some stuff
3. Click File and Save as in the menu bar. "save" it to a location there is no
access via flatseal LibreOffice Calc "thinks" the file is saved there as the
file picker suggets
4. Navigate to that location in your file explorer (Dolphin for me).
5. Close LibreOffice Calc flatpak
6. Reopen LibreOffice Calc flatpak
7. The file never existed in LibreOffice Calc apparently
8. Cry because you lost hours of work.

Actual Results:
The file is nowhere to be found.

Expected Results:
LibreOffice would warn the user that they are not able to save to that
directory due to lacking permissions in flatseal/bubblewrap.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Operating System: Arch Linux
KDE Plasma Version: 5.23.5
KDE Frameworks Version: 5.90.0
Qt Version: 5.15.2
Kernel Version: 5.15.16-hardened1-1-hardened (64-bit)
Graphics Platform: X11

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143002] [META] Tracked Changes of tables

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143002
Bug 143002 depends on bug 146966, which changed state.

Bug 146966 Summary: FILEEDIT ODT Moving multiple rows inserts also empty rows 
(not related to change tracking
https://bugs.documentfoundation.org/show_bug.cgi?id=146966

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146966] FILEEDIT ODT Moving multiple rows inserts also empty rows (not related to change tracking

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146966

László Németh  changed:

   What|Removed |Added

   Keywords|filter:odt  |regression
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
   Assignee|nem...@numbertext.org   |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #4 from László Németh  ---
Add keyword "regression".

Commit description:

tdf#146966 sw: fix inserting empty rows at copying multiple rows

HTML expansion of the clipboard content is used to calculate the
row number of the table on the clipboard. Skip its empty 
elements here, similar to Paste As HTML in Edit->Paste Special->
Paste Special... to avoid inserting empty rows (e.g. selecting and
copying/moving 4 rows inserted 30 extra empty rows).

Note: likely this was a regression, related to the new empty
rows in the clipboard/expansion code.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146974] Scrolling with mouse pastes data in randm cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146974

--- Comment #5 from David Bryant  ---
Well, so far that seems to have done the trick. I'll write back in a week or so
to confirm.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146862] VIEWING: If document background is set to black, Formula remains black in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146862

--- Comment #11 from LeroyG  ---
In the sample file attached at comment 4, toggling the Edit Mode (Ctrl+Shift+M)
make all formulas take the actual font color.

Not reproducible in the sample file attached at comment 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[László Németh (via logerrit)]

 sw/qa/extras/uiwriter/uiwriter2.cxx  |   36 +++
 sw/source/uibase/dochdl/swdtflvr.cxx |7 +-
 2 files changed, 42 insertions(+), 1 deletion(-)

New commits:
commit 6ad9a3d74ef6eae3e645df12dedbe059acc180c4
Author: László Németh 
AuthorDate: Wed Jan 26 13:44:39 2022 +0100
Commit: László Németh 
CommitDate: Wed Jan 26 18:09:53 2022 +0100

tdf#146966 sw: fix inserting empty rows at copying multiple rows

HTML expansion of the clipboard content is used to calculate the
row number of the table on the clipboard. Skip its empty 
elements here, similar to Paste As HTML in Edit->Paste Special->
Paste Special... to avoid inserting empty rows (e.g. selecting and
copying/moving 4 rows inserted 30 extra empty rows).

Note: likely this was a regression, related to the new empty
rows in the clipboard/expansion code.

Change-Id: I58b16c7869c08cda7e2a2c21c3c03bf38446d826
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128986
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx 
b/sw/qa/extras/uiwriter/uiwriter2.cxx
index a1fc810fafec..f730a0285d87 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -5156,6 +5156,42 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, 
testPasteTrackedTableRowInHideChangesMode)
 CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable->getRows()->getCount());
 }
 
+CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf146966)
+{
+// load a 4-row table, select more than 1 row and copy them
+// to check insertion of unnecessary empty rows
+SwDoc* pDoc = createSwDoc(DATA_DIRECTORY, "tdf144748.fodt");
+
+// check table row count
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTextTablesSupplier->getTextTables(),
+uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables->getCount());
+uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+
+// copy table row and paste it by Paste Special->Rows Above
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->Down(/*bSelect=*/false);
+dispatchCommand(mxComponent, ".uno:SelectTable", {});
+dispatchCommand(mxComponent, ".uno:Copy", {});
+dispatchCommand(mxComponent, ".uno:Escape", {});
+dispatchCommand(mxComponent, ".uno:PasteRowsBefore", {});
+
+// This was 35 (extra empty rows)
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), xTable->getRows()->getCount());
+
+dispatchCommand(mxComponent, ".uno:Undo", {});
+dispatchCommand(mxComponent, ".uno:Undo", {});
+dispatchCommand(mxComponent, ".uno:Undo", {}); // FIXME Why 3 Undos?
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xTable->getRows()->getCount());
+
+dispatchCommand(mxComponent, ".uno:Redo", {});
+dispatchCommand(mxComponent, ".uno:Redo", {});
+CPPUNIT_ASSERT_EQUAL(sal_Int32(8), xTable->getRows()->getCount());
+// dispatchCommand(mxComponent, ".uno:Redo", {}); // FIXME assert
+}
+
 CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testTdf145091)
 {
 // load a deleted table, reject them, and delete only its text and export 
to DOCX
diff --git a/sw/source/uibase/dochdl/swdtflvr.cxx 
b/sw/source/uibase/dochdl/swdtflvr.cxx
index 883ada5147b8..65fefd68804b 100644
--- a/sw/source/uibase/dochdl/swdtflvr.cxx
+++ b/sw/source/uibase/dochdl/swdtflvr.cxx
@@ -1569,8 +1569,13 @@ bool SwTransferable::Paste(SwWrtShell& rSh, 
TransferableDataHelper& rData, RndSt
 while((nIdx = aExpand.indexOf(sSearchRowOrCol, nIdx)) > -1)
 {
 // skip rows/columns of nested tables, based on HTML 
indentation
-if (nIdx > 2 && (aExpand[nIdx-1] != '\t' || aExpand[nIdx-2] != 
'\t' || (bShifted && aExpand[nIdx-3] != '\t')))
+if ( nIdx > 3 && (aExpand[nIdx-1] != '\t' || aExpand[nIdx-2] 
!= '\t' ||
+( bShifted && aExpand[nIdx-3] != '\t') ) &&
+// skip also strange hidden empty rows 
+!aExpand.match("", nIdx - 4) )
+{
 ++nSelectedRowsOrCols;
+}
 ++nIdx;
 }
 // are we at the beginning of the cell?

RE: ~20s delay on startup of LO 7.2.3.2 x64 with regular user on win10

[Marc]

> > Is there some issue known about startup issues with LO 7.2.3.2 with a
> > regular user under windows 10. The delay is around 20 seconds on the
> > 'LibreOffice community' progress bar (at the end)
> >
> > LO starts fast (no delay) when ran from the Administrator account.
> >
> > Removing the C:\Users\%user%\AppData\Roaming\LibreOffice\4\* does not
> > change anything, still ~20s delay.
> >
> > PS. this test setup is not connected to the internet. But I guess that
> > does not an issue, as the administrator account start fast.
> 
> Please use the bug tracker:
> https://wiki.documentfoundation.org/QA/BugReport
> 

Ok thanks filing it there, keeps returning with new users.

[Libreoffice-commits] core.git: filter/uiconfig

[Caolán McNamara (via logerrit)]

 filter/uiconfig/ui/warnpdfdialog.ui |1 -
 1 file changed, 1 deletion(-)

New commits:
commit f25d5b11d6151978ad0b7ff3c4161cbc2cc8aded
Author: Caolán McNamara 
AuthorDate: Wed Jan 26 15:54:09 2022 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 26 18:04:23 2022 +0100

this should be a normal dialog type

Change-Id: I1c8c180b521c3cd2def35fca93b3f299ca437dd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128996
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/filter/uiconfig/ui/warnpdfdialog.ui 
b/filter/uiconfig/ui/warnpdfdialog.ui
index ec4274e8166e..21b455f00e99 100644
--- a/filter/uiconfig/ui/warnpdfdialog.ui
+++ b/filter/uiconfig/ui/warnpdfdialog.ui
@@ -15,7 +15,6 @@
   
 False
 6
-popup
 Problems During PDF Export
 False
 True

[Libreoffice-commits] core.git: filter/uiconfig

[Caolán McNamara (via logerrit)]

 filter/uiconfig/ui/warnpdfdialog.ui |   57 +---
 1 file changed, 27 insertions(+), 30 deletions(-)

New commits:
commit 59491bb67c52be32dd9a079a966ce802cbc0b239
Author: Caolán McNamara 
AuthorDate: Wed Jan 26 15:49:52 2022 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 26 18:03:51 2022 +0100

resave with latest glade

Change-Id: I10ebd53c21670242c49332068a1d5b04e6f58fc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128995
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/filter/uiconfig/ui/warnpdfdialog.ui 
b/filter/uiconfig/ui/warnpdfdialog.ui
index 6ff3a2bc097b..ec4274e8166e 100644
--- a/filter/uiconfig/ui/warnpdfdialog.ui
+++ b/filter/uiconfig/ui/warnpdfdialog.ui
@@ -1,5 +1,5 @@
 
-
+
 
   
   
@@ -13,78 +13,78 @@
 
   
   
-False
-6
+False
+6
 popup
 Problems During PDF Export
 False
 True
-dialog
-True
-warning
+dialog
+True
+warning
 ok
 During PDF export the following problems 
occurred:
 
   
-False
+False
 True
 True
 vertical
 12
 
   
-False
+False
   
   
 False
 True
-end
+end
 0
   
 
 
-  
+  
   
 True
-False
+False
 True
 True
-12
-True
+12
+True
 
   
 True
-False
+False
 True
 True
 True
-30
-30
+30
+30
 0
 0
   
   
-1
-0
+1
+0
   
 
 
   
 True
-True
+True
 True
 True
-in
+in
 
   
 True
-True
+True
 True
 liststore1
-False
-False
-1
-False
+False
+False
+1
+False
 
   
 
@@ -112,8 +112,8 @@
 
   
   
-0
-0
+0
+0
   
 
   
@@ -125,8 +125,5 @@
 
   
 
-
-  
-
   
 

[Libreoffice-commits] core.git: sc/uiconfig

[Caolán McNamara (via logerrit)]

 sc/uiconfig/scalc/ui/warnautocorrect.ui |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 5c6285da8b0008f3ba0499a4e297864d117d7906
Author: Caolán McNamara 
AuthorDate: Wed Jan 26 15:43:43 2022 +
Commit: Caolán McNamara 
CommitDate: Wed Jan 26 18:03:21 2022 +0100

warning is a dialog not a popup

with the wrong setting it appears misplaced on a multi-monitor setup

Change-Id: I43faeb72f6678a653feef82e0f0deaf87c039e9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128994
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/uiconfig/scalc/ui/warnautocorrect.ui 
b/sc/uiconfig/scalc/ui/warnautocorrect.ui
index 02c1cf055473..f8cf563fd123 100644
--- a/sc/uiconfig/scalc/ui/warnautocorrect.ui
+++ b/sc/uiconfig/scalc/ui/warnautocorrect.ui
@@ -5,7 +5,6 @@
   
 False
 6
-popup
 True
 dialog
 True

[Libreoffice-bugs] [Bug 146862] VIEWING: If document background is set to black, Formula remains black in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146862

--- Comment #10 from LeroyG  ---
Created attachment 177813
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177813=edit
Thumbnail of the document in the start center

It can be seen the lines 1, 2 and 4 of the table with black font color.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146862] VIEWING: If document background is set to black, Formula remains black in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146862

--- Comment #9 from LeroyG  ---
Created attachment 177812
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177812=edit
Screenshot with background color set to black

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146862] VIEWING: If document background is set to black, Formula remains black in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146862

--- Comment #8 from LeroyG  ---
Created attachment 177811
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177811=edit
PDF from the previous .odt document

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146862] VIEWING: If document background is set to black, Formula remains black in Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146862

--- Comment #7 from LeroyG  ---
Created attachment 177810
  --> https://bugs.documentfoundation.org/attachment.cgi?id=177810=edit
A document with a formula testing multiple font colors, and anchor options

Test made with all "Light  4" (and a few other) colors of the standard
color pallete.

For Font Color values of Automatic, White and Light Yellow 4, the formula is
shown in black.

There may be other light colors with the same result.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146992] Arrowheads in dropdowns shift a little when opened

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146992

--- Comment #4 from Commit Notification 
 ---
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/53e5f7e031ebb35de29f569cc70d0d5967263873

tdf#146992 gtk_window_set_attached_to causing widgets to shift

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146992] Arrowheads in dropdowns shift a little when opened

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146992

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0|target:7.4.0 target:7.3.1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 53e5f7e031ebb35de29f569cc70d0d5967263873
Author: Caolán McNamara 
AuthorDate: Wed Jan 26 14:54:55 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Jan 26 17:43:11 2022 +0100

tdf#146992 gtk_window_set_attached_to causing widgets to shift

which isn't desirable, just drop its use.

Change-Id: Ic29efa9e785cad3c221e0ef37816b8485979e719
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128957
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 515eabb1fe73..bb6779af6cf9 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -9659,8 +9659,6 @@ GtkPositionType show_menu_older_gtk(GtkWidget* 
pMenuButton, GtkWindow* pMenu, co
 else
 x += nButtonWidth;
 
-gtk_window_set_attached_to(pMenu, pMenuButton);
-
 gtk_window_group_add_window(gtk_window_get_group(GTK_WINDOW(pToplevel)), 
pMenu);
 gtk_window_set_transient_for(pMenu, GTK_WINDOW(pToplevel));
 
@@ -9790,8 +9788,6 @@ bool show_menu_newer_gtk(GtkWidget* pComboBox, GtkWindow* 
pMenu, const GdkRectan
 gtk_coord x, y;
 gtk_widget_translate_coordinates(pComboBox, pToplevel, rAnchor.x, 
rAnchor.y, , );
 
-gtk_window_set_attached_to(pMenu, pComboBox);
-
 gtk_widget_realize(GTK_WIDGET(pMenu));
 gtk_window_group_add_window(gtk_window_get_group(GTK_WINDOW(pToplevel)), 
pMenu);
 gtk_window_set_transient_for(pMenu, GTK_WINDOW(pToplevel));

[Libreoffice-bugs] [Bug 146953] RTF document being opened in Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=146953

--- Comment #5 from Vasily Melenchuk (CIB)  ---
Thanks for extra info for this problem.

Anyway situation looks strange for me:
1. RTF is a text format and it is expected to be opened in Writer.
2. Different behavior described in this bug is not the good UX experience imho:
it is quite a surprise to realize that RTF can be opened by Writer or by Calc
depending on absolutely unrelated document type I'm editing right now.
3. The behavior is not consistent: we are trying to expand RTF tables from file
to calc spreadsheet, but why we are not doing so for DOC, DOCX or even ODT?
They are also text formats with tables.
4. Opened by Calc RTF we can't save back to RTF.
5. If there is real need to have RTF table in Calc, it can be opened in Writer
and copy-pasted to Calc.

I'm not sure, if this is intended behavior or side-effect from introducing RTF
filter for Calc (for example, to use copy-paste). implementation is done in
bunch of commits starting from:
>commit ed55b27bae9f7517863216e9bcc0312d7e48b35b
>Author: Kurt Zenker 
>Date:   Wed Jan 28 15:22:14 2004 +
>
>INTEGRATION: CWS filtercfg (1.1.2); FILE ADDED
>2003/10/02 11:25:02 as 1.1.2.1: #102620# first revision

-- 
You are receiving this mail because:
You are the assignee for the bug.