[Libreoffice-bugs] [Bug 144777] countifs() in Calc is slower than Excel's countifs()
https://bugs.documentfoundation.org/show_bug.cgi?id=144777 --- Comment #26 from Shad Sterling --- The problem I reported in bug 146546 seems to be triggered by selecting a cell that contains the triggering formula, but not when recalculating that same cell in response to changes in referenced cells. It makes LibreOffice unusable for several hours, sometimes across killing and relaunching the app -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 --- Comment #8 from Timur --- No need to inflate bugs, rather all should be tested in older versions to see if a regression. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146804] FILESAVE Dashed lines do not export properly to EPS file
https://bugs.documentfoundation.org/show_bug.cgi?id=146804 --- Comment #1 from John Fattaruso --- One additional condition for this bug: The dashed line must also be set with a width greater than the default 0. Dashed lines with 0 width actually get exported with proper dash patterns in the EPS file. But for dashed lines set even one step thicker, at 0.2 inch, the exported dash pattern is incorrect as described. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147051] When using the tabbed mode, none of the tab labels are aligned with the colored bottom line
https://bugs.documentfoundation.org/show_bug.cgi?id=147051 --- Comment #1 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177893 --> https://bugs.documentfoundation.org/attachment.cgi?id=177893=edit Misalignment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147051] New: When using the tabbed mode, none of the tab labels are aligned with the colored bottom line
https://bugs.documentfoundation.org/show_bug.cgi?id=147051 Bug ID: 147051 Summary: When using the tabbed mode, none of the tab labels are aligned with the colored bottom line Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 7p1pj...@anonaddy.me Description: When using the tabbed mode, none of the tab labels are aligned with the colored bottom line. Steps to Reproduce: 1. Switch to tabbed mode. Actual Results: The text it's a bit to the left. Expected Results: The text being at the center. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.5.2.0+ Build ID: 20(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Fedora 35, GNOME 41 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147050] [FILEOPEN] NUMBERS table incorrect number formats
https://bugs.documentfoundation.org/show_bug.cgi?id=147050 --- Comment #1 from SheetJS --- Created attachment 177892 --> https://bugs.documentfoundation.org/attachment.cgi?id=177892=edit sample File was generated by opening Numbers 11.2 and creating a new document from the template Basic > Charting Basics -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147050] New: [FILEOPEN] NUMBERS table incorrect number formats
https://bugs.documentfoundation.org/show_bug.cgi?id=147050 Bug ID: 147050 Summary: [FILEOPEN] NUMBERS table incorrect number formats Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: d...@sheetjs.com Description: The attached file was generated by open the "Charting Basics" template in Numbers 11.2 and saving without making changes. When opening with the current release build (7.2.5.2), a number of formats are incorrect: Table "Monthly Sales by Region" (original table in worksheet "Interactive Chart") should have months as column labels, but LO shows raw date codes. A similar issue affects "Comparison of Units Sold by Year" (column headers should be year) Table "Monthly Sales by Region" (original table in worksheet "Interactive Chart") body cells (B2:E5) are formatted as number in Numbers, but LO shows currency. This issue also affects "Comparison of Units Sold by Year" and "Average Rainfall" Table "Average Rainfall" (original table in worksheet "2-Axis Chart") column B is formatted as Number with 2 decimal places, but LO shows integers. Steps to Reproduce: Open Attached File. Actual Results: See Description Expected Results: See Description Reproducible: Always User Profile Reset: Yes Additional Info: See Description -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147049] There is a extra line below the titlebar when using the tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=147049 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> changed: What|Removed |Added Summary|There is a extra line in|There is a extra line below |below the titlebar when |the titlebar when using the |using the tabbed mode |tabbed mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147049] There is a extra line in below the titlebar when using the tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=147049 --- Comment #2 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177891 --> https://bugs.documentfoundation.org/attachment.cgi?id=177891=edit Normal mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147049] There is a extra line in below the titlebar when using the tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=147049 --- Comment #1 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177890 --> https://bugs.documentfoundation.org/attachment.cgi?id=177890=edit Tabbed mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147049] New: There is a extra line in below the titlebar when using the tabbed mode
https://bugs.documentfoundation.org/show_bug.cgi?id=147049 Bug ID: 147049 Summary: There is a extra line in below the titlebar when using the tabbed mode Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 7p1pj...@anonaddy.me Description: I'm using GNOME 42 with Adwaita theme. In tabbed mode, there is a second line above the titlebar line, which creates an odd look. Steps to Reproduce: 1. Switch to tabbed mode. 2. Switch to normal mode. Actual Results: There is a extra line in below the titlebar when using the tabbed mode. Expected Results: The line shouldn't be present, like in normal mode. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.5.2.0+ Build ID: 20(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147047] Some texts in the tab bar are black when using Adwaita Dark (or a dark theme)
https://bugs.documentfoundation.org/show_bug.cgi?id=147047 --- Comment #4 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Additional info: Fedora 35 GNOME 41 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147048] Font is too small in some parts of the tabbed bar
https://bugs.documentfoundation.org/show_bug.cgi?id=147048 --- Comment #2 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Additional info: Fedora 35 GNOME 41 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147048] Font is too small in some parts of the tabbed bar
https://bugs.documentfoundation.org/show_bug.cgi?id=147048 --- Comment #1 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177889 --> https://bugs.documentfoundation.org/attachment.cgi?id=177889=edit Font is too small -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147048] New: Font is too small in some parts of the tabbed bar
https://bugs.documentfoundation.org/show_bug.cgi?id=147048 Bug ID: 147048 Summary: Font is too small in some parts of the tabbed bar Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 7p1pj...@anonaddy.me Description: When using the tabbed mode, the font are too small and it's clearly inconsistent with the rest of the other text displayed in this area. Steps to Reproduce: 1. Switch to tabbed mode and compare. Actual Results: Font size is not consistent with the size that it's hard to read and it's inconsistent with other parts of LibreOffice. Expected Results: The font size being consistent in tabbed bar. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.5.2.0+ Build ID: 20(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147047] Some texts in the tab bar are black when using Adwaita Dark (or a dark theme)
https://bugs.documentfoundation.org/show_bug.cgi?id=147047 --- Comment #3 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177888 --> https://bugs.documentfoundation.org/attachment.cgi?id=177888=edit Tabbed mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147047] Some texts in the tab bar are black when using Adwaita Dark (or a dark theme)
https://bugs.documentfoundation.org/show_bug.cgi?id=147047 --- Comment #2 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177887 --> https://bugs.documentfoundation.org/attachment.cgi?id=177887=edit Switching themes while the app is opened causes this -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147047] Some texts in the tab bar are black when using Adwaita Dark (or a dark theme)
https://bugs.documentfoundation.org/show_bug.cgi?id=147047 --- Comment #1 from 7p1pj...@anonaddy.me <7p1pj...@anonaddy.me> --- Created attachment 177886 --> https://bugs.documentfoundation.org/attachment.cgi?id=177886=edit Grouped bar compact -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147047] New: Some texts in the tab bar are black when using Adwaita Dark (or a dark theme)
https://bugs.documentfoundation.org/show_bug.cgi?id=147047 Bug ID: 147047 Summary: Some texts in the tab bar are black when using Adwaita Dark (or a dark theme) Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 7p1pj...@anonaddy.me Description: Some texts in the tab bar are black when using Adwaita Dark (or a dark theme). This affects the readability. I'm aware about the Don't Theme My App manifesto, but something is wrong with the GTK part of the tab bar. When you switch themes (like from dark to light), LibreOffice gets white but the tab remains black. It might be the related to this issue. Steps to Reproduce: 1. Switch to a dark theme like Adwaita Dark (GNOME) or Breeze Dark (GNOME). 2. Open LibreOffice and change the UI to grouped bar compact/tabbed compact/tabbed Actual Results: Note that some text are black at the right such as "References", "Layout" (when using tabbed mode). The grouped bar compact mode has more black texts such as "File", "Edit", "Styles", "Font" etc. Expected Results: Text being white. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.5.2.0+ Build ID: 20(Build:2) CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146634] Crash in: std::_Tree, std::allocator, 0> >::erase
https://bugs.documentfoundation.org/show_bug.cgi?id=146634 --- Comment #5 from Colin --- I think I have caused duplicated effort: Bug 146497 appears to be related to an identical crash report My apologies if I have wasted your time -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146497] Crash in: std::_Tree, std::allocator, 0> >::erase
https://bugs.documentfoundation.org/show_bug.cgi?id=146497 --- Comment #11 from Colin --- Auditing my reports; Bug 146634 also generated in response to a crash report is the same issue. My apologies, perhaps I should have audited before allowing the crash report off my desktop -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/clipcontext.hxx |4 +-- sc/inc/document.hxx | 28 -- sc/qa/unit/ucalc_copypaste.cxx |2 - sc/source/core/data/clipcontext.cxx |8 +++ sc/source/core/data/column3.cxx |4 +-- sc/source/core/data/column4.cxx |2 - sc/source/core/data/document.cxx| 14 ++--- sc/source/ui/inc/undoblk.hxx|4 +-- sc/source/ui/inc/viewfunc.hxx | 30 sc/source/ui/undo/undoblk.cxx |2 - sc/source/ui/view/viewfun3.cxx | 38 ++-- 11 files changed, 73 insertions(+), 63 deletions(-) New commits: commit e8032897b4a012d8e236211ee6e5ce89fb90492e Author: Kohei Yoshida AuthorDate: Fri Jan 28 22:51:52 2022 -0500 Commit: Kohei Yoshida CommitDate: Sat Jan 29 05:48:34 2022 +0100 Standardize the flag name on bSkipEmptyCells. And document what the flag does. This corresponds with the "Skip empty cells" check box in the Paste Special dialog. Change-Id: Ic6cf9099efbee43f737a1472a4e275839e3d2c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129130 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/sc/inc/clipcontext.hxx b/sc/inc/clipcontext.hxx index ccce671eea65..5754feaaac59 100644 --- a/sc/inc/clipcontext.hxx +++ b/sc/inc/clipcontext.hxx @@ -63,7 +63,7 @@ class SC_DLLPUBLIC CopyFromClipContext final : public ClipContextBase ScConditionalFormatList* mpCondFormatList; bool mbAsLink:1; -bool mbSkipAttrForEmptyCells:1; +bool mbSkipEmptyCells:1; bool mbCloneNotes:1; bool mbTableProtected:1; @@ -126,7 +126,7 @@ public: bool isTableProtected() const; bool isAsLink() const; -bool isSkipAttrForEmptyCells() const; +bool isSkipEmptyCells() const; bool isCloneNotes() const; bool isDateCell( const ScColumn& rCol, SCROW nRow ) const; }; diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx index 85c6829b4a54..87fb59e8980d 100644 --- a/sc/inc/document.hxx +++ b/sc/inc/document.hxx @@ -1628,17 +1628,23 @@ public: const ScMarkData& rMark, InsertDeleteFlags nInsFlag, sc::ColumnSpanSet& rBroadcastSpans ); -/** If pDestRanges is given it overrides rDestRange, rDestRange in this -case is the overall encompassing range. */ -SC_DLLPUBLIC void CopyFromClip( const ScRange& rDestRange, const ScMarkData& rMark, -InsertDeleteFlags nInsFlag, -ScDocument* pRefUndoDoc, -ScDocument* pClipDoc, -bool bResetCut = true, -bool bAsLink = false, -bool bIncludeFiltered = true, -bool bSkipAttrForEmpty = false, -const ScRangeList * pDestRanges = nullptr ); +/** + * Paste data from a clipboard document into this document. + * + * @param rDestRange destination range. + * @param pClipDoc pointer to the clipboard document to copy data from. + * @param bSkipEmptyCells if this flag is set, empty cells in the source + *range in the clipboard document will not overwrite + *the target destination cells. + * @param pDestRanges If pDestRanges is given it overrides rDestRange, where + *rDestRange becomes the overall encompassing range. + */ +SC_DLLPUBLIC void CopyFromClip( +const ScRange& rDestRange, const ScMarkData& rMark, InsertDeleteFlags nInsFlag, +ScDocument* pRefUndoDoc, ScDocument* pClipDoc, +bool bResetCut = true, bool bAsLink = false, +bool bIncludeFiltered = true, bool bSkipEmptyCells = false, +const ScRangeList* pDestRanges = nullptr ); voidCopyMultiRangeFromClip(const ScAddress& rDestPos, const ScMarkData& rMark, InsertDeleteFlags nInsFlag, ScDocument* pClipDoc, diff --git a/sc/qa/unit/ucalc_copypaste.cxx b/sc/qa/unit/ucalc_copypaste.cxx index 61ecdd651d70..50850c59fc2b 100644 --- a/sc/qa/unit/ucalc_copypaste.cxx +++ b/sc/qa/unit/ucalc_copypaste.cxx @@ -457,7 +457,7 @@ void TestCopyPaste::prepareUndoAfterPaste(ScDocumentUniquePtr& pPasteUndoDoc, ScUndoPasteOptions aOptions; // store options for repeat aOptions.nFunction = nFunction; -aOptions.bSkipEmpty = bSkipEmpty; +aOptions.bSkipEmptyCells = bSkipEmpty; aOptions.bTranspose = bTranspose; aOptions.bAsLink = bAsLink; aOptions.eMoveMode = eMoveMode; diff --git a/sc/source/core/data/clipcontext.cxx b/sc/source/core/data/clipcontext.cxx index 0d336940fece..02e2bcc86652 100644 --- a/sc/source/core/data/clipcontext.cxx +++
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/content.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 3be0151bb619786b65499be413de04ad7c343cad
Author: Jim Raykowski
AuthorDate: Thu Jan 27 19:20:07 2022 -0900
Commit: Jim Raykowski
CommitDate: Sat Jan 29 05:13:04 2022 +0100
SwNavigator: check if unselect_all is needed
Change-Id: I2a3914482167700bebf5ff8e67c34f7e31a0be9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129089
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 3a0611152894..9844a92ba774 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -3781,8 +3781,11 @@ void SwContentTree::UpdateTracking()
else
{
// clear treeview selections
-m_xTreeView->unselect_all();
-Select();
+if (m_xTreeView->count_selected_rows() > 0)
+{
+m_xTreeView->unselect_all();
+Select();
+}
}
}
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit.cxx | 14 +++---
editeng/source/editeng/impedit.hxx |2 +-
2 files changed, 12 insertions(+), 4 deletions(-)
New commits:
commit 07e8233298965ed035bc4a285de19ca540e72246
Author: Dennis Francis
AuthorDate: Mon Nov 22 16:34:32 2021 +0530
Commit: Dennis Francis
CommitDate: Sat Jan 29 05:05:35 2022 +0100
lokCalcRTL: selection coords should be mirrored w.r.t output area
Conflicts:
editeng/source/editeng/impedit.cxx
editeng/source/editeng/impedit.hxx
Change-Id: I52bbbd4ca69a599c90c00d25513064b025f72bf4
(cherry picked from commit 04a48ea15b9e692ded4f3012b41e765451669e46)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128900
Tested-by: Jenkins
Reviewed-by: Dennis Francis
diff --git a/editeng/source/editeng/impedit.cxx
b/editeng/source/editeng/impedit.cxx
index 267045460073..1175c28661cd 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -525,6 +525,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel,
vcl::Region* pRegion,
bool bStartHandleVisible = false;
bool bEndHandleVisible = false;
+bool bLOKCalcRTL = mpLOKSpecialPositioning &&
pEditEngine->IsRightToLeft(nStartPara);
auto DrawHighlight = [&, nStartLine = sal_Int32(0), nEndLine =
sal_Int32(0)](
const ImpEditEngine::LineAreaInfo& rInfo) mutable
{
@@ -601,7 +602,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel,
vcl::Region* pRegion,
aTmpRect.SetRight(aLineXPosStartEnd.Max());
aTmpRect.Move(aLineOffset.Width(), 0);
ImplDrawHighlightRect(rTarget, aTmpRect.TopLeft(),
aTmpRect.BottomRight(),
- pPolyPoly ? &*pPolyPoly : nullptr);
+ pPolyPoly ? &*pPolyPoly : nullptr,
bLOKCalcRTL);
}
else
{
@@ -627,7 +628,7 @@ void ImpEditView::DrawSelectionXOR( EditSelection aTmpSel,
vcl::Region* pRegion,
aTmpRect.Move(aLineOffset.Width(), 0);
ImplDrawHighlightRect(rTarget, aTmpRect.TopLeft(),
aTmpRect.BottomRight(),
- pPolyPoly ? &*pPolyPoly : nullptr);
+ pPolyPoly ? &*pPolyPoly : nullptr,
bLOKCalcRTL);
nTmpStartIndex = nTmpEndIndex;
}
}
@@ -664,7 +665,7 @@ void ImpEditView::GetSelectionRectangles(EditSelection
aTmpSel, std::vector
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/gridwin4.cxx | 14 ++
1 file changed, 14 insertions(+)
New commits:
commit 86125f45b8cb608a5f9277fa8013f175496dfe4d
Author: Dennis Francis
AuthorDate: Mon Nov 22 14:29:05 2021 +0530
Commit: Dennis Francis
CommitDate: Sat Jan 29 05:04:00 2022 +0100
lokCalcRTL: fix editcell painting from other views as well
Change-Id: Iac431996570f1f7eb091809442d8781ea60aa9b5
(cherry picked from commit 455d4047487396c3c70d6113ac5d07deecb1d3a1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128899
Tested-by: Jenkins
Reviewed-by: Dennis Francis
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 4ef2e92ad0fd..4f1f1cc49130 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1063,12 +1063,26 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
Point aStart = mrViewData.GetScrPos( nCol1, nRow1,
eOtherWhich );
Point aEnd = mrViewData.GetScrPos( nCol2+1,
nRow2+1, eOtherWhich );
+if (bIsTiledRendering && bLayoutRTL)
+{
+// Transform the cell range X coordinates such
that the edit cell area is
+// horizontally mirrored w.r.t the
(combined-)tile.
+tools::Long nStartTileX =
-o3tl::convert(aOriginalMode.GetOrigin().X(), o3tl::Length::twip,
o3tl::Length::px);
+// Note: nStartTileX is scaled by 2 only to
offset for the addition of
+// the -ve of the same qty (and nScrX) few
lines below.
+tools::Long nMirrorX = 2 * nStartTileX +
aOutputData.GetScrW();
+aStart.setX(nMirrorX - 1 - aStart.X());
+aEnd.setX(nMirrorX - 1 - aEnd.X());
+}
+
// don't overwrite grid
tools::Long nLayoutSign = bLayoutRTL ? -1 : 1;
aEnd.AdjustX( -(2 * nLayoutSign) );
aEnd.AdjustY( -2 );
tools::Rectangle aBackground(aStart, aEnd);
+if (bIsTiledRendering && bLayoutRTL)
+aBackground.Justify();
// Need to draw the background in absolute coords.
Point aOrigin = aOriginalMode.GetOrigin();
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/gridwin4.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 47c793529eabbd1395c7251b91a83efb853950d8 Author: Dennis Francis AuthorDate: Mon Nov 22 14:14:10 2021 +0530 Commit: Dennis Francis CommitDate: Sat Jan 29 05:02:55 2022 +0100 lokCalcRTL: edit cell painting: avoid indent... to match the behaviour in desktop Calc. Change-Id: I615255635500edf375b237abcab0a21ba6153cce (cherry picked from commit 48e6ef20c6bab7029e46d985d67a907147dd2adf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128898 Tested-by: Jenkins Reviewed-by: Dennis Francis diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx index ddd1cff08964..4ef2e92ad0fd 100644 --- a/sc/source/ui/view/gridwin4.cxx +++ b/sc/source/ui/view/gridwin4.cxx @@ -294,7 +294,8 @@ static void lcl_GetEditAreaTLOffset(tools::Long& nOffsetX, tools::Long& nOffsetY rViewData.GetPPTY(), Fraction(1.0), Fraction(1.0), false /* bPrintTwips */); const ScPatternAttr* pPattern = rDoc.GetPattern(rAddr); -nIndent = aEUtil.GetIndent(pPattern); +if (!rDoc.IsLayoutRTL(rAddr.Tab())) +nIndent = aEUtil.GetIndent(pPattern); aEUtil.GetMargins(pPattern, nLeftMargin, nTopMargin, nDummy, nDummy); nOffsetX = nIndent + nLeftMargin; nOffsetY = nTopMargin;
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit.cxx |7 +++
1 file changed, 7 insertions(+)
New commits:
commit 5264f325ab8fc6b7523821a9fc7dd7157a7c66ba
Author: Dennis Francis
AuthorDate: Mon Nov 22 14:12:32 2021 +0530
Commit: Dennis Francis
CommitDate: Sat Jan 29 05:02:12 2022 +0100
lokCalcRTL: text cursor pos should be mirrored w.r.t output area
Change-Id: Ied4e02d2dd30b7132ea1bc5f0d5b717355ed8b4f
(cherry picked from commit 92d2035acc9d13fea46003a2b2650439d6a2f2fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128897
Tested-by: Jenkins
Reviewed-by: Dennis Francis
diff --git a/editeng/source/editeng/impedit.cxx
b/editeng/source/editeng/impedit.cxx
index 3b44e851b821..267045460073 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -1339,6 +1339,13 @@ void ImpEditView::ShowCursor( bool bGotoCursor, bool
bForceVisCursor )
Point aRefPointLogical = GetOutputArea().TopLeft();
// Get the relative coordinates w.r.t refpoint in display hmm.
aCursorRectPureLogical.Move(-aRefPointLogical.X(),
-aRefPointLogical.Y());
+if (pEditEngine->IsRightToLeft(nPara))
+{
+tools::Long nMirrorW = GetOutputArea().GetWidth();
+tools::Long nLeft = aCursorRectPureLogical.Left(), nRight
= aCursorRectPureLogical.Right();
+aCursorRectPureLogical.SetLeft(nMirrorW - nRight);
+aCursorRectPureLogical.SetRight(nMirrorW - nLeft);
+}
// Convert to twips.
aCursorRectPureLogical =
OutputDevice::LogicToLogic(aCursorRectPureLogical, MapMode(eDevUnit),
MapMode(MapUnit::MapTwip));
// "refpoint" in print twips.
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/editutil.cxx |6 --
sc/source/ui/view/gridwin4.cxx | 16 +++-
sc/source/ui/view/viewdata.cxx | 21 +++--
3 files changed, 30 insertions(+), 13 deletions(-)
New commits:
commit 09ed49ae42b7c5368d0ef2774ba4e04aeb9bafdb
Author: Dennis Francis
AuthorDate: Fri Nov 19 10:21:46 2021 +0530
Commit: Dennis Francis
CommitDate: Sat Jan 29 05:01:16 2022 +0100
lokCalcRTL: fix editcell tile painting
Don't use internal gridwindow width to invert the edit area coordinates.
The gridwin width is not in sync with lok client width, and it seems
making them in sync is non-trivial as it currently breaks other things.
For tile-painting, always use the width of visible columns in the
(combined-)tile area as the mirror width.
In the case of LOK + RTL, because we avoid coordinate mirroring based on
gridwin-width, any corresponding adjustments in edit engine paper-size,
output area, visible area are done appropriately.
Advantage of this approach is that the invalidation rectangles sent are
in the document coordinates which is exactly what the client expects! So
no additional coordinate reversal needed in core or in lok client for
invalidation.
Change-Id: I0b687a12dc9344fba9ee772111e759fa16bf
(cherry picked from commit 8266f569c864ae309f362088d42dfb3b952c4267)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128896
Tested-by: Jenkins
Reviewed-by: Dennis Francis
diff --git a/sc/source/core/tool/editutil.cxx b/sc/source/core/tool/editutil.cxx
index 331f50af8b93..56ee97ab7bde 100644
--- a/sc/source/core/tool/editutil.cxx
+++ b/sc/source/core/tool/editutil.cxx
@@ -32,6 +32,7 @@
#include
#include
#include
+#include
#include
#include
@@ -327,9 +328,10 @@ tools::Rectangle ScEditUtil::GetEditArea( const
ScPatternAttr* pPattern, bool bF
pPattern = pDoc->GetPattern( nCol, nRow, nTab );
Point aStartPos = aCellPos;
+bool bIsTiledRendering = comphelper::LibreOfficeKit::isActive();
bool bLayoutRTL = pDoc->IsLayoutRTL( nTab );
-tools::Long nLayoutSign = bLayoutRTL ? -1 : 1;
+tools::Long nLayoutSign = (bLayoutRTL && !bIsTiledRendering) ? -1 : 1;
const ScMergeAttr* pMerge = >GetItem(ATTR_MERGE);
tools::Long nCellX = pDoc->GetColWidth(nCol,nTab);
@@ -428,7 +430,7 @@ tools::Rectangle ScEditUtil::GetEditArea( const
ScPatternAttr* pPattern, bool bF
aStartPos.AdjustY(nDifY );
nCellY -= nDifY;
-if ( bLayoutRTL )
+if ( bLayoutRTL && !bIsTiledRendering )
aStartPos.AdjustX( -(nCellX - 2) );// excluding grid on both sides
// -1 -> don't
overwrite grid
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 4ae520a429fc..ddd1cff08964 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -1146,6 +1146,18 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
Point aStart = mrViewData.GetScrPos( nCol1, nRow1, eWhich );
Point aEnd = mrViewData.GetScrPos( nCol2+1, nRow2+1, eWhich );
+if (bIsTiledRendering && bLayoutRTL)
+{
+// Transform the cell range X coordinates such that the edit cell
area is
+// horizontally mirrored w.r.t the (combined-)tile.
+tools::Long nStartTileX =
-o3tl::convert(aOriginalMode.GetOrigin().X(), o3tl::Length::twip,
o3tl::Length::px);
+// Note: nStartTileX is scaled by 2 only to offset for the
addition of
+// the -ve of the same qty (and nScrX) few lines below.
+tools::Long nMirrorX = 2 * nStartTileX + aOutputData.GetScrW();
+aStart.setX(nMirrorX - 1 - aStart.X());
+aEnd.setX(nMirrorX - 1 - aEnd.X());
+}
+
// don't overwrite grid
tools::Long nLayoutSign = bLayoutRTL ? -1 : 1;
aEnd.AdjustX( -(2 * nLayoutSign) );
@@ -1153,7 +1165,9 @@ void ScGridWindow::DrawContent(OutputDevice ,
const ScTableInfo& rTableI
// set the correct mapmode
tools::Rectangle aBackground(aStart, aEnd);
-tools::Rectangle aBGAbs(aStart, aEnd);
+if (bIsTiledRendering && bLayoutRTL)
+aBackground.Justify();
+tools::Rectangle aBGAbs(aBackground);
if (bIsTiledRendering)
{
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 422b56074ae4..6f51cd24037d 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -1648,6 +1648,7 @@ void ScViewData::SetEditEngine( ScSplitPos eWhich,
// (existing or started) with default alignment extend to the right.
bool bGrowCentered = ( eJust == SvxCellHorJustify::Center );
bool bGrowToLeft = ( eJust == SvxCellHorJustify::Right ); //
visual left
+bool bLOKRTLInvert = (bLOKActive &&
[Libreoffice-bugs] [Bug 146764] LibreOffice Vanilla & Collabora Office - form wizard fails to launch
https://bugs.documentfoundation.org/show_bug.cgi?id=146764 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146763] LOCALHELP: Interval argument help in Spanish for DATEDIF (SIFECHA) function
https://bugs.documentfoundation.org/show_bug.cgi?id=146763 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146814] Crash in: ScBroadcastAreaSlotMachine::AreaBroadcast(ScRange const &, SfxHintId)
https://bugs.documentfoundation.org/show_bug.cgi?id=146814 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146814] Crash in: ScBroadcastAreaSlotMachine::AreaBroadcast(ScRange const &, SfxHintId)
https://bugs.documentfoundation.org/show_bug.cgi?id=146814 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141265] Random characters appear as black boxes at certain zoom levels in windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=141265 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141265] Random characters appear as black boxes at certain zoom levels in windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=141265 --- Comment #9 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140578] Poor performance when running LibreOffice programs as another user in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=140578 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140578] Poor performance when running LibreOffice programs as another user in KDE
https://bugs.documentfoundation.org/show_bug.cgi?id=140578 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143099] Paste Text removes text at destination, v7.1.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=143099 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143099] Paste Text removes text at destination, v7.1.4.2
https://bugs.documentfoundation.org/show_bug.cgi?id=143099 --- Comment #3 from QA Administrators --- Dear dbalt2010, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 59926] FILESAVE breaks Edit Password Protection
https://bugs.documentfoundation.org/show_bug.cgi?id=59926 --- Comment #12 from QA Administrators --- Dear Rainer Bielefeld Retired, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 143652] All of a sudden, the document will begin to scroll out of control, adding multiple blank pages to the document until I close it.
https://bugs.documentfoundation.org/show_bug.cgi?id=143652 --- Comment #2 from QA Administrators --- Dear MAWhitford2, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146912] Opening Calc 7.3.0.2 crashes LibreOffice on Linux Mint 20.3 Cinnamon
https://bugs.documentfoundation.org/show_bug.cgi?id=146912 --- Comment #5 from Óvári --- (In reply to Roman Kuznetsov from comment #4) > Óvári what hardware do you use? Processor: Intel© Celeron© N4000 CPU @ 1.10GHz × 2 > Is there Nvidia videocard there? Graphics Card: Intel Corporation UHD Graphics 605 > I had the same problem , I added my own report to > See also, but I can repro it only on one of my PCs > with Linux Only have computer with Linux Mint 20.3 Cinnamon -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147041] Double-clicking an element in Navigator shows it in the middle of the document view instead of at the top
https://bugs.documentfoundation.org/show_bug.cgi?id=147041 Jim Raykowski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Assignee|libreoffice-b...@lists.free |rayk...@gmail.com |desktop.org | --- Comment #1 from Jim Raykowski --- Hi Buovjaga, I was not able to repro following the STR but looking at the bibisected patch I see what happened: -// force scroll to cursor position when navigating to inactive document -if(!bSel) +// assure visible view area is at cursor position + if (!m_pActiveShell->IsCursorVisible() && !m_pActiveShell->IsFrameSelected() && !m_pActiveShell->IsObjSelected()) The GotoOutline function brings the heading into view so it doesn't get force scroll to the top. Easy enough to revert to previous behavior: https://gerrit.libreoffice.org/c/core/+/129129 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146795] Calc crashes when pasting data into filtered cells (mdds)
https://bugs.documentfoundation.org/show_bug.cgi?id=146795 --- Comment #20 from Kohei Yoshida --- (In reply to Kevin Suo from comment #18) > Is downgrading the LO mdds version an option, in case it will take too long > for a fix, provided that 7.3 is going to be released as "stable" to the > public? >From my POV that makes little sense. But I'll leave that up to TDF. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc.cxx | 36
sc/qa/unit/ucalc_condformat.cxx|7 ---
sc/qa/unit/ucalc_copypaste.cxx |8
sc/qa/unit/ucalc_formula.cxx | 17 -
sc/qa/unit/ucalc_pivottable.cxx| 12
sc/qa/unit/ucalc_sharedformula.cxx | 10 --
sc/qa/unit/ucalc_sort.cxx |5 -
7 files changed, 95 deletions(-)
New commits:
commit 651ff4f195804b206941e6316c5120a914d28b6b
Author: Xisco Fauli
AuthorDate: Fri Jan 28 22:19:26 2022 +0100
Commit: Xisco Fauli
CommitDate: Sat Jan 29 00:58:28 2022 +0100
CppunitTest_sc_ucalc*: remove unused includes
Change-Id: Ia741cd86f36e41282c00670532c407ab896c471c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129126
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index e89ae7c4f5db..8c305df59467 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -10,68 +10,40 @@
#include "helper/debughelper.hxx"
#include "helper/qahelper.hxx"
-#include
-#include
-
#include
-#include
#include
#include
-#include
#include
#include
-#include
#include
#include
-#include
#include
-#include
-#include
#include
-#include
-#include
#include
#include
#include
#include
-#include
#include
-#include
#include
#include
-#include
#include
-#include
-#include
#include
#include
-#include
#include
#include
-#include
#include
#include
-#include
-#include
#include
#include
-#include
#include
#include
-#include
-#include
#include
-#include
-
-#include
-#include
#include
-#include
#include
#include
#include
@@ -84,18 +56,10 @@
#include
#include
#include
-#include
-#include
#include
-#include
#include
-#include
-#include
-#include
-#include
-
class ScUndoPaste;
class ScUndoCut;
diff --git a/sc/qa/unit/ucalc_condformat.cxx b/sc/qa/unit/ucalc_condformat.cxx
index 56ff357a6bb5..64a8d4cba01a 100644
--- a/sc/qa/unit/ucalc_condformat.cxx
+++ b/sc/qa/unit/ucalc_condformat.cxx
@@ -7,14 +7,8 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
-#include
#include "helper/qahelper.hxx"
-#include
-#include
-
-#include
#include
#include
#include
@@ -23,7 +17,6 @@
#include
#include
#include
-#include
#include
diff --git a/sc/qa/unit/ucalc_copypaste.cxx b/sc/qa/unit/ucalc_copypaste.cxx
index dc3a74f2ec8f..61ecdd651d70 100644
--- a/sc/qa/unit/ucalc_copypaste.cxx
+++ b/sc/qa/unit/ucalc_copypaste.cxx
@@ -7,8 +7,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
-#include
#include "helper/debughelper.hxx"
#include "helper/qahelper.hxx"
@@ -20,19 +18,13 @@
#include
#include
#include
-#include
#include
#include
-#include
-#include
-#include
#include
-#include
#include
#include
#include
#include
-#include
#include
#include
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index c0fb17bc1b59..544a3aa15fb0 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -7,46 +7,29 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
#include "helper/debughelper.hxx"
#include "helper/qahelper.hxx"
-#include
-#include
#include
-#include
-#include
-#include
#include
#include
-#include
#include
#include
-#include
#include
#include
#include
#include
#include
#include
-#include
#include
-#include
-#include
#include
#include
#include
-#include
#include
#include
#include
#include
-#include
-#include
-#include
-#include
-
using namespace formula;
namespace {
diff --git a/sc/qa/unit/ucalc_pivottable.cxx b/sc/qa/unit/ucalc_pivottable.cxx
index 9be50c461384..3d2d159a8f96 100644
--- a/sc/qa/unit/ucalc_pivottable.cxx
+++ b/sc/qa/unit/ucalc_pivottable.cxx
@@ -7,13 +7,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
-#include
-#include
-
-#include
-
-#include
#include
#include
#include "helper/qahelper.hxx"
@@ -21,18 +14,13 @@
#include
#include
#include
-#include
-#include
#include
-#include
#include
#include
#include
#include
-#include
#include
-#include
#include
#include
diff --git a/sc/qa/unit/ucalc_sharedformula.cxx
b/sc/qa/unit/ucalc_sharedformula.cxx
index 944c611c5742..2230a5869687 100644
--- a/sc/qa/unit/ucalc_sharedformula.cxx
+++ b/sc/qa/unit/ucalc_sharedformula.cxx
@@ -7,32 +7,22 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
-#include
-#include
#include "helper/debughelper.hxx"
#include "helper/qahelper.hxx"
#include
#include
#include
-#include
-#include
#include
#include
#include
-#include
#include
#include
#include
#include
-#include
#include
-#include
#include
-#include
-
class
[Libreoffice-bugs] [Bug 146795] Calc crashes when pasting data into filtered cells (mdds)
https://bugs.documentfoundation.org/show_bug.cgi?id=146795 --- Comment #19 from Kohei Yoshida --- The short story is that the issue is on the Calc side. The crash is caused by the uses of invalid position hints when modifying the cell store. Sorting that out on the Calc side will fix this issue. Having said that, the issue existed from at least 2014, but somehow it never manifested itself as a crash using the old storage layout of mdds::multi_type_vector (mtv). In 2.0, mtv switched to an alternative layout, and somehow that triggers the crash from invalid position hints more easily. No idea why that is. I have a proof-of-concept fix that fixes the crash, but unfortunately that involves quite a bit of non-trivial change in Calc's CopyFromClip* code which may potentially introduce other regressions if not done right. So I would still need to flesh out my fix there, which may take a while. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/subsequent_export_test.cxx | 31 --- sc/qa/unit/subsequent_export_test2.cxx | 44 - 2 files changed, 75 deletions(-) New commits: commit e35d6030bc1a5bfb4fb96e5499d75189c96b1a10 Author: Xisco Fauli AuthorDate: Fri Jan 28 19:45:43 2022 +0100 Commit: Xisco Fauli CommitDate: Fri Jan 28 23:33:36 2022 +0100 CppunitTest_sc_subsequent_export_test*: remove unused includes Change-Id: Idda4beeabab4a2445cc6d084ab910458e40e2532 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129121 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sc/qa/unit/subsequent_export_test.cxx b/sc/qa/unit/subsequent_export_test.cxx index 872d5122a686..672c95ccf969 100644 --- a/sc/qa/unit/subsequent_export_test.cxx +++ b/sc/qa/unit/subsequent_export_test.cxx @@ -7,53 +7,32 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#include - -#include - #include -#include #include -#include - #include "helper/debughelper.hxx" -#include "helper/qahelper.hxx" #include "helper/xpath.hxx" #include "helper/shared_test_impl.hxx" #include -#include -#include #include #include #include #include -#include -#include -#include #include #include -#include #include #include #include #include -#include #include -#include -#include -#include -#include #include #include #include #include #include -#include #include -#include #include #include #include @@ -61,22 +40,12 @@ #include #include #include -#include #include -#include #include -#include -#include -#include -#include -#include -#include #include #include -#include #include -#include using namespace ::com::sun::star; using namespace ::com::sun::star::uno; diff --git a/sc/qa/unit/subsequent_export_test2.cxx b/sc/qa/unit/subsequent_export_test2.cxx index 3aef467687d2..8313b275d0f5 100644 --- a/sc/qa/unit/subsequent_export_test2.cxx +++ b/sc/qa/unit/subsequent_export_test2.cxx @@ -8,82 +8,38 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#include - -#include - #include -#include - -#include -#include "helper/debughelper.hxx" #include "helper/qahelper.hxx" #include "helper/xpath.hxx" -#include "helper/shared_test_impl.hxx" -#include #include -#include #include #include #include #include -#include #include -#include -#include -#include -#include -#include -#include -#include #include -#include -#include -#include #include #include #include -#include -#include -#include #include #include -#include #include #include -#include -#include -#include -#include -#include -#include -#include #include -#include #include -#include -#include #include #include #include -#include -#include #include #include -#include #include #include #include -#include -#include -#include -#include #include -#include #include #include #include
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #20 from Telesto --- Created attachment 177885 --> https://bugs.documentfoundation.org/attachment.cgi?id=177885=edit BT with symbols Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: c1205c1cf6e08d94e6e2e2753679d99bc1842ca0 CPU threads: 8; OS: Mac OS X 12.0.1; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded OK it does happen with my own build -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 100998] Add an option in Writer Configuration to disable selected text drag'n'drop when editing
https://bugs.documentfoundation.org/show_bug.cgi?id=100998 peterjdelmo...@gmail.com changed: What|Removed |Added CC||peterjdelmo...@gmail.com --- Comment #13 from peterjdelmo...@gmail.com --- Being able to disable drag-and-drop text editing would be a very useful enhancement for me, also. I far prefer to use Ctrl-X / Ctrl-V for moving text. It's much more accurate, and less prone to accidents. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: bin/check-elf-dynamic-objects
bin/check-elf-dynamic-objects |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d6cbf5532b843a3f189c9df2481c3003690dda73
Author: Stephan Bergmann
AuthorDate: Fri Jan 28 19:04:11 2022 +0100
Commit: Stephan Bergmann
CommitDate: Fri Jan 28 22:07:45 2022 +0100
Fix CustomTarget_postprocess/check_dynamic_objects for --enable-dconf...
...plus --enable-mergelibs, like 4a2db3545a023468e191a5ec89a6343b7aef2ef2
"Fix CustomTarget_postprocess/check_dynamic_objects for --enable-dconf"
Change-Id: I981ab82ecf2a459b384e243260a9611f6016acf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129119
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/bin/check-elf-dynamic-objects b/bin/check-elf-dynamic-objects
index e19bbaeadfe8..f23363da84fa 100755
--- a/bin/check-elf-dynamic-objects
+++ b/bin/check-elf-dynamic-objects
@@ -185,7 +185,7 @@ local file="$1"
fi
;;
*/libmergedlo.so)
-allowlist="${allowlist} ${x11allowlist} ${openglallowlist}
${gioallowlist} libcups.so.2 libcairo.so.2"
+allowlist="${allowlist} ${x11allowlist} ${openglallowlist}
${gioallowlist} ${dconfallowlist} libcups.so.2 libcairo.so.2"
;;
esac
if test "${skip}" = 0 && readelf -d "${file}" &> /dev/null ; then
[Libreoffice-bugs] [Bug 147045] Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147045 m.a.riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #4 from m.a.riosv --- Please test with a clean profile, Menu/Help/Restart in Safe Mode -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145779] Text Cursor disappear when you click in any drop-down list
https://bugs.documentfoundation.org/show_bug.cgi?id=145779 --- Comment #7 from xi...@web.de --- In 7.2.5.1 with kde I have the same issue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: download.lst external/expat
download.lst|4 -
external/expat/CVE-2022-23852.patch | 115
external/expat/CVE-2022-23990.patch | 71 +++
external/expat/UnpackedTarball_expat.mk |2
external/expat/expat-winapi.patch | 15 +---
5 files changed, 196 insertions(+), 11 deletions(-)
New commits:
commit 43d04b91e59e17b872798e3227cbf44e9973506e
Author: Caolán McNamara
AuthorDate: Fri Jan 28 19:40:40 2022 +
Commit: Caolán McNamara
CommitDate: Fri Jan 28 21:50:46 2022 +0100
upgrade expat to 2.4.3 + CVE-2022-23852 and CVE-2022-23990
wget https://github.com/libexpat/libexpat/pull/550.patch -O
CVE-2022-23852.patch
wget https://github.com/libexpat/libexpat/pull/551.patch -O
CVE-2022-23990.patch
Change-Id: I1f2694abd9f577e0b4fedbf27118b52be8a1a688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129124
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/download.lst b/download.lst
index a293026875ec..f9153df2bb6b 100644
--- a/download.lst
+++ b/download.lst
@@ -46,8 +46,8 @@ export EPUBGEN_TARBALL := libepubgen-0.1.1.tar.xz
export ETONYEK_SHA256SUM :=
b430435a6e8487888b761dc848b7981626eb814884963ffe25eb26a139301e9a
export ETONYEK_VERSION_MICRO := 10
export ETONYEK_TARBALL := libetonyek-0.1.$(ETONYEK_VERSION_MICRO).tar.xz
-export EXPAT_SHA256SUM :=
2f9b6a580b94577b150a7d5617ad4643a4301a6616ff459307df3e225bcfbf40
-export EXPAT_TARBALL := expat-2.4.1.tar.bz2
+export EXPAT_SHA256SUM :=
b1f9f1b1a5ebb0acaa88c9ff79bfa4e145823b78aa5185e5c5d85f060824778a
+export EXPAT_TARBALL := expat-2.4.3.tar.xz
export FIREBIRD_SHA256SUM :=
acb85cedafa10ce106b1823fb236b1b3e5d942a5741e8f8435cc8ccfec0afe76
export FIREBIRD_TARBALL := Firebird-3.0.7.33374-0.tar.bz2
export FONTCONFIG_SHA256SUM :=
a5f052cb73fd479ffb7b697980510903b563bbb55b8f7a2b001fcfb94026003c
diff --git a/external/expat/CVE-2022-23852.patch
b/external/expat/CVE-2022-23852.patch
new file mode 100644
index ..c2b55ca854ef
--- /dev/null
+++ b/external/expat/CVE-2022-23852.patch
@@ -0,0 +1,115 @@
+From 847a645152f5ebc10ac63b74b604d0c1a79fae40 Mon Sep 17 00:00:00 2001
+From: Samanta Navarro
+Date: Sat, 22 Jan 2022 17:48:00 +0100
+Subject: [PATCH 1/3] lib: Detect and prevent integer overflow in XML_GetBuffer
+ (CVE-2022-23852)
+
+---
+ expat/lib/xmlparse.c | 5 +
+ 1 file changed, 5 insertions(+)
+
+diff --git a/expat/lib/xmlparse.c b/expat/lib/xmlparse.c
+index d54af683..5ce31402 100644
+--- a/expat/lib/xmlparse.c
b/expat/lib/xmlparse.c
+@@ -2067,6 +2067,11 @@ XML_GetBuffer(XML_Parser parser, int len) {
+ keep = (int)EXPAT_SAFE_PTR_DIFF(parser->m_bufferPtr, parser->m_buffer);
+ if (keep > XML_CONTEXT_BYTES)
+ keep = XML_CONTEXT_BYTES;
++/* Detect and prevent integer overflow */
++if (keep > INT_MAX - neededSize) {
++ parser->m_errorCode = XML_ERROR_NO_MEMORY;
++ return NULL;
++}
+ neededSize += keep;
+ #endif /* defined XML_CONTEXT_BYTES */
+ if (neededSize
+
+From acf956f14bf79a5e6383a969aaffec98bfbc2e44 Mon Sep 17 00:00:00 2001
+From: Sebastian Pipping
+Date: Sun, 23 Jan 2022 18:17:04 +0100
+Subject: [PATCH 2/3] tests: Cover integer overflow in XML_GetBuffer
+ (CVE-2022-23852)
+
+---
+ expat/tests/runtests.c | 27 +++
+ 1 file changed, 27 insertions(+)
+
+diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c
+index e89e8220..579dad1a 100644
+--- a/expat/tests/runtests.c
b/expat/tests/runtests.c
+@@ -3847,6 +3847,30 @@ START_TEST(test_get_buffer_2) {
+ }
+ END_TEST
+
++/* Test for signed integer overflow CVE-2022-23852 */
++#if defined(XML_CONTEXT_BYTES)
++START_TEST(test_get_buffer_3_overflow) {
++ XML_Parser parser = XML_ParserCreate(NULL);
++ assert(parser != NULL);
++
++ const char *const text = "\n";
++ const int expectedKeepValue = (int)strlen(text);
++
++ // After this call, variable "keep" in XML_GetBuffer will
++ // have value expectedKeepValue
++ if (XML_Parse(parser, text, (int)strlen(text), XML_FALSE /* isFinal */)
++ == XML_STATUS_ERROR)
++xml_failure(parser);
++
++ assert(expectedKeepValue > 0);
++ if (XML_GetBuffer(parser, INT_MAX - expectedKeepValue + 1) != NULL)
++fail("enlarging buffer not failed");
++
++ XML_ParserFree(parser);
++}
++END_TEST
++#endif // defined(XML_CONTEXT_BYTES)
++
+ /* Test position information macros */
+ START_TEST(test_byte_info_at_end) {
+ const char *text = "";
+@@ -11731,6 +11755,9 @@ make_suite(void) {
+ tcase_add_test(tc_basic, test_empty_parse);
+ tcase_add_test(tc_basic, test_get_buffer_1);
+ tcase_add_test(tc_basic, test_get_buffer_2);
++#if defined(XML_CONTEXT_BYTES)
++ tcase_add_test(tc_basic, test_get_buffer_3_overflow);
++#endif
+ tcase_add_test(tc_basic, test_byte_info_at_end);
+ tcase_add_test(tc_basic, test_byte_info_at_error);
+ tcase_add_test(tc_basic, test_byte_info_at_cdata);
+
+From 99cec436fbd9444f57ee74ca8ae4c0a13e561a4f Mon Sep
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 --- Comment #42 from Shawn --- Offfice 365 is Now Microsoft 365/setup – Renew, Activate, Download and Install Microsoft 365 [url=https://microsof365setup.com/]microsoft365/setup[/url] [url=https://microsof365setup.com/]www.microsoft365.com/setup[/url] [url=https://microsof365setup.com/]microsoft365 setup[/url] [url=https://microsof365setup.com/]office.com/setup[/url] [url=https://microsof365setup.com/]www.office.com/setup[/url] [url=https://microsof365setup.com/]microsoft365.com/setup[/url] -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/cctrl/checklistmenu.cxx | 17 +
sc/source/ui/inc/checklistmenu.hxx |2 ++
sc/source/ui/view/gridwin.cxx|1 +
3 files changed, 16 insertions(+), 4 deletions(-)
New commits:
commit ac41defa75365451db264379c514993679618208
Author: Caolán McNamara
AuthorDate: Fri Jan 28 09:58:05 2022 +
Commit: Caolán McNamara
CommitDate: Fri Jan 28 21:35:08 2022 +0100
Resolves: tdf#147016 ensure focus returns to document after popup closes
Change-Id: I67e59afc08bc5983d473cb9dceb4fcefedeec117
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129094
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index 0d4a3857d34f..52f53a34838e 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -299,6 +299,8 @@ void ScCheckListMenuControl::queueCloseSubMenu()
maCloseTimer.mpSubMenu = maOpenTimer.mpSubMenu;
maCloseTimer.mnMenuPos = maOpenTimer.mnMenuPos;
+maOpenTimer.mpSubMenu = nullptr;
+maOpenTimer.mnMenuPos = MENU_NOT_SELECTED;
maCloseTimer.maTimer.Start();
}
@@ -586,11 +588,8 @@ void ScCheckListMenuControl::GrabFocus()
}
}
-ScCheckListMenuControl::~ScCheckListMenuControl()
+void ScCheckListMenuControl::DropPendingEvents()
{
-EndPopupMode();
-for (auto& rMenuItem : maMenuItems)
-rMenuItem.mxSubMenuWin.reset();
if (mnAsyncPostPopdownId)
{
Application::RemoveUserEvent(mnAsyncPostPopdownId);
@@ -603,6 +602,14 @@ ScCheckListMenuControl::~ScCheckListMenuControl()
}
}
+ScCheckListMenuControl::~ScCheckListMenuControl()
+{
+EndPopupMode();
+for (auto& rMenuItem : maMenuItems)
+rMenuItem.mxSubMenuWin.reset();
+DropPendingEvents();
+}
+
void ScCheckListMenuControl::prepWindow()
{
mxMenu->set_size_request(-1, mxMenu->get_preferred_size().Height() + 2);
@@ -1472,6 +1479,8 @@ IMPL_LINK_NOARG(ScCheckListMenuControl, PopupModeEndHdl,
weld::Popover&, void)
if (mxPopupEndAction)
mxPopupEndAction->execute();
+DropPendingEvents();
+
if (comphelper::LibreOfficeKit::isActive())
NotifyCloseLOK();
}
diff --git a/sc/source/ui/inc/checklistmenu.hxx
b/sc/source/ui/inc/checklistmenu.hxx
index 87a3e4325e45..31d5a5b97fde 100644
--- a/sc/source/ui/inc/checklistmenu.hxx
+++ b/sc/source/ui/inc/checklistmenu.hxx
@@ -255,6 +255,8 @@ private:
void ResizeToRequest();
+void DropPendingEvents();
+
private:
std::unique_ptr mxBuilder;
std::unique_ptr mxPopover;
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 2404ea47dd29..1bc40626c81a 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -526,6 +526,7 @@ public:
virtual bool execute() override
{
mpWindow->RefreshAutoFilterButton(maPos);
+mpWindow->GrabFocus();
return false; // this is called after the popup has been closed
}
};
[Libreoffice-bugs] [Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Telesto changed: What|Removed |Added Depends on||146976 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=146976 [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 Telesto changed: What|Removed |Added Blocks||133092 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 Telesto changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 --- Comment #7 from Telesto --- Created attachment 177884 --> https://bugs.documentfoundation.org/attachment.cgi?id=177884=edit BT without symbols (for clicking inside document while loading) If you click around in the document, while it's loading you might catch an crash. Probably something to do with timing.. This unrelated to the STR but matches the observation at comment 0. Will need a separate report.. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147046] New: Tool Bar Appearance Customization in 4k res
https://bugs.documentfoundation.org/show_bug.cgi?id=147046 Bug ID: 147046 Summary: Tool Bar Appearance Customization in 4k res Product: LibreOffice Version: 7.2.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jediguitar...@yahoo.com Description: I can't get the toolbar to completely go into darkmode with my resolution being 4k. I'm certainly not interested in lowering my resolution. Are you guys still working on this issue? Actual Results: NA Expected Results: NA Reproducible: Always User Profile Reset: No Additional Info: NA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - RepositoryExternal.mk
RepositoryExternal.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e92dc76d9b7ec0105578c72d37d0ed2d85ef0140 Author: Michael Weghorn AuthorDate: Thu Jan 27 08:17:54 2022 + Commit: Caolán McNamara CommitDate: Fri Jan 28 21:18:55 2022 +0100 Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not built Since commit 894450d6ebbb2d5e063d72b971580d1b8c10a5e3 Author: Michael Weghorn Date: Tue Sep 28 08:36:44 2021 +0200 Unify how Qt/KF build flags/libs are set the qt5/kf5 externals are used to set includes and compiler/linker flags for the gtk3_kde5 VCL plugin as well. However, the relevant link targets were only actually defined as needed when building the qt5 and kf5 VCL plugins was enabled as well. Adapt that so that building the gtk3_kde5 VCL plugin but not the qt5 and kf5 ones also works again (e.g. '--enable-gtk3-kde5 --disable-qt5 --disable-kf5'). [NOTE: This backport for 7-3 also incorporates the follow-up fix commit ba67202007f37d228a813c0915fd630bc2ff177b Author: Michael Weghorn Date: Thu Jan 27 15:16:47 2022 +0100 Fix up "Fix gtk3_kde5 build when qt5/kf5 VCL plugins are not built" ] Change-Id: I65b75d7c2ccab71eade01aa2529fb45174056701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129022 Tested-by: Jenkins Reviewed-by: Michael Weghorn (cherry picked from commit 5801b9fc65508391e130670f79a9af51f18d4e96) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128965 Reviewed-by: Caolán McNamara diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index e63ab24dba27..4854a20aa050 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -3105,7 +3105,7 @@ endef # gb_LinkTarget__use_postgresql endif # !SYSTEM_POSTGRESQL -ifeq ($(ENABLE_KF5),TRUE) +ifneq (,$(filter TRUE,$(ENABLE_KF5) $(ENABLE_GTK3_KDE5))) define gb_LinkTarget__use_kf5 $(call gb_LinkTarget_set_include,$(1),\ @@ -3133,7 +3133,7 @@ endif # ENABLE_KF5 -ifeq ($(ENABLE_QT5),TRUE) +ifneq (,$(filter TRUE,$(ENABLE_QT5) $(ENABLE_GTK3_KDE5))) define gb_LinkTarget__use_qt5 $(call gb_LinkTarget_set_include,$(1),\
[Libreoffice-commits] core.git: chart2/source
chart2/source/inc/InternalDataProvider.hxx |3 ++-
chart2/source/tools/InternalDataProvider.cxx | 16 ++--
2 files changed, 8 insertions(+), 11 deletions(-)
New commits:
commit 642e98613ad4479f7601ea8cec78754546f563d1
Author: Noel Grandin
AuthorDate: Thu Jan 27 18:19:44 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 28 20:56:19 2022 +0100
use more concrete types in chart2, ChartModel
Change-Id: Idd686acd0e8acaafcbbd18a4d6b0f298cc577784
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129111
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/inc/InternalDataProvider.hxx
b/chart2/source/inc/InternalDataProvider.hxx
index 0fa2bdf8b855..a5032efcdab8 100644
--- a/chart2/source/inc/InternalDataProvider.hxx
+++ b/chart2/source/inc/InternalDataProvider.hxx
@@ -37,6 +37,7 @@ namespace com::sun::star::chart2 { class XChartDocument; }
namespace chart
{
+class ChartModel;
class UncachedDataSequence;
namespace impl
@@ -72,7 +73,7 @@ public:
// #i120559# allow handing over a default for data orientation
// (DataInColumns) that will be used when no data is available
explicit InternalDataProvider(
-const css::uno::Reference< css::chart2::XChartDocument > & xChartDoc,
+const rtl::Reference< ::chart::ChartModel > & xChartDoc,
bool bConnectToModel,
bool bDefaultDataInColumns );
explicit InternalDataProvider( const InternalDataProvider & rOther );
diff --git a/chart2/source/tools/InternalDataProvider.cxx
b/chart2/source/tools/InternalDataProvider.cxx
index 7a2fdb3aed84..696611e80fa3 100644
--- a/chart2/source/tools/InternalDataProvider.cxx
+++ b/chart2/source/tools/InternalDataProvider.cxx
@@ -309,22 +309,18 @@ InternalDataProvider::InternalDataProvider()
{}
InternalDataProvider::InternalDataProvider(
-const Reference< chart2::XChartDocument > & xChartDoc,
+const rtl::Reference< ChartModel > & xModel,
bool bConnectToModel,
bool bDefaultDataInColumns)
: m_bDataInColumns( bDefaultDataInColumns )
{
-if (!xChartDoc.is())
+if (!xModel.is())
return;
try
{
-auto pModel = dynamic_cast(xChartDoc.get());
-assert(pModel);
-rtl::Reference< Diagram > xDiagram( ChartModelHelper::findDiagram(
pModel ) );
+rtl::Reference< Diagram > xDiagram( ChartModelHelper::findDiagram(
xModel ) );
if( xDiagram.is())
{
-Reference< frame::XModel > xChartModel = xChartDoc;
-
//data in columns?
{
OUString aRangeString;
@@ -333,7 +329,7 @@ InternalDataProvider::InternalDataProvider(
uno::Sequence< sal_Int32 > aSequenceMapping;
const bool bSomethingDetected(
DataSourceHelper::detectRangeSegmentation(
-pModel, aRangeString, aSequenceMapping,
m_bDataInColumns, bFirstCellAsLabel, bHasCategories ));
+xModel, aRangeString, aSequenceMapping,
m_bDataInColumns, bFirstCellAsLabel, bHasCategories ));
// #i120559# if no data was available, restore default
if(!bSomethingDetected && m_bDataInColumns !=
bDefaultDataInColumns)
@@ -346,7 +342,7 @@ InternalDataProvider::InternalDataProvider(
{
vector< vector< uno::Any > > aNewCategories;//inner count is
level
{
-ExplicitCategoriesProvider
aExplicitCategoriesProvider(ChartModelHelper::getFirstCoordinateSystem(pModel),
*pModel);
+ExplicitCategoriesProvider
aExplicitCategoriesProvider(ChartModelHelper::getFirstCoordinateSystem(xModel),
*xModel);
const Sequence< Reference<
chart2::data::XLabeledDataSequence> >& rSplitCategoriesList(
aExplicitCategoriesProvider.getSplitCategoriesList() );
sal_Int32 nLevelCount = rSplitCategoriesList.getLength();
@@ -390,7 +386,7 @@ InternalDataProvider::InternalDataProvider(
}
// data series
-std::vector< Reference< chart2::XDataSeries > > aSeriesVector(
ChartModelHelper::getDataSeries( pModel ));
+std::vector< Reference< chart2::XDataSeries > > aSeriesVector(
ChartModelHelper::getDataSeries( xModel ));
lcl_internalizeSeries ftor( m_aInternalData, *this,
bConnectToModel, m_bDataInColumns );
for( const auto& rxScreen : aSeriesVector )
ftor( rxScreen );
[Libreoffice-bugs] [Bug 146814] Crash in: ScBroadcastAreaSlotMachine::AreaBroadcast(ScRange const &, SfxHintId)
https://bugs.documentfoundation.org/show_bug.cgi?id=146814 --- Comment #2 from Colin --- Created attachment 177883 --> https://bugs.documentfoundation.org/attachment.cgi?id=177883=edit Sample ods It's the file already uploaded for Bug 146815, that being attachment 177631 It's also attached herewith Full Instructions to replicate the initial crash are with 146815 The system was constantly crashing and offering an empty recovery file panel and recovering nothing and then crashing when I reopened any file on disk etc. I suspect the crash corrupted the user profile as I was unable to continue without clearing the user profile and reinstalling LO. If you are going to replicate the actions then it's only the cells below the rightmost DataTable containing the a-z word lists. Note: A-Z signifies that the word ENDS with that character so all the words are also sorted A-Z within those columns. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147032] hazardous animation objects selected
https://bugs.documentfoundation.org/show_bug.cgi?id=147032 raal changed: What|Removed |Added Version|unspecified |7.1.0.3 release CC||caol...@redhat.com Keywords||bibisected, bisected --- Comment #2 from raal --- This seems to have begun at the below commit. Adding Cc: to Caolán McNamara; Could you possibly take a look at this one? Thanks 9ff12c78a14275c103335bce76a0ddee5680ef49 is the first bad commit commit 9ff12c78a14275c103335bce76a0ddee5680ef49 Author: Jenkins Build User Date: Mon Apr 6 21:44:38 2020 +0200 source sha:21e8ce9ab9a522d25e95773af59b7aee4e54 https://git.libreoffice.org/core/+/21e8ce9ab9a522d25e95773af59b7aee4e54 weld custom animation panel -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmlexport.cxx |1 + sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |1 + sw/qa/extras/uiwriter/uiwriter4.cxx |1 + 3 files changed, 3 insertions(+) New commits: commit 38358c6b1630d1d003e3a6e8289ab36bf4d40546 Author: Stephan Bergmann AuthorDate: Fri Jan 28 18:51:49 2022 +0100 Commit: Stephan Bergmann CommitDate: Fri Jan 28 20:32:27 2022 +0100 Fix --with-latest-c++ build ...after e53ad7928fc1cbe9950efebe41f1aa5a1a289439 "CppunitTest_sw_uiwriter*: remove unused includes" and ba593f5fdfecd1b8b2036f99618b39e18facca55 "CppunitTest_sw_ooxmlexport*: remove unused includes" caused > In file included from workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:8, > from include/test/bootstrapfixture.hxx:20, > from sw/qa/inc/swmodeltestbase.hxx:26, > from sw/qa/extras/ooxmlexport/ooxmlexport.cxx:10: > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h: In instantiation of ‘typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string >::type CppUnit::StringHelper::toString(const T&) [with T = char16_t; typename std::enable_if<(! std::is_enum<_Tp>::value), std::__cxx11::basic_string >::type = std::__cxx11::basic_string]’: > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:74:50: required from ‘static std::string CppUnit::assertion_traits::toString(const T&) [with T = char16_t; std::string = std::__cxx11::basic_string]’ > workdir/UnpackedTarball/cppunit/include/cppunit/TestAssert.h:168:58: required from ‘void CppUnit::assertEquals(const T&, const T&, SourceLine, const std::string&) [with T = char16_t; std::string = std::__cxx11::basic_string]’ > sw/qa/extras/ooxmlexport/ooxmlexport.cxx:967:5: required from here > workdir/UnpackedTarball/cppunit/include/cppunit/tools/StringHelper.h:25:9: error: use of deleted function ‘std::basic_ostream& std::operator<<(basic_ostream&, char16_t) [with _Traits = char_traits]’ >25 | ost << x; > | ^~~~ > In file included from ~/gcc/trunk/inst/include/c++/12.0.1/bits/unique_ptr.h:41, > from ~/gcc/trunk/inst/include/c++/12.0.1/memory:76, > from sw/qa/inc/swmodeltestbase.hxx:13: > ~/gcc/trunk/inst/include/c++/12.0.1/ostream:558:5: note: declared here > 558 | operator<<(basic_ostream&, char16_t) = delete; > | ^~~~ etc. Change-Id: I85087a8472eab923065ceb7ca6a1585f7ade75e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129118 Reviewed-by: Xisco Fauli Reviewed-by: Stephan Bergmann Tested-by: Jenkins diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx index f6642444a105..3e44a2f869aa 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx @@ -26,6 +26,7 @@ #include #include +#include #include #include #include diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx index 4d4a4f60f383..9d3bed3d6b44 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx @@ -19,6 +19,7 @@ #include #include +#include #include #include diff --git a/sw/qa/extras/uiwriter/uiwriter4.cxx b/sw/qa/extras/uiwriter/uiwriter4.cxx index 8f6c31f8ab45..5e916b6a43a6 100644 --- a/sw/qa/extras/uiwriter/uiwriter4.cxx +++ b/sw/qa/extras/uiwriter/uiwriter4.cxx @@ -42,6 +42,7 @@ #include #include #include +#include #include #include #include
[Libreoffice-bugs] [Bug 147032] hazardous animation objects selected
https://bugs.documentfoundation.org/show_bug.cgi?id=147032 raal changed: What|Removed |Added CC||r...@post.cz Keywords||regression Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from raal --- Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2f4f4cbeb8e50081d607b86b0475b93971c40ab8 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: tr-TR (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo but not in Version: 6.1.0.0.alpha0+ Build ID: e1b247a843c5eb850fe0079819239d9883412d38 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3; Locale: cs-CZ (cs_CZ.UTF-8); Calc: group -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 Telesto changed: What|Removed |Added Keywords||wantBacktrace CC||serval2...@yahoo.fr -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 --- Comment #6 from Telesto --- Created attachment 177882 --> https://bugs.documentfoundation.org/attachment.cgi?id=177882=edit BT without symbols I can confirm the crash Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4a388f5e01ebb5a512931d11e48c4380382239c8 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Saving & opening the file at cursor position didn't work for me (bug 146988).. But scrolled down & put the cursor on the last page.. and opened a new Window -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146814] Crash in: ScBroadcastAreaSlotMachine::AreaBroadcast(ScRange const &, SfxHintId)
https://bugs.documentfoundation.org/show_bug.cgi?id=146814 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- Colin, can you attach your file with data here? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146912] Opening Calc 7.3.0.2 crashes LibreOffice on Linux Mint 20.3 Cinnamon
https://bugs.documentfoundation.org/show_bug.cgi?id=146912 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- Óvári what hardware do you use? Is there Nvidia videocard there? I had the same problem , I added my own report to See also, but I can repro it only on one of my PCs with Linux -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144164] LibreOffice crashes when I try start Calc from Start center (possibly SUSE-specific)
https://bugs.documentfoundation.org/show_bug.cgi?id=144164 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6912 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146912] Opening Calc 7.3.0.2 crashes LibreOffice on Linux Mint 20.3 Cinnamon
https://bugs.documentfoundation.org/show_bug.cgi?id=146912 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4164 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147045] Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147045 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- no repro Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: 2f4f4cbeb8e50081d607b86b0475b93971c40ab8 CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3 Locale: tr-TR (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: hwpfilter/source
hwpfilter/source/htags.cxx | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
New commits:
commit 231f827fabe0b4361c6e3e3245e7bf25a61dff44
Author: Caolán McNamara
AuthorDate: Fri Jan 28 11:34:23 2022 +
Commit: Caolán McNamara
CommitDate: Fri Jan 28 20:18:06 2022 +0100
use our own tempfile mechanism
Change-Id: Ie7853ea8bd083d1056872cfad4323ff6cede235f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129097
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/hwpfilter/source/htags.cxx b/hwpfilter/source/htags.cxx
index b8cafcf38675..4644d286d75c 100644
--- a/hwpfilter/source/htags.cxx
+++ b/hwpfilter/source/htags.cxx
@@ -19,6 +19,9 @@
#include "precompile.h"
+#include
+#include
+
#include
#include "hwplib.h"
@@ -108,27 +111,20 @@ void OlePicture::Read(HWPFile & hwpf)
delete [] data;
return;
}
-FILE *fp;
-char tname[200];
-wchar_t wtname[200];
-tmpnam(tname);
-if (nullptr == (fp = fopen(tname, "wb")))
-{
- delete [] data;
- return;
-}
-fwrite(data, size, 1, fp);
+
+utl::TempFile aTempFile;
+aTempFile.EnableKillingFile();
+
+SvFileStream aOutputStream(aTempFile.GetURL(), StreamMode::WRITE);
+aOutputStream.WriteBytes(data, size);
delete [] data;
-fclose(fp);
-MultiByteToWideChar(CP_ACP, 0, tname, -1, wtname, 200);
-if( StgOpenStorage(wtname, nullptr,
+aOutputStream.Close();
+if( StgOpenStorage(o3tl::toW(aTempFile.GetFileName().getStr()), nullptr,
STGM_READWRITE|STGM_SHARE_EXCLUSIVE|STGM_TRANSACTED,
nullptr, 0, ) != S_OK ) {
pis = nullptr;
- unlink(tname);
return;
}
-unlink(tname);
#else
hwpf.SkipBlock(size);
#endif
[Libreoffice-bugs] [Bug 146940] Libreoffice became increadibly slow on using emoticons
https://bugs.documentfoundation.org/show_bug.cgi?id=146940 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Keywords||perf CC||79045_79...@mail.ru Ever confirmed|0 |1 --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- No problem in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 06ac18e6302d666c363740644a7976e8c22d1113 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded Linux only? Vitovt, please write info from LibreOffice's Help->About dialog as I made it above -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147045] Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147045 --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- *** Bug 147044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147044] Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147044 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- *** This bug has been marked as a duplicate of bug 147045 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 Greg changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from Greg --- Test File attached. Telesto: Thank you for the information on how to sanitize a file. As to be expected, both procedures crashed, freezing the application. Instead, I replaced some of the characters with an "X", which should be sufficient. Your comment that "LibreOffice & OpenOffice aren't scanning the file, but reading it into memory? It's rendering the text, positioning footnotes, spell checking in the background.. but it takes far longer for larger files.." is exactly what I was attempting to describe. Thank you. Timur: I experienced many repagination crashes as well in my attempt to create the test file. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147045] Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147045 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru --- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> --- No repro in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 06ac18e6302d666c363740644a7976e8c22d1113 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded nor in Version: 7.2.0.1.0+ (x64) / LibreOffice Community Build ID: c3dd27d24dec0c581ed731acf8ff3504a4068b03 CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: default; VCL: win Locale: ru-RU (ru_RU); UI: ru-RU Calc: threaded macOS only? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146976] Writer Crashes After Opening A Large File of 2000 text pages
https://bugs.documentfoundation.org/show_bug.cgi?id=146976 --- Comment #4 from Greg --- Created attachment 177881 --> https://bugs.documentfoundation.org/attachment.cgi?id=177881=edit large test file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145843] Incidental Crash on macOS with skia raster
https://bugs.documentfoundation.org/show_bug.cgi?id=145843 --- Comment #19 from Telesto --- (In reply to Mike Saunders from comment #17) > I'm using the TDF Apple Silicon (aarch64) build: > > Version: 7.3.0.2 / LibreOffice Community > Build ID: f1c9017ac60ecca268da7b1cf147b10e244b9b21 > CPU threads: 8; OS: Mac OS X 11.5.2; UI render: Skia/Metal; VCL: osx > Locale: en-GB (en_GB.UTF-8); UI: en-US > Calc: threaded > > I can't reproduce the original crash described by Telesto, or the crash > steps in comment 8. All seems to be working fine here... Anything else I can > test? A) The problem appears to be limited to macOS Monterey (all reports pointing into that direction) B) It only occurs with Skia Raster mode (aka Software rendering). Tools -> Options -> View -> Force Skia Software rendering. C) It only occurs with Master builds (not self-build) D) It might be dependent on Haswell processor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147045] New: Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147045 Bug ID: 147045 Summary: Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash Product: LibreOffice Version: 7.2.4.1 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marco.mizr...@yahoo.com Description: I was trying to create navigation links between different spreadsheets but rather than using the default text for the hyperlink, I used the option to change the text, when I did this, the program crashed. Luckily I was able to recover the document right away. I restarted my computer and the issue persisted. I try again but without changing the text and the hyperlink was created, the program continued to work. Steps to Reproduce: 1.Choose a cell to be a hyperlink (ctrl+K) 2.Chose the target as within a document 3.Change the text of the hyperlink in the box called "text" 4.Press accept/enter Actual Results: LibreOffice crashed and offered to recover the document. Expected Results: I was expecting a hyperlink with my desired text. Reproducible: Always User Profile Reset: No Additional Info: That's all. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147044] New: Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147044 Bug ID: 147044 Summary: Changing the text to an URL with a target in the same document (Spreadsheet) caused the program to crash Product: LibreOffice Version: 7.2.4.1 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marco.mizr...@yahoo.com Description: I was trying to create navigation links between different spreadsheets but rather than using the default text for the hyperlink, I used the option to change the text, when I did this, the program crashed. Luckily I was able to recover the document right away. I restarted my computer and the issue persisted. I try again but without changing the text and the hyperlink was created, the program continued to work. Steps to Reproduce: 1.Choose a cell to be a hyperlink (ctrl+K) 2.Chose the target as within a document 3.Change the text of the hyperlink in the box called "text" 4.Press accept/enter Actual Results: LibreOffice crashed and offered to recover the document. Expected Results: I was expecting a hyperlink with my desired text. Reproducible: Always User Profile Reset: No Additional Info: That's all. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/export-tests-ooxml1.cxx | 13 -
sd/qa/unit/export-tests-ooxml2.cxx | 24 ++--
sd/qa/unit/export-tests-ooxml3.cxx | 23 ++-
3 files changed, 4 insertions(+), 56 deletions(-)
New commits:
commit 0176a6627755d938163ac64733929af79508f825
Author: Xisco Fauli
AuthorDate: Fri Jan 28 14:21:07 2022 +0100
Commit: Xisco Fauli
CommitDate: Fri Jan 28 20:00:45 2022 +0100
CppunitTest_sd_export_tests-ooxml*: remove unused includes
Change-Id: I2811e151a9643f589e251e176d9c717472a5dd4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129099
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sd/qa/unit/export-tests-ooxml1.cxx
b/sd/qa/unit/export-tests-ooxml1.cxx
index 22435dd51d78..7631b3113bbd 100644
--- a/sd/qa/unit/export-tests-ooxml1.cxx
+++ b/sd/qa/unit/export-tests-ooxml1.cxx
@@ -7,16 +7,11 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
-
-#include
-
#include
#include "sdmodeltestbase.hxx"
#include
#include
#include
-#include
#include
#include
#include
@@ -27,8 +22,6 @@
#include
-#include
-#include
#include
#include
#include
@@ -36,19 +29,13 @@
#include
#include
#include
-#include
-#include
-#include
-#include
-#include
#include
#include
#include
#include
#include
#include
-#include
#include
#include
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx
b/sd/qa/unit/export-tests-ooxml2.cxx
index 4ab2a893e1f0..4777845308c5 100644
--- a/sd/qa/unit/export-tests-ooxml2.cxx
+++ b/sd/qa/unit/export-tests-ooxml2.cxx
@@ -6,44 +6,24 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include
+
#include "sdmodeltestbase.hxx"
#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-
-#include
+
#include
#include
-#include
-#include
-#include
-#include
-#include
#include
#include
-#include
-#include
-#include
#include
-#include
#include
#include
#include
-#include
#include
#include
#include
-#include
-#include
#include
diff --git a/sd/qa/unit/export-tests-ooxml3.cxx
b/sd/qa/unit/export-tests-ooxml3.cxx
index 437f1906dd97..e0aa2290e799 100644
--- a/sd/qa/unit/export-tests-ooxml3.cxx
+++ b/sd/qa/unit/export-tests-ooxml3.cxx
@@ -7,46 +7,27 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+
#include
#include "sdmodeltestbase.hxx"
-#include
#include
#include
#include
-#include
#include
#include
-#include
-#include
-#include
#include
#include
#include
-#include
-
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
+
#include
#include
-#include
-#include
#include
#include
#include
#include
-#include
-#include
-
-#include
class SdOOXMLExportTest3 : public SdModelTestBaseXML
{
[Libreoffice-bugs] [Bug 146842] Empty/white pages when printing (skia)
https://bugs.documentfoundation.org/show_bug.cgi?id=146842 --- Comment #17 from José Luís Andrade --- I can confirm this with 7.3.0.3 on macOS (12.2, Intel). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: cppuhelper/source
cppuhelper/source/paths.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1a403f67ec437c57d25a1ac2d0368dce6c571cbd
Author: Jan-Marek Glogowski
AuthorDate: Fri Jan 28 14:40:51 2022 +0100
Commit: Jan-Marek Glogowski
CommitDate: Fri Jan 28 19:34:17 2022 +0100
WASM set correct path to FS image unorc
Guess in all the fixing when upstreaming all the WASM changes,
that hunk got lost. This actually makes the WASM build run, not
just compile.
Change-Id: Ided621af284e62961eb47957d74b31871a30a2bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129105
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski
diff --git a/cppuhelper/source/paths.cxx b/cppuhelper/source/paths.cxx
index d2f37bb549a7..b6a1e12600dd 100644
--- a/cppuhelper/source/paths.cxx
+++ b/cppuhelper/source/paths.cxx
@@ -52,7 +52,7 @@ OUString get_this_libpath() {
}
OUString cppu::getUnoIniUri() {
-#if defined ANDROID || defined EMSCRIPTEN
+#if defined ANDROID
// Wouldn't it be lovely to avoid this ugly hard-coding.
// The problem is that the 'create_bootstrap_macro_expander_factory()'
// required for bootstrapping services, calls cppu::get_unorc directly
[Libreoffice-commits] core.git: chart2/source
chart2/source/inc/ChartType.hxx |4 ++--
chart2/source/inc/UncachedDataSequence.hxx |3 ++-
chart2/source/model/template/ChartType.cxx |6 ++
chart2/source/tools/UncachedDataSequence.cxx | 20 ++--
4 files changed, 8 insertions(+), 25 deletions(-)
New commits:
commit 6043d01496fe7e4c2000b2c3121aab759cab0fc3
Author: Noel Grandin
AuthorDate: Thu Jan 27 18:14:27 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 28 19:28:27 2022 +0100
use more concrete types in chart2, ModifyEventForwarder
Change-Id: Ibd1102dbc269bb2e9a2afd67fae1e4ec7d51b1ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129110
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/inc/ChartType.hxx b/chart2/source/inc/ChartType.hxx
index 729e58109de5..833fa9783993 100644
--- a/chart2/source/inc/ChartType.hxx
+++ b/chart2/source/inc/ChartType.hxx
@@ -35,6 +35,7 @@
namespace chart
{
+class ModifyEventForwarder;
namespace impl
{
@@ -119,8 +120,7 @@ protected:
DECLARE_XTYPEPROVIDER()
protected:
-css::uno::Reference< css::util::XModifyListener >
-const m_xModifyEventForwarder;
+rtl::Reference m_xModifyEventForwarder;
private:
void impl_addDataSeriesWithoutNotification(
diff --git a/chart2/source/inc/UncachedDataSequence.hxx
b/chart2/source/inc/UncachedDataSequence.hxx
index e3a51f55727a..6b4c21fe7afe 100644
--- a/chart2/source/inc/UncachedDataSequence.hxx
+++ b/chart2/source/inc/UncachedDataSequence.hxx
@@ -42,6 +42,7 @@ namespace com::sun::star::chart2 { class
XInternalDataProvider; }
namespace chart
{
class InternalDataProvider;
+class ModifyEventForwarder;
namespace impl
{
@@ -164,7 +165,7 @@ private:
rtl::Reference< InternalDataProvider > m_xDataProvider;
OUString m_aSourceRepresentation;
-css::uno::Reference< css::util::XModifyListener > m_xModifyEventForwarder;
+rtl::Reference m_xModifyEventForwarder;
};
} // namespace chart
diff --git a/chart2/source/model/template/ChartType.cxx
b/chart2/source/model/template/ChartType.cxx
index aa0a17453f25..96273874643e 100644
--- a/chart2/source/model/template/ChartType.cxx
+++ b/chart2/source/model/template/ChartType.cxx
@@ -242,8 +242,7 @@ void SAL_CALL ChartType::addModifyListener( const
uno::Reference< util::XModifyL
{
try
{
-uno::Reference< util::XModifyBroadcaster > xBroadcaster(
m_xModifyEventForwarder, uno::UNO_QUERY_THROW );
-xBroadcaster->addModifyListener( aListener );
+m_xModifyEventForwarder->addModifyListener( aListener );
}
catch( const uno::Exception & )
{
@@ -255,8 +254,7 @@ void SAL_CALL ChartType::removeModifyListener( const
uno::Reference< util::XModi
{
try
{
-uno::Reference< util::XModifyBroadcaster > xBroadcaster(
m_xModifyEventForwarder, uno::UNO_QUERY_THROW );
-xBroadcaster->removeModifyListener( aListener );
+m_xModifyEventForwarder->removeModifyListener( aListener );
}
catch( const uno::Exception & )
{
diff --git a/chart2/source/tools/UncachedDataSequence.cxx
b/chart2/source/tools/UncachedDataSequence.cxx
index fa069a631870..e8a6075d643e 100644
--- a/chart2/source/tools/UncachedDataSequence.cxx
+++ b/chart2/source/tools/UncachedDataSequence.cxx
@@ -298,28 +298,12 @@ void SAL_CALL UncachedDataSequence::setModified( sal_Bool
bModified )
// XModifyBroadcaster (base of XModifiable)
void SAL_CALL UncachedDataSequence::addModifyListener( const Reference<
util::XModifyListener >& aListener )
{
-try
-{
-Reference< util::XModifyBroadcaster > xBroadcaster(
m_xModifyEventForwarder, uno::UNO_QUERY_THROW );
-xBroadcaster->addModifyListener( aListener );
-}
-catch( const uno::Exception & )
-{
-DBG_UNHANDLED_EXCEPTION("chart2");
-}
+m_xModifyEventForwarder->addModifyListener( aListener );
}
void SAL_CALL UncachedDataSequence::removeModifyListener( const Reference<
util::XModifyListener >& aListener )
{
-try
-{
-Reference< util::XModifyBroadcaster > xBroadcaster(
m_xModifyEventForwarder, uno::UNO_QUERY_THROW );
-xBroadcaster->removeModifyListener( aListener );
-}
-catch( const uno::Exception & )
-{
-DBG_UNHANDLED_EXCEPTION("chart2");
-}
+m_xModifyEventForwarder->removeModifyListener( aListener );
}
void UncachedDataSequence::fireModifyEvent()
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/layout/layout.cxx |8 sw/qa/extras/layout/layout2.cxx |5 - 2 files changed, 13 deletions(-) New commits: commit 66567d95ac103b8dba8736b554d9a061cf771fe8 Author: Xisco Fauli AuthorDate: Fri Jan 28 15:18:29 2022 +0100 Commit: Xisco Fauli CommitDate: Fri Jan 28 19:19:03 2022 +0100 CppunitTest_sw_layoutwriter*: remove unused includes Change-Id: I5f826496f7fbdbe6ef4139f0907c4baf04826bc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129106 Tested-by: Jenkins Reviewed-by: Xisco Fauli diff --git a/sw/qa/extras/layout/layout.cxx b/sw/qa/extras/layout/layout.cxx index 20158e3ae744..74638e413d59 100644 --- a/sw/qa/extras/layout/layout.cxx +++ b/sw/qa/extras/layout/layout.cxx @@ -8,23 +8,18 @@ */ #include -#include #include #include #include -#include #include #include -#include #include #include #include #include -#include #include #include -#include #include #include #include @@ -34,17 +29,14 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include #include -#include #include #include #include diff --git a/sw/qa/extras/layout/layout2.cxx b/sw/qa/extras/layout/layout2.cxx index 7e548490f67d..d833800c9fae 100644 --- a/sw/qa/extras/layout/layout2.cxx +++ b/sw/qa/extras/layout/layout2.cxx @@ -14,20 +14,15 @@ #include #include -#include #include -#include #include #include -#include #include #include -#include #include #include #include -#include constexpr OUStringLiteral DATA_DIRECTORY = u"/sw/qa/extras/layout/data/";
[Libreoffice-commits] core.git: writerfilter/qa writerfilter/source
writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx | 26 ++
writerfilter/qa/cppunittests/dmapper/data/ptab.docx|binary
writerfilter/source/dmapper/DomainMapper.cxx |2
writerfilter/source/dmapper/DomainMapper_Impl.cxx | 56 +
writerfilter/source/dmapper/DomainMapper_Impl.hxx |3
5 files changed, 87 insertions(+)
New commits:
commit 8bac48991857d222f0e8f0c07b8c4e06649e1632
Author: Miklos Vajna
AuthorDate: Fri Jan 28 13:38:20 2022 +0100
Commit: Miklos Vajna
CommitDate: Fri Jan 28 19:15:37 2022 +0100
DOCX import: handle a subset of
The case when we can map it to a line break. This way the page number is
visually inside the rectangle shape that is behind the field.
The test intentionally uses \n as-is for line-break, because
SwASCWriter::WriteStream() uses \n in the LINEEND_LF case even on
Windows (and not SAL_NEWLINE_STRING), while SAL_NEWLINE_STRING is used
for paragraph-break.
Change-Id: Ic85e57b2391bfac73507727b17240f4d85fc2698
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129059
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx
b/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx
index 3719a09e3323..c0468d9d55cc 100644
--- a/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/qa/cppunittests/dmapper/DomainMapper_Impl.cxx
@@ -19,6 +19,7 @@
#include
#include
#include
+#include
#include
@@ -230,6 +231,31 @@ CPPUNIT_TEST_FIXTURE(Test, testChartZOrder)
// of the shape.
CPPUNIT_ASSERT(xChart->supportsService("com.sun.star.text.TextEmbeddedObject"));
}
+
+CPPUNIT_TEST_FIXTURE(Test, testPTab)
+{
+// Given a document that has a to render a linebreak:
+OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "ptab.docx";
+
+// When opening that file:
+getComponent() = loadFromDesktop(aURL);
+
+// Then make sure that the Writer doc model contains that linebreak:
+uno::Reference
xStyleFamiliesSupplier(getComponent(),
+
uno::UNO_QUERY);
+uno::Reference xStyleFamilies
+= xStyleFamiliesSupplier->getStyleFamilies();
+uno::Reference
xStyleFamily(xStyleFamilies->getByName("PageStyles"),
+uno::UNO_QUERY);
+uno::Reference
xStyle(xStyleFamily->getByName("Standard"), uno::UNO_QUERY);
+auto xFooter =
xStyle->getPropertyValue("FooterText").get>();
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: 1\n
+// - Actual: 1\n
+// i.e. the layout height of the footer text was incorrect, the page
number field was not
+// visually inside the background shape.
+CPPUNIT_ASSERT_EQUAL(OUString(" \n1" SAL_NEWLINE_STRING),
xFooter->getString());
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/qa/cppunittests/dmapper/data/ptab.docx
b/writerfilter/qa/cppunittests/dmapper/data/ptab.docx
new file mode 100644
index ..d1ae18a27a55
Binary files /dev/null and
b/writerfilter/qa/cppunittests/dmapper/data/ptab.docx differ
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index e8b5a3f40e5b..6a18d8d12da0 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1167,7 +1167,9 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
break;
case NS_ooxml::LN_CT_PTab_leader:
case NS_ooxml::LN_CT_PTab_relativeTo:
+break;
case NS_ooxml::LN_CT_PTab_alignment:
+m_pImpl->HandlePTab(nIntValue);
break;
case NS_ooxml::LN_CT_Cnf_lastRowLastColumn:
m_pImpl->appendGrabBag(m_pImpl->m_aInteropGrabBag,
"lastRowLastColumn", OUString::number(nIntValue));
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index f0902918e0ff..952d225f52f7 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -3868,6 +3868,62 @@ void DomainMapper_Impl::HandleAltChunk(const OUString&
rStreamName)
}
}
+void DomainMapper_Impl::HandlePTab(sal_Int32 nAlignment)
+{
+// We only handle the case when the line already has content, so the
left-aligned ptab is
+// equivalent to a line break.
+if (nAlignment != NS_ooxml::LN_Value_ST_PTabAlignment_left)
+{
+return;
+}
+
+if (m_aTextAppendStack.empty())
+{
+return;
+}
+
+uno::Reference xTextAppend =
m_aTextAppendStack.top().xTextAppend;
+if (!xTextAppend.is())
+{
+return;
+}
+
+uno::Reference xInsertPosition
+=
[Libreoffice-bugs] [Bug 104790] [META] Database connectivity interfaces (ODBC, JDBC..) and external databases
https://bugs.documentfoundation.org/show_bug.cgi?id=104790 Bug 104790 depends on bug 81430, which changed state. Bug 81430 Summary: libreoffice-mysql-connector cannot create/edit tables without primary key https://bugs.documentfoundation.org/show_bug.cgi?id=81430 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 81430] libreoffice-mysql-connector cannot create/edit tables without primary key
https://bugs.documentfoundation.org/show_bug.cgi?id=81430 Julien Nabet changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 52310] Calling Relations tool with LO Base and mysql native connector appears to freeze LO pushing user to force kill the app
https://bugs.documentfoundation.org/show_bug.cgi?id=52310 --- Comment #30 from Julien Nabet --- I gave a new try with LO Debian package 7.3.0.2 and with master sources updated today + gen rendering in both cases, no pb to open relationship dialog, add 2 tables and link them. Now it's just for the record since it was on Linux not in Mac or Windows as reported. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141265] Random characters appear as black boxes at certain zoom levels in windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=141265 Allan Macdonald changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #8 from Allan Macdonald --- Resetting to needinfo now -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141265] Random characters appear as black boxes at certain zoom levels in windows 10.
https://bugs.documentfoundation.org/show_bug.cgi?id=141265 Allan Macdonald changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82066] FILEOPEN: RTF - Images dont have correct arrangement
https://bugs.documentfoundation.org/show_bug.cgi?id=82066 --- Comment #9 from Gabor Kelemen (allotropia) --- Created attachment 177880 --> https://bugs.documentfoundation.org/attachment.cgi?id=177880=edit The original DOCX file and its Writer-saved RTF version in Word 2013 and current Writer It looks mostly okay in current Writer, but quite bad in Word: the red rectangle comes to the front from the background and the blue rectangle is moved to the right by a few cm. Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: eb69767d7c1bb8e6e780fd9503f08c9d7f5ecb45 CPU threads: 13; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 129611] Not Autosaving
https://bugs.documentfoundation.org/show_bug.cgi?id=129611 Jean-Baptiste Faure changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||jbfa...@libreoffice.org --- Comment #10 from Jean-Baptiste Faure --- (In reply to Joe Abraham from comment #8) > I am confused. How do I unexpectedly crash my system? > > Thanks. Does that mean your system does not crash anymore? How did you enable autosave ? Status has been set to NEEDINFO, please set it back to UNCONFIRMED once requested information has been provided. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/tdf119952_negativeMargins.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport11.cxx | 83 +++
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 38 -
writerfilter/source/dmapper/DomainMapper_Impl.cxx| 63
writerfilter/source/dmapper/DomainMapper_Impl.hxx|3
writerfilter/source/dmapper/PropertyMap.cxx | 78 --
writerfilter/source/dmapper/PropertyMap.hxx |7
7 files changed, 190 insertions(+), 82 deletions(-)
New commits:
commit 4a539a150d5f9f606aabca11633f2c7104fb2a13
Author: Attila Szűcs
AuthorDate: Fri Jun 25 10:37:47 2021 +0200
Commit: Miklos Vajna
CommitDate: Fri Jan 28 18:18:07 2022 +0100
tdf#119952 DOCX import: fix negative page margins
DOCX body text can overlap with header/footer, if top/bottom
page margin is negative. To support this, convert header/footer
text content to textbox anchored to header/footer, if needed.
Note: possible improvements:
1) Skip this hack, if the header is small enough to not overlap with
the body, calculate only the height of the header at the import time.
2) This hack does not fix the case when the top of the header
is under the top of the body. (A problem in DOC import, too.)
This could be achieved by repositioning the dummy header to the top,
and lower the textbox by the same amount. (This would still not
resolve the extreme situation, when the body start from 0 mm
(in LibreOffice, header must be at least 1 mm).
3) Import of VertOrientation::BOTTOM property seems to be bad,
or at least the footer loses this property after a DOCX round-trip,
resulting bad footer position.
4) after a round-trip, the 1 mm height of the dummy header
increases to 1 line height. Also the "Autofit height" and
"Use dynamic spacing" settings are changed, likely related
to their missing DOCX export.
Co-authored-by: Tibor Nagy (NISZ)
(cherry picked from commit d656191ec308d4280b93c7169372e543a255d108)
Change-Id: I8319c93c6c5a980878ee9956c8ab2953da60409e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129102
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/ooxmlexport/data/tdf119952_negativeMargins.docx
b/sw/qa/extras/ooxmlexport/data/tdf119952_negativeMargins.docx
new file mode 100644
index ..9b5a98d3f1aa
Binary files /dev/null and
b/sw/qa/extras/ooxmlexport/data/tdf119952_negativeMargins.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
index 1638d93cf878..4523b19e5311 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport11.cxx
@@ -1424,6 +1424,89 @@ DECLARE_OOXMLEXPORT_TEST(testTdf124678_case2,
"tdf124678_with_leading_paragraph.
CPPUNIT_ASSERT_EQUAL_MESSAGE("Second page header text",
OUString("HEADER"), parseDump("/root/page[2]/header/txt"));
}
+static bool lcl_nearEqual(const sal_Int32 nNumber1, const sal_Int32 nNumber2,
sal_Int32 nMaxDiff = 5)
+{
+return std::abs(nNumber1 - nNumber2) < nMaxDiff;
+}
+
+DECLARE_OOXMLEXPORT_TEST(testTdf119952_negativeMargins,
"tdf119952_negativeMargins.docx")
+{
+// With negative margins (in MS Word) one can set up header (or footer)
that overlaps with the body.
+// LibreOffice unable to display that, so when importing negative margins,
+// the header (or footer) converted to a flyframe, anchored to the header..
+// that can overlap with the body, and will appear like in Word.
+// This conversion modifies the document [i.e. replacing header text with
a textbox...]
+// but its DOCX export looks the same, as the original document in Word,
too.
+xmlDocUniquePtr pDump = parseLayoutDump();
+
+//Check layout positions / sizes
+sal_Int32 nLeftHead = getXPath(pDump, "//page[1]/header/infos/bounds",
"left").toInt32();
+sal_Int32 nLeftBody = getXPath(pDump, "//page[1]/body/infos/bounds",
"left").toInt32();
+sal_Int32 nLeftFoot = getXPath(pDump, "//page[1]/footer/infos/bounds",
"left").toInt32();
+sal_Int32 nLeftHFly = getXPath(pDump,
"//page[1]/header/txt/anchored/fly/infos/bounds", "left").toInt32();
+sal_Int32 nLeftFFly = getXPath(pDump,
"//page[1]/footer/txt/anchored/fly/infos/bounds", "left").toInt32();
+
+sal_Int32 nTopHead = getXPath(pDump, "//page[1]/header/infos/bounds",
"top").toInt32();
+sal_Int32 nTopBody = getXPath(pDump, "//page[1]/body/infos/bounds",
"top").toInt32();
+sal_Int32 nTopFoot = getXPath(pDump, "//page[1]/footer/infos/bounds",
"top").toInt32();
+sal_Int32 nTopHFly = getXPath(pDump,
"//page[1]/header/txt/anchored/fly/infos/bounds", "top").toInt32();
+sal_Int32 nTopFFly = getXPath(pDump,
"//page[1]/footer/txt/anchored/fly/infos/bounds", "top").toInt32();
+
+
[Libreoffice-bugs] [Bug 117836] Missing colours in colour palette tonal in preview
https://bugs.documentfoundation.org/show_bug.cgi?id=117836 Julien Nabet changed: What|Removed |Added CC||serval2...@yahoo.fr, ||vstuart.fo...@utsa.edu --- Comment #6 from Julien Nabet --- On pc Debian x86-64 with master sources updated today, I could reproduce this. The colors are defined in extras/source/palettes/tonal.soc The 21 blank boxes correspond to the 21 lines which indicate "Out of Gamut", eg: extras/source/palettes/tonal.soc:16: V Stuart: any thoughts here? (I'm not expert about color management RGB/CMYK, Gamut issues, etc...) I mean, it seems it might be expected but I don't understand the use of these. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source
chart2/source/inc/DataSourceHelper.hxx |2 +-
chart2/source/tools/DataSourceHelper.cxx |6 ++
2 files changed, 3 insertions(+), 5 deletions(-)
New commits:
commit 8c558549b7dc3348da207627663824043eed6204
Author: Noel Grandin
AuthorDate: Thu Jan 27 17:57:53 2022 +0200
Commit: Noel Grandin
CommitDate: Fri Jan 28 18:08:59 2022 +0100
use more concrete types in chart2, ChartModel
Change-Id: I0f1c50448f6ab744e40d8744340685f59f139261
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129109
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/inc/DataSourceHelper.hxx
b/chart2/source/inc/DataSourceHelper.hxx
index 892412cc8d63..3956ab9d05b5 100644
--- a/chart2/source/inc/DataSourceHelper.hxx
+++ b/chart2/source/inc/DataSourceHelper.hxx
@@ -77,7 +77,7 @@ public:
, bool& bUseColumns, bool& bFirstCellAsLabel, bool& bHasCategories
);
static css::uno::Reference< css::chart2::data::XDataSource >
-pressUsedDataIntoRectangularFormat( const css::uno::Reference<
css::chart2::XChartDocument >& xChartDoc );
+pressUsedDataIntoRectangularFormat( const rtl::Reference<
::chart::ChartModel >& xChartDoc );
SAL_DLLPRIVATE static css::uno::Sequence< OUString > getUsedDataRanges(
const rtl::Reference< ::chart::Diagram > & xDiagram );
diff --git a/chart2/source/tools/DataSourceHelper.cxx
b/chart2/source/tools/DataSourceHelper.cxx
index eda39aa7de78..37a1fc666057 100644
--- a/chart2/source/tools/DataSourceHelper.cxx
+++ b/chart2/source/tools/DataSourceHelper.cxx
@@ -220,14 +220,12 @@ void DataSourceHelper::readArguments( const
uno::Sequence< beans::PropertyValue
}
uno::Reference< chart2::data::XDataSource >
DataSourceHelper::pressUsedDataIntoRectangularFormat(
-const uno::Reference< chart2::XChartDocument >& xChartDoc )
+const rtl::Reference< ChartModel >& xChartDoc )
{
std::vector< Reference< chart2::data::XLabeledDataSequence > >
aResultVector;
//categories are always the first sequence
-auto pModel = dynamic_cast(xChartDoc.get());
-assert(pModel);
-rtl::Reference< Diagram > xDiagram( pModel->getFirstChartDiagram());
+rtl::Reference< Diagram > xDiagram( xChartDoc->getFirstChartDiagram());
Reference< chart2::data::XLabeledDataSequence > xCategories(
DiagramHelper::getCategoriesFromDiagram( xDiagram ) );
if( xCategories.is() )
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/window/salframe.cxx | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) New commits: commit 1dea71cbaa04a68aa496a146bb71a690aed0f88d Author: Caolán McNamara AuthorDate: Fri Jan 28 15:41:52 2022 + Commit: Caolán McNamara CommitDate: Fri Jan 28 18:05:30 2022 +0100 Related: tdf#146261 the intent it to keep the dialog within the screen not the parent allocation Change-Id: I1801fca14e864e4e18c0b42d7f3c3956e71f8e23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129115 Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara diff --git a/vcl/unx/generic/window/salframe.cxx b/vcl/unx/generic/window/salframe.cxx index 70803c7353e4..4b1a00e2eed3 100644 --- a/vcl/unx/generic/window/salframe.cxx +++ b/vcl/unx/generic/window/salframe.cxx @@ -1725,15 +1725,20 @@ void X11SalFrame::SetWindowState( const SalFrameState *pState ) } } +auto nRight = aPosSize.Right() + (mpParent ? mpParent->maGeometry.nX : 0); +auto nBottom = aPosSize.Bottom() + (mpParent ? mpParent->maGeometry.nY : 0); +auto nLeft = aPosSize.Left() + (mpParent ? mpParent->maGeometry.nX : 0); +auto nTop = aPosSize.Top() + (mpParent ? mpParent->maGeometry.nY : 0); + // adjust position so that frame fits onto screen -if( aPosSize.Right()+static_cast(aGeom.nRightDecoration) > aScreenSize.Width()-1 ) -aPosSize.Move( aScreenSize.Width() - aPosSize.Right() - static_cast(aGeom.nRightDecoration), 0 ); -if( aPosSize.Bottom()+static_cast(aGeom.nBottomDecoration) > aScreenSize.Height()-1 ) -aPosSize.Move( 0, aScreenSize.Height() - aPosSize.Bottom() - static_cast(aGeom.nBottomDecoration) ); -if( aPosSize.Left() < static_cast(aGeom.nLeftDecoration) ) -aPosSize.Move( static_cast(aGeom.nLeftDecoration) - aPosSize.Left(), 0 ); -if( aPosSize.Top() < static_cast(aGeom.nTopDecoration) ) -aPosSize.Move( 0, static_cast(aGeom.nTopDecoration) - aPosSize.Top() ); +if( nRight+static_cast(aGeom.nRightDecoration) > aScreenSize.Width()-1 ) +aPosSize.Move( aScreenSize.Width() - nRight - static_cast(aGeom.nRightDecoration), 0 ); +if( nBottom+static_cast(aGeom.nBottomDecoration) > aScreenSize.Height()-1 ) +aPosSize.Move( 0, aScreenSize.Height() - nBottom - static_cast(aGeom.nBottomDecoration) ); +if( nLeft < static_cast(aGeom.nLeftDecoration) ) +aPosSize.Move( static_cast(aGeom.nLeftDecoration) - nLeft, 0 ); +if( nTop < static_cast(aGeom.nTopDecoration) ) +aPosSize.Move( 0, static_cast(aGeom.nTopDecoration) - nTop ); } SetPosSize(aPosSize.getX(), aPosSize.getY(),
[Libreoffice-bugs] [Bug 122708] UI: Template manager, no highlighting when the focus is inside the template preview window (using keyboard)
https://bugs.documentfoundation.org/show_bug.cgi?id=122708 Katarina Behrens changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |bu...@bubli.org |desktop.org | -- You are receiving this mail because: You are the assignee for the bug.
