[Libreoffice-commits] core.git: sal/rtl

[Mike Kaganski (via logerrit)]

 sal/rtl/string.cxx  |   15 ++-
 sal/rtl/strtmpl.hxx |   52 
 sal/rtl/ustring.cxx |   15 ++-
 3 files changed, 20 insertions(+), 62 deletions(-)

New commits:
commit 8ae8bea13565012410ecf13332f4696346294c12
Author: Mike Kaganski 
AuthorDate: Wed Mar 2 10:11:23 2022 +0300
Commit: Mike Kaganski 
CommitDate: Wed Mar 2 08:54:56 2022 +0100

Drop useless indirection and unused template

Change-Id: Icbcf56c30c9d901a4436f56a1648a7c8e7504848
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130817
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sal/rtl/string.cxx b/sal/rtl/string.cxx
index 87c65f6069ce..c5d535075354 100644
--- a/sal/rtl/string.cxx
+++ b/sal/rtl/string.cxx
@@ -506,28 +506,33 @@ sal_Bool SAL_CALL rtl_str_toBoolean(const char* pStr) 
SAL_THROW_EXTERN_C()
 
 sal_Int32 SAL_CALL rtl_str_toInt32(const char* pStr, sal_Int16 nRadix) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toInt32(pStr, nRadix);
+assert(pStr);
+return rtl::str::toInt(pStr, nRadix);
 }
 
 sal_Int64 SAL_CALL rtl_str_toInt64(const char* pStr, sal_Int16 nRadix) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toInt64(pStr, nRadix);
+assert(pStr);
+return rtl::str::toInt(pStr, nRadix);
 }
 
 sal_Int64 SAL_CALL rtl_str_toInt64_WithLength(const char* pStr, sal_Int16 
nRadix,
   sal_Int32 nStrLength) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toInt64_WithLength(pStr, nRadix, nStrLength);
+assert(pStr || nStrLength == 0);
+return rtl::str::toInt(std::basic_string_view(pStr, 
nStrLength), nRadix);
 }
 
 sal_uInt32 SAL_CALL rtl_str_toUInt32(const char* pStr, sal_Int16 nRadix) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toUInt32(pStr, nRadix);
+assert(pStr);
+return rtl::str::toInt(pStr, nRadix);
 }
 
 sal_uInt64 SAL_CALL rtl_str_toUInt64(const char* pStr, sal_Int16 nRadix) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toUInt64(pStr, nRadix);
+assert(pStr);
+return rtl::str::toInt(pStr, nRadix);
 }
 
 rtl_String* rtl_string_ImplAlloc(sal_Int32 nLen) { return 
rtl::str::Alloc(nLen); }
diff --git a/sal/rtl/strtmpl.hxx b/sal/rtl/strtmpl.hxx
index a6b06ad0256e..6988865e8f11 100644
--- a/sal/rtl/strtmpl.hxx
+++ b/sal/rtl/strtmpl.hxx
@@ -834,58 +834,6 @@ template  T toInt(S str, sal_Int16 
nRadix)
 return static_cast(n);
 }
 
-template 
-sal_Int32 toInt32 ( const IMPL_RTL_STRCODE* pStr,
-sal_Int16 nRadix )
-{
-assert(pStr);
-return toInt(pStr, nRadix);
-}
-
-template 
-sal_Int32 toInt32_WithLength  ( const IMPL_RTL_STRCODE* pStr,
-sal_Int16 nRadix,
-sal_Int32 nStrLength)
-
-{
-assert(pStr);
-return toInt(std::basic_string_view(pStr, nStrLength), nRadix);
-}
-
-template 
-sal_Int64 toInt64 ( const IMPL_RTL_STRCODE* pStr,
-sal_Int16 nRadix )
-{
-assert(pStr);
-return toInt(pStr, nRadix);
-}
-
-template 
-sal_Int64 toInt64_WithLength  ( const IMPL_RTL_STRCODE* pStr,
-sal_Int16 nRadix,
-sal_Int32 nStrLength)
-
-{
-assert(pStr);
-return toInt(std::basic_string_view(pStr, nStrLength), nRadix);
-}
-
-template 
-sal_uInt32 toUInt32 ( const IMPL_RTL_STRCODE* pStr,
-  sal_Int16 nRadix )
-{
-assert(pStr);
-return toInt(pStr, nRadix);
-}
-
-template 
-sal_uInt64 toUInt64 ( const IMPL_RTL_STRCODE* pStr,
-  sal_Int16 nRadix )
-{
-assert(pStr);
-return toInt(pStr, nRadix);
-}
-
 /* === */
 /* Internal String-Class help functions*/
 /* === */
diff --git a/sal/rtl/ustring.cxx b/sal/rtl/ustring.cxx
index 62157a6bafca..4451866e4588 100644
--- a/sal/rtl/ustring.cxx
+++ b/sal/rtl/ustring.cxx
@@ -1171,30 +1171,35 @@ sal_Bool SAL_CALL rtl_ustr_toBoolean(const sal_Unicode* 
pStr) SAL_THROW_EXTERN_C
 
 sal_Int32 SAL_CALL rtl_ustr_toInt32(const sal_Unicode* pStr, sal_Int16 nRadix) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toInt32(pStr, nRadix);
+assert(pStr);
+return rtl::str::toInt(pStr, nRadix);
 }
 
 sal_Int64 SAL_CALL rtl_ustr_toInt64(const sal_Unicode* pStr, sal_Int16 nRadix) 
SAL_THROW_EXTERN_C()
 {
-return rtl::str::toInt64(pStr, nRadix);
+assert(pStr);
+return rtl::str::toInt(pStr, nRadix);
 }
 
 sal_Int64 SAL_CALL rtl_ustr_toInt64_WithLength(const sal_Unicode* pStr, 
sal_Int16 nRadix,

[Libreoffice-bugs] [Bug 145160] Writer Impress : the image compression form should select by default the former image format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145160

Heiko Tietze  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #4 from Heiko Tietze  ---
Duplicate of bug 146929? The settings will be remembered across the session.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147456] Libreoffice Writer default jpeg image compression different than online help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147456

Heiko Tietze  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8658

--- Comment #4 from Heiko Tietze  ---
(In reply to andreas_k from comment #3)
> I changed the default to 80% ...

For bug 128658. So rather update the documentation? Franz, can you follow
Andreas' arguments?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147456] Libreoffice Writer default jpeg image compression different than online help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147456

andreas_k  changed:

   What|Removed |Added

 CC||kain...@gmail.com

--- Comment #3 from andreas_k  ---
I changed the default to 80% which make the images smaller in file size, but
you can't see it with your eyes. 

In addition you click on image compression, so the user want smaller file size.
If you use 90% the sizes are way bigger.

The difference between 90% and 80% are ordinary factor 10.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: 2 commits - sw/source

[Noel Grandin (via logerrit)]

 sw/source/filter/ww8/docxattributeoutput.cxx |   10 +-
 sw/source/filter/ww8/writerhelper.cxx|2 
 sw/source/filter/ww8/writerhelper.hxx|   91 ---
 sw/source/filter/ww8/writerwordglue.cxx  |3 
 sw/source/filter/ww8/wrtw8nds.cxx|   20 ++---
 sw/source/filter/ww8/wrtw8sty.cxx|4 -
 sw/source/filter/ww8/wrtww8.cxx  |2 
 sw/source/filter/ww8/ww8atr.cxx  |6 -
 sw/source/filter/ww8/ww8par.cxx  |4 -
 sw/source/filter/ww8/ww8par2.cxx |2 
 sw/source/filter/ww8/ww8par3.cxx |6 -
 sw/source/filter/ww8/ww8par5.cxx |6 -
 sw/source/filter/ww8/ww8par6.cxx |   12 +--
 13 files changed, 37 insertions(+), 131 deletions(-)

New commits:
commit 2d33c22e55b7af7481cc36a1fff979a33daf8519
Author: Noel Grandin 
AuthorDate: Tue Mar 1 19:20:44 2022 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 2 08:31:49 2022 +0100

remove writerhelper::DefaultItemGet

the TypedWhichId template methods on SfxItemPool supercede this

Change-Id: Ice8fc953b0ec2cc3cfd4075a99f21889c23accda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130806
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ww8/writerhelper.hxx 
b/sw/source/filter/ww8/writerhelper.hxx
index e07c6759d9c6..a9bb8ce04a66 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -248,71 +248,6 @@ namespace sw
 return dynamic_cast(pItem);
 }
 
-/** Extract a default SfxPoolItem derived property from a SfxItemPool
-
-Writer's attributes are retrieved by passing a numeric identifier
-and receiving a SfxPoolItem reference which must then typically be
-cast back to its original type which is both tedious and verbose.
-
-DefaultItemGet returns a reference to the default property of a
-given SfxItemPool for a given property id, e.g. default fontsize
-
-DefaultItemGet uses item_cast () on the retrieved reference to test
-that the retrieved property is of the type that the developer 
thinks
-it is.
-
-@param rPool
-The SfxItemPool whose default property we want
-
-@param eType
-The numeric identifier of the default property to be retrieved
-
-@tplparam T
-A SfxPoolItem derived class of the retrieved property
-
-@exception std::bad_cast Thrown if the property was not a T
-
-@return The T requested
-*/
-template const T & DefaultItemGet(const SfxItemPool ,
-sal_uInt16 eType)
-{
-return item_cast(rPool.GetDefaultItem(eType));
-}
-
-/** Extract a default SfxPoolItem derived property from a SwDoc
-
-Writer's attributes are retrieved by passing a numeric identifier
-and receiving a SfxPoolItem reference which must then typically be
-cast back to its original type which is both tedious and verbose.
-
-DefaultItemGet returns a reference to the default property of a
-given SwDoc (Writer Document) for a given property id, e.g default
-fontsize
-
-DefaultItemGet uses item_cast () on the retrieved reference to test
-that the retrieved property is of the type that the developer 
thinks
-it is.
-
-@param rPool
-The SfxItemPool whose default property we want
-
-@param eType
-The numeric identifier of the default property to be retrieved
-
-@tplparam T
-A SfxPoolItem derived class of the retrieved property
-
-@exception std::bad_cast Thrown if the property was not a T
-
-@return The T requested
-*/
-template const T & DefaultItemGet(const SwDoc ,
-sal_uInt16 eType)
-{
-return DefaultItemGet(rDoc.GetAttrPool(), eType);
-}
-
 /** Get the Paragraph Styles of a SwDoc
 
 Writer's styles are in one of those dreaded macro based pre-STL
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx 
b/sw/source/filter/ww8/wrtw8nds.cxx
index ff9304815f78..658cadabba08 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -1706,7 +1706,7 @@ const SvxBrushItem* WW8Export::GetCurrentPageBgBrush() 
const
 if (SfxItemState::SET != eState || !pRet || (!pRet->GetGraphic() &&
 pRet->GetColor() == COL_TRANSPARENT))
 {
-pRet = &(DefaultItemGet(m_rDoc,RES_BACKGROUND));
+pRet = _rDoc.GetAttrPool().GetDefaultItem(RES_BACKGROUND);
 }
 return pRet;
 }
@@ -3644,12 +3644,12 @@ WW8Ruby::WW8Ruby(const SwTextNode& rNode, const 
SwFormatRuby& rRuby, const MSWor
 pPool = pPool ? pPool : _rDoc.GetAttrPool();
 
 
-const 

[Libreoffice-commits] core.git: 2 commits - sw/inc sw/source

[Noel Grandin (via logerrit)]

 sw/inc/hintids.hxx  |6 ++
 sw/source/core/bastyp/calc.cxx  |6 +++---
 sw/source/core/fields/expfld.cxx|8 
 sw/source/filter/ww8/writerhelper.cxx   |2 +-
 sw/source/filter/ww8/writerhelper.hxx   |   28 
 sw/source/filter/ww8/writerwordglue.cxx |4 ++--
 sw/source/filter/ww8/wrtw8esh.cxx   |2 +-
 sw/source/filter/ww8/wrtw8nds.cxx   |2 +-
 sw/source/filter/ww8/ww8atr.cxx |   12 +---
 sw/source/filter/ww8/ww8par6.cxx|2 +-
 sw/source/uibase/shells/annotsh.cxx |6 --
 sw/source/uibase/shells/drwtxtsh.cxx|8 ++--
 sw/source/uibase/shells/textsh.cxx  |   12 +++-
 13 files changed, 41 insertions(+), 57 deletions(-)

New commits:
commit 919b923e9fe59bd83d954a53c21635317fea0de7
Author: Noel Grandin 
AuthorDate: Tue Mar 1 19:04:01 2022 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 2 08:31:07 2022 +0100

remove writerhelper::ItemGet

the TypedWhichId template methods on SwContentNode supercede this

Change-Id: Ibb9a6a6a1642e2d764004c7179dce642fef7a40a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130804
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ww8/writerhelper.cxx 
b/sw/source/filter/ww8/writerhelper.cxx
index 64cb0d7959c7..740274453dfb 100644
--- a/sw/source/filter/ww8/writerhelper.cxx
+++ b/sw/source/filter/ww8/writerhelper.cxx
@@ -592,7 +592,7 @@ namespace sw
 pBreak = &(ItemGet(*pApply, 
RES_BREAK));
 }
 else if (const SwContentNode *pNd = rNd.GetContentNode())
-pBreak = &(ItemGet(*pNd, RES_BREAK));
+pBreak = >GetAttr(RES_BREAK);
 
 return pBreak && pBreak->GetBreak() == SvxBreak::PageBefore;
 }
diff --git a/sw/source/filter/ww8/writerhelper.hxx 
b/sw/source/filter/ww8/writerhelper.hxx
index 29e9a8e6b495..65d5c2501bc4 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -248,34 +248,6 @@ namespace sw
 return dynamic_cast(pItem);
 }
 
-/** Extract a SfxPoolItem derived property from a SwContentNode
-
-Writer's attributes are retrieved by passing a numeric identifier
-and receiving a SfxPoolItem reference which must then typically be
-cast back to its original type which is both tedious and verbose.
-
-ItemGet uses item_cast () on the retrieved reference to test that 
the
-retrieved property is of the type that the developer thinks it is.
-
-@param rNode
-The SwContentNode to retrieve the property from
-
-@param eType
-The numeric identifier of the property to be retrieved
-
-@tplparam T
-A SfxPoolItem derived class of the retrieved property
-
-@exception std::bad_cast Thrown if the property was not a T
-
-@return The T requested
-*/
-template const T & ItemGet(const SwContentNode ,
-sal_uInt16 eType)
-{
-return item_cast(rNode.GetAttr(eType));
-}
-
 /** Extract a SfxPoolItem derived property from a SwFormat
 
 Writer's attributes are retrieved by passing a numeric identifier
diff --git a/sw/source/filter/ww8/writerwordglue.cxx 
b/sw/source/filter/ww8/writerwordglue.cxx
index fda1043db476..5474148b5c5d 100644
--- a/sw/source/filter/ww8/writerwordglue.cxx
+++ b/sw/source/filter/ww8/writerwordglue.cxx
@@ -532,8 +532,8 @@ namespace sw
 if (!rText.isEmpty())
 nScript = g_pBreakIt->GetBreakIter()->getScriptType(rText, 0);
 
-rtl_TextEncoding eChrSet = ItemGet(rTextNd,
-GetWhichOfScript(RES_CHRATR_FONT, nScript)).GetCharSet();
+TypedWhichId nFontWhichId = 
GetWhichOfScript(RES_CHRATR_FONT, nScript);
+rtl_TextEncoding eChrSet = 
rTextNd.GetAttr(nFontWhichId).GetCharSet();
 eChrSet = GetExtendedTextEncoding(eChrSet);
 
 CharRuns aRunChanges;
diff --git a/sw/source/filter/ww8/wrtw8esh.cxx 
b/sw/source/filter/ww8/wrtw8esh.cxx
index 6ce80301125c..82392ea5106c 100644
--- a/sw/source/filter/ww8/wrtw8esh.cxx
+++ b/sw/source/filter/ww8/wrtw8esh.cxx
@@ -2425,7 +2425,7 @@ bool WinwordAnchoring::ConvertPosition( 
SwFormatHoriOrient& _iorHoriOri,
 {
 SwTextNode& rAnchorTextNode =
 
dynamic_cast(_rFrameFormat.GetAnchor().GetContentAnchor()->nNode.GetNode());
-const SvxFormatBreakItem& rBreak = 
ItemGet(rAnchorTextNode, RES_BREAK);
+const SvxFormatBreakItem& rBreak = rAnchorTextNode.GetAttr(RES_BREAK);
 if (rBreak.GetBreak() == SvxBreak::ColumnBefore)
 {
 bConvDueToAnchoredAtColBreakPara = true;
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx 
b/sw/source/filter/ww8/wrtw8nds.cxx
index bf0d049b1d6a..394203367dc4 100644
--- 

[Libreoffice-bugs] [Bug 147456] Libreoffice Writer default jpeg image compression different than online help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147456

Heiko Tietze  changed:

   What|Removed |Added

  Component|Writer  |UI
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicUI
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mentoring@documentfoundatio
   ||n.org
   Severity|normal  |enhancement
 OS|Windows (All)   |All

--- Comment #2 from Heiko Tietze  ---
Yes, let's go with 90 (it's not percent but some arbitrary value between 1 and
100).

Code pointer: 
* QualityMF in svx/source/dialog/compressgraphicdialog.cxx
* quality-adjustment-spin/quality-adjustment-scale in
svx/uiconfig/ui/compressgraphicdialog.ui (but those will be overwritten anyway)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147456] Libreoffice Writer default jpeg image compression different than online help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147456

Heiko Tietze  changed:

   What|Removed |Added

  Component|Writer  |UI
   Keywords|needsUXEval |difficultyBeginner,
   ||easyHack, skillDesign,
   ||topicUI
 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org,
   ||mentoring@documentfoundatio
   ||n.org
   Severity|normal  |enhancement
 OS|Windows (All)   |All

--- Comment #2 from Heiko Tietze  ---
Yes, let's go with 90 (it's not percent but some arbitrary value between 1 and
100).

Code pointer: 
* QualityMF in svx/source/dialog/compressgraphicdialog.cxx
* quality-adjustment-spin/quality-adjustment-scale in
svx/uiconfig/ui/compressgraphicdialog.ui (but those will be overwritten anyway)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: embeddedobj/qa

[Miklos Vajna (via logerrit)]

 embeddedobj/qa/cppunit/general.cxx |   17 ++---
 1 file changed, 10 insertions(+), 7 deletions(-)

New commits:
commit a12b4d548cd4173d87d8736ec6a484becb44d943
Author: Miklos Vajna 
AuthorDate: Tue Mar 1 20:17:41 2022 +0100
Commit: Miklos Vajna 
CommitDate: Wed Mar 2 08:14:21 2022 +0100

CppunitTest_embeddedobj_general: put the base class into an anon namespace

Which reduces the probability that the base class name collides with a
symbol from non-test code.

Change-Id: I7df17a76602b12da7b10cb77f6e44466676d15a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130811
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/embeddedobj/qa/cppunit/general.cxx 
b/embeddedobj/qa/cppunit/general.cxx
index 815656519c83..c7824fe87eaf 100644
--- a/embeddedobj/qa/cppunit/general.cxx
+++ b/embeddedobj/qa/cppunit/general.cxx
@@ -21,8 +21,10 @@
 
 using namespace ::com::sun::star;
 
-/// embeddedobj general tests.
-class EmbeddedobjGeneralTest : public test::BootstrapFixture, public 
unotest::MacrosTest
+namespace
+{
+/// Covers embeddedobj/source/general/ fixes.
+class Test : public test::BootstrapFixture, public unotest::MacrosTest
 {
 private:
 uno::Reference mxComponent;
@@ -33,22 +35,23 @@ public:
 uno::Reference& getComponent() { return mxComponent; }
 };
 
-void EmbeddedobjGeneralTest::setUp()
+void Test::setUp()
 {
 test::BootstrapFixture::setUp();
 
 mxDesktop.set(frame::Desktop::create(mxComponentContext));
 }
 
-void EmbeddedobjGeneralTest::tearDown()
+void Test::tearDown()
 {
 if (mxComponent.is())
 mxComponent->dispose();
 
 test::BootstrapFixture::tearDown();
 }
+}
 
-CPPUNIT_TEST_FIXTURE(EmbeddedobjGeneralTest, testInsertFileConfig)
+CPPUNIT_TEST_FIXTURE(Test, testInsertFileConfig)
 {
 // Explicitly disable Word->Writer mapping for this test.
 std::shared_ptr pBatch(
@@ -82,7 +85,7 @@ CPPUNIT_TEST_FIXTURE(EmbeddedobjGeneralTest, 
testInsertFileConfig)
 CPPUNIT_ASSERT(!xObject.is());
 }
 
-CPPUNIT_TEST_FIXTURE(EmbeddedobjGeneralTest, testInsertFileConfigVsdx)
+CPPUNIT_TEST_FIXTURE(Test, testInsertFileConfigVsdx)
 {
 // Explicitly disable Word->Writer mapping for this test.
 std::shared_ptr pBatch(
@@ -115,7 +118,7 @@ CPPUNIT_TEST_FIXTURE(EmbeddedobjGeneralTest, 
testInsertFileConfigVsdx)
 CPPUNIT_ASSERT(!xObject.is());
 }
 
-CPPUNIT_TEST_FIXTURE(EmbeddedobjGeneralTest, testInsertFileConfigPdf)
+CPPUNIT_TEST_FIXTURE(Test, testInsertFileConfigPdf)
 {
 // Explicitly disable Word->Writer mapping for this test.
 std::shared_ptr pBatch(

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5752760f0af5c5c6411d4dc7704b2a683211341f
Author: Adolfo Jayme Barrientos 
AuthorDate: Wed Mar 2 00:47:25 2022 -0600
Commit: Gerrit Code Review 
CommitDate: Wed Mar 2 07:47:25 2022 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to e15b650cf80aea131a4429d4bda438130f4cf601
  - Update menu path

Change-Id: I2f23458e8abc9697b0a2da089e6fd48c86503186
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130816
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index dd0acce90739..e15b650cf80a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit dd0acce907394934a9323fc2d34290f1db74f166
+Subproject commit e15b650cf80aea131a4429d4bda438130f4cf601

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos (via logerrit)]

 source/text/swriter/guide/smarttags.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e15b650cf80aea131a4429d4bda438130f4cf601
Author: Adolfo Jayme Barrientos 
AuthorDate: Wed Mar 2 00:46:26 2022 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 2 07:47:24 2022 +0100

Update menu path

Change-Id: I2f23458e8abc9697b0a2da089e6fd48c86503186
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/130816
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/swriter/guide/smarttags.xhp 
b/source/text/swriter/guide/smarttags.xhp
index ef9db24ae..26a5b0d50 100644
--- a/source/text/swriter/guide/smarttags.xhp
+++ b/source/text/swriter/guide/smarttags.xhp
@@ -52,7 +52,7 @@
   When you 
point to a Smart Tag, a tip help informs you to CommandCtrl-click
 to open the Smart Tags menu. If you don't use a mouse, position the cursor 
inside the marked text and open the context menu by 
Shift+F10.
   In the 
Smart Tags menu you see the available actions that are defined for this Smart 
Tag. Choose an option from the menu. The Smart Tags 
Options command opens the Smart 
Tags page of Tools - Autocorrect Options.
   To Enable and Disable Smart Tags
-  When you 
have installed at least one Smart Tags extension, you see the Smart Tags page in Tools - Autocorrect Options. Use this dialog to enable 
or disable Smart Tags and to manage the installed tags.
+  When you 
have installed at least one Smart Tags extension, you see the Smart Tags page in Tools - AutoCorrect - AutoCorrect Options. Use this 
dialog to enable or disable Smart Tags and to manage the installed 
tags.
   Text that is 
recognized as a Smart Tag is not checked by the automatic 
spellcheck.

 

[Libreoffice-commits] core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/filter/ww8/writerhelper.hxx   |   28 
 sw/source/filter/ww8/writerwordglue.cxx |3 +--
 sw/source/filter/ww8/wrtw8esh.cxx   |2 +-
 sw/source/filter/ww8/wrtw8nds.cxx   |   13 ++---
 sw/source/filter/ww8/ww8atr.cxx |   12 +---
 sw/source/filter/ww8/ww8graf.cxx|2 +-
 sw/source/filter/ww8/ww8par.cxx |2 +-
 sw/source/filter/ww8/ww8par6.cxx|   10 +-
 8 files changed, 20 insertions(+), 52 deletions(-)

New commits:
commit aa01aa03b73ddeeae1f98730b21ec77338af5f9e
Author: Noel Grandin 
AuthorDate: Tue Mar 1 18:57:56 2022 +0200
Commit: Noel Grandin 
CommitDate: Wed Mar 2 07:46:07 2022 +0100

remove writerhelper::ItemGet

the TypedWhichId template methods on SfxItemSet supercede this

Change-Id: I9c6240657a7c98fad93399f9ce17c370acd125c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130803
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/filter/ww8/writerhelper.hxx 
b/sw/source/filter/ww8/writerhelper.hxx
index 91b881eaf57c..29e9a8e6b495 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -302,34 +302,6 @@ namespace sw
 return item_cast(rFormat.GetFormatAttr(eType));
 }
 
-/** Extract a SfxPoolItem derived property from a SfxItemSet
-
-Writer's attributes are retrieved by passing a numeric identifier
-and receiving a SfxPoolItem reference which must then typically be
-cast back to its original type which is both tedious and verbose.
-
-ItemGet uses item_cast () on the retrieved reference to test that 
the
-retrieved property is of the type that the developer thinks it is.
-
-@param rSet
-The SfxItemSet to retrieve the property from
-
-@param eType
-The numeric identifier of the property to be retrieved
-
-@tplparam T
-A SfxPoolItem derived class of the retrieved property
-
-@exception std::bad_cast Thrown if the property was not a T
-
-@return The T requested
-*/
-template const T & ItemGet(const SfxItemSet ,
-sal_uInt16 eType)
-{
-return item_cast(rSet.Get(eType));
-}
-
 /** Extract a default SfxPoolItem derived property from a SfxItemPool
 
 Writer's attributes are retrieved by passing a numeric identifier
diff --git a/sw/source/filter/ww8/writerwordglue.cxx 
b/sw/source/filter/ww8/writerwordglue.cxx
index 3d4a06e5cce3..fda1043db476 100644
--- a/sw/source/filter/ww8/writerwordglue.cxx
+++ b/sw/source/filter/ww8/writerwordglue.cxx
@@ -404,8 +404,7 @@ namespace sw
 {
 dyaHdrTop = dyaHdrBottom = 0;
 }
-const SvxULSpaceItem  =
-ItemGet(rPage, RES_UL_SPACE);
+const SvxULSpaceItem  = rPage.Get(RES_UL_SPACE);
 dyaHdrTop += rUL.GetUpper();
 dyaHdrBottom += rUL.GetLower();
 
diff --git a/sw/source/filter/ww8/wrtw8esh.cxx 
b/sw/source/filter/ww8/wrtw8esh.cxx
index 7927d230a553..6ce80301125c 100644
--- a/sw/source/filter/ww8/wrtw8esh.cxx
+++ b/sw/source/filter/ww8/wrtw8esh.cxx
@@ -1032,7 +1032,7 @@ void MSWord_SdrAttrIter::NextPara( sal_Int32 nPar )
 
 SfxItemSet aSet( pEditObj->GetParaAttribs( nPara ));
 pEditPool = aSet.GetPool();
-eNdChrSet = ItemGet(aSet,EE_CHAR_FONTINFO).GetCharSet();
+eNdChrSet = aSet.Get(EE_CHAR_FONTINFO).GetCharSet();
 
 assert(g_pBreakIt && g_pBreakIt->GetBreakIter().is());
 nScript = g_pBreakIt->GetBreakIter()->getScriptType( 
pEditObj->GetText(nPara), 0);
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx 
b/sw/source/filter/ww8/wrtw8nds.cxx
index 36d80ebb427d..bf0d049b1d6a 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -403,7 +403,7 @@ void SwWW8AttrIter::OutAttr(sal_Int32 nSwPos, bool 
bWriteCombChars)
  script, the idea is that the font that is actually in use to render this
  range of text ends up in pFont
 */
-sal_uInt16 nFontId = GetWhichOfScript( RES_CHRATR_FONT, GetScript() );
+TypedWhichId nFontId = GetWhichOfScript( RES_CHRATR_FONT, 
GetScript() );
 
 const SvxFontItem  = ItemGet(
 static_cast(rNd.GetAnyFormatColl()), nFontId);
@@ -418,7 +418,7 @@ void SwWW8AttrIter::OutAttr(sal_Int32 nSwPos, bool 
bWriteCombChars)
 // only copy hard attributes - bDeep = false
 aExportSet.Set(rNd.GetSwAttrSet(), false/*bDeep*/);
 // get the current font item. Use rNd.GetSwAttrSet instead of 
aExportSet:
-const SvxFontItem  = ItemGet(rNd.GetSwAttrSet(), 
nFontId);
+const SvxFontItem  = rNd.GetSwAttrSet().Get(nFontId);
 pFont = 
 aExportSet.ClearItem(nFontId);
 }
@@ -2807,7 +2807,7 @@ void MSWordExportBase::OutputTextNode( SwTextNode& rNode )
 
 if ( 

[Libreoffice-bugs] [Bug 147411] SfxSlotMode TOOLBOXCONFIG & ACCELCONFIG not working independently from each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147411

--- Comment #2 from Heiko Tietze  ---
(In reply to Xisco Faulí from comment #1)
> @Heiko, easyhack ?

Ultimately it might be an easyhack but I have no idea where to look for the
problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 35092] Inking functionality: Ink drawings / annotations with Stylus, Pen or Finger on Touchscreen or Tablet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35092

--- Comment #159 from Zara Bolen  ---
A https://www.nativeassignmenthelp.co.uk/law-assignment-help/;>law
Assignment Helper is the legal experts who have extensive knowledge as a
researcher as well as subject matter experts and lawyers who are legal
consultants. Request Law Assignments from Legal Experts. If you're having
trouble with your assignments, you can ask for assistance online with your law
assignment. Our firm Native Assignment Help offers the most effective writing
services for law assignments across the UK.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127397] FILEOPEN PPTX combined stacked bar - stacked line chart has line category-axis not bottom but left

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=127397

Justin L  changed:

   What|Removed |Added

 Blocks||99877


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=99877
[Bug 99877] [CHART] XLTX wrongly imported chart
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 99877] [CHART] XLTX wrongly imported chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99877

Justin L  changed:

   What|Removed |Added

 Depends on||127397

--- Comment #12 from Justin L  ---
This seems primarily like bug 127397 - where the axis X / Y axis are flipped.
So lets make this report dependent on that one, and then any remaining issues
(like the extra Mentor G series not seen in Excel) can be cleaned up.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=127397
[Bug 127397] FILEOPEN PPTX combined stacked bar - stacked line chart has line
category-axis not bottom but left
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124943] Copy to edit bar adds a suffix space, that is inconsistent with paste to cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124943

davidpbrown  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
Version|5.4.7.2 release |7.3.0.3 release
 OS|All |Linux (All)
 Status|RESOLVED|REOPENED

--- Comment #6 from davidpbrown  ---
Still present in

Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source

[Caolán McNamara (via logerrit)]

 sw/source/core/layout/tabfrm.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 8dff1bd93a2f1db463002fc660f98388f69484a0
Author: Caolán McNamara 
AuthorDate: Tue Mar 1 11:45:23 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 2 06:30:39 2022 +0100

protect frame from triggering deleting itself

LIBREOFFICE-N4LA0OHZ

Change-Id: I0d24277665a317f047b286fe0f0878b3814ded65
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130788
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index f0ad11a0653a..7786f3aec4fc 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -2114,6 +2114,7 @@ void SwTabFrame::MakeAll(vcl::RenderContext* 
pRenderContext)
 }
 SwFootnoteBossFrame *pOldBoss = bFootnotesInDoc ? 
FindFootnoteBossFrame( true ) : nullptr;
 bool bReformat;
+SwFrameDeleteGuard g(this);
 if ( MoveBwd( bReformat ) )
 {
 aRectFnSet.Refresh(this);

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - sw/source

[Heiko Tietze (via logerrit)]

 sw/source/ui/misc/outline.cxx |   12 
 1 file changed, 8 insertions(+), 4 deletions(-)

New commits:
commit a0ad72cb1404544ae0a3c3062431ed22edb7fa21
Author: Heiko Tietze 
AuthorDate: Fri Feb 18 11:29:26 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 2 06:29:50 2022 +0100

Resolves tdf#137381 - Use app colors on chapter numbering preview

Change-Id: I8e5edec1ad6f4b6f44855014ce91a642efbd75f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130133
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 
(cherry picked from commit 87aeb7be943921942f791cd182122e8e073ce804)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130154
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sw/source/ui/misc/outline.cxx b/sw/source/ui/misc/outline.cxx
index c7fa599c9bfa..3c1345f308ae 100644
--- a/sw/source/ui/misc/outline.cxx
+++ b/sw/source/ui/misc/outline.cxx
@@ -42,6 +42,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -875,8 +876,8 @@ void NumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const tools::Re
 pVDev->SetOutputSize(aSize);
 
 // #101524# OJ
-
pVDev->SetFillColor(rRenderContext.GetSettings().GetStyleSettings().GetWindowColor());
-
pVDev->SetLineColor(rRenderContext.GetSettings().GetStyleSettings().GetButtonTextColor());
+pVDev->SetFillColor(SwViewOption::GetDocColor());
+pVDev->SetLineColor(SwViewOption::GetDocBoundariesColor());
 pVDev->DrawRect(tools::Rectangle(Point(0,0), aSize));
 
 if (pActNum)
@@ -897,8 +898,11 @@ void NumberingPreview::Paint(vcl::RenderContext& 
rRenderContext, const tools::Re
 tools::Long nYStart = 4;
 aStdFont = OutputDevice::GetDefaultFont(DefaultFontType::UI_SANS, 
GetAppLanguage(),
 GetDefaultFontFlags::OnlyOne, 
);
-// #101524# OJ
-aStdFont.SetColor(SwViewOption::GetFontColor());
+
+if (svtools::ColorConfig().GetColorValue(svtools::FONTCOLOR, 
false).nColor == COL_AUTO)
+aStdFont.SetColor( SwViewOption::GetDocColor().IsDark() ? 
COL_WHITE : COL_BLACK );
+else
+aStdFont.SetColor( SwViewOption::GetFontColor() );
 
 const tools::Long nFontHeight = nYStep * ( bPosition ? 15 : 6 ) / 10;
 aStdFont.SetFontSize(Size( 0, nFontHeight ));

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - icon-themes/sukapura icon-themes/sukapura_svg

[Rizal Muttaqin (via logerrit)]

 icon-themes/sukapura/cmd/32/grow.png  |binary
 icon-themes/sukapura/cmd/32/shrink.png|binary
 icon-themes/sukapura/cmd/32/smallcaps.png |binary
 icon-themes/sukapura/cmd/lc_defaultcharstyle.png  |binary
 icon-themes/sukapura/cmd/lc_grow.png  |binary
 icon-themes/sukapura/cmd/lc_shrink.png|binary
 icon-themes/sukapura/cmd/lc_smallcaps.png |binary
 icon-themes/sukapura/cmd/lc_textbodyparastyle.png |binary
 icon-themes/sukapura/cmd/sc_grow.png  |binary
 icon-themes/sukapura/cmd/sc_shrink.png|binary
 icon-themes/sukapura/cmd/sc_smallcaps.png |binary
 icon-themes/sukapura_svg/cmd/32/grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/32/ko/grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/32/ko/shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/32/shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/32/smallcaps.svg |6 +-
 icon-themes/sukapura_svg/cmd/ko/lc_grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/ko/lc_shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/ko/sc_grow.svg   |1 -
 icon-themes/sukapura_svg/cmd/ko/sc_shrink.svg |1 -
 icon-themes/sukapura_svg/cmd/lc_defaultcharstyle.svg  |2 +-
 icon-themes/sukapura_svg/cmd/lc_grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/lc_shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/lc_smallcaps.svg |2 +-
 icon-themes/sukapura_svg/cmd/lc_textbodyparastyle.svg |2 +-
 icon-themes/sukapura_svg/cmd/sc_grow.svg  |2 +-
 icon-themes/sukapura_svg/cmd/sc_shrink.svg|2 +-
 icon-themes/sukapura_svg/cmd/sc_smallcaps.svg |2 +-
 28 files changed, 15 insertions(+), 17 deletions(-)

New commits:
commit 1739fbb9a22d2e275329f1f1ce9fbfa3aea7b7fa
Author: Rizal Muttaqin 
AuthorDate: Tue Mar 1 06:25:32 2022 +0700
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 2 06:28:38 2022 +0100

Sukapura: tdf#147664 Revise Increase Font & Decrease Font, Default Style,

Small Caps icons

Change-Id: I1348cc7fbde63d335ba3676a4c424d76f8cf2349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130681
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/sukapura/cmd/32/grow.png 
b/icon-themes/sukapura/cmd/32/grow.png
index a8f5d739eac1..f6d50b1d6b5c 100644
Binary files a/icon-themes/sukapura/cmd/32/grow.png and 
b/icon-themes/sukapura/cmd/32/grow.png differ
diff --git a/icon-themes/sukapura/cmd/32/shrink.png 
b/icon-themes/sukapura/cmd/32/shrink.png
index f14197a4b0c5..f6932cb02d26 100644
Binary files a/icon-themes/sukapura/cmd/32/shrink.png and 
b/icon-themes/sukapura/cmd/32/shrink.png differ
diff --git a/icon-themes/sukapura/cmd/32/smallcaps.png 
b/icon-themes/sukapura/cmd/32/smallcaps.png
index 0c19165ed03e..e69de29bb2d1 100644
Binary files a/icon-themes/sukapura/cmd/32/smallcaps.png and 
b/icon-themes/sukapura/cmd/32/smallcaps.png differ
diff --git a/icon-themes/sukapura/cmd/lc_defaultcharstyle.png 
b/icon-themes/sukapura/cmd/lc_defaultcharstyle.png
index af57cae79a92..8dcca8c2178e 100644
Binary files a/icon-themes/sukapura/cmd/lc_defaultcharstyle.png and 
b/icon-themes/sukapura/cmd/lc_defaultcharstyle.png differ
diff --git a/icon-themes/sukapura/cmd/lc_grow.png 
b/icon-themes/sukapura/cmd/lc_grow.png
index 96716988b8c7..f26850dcd2cd 100644
Binary files a/icon-themes/sukapura/cmd/lc_grow.png and 
b/icon-themes/sukapura/cmd/lc_grow.png differ
diff --git a/icon-themes/sukapura/cmd/lc_shrink.png 
b/icon-themes/sukapura/cmd/lc_shrink.png
index 6d5b8ea7ce3d..1457cda3f521 100644
Binary files a/icon-themes/sukapura/cmd/lc_shrink.png and 
b/icon-themes/sukapura/cmd/lc_shrink.png differ
diff --git a/icon-themes/sukapura/cmd/lc_smallcaps.png 
b/icon-themes/sukapura/cmd/lc_smallcaps.png
index 77828a7749fa..125eddd50a01 100644
Binary files a/icon-themes/sukapura/cmd/lc_smallcaps.png and 
b/icon-themes/sukapura/cmd/lc_smallcaps.png differ
diff --git a/icon-themes/sukapura/cmd/lc_textbodyparastyle.png 
b/icon-themes/sukapura/cmd/lc_textbodyparastyle.png
index fba6822e3682..90daf2c49191 100644
Binary files a/icon-themes/sukapura/cmd/lc_textbodyparastyle.png and 
b/icon-themes/sukapura/cmd/lc_textbodyparastyle.png differ
diff --git a/icon-themes/sukapura/cmd/sc_grow.png 
b/icon-themes/sukapura/cmd/sc_grow.png
index c7c106dc52a6..9917192dbc44 100644
Binary files a/icon-themes/sukapura/cmd/sc_grow.png and 
b/icon-themes/sukapura/cmd/sc_grow.png differ
diff --git a/icon-themes/sukapura/cmd/sc_shrink.png 
b/icon-themes/sukapura/cmd/sc_shrink.png
index f1445ca9238b..4273b8880432 100644
Binary files a/icon-themes/sukapura/cmd/sc_shrink.png and 
b/icon-themes/sukapura/cmd/sc_shrink.png differ
diff --git a/icon-themes/sukapura/cmd/sc_smallcaps.png 
b/icon-themes/sukapura/cmd/sc_smallcaps.png
index 5ee5fa917921..1ef127831763 100644
Binary 

[Libreoffice-commits] core.git: sal/rtl

[Mike Kaganski (via logerrit)]

 sal/rtl/strtmpl.hxx |  145 
 1 file changed, 56 insertions(+), 89 deletions(-)

New commits:
commit 5b03e07dd21b56e99d6b6b60edec1ed2f388bfc2
Author: Mike Kaganski 
AuthorDate: Wed Mar 2 00:36:10 2022 +0300
Commit: Mike Kaganski 
CommitDate: Wed Mar 2 06:22:22 2022 +0100

Unify and deduplicate to[U]Int[_WithLength]

Change-Id: I05e71b36030da0a91c24b3926ee1d069912849f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130815
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/sal/rtl/strtmpl.hxx b/sal/rtl/strtmpl.hxx
index 78375ae07e26..a6b06ad0256e 100644
--- a/sal/rtl/strtmpl.hxx
+++ b/sal/rtl/strtmpl.hxx
@@ -761,58 +761,63 @@ template  sal_Bool toBoolean( 
const IMPL_RTL_STRCODE*
 }
 
 /* --- */
-template 
-T toInt_WithLength  ( const 
IMPL_RTL_STRCODE* pStr,
-  sal_Int16 
nRadix,
-  sal_Int32 
nStrLength )
+
+template  inline bool HandleSignChar(Iter& iter)
+{
+if constexpr (std::numeric_limits::is_signed)
+{
+if (*iter == '-')
+{
+++iter;
+return true;
+}
+}
+if (*iter == '+')
+++iter;
+return false;
+}
+
+template  std::pair DivMod(sal_Int16 nRadix, 
[[maybe_unused]] bool bNeg)
+{
+if constexpr (std::numeric_limits::is_signed)
+if (bNeg)
+return { -(std::numeric_limits::min() / nRadix),
+ -(std::numeric_limits::min() % nRadix) };
+return { std::numeric_limits::max() / nRadix, 
std::numeric_limits::max() % nRadix };
+}
+
+template  auto getIter(const SV& sv) { return sv.begin(); }
+template  auto getIter(const C* pStr) { return pStr; }
+
+template  auto good(typename SV::iterator iter, const SV& sv) { 
return iter != sv.end(); }
+template  auto good(const C* pStr, const C*) { return *pStr != 0; }
+
+template  T toInt(S str, sal_Int16 nRadix)
 {
-static_assert(std::numeric_limits::is_signed, "is signed");
 assert( nRadix >= RTL_STR_MIN_RADIX && nRadix <= RTL_STR_MAX_RADIX );
-assert( nStrLength >= 0 );
-boolbNeg;
-sal_Int16   nDigit;
-U   n = 0;
-const IMPL_RTL_STRCODE* pEnd = pStr + nStrLength;
 
 if ( (nRadix < RTL_STR_MIN_RADIX) || (nRadix > RTL_STR_MAX_RADIX) )
 nRadix = 10;
 
+auto pStr = getIter(str);
+
 /* Skip whitespaces */
-while ( pStr != pEnd && rtl_ImplIsWhitespace( IMPL_RTL_USTRCODE( *pStr ) ) 
)
+while (good(pStr, str) && rtl_ImplIsWhitespace(IMPL_RTL_USTRCODE(*pStr)))
 pStr++;
+if (!good(pStr, str))
+return 0;
 
-if ( *pStr == '-' )
-{
-bNeg = true;
-pStr++;
-}
-else
-{
-if ( *pStr == '+' )
-pStr++;
-bNeg = false;
-}
-
-T nDiv;
-sal_Int16 nMod;
-if ( bNeg )
-{
-nDiv = -(std::numeric_limits::min() / nRadix);
-nMod = -(std::numeric_limits::min() % nRadix);
-}
-else
-{
-nDiv = std::numeric_limits::max() / nRadix;
-nMod = std::numeric_limits::max() % nRadix;
-}
+const bool bNeg = HandleSignChar(pStr);
+const auto& [nDiv, nMod] = DivMod(nRadix, bNeg);
+assert(nDiv > 0);
 
-while ( pStr != pEnd )
+std::make_unsigned_t n = 0;
+while (good(pStr, str))
 {
-nDigit = rtl_ImplGetDigit( IMPL_RTL_USTRCODE( *pStr ), nRadix );
+sal_Int16 nDigit = rtl_ImplGetDigit(IMPL_RTL_USTRCODE(*pStr), nRadix);
 if ( nDigit < 0 )
 break;
-assert(nDiv > 0);
-if( static_cast( nMod < nDigit ? nDiv-1 : nDiv ) < n )
+if (static_cast>(nMod < nDigit ? nDiv - 1 : 
nDiv) < n)
 return 0;
 
 n *= nRadix;
@@ -821,11 +826,12 @@ T toInt_WithLength
  ( const IMPL_RTL
 pStr++;
 }
 
-if ( bNeg )
-return n == static_cast(std::numeric_limits::min())
-? std::numeric_limits::min() : -static_cast(n);
-else
-return static_cast(n);
+if constexpr (std::numeric_limits::is_signed)
+if (bNeg)
+return n == 
static_cast>(std::numeric_limits::min())
+   ? std::numeric_limits::min()
+   : -static_cast(n);
+return static_cast(n);
 }
 
 template 
@@ -833,7 +839,7 @@ sal_Int32 toInt32 ( const 
IMPL_RTL_STRCODE* pStr,
 sal_Int16 nRadix )
 {
 assert(pStr);
-return toInt_WithLength(pStr, nRadix, 
getLength(pStr));
+return toInt(pStr, nRadix);
 }
 
 template 
@@ -843,7 +849,7 @@ sal_Int32 toInt32_WithLength  ( const 
IMPL_RTL_STRCODE* pStr,
 
 {
 assert(pStr);
-return toInt_WithLength(pStr, nRadix, nStrLength);
+   

[Libreoffice-bugs] [Bug 103381] [META] Pivot table (aka Data Pilot) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103381
Bug 103381 depends on bug 118117, which changed state.

Bug 118117 Summary: Pivot table with column named "Data"
https://bugs.documentfoundation.org/show_bug.cgi?id=118117

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

[Justin Luth (via logerrit)]

 sc/source/core/data/dpcache.cxx |7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

New commits:
commit b7f654a406b704f469d1df424d83a3d98ae46432
Author: Justin Luth 
AuthorDate: Tue Mar 1 08:54:25 2022 +0200
Commit: Justin Luth 
CommitDate: Wed Mar 2 06:12:02 2022 +0100

tdf#118117 sc pivottable: STR_PIVOT_DATA is an existing name too

This fixes a LO 6.0 regression from
commit a078328e91ab9cbd78a92608c1abdc2c57ff9ac5

I looked for existing unit test examples using
assert (rLabel != ScResId(STR_PIVOT_DATA));
but found nothing.

I don't see the need for a unit test here.
The whole pivot table is messed up if you duplicate
a label, so why bother testing. It just is not
as bad now as it was before.

Change-Id: I59cc73becf91f766a29d2007c2d67685ffa2a65c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130751
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sc/source/core/data/dpcache.cxx b/sc/source/core/data/dpcache.cxx
index 0f3778eb40a6..52109c673bd3 100644
--- a/sc/source/core/data/dpcache.cxx
+++ b/sc/source/core/data/dpcache.cxx
@@ -356,9 +356,11 @@ void normalizeAddLabel(const OUString& rLabel, 
std::vector& rLabels, L
 
 std::vector normalizeLabels(const std::vector& 
rColData)
 {
-std::vector aLabels(1u, ScResId(STR_PIVOT_DATA));
+std::vector aLabels;
+aLabels.reserve(rColData.size() + 1);
 
 LabelSet aExistingNames;
+normalizeAddLabel(ScResId(STR_PIVOT_DATA), aLabels, aExistingNames);
 
 for (const InitColumnData& rCol : rColData)
 normalizeAddLabel(rCol.maLabel, aLabels, aExistingNames);
@@ -368,10 +370,11 @@ std::vector normalizeLabels(const 
std::vector& rColDat
 
 std::vector normalizeLabels(const ScDPCache::DBConnector& rDB, const 
sal_Int32 nLabelCount)
 {
-std::vector aLabels(1u, ScResId(STR_PIVOT_DATA));
+std::vector aLabels;
 aLabels.reserve(nLabelCount + 1);
 
 LabelSet aExistingNames;
+normalizeAddLabel(ScResId(STR_PIVOT_DATA), aLabels, aExistingNames);
 
 for (sal_Int32 nCol = 0; nCol < nLabelCount; ++nCol)
 {

[Libreoffice-bugs] [Bug 128747] FILEOPEN DOCX Chart has different legend entry text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128747

Justin L  changed:

   What|Removed |Added

 CC||jl...@mail.com
   Keywords|regression  |

--- Comment #7 from Justin L  ---
removing "regression" because before this half of the labels were missing, so
if one thing happened to be in the right place, it likely was simply
miraculous.
Plus, the code that was being replaced was horrendous and hacky beyond belief.

I think the problem is related to column C and D being empty. There is only the
string Reference for those columns.

The problematic column is the first in read-order in the file, followed by the
two empty ones. It is picking up the strRef of the last empty column.

I think the identified commit is a complete red herring. As far as I can see,
the entire chart passed to this file already only has 4 columns (instead of 6),
and the desired label string is not included in any of these four columns. So I
expect the code to be in a completely different place.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Gautham Krishan license statement

[Gautham Krishnan]

All of my past & future contributions to LibreOffice may be licensed
under the MPLv2/LGPLv3+ dual license.

[Libreoffice-bugs] [Bug 147463] Clicking on field link scrolls to page, but focuses only 1/3 of the page in question

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147463

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
I confirm the described behaviour, but why is it a bug as soon as it doesn't
follow MSO?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147474] Math equations are converted to images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147474

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
I can't confirm it with

Version: 7.3.1.2 (x64) / LibreOffice Community
Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

Please provide a clearer set of step-by-step instructions on how to reproduce
the problem.
I have set the bug's status to 'NEEDINFO'. Please change it back to
'UNCONFIRMED' once the steps are provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147465] Master Document does not Repeat header of table when source is linked as file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147465

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de

--- Comment #2 from Dieter  ---
Thank you for reporting the bug. It seems you're using an old version of
LibreOffice. Could you please try to reproduce it with the latest version of
LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I
have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED'
if the bug is still present in the latest version. Change to RESOLVED
WORKSFORME, if the problem went away.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147456] Libreoffice Writer default jpeg image compression different than online help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147456

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Dieter  ---
I confirm it with

Version: 7.3.1.2 (x64) / LibreOffice Community
Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

I don't know, if help is wrong or dialog
cc: Design-Team

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 147456] Libreoffice Writer default jpeg image compression different than online help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147456

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
   Keywords||needsUXEval

--- Comment #1 from Dieter  ---
I confirm it with

Version: 7.3.1.2 (x64) / LibreOffice Community
Build ID: 9fff0292474d6d0bf5df787b512c71d9ac4bc98e
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

I don't know, if help is wrong or dialog
cc: Design-Team

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147411] SfxSlotMode TOOLBOXCONFIG & ACCELCONFIG not working independently from each other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147411

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144318] open by remote_files tries login with invalid users I do not specify

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144318

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147452] Timestamps on digital signatures incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147452

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147450] Line end point moving not possible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147450

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147446] CALC Navigator Insert as Link Non-Functional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147446

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147441] Line spacing changes when applying highlighting at 180% zoom

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147441

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147436] Certain changes remain in track & changes record even after undo of every change

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147436

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147426] Media sidebars Position and time items not updating while playing media file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147426

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138738] graphic error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138738

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138738] graphic error

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=138738

--- Comment #3 from QA Administrators  ---
Dear Danielj80230!,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144263] On LibreOffice version 7.1.5.2 , the skip next page (ctrl + enter) doesn't work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144263

--- Comment #3 from QA Administrators  ---
Dear jpn4358,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143932] horizontal pitch resolution limit disrupts label spacing in Labels creator, formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143932

--- Comment #2 from QA Administrators  ---
Dear be!bob,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 99014] FORMATTING: Pasting text marked with comments is wrongly formatted (see comments 7 and 8)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99014

--- Comment #13 from QA Administrators  ---
Dear Luke Kendall,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   27 ++-
 1 file changed, 26 insertions(+), 1 deletion(-)

New commits:
commit e388a4d6d7ab355fc7aa5fca05e06070693847e9
Author: Caolán McNamara 
AuthorDate: Tue Mar 1 16:50:37 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 2 04:30:47 2022 +0100

Resolves: tdf#145580 need to use gtk_im_context_filter_keypress

for at least xim, ibus works fine. To reproduce under Fedora with gtk3
can use a keyboard layout of "US International with dead keys" with
export GDK_BACKEND=x11
export GTK_IM_MODULE=xim

and 'a in writer comment or calc header/footer dialog

Change-Id: I49425887dccc23c4fadf2bc007b6e83fc7993f7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130802
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index aa5b0685aa21..d106aaf92c78 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -3911,7 +3911,7 @@ public:
 }
 
 #if !GTK_CHECK_VERSION(4, 0, 0)
-bool signal_key(const GdkEventKey* pEvent)
+virtual bool do_signal_key(const GdkEventKey* pEvent)
 {
 if (pEvent->type == GDK_KEY_PRESS && m_aKeyPressHdl.IsSet())
 {
@@ -3925,6 +3925,11 @@ public:
 }
 return false;
 }
+
+bool signal_key(const GdkEventKey* pEvent)
+{
+return do_signal_key(pEvent);
+}
 #endif
 
 virtual void grab_add() override
@@ -16855,6 +16860,10 @@ public:
 return signal_im_context_delete_surrounding(rRange);
 }
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+virtual bool do_signal_key(const GdkEventKey* pEvent) override;
+#endif
+
 virtual void queue_draw() override
 {
 gtk_widget_queue_draw(GTK_WIDGET(m_pDrawingArea));
@@ -17206,8 +17215,24 @@ public:
 pThis->updateIMSpotLocation();
 pThis->EndExtTextInput();
 }
+
+#if !GTK_CHECK_VERSION(4, 0, 0)
+bool im_context_filter_keypress(const GdkEventKey* pEvent)
+{
+return gtk_im_context_filter_keypress(m_pIMContext, 
const_cast(pEvent));
+}
+#endif
 };
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+bool GtkInstanceDrawingArea::do_signal_key(const GdkEventKey* pEvent)
+{
+if (m_xIMHandler && m_xIMHandler->im_context_filter_keypress(pEvent))
+return true;
+return GtkInstanceWidget::do_signal_key(pEvent);
+}
+#endif
+
 void GtkInstanceDrawingArea::set_input_context(const InputContext& 
rInputContext)
 {
 bool bUseIm(rInputContext.GetOptions() & InputContextFlags::Text);

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   43 +--
 1 file changed, 41 insertions(+), 2 deletions(-)

New commits:
commit 8badc2314961e87e0b2cc01164442d97e20f9419
Author: Caolán McNamara 
AuthorDate: Tue Mar 1 16:50:37 2022 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Mar 2 04:30:00 2022 +0100

Resolves: tdf#145580 need to use gtk_im_context_filter_keypress

for at least xim, ibus works fine. To reproduce under Fedora with gtk3
can use a keyboard layout of "US International with dead keys" with
export GDK_BACKEND=x11
export GTK_IM_MODULE=xim

and 'a in writer comment or calc header/footer dialog

Change-Id: I49425887dccc23c4fadf2bc007b6e83fc7993f7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130775
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index fad6ad3846fa..31935aea6102 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -4017,7 +4017,8 @@ public:
 return false;
 }
 #else
-bool signal_key_press(const GdkEventKey* pEvent)
+
+virtual bool do_signal_key_press(const GdkEventKey* pEvent)
 {
 if (m_aKeyPressHdl.IsSet())
 {
@@ -4027,7 +4028,7 @@ public:
 return false;
 }
 
-bool signal_key_release(const GdkEventKey* pEvent)
+virtual bool do_signal_key_release(const GdkEventKey* pEvent)
 {
 if (m_aKeyReleaseHdl.IsSet())
 {
@@ -4036,6 +4037,16 @@ public:
 }
 return false;
 }
+
+bool signal_key_press(const GdkEventKey* pEvent)
+{
+return do_signal_key_press(pEvent);
+}
+
+bool signal_key_release(const GdkEventKey* pEvent)
+{
+return do_signal_key_release(pEvent);
+}
 #endif
 
 virtual void grab_add() override
@@ -17424,6 +17435,11 @@ public:
 return signal_im_context_delete_surrounding(rRange);
 }
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+virtual bool do_signal_key_press(const GdkEventKey* pEvent) override;
+virtual bool do_signal_key_release(const GdkEventKey* pEvent) override;
+#endif
+
 virtual void queue_draw() override
 {
 gtk_widget_queue_draw(GTK_WIDGET(m_pDrawingArea));
@@ -17805,8 +17821,31 @@ public:
 pThis->updateIMSpotLocation();
 pThis->EndExtTextInput();
 }
+
+#if !GTK_CHECK_VERSION(4, 0, 0)
+bool im_context_filter_keypress(const GdkEventKey* pEvent)
+{
+return gtk_im_context_filter_keypress(m_pIMContext, 
const_cast(pEvent));
+}
+#endif
 };
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+bool GtkInstanceDrawingArea::do_signal_key_press(const GdkEventKey* pEvent)
+{
+if (m_xIMHandler && m_xIMHandler->im_context_filter_keypress(pEvent))
+return true;
+return GtkInstanceWidget::do_signal_key_press(pEvent);
+}
+
+bool GtkInstanceDrawingArea::do_signal_key_release(const GdkEventKey* pEvent)
+{
+if (m_xIMHandler && m_xIMHandler->im_context_filter_keypress(pEvent))
+return true;
+return GtkInstanceWidget::do_signal_key_release(pEvent);
+}
+#endif
+
 void GtkInstanceDrawingArea::set_input_context(const InputContext& 
rInputContext)
 {
 bool bUseIm(rInputContext.GetOptions() & InputContextFlags::Text);

[Libreoffice-bugs] [Bug 147715] image infomation for WebP can't be acquired.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147715

--- Comment #4 from 20001...@protonmail.com <20001...@protonmail.com> ---
(In reply to Luboš Luňák from comment #3)
> That is actually correct. As long as WebP is not kept for saving to
> documents, the image is not WebP after import. The same happens e.g. with
> XPM images.

I understood.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sax/source

[Hossein (via logerrit)]

 sax/source/fastparser/fastparser.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d1cfe4228316322d0ae9f3b8020036e5140fc32b
Author: Hossein 
AuthorDate: Tue Mar 1 14:33:33 2022 +0100
Commit: Hossein 
CommitDate: Wed Mar 2 02:11:23 2022 +0100

Remove 'const' from for loop variable

In the commit f63a6f2e396fa41ed1338dcec874e06159cafa9f, a for loop is
converted into a range-based for loop. The pointer is used to change
the nodes using xmlUnlinkNode() and xmlFreeNode(), thus the 'const'
should have not been used.

The reinterpret_cast does not change the constness, thus I have
removed the const from the loop variable, and it will no longer be a
const reference.

Change-Id: If4c61017ea77f464230bb5802f6fc928acc7a7e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130792
Tested-by: Jenkins
Reviewed-by: Hossein 

diff --git a/sax/source/fastparser/fastparser.cxx 
b/sax/source/fastparser/fastparser.cxx
index beb30443ba02..71b316378e01 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -674,7 +674,7 @@ FastSaxParserImpl::~FastSaxParserImpl()
 {
 if( mxDocumentLocator.is() )
 mxDocumentLocator->dispose();
-for (const auto& entity : m_TemporalEntities)
+for (auto& entity : m_TemporalEntities)
 {
 if (!entity)
 continue;

[Libreoffice-bugs] [Bug 139466] Impress saves keywords twice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=139466

Scott Clewell  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Scott Clewell  ---
No longer duplicates keywords on this version.

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: cb56edb177f4db5b9cc4d140543c4b11d41ef1b0
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147705] CRASH when pressing compose key

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147705

--- Comment #2 from Hamish  ---
Created attachment 178608
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178608=edit
Backtrace

Is this any good? I can do another if it hasn't worked properly

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147720] New: Bullet points are very confusing to use and bug filled.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147720

Bug ID: 147720
   Summary: Bullet points are very confusing to use and bug
filled.
   Product: LibreOffice
   Version: 7.3.0.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 073.jose...@gmail.com

Description:
Whenever you create a bullet point list it is hard to use due to it being very
buggy. When you press enter to create another bullet point and paste copied
text it creates a very large bullet point, sometimes in a different color than
intended. It will also split selected text into different bullet points
seemingly at random.

Steps to Reproduce:
1. Create a bullet point list using Shift+F12
2. Copy any text from a website
3. Paste into the bullet point list
4. Should replicate the bug

Actual Results:
It did as I thought it would and made a weird looking mess.

Expected Results:
Had it perfectly pasted into the bullet list without error or difficulty.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: StartModule
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147719] Calc freezes when resizing Properties pane

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147719

--- Comment #1 from grolsc...@gmail.com ---
I meant Properties pane, not tab.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147719] Calc freezes when resizing Properties pane

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147719

grolsc...@gmail.com changed:

   What|Removed |Added

Summary|Calc freezes when resizing  |Calc freezes when resizing
   |Properties tab  |Properties pane

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147719] New: Calc freezes when resizing Properties tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147719

Bug ID: 147719
   Summary: Calc freezes when resizing Properties tab
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: grolsc...@gmail.com

Description:
Clicking on the left side of the Properties tab to expand it, results in the
application freezing. 

Steps to Reproduce:
1. Open Calc
2. Click and drag the edge of the Properties tab on the right of the window.
3. Freezes

Actual Results:
Application freezes. Properties tab wiggles left and right constantly by a few
pixels. Horizontal scrollbar at the bottom of the Properties tab flashes
constantly.

Expected Results:
I expect the resize the Properties tab so that I can see and use the contents.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Screen is QHD+ 3200x1800 resolution but only 13" in size.
PC is a Dell XPS 13 9360 (i7, 8GB RAM, 256GB SSD).
Running Windows 11.

Fresh install of LibreOffice after newly purchasing from the Microsoft Store.
It's the first thing I tried to do and it freeze.

I have previously used older LibreOffice downloadable versions with no
problems. It's just this version from the Microsoft Store.

I have also tried deleting my entire LibreOffice Profile.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 68326] FILEOPEN: Bad table in docx generated from bank (excessive use of tables)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=68326

Regina Henschel  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7713

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147713] Certain text in docx file will not show when opened in LOO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147713

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=68
   ||326
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Regina Henschel  ---
The document has a lot of tables inside table-cell. These are not imported.

It seems, that some size settings are not imported.

The import becomes better, if I explicitly set column backgrounds in Word.

Tested with Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ea25606de5f1a60430a74107b0e2e0986ac1bb15
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: default; VCL: win
Locale: de-DE (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147718

--- Comment #4 from Malome Khomo  ---
Created attachment 178607
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178607=edit
The 7.2.5.2 LibreOffice Build on AMD64 CentOS 8

It is not clear if this is merely a missing UI flag that used to be turned off
via UI options flag or whether it is a missing Configuration  Option piece
specific to the Linux CentOS 8 Build.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147718

--- Comment #3 from Malome Khomo  ---
Created attachment 178606
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178606=edit
No Tools>Options>LibreOffice Writer>Compatibility Flag to turn off

Earlier version apparently could turn of write-protection via an option flag
that is not available in LibreOffice 7.x

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147718

--- Comment #2 from Malome Khomo  ---
Created attachment 178605
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178605=edit
The blocked edit when trying to edit the attached XML Form document

Then blocked edit warning

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147718] LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147718

Malome Khomo  changed:

   What|Removed |Added

 CC||mkh...@gmail.com

--- Comment #1 from Malome Khomo  ---
Created attachment 178604
  --> https://bugs.documentfoundation.org/attachment.cgi?id=178604=edit
A copy of the now Read-only Write-protected XML Form document as described

The file attached raises the Read-only Write-protect block when trying to -for
example - delete the text control widget created as I describe in this report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147718] New: LO(7.2) XML Form Document cannot unlock Read-only / Write-protected via any visible UI option

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147718

Bug ID: 147718
   Summary: LO(7.2) XML Form Document cannot unlock Read-only /
Write-protected via any visible UI option
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mkh...@gmail.com

Description:
After Editing NEW XML Form Document then closing it Writer (LO7.2) does not
allow deleting a control for example on reopening the document. Workarounds in
earlier versions speak of a Tools>Options>LibreOffice Writer>Compatibility flag
to switch off but my LO7.2 does not have Tools>Options>LibreOffice Writer.

Steps to Reproduce:
1. Open New XML Form Document
2. Use Design Mode to add a widget such as Text Control
3. Add a small instanceData XML nodeset fragment to the default Model
4. Tap on a leaf node of that nodeset to create a Binding
5. Edit the TextControl in design mode and add the Binding to its Data property
6. Save the document and exit from Libre Office.
7. Reopen the Document, highlight the TextControl in Design Mode and press
keyboard [Delete], and the Read-Only Write-protected edit block comes up

Actual Results:
1.This happened with LO 7.2.4.1
2.I upgraded to LO 7.2.5.2 but the behavior remains the same

Expected Results:
I expect to edit the document further but it will not allow that.


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: XMLFormDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128798] Crash with chart inserting from Writer's table with merged cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128798

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
Still repro

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-21.06.19-1'

[Andras Timar (via logerrit)]

Tag 'cp-21.06.19-1' created by Andras Timar  at 
2022-03-01 21:40 +

cp-21.06.19-1

Changes since cp-21.06.18-1-2:
---
 0 files changed
---

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-21.06.19-1'

[Andras Timar (via logerrit)]

Tag 'cp-21.06.19-1' created by Andras Timar  at 
2022-03-01 21:40 +

cp-21.06.19-1

Changes since cp-21.06.13-1-1:
---
 0 files changed
---

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-21.06.19-1'

[Adolfo Jayme Barrientos (via logerrit)]

Tag 'cp-21.06.19-1' created by Andras Timar  at 
2022-03-01 21:40 +

cp-21.06.19-1

Changes since co-2021-branch-point-10:
---
 0 files changed
---

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-21.06.19-1'

[Andras Timar (via logerrit)]

Tag 'cp-21.06.19-1' created by Andras Timar  at 
2022-03-01 21:40 +

cp-21.06.19-1

Changes since libreoffice-7-1-branch-point-5:
---
 0 files changed
---

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - configure.ac

[Andras Timar (via logerrit)]

Rebased ref, commits from common ancestor:
commit a7dfb7c4476bec2095e404d1fc43e0d46e3b2361
Author: Andras Timar 
AuthorDate: Tue Mar 1 22:38:02 2022 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 1 22:39:00 2022 +0100

Bump version to 21.06.19.1

Change-Id: I505d783ee087d113a53bafce257f16bdfd87ae7a

diff --git a/configure.ac b/configure.ac
index 2991ef0b09bf..18dce3937ed0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[21.06.18.1],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[21.06.19.1],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-2021' - configure.ac

[Andras Timar (via logerrit)]

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 931511d7843f989da744432485bc84efe47cbc70
Author: Andras Timar 
AuthorDate: Tue Mar 1 22:38:02 2022 +0100
Commit: Andras Timar 
CommitDate: Tue Mar 1 22:38:02 2022 +0100

Bump version to 21.16.19.1

Change-Id: I505d783ee087d113a53bafce257f16bdfd87ae7a

diff --git a/configure.ac b/configure.ac
index 2991ef0b09bf..18dce3937ed0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
 # several non-alphanumeric characters, those are split off and used only for 
the
 # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no 
idea.
 
-AC_INIT([Collabora Office],[21.06.18.1],[],[],[https://collaboraoffice.com/])
+AC_INIT([Collabora Office],[21.06.19.1],[],[],[https://collaboraoffice.com/])
 
 dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just 
fine if it is installed
 dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails 
hard

[Libreoffice-bugs] [Bug 115463] EDITING: Image changes after add a caption to a rotated image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115463

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||3723

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||143723


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143723
[Bug 143723] Writer: Changing anchor of rotated image crops image unexpectedly.
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143723] Writer: Changing anchor of rotated image crops image unexpectedly.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143723

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 CC||kelem...@ubuntu.com
 Blocks||103152
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=11
   ||5463

--- Comment #3 from Gabor Kelemen (allotropia)  ---
Same commit as bug 115463.
But I'm leaving as not duplicate, that commit was huge.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 83307] FILEOPEN: XLS - Charts with data embedded in object imported with blank chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83307

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #13 from Roman Kuznetsov <79045_79...@mail.ru> ---
Still repro in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 64914] FILEOPEN: Libreoffice freezes importing a file containing a chart with large data source

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64914

--- Comment #15 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Roman Kuznetsov from comment #11)
> 32 sec (Intel Core2Quad 9450) in
> 
> Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 1be170d0629cf761f0ee4173007a3c021966546e
> CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
> Skia/Raster; VCL: win
> Locale: ru-RU (ru_RU); UI: en-US
> Calc: CL

Today it took only 18 sec on the same hardware in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

MS Excel 2007 opens it for 5 sec, btw

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142468] LibreOffice randomly hangs on macOS Big Sur 2020 MacBook Air M1

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142468

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7709

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144060] Writer process hangs frequently on macOS 11.4 on MacBook Air M1 -- Apple Silicon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144060

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||7709

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147709] Libreoffice freezes on Macbook Air M1, must be restarted with force close

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147709

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4060,
   ||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2468

--- Comment #7 from Julien Nabet  ---
Let's put some other bugtrackers about hanging on M1 for info.
Reading them, I just remember there are now 2 versions for LO on Mac: Intel
version and Apple Silicon one (which uses Rosetta and not native support yet).
With notarization/rights pb + Java pbs too, what a mess for LO on MacOs...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115463] EDITING: Image changes after add a caption to a rotated image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115463

--- Comment #11 from Gabor Kelemen (allotropia)  ---
FTR: clickable link
https://git.libreoffice.org/core/+/a42b0985c7619efdc934bb1cf19e5e2c2b6faea2%5E%21/#F11

Example file is attachment 145542 from the duplicate, rotate 90 degrees
left/right is bad since above commit without even adding a caption.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 31092] Creating 3D smooth lines chart takes several seconds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=31092

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
Summary|Creating  3D smooth lines   |Creating 3D smooth lines
   |chart takes several minutes |chart takes several seconds

--- Comment #19 from Roman Kuznetsov <79045_79...@mail.ru> ---
Around 10 sec in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-2-6' - sc/inc sc/source

[Caolán McNamara (via logerrit)]

 sc/inc/documentimport.hxx|2 ++
 sc/source/core/data/documentimport.cxx   |   14 ++
 sc/source/filter/oox/sheetdatabuffer.cxx |   16 ++--
 3 files changed, 30 insertions(+), 2 deletions(-)

New commits:
commit 0f62288b989f78e3e757aa7f3811c9fad03c1c0d
Author: Caolán McNamara 
AuthorDate: Wed Feb 16 11:14:48 2022 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 1 22:25:32 2022 +0100

clear ScDocumentImport position cache if iterators are invalid

SheetDataBuffer::finalizeArrayFormula calls

ScCellRangeObj::setArrayTokens
ScDocFunc::EnterMatrix
ScDocument::InsertMatrixFormula

and InsertMatrixFormula calls the variant of ScColumn::SetFormulaCell
which doesn't take a sc::ColumnBlockPosition& param when SetFormulaCell
adds a cell to the column so any iterators belonging to ScDocumentImport
are invalid.

Change-Id: Ic2814ecbeafdeb99632d2a255ed6c1dedf7376b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130151
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
(cherry picked from commit fea55f5ef8dba16706033c9efdd33c45477eb333)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130309
Reviewed-by: Michael Stahl 
Reviewed-by: Eike Rathke 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/documentimport.hxx b/sc/inc/documentimport.hxx
index cefe2949dcc7..0e49e073fd62 100644
--- a/sc/inc/documentimport.hxx
+++ b/sc/inc/documentimport.hxx
@@ -125,6 +125,8 @@ public:
 
 void setMergedCells(SCTAB nTab, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2);
 
+void invalidateBlockPositionSet(SCTAB nTab);
+
 void finalize();
 
 /** Broadcast all formula cells that are marked with
diff --git a/sc/source/core/data/documentimport.cxx 
b/sc/source/core/data/documentimport.cxx
index 2dbc61c03938..d2350c1cdb6b 100644
--- a/sc/source/core/data/documentimport.cxx
+++ b/sc/source/core/data/documentimport.cxx
@@ -96,6 +96,15 @@ struct ScDocumentImportImpl
 return rTab.getBlockPosition(nCol);
 }
 
+void invalidateBlockPositionSet(SCTAB nTab)
+{
+if (o3tl::make_unsigned(nTab) >= maBlockPosSet.size())
+return;
+
+sc::TableColumnBlockPositionSet& rTab = maBlockPosSet[nTab];
+rTab.invalidate();
+}
+
 void initForSheets()
 {
 size_t n = mrDoc.GetTableCount();
@@ -183,6 +192,11 @@ void ScDocumentImport::setOriginDate(sal_uInt16 nYear, 
sal_uInt16 nMonth, sal_uI
 mpImpl->mrDoc.pDocOptions->SetDate(nDay, nMonth, nYear);
 }
 
+void ScDocumentImport::invalidateBlockPositionSet(SCTAB nTab)
+{
+mpImpl->invalidateBlockPositionSet(nTab);
+}
+
 void ScDocumentImport::setAutoInput(const ScAddress& rPos, const OUString& 
rStr, const ScSetStringParam* pStringParam)
 {
 ScTable* pTab = mpImpl->mrDoc.FetchTable(rPos.Tab());
diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx 
b/sc/source/filter/oox/sheetdatabuffer.cxx
index e497ee44f8d8..29de63bdb9f4 100644
--- a/sc/source/filter/oox/sheetdatabuffer.cxx
+++ b/sc/source/filter/oox/sheetdatabuffer.cxx
@@ -443,9 +443,22 @@ void SheetDataBuffer::addColXfStyleProcessRowRanges()
 
 void SheetDataBuffer::finalizeImport()
 {
+ScDocumentImport& rDocImport = getDocImport();
+
+SCTAB nStartTabInvalidatedIters(SCTAB_MAX);
+SCTAB nEndTabInvalidatedIters(0);
+
 // create all array formulas
 for( const auto& [rRange, rTokens] : maArrayFormulas )
-finalizeArrayFormula( rRange, rTokens );
+{
+finalizeArrayFormula(rRange, rTokens);
+
+nStartTabInvalidatedIters = std::min(rRange.aStart.Tab(), 
nStartTabInvalidatedIters);
+nEndTabInvalidatedIters = std::max(rRange.aEnd.Tab(), 
nEndTabInvalidatedIters);
+}
+
+for (SCTAB nTab = nStartTabInvalidatedIters; nTab <= 
nEndTabInvalidatedIters; ++nTab)
+rDocImport.invalidateBlockPositionSet(nTab);
 
 // create all table operations
 for( const auto& [rRange, rModel] : maTableOperations )
@@ -458,7 +471,6 @@ void SheetDataBuffer::finalizeImport()
 
 addColXfStyleProcessRowRanges();
 
-ScDocumentImport& rDocImport = getDocImport();
 ScDocument& rDoc = rDocImport.getDoc();
 StylesBuffer& rStyles = getStyles();
 for ( const auto& [rCol, rRowStyles] : maStylesPerColumn )

[Libreoffice-bugs] [Bug 145378] [META] Issues related to weld annotation window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145378
Bug 145378 depends on bug 145580, which changed state.

Bug 145580 Summary: Comment balloon doesn't allow Latin characters
https://bugs.documentfoundation.org/show_bug.cgi?id=145580

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/unx/gtk3/gtkinst.cxx |   43 +--
 1 file changed, 41 insertions(+), 2 deletions(-)

New commits:
commit dc99d27f04b47c173de934a19b6d6a3cc572c20a
Author: Caolán McNamara 
AuthorDate: Tue Mar 1 16:50:37 2022 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 1 22:20:38 2022 +0100

Resolves: tdf#145580 need to use gtk_im_context_filter_keypress

for at least xim, ibus works fine. To reproduce under Fedora with gtk3
can use a keyboard layout of "US International with dead keys" with
export GDK_BACKEND=x11
export GTK_IM_MODULE=xim

and 'a in writer comment or calc header/footer dialog

Change-Id: I49425887dccc23c4fadf2bc007b6e83fc7993f7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130801
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 125c58808bf3..b0566791d4f1 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -3996,7 +3996,8 @@ public:
 return false;
 }
 #else
-bool signal_key_press(const GdkEventKey* pEvent)
+
+virtual bool do_signal_key_press(const GdkEventKey* pEvent)
 {
 if (m_aKeyPressHdl.IsSet())
 {
@@ -4006,7 +4007,7 @@ public:
 return false;
 }
 
-bool signal_key_release(const GdkEventKey* pEvent)
+virtual bool do_signal_key_release(const GdkEventKey* pEvent)
 {
 if (m_aKeyReleaseHdl.IsSet())
 {
@@ -4015,6 +4016,16 @@ public:
 }
 return false;
 }
+
+bool signal_key_press(const GdkEventKey* pEvent)
+{
+return do_signal_key_press(pEvent);
+}
+
+bool signal_key_release(const GdkEventKey* pEvent)
+{
+return do_signal_key_release(pEvent);
+}
 #endif
 
 virtual void grab_add() override
@@ -17551,6 +17562,11 @@ public:
 return signal_im_context_delete_surrounding(rRange);
 }
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+virtual bool do_signal_key_press(const GdkEventKey* pEvent) override;
+virtual bool do_signal_key_release(const GdkEventKey* pEvent) override;
+#endif
+
 virtual void queue_draw() override
 {
 gtk_widget_queue_draw(GTK_WIDGET(m_pDrawingArea));
@@ -17932,8 +17948,31 @@ public:
 pThis->updateIMSpotLocation();
 pThis->EndExtTextInput();
 }
+
+#if !GTK_CHECK_VERSION(4, 0, 0)
+bool im_context_filter_keypress(const GdkEventKey* pEvent)
+{
+return gtk_im_context_filter_keypress(m_pIMContext, 
const_cast(pEvent));
+}
+#endif
 };
 
+#if !GTK_CHECK_VERSION(4, 0, 0)
+bool GtkInstanceDrawingArea::do_signal_key_press(const GdkEventKey* pEvent)
+{
+if (m_xIMHandler && m_xIMHandler->im_context_filter_keypress(pEvent))
+return true;
+return GtkInstanceWidget::do_signal_key_press(pEvent);
+}
+
+bool GtkInstanceDrawingArea::do_signal_key_release(const GdkEventKey* pEvent)
+{
+if (m_xIMHandler && m_xIMHandler->im_context_filter_keypress(pEvent))
+return true;
+return GtkInstanceWidget::do_signal_key_release(pEvent);
+}
+#endif
+
 void GtkInstanceDrawingArea::set_input_context(const InputContext& 
rInputContext)
 {
 bool bUseIm(rInputContext.GetOptions() & InputContextFlags::Text);

[Libreoffice-bugs] [Bug 124943] Copy to edit bar adds a suffix space, that is inconsistent with paste to cell.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124943

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 CC||79045_79...@mail.ru

--- Comment #5 from Roman Kuznetsov <79045_79...@mail.ru> ---
No repro in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

Closed as WFM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||124006


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=124006
[Bug 124006] EDITING: copy & paste from AOO to LO fails for formula's
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 124006] EDITING: copy & paste from AOO to LO fails for formula's

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=124006

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||102593


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123085] tag not pasted / not recognized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123085

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

   Keywords||filter:html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 123085] tag not pasted / not recognized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=123085

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||111951


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=111951
[Bug 111951] [META] HTML import bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 111951] [META] HTML import bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=111951

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||123085


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=123085
[Bug 123085]  tag not pasted / not recognized
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115463] EDITING: Image changes after add a caption to a rotated image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115463

--- Comment #10 from Gabor Kelemen (allotropia)  ---
Still an issue in current master

Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: c97a3592c78ce276a353f95ce68c70a8a39174a0
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107209] Text layout error; text lines overlap randomly in long "complicated" documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107209

--- Comment #16 from y3kcjd5  ---
Persistent as of version 7.3.0.3. The "wrinkles" were found in the first
example document on page 1 this time.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122910] Cut+undo of formulas loses absolute and performs a relative paste

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122910

--- Comment #3 from Roman Kuznetsov <79045_79...@mail.ru> ---
Still repro in

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105948

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||122910


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122910
[Bug 122910] Cut+undo of formulas loses absolute and performs a relative paste
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102593] [META] Paste bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102593

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||122910


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=122910
[Bug 122910] Cut+undo of formulas loses absolute and performs a relative paste
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122910] Cut+undo of formulas loses absolute and performs a relative paste

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122910

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Blocks||102593, 105948


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102593
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948
[Bug 105948] [META] Undo/Redo bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147716] Error dialog instead of WebDAV authentication - WebDAV completely broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147716

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Just for your information, from LO 7.3 LO uses Curl for WebDav instead of Neon
or Serf lib. (see
https://blog.allotropia.de/2022/02/07/improving-libreoffices-network-file-access/).

So even if there's indeed some bugs in 7.2.5, I'd be astonished it could be
fixed in 7.2.6 or even 7.2.7 (see
https://wiki.documentfoundation.org/ReleasePlan/7.2) but I may be wrong.

Would it be possible you give a try with LO 7.3.0 ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147709] Libreoffice freezes on Macbook Air M1, must be restarted with force close

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147709

--- Comment #6 from adrie...@freudianslit.com ---
So, I've basically reverted to using OnlyOffice to avoid LO crashing, and I can
work on these files there without any problem. I also use this device for video
editing in Da Vinci Resolve and music production and have no problems with
other applications, so I don't think its the device.

When I can I'll try working on files on the internal SSD, but from memory this
freezing has occurred with new documents, even before I saved them anywhere.
I'll update you with my observations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 37923] Improve Calc precision when subtracting large integers to parity with Excel

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=37923

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Resolution|--- |WORKSFORME
 Status|REOPENED|RESOLVED

--- Comment #20 from Roman Kuznetsov <79045_79...@mail.ru> ---
in 

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2c6f5ebfe69c3031af7b4903637226bd8a3dde62
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL Jumbo

I see -1 result as it should be in the file

Closed as WFM now

b. try retest *this problem* yourself and if you still have some your own
calculation problems please file *the different* report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/avmedia

[Caolán McNamara (via logerrit)]

 include/avmedia/mediawindow.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 684e0b742aa611e684cfdf1f7ddff711bf6ab513
Author: Caolán McNamara 
AuthorDate: Tue Mar 1 15:47:19 2022 +
Commit: Caolán McNamara 
CommitDate: Tue Mar 1 21:57:32 2022 +0100

xPreferredPixelSizeListener is never null

Change-Id: Ide71bad809c192446e157662787ef2f4437ef66f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130800
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/include/avmedia/mediawindow.hxx b/include/avmedia/mediawindow.hxx
index 4954e04558bb..e81630002fd0 100644
--- a/include/avmedia/mediawindow.hxx
+++ b/include/avmedia/mediawindow.hxx
@@ -137,7 +137,7 @@ namespace avmedia
 static css::uno::Reference grabFrame(const 
css::uno::Reference& rPlayer);
 
 static css::uno::Reference< css::graphic::XGraphic > grabFrame(const 
OUString& rURL, const OUString& rReferer,
-const OUString& sMimeType, rtl::Reference 
xPreferredPixelSizeListener = nullptr);
+const OUString& sMimeType, rtl::Reference 
xPreferredPixelSizeListener);
 
 static void dispatchInsertAVMedia(const 
css::uno::Reference&,
   const css::awt::Size& rSize, const 
OUString& rURL, bool bLink);

[Libreoffice-bugs] [Bug 147668] Writer crashes shortly after loading document with LanguageTool extension active

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147668

--- Comment #6 from Stephan Bergmann  ---
(In reply to Julien Nabet from comment #5)
> Here's a part which may help from Gerry:
> Thread 67 "Thread-24" received signal SIGBUS, Bus error.

This is from private communication between Julien and Gerry?  SIGBUS is
somewhat odd.  I assume this is on x86-64 hardware?  (And a backtrace with
apparently lacking debug information is of reduced usefulness and might even be
misleading.)

> BTW, I noticed other things on console logs:
> - when opening Writer:
> warn:configmgr:25772:25772:configmgr/source/xcuparser.cxx:159: bad set node
>  member in
> "file:///home/julien/lo/libreoffice/instdir/program/../program/../user/
> uno_packages/cache/uno_packages/lu25eow.tmp_/LanguageTool-5.6.oxt/Addons.xcu"

Definitely harmless and unrelated, see
 "Remove spurious
'Title' prop".

> but above all a kind of crash at the end with:
> warn:sal.osl.mutex:25918:26030:sal/osl/unx/mutex.cxx:149:
> pthread_mutex_unlock failed: EINVAL
> warn:sal.osl.mutex:25918:26030:sal/osl/unx/mutex.cxx:103: pthread_mutex_lock
> failed: EINVAL
> warn:sal.osl.mutex:25918:26030:sal/osl/unx/mutex.cxx:149:
> pthread_mutex_unlock failed: EINVAL
> #
> # A fatal error has been detected by the Java Runtime Environment:
> #
> #  SIGSEGV (0xb) at pc=0x7f8f4776e8e4, pid=25918, tid=25918
> #
> # JRE version: OpenJDK Runtime Environment (11.0.14+9) (build
> 11.0.14+9-post-Debian-1)
> # Java VM: OpenJDK 64-Bit Server VM (11.0.14+9-post-Debian-1, mixed mode,
> sharing, tiered, compressed oops, g1 gc, linux-amd64)
> # Problematic frame:
> # C  [libc.so.6+0x828e4]

It smells like LanguageTool causes some threads to still run during process
exit.  That's definitely something that should be addressed, but it's unclear
whether that might be related to Garry's original issue.  (What I e.g. see when
typing some words in Writer, then trying to quit LO without saving the document
is

> Thread 77 "Thread-102" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fff0effe640 (LWP 3960536)]
> 0x71b9c115 in std::__1::unique_ptr std::__1::default_delete >::get (this=0x10) at 
> ~llvm/inst/include/c++/v1/__memory/unique_ptr.h:287
> 287   return __ptr_.first();
> 
> Thread 77 (Thread 0x7fff0effe640 (LWP 3960536) "Thread-102"):
> ##0  0x71b9c115 in std::__1::unique_ptr std::__1::default_delete >::get() const (this=0x10) 
> at ~llvm/inst/include/c++/v1/__memory/unique_ptr.h:287
> #1  0x71b5c819 in SalInstance::GetYieldMutex() (this=0x0) at 
> vcl/source/app/salvtables.cxx:120
> #2  0x7fffdc4b2d95 in GdkThreadsLeave() () at vcl/unx/gtk3/gtkinst.cxx:115
> #3  0x7fffb48d65c2 in 
> Java_com_sun_java_swing_plaf_gtk_GTKStyle_nativeGetXThicknessDownloading 0.00 
> MB source file 
> /usr/src/debug/java-latest-openjdk-17.0.2.0.8-2.rolling.fc35.x86_64/openjdk/src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKStyle.c
>  (env=, klass=, widget_type=18) at 
> /usr/src/debug/java-latest-openjdk-17.0.2.0.8-2.rolling.fc35.x86_64/openjdk/src/java.desktop/unix/native/libawt_xawt/awt/swing_GTKStyle.c:49
> #4  0x7fffa08fec48 in  ()
> #5  0x000800448d58 in  ()
> #6  0x7fff0effb528 in  ()
> #7  0x in  ()

[...]

> Thread 1 (Thread 0x7fffe9cf9080 (LWP 3960429) "soffice.bin"):
> #0  0x77fc9d88 in _dl_close_workerDownloading -0.00 MB source file 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/elf/dl-close.c...
>  (map=map@entry=0x1675640, force=force@entry=false) at 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/elf/dl-close.c:825
> #1  0x77fca33b in _dl_close (_map=0x1675640) at 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/elf/dl-close.c:873
> #2  0x77976878 in __GI__dl_catch_exceptionDownloading 0.00 MB source 
> file /usr/src/debug/glibc-2.34-25.fc35.x86_64/elf/dl-error-skeleton.c...
>  (exception=exception@entry=0x7fffda80, operate=, 
> args=) at 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/elf/dl-error-skeleton.c:208
> #3  0x77976943 in __GI__dl_catch_error (objname=0x7fffdad8, 
> errstring=0x7fffdae0, mallocedp=0x7fffdad7, operate=, 
> args=) at 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/elf/dl-error-skeleton.c:227
> #4  0x778a682e in _dlerror_runDownloading 0.00 MB source file 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/dlfcn/dlerror.c...
>  (operate=, args=) at 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/dlfcn/dlerror.c:138
> #5  0x778a6558 in __dlcloseDownloading 0.00 MB source file 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/dlfcn/dlclose.c...
>  (handle=) at 
> /usr/src/debug/glibc-2.34-25.fc35.x86_64/dlfcn/dlclose.c:31
> #6  0x77f820d9 in osl_unloadModule(oslModule) (hModule=0x1675640) at 
> sal/osl/unx/module.cxx:217
> #7  0x77f56588 in osl::Module::~Module() (this=0x77fbe7e8 
> ) at 
> include/osl/module.hxx:78
> #8  0x77f56495 in (anonymous 
> 

[Libreoffice-bugs] [Bug 147709] Libreoffice freezes on Macbook Air M1, must be restarted with force close

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=147709

--- Comment #5 from Julien Nabet  ---
(In reply to adrienne from comment #4)
> Hi Julien
> 
> - are all files used local files or some are on a network, usb, ... ?
> 
> Most files are kept on an external SSD connected via usb-c
>...
I don't know very much MacOs, for example if there are regular (at least once
per week) updates of the system anyway, could you check you got all the
updates?

Then I don't know if LO freezes happen after 30 min, 1 hour, 2 hours or more
but I think it could be interesting for the test to:
- copy the files you need to work with on local drive
- work on these files for some time
and see if it freezes too.

If it still freezes, at least we'll know it's not related to usb or the
external ssd itself
If it doesn't freeze and supposing it happens only with LO, it could be
interesting to test on another usb external device to know if it's the device.
Also, it could be usb related in this case so whatever the external device.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 63320] EDITING: Snap to grid does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63320

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 CC||79045_79...@mail.ru
 Resolution|--- |WORKSFORME

--- Comment #18 from Roman Kuznetsov <79045_79...@mail.ru> ---
Closed by Comment 17

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131155] Sorting - Move 'Range contains column labels' from 'Options' tab to 'Sort Criteria' tab

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=131155

--- Comment #10 from Allison King  ---
for the life of me, I don't understand why the "range contains column labels"
option isn't on the sort criteria tab. Virtually every other spreadsheet does
it. Would really love to see this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.