[Libreoffice-bugs] [Bug 148315] New: 7.3.2.2 has many untranslated items (Russian language)

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148315

Bug ID: 148315
   Summary: 7.3.2.2 has many untranslated items (Russian language)
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Localization
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kaktebyaviru...@gmail.com

Created attachment 179265
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179265=edit
Screenshots with found untranslated items (underlined with red)

Version: 7.3.2.2 (x86) / LibreOffice Community
Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

Version 7.3.2.2 has many untranslated items (Russian language). Some items have
translation (for example, in nested dialogs, item is translated, but in the
menu from which it is called, English string is used). Compared to the 7.2.X.X 
the situation is much better, but there are still many problems. Attached
screenshots with found untranslated items (underlined with red)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148233] Editing - Form - Listbox: Direct SQL-code with breaks will be destroyed if edited in text mode

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148233

QA Administrators  changed:

   What|Removed |Added

   Keywords||bibisectRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148066] Warning dialog open above other window

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148066

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148020] Re-arranging sheets with drag & drop lacks responsiveness if the sheet to move being content rich

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148020

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148265] Freeze when u want copy from one file to another opened file - macOS

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148265

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148265] Freeze when u want copy from one file to another opened file - macOS

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148265

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

--- Comment #21 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147732] font highlighting small caps does not work in Impress

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147732

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147732] font highlighting small caps does not work in Impress

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147732

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141216] Stock Chart - Type 2 2nd Data Series

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141216

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141216] Stock Chart - Type 2 2nd Data Series

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144263] On LibreOffice version 7.1.5.2 , the skip next page (ctrl + enter) doesn't work

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144263

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144263] On LibreOffice version 7.1.5.2 , the skip next page (ctrl + enter) doesn't work

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144263

--- Comment #4 from QA Administrators  ---
Dear jpn4358,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120679] [META] Labels and Business Cards issues

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120679
Bug 120679 depends on bug 143932, which changed state.

Bug 143932 Summary: horizontal pitch resolution limit disrupts label spacing in 
Labels creator, formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=143932

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143932] horizontal pitch resolution limit disrupts label spacing in Labels creator, formatting

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143932

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144884] Sudden Change in Basic Ability to Copy & Paste

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144884

--- Comment #2 from QA Administrators  ---
Dear rebeccamkiel,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143932] horizontal pitch resolution limit disrupts label spacing in Labels creator, formatting

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143932

--- Comment #3 from QA Administrators  ---
Dear be!bob,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144861] 44 malware mis en quarantaine par Immunet lors du téléchargement de LibreOffice 7.2.1.2 Win64

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144861

--- Comment #3 from QA Administrators  ---
Dear JF Commes,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 82087] FORMATTING: (Hyphenation) "Paragraph Styles > Text Flow > Characters at line end" lower limit is wrong for Greek language

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82087

--- Comment #15 from QA Administrators  ---
Dear Spiros Georgaras,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #12 from Vince  ---
This revised patch contains the following changes:

vcl/unx/gtk3/gtkframe.cxx

Instead of bypassing the code, I moved it to another location in the code.
Based on my admittedly short testing, this fixes bug 146174 AND preserves fix
to bug 144846.

sw/source/uibase/docvw/edtwin.cxx

No changes.

The proposed changes to these modules are intended as an attempt to address
"Regaining user control over keyboard customization". If desired, I can break
this into 2 patches and post them to their respective bug reports.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #12 from Vince  ---
This revised patch contains the following changes:

vcl/unx/gtk3/gtkframe.cxx

Instead of bypassing the code, I moved it to another location in the code.
Based on my admittedly short testing, this fixes bug 146174 AND preserves fix
to bug 144846.

sw/source/uibase/docvw/edtwin.cxx

No changes.

The proposed changes to these modules are intended as an attempt to address
"Regaining user control over keyboard customization". If desired, I can break
this into 2 patches and post them to their respective bug reports.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148283] Calc unrecoverable crash

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148283

Elmar  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Elmar  ---
Installed latest dev version
Backups in recovery folder being created 
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: aca4b5708207962935ca34adc70fed3a9ffb6074
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded

before latest update, found this today:
Checked the Backup directory: there os an entry but it is 0 bytes
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: 28de720bc088a4afd3b2f28c5136a3478af5d22a
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Calc: threaded


The current official version backup is not 0 bytes
Version: 6.4.7.2
Build ID: 1:6.4.7-0ubuntu0.20.04.4
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: en-GB (en_GB.UTF-8); UI-Language: en-GB
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #11 from Vince  ---
Created attachment 179264
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179264=edit
Updated patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #11 from Vince  ---
Created attachment 179264
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179264=edit
Updated patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #10 from Vince  ---
(In reply to V Stuart Foote from comment #9)
> (In reply to Vince from comment #8)
> 
> > 
> > Perhaps I didn't describe it precisely. With a fresh profile, Alt+a brings
> > up the table submenu. Since I don't need to access the table submenu very
> > often, I prefer for that keystroke to do something more useful to me:
> > execute my MyFavoriteMacro. I customize the keyboard to assign Alt+a to do
> > just that. 
> 
> For vcl backends other than gtk3 it still does. Only the gtk3/4
> implementation has been affected.
> 
> 
> > > Alt+ combinations should not be used for shortcuts at all.
> > 
> > Where does this come from? The capability was introduced a long time ago,
> > after lots of impassioned discussion (see
> > https://bz.apache.org/ooo/show_bug.cgi?id=4756). I suspect a lot of people
> > are using it, including those who reported bug 146174.
> 
> + are still fully customizable, except the behavior difference in
> handling the accelerators vs. shortcuts got a major tweak for supporting
> gtk3 DE with the work on bug 92630, which now splits the accelerator key
> sequence. 
> 
>  is now the gtk3 compliant toggle to show the mnemonics assigned, the
> underlined character for the lable.
> 
> So now ,  in sequence will open the menu; + will read the
> short-cut if assigned in the customize dialog, except on gtk3/4--check it
> out with the vcl 'gen', 'kf5', or on a Windows build.
> 
> If you don't like that gtk3 compliance feature, don't use a gtk3 based DE.

The gtk3 compliance feature never presented issues. Nothing broke after bug
92630 was resolved. Bug 146174 surfaced after the commit last October which
ironically addressed what appears to be a bug in the way gtk3 processes
mnemonics (https://bugs.documentfoundation.org/show_bug.cgi?id=144846#c5).

The discussion in this thread seems to be focussed around my proposed changes
to vcl/unx/gtk3/gtkframe.cxx. I realize that I need to do something better than
bypassing the recently introduced code, so I am going to propose a more
constructive patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #10 from Vince  ---
(In reply to V Stuart Foote from comment #9)
> (In reply to Vince from comment #8)
> 
> > 
> > Perhaps I didn't describe it precisely. With a fresh profile, Alt+a brings
> > up the table submenu. Since I don't need to access the table submenu very
> > often, I prefer for that keystroke to do something more useful to me:
> > execute my MyFavoriteMacro. I customize the keyboard to assign Alt+a to do
> > just that. 
> 
> For vcl backends other than gtk3 it still does. Only the gtk3/4
> implementation has been affected.
> 
> 
> > > Alt+ combinations should not be used for shortcuts at all.
> > 
> > Where does this come from? The capability was introduced a long time ago,
> > after lots of impassioned discussion (see
> > https://bz.apache.org/ooo/show_bug.cgi?id=4756). I suspect a lot of people
> > are using it, including those who reported bug 146174.
> 
> + are still fully customizable, except the behavior difference in
> handling the accelerators vs. shortcuts got a major tweak for supporting
> gtk3 DE with the work on bug 92630, which now splits the accelerator key
> sequence. 
> 
>  is now the gtk3 compliant toggle to show the mnemonics assigned, the
> underlined character for the lable.
> 
> So now ,  in sequence will open the menu; + will read the
> short-cut if assigned in the customize dialog, except on gtk3/4--check it
> out with the vcl 'gen', 'kf5', or on a Windows build.
> 
> If you don't like that gtk3 compliance feature, don't use a gtk3 based DE.

The gtk3 compliance feature never presented issues. Nothing broke after bug
92630 was resolved. Bug 146174 surfaced after the commit last October which
ironically addressed what appears to be a bug in the way gtk3 processes
mnemonics (https://bugs.documentfoundation.org/show_bug.cgi?id=144846#c5).

The discussion in this thread seems to be focussed around my proposed changes
to vcl/unx/gtk3/gtkframe.cxx. I realize that I need to do something better than
bypassing the recently introduced code, so I am going to propose a more
constructive patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 147721] Autostart not functioning when running a presentation on loop and repeat

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147721

--- Comment #5 from Scott Clewell  ---
Hey PeeWee,
I followed your well documented steps but cannot reproduce the bug.

I click or space bar through the template slides and after 5 seconds it loops
to the first slide.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147721] Autostart not functioning when running a presentation on loop and repeat

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147721

--- Comment #4 from Scott Clewell  ---
Created attachment 179263
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179263=edit
Slide Show Settings

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/colibre_dark icon-themes/colibre_dark_svg

2022-04-01 Thread Rizal Muttaqin (via logerrit)
 icon-themes/colibre_dark/cmd/32/saveastemplate.png |binary
 icon-themes/colibre_dark/cmd/lc_saveastemplate.png |binary
 icon-themes/colibre_dark/cmd/sc_saveastemplate.png |binary
 icon-themes/colibre_dark_svg/cmd/32/saveastemplate.svg |2 +-
 icon-themes/colibre_dark_svg/cmd/lc_saveastemplate.svg |2 +-
 icon-themes/colibre_dark_svg/cmd/sc_saveastemplate.svg |3 ++-
 6 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit a3b141624930b6eb96b3273fee8396476db6d116
Author: Rizal Muttaqin 
AuthorDate: Sat Apr 2 06:09:23 2022 +0700
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Apr 2 01:59:01 2022 +0200

Colibre: Update dark Save As Template icons

Change-Id: Iac2b5497feb763ae27b543365ce63d5432002dcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132449
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/colibre_dark/cmd/32/saveastemplate.png 
b/icon-themes/colibre_dark/cmd/32/saveastemplate.png
index ccf0bc1a3a0b..7dde54a4be46 100644
Binary files a/icon-themes/colibre_dark/cmd/32/saveastemplate.png and 
b/icon-themes/colibre_dark/cmd/32/saveastemplate.png differ
diff --git a/icon-themes/colibre_dark/cmd/lc_saveastemplate.png 
b/icon-themes/colibre_dark/cmd/lc_saveastemplate.png
index 9c723e919609..7c9473ccd4f9 100644
Binary files a/icon-themes/colibre_dark/cmd/lc_saveastemplate.png and 
b/icon-themes/colibre_dark/cmd/lc_saveastemplate.png differ
diff --git a/icon-themes/colibre_dark/cmd/sc_saveastemplate.png 
b/icon-themes/colibre_dark/cmd/sc_saveastemplate.png
index b1742c51664f..c553c0d91839 100644
Binary files a/icon-themes/colibre_dark/cmd/sc_saveastemplate.png and 
b/icon-themes/colibre_dark/cmd/sc_saveastemplate.png differ
diff --git a/icon-themes/colibre_dark_svg/cmd/32/saveastemplate.svg 
b/icon-themes/colibre_dark_svg/cmd/32/saveastemplate.svg
index c22dbf3a7a9d..3dad314d48af 100644
--- a/icon-themes/colibre_dark_svg/cmd/32/saveastemplate.svg
+++ b/icon-themes/colibre_dark_svg/cmd/32/saveastemplate.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/colibre_dark_svg/cmd/lc_saveastemplate.svg 
b/icon-themes/colibre_dark_svg/cmd/lc_saveastemplate.svg
index d14800f667f8..06cc51882845 100644
--- a/icon-themes/colibre_dark_svg/cmd/lc_saveastemplate.svg
+++ b/icon-themes/colibre_dark_svg/cmd/lc_saveastemplate.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/colibre_dark_svg/cmd/sc_saveastemplate.svg 
b/icon-themes/colibre_dark_svg/cmd/sc_saveastemplate.svg
index e87cf481f8be..38e1ddeff4bf 100644
--- a/icon-themes/colibre_dark_svg/cmd/sc_saveastemplate.svg
+++ b/icon-themes/colibre_dark_svg/cmd/sc_saveastemplate.svg
@@ -1,2 +1,3 @@
 http://www.w3.org/2000/svg;>
-/amp;amp;amp;amp;amp;amp;gt;
\ No newline at end of file
+
+/amp;amp;amp;amp;amp;amp;amp;gt;
\ No newline at end of file


[Libreoffice-bugs] [Bug 148293] Sorting columns with autofilter

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148293

--- Comment #3 from Aron Budea  ---
Created attachment 179262
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179262=edit
Screencast

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148293] Sorting columns with autofilter

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148293

--- Comment #2 from Aron Budea  ---
(In reply to Aron Budea from comment #0)
> When an autofiltered range is sorted using Sort Ascending / Sort Descending,
> the following discrepancies happen:
My bad, I wasn't clear, I meant the Sort Ascending / Sort Descending toolbar
buttons, not the similar autofilter functions in the first two cases (and the
functions in the dropdown in the other two).

Let me attach a screencast, out of the 4 cases only the last works as expected.

On a sidenote, if I show the 1st case by sorting using the toolbar buttons,
undo it, and then do the 4th case using the filter dropdown, it behaves
differently (badly).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148314] File corruption after crash

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148314

--- Comment #1 from Simon  ---
Crash occurred on large calc file I have been using for a long time. Normal
restore successful? but weird stuff happening now in that file. 
Was using v 7.3.1, went back to 7.2.6 - same stuff.

For instance, lost cursor on cell, Del key on hi-lited text in input deletes
all the text there. A formula entered shows correct value, but if you drag it
or copy it the value shown is that of original cell, tho formula shows
correctly in the copied cells. These are just some examples of weirdness, there
is way more too complex to go into now.

To illustrate type 1 into say d1, and enter =d1+1  into e1 drag this across and
I get all 2  as the results in the copied cells!!!

This happens on all the sheets in the file. If I create a new file or use an
old file there are no problems. So I think obviously a file corruption. What to
do?
Can it be fixed? Has this happened before?

Concerned
Simon

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 130453] [macOS] Convert from Carbon to Cocoa framework

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=130453

steve  changed:

   What|Removed |Added

 CC||l...@disr.it
Summary|[MacOS] Convert from Carbon |[macOS] Convert from Carbon
   |to Cocoa framework  |to Cocoa framework

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148314] New: File corruption after crash

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148314

Bug ID: 148314
   Summary: File corruption after crash
   Product: LibreOffice
   Version: 7.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sim...@smcalister.me.uk

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148293] Sorting columns with autofilter

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148293

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m.a.riosv  ---
Works for me.
Version: 7.2.6.2 (x64) / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148304] Using toolbar in Calc to set object line, style, width or colour triggers Assertion `(typeid(*this) == typeid(SfxItemSet)) && "cannot call this on a subclass of SfxItem

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148304

Aron Budea  changed:

   What|Removed |Added

 OS|Linux (All) |All
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Hardware|x86-64 (AMD64)  |All
 CC||aron.bu...@gmail.com

--- Comment #1 from Aron Budea  ---
Confirmed using an LO 7.4.0.0.alpha0+
(2fa01ae540e174452bf5cd763c1464cfe37af076) debug build / Ubuntu.
Nevertheless, since the assert doesn't seem to be OS-specific, setting it to
All for now.

Assertion:
svl/source/items/itemset.cxx:1256: SfxItemSet SfxItemSet::CloneAsValue(bool,
SfxItemPool*) const: Assertion `(typeid(*this) == typeid(SfxItemSet)) &&
"cannot call this on a subclass of SfxItemSet"' failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148297] Page Layout in View menu in LibreOffice Calc

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148297

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
There are 'Menu/View/Normal' and 'Menu/View/Page break', what do you want with
'Page Layout'
And, please copy from Menu/Help/About, with the button in it, the information
about version and OS here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #9 from V Stuart Foote  ---
(In reply to Vince from comment #8)

> 
> Perhaps I didn't describe it precisely. With a fresh profile, Alt+a brings
> up the table submenu. Since I don't need to access the table submenu very
> often, I prefer for that keystroke to do something more useful to me:
> execute my MyFavoriteMacro. I customize the keyboard to assign Alt+a to do
> just that. 

For vcl backends other than gtk3 it still does. Only the gtk3/4 implementation
has been affected.


> > Alt+ combinations should not be used for shortcuts at all.
> 
> Where does this come from? The capability was introduced a long time ago,
> after lots of impassioned discussion (see
> https://bz.apache.org/ooo/show_bug.cgi?id=4756). I suspect a lot of people
> are using it, including those who reported bug 146174.

+ are still fully customizable, except the behavior difference in
handling the accelerators vs. shortcuts got a major tweak for supporting gtk3
DE with the work on bug 92630, which now splits the accelerator key sequence. 

 is now the gtk3 compliant toggle to show the mnemonics assigned, the
underlined character for the lable.

So now ,  in sequence will open the menu; + will read the
short-cut if assigned in the customize dialog, except on gtk3/4--check it out
with the vcl 'gen', 'kf5', or on a Windows build.

If you don't like that gtk3 compliance feature, don't use a gtk3 based DE.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #9 from V Stuart Foote  ---
(In reply to Vince from comment #8)

> 
> Perhaps I didn't describe it precisely. With a fresh profile, Alt+a brings
> up the table submenu. Since I don't need to access the table submenu very
> often, I prefer for that keystroke to do something more useful to me:
> execute my MyFavoriteMacro. I customize the keyboard to assign Alt+a to do
> just that. 

For vcl backends other than gtk3 it still does. Only the gtk3/4 implementation
has been affected.


> > Alt+ combinations should not be used for shortcuts at all.
> 
> Where does this come from? The capability was introduced a long time ago,
> after lots of impassioned discussion (see
> https://bz.apache.org/ooo/show_bug.cgi?id=4756). I suspect a lot of people
> are using it, including those who reported bug 146174.

+ are still fully customizable, except the behavior difference in
handling the accelerators vs. shortcuts got a major tweak for supporting gtk3
DE with the work on bug 92630, which now splits the accelerator key sequence. 

 is now the gtk3 compliant toggle to show the mnemonics assigned, the
underlined character for the lable.

So now ,  in sequence will open the menu; + will read the
short-cut if assigned in the customize dialog, except on gtk3/4--check it out
with the vcl 'gen', 'kf5', or on a Windows build.

If you don't like that gtk3 compliance feature, don't use a gtk3 based DE.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148197] LibreOffice crashes when I try to dock floating Navigator window

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148197

--- Comment #2 from Gerry  ---
Crash reproducible in the new version 7.3.2.2 

The crashes also appear if I deactivate hardware acceleration in options ->
view.

Version: 7.3.2.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Ubuntu package version: 1:7.3.2~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/colibre icon-themes/colibre_dark icon-themes/colibre_dark_svg icon-themes/colibre_svg

2022-04-01 Thread Rizal Muttaqin (via logerrit)
 icon-themes/colibre/cmd/sc_dbviewaliases.png  |binary
 icon-themes/colibre_dark/cmd/sc_dbviewaliases.png |binary
 icon-themes/colibre_dark_svg/cmd/sc_dbviewaliases.svg |2 +-
 icon-themes/colibre_svg/cmd/sc_dbviewaliases.svg  |3 ++-
 4 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 3f15a310ff4f13cd9e26d442a82f091176e3583c
Author: Rizal Muttaqin 
AuthorDate: Sat Apr 2 04:12:22 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sat Apr 2 00:04:21 2022 +0200

Colibre: tdf#148029 Change line only shapes with real intersected shapes

Change-Id: Ia938d9e7aaef08052a722c118e7b805d8986dd37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132448
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/colibre/cmd/sc_dbviewaliases.png 
b/icon-themes/colibre/cmd/sc_dbviewaliases.png
index f97b1e3b734a..d8acc2e6ac33 100644
Binary files a/icon-themes/colibre/cmd/sc_dbviewaliases.png and 
b/icon-themes/colibre/cmd/sc_dbviewaliases.png differ
diff --git a/icon-themes/colibre_dark/cmd/sc_dbviewaliases.png 
b/icon-themes/colibre_dark/cmd/sc_dbviewaliases.png
index 96376840fb25..164e3ba7b8b8 100644
Binary files a/icon-themes/colibre_dark/cmd/sc_dbviewaliases.png and 
b/icon-themes/colibre_dark/cmd/sc_dbviewaliases.png differ
diff --git a/icon-themes/colibre_dark_svg/cmd/sc_dbviewaliases.svg 
b/icon-themes/colibre_dark_svg/cmd/sc_dbviewaliases.svg
index 5fa2039c307a..8db09ddbcc7a 100644
--- a/icon-themes/colibre_dark_svg/cmd/sc_dbviewaliases.svg
+++ b/icon-themes/colibre_dark_svg/cmd/sc_dbviewaliases.svg
@@ -1,2 +1,2 @@
 http://www.w3.org/2000/svg;>
-/amp;amp;gt;
\ No newline at end of file
+/amp;amp;amp;gt;
\ No newline at end of file
diff --git a/icon-themes/colibre_svg/cmd/sc_dbviewaliases.svg 
b/icon-themes/colibre_svg/cmd/sc_dbviewaliases.svg
index a9db483fa73d..c8ad3812db3a 100644
--- a/icon-themes/colibre_svg/cmd/sc_dbviewaliases.svg
+++ b/icon-themes/colibre_svg/cmd/sc_dbviewaliases.svg
@@ -1 +1,2 @@
-http://www.w3.org/2000/svg;>/amp;gt;
\ No newline at end of file
+http://www.w3.org/2000/svg;>
+/amp;amp;gt;
\ No newline at end of file


[Libreoffice-bugs] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #8 from Vince  ---
(In reply to Heiko Tietze from comment #7)
> (In reply to Vince from comment #6)
> > The request here is NOT simply about mnemonics but about the ability to
> > override those mnemonics via keyboard customization.
> 
> The customization changes the assignment of shortcuts to UNO commands. It
> never changed mnemonics from _File (alt+F) to F_ile (alt+I). You may have
> Alt+P for Open, instead of ctrl+O, but the mnemonic alt+O will work anyway.

Perhaps I didn't describe it precisely. With a fresh profile, Alt+a brings up
the table submenu. Since I don't need to access the table submenu very often, I
prefer for that keystroke to do something more useful to me: execute my
MyFavoriteMacro. I customize the keyboard to assign Alt+a to do just that. When
I need to access the table submenu, I can still do so with a variety of other
methods: mouse click; type F6 (focus on menubar), followed by 'a'; type F10,
followed by right arrow 5 times. All of this worked just fine for many years
but stopped working recently.

> Alt+ combinations should not be used for shortcuts at all.

Where does this come from? The capability was introduced a long time ago, after
lots of impassioned discussion (see
https://bz.apache.org/ooo/show_bug.cgi?id=4756). I suspect a lot of people are
using it, including those who reported bug 146174.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148258] Regaining user control over keyboard customization

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148258

--- Comment #8 from Vince  ---
(In reply to Heiko Tietze from comment #7)
> (In reply to Vince from comment #6)
> > The request here is NOT simply about mnemonics but about the ability to
> > override those mnemonics via keyboard customization.
> 
> The customization changes the assignment of shortcuts to UNO commands. It
> never changed mnemonics from _File (alt+F) to F_ile (alt+I). You may have
> Alt+P for Open, instead of ctrl+O, but the mnemonic alt+O will work anyway.

Perhaps I didn't describe it precisely. With a fresh profile, Alt+a brings up
the table submenu. Since I don't need to access the table submenu very often, I
prefer for that keystroke to do something more useful to me: execute my
MyFavoriteMacro. I customize the keyboard to assign Alt+a to do just that. When
I need to access the table submenu, I can still do so with a variety of other
methods: mouse click; type F6 (focus on menubar), followed by 'a'; type F10,
followed by right arrow 5 times. All of this worked just fine for many years
but stopped working recently.

> Alt+ combinations should not be used for shortcuts at all.

Where does this come from? The capability was introduced a long time ago, after
lots of impassioned discussion (see
https://bz.apache.org/ooo/show_bug.cgi?id=4756). I suspect a lot of people are
using it, including those who reported bug 146174.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 131754] Character emphasis menu unclear

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131754

--- Comment #4 from Kenneth Hanson  ---
No change as of v7.2.6.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131752] Character emphasis marks low resolution and render badly in UI

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=131752

--- Comment #4 from Kenneth Hanson  ---
Bug is still present in v7.2.6.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - connectivity/source

2022-04-01 Thread Julien Nabet (via logerrit)
 connectivity/source/drivers/firebird/PreparedStatement.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3507f6e6513cb53e404f2e33d5500fdeb2b7788d
Author: Julien Nabet 
AuthorDate: Fri Apr 1 19:40:21 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Fri Apr 1 23:19:48 2022 +0200

tdf#148310: Firebird: copy complete rows, CLOB field, last character lost

off by 1 pb.

Indeed we got:
610 sal_Int64 nCharWritten = 1; // XClob is indexed from 1
offapi/com/sun/star/sdbc/XClob.idl indeed indicates:
114 The substring begins at position pos and has up
115 to
116 length
117 consecutive characters.
118 
119 @param pos
120 the starting position, 1-based
121 @param length
122 the length of the substring
123 @returns
124 the substring
125 @throws SQLException
126 if a database access error occurs.
127  */
128 string getSubString([in]hyper pos, [in]long length) raises 
(SQLException);

but if the string to copy has length 1, we never enter:
while ( nLen > nCharWritten )
=> we must change this into: while ( nLen >= nCharWritten )
also number of remaining characters to take into account at each loop must 
be adapted too:
sal_Int64 nCharRemain = nLen - nCharWritten;  => would be 0
into:
sal_Int64 nCharRemain = nLen - nCharWritten + 1;

Change-Id: I7697c8312024818f73a19c39f694cf209f494d71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132443
Tested-by: Jenkins
Reviewed-by: Julien Nabet 
(cherry picked from commit da81a880df76bebb6d9fbc770c313381a3c33268)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132378
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx 
b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index a3abf2d68cc8..392785b9c816 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -612,9 +612,9 @@ void SAL_CALL OPreparedStatement::setClob(sal_Int32 
nParameterIndex, const Refer
 sal_Int64 nCharWritten = 1; // XClob is indexed from 1
 ISC_STATUS aErr = 0;
 sal_Int64 nLen = xClob->length();
-while ( nLen > nCharWritten )
+while ( nLen >= nCharWritten )
 {
-sal_Int64 nCharRemain = nLen - nCharWritten;
+sal_Int64 nCharRemain = nLen - nCharWritten + 1;
 constexpr sal_uInt16 MAX_SIZE = SAL_MAX_UINT16 / 4;
 sal_uInt16 nWriteSize = std::min(nCharRemain, MAX_SIZE);
 OString sData = OUStringToOString(


[Libreoffice-bugs] [Bug 141216] Stock Chart - Type 2 2nd Data Series

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=141216

--- Comment #2 from Ian Eales  ---
Created attachment 179261
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179261=edit
Dual series stock chart example


I frequently plot multiple series on a chart and use the 2nd access when scales
are vastly different.

If I have 12 months and want to plot some annual values, the categories will be
12+ rows.

The monthly data includes the number of additional annual values as blank
cells. The annual data has 12 blank cells and the annual values.

There are two series in the charts in the file. The bar chart allows selection
of each. The stock chart does not and does not plot Min/Max values

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc

2022-04-01 Thread Stephan Bergmann (via logerrit)
 sw/inc/formatcontentcontrol.hxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 5cb3a31ff0fb17ee75c4a8ce6c79ae6c39d0954f
Author: Stephan Bergmann 
AuthorDate: Fri Apr 1 21:21:05 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Apr 1 22:44:31 2022 +0200

UBSan needs some more RTTI during CppunitTest_sw_core_unocore now

> DynamicLibraryManagerException: "Failed to load dynamic library: 
workdir/LinkTarget/CppunitTest/libtest_sw_core_unocore.so
> LinkTarget/CppunitTest/libtest_sw_core_unocore.so: undefined symbol: 
_ZTI22SwFormatContentControl"

and

> DynamicLibraryManagerException: "Failed to load dynamic library: 
workdir/LinkTarget/CppunitTest/libtest_sw_core_unocore.so
> workdir/LinkTarget/CppunitTest/libtest_sw_core_unocore.so: undefined 
symbol: _ZTI16SwContentControl"

presumably since 5da08b21cd23f2e70f5003733b03a7aee7915225 "sw content 
controls:
add UNO API to insert this with custom props"

Change-Id: I77370f11766456081827257d688490ff6e138cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132447
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/inc/formatcontentcontrol.hxx b/sw/inc/formatcontentcontrol.hxx
index c1ac07279efe..097f4ae7c179 100644
--- a/sw/inc/formatcontentcontrol.hxx
+++ b/sw/inc/formatcontentcontrol.hxx
@@ -22,6 +22,7 @@
 #include 
 
 #include 
+#include 
 #include 
 
 #include "calbck.hxx"
@@ -32,7 +33,7 @@ class SwTextNode;
 class SwXContentControl;
 
 /// SfxPoolItem subclass that wraps an SwContentControl.
-class SwFormatContentControl final : public SfxPoolItem
+class SAL_DLLPUBLIC_RTTI SwFormatContentControl final : public SfxPoolItem
 {
 std::shared_ptr m_pContentControl;
 SwTextContentControl* m_pTextAttr;
@@ -66,7 +67,7 @@ public:
 };
 
 /// Stores the properties of a content control.
-class SwContentControl : public sw::BroadcastingModify
+class SAL_DLLPUBLIC_RTTI SwContentControl : public sw::BroadcastingModify
 {
 css::uno::WeakReference m_wXContentControl;
 


[Libreoffice-commits] core.git: Branch 'libreoffice-7-2' - configure.ac

2022-04-01 Thread Tor Lillqvist (via logerrit)
 configure.ac |   15 ---
 1 file changed, 12 insertions(+), 3 deletions(-)

New commits:
commit 1d9205e7093b367d95521016c0aba4a246ac818d
Author: Tor Lillqvist 
AuthorDate: Mon Mar 14 23:43:35 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 1 22:42:52 2022 +0200

Accept macOS SDK 12.3

Change-Id: Ice469236dd79675b6fad6f7c5a244888200fea8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131565
Tested-by: Tor Lillqvist 
Reviewed-by: Tor Lillqvist 
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131975
Tested-by: Jenkins
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132436

diff --git a/configure.ac b/configure.ac
index a8802eb6eb78..1bb6ea0a1af9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3225,7 +3225,7 @@ if test $_os = Darwin; then
 # higher than or equal to the minimum required should be found.
 
 AC_MSG_CHECKING([what macOS SDK to use])
-for _macosx_sdk in ${with_macosx_sdk-12.1 12.0 11.3 11.1 11.0 10.15 10.14 
10.13}; do
+for _macosx_sdk in ${with_macosx_sdk-12.3 12.1 12.0 11.3 11.1 11.0 10.15 
10.14 10.13}; do
 MACOSX_SDK_PATH=`xcrun --sdk macosx${_macosx_sdk} --show-sdk-path 2> 
/dev/null`
 if test -d "$MACOSX_SDK_PATH"; then
 with_macosx_sdk="${_macosx_sdk}"
@@ -3269,6 +3269,9 @@ if test $_os = Darwin; then
 12.1)
 MACOSX_SDK_VERSION=120100
 ;;
+12.3)
+MACOSX_SDK_VERSION=120300
+;;
 *)
 AC_MSG_ERROR([with-macosx-sdk $with_macosx_sdk is not a supported 
value, supported values are 10.13--12.1])
 ;;
@@ -3344,8 +3347,11 @@ if test $_os = Darwin; then
 12.1)
 MAC_OS_X_VERSION_MIN_REQUIRED="120100"
 ;;
+12.3)
+MAC_OS_X_VERSION_MIN_REQUIRED="120300"
+;;
 *)
-AC_MSG_ERROR([with-macosx-version-min-required 
$with_macosx_version_min_required is not a supported value, supported values 
are 10.10--12.1])
+AC_MSG_ERROR([with-macosx-version-min-required 
$with_macosx_version_min_required is not a supported value, supported values 
are 10.10--12.3])
 ;;
 esac
 
@@ -3418,8 +3424,11 @@ if test $_os = Darwin; then
 12.1)
 MAC_OS_X_VERSION_MAX_ALLOWED="120100"
 ;;
+12.3)
+MAC_OS_X_VERSION_MAX_ALLOWED="120300"
+;;
 *)
-AC_MSG_ERROR([with-macosx-version-max-allowed 
$with_macosx_version_max_allowed is not a supported value, supported values are 
10.10--12.1])
+AC_MSG_ERROR([with-macosx-version-max-allowed 
$with_macosx_version_max_allowed is not a supported value, supported values are 
10.10--12.3])
 ;;
 esac
 


[Libreoffice-commits] core.git: sw/qa sw/source

2022-04-01 Thread Michael Stahl (via logerrit)
 sw/qa/core/data/rtf/pass/forcepoint-96.rtf  |8 
 sw/source/core/doc/DocumentContentOperationsManager.cxx |   31 
 2 files changed, 39 insertions(+)

New commits:
commit 784ed64ff50bad19ab3edeefaf336a85594bddaa
Author: Michael Stahl 
AuthorDate: Fri Apr 1 17:16:20 2022 +0200
Commit: Caolán McNamara 
CommitDate: Fri Apr 1 22:26:33 2022 +0200

forcepoint#96 sw: delete fieldmarks in DelFullPara()

The problem is that CorrAbs() will move any position of a fieldmark
that's in the deleted SwTextNodes to a different node that doesn't have
the CH_TXT_ATR_FIELD*.

Then it will inevitably crash later when it can't find its chars.

The other problem is that if there's only a CH_TXT_ATR_FIELDSEP in the
deleted nodes, that fieldmark would then be missing it.

Just delete fieldmarks with positions in deleted nodes, that should work
fine for the usual cases where DelFullPara() is called.

Change-Id: I8dfac9a315d74025dbe1ed5ccb95b7c9121fb569
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132422
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/core/data/rtf/pass/forcepoint-96.rtf 
b/sw/qa/core/data/rtf/pass/forcepoint-96.rtf
new file mode 100644
index ..1e5a05d4801f
--- /dev/null
+++ b/sw/qa/core/data/rtf/pass/forcepoint-96.rtf
@@ -0,0 +1,8 @@
+{\rtf1
+\clvertalt
+\chpgn
+\clvertalb
+\cell
+\pard\intbl
+\cellx279
+}
diff --git a/sw/source/core/doc/DocumentContentOperationsManager.cxx 
b/sw/source/core/doc/DocumentContentOperationsManager.cxx
index 8eb9f3fc4864..a979ebddb951 100644
--- a/sw/source/core/doc/DocumentContentOperationsManager.cxx
+++ b/sw/source/core/doc/DocumentContentOperationsManager.cxx
@@ -2252,6 +2252,37 @@ bool DocumentContentOperationsManager::DelFullPara( 
SwPaM& rPam )
 return false;
 }
 }
+
+// must delete all fieldmarks before CorrAbs(), or they'll remain
+// moved to wrong node without their CH_TXT_ATR_FIELD*
+// (note: deleteMarks() doesn't help here, in case of partially
+// selected fieldmarks; let's delete these as re-inserting their chars
+// elsewhere looks difficult)
+::std::set<::sw::mark::IFieldmark*> fieldmarks;
+for (SwNodeIndex i = aRg.aStart; i <= aRg.aEnd; ++i)
+{
+if (SwTextNode *const pTextNode = i.GetNode().GetTextNode())
+{
+for (sal_Int32 j = 0; j < pTextNode->GetText().getLength(); 
++j)
+{
+switch (pTextNode->GetText()[j])
+{
+case CH_TXT_ATR_FIELDSTART:
+case CH_TXT_ATR_FIELDEND:
+
fieldmarks.insert(m_rDoc.getIDocumentMarkAccess()->getFieldmarkAt(SwPosition(*pTextNode,
 j)));
+break;
+case CH_TXT_ATR_FIELDSEP:
+
fieldmarks.insert(m_rDoc.getIDocumentMarkAccess()->getFieldmarkFor(SwPosition(*pTextNode,
 j)));
+break;
+}
+}
+}
+}
+for (auto const pFieldMark : fieldmarks)
+{
+m_rDoc.getIDocumentMarkAccess()->deleteMark(pFieldMark);
+}
+
 // move bookmarks, redlines etc.
 if (aRg.aStart == aRg.aEnd) // only first CorrAbs variant handles this
 {


[Libreoffice-bugs] [Bug 148313] New: CRASH: Basic IDE crashing while resizing dialog

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148313

Bug ID: 148313
   Summary: CRASH: Basic IDE crashing while resizing dialog
   Product: LibreOffice
   Version: 7.3.1.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rafael.palma.l...@gmail.com

Created attachment 179260
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179260=edit
Video showing the crash

See the attached video. LibreOffice is crashing when resizing a dialog in the
Basic IDE.

Note that if you simply create a new dialog and resize it, everything is fine.
However, if you add controls, save the changes, close the IDE and reopen it,
then the crash will happen.

Steps to reproduce:
1) Open the Basic IDE
2) Create a new dialog
3) Add some controls to the dialog
4) Save
5) Close LibreOffice
6) Reopen LO and open the Basic IDE
7) Try resizing the dialog created in step 2
8) After a few resize operations, LO will crash

System info:
Version: 7.3.2.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 16; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.2~rc2-0ubuntu0.21.10.1~lo1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103030

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||148312


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148312
[Bug 148312] Navigator should not show ToC entries as hyperlinks, at all
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 52113] Navigator should show the Hyperlinks embedded in TOC separately

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=52113

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||8312

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148312] New: Navigator should not show ToC entries as hyperlinks, at all

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148312

Bug ID: 148312
   Summary: Navigator should not show ToC entries as hyperlinks,
at all
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com
Blocks: 103030

The Navigator already has a hierarchy of items with outline-levels. It
therefore does not make sense for it to also duplicate the hierarchy within a
table of contents, as a sequence of Hyperlink-category items. Yet - they are.

Bug 52113 suggest these hyperlinks should be shown separately - I disagree,
that's not going far enough. I claim it is a bug they are displayed at all.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
[Bug 103030] [META] Navigator sidebar deck and floating window
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2022-04-01 Thread Caolán McNamara (via logerrit)
 sc/source/core/data/documen4.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 74a12d9710ba1a9855c6afb18055152120148833
Author: Caolán McNamara 
AuthorDate: Fri Apr 1 17:21:42 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 1 20:58:00 2022 +0200

ofz#45529 Timeout

Change-Id: I232d3c07623c7efbc7b0b910298bd77bf469a38b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132442
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index 9ec96b77b243..d19f9cedf91b 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -274,9 +274,9 @@ void ScDocument::InsertMatrixFormula(SCCOL nCol1, SCROW 
nRow1,
 if (utl::ConfigManager::IsFuzzing())
 {
 // just too slow
-if (nCol2 - nCol1 > 1024)
+if (nCol2 - nCol1 > 256)
 return;
-if (nRow2 - nRow1 > 1024)
+if (nRow2 - nRow1 > 256)
 return;
 }
 assert( ValidColRow( nCol1, nRow1) && ValidColRow( nCol2, nRow2));


[Libreoffice-commits] core.git: vcl/source

2022-04-01 Thread Caolán McNamara (via logerrit)
 vcl/source/filter/svm/SvmConverter.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit cd91de9d23106ad5170bb83ce71b74342b42d02f
Author: Caolán McNamara 
AuthorDate: Fri Apr 1 15:07:40 2022 +0100
Commit: Caolán McNamara 
CommitDate: Fri Apr 1 20:57:34 2022 +0200

ofz: Invalid-enum-value

Change-Id: I315223371d3b52981a0db109933f3a0e93903980
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132430
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/filter/svm/SvmConverter.cxx 
b/vcl/source/filter/svm/SvmConverter.cxx
index 2204b738ab0d..78ba871d448e 100644
--- a/vcl/source/filter/svm/SvmConverter.cxx
+++ b/vcl/source/filter/svm/SvmConverter.cxx
@@ -676,8 +676,8 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 aFont.SetAlignment( static_cast(nAlign) );
 aFont.SetWeight( ( nWeight == 1 ) ? WEIGHT_LIGHT : ( nWeight 
== 2 ) ? WEIGHT_NORMAL :
  ( nWeight == 3 ) ? WEIGHT_BOLD : 
WEIGHT_DONTKNOW );
-aFont.SetUnderline( static_cast(nUnderline) );
-aFont.SetStrikeout( static_cast(nStrikeout) );
+aFont.SetUnderline( static_cast(nUnderline & 
SAL_MAX_ENUM) );
+aFont.SetStrikeout( static_cast(nStrikeout & 
SAL_MAX_ENUM) );
 aFont.SetItalic( bItalic ? ITALIC_NORMAL : ITALIC_NONE );
 aFont.SetOutline( bOutline );
 aFont.SetShadow( bShadow );
@@ -1187,8 +1187,8 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
 rIStm.ReadInt32(nWidth 
).ReadUInt32(nStrikeout).ReadUInt32(nUnderline).ReadInt32(nFollowingActionCount);
 ImplSkipActions(rIStm, nFollowingActionCount);
 rMtf.AddAction( new MetaTextLineAction( aStartPt, nWidth,
-
static_cast(nStrikeout),
-
static_cast(nUnderline),
+
static_cast(nStrikeout & SAL_MAX_ENUM),
+
static_cast(nUnderline & SAL_MAX_ENUM),
 LINESTYLE_NONE ) );
 
 i = SkipActions(i, nFollowingActionCount, nActions);


[Libreoffice-bugs] [Bug 144124] pasting older entries from clipboard manager (e.g. LaunchBar or Alfred) pastes latest clipboard content on macOS

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144124

--- Comment #3 from Neil  ---
I see this bug frequently while using Alfred and LibreOffice.

If I copy anything in LibreOffice Writer, I cannot paste anything from Alfred
until I switch to a different app (not just another LibreOffice window), and
switch back. Until I switch away, trying to use Alfred's clipboard (including
Alfred's Snippets) only pastes whatever Libreoffice copied most recently.

After switching away from Libreoffice and back, Alfred works as expected until
I copy anything in Libreoffice.

Interestingly, if I copy something in Libreoffice, then try to paste something
from Alfred, Libreoffice's paste keeps pasting the same thing until I switch to
another app. When I switch back to Libreoffice, Libreoffice's paste pastes the
desired Alfred content.

There's something different about how the clipboard is refreshed when returning
to LibreOffice that isn't done when pasting after a copy.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102998] [META] Mail merge bugs and enhancements

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=102998

Michael Weghorn  changed:

   What|Removed |Added

 Depends on||148309


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=148309
[Bug 148309] Mail-merging a complex document with many data records
significantly slower after fix for bug 144565
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148309] Mail-merging a complex document with many data records significantly slower after fix for bug 144565

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148309

Michael Weghorn  changed:

   What|Removed |Added

   Keywords||bibisected, bisected, perf
 Blocks||102998


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=102998
[Bug 102998] [META] Mail merge bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: connectivity/source

2022-04-01 Thread Julien Nabet (via logerrit)
 connectivity/source/drivers/firebird/PreparedStatement.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit da81a880df76bebb6d9fbc770c313381a3c33268
Author: Julien Nabet 
AuthorDate: Fri Apr 1 19:40:21 2022 +0200
Commit: Julien Nabet 
CommitDate: Fri Apr 1 20:39:47 2022 +0200

tdf#148310: Firebird: copy complete rows, CLOB field, last character lost

off by 1 pb.

Indeed we got:
610 sal_Int64 nCharWritten = 1; // XClob is indexed from 1
offapi/com/sun/star/sdbc/XClob.idl indeed indicates:
114 The substring begins at position pos and has up
115 to
116 length
117 consecutive characters.
118 
119 @param pos
120 the starting position, 1-based
121 @param length
122 the length of the substring
123 @returns
124 the substring
125 @throws SQLException
126 if a database access error occurs.
127  */
128 string getSubString([in]hyper pos, [in]long length) raises 
(SQLException);

but if the string to copy has length 1, we never enter:
while ( nLen > nCharWritten )
=> we must change this into: while ( nLen >= nCharWritten )
also number of remaining characters to take into account at each loop must 
be adapted too:
sal_Int64 nCharRemain = nLen - nCharWritten;  => would be 0
into:
sal_Int64 nCharRemain = nLen - nCharWritten + 1;

Change-Id: I7697c8312024818f73a19c39f694cf209f494d71
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132443
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx 
b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index 39fef04a185c..10f034ce15ce 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -610,9 +610,9 @@ void SAL_CALL OPreparedStatement::setClob(sal_Int32 
nParameterIndex, const Refer
 sal_Int64 nCharWritten = 1; // XClob is indexed from 1
 ISC_STATUS aErr = 0;
 sal_Int64 nLen = xClob->length();
-while ( nLen > nCharWritten )
+while ( nLen >= nCharWritten )
 {
-sal_Int64 nCharRemain = nLen - nCharWritten;
+sal_Int64 nCharRemain = nLen - nCharWritten + 1;
 constexpr sal_uInt16 MAX_SIZE = SAL_MAX_UINT16 / 4;
 sal_uInt16 nWriteSize = std::min(nCharRemain, MAX_SIZE);
 OString sData = OUStringToOString(


[Libreoffice-bugs] [Bug 147925] Cursor scrolling back to comment when clicking outside of comment since LO 7.3

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147925

Rafael Lima  changed:

   What|Removed |Added

 CC||rayk...@gmail.com

--- Comment #4 from Rafael Lima  ---
@Jim, any chances this bug is related to the work being done in the Navigator?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

2022-04-01 Thread Xisco Fauli (via logerrit)
 sw/qa/uitest/findReplace/findReplace.py|8 ++--
 sw/qa/uitest/findReplace/findSimilarity.py |5 -
 sw/qa/uitest/findReplace/tdf137737.py  |8 ++--
 sw/qa/uitest/findReplace/tdf144089.py  |8 ++--
 sw/qa/uitest/macro_tests/tdf64690.py   |7 +--
 5 files changed, 23 insertions(+), 13 deletions(-)

New commits:
commit 8ed2457a089ae78b54f82c1fae07d54777dda3ca
Author: Xisco Fauli 
AuthorDate: Fri Apr 1 16:15:56 2022 +0200
Commit: Xisco Fauli 
CommitDate: Fri Apr 1 20:34:14 2022 +0200

uitest: sw: Deselect regexp checkbox after using it

Otherwise, this is saved and it might affects other tests

Change-Id: I326fd16ee87f49154acf952fe4d36616581a1cee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132432
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/findReplace/findReplace.py 
b/sw/qa/uitest/findReplace/findReplace.py
index 1f6f607ec5b4..3321ebd108c8 100644
--- a/sw/qa/uitest/findReplace/findReplace.py
+++ b/sw/qa/uitest/findReplace/findReplace.py
@@ -107,13 +107,17 @@ class findReplace(UITestCase):
 xSimilarity.executeAction("CLICK", tuple())
 
 regexp = xDialog.getChild("regexp")
-if get_state_as_dict(regexp)['Selected'] == 'false':
-regexp.executeAction("CLICK", tuple())   #regular 
expressions
+regexp.executeAction("CLICK", tuple())
+self.assertEqual("true", get_state_as_dict(regexp)['Selected'])
 replaceall = xDialog.getChild("replaceall")
 replaceall.executeAction("CLICK", tuple())
 #verify
 self.assertEqual(document.Text.String[0:27], "replacedest 
number1 testnot")
 
+# Deselect regex button, otherwise it might affect other tests
+regexp.executeAction("CLICK", tuple())
+self.assertEqual("false", 
get_state_as_dict(regexp)['Selected'])
+
 #tdf116242  ţ ț
 def test_tdf116242_replace_t_with_cedilla(self):
 with self.ui_test.load_file(get_url_for_data_file("tdf116242.odt")) as 
writer_doc:
diff --git a/sw/qa/uitest/findReplace/findSimilarity.py 
b/sw/qa/uitest/findReplace/findSimilarity.py
index 741feb8b50b8..7c532cc20c16 100644
--- a/sw/qa/uitest/findReplace/findSimilarity.py
+++ b/sw/qa/uitest/findReplace/findSimilarity.py
@@ -26,11 +26,6 @@ class findSimilarities(UITestCase):
 searchterm.executeAction("TYPE", 
mkPropertyValues({"TEXT":"seco"}))  #seco
 # check similarities, button similarities, set values = 1; 
close dialog with OK
 
-# Deselect regex before selecting similarity
-xRegexp = xDialog.getChild("regexp")
-if get_state_as_dict(xRegexp)['Selected'] == 'true':
-xRegexp.executeAction("CLICK", tuple())
-
 similarity = xDialog.getChild("similarity")
 if get_state_as_dict(similarity)['Selected'] == 'false':
 similarity.executeAction("CLICK", tuple())
diff --git a/sw/qa/uitest/findReplace/tdf137737.py 
b/sw/qa/uitest/findReplace/tdf137737.py
index 64a155834c85..b2abf3f95acb 100644
--- a/sw/qa/uitest/findReplace/tdf137737.py
+++ b/sw/qa/uitest/findReplace/tdf137737.py
@@ -35,12 +35,16 @@ class tdf137737(UITestCase):
 xSimilarity.executeAction("CLICK", tuple())
 
 xRegexp = xDialog.getChild("regexp")
-if get_state_as_dict(xRegexp)['Selected'] == 'false':
-xRegexp.executeAction("CLICK", tuple())
+xRegexp.executeAction("CLICK", tuple())
+self.assertEqual("true", 
get_state_as_dict(xRegexp)['Selected'])
 
 replaceall = xDialog.getChild("replaceall")
 replaceall.executeAction("CLICK", tuple())
 
+# Deselect regex button, otherwise it might affect other tests
+xRegexp.executeAction("CLICK", tuple())
+self.assertEqual("false", 
get_state_as_dict(xRegexp)['Selected'])
+
 # Without the fix in place, this test would have failed with
 # AssertionError: 0 != 1
 self.assertEqual(0, writer_doc.Endnotes.Count)
diff --git a/sw/qa/uitest/findReplace/tdf144089.py 
b/sw/qa/uitest/findReplace/tdf144089.py
index bd2c89403a96..ae26ffd24a34 100644
--- a/sw/qa/uitest/findReplace/tdf144089.py
+++ b/sw/qa/uitest/findReplace/tdf144089.py
@@ -41,12 +41,16 @@ class tdf144089(UITestCase):
 xSimilarity.executeAction("CLICK", tuple())
 
 xRegexp = xDialog.getChild("regexp")
-if get_state_as_dict(xRegexp)['Selected'] == 'false':
-xRegexp.executeAction("CLICK", tuple())
+xRegexp.executeAction("CLICK", tuple())
+self.assertEqual("true", 
get_state_as_dict(xRegexp)['Selected'])
 
 replaceall = 

[Libreoffice-bugs] [Bug 148311] calc . REQUEST for Copy & Past configurability ......... ( 500 000 asking calc user so far )

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148311

--- Comment #1 from Karl  ---
Created attachment 179259
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179259=edit
500 k asking users

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148311] New: calc . REQUEST for Copy & Past configurability ......... ( 500 000 asking calc user so far )

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148311

Bug ID: 148311
   Summary: calc . REQUEST for Copy & Past configurability
. ( 500 000 asking calc user so far )
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jkl...@dokom.net

Description:
Hi folks,
i do design a small spreasheet for a sour-dough receipe.

This is designet with colours in Lines and rows, because there are som timings,
materials like wheat and water, temperatures.

Some formulas ar to be used in following steps to produce the different stages
of the doug.

When i copy and paste VALUES, FORMULAS, DESCRIPTIONS(text) 
from one to another cell

by using Keys " STRG C " (german) might be CRTL C
and " STRG V " might be " CRTL V "

as well COLOR FORMATTING is copied also !

THe method " STRG SHIFT ALT V " invokes a dialog, on which i can select "
formulas, text, values etc. ) WITHOUT FORMATTING

BUT IT NEED ADDITIONAL CLICKING plus the APES GRIP on several Keys.
(ok i could use a different key - dialog assigning by EXTRAS / OPTIONS.

--

I googeld the question " libreofffice calc copy paste except formats "!

and found roughly 500 000 asking people ( see attatchment graphics )

--
 SO MY REQUEST IS 
==

Have the  " STRG / CRTL + C ---  STRG / CRTL + V " functionality
CONFIGURABLE

SO
it has a DEFAULT OPERATION either " EVERYTHING except FORMATTING "
OR configurable by the user.

OR as a FUNCTION in THE EXTRAS / OPTIONS FUNCTION LIST, 
where it can be assigned to a key.

Best regards
juergen





















Steps to Reproduce:
1.
2.
3.no

Actual Results:
no

Expected Results:
no


Reproducible: Always


User Profile Reset: No



Additional Info:
no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147967] Libreoffice Writer crashes after trying to insert a formula via the formula editor (macOS)

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147967

--- Comment #13 from Gustavo  ---
(In reply to Xisco Faulí from comment #11)
> hi Gustavo, Alex,
> In approximately 10-20 hours from now there will be a new daily build
> available including Noel's blind fix for this issue.
> Could you please download it from
> https://dev-builds.libreoffice.org/daily/master/current.html, install it and
> test it ?
> Thanks in advance

I'll give a try tomorrow

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148310] Firebird: copy complete rows, CLOB field, last character lost

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148310

Julien Nabet  changed:

   What|Removed |Added

 OS|Windows (All)   |All
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |

--- Comment #3 from Julien Nabet  ---
I submitted a patch here to review:
https://gerrit.libreoffice.org/c/core/+/132443

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148310] Firebird: copy complete rows, CLOB field, last character lost

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148310

Julien Nabet  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Good catch!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147868] "[+] Add New sheet" button should be disabled when "Spreadsheet structure" is protected

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147868

--- Comment #7 from Roman Kuznetsov <79045_79...@mail.ru> ---
(In reply to Dmitry INEC from comment #6)
> Created attachment 179160 [details]
> Main menu, in Russian

> Hmm... but look at the menu screenshot.
> 
> The first item talks about "document", but next two talk about "sheet" (in
> singular, not in plural)
> 
> Does it look like mistranslation? Should there be another ticket on i18n
> then?

Yes, please file another ticket about translation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 140267] Improve primary key creation when creating/importing a table

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140267

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||120255

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Agree


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120255
[Bug 120255] [META] Base feature enhancements
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 140267] Improve primary key creation when creating/importing a table

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140267

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 Blocks||120255

--- Comment #1 from Roman Kuznetsov <79045_79...@mail.ru> ---
Agree


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=120255
[Bug 120255] [META] Base feature enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120255] [META] Base feature enhancements

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120255

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Depends on||140267


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=140267
[Bug 140267] Improve primary key creation when creating/importing a table
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - icon-themes/galaxy

2022-04-01 Thread Pedro Pinto Silva (via logerrit)
 icon-themes/galaxy/brand_cp/about.svg |   20 +-
 icon-themes/galaxy/brand_cp/about_inverted.svg|   14 -
 icon-themes/galaxy/brand_cp/flat_logo.svg |4 
 icon-themes/galaxy/brand_cp/intro-highres.png |binary
 icon-themes/galaxy/brand_cp/intro.png |binary
 icon-themes/galaxy/brand_cp/logo-sc.svg   |6 
 icon-themes/galaxy/brand_cp/logo-sc_inverted.svg  |9 -
 icon-themes/galaxy/brand_cp/logo.svg  |   39 ++--
 icon-themes/galaxy/brand_cp/logo_inverted.svg |9 -
 icon-themes/galaxy/brand_cp_snapshot/about.svg|   20 +-
 icon-themes/galaxy/brand_cp_snapshot/about_inverted.svg   |   12 -
 icon-themes/galaxy/brand_cp_snapshot/flat_logo.svg|  126 +++---
 icon-themes/galaxy/brand_cp_snapshot/intro-highres.png|binary
 icon-themes/galaxy/brand_cp_snapshot/intro.png|binary
 icon-themes/galaxy/brand_cp_snapshot/logo-sc.svg  |6 
 icon-themes/galaxy/brand_cp_snapshot/logo-sc_inverted.svg |9 -
 icon-themes/galaxy/brand_cp_snapshot/logo.svg |6 
 icon-themes/galaxy/brand_cp_snapshot/logo_inverted.svg|9 -
 18 files changed, 144 insertions(+), 145 deletions(-)

New commits:
commit a72542df1d15aaac4c8a4772650130fd826a564c
Author: Pedro Pinto Silva 
AuthorDate: Fri Apr 1 16:16:58 2022 +0200
Commit: Andras Timar 
CommitDate: Fri Apr 1 19:29:29 2022 +0200

[cp] Update brand colors

Signed-off-by: Pedro Pinto Silva 
Change-Id: I8568f6f4bd4dd60a2559396ff83aef8f93bc0468
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132433
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 

diff --git a/icon-themes/galaxy/brand_cp/about.svg 
b/icon-themes/galaxy/brand_cp/about.svg
index 1cb919f180aa..d81cb0f02e83 100644
--- a/icon-themes/galaxy/brand_cp/about.svg
+++ b/icon-themes/galaxy/brand_cp/about.svg
@@ -64,7 +64,7 @@
inkscape:collect="always"
id="linearGradient1202">
   
   
   
   
   
 
@@ -169,15 +169,15 @@
  id="stop4574" />
   
   
   
 
   
@@ -198,7 +198,7 @@
  offset="0"
  id="stop4560" />
   
 
@@ -1396,11 +1396,11 @@
  id="path1159"
  sodipodi:nodetypes="ccc" />
   
   
   
   
   
   
   
   
   
   
 
   
@@ -222,7 +222,7 @@
  offset="0"
  id="stop4560" />
   
 
@@ -238,11 +238,11 @@
 
   
   
 
diff --git a/icon-themes/galaxy/brand_cp/flat_logo.svg 
b/icon-themes/galaxy/brand_cp/flat_logo.svg
index e9e09330dcfa..a770a89ed3a7 100644
--- a/icon-themes/galaxy/brand_cp/flat_logo.svg
+++ b/icon-themes/galaxy/brand_cp/flat_logo.svg
@@ -708,10 +708,10 @@
  id="polygon14-7" />
\ No newline at end of file
+ style="fill:#2e1a47;fill-opacity:1" />
diff --git a/icon-themes/galaxy/brand_cp/intro-highres.png 
b/icon-themes/galaxy/brand_cp/intro-highres.png
index 17724c32f2fa..b2f86893405c 100644
Binary files a/icon-themes/galaxy/brand_cp/intro-highres.png and 
b/icon-themes/galaxy/brand_cp/intro-highres.png differ
diff --git a/icon-themes/galaxy/brand_cp/intro.png 
b/icon-themes/galaxy/brand_cp/intro.png
index 4f0937b451e2..3bba49ba72c9 100644
Binary files a/icon-themes/galaxy/brand_cp/intro.png and 
b/icon-themes/galaxy/brand_cp/intro.png differ
diff --git a/icon-themes/galaxy/brand_cp/logo-sc.svg 
b/icon-themes/galaxy/brand_cp/logo-sc.svg
index 18401b2a7284..341760ab4ce9 100644
--- a/icon-themes/galaxy/brand_cp/logo-sc.svg
+++ b/icon-themes/galaxy/brand_cp/logo-sc.svg
@@ -63,7 +63,7 @@
  id="g14">
 
 
   
 
diff --git a/icon-themes/galaxy/brand_cp/logo-sc_inverted.svg 
b/icon-themes/galaxy/brand_cp/logo-sc_inverted.svg
index a0f79104e711..118f676ecd1f 100644
--- a/icon-themes/galaxy/brand_cp/logo-sc_inverted.svg
+++ b/icon-themes/galaxy/brand_cp/logo-sc_inverted.svg
@@ -34,10 +34,9 @@
  id="g14">
 
+   id="path2" />
 
   
 
diff --git a/icon-themes/galaxy/brand_cp/logo.svg 
b/icon-themes/galaxy/brand_cp/logo.svg
index 18401b2a7284..75eb88521bf6 100644
--- a/icon-themes/galaxy/brand_cp/logo.svg
+++ b/icon-themes/galaxy/brand_cp/logo.svg
@@ -1,12 +1,5 @@
 
 http://purl.org/dc/elements/1.1/;
-   xmlns:cc="http://creativecommons.org/ns#;
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
-   xmlns:svg="http://www.w3.org/2000/svg;
-   xmlns="http://www.w3.org/2000/svg;
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
width="128"
height="54"
fill-rule="evenodd"
@@ -17,7 +10,14 @@
viewBox="0 0 3386.6787 1428.7765"
id="svg16"
sodipodi:docname="logo.svg"
-   inkscape:version="1.0.2 (e86c870879, 2021-01-15)">
+   inkscape:version="1.1.2 (0a00cf5339, 2022-02-04)"
+   

[Libreoffice-commits] core.git: Branch 'feature/cib_contract891c' - 2 commits - external/libxmlsec xmlsecurity/Library_xsec_xmlsec.mk xmlsecurity/source

2022-04-01 Thread Michael Stahl (via logerrit)
 external/libxmlsec/xmlsec1-customkeymanage.patch.1| 4648 
--
 xmlsecurity/Library_xsec_xmlsec.mk|1 
 xmlsecurity/source/xmlsec/mscrypt/akmngr.cxx  |  233 
 xmlsecurity/source/xmlsec/mscrypt/akmngr.hxx  |   55 
 xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx |2 
 xmlsecurity/source/xmlsec/mscrypt/xmlsecuritycontext_mscryptimpl.cxx  |2 
 6 files changed, 291 insertions(+), 4650 deletions(-)

New commits:
commit dfb93f42d295f3912b5485401d973137ec9780e6
Author: Michael Stahl 
AuthorDate: Fri Apr 1 18:57:14 2022 +0200
Commit: Michael Stahl 
CommitDate: Fri Apr 1 18:59:04 2022 +0200

xmlsec: somehow deleteing this was dropped from ...

... b56400a1e6db6512543dcb69f1ba97d644e9e859

diff --git a/external/libxmlsec/xmlsec1-customkeymanage.patch.1 
b/external/libxmlsec/xmlsec1-customkeymanage.patch.1
deleted file mode 100644
index d0984cfc06c1..
--- a/external/libxmlsec/xmlsec1-customkeymanage.patch.1
+++ /dev/null
@@ -1,4321 +0,0 @@
-From 082e7399e0396bef9de46ddf8180d253d594a826 Mon Sep 17 00:00:00 2001
-From: Miklos Vajna 
-Date: Fri, 4 Mar 2016 16:19:12 +0100
-Subject: [PATCH] xmlsec1-customkeymanage.patch
-
-Conflicts:
-   include/xmlsec/nss/app.h
-   include/xmlsec/nss/keysstore.h
-   src/nss/Makefile.in
-   src/nss/hmac.c
-   src/nss/keysstore.c
-   src/nss/pkikeys.c
-   src/nss/symkeys.c
-   src/nss/x509.c
-   src/nss/x509vfy.c

- include/xmlsec/nss/Makefile.am  |   3 +
- include/xmlsec/nss/Makefile.in  |   3 +
- include/xmlsec/nss/akmngr.h |  56 +++
- include/xmlsec/nss/app.h|   5 +
- include/xmlsec/nss/ciphers.h|  35 ++
- include/xmlsec/nss/keysstore.h  |   4 +
- include/xmlsec/nss/tokens.h | 182 +
- src/nss/Makefile.am |   2 +
- src/nss/Makefile.in |  20 +
- src/nss/akmngr.c| 384 ++
- src/nss/hmac.c  |   6 +-
- src/nss/keysstore.c | 772 ++--
- src/nss/pkikeys.c   |  81 ++--
- src/nss/symkeys.c   | 705 ++--
- src/nss/tokens.c| 544 +
- src/nss/x509.c  | 491 ++-
- src/nss/x509vfy.c   | 248 
- 22 files changed, 2971 insertions(+), 838 deletions(-)
- create mode 100644 include/xmlsec/nss/akmngr.h
- create mode 100644 include/xmlsec/nss/ciphers.h
- create mode 100644 include/xmlsec/nss/tokens.h
- create mode 100644 src/nss/akmngr.c
- create mode 100644 src/nss/tokens.c
-
-diff --git a/include/xmlsec/nss/Makefile.am b/include/xmlsec/nss/Makefile.am
-index e3521622..997ca7fd 100644
 a/include/xmlsec/nss/Makefile.am
-+++ b/include/xmlsec/nss/Makefile.am
-@@ -10,6 +10,9 @@ bignum.h \
- keysstore.h \
- pkikeys.h \
- x509.h \
-+akmngr.h \
-+tokens.h \
-+ciphers.h \
- $(NULL)
- 
- install-exec-hook:
-diff --git a/include/xmlsec/nss/Makefile.in b/include/xmlsec/nss/Makefile.in
-index ee5c02e3..6d18158c 100644
 a/include/xmlsec/nss/Makefile.in
-+++ b/include/xmlsec/nss/Makefile.in
-@@ -407,6 +407,9 @@ bignum.h \
- keysstore.h \
- pkikeys.h \
- x509.h \
-+akmngr.h \
-+tokens.h \
-+ciphers.h \
- $(NULL)
- 
- all: all-am
-diff --git a/include/xmlsec/nss/akmngr.h b/include/xmlsec/nss/akmngr.h
-new file mode 100644
-index ..80535110
 /dev/null
-+++ b/include/xmlsec/nss/akmngr.h
-@@ -0,0 +1,56 @@
-+/** 
-+ * XMLSec library
-+ *
-+ * This is free software; see Copyright file in the source
-+ * distribution for preciese wording.
-+ * 
-+ * Copyright ..
-+ */
-+#ifndef __XMLSEC_NSS_AKMNGR_H__
-+#define __XMLSEC_NSS_AKMNGR_H__
-+
-+#include 
-+#include 
-+#include 
-+#include 
-+
-+#include 
-+#include 
-+#include 
-+
-+#ifdef __cplusplus
-+extern "C" {
-+#endif /* __cplusplus */ 
-+
-+XMLSEC_CRYPTO_EXPORT xmlSecKeysMngrPtr
-+xmlSecNssAppliedKeysMngrCreate(
-+PK11SlotInfo** slots,
-+  int cSlots,
-+CERTCertDBHandle* handler
-+) ;
-+
-+XMLSEC_CRYPTO_EXPORT int
-+xmlSecNssAppliedKeysMngrSymKeyLoad(
-+  xmlSecKeysMngrPtr   mngr ,
-+  PK11SymKey* symKey
-+) ;
-+
-+XMLSEC_CRYPTO_EXPORT int
-+xmlSecNssAppliedKeysMngrPubKeyLoad(
-+  xmlSecKeysMngrPtr   mngr ,
-+  SECKEYPublicKey*pubKey
-+) ;
-+
-+XMLSEC_CRYPTO_EXPORT int
-+xmlSecNssAppliedKeysMngrPriKeyLoad(
-+  xmlSecKeysMngrPtr   mngr ,
-+  SECKEYPrivateKey*   priKey
-+) ;
-+
-+#ifdef __cplusplus
-+}
-+#endif /* __cplusplus */
-+
-+#endif /* __XMLSEC_NSS_AKMNGR_H__ */
-+
-+
-diff --git a/include/xmlsec/nss/app.h b/include/xmlsec/nss/app.h
-index 93f6c637..03f6aa14 100644
 a/include/xmlsec/nss/app.h
-+++ b/include/xmlsec/nss/app.h
-@@ -22,6 +22,9 @@ extern "C" {
- #include 
- 

[Libreoffice-bugs] [Bug 140405] UI: Speedup scrolling by looking ahead in keyboard buffer to skip redundant screen rendering

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140405

--- Comment #2 from Luboš Luňák  ---
Version: 7.0.4.2? This is most likely outdated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 140405] UI: Speedup scrolling by looking ahead in keyboard buffer to skip redundant screen rendering

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140405

--- Comment #2 from Luboš Luňák  ---
Version: 7.0.4.2? This is most likely outdated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 84845] spam

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=84845

--- Comment #20 from Scoot D Cook  ---
Accounting Def ( https://accountingdef.com/ ) is quick resolution for fix
software errors like quickbooks, sage, xero etc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148266] Firebird: entering several SQL commands directly with delimiter impossible

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148266

--- Comment #5 from bugreport...@protonmail.com ---
in Tools > SQL:

execute block as
begin
  ALTER TABLE "0base" ALTER "eL1" POSITION 1;
  ALTER TABLE "0base" ALTER "eL2" POSITION 2;
  ALTER TABLE "0base" ALTER "eL3" POSITION 3;
end

results in:

1: firebird_sdbc error:
*Dynamic SQL Error
*SQL error code = -104
*Token unknown - line 3, column 3
*ALTER
caused by
'isc_dsql_prepare'

each SQL command alone works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148310] Firebird: copy complete rows, CLOB field, last character lost

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148310

--- Comment #1 from bugreport...@protonmail.com ---
Created attachment 179258
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179258=edit
example

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148310] New: Firebird: copy complete rows, CLOB field, last character lost

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148310

Bug ID: 148310
   Summary: Firebird: copy complete rows, CLOB field, last
character lost
   Product: LibreOffice
   Version: 7.2.6.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bugreport...@protonmail.com

Description:
When copying a complete row by clicking the row header with the left mouse
button then holding down the button and draging the 
mouse, the cursor will change to a symbol with a + sign. Letting go the row is
copied to the last entry of the table.
For CLOB Field Types, with each copy the last character is lost.


I did not notice this in versions before 7.2.6.2 (x64)


Version: 7.2.6.2 (x64) / LibreOffice Community
Build ID: b0ec3a565991f7569a5a7f5d24fed7f52653d754
CPU threads: 6; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

Steps to Reproduce:
1.copy a row with CLOB field
2.
3.

Actual Results:
last character lost

Expected Results:
full copy


Reproducible: Always


User Profile Reset: Yes



Additional Info:
See tabelle1 in copy-2022-04-01-18-31-38.odb.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

--- Comment #20 from Alexander Van den Panhuysen 
 ---
I switched both off, quit LO and started up again, then when I opened an
existing Calc, it opens without a problem, but then after having closed that
Calc, again crashing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142498] UI: Highlight the found search text in cell

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142498

Michael Warner  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #3 from Michael Warner  ---
More than one person agrees that this enhancement would be useful. Let's go
ahead and mark it as new.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-04-01 Thread Alain Romedenne (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 43216ed5ddb6d8dc38d505cb63ca9b894be5f2c0
Author: Alain Romedenne 
AuthorDate: Fri Apr 1 17:39:29 2022 +0100
Commit: Gerrit Code Review 
CommitDate: Fri Apr 1 18:39:29 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 6bc28e0b9909efc3052105193564ec4161954d60
  - Some SF services lack pre-requisite note

Change-Id: Idfd233430aabb5815f1f1db625ca48fd2e613b15
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131873
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/helpcontent2 b/helpcontent2
index 6e7aa9a6c7a4..6bc28e0b9909 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6e7aa9a6c7a40149d05a611cee896c582a9952f7
+Subproject commit 6bc28e0b9909efc3052105193564ec4161954d60


[Libreoffice-commits] help.git: source/text

2022-04-01 Thread Alain Romedenne (via logerrit)
 source/text/sbasic/shared/03/lib_ScriptForge.xhp |2 ++
 source/text/sbasic/shared/03/sf_base.xhp |3 +++
 source/text/sbasic/shared/03/sf_calc.xhp |3 +++
 source/text/sbasic/shared/03/sf_chart.xhp|3 +++
 source/text/sbasic/shared/03/sf_database.xhp |3 +++
 source/text/sbasic/shared/03/sf_document.xhp |3 +++
 source/text/sbasic/shared/03/sf_form.xhp |3 +++
 source/text/sbasic/shared/03/sf_formcontrol.xhp  |4 
 source/text/sbasic/shared/03/sf_writer.xhp   |5 -
 9 files changed, 28 insertions(+), 1 deletion(-)

New commits:
commit 6bc28e0b9909efc3052105193564ec4161954d60
Author: Alain Romedenne 
AuthorDate: Wed Mar 23 18:00:17 2022 +0100
Commit: Alain Romedenne 
CommitDate: Fri Apr 1 18:39:25 2022 +0200

Some SF services lack pre-requisite note

Change-Id: Idfd233430aabb5815f1f1db625ca48fd2e613b15
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/131873
Tested-by: Jenkins
Reviewed-by: Rafael Lima 

diff --git a/source/text/sbasic/shared/03/lib_ScriptForge.xhp 
b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
index 2b7e50b6e..3dccd6a3c 100644
--- a/source/text/sbasic/shared/03/lib_ScriptForge.xhp
+++ b/source/text/sbasic/shared/03/lib_ScriptForge.xhp
@@ -25,9 +25,11 @@
 
   
 ScriptForge 
libraries build up an extensible collection of macro scripting resources for 
%PRODUCTNAME to be invoked from Basic macros or Python scripts.
+  
  Basic macros 
require to load ScriptForge library using the following 
statement:   
GlobalScope.BasicLibraries.loadLibrary("ScriptForge")
 Python scripts require an import from scriptforge 
module:
   from scriptforge import CreateScriptService
 
+  
   To learn more about how to create and 
execute Python scripts using the ScriptForge library, read 
the help page Creating Python Scripts with ScriptForge.
 
   Invoking ScriptForge services
diff --git a/source/text/sbasic/shared/03/sf_base.xhp 
b/source/text/sbasic/shared/03/sf_base.xhp
index 43b28fa3e..a619a53e1 100644
--- a/source/text/sbasic/shared/03/sf_base.xhp
+++ b/source/text/sbasic/shared/03/sf_base.xhp
@@ -41,6 +41,9 @@
   Refer to the Document service to learn more about methods 
and properties that can be used to manage %PRODUCTNAME documents.
 
   Service invocation
+  Before using the 
Base service the ScriptForge library 
needs to be loaded or imported:
+  
+
   
   The Base service can 
be invoked in a variety of ways. The code snippet below uses the method 
CreateBaseDocument from the UI service to 
create a new Base file.
   Note that in all 
examples the object oDoc is an instance of the 
Base service.
diff --git a/source/text/sbasic/shared/03/sf_calc.xhp 
b/source/text/sbasic/shared/03/sf_calc.xhp
index 54b50a279..c191c0baa 100644
--- a/source/text/sbasic/shared/03/sf_calc.xhp
+++ b/source/text/sbasic/shared/03/sf_calc.xhp
@@ -43,6 +43,9 @@
   This help page describes methods and 
properties that are applicable only to Calc documents.
 
   Service invocation
+  Before using the 
Calc service the ScriptForge library 
needs to be loaded or imported:
+  
+
   The 
Calc service is closely related to the UI 
service of the ScriptForge library. Below are a few examples 
of how the Calc service can be invoked.
   
   The code snippet 
below creates a Calc service instance that corresponds to 
the currently active Calc document.
diff --git a/source/text/sbasic/shared/03/sf_chart.xhp 
b/source/text/sbasic/shared/03/sf_chart.xhp
index a5f6d22bd..ca1cc338f 100644
--- a/source/text/sbasic/shared/03/sf_chart.xhp
+++ b/source/text/sbasic/shared/03/sf_chart.xhp
@@ -49,6 +49,9 @@
   The Chart service 
primarily uses the user-defined name to access a chart object. If it does not 
exist, than the internal name is used.
 
   Service invocation
+  Before using the 
Chart service the ScriptForge library 
needs to be loaded or imported:
+  
+
   The 
Chart service is instantiated from a Calc 
service instance either using the Charts or 
CreateChart methods.
   
   The example below 
creates a Chart service instance from an existing chart in 
the current Calc document:
diff --git a/source/text/sbasic/shared/03/sf_database.xhp 
b/source/text/sbasic/shared/03/sf_database.xhp
index f788aa48d..dc76976d8 100644
--- a/source/text/sbasic/shared/03/sf_database.xhp
+++ b/source/text/sbasic/shared/03/sf_database.xhp
@@ -45,6 +45,9 @@
 To make SQL statements 
more readable, you may use square brackets "[ ]" to enclose names of tables, 
queries and fields instead of using other enclosing characters that may be 
exclusive to certain Relational Database Management Systems (RDBMS). But beware 
that enclosing characters are mandatory in this context.
 
 Service invocation
+Before using the 
Database service the ScriptForge library 
needs to be loaded or imported:
+
+
 
 To 
create a instance of the Database service you can use the 
CreateScriptService method:
 
diff --git 

[Libreoffice-bugs] [Bug 148309] Mail-merging a complex document with many data records significantly slower after fix for bug 144565

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148309

Thorsten Behrens (allotropia)  changed:

   What|Removed |Added

 CC||t...@libreoffice.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148307] When inserting a new row or column into a table, LO changes the font & size of the text in the selected rows/ccolumns back to style default.

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148307

Rainer Bielefeld Retired  changed:

   What|Removed |Added

   Keywords||regression

--- Comment #3 from Rainer Bielefeld Retired  
---
e) Still REPRODUCIBLE with Server Installation of Version: 7.4.0.0.alpha0+
(x64)  
   Build ID b000d964fcc8849d10576bf3539bde7729db2eb1
   CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
   Locale: de-DE (de_DE); UI: en-US  |  Calc: CL  |  Auto Colibre Theme  |
   Special devUserProfile
f) Query

shows a possible DUP: 
"Bug 126008 - TABLES STYLES: If you insert a row or column (with cursor in a
cell), the formatting of the whole table changes"

b1) Regression due to (b)

@Chuck Lindeberg
Your opinion concerning my DUP suspect?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148309] Mail-merging a complex document with many data records significantly slower after fix for bug 144565

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148309

Michael Weghorn  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||4565

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148309] Mail-merging a complex document with many data records significantly slower after fix for bug 144565

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148309

Michael Weghorn  changed:

   What|Removed |Added

 CC||michael.st...@allotropia.de

--- Comment #2 from Michael Weghorn  ---
Win bibisect repo for 7.4 shows that this started with


commit 42448f48bb48a13d6618a181b12840db6d85c574
Author: Michael Stahl
Date:   Thu Dec 16 13:36:46 2021 +0100

tdf#144565 sw_redlinehide: fix mailmerge when flys anchored at last node

The InsertPageBreak() calls SplitNode() which is not ideal as the flys
anchored at the last node of the document may end up anchored to the
newly inserted node and this one will be removed again a bit further on:
  GetNodes().Delete( aDelIdx, iDelNodes );

... which is what crashes, when the SwNodeIndex of the anchor is moved
hard to a different node, which causes inconsistencies such as:

sw/source/core/text/txtfrm.cxx:1263: TextFrameIndex
SwTextFrame::MapModelToView(const SwTextNode*, sal_Int32) const: Assertion
`static_cast(const_cast(SwFrame::GetDep()))
== pNode' failed.

Instead, always use AppendTextNode() and then set the break item
directly, which even simplifies the code.

(reportedly a regression from 166b5010b402a41b192b1659093a25acf9065fd9
 although i wasn't able to find an earlier version that didn't crash
 in some way)

Change-Id: I4cac74fc86fc505f62b14cf0d7a7f9689c7402ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126921
Tested-by: Jenkins
Reviewed-by: Michael Stahl



Adding CC: to Michael Stahl

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148309] Mail-merging a complex document with many data records significantly slower after fix for bug 144565

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148309

Michael Weghorn  changed:

   What|Removed |Added

 CC||m.wegh...@posteo.de

--- Comment #1 from Michael Weghorn  ---
Created attachment 179257
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179257=edit
sample database containing 1000 dummy entries

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148309] New: Mail-merging a complex document with many data records significantly slower after fix for bug 144565

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148309

Bug ID: 148309
   Summary: Mail-merging a complex document with many data records
significantly slower after fix for bug 144565
   Product: LibreOffice
   Version: 7.4.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m.wegh...@posteo.de

Created attachment 179256
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179256=edit
sample doc for mail merge

With the fix for tdf#144565 in place, performing a mail merge of the attached
document with many data records has become significantly slower.

# Steps to reproduce

1) open attached sample document "sample_mail_merge.odt"
2) run mail merge wizard ("Tools" -> "Mail merge wizard")
3) use the attached ODS file "1000ds.ods" that contains 1000 records as
database ("Exchange Database", then select the file)
4) finish mail merge wizard
5) select "Save Merged Documents" in the mail merge toolbar
6) leave default selection ("Save as a single large document") and press "Save
Documents"
7) wait for mail merge to finish

# Actual behavior:

With the fix for tdf#144565 in place, this takes a long time.

Using commit dfaa8725a4762de874fb144f8a370b9f42f3920f (source
sha:b8f68233b8dc5a009396141fba6e47867e70f342) from the 7.4 bibisect repository
in my Windows VM, the first 200-300 records went pretty fast, but then it
slowed down significantly. After 20 minutes, it was at 775 out of 1000,
advancing by 1 every few seconds. (I didn't wait until the end.)

## Expected behavior

Mail merge should be reasonably fast, as used to be the case earlier.
With commit 77d0c49a8b9ee59493696438d51cff11e107c3b2 (source
sha:42448f48bb48a13d6618a181b12840db6d85c574) of the bibisect repository, the
dialog asking where to save the file appeared after ~1.5 min.

## Additional information

Initially observed with mail merge from the WollMux extension [1] in a 6.4
based LO version that contains a backport of the fix for tdf#144565. The user
reported that it took ~10 min with the original document without the fix for
tdf#144565 in place, and 90-100 min afterwards.

[1] https://github.com/WollMux/WollMux/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148307] When inserting a new row or column into a table, LO changes the font & size of the text in the selected rows/ccolumns back to style default.

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148307

Rainer Bielefeld Retired  changed:

   What|Removed |Added

 CC||LibreOffice@bielefeldundbus
   ||s.de

--- Comment #2 from Rainer Bielefeld Retired  
---
REPRODUCIBLE with reporter's sample document and Installation of Version:
7.3.0.3 (x64) Build ID a69ca51ded25f3eefd52d7bf9a5fad8c90b87951
CPU threads: 12; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
| Locale: de-DE (de_DE); UI: de-DE | Calc: threaded | ElementaryTheme | My
normal User Profile:
1. open document
2. click A5 behind "Research"
   » caret flashes behind "h" of "Research"
3. ˋRightclick caret position  → Insert Row →  Rows Belowˊ
   » Row inserted, Font for complete table changes from 
 'Arial 12'  to 'Liberation Serif 12'

Additional info:

a) Font will not switch back with  (several times)
b) Was still ok with Server Installation of Version:  4.0.0.3 WIN10
   Build-ID  7545bee9c2a0782548772a21bc84a9dcc583b89;  Special devUserProfile
c) Already REPRODUCIBLE with Server Installation of Version: 6.0.7.3 (x64)
   Build-ID dc89aa7a9eabfd848af146d5086077aeed2ae4a5; CPU-Threads: 12; 
   BS: Windows 10.0; UI-Render: GL; Gebietsschema: de-DE (de_DE); 
   Calc: CL, Special devUserProfile
d) Problem for me also appears when I delete Row ein step 3

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: drawinglayer/source emfio/qa

2022-04-01 Thread Bartosz Kosiorek (via logerrit)
 drawinglayer/source/tools/emfphelperdata.cxx   |  180 -
 drawinglayer/source/tools/emfphelperdata.hxx   |3 
 emfio/qa/cppunit/emf/EmfImportTest.cxx |   66 +
 emfio/qa/cppunit/emf/data/TestEmfPlusGetDC.emf |binary
 emfio/qa/cppunit/emf/data/TestEmfPlusSave.emf  |binary
 5 files changed, 184 insertions(+), 65 deletions(-)

New commits:
commit f26ba7f7c951164cc8677e55fa73081e16659147
Author: Bartosz Kosiorek 
AuthorDate: Fri Apr 1 11:43:30 2022 +0200
Commit: Bartosz Kosiorek 
CommitDate: Fri Apr 1 17:24:07 2022 +0200

tdf#147818 EMF+ Fix restoring clipping states

With previous implementation the clipping restoring with 
EmfPlusRecordTypeRestore
was implemented wrongly as it is only taken to account
the shape of clipping (state.getClipPolyPolygon) and doesn't
take if clipping was even enabled (state.getClipPolyPolygonActive).

Additionally the changing states should be made by using method:
wmfemfhelper::HandleNewClipRegion() and not directly.

The similar implementation was applied also to EmfPlusRecordTypeGetDC.

Additionally the clipping for
   EmfPlusRecordTypeSetClipRect
   EmfPlusRecordTypeSetClipPath
   EmfPlusRecordTypeSetClipRegion
was fixed, as initially the clipping is disabled 
(state.getClipPolyPolygonActive)
and the clipping shape is empty (state.getClipPolyPolygon).
It means that combination other than EmfPlusCombineModeReplace,
was not working correctly.

With this implementation, if Clipping is disabled, then treat clip combining
in special way.

Change-Id: I258bda64e8bfdade7f47ffc7518bf04b7340344f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132415
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/drawinglayer/source/tools/emfphelperdata.cxx 
b/drawinglayer/source/tools/emfphelperdata.cxx
index 447686167837..e60f8815ef79 100644
--- a/drawinglayer/source/tools/emfphelperdata.cxx
+++ b/drawinglayer/source/tools/emfphelperdata.cxx
@@ -486,18 +486,32 @@ namespace emfplushelper
 map[ index ] = state;
 }
 
-void EmfPlusHelperData::GraphicStatePop(GraphicStateMap& map, sal_Int32 
index, wmfemfhelper::PropertyHolder& rState)
+void EmfPlusHelperData::GraphicStatePop(GraphicStateMap& map, sal_Int32 
index)
 {
-GraphicStateMap::iterator iter = map.find( index );
+GraphicStateMap::iterator iter = map.find(index);
 
-if ( iter != map.end() )
+if (iter != map.end())
 {
 wmfemfhelper::PropertyHolder state = iter->second;
 
 maWorldTransform = state.getTransformation();
-rState.setClipPolyPolygon( state.getClipPolyPolygon() );
+if (state.getClipPolyPolygonActive())
+{
+SAL_INFO("drawinglayer.emf",
+"EMF+\t Restore clipping region to saved in index: " 
<< index);
+wmfemfhelper::HandleNewClipRegion(state.getClipPolyPolygon(), 
mrTargetHolders,
+  mrPropertyHolders);
+}
+else
+{
+SAL_INFO("drawinglayer.emf", "EMF+\t Disable clipping");
+wmfemfhelper::HandleNewClipRegion(::basegfx::B2DPolyPolygon(), 
mrTargetHolders,
+  mrPropertyHolders);
+}
 mappingChanged();
-SAL_INFO("drawinglayer.emf", "EMF+\t\tStack index: " << index << " 
found, maWorldTransform: " << maWorldTransform);
+SAL_INFO("drawinglayer.emf",
+"EMF+\t\tStack index: " << index
+<< " found, maWorldTransform: " << 
maWorldTransform);
 }
 }
 
@@ -1000,14 +1014,8 @@ namespace emfplushelper
 }
 case EmfPlusCombineModeIntersect:
 {
-if (leftPolygon.count())
-{
-aClippedPolyPolygon = 
basegfx::utils::clipPolyPolygonOnPolyPolygon(
-leftPolygon,
-rightPolygon,
-true,
-false);
-}
+aClippedPolyPolygon = basegfx::utils::clipPolyPolygonOnPolyPolygon(
+leftPolygon, rightPolygon, true, false);
 break;
 }
 case EmfPlusCombineModeUnion:
@@ -1080,8 +1088,18 @@ namespace emfplushelper
 
 if (bIsGetDCProcessing)
 {
-SAL_INFO("drawinglayer.emf", "EMF+\t reset the current 
clipping region for the world space to infinity.");
-wmfemfhelper::HandleNewClipRegion(::basegfx::B2DPolyPolygon(), 
mrTargetHolders, mrPropertyHolders);
+if (aGetDCState.getClipPolyPolygonActive())
+{
+SAL_INFO("drawinglayer.emf", "EMF+\t Restore region to 
GetDC saved");
+

[Libreoffice-bugs] [Bug 147982] On macOS Monterey LibreOffice 7.3 crashes about every day. This was also with previous versions of LibreOffice.

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147982

--- Comment #19 from Alex Thurgood  ---
@Alexander : try switching off both automatic document saving and update
verification and restart LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147967] Libreoffice Writer crashes after trying to insert a formula via the formula editor (macOS)

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147967

--- Comment #12 from Alex Thurgood  ---
(In reply to Xisco Faulí from comment #11)
> hi Gustavo, Alex,
> In approximately 10-20 hours from now there will be a new daily build
> available including Noel's blind fix for this issue.
> Could you please download it from
> https://dev-builds.libreoffice.org/daily/master/current.html, install it and
> test it ?

Just my luck, I downloaded this morning's dev build :-)
If I remember over the weekend, I'll give the latest version a spin.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa writerfilter/source

2022-04-01 Thread Justin Luth (via logerrit)
 sw/qa/extras/ooxmlexport/data/tdf147861_customField.docx |binary
 sw/qa/extras/ooxmlexport/ooxmlexport17.cxx   |   19 +++
 sw/qa/extras/ooxmlexport/ooxmlexport8.cxx|2 -
 writerfilter/source/dmapper/DomainMapper_Impl.cxx|   25 ++-
 writerfilter/source/dmapper/DomainMapper_Impl.hxx|4 ++
 5 files changed, 48 insertions(+), 2 deletions(-)

New commits:
commit 0bb206bb444bebc7726bdda4c8955de9934eb160
Author: Justin Luth 
AuthorDate: Sat Mar 12 11:11:01 2022 +0200
Commit: Miklos Vajna 
CommitDate: Fri Apr 1 17:12:02 2022 +0200

tdf#147861 writerfilter: use GetFieldResult, not current DocProperty

Import DOCX and RTF DocProperty fields as "fixed" if the displayed
text does not match the File - Properties - Custom variable's content.

Otherwise LO will automatically update the field and show the wrong
contents (because MS Word requires the user to manually refresh via F9).

(cherry picked from commit c4cb1d1dd581a5f120d9cf8b1d4274ec38f3eabe)

Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport17.cxx

Change-Id: Id5d3d0794e81b13465c5e824f1e994f563e62c1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132401
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ooxmlexport/data/tdf147861_customField.docx 
b/sw/qa/extras/ooxmlexport/data/tdf147861_customField.docx
new file mode 100644
index ..70071fa7e8a3
Binary files /dev/null and 
b/sw/qa/extras/ooxmlexport/data/tdf147861_customField.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
index be2f031c51d6..ee875f24acb9 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport17.cxx
@@ -21,6 +21,7 @@
 #include 
 
 #include 
+#include 
 
 constexpr OUStringLiteral DATA_DIRECTORY = u"/sw/qa/extras/ooxmlexport/data/";
 
@@ -51,6 +52,24 @@ DECLARE_OOXMLEXPORT_TEST(testTdf135164_cancelledNumbering, 
"tdf135164_cancelledN
 CPPUNIT_ASSERT_EQUAL(OUString("i"), getProperty(xPara, 
"ListLabelString"));
 }
 
+DECLARE_OOXMLEXPORT_TEST(testTdf147861_customField, 
"tdf147861_customField.docx")
+{
+// These should each be specific values, not a shared DocProperty
+getParagraph(1, "CustomEditedTitle"); // edited
+// A couple of nulls at the end of the string thwarted all attemps at an 
"equals" comparison.
+CPPUNIT_ASSERT(getParagraph(2)->getString().startsWith(" INSERT Custom 
Title here"));
+getParagraph(3, "My Title"); // edited
+
+// Verify that these are fields, and not just plain text
+uno::Reference xTextFieldsSupplier(mxComponent, 
uno::UNO_QUERY);
+auto xFieldsAccess(xTextFieldsSupplier->getTextFields());
+uno::Reference 
xFields(xFieldsAccess->createEnumeration());
+uno::Reference xField(xFields->nextElement(), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(OUString("CustomEditedTitle"), 
xField->getPresentation(false));
+// The " (fixed)" part is unnecessary, but it must be consistent across a 
round-trip
+CPPUNIT_ASSERT_EQUAL(OUString("DocInformation:Title (fixed)"), 
xField->getPresentation(true));
+}
+
 DECLARE_OOXMLEXPORT_EXPORTONLY_TEST(testTdf135906, "tdf135906.docx")
 {
 // just test round-tripping. The document was exported as corrupt and 
didn't re-load.
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
index 59d713fdfb04..c65d279739ba 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport8.cxx
@@ -147,7 +147,7 @@ DECLARE_OOXMLEXPORT_TEST(testN751117, "n751117.docx")
 DECLARE_OOXMLEXPORT_TEST(testFdo74745, "fdo74745.docx")
 {
 uno::Reference paragraph = getParagraph(3);
-CPPUNIT_ASSERT_EQUAL(OUString("09/02/14"), paragraph->getString());
+CPPUNIT_ASSERT_EQUAL(OUString("09/02/2014"), paragraph->getString());
 }
 
 DECLARE_OOXMLEXPORT_TEST(testFdo81486, "fdo81486.docx")
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index df943fb1dda7..2e1d13d5de17 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4723,6 +4723,11 @@ void 
FieldContext::SetTextField(uno::Reference const& xTextFie
 m_xTextField = xTextField;
 }
 
+void FieldContext::CacheVariableValue(const uno::Any& rAny)
+{
+rAny >>= m_sVariableValue;
+}
+
 void FieldContext::AppendCommand(std::u16string_view rPart)
 {
 m_sCommand += rPart;
@@ -5356,6 +5361,9 @@ void DomainMapper_Impl::handleAuthor
 }
 }
 }
+else
+
pContext->CacheVariableValue(xUserDefinedProps->getPropertyValue(rFirstParam));
+
 OUString sServiceName("com.sun.star.text.TextField.");
 bool bIsCustomField = false;
 if(sFieldServiceName.isEmpty())
@@ -6975,7 +6983,22 @@ void 

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sw/qa sw/source

2022-04-01 Thread Justin Luth (via logerrit)
 sw/qa/extras/ww8export/ww8export3.cxx |3 ++-
 sw/source/filter/ww8/ww8par5.cxx  |   23 ---
 2 files changed, 22 insertions(+), 4 deletions(-)

New commits:
commit 2c7e4d31662add89f0fa4c7a8e007caaacadc0b7
Author: Justin Luth 
AuthorDate: Fri Mar 11 14:55:00 2022 +0200
Commit: Miklos Vajna 
CommitDate: Fri Apr 1 17:11:45 2022 +0200

tdf#147861 ww8import: solve TODO: not fixed-field if equal

Do not mark the field as "fixed" if the displayed string
matches the internal variable. This allows changing the variable
within LO and having the field update to reflect that change,
which is the way that these fields are supposed to work
(although in MS Word they only update manually via F9
 which is why some needed to be fixed in the first place).

(cherry picked from commit f5c2085e70c40370a790868d4683133a41e6599d)

Change-Id: Id359cbf0b48e63bddab3e45871326988467d7ddb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132400
Tested-by: Miklos Vajna 
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/ww8export/ww8export3.cxx 
b/sw/qa/extras/ww8export/ww8export3.cxx
index 80f0daf11f93..0ed99f7e64dc 100644
--- a/sw/qa/extras/ww8export/ww8export3.cxx
+++ b/sw/qa/extras/ww8export/ww8export3.cxx
@@ -104,7 +104,8 @@ DECLARE_WW8EXPORT_TEST(testTdf147861_customField, 
"tdf147861_customField.doc")
 {
 // These should each be specific values, not a shared DocProperty
 getParagraph(1, "CustomEditedTitle"); // edited
-getParagraph(2, " INSERT Custom Title here"); // matches current 
DocProperty
+// A couple of \x0\x0 at the end of the import variable thwart an equality 
comparison
+CPPUNIT_ASSERT(getParagraph(2)->getString().startsWith(" INSERT Custom 
Title here"));
 getParagraph(3, "My Title"); // edited
 
 // Verify that these are fields, and not just plain text
diff --git a/sw/source/filter/ww8/ww8par5.cxx b/sw/source/filter/ww8/ww8par5.cxx
index 76461ab6c86a..99841fe175fe 100644
--- a/sw/source/filter/ww8/ww8par5.cxx
+++ b/sw/source/filter/ww8/ww8par5.cxx
@@ -1650,13 +1650,30 @@ eF_ResT SwWW8ImplReader::Read_F_DocInfo( WW8FieldDesc* 
pF, OUString& rStr )
 // In other words, Word lets the field to be out of sync with the 
controlling variable.
 // Marking as FIXEDFLD solves the automatic replacement problem, 
but of course prevents
 // Writer from making any changes, even on an F9 refresh.
-// TODO: If the field already matches the DocProperty, no need to 
mark as fixed.
 // TODO: Extend LO to allow a linked field that doesn't 
automatically update.
+IDocumentContentOperations& 
rIDCO(m_rDoc.getIDocumentContentOperations());
 const auto pType(static_cast(
 
m_rDoc.getIDocumentFieldsAccess().GetSysFieldType(SwFieldIds::DocInfo)));
 const OUString sDisplayed = GetFieldResult(pF);
-SwDocInfoField aField(pType, DI_CUSTOM | DI_SUB_FIXED | nReg, 
aDocProperty, sDisplayed);
-m_rDoc.getIDocumentContentOperations().InsertPoolItem(*m_pPaM, 
SwFormatField(aField));
+SwDocInfoField aField(pType, DI_CUSTOM | nReg, aDocProperty);
+
+// If text already matches the DocProperty var, then safe to treat 
as refreshable field.
+OUString sVariable = aField.ExpandField(/*bCache=*/false, nullptr);
+if (sDisplayed.getLength() != sVariable.getLength())
+{
+sal_Int32 nLen = sVariable.indexOf('\x0');
+if (nLen >= 0)
+sVariable = sVariable.copy(0, nLen);
+}
+if (sDisplayed == sVariable)
+rIDCO.InsertPoolItem(*m_pPaM, SwFormatField(aField));
+else
+{
+// They don't match, so use a fixed field to prevent LO from 
altering the contents.
+SwDocInfoField aFixedField(pType, DI_CUSTOM | DI_SUB_FIXED | 
nReg, aDocProperty,
+   sDisplayed);
+rIDCO.InsertPoolItem(*m_pPaM, SwFormatField(aFixedField));
+}
 
 return eF_ResT::OK;
 }


[Libreoffice-bugs] [Bug 147828] "Select to Next Sentence" does not work properly when the current sentence ends with a period and the next sentence does not have a capital letter at the beginning of t

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147828

--- Comment #11 from V Stuart Foote  ---
Michael S. did the last substantive rework of the view shell and cursor mgmt
here.
But unclear if we are using CLDR and ICU libs to respond fully to locale--what
is happening for CJK and CTL users where "sentence" and word breaks can be much
more complex. Are the break iterators appropriate?

=-ref-=

https://opengrok.libreoffice.org/xref/core/sw/inc/breakit.hxx?a=true=06bd8d70=60#62

https://opengrok.libreoffice.org/xref/core/sw/source/core/crsr/swcrsr.cxx?a=true=ec1c4c49=1550#1558

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147828] "Select to Next Sentence" does not work properly when the current sentence ends with a period and the next sentence does not have a capital letter at the beginning of t

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147828

--- Comment #10 from V Stuart Foote  ---
See comments around OOo era bug i24098 [1] when the sentence break iterators
were being implemented in 2004. Not sure we've ever refactored to keep them
current with ICU lib offerings.

=-ref-=

[1] https://bz.apache.org/ooo/show_bug.cgi?id=24098#c12

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148147] Calc freezes on "Sheet" menu after selecting multiple row ranges

2022-04-01 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148147

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org
   Keywords||perf

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: pyuno/source

2022-04-01 Thread Stephan Bergmann (via logerrit)
 pyuno/source/module/pyuno.cxx |   20 +++-
 1 file changed, 15 insertions(+), 5 deletions(-)

New commits:
commit b3b18ed165b7bab80e15f130fe7826595460539c
Author: Stephan Bergmann 
AuthorDate: Fri Apr 1 14:27:52 2022 +0200
Commit: Stephan Bergmann 
CommitDate: Fri Apr 1 16:56:58 2022 +0200

Don't make UNO calls from PyThreadAttached regions (i.e., with the GIL 
locked)

...which caused e.g. UITest_writer_tests3 to occasionally hang with the
python.bin process thread 1 at

>   File "sw/qa/uitest/writer_tests3/insertPageFooter.py", line 30, in 
delete_footer
[...]

i.e.,

> #4  ___pthread_cond_wait at 
/usr/src/debug/glibc-2.35-4.fc36.x86_64/nptl/pthread_cond_wait.c:618
> #5  0x7ff9d6ad9c43 in cppu_threadpool::JobQueue::enter(void const*, 
bool) at cppu/source/threadpool/jobqueue.cxx:72
> #6  0x7ff9d6ae8e79 in 
cppu_threadpool::ThreadPool::enter(rtl::ByteSequence const&, void const*) at 
cppu/source/threadpool/threadpool.cxx:303
> #7  0x7ff9d6ae9278 in uno_threadpool_enter(uno_ThreadPool, void**) at 
cppu/source/threadpool/threadpool.cxx:407
> #8  0x7ff9c7d016eb in binaryurp::Bridge::makeCall(rtl::OUString 
const&, com::sun::star::uno::TypeDescription const&, bool, 
std::__debug::vector 
>&&, binaryurp::BinaryAny*, std::__debug::vector >*) at binaryurp/source/bridge.cxx:604
> #9  0x7ff9c7d322fc in 
binaryurp::Proxy::do_dispatch_throw(_typelib_TypeDescription const*, void*, 
void**, _uno_Any**) const at binaryurp/source/proxy.cxx:168
> #10 0x7ff9c7d338cb in 
binaryurp::Proxy::do_dispatch(_typelib_TypeDescription const*, void*, void**, 
_uno_Any**) const at binaryurp/source/proxy.cxx:101
> #11 0x7ff9d63222e0 in 
cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, 
typelib_TypeDescription const*, typelib_TypeDescriptionReference*, sal_Int32, 
typelib_MethodParameter*, void**, void**, void**, sal_uInt64*) at 
bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:191
> #12 0x7ff9d6322b59 in cpp_vtable_call(sal_Int32, sal_Int32, void**, 
void**, void**, sal_uInt64*) at 
bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:389
> #13 0x7ff9d63336ca in privateSnippetExecutor at 
instdir/program/libgcc3_uno.so
> #14 0x7ff9d6241f38 in (anonymous 
namespace)::ImplIntrospectionAccess::hasByName(rtl::OUString const&) at 
stoc/source/inspect/introspection.cxx:1114
> #15 0x7ff9d6b856b2 in pyuno::PyUNO_getattr(PyObject*, char*) at 
pyuno/source/module/pyuno.cxx:1392
[...]

doing a remote call to soffice.bin with GIL locked, and thread 4 at

> #6  0x7ff9e51efa28 in take_gil at 
workdir/UnpackedTarball/python3/Python/ceval_gil.h:207
> #7  0x7ff9e51f00d3 in PyEval_AcquireThread at 
workdir/UnpackedTarball/python3/Python/ceval.c:316
> #8  0x7ff9d6b9b1e8 in pyuno::Adapter::invoke(rtl::OUString const&, 
com::sun::star::uno::Sequence const&, 
com::sun::star::uno::Sequence&, 
com::sun::star::uno::Sequence&) at 
pyuno/source/module/pyuno_adapter.cxx:181
> #9  0x7ff9d632b3e4 in gcc3::callVirtualMethod(void*, unsigned int, 
void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, 
unsigned long*, double*) at 
bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77
> #10 0x7ff9d632a4f1 in 
cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, 
bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, 
sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**) at 
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
> #11 0x7ff9d632a9e6 in 
bridges::cpp_uno::shared::unoInterfaceProxyDispatch(uno_Interface*, 
typelib_TypeDescription const*, void*, void**, uno_Any**) at 
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
> #12 0x7ff9d621384a in stoc_invadp::(anonymous 
namespace)::AdapterImpl::invoke at 
stoc/source/invocation_adapterfactory/iafactory.cxx:457
> #13 stoc_invadp::adapter_dispatch(uno_Interface*, typelib_TypeDescription 
const*, void*, void**, uno_Any**) at 
stoc/source/invocation_adapterfactory/iafactory.cxx:605
> #14 0x7ff9c7d1a7db in 
binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, 
std::__debug::vector 
>*) const at include/typelib/typedescription.hxx:155
> #15 0x7ff9c7d1d65f in binaryurp::IncomingRequest::execute() const at 
binaryurp/source/incomingrequest.cxx:78
> #16 0x7ff9c7d33ad3 in binaryurp::(anonymous 
namespace)::request(void*) at 
~/gcc/trunk/inst/include/c++/12.0.1/bits/unique_ptr.h:172
> #17 0x7ff9d6ad9e1b in cppu_threadpool::JobQueue::enter(void const*, 
bool) at cppu/source/threadpool/jobqueue.cxx:100
> #18 0x7ff9d6adbb80 in cppu_threadpool::ORequestThread::run() at 
cppu/source/threadpool/thread.cxx:164
[...]

processing an unrelated incoming call from soffice.bin and blocked trying to
lock the GIL.  (The reason that thread 1 doesn't make 

  1   2   3   4   >