[Libreoffice-commits] core.git: dbaccess/source

2022-04-17 Thread Siddhant Chaudhary (via logerrit)
 dbaccess/source/core/api/FilteredContainer.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 370077502210f4d41a1d2014c3e3f99536217ce7
Author: Siddhant Chaudhary 
AuthorDate: Sun Apr 17 00:49:07 2022 +0530
Commit: Stephan Bergmann 
CommitDate: Mon Apr 18 08:42:46 2022 +0200

tdf#42982 Improved UNO API error reporting.

Messages to thrown `RuntimeException` instances have been added to make
the error clearer.

Change-Id: I566c475bd4ddf891a2cebf15664576cff792c118
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133100
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/dbaccess/source/core/api/FilteredContainer.cxx 
b/dbaccess/source/core/api/FilteredContainer.cxx
index 70eb85210a80..a5cf0b156327 100644
--- a/dbaccess/source/core/api/FilteredContainer.cxx
+++ b/dbaccess/source/core/api/FilteredContainer.cxx
@@ -132,7 +132,7 @@ static sal_Int32 createWildCardVector(Sequence< OUString >& 
_rTableFilter, std::
 static void lcl_ensureComposedName( TableInfo& _io_tableInfo, const 
Reference< XDatabaseMetaData >& _metaData )
 {
 if ( !_metaData.is() )
-throw RuntimeException();
+throw RuntimeException("lcl_ensureComposedName: _metaData cannot 
be null!");
 
 if ( !_io_tableInfo.sComposedName )
 {
@@ -153,7 +153,7 @@ static sal_Int32 createWildCardVector(Sequence< OUString >& 
_rTableFilter, std::
 lcl_ensureComposedName( _io_tableInfo, _metaData );
 
 if ( !_masterContainer.is() )
-throw RuntimeException();
+throw RuntimeException("lcl_ensureType: _masterContainer cannot be 
null!");
 
 OUString sTypeName;
 try


[Libreoffice-commits] core.git: dictionaries

2022-04-17 Thread Batmunkh Dorjgotov (via logerrit)
 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f0d61446df66dd026419dae25fc9a8cfaccfb079
Author: Batmunkh Dorjgotov 
AuthorDate: Mon Apr 18 13:06:31 2022 +0800
Commit: Gerrit Code Review 
CommitDate: Mon Apr 18 07:06:31 2022 +0200

Update git submodules

* Update dictionaries from branch 'master'
  to e0a820ca5c6a4a7e5175a4191f21a2ec3108ee86
  - Update Mongolian dictionary

Change-Id: Iefd26d95473785a73e77f8a3f459a50d1da03d27
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/131063
Tested-by: Aron Budea 
Reviewed-by: Aron Budea 

diff --git a/dictionaries b/dictionaries
index 5314824424e7..e0a820ca5c6a 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit 5314824424e7efbba66df57cafafa7ae246b5b31
+Subproject commit e0a820ca5c6a4a7e5175a4191f21a2ec3108ee86


[Libreoffice-commits] dictionaries.git: mn_MN/description.xml mn_MN/dictionaries.xcu mn_MN/DictMN.png mn_MN/lppl.txt mn_MN/mn_MN.aff mn_MN/mn_MN.dic mn_MN/README_mn_MN.txt

2022-04-17 Thread Batmunkh Dorjgotov (via logerrit)
 mn_MN/DictMN.png   |binary
 mn_MN/README_mn_MN.txt |   33 
 mn_MN/description.xml  |   11 
 mn_MN/dictionaries.xcu |2 
 mn_MN/lppl.txt |4 
 mn_MN/mn_MN.aff| 6568 
 mn_MN/mn_MN.dic|1061952 
+
 7 files changed, 554223 insertions(+), 514347 deletions(-)

New commits:
commit e0a820ca5c6a4a7e5175a4191f21a2ec3108ee86
Author: Batmunkh Dorjgotov 
AuthorDate: Sun Mar 6 00:14:53 2022 +0800
Commit: Aron Budea 
CommitDate: Mon Apr 18 07:06:27 2022 +0200

Update Mongolian dictionary

Change-Id: Iefd26d95473785a73e77f8a3f459a50d1da03d27
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/131063
Tested-by: Aron Budea 
Reviewed-by: Aron Budea 

diff --git a/mn_MN/DictMN.png b/mn_MN/DictMN.png
new file mode 100644
index 000..01db111
Binary files /dev/null and b/mn_MN/DictMN.png differ
diff --git a/mn_MN/README_mn_MN.txt b/mn_MN/README_mn_MN.txt
index 33cd555..e9a43f2 100644
--- a/mn_MN/README_mn_MN.txt
+++ b/mn_MN/README_mn_MN.txt
@@ -1,31 +1,12 @@
 Туршилтын хувилбар болох ойролцоогоор 2 сая үгийн сантай толио гаргаснаас хойш
-даруй 13 жил өнгөрчээ. Энэ удаагийн шинэчлэлээр 40 мянга орчим, тэдгээрийн
-хувилал болох 400 сая гаруй үгийн санг бэлтгэлээ.
+даруй 14 жил өнгөрчээ. Энэ удаагийн шинэчлэлээр 45 мянга орчим, тэдгээрийн
+хувилал болох 450 сая гаруй үгийн санг бэлтгэлээ.
 
-Энэхүү толийн онцлог гэвэл эрдэмтэн Ц. Дамдинсүрэн нарын 'Монгол үсгийн дүрмийн
-толь', 'Монгол хэлний хадмал толь', 'Монгол хэлний их тайлбар толь' болон
-'Монгол хэлний зөв бичих дүрмийн журамласан толь' зэрэг бүтээлүүдийг тусгасан
-болно.
+Энэхүү толины онцлог гэвэл академич Ц. Дамдинсүрэн нарын 'Монгол үсгийн дүрмийн
+толь' бүтээлийг баримтлан туурвисан болно.
 
 Өөрчлөн тараахыг хориглоно. Зохиогчийн эрх хуулиар хамгаалагдсан.
 

-
-Copyright 2020-present, Batmunkh Dorjgotov 
-
-Special thanks to Guntevsuren Nanzad for your great professional assistance.
-
-This work may be distributed and/or modified under the
-conditions of the LaTeX Project Public License, either version 1.3
-of this license or (at your option) any later version.
-The latest version of this license is in
-  http://www.latex-project.org/lppl.txt
-and version 1.3 or later is part of all distributions of LaTeX
-version 2005/12/01 or later.
-
-This work has the LPPL maintenance status maintained.
-
-The Current Maintainer of this work is Batmunkh Dorjgotov.
-
-This work consists of the files mn_MN.aff, mn_MN.dic, mn_MN.zip and
-README_mn_MN.txt.
+Уг толийг хэрэглээний программууд дээр хэрхэн ашиглах талаарх зааварчилгыг
+  https://zuv.bichig.dev
+цахим хуудаснаас авна уу!
diff --git a/mn_MN/description.xml b/mn_MN/description.xml
index d80ec64..8745f9d 100644
--- a/mn_MN/description.xml
+++ b/mn_MN/description.xml
@@ -1,6 +1,6 @@
 
 http://openoffice.org/extensions/description/2006"; 
xmlns:d="http://openoffice.org/extensions/description/2006"; 
xmlns:xlink="http://www.w3.org/1999/xlink";>
-
+
 
 
 Mongolian spelling and hyphenation 
dictionaries
@@ -15,8 +15,11 @@
 
 
 
-
-
-
+
+
+
 
+
+
+
 
diff --git a/mn_MN/dictionaries.xcu b/mn_MN/dictionaries.xcu
index fcf6ee7..5353750 100644
--- a/mn_MN/dictionaries.xcu
+++ b/mn_MN/dictionaries.xcu
@@ -13,7 +13,7 @@
 mn-Cyrl-MN
 
 
-   
+
 
 %origin%/hyph_mn_MN.dic
 
diff --git a/mn_MN/lppl.txt b/mn_MN/lppl.txt
index b597966..885c28c 100644
--- a/mn_MN/lppl.txt
+++ b/mn_MN/lppl.txt
@@ -1,4 +1,6 @@
-Copyright 2020-present, Batmunkh Dorjgotov 
+Copyright 2020-2022, Batmunkh Dorjgotov 
+
+Special thanks to Guntevsuren Nanzad for your great professional assistance.
 
 This work may be distributed and/or modified under the
 conditions of the LaTeX Project Public License, either version 1.3
diff --git a/mn_MN/mn_MN.aff b/mn_MN/mn_MN.aff
index 9a20739..c3d5bcc 100644
--- a/mn_MN/mn_MN.aff
+++ b/mn_MN/mn_MN.aff
@@ -1,7 +1,7 @@
 ## mn_MN.aff
-## Version: 2021.04.27
-## Copyright 2020-present, Batmunkh Dorjgotov 
-#
+## Version: 2022.04.14
+## Copyright 2020-2022, Batmunkh Dorjgotov 
+#   https://zuv.bichig.dev
 # Special thanks to Guntevsuren Nanzad for your great professional assistance.
 #
 # This work may be distributed and/or modified under the
@@ -21,7 +21,7 @@
 #
 LANG mn_MN
 SET UTF-8
-TRY аоөийубвгцхдтжчзүьэлмныёеъсшяюрпфкАОӨИЙУБВГЦХДТЖЧЗҮЬЭЛМНЫЁЕЪСШЯЮРПФК
+TRY аоөийубвгцхдтжчзүьэлмныёеъсшяюрпфкщАОӨИЙУБВГЦХДТЖЧЗҮЬЭЛМНЫЁЕЪСШЯЮРПФКЩ
 FLAG long
 
 FULLSTRIP
@@ -32,9 +32,10 @@ WORDCHARS -1234567890%.
 BREAK 0
 
 CHECKCOMPOUNDCASE
+ONLYINCOMPOUND oc
 COMPOUNDFLAG ++
-
 COMPOUNDMIN 1
+
 COMPOUNDRULE 8
 COMPOUNDRULE (nn)*[a0,a1,a2,a3]
 COMPOUNDRULE (nn)*[e0,e1,e2,e3]
@@ -45,7 +46,7 @@ COMPOUNDRULE (nn)*[o0,o1,o2,o3]
 COMPOUNDRULE (nn)*%?
 COMPOUNDRULE (nn)*.(nn)*%?
 
-REP 2255
+REP 2757
 REP a а
 REP c с
 REP e е
@@ -60,6 +61

[Libreoffice-commits] core.git: sw/qa sw/source

2022-04-17 Thread Justin Luth (via logerrit)
 sw/qa/extras/ooxmlexport/ooxmlexport5.cxx|5 -
 sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit c136249982345b205da83d1907e21da0c7bab7dd
Author: Justin Luth 
AuthorDate: Thu Apr 7 09:28:42 2022 +0200
Commit: Justin Luth 
CommitDate: Mon Apr 18 05:18:48 2022 +0200

tdf#148380 docx export: use content of unknown fields, not name

This used to be GetCntnt, but then out of the blue in a huge
squashed commit, it changed to GetFieldName. So I assume that
was just debugging code that got accidentally committed.
It just doesn't make any sense to export the field name
as the plain text content instead of the field's value.

commit ed40f62e64564d2b22c9285cfdc6778aeac8fd68
Author: Michael Meeks on Mon Mar 14 16:51:14 2011 +
Merge commit 'ooo/DEV300_m101' into integration/dev300_m101

NOTE: DOC also does a .replace(0x0A, 0x0B),
//replace LF 0x0A with VT 0x0B
//#i19604# convert hard line breaks inside fields to word equivalent

After taking care of SAVEDATE, PRINTDATE, I tested this with
assert(rInfos.pField->GetFieldName() == "Sender");
and found no other examples.

Change-Id: Ie24b8c176fe6df4015be221c87aa249fe9b8ce92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132666
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index c4bcd2b23da1..2cf70462cbe9 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -319,9 +319,12 @@ CPPUNIT_TEST_FIXTURE(Test, testOldComplexMergeTableInTable)
 
 CPPUNIT_TEST_FIXTURE(Test, testHyperlinkContainingPlaceholderField)
 {
-loadAndSave("hyperlink-field.odt");
+loadAndReload("hyperlink-field.odt");
 CPPUNIT_ASSERT_EQUAL(1, getShapes());
 parseExport("word/document.xml");
+
+// tdf#148380 output unknown field's contents("") instead of field 
name("Sender" aka e-mail)
+CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), 
getParagraph(1)->getString().indexOf("Sender"));
 }
 
 CPPUNIT_TEST_FIXTURE(Test, testTablePreferredWidth)
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 6daca466f1ff..88df3b95f46d 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -2403,7 +2403,7 @@ void DocxAttributeOutput::StartField_Impl( const 
SwTextNode* pNode, sal_Int32 nP
 if ( rInfos.pField && rInfos.eType == ww::eUNKNOWN )
 {
 // Expand unsupported fields
-RunText( rInfos.pField->GetFieldName() );
+RunText(rInfos.pField->ExpandField(/*bCached=*/true, nullptr));
 return;
 }
 else if ( rInfos.eType == ww::eFORMDATE )


camera

2022-04-17 Thread adeline leclercq
Bonjour,

Serait-il possible d'insérer des images directement depuis la caméra ?

merci


Bien à vous,

Adeline LECLERCQ


Infra call on Tue, Apr 19 at 16:30 UTC

2022-04-17 Thread Guilhem Moulin
Hi there,

The next infra call will take place at `date -d "Tue, 19 Apr 2022 16:30 UTC"`
(18:30 Berlin time).

We'll meet at https://jitsi.documentfoundation.org/infra and write the minutes
to https://pad.documentfoundation.org/p/infra .  Agenda TBA.

See you there!
Cheers,
-- 
Guilhem.


signature.asc
Description: PGP signature


[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-3' - ucb/source

2022-04-17 Thread Michael Stahl (via logerrit)
 ucb/source/ucp/webdav-curl/CurlSession.cxx |   20 ++--
 1 file changed, 18 insertions(+), 2 deletions(-)

New commits:
commit 3b9bd1dad614b2f0526ae43a0d7250e9e0ec39f9
Author: Michael Stahl 
AuthorDate: Wed Apr 13 16:50:30 2022 +0200
Commit: Caolán McNamara 
CommitDate: Sun Apr 17 20:19:59 2022 +0200

ucb: webdav-curl: only allow system credentials for auth once

... and in any case abort authentication after 10 failed attempts.

Apparently some PasswordContainer can turn this into an infinite loop.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132974
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 2bc4d1d22fdbd9d97c66bb53762b4b4bf7b61b47)

ucb: webdav-curl: oops, increment after checking
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132982
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit ab65a74998b498ff49c15db87fc14a9afa89d8bf)

Change-Id: Ib2333b371a770999e8407ce7e1af21512aadb70d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132867
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 
(cherry picked from commit 6b54e6a8e64233de63b826211b81a8ed6767483f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133041
Reviewed-by: Adolfo Jayme Barrientos 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/ucb/source/ucp/webdav-curl/CurlSession.cxx 
b/ucb/source/ucp/webdav-curl/CurlSession.cxx
index 70f9f828467d..813988c78489 100644
--- a/ucb/source/ucp/webdav-curl/CurlSession.cxx
+++ b/ucb/source/ucp/webdav-curl/CurlSession.cxx
@@ -1223,6 +1223,8 @@ auto CurlProcessor::ProcessRequest(
 }
 }
 bool isRetry(false);
+int nAuthRequests(0);
+int nAuthRequestsProxy(0);
 
 // libcurl does not have an authentication callback so handle auth
 // related status codes and requesting credentials via this loop
@@ -1365,7 +1367,14 @@ auto CurlProcessor::ProcessRequest(
 case SC_UNAUTHORIZED:
 case SC_PROXY_AUTHENTICATION_REQUIRED:
 {
-if (pEnv && pEnv->m_xAuthListener)
+auto& rnAuthRequests(statusCode == SC_UNAUTHORIZED ? 
nAuthRequests
+   : 
nAuthRequestsProxy);
+if (rnAuthRequests == 10)
+{
+SAL_INFO("ucb.ucp.webdav.curl", "aborting 
authentication after "
+<< 
rnAuthRequests << " attempts");
+}
+else if (pEnv && pEnv->m_xAuthListener)
 {
 ::std::optional const 
oRealm(ExtractRealm(
 headers, statusCode == SC_UNAUTHORIZED ? 
"WWW-Authenticate"
@@ -1383,7 +1392,14 @@ auto CurlProcessor::ProcessRequest(
   &authAvail);
 assert(rc == CURLE_OK);
 (void)rc;
-bool const isSystemCredSupported((authAvail & 
authSystem) != 0);
+// only allow SystemCredentials once - the
+// PasswordContainer may have stored it in the
+// Config (TrySystemCredentialsFirst or
+// AuthenticateUsingSystemCredentials) and then it
+// will always force its use no matter how hopeless
+bool const isSystemCredSupported((authAvail & 
authSystem) != 0
+ && rnAuthRequests 
== 0);
+++rnAuthRequests;
 
 // Ask user via XInteractionHandler.
 // Warning: This likely runs an event loop which 
may


[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-3' - officecfg/registry

2022-04-17 Thread Caolán McNamara (via logerrit)
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 45ca2ec0d7a3205f773aa814a00ea7414fa95f6d
Author: Caolán McNamara 
AuthorDate: Wed Apr 13 17:09:01 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sun Apr 17 20:19:20 2022 +0200

Resolves: tdf#148122 Celtic MD font appears wrong

Change-Id: Ib551f073b8ea0e0662660ccf01ebf56c2fd7f340
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132868
Reviewed-by: Michael Stahl 
Tested-by: Caolán McNamara 
(cherry picked from commit 75893fb99173f615d9fa40b50dfba147d22967b4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133042
Reviewed-by: Xisco Fauli 
Reviewed-by: Thorsten Behrens 
Reviewed-by: Adolfo Jayme Barrientos 
Reviewed-by: Caolán McNamara 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 0c7b9d1741a3..72ba024f8bc3 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -5581,6 +5581,8 @@
   
 
 
+  
+  Celticmd,1571,-567,1571,-547,2126,559
   
   DIN Light,1509,-503,1509,-483,1997,483
 


[Libreoffice-commits] core.git: vcl/workben

2022-04-17 Thread Caolán McNamara (via logerrit)
 vcl/workben/commonfuzzer.hxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit f8e11c6480ff0005715b989a6d4e2e10a3816cf6
Author: Caolán McNamara 
AuthorDate: Sun Apr 17 17:15:05 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sun Apr 17 20:12:21 2022 +0200

Revert "ofz#46632 Direct-leak"

This reverts commit 4659fc2f0a7223a89446edff0b77e58758b5edf5.

Change-Id: Id8d654ff4c36185b08012ab5a69f7cf75fc43249
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133106
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/workben/commonfuzzer.hxx b/vcl/workben/commonfuzzer.hxx
index e64a53dda644..c9afd65552fe 100644
--- a/vcl/workben/commonfuzzer.hxx
+++ b/vcl/workben/commonfuzzer.hxx
@@ -129,8 +129,6 @@ void CommonInitialize(int *argc, char ***argv)
 psp::PrintFontManager::get();
 //get the printer info
 Printer::GetPrinterQueues();
-//Draw some text to fill CairoTextRender fontoptions cache
-Application::GetDefaultDevice()->DrawText(Point(0, 0), "hello world");
 
 //https://github.com/google/oss-fuzz/issues/1449
 //https://github.com/google/oss-fuzz/issues/5441


[Libreoffice-commits] core.git: svx/source

2022-04-17 Thread Caolán McNamara (via logerrit)
 svx/source/customshapes/EnhancedCustomShapeFontWork.cxx |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 178044ec01227771542de809f8140d107035ca0f
Author: Caolán McNamara 
AuthorDate: Sun Apr 17 17:24:24 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sun Apr 17 20:11:42 2022 +0200

ofz#46782 Timeout

Change-Id: I14129770c7fc8505c8060d79fa8bb9683a688a68
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133107
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx 
b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
index 40b7f222dad9..70fff24c9ba0 100644
--- a/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
@@ -238,11 +238,13 @@ static void CalculateHorizontalScalingFactor(
 
 if (fScalingFactor < 1.0)
 {
-// if we have a ridiculously large font (flagged with the SAL_WARN
-// above) that will require scaling down to a very small value then
+// if we have a very large font that will require scaling down to 
a very small value then
 // skip directly to a small font size
-if (nFontSize > SAL_MAX_INT16 && fScalingFactor * nFontSize < 1.0)
+if (nFontSize > 128 && fScalingFactor * nFontSize < 1.0)
+{
 nFontSize = 16;
+SAL_WARN("svx", "CalculateHorizontalScalingFactor skipping 
direct to: " << nFontSize << " from " << rFontHeight.GetHeight());
+}
 nFontSize--;
 aFont.SetFontHeight( nFontSize );
 pVirDev->SetFont( aFont );


[Libreoffice-commits] core.git: vcl/unx

2022-04-17 Thread Caolán McNamara (via logerrit)
 vcl/unx/gtk3/gtkdata.cxx |   16 +-
 vcl/unx/gtk3/gtkinst.cxx |  114 ++-
 2 files changed, 40 insertions(+), 90 deletions(-)

New commits:
commit 689d1f5dd3dc12d9f85ba98702a66c7af20849dc
Author: Caolán McNamara 
AuthorDate: Sat Apr 16 12:30:01 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sun Apr 17 17:35:47 2022 +0200

Related: tdf#148349 gtk[3|4] use a css effect to draw attention to the 
widget

Change-Id: I96af6c87d5aeab6513ff782a0bf25554602b4953
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/gtk3/gtkdata.cxx b/vcl/unx/gtk3/gtkdata.cxx
index 53f897420299..cc8535ff2ad2 100644
--- a/vcl/unx/gtk3/gtkdata.cxx
+++ b/vcl/unx/gtk3/gtkdata.cxx
@@ -462,7 +462,7 @@ static GtkStyleProvider* CreateStyleProvider()
 #if GTK_CHECK_VERSION(4, 0, 0)
   // we basically assumed during dialog design that the frame's were 
invisible, because
   // they used to be in the default theme during gtk3
-  "frame { border-style: none;  }"
+  "frame { border-style: none; }"
 #endif
   "notebook.overflow > header.top > tabs > tab:checked { "
   "box-shadow: none; padding: 0 0 0 0; margin: 0 0 0 0;"
@@ -470,7 +470,19 @@ static GtkStyleProvider* CreateStyleProvider()
   "background-image: none; background-color: transparent;"
   "border-radius: 0 0 0 0; border-width: 0 0 0 0;"
   "border-style: none; border-color: transparent;"
-  "opacity: 0; min-height: 0; min-width: 0; }";
+  "opacity: 0; min-height: 0; min-width: 0; }"
+  // https://css-tricks.com/restart-css-animation/
+  // This animation appears twice with two different names so we can change
+  // the class from "call_attention_1" to "call_attention_2" to restart the
+  // animation
+  "@keyframes shinkandrestore1 { 50% { margin-left: 15px; margin-right: 
15px; opacity: 0.5; } }"
+  "@keyframes shinkandrestore2 { 50% { margin-left: 15px; margin-right: 
15px; opacity: 0.5; } }"
+  " *.call_attention_1 {"
+  "animation-name: shinkandrestore1; animation-duration: 1s; "
+  "animation-timing-function: linear; animation-iteration-count: 2; }"
+  " *.call_attention_2 {"
+  "animation-name: shinkandrestore2; animation-duration: 1s; "
+  "animation-timing-function: linear; animation-iteration-count: 2; }";
 css_provider_load_from_data(pStyleProvider, data, -1);
 return GTK_STYLE_PROVIDER(pStyleProvider);
 }
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 65c618eeae13..ca8c893d3915 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -2494,92 +2494,6 @@ void set_buildable_id(GtkBuildable* pWidget, const 
OString& rId)
 
 namespace {
 
-class FlashAttention
-{
-private:
-GtkWidget* m_pWidget;
-int m_nFlashCount;
-gint m_nFlashTimeout;
-
-static gboolean signalDraw(GtkWidget* pWidget, cairo_t* cr, gpointer self)
-{
-FlashAttention* pThis = static_cast(self);
-if (pThis->m_nFlashCount % 2 == 0)
-return false;
-
-GtkAllocation alloc {0, 0,
- gtk_widget_get_allocated_width(pWidget),
- gtk_widget_get_allocated_height(pWidget)};
-
-Color 
aColor(Application::GetSettings().GetStyleSettings().GetHighlightColor());
-cairo_set_source_rgba(cr, aColor.GetRed() / 255.0, aColor.GetGreen() / 
255.0, aColor.GetBlue() / 255.0, 0.5);
-cairo_rectangle(cr, alloc.x + 0.5, alloc.y + 0.5, alloc.width - 1, 
alloc.height - 1);
-cairo_fill(cr);
-
-return false;
-}
-
-static void signalUnmap(gpointer self)
-{
-FlashAttention* pThis = static_cast(self);
-pThis->ClearFlash();
-}
-
-void ClearFlash()
-{
-if (m_nFlashTimeout != 0)
-{
-g_source_remove(m_nFlashTimeout);
-m_nFlashTimeout = 0;
-}
-if (m_pWidget)
-{
-gtk_widget_queue_draw(m_pWidget);
-g_signal_handlers_disconnect_by_func(m_pWidget, 
reinterpret_cast(signalDraw), this);
-g_signal_handlers_disconnect_by_func(m_pWidget, 
reinterpret_cast(signalUnmap), this);
-m_pWidget = nullptr;
-}
-}
-
-bool QueueFlash()
-{
-constexpr int FlashesWanted = 1;
-
-gtk_widget_queue_draw(m_pWidget);
-m_nFlashCount++;
-
-if (m_nFlashCount == FlashesWanted * 2)
-{
-ClearFlash();
-return false;
-}
-
-return true;
-}
-
-static gboolean FlashTimeout(FlashAttention* pThis)
-{
-return pThis->QueueFlash();
-}
-
-public:
-FlashAttention(GtkWidget* pWidget)
-: m_pWidget(pWidget)
-, m_nFlashCount(1)
-{
-g_signal_connect_after(m_pWidget, "draw", G_CALLBACK(signalDraw), 
this);
-g_signal_connect_swapped(m_pWidget, "unmap", G_CALLBA

[Libreoffice-commits] core.git: idlc/inc

2022-04-17 Thread Aman Jha (via logerrit)
 idlc/inc/astbasetype.hxx |5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 7784744b1fbc0e07c1b01addd1043606e8a631da
Author: Aman Jha 
AuthorDate: Fri Apr 15 15:42:44 2022 +0530
Commit: Ilmari Lauhakangas 
CommitDate: Sun Apr 17 16:57:02 2022 +0200

tdf#143148 use pragma once in idlc

Change-Id: I2f7108da12f8345a0b13754398c38c068aa74be7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132853
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas 

diff --git a/idlc/inc/astbasetype.hxx b/idlc/inc/astbasetype.hxx
index 9c4e6ea42575..0b488c8006fd 100644
--- a/idlc/inc/astbasetype.hxx
+++ b/idlc/inc/astbasetype.hxx
@@ -16,8 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_IDLC_INC_ASTBASETYPE_HXX
-#define INCLUDED_IDLC_INC_ASTBASETYPE_HXX
+#pragma once
 
 #include "asttype.hxx"
 #include "astexpression.hxx"
@@ -48,6 +47,4 @@ private:
 const ExprType m_exprType;
 };
 
-#endif // INCLUDED_IDLC_INC_ASTBASETYPE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-commits] core.git: helpcontent2

2022-04-17 Thread Ilmari Lauhakangas (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 11ad1fe346b16b388280018b0ef3f4130a45dd40
Author: Ilmari Lauhakangas 
AuthorDate: Sun Apr 17 17:38:32 2022 +0300
Commit: Gerrit Code Review 
CommitDate: Sun Apr 17 16:38:32 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 24828f91e22842cdaf64faf7d22a028541e5746c
  - tdf#148621 Improve Basic Help layout

- Get rid of tables
- Add normalize-whitespace Prism plugin to get rid of useless indents
- Fix code blocks poking through sticky header
- Add some word wrapping CSS to fix mobile-unfriendliness

Change-Id: I73fd1e0678624b0d4bd5561f50e80990db5567be
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133096
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 8d70f37fcc80..24828f91e228 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 8d70f37fcc80c0b6c4fbfa36709ec1b1e9002a40
+Subproject commit 24828f91e22842cdaf64faf7d22a028541e5746c


[Libreoffice-commits] help.git: help3xsl/default.css help3xsl/online_transform.xsl help3xsl/prism.css help3xsl/prism.js source/text

2022-04-17 Thread Ilmari Lauhakangas (via logerrit)
 help3xsl/default.css   |6 
 help3xsl/online_transform.xsl  |2 
 help3xsl/prism.css |2 
 help3xsl/prism.js  |  201 ++
 source/text/sbasic/shared/03/lib_tools.xhp | 2280 +
 5 files changed, 969 insertions(+), 1522 deletions(-)

New commits:
commit 24828f91e22842cdaf64faf7d22a028541e5746c
Author: Ilmari Lauhakangas 
AuthorDate: Sat Apr 16 16:42:40 2022 +0300
Commit: Olivier Hallot 
CommitDate: Sun Apr 17 16:38:31 2022 +0200

tdf#148621 Improve Basic Help layout

- Get rid of tables
- Add normalize-whitespace Prism plugin to get rid of useless indents
- Fix code blocks poking through sticky header
- Add some word wrapping CSS to fix mobile-unfriendliness

Change-Id: I73fd1e0678624b0d4bd5561f50e80990db5567be
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/133096
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/help3xsl/default.css b/help3xsl/default.css
index 085d323a9..2c5e59ac0 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -121,6 +121,7 @@ pre,
 display: inline;
 padding: 1px 3px;
 font-family: var(--font_mono);
+word-wrap: anywhere;
 }
 .smathcode {
 border-radius: 2px;
@@ -178,6 +179,10 @@ pre,
 .noteicon, .notetext {
 padding:0.3em;
 }
+/* Override some Prism.js styles */
+code[class*="language-"], pre[class*="language-"] {
+white-space: pre-wrap;
+}
 
 /* Table related classes */
 
@@ -603,6 +608,7 @@ li.disabled a {
 background: #18A303;
 top: 0px;
 position: sticky;
+z-index: 100;
 }
 .xapian-omega-search {
 margin: auto;
diff --git a/help3xsl/online_transform.xsl b/help3xsl/online_transform.xsl
index 0751d7a86..465415ea2 100644
--- a/help3xsl/online_transform.xsl
+++ b/help3xsl/online_transform.xsl
@@ -143,8 +143,8 @@
 
 
 
-
 
+
 
 
 
diff --git a/help3xsl/prism.css b/help3xsl/prism.css
index f974d0c87..79d07d18a 100644
--- a/help3xsl/prism.css
+++ b/help3xsl/prism.css
@@ -1,5 +1,5 @@
 /* PrismJS 1.27.0
-https://prismjs.com/download.html#themes=prism-coy&languages=markup+css+clike+javascript+python+visual-basic&plugins=line-numbers
 */
+https://prismjs.com/download.html#themes=prism-coy&languages=markup+css+clike+javascript+python+visual-basic&plugins=line-numbers+normalize-whitespace
 */
 /**
  * prism.js Coy theme for JavaScript, CoffeeScript, CSS and HTML
  * Based on https://github.com/tshedor/workshop-wp-theme (Example: 
http://workshop.kansan.com/category/sessions/basics or 
http://workshop.timshedor.com/category/sessions/basics);
diff --git a/help3xsl/prism.js b/help3xsl/prism.js
index 546388f44..4e00aeb04 100644
--- a/help3xsl/prism.js
+++ b/help3xsl/prism.js
@@ -1,5 +1,5 @@
 /* PrismJS 1.27.0
-https://prismjs.com/download.html#themes=prism-coy&languages=markup+css+clike+javascript+python+visual-basic&plugins=line-numbers
 */
+https://prismjs.com/download.html#themes=prism-coy&languages=markup+css+clike+javascript+python+visual-basic&plugins=line-numbers+normalize-whitespace
 */
 /// 
 
 var _self = (typeof window !== 'undefined')
@@ -2067,3 +2067,202 @@ Prism.languages.vba = Prism.languages['visual-basic'];
 
 }());
 
+(function () {
+
+   if (typeof Prism === 'undefined') {
+   return;
+   }
+
+   var assign = Object.assign || function (obj1, obj2) {
+   for (var name in obj2) {
+   if (obj2.hasOwnProperty(name)) {
+   obj1[name] = obj2[name];
+   }
+   }
+   return obj1;
+   };
+
+   function NormalizeWhitespace(defaults) {
+   this.defaults = assign({}, defaults);
+   }
+
+   function toCamelCase(value) {
+   return value.replace(/-(\w)/g, function (match, firstChar) {
+   return firstChar.toUpperCase();
+   });
+   }
+
+   function tabLen(str) {
+   var res = 0;
+   for (var i = 0; i < str.length; ++i) {
+   if (str.charCodeAt(i) == '\t'.charCodeAt(0)) {
+   res += 3;
+   }
+   }
+   return str.length + res;
+   }
+
+   NormalizeWhitespace.prototype = {
+   setDefaults: function (defaults) {
+   this.defaults = assign(this.defaults, defaults);
+   },
+   normalize: function (input, settings) {
+   settings = assign(this.defaults, settings);
+
+   for (var name in settings) {
+   var methodName = toCamelCase(name);
+   if (name !== 'normalize' && methodName !== 
'setDefaults' &&
+   settings[name] && this[methodName]) {
+

Aman Jha license statement

2022-04-17 Thread Aman Jha
All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

Regards,
Aman Jha


[Libreoffice-commits] core.git: oox/source

2022-04-17 Thread Caolán McNamara (via logerrit)
 oox/source/ppt/slidepersist.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit e8157e60561b950f6a7d8a577145f034912e742d
Author: Caolán McNamara 
AuthorDate: Sun Apr 17 12:14:17 2022 +0100
Commit: Caolán McNamara 
CommitDate: Sun Apr 17 14:33:05 2022 +0200

ofz: Null-dereference

Change-Id: Ib058458860f606736455ae997a6f7f74de5585bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133104
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/oox/source/ppt/slidepersist.cxx b/oox/source/ppt/slidepersist.cxx
index e90f2365fefc..bd7f32b5ef14 100644
--- a/oox/source/ppt/slidepersist.cxx
+++ b/oox/source/ppt/slidepersist.cxx
@@ -361,6 +361,8 @@ void SlidePersist::createConnectorShapeConnection()
 {
 OUString aDestShapeId = 
aConnectorShapeProperties[j].maDestShapeId;
 const auto& pShape = maShapeMap.find(aDestShapeId);
+if (pShape == maShapeMap.end())
+continue;
 uno::Reference 
xShape(pShape->second->getXShape(), uno::UNO_QUERY);
 uno::Reference xSet(xShape, 
uno::UNO_QUERY);
 if (xShape.is())


Re: GSOC 2022 application

2022-04-17 Thread Regina Henschel

Hi Rupesh,

we appreciate that you want to work on the further development of 
LibreOffice.


For participation in GSOC we expect that you have submitted a so-called 
"easyhack" to become familiar with the build process.


I do not find an "easyhack" from you. Do you have submitted it with a 
different name?


Or do you not aware of section "How to apply" on 
https://wiki.documentfoundation.org/Development/GSoC/2022?


Kind regards,
Regina

Rupesh Darimisetti schrieb am 17.04.2022 um 11:39:
My name is Rupesh Darimisetti a prefinal student studying mechanical 
engineering passionate about coding, came across your organization in 
GSOC 2022 looking to develop the codebase of your organization



  Convert Writer's Java UNO API tests to C++

**

A big chunk of UNO API tests are still implemented in Java, but to 
minimise the dependency on Java during the build, we have a long-term 
plan to move them to C++.


Currently a small set of test are already converted and can be found in 
here . The 
Java test are located in here 
.


*Required skills/knowledge*

Java, C++

*Size*

175 hours or 350 hours

*Difficulty*

Medium

*Potential mentors*

/Tomaž Vajngerl/, IRC: quikee, mail: quikee @ gmail.com

Sent from Mail  for Windows





Re: GSOC 2022 application

2022-04-17 Thread Ilmari Lauhakangas

On 17.4.2022 12.39, Rupesh Darimisetti wrote:
My name is Rupesh Darimisetti a prefinal student studying mechanical 
engineering passionate about coding, came across your organization in 
GSOC 2022 looking to develop the codebase of your organization


1) You send your proposal into Google's system 
https://summerofcode.withgoogle.com/
2) A proposal is not a copy & paste job from our ideas page. See 
https://google.github.io/gsocguides/student/writing-a-proposal
3) You need to solve at least one difficultyInteresting easy hack and 
get it merged before 12 May


Ilmari


GSOC 2022 application

2022-04-17 Thread Rupesh Darimisetti
My name is Rupesh Darimisetti a prefinal student studying mechanical engineering passionate about coding, came across your organization in GSOC 2022 looking to develop the codebase of your organization Convert Writer's Java UNO API tests to C++ A big chunk of UNO API tests are still implemented in Java, but to minimise the dependency on Java during the build, we have a long-term plan to move them to C++.Currently a small set of test are already converted and can be found in here. The Java test are located in here.Required skills/knowledgeJava, C++Size175 hours or 350 hoursDifficultyMediumPotential mentorsTomaž Vajngerl, IRC: quikee, mail: quikee @ gmail.com   Sent from Mail for Windows 


[Libreoffice-commits] core.git: dbaccess/source

2022-04-17 Thread Andrea Gelmini (via logerrit)
 dbaccess/source/filter/hsqldb/createparser.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit c69db531ede119b950fbe1f35560f94e762e1070
Author: Andrea Gelmini 
AuthorDate: Thu Apr 14 18:14:28 2022 +0200
Commit: Julien Nabet 
CommitDate: Sun Apr 17 10:29:41 2022 +0200

Removed duplicated include

Change-Id: I09556d8041023f765980d8b5cf953b955545d0b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133023
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/dbaccess/source/filter/hsqldb/createparser.cxx 
b/dbaccess/source/filter/hsqldb/createparser.cxx
index 03952655dfd8..cfff560c0de5 100644
--- a/dbaccess/source/filter/hsqldb/createparser.cxx
+++ b/dbaccess/source/filter/hsqldb/createparser.cxx
@@ -23,7 +23,6 @@
 #include "createparser.hxx"
 #include "utils.hxx"
 #include 
-#include 
 
 using namespace ::comphelper;
 using namespace css::sdbc;


[Libreoffice-commits] core.git: basic/inc basic/source codemaker/source comphelper/source compilerplugins/clang desktop/source framework/inc framework/source i18npool/source idl/source pyuno/source sa

2022-04-17 Thread Noel Grandin (via logerrit)
 basic/inc/sbxform.hxx |   10 -
 basic/source/sbx/sbxform.cxx  |   68 +-
 codemaker/source/javamaker/javatype.cxx   |   17 +-
 comphelper/source/misc/string.cxx |2 
 compilerplugins/clang/stringviewparam.cxx |3 
 desktop/source/app/dispatchwatcher.cxx|   10 -
 framework/inc/uifactory/configurationaccessfactorymanager.hxx |2 
 framework/source/uifactory/uielementfactorymanager.cxx|8 -
 i18npool/source/transliteration/transliteration_body.cxx  |4 
 idl/source/prj/svidl.cxx  |8 -
 pyuno/source/loader/pyuno_loader.cxx  |   16 +-
 sal/cppunittester/cppunittester.cxx   |   10 -
 scripting/source/provider/URIHelper.cxx   |8 -
 scripting/source/provider/URIHelper.hxx   |2 
 scripting/source/vbaevents/eventhelper.cxx|   14 +-
 svx/source/svdraw/svdmrkv.cxx |   62 -
 unodevtools/source/skeletonmaker/cpptypemaker.cxx |   12 -
 unodevtools/source/skeletonmaker/javacompskeleton.cxx |8 -
 unodevtools/source/skeletonmaker/javatypemaker.cxx|4 
 uui/source/iahndl-ssl.cxx |   14 +-
 uui/source/secmacrowarnings.cxx   |   18 +-
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   41 +++---
 22 files changed, 173 insertions(+), 168 deletions(-)

New commits:
commit 33bd16b344e273c427091ee68e946bf67b371dd7
Author: Noel Grandin 
AuthorDate: Sun Apr 3 10:34:37 2022 +0200
Commit: Noel Grandin 
CommitDate: Sun Apr 17 10:27:33 2022 +0200

loplugin:stringviewparam convert methods using copy()

which converts to std::string_view::substr()

Change-Id: I3f42213b41a97e77ddcc79d84d512f49d68ca559
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132729
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/basic/inc/sbxform.hxx b/basic/inc/sbxform.hxx
index 8ae9cb2db3f4..8accc399547a 100644
--- a/basic/inc/sbxform.hxx
+++ b/basic/inc/sbxform.hxx
@@ -93,7 +93,7 @@ class SbxBasicFormater {
 String containing the formatted output
 */
 OUString  BasicFormat( double dNumber, const OUString& sFormatStrg );
-static OUString BasicFormatNull( const OUString& sFormatStrg );
+static OUString BasicFormatNull( std::u16string_view sFormatStrg );
 
 static  bool isBasicFormat( std::u16string_view sFormatStrg );
 
@@ -112,10 +112,10 @@ class SbxBasicFormater {
 short  GetDigitAtPosExpScan( double dNewExponent, short nPos,
   bool& bFoundFirstDigit );
 short  GetDigitAtPosExpScan( short nPos, bool& bFoundFirstDigit );
-static OUString GetPosFormatString( const OUString& sFormatStrg, bool & 
bFound );
-static OUString GetNegFormatString( const OUString& sFormatStrg, bool & 
bFound );
-static OUString Get0FormatString( const OUString& sFormatStrg, bool & 
bFound );
-static OUString GetNullFormatString( const OUString& sFormatStrg, bool & 
bFound );
+static OUString GetPosFormatString( std::u16string_view sFormatStrg, bool 
& bFound );
+static OUString GetNegFormatString( std::u16string_view sFormatStrg, bool 
& bFound );
+static OUString Get0FormatString( std::u16string_view sFormatStrg, bool & 
bFound );
+static OUString GetNullFormatString( std::u16string_view sFormatStrg, bool 
& bFound );
 static void AnalyseFormatString( const OUString& sFormatStrg,
  short& nNoOfDigitsLeft, 
short& nNoOfDigitsRight,
  short& 
nNoOfOptionalDigitsLeft,
diff --git a/basic/source/sbx/sbxform.cxx b/basic/source/sbx/sbxform.cxx
index ef273c1f392b..4bd0c09ac99f 100644
--- a/basic/source/sbx/sbxform.cxx
+++ b/basic/source/sbx/sbxform.cxx
@@ -296,71 +296,71 @@ short SbxBasicFormater::GetDigitAtPosExpScan( double 
dNewExponent, short nPos,
 
 // Copies the respective part of the format-string, if existing, and returns 
it.
 // So a new string is created, which has to be freed by the caller later.
-OUString SbxBasicFormater::GetPosFormatString( const OUString& sFormatStrg, 
bool & bFound )
+OUString SbxBasicFormater::GetPosFormatString( std::u16string_view 
sFormatStrg, bool & bFound )
 {
 bFound = false; // default...
-sal_Int32 nPos = sFormatStrg.indexOf( FORMAT_SEPARATOR );
+size_t nPos = sFormatStrg.find( FORMAT_SEPARATOR );
 
-if( nPos >= 0 )
+if( nPos != std::u16string_view::npos )
 {
 bFound = true;
 // the format-string for positive numbers is
 // everything before the first ';'
-return sFormatStrg.copy( 0,nPos );
+return OUString(sFormat

[Libreoffice-commits] core.git: basic/qa

2022-04-17 Thread Mike Kaganski (via logerrit)
 basic/qa/basic_coverage/test_non_ascii_names.bas |   28 +++
 1 file changed, 28 insertions(+)

New commits:
commit fe597a337914decd62480d3eba84258333116db9
Author: Mike Kaganski 
AuthorDate: Sun Apr 17 10:18:32 2022 +0300
Commit: Mike Kaganski 
CommitDate: Sun Apr 17 10:08:08 2022 +0200

Test StarBasic's native non-ASCII name syntax

Change-Id: Ie9f0cd21e59ffc1e3fbe2616e2ae7abbd0169424
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133103
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/basic/qa/basic_coverage/test_non_ascii_names.bas 
b/basic/qa/basic_coverage/test_non_ascii_names.bas
new file mode 100644
index ..a9ef0f159da2
--- /dev/null
+++ b/basic/qa/basic_coverage/test_non_ascii_names.bas
@@ -0,0 +1,28 @@
+'
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+
+Option Explicit
+
+Function doUnitTest as String
+  [Prüfung]
+  doUnitTest = TestUtil.GetResult()
+End Function
+
+Function [Функция]([😁])
+  [Функция] = [😁] & " and some text"
+End Function
+
+Sub [Prüfung]
+  On Error GoTo errorHandler
+
+  TestUtil.AssertEqual([Функция]("Smiley"), "Smiley and some text", 
"[Функция](""Smiley"")")
+
+  Exit Sub
+errorHandler:
+  TestUtil.ReportErrorHandler("Prüfung", Err, Error$, Erl)
+End Sub