[Libreoffice-bugs] [Bug 148836] Categories in Customize keyboard dialog should be alphabetized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148836

--- Comment #2 from Mike Kaganski  ---
I believe that originally, that list was intended to:
1. Have its categories reflect the main menu order (File, Edit, View, Insert,
...);
2. Have some special categories in specific positions (All commands, Macros,
Styles).

I have no personal preference for #1, but #2 IMO is important.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148836] Categories in Customize keyboard dialog should be alphabetized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148836

--- Comment #2 from Mike Kaganski  ---
I believe that originally, that list was intended to:
1. Have its categories reflect the main menu order (File, Edit, View, Insert,
...);
2. Have some special categories in specific positions (All commands, Macros,
Styles).

I have no personal preference for #1, but #2 IMO is important.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: svx/qa svx/source

[Regina Henschel (via logerrit)]

 svx/qa/unit/customshapes.cxx|   73 
 svx/qa/unit/data/tdf148714_CurvedArrows.ppt |binary
 svx/source/customshapes/EnhancedCustomShapeGeometry.cxx |   12 +-
 3 files changed, 81 insertions(+), 4 deletions(-)

New commits:
commit 4cfe46997eab3498cc519ef94c85ad2d644d3886
Author: Regina Henschel 
AuthorDate: Thu Apr 28 23:35:44 2022 +0200
Commit: Regina Henschel 
CommitDate: Fri Apr 29 07:27:48 2022 +0200

tdf#148714 connect first and second arc with arcTo

The curved*Arrows start with two arcs, which should be connected by a
line. The used commands are double V and double B respectively. Both
have an implicit moveTo, so that there should be no line between.
Other applications show the shapes correctly without line. But because
of bug 148714 LO shows a connecting line so that the error was not
earlier detected.
The patch changes the segment definition so that for the second
command the variant with implicit lineTo is used. This does not change
rendering in LO but makes other applications rendering the shapes
like LO.

Change-Id: I4f799f89497e52b1a7e00d8e5345a66ce21c00a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133586
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/svx/qa/unit/customshapes.cxx b/svx/qa/unit/customshapes.cxx
index fc671384e0c8..62e7728f7556 100644
--- a/svx/qa/unit/customshapes.cxx
+++ b/svx/qa/unit/customshapes.cxx
@@ -39,6 +39,8 @@
 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -1304,6 +1306,77 @@ CPPUNIT_TEST_FIXTURE(CustomshapesTest, 
testTdf148501_OctagonBevel)
 nColorDistance = aExpectedColor.GetColorError(aActualColor);
 CPPUNIT_ASSERT_LESS(sal_uInt16(6), nColorDistance);
 }
+
+bool lcl_getShapeSegments(uno::Sequence& 
rSegments,
+  const uno::Reference& xShape)
+{
+uno::Reference xShapeProps(xShape, 
uno::UNO_QUERY_THROW);
+uno::Any anotherAny = xShapeProps->getPropertyValue("CustomShapeGeometry");
+uno::Sequence aCustomShapeGeometry;
+if (!(anotherAny >>= aCustomShapeGeometry))
+return false;
+uno::Sequence aPathProps;
+for (beans::PropertyValue const& rProp : 
std::as_const(aCustomShapeGeometry))
+{
+if (rProp.Name == "Path")
+{
+rProp.Value >>= aPathProps;
+break;
+}
+}
+
+for (beans::PropertyValue const& rProp : std::as_const(aPathProps))
+{
+if (rProp.Name == "Segments")
+{
+rProp.Value >>= rSegments;
+break;
+}
+}
+if (rSegments.getLength() > 2)
+return true;
+else
+return false;
+}
+
+CPPUNIT_TEST_FIXTURE(CustomshapesTest, testTdf148714_CurvedArrows)
+{
+// Error was, that the line between 1. and 2. arc was missing.
+OUString sURL = m_directories.getURLFromSrc(sDataDirectory) + 
"tdf148714_CurvedArrows.ppt";
+mxComponent = loadFromDesktop(sURL, 
"com.sun.star.presentation.PresentationDocument");
+
+for (sal_Int32 nShapeIndex = 0; nShapeIndex < 4; nShapeIndex++)
+{
+uno::Reference xShape(getShape(nShapeIndex));
+uno::Sequence aSegments;
+CPPUNIT_ASSERT(lcl_getShapeSegments(aSegments, xShape));
+
+if (nShapeIndex == 0 || nShapeIndex == 3)
+{
+// curvedDownArrow or curvedLeftArrow. Segments should start with 
VW. Without fix it was
+// V with count 2, which means VV.
+CPPUNIT_ASSERT_EQUAL(
+
sal_Int16(drawing::EnhancedCustomShapeSegmentCommand::CLOCKWISEARC),
+aSegments[0].Command);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), aSegments[0].Count);
+CPPUNIT_ASSERT_EQUAL(
+
sal_Int16(drawing::EnhancedCustomShapeSegmentCommand::CLOCKWISEARCTO),
+aSegments[1].Command);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), aSegments[1].Count);
+}
+else
+{
+// curvedUpArrow or curvedRightArrow. Segments should start with 
BA. Without fix is was
+// B with count 2, which means BB.
+
CPPUNIT_ASSERT_EQUAL(sal_Int16(drawing::EnhancedCustomShapeSegmentCommand::ARC),
+ aSegments[0].Command);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), aSegments[0].Count);
+
CPPUNIT_ASSERT_EQUAL(sal_Int16(drawing::EnhancedCustomShapeSegmentCommand::ARCTO),
+ aSegments[1].Command);
+CPPUNIT_ASSERT_EQUAL(sal_Int16(1), aSegments[1].Count);
+}
+}
+}
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/qa/unit/data/tdf148714_CurvedArrows.ppt 
b/svx/qa/unit/data/tdf148714_CurvedArrows.ppt
new file mode 100644
index ..23e4ed0ad3eb
Binary files /dev/null and b/svx/qa/unit/data/tdf148714_CurvedArrows.ppt differ
diff --git 

[Libreoffice-bugs] [Bug 148714] shapes of type "curved*Arrow" use wrong commands in segments definition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148714

--- Comment #2 from Commit Notification 
 ---
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4cfe46997eab3498cc519ef94c85ad2d644d3886

tdf#148714 connect first and second arc with arcTo

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148714] shapes of type "curved*Arrow" use wrong commands in segments definition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148714

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144653] The command ".uno:ExportToPDF" ignore all given options in FilterData argument.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144653

--- Comment #1 from grv0815  ---
With the help of the Ask LibreOffice Community, I have found the error in my
code collecting the filter arguments.

The command ".uno:ExportToPDF" works perfect!

This Ask LibreOffice post contain the details:
https://ask.libreoffice.org/t/der-filter-writer-pdf-export-ignoriert-alle-argumente-aus-den-mitgegebenen-filterdata-properties/68343/6?u=grv0815

This bug report can be closed.
I'm sorry for my false positive report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148581] Navigator pane not showed although option is activated by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148581

--- Comment #1 from xtrailrunner  ---
Although I'm still using LibreOffice 6.4.7.2 the unwanted behaviour disappeared
in LO Writer and LO Calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148843] Function AGGREGATE bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148843

--- Comment #1 from Yoshikawa Yusuke  ---
Created attachment 179833
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179833=edit
Calculating buggy

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[Luboš Luňák (via logerrit)]

 vcl/source/gdi/impglyphitem.cxx |   10 ++
 1 file changed, 10 insertions(+)

New commits:
commit 467f2c50a935efff6ff8911e7282ecea535665a3
Author: Luboš Luňák 
AuthorDate: Thu Apr 28 20:04:52 2022 +0200
Commit: Luboš Luňák 
CommitDate: Fri Apr 29 06:57:42 2022 +0200

hack for glyph subset being different because of space being RTL

This is a rather weird corner case than I can see only with
JunitTest_svx_unoapi failing without this, when asking to lay out
characters 7-9 from "paragraph 1" with layout mode set to RTL.

Change-Id: Ic55e571a5934ea2b9de2f09b7c066abf014ac212
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133578
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index b313cf8967e2..e66a5bad1a2d 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -165,6 +165,16 @@ SalLayoutGlyphsImpl* 
SalLayoutGlyphsImpl::cloneCharRange(sal_Int32 index, sal_In
 if (pos->IsUnsafeToBreak() || (pos->IsInCluster() && 
!pos->IsClusterStart()))
 return nullptr;
 }
+// HACK: If mode is se to be RTL, but the last glyph is a non-RTL space,
+// then making a subset would give a different result than the actual 
layout,
+// because the weak BiDi mode code in ImplLayoutArgs ctor would interpret
+// the string subset ending with space as the space being RTL, but it would
+// treat it as non-RTL for the whole string if there would be more non-RTL
+// characters after the space. So bail out.
+if (GetFlags() & SalLayoutFlags::BiDiRtl && !rtl && !copy->empty() && 
copy->back().IsSpacing())
+{
+return nullptr;
+}
 return copy.release();
 }
 

[Libreoffice-commits] core.git: vcl/source

[Luboš Luňák (via logerrit)]

 vcl/source/gdi/CommonSalLayout.cxx |5 +
 vcl/source/outdev/font.cxx |3 +++
 2 files changed, 8 insertions(+)

New commits:
commit 3d7ca1bd1c4cc9d468ae214ecb497f71bad340f8
Author: Luboš Luňák 
AuthorDate: Thu Apr 28 15:24:07 2022 +0200
Commit: Luboš Luňák 
CommitDate: Fri Apr 29 06:57:24 2022 +0200

don't try to find glyph font fallback for null character

Change-Id: I53000b4da6e208774d5e8c23948474e2e9a1cf3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133561
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/vcl/source/gdi/CommonSalLayout.cxx 
b/vcl/source/gdi/CommonSalLayout.cxx
index 0007e3f355d1..e2b9e79bfba4 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -165,6 +165,11 @@ void 
GenericSalLayout::SetNeedFallback(vcl::text::ImplLayoutArgs& rArgs, sal_Int
 if (nCharPos < 0 || mbFuzzing)
 return;
 
+// Do not try to find fallback for null character, as that is pointless 
and it would break
+// searching for it (the broken ofz34898-1.doc document triggers this).
+if (rArgs.mrStr[nCharPos] == '\0')
+return;
+
 using namespace ::com::sun::star;
 
 if (!mxBreak.is())
diff --git a/vcl/source/outdev/font.cxx b/vcl/source/outdev/font.cxx
index ba487b0198c3..de3a0726c72c 100644
--- a/vcl/source/outdev/font.cxx
+++ b/vcl/source/outdev/font.cxx
@@ -1208,7 +1208,10 @@ std::unique_ptr 
OutputDevice::ImplGlyphFallbackLayout( std::unique_pt
 bool bRTL = false;
 OUStringBuffer aMissingCodeBuf(512);
 while (rLayoutArgs.GetNextPos( , ))
+{
+assert(rLayoutArgs.mrStr[nCharPos] != '\0');
 aMissingCodeBuf.append(rLayoutArgs.mrStr[nCharPos]);
+}
 rLayoutArgs.ResetPos();
 OUString aMissingCodes = aMissingCodeBuf.makeStringAndClear();
 

[Libreoffice-commits] core.git: config_host/config_features.h.in config_host/config_validation.h.in configure.ac test/source

[Luboš Luňák (via logerrit)]

 config_host/config_features.h.in   |   13 -
 config_host/config_validation.h.in |   14 ++
 configure.ac   |1 +
 test/source/bootstrapfixture.cxx   |2 +-
 4 files changed, 16 insertions(+), 14 deletions(-)

New commits:
commit 2e33af67e04da39116a1dc9fda96d961ae0a4bd5
Author: Luboš Luňák 
AuthorDate: Thu Apr 28 18:17:12 2022 +0200
Commit: Luboš Luňák 
CommitDate: Fri Apr 29 06:55:04 2022 +0200

move HAVE_EXPORT_VALIDATION from config_features.h

So that so much stuff doesn't get rebuilt on --with-java change.

Change-Id: I87388590a4fd218fd22e68ba0edd290831f6f0fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133570
Tested-by: Jenkins
Reviewed-by: Luboš Luňák 

diff --git a/config_host/config_features.h.in b/config_host/config_features.h.in
index de3e9d58f7d2..867258e262db 100644
--- a/config_host/config_features.h.in
+++ b/config_host/config_features.h.in
@@ -76,19 +76,6 @@
 
 #define HAVE_FEATURE_READONLY_INSTALLSET 0
 
-/*
- * Whether to use validation on files.
- */
-#define HAVE_EXPORT_VALIDATION 0
-
-/*
- * Whether to use export validation of binary formats (doc, xls, ppt)
- *
- * Requires installed Microsoft Office Binary File Format Validator
- * https://www.microsoft.com/en-us/download/details.aspx?id=26794
- */
-#define HAVE_BFFVALIDATOR 0
-
 /*
  * Whether we support breakpad as crash reporting lib.
  */
diff --git a/config_host/config_validation.h.in 
b/config_host/config_validation.h.in
new file mode 100644
index ..892dd1262c90
--- /dev/null
+++ b/config_host/config_validation.h.in
@@ -0,0 +1,14 @@
+#pragma once
+
+/*
+ * Whether to use validation on files.
+ */
+#define HAVE_EXPORT_VALIDATION 0
+
+/*
+ * Whether to use export validation of binary formats (doc, xls, ppt)
+ *
+ * Requires installed Microsoft Office Binary File Format Validator
+ * https://www.microsoft.com/en-us/download/details.aspx?id=26794
+ */
+#define HAVE_BFFVALIDATOR 0
diff --git a/configure.ac b/configure.ac
index a43d6bddd344..b40d16003d44 100644
--- a/configure.ac
+++ b/configure.ac
@@ -14722,6 +14722,7 @@ AC_CONFIG_HEADERS([config_host/config_options_calc.h])
 AC_CONFIG_HEADERS([config_host/config_zxing.h])
 AC_CONFIG_HEADERS([config_host/config_skia.h])
 AC_CONFIG_HEADERS([config_host/config_typesizes.h])
+AC_CONFIG_HEADERS([config_host/config_validation.h])
 AC_CONFIG_HEADERS([config_host/config_vendor.h])
 AC_CONFIG_HEADERS([config_host/config_vcl.h])
 AC_CONFIG_HEADERS([config_host/config_vclplug.h])
diff --git a/test/source/bootstrapfixture.cxx b/test/source/bootstrapfixture.cxx
index c13caf807d1e..be273f0a1955 100644
--- a/test/source/bootstrapfixture.cxx
+++ b/test/source/bootstrapfixture.cxx
@@ -7,7 +7,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#include 
+#include 
 
 #include 
 #include 

[Libreoffice-bugs] [Bug 148843] New: Function AGGREGATE bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148843

Bug ID: 148843
   Summary: Function AGGREGATE bug
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yoshikawa...@yamaha-motor.co.jp

Description:
When the error is ignored by sum in the AGGREGATE function, the cell specified
next to the error cell is not summed.

Steps to Reproduce:
1.Enter numbers in some cells
2.Create a cell where the calculation formula becomes an error (example: = 1/0)
3.Calculate with the AGGREGATE function.(AGGREGATE(9,6,x,y,z,Error cell,...)

Actual Results:
The number in the cell to calculate before the error cell is ignored.

Expected Results:
I do not understand.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
If you put a number in the error cell, it will be calculated normally.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148568] Rework the Sparklines dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148568

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148316] I would like an option to disable font margins.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148316

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148600] Wrong encoding in the GUI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148600

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148592] FILESAVE RTF Text form field gets extra direct formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148592

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148589] default download mirror for thailand has been dead for about a year.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148589

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148587] Summary Slide and Expand Slide do not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148587

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148586] Slowdown cut, paste (4x), undo, cut action of a complex slide

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148586

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148581] Navigator pane not showed although option is activated by default

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148581

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148579] Print Preview jumps to a different page upon zooming in/out

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148579

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148569] Character highlighting: custom color color picker doesn't look properly with skia raster on macOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148569

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148564] FILEOPEN RTF Table with undefined left-right cell padding gets 0 padding

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148564

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148225] spaces are highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148225

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148128] Mark page center on horizontal and vertical rulers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148128

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148225] spaces are highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148225

--- Comment #7 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148128] Mark page center on horizontal and vertical rulers

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148128

--- Comment #9 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142586] Slow UI on Linux arm64 build (Pinebook Pro)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142586

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142586] Slow UI on Linux arm64 build (Pinebook Pro)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142586

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144806] LibreOffice does not start after installing version 7.1.6 with Dutch help pack 7.1.6.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144806

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144806] LibreOffice does not start after installing version 7.1.6 with Dutch help pack 7.1.6.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144806

--- Comment #3 from QA Administrators  ---
Dear Carel Paradies,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144792] installed new version 7.1.6_win_x64.msi and new version 7.1.6.win_x64 helpack_en-gb.msi would not open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144792

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144792] installed new version 7.1.6_win_x64.msi and new version 7.1.6.win_x64 helpack_en-gb.msi would not open

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144792

--- Comment #3 from QA Administrators  ---
Dear Kevin Barnes,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144725] Formulario nuevo registro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144725

--- Comment #4 from QA Administrators  ---
Dear ramon6419,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144725] Formulario nuevo registro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144725

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144690] Randomly crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144690

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144690] Randomly crashes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144690

--- Comment #3 from QA Administrators  ---
Dear bookdoctorgwen,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144670] clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144670] clipboard problem in LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=144670

--- Comment #7 from QA Administrators  ---
Dear J22Gim,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128161] Save after the file is opened, the ppt line spacing is reduced until 0

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128161

--- Comment #6 from QA Administrators  ---
Dear xiaohaodaye,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137899] The text present in a cell that is being edited will appear in a new sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137899

Justin L  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Whiteboard||target:7.4.0
 Status|NEW |RESOLVED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

--- Comment #10 from Justin L  ---
Interesting - no automatic merge notification even though the link to this bug
report is intact. Anyway, the patch was merged.

tdf#137899 sc: accept any unfinished editing before adding sheet
https://gerrit.libreoffice.org/c/core/+/126501

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148225] spaces are highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148225

--- Comment #6 from mois...@hushmail.com ---
I would love it if you could fix it and, again, apologies for the negativity!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148225] spaces are highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148225

--- Comment #5 from mois...@hushmail.com ---
When I first started using the product, Libre office highlighted EVERY space.
Over the years it has become fewer and fewer. And just like the car that you
take to the mechanic that refuses to make the noise when you get therethe
screen shot I got just happened to have only a few spaces highlighted.
typically it is much more. but even one highlighted space is nuts. Sorry. it
just drives me batty. No other program does that, as far as I have seen.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148225] spaces are highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148225

--- Comment #4 from mois...@hushmail.com ---
Created attachment 179832
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179832=edit
highlighted spaces

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148225] spaces are highlighted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148225

--- Comment #3 from mois...@hushmail.com ---
Created attachment 179831
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179831=edit
screen shot highlights spaces

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148836] Categories in Customize keyboard dialog should be alphabetized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148836

Jim Raykowski  changed:

   What|Removed |Added

 CC||rayk...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Jim Raykowski  ---
code pointers:

 cui/source/inc/cfgutil.hxx 
 cui/source/customize/cfgutil.cxx

 In CuiConfigGroupListBox::Init add m_xTreeView->make_sorted()
 after m_xTreeView->thaw().

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148836] Categories in Customize keyboard dialog should be alphabetized

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148836

Jim Raykowski  changed:

   What|Removed |Added

 CC||rayk...@gmail.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Jim Raykowski  ---
code pointers:

 cui/source/inc/cfgutil.hxx 
 cui/source/customize/cfgutil.cxx

 In CuiConfigGroupListBox::Init add m_xTreeView->make_sorted()
 after m_xTreeView->thaw().

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 46037] Clean up uses of comphelper/configurationhelper.hxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=46037

--- Comment #44 from Michael Meeks  ---
Are any of these still do-able? looking for openConfig's - it seems that most
of the remaining paths to folders are constructed by string concatenation which
doesn't lend itself to compile time wrapper use, particularly since there are
no generated wrappers for XNameAccess we can ::get() for directories (that I
could see with a quick poke) - did I miss something =)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

[Justin Luth (via logerrit)]

 sc/source/ui/view/tabcont.cxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 83d0f2eebae41d431d9a5bfd1a918523977752d0
Author: Justin Luth 
AuthorDate: Wed Dec 8 07:06:45 2021 +0200
Commit: Eike Rathke 
CommitDate: Thu Apr 28 23:50:39 2022 +0200

tdf#137899 sc: accept any unfinished editing before adding sheet

There might be a more general place where this belongs,
to cover other similar kinds of situations.
However, putting it here is very targetted,
and shouldn't get me into unanticipated trouble.

Any changes made in the "top view" need to be accepted before
they are committed. In this case, the user switched gears
and added a new sheet while in the process of editing.
So what should happen here? Should we commit the change
before changing task? Perhaps. Certainly it should
NOT show up on the new sheet - but that is what was happening.

Accepting the change when the user gets side-tracked is the norm
in cases like print-preview, switching to another soffice app,
or simply clicking on a different cell or switching tabs.
So auto-accepting in this situation is consistent behaviour.

Change-Id: I4f3f0103ad4fcc1aa8a0c6118383b63ace07ff5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126501
Tested-by: Jenkins
Reviewed-by: Justin Luth 
Reviewed-by: Eike Rathke 

diff --git a/sc/source/ui/view/tabcont.cxx b/sc/source/ui/view/tabcont.cxx
index a95df55b98d8..a15b1c20e54b 100644
--- a/sc/source/ui/view/tabcont.cxx
+++ b/sc/source/ui/view/tabcont.cxx
@@ -234,6 +234,11 @@ void ScTabControl::AddTabClick()
 ScModule* pScMod = SC_MOD();
 if (!rDoc.IsDocEditable() || pScMod->IsTableLocked())
 return;
+
+// auto-accept any in-process input - which would otherwise end up on the 
new sheet
+if (!pScMod->IsFormulaMode())
+pScMod->InputEnterHandler();
+
 OUString aName;
 rDoc.CreateValidTabName(aName);
 SCTAB nTabCount = rDoc.GetTableCount();

[Libreoffice-bugs] [Bug 90439] EDITING : Unhide of first column is impossible by mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90439

--- Comment #9 from Laurent Lyaudet  ---
The bug is still here :
Version: 7.3.2.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Ubuntu package version: 1:7.3.2-0ubuntu2
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: xmlsecurity/source

[Thorsten Behrens (via logerrit)]

 xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit b7a37d6fb9fc21afc77964de725d5143f5aad435
Author: Thorsten Behrens 
AuthorDate: Thu Apr 28 16:19:36 2022 +
Commit: Thorsten Behrens 
CommitDate: Thu Apr 28 23:23:08 2022 +0200

Fix system-nss: add hasht.h header back

Revert part of 02e1be8883a08ab17f3e890a834ab88f13c5867d which broke
with-system-nss builds - the hasht.h header was actually needed.

Change-Id: Ida36bc6cd91f0a9b26a2029f1cab835f90f40dde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133571
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx 
b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
index bf1da39b3fec..b75d73bb0a89 100644
--- a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
@@ -22,6 +22,7 @@
 
 #include 
 #include 
+#include 
 
 #include 
 #include 

[Libreoffice-bugs] [Bug 145596] provide word count annotation to document canvas, alternative to current line count

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145596

tripleo  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|---
 Status|RESOLVED|REOPENED

--- Comment #8 from tripleo  ---
Nobody commented on my comment #3. (Or 4 for that matter)

There may be opposition to include this in the mainline.

I am happy to hack on it myself.  I have distro packages installed, but I
mainly run a self compiled build.

If I could get some pointers on how to begin with this, I would happily
maintain it for myself.

Another consideration is can this type of functionality be made available
through a plugin?


tl;dr:

1a) Where is the line count code in Writer?
1b) Where is the word count code in Writer?

2) What are the limitations of the plugin architecture?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 145596] provide word count annotation to document canvas, alternative to current line count

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145596

tripleo  changed:

   What|Removed |Added

 Resolution|INSUFFICIENTDATA|---
 Status|RESOLVED|REOPENED

--- Comment #8 from tripleo  ---
Nobody commented on my comment #3. (Or 4 for that matter)

There may be opposition to include this in the mainline.

I am happy to hack on it myself.  I have distro packages installed, but I
mainly run a self compiled build.

If I could get some pointers on how to begin with this, I would happily
maintain it for myself.

Another consideration is can this type of functionality be made available
through a plugin?


tl;dr:

1a) Where is the line count code in Writer?
1b) Where is the word count code in Writer?

2) What are the limitations of the plugin architecture?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 142840] FILESAVE DOC Hyperlinks to bookmarks break when saving to .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142840

Aron Budea  changed:

   What|Removed |Added

Version|6.3.0.4 release |6.0.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108288] [META] Bookmark bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108288

Aron Budea  changed:

   What|Removed |Added

 Depends on||142840


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142840
[Bug 142840] FILESAVE DOC Hyperlinks to bookmarks break when saving to .doc
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142840] FILESAVE DOC Hyperlinks to bookmarks break when saving to .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142840

Aron Budea  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||3090
 Blocks||108288
 CC||vasily.melenc...@cib.de

--- Comment #4 from Aron Budea  ---
This is a regression from the following commit, bibisected using
bibisect-linux-64-6.0. Adding CC: to Vasily Melenchuk.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=aa3c0ddc61726f9e2e927e08966acd63a3fcf968
author  Vasily Melenchuk   2017-09-05
21:30:06 +0300
committer   Thorsten Behrens   2017-09-07
15:03:08 +0200

tdf#103090 replace spaces by underscore in bookmark names for DOCX.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108288
[Bug 108288] [META] Bookmark bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Caolán McNamara (via logerrit)]

 sw/qa/extras/layout/data/abi11870-2.odt |binary
 1 file changed

New commits:
commit 972819fe36e5d59fd11b3b40d432f5270ae98bfb
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 14:23:31 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 22:17:01 2022 +0200

avoid a glyph fallback in writerlayout test

replace the obscure graphemes with a bullet that exists in the font

Change-Id: Ib95ae2a8f83a04a3a8b32cf3f7d9d1ecaf7d5f8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133564
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/data/abi11870-2.odt 
b/sw/qa/extras/layout/data/abi11870-2.odt
index 295e91bbdd50..3091f2c9b0a1 100644
Binary files a/sw/qa/extras/layout/data/abi11870-2.odt and 
b/sw/qa/extras/layout/data/abi11870-2.odt differ

[Libreoffice-commits] core.git: sw/qa

[Caolán McNamara (via logerrit)]

 sw/qa/extras/layout/data/abi11870-2.odt |binary
 1 file changed

New commits:
commit 1d59798a17b35ea9b508728809cf793520f06ab9
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 14:08:23 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 22:16:40 2022 +0200

Linux Libertine -> Linux Libertine G for repeatable results

Change-Id: I42ec2b6b0a42428f7a322ffd96fadb96ef0e7678
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133563
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/data/abi11870-2.odt 
b/sw/qa/extras/layout/data/abi11870-2.odt
index b02bb85646aa..295e91bbdd50 100644
Binary files a/sw/qa/extras/layout/data/abi11870-2.odt and 
b/sw/qa/extras/layout/data/abi11870-2.odt differ

[Libreoffice-bugs] [Bug 148842] New: Chinese search function not working properly while working with multiple LibreOffice Writer files that each files are larger than 5M in size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148842

Bug ID: 148842
   Summary: Chinese search function not working properly while
working with multiple LibreOffice Writer files that
each files are larger than 5M in size
   Product: LibreOffice
   Version: 7.3.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: george.socie.assn.uk@gmail.com

Chinese search function not working properly while working with multiple
LibreOffice Writer files that each files are larger than 5M in size. Especially
when the PC is working with multiple Chrome cloned web browsers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148432

--- Comment #16 from Caolán McNamara  ---
Maybe table of contents dialog? and some bookmark/index selecting dialogs, not
sure off the top of my head but presumably of lesser importance than the
already mentioned cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148432

--- Comment #15 from Eyal Rozenberg  ---
(In reply to Caolán McNamara from comment #14)
> if there was only two places

You can check... the relevant criterion is inserting runs of text from the
document into the UI. Obviously that's not done often.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - vcl/source

[Julien Nabet (via logerrit)]

 vcl/source/filter/itiff/itiff.cxx |   34 +++---
 1 file changed, 7 insertions(+), 27 deletions(-)

New commits:
commit ab3bfc464f681c715f04b6c3135b850bab8576d3
Author: Julien Nabet 
AuthorDate: Mon Apr 18 12:26:39 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Apr 28 21:20:40 2022 +0200

Following tdf#142151: Red cast rendered in 16 bit TIFF image

Just simplify by merging both almost identical parts.

Change-Id: I1658621609e10312feed530090adfa873602d2f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133115
Tested-by: Jenkins
(cherry picked from commit dc97aac5cdfa3789d4e71e9d92df6e7e68802825)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133485
Reviewed-by: Xisco Fauli 

diff --git a/vcl/source/filter/itiff/itiff.cxx 
b/vcl/source/filter/itiff/itiff.cxx
index 25c8af8b6582..cad78f1b7d1f 100644
--- a/vcl/source/filter/itiff/itiff.cxx
+++ b/vcl/source/filter/itiff/itiff.cxx
@@ -902,7 +902,10 @@ bool TIFFReader::ConvertScanline(sal_Int32 nY)
 }
 }
 }
-else if ( nPhotometricInterpretation == 2 && nSamplesPerPixel >= 3 )
+else if (
+   ( nPhotometricInterpretation == 2 && nSamplesPerPixel >= 3 ) ||
+   ( nPhotometricInterpretation == 5 && nSamplesPerPixel == 3 )
+)
 {
 if ( nMaxSampleValue > nMinSampleValue )
 {
@@ -921,33 +924,10 @@ bool TIFFReader::ConvertScanline(sal_Int32 nY)
 nGreen = GetBits( getMapData(1), nx * nBitsPerSample, 
nBitsPerSample );
 nBlue = GetBits( getMapData(2), nx * nBitsPerSample, 
nBitsPerSample );
 }
-SetPixel(nY, nx, Color(static_cast(nRed - 
nMinMax), static_cast(nGreen - nMinMax), 
static_cast(nBlue - nMinMax)));
-}
-}
-}
-else if ( nPhotometricInterpretation == 5 && nSamplesPerPixel == 3 )
-{
-if ( nMaxSampleValue > nMinSampleValue )
-{
-sal_uInt32 nMinMax =  nMinSampleValue * 255 / ( 
nMaxSampleValue - nMinSampleValue );
-for (sal_Int32 nx = 0; nx < nImageWidth; ++nx)
-{
-if ( nPlanes < 3 )
-{
-nRed = GetBits( getMapData(0), ( nx * nSamplesPerPixel 
+ 0 ) * nBitsPerSample, nBitsPerSample );
-nGreen = GetBits( getMapData(0), ( nx * 
nSamplesPerPixel + 1 ) * nBitsPerSample, nBitsPerSample );
-nBlue = GetBits( getMapData(0), ( nx * 
nSamplesPerPixel + 2 ) * nBitsPerSample, nBitsPerSample );
-}
+if (nPhotometricInterpretation == 2)
+SetPixel(nY, nx, Color(static_cast(nRed - 
nMinMax), static_cast(nGreen - nMinMax), 
static_cast(nBlue - nMinMax)));
 else
-{
-nRed = GetBits( getMapData(0), nx * nBitsPerSample, 
nBitsPerSample );
-nGreen = GetBits( getMapData(1), nx * nBitsPerSample, 
nBitsPerSample );
-nBlue = GetBits( getMapData(2), nx * nBitsPerSample, 
nBitsPerSample );
-}
-nRed = 255 - static_cast( nRed - nMinMax );
-nGreen = 255 - static_cast( nGreen - nMinMax );
-nBlue = 255 - static_cast( nBlue - nMinMax );
-SetPixel(nY, nx, Color(static_cast(nRed), 
static_cast(nGreen), static_cast(nBlue)));
+SetPixel(nY, nx, Color(255 - 
static_cast(nRed - nMinMax), 255 - static_cast(nGreen - 
nMinMax), 255 - static_cast(nBlue - nMinMax)));
 }
 }
 }

[Libreoffice-commits] core.git: vcl/qa

[Xisco Fauli (via logerrit)]

 vcl/qa/cppunit/graphicfilter/data/tiff/tdf74331.tif |binary
 vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx  |   51 
 2 files changed, 51 insertions(+)

New commits:
commit 49ce19a824700b2011334a6739ae2749e781155f
Author: Xisco Fauli 
AuthorDate: Thu Apr 28 13:45:38 2022 +0200
Commit: Xisco Fauli 
CommitDate: Thu Apr 28 21:20:15 2022 +0200

tdf#74331: vcl_filters: Add unittest

Change-Id: Ia93f5f5f3ca5b4ddd51d68335af7f1c7b79b5c31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133551
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/vcl/qa/cppunit/graphicfilter/data/tiff/tdf74331.tif 
b/vcl/qa/cppunit/graphicfilter/data/tiff/tdf74331.tif
new file mode 100644
index ..702b8218ca5f
Binary files /dev/null and 
b/vcl/qa/cppunit/graphicfilter/data/tiff/tdf74331.tif differ
diff --git a/vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx 
b/vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx
index 24ce5492d3be..77e412088bf3 100644
--- a/vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx
+++ b/vcl/qa/cppunit/graphicfilter/filters-tiff-test.cxx
@@ -45,6 +45,7 @@ public:
 void testTdf126460();
 void testTdf115863();
 void testTdf138818();
+void testTdf74331();
 void testRoundtrip();
 void testRGB8bits();
 void testRGB16bits();
@@ -54,6 +55,7 @@ public:
 CPPUNIT_TEST(testTdf126460);
 CPPUNIT_TEST(testTdf115863);
 CPPUNIT_TEST(testTdf138818);
+CPPUNIT_TEST(testTdf74331);
 CPPUNIT_TEST(testRoundtrip);
 CPPUNIT_TEST(testRGB8bits);
 CPPUNIT_TEST(testRGB16bits);
@@ -128,6 +130,55 @@ void TiffFilterTest::testTdf138818()
 CPPUNIT_ASSERT_EQUAL(sal_uInt32(46428), 
aGraphic.GetGfxLink().GetDataSize());
 }
 
+void TiffFilterTest::testTdf74331()
+{
+OUString aURL = getUrl() + "tdf74331.tif";
+SvFileStream aFileStream(aURL, StreamMode::READ);
+Graphic aGraphic;
+GraphicFilter& rFilter = GraphicFilter::GetGraphicFilter();
+
+ErrCode bResult = rFilter.ImportGraphic(aGraphic, aURL, aFileStream);
+
+CPPUNIT_ASSERT_EQUAL(ERRCODE_NONE, bResult);
+
+Bitmap aBitmap = aGraphic.GetBitmapEx().GetBitmap();
+Size aSize = aBitmap.GetSizePixel();
+CPPUNIT_ASSERT_EQUAL(tools::Long(200), aSize.Width());
+CPPUNIT_ASSERT_EQUAL(tools::Long(200), aSize.Height());
+
+Bitmap::ScopedReadAccess pReadAccess(aBitmap);
+
+// Check the image contains different kinds of grays
+int nGrayCount = 0;
+int nGray3Count = 0;
+int nGray7Count = 0;
+int nLightGrayCount = 0;
+
+for (tools::Long nX = 1; nX < aSize.Width() - 1; ++nX)
+{
+for (tools::Long nY = 1; nY < aSize.Height() - 1; ++nY)
+{
+const Color aColor = pReadAccess->GetColor(nY, nX);
+if (aColor == COL_GRAY)
+++nGrayCount;
+else if (aColor == COL_GRAY3)
+++nGray3Count;
+else if (aColor == COL_GRAY7)
+++nGray7Count;
+else if (aColor == COL_LIGHTGRAY)
+++nLightGrayCount;
+}
+}
+
+// Without the fix in place, this test would have failed with
+// - Expected: 313
+// - Actual  : 0
+CPPUNIT_ASSERT_EQUAL(313, nGrayCount);
+CPPUNIT_ASSERT_EQUAL(71, nGray3Count);
+CPPUNIT_ASSERT_EQUAL(227, nGray7Count);
+CPPUNIT_ASSERT_EQUAL(165, nLightGrayCount);
+}
+
 void TiffFilterTest::testRoundtrip()
 {
 Bitmap aBitmap(Size(2, 2), vcl::PixelFormat::N24_BPP);

[Libreoffice-bugs] [Bug 148756] Document Type in Options dialog should correspond to the application that opened the dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148756

Jim Raykowski  changed:

   What|Removed |Added

 CC||rayk...@gmail.com

--- Comment #3 from Jim Raykowski  ---
code pointers:

  cui/uiconfig/ui/optsave.ui
  cui/source/options/optsave.hxx
  cui/source/options/optsave.cxx

  void SvxSaveTabPage::Reset
  m_xDocTypeLB set_active_id

  hints on how to identify the module:
  cui/source/customize/acccfg.cxx SfxAcceleratorConfigPage::InitAccCfg
  git grep -n 'xModuleManager->identify'

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: SalAbort:Unspecified application error

[Michael Weghorn]

On 28/04/2022 05.04, di liu wrote:

Thank you for your response ^_^

The video appears to be inaccessible unless access has specifically been
granted in Google Drive.

I am sorry, have made it

  Does that device have a 64-bit ARM processor?

Yeah ,my device abi is arm64-v8a,And the so is compiled for armeabi-v7a

i.e. the crash is not 100% reproducible? Can you give a rough estimation
of how often it happens? (like "almost always", "about every third
time",...)?

almost always

  It might also help to share a sample doc (e.g. attaching one to a bug

report on Bugzilla) if it happens more often with specific files.
see the accessories


Thanks for sharing the video and a sample file. With those, I can 
reproduce a crash.


Is that file confidential or can it be shared publicly (attached to a 
Bugzilla ticket)? (I can't read most of the text in it. :-))



What does your autogen.input look like? (Or what options are you passing
to ./autogen.sh manually?)

passing nothing to ./autogen.sh
the autogen.input containing this:
--with-distro=LibreOfficeAndroid
--with-android-sdk=/home/disco/Documents/dev_env/android_sdk
--with-android-ndk=/home/disco/Documents/dev_env/android_sdk/ndk/20.1.5948944
--with-ant-home=/home/disco/Documents/dev_env/apache-ant-1.10.12
--enable-debug
--enable-symbols="vcl/source/app/"

For a 64-bit ARM debug build, using LLD with NDK 22.1.7171670 worked for
me in the past, by applying this change on top of master:
https://gerrit.libreoffice.org/c/core/+/130947


and then using an autogen.input containing this:

--build=x86_64-unknown-linux-gnu
--with-android-ndk=/home/michi/Android/Sdk/ndk/21.0.6113669
--with-android-sdk=/home/michi/Android/Sdk
--with-distro=LibreOfficeAndroidAarch64
--enable-sal-log
--with-external-tar=/home/michi/development/libreoffice-external
--enable-ccache
--enable-ld=lld
--enable-dbgutil
--with-jdk-home=/usr/lib/jvm/java-11-openjdk-amd64/

If i want to build debug version so must build a 64-bit ?


I suppose, in theory, 32-bit should also work. My practical experience 
with the Android toolchain was that several things that should work in 
theory didn't work in reality, and trying a different architecture, NDK 
version, or linker could give better results.


Trying an x86 or x86_64 AVD might also be worth trying.
A dbgutil build works fine for me on a Debian testing machine with 16 GB 
of RAM and an autogen.input containing


--build=x86_64-unknown-linux-gnu
--with-android-ndk=/home/michi/Android/Sdk/ndk/20.0.5594570/
--with-android-sdk=/home/michi/Android/Sdk
--with-distro=LibreOfficeAndroidX86
--enable-sal-log
--enable-ccache
--enable-dbgutil
--with-jdk-home=/usr/lib/jvm/java-11-openjdk-amd64/

so with your config that uses --enable-debug and restricts for what 
modules symbols are enabled, even less should be needed.



Addition:
Yesterday i use "bugreport" command on my device and found below logs:

04-27 15:53:50.551 10316  3015  3287 W libc    : malloc(2292954)
failed: returning null pointer
04-27 15:53:50.552  1000  2433  6251 I chatty  : uid=1000(system)
Binder:2433_6 expire 4 lines
04-27 15:53:50.553 10316  3015  3287 E LibreOffice/androidinst:
SalAbort: 'Unspecified application error'


There have a log "malloc(2292954) failed: returning null pointer" before 
the error 'Unspecified application error' (both of them come from my 
app(pid=10316))
So i wonder if it is possible that the crash was happened in java ? 
Because i found every time i slide the screen it's will trigger the 
render redraw which will trigger allocate a direct buffer


From what I have seen so far, the problem is that the app/system is 
running out of memory, caused by a memory leak on the C++ side.


Can you try whether the demo patch at 
https://gerrit.libreoffice.org/c/core/+/133581 makes the crash go away 
for you as well?


At least with the experimental editing mode disabled, this worked here.
I haven't tried with experimental mode enabled yet, which was running 
out of memory earlier without the patch in place, and was showing 
another out-of-memory-related error in the ADB log ouput with an x86 
debug build.


(The patch is obviously not meant to be merged as is, just a demo where 
the problem is.)


PS: Adding dev list back to the conversation.

[Libreoffice-bugs] [Bug 148838] Comment puis-je corriger cette erreur ?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148838

Julien Nabet  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |serval2...@yahoo.fr
   |desktop.org |
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
Should be fixed now with
https://translations.documentfoundation.org/translate/libo_help-master/textscalc01/fr/?checksum=6e41ec0b3cd7a57f=note%3AoUhBB_by=-priority%2Cposition

Of course I just fixed this on Weblate so it must be synchronized with the
website and I can't tell what would be the delay.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: ucbhelper/source

[Noel Grandin (via logerrit)]

 ucbhelper/source/client/proxydecider.cxx |   19 +--
 1 file changed, 9 insertions(+), 10 deletions(-)

New commits:
commit d9c3f05dcb6c03633bbcc8d88e55237a0855d9a5
Author: Noel Grandin 
AuthorDate: Wed Apr 27 20:42:35 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Apr 28 20:56:18 2022 +0200

use more string_view in ucbhelper

Change-Id: Ief60eda8be8e184b9d637ab84fec2f8740c04396
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133554
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/ucbhelper/source/client/proxydecider.cxx 
b/ucbhelper/source/client/proxydecider.cxx
index 10228b72aedc..cf10fda8baa3 100644
--- a/ucbhelper/source/client/proxydecider.cxx
+++ b/ucbhelper/source/client/proxydecider.cxx
@@ -157,7 +157,7 @@ public:
 virtual void SAL_CALL disposing( const lang::EventObject& Source ) 
override;
 
 private:
-void setNoProxyList( const OUString & rNoProxyList );
+void setNoProxyList( std::u16string_view rNoProxyList );
 };
 
 
@@ -809,29 +809,28 @@ void SAL_CALL InternetProxyDecider_Impl::disposing(const 
lang::EventObject&)
 }
 
 
-void InternetProxyDecider_Impl::setNoProxyList(
-const OUString & rNoProxyList )
+void InternetProxyDecider_Impl::setNoProxyList( std::u16string_view 
rNoProxyList )
 {
 osl::Guard< osl::Mutex > aGuard( m_aMutex );
 
 m_aNoProxyList.clear();
 
-if ( rNoProxyList.isEmpty() )
+if ( rNoProxyList.empty() )
 return;
 
 // List of connection endpoints hostname[:port],
 // separated by semicolon. Wildcards allowed.
 
-sal_Int32 nPos = 0;
-sal_Int32 nEnd = rNoProxyList.indexOf( ';' );
-sal_Int32 nLen = rNoProxyList.getLength();
+size_t nPos = 0;
+size_t nEnd = rNoProxyList.find( ';' );
+size_t nLen = rNoProxyList.size();
 
 do
 {
-if ( nEnd == -1 )
+if ( nEnd == std::u16string_view::npos )
 nEnd = nLen;
 
-OUString aToken = rNoProxyList.copy( nPos, nEnd - nPos );
+OUString aToken( rNoProxyList.substr( nPos, nEnd - nPos ) );
 
 if ( !aToken.isEmpty() )
 {
@@ -910,7 +909,7 @@ void InternetProxyDecider_Impl::setNoProxyList(
 if ( nEnd != nLen )
 {
 nPos = nEnd + 1;
-nEnd = rNoProxyList.indexOf( ';', nPos );
+nEnd = rNoProxyList.find( ';', nPos );
 }
 }
 while ( nEnd != nLen );

[Libreoffice-bugs] [Bug 148432] Navigator never presents an RTL tree for RTL documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148432

Caolán McNamara  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #14 from Caolán McNamara  ---
wrt comment #8 if there was only two places where this was wanted I could see
it as practicable to implement. Widget::set_direction exists to override the
default UI direction for a widget so that capability exists. Possibly worth
exploring.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: test/user-template

[Caolán McNamara (via logerrit)]

 test/user-template/registry/modifications.xcd |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit ac1c31a577e6fb0efa05ff0ab098ee62f50cb88a
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 13:14:14 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 20:45:52 2022 +0200

set CJK_HEADING and CTL_HEADING for cppunit tests to something from 
more_fonts

Change-Id: Iabd60e6266f0543e258151aa1bc7199eb7edc35f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133559
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/test/user-template/registry/modifications.xcd 
b/test/user-template/registry/modifications.xcd
index b5162cb2a17a..55daed60eaec 100644
--- a/test/user-template/registry/modifications.xcd
+++ b/test/user-template/registry/modifications.xcd
@@ -16,6 +16,12 @@
 


+
+ DejaVu Sans
+
+
+ DejaVu Sans
+
 
  DejaVu Sans
 

[Libreoffice-bugs] [Bug 148790] UI: The No List button constantly highlighted when no some text isn't a list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148790

--- Comment #9 from Telesto  ---
(In reply to Eyal Rozenberg from comment #8)
> > However this does hit the fundamental question how much of the UI (and
> > logic) must be bend. And where the need for an dedicated UI begins. 
> 
> You mean, whether dependent checkboxes are appropriate at all? Otherwise I
> don't quite follow.

Sorry, I'm talk gibberish once in a while..

The no list feature got introduced because of screenreaders: NVDA & Orca
Screen readers are used for individuals who are blind or visually impaired.

The complaint for bug 115965 was: Screen readers read Number List and Bullet
list as check items. They should be read as radio items because only one can be
selected at a time.

So the introduction of 'No list' is triggered 'special group' of stakeholders
with specific needs. 

The ordered lists/unordered list are mutual exclusive, but can also be turned
on/off. The screenreading detecting the (un)ordered list checkbox being
'proper' from the on/off perspective. But makes les sense from the 'mutual
exclusive' perspective. Except if in that case the 'on/off' switch is missing..
which causes the introduction of No-List

Which is introduction a button 'exclusively' needed for people with screen
readers. There likely more area's where impaired people prefer a different UI
design (at least I assume so, I actually don't know). 

It's bit of slippery slope if we are start modifying the UI, and start adding
buttons like 'no list' without value for non-impaired and even breaking UI
logic  (and causing 'issues, like the 'bug' here)

Different targets groups have different requirements. A dedicated UI targeting
the visual impaired is likely always 'better' compared to long list of
compromises.. with lose-lose, win-lose situations.

So an UI template (in form of say an extension) might be better in the long
run. However this is depending on 'needs and desires' of impaired people. I'm
unable to make realistic assessment here. I have tendency to blow things out of
proportion

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: filter/source

[Bartosz Kosiorek (via logerrit)]

 filter/source/msfilter/msdffimp.cxx |   96 +++-
 1 file changed, 63 insertions(+), 33 deletions(-)

New commits:
commit 8c9e6d3a99df641f9c395c65f7b48225b8775baa
Author: Bartosz Kosiorek 
AuthorDate: Wed Apr 27 20:17:37 2022 +0200
Commit: Bartosz Kosiorek 
CommitDate: Thu Apr 28 20:40:09 2022 +0200

Add initial support OfficeArtBlip TIFF format

Additionally the magic number were replaced with enum
Change-Id: I7d825ec84ff5cd5ff315ee37613e3b84cb6f0567

Change-Id: Ic33022a0e225099f2397dd300f4792055184fd10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133526
Tested-by: Jenkins
Reviewed-by: Bartosz Kosiorek 

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 7fae12fc40ea..7c036227e8b8 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -171,6 +171,18 @@ static sal_uInt32 nMSOleObjCntr = 0;
 constexpr OUStringLiteral MSO_OLE_Obj = u"MSO_OLE_Obj";
 
 namespace {
+/* Office File Formats - 2.2.23  */
+enum class OfficeArtBlipRecInstance : sal_uInt32
+{
+EMF = 0x3D4, // defined in section 2.2.24.
+WMF = 0x216, // defined in section 2.2.25.
+PICT = 0x542, // as defined in section 2.2.26.
+JPEG_RGB = 0x46A, // defined in section 2.2.27.
+JPEG_CMYK = 0x6E2, // defined in section 2.2.27.
+PNG = 0x6E0, // defined in section 2.2.28.
+DIB = 0x7A8, // defined in section 2.2.29.
+TIFF = 0x6E4 // defined in section 2.2.30.
+};
 
 struct SvxMSDffBLIPInfo
 {
@@ -6479,40 +6491,42 @@ bool SvxMSDffManager::GetBLIPDirect( SvStream& 
rBLIPStream, Graphic& rData, tool
 boolbMtfBLIP = false;
 boolbZCodecCompression = false;
 // now position it exactly at the beginning of the embedded graphic
-sal_uLong nSkip = ( nInst & 0x0001 ) ? 32 : 16;
-
-switch( nInst & 0xFFFE )
+sal_uLong nSkip = (nInst & 0x0001) ? 32 : 16;
+const OfficeArtBlipRecInstance aRecInstanse = 
OfficeArtBlipRecInstance(nInst & 0xFFFE);
+switch (aRecInstanse)
 {
-case 0x216 :// Metafile header then compressed WMF
-case 0x3D4 :// Metafile header then compressed EMF
-case 0x542 :// Metafile hd. then compressed PICT
+case OfficeArtBlipRecInstance::EMF:
+case OfficeArtBlipRecInstance::WMF:
+case OfficeArtBlipRecInstance::PICT:
 {
-rBLIPStream.SeekRel( nSkip + 20 );
+rBLIPStream.SeekRel(nSkip + 20);
 
-// read in size of metafile in EMUS
+// read in size of metafile in English Metric Units (EMUs)
 sal_Int32 width(0), height(0);
-rBLIPStream.ReadInt32( width ).ReadInt32( height );
-aMtfSize100.setWidth( width );
-aMtfSize100.setHeight( height );
+rBLIPStream.ReadInt32(width).ReadInt32(height);
+aMtfSize100.setWidth(width);
+aMtfSize100.setHeight(height);
 
+// 1 EMU = 1/360,000 of a centimeter
 // scale to 1/100mm
-aMtfSize100.setWidth( aMtfSize100.Width() / 360 );
-aMtfSize100.setHeight( aMtfSize100.Height() / 360 );
+aMtfSize100.setWidth(aMtfSize100.Width() / 360);
+aMtfSize100.setHeight(aMtfSize100.Height() / 360);
 
-if ( pVisArea ) // seem that we currently are skipping the 
visarea position
-*pVisArea = tools::Rectangle( Point(), aMtfSize100 );
+if (pVisArea) // seem that we currently are skipping the 
visarea position
+*pVisArea = tools::Rectangle(Point(), aMtfSize100);
 
 // skip rest of header
 nSkip = 6;
 bMtfBLIP = bZCodecCompression = true;
 }
 break;
-case 0x46A :// One byte tag then JPEG (= JFIF) data
-case 0x6E0 :// One byte tag then PNG data
-case 0x6E2 :// One byte tag then JPEG in CMYK color 
space
-case 0x7A8 :
-nSkip += 1; // One byte tag then DIB data
-break;
+case OfficeArtBlipRecInstance::JPEG_RGB:
+case OfficeArtBlipRecInstance::JPEG_CMYK:
+case OfficeArtBlipRecInstance::PNG:
+case OfficeArtBlipRecInstance::DIB:
+case OfficeArtBlipRecInstance::TIFF:
+nSkip += 1; // Skip one byte tag
+break;
 }
 rBLIPStream.SeekRel( nSkip );
 
@@ -6535,18 +6549,34 @@ bool SvxMSDffManager::GetBLIPDirect( SvStream& 
rBLIPStream, Graphic& rData, tool
 // extract graphics from ole storage into "dbggfxNNN.*"
 static sal_Int32 nGrfCount;
 
-OUString aFileName = "dbggfx" + OUString::number( nGrfCount++ );
-

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3804d4991c2371dcf06f0d359aa21a1f2860
Author: Adolfo Jayme Barrientos 
AuthorDate: Thu Apr 28 13:37:10 2022 -0500
Commit: Gerrit Code Review 
CommitDate: Thu Apr 28 20:37:10 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to d7890e97169844d9a2f46703b893c1123dd8ebce
  - Drop reference to AskBot and update link

It is never a good idea to hardcode the name of the backend software for
a website in a translatable string directed to users. It’s not 
future-proof.
Also, we’ve never called it that; it’s always been “Ask LibreOffice”.

But in this case, I’ve carefully avoided mentioning the product name, 
for
the sake of corporate builds.

Change-Id: Ic4c1c01e7ecc86d44157fec638a5d79dcb809733

diff --git a/helpcontent2 b/helpcontent2
index d4e7c6e6e119..d7890e971698 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit d4e7c6e6e119fe3fab827753bbb8d27caff195c2
+Subproject commit d7890e97169844d9a2f46703b893c1123dd8ebce

[Libreoffice-commits] help.git: source/text

[Adolfo Jayme Barrientos (via logerrit)]

 source/text/shared/01/moviesound.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d7890e97169844d9a2f46703b893c1123dd8ebce
Author: Adolfo Jayme Barrientos 
AuthorDate: Thu Apr 28 13:32:01 2022 -0500
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Apr 28 13:36:48 2022 -0500

Drop reference to AskBot and update link

It is never a good idea to hardcode the name of the backend software for
a website in a translatable string directed to users. It’s not future-proof.
Also, we’ve never called it that; it’s always been “Ask LibreOffice”.

But in this case, I’ve carefully avoided mentioning the product name, for
the sake of corporate builds.

Change-Id: Ic4c1c01e7ecc86d44157fec638a5d79dcb809733

diff --git a/source/text/shared/01/moviesound.xhp 
b/source/text/shared/01/moviesound.xhp
index 45cb781fa..a8f3ac5db 100644
--- a/source/text/shared/01/moviesound.xhp
+++ b/source/text/shared/01/moviesound.xhp
@@ -94,7 +94,7 @@
   https://docs.microsoft.com/en-us/windows/win32/directshow/supported-formats-in-directshow;
 name="directshow">List of default formats for Microsoft Windows 
DirectShow.
   https://gstreamer.freedesktop.org/documentation/plugin-development/advanced/media-types.html#list-of-defined-types;
 name="gstreamer">List of defined types for gstreamer in 
GNU/Linux.
   https://help.apple.com/finalcutpro/mac/10.4.6/en.lproj/ver2833f855.html; 
name="quicktime">List of media formats for Apple macOS 
QuickTime.
-  https://ask.libreoffice.org/en/question/854/what-video-formats-does-libreoffice-impress-support/;
 name="askbot">%PRODUCTNAME Askbot question and answer
+  https://ask.libreoffice.org/t/what-video-formats-does-libreoffice-impress-support/291;
 name="AskLO">“What video formats does Impress support?” on 
Ask
 
 
 

[Libreoffice-bugs] [Bug 148568] Rework the Sparklines dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148568

--- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> ---
Created attachment 179830
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179830=edit
new .ui file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148797] Add to List help needs clarifying

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148797

Telesto  changed:

   What|Removed |Added

Summary|UI: Add to list button  |Add to List help needs
   |disabled as long someone|clarifying
   |keeping CTRL  pressed   |

--- Comment #13 from Telesto  ---
(In reply to sdc.blanco from comment #12)
> (In reply to Telesto from comment #9)
> > +1
> Shall we say that I push the patch that revises the help, and that we change
> the summary for this ticket to something like:  Add to List help needs
> clarifying
> and then close it as FIXED?  And then comment 3 lays out the issues about
> interaction between CTRL and toolbars, and I will leave it up to you whether
> to open a new ticket about that. OK?

Fine with me! 1+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148797] Add to List help needs clarifying

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148797

Telesto  changed:

   What|Removed |Added

Summary|UI: Add to list button  |Add to List help needs
   |disabled as long someone|clarifying
   |keeping CTRL  pressed   |

--- Comment #13 from Telesto  ---
(In reply to sdc.blanco from comment #12)
> (In reply to Telesto from comment #9)
> > +1
> Shall we say that I push the patch that revises the help, and that we change
> the summary for this ticket to something like:  Add to List help needs
> clarifying
> and then close it as FIXED?  And then comment 3 lays out the issues about
> interaction between CTRL and toolbars, and I will leave it up to you whether
> to open a new ticket about that. OK?

Fine with me! 1+

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148841] LibreOffice 7.2.5.1 Module Base, ODB - printing of a report fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148841

--- Comment #3 from h8...@t-online.de ---
Forgot to include Java Version:
openjdk 11.0.14.1 2022-02-08
OpenJDK Runtime Environment (build 11.0.14.1+1-suse-3.77.5-x8664)
OpenJDK 64-Bit Server VM (build 11.0.14.1+1-suse-3.77.5-x8664, mixed mode)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: M. A. ADAM license statement

[Eike Rathke]

Hi Adam,

On Wednesday, 2022-04-27 16:42:40 +0500, Adam wrote:

> Am I supposed to do: Upload the attached signature.asc file to the by
> logging via the link given, right?

Nonono, that was meant as *I* put your license statement on file in that
wiki page change indicated.

Nothing to do for you :)  sorry if that wasn't clear.

  Eike

-- 
GPG key 0x6A6CD5B765632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A


signature.asc
Description: PGP signature

[Libreoffice-bugs] [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" and "Ri

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148782

--- Comment #3 from sdc.bla...@youmail.dk ---
Hoping to get a confirmation for this ticket, which is needed in order to
address bug 148519 to use "Frame border".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 148782] "Left frame border" and "Right frame border" options for Horizontal "to" position in Position and Size for shapes should be changed to "Left of frame text area" an

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148782

--- Comment #3 from sdc.bla...@youmail.dk ---
Hoping to get a confirmation for this ticket, which is needed in order to
address bug 148519 to use "Frame border".

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148841] LibreOffice 7.2.5.1 Module Base, ODB - printing of a report fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148841

--- Comment #2 from h8...@t-online.de ---
Created attachment 179829
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179829=edit
Error Message

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148841] LibreOffice 7.2.5.1 Module Base, ODB - printing of a report fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148841

h8...@t-online.de changed:

   What|Removed |Added

 CC||h8...@t-online.de

--- Comment #1 from h8...@t-online.de ---
Created attachment 179828
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179828=edit
Starting point ...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148841] New: LibreOffice 7.2.5.1 Module Base, ODB - printing of a report fails

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148841

Bug ID: 148841
   Summary: LibreOffice 7.2.5.1 Module Base, ODB - printing of a
report fails
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Base
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: h8...@t-online.de

Description:
Executing a report in an open odb crashes with errormessage. Document-Preview
is OK. Same error with Version 7.3.0.3



Steps to Reproduce:
1.Doubleclick on *.odb
2.Select Reports
3.Execute

Actual Results:
The following Errormessage pops up:
[jni_uno bridge error] UNO calling Java method execute: non-UNO exception
occurred: java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
java stack trace:
java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
at
org.pentaho.reporting.libraries.base.boot.AbstractBoot.(AbstractBoot.java:55)
at
org.libreoffice.report.pentaho.PentahoReportEngine.(PentahoReportEngine.java:34)
at
org.libreoffice.report.pentaho.SOReportJobFactory$_SOReportJobFactory.createReportJob(SOReportJobFactory.java:352)
at
org.libreoffice.report.pentaho.SOReportJobFactory$_SOReportJobFactory.execute(SOReportJobFactory.java:236)
Caused by: java.lang.ClassNotFoundException:
org.apache.commons.logging.LogFactory
at java.net.URLClassLoader.findClass(URLClassLoader.java:387)
at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
at java.net.FactoryURLClassLoader.loadClass(URLClassLoader.java:822)
at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
... 4 more

/home/abuild/rpmbuild/BUILD/libreoffice-7.2.5.1/bridges/source/jni_uno/jni_uno2java.cxx:785


Expected Results:
OO Writer should come up to finish printing.


Reproducible: Always


User Profile Reset: No



Additional Info:
System:
Linux localhost.localdomain 5.3.18-150300.59.63-preempt #1 SMP PREEMPT Tue Apr
5 12:47:31 UTC 2022 (d77db66) x86_64 x86_64 x86_64 GNU/Linux

Packages installed:
libreoffice-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-base-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-branding-openSUSE-15.3.20210112-lp153.1.26.noarch
libreoffice-calc-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-draw-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-filters-optional-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-icon-themes-7.2.5.1-150300.14.22.18.3.noarch
libreoffice-impress-7.2.5.1-150300.14.22.18.3.x86_64
libreofficekit-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-l10n-de-7.2.5.1-150300.14.22.18.3.noarch
libreoffice-l10n-en-7.2.5.1-150300.14.22.18.3.noarch
libreoffice-mailmerge-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-math-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-pyuno-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-qt5-7.2.5.1-150300.14.22.18.3.x86_64
libreoffice-share-linker-1-3.3.1.noarch
libreoffice-writer-7.2.5.1-150300.14.22.18.3.x86_64

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108741
Bug 108741 depends on bug 148593, which changed state.

Bug 148593 Summary: "Left page border" and "right page border" options for 
Horizontal "to" position in Position and Size for shapes are misleading names, 
which should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=148593

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103270] [META] Image/Picture dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103270
Bug 103270 depends on bug 148593, which changed state.

Bug 148593 Summary: "Left page border" and "right page border" options for 
Horizontal "to" position in Position and Size for shapes are misleading names, 
which should be changed
https://bugs.documentfoundation.org/show_bug.cgi?id=148593

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148593

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |sdc.bla...@youmail.dk
   |desktop.org |
 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: svx/inc

[Seth Chaiklin (via logerrit)]

 svx/inc/swframeposstrings.hrc |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ceb1d4836d7fa04f600dea2beb146c263f8d3efa
Author: Seth Chaiklin 
AuthorDate: Mon Apr 25 23:51:50 2022 +0100
Commit: Seth Chaiklin 
CommitDate: Thu Apr 28 18:55:59 2022 +0200

tdf#148593  Rename two Horizontal "to" position options for Shape/Image

   Left page border ->  Left of page text area
   Right page border ->  Right of page text area

   The CSS box model is the underlying idea here, where
   LO uses "page text area" for what is called "content area"
   in the box model. 
https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model

   The reference to "border" in the options was incorrect.
   The renamed controls refer to the regions to the
   left (and right) of the page text area. These regions
   can be used for horizontal positioning  of shapes and images.

Change-Id: I2ea8c682da8fb34b04496b3629819bf5201e86e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133403
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin 

diff --git a/svx/inc/swframeposstrings.hrc b/svx/inc/swframeposstrings.hrc
index d5bf9af274e9..1b603dd3e602 100644
--- a/svx/inc/swframeposstrings.hrc
+++ b/svx/inc/swframeposstrings.hrc
@@ -35,8 +35,8 @@ const TranslateId RID_SVXSW_FRAMEPOSITIONS[] =
 NC_("RID_SVXSW_FRAMEPOSITIONS", "From inside"),
 NC_("RID_SVXSW_FRAMEPOSITIONS", "Paragraph area"),
 NC_("RID_SVXSW_FRAMEPOSITIONS", "Paragraph text area"),
-NC_("RID_SVXSW_FRAMEPOSITIONS", "Left page border"),
-NC_("RID_SVXSW_FRAMEPOSITIONS", "Right page border"),
+NC_("RID_SVXSW_FRAMEPOSITIONS", "Left of page text area"),
+NC_("RID_SVXSW_FRAMEPOSITIONS", "Right of page text area"),
 NC_("RID_SVXSW_FRAMEPOSITIONS", "Left paragraph border"),
 NC_("RID_SVXSW_FRAMEPOSITIONS", "Right paragraph border"),
 NC_("RID_SVXSW_FRAMEPOSITIONS", "Inner page border"),

[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148593

--- Comment #14 from Commit Notification 
 ---
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ceb1d4836d7fa04f600dea2beb146c263f8d3efa

tdf#148593  Rename two Horizontal "to" position options for Shape/Image

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148593] "Left page border" and "right page border" options for Horizontal "to" position in Position and Size for shapes are misleading names, which should be changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148593

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.4.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'feature/scaling-geometry-provider' - vcl/headless vcl/inc vcl/qt5 vcl/skia vcl/source vcl/unx

[Jan-Marek Glogowski (via logerrit)]

 vcl/headless/svpvd.cxx  |5 ---
 vcl/inc/headless/svpvd.hxx  |1 
 vcl/inc/qt5/QtGraphics_Controls.hxx |3 +-
 vcl/inc/qt5/QtSvpVirtualDevice.hxx  |2 -
 vcl/inc/qt5/QtVirtualDevice.hxx |1 
 vcl/inc/salvd.hxx   |2 -
 vcl/inc/skia/x11/salvd.hxx  |2 -
 vcl/inc/unx/salvd.h |1 
 vcl/qt5/QtGraphics.cxx  |   10 ---
 vcl/qt5/QtGraphics_Controls.cxx |   14 +-
 vcl/qt5/QtSvpGraphics.cxx   |   27 +++
 vcl/qt5/QtSvpVirtualDevice.cxx  |   10 ---
 vcl/qt5/QtVirtualDevice.cxx |8 -
 vcl/qt5/QtWidget.cxx|8 -
 vcl/skia/x11/salvd.cxx  |4 --
 vcl/source/image/ImplImage.cxx  |2 -
 vcl/source/window/window.cxx|4 +-
 vcl/unx/generic/gdi/gdiimpl.cxx |   29 +
 vcl/unx/generic/gdi/gdiimpl.hxx |6 
 vcl/unx/generic/gdi/salgdi.cxx  |4 ++
 vcl/unx/generic/gdi/salvd.cxx   |9 +-
 vcl/unx/generic/window/salframe.cxx |   49 +---
 22 files changed, 56 insertions(+), 145 deletions(-)

New commits:
commit a45277a271b943cfa929670223ddf0447c968269
Author: Jan-Marek Glogowski 
AuthorDate: Thu Apr 28 18:53:47 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Thu Apr 28 18:53:47 2022 +0200

Todys work, actully working correctly

diff --git a/vcl/headless/svpvd.cxx b/vcl/headless/svpvd.cxx
index c27ff3baa917..bf02c6ac7e44 100644
--- a/vcl/headless/svpvd.cxx
+++ b/vcl/headless/svpvd.cxx
@@ -64,11 +64,6 @@ void SvpSalVirtualDevice::ReleaseGraphics( SalGraphics* 
pGraphics )
 delete pGraphics;
 }
 
-void SvpSalVirtualDevice::SetScalePercentage(sal_Int32 nScale)
-{
-CreateSurface(0, 0, nullptr, nScale);
-}
-
 void SvpSalVirtualDevice::CreateSurface(sal_Int32 nNewDX, sal_Int32 nNewDY, 
sal_uInt8 *const pBuffer, sal_Int32 nScalePercentage)
 {
 double fXScale, fYScale;
diff --git a/vcl/inc/headless/svpvd.hxx b/vcl/inc/headless/svpvd.hxx
index 7c4f1024d536..c1b68a138e69 100644
--- a/vcl/inc/headless/svpvd.hxx
+++ b/vcl/inc/headless/svpvd.hxx
@@ -54,7 +54,6 @@ public:
 virtual boolSetSizeUsingBuffer( sal_Int32 nNewDX, sal_Int32 nNewDY,
 sal_uInt8 * pBuffer, sal_Int32 
nScale = 100
   ) override;
-virtual void SetScalePercentage(sal_Int32) override;
 
 cairo_surface_t* GetSurface() const { return m_pSurface; }
 
diff --git a/vcl/inc/qt5/QtGraphics_Controls.hxx 
b/vcl/inc/qt5/QtGraphics_Controls.hxx
index 15931d6d18ba..5611706a4b76 100644
--- a/vcl/inc/qt5/QtGraphics_Controls.hxx
+++ b/vcl/inc/qt5/QtGraphics_Controls.hxx
@@ -38,9 +38,10 @@ class QtGraphics_Controls final : public 
vcl::WidgetDrawInterface
 std::unique_ptr m_image;
 QRect m_lastPopupRect;
 SalGraphics const& m_rGraphics;
+qreal m_fDevicePixelRatio;
 
 public:
-QtGraphics_Controls(const SalGraphics& rGraphics, sal_Int32 nScale);
+QtGraphics_Controls(const SalGraphics& rGraphics, sal_Int32 
nScalePercentage);
 
 QImage* getImage() { return m_image.get(); }
 
diff --git a/vcl/inc/qt5/QtSvpVirtualDevice.hxx 
b/vcl/inc/qt5/QtSvpVirtualDevice.hxx
index 5d80ba8c0dbf..9da7c640ee6f 100644
--- a/vcl/inc/qt5/QtSvpVirtualDevice.hxx
+++ b/vcl/inc/qt5/QtSvpVirtualDevice.hxx
@@ -15,7 +15,7 @@ class QtSvpGraphics;
 
 class VCL_DLLPUBLIC QtSvpVirtualDevice final : public SvpSalVirtualDevice
 {
-QtSvpGraphics& m_rRefGraphics;
+sal_Int32 m_nScalePercentage;
 
 public:
 QtSvpVirtualDevice(QtSvpGraphics& rGraphics, cairo_surface_t* 
pPreExistingTarget);
diff --git a/vcl/inc/qt5/QtVirtualDevice.hxx b/vcl/inc/qt5/QtVirtualDevice.hxx
index dc5846a57307..9f86dac0938f 100644
--- a/vcl/inc/qt5/QtVirtualDevice.hxx
+++ b/vcl/inc/qt5/QtVirtualDevice.hxx
@@ -47,7 +47,6 @@ public:
 
 // SalGeometryProvider
 virtual sal_Int32 GetSgpMetric(vcl::SGPmetric eMetric) const override;
-virtual void SetScalePercentage(sal_Int32) override;
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/salvd.hxx b/vcl/inc/salvd.hxx
index 213cc81c3673..bf3c8cf69c83 100644
--- a/vcl/inc/salvd.hxx
+++ b/vcl/inc/salvd.hxx
@@ -44,8 +44,6 @@ public:
 
 // Set new size using a buffer at the given address
 virtual bool SetSizeUsingBuffer(sal_Int32 nNewDX, sal_Int32 nNewDY, 
sal_uInt8*, sal_Int32 nScale = 100) = 0;
-
-virtual void SetScalePercentage(sal_Int32 nScale) = 0;
 };
 
 void SalVirtualDevice::FixSetSizeParams(sal_Int32& nDX, sal_Int32& nDY, 
sal_Int32& nScale)
diff --git a/vcl/inc/skia/x11/salvd.hxx b/vcl/inc/skia/x11/salvd.hxx
index b2ce698de77b..7ef6f9dd3a1d 100644
--- a/vcl/inc/skia/x11/salvd.hxx
+++ b/vcl/inc/skia/x11/salvd.hxx
@@ -38,8 +38,6 @@ public:
 
 // Set new size, without saving the old contents
 virtual bool SetSizeUsingBuffer(sal_Int32 nNewDX, sal_Int32 nNewDY, 
sal_uInt8*, sal_Int32 = 100) 

[Libreoffice-commits] core.git: sw/qa

[Caolán McNamara (via logerrit)]

 sw/qa/extras/layout/data/fdo43573-2-min.docx |binary
 1 file changed

New commits:
commit 002e00eed994fdfb50cbbf4486deb1f88a9c5c0c
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 13:10:38 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 18:34:56 2022 +0200

Thorndale -> Liberation Serif for repeatable results

Change-Id: I2096d3a4265d5f38d8bce54ef6089f767aa39afb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133558
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/data/fdo43573-2-min.docx 
b/sw/qa/extras/layout/data/fdo43573-2-min.docx
index 429b7948ed02..625c3a24556c 100644
Binary files a/sw/qa/extras/layout/data/fdo43573-2-min.docx and 
b/sw/qa/extras/layout/data/fdo43573-2-min.docx differ

[Libreoffice-commits] core.git: sw/qa

[Caolán McNamara (via logerrit)]

 sw/qa/extras/layout/data/tdf136613.docx |binary
 1 file changed

New commits:
commit dd00ccf29dd03a80bcd24feed63978e97ab7b2ca
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 13:07:40 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 18:34:40 2022 +0200

Engravers MT -> DejaVu Sans for repeatable results

Change-Id: I95273d657fe18b5a8f2315650a6232b5a1de4be5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133557
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/extras/layout/data/tdf136613.docx 
b/sw/qa/extras/layout/data/tdf136613.docx
index f885564521b1..a67e2f6c3b2c 100644
Binary files a/sw/qa/extras/layout/data/tdf136613.docx and 
b/sw/qa/extras/layout/data/tdf136613.docx differ

[Libreoffice-commits] core.git: test/user-template

[Caolán McNamara (via logerrit)]

 test/user-template/registry/modifications.xcd |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit a76bc737235a1872845817edccac749e65a646d1
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 12:54:04 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 18:34:09 2022 +0200

override default "Segoe UI" for UI_SANS for cppunit tests

Change-Id: If8b073c6ed9f9508a03ec65e885313d7a618b600
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133556
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/test/user-template/registry/modifications.xcd 
b/test/user-template/registry/modifications.xcd
index 7fa9082f64fd..b5162cb2a17a 100644
--- a/test/user-template/registry/modifications.xcd
+++ b/test/user-template/registry/modifications.xcd
@@ -19,6 +19,9 @@
 
  DejaVu Sans
 
+
+ DejaVu Sans
+


 

[Libreoffice-commits] core.git: test/user-template

[Caolán McNamara (via logerrit)]

 test/user-template/registry/modifications.xcd |   32 +-
 1 file changed, 31 insertions(+), 1 deletion(-)

New commits:
commit 5dcd46fb8f80372f7ce159e168cae4084d41a9fa
Author: Caolán McNamara 
AuthorDate: Thu Apr 28 11:58:50 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Apr 28 18:33:36 2022 +0200

set default cjk/ctl fonts for cppunit tests that exist in "more fonts"

Change-Id: Ib145f1ce60eb8bb3aef15c803b0d78f684507bc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133550
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/test/user-template/registry/modifications.xcd 
b/test/user-template/registry/modifications.xcd
index dcccd94b69d5..7fa9082f64fd 100644
--- a/test/user-template/registry/modifications.xcd
+++ b/test/user-template/registry/modifications.xcd
@@ -7,7 +7,37 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  *
 -->
-http://openoffice.org/2001/registry;>
+http://www.w3.org/2001/XMLSchema; 
xmlns:oor="http://openoffice.org/2001/registry;>
+ http://openoffice.org/2004/installation; 
oor:name="VCL" oor:package="org.openoffice">
+  
+   
+
+ DejaVu Sans
+
+   
+   
+
+ DejaVu Sans
+
+   
+   
+
+ DejaVu Sans
+
+
+ DejaVu Sans
+
+   
+   
+
+ DejaVu Sans
+
+
+ DejaVu Sans
+
+   
+  
+ 
  
   
 

[Libreoffice-bugs] [Bug 148840] Find and replace does not function as expected or consistently

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148840

--- Comment #1 from Randy  ---
Created attachment 179827
  --> https://bugs.documentfoundation.org/attachment.cgi?id=179827=edit
screen shot of incomplete search

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148840] New: Find and replace does not function as expected or consistently

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148840

Bug ID: 148840
   Summary: Find and replace does not function as expected or
consistently
   Product: LibreOffice
   Version: 7.2.5.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rpeas...@saultchurch.com

Description:
I created a document with both Times New Roman text and Arial text.  It is a
chord sheet.  All the chord notations are Times New Roman bold and the lyrics
are Arial regular.  For easily changing a song from one key to another, find
and replace works great.  However, I have found it to be inconsistent.  In the
original document, "find" only found 7 A's out of probably 30.  When I changed
all the text to Times New Roman it was then able to find all the A's.  After I
changed all the chord symbols (letters) I went back through and changed all the
lyrics to Arial and saved the document.  Then I saved it as a new document so I
could change it to another key.  This time find and replace was able to find
all of the letters I was searching for and I did not need to change the lyric
text to Times New Roman.  I've experienced this inconsistency before.

Steps to Reproduce:
1.Type text into document in two fonts alternating fonts on each new line of
text
2.Search for specific letters in text
3.

Actual Results:
Only some of the specific letter searched for are found

Expected Results:
all of the specific letter should be found


Reproducible: Sometimes


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/tools tools/source

[Noel Grandin (via logerrit)]

 include/tools/inetmime.hxx |2 +-
 tools/source/inet/inetmime.cxx |6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit e6d60166dbece401d29608d5c9005a882b443baa
Author: Noel Grandin 
AuthorDate: Thu Apr 28 12:57:55 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Apr 28 17:49:28 2022 +0200

use more string_view in tools::INetMIME

Change-Id: I3bfa5a1402835c21ec70b8d995f79a2edaa6577d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133549
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/include/tools/inetmime.hxx b/include/tools/inetmime.hxx
index a3c7de49690c..3c0fe30ffbde 100644
--- a/include/tools/inetmime.hxx
+++ b/include/tools/inetmime.hxx
@@ -180,7 +180,7 @@ public:
 parameters will be modified.
  */
 static sal_Unicode const * scanContentType(
-OUString const & rStr,
+std::u16string_view rStr,
 OUString * pType = nullptr, OUString * pSubType = nullptr,
 INetContentTypeParameterList * pParameters = nullptr);
 
diff --git a/tools/source/inet/inetmime.cxx b/tools/source/inet/inetmime.cxx
index 85f03cfce3e2..2a57c099c93f 100644
--- a/tools/source/inet/inetmime.cxx
+++ b/tools/source/inet/inetmime.cxx
@@ -1003,11 +1003,11 @@ bool INetMIME::scanUnsigned(const sal_Unicode *& rBegin,
 
 // static
 sal_Unicode const * INetMIME::scanContentType(
-OUString const & rStr, OUString * pType,
+std::u16string_view rStr, OUString * pType,
 OUString * pSubType, INetContentTypeParameterList * pParameters)
 {
-sal_Unicode const * pBegin = rStr.getStr();
-sal_Unicode const * pEnd = pBegin + rStr.getLength();
+sal_Unicode const * pBegin = rStr.data();
+sal_Unicode const * pEnd = pBegin + rStr.size();
 sal_Unicode const * p = skipLinearWhiteSpaceComment(pBegin, pEnd);
 sal_Unicode const * pTypeBegin = p;
 while (p != pEnd && isTokenChar(*p))

[Libreoffice-bugs] [Bug 148790] UI: The No List button constantly highlighted when no some text isn't a list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148790

--- Comment #8 from Eyal Rozenberg  ---
(In reply to Telesto from comment #6)
> Note: when I say I'm in principle against, doesn't mean there can be
> exceptions.. I'm undecided if this is such a case.. I do struggle.. I'm
> already happy with removal from toolbar. 

I was thinking that removal from the toolbar is the right way to go since it's
the path of least resistance - anyone who wants the "No List" button can still
get it back. But... are there such people? That is, do the people who pushed
forward 115965 care in particular about "No List", or are two dependent
checkboxes ok with them? I pinged on that bug.

If nobody actively wants to keep the No List button, perhaps it's better to
remove it altogether, and not just from the toolbar.


> However this does hit the fundamental question how much of the UI (and
> logic) must be bend. And where the need for an dedicated UI begins. 

You mean, whether dependent checkboxes are appropriate at all? Otherwise I
don't quite follow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148772] Text in Word 2007 DOCX table shown with a vertical layout instead of an horizontal layout (OK if resaved in MSO)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148772

Timur  changed:

   What|Removed |Added

 CC||vmik...@collabora.com

--- Comment #7 from Timur  ---
Previous change in the same repo was for the 1st cell "Version" in
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range=240d1f289c5788845cd4336f223f2c4bc8975a99..4f918cd5daed963287805da761e6983a392ae050

Miklos, please see if your commits 226df017ee949429657dea20e2d21e2775e4d162 and
f4badd9a485f32f787d78431ed673e2932973887 caused this. 
(I suspect this because the later has a code "bad" hidden inside).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[Andrea Gelmini (via logerrit)]

 vcl/source/gdi/impglyphitem.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6cb72c5fc6f9f10f6e450fb80c043c3afa88bd56
Author: Andrea Gelmini 
AuthorDate: Thu Apr 28 13:57:12 2022 +0200
Commit: Julien Nabet 
CommitDate: Thu Apr 28 17:09:59 2022 +0200

Fix typo

Change-Id: I600199f87df8a211b2a27913bc1fe2340d315766
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133552
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index d6c59e5decfa..b313cf8967e2 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -372,7 +372,7 @@ 
SalLayoutGlyphsCache::CachedGlyphsKey::CachedGlyphsKey(const VclPtrGetFont())
 // TODO It would be possible to get a better hit ratio if mapMode wasn't 
part of the key
 // and results that differ only in mapmode would have coordinates adjusted 
based on that.
-// That would occassionally lead to rounding errors (at least differences 
that would
+// That would occasionally lead to rounding errors (at least differences 
that would
 // make checkGlyphsEqual() fail).
 , mapMode(outputDevice->GetMapMode())
 , rtl(outputDevice->IsRTLEnabled())