date:20220617

[Libreoffice-bugs] [Bug 149600] Hue band in color picker dialog doesn't react to clicks before picking a color

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149600

Aron Budea  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149600] New: Hue band in color picker dialog doesn't react to clicks before picking a color

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149600

Bug ID: 149600
Summary: Hue band in color picker dialog doesn't react to
clicks before picking a color
Product: LibreOffice
Version: 5.4.3.2 release
Hardware: All
OS: All
Status: UNCONFIRMED
Keywords: bibisected, bisected, regression
Severity: trivial
Priority: low
Component: framework
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: aron.bu...@gmail.com
CC: caol...@redhat.com
Blocks: 87064

- Open one of the apps, and open a Custom Color... color picker, eg. in Writer
for the text color.
- In the dialog, click inside the Hue band in various places.

=> The main color area isn't updated, and shows the default white/red/black
range of colors.

If you pick a color, the correct color will be chosen, as can be seen in the
color preview in the bottom left corner.
Also, from now, clicking inside the Hue band correctly updates the area. So
it's only a small inconvenience, but you have to pick a color once in the
dialog to have it behave properly.

Observed using LO Version: 7.4.0.0.beta1+
(fe3be12afd810e17427601178b5d186364bef8de) / Ubuntu.

This is a regression from the following commit in 6.0, bibisected to its 5.4
backport using repo bibisect-linux-64-5.4. Adding CC: to Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6ddd8fcf5c92936de2a3f9d824b06a9f7dc5a86a
author Caolán McNamara 2017-09-28 11:19:57
+0100
committer Caolán McNamara 2017-09-28 21:20:30
+0200

Resolves: tdf#112680 start color picker with currently selected color

Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87064
[Bug 87064] [META] Color picker dialog bugs and enhancements
--
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 87064] [META] Color picker dialog bugs and enhancements

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=87064

Aron Budea  changed:

   What|Removed |Added

 Depends on||149600


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=149600
[Bug 149600] Hue band in color picker dialog doesn't react to clicks before
picking a color
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128580] Copy text from Word is pasted as an image in Mac OS

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=128580

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||7905

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137905] macOS clipboard handling, copying and pasting text from Word into Writer pastes an image, other formats available on Paste Special

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=137905

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=12
   ||8580

--- Comment #12 from Dieter  ---
Perhaps duplicate of bug 128580?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149591] WORD COMPLETION: Make it visible, if there is more than one option for word completion

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149591

--- Comment #2 from Dieter  ---
(In reply to Heiko Tietze from comment #1)
> You essentially get a dropdown with the options and navigate through
> it using the arrow keys. Would that be an improvement?

I think so. This would replace Ctrl+tab, correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149591] WORD COMPLETION: Make it visible, if there is more than one option for word completion

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149591

--- Comment #2 from Dieter  ---
(In reply to Heiko Tietze from comment #1)
> You essentially get a dropdown with the options and navigate through
> it using the arrow keys. Would that be an improvement?

I think so. This would replace Ctrl+tab, correct?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149444] Can't "Save Remote" to Google Drive (password protected)

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149444

Dieter  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=10
   ||1630
 CC||dgp-m...@gmx.de
Summary|Can't "Save Remote" to  |Can't "Save Remote" to
   |Google Drive|Google Drive (password
   ||protected)
 Whiteboard| QA:needsComment|

--- Comment #1 from Dieter  ---
Two factor authentication doesn't work, this is bug 101630. So let's focus here
on an acount with a simple password.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 97341] Width for document comments cannot be changed manually

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97341

--- Comment #47 from mestatusvideo  ---
Pretty great post. I simply stumbled upon your blog and wanted to say that I’ve
truly loved surfing around your weblog posts. After all I will be subscribing
for your feed and I am hoping you write once more soon!
https://mestatusvideo.com/happy-fathers-day-whatsapp-status-video-download/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 97341] Width for document comments cannot be changed manually

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97341

mestatusvideo  changed:

   What|Removed |Added

URL||https://mestatusvideo.com/h
   ||appy-fathers-day-whatsapp-s
   ||tatus-video-download/
 Whiteboard||happy fathers day whatsapp
   ||status video download
   Keywords||topicWeb

--- Comment #46 from mestatusvideo  ---
I simply stumbled upon your blog and wanted to say that I’ve truly loved
surfing around your weblog posts.

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

2022-06-17 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

7 new defect(s) introduced to LibreOffice found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent 
build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)


** CID 1506308:(CHECKED_RETURN)
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 347 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 343 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 349 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 348 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 357 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 341 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 362 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 350 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 346 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 354 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()



*** CID 1506308:(CHECKED_RETURN)
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 347 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
341 curl_easy_setopt(curl.get(), CURLOPT_URL, aURL.data());
342 
343 curl_easy_setopt(curl.get(), CURLOPT_FAILONERROR, 1L);
344 // curl_easy_setopt(curl.get(), CURLOPT_VERBOSE, 1L);
345 
346 curl_easy_setopt(curl.get(), CURLOPT_WRITEFUNCTION, WriteCallback);
>>> CID 1506308:(CHECKED_RETURN)
>>> Calling "curl_easy_setopt(curl.get(), CURLOPT_WRITEDATA, 
>>> static_cast(_body))" without checking return value. This 
>>> library function may fail and return an error code.
347 curl_easy_setopt(curl.get(), CURLOPT_WRITEDATA, 
static_cast(_body));
348 curl_easy_setopt(curl.get(), CURLOPT_SSL_VERIFYPEER, false);
349 curl_easy_setopt(curl.get(), CURLOPT_SSL_VERIFYHOST, false);
350 curl_easy_setopt(curl.get(), CURLOPT_TIMEOUT, CURL_TIMEOUT);
351 
352 if (method == HTTP_METHOD::HTTP_POST)
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 343 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
337 isPremium = true;
338 }
339 
340 std::string response_body;
341 curl_easy_setopt(curl.get(), CURLOPT_URL, aURL.data());
342 
>>> CID 1506308:(CHECKED_RETURN)
>>> Calling "curl_easy_setopt(curl.get(), CURLOPT_FAILONERROR, 1L)" without 
>>> checking return value. This library function may fail and return an error 
>>> code.
343 curl_easy_setopt(curl.get(), CURLOPT_FAILONERROR, 1L);
344 // curl_easy_setopt(curl.get(), CURLOPT_VERBOSE, 1L);
345 
346 curl_easy_setopt(curl.get(), CURLOPT_WRITEFUNCTION, WriteCallback);
347 curl_easy_setopt(curl.get(), CURLOPT_WRITEDATA, 
static_cast(_body));
348 curl_easy_setopt(curl.get(), CURLOPT_SSL_VERIFYPEER, false);
/lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx: 349 in 
LanguageToolGrammarChecker::makeHttpRequest[abi:cxx11](std::basic_string_view>, HTTP_METHOD, const rtl::OString &, long &)()
343 curl_easy_setopt(curl.get(), CURLOPT_FAILONERROR, 1L);
344 // curl_easy_setopt(curl.get(), CURLOPT_VERBOSE, 1L);
345 
346 curl_easy_setopt(curl.get(),

[Libreoffice-bugs] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

--- Comment #7 from Commit Notification 
 ---
xuenhua committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/334b44affe24340f44216021a4699699dd5dde96

tdf#149431 Fix the sidebar's width

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

--- Comment #7 from Commit Notification 
 ---
xuenhua committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/334b44affe24340f44216021a4699699dd5dde96

tdf#149431 Fix the sidebar's width

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0
   ||target:7.4.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0|target:7.5.0
   ||target:7.4.0.0.beta2

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sfx2/source

2022-06-17 Thread xuenhua (via logerrit)

 sfx2/source/sidebar/SidebarController.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 334b44affe24340f44216021a4699699dd5dde96
Author: xuenhua 
AuthorDate: Wed Jun 1 15:29:49 2022 +0800
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jun 18 05:53:33 2022 +0200

tdf#149431 Fix the sidebar's width

When click the wider sidebar and then go back to the narrow one in Writer,
the narrow one becomes the same width as wider one, it's not suitable
and doesn't look good. Fix the width to smallest width unless you drag
the splitter. Take the maximum width from the smallest width and
mnWidthOnSplitterButtonDown.

Change-Id: I60aaab84593d59ac28b96c2d3c3bd62a4bbddbbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135220
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 
(cherry picked from commit 0ec2b93c28093c80572c43f7be261630bd85f232)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136039
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index cff76a95850b..088384641efd 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -506,6 +506,8 @@ void SidebarController::ProcessNewWidth (const sal_Int32 
nNewWidth)
 {
 // Deck became large enough to be shown.  Show it.
 mnSavedSidebarWidth = nNewWidth;
+// Store nNewWidth to mnWidthOnSplitterButtonDown when dragging 
sidebar Splitter
+mnWidthOnSplitterButtonDown = nNewWidth;
 if (!*mbIsDeckOpen)
 RequestOpenDeck();
 }
@@ -653,8 +655,12 @@ void SidebarController::OpenThenToggleDeck (
 if (mpCurrentDeck && mpTabBar)
 {
 sal_Int32 nRequestedWidth = mpCurrentDeck->GetMinimalWidth() + 
TabBar::GetDefaultWidth();
-if (mnSavedSidebarWidth < nRequestedWidth)
+// if sidebar was dragged
+if(mnWidthOnSplitterButtonDown > 0 && mnWidthOnSplitterButtonDown > 
nRequestedWidth){
+SetChildWindowWidth(mnWidthOnSplitterButtonDown);
+}else{
 SetChildWindowWidth(nRequestedWidth);
+}
 }
 }
 
@@ -1060,7 +1066,6 @@ IMPL_LINK(SidebarController, WindowEventHandler, 
VclWindowEvent&, rEvent, void)
 case VclEventId::WindowMouseButtonUp:
 {
 ProcessNewWidth(mpParentWindow->GetSizePixel().Width());
-mnWidthOnSplitterButtonDown = 0;
 break;
 }

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

--- Comment #20 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/4aa61f7cf13cfc2bc9f0af0a4ac2110d350e7bc1

Breeze: tdf#138400 update General Format icons

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.3.2   |target:7.4.0 target:7.3.2
   |target:7.2.7 target:7.5.0   |target:7.2.7 target:7.5.0
   |target:7.4.0.0.beta2|target:7.4.0.0.beta2
   ||target:7.3.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2

2022-06-17 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ecae3bfc98ea15bbaa94e6b1abb256e81df2b70e
Author: Olivier Hallot 
AuthorDate: Sat Jun 18 00:49:42 2022 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Jun 18 05:49:42 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-4'
  to 601ecc400a58555bf3225001c8c90ae7382c3068
  - Refactor table into list in redlining_enter.xhp

Change-Id: Iba8074cd05c199f75d122955ebd4099262f7cde1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136062
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136043
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 805ad055181e..601ecc400a58 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 805ad055181ec05ef35a718bef6366d091553fe7
+Subproject commit 601ecc400a58555bf3225001c8c90ae7382c3068

[Libreoffice-commits] help.git: Branch 'libreoffice-7-4' - source/text

2022-06-17 Thread Olivier Hallot (via logerrit)

 source/text/shared/guide/redlining_enter.xhp |   37 ---
 1 file changed, 11 insertions(+), 26 deletions(-)

New commits:
commit 601ecc400a58555bf3225001c8c90ae7382c3068
Author: Olivier Hallot 
AuthorDate: Fri Jun 17 14:05:53 2022 -0300
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jun 18 05:49:39 2022 +0200

Refactor table into list in redlining_enter.xhp

Change-Id: Iba8074cd05c199f75d122955ebd4099262f7cde1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136062
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136043
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/shared/guide/redlining_enter.xhp 
b/source/text/shared/guide/redlining_enter.xhp
index 397aa4fdf..dc8a94a03 100644
--- a/source/text/shared/guide/redlining_enter.xhp
+++ b/source/text/shared/guide/redlining_enter.xhp
@@ -36,32 +36,17 @@
 
   The review function is available in 
%PRODUCTNAME for text documents and spreadsheet documents.
   Not all 
changes are recorded. For example, the changing of a tab stop from align left 
to align right is not recorded. However, all usual changes made by a 
proofreader are recorded, such as additions, deletions, text alterations, and 
usual formatting.
-  
- 
-
-   1.
-
-
-   To start recording changes, open the document to be edited and 
choose Edit - Track Changes and then choose 
Record.
-
- 
- 
-
-   2.
-
-
-   Now start making your changes. You will note that all new text 
passages that you enter are underlined in color, while all text that you delete 
remains visible but is crossed out and shown in color.
-
- 
- 
-
-   3.
-
-
-   If you move to a marked change with the mouse pointer, you 
will see a reference to the type of change, the author, date and time of day 
for the change in the Help Tip. If the Extended Tips are also enabled, you will 
also see any available comments on this change.
-
- 
-  
+  
+ 
+To 
start recording changes, open the document to be edited and choose Edit - 
Track Changes and then choose Record.
+ 
+ 
+Now 
start making your changes. You will note that all new text passages that you 
enter are underlined in color, while all text that you delete remains visible 
but is crossed out and shown in color.
+ 
+ 
+If 
you move to a marked change with the mouse pointer, you will see a reference to 
the type of change, the author, date and time of day for the change in the Help 
Tip. If the Extended Tips are also enabled, you will also see any available 
comments on this change.
+ 
+  
 
 Changes in a 
spreadsheet document are highlighted by a border around the cells; when you 
point to the cell you can see more detailed information on this change in the 
Help Tip.
 You can enter 
a comment on each recorded change by placing the cursor in the area of the 
change and then choosing Edit - Track Changes - Comment. In 
addition to Extended Tips, the comment is also displayed in the list in the 
Manage 
Changes dialog.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_dark_svg icon-themes/breeze_svg

2022-06-17 Thread Rizal Muttaqin (via logerrit)

 icon-themes/breeze/cmd/32/numberformatstandard.png  |binary
 icon-themes/breeze/cmd/lc_numberformatstandard.png  |binary
 icon-themes/breeze/cmd/sc_numberformatstandard.png  |binary
 icon-themes/breeze_dark/cmd/32/numberformatstandard.png |binary
 icon-themes/breeze_dark/cmd/lc_numberformatstandard.png |binary
 icon-themes/breeze_dark/cmd/sc_numberformatstandard.png |binary
 icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg |2 +-
 icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg |2 +-
 icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg |2 +-
 icon-themes/breeze_svg/cmd/32/numberformatstandard.svg  |2 +-
 icon-themes/breeze_svg/cmd/lc_numberformatstandard.svg  |2 +-
 icon-themes/breeze_svg/cmd/sc_numberformatstandard.svg  |2 +-
 12 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 4aa61f7cf13cfc2bc9f0af0a4ac2110d350e7bc1
Author: Rizal Muttaqin 
AuthorDate: Sat Jun 18 06:15:36 2022 +0700
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jun 18 05:49:18 2022 +0200

Breeze: tdf#138400 update General Format icons

Change-Id: I7daad09129c505e300d84634768f4bcf14653500
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136069
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 
(cherry picked from commit 4207f5c291902cd157f204e4f025b040f4445912)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136041
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/cmd/32/numberformatstandard.png 
b/icon-themes/breeze/cmd/32/numberformatstandard.png
index 6d62ceb41ea0..61fae2e336d5 100644
Binary files a/icon-themes/breeze/cmd/32/numberformatstandard.png and 
b/icon-themes/breeze/cmd/32/numberformatstandard.png differ
diff --git a/icon-themes/breeze/cmd/lc_numberformatstandard.png 
b/icon-themes/breeze/cmd/lc_numberformatstandard.png
index 74a147cb37f3..92d43df0ace7 100644
Binary files a/icon-themes/breeze/cmd/lc_numberformatstandard.png and 
b/icon-themes/breeze/cmd/lc_numberformatstandard.png differ
diff --git a/icon-themes/breeze/cmd/sc_numberformatstandard.png 
b/icon-themes/breeze/cmd/sc_numberformatstandard.png
index ac4a5a63769b..de70d8c03b6c 100644
Binary files a/icon-themes/breeze/cmd/sc_numberformatstandard.png and 
b/icon-themes/breeze/cmd/sc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/32/numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/32/numberformatstandard.png
index 935aeebe9d9a..86990019ffdd 100644
Binary files a/icon-themes/breeze_dark/cmd/32/numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/32/numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png
index 1be34291425b..c91e8d16ec17 100644
Binary files a/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png
index 665e7c94d403..42014a50a60c 100644
Binary files a/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
index aac100dec0d2..8cd40178d134 100644
--- a/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
index 197c9b1c92aa..fd753956ca08 100644
--- a/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
index b0c3ed78d068..0813936ea98a 100644
--- a/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>/
\ No newline at end of file
+http://www.w3.org/2000/svg;>/gt;
\ No newline at end of file
diff --git a/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg 
b/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
index 34fcdc4602b3..106fcd973da0 100644
--- a/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
+++ b/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

--- Comment #19 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/00aa201a90885e4d973fd05e5976977a9d87737b

Breeze: tdf#138400 update General Format icons

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.3.2   |target:7.4.0 target:7.3.2
   |target:7.2.7 target:7.5.0   |target:7.2.7 target:7.5.0
   ||target:7.4.0.0.beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_dark_svg icon-themes/breeze_svg

2022-06-17 Thread Rizal Muttaqin (via logerrit)

 icon-themes/breeze/cmd/32/numberformatstandard.png  |binary
 icon-themes/breeze/cmd/lc_numberformatstandard.png  |binary
 icon-themes/breeze/cmd/sc_numberformatstandard.png  |binary
 icon-themes/breeze_dark/cmd/32/numberformatstandard.png |binary
 icon-themes/breeze_dark/cmd/lc_numberformatstandard.png |binary
 icon-themes/breeze_dark/cmd/sc_numberformatstandard.png |binary
 icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg |2 +-
 icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg |2 +-
 icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg |2 +-
 icon-themes/breeze_svg/cmd/32/numberformatstandard.svg  |2 +-
 icon-themes/breeze_svg/cmd/lc_numberformatstandard.svg  |2 +-
 icon-themes/breeze_svg/cmd/sc_numberformatstandard.svg  |2 +-
 12 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 00aa201a90885e4d973fd05e5976977a9d87737b
Author: Rizal Muttaqin 
AuthorDate: Sat Jun 18 06:15:36 2022 +0700
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jun 18 05:48:32 2022 +0200

Breeze: tdf#138400 update General Format icons

Change-Id: I7daad09129c505e300d84634768f4bcf14653500
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136069
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 
(cherry picked from commit 4207f5c291902cd157f204e4f025b040f4445912)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136040
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/icon-themes/breeze/cmd/32/numberformatstandard.png 
b/icon-themes/breeze/cmd/32/numberformatstandard.png
index 6d62ceb41ea0..61fae2e336d5 100644
Binary files a/icon-themes/breeze/cmd/32/numberformatstandard.png and 
b/icon-themes/breeze/cmd/32/numberformatstandard.png differ
diff --git a/icon-themes/breeze/cmd/lc_numberformatstandard.png 
b/icon-themes/breeze/cmd/lc_numberformatstandard.png
index 74a147cb37f3..92d43df0ace7 100644
Binary files a/icon-themes/breeze/cmd/lc_numberformatstandard.png and 
b/icon-themes/breeze/cmd/lc_numberformatstandard.png differ
diff --git a/icon-themes/breeze/cmd/sc_numberformatstandard.png 
b/icon-themes/breeze/cmd/sc_numberformatstandard.png
index ac4a5a63769b..de70d8c03b6c 100644
Binary files a/icon-themes/breeze/cmd/sc_numberformatstandard.png and 
b/icon-themes/breeze/cmd/sc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/32/numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/32/numberformatstandard.png
index 935aeebe9d9a..86990019ffdd 100644
Binary files a/icon-themes/breeze_dark/cmd/32/numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/32/numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png
index 1be34291425b..c91e8d16ec17 100644
Binary files a/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png
index 665e7c94d403..42014a50a60c 100644
Binary files a/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
index aac100dec0d2..8cd40178d134 100644
--- a/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
index 197c9b1c92aa..fd753956ca08 100644
--- a/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
index b0c3ed78d068..0813936ea98a 100644
--- a/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>/
\ No newline at end of file
+http://www.w3.org/2000/svg;>/gt;
\ No newline at end of file
diff --git a/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg 
b/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
index 34fcdc4602b3..106fcd973da0 100644
--- a/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
+++ b/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - helpcontent2

2022-06-17 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7443be96c83604c7bf5d833fba6c3a4abb77f1ee
Author: Olivier Hallot 
AuthorDate: Sat Jun 18 05:46:15 2022 +0200
Commit: Gerrit Code Review 
CommitDate: Sat Jun 18 05:46:15 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'libreoffice-7-4'
  to 805ad055181ec05ef35a718bef6366d091553fe7
  - Mute l10n

Change-Id: Ie3f063c53f424293da59e85e4a34334f37d4324c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136021
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 665f218e5e027ab3ad56bf6066d98d8323555ab3)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136042
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 9c49f2a9e814..805ad055181e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 9c49f2a9e8140358395e423ccf1c07b7b4af1a15
+Subproject commit 805ad055181ec05ef35a718bef6366d091553fe7

[Libreoffice-commits] help.git: Branch 'libreoffice-7-4' - source/text

2022-06-17 Thread Olivier Hallot (via logerrit)

 source/text/smath/guide/limits.xhp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 805ad055181ec05ef35a718bef6366d091553fe7
Author: Olivier Hallot 
AuthorDate: Thu Jun 16 21:37:54 2022 +0200
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Jun 18 05:46:11 2022 +0200

Mute l10n

Change-Id: Ie3f063c53f424293da59e85e4a34334f37d4324c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136021
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 665f218e5e027ab3ad56bf6066d98d8323555ab3)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136042
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/source/text/smath/guide/limits.xhp 
b/source/text/smath/guide/limits.xhp
index 282f1fb66..65b4d02c0 100644
--- a/source/text/smath/guide/limits.xhp
+++ b/source/text/smath/guide/limits.xhp
@@ -33,7 +33,7 @@
 You want to 
insert a summation formula like "summation of s^k from k = 0 to n" at the 
cursor in a Writer text document.
 
 
-
+
 You see the 
Math input window and the Elements pane on the left.
 
 
@@ -64,7 +64,7 @@
 In the same 
way, you can enter an Integral formula with limits. When you click an icon from 
the Elements pane, the assigned text command is inserted in the input window. 
If you know the text commands, you can enter the commands directly in the input 
window.
 
 
-
+
 
 
 Click in the 
input window and enter the following line:

[Libreoffice-bugs] [Bug 149444] Can't "Save Remote" to Google Drive

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149444

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149441] Attribute draw:glue-point-leaving-directions is lost on save

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149441

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149440] Implement ODF attribute draw:glue-point-leaving-directions for Custom Shapes

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149440

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149439] custom usercode with lpoptions isn't shown in Libreoffice

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149439

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149432

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149432

--- Comment #11 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145746] Crash after dragging a block diagram connector to document

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=145746

--- Comment #3 from QA Administrators  ---
Dear pkuszn,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145746] Crash after dragging a block diagram connector to document

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=145746

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145706] Click on a page, goes to a different page

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=145706

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145706] Click on a page, goes to a different page

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=145706

--- Comment #3 from QA Administrators  ---
Dear Menoo,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146309] How can I install the German language package on macOS? Error: /Volumes/LibreOffice/LibreOffice.app/Dies ist keine gültige Installation von LibreOffice 7.2

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146309

--- Comment #2 from QA Administrators  ---
Dear Walter,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/source

2022-06-17 Thread Xisco Fauli (via logerrit)

 vcl/source/window/layout.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 9ca2a827de1b7f3180975ce750674169986c5978
Author: Xisco Fauli 
AuthorDate: Thu May 26 16:45:30 2022 +0200
Commit: Aron Budea 
CommitDate: Sat Jun 18 03:21:41 2022 +0200

tdf#147844: Use sanity check only if LibreOfficeKit is active

Regression from 2b58a0979f9206cfca6d78cb2f3d5e65cd735f8b
"Add sanity check to avoid potential crash in the Collabora Online
server"

Change-Id: I2fcfb634b47f9d76f8efbbd64a8e69ea236894c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135024
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit b7efccde76ca7bfa181fff39c52282e87e940614)

Related: tdf#147844 still log the discrepancy

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135367
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 
Reviewed-by: Aron Budea 
(cherry picked from commit 08850dbead8a8a797965aaa97d43d639bc0814d3)

Change-Id: I2fcfb634b47f9d76f8efbbd64a8e69ea236894c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136065
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Aron Budea 

diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 995ae09a0c9e..c38790b6b2df 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -14,6 +14,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -283,10 +284,14 @@ void VclBox::setAllocation(const Size )
 // Though the dialogs are rendered in javascript for LOK Android some widgets 
like weld::DrawingArea
 // is sent as bitmap but it is rendered from only the visible part
 // when it gets negative, it shrinks instead of expands and it becomes 
invisible
+
 if (nExtraSpace < 0)
 {
-SAL_WARN("vcl.layout", "nExtraSpace went negative, setting to 
zero");
-nExtraSpace = 0;
+SAL_WARN("vcl.layout", "nExtraSpace went negative for VclBox: " << 
GetHelpId());
+if (comphelper::LibreOfficeKit::isActive())
+{
+nExtraSpace = 0;
+}
 }
 }

[Libreoffice-bugs] [Bug 120949] [META] Elementary icons

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=120949
Bug 120949 depends on bug 138400, which changed state.

Bug 138400 Summary: UI Calc Wrong icons showing for format as general
https://bugs.documentfoundation.org/show_bug.cgi?id=138400

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 131141] [META] Sukapura icons

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=131141
Bug 131141 depends on bug 138400, which changed state.

Bug 138400 Summary: UI Calc Wrong icons showing for format as general
https://bugs.documentfoundation.org/show_bug.cgi?id=138400

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 125965] [META] Sifr icons

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=125965
Bug 125965 depends on bug 138400, which changed state.

Bug 138400 Summary: UI Calc Wrong icons showing for format as general
https://bugs.documentfoundation.org/show_bug.cgi?id=138400

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117497] [META] Colibre icons

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=117497
Bug 117497 depends on bug 138400, which changed state.

Bug 138400 Summary: UI Calc Wrong icons showing for format as general
https://bugs.documentfoundation.org/show_bug.cgi?id=138400

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107139] [META] Breeze icons

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107139
Bug 107139 depends on bug 138400, which changed state.

Bug 138400 Summary: UI Calc Wrong icons showing for format as general
https://bugs.documentfoundation.org/show_bug.cgi?id=138400

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

Rizal Muttaqin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

Rizal Muttaqin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

--- Comment #18 from Commit Notification 
 ---
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ca47989ad60b1414f92be22a1fbf4c1d1a92dd97

Breeze: tdf#138400 update General Format icons

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.3.2   |target:7.4.0 target:7.3.2
   |target:7.2.7|target:7.2.7 target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: icon-themes/breeze icon-themes/breeze_dark icon-themes/breeze_dark_svg icon-themes/breeze_svg

2022-06-17 Thread Rizal Muttaqin (via logerrit)

 icon-themes/breeze/cmd/32/numberformatstandard.png  |binary
 icon-themes/breeze/cmd/lc_numberformatstandard.png  |binary
 icon-themes/breeze/cmd/sc_numberformatstandard.png  |binary
 icon-themes/breeze_dark/cmd/32/numberformatstandard.png |binary
 icon-themes/breeze_dark/cmd/lc_numberformatstandard.png |binary
 icon-themes/breeze_dark/cmd/sc_numberformatstandard.png |binary
 icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg |2 +-
 icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg |2 +-
 icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg |2 +-
 icon-themes/breeze_svg/cmd/32/numberformatstandard.svg  |2 +-
 icon-themes/breeze_svg/cmd/lc_numberformatstandard.svg  |2 +-
 icon-themes/breeze_svg/cmd/sc_numberformatstandard.svg  |2 +-
 12 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit ca47989ad60b1414f92be22a1fbf4c1d1a92dd97
Author: Rizal Muttaqin 
AuthorDate: Sat Jun 18 06:15:36 2022 +0700
Commit: Rizal Muttaqin 
CommitDate: Sat Jun 18 02:34:52 2022 +0200

Breeze: tdf#138400 update General Format icons

Change-Id: I7daad09129c505e300d84634768f4bcf14653500
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136069
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin 

diff --git a/icon-themes/breeze/cmd/32/numberformatstandard.png 
b/icon-themes/breeze/cmd/32/numberformatstandard.png
index 6d62ceb41ea0..61fae2e336d5 100644
Binary files a/icon-themes/breeze/cmd/32/numberformatstandard.png and 
b/icon-themes/breeze/cmd/32/numberformatstandard.png differ
diff --git a/icon-themes/breeze/cmd/lc_numberformatstandard.png 
b/icon-themes/breeze/cmd/lc_numberformatstandard.png
index 74a147cb37f3..92d43df0ace7 100644
Binary files a/icon-themes/breeze/cmd/lc_numberformatstandard.png and 
b/icon-themes/breeze/cmd/lc_numberformatstandard.png differ
diff --git a/icon-themes/breeze/cmd/sc_numberformatstandard.png 
b/icon-themes/breeze/cmd/sc_numberformatstandard.png
index ac4a5a63769b..de70d8c03b6c 100644
Binary files a/icon-themes/breeze/cmd/sc_numberformatstandard.png and 
b/icon-themes/breeze/cmd/sc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/32/numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/32/numberformatstandard.png
index 935aeebe9d9a..86990019ffdd 100644
Binary files a/icon-themes/breeze_dark/cmd/32/numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/32/numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png
index 1be34291425b..c91e8d16ec17 100644
Binary files a/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/lc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png 
b/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png
index 665e7c94d403..42014a50a60c 100644
Binary files a/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png and 
b/icon-themes/breeze_dark/cmd/sc_numberformatstandard.png differ
diff --git a/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
index aac100dec0d2..8cd40178d134 100644
--- a/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/32/numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
index 197c9b1c92aa..fd753956ca08 100644
--- a/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/lc_numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg 
b/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
index b0c3ed78d068..0813936ea98a 100644
--- a/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
+++ b/icon-themes/breeze_dark_svg/cmd/sc_numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>/
\ No newline at end of file
+http://www.w3.org/2000/svg;>/gt;
\ No newline at end of file
diff --git a/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg 
b/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
index 34fcdc4602b3..106fcd973da0 100644
--- a/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
+++ b/icon-themes/breeze_svg/cmd/32/numberformatstandard.svg
@@ -1 +1 @@
-http://www.w3.org/2000/svg;>
\ No newline at end of file
+http://www.w3.org/2000/svg;>
\ No newline at end of file
diff --git a/icon-themes/breeze_svg/cmd/lc_numberformatstandard.svg 
b/icon-themes/breeze_svg/cmd/lc_numberformatstandard.svg
index

[Libreoffice-bugs] [Bug 149599] Enhancement request: manual formula recalculation

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149599

--- Comment #2 from rmikke  ---
(In reply to Eike Rathke from comment #1)
> That's already available: switch off menu Data -> Calculate -> AutoCalculate
> and use F9 to recalculate pending changes within a session, or Shift+Ctrl+F9
> to recalculate the entire document.

Thanks, I was searching in file properties :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149599] Enhancement request: manual formula recalculation

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149599

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149599] Enhancement request: manual formula recalculation

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149599

Eike Rathke  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Eike Rathke  ---
That's already available: switch off menu Data -> Calculate -> AutoCalculate
and use F9 to recalculate pending changes within a session, or Shift+Ctrl+F9 to
recalculate the entire document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149599] New: Enhancement request: manual formula recalculation

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149599

Bug ID: 149599
   Summary: Enhancement request: manual formula recalculation
   Product: LibreOffice
   Version: 7.1.0.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ryszard.mi...@gmail.com

Description:
I'd like to have a possibility to switch off automatic formula recalculation in
CALC. Ideally: per file i.e. I'd like to be able to mark a file "do nat
recalculate automatically formulas in this file".

This is a very useful feature for big files with plenty of formulas, where I
don't need formulas recalculated after every cell change.

Actual Results:
For every cell I change all the formulas in file are recalculated.

Expected Results:
Possibility to mark a file for manual recalculation of formulas


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: pl-PL (pl_PL); UI: pl-PL
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2022-06-17 Thread Eike Rathke (via logerrit)

 sc/source/core/tool/odffmap.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f804b8d0b1fc0c215c8883c76344b2d256d5c003
Author: Eike Rathke 
AuthorDate: Fri Jun 17 23:53:34 2022 +0200
Commit: Eike Rathke 
CommitDate: Sat Jun 18 01:53:49 2022 +0200

Remove comment of long removed MapDupToInternal field

Change-Id: I0fd78eb1ff1fedf0ddb9728b06a3ee6de7973329
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136066
Reviewed-by: Eike Rathke 
Tested-by: Jenkins

diff --git a/sc/source/core/tool/odffmap.cxx b/sc/source/core/tool/odffmap.cxx
index 112854f4a71c..1a469208fc35 100644
--- a/sc/source/core/tool/odffmap.cxx
+++ b/sc/source/core/tool/odffmap.cxx
@@ -19,8 +19,8 @@
 
 #include 
 
-// ODFF, English, MapDupToInternal when writing ODFF, Programmatical, ODF_11
-// functions duplicated to internal when writing ODFF are listed in static 
const XclFunctionInfo saFuncTable_4[]
+// ODFF, English, Programmatical, ODF_11
+// Functions duplicated to internal when writing ODFF are listed in static 
const XclFunctionInfo saFuncTable_4[]
 const ScCompiler::AddInMap ScCompiler::g_aAddInMap[] =
 {
 { "ORG.OPENOFFICE.WEEKS", "WEEKS", 
"com.sun.star.sheet.addin.DateFunctions.getDiffWeeks", 
"COM.SUN.STAR.SHEET.ADDIN.DATEFUNCTIONS.GETDIFFWEEKS" },

[Libreoffice-bugs] [Bug 74439] Remember (and restore) size of Libreoffice dialogues boxes (File/Open etc) , after they are manually resized

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=74439

--- Comment #11 from Dan Dascalescu  ---
Related:
* bug 149598
* bug 101285 (which was recently fixed)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149598] New: "Format cells" dialog does not remember size

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149598

Bug ID: 149598
   Summary: "Format cells" dialog does not remember size
   Product: LibreOffice
   Version: 7.2.7.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddascalescu+freedesk...@gmail.com

Created attachment 180816
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180816=edit
Narrow number format column, cramped tabs

Every time I right click on a cell and choose Format Cells, I have to resize
that dialog in order to see the user-defined formats in their entirety.

Would it be possible to remember the size of this dialog?

Similar to bug 101285.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149494] Sidebar hamburger menu is now showing in Breeze Dark icon theme

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149494

--- Comment #3 from Rizal Muttaqin  ---
After looking at
https://github.com/rizmut/libreoffice-style-breeze/raw/master/libreoffice-style-breeze.png,
the icon should be icon-themes/breeze_svg/sfx2/res/symphony/open_more.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

Rizal Muttaqin  changed:

   What|Removed |Added

Summary|UI Calc Wrong icons showing |UI Calc Wrong icons showing
   |for format as general and   |for format as general
   |format as currency  |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138400] UI Calc Wrong icons showing for format as general and format as currency

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=138400

--- Comment #17 from Rizal Muttaqin  ---
As a side note, I will not change the icon for currency as we are agree to
avoid certain currency symbol to be used. Instead, the majority of icon themes
are using generic money symbol.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-06-17 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 72a33ebe0a50f289d1842881638ae763c2f2449c
Author: Olivier Hallot 
AuthorDate: Fri Jun 17 20:03:01 2022 -0300
Commit: Gerrit Code Review 
CommitDate: Sat Jun 18 01:03:01 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 65290dc95fe2efb330ac54ecf9d771984b4e5c9d
  - TDF#147862 (part) Update toolbar contents Help pages

+ Upgraded the Tools toolbar help page
+ several fixes in embeded files
+ bug147862 still work in progress

Change-Id: I35238075f6a917a8d7c39bfb5cbf6a5a6ebc783b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136063
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 3647d4f0a70c..65290dc95fe2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a
+Subproject commit 65290dc95fe2efb330ac54ecf9d771984b4e5c9d

[Libreoffice-commits] help.git: source/text

2022-06-17 Thread Olivier Hallot (via logerrit)

 source/text/shared/00/0406.xhp|   15 +++-
 source/text/shared/01/0305.xhp|9 
 source/text/shared/01/0306.xhp|6 +--
 source/text/shared/01/0602.xhp|2 -
 source/text/shared/01/0603.xhp|   27 ++
 source/text/swriter/00/0004.xhp   |   42 ---
 source/text/swriter/00/0403.xhp   |9 +---
 source/text/swriter/00/0406.xhp   |2 -
 source/text/swriter/01/0312.xhp   |4 +-
 source/text/swriter/01/0603.xhp   |   25 ++---
 source/text/swriter/02/1801.xhp   |   47 +++---
 source/text/swriter/02/1812.xhp   |9 ++--
 source/text/swriter/02/1813.xhp   |   19 ++
 source/text/swriter/main0200.xhp  |8 ++--
 source/text/swriter/track_changes_toolbar.xhp |4 +-
 15 files changed, 115 insertions(+), 113 deletions(-)

New commits:
commit 65290dc95fe2efb330ac54ecf9d771984b4e5c9d
Author: Olivier Hallot 
AuthorDate: Fri Jun 17 16:17:02 2022 -0300
Commit: Olivier Hallot 
CommitDate: Sat Jun 18 01:02:59 2022 +0200

TDF#147862 (part) Update toolbar contents Help pages

+ Upgraded the Tools toolbar help page
+ several fixes in embeded files
+ bug147862 still work in progress

Change-Id: I35238075f6a917a8d7c39bfb5cbf6a5a6ebc783b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136063
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/00/0406.xhp 
b/source/text/shared/00/0406.xhp
index a6903a822..901af13de 100644
--- a/source/text/shared/00/0406.xhp
+++ b/source/text/shared/00/0406.xhp
@@ -68,7 +68,20 @@
 Choose Tools - Spelling, then click 
Options.
 
 Choose 
Tools - Thesaurus.
-CommandCtrl+F7
+CommandCtrl+F7
+On the 
Tools bar, click
+
+
+
+
+Icon Thesaurus
+
+
+
+Thesaurus
+
+
+
 
 
 Choose 
Tools - Color Replacer ($[officename] Draw and $[officename] 
Impress).
diff --git a/source/text/shared/01/0305.xhp 
b/source/text/shared/01/0305.xhp
index 915910a56..64214960f 100644
--- a/source/text/shared/01/0305.xhp
+++ b/source/text/shared/01/0305.xhp
@@ -32,11 +32,18 @@
 tools bar
 
 
-Tools Bar
+Tools Bar
   Shows or hides the Tools 
bar.
 
 
   
 
+The Tools 
bar contains the following icons:
+
+
+
+
+
+
 
 
diff --git a/source/text/shared/01/0306.xhp 
b/source/text/shared/01/0306.xhp
index 08f8bd1b2..f6cc05e2b 100644
--- a/source/text/shared/01/0306.xhp
+++ b/source/text/shared/01/0306.xhp
@@ -39,10 +39,10 @@
 
 
 can remove this switch when there are related 
topics for BASE and DRAW
-
-
+
+
 
-
+
 
 
 
diff --git a/source/text/shared/01/0602.xhp 
b/source/text/shared/01/0602.xhp
index ab0549fd7..5f0186e93 100644
--- a/source/text/shared/01/0602.xhp
+++ b/source/text/shared/01/0602.xhp
@@ -30,7 +30,7 @@
 
 
 
-Thesaurus
+Thesaurus
 Opens a dialog box to replace the 
current word with a synonym, or a related term.
 
 
diff --git a/source/text/shared/01/0603.xhp 
b/source/text/shared/01/0603.xhp
index 1dbcd9b8b..4d7cda45a 100644
--- a/source/text/shared/01/0603.xhp
+++ b/source/text/shared/01/0603.xhp
@@ -1,6 +1,4 @@
 
-
-
 
-
 
 
 
@@ -31,7 +28,7 @@
 
 
 
-Color 
Replacer
+Color Replacer
 Opens the Color Replacer dialog, where you can replace colors in bitmap 
and meta file graphics.
 
 You can 
replace up to four different colors at one time.
@@ -46,12 +43,12 @@
 
 
 
-
+
 
 Icon

 
-
+
 Color 
Replacer
 
 
@@ -60,39 +57,39 @@
 
 Select one of the four source color boxes. Move the mouse 
pointer over the selected image, and then click the color that you want to 
replace.
 
-Color 
Replacer color
+Color Replacer color
 Displays the color in the selected image that directly underlies the 
current mouse pointer position. This features only works if the Color Replacer 
tool is selected.
 
-Replace
+Replace
 Replaces the selected source colors in 
the current image with the colors that you specify in the Replace with 
boxes.
-Colors
+Colors
 Lists the 
source colors and the replacement colors.
 
 
 
 
-Source 
color checkbox
+Source color checkbox
 Select this checkbox to replace the current Source color 
with the color that you specify in the Replace with 
box.
 
-Source 
color
+Source color
 Displays the color in the selected image that you want to replace. To 
set the source color, click here, click the Color Replacer, and then click a 
color in the selected image.
 
 
 
 
-Tolerance
+Tolerance
 Set the tolerance for replacing a source color in the source image. To 
replace colors that are similar to the color that you selected, enter a low 
value. To replace a wider range of colors,

[Libreoffice-bugs] [Bug 149494] Sidebar hamburger menu is now showing in Breeze Dark icon theme

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149494

--- Comment #2 from Rizal Muttaqin  ---
Sorry, I mean icon-themes/breeze_dark/sfx2/res/symphony/morebutton.png

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149494] Sidebar hamburger menu is now showing in Breeze Dark icon theme

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149494

Rizal Muttaqin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
Summary|Sidebar hamburger menu not  |Sidebar hamburger menu is
   |available in Breeze Dark|now showing in Breeze Dark
   |icon theme  |icon theme

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149494] Sidebar hamburger menu not available in Breeze Dark icon theme

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149494

Rizal Muttaqin  changed:

   What|Removed |Added

 CC||riz...@libreoffice.org

--- Comment #1 from Rizal Muttaqin  ---
Created attachment 180815
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180815=edit
LibreOffice 7.5 alpha

But in fact, the icon for breeze dark variant is not missing, see
icon-themes/breeze_dark/fx2/res/symphony/morebutton.png.

The suspect is in the code

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 8a5beccc19b4fdffb7b82ba5fd26f4cf316d9811
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
Calc: threaded

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 8a5beccc19b4fdffb7b82ba5fd26f4cf316d9811
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139057

--- Comment #14 from sdc.bla...@youmail.dk ---
(In reply to Telesto from comment #11)

In short and in general: Problems in comment 11 seem to stem from difficulties
in knowing how to select an anchor (see bug 146445 for relevant explanations),
which is related to/interacts with difficulty in knowing how to interpret the
current anchor icon properly to determine the anchor location. Bug 138351
discusses the issue of improving the display of anchor location -- but even if
that is improved, it is necessary to know how to insure that the anchor is
included in the selection.  

Possible "responses":
 - make it easier for a user to know when an anchor is included in a text
selection (but no proposals offered for design changes.)

 - give better documentation about how to insure selection of an anchor (but
less effective for those users who expect the interface to be "intuitive", and
therefore will not read documentation).


About selecting the anchor:

Here are three examples that will illustrate how to "succeed" in places where
you have "failed". Perhaps these positive examples (along with the explanations
in bug 146445) will help you to form an understanding of what is needed to
insure that an anchor is selected. 

> 3. Move the text up. Yellow and orange shape not moving 
Do NOT repro with cursor placed in paragraph and Ctrl+Alt+Up arrow. All shapes
move.
Do repro with Ctrl+X on selection and Ctrl+V.

> 8. Double click 'Blue'
> 9. Drag & drop below heading 1.. image not following 
> 11. Place cursor after 'yellow' and select blue with the space before
> 12. Drag up below heading 1. -> Only "blue' text moves image stays
8 and 11 show examples where you have failed to select the anchor.

Additional tests to show how to drag blue shape up, by including the anchor in
the selection.

13. Open attachment 180813, place cursor before "b" in blue, then select two
characters to left (i.e., space and "w" at end of yellow). Drag selection to
Heading 1, see "blue" shape follow.

14. Open attachment 180813, select blue shape, move anchor to middle of word
"blue". Double-click "blue", drag to Heading 1, see "blue" shape follow.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 90028] Importer drops Lotus Word Pro document formatting

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90028

--- Comment #25 from Todd  ---
It is still pretty much a mess.

Fedora 35
LibreOffice-7.3.4-Linux_x86-64_rpm.tar.gz

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149525] Add sparklines extended tips

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149525

Hossein  changed:

   What|Removed |Added

 CC||hoss...@libreoffice.org
   Keywords||difficultyBeginner,
   ||topicDoc, topicUI
 Whiteboard||reviewed:2022

--- Comment #2 from Hossein  ---
Two notes:

1. To find the "accessibility" tab, one may have to scroll the top right side
tab bar of the Glade to find the  (man) icon. Then a click on  (pencil) icon
to see "Context for translation" and other options.

2. One may need a recent version of Glade to be able to do this task. Try
opening the sc/uiconfig/scalc/ui/xmlsourcedialog.ui file and finding
"mlsourcedialog|extended_tip|XMLSourceDialog" as an example. I was using Glade
3.22.2 in Ubuntu 20.04, and the "Context for translation" field was completely
empty. Using Glade 3.38.2 in Ubuntu 22.04,
"xmlsourcedialog|extended_tip|XMLSourceDialog" is visible in that place.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112876] Make use of scroll lock for navigation configurable (it conflicts with system use as keyboard layout indicator)

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=112876

--- Comment #29 from Igor  ---
It is impossible to work when the whole sheet moves instead of moving through
the cells!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: helpcontent2

2022-06-17 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d8bc56ca9a6ce3fffb4ba2379c6a3f39211f6271
Author: Olivier Hallot 
AuthorDate: Fri Jun 17 16:41:07 2022 -0300
Commit: Gerrit Code Review 
CommitDate: Fri Jun 17 21:41:07 2022 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a
  - Refactor table into list in redlining_enter.xhp

Change-Id: Iba8074cd05c199f75d122955ebd4099262f7cde1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136062
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 665f218e5e02..3647d4f0a70c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 665f218e5e027ab3ad56bf6066d98d8323555ab3
+Subproject commit 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a

[Libreoffice-commits] help.git: source/text

2022-06-17 Thread Olivier Hallot (via logerrit)

 source/text/shared/guide/redlining_enter.xhp |   37 ---
 1 file changed, 11 insertions(+), 26 deletions(-)

New commits:
commit 3647d4f0a70cfdf67d03e725ceff0b2b1d14505a
Author: Olivier Hallot 
AuthorDate: Fri Jun 17 14:05:53 2022 -0300
Commit: Olivier Hallot 
CommitDate: Fri Jun 17 21:41:04 2022 +0200

Refactor table into list in redlining_enter.xhp

Change-Id: Iba8074cd05c199f75d122955ebd4099262f7cde1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/136062
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/guide/redlining_enter.xhp 
b/source/text/shared/guide/redlining_enter.xhp
index 397aa4fdf..dc8a94a03 100644
--- a/source/text/shared/guide/redlining_enter.xhp
+++ b/source/text/shared/guide/redlining_enter.xhp
@@ -36,32 +36,17 @@
 
   The review function is available in 
%PRODUCTNAME for text documents and spreadsheet documents.
   Not all 
changes are recorded. For example, the changing of a tab stop from align left 
to align right is not recorded. However, all usual changes made by a 
proofreader are recorded, such as additions, deletions, text alterations, and 
usual formatting.
-  
- 
-
-   1.
-
-
-   To start recording changes, open the document to be edited and 
choose Edit - Track Changes and then choose 
Record.
-
- 
- 
-
-   2.
-
-
-   Now start making your changes. You will note that all new text 
passages that you enter are underlined in color, while all text that you delete 
remains visible but is crossed out and shown in color.
-
- 
- 
-
-   3.
-
-
-   If you move to a marked change with the mouse pointer, you 
will see a reference to the type of change, the author, date and time of day 
for the change in the Help Tip. If the Extended Tips are also enabled, you will 
also see any available comments on this change.
-
- 
-  
+  
+ 
+To 
start recording changes, open the document to be edited and choose Edit - 
Track Changes and then choose Record.
+ 
+ 
+Now 
start making your changes. You will note that all new text passages that you 
enter are underlined in color, while all text that you delete remains visible 
but is crossed out and shown in color.
+ 
+ 
+If 
you move to a marked change with the mouse pointer, you will see a reference to 
the type of change, the author, date and time of day for the change in the Help 
Tip. If the Extended Tips are also enabled, you will also see any available 
comments on this change.
+ 
+  
 
 Changes in a 
spreadsheet document are highlighted by a border around the cells; when you 
point to the cell you can see more detailed information on this change in the 
Help Tip.
 You can enter 
a comment on each recorded change by placing the cursor in the area of the 
change and then choosing Edit - Track Changes - Comment. In 
addition to Extended Tips, the comment is also displayed in the list in the 
Manage 
Changes dialog.

[Libreoffice-ux-advise] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

--- Comment #6 from Commit Notification 
 ---
xuenhua committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0ec2b93c28093c80572c43f7be261630bd85f232

tdf#149431 Fix the sidebar's width

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

--- Comment #6 from Commit Notification 
 ---
xuenhua committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0ec2b93c28093c80572c43f7be261630bd85f232

tdf#149431 Fix the sidebar's width

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149431] Sidebar width is not suitable in Writer when switch from wide tab to narrow one

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149431

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: sfx2/source

2022-06-17 Thread xuenhua (via logerrit)

 sfx2/source/sidebar/SidebarController.cxx |9 +++--
 1 file changed, 7 insertions(+), 2 deletions(-)

New commits:
commit 0ec2b93c28093c80572c43f7be261630bd85f232
Author: xuenhua 
AuthorDate: Wed Jun 1 15:29:49 2022 +0800
Commit: Caolán McNamara 
CommitDate: Fri Jun 17 20:52:05 2022 +0200

tdf#149431 Fix the sidebar's width

When click the wider sidebar and then go back to the narrow one in Writer,
the narrow one becomes the same width as wider one, it's not suitable
and doesn't look good. Fix the width to smallest width unless you drag
the splitter. Take the maximum width from the smallest width and
mnWidthOnSplitterButtonDown.

Change-Id: I60aaab84593d59ac28b96c2d3c3bd62a4bbddbbe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135220
Tested-by: Jenkins
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sfx2/source/sidebar/SidebarController.cxx 
b/sfx2/source/sidebar/SidebarController.cxx
index cff76a95850b..088384641efd 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -506,6 +506,8 @@ void SidebarController::ProcessNewWidth (const sal_Int32 
nNewWidth)
 {
 // Deck became large enough to be shown.  Show it.
 mnSavedSidebarWidth = nNewWidth;
+// Store nNewWidth to mnWidthOnSplitterButtonDown when dragging 
sidebar Splitter
+mnWidthOnSplitterButtonDown = nNewWidth;
 if (!*mbIsDeckOpen)
 RequestOpenDeck();
 }
@@ -653,8 +655,12 @@ void SidebarController::OpenThenToggleDeck (
 if (mpCurrentDeck && mpTabBar)
 {
 sal_Int32 nRequestedWidth = mpCurrentDeck->GetMinimalWidth() + 
TabBar::GetDefaultWidth();
-if (mnSavedSidebarWidth < nRequestedWidth)
+// if sidebar was dragged
+if(mnWidthOnSplitterButtonDown > 0 && mnWidthOnSplitterButtonDown > 
nRequestedWidth){
+SetChildWindowWidth(mnWidthOnSplitterButtonDown);
+}else{
 SetChildWindowWidth(nRequestedWidth);
+}
 }
 }
 
@@ -1060,7 +1066,6 @@ IMPL_LINK(SidebarController, WindowEventHandler, 
VclWindowEvent&, rEvent, void)
 case VclEventId::WindowMouseButtonUp:
 {
 ProcessNewWidth(mpParentWindow->GetSizePixel().Width());
-mnWidthOnSplitterButtonDown = 0;
 break;
 }

[Libreoffice-commits] core.git: include/tools tools/source

2022-06-17 Thread Jan-Marek Glogowski (via logerrit)

 include/tools/gen.hxx|   30 +-
 tools/source/generic/gen.cxx |   17 -
 2 files changed, 29 insertions(+), 18 deletions(-)

New commits:
commit 80d801cf07b6583e824ad89c3c750b076118f41d
Author: Jan-Marek Glogowski 
AuthorDate: Tue Jun 14 05:37:30 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Fri Jun 17 20:41:28 2022 +0200

Rectangle: split SetSize into SetWidth/SetHeight

... and inline the functions.

Change-Id: I9285c72e8524f8f0a2d242bfd4cd29edf6d1ed73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135811
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/include/tools/gen.hxx b/include/tools/gen.hxx
index 7a8e66e2a6ff..ab8b443ca403 100644
--- a/include/tools/gen.hxx
+++ b/include/tools/gen.hxx
@@ -537,7 +537,9 @@ public:
 /// Set the top edge of the rectangle to y, preserving the height
 inline void SetPosY(tools::Long y);
 inline void SetPos( const Point& rPoint );
-voidSetSize( const Size& rSize );
+inline void SetWidth(tools::Long);
+inline void SetHeight(tools::Long);
+inline void SetSize(const Size&);
 
 constexpr Point GetPos() const { return TopLeft(); }
 constexpr Size GetSize() const { return { GetWidth(), GetHeight() }; }
@@ -671,6 +673,32 @@ inline void tools::Rectangle::SetPos( const Point& rPoint )
 SetPosY(rPoint.Y());
 }
 
+inline void tools::Rectangle::SetWidth(tools::Long nWidth)
+{
+if (nWidth < 0)
+nRight = nLeft + nWidth + 1;
+else if (nWidth > 0)
+nRight = nLeft + nWidth - 1;
+else
+SetWidthEmpty();
+}
+
+inline void tools::Rectangle::SetHeight(tools::Long nHeight)
+{
+if (nHeight < 0)
+nBottom = nTop + nHeight + 1;
+else if (nHeight > 0)
+nBottom = nTop + nHeight - 1;
+else
+SetHeightEmpty();
+}
+
+inline void tools::Rectangle::SetSize(const Size& rSize)
+{
+SetWidth(rSize.Width());
+SetHeight(rSize.Height());
+}
+
 constexpr inline tools::Long tools::Rectangle::GetWidth() const
 {
 tools::Long n = 0;
diff --git a/tools/source/generic/gen.cxx b/tools/source/generic/gen.cxx
index 27120d6abbd1..069b7482cfba 100644
--- a/tools/source/generic/gen.cxx
+++ b/tools/source/generic/gen.cxx
@@ -42,23 +42,6 @@ size_t Pair::GetHashValue() const
 return hash;
 }
 
-void tools::Rectangle::SetSize( const Size& rSize )
-{
-if ( rSize.Width() < 0 )
-nRight  = nLeft + rSize.Width() +1;
-else if ( rSize.Width() > 0 )
-nRight  = nLeft + rSize.Width() -1;
-else
-SetWidthEmpty();
-
-if ( rSize.Height() < 0 )
-nBottom  = nTop + rSize.Height() +1;
-else if ( rSize.Height() > 0 )
-nBottom  = nTop + rSize.Height() -1;
-else
-SetHeightEmpty();
-}
-
 void tools::Rectangle::SaturatingSetSize(const Size& rSize)
 {
 if (rSize.Width() < 0)

[Libreoffice-commits] core.git: include/vcl vcl/inc

2022-06-17 Thread Jan-Marek Glogowski (via logerrit)

 include/vcl/WindowPosSize.hxx |5 +++--
 include/vcl/windowstate.hxx   |   29 +
 vcl/inc/salgeom.hxx   |2 +-
 3 files changed, 33 insertions(+), 3 deletions(-)

New commits:
commit e2a8b4a420ab0f726c43ec6c609d17211cd6ed11
Author: Jan-Marek Glogowski 
AuthorDate: Sun Jun 12 08:01:32 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Fri Jun 17 20:27:50 2022 +0200

Fix and add ostreams for vcl::WindowPosSize

... and inheriting classes.

Follow-up on commit ea5a0918c8c32309821ab239c4b95f4d6a3b5c12
("VCL add vcl::WindowPosSize abstract class").

Change-Id: I4733cd4619f91fe1ba05c208a650be591ecf5d8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135806
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/include/vcl/WindowPosSize.hxx b/include/vcl/WindowPosSize.hxx
index ed52488be33a..6c5484c47b30 100644
--- a/include/vcl/WindowPosSize.hxx
+++ b/include/vcl/WindowPosSize.hxx
@@ -124,9 +124,10 @@ public:
 void setPosSize(const Point& rPos, const Size& rSize) { setPosSize({ rPos, 
rSize }); }
 };
 
-inline std::ostream& operator<<(std::ostream& s, const WindowPosSize& rGeom)
+inline std::ostream& operator<<(std::ostream& s, const WindowPosSize& rPosSize)
 {
-s << rGeom.width() << "x" << rGeom.height() << "@(" << rGeom.x() << "," << 
rGeom.y() << ")";
+s << rPosSize.width() << "x" << rPosSize.height() << "@(" << rPosSize.x() 
<< "," << rPosSize.y()
+  << ")";
 return s;
 }
 
diff --git a/include/vcl/windowstate.hxx b/include/vcl/windowstate.hxx
index 772d5c397f76..ed3cbf1a7f6e 100644
--- a/include/vcl/windowstate.hxx
+++ b/include/vcl/windowstate.hxx
@@ -115,6 +115,35 @@ template <> struct typed_flags : 
is_typed_flags(rData.state()) << 
std::dec;
+else
+s << "?";
+return s;
+}
+
+} // namespace vcl
+
 #endif // INCLUDED_VCL_WINDOWSTATE_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/salgeom.hxx b/vcl/inc/salgeom.hxx
index 63675b6d9ceb..1b19931c5c50 100644
--- a/vcl/inc/salgeom.hxx
+++ b/vcl/inc/salgeom.hxx
@@ -98,7 +98,7 @@ public:
 
 inline std::ostream& operator<<(std::ostream& s, const SalFrameGeometry& rGeom)
 {
-s << static_cast() << ":{" << 
rGeom.leftDecoration() << ","
+s << *static_cast() << ":{" << 
rGeom.leftDecoration() << ","
   << rGeom.topDecoration() << "," << rGeom.rightDecoration() << "," << 
rGeom.bottomDecoration()
   << "}s" << rGeom.screen();
 return s;

Re: How to write OOXML attribute 'vert' of element to ODF?

2022-06-17 Thread Regina Henschel

Hi Mark,

Mark Hung schrieb am 17.06.2022 um 17:17:

Hi Regina,

Regina Henschel > 於 2022年6月16日 週四 晚上8:49寫道：

Hi all,

Currently the "vert" attribute of element is connected to
TextPreRotateAngle property. vert="vert" produces
TextPreRotateAngle=-90
and vert="vert270" produces TextPreRotateAngle=-270. When converting it
to ODF it produces draw:text-rotate-angle="-90" and
draw:text-rotate-angle="-270".

That approach does not work, because the ODF attribute
draw:text-rotate-angle produces a rotation of the text area rectangle,
same as the 'rot' attribute of element in OOXML. Try with
attached file the export to ODF and reload to see the problem.

For using draw:text-rotate-angle attribute it would be necessary to
change the values of the draw:text-areas attribute in addition. But
this
requires introducing additional equations and it conflicts with the
definitions of the predefined shapes of the presets.

My idea is to introduce a new loext:text-direction attribute of the
element, which can carry each of the values of
the OOXML attribute 'vert'. "Each" needs to be discussed, perhaps
better
to exclude values eaVert and mongolianVert, which in fact are writing
modes TB_RL and TB_LR. Possible values would be ("eaVert"), "horz",
("mongolianVert"), "vert", "vert270", "wordArtVert" and
"wordArtVertRtl".

It's not clear to me why you think eaVert, and mongolianVert should be
excluded here.

Maybe you can explain further.

vert="eaVert" in a shape describes the same as WritingMode2::RL_TB and
WritingMode::RL_TB. vert="mongolianVert" in a shape describes the same
as WringingMode::TB_LR. Setting the writing mode is already used for
"eaVert" in
https://opengrok.libreoffice.org/xref/core/oox/source/shape/WpsContext.cxx?r=adf7d6ef#70
So it might be better to use that too in
https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/textbodypropertiescontext.cxx?r=486a11ad#117

AFAIK, we can currently not use WritingMode2 in these places. But
because WritingMode is deprecated, it might be more seminal to improve
the implementation to use WritingMode2. And then be able to use "TB_LR"
for "mongolianVert". We are already able to render "TB_LR" in Writer
text frames, but not for text in custom shapes.

Both "eaVert" and "mongolianVert" are not pure geometrical, but consider
east asian scripts, so that such characters are excluded from the rotation.

It seems to me that:
- horz, vert, vert270 are effectively horizontal (LR_TB or RL_TB) with
different rotation angles.

Yes. That makes it possible to render "vert" and "vert270" by
incorporating the "TextPreRotateAngle" into aTextBoxMatrix in

https://opengrok.libreoffice.org/xref/core/svx/source/sdr/contact/viewcontactofsdrobjcustomshape.cxx?r=b739bdab#160

The same matrix gets later the "TextRotateAngle" incorporated, which
describes the rotation of the text area rectangle. And only for that one
a corresponding attribute is available in ODF.

CJK text ( along its upright axis ) is perpendicular to the run direction.

- eaVert, wordArtVertRtl : TB_RL. CJK text is parallel to the run direction.

- mongolianVert, wordArtVert: TB_LR. CJK text is parallel to the run
direction.

CJK characters are not rotated for eaVert and mongolianVert.

Both wordArtVertRtl and wordArtVert don't apply rotation to Latin
scripts - which I think is something missing in LibreOffice.

wordArtVertRTL and wordArtVert are currently not implemented in LO, but
the rendering in PowerPoint is so, that the CJK characters are not rotated.

We don't have the attribute to keep the state. We always render Latin
script text in vertical writing as same as in horizontal writing, only
rotate the whole run.

Not always. We can render WritingMode::TB_RL (=eaVert) in custom shapes,
both with and without attached text frame. For import from pptx, I think
the error is in
https://opengrok.libreoffice.org/xref/core/oox/source/drawingml/textbodypropertiescontext.cxx?r=486a11ad#116.
But I have not yet tested it, because first I want a clear separation of
"TextPreRotateAngle" (attribute 'vert' in OOXML) and "TextRotateAngle"
(attribute 'rot' in OOXML).

Kind regards
Regina

[Libreoffice-commits] core.git: vcl/inc vcl/win

2022-06-17 Thread Jan-Marek Glogowski (via logerrit)

 vcl/inc/win/salframe.h  |   10 +-
 vcl/win/window/salframe.cxx |  201 +---
 2 files changed, 88 insertions(+), 123 deletions(-)

New commits:
commit 8b6000f6075725b2e17b8fa745251ea96d7185f1
Author: Jan-Marek Glogowski 
AuthorDate: Mon Jun 13 10:26:18 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Fri Jun 17 19:58:08 2022 +0200

WIN drop window state redundancies

So on Windows a window's state is stored in:
- maGeometry, inherited from SalFrame
- maState, which is the same type then maGeometry
- mnWidth and mnHeight, which are just set, never read
- mbFullScreen, which can be encoded in the vcl::WindowState

IMHO we can get rid of mnWidth, mnHeight and mbFullScreen. Which
leaves the mystery of the extra maState. But at least it looks
like we can simply cache an vcl::WindowState instead.

And this is a little start to make WinSalFrame variable members
private; it'll be a long way...

And it also changes a SW_SHOWMAXIMIZED to SW_SHOWMINIMIZED in the
cleaned UpdateFrameState(), which looks like an error.

Change-Id: I5895313d87a6f81371e2b77af6c813d35f591725
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135809
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/inc/win/salframe.h b/vcl/inc/win/salframe.h
index 0e3cbba81253..bbf3506a723f 100644
--- a/vcl/inc/win/salframe.h
+++ b/vcl/inc/win/salframe.h
@@ -33,6 +33,8 @@ class WinSalGraphics;
 
 class WinSalFrame final: public SalFrame
 {
+vcl::WindowState m_eState;
+
 public:
 HWNDmhWnd;  // Window handle
 HCURSOR mhCursor;   // cursor handle
@@ -43,10 +45,7 @@ public:
 HMENU   mSelectedhMenu; // the menu where 
highlighting is currently going on
 HMENU   mLastActivatedhMenu;// the menu that was most 
recently opened
 SystemEnvData   maSysData;  // system data
-vcl::WindowData maState; ///< frame state
 int mnShowState;// show state
-LONGmnWidth;// client width in pixeln
-LONGmnHeight;   // client height in pixeln
 int mnMinWidth; // min. client width in 
pixeln
 int mnMinHeight;// min. client height in 
pixeln
 int mnMaxWidth; // max. client width in 
pixeln
@@ -64,7 +63,6 @@ public:
 boolmbSizeBorder;   // has window a sizeable 
border
 boolmbNoIcon;   // is a window without an 
icon
 boolmbFloatWin; // is a FloatingWindow
-boolmbFullScreen;   // TRUE: in full screen 
mode
 boolmbPresentation; // TRUE: Presentation Mode 
running
 boolmbInShow;   // inside a show call
 boolmbRestoreMaximize;  // Restore-Maximize
@@ -141,6 +139,10 @@ public:
 virtual voidBeginSetClipRegion( sal_uInt32 nRects ) 
override;
 virtual voidUnionClipRegion( tools::Long nX, tools::Long 
nY, tools::Long nWidth, tools::Long nHeight ) override;
 virtual voidEndSetClipRegion() override;
+
+constexpr vcl::WindowState state() const { return m_eState; }
+void UpdateFrameState();
+constexpr bool isFullScreen() const { return bool(m_eState & 
vcl::WindowState::FullScreen); }
 };
 
 void ImplSalGetWorkArea( HWND hWnd, RECT *pRect, const RECT *pParentRect );
diff --git a/vcl/win/window/salframe.cxx b/vcl/win/window/salframe.cxx
index 2b2bd6cb7b72..567d95eec233 100644
--- a/vcl/win/window/salframe.cxx
+++ b/vcl/win/window/salframe.cxx
@@ -128,7 +128,7 @@ bool WinSalFrame::mbInReparent = false;
 // Macros for support of WM_UNICHAR & Keyman 6.0
 #define Uni_SupplementaryPlanesStart0x1
 
-static void UpdateFrameGeometry( HWND hWnd, WinSalFrame* pFrame );
+static void UpdateFrameGeometry(WinSalFrame* pFrame);
 static void SetMaximizedFrameGeometry( HWND hWnd, WinSalFrame* pFrame, RECT* 
pParentRect = nullptr );
 
 static void SetGeometrySize(vcl::WindowPosSize& rWinPosSize, const Size& rSize)
@@ -137,57 +137,37 @@ static void SetGeometrySize(vcl::WindowPosSize& 
rWinPosSize, const Size& rSize)
 rWinPosSize.setHeight(rSize.Height() < 0 ? 0 : rSize.Height());
 }
 
-static void UpdateGeometry(WinSalFrame* pFrame, RECT& aRect)
+// If called with UpdateFrameGeometry, it must be called after it, as 
UpdateFrameGeometry
+// updates the geometry depending on the old state!
+void WinSalFrame::UpdateFrameState()
 {
-RECT aRect2 = aRect;
-AdjustWindowRectEx(, GetWindowStyle(pFrame->mhWnd),
-   FALSE, GetWindowExStyle(pFrame->mhWnd));
-

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2022-06-17 Thread Michael Weghorn (via logerrit)

 vcl/inc/qt5/QtAccessibleEventListener.hxx |3 
 vcl/qt5/QtAccessibleEventListener.cxx |  115 +-
 2 files changed, 116 insertions(+), 2 deletions(-)

New commits:
commit 8c3e8af0e60865ec6d38e2117efdb4ed2f10a20c
Author: Michael Weghorn 
AuthorDate: Fri Jun 17 17:29:19 2022 +0200
Commit: Michael Weghorn 
CommitDate: Fri Jun 17 19:30:29 2022 +0200

qt a11y: Forward STATE_CHANGED event as such

Handle `AccessibleEventId::STATE_CHANGED` by
sending a corresponding `QAccessibleStateChangeEvent`.

The previous way of sending a `QAccessible::ForegroundChanged`
event looked rather arbitrary and had no effect in practice,
since that type of event is currently ignored in Qt's AT-SPI adapter
anyway.

At this point in time, the Qt library doesn't forward
changes of all states to the AT-SPI layer. Most notably,
it ignores changes to the focused state.
(Qt itself uses events of type `QAccessible::Focus`
instead of `QAccessibleStateChangeEvent` with the `focused`
state set to notify about focus changes, but that's not exactly the
same, and e.g. causes Orca to ignore some focus changes).
I have submitted a change to Qt to implement
forwarding of `QAccessibleStateChangeEvent`s for the
focused state to the AT-SPI layer, currently awaiting
review. [1]

With that Qt change in place, Orca still ignored these
events in LibreOffice message dialogs, since those
use a11y role `ALERT`, which wasn't previously considered
when trying to retrieve a potential dialog that an
a11y object belonged to.
The corresponding Orca merge request [2] has just been merged.

With these two in place, Orca now announces the focused
button when switching focus using the tab key
e.g. in the "Save document?" dialog when using the qt6 VCL plugin.
(Most other things in the LO UI are still usually not announced.)

For some reason, forwarding changes to state `AccessibleStateType::ACTIVE`
resulted in Orca becoming unresponsive (stop talking) quite quickly.
That needs further analysis, so that state change isn't forwarded
to Qt for now.

[1] https://codereview.qt-project.org/c/qt/qtbase/+/416510
[2] https://gitlab.gnome.org/GNOME/orca/-/merge_requests/127

Change-Id: I81c9a0f5ec8c74f95943d3073bba5b304f995d31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136057
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/inc/qt5/QtAccessibleEventListener.hxx 
b/vcl/inc/qt5/QtAccessibleEventListener.hxx
index a73f6d31f2f8..1103dc9da598 100644
--- a/vcl/inc/qt5/QtAccessibleEventListener.hxx
+++ b/vcl/inc/qt5/QtAccessibleEventListener.hxx
@@ -33,6 +33,9 @@ public:
 private:
 css::uno::Reference m_xAccessible;
 QtAccessibleWidget* m_pAccessibleWidget;
+
+static void HandleStateChangedEvent(QAccessibleInterface* 
pQAccessibleInterface,
+const 
css::accessibility::AccessibleEventObject& rEvent);
 };
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qt5/QtAccessibleEventListener.cxx 
b/vcl/qt5/QtAccessibleEventListener.cxx
index 515584351c74..ee9acc651599 100644
--- a/vcl/qt5/QtAccessibleEventListener.cxx
+++ b/vcl/qt5/QtAccessibleEventListener.cxx
@@ -23,6 +23,7 @@
 #include 
 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -41,6 +42,117 @@ QtAccessibleEventListener::QtAccessibleEventListener(const 
Reference>= nState;
+// States in 'QAccessibleStateChangeEvent' indicate what states have 
changed, so if e.g.
+// an object loses focus (not just if it gains it), 'focus' state needs to 
be set to 'true',
+// so retrieve the old/previous value from the event if necessary.
+if (nState == AccessibleStateType::INVALID)
+rEvent.OldValue >>= nState;
+
+switch (nState)
+{
+case AccessibleStateType::ACTIVE:
+// ignore for now, since it somehow causes Orca to become 
unresponsive quite quickly
+// TODO: analyze further and fix root cause
+/*
+aState.active = true;
+break;
+*/
+return;
+case AccessibleStateType::BUSY:
+aState.busy = true;
+break;
+case AccessibleStateType::CHECKED:
+aState.checked = true;
+break;
+case AccessibleStateType::COLLAPSE:
+aState.collapsed = true;
+break;
+case AccessibleStateType::DEFAULT:
+aState.defaultButton = true;
+break;
+case AccessibleStateType::ENABLED:
+aState.disabled = true;
+break;
+case AccessibleStateType::EDITABLE:
+aState.editable = true;
+break;
+case AccessibleStateType::EXPANDABLE:
+aState.expandable = true;
+break;
+case AccessibleStateType::EXPANDED:
+

Diane Leigh license statement

2022-06-17 Thread Diane Leigh

 All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source vcl/unx

2022-06-17 Thread Jan-Marek Glogowski (via logerrit)

 include/vcl/windowstate.hxx  |1 +
 vcl/inc/window.h |2 --
 vcl/source/window/syswin.cxx |8 +++-
 vcl/unx/gtk3/gtkinst.cxx |4 +---
 4 files changed, 5 insertions(+), 10 deletions(-)

New commits:
commit 2e509b886f1d77ef158579385b55f1f94cfbc710
Author: Jan-Marek Glogowski 
AuthorDate: Sun Jun 12 17:42:05 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Fri Jun 17 19:14:05 2022 +0200

Convert ImplWindowStateFromStr to WindowData(str)

To have a constructor as the counterpart of the toStr() function.
Better then some unrelated independant function.

Change-Id: Iba4cb3d400a92704753db6b35d12f2189b23077e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135807
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/include/vcl/windowstate.hxx b/include/vcl/windowstate.hxx
index b78162ddf52e..772d5c397f76 100644
--- a/include/vcl/windowstate.hxx
+++ b/include/vcl/windowstate.hxx
@@ -80,6 +80,7 @@ public:
 , mnMaximizedHeight(0)
 {
 }
+WindowData(std::string_view rStr);
 
 // serialize values to a string (the original WindowState representation)
 OString toStr() const;
diff --git a/vcl/inc/window.h b/vcl/inc/window.h
index 18e1a3e1e417..3021e8bc7b6b 100644
--- a/vcl/inc/window.h
+++ b/vcl/inc/window.h
@@ -433,8 +433,6 @@ bool ImplLOKHandleMouseEvent( const VclPtr& 
xWindow, MouseNotifyEve
 
 void ImplHandleResize( vcl::Window* pWindow, tools::Long nNewWidth, 
tools::Long nNewHeight );
 
-VCL_DLLPUBLIC void ImplWindowStateFromStr(vcl::WindowData& rData, 
std::string_view rStr);
-
 VCL_DLLPUBLIC css::uno::Reference
 
FindFocusedEditableText(css::uno::Reference
 const&);
 
diff --git a/vcl/source/window/syswin.cxx b/vcl/source/window/syswin.cxx
index 113b2da02689..5a5baf380e71 100644
--- a/vcl/source/window/syswin.cxx
+++ b/vcl/source/window/syswin.cxx
@@ -399,8 +399,9 @@ const Size& SystemWindow::GetMaxOutputSizePixel() const
 return mpImplData->maMaxOutSize;
 }
 
-void ImplWindowStateFromStr(vcl::WindowData& rData, std::string_view rStr)
+vcl::WindowData::WindowData(std::string_view rStr)
 {
+vcl::WindowData& rData = *this;
 vcl::WindowDataMask nValidMask = vcl::WindowDataMask::NONE;
 sal_Int32 nIndex  = 0;
 
@@ -826,10 +827,7 @@ void SystemWindow::SetWindowState(std::string_view rStr)
 {
 if (rStr.empty())
 return;
-
-vcl::WindowData aData;
-ImplWindowStateFromStr( aData, rStr );
-SetWindowState( aData );
+SetWindowState(vcl::WindowData(rStr));
 }
 
 OString SystemWindow::GetWindowState(vcl::WindowDataMask nMask) const
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index a49e32dc8cfa..6959f80698b0 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -6334,9 +6334,7 @@ public:
 
 virtual void set_window_state(const OString& rStr) override
 {
-vcl::WindowData aData;
-ImplWindowStateFromStr( aData, rStr );
-
+const vcl::WindowData aData(rStr);
 const auto nMask = aData.mask();
 const auto nState = aData.state() & vcl::WindowState::SystemMask;

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 13 commits - chart2/source oox/inc oox/source

2022-06-17 Thread Tomaž Vajngerl (via logerrit)

Rebased ref, commits from common ancestor:
commit 8ab457543b0e3444029bb46c29111aa11f2c04ba
Author: Tomaž Vajngerl 
AuthorDate: Fri Jun 17 16:38:54 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jun 17 17:52:17 2022 +0200

chart2: remove unneeded class prefix in ObjectHierarchy.cxx

Change-Id: Iee007f7ff4d9665ee089712e7ba98090a8090609

diff --git a/chart2/source/controller/main/ObjectHierarchy.cxx 
b/chart2/source/controller/main/ObjectHierarchy.cxx
index ab1fa891377e..c696a94d8fcd 100644
--- a/chart2/source/controller/main/ObjectHierarchy.cxx
+++ b/chart2/source/controller/main/ObjectHierarchy.cxx
@@ -115,7 +115,7 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 ObjectIdentifier aDiaOID;
 if( xDiagram.is() )
 aDiaOID = ObjectIdentifier( 
ObjectIdentifier::createClassifiedIdentifierForObject( 
static_cast(xDiagram.get()), xChartDocument ) );
-ObjectHierarchy::tChildContainer aTopLevelContainer;
+tChildContainer aTopLevelContainer;
 
 // First Level
 
@@ -158,7 +158,7 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 createDiagramTree( aTopLevelContainer, xChartDocument, xDiagram );
 else
 {
-ObjectHierarchy::tChildContainer aSubContainer;
+tChildContainer aSubContainer;
 createDiagramTree( aSubContainer, xChartDocument, xDiagram );
 if( !aSubContainer.empty() )
 m_aChildMap[ aDiaOID ] = aSubContainer;
@@ -179,11 +179,11 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 aTopLevelContainer.emplace_back( 
ObjectIdentifier::createClassifiedIdentifier( OBJECTTYPE_PAGE, u"" ) );
 
 if( ! aTopLevelContainer.empty())
-m_aChildMap[ ObjectHierarchy::getRootNodeOID() ] = aTopLevelContainer;
+m_aChildMap[ObjectHierarchy::getRootNodeOID()] = aTopLevelContainer;
 }
 
 void ObjectHierarchy::createLegendTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram  )
 {
@@ -199,7 +199,7 @@ void ObjectHierarchy::createLegendTree(
 rtl::Reference< SvxShapeGroupAnyD > xLegendShapeContainer =
 dynamic_cast(
 m_pExplicitValueProvider->getShapeForCID( 
aLegendOID.getObjectCID() ).get() );
-ObjectHierarchy::tChildContainer aLegendEntryOIDs;
+tChildContainer aLegendEntryOIDs;
 lcl_getChildOIDs( aLegendEntryOIDs, xLegendShapeContainer );
 
 m_aChildMap[ aLegendOID ] = aLegendEntryOIDs;
@@ -207,7 +207,7 @@ void ObjectHierarchy::createLegendTree(
 }
 
 void ObjectHierarchy::createAxesTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram  )
 {
@@ -271,7 +271,7 @@ void ObjectHierarchy::createAxesTree(
 }
 
 void ObjectHierarchy::createWallAndFloor(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference< Diagram > & xDiagram )
 {
 sal_Int32 nDimensionCount = DiagramHelper::getDimension( xDiagram );
@@ -289,7 +289,7 @@ void ObjectHierarchy::createWallAndFloor(
 }
 
 void ObjectHierarchy::createDiagramTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram )
 {
@@ -307,7 +307,7 @@ void ObjectHierarchy::createDiagramTree(
 }
 
 void ObjectHierarchy::createDataSeriesTree(
-ObjectHierarchy::tChildContainer & rOutDiagramSubContainer,
+tChildContainer & rOutDiagramSubContainer,
 const rtl::Reference< Diagram > & xDiagram )
 {
 try
@@ -334,7 +334,7 @@ void ObjectHierarchy::createDataSeriesTree(
 ObjectIdentifier( 
ObjectIdentifier::createClassifiedIdentifierForParticle( aSeriesParticle ) ) );
 rOutDiagramSubContainer.push_back( aSeriesOID );
 
-ObjectHierarchy::tChildContainer aSeriesSubContainer;
+tChildContainer aSeriesSubContainer;
 
 rtl::Reference< DataSeries > const & xSeries = 
aSeriesSeq[nSeriesIdx];
 
@@ -406,7 +406,7 @@ void ObjectHierarchy::createDataSeriesTree(
 }
 }
 
-void ObjectHierarchy::createAdditionalShapesTree( 
ObjectHierarchy::tChildContainer& rContainer )
+void ObjectHierarchy::createAdditionalShapesTree(tChildContainer& rContainer)
 {
 try
 {
@@ -453,7 +453,7 @@ const ObjectHierarchy::tChildContainer & 
ObjectHierarchy::getChildren( const Obj
 if( aIt != m_aChildMap.end())
 return aIt->second;
 }
-static const ObjectHierarchy::tChildContainer EMPTY;
+static const tChildContainer EMPTY;
 return EMPTY;
 }
 
@@ -463,13 +463,13 @@

[Libreoffice-bugs] [Bug 149597] New: ENHANCEMENT: Multi-color line attribute (dashed lines with alternate background color

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149597

Bug ID: 149597
   Summary: ENHANCEMENT: Multi-color line attribute (dashed lines
with alternate background color
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikehughesdesi...@yahoo.com

Created attachment 180814
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180814=edit
The process of dual-colored lines now...

An enhancement to line attribute- line types of dash / dot-dash where the
"unfilled" or background color of the line is given a secondary color.

In electrical work (especially automotive) wires with a main color and a stripe
are drawn in schematics with 2-color lines. These show up as dashed lines of 2
colors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: offapi/com

2022-06-17 Thread Mike Kaganski (via logerrit)

 offapi/com/sun/star/view/XMultiSelectionSupplier.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5e0b95494093de2849c5154b98917e1beab2a708
Author: Mike Kaganski 
AuthorDate: Fri Jun 17 15:15:16 2022 +0200
Commit: Mike Kaganski 
CommitDate: Fri Jun 17 18:19:20 2022 +0200

Drop a bogus slash

... added in commit eae791e82c8e138cc983c3e7058cc4e9dafa4002
  Author Jens-Heiner Rechtien 
  Date   Wed Jun 27 11:30:00 2007 +
INTEGRATION: CWS awttree01 (1.1.2); FILE ADDED

where it was misplaced (intended to be , not /).

Commit  1501e17b889b28e7394596ce4f98eab1c5b00d8f
  Author Rüdiger Timm 
  Date   Wed Jan 30 07:20:16 2008 +
INTEGRATION: CWS dba24d (1.2.92); FILE MERGED

added '/' before the '>', but kept the incorrect initial one.

Later commit 928b8640c0d1a9c49249100efbdd70f8c1090b07
  Author Michael Stahl 
  Date   Sun Apr 28 00:44:31 2013 +0200
*api: convert

removed the correctly placed slashes. This is a leftover.

Change-Id: I800f28de02dd8447509bc236614cab05c2b8c0df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136037
Tested-by: Mike Kaganski 
Reviewed-by: Mike Kaganski 

diff --git a/offapi/com/sun/star/view/XMultiSelectionSupplier.idl 
b/offapi/com/sun/star/view/XMultiSelectionSupplier.idl
index e6e4c48c97fe..937d3d347013 100644
--- a/offapi/com/sun/star/view/XMultiSelectionSupplier.idl
+++ b/offapi/com/sun/star/view/XMultiSelectionSupplier.idl
@@ -41,7 +41,7 @@ interface XMultiSelectionSupplier: XSelectionSupplier
 either an Object that is selectable or a sequence of objects that 
are selectable.
 
 @returns
-`TRUE`/, if Selection was added to the current 
selection.
+`TRUE`, if Selection was added to the current selection.
 `FALSE`, if Selection or parts of Selection 
could not be
 added to the current selection. For example, if the selection 
already contains
 objects that are forbidden to be selected together with 
Selection

[Libreoffice-bugs] [Bug 123846] Assign styles dialog not accessible

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=123846

--- Comment #6 from Joanmarie Diggs  ---
The LibreOffice script in Orca can check the toolkit and defer to the Gtk
script if it's native Gtk.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139057

--- Comment #13 from Eyal Rozenberg  ---
"Image to character/paragraph at the end or beginning of a paragraph isn't
included in a single line section"

Do you mean "an image anchored to a character or to a paragraph, or at the
beginning of a paragraph, isn't included when selecting the single line
containing  that character, or the end of the paragraph, or the beginning of
the paragraph respectively"?

If not, please try to rephrase the title.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139057

Telesto  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com,
   ||sdc.bla...@youmail.dk

--- Comment #12 from Telesto  ---
I would like some extra input/ other perspectives on the topic here

@Seth,
You fixed quite a number of documentation issues... and well you're also good
at investing a design.. 

This might become a documentation topic some point anyhow

@Eyal
You're comments are always appreciated..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139057] Image to character/paragraph at the end or beginning of a paragraph isn't included in a single line section

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139057

--- Comment #11 from Telesto  ---
Created attachment 180813
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180813=edit
Example file

Sorry that I keep going .. 
1. Open the attached file
2. Select the highlighted text
3. Move the text up. Yellow and orange shape not moving (yes, I know: anchored
at beginning and end of a singe paragraph)
4. CTRL+Z
5. Place arrow before 'ghi'
6. Press Shift Arrow Down (2 paragraph selected). Drag and drop the text below
heading 1 -> all images follow
7. CTRL+Z
8. Double click 'Blue'
9. Drag & drop below heading 1.. image not following (image anchored 'before'
b)
10. CTRL+Z
11. Place cursor after 'yellow' and select blue with the space before
12. Drag up below heading 1. -> Only "blue' text moves image stays

I do not really understand why multi-line paragraph will include images.. but
single paragraph not..

And why an anchor at the left of word isn't included  with the selection
(especially if the space is also included)

There is obviously the possibility that I'm mistaking about what to character
anchoring is and how it should be used. Aka I might have different expectations
compared to the design (how I think it should working < - > How it's actually
working). And there obviously also a difference between 'ideal situation' and
the part which is technically possible. And yes, sure, there likely always
which don't fit any model. (So being off)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149596] New: UI Groupedbar is missing

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149596

Bug ID: 149596
   Summary: UI Groupedbar is missing
   Product: LibreOffice
   Version: 7.4.0.0 beta1+
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: po...@rocketmail.com

Description:
UI Groupedbar is missing, only UI Groupedbar compact available.

Actual Results:
UI Groupedbar is missing

Expected Results:
Bring UI Groupedbar back.


Reproducible: Always


User Profile Reset: No



Additional Info:
In 7.3.x still available.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/qt5

2022-06-17 Thread Jan-Marek Glogowski (via logerrit)

 vcl/inc/qt5/QtWidget.hxx |   24 +++-
 vcl/qt5/QtWidget.cxx |   25 -
 2 files changed, 15 insertions(+), 34 deletions(-)

New commits:
commit 393c9f736b10d1ea82979e9c2c43c8f91ba5831d
Author: Jan-Marek Glogowski 
AuthorDate: Tue Apr 19 16:00:31 2022 +0200
Commit: Jan-Marek Glogowski 
CommitDate: Fri Jun 17 17:27:16 2022 +0200

Qt use QEvent::type to handle the event correctly

No need for an extra function parameter.

Change-Id: Iedb949b45ad3f161121110e2db2132b6c3cb706e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135894
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski 

diff --git a/vcl/inc/qt5/QtWidget.hxx b/vcl/inc/qt5/QtWidget.hxx
index e644e7f70cd9..e61357198027 100644
--- a/vcl/inc/qt5/QtWidget.hxx
+++ b/vcl/inc/qt5/QtWidget.hxx
@@ -42,17 +42,10 @@ class QtWidget : public QWidget
 int m_nDeltaX;
 int m_nDeltaY;
 
-enum class ButtonKeyState
-{
-Pressed,
-Released
-};
-
 static void commitText(QtFrame&, const QString& aText);
 static void deleteReplacementText(QtFrame& rFrame, int nReplacementStart,
   int nReplacementLength);
-static bool handleKeyEvent(QtFrame&, const QWidget&, QKeyEvent*, const 
ButtonKeyState);
-static void handleMouseButtonEvent(const QtFrame&, const QMouseEvent*, 
const ButtonKeyState);
+static bool handleKeyEvent(QtFrame&, const QWidget&, QKeyEvent*);
 static void handleMouseEnterLeaveEvents(const QtFrame&, QEvent*);
 static void fillSalAbstractMouseEvent(const QtFrame& rFrame, const 
QInputEvent* pQEvent,
   const QPoint& rPos, Qt::MouseButtons 
eButtons, int nWidth,
@@ -101,23 +94,12 @@ public:
 // key events might be propagated further down => call base on false
 static inline bool handleKeyReleaseEvent(QtFrame&, const QWidget&, 
QKeyEvent*);
 // mouse events are always accepted
-static inline void handleMousePressEvent(const QtFrame&, const 
QMouseEvent*);
-static inline void handleMouseReleaseEvent(const QtFrame&, const 
QMouseEvent*);
+static void handleMouseButtonEvent(const QtFrame&, const QMouseEvent*);
 };
 
 bool QtWidget::handleKeyReleaseEvent(QtFrame& rFrame, const QWidget& rWidget, 
QKeyEvent* pEvent)
 {
-return handleKeyEvent(rFrame, rWidget, pEvent, ButtonKeyState::Released);
-}
-
-void QtWidget::handleMousePressEvent(const QtFrame& rFrame, const QMouseEvent* 
pEvent)
-{
-handleMouseButtonEvent(rFrame, pEvent, ButtonKeyState::Pressed);
-}
-
-void QtWidget::handleMouseReleaseEvent(const QtFrame& rFrame, const 
QMouseEvent* pEvent)
-{
-handleMouseButtonEvent(rFrame, pEvent, ButtonKeyState::Released);
+return handleKeyEvent(rFrame, rWidget, pEvent);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/qt5/QtWidget.cxx b/vcl/qt5/QtWidget.cxx
index 5c6fc002ac22..e26e1e3aee1f 100644
--- a/vcl/qt5/QtWidget.cxx
+++ b/vcl/qt5/QtWidget.cxx
@@ -153,8 +153,7 @@ void QtWidget::fillSalAbstractMouseEvent(const QtFrame& 
rFrame, const QInputEven
 #define FILL_SAME(rFrame, nWidth)  
\
 fillSalAbstractMouseEvent(rFrame, pEvent, pEvent->pos(), 
pEvent->buttons(), nWidth, aEvent)
 
-void QtWidget::handleMouseButtonEvent(const QtFrame& rFrame, const 
QMouseEvent* pEvent,
-  const ButtonKeyState eState)
+void QtWidget::handleMouseButtonEvent(const QtFrame& rFrame, const 
QMouseEvent* pEvent)
 {
 SalMouseEvent aEvent;
 FILL_SAME(rFrame, rFrame.GetQWidget()->width());
@@ -175,7 +174,7 @@ void QtWidget::handleMouseButtonEvent(const QtFrame& 
rFrame, const QMouseEvent*
 }
 
 SalEvent nEventType;
-if (eState == ButtonKeyState::Pressed)
+if (pEvent->type() == QEvent::MouseButtonPress)
 nEventType = SalEvent::MouseButtonDown;
 else
 nEventType = SalEvent::MouseButtonUp;
@@ -184,13 +183,13 @@ void QtWidget::handleMouseButtonEvent(const QtFrame& 
rFrame, const QMouseEvent*
 
 void QtWidget::mousePressEvent(QMouseEvent* pEvent)
 {
-handleMousePressEvent(m_rFrame, pEvent);
+handleMouseButtonEvent(m_rFrame, pEvent);
 if (m_rFrame.isPopup()
 && !geometry().translated(geometry().topLeft() * 
-1).contains(pEvent->pos()))
 closePopup();
 }
 
-void QtWidget::mouseReleaseEvent(QMouseEvent* pEvent) { 
handleMouseReleaseEvent(m_rFrame, pEvent); }
+void QtWidget::mouseReleaseEvent(QMouseEvent* pEvent) { 
handleMouseButtonEvent(m_rFrame, pEvent); }
 
 void QtWidget::mouseMoveEvent(QMouseEvent* pEvent)
 {
@@ -514,11 +513,12 @@ void QtWidget::deleteReplacementText(QtFrame& rFrame, int 
nReplacementStart, int
 rFrame.CallCallback(SalEvent::DeleteSurroundingTextRequest, );
 }
 
-bool QtWidget::handleKeyEvent(QtFrame& rFrame, const QWidget& rWidget, 
QKeyEvent* pEvent,
-  const ButtonKeyState eState)
+bool

[Libreoffice-bugs] [Bug 148803] "find" dialog does not get focus

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=148803

--- Comment #6 from Caolán McNamara  ---
Proving quite difficult to find a fix that doesn't cause another problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141495] CONFIGURATION = EOMONTH function corruption

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=141495

--- Comment #20 from Eike Rathke  ---
And also the LO version of course and operating system, thanks again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149595] New: Images disappearing when moving text with drag & drop & track changes record enabled

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149595

Bug ID: 149595
   Summary: Images disappearing when moving text with drag & drop
& track changes record enabled
   Product: LibreOffice
   Version: 7.4.0.0 beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tele...@surfxs.nl

Description:
Images disappearing when moving text with drag & drop & track changes record
enabled

Steps to Reproduce:
1. Open the attached file
2. Select the yellow text
3. Drag and drop to top (position doesn't really matter)

Actual Results:
Shapes at anchored at the start/end of the paragraph gone

Expected Results:
If it's up to me, image should be included within the drag.. But well the
current design is to leave those images behind.. disappearing is certainly not
OK


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.4.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 089c91b1ad16232f130cb50266732509f83c52eb
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (nl_NL); UI: en-GB
Calc: CL Jumbo

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: How to write OOXML attribute 'vert' of element to ODF?

2022-06-17 Thread Mark Hung

Hi Regina,

Regina Henschel  於 2022年6月16日 週四 晚上8:49寫道：

> Hi all,
>
> Currently the "vert" attribute of  element is connected to
> TextPreRotateAngle property. vert="vert" produces TextPreRotateAngle=-90
> and vert="vert270" produces TextPreRotateAngle=-270. When converting it
> to ODF it produces draw:text-rotate-angle="-90" and
> draw:text-rotate-angle="-270".
>
> That approach does not work, because the ODF attribute
> draw:text-rotate-angle produces a rotation of the text area rectangle,
> same as the 'rot' attribute of element  in OOXML. Try with
> attached file the export to ODF and reload to see the problem.
>
> For using draw:text-rotate-angle attribute it would be necessary to
> change the values of the draw:text-areas attribute in addition. But this
> requires introducing additional equations and it conflicts with the
> definitions of the predefined shapes of the presets.
>
> My idea is to introduce a new loext:text-direction attribute of the
>  element, which can carry each of the values of
> the OOXML attribute 'vert'. "Each" needs to be discussed, perhaps better
> to exclude values eaVert and mongolianVert, which in fact are writing
> modes TB_RL and TB_LR. Possible values would be ("eaVert"), "horz",
> ("mongolianVert"), "vert", "vert270", "wordArtVert" and "wordArtVertRtl".
>
>
It's not clear to me why you think eaVert, and mongolianVert should be
excluded here.
Maybe you can explain further.

It seems to me that:
- horz, vert, vert270 are effectively horizontal (LR_TB or RL_TB) with
different rotation angles.
CJK text ( along its upright axis ) is perpendicular to the run direction.

- eaVert, wordArtVertRtl : TB_RL. CJK text is parallel to the run direction.

- mongolianVert, wordArtVert: TB_LR. CJK text is parallel to the run
direction.

Both wordArtVertRtl and wordArtVert don't apply rotation to Latin scripts -
which I think is something missing in LibreOffice.
We don't have the attribute to keep the state. We always render Latin
script text in vertical writing as same as in horizontal writing, only
rotate the whole run.


> The CustomShapeGeometry property, which is a sequence, would get a new
> property "TextDirection". Import from OOXML or from ODF-extended would
> put the value into it without any rotate-angle calculations. Evaluation
> of the attribute would be at rendering time in
>
> ViewContactOfSdrObjCustomShape::createViewIndependentPrimitive2DSequence().

The current used attribute TextPreRotateAngle would be removed.
> Currently it can be used in the CustomShapeGeometry sequence via macro,
> but is not published in the API and has no UI.
>
> Currently we have a confusion of attribute 'vert' and attribute 'rot'
> resulting in bug 124437 (assigning the angle of the 'rot' attribute to
> TextPreRotateAngle, which produces sheared text) and bug 127457 (value
> of attribute 'vert' overwrites value of 'rot'). Therefore I prefer an
> enum (or constants in API or string?) so that such errors cannot happen.
>
> What do you think?
>
> Kind regards,
> Regina
>


-- 
Mark Hung

[Libreoffice-commits] core.git: sc/inc sc/source

2022-06-17 Thread Noel Grandin (via logerrit)

 sc/inc/cellvalue.hxx   |   13 +++
 sc/inc/dociter.hxx |2 
 sc/source/core/data/attarray.cxx   |8 +-
 sc/source/core/data/cellvalue.cxx  |   56 -
 sc/source/core/data/column2.cxx|2 
 sc/source/core/data/column4.cxx|2 
 sc/source/core/data/conditio.cxx   |4 -
 sc/source/core/data/dociter.cxx|2 
 sc/source/core/data/documen8.cxx   |4 -
 sc/source/core/data/documentimport.cxx |3 
 sc/source/core/data/table3.cxx |2 
 sc/source/core/data/table4.cxx |4 -
 sc/source/core/data/table6.cxx |4 -
 sc/source/core/data/validat.cxx|4 -
 sc/source/core/tool/cellform.cxx   |2 
 sc/source/core/tool/chgtrack.cxx   |8 +-
 sc/source/filter/excel/xetable.cxx |2 
 sc/source/filter/excel/xicontent.cxx   |2 
 sc/source/filter/html/htmlexp.cxx  |2 
 sc/source/filter/rtf/rtfexp.cxx|2 
 sc/source/filter/xcl97/XclExpChangeTrack.cxx   |6 -
 sc/source/filter/xml/XMLChangeTrackingExportHelper.cxx |   10 +--
 sc/source/filter/xml/xmlcelli.cxx  |2 
 sc/source/filter/xml/xmlexprt.cxx  |4 -
 sc/source/ui/app/transobj.cxx  |2 
 sc/source/ui/docshell/docsh.cxx|2 
 sc/source/ui/docshell/docsh8.cxx   |4 -
 sc/source/ui/undo/undocell.cxx |2 
 sc/source/ui/unoobj/cellsuno.cxx   |2 
 sc/source/ui/unoobj/textuno.cxx|2 
 sc/source/ui/view/gridwin.cxx  |4 -
 sc/source/ui/view/output2.cxx  |8 +-
 sc/source/ui/view/spellcheckcontext.cxx|2 
 sc/source/ui/view/spelleng.cxx |2 
 sc/source/ui/view/tabvwsha.cxx |2 
 sc/source/ui/view/viewfun4.cxx |2 
 sc/source/ui/view/viewfunc.cxx |2 
 37 files changed, 97 insertions(+), 89 deletions(-)

New commits:
commit c78193b32152122e9b71151b1b463b2dff99f42f
Author: Noel Grandin 
AuthorDate: Fri Jun 17 16:00:06 2022 +0200
Commit: Noel Grandin 
CommitDate: Fri Jun 17 17:00:11 2022 +0200

create getter for ScCellValue::mpEditText

so we can assert that it has the correct tag type

Change-Id: I984c22ae2527d652f2d4194227dc1173793300c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136054
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/cellvalue.hxx b/sc/inc/cellvalue.hxx
index 643889e2c154..192e499bbb25 100644
--- a/sc/inc/cellvalue.hxx
+++ b/sc/inc/cellvalue.hxx
@@ -40,7 +40,7 @@ public:
 union {
 double mfValue1;
 svl::SharedString* mpString;
-EditTextObject* mpEditText;
+EditTextObject* mpEditText1;
 ScFormulaCell* mpFormula;
 };
 
@@ -64,6 +64,14 @@ public:
 CellType getType() const { return meType; }
 double getDouble() const { assert(meType == CELLTYPE_VALUE); return 
mfValue1; }
 svl::SharedString* getSharedString() const { assert(meType == 
CELLTYPE_STRING); return mpString; }
+EditTextObject* getEditText() const { assert(meType == CELLTYPE_EDIT); 
return mpEditText1; }
+EditTextObject* releaseEditText()
+{
+assert(meType == CELLTYPE_EDIT);
+auto p = mpEditText1;
+mpEditText1 = nullptr;
+return p;
+}
 
 /**
  * Take cell value from specified position in specified document.
@@ -115,7 +123,7 @@ public:
 union {
 double mfValue1;
 const svl::SharedString* mpString;
-const EditTextObject* mpEditText;
+const EditTextObject* mpEditText1;
 ScFormulaCell* mpFormula;
 };
 
@@ -136,6 +144,7 @@ public:
 CellType getType() const { return meType; }
 double getDouble() const { assert(meType == CELLTYPE_VALUE); return 
mfValue1; }
 const svl::SharedString* getSharedString() const { assert(meType == 
CELLTYPE_STRING); return mpString; }
+const EditTextObject* getEditText() const { assert(meType == 
CELLTYPE_EDIT); return mpEditText1; }
 
 /**
  * Take cell value from specified position in specified document.
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index 622d36332d97..fc1609d6daab 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -234,7 +234,7 @@ public:
 
 CellType getType() const { return maCurCell.getType();}
 OUString getString() const;
-const EditTextObject* getEditText() const { return maCurCell.mpEditText;}
+

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 325 commits - accessibility/inc accessibility/Library_acc.mk accessibility/source android/source basic/source binaryurp/source bin/cra

2022-06-17 Thread Tomaž Vajngerl (via logerrit)

Rebased ref, commits from common ancestor:
commit d469ffb22f9fe23b541730c15ba384392ebe21ce
Author: Tomaž Vajngerl 
AuthorDate: Fri Jun 17 16:38:54 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jun 17 16:55:44 2022 +0200

chart2: remove unneeded class prefix in ObjectHierarchy.cxx

Change-Id: Iee007f7ff4d9665ee089712e7ba98090a8090609

diff --git a/chart2/source/controller/main/ObjectHierarchy.cxx 
b/chart2/source/controller/main/ObjectHierarchy.cxx
index ab1fa891377e..c696a94d8fcd 100644
--- a/chart2/source/controller/main/ObjectHierarchy.cxx
+++ b/chart2/source/controller/main/ObjectHierarchy.cxx
@@ -115,7 +115,7 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 ObjectIdentifier aDiaOID;
 if( xDiagram.is() )
 aDiaOID = ObjectIdentifier( 
ObjectIdentifier::createClassifiedIdentifierForObject( 
static_cast(xDiagram.get()), xChartDocument ) );
-ObjectHierarchy::tChildContainer aTopLevelContainer;
+tChildContainer aTopLevelContainer;
 
 // First Level
 
@@ -158,7 +158,7 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 createDiagramTree( aTopLevelContainer, xChartDocument, xDiagram );
 else
 {
-ObjectHierarchy::tChildContainer aSubContainer;
+tChildContainer aSubContainer;
 createDiagramTree( aSubContainer, xChartDocument, xDiagram );
 if( !aSubContainer.empty() )
 m_aChildMap[ aDiaOID ] = aSubContainer;
@@ -179,11 +179,11 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 aTopLevelContainer.emplace_back( 
ObjectIdentifier::createClassifiedIdentifier( OBJECTTYPE_PAGE, u"" ) );
 
 if( ! aTopLevelContainer.empty())
-m_aChildMap[ ObjectHierarchy::getRootNodeOID() ] = aTopLevelContainer;
+m_aChildMap[ObjectHierarchy::getRootNodeOID()] = aTopLevelContainer;
 }
 
 void ObjectHierarchy::createLegendTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram  )
 {
@@ -199,7 +199,7 @@ void ObjectHierarchy::createLegendTree(
 rtl::Reference< SvxShapeGroupAnyD > xLegendShapeContainer =
 dynamic_cast(
 m_pExplicitValueProvider->getShapeForCID( 
aLegendOID.getObjectCID() ).get() );
-ObjectHierarchy::tChildContainer aLegendEntryOIDs;
+tChildContainer aLegendEntryOIDs;
 lcl_getChildOIDs( aLegendEntryOIDs, xLegendShapeContainer );
 
 m_aChildMap[ aLegendOID ] = aLegendEntryOIDs;
@@ -207,7 +207,7 @@ void ObjectHierarchy::createLegendTree(
 }
 
 void ObjectHierarchy::createAxesTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram  )
 {
@@ -271,7 +271,7 @@ void ObjectHierarchy::createAxesTree(
 }
 
 void ObjectHierarchy::createWallAndFloor(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference< Diagram > & xDiagram )
 {
 sal_Int32 nDimensionCount = DiagramHelper::getDimension( xDiagram );
@@ -289,7 +289,7 @@ void ObjectHierarchy::createWallAndFloor(
 }
 
 void ObjectHierarchy::createDiagramTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram )
 {
@@ -307,7 +307,7 @@ void ObjectHierarchy::createDiagramTree(
 }
 
 void ObjectHierarchy::createDataSeriesTree(
-ObjectHierarchy::tChildContainer & rOutDiagramSubContainer,
+tChildContainer & rOutDiagramSubContainer,
 const rtl::Reference< Diagram > & xDiagram )
 {
 try
@@ -334,7 +334,7 @@ void ObjectHierarchy::createDataSeriesTree(
 ObjectIdentifier( 
ObjectIdentifier::createClassifiedIdentifierForParticle( aSeriesParticle ) ) );
 rOutDiagramSubContainer.push_back( aSeriesOID );
 
-ObjectHierarchy::tChildContainer aSeriesSubContainer;
+tChildContainer aSeriesSubContainer;
 
 rtl::Reference< DataSeries > const & xSeries = 
aSeriesSeq[nSeriesIdx];
 
@@ -406,7 +406,7 @@ void ObjectHierarchy::createDataSeriesTree(
 }
 }
 
-void ObjectHierarchy::createAdditionalShapesTree( 
ObjectHierarchy::tChildContainer& rContainer )
+void ObjectHierarchy::createAdditionalShapesTree(tChildContainer& rContainer)
 {
 try
 {
@@ -453,7 +453,7 @@ const ObjectHierarchy::tChildContainer & 
ObjectHierarchy::getChildren( const Obj
 if( aIt != m_aChildMap.end())
 return aIt->second;
 }
-static const ObjectHierarchy::tChildContainer EMPTY;
+static const tChildContainer EMPTY;
 return EMPTY;
 }
 
@@ -463,13 +463,13 @@

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 3 commits - chart2/source

2022-06-17 Thread Tomaž Vajngerl (via logerrit)

 chart2/source/controller/inc/ObjectHierarchy.hxx  |   24 +++
 chart2/source/controller/main/ObjectHierarchy.cxx |   34 +++---
 2 files changed, 28 insertions(+), 30 deletions(-)

New commits:
commit fd5eb88a0f054d962d56886cd733ff0fcb077884
Author: Tomaž Vajngerl 
AuthorDate: Fri Jun 17 16:38:54 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Fri Jun 17 16:38:54 2022 +0200

chart2: remove unneeded class prefix in ObjectHierarchy.cxx

Change-Id: Iee007f7ff4d9665ee089712e7ba98090a8090609

diff --git a/chart2/source/controller/main/ObjectHierarchy.cxx 
b/chart2/source/controller/main/ObjectHierarchy.cxx
index 81324e432e7d..197d9b854925 100644
--- a/chart2/source/controller/main/ObjectHierarchy.cxx
+++ b/chart2/source/controller/main/ObjectHierarchy.cxx
@@ -114,7 +114,7 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 ObjectIdentifier aDiaOID;
 if( xDiagram.is() )
 aDiaOID = ObjectIdentifier( 
ObjectIdentifier::createClassifiedIdentifierForObject( 
static_cast(xDiagram.get()), xChartDocument ) );
-ObjectHierarchy::tChildContainer aTopLevelContainer;
+tChildContainer aTopLevelContainer;
 
 // First Level
 
@@ -157,7 +157,7 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 createDiagramTree( aTopLevelContainer, xChartDocument, xDiagram );
 else
 {
-ObjectHierarchy::tChildContainer aSubContainer;
+tChildContainer aSubContainer;
 createDiagramTree( aSubContainer, xChartDocument, xDiagram );
 if( !aSubContainer.empty() )
 m_aChildMap[ aDiaOID ] = aSubContainer;
@@ -178,11 +178,11 @@ void ObjectHierarchy::createTree( const 
rtl::Reference<::chart::ChartModel>& xCh
 aTopLevelContainer.emplace_back( 
ObjectIdentifier::createClassifiedIdentifier( OBJECTTYPE_PAGE, u"" ) );
 
 if( ! aTopLevelContainer.empty())
-m_aChildMap[ ObjectHierarchy::getRootNodeOID() ] = aTopLevelContainer;
+m_aChildMap[ObjectHierarchy::getRootNodeOID()] = aTopLevelContainer;
 }
 
 void ObjectHierarchy::createLegendTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram  )
 {
@@ -198,7 +198,7 @@ void ObjectHierarchy::createLegendTree(
 rtl::Reference< SvxShapeGroupAnyD > xLegendShapeContainer =
 dynamic_cast(
 m_pExplicitValueProvider->getShapeForCID( 
aLegendOID.getObjectCID() ).get() );
-ObjectHierarchy::tChildContainer aLegendEntryOIDs;
+tChildContainer aLegendEntryOIDs;
 lcl_getChildOIDs( aLegendEntryOIDs, xLegendShapeContainer );
 
 m_aChildMap[ aLegendOID ] = aLegendEntryOIDs;
@@ -206,7 +206,7 @@ void ObjectHierarchy::createLegendTree(
 }
 
 void ObjectHierarchy::createAxesTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram  )
 {
@@ -270,7 +270,7 @@ void ObjectHierarchy::createAxesTree(
 }
 
 void ObjectHierarchy::createWallAndFloor(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference< Diagram > & xDiagram )
 {
 sal_Int32 nDimensionCount = DiagramHelper::getDimension( xDiagram );
@@ -288,7 +288,7 @@ void ObjectHierarchy::createWallAndFloor(
 }
 
 void ObjectHierarchy::createDiagramTree(
-ObjectHierarchy::tChildContainer & rContainer,
+tChildContainer & rContainer,
 const rtl::Reference<::chart::ChartModel> & xChartDoc,
 const rtl::Reference< Diagram > & xDiagram )
 {
@@ -306,7 +306,7 @@ void ObjectHierarchy::createDiagramTree(
 }
 
 void ObjectHierarchy::createDataSeriesTree(
-ObjectHierarchy::tChildContainer & rOutDiagramSubContainer,
+tChildContainer & rOutDiagramSubContainer,
 const rtl::Reference< Diagram > & xDiagram )
 {
 try
@@ -333,7 +333,7 @@ void ObjectHierarchy::createDataSeriesTree(
 ObjectIdentifier( 
ObjectIdentifier::createClassifiedIdentifierForParticle( aSeriesParticle ) ) );
 rOutDiagramSubContainer.push_back( aSeriesOID );
 
-ObjectHierarchy::tChildContainer aSeriesSubContainer;
+tChildContainer aSeriesSubContainer;
 
 rtl::Reference< DataSeries > const & xSeries = 
aSeriesSeq[nSeriesIdx];
 
@@ -405,7 +405,7 @@ void ObjectHierarchy::createDataSeriesTree(
 }
 }
 
-void ObjectHierarchy::createAdditionalShapesTree( 
ObjectHierarchy::tChildContainer& rContainer )
+void ObjectHierarchy::createAdditionalShapesTree(tChildContainer& rContainer)
 {
 try
 {
@@ -452,7 +452,7 @@ const ObjectHierarchy::tChildContainer & 
ObjectHierarchy::getChildren( const Obj
 if( aIt != m_aChildMap.end())

[Libreoffice-bugs] [Bug 149432] system font in Hebrew is not a standard font

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=149432

--- Comment #10 from Shlomo belleli  ---
Created attachment 180812
  --> https://bugs.documentfoundation.org/attachment.cgi?id=180812=edit
CTL_TEXT data

my version
Version: 7.3.3.2 (x64) / LibreOffice Community
Build ID: d1d0ea68f081ee2800a922cac8f79445e4603348
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: he-IL (he_IL); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142293] EDATE function problem in a file saved as Excel format

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=142293

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |er...@redhat.com
   |desktop.org |

--- Comment #5 from Eike Rathke  ---
The odd thing is, I could identify how the upper-casing of the programmatic
Add-In functions' names goes wrong, but I could not reproduce that such
programmatic name gets saved to the document instead of the English function
name, not even when using a tr-TR locale.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140005] Draw import of PDF squishes text together

2022-06-17 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=140005

--- Comment #13 from Randy  ---
Tested with latest version and the pdf opened correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

1 2 3 >

1 - 100 of 200 matches

Mail list logo