[Libreoffice-bugs] [Bug 150374] right click don't work, often menu entry are unreadable

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150374

--- Comment #2 from Michael Buchholz  ---
1. Right click:
Sorry to say, but right-clicking does not work in test mode either, regardless
of the LO application

2. Menu "black out"
Hasn't reappeared yet. As soon as the error is back, I will provide data

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - include/vcl vcl/inc vcl/source

2022-08-11 Thread Mike Kaganski (via logerrit)
 include/vcl/toolkit/treelistbox.hxx |6 +++-
 vcl/inc/salvtables.hxx  |4 +--
 vcl/source/app/salvtables.cxx   |   46 
 vcl/source/treelist/iconview.cxx|4 +++
 vcl/source/treelist/treelistbox.cxx |   18 --
 5 files changed, 37 insertions(+), 41 deletions(-)

New commits:
commit a44cc9c1e4020b841a8f0009449add916c85a194
Author: Mike Kaganski 
AuthorDate: Wed Aug 10 13:05:45 2022 +0300
Commit: Mike Kaganski 
CommitDate: Fri Aug 12 07:37:23 2022 +0200

jsdialog: dump tooltips for IconView entries

This required to move the code calling Help::ShowQuickHelp from
weld objects into SvTreeListBox::RequestHelp, and have it only
request the tooltip text from those objects.

Change-Id: I25c97360bbaac4705830a13aa06e0992b68f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138084
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138109
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Szymon Kłos 

diff --git a/include/vcl/toolkit/treelistbox.hxx 
b/include/vcl/toolkit/treelistbox.hxx
index 0fdf8a0e469c..38b81e438a65 100644
--- a/include/vcl/toolkit/treelistbox.hxx
+++ b/include/vcl/toolkit/treelistbox.hxx
@@ -198,7 +198,7 @@ class VCL_DLLPUBLIC SvTreeListBox
 Link  aSelectHdl;
 Link  aDeselectHdl;
 Link aPopupMenuHdl;
-Link aTooltipHdl;
+Link aTooltipHdl;
 Link aCustomRenderHdl;
 Link aCustomMeasureHdl;
 
@@ -395,6 +395,8 @@ public:
 SvViewDataItem*  GetViewDataItem(SvTreeListEntry const *, SvLBoxItem const 
*);
 const SvViewDataItem*  GetViewDataItem(const SvTreeListEntry*, const 
SvLBoxItem*) const;
 
+OUString GetEntryTooltip(SvTreeListEntry* pEntry) const { return 
aTooltipHdl.Call(pEntry); }
+
 bool IsInplaceEditingEnabled() const { return bool(nImpFlags & 
SvTreeListBoxFlags::EDT_ENABLED); }
 bool IsEditingActive() const { return bool(nImpFlags & 
SvTreeListBoxFlags::IN_EDT); }
 void EndEditing( bool bCancel = false );
@@ -409,7 +411,7 @@ public:
 voidSetExpandingHdl(const Link& 
rNewHdl){aExpandingHdl=rNewHdl;}
 voidSetExpandedHdl(const Link& 
rNewHdl){aExpandedHdl=rNewHdl;}
 void SetPopupMenuHdl(const Link& rLink) { 
aPopupMenuHdl = rLink; }
-void SetTooltipHdl(const Link& rLink) { 
aTooltipHdl = rLink; }
+void SetTooltipHdl(const Link& rLink) { 
aTooltipHdl = rLink; }
 void SetCustomRenderHdl(const Link& rLink) { 
aCustomRenderHdl = rLink; }
 void SetCustomMeasureHdl(const Link& rLink) { 
aCustomMeasureHdl = rLink; }
 
diff --git a/vcl/inc/salvtables.hxx b/vcl/inc/salvtables.hxx
index 705564665374..46937c161f24 100644
--- a/vcl/inc/salvtables.hxx
+++ b/vcl/inc/salvtables.hxx
@@ -1385,7 +1385,7 @@ protected:
 DECL_LINK(VisibleRangeChangedHdl, SvTreeListBox*, void);
 DECL_LINK(CompareHdl, const SvSortData&, sal_Int32);
 DECL_LINK(PopupMenuHdl, const CommandEvent&, bool);
-DECL_LINK(TooltipHdl, const HelpEvent&, bool);
+DECL_LINK(TooltipHdl, SvTreeListEntry*, OUString);
 DECL_LINK(CustomRenderHdl, svtree_render_args, void);
 DECL_LINK(CustomMeasureHdl, svtree_measure_args, Size);
 
@@ -1749,7 +1749,7 @@ private:
 DECL_LINK(DeSelectHdl, SvTreeListBox*, void);
 DECL_LINK(DoubleClickHdl, SvTreeListBox*, bool);
 DECL_LINK(CommandHdl, const CommandEvent&, bool);
-DECL_LINK(TooltipHdl, const HelpEvent&, bool);
+DECL_LINK(TooltipHdl, SvTreeListEntry*, OUString);
 DECL_LINK(EntryAccessibleDescriptionHdl, SvTreeListEntry*, OUString);
 
 public:
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 46d51c2c2cee..fccf9a0205f2 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -4943,29 +4943,17 @@ SalInstanceTreeView::~SalInstanceTreeView()
 m_xTreeView->SetSelectHdl(Link());
 m_xTreeView->SetDeselectHdl(Link());
 m_xTreeView->SetScrolledHdl(Link());
-m_xTreeView->SetTooltipHdl(Link());
+m_xTreeView->SetTooltipHdl({});
 m_xTreeView->SetCustomRenderHdl(Link());
 m_xTreeView->SetCustomMeasureHdl(Link());
 }
 
-IMPL_LINK(SalInstanceTreeView, TooltipHdl, const HelpEvent&, rHEvt, bool)
+IMPL_LINK(SalInstanceTreeView, TooltipHdl, SvTreeListEntry*, pEntry, OUString)
 {
-if (notify_events_disabled())
-return false;
-Point aPos(m_xTreeView->ScreenToOutputPixel(rHEvt.GetMousePosPixel()));
-SvTreeListEntry* pEntry = m_xTreeView->GetEntry(aPos);
-if (pEntry)
-{
-SalInstanceTreeIter aIter(pEntry);
-OUString aTooltip = signal_query_tooltip(aIter);
-if (aTooltip.isEmpty())
-return false;
-Size aSize(m_xTreeView->GetOutputSizePixel().Width(), 
m_xTreeView->GetEntryHeight());
-tools::Rectangle aScreenRect(
-
m_xTreeView->OutputToScreenPixel(m_xTreeView->GetEntryPosition(pEntry)), aSize);
-

[Libreoffice-bugs] [Bug 135559] Image don't move with paragraph

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135559

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #4 from BogdanB  ---
Seems ok in
Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

The images are moving with the text

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144998] Impress Ubuntu at save us the last modifications disappear from both last versions

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144998

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g

--- Comment #6 from BogdanB  ---
I tested based on comment 2 and NO REPRO on my Ubuntu 22.04

Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144998] Impress Ubuntu at save us the last modifications disappear from both last versions

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144998

--- Comment #5 from QA Administrators  ---
Dear szelev71,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142471] hyperlink misdirection

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=142471

--- Comment #10 from QA Administrators  ---
Dear Ed Sharman,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140011] LibreOffice writer adds dots and dashes to arabic text odt and pdf documents

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=140011

--- Comment #8 from QA Administrators  ---
Dear Joseph,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

ESC meeting minutes: 2022-08-11

2022-08-11 Thread Thorsten Behrens
* Present:
+ Xisco, Hossein, Thorsten, Olivier, Heiko, Ilmari, Caolan,
  Michael W, Michael S, Cloph, Lubos

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
+ 7.4 status
  + RC3 this week, final by next
  + Windows builds running, available this evening
+ 7.3 status: 7.3.6 rc1 in 1 week
+ Appstores
  + all good on Apple side (Cloph)
  + MS store - funny probs with the web form, waiting for MS to
fix it
  + can jump in if necessary (Thorsten)

* Documentation (Olivier)
+ New help
   + LO74 Help online Help updated
   + ~ready for releasing next week
+ HelpContent2
   + Bug triaging - Unconfirmed and unclosed (ohallot)
   + Q: Is there a Help for the toolbars (usig F1 on the tbar)
 + there is a fix in RC3 hopefully? (Thorsten)
   https://gerrit.libreoffice.org/c/core/+/138030 related?
 + seems F1 is processed differently in toolbars
 + did it ever work? needs some more digging (feedback appreciated)
+ Guides
   + Work in progress

+ Bugzilla Documentation statistics
235(235) bugs open
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
   created 19(11)   27(3)  91(1)  330(0)  
 commented 17(6)45(0) 284(10)1474(10) 
  resolved 10(8)13(4)  43(7)  215(9)  
+ top 10 contributors:
  Olivier Hallot made 42 changes in 1 month, and 499 changes in 1 year
  Kaganski, Mike made 23 changes in 1 month, and 109 changes in 1 year
  Rafael Lima made 9 changes in 1 month, and 315 changes in 1 year
  Robert Großkopf made 6 changes in 1 month, and 15 changes in 1 year
  Dieter made 5 changes in 1 month, and 99 changes in 1 year
  Justin Luth made 4 changes in 1 month, and 11 changes in 1 year
  Xisco Fauli made 4 changes in 1 month, and 84 changes in 1 year
  Balland-Poirier, Laurent made 3 changes in 1 month, and 3 changes in 
1 year
  Nabet, Julien made 3 changes in 1 month, and 92 changes in 1 year
  Werner Tietz made 3 changes in 1 month, and 3 changes in 1 year


* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
268(268) (topicUI) bugs open, 54(54) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
 added  5(0)  9(1) 11(-1)  36(-1) 
 commented 66(22)   186(29)   472(-2)2224(-12)
   removed  0(0)  0(0)  1(-1)  29(0)  
  resolved  5(-3)22(-3)69(1)  320(-8) 
+ top 10 contributors:
  Heiko Tietze made 92 changes in 1 month, and 1579 changes in 1 year
  Roman Kuznetsov made 31 changes in 1 month, and 180 changes in 1 year
  Kaganski, Mike made 23 changes in 1 month, and 155 changes in 1 year
  Dieter made 20 changes in 1 month, and 211 changes in 1 year
  Eyal Rozenberg made 20 changes in 1 month, and 96 changes in 1 year
  Rafael Lima made 20 changes in 1 month, and 96 changes in 1 year
  Timur made 17 changes in 1 month, and 65 changes in 1 year
  Bielefeld, Rainer made 13 changes in 1 month, and 19 changes in 1 year
  C.Rogers made 9 changes in 1 month, and 9 changes in 1 year
  Tavo made 9 changes in 1 month, and 9 changes in 1 year
+ [Bug 150260] Last row does not remain hidden when deleting row(s)
+ [Bug 67669] Make narrow non-breaking spaces visible
+ [Bug 146121] UI: Redesign proposal regarding to Page Size and Orientation 
   feature in Print dialog
+ [Bug 146161] Consider renaming button "open" in templates dialog
 -> + [Bug 150276] Paragraph mark in rotated-character paragraph placed in 
   middle of text
   * suggestion: if in doubt, do it like Word does (Caolan)
+ [Bug 150262] Make Autosum button a split button
+ [Bug 150264] FORMATTING: UI improvements to add automatic data 
   validation of dates

* Crash Testing (Caolan)
+ 135(+16) import failure, 94(+14) export failures
+ 18 coverity issues
  - new run underway, 16 expected to go
  - new coverity release coming mid Aug, the one we use will no
longer work we skipped the last update because it was too
noisy, maybe the new one will be better, unlikely, so probably
some churn there
+ 10 ossfuzz issues
  - 2 crashes

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.2.7.2
 + (-10) 502 512 516 479 484 410 396 382 314 268 167 0 
   + https://crashreport.libreoffice.org/stats/version/7.3.4.2
 + (-196) 1498 1695 1672 1581 1128 963 675 0
   + https://crashreport.libreoffice.org/stats/version/7.3.5.2
 + (+316) 866 550 0

+ Crashes fixed in 7.3.5.2

- SwEditWin::MouseButtonDown(MouseEvent const &)

   

[Libreoffice-qa] ESC meeting minutes: 2022-08-11

2022-08-11 Thread Thorsten Behrens
* Present:
+ Xisco, Hossein, Thorsten, Olivier, Heiko, Ilmari, Caolan,
  Michael W, Michael S, Cloph, Lubos

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
+ 7.4 status
  + RC3 this week, final by next
  + Windows builds running, available this evening
+ 7.3 status: 7.3.6 rc1 in 1 week
+ Appstores
  + all good on Apple side (Cloph)
  + MS store - funny probs with the web form, waiting for MS to
fix it
  + can jump in if necessary (Thorsten)

* Documentation (Olivier)
+ New help
   + LO74 Help online Help updated
   + ~ready for releasing next week
+ HelpContent2
   + Bug triaging - Unconfirmed and unclosed (ohallot)
   + Q: Is there a Help for the toolbars (usig F1 on the tbar)
 + there is a fix in RC3 hopefully? (Thorsten)
   https://gerrit.libreoffice.org/c/core/+/138030 related?
 + seems F1 is processed differently in toolbars
 + did it ever work? needs some more digging (feedback appreciated)
+ Guides
   + Work in progress

+ Bugzilla Documentation statistics
235(235) bugs open
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
   created 19(11)   27(3)  91(1)  330(0)  
 commented 17(6)45(0) 284(10)1474(10) 
  resolved 10(8)13(4)  43(7)  215(9)  
+ top 10 contributors:
  Olivier Hallot made 42 changes in 1 month, and 499 changes in 1 year
  Kaganski, Mike made 23 changes in 1 month, and 109 changes in 1 year
  Rafael Lima made 9 changes in 1 month, and 315 changes in 1 year
  Robert Großkopf made 6 changes in 1 month, and 15 changes in 1 year
  Dieter made 5 changes in 1 month, and 99 changes in 1 year
  Justin Luth made 4 changes in 1 month, and 11 changes in 1 year
  Xisco Fauli made 4 changes in 1 month, and 84 changes in 1 year
  Balland-Poirier, Laurent made 3 changes in 1 month, and 3 changes in 
1 year
  Nabet, Julien made 3 changes in 1 month, and 92 changes in 1 year
  Werner Tietz made 3 changes in 1 month, and 3 changes in 1 year


* UX Update (Heiko)
+ Bugzilla (topicUI) statistics
268(268) (topicUI) bugs open, 54(54) (needsUXEval) needs to be 
evaluated by the UXteam
+ Updates:
BZ changes   1 week   1 month   3 months   12 months  
 added  5(0)  9(1) 11(-1)  36(-1) 
 commented 66(22)   186(29)   472(-2)2224(-12)
   removed  0(0)  0(0)  1(-1)  29(0)  
  resolved  5(-3)22(-3)69(1)  320(-8) 
+ top 10 contributors:
  Heiko Tietze made 92 changes in 1 month, and 1579 changes in 1 year
  Roman Kuznetsov made 31 changes in 1 month, and 180 changes in 1 year
  Kaganski, Mike made 23 changes in 1 month, and 155 changes in 1 year
  Dieter made 20 changes in 1 month, and 211 changes in 1 year
  Eyal Rozenberg made 20 changes in 1 month, and 96 changes in 1 year
  Rafael Lima made 20 changes in 1 month, and 96 changes in 1 year
  Timur made 17 changes in 1 month, and 65 changes in 1 year
  Bielefeld, Rainer made 13 changes in 1 month, and 19 changes in 1 year
  C.Rogers made 9 changes in 1 month, and 9 changes in 1 year
  Tavo made 9 changes in 1 month, and 9 changes in 1 year
+ [Bug 150260] Last row does not remain hidden when deleting row(s)
+ [Bug 67669] Make narrow non-breaking spaces visible
+ [Bug 146121] UI: Redesign proposal regarding to Page Size and Orientation 
   feature in Print dialog
+ [Bug 146161] Consider renaming button "open" in templates dialog
 -> + [Bug 150276] Paragraph mark in rotated-character paragraph placed in 
   middle of text
   * suggestion: if in doubt, do it like Word does (Caolan)
+ [Bug 150262] Make Autosum button a split button
+ [Bug 150264] FORMATTING: UI improvements to add automatic data 
   validation of dates

* Crash Testing (Caolan)
+ 135(+16) import failure, 94(+14) export failures
+ 18 coverity issues
  - new run underway, 16 expected to go
  - new coverity release coming mid Aug, the one we use will no
longer work we skipped the last update because it was too
noisy, maybe the new one will be better, unlikely, so probably
some churn there
+ 10 ossfuzz issues
  - 2 crashes

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.2.7.2
 + (-10) 502 512 516 479 484 410 396 382 314 268 167 0 
   + https://crashreport.libreoffice.org/stats/version/7.3.4.2
 + (-196) 1498 1695 1672 1581 1128 963 675 0
   + https://crashreport.libreoffice.org/stats/version/7.3.5.2
 + (+316) 866 550 0

+ Crashes fixed in 7.3.5.2

- SwEditWin::MouseButtonDown(MouseEvent const &)

   

[Libreoffice-bugs] [Bug 150376] New: ReportsInsights Consulting Pvt Ltd is the leading research industry that offers contextual and data-centric research services to its customers across the globe. Th

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150376

Bug ID: 150376
   Summary: ReportsInsights Consulting Pvt Ltd is the leading
research industry that offers contextual and
data-centric research services to its customers across
the globe. The firm assists its clients to strategize
business policies and accomplish sustainable growth
   Product: Impress Remote
   Version: 1.0.0
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: General
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kartikpande...@gmail.com

Description:
Topnotch research organizations and institutions to comprehend the regional and
global commercial status use the data produced by ReportsInsights Consulting
Pvt Ltd. Our reports comprises in depth analytical and statistical analysis on
various industries in foremost countries around the globe. We deliver around
3+ unique and fresh reports by serving more than 100+ clients in diverse
business fields.

Actual Results:
https://www.reportsinsights.com/
https://www.reportsinsights.com/;>https://www.reportsinsights.com/

Expected Results:
https://www.reportsinsights.com/
https://www.reportsinsights.com/;>https://www.reportsinsights.com/


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
https://www.reportsinsights.com/
https://www.reportsinsights.com/;>https://www.reportsinsights.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

V Stuart Foote  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

V Stuart Foote  changed:

   What|Removed |Added

Version|7.3.5.2 release |4.1.0.4 release

--- Comment #18 from V Stuart Foote  ---
OK, so my recollection regards preview was flat out wrong.

Checking every major back to 3.3, in the sm Formula module we do present the
preview of the full doccument.

When opening an OLE linked formula, it will render the document canvas current
view as its preview expanse.

Zoom for a linked formula has changed a bit over the build releases, at 3.3 the
canvas zoom worked on the full canvas when "previewed" in the Formula
editor--but the sm editor's zoom controls (TB, Menu) were already disabled at
that point.

And at 4.2 the sm Formula editor got its zoom bar added (bug 63351) and
https://gerrit.libreoffice.org/c/core/+/4053/

But guess the syncronization between the source LO module and sm Formula zoom
controls got missed then.

It has only ever been that the sm Formula editor handles individual ODF Formula
in their own canvas with full zoom controls from menu, toolbar and slider.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132293] Run pyflakes on python uitest files to find unused imports

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132293

Hossein  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|mr.hashemian2...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #21 from Hossein  ---
Setting the status back to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135392] Paste from a non-LOO source into LOO CALC overwrites cells containing data without giving a warning

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135392

Dale Eltoft  changed:

   What|Removed |Added

Summary|Paste from AOO to CALC  |Paste from a non-LOO source
   |overwriting cells with data |into LOO CALC overwrites
   |fails to give warning   |cells containing data
   ||without giving a warning
Version|6.4.5.2 release |7.3.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135392] Paste from AOO to CALC overwriting cells with data fails to give warning

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135392

--- Comment #7 from Dale Eltoft  ---
I installed the latest version 7.3.5
To recreate the problem I
1) opened a new spreadsheet and
2) populated several cells with random numbers.
3) I selected a cell with a number in it and clicked "Copy"
4) Selected another cell with a number in it and clicked "Paste"
**This resulted in a warning message indicating I was about to paste over
existing content which I believe is the correct result.

After cancelling that paste I
6) opened Windows Notepad
7) I typed in a random number and selected it.
8) clicked "Copy"
9) Shifted focus to the spreadsheet and selected the same cell a in #4 above
10) then clicked "Paste"
**This resulted in the data from Notepad being entered into the cell with no
warning which seems to me to be a problem.

In my past experience the source of the data doesn't matter as long as it is
not from another LibreOffice app.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150374] right click don't work, often menu entry are unreadable

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150374

m.a.riosv  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||miguelangelrv@libreoffice.o
   ||rg
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from m.a.riosv  ---
Please test with in Safe Mode, Menu/Help/Restart in Safe Mode

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

--- Comment #17 from V Stuart Foote  ---
This is getting off-topic, but relationship to bug 99225 is to 'avoid
data-loss'  

Such that if synchronizing the zoom behavior between the documents source
module and the preview pane in sm Formula editor worsens user experience bcz of
lost StarMath or MathML formulas then any benefit of WYSIWYG formula preview in
the sm Formula module would vanish.

Don't know that it would worsen things, but fully presenting WYSIWYG in sm
preview seems risky given the general lack of integration of the entire sm
module--it does its own thing. And the opened ODF document archives are very
dependent on how the formula get added into the document, and how the formulas
are opened for editing. And how the document is written out to archive on
save/close or export.

We don't know why the OLE formulas drop out of the archives, Regina suggests it
is a memory configuration issue (and we know we've had images doing similar
things TCO by Tomaž image life cycle work on tender 201705-01).  Don't know
that similar life-cycle handling for OLE formulas can be addressed but believe
their loss are still an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'feature/chartdatatable' - 2 commits - chart2/source

2022-08-11 Thread Tomaž Vajngerl (via logerrit)
 chart2/source/view/main/DataTableView.cxx |   34 +++---
 1 file changed, 27 insertions(+), 7 deletions(-)

New commits:
commit 3fe3f3a985ae85e3cd3010f875ca4acc62219bb6
Author: Tomaž Vajngerl 
AuthorDate: Thu Aug 11 22:44:56 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Aug 11 22:44:56 2022 +0200

chart2: render line legend symbols better in a data table

Change-Id: I556b4f249688a3836bbeeb3f554cb9ecf1d31f65

diff --git a/chart2/source/view/main/DataTableView.cxx 
b/chart2/source/view/main/DataTableView.cxx
index eafb64c69f60..7202f332b143 100644
--- a/chart2/source/view/main/DataTableView.cxx
+++ b/chart2/source/view/main/DataTableView.cxx
@@ -276,8 +276,10 @@ void DataTableView::createShapes(basegfx::B2DVector const& 
rStart, basegfx::B2DV
 {
 xCellTextRange->setString(rString);
 
-bool bLeft = (bOutline && nColumn == 1) || (bVBorder && nColumn > 
1 && nColumn < nColumnCount);
-bool bRight = (bOutline && nColumn == nColumnCount) || (bVBorder 
&& nColumn > 1 && nColumn < nColumnCount);
+bool bLeft
+= (bOutline && nColumn == 1) || (bVBorder && nColumn > 1 && 
nColumn < nColumnCount);
+bool bRight = (bOutline && nColumn == nColumnCount)
+  || (bVBorder && nColumn > 1 && nColumn < 
nColumnCount);
 setCellProperties(xPropertySet, bLeft, bOutline, bRight, bOutline);
 setCellCharAndParagraphProperties(xPropertySet);
 }
@@ -285,16 +287,22 @@ void DataTableView::createShapes(basegfx::B2DVector 
const& rStart, basegfx::B2DV
 }
 
 // ROW HEADER
-// Prepare keys
+// Prepare keys (symbols)
+sal_Int32 nMaxSymbolWidth = 0;
 if (bKeys)
 {
-awt::Size aMaxSymbolExtent(300, 300);
 for (VSeriesPlotter* pSeriesPlotter : m_pSeriesPlotterList)
 {
 if (pSeriesPlotter)
 {
+sal_Int32 nSymbolWidth = 300;
+if (pSeriesPlotter->getLegendSymbolStyle() == 
LegendSymbolStyle::Line)
+nSymbolWidth = 600;
+
+nMaxSymbolWidth = std::max(nSymbolWidth, nMaxSymbolWidth);
+
 std::vector aNewEntries = 
pSeriesPlotter->createSymbols(
-aMaxSymbolExtent, m_xTarget, m_xComponentContext);
+{ nSymbolWidth, 300 }, m_xTarget, m_xComponentContext);
 aSymbols.insert(aSymbols.end(), aNewEntries.begin(), 
aNewEntries.end());
 }
 }
@@ -309,7 +317,8 @@ void DataTableView::createShapes(basegfx::B2DVector const& 
rStart, basegfx::B2DV
 if (xCellTextRange.is())
 {
 bool bTop = (bOutline && nRow == 1) || (bHBorder && nRow > 1 && 
nRow < nRowCount);
-bool bBottom = (bOutline && nRow == nRowCount) || (bHBorder && 
nRow > 1 && nRow < nRowCount);
+bool bBottom
+= (bOutline && nRow == nRowCount) || (bHBorder && nRow > 1 && 
nRow < nRowCount);
 setCellProperties(xCellPropertySet, bOutline, bTop, bOutline, 
bBottom);
 
 auto xText = xCellTextRange->getText();
@@ -324,7 +333,8 @@ void DataTableView::createShapes(basegfx::B2DVector const& 
rStart, basegfx::B2DV
 
 xCellPropertySet->setPropertyValue("ParaAdjust", 
uno::Any(style::ParagraphAdjust_LEFT));
 if (bKeys)
-xCellPropertySet->setPropertyValue("ParaLeftMargin", 
uno::Any(500));
+xCellPropertySet->setPropertyValue("ParaLeftMargin",
+   uno::Any(nMaxSymbolWidth + 
200));
 }
 nRow++;
 }
@@ -373,6 +383,7 @@ void DataTableView::createShapes(basegfx::B2DVector const& 
rStart, basegfx::B2DV
 pTableObject->DistributeColumns(0, nColumnCount - 1, true, true);
 pTableObject->DistributeRows(0, nRowCount - 1, true, true);
 
+xBroadcaster->lockBroadcasts();
 uno::Reference 
xPropertySet(xTableColumns->getByIndex(0), uno::UNO_QUERY);
 sal_Int32 nWidth = 0;
 xPropertySet->getPropertyValue("Width") >>= nWidth;
@@ -403,6 +414,7 @@ void DataTableView::createShapes(basegfx::B2DVector const& 
rStart, basegfx::B2DV
 nTotalHeight += nHeight;
 }
 }
+xBroadcaster->unlockBroadcasts();
 }
 
 void DataTableView::initializeShapes(const rtl::Reference& 
xTarget)
commit 7c630f846cb6d1e897a6eba1e2f3640236a74956
Author: Tomaž Vajngerl 
AuthorDate: Thu Aug 11 22:40:27 2022 +0200
Commit: Tomaž Vajngerl 
CommitDate: Thu Aug 11 22:40:27 2022 +0200

chart2: fix rendering of table borders of row/column headers

The row/column headers didn't enable/disable the table borders
correctly when outline was enabled and horizontal and vertical
borders properties were disabled.

diff --git a/chart2/source/view/main/DataTableView.cxx 
b/chart2/source/view/main/DataTableView.cxx
index 981eb873669d..eafb64c69f60 100644
--- 

[Libreoffice-bugs] [Bug 150310] Changing the DPI during Export of PNG does not change the resulting file

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150310

stragu  changed:

   What|Removed |Added

 CC||stephane.guil...@member.fsf
   ||.org
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #2 from stragu  ---
Also reproduced in:

Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109323

stragu  changed:

   What|Removed |Added

 Depends on||144167


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=144167
[Bug 144167] exported PNG image has wrong size when page has border
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144167] exported PNG image has wrong size when page has border

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144167

stragu  changed:

   What|Removed |Added

 Blocks||109323


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109323
[Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff,
gif ...)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146713] RTL language overlap problem when mixed with LTR language

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146713

--- Comment #11 from Khaled Hosny  ---
This seems similar to bug 138199, and bug 150286. Removing the two footnotes in
the first paragraph fixes the overlap in this paragraph.

I’m still skeptical that this commit what really broke it, I reverted the
change in GenericSalLayout::GetTextWidth() and it made no difference.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - vcl/unx

2022-08-11 Thread Caolán McNamara (via logerrit)
 vcl/unx/generic/fontmanager/fontconfig.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 45e739dfa34b5ea779f59a6b079323fbf5ffee9d
Author: Caolán McNamara 
AuthorDate: Thu Aug 11 16:05:55 2022 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Thu Aug 11 22:14:13 2022 +0200

don't worry about Linux Libertine O vs Linux Libertine G

Change-Id: I3f7418380e655b6c25e675493d859444e343d646
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138117
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx 
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index f259277304d0..1daf54b69fa6 100644
--- a/vcl/unx/generic/fontmanager/fontconfig.cxx
+++ b/vcl/unx/generic/fontmanager/fontconfig.cxx
@@ -1185,6 +1185,8 @@ void 
PrintFontManager::Substitute(vcl::font::FontSelectPattern , OUStri
 // ImplFontMetricData::ImplInitTextLineSize
 return;
 }
+if (rPattern.maTargetName == "Linux Libertine G" && 
rPattern.maSearchName == "Linux Libertine O")
+return;
 SAL_WARN("vcl.fonts", "PrintFontManager::Substitute: missing font: '" 
<< rPattern.maTargetName <<
   "' try: " << rPattern.maSearchName << " 
instead");
 std::abort();


[Libreoffice-bugs] [Bug 150274] Grey bottom/right border appear exporting a black-area page to PNG

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150274

--- Comment #4 from stragu  ---
Created attachment 181732
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181732=edit
zoom on overlapped border after export by 7.4.0.2

PNG export is overlapped on other picture in GIMP. 1 pixel-wide grey band and 1
pixel-wide transparent border are visible.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

--- Comment #16 from Klaus  ---
(In reply to V Stuart Foote from comment #14)

> I'd take reliability and consistent behavior over convenience of WYSWYG
> handling. If the zooming, paning, scrolling of document canvas in the sm
> Formula editor can't be synchronized--should revert to only exposing the OLE
> frame for the current formula in the sm preview.

>From the previous post I understand that you'd consider removing the workflow,
where the formula being edited is being previewed in the document context, is
that correct?

Please strongly reconsider this stance. When drafting documents, I usually need
to refer to other equations while editing the next equation. I also need to
account for page width limitations and such constraints.

The current zooming issue would be preferable to me over a fix that removes
live editing in the document context.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff, gif ...)

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109323

stragu  changed:

   What|Removed |Added

 Depends on||150274


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150274
[Bug 150274] Grey bottom/right border appear exporting a black-area page to PNG
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150274] Grey bottom/right border appear exporting a black-area page to PNG

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150274

stragu  changed:

   What|Removed |Added

 CC||stephane.guil...@member.fsf
   ||.org
 Blocks||109323
Version|unspecified |7.2.7.2 release

--- Comment #3 from stragu  ---
The transparent border is in 7.4.0.2 but not in 7.2.7.2. Only the grey border
in that one.

Version: 7.2.7.2 / LibreOffice Community
Build ID: 8d71d29d553c0f7dcbfa38fbfda25ee34cce99a2
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109323
[Bug 109323] [META] Graphic export bugs and enhancements (jpg, png, eps, tiff,
gif ...)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 135778] Characters misplaced in rtl text with fonts "B fontName"

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135778

Khaled Hosny  changed:

   What|Removed |Added

   See Also||https://github.com/harfbuzz
   ||/harfbuzz/issues/2647

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150274] Grey bottom/right border appear exporting a black-area page to PNG

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150274

stragu  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #2 from stragu  ---
Confirmed with:

Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Looks like it's a border of one pixel width of grey and one pixel width
(outermost) of full transparency (see attachment).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143673] LibreOffice logo / banner bad display in Start Center in GNOME dark mode (steps in Comment 8)

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143673

--- Comment #11 from stragu  ---
still reproducible with:

Version: 7.4.0.2 / LibreOffice Community
Build ID: 1512ce97d7ed39dce3121f7e15651fd8895f950e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

--- Comment #15 from Mike Kaganski  ---
(In reply to V Stuart Foote from comment #14)

I simply do not understand what bug 99225 has to do with this. Even if it is
connected to zooming the formula (which I didn't understand from *really
cursory* reading that longish issue), that is definitely a **bug**, which can't
be a reason to reject this - at most, that could be **blocker** for this one
(again, if these are connected somehow). But:

1. This one is perfectly valid user expectation and workflow.
2. This is definitely doable.
3. That one is a bug that must be fixed, bit swept under the carpet.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

2022-08-11 Thread Caolán McNamara (via logerrit)
 sw/qa/inc/swmodeltestbase.hxx  |1 +
 sw/qa/unit/swmodeltestbase.cxx |   11 ++-
 2 files changed, 11 insertions(+), 1 deletion(-)

New commits:
commit bfca51d9035000e518e4938ceb145cb92cc17b1f
Author: Caolán McNamara 
AuthorDate: Thu Aug 11 09:06:49 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Aug 11 21:48:15 2022 +0200

turn off font combobox preview if SAL_ABORT_ON_NON_APPLICATION_FONT_USE set

Change-Id: Ib9c74599afb2b85564de85bf64340315ca0ba4f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138108
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sw/qa/inc/swmodeltestbase.hxx b/sw/qa/inc/swmodeltestbase.hxx
index 5b3cde89314f..c102e75422de 100644
--- a/sw/qa/inc/swmodeltestbase.hxx
+++ b/sw/qa/inc/swmodeltestbase.hxx
@@ -105,6 +105,7 @@ protected:
 sal_uInt32 mnStartTime;
 utl::TempFile maTempFile;
 bool mbExported; ///< Does maTempFile already contain something useful?
+bool mbFontNameWYSIWYG;
 
 protected:
 
diff --git a/sw/qa/unit/swmodeltestbase.cxx b/sw/qa/unit/swmodeltestbase.cxx
index cdbdf6c391f5..374e18b6f799 100644
--- a/sw/qa/unit/swmodeltestbase.cxx
+++ b/sw/qa/unit/swmodeltestbase.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -58,6 +59,7 @@ SwModelTestBase::SwModelTestBase(const OUString& 
pTestDocumentPath, const char*
 , mpFilter(pFilter)
 , mnStartTime(0)
 , mbExported(false)
+, 
mbFontNameWYSIWYG(officecfg::Office::Common::Font::View::ShowFontBoxWYSIWYG::get())
 {
 maTempFile.EnableKillingFile();
 }
@@ -68,13 +70,20 @@ void SwModelTestBase::setUp()
 mxDesktop.set(
 
css::frame::Desktop::create(comphelper::getComponentContext(getMultiServiceFactory(;
 SfxApplication::GetOrCreate();
+std::shared_ptr xChanges(
+comphelper::ConfigurationChanges::create());
+officecfg::Office::Common::Font::View::ShowFontBoxWYSIWYG::set(false, 
xChanges);
+xChanges->commit();
 }
 
 void SwModelTestBase::tearDown()
 {
 if (mxComponent.is())
 mxComponent->dispose();
-
+std::shared_ptr xChanges(
+comphelper::ConfigurationChanges::create());
+
officecfg::Office::Common::Font::View::ShowFontBoxWYSIWYG::set(mbFontNameWYSIWYG,
 xChanges);
+xChanges->commit();
 test::BootstrapFixture::tearDown();
 }
 


[Libreoffice-bugs] [Bug 150375] Render non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

--- Comment #2 from Eyal Rozenberg  ---
(In reply to V Stuart Foote from comment #1)
> Adding feature to keep the LN print interval enabled, and add a non-printing
> "fill" for screen preview/active editing would be neat but is its utility
> worth the dev effort?

That's a good question. I can't say, at least for the reason of not knowing how
popular the use of line numbering in LO actually is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150375] Render non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

--- Comment #2 from Eyal Rozenberg  ---
(In reply to V Stuart Foote from comment #1)
> Adding feature to keep the LN print interval enabled, and add a non-printing
> "fill" for screen preview/active editing would be neat but is its utility
> worth the dev effort?

That's a good question. I can't say, at least for the reason of not knowing how
popular the use of line numbering in LO actually is.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 144862] Wiggling letter with window size of 1920 pixel width (72dpi) and zoom 140% (RSID?)

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144862

--- Comment #45 from V Stuart Foote  ---
Hey, what happened to the "GlyphPositioning" mode work? Not seeing it in the
Tools -> Options -> LO Writer -> View panel on recent TB Windows builds of
master against 7.5 -- and can't find in source cgit/gerrit/grok where it
resides or got pared out.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150375] Render non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

V Stuart Foote  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu
   Keywords||needsUXEval

--- Comment #1 from V Stuart Foote  ---
Seems feasible, but not really necessary as we already have ability via Tools
-> Line Numbering... dialog to easily enable/disable line numbering for
printing and to set LN interval to something other than 5, e.g. 1 if desired. 

Adding feature to keep the LN print interval enabled, and add a non-printing
"fill" for screen preview/active editing would be neat but is its utility worth
the dev effort?

The current control seems sufficient.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150375] Render non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

V Stuart Foote  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org,
   ||vstuart.fo...@utsa.edu
   Keywords||needsUXEval

--- Comment #1 from V Stuart Foote  ---
Seems feasible, but not really necessary as we already have ability via Tools
-> Line Numbering... dialog to easily enable/disable line numbering for
printing and to set LN interval to something other than 5, e.g. 1 if desired. 

Adding feature to keep the LN print interval enabled, and add a non-printing
"fill" for screen preview/active editing would be neat but is its utility worth
the dev effort?

The current control seems sufficient.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: vcl/unx

2022-08-11 Thread Caolán McNamara (via logerrit)
 vcl/unx/generic/fontmanager/fontconfig.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 5dbe2a1488de444c4af23a6009f9f16bba399052
Author: Caolán McNamara 
AuthorDate: Thu Aug 11 16:05:55 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Aug 11 21:21:45 2022 +0200

don't worry about Linux Libertine O vs Linux Libertine G

Change-Id: I3f7418380e655b6c25e675493d859444e343d646
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138149
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/unx/generic/fontmanager/fontconfig.cxx 
b/vcl/unx/generic/fontmanager/fontconfig.cxx
index 24ff67b4b893..0be8062cbadf 100644
--- a/vcl/unx/generic/fontmanager/fontconfig.cxx
+++ b/vcl/unx/generic/fontmanager/fontconfig.cxx
@@ -1185,6 +1185,8 @@ void 
PrintFontManager::Substitute(vcl::font::FontSelectPattern , OUStri
 // ImplFontMetricData::ImplInitTextLineSize
 return;
 }
+if (rPattern.maTargetName == "Linux Libertine G" && 
rPattern.maSearchName == "Linux Libertine O")
+return;
 SAL_WARN("vcl.fonts", "PrintFontManager::Substitute: missing font: '" 
<< rPattern.maTargetName <<
   "' try: " << rPattern.maSearchName << " 
instead");
 std::abort();


New Defects reported by Coverity Scan for LibreOffice

2022-08-11 Thread scan-admin
Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
16 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1507888:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/filter/GraphicFormatDetector.cxx: 352 in 
vcl::GraphicFormatDetector::GraphicFormatDetector(SvStream &, rtl::OUString, 
bool)()



*** CID 1507888:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/filter/GraphicFormatDetector.cxx: 352 in 
vcl::GraphicFormatDetector::GraphicFormatDetector(SvStream &, rtl::OUString, 
bool)()
346 , mnSecondLong(0)
347 , mnStreamPosition(0)
348 , mnStreamLength(0)
349 , mbExtendedInfo(bExtendedInfo)
350 , maMetadata()
351 {
>>> CID 1507888:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "mbWasCompressed" is not initialized in this 
>>> constructor nor in any functions that it calls.
352 }
353 
354 bool GraphicFormatDetector::detect()
355 {
356 maFirstBytes.clear();
357 maFirstBytes.resize(256, 0);

** CID 1507887:  Code maintainability issues  (UNUSED_VALUE)
/sc/source/ui/view/tabview.cxx: 519 in ScTabView::DoResize(const Point &, const 
Size &, bool)()



*** CID 1507887:  Code maintainability issues  (UNUSED_VALUE)
/sc/source/ui/view/tabview.cxx: 519 in ScTabView::DoResize(const Point &, const 
Size &, bool)()
513 pVSplitter->SetDragRectPixel(
514 tools::Rectangle( nPosX, nPosY, nPosX+nSizeX, nPosY+nSizeY 
), pFrameWin );
515 
516 if (bTabControl && ! bHScroll )
517 {
518 nBarY = aHScrollLeft->GetSizePixel().Height();
>>> CID 1507887:  Code maintainability issues  (UNUSED_VALUE)
>>> Assigning value from "this->aVScrollBottom->GetSizePixel().Width()" to 
>>> "nBarX" here, but that stored value is overwritten before it can be used.
519 nBarX = aVScrollBottom->GetSizePixel().Width();
520 
521 tools::Long nSize1 = nSizeX;
522 
523 tools::Long nTabSize = nSize1;
524 if (nTabSize < 0) nTabSize = 0;



To view the defects in Coverity Scan visit, 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DwsR7_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiALwYzAItGe-2FwqSPRYT3IydrHie0m-2FP0GuaIqKUUrUxmwSgDDtPeAhdkYH7SZg7K811NIWv2LQpYhDOd4d-2F126bsXHR04G6aGbi1-2BemUGUpUPiGYcxesXokItMoFcD7ugWqLD8pKskh3LeazUryY2rhs4d-2BEcT3ArTl0OtTeDpeU-3D



[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

--- Comment #14 from V Stuart Foote  ---
Well yes. But then we have issues like bug 99225 where the sm formula are
rendered to images but then the OLE formulas go missing from the .odt

Non-WYSWYG work flows with linked (or embedded) ODF Formula is more
conservative and less risky to calling the Formula editor inside a Writer
session.

So questions of workflow for assembling a manuscript with formulas, and the
behavior of the sm Formula editor in Writer are valid.

I'd take reliability and consistent behavior over convenience of WYSWYG
handling. If the zooming, paning, scrolling of document canvas in the sm
Formula editor can't be synchronized--should revert to only exposing the OLE
frame for the current formula in the sm preview.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-22.05.5-3'

2022-08-11 Thread Szymon Kłos (via logerrit)
Tag 'cp-22.05.5-3' created by Michael Meeks  at 
2022-08-11 18:57 +

cp-22.05.5-3

Changes since cp-22.05.5-2-7:
---
 0 files changed
---


[Libreoffice-ux-advise] [Bug 105365] Clicking the font color button should apply the select font color instead of a color bucked

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105365

Justin L  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #9 from Justin L  ---


*** This bug has been marked as a duplicate of bug 105293 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 105365] Clicking the font color button should apply the select font color instead of a color bucked

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105365

Justin L  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #9 from Justin L  ---


*** This bug has been marked as a duplicate of bug 105293 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - vcl/inc vcl/jsdialog

2022-08-11 Thread Szymon Kłos (via logerrit)
 vcl/inc/jsdialog/jsdialogbuilder.hxx |   14 +-
 vcl/jsdialog/jsdialogbuilder.cxx |   45 ---
 2 files changed, 49 insertions(+), 10 deletions(-)

New commits:
commit 53a9745c2a1dcc659b954d7d6f0588ffb5d7
Author: Szymon Kłos 
AuthorDate: Thu Aug 11 09:21:30 2022 +0200
Commit: Michael Meeks 
CommitDate: Thu Aug 11 20:56:23 2022 +0200

jsdialog: send MessageDialog on run not when built

- some message boxes doesn't have correct notifier set initially
- then when runAsync is called it is ok so we can remember widget

Signed-off-by: Szymon Kłos 
Change-Id: I8ecf2d20ef4c2ebda3acf3b80bb390717b6caf6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138107
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 

diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx 
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index 304b9c330795..e5f3e6916d76 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -219,6 +219,8 @@ class JSInstanceBuilder final : public SalInstanceBuilder, 
public JSDialogSender
 /// When LOKNotifier is set by jsdialogs code we need to release it
 VclPtr m_aWindowToRelease;
 
+friend class JSMessageDialog; // static message boxes have to be 
registered outside
+
 friend VCL_DLLPUBLIC bool jsdialog::ExecuteAction(const std::string& 
nWindowId,
   const OString& rWidget, 
StringMap& rData);
 friend VCL_DLLPUBLIC void jsdialog::SendFullUpdate(const std::string& 
nWindowId,
@@ -421,8 +423,7 @@ public:
 virtual void grab_focus() override
 {
 BaseInstanceClass::grab_focus();
-std::unique_ptr pMap
-= std::make_unique();
+std::unique_ptr pMap = 
std::make_unique();
 (*pMap)[ACTION_TYPE] = "grab_focus";
 sendAction(std::move(pMap));
 }
@@ -567,6 +568,8 @@ class JSMessageDialog final : public 
JSWidget aOwner,
+  const std::function& rEndDialogFn) override;
+
+bool runAsync(std::shared_ptr const& rxSelf,
+  const std::function& rEndDialogFn) override;
 };
 
 class JSCheckButton final : public JSWidget
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index 11edcb26d94d..5c62face9769 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -1174,18 +1174,14 @@ weld::MessageDialog* 
JSInstanceBuilder::CreateMessageDialog(weld::Widget* pParen
 aJsonWriter.put("jsontype", "dialog");
 std::unique_ptr 
message(aJsonWriter.extractData());
 pNotifier->libreOfficeKitViewCallback(LOK_CALLBACK_JSDIALOG, 
message.get());
+
+std::string sWindowId = 
std::to_string(xMessageDialog->GetLOKWindowId());
+InsertWindowToMap(sWindowId);
 }
 
 xMessageDialog->SetLOKTunnelingState(false);
-std::string sWindowId = std::to_string(xMessageDialog->GetLOKWindowId());
-InsertWindowToMap(sWindowId);
-
-weld::MessageDialog* pRet = new JSMessageDialog(xMessageDialog, nullptr, 
true);
-
-if (pRet)
-RememberWidget(sWindowId, "__DIALOG__", pRet);
 
-return pRet;
+return new JSMessageDialog(xMessageDialog, nullptr, true);
 }
 
 JSDialog::JSDialog(JSDialogSender* pSender, ::Dialog* pDialog, 
SalInstanceBuilder* pBuilder,
@@ -1421,6 +1417,39 @@ JSMessageDialog::~JSMessageDialog()
 JSInstanceBuilder::RemoveWindowWidget(m_sWindowId);
 }
 
+void JSMessageDialog::RememberMessageDialog()
+{
+static OStringLiteral sWidgetName = "__DIALOG__";
+std::string sWindowId = std::to_string(m_xMessageDialog->GetLOKWindowId());
+if (JSInstanceBuilder::FindWeldWidgetsMap(sWindowId, sWidgetName) != 
nullptr)
+return;
+
+JSInstanceBuilder::InsertWindowToMap(sWindowId);
+JSInstanceBuilder::RememberWidget(sWindowId, sWidgetName, this);
+}
+
+bool JSMessageDialog::runAsync(std::shared_ptr aOwner,
+   const std::function& 
rEndDialogFn)
+{
+bool bRet = SalInstanceMessageDialog::runAsync(aOwner, rEndDialogFn);
+
+RememberMessageDialog();
+sendFullUpdate();
+
+return bRet;
+}
+
+bool JSMessageDialog::runAsync(std::shared_ptr const& rxSelf,
+   const std::function& 
rEndDialogFn)
+{
+bool bRet = SalInstanceMessageDialog::runAsync(rxSelf, rEndDialogFn);
+
+RememberMessageDialog();
+sendFullUpdate();
+
+return bRet;
+}
+
 IMPL_LINK_NOARG(JSMessageDialog, OKHdl, weld::Button&, void) { 
response(RET_OK); }
 
 IMPL_LINK_NOARG(JSMessageDialog, CancelHdl, weld::Button&, void) { 
response(RET_CANCEL); }


[Libreoffice-bugs] [Bug 147996] keyboardshortcut font-color doesn't work

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147996

Justin L  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||jl...@mail.com
Version|7.1.6.2 release |unspecified

--- Comment #2 from Justin L  ---
The "color changes back to default" happens after something like a "print
preview". bug 139803

Ambiguous names was the topic of bug 108458.

Perhaps in your workflow it would work to use Edit-Repeat (Shift-Ctrl-Y)?

AFAICS, the difference (at least in the toolbars) between the two seemingly
identical choices is:
uno:Color: with no selection, it applies to the whole word.
uno:FontColor: with no selection, it turns into a watering can.

And as Dieter clarified, the keyboard shortcut for uno:Color pops up the
character properties dialog. (Already true in LO 3.5.) The keyboard shortcut is
going to work similarly to a menu entry (like Format) - and a menu entry
wouldn't make sense to apply a toolbar's color-value.

FontColor was in the main formatting toolbar
(swriter/toolbar/textobjectbar.xml) until LO 5.4.
https://gerrit.libreoffice.org/37203

I tested setting Ctrl-6 to uno:FontColor and Ctrl-7 to uno:Color in
bibisect-linux-43all at the oldest commit I can run - LO 3.5.

I don't see how you could have had your desired results work in earlier
versions. Can you identify a version where it worked, and then also the exact
steps taken? NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/qa

2022-08-11 Thread Caolán McNamara (via logerrit)
 vcl/qa/cppunit/graphicfilter/data/tiff/fail/CVE-2022-1210-1.tiff |binary
 1 file changed

New commits:
commit ff1db14fe71eec4cdf7e6b7cfec4c0db9c6014d2
Author: Caolán McNamara 
AuthorDate: Thu Aug 11 11:11:50 2022 +0100
Commit: Caolán McNamara 
CommitDate: Thu Aug 11 20:40:04 2022 +0200

add CVE-2022-1210 testcase

Change-Id: I9390b128006dd3cec4e0b482885dbbd5492f912f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138138
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/qa/cppunit/graphicfilter/data/tiff/fail/CVE-2022-1210-1.tiff 
b/vcl/qa/cppunit/graphicfilter/data/tiff/fail/CVE-2022-1210-1.tiff
new file mode 100644
index ..78460c790ca9
Binary files /dev/null and 
b/vcl/qa/cppunit/graphicfilter/data/tiff/fail/CVE-2022-1210-1.tiff differ


[Libreoffice-commits] core.git: sc/inc sc/source

2022-08-11 Thread Noel Grandin (via logerrit)
 sc/inc/formularesult.hxx  |   14 --
 sc/source/core/tool/formularesult.cxx |9 +++--
 2 files changed, 3 insertions(+), 20 deletions(-)

New commits:
commit 0dffa005544ca29c8726aa008fadfccc5520e791
Author: Noel Grandin 
AuthorDate: Thu Aug 11 12:14:13 2022 +0200
Commit: Noel Grandin 
CommitDate: Thu Aug 11 20:37:17 2022 +0200

fix tsan data-race

this check is not necessary, we are using a 32/64 bit counter (depending
on platform) for some years now

WARNING: ThreadSanitizer: data race (pid=90197)
  Atomic write of size 4 at 0x7b08002f474c by thread T90:
#0 ScInterpreter::Interpret() interpr4.cxx:? (libsclo.so+0xb99c26)
#1 ScFormulaCell::InterpretTail(ScInterpreterContext&, 
ScFormulaCell::ScInterpretTailParameter) ??:? (libsclo.so+0x95bfeb)
#2 ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned 
long, unsigned long, unsigned int, unsigned int) column2.cxx:? 
(libsclo.so+0x754eea)
#3 ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, 
short, int, int, unsigned int, unsigned int) table1.cxx:? (libsclo.so+0x9e692b)
#4 ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScRange 
const&, unsigned int, unsigned int) documen8.cxx:? (libsclo.so+0x83479f)
#5 
ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, 
bool&, bool&, int, int)::Executor::doWork() formulacell.cxx:? 
(libsclo.so+0x96b5e1)
#6 comphelper::ThreadPool::ThreadWorker::execute() threadpool.cxx:? 
(libcomphelper.so+0x1cb0a1)
#7 non-virtual thunk to salhelper::Thread::run() ??:? 
(libuno_salhelpergcc3.so.3+0x67f7)
#8 threadFunc thread.cxx:? (libuno_salhelpergcc3.so.3+0x6aae)
#9 osl_thread_start_Impl(void*) thread.cxx:? (libuno_sal.so.3+0x86245)

  Previous read of size 4 at 0x7b08002f474c by thread T89:
#0 ScFormulaResult::SetToken(formula::FormulaToken const*) 
formularesult.cxx:? (libsclo.so+0xb0e11f)
#1 ScFormulaResult::Assign(ScFormulaResult const&) formularesult.cxx:? 
(libsclo.so+0xb0e837)
#2 ScFormulaCell::InterpretTail(ScInterpreterContext&, 
ScFormulaCell::ScInterpretTailParameter) ??:? (libsclo.so+0x95caa3)
#3 ScColumn::CalculateInThread(ScInterpreterContext&, int, unsigned 
long, unsigned long, unsigned int, unsigned int) column2.cxx:? 
(libsclo.so+0x754eea)
#4 ScTable::CalculateInColumnInThread(ScInterpreterContext&, short, 
short, int, int, unsigned int, unsigned int) table1.cxx:? (libsclo.so+0x9e692b)
#5 ScDocument::CalculateInColumnInThread(ScInterpreterContext&, ScRange 
const&, unsigned int, unsigned int) documen8.cxx:? (libsclo.so+0x83479f)
#6 
ScFormulaCell::InterpretFormulaGroupThreading(sc::FormulaLogger::GroupScope&, 
bool&, bool&, int, int)::Executor::doWork() formulacell.cxx:? 
(libsclo.so+0x96b5e1)
#7 comphelper::ThreadPool::ThreadWorker::execute() threadpool.cxx:? 
(libcomphelper.so+0x1cb0a1)
#8 non-virtual thunk to salhelper::Thread::run() ??:? 
(libuno_salhelpergcc3.so.3+0x67f7)
#9 threadFunc thread.cxx:? (libuno_salhelpergcc3.so.3+0x6aae)
#10 osl_thread_start_Impl(void*) thread.cxx:? (libuno_sal.so.3+0x86245)

Change-Id: I3e51db3a8a0a18fee1647657369ecebf5de108e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138137
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/formularesult.hxx b/sc/inc/formularesult.hxx
index 52be625b7b82..ff036a78bcb3 100644
--- a/sc/inc/formularesult.hxx
+++ b/sc/inc/formularesult.hxx
@@ -55,20 +55,6 @@ class ScFormulaResult
 static const Multiline MULTILINE_FALSE   = 1;
 static const Multiline MULTILINE_TRUE= 2;
 
-// Clone token if the 16-bit only reference counter is nearing it's
-// capacity during fill or copy, leaving 4k for temporary passing
-// around. (That should be enough for all times (TM) ;-)
-static const sal_uInt16 MAX_TOKENREF_COUNT = 0xf000;
-static void IncrementTokenRef( const formula::FormulaToken* & rp )
-{
-if (rp)
-{
-if (rp->GetRef() >= MAX_TOKENREF_COUNT)
-rp = rp->Clone();
-rp->IncRef();
-}
-}
-
 union
 {
 double  mfValue;// double result direct for performance 
and memory consumption
diff --git a/sc/source/core/tool/formularesult.cxx 
b/sc/source/core/tool/formularesult.cxx
index d4b146dfe3bd..31b13af8fea8 100644
--- a/sc/source/core/tool/formularesult.cxx
+++ b/sc/source/core/tool/formularesult.cxx
@@ -52,12 +52,8 @@ ScFormulaResult::ScFormulaResult( const ScFormulaResult & r 
) :
 const ScMatrixFormulaCellToken* pMatFormula =
 r.GetMatrixFormulaCellToken();
 if (pMatFormula)
-{
 mpToken = new ScMatrixFormulaCellToken( *pMatFormula);
-mpToken->IncRef();
-}
-else
-

[Libreoffice-bugs] [Bug 149022] Different-color Arabic letters typeset as disconnected from each other

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149022

--- Comment #6 from Khaled Hosny  ---
(In reply to Eyal Rozenberg from comment #5)
> (In reply to Khaled Hosny from comment #4)
> > Created attachment 181731 [details]
> > Screenshot showing parial shaping
> > 
> > I think there are multiple other bug reports for this same issue. Basically
> > currently a color change amounts to a font change
> 
> And is this the Right Thing to do, in your opinion?

No, it shouldn’t. But it is a big architectural change and I don’t even know
what it entails. Instead of changing font on any style change, some style
changes (like color, underline, font features, etc.) should be some kind of
attribute applied to the text after shaping.

Very few application handle this right, though. Firefox and recent-ish Chrome
do, and IIRC Microsoft Word also does.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150237] LINE NUMBERING DIALOG: Change interval to 1 by default

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150237

--- Comment #9 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #8)
> the comments are a tie.

Suggested a potential tie-breaker feature in bug 150375.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150375] Render non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Indicate non-printing line  |Render non-printing line
   |numbers with faint gray |numbers with faint gray

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149022] Different-color Arabic letters typeset as disconnected from each other

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149022

--- Comment #5 from Eyal Rozenberg  ---
(In reply to Khaled Hosny from comment #4)
> Created attachment 181731 [details]
> Screenshot showing parial shaping
> 
> I think there are multiple other bug reports for this same issue. Basically
> currently a color change amounts to a font change

And is this the Right Thing to do, in your opinion?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #6 from Khaled Hosny  ---
This seems to be similar to (if not a duplicate of) bug 138199.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

--- Comment #13 from Mike Kaganski  ---
WYSIWYG definitely helps.

When you create an *embedded* formula, you are e.g. limited by the width of
page, or a table cell, or whatever surrounds. It's absolutely unreasonable to
consider editing the embedded formula totally different compared to, say,
editing of fontworks, smart shapes, charts (using another module by the way),
or frames. The technical difference (we have a different module making this
work) is just an implementation detail, and user needs no care about that.
Requiring that for some elements, user needs to abandon the convenience to feel
the surroundings and "focus on formula", unlike other elements, is not
reasonable. If you need to focus on formula, then use Math, not Writer with
Math.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150373] Updating styles (Ctrl+Shift+f11) removes the new created style

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150373

Telesto  changed:

   What|Removed |Added

 Status|NEW |UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150237] LINE NUMBERING DIALOG: Change interval to 1 by default

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150237

Eyal Rozenberg  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0375

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113071] [META] Line numbering/numbers bugs and enhancements

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113071

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||150375


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150375
[Bug 150375] Indicate non-printing line numbers with faint gray
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150375] Indicate non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||113071
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||0237


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113071
[Bug 113071] [META] Line numbering/numbers bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150375] New: Indicate non-printing line numbers with faint gray

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150375

Bug ID: 150375
   Summary: Indicate non-printing line numbers with faint gray
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

When a user enables line numbering, they are somewhat interested in the
relative number of each line on the page/within the document. Often, they don't
want the final printed document to have a number on every line, but when
working on the document, the balance probably tilts more towards in the benefit
of more line numbers being visible (but not intrusively so). This is somewhat
similar to table cell boundaries: Many of them usually don't get printed as
lines, but are useful to help the user while editing the document.

I therefore suggest that when displaying line numbers, at the set frequency we
will see a fully-realized number (typically black-color; current default is
once every 5 lines); but on every line we'll have a faint/semi-transparent
number, which doesn't get printed. The user will have the option to make the
faint per-line numbers disappear, either through the line numbering dialog, or
by toggling non-printing marks, or both. They will be on by default to help
avoid the confusion described in issue 150237.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150374] New: right click don't work, often menu entry are unreadable

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150374

Bug ID: 150374
   Summary: right click don't work, often menu entry are
unreadable
   Product: LibreOffice
   Version: 7.4.0.0 beta1+
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: michael@buchholz.family

Description:
1.
Right-click does not work in all applications.

2.
Menu items are often displayed as black text on a dark background (System
Preferences: Dark Mode) and are unreadable

Steps to Reproduce:
1a. Open any LO- App
1b. Right click anything
2a. Open any LO- App
2b. Chose any menu

Actual Results:
1.: Nothing
2.: Often black letters on dark background

Expected Results:
1.: Open right click options
2.: Stay as it


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: de
Module: ALL
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

Version: 7.4.0.0.beta1 (x64) / LibreOffice Community
Build ID: cec1fe9b57a55c032f9f118c907f34e22a63d040
CPU threads: 16; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150320] Calc: Link converted to text on copy of cell

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150320

--- Comment #7 from BDF  ---
(In reply to Timur from comment #6)
> Comment 0 is a basic feature of spreadsheet and NotABug. 

Can you may enlighten me how inserting values randomly can be considered a
"feature" let alone a "basic" one.
This type of "festure" than I can only describe as _I know better what you need
than you know yourself_ is an Apple level style of development.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 105079] kashida problem in justification of persian and english words in same line

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=105079

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103871] Gaps inside justified Arabic words

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103871

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 88976] Justification problem with Persian (Farsi) script in LO Writer 4.4

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=88976

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 62751] FORMATTING: Justified Alignment in right to left (arabic) languages

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=62751

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 70775] VIEWING: Arabic font rendering has problems from as little as subtle artifacts all the way to unusability, depending on the font

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=70775

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 65414] Arabic: wrong render for Arabic text in impress and calc on text direction LTR

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65414

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 64559] Kashida appears randomly between non-justified Arabic letters/words

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64559

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150285

Khaled Hosny  changed:

   What|Removed |Added

  Alias|Justified-Arabic-Text-Kashi |Kashida-Justification
   |da  |
 Depends on||116344, 35320, 103871,
   ||105079, 65344, 70775,
   ||64559, 88976, 65414, 62751


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=35320
[Bug 35320] EDITING: Justified problem in arabic
https://bugs.documentfoundation.org/show_bug.cgi?id=62751
[Bug 62751] FORMATTING: Justified Alignment in right to left (arabic) languages
https://bugs.documentfoundation.org/show_bug.cgi?id=64559
[Bug 64559] Kashida appears randomly between non-justified Arabic letters/words
https://bugs.documentfoundation.org/show_bug.cgi?id=65344
[Bug 65344] kashida should not be used with ligatures on justified Arabic text
https://bugs.documentfoundation.org/show_bug.cgi?id=65414
[Bug 65414] Arabic: wrong render for Arabic text in impress and calc on text
direction LTR
https://bugs.documentfoundation.org/show_bug.cgi?id=70775
[Bug 70775] VIEWING: Arabic font rendering has problems from as little as
subtle artifacts all the way to unusability, depending on the font
https://bugs.documentfoundation.org/show_bug.cgi?id=88976
[Bug 88976] Justification problem with Persian (Farsi) script in LO Writer 4.4
https://bugs.documentfoundation.org/show_bug.cgi?id=103871
[Bug 103871] Gaps inside justified Arabic words
https://bugs.documentfoundation.org/show_bug.cgi?id=105079
[Bug 105079] kashida problem in justification of persian and english words in
same line
https://bugs.documentfoundation.org/show_bug.cgi?id=116344
[Bug 116344] Writer, CTL/RIGHT-TO-LEFT: Awkward Justification with Syriac Fonts
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150368] Equation editor ignores document zoom, and cannot be zoomed manually

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150368

V Stuart Foote  changed:

   What|Removed |Added

  Component|Writer  |Formula Editor

--- Comment #12 from V Stuart Foote  ---
(In reply to Mike Kaganski from comment #11)
> Created attachment 181730 [details]

@Mike, you never fully create the formula object in that clip so sm zoom works
until it is completed. 

Otherwise seems issue is when you have a formula already in an ODF document
(Writer here), and then OLE open it into the sm module. Everything on the
document canvas is being previewed. But layout changes made in sm to the
formula with focus are not being refreshed in the preview, and will fully
render only when the object is closed.  

The zoom for sm is independent of the source module for the OLE formula, and sm
zoom controls disabled for the OLE edit; correctly?

> Why not synchronize the two separate zooms?

OK but, should the formula editor display the source canvas with high fidelity
to its layout WYSIWYG --or is it better to preview just the OLE formula with
focus?  

Ignore the document canvas, with Zoom disabled and no dynamic change to the
source OLE frame until edit is completed. I think that was our legacy that now
is muddled by preview of the entire document.

Question could be, what is the more desirable canvas "preview" to display in
the sm document frame? 

What is the workflow? 
A.) Concentrate of formula editing, and limit view to its dynamic OLE frame. 

B.) Concentrate on layout in document, and provide document zoom while the OLE
is being edited?

Is formula editing improved by WYSIWYG and allowing the sm to display more than
just the OLE frame for the formula object with focus?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117907] VIEWING, PDF: Justifying Syriac and Arabic text creates clutter in LibreOffice Writer

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117907

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132121] LibreOffice 6.4.2.2 (x64) Writer sucks at kashidas when justifying Arabic text, whereas LibreOffice 4.1.3.2 (x86) Writer does quite good

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=132121

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] [META] Problems with Justified Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150285] [META] Problems with Justified Arabic/Persian text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150285

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||132121, 124109, 117907
Summary|(Justified-Arabic-Text-Kash |[META] Problems with
   |ida) - [META] Problems with |Justified Arabic/Persian
   |Justified Arabic/Persian|text
   |text|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=117907
[Bug 117907] VIEWING, PDF: Justifying Syriac and Arabic text creates clutter in
LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=124109
[Bug 124109] Justified Arabic text has gaps in place of kashida
https://bugs.documentfoundation.org/show_bug.cgi?id=132121
[Bug 132121] LibreOffice 6.4.2.2 (x64) Writer sucks at kashidas when justifying
Arabic text, whereas LibreOffice 4.1.3.2 (x86) Writer does quite good
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150285

Khaled Hosny  changed:

   What|Removed |Added

 Blocks||43808


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left and Complex Text Layout language issues
(RTL/CTL)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43808

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||150285


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150285
[Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified
Arabic/Persian text
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150285

Khaled Hosny  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
  Alias||Justified-Arabic-Text-Kashi
   ||da

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150285] (Justified-Arabic-Text-Kashida) - [META] Problems with Justified Arabic/Persian text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150285

Khaled Hosny  changed:

   What|Removed |Added

 Depends on||139627, 137528, 146199,
   ||145647, 127176, 112849,
   ||108604, 87731, 104921,
   ||106309


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=87731
[Bug 87731] Tag appearing in Arabic characters when change size of fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=104921
[Bug 104921] Make Arabic text justification more robust
https://bugs.documentfoundation.org/show_bug.cgi?id=106309
[Bug 106309] Wrong placement of kashida causes defect in Arabic/Persian text
rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=108604
[Bug 108604] wrong kashida placement when exporting to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=112849
[Bug 112849] Kashida characters appears at particular zoom levels (310%)
https://bugs.documentfoundation.org/show_bug.cgi?id=127176
[Bug 127176] 'Noto Nastaliq Urdu' font does not render correctly when
justified.
https://bugs.documentfoundation.org/show_bug.cgi?id=137528
[Bug 137528] Arabic Letters are sometimes disjoined and the vowel marks are
misplaced in justified paragraph in Text Box
https://bugs.documentfoundation.org/show_bug.cgi?id=139627
[Bug 139627] Justified paragraph rendering defect when inserting Arabic
diacritics
https://bugs.documentfoundation.org/show_bug.cgi?id=145647
[Bug 145647] Arabic tatweel rendered as whitespace with preceding English text
https://bugs.documentfoundation.org/show_bug.cgi?id=146199
[Bug 146199] Farsi character overlapped with underscore/dash in an Impress
presentation
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150286] Wrong justification of Persian/Arabic text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150286

--- Comment #5 from Khaled Hosny  ---
I’m skeptical that the mentioned commit is the source of this. The formatting
seems to be unstable, changing the font fixes the issue, but it shows up again
after closing and opening the file.

It seems to be related to the tab stops and/or the footnote numbers, which is
higher level that the code this commit touches.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149022] Different-color Arabic letters typeset as disconnected from each other

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149022

--- Comment #4 from Khaled Hosny  ---
Created attachment 181731
  --> https://bugs.documentfoundation.org/attachment.cgi?id=181731=edit
Screenshot showing parial shaping

I think there are multiple other bug reports for this same issue. Basically
currently a color change amounts to a font change, so there is no interaction
at the low level across the color change.

We try to handle this a bit more gracefully by passing the full text context to
HarfBuzz even across font change to allow basic shaping (it would help with the
خ here, but still break the لآ ligature), but I don’t know why it isn’t working
for you, it works for me (using a different font).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112706] [META] DOC (binary) bullet and numbering list-related issues

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112706
Bug 112706 depends on bug 148360, which changed state.

Bug 148360 Summary: FILEOPEN: Incorrect indent of first line
https://bugs.documentfoundation.org/show_bug.cgi?id=148360

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148360] FILEOPEN: Incorrect indent of first line

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148360

Justin L  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
   Assignee|libreoffice-b...@lists.free |vasily.melenc...@cib.de
   |desktop.org |
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113753] Easier use of CSV in Wizards->Address Data Source

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113753

Buovjaga  changed:

   What|Removed |Added

 CC|ilmari.lauhakangas@libreoff |
   |ice.org |

--- Comment #13 from Buovjaga  ---
(In reply to Radhey Parekh from comment #12)
> Added the patch for the same on gerrit. Kindly check. Thank you.

Patch link to save time https://gerrit.libreoffice.org/c/core/+/138153

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148360] FILEOPEN: Incorrect indent of first line

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148360

--- Comment #6 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2405a36f3bcd43f80371ccaed47f7523ff0d8757

tdf#148360 doc import: add NO_NUMBERING_SHOW_FOLLOWBY(true)

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: solenv/clang-format sw/CppunitTest_sw_ww8export4.mk sw/Module_sw.mk sw/qa sw/source

2022-08-11 Thread Justin Luth (via logerrit)
 solenv/clang-format/excludelist   |1 
 sw/CppunitTest_sw_ww8export4.mk   |   14 +++
 sw/Module_sw.mk   |1 
 sw/qa/extras/ww8export/data/tdf148360.doc |binary
 sw/qa/extras/ww8export/ww8export4.cxx |   55 ++
 sw/source/filter/ww8/ww8par.cxx   |1 
 6 files changed, 72 insertions(+)

New commits:
commit 2405a36f3bcd43f80371ccaed47f7523ff0d8757
Author: Justin Luth 
AuthorDate: Thu Aug 11 09:29:58 2022 -0400
Commit: Justin Luth 
CommitDate: Thu Aug 11 19:38:29 2022 +0200

tdf#148360 doc import: add NO_NUMBERING_SHOW_FOLLOWBY(true)

Change-Id: I2bc595e13fd13f29b4bf22f71c6c6bb4b4483731
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138148
Tested-by: Jenkins
Reviewed-by: Justin Luth 

diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index 0cd36cb7d1c3..44d5c3392974 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -12259,6 +12259,7 @@ sw/qa/extras/uiwriter/uiwriter.cxx
 sw/qa/extras/ww8export/ww8export.cxx
 sw/qa/extras/ww8export/ww8export2.cxx
 sw/qa/extras/ww8export/ww8export3.cxx
+sw/qa/extras/ww8export/ww8export4.cxx
 sw/qa/extras/ww8import/ww8import.cxx
 sw/qa/inc/bordertest.hxx
 sw/qa/inc/swmodeltestbase.hxx
diff --git a/sw/CppunitTest_sw_ww8export4.mk b/sw/CppunitTest_sw_ww8export4.mk
new file mode 100644
index ..47ac483ba688
--- /dev/null
+++ b/sw/CppunitTest_sw_ww8export4.mk
@@ -0,0 +1,14 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call sw_ww8export_test,4))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index 146b6c7bf138..e93ae26ceb42 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -100,6 +100,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\
 CppunitTest_sw_ww8export \
 CppunitTest_sw_ww8export2 \
 CppunitTest_sw_ww8export3 \
+CppunitTest_sw_ww8export4 \
 CppunitTest_sw_ww8import \
 CppunitTest_sw_rtfimport \
 CppunitTest_sw_odfexport \
diff --git a/sw/qa/extras/ww8export/data/tdf148360.doc 
b/sw/qa/extras/ww8export/data/tdf148360.doc
new file mode 100644
index ..3969a560999f
Binary files /dev/null and b/sw/qa/extras/ww8export/data/tdf148360.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export4.cxx 
b/sw/qa/extras/ww8export/ww8export4.cxx
new file mode 100644
index ..91b9477a996f
--- /dev/null
+++ b/sw/qa/extras/ww8export/ww8export4.cxx
@@ -0,0 +1,55 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+class Test : public SwModelTestBase
+{
+public:
+Test()
+: SwModelTestBase("/sw/qa/extras/ww8export/data/", "MS Word 97")
+{
+}
+
+bool mustTestImportOf(const char* filename) const override
+{
+// If the testcase is stored in some other format, it's pointless to 
test.
+return o3tl::ends_with(filename, ".doc");
+}
+};
+
+CPPUNIT_TEST_FIXTURE(Test, testTdf148360)
+{
+loadAndReload("tdf148360.doc");
+const auto& pLayout = parseLayoutDump();
+
+// Ensure first element is a tab
+assertXPath(pLayout, "/root/page[1]/body/txt[1]/Text[1]", "nType", 
"PortionType::TabLeft");
+// and only then goes content
+assertXPath(pLayout, "/root/page[1]/body/txt[1]/Text[2]", "nType", 
"PortionType::Text");
+}
+
+
+
+CPPUNIT_PLUGIN_IMPLEMENT();
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx
index 548726482993..1da871b4c9d1 100644
--- a/sw/source/filter/ww8/ww8par.cxx
+++ b/sw/source/filter/ww8/ww8par.cxx
@@ -1887,6 +1887,7 @@ void SwWW8ImplReader::ImportDop()
 
m_rDoc.getIDocumentSettingAccess().set(DocumentSettingId::SURROUND_TEXT_WRAP_SMALL,
 true);
 
m_rDoc.getIDocumentSettingAccess().set(DocumentSettingId::PROP_LINE_SPACING_SHRINKS_FIRST_LINE,
 true);
 
m_rDoc.getIDocumentSettingAccess().set(DocumentSettingId::CONTINUOUS_ENDNOTES, 
true);
+
m_rDoc.getIDocumentSettingAccess().set(DocumentSettingId::NO_NUMBERING_SHOW_FOLLOWBY,
 true);
 
 // COMPATIBILITY FLAGS END
 


[Libreoffice-bugs] [Bug 135778] Characters misplaced in rtl text with fonts "B fontName"

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=135778

Khaled Hosny  changed:

   What|Removed |Added

 Resolution|--- |NOTOURBUG
 Status|NEW |RESOLVED

--- Comment #7 from Khaled Hosny  ---
These fonts are essentially broken and depend on undocumented quirks of Windows
OpenType implementation. The issue might be fixed in HarfBuzz, but there is
nothing to fix in LibreOffice itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 71732] [META] Bugs related to text rendering, typography and font features in LO

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71732
Bug 71732 depends on bug 143705, which changed state.

Bug 143705 Summary: Distortion of Armenian letters
https://bugs.documentfoundation.org/show_bug.cgi?id=143705

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143705] Distortion of Armenian letters

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143705

Khaled Hosny  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #6 from Khaled Hosny  ---
These are ligatures in these fonts, and LibreOffice is simply rendering the
text as the font designer intended it. You can either disable the ligatures or
use different fonts that satisfy your requirements.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150373] Updating styles (Ctrl+Shift+f11) removes the new created style

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150373

gris...@zaclys.net  changed:

   What|Removed |Added

 OS|All |Linux (All)
   Hardware|All |x86-64 (AMD64)
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150373] New: Updating styles (Ctrl+Shift+f11) removes the new created style

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150373

Bug ID: 150373
   Summary: Updating styles (Ctrl+Shift+f11) removes the new
created style
   Product: LibreOffice
   Version: 7.4.0.0 beta1+
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gris...@zaclys.net

Description:
Paragraph styles are not updated after a style modification directly in the
text. On the contrary, the initial style is reactivated when the update option
is activated (by clicking in the panel or in the "Style" menu, or with
Ctrl+Shift+f11).

(The modification with the style editing menu works, only the update option has
a problem)

Steps to Reproduce:
1. Apply a style to a paragraph (Heading 1, for example)
2. Change the appearance of the title (Font size, Bold)
3. Activate the style update

Actual Results:
the initial style is reactivated

Expected Results:
The new style should apply to all paragraphs of the same style (to all Headings
1 in the example)


Reproducible: Always


User Profile Reset: No



Additional Info:
I use Libreoffice for Debian.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103322] Use floating point for glyph positioning in VCL

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103322

--- Comment #40 from Khaled Hosny  ---
I agree with Aron’s comment above. I think folks are overemphasizing what kind
of issues this change can fix. To be honest, I don’t expect it to fix any
glaring issues any more, possibly only subtler sub-pixel positioning issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 139627] Justified paragraph rendering defect when inserting Arabic diacritics

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=139627

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137528] Arabic Letters are sometimes disjoined and the vowel marks are misplaced in justified paragraph in Text Box

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137528

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 146199] Farsi character overlapped with underscore/dash in an Impress presentation

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146199

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145647] Arabic tatweel rendered as whitespace with preceding English text

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145647

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 127176] 'Noto Nastaliq Urdu' font does not render correctly when justified.

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=127176

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114257] DRAW: Bad "Convert - To Curve" some arabic letters from the Text Box

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114257

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112849] Kashida characters appears at particular zoom levels (310%)

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=112849

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108604] wrong kashida placement when exporting to PDF

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=108604

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106653] RTL Arabic text has some gaps between characters

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106653

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 106309] Wrong placement of kashida causes defect in Arabic/Persian text rendering

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=106309

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 87731] Tag appearing in Arabic characters when change size of fonts

2022-08-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=87731

Khaled Hosny  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |kha...@aliftype.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   4   >