[Libreoffice-commits] core.git: winaccessibility/source
winaccessibility/source/UAccCOM/AccTextBase.cxx | 35
1 file changed, 6 insertions(+), 29 deletions(-)
New commits:
commit 5f86f491701dc9f6f52129cf87644167e95ab40a
Author: Julien Nabet
AuthorDate: Thu Sep 8 21:02:31 2022 +0200
Commit: Mike Kaganski
CommitDate: Fri Sep 9 06:32:44 2022 +0200
Simplify by using replaceAll in a loop (winaccessibility/AccTextBase)
Change-Id: I68c895033d26c81c76e680d2042aac941d56d213
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139707
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/winaccessibility/source/UAccCOM/AccTextBase.cxx
b/winaccessibility/source/UAccCOM/AccTextBase.cxx
index a1f371a47ec9..40620bb5b64f 100644
--- a/winaccessibility/source/UAccCOM/AccTextBase.cxx
+++ b/winaccessibility/source/UAccCOM/AccTextBase.cxx
@@ -74,8 +74,6 @@ sal_Int16 lcl_matchIA2TextBoundaryType(IA2TextBoundaryType
boundaryType)
// Construction/Destruction
-static OUString ReplaceFourChar(OUString const & oldOUString);
-
CAccTextBase::CAccTextBase()
{}
@@ -182,7 +180,12 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CAccTextBase::get_attributes(long offset, long
if (bHaveNumberingLevel && bHaveNumberingRules &&
bHaveNumberingPrefixAttr)
{
strAttrs.append(';');
-numberingPrefix = ReplaceFourChar(numberingPrefix);
+numberingPrefix = numberingPrefix.replaceAll(u"\\", u"")
+ .replaceAll(u";", u"\\;")
+ .replaceAll(u"=", u"\\=")
+ .replaceAll(u",", u"\\,")
+ .replaceAll(u":", u"\\:");
+
strAttrs.append(CMAccessible::get_String4Numbering(anyNumRule,numberingLevel,numberingPrefix));
bHaveNumberingLevel = false;
bHaveNumberingRules = false;
@@ -882,30 +885,4 @@ COM_DECLSPEC_NOTHROW STDMETHODIMP
CAccTextBase::put_XInterface(hyper pXInterface
} catch(...) { return E_FAIL; }
}
-static OUString ReplaceOneChar(OUString const & oldOUString, sal_Unicode
replacedChar, std::u16string_view replaceStr)
-{
-auto s = oldOUString;
-int iReplace = s.lastIndexOf(replacedChar);
-if (iReplace > -1)
-{
-for(;iReplace>-1;)
-{
-s = s.replaceAt(iReplace,1, replaceStr);
-iReplace=s.lastIndexOf(replacedChar,iReplace);
-}
-}
-return s;
-}
-
-static OUString ReplaceFourChar(OUString const & oldOUString)
-{
-auto s = oldOUString;
-s = ReplaceOneChar(s, '\\', u"");
-s = ReplaceOneChar(s, ';', u"\\;");
-s = ReplaceOneChar(s, '=', u"\\=");
-s = ReplaceOneChar(s, ',', u"\\,");
-s = ReplaceOneChar(s, ':', u"\\:");
-return s;
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
[Libreoffice-bugs] [Bug 147495] Scrolling within Calc sheet is erratic or ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=147495 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150603] Missing File Extension on Export
https://bugs.documentfoundation.org/show_bug.cgi?id=150603 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150598] Calc lost datas every time i save the file
https://bugs.documentfoundation.org/show_bug.cgi?id=150598 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150590] 文件列印顏色錯誤
https://bugs.documentfoundation.org/show_bug.cgi?id=150590 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150532] CALC window appearing "off-screen" seems to be SKIA related
https://bugs.documentfoundation.org/show_bug.cgi?id=150532 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150818] Erroneous indent in 3rd level ordered list
https://bugs.documentfoundation.org/show_bug.cgi?id=150818 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150818] Erroneous indent in 3rd level ordered list
https://bugs.documentfoundation.org/show_bug.cgi?id=150818 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150807] "2 Content" is not correct English
https://bugs.documentfoundation.org/show_bug.cgi?id=150807 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150807] "2 Content" is not correct English
https://bugs.documentfoundation.org/show_bug.cgi?id=150807 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150807] "2 Content" is not correct English
https://bugs.documentfoundation.org/show_bug.cgi?id=150807 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150807] "2 Content" is not correct English
https://bugs.documentfoundation.org/show_bug.cgi?id=150807 --- Comment #8 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 147153] Calc freezes and crash if manually selecting of thousands of lines
https://bugs.documentfoundation.org/show_bug.cgi?id=147153 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147153] Calc freezes and crash if manually selecting of thousands of lines
https://bugs.documentfoundation.org/show_bug.cgi?id=147153 --- Comment #9 from QA Administrators --- Dear Martin Reichel, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146824] si chiude subito
https://bugs.documentfoundation.org/show_bug.cgi?id=146824 --- Comment #3 from QA Administrators --- Dear g1wqr2, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146824] si chiude subito
https://bugs.documentfoundation.org/show_bug.cgi?id=146824 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140693] Print Dialog showing wrong page layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=140693 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140693] Print Dialog showing wrong page layout.
https://bugs.documentfoundation.org/show_bug.cgi?id=140693 --- Comment #7 from QA Administrators --- Dear avdzm, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147256] PDF export Accessibility not working in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=147256 --- Comment #6 from QA Administrators --- Dear kirisutojan, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-4' - 2 commits - brand/cib configure.ac instsetoo_native/inc_ooohelppack instsetoo_native/util sfx2/source svx/source
brand/cib/intro-highres.png |binary brand/cib/intro-highres.svg | 18 +- brand/cib/intro.png |binary brand/cib/intro.svg | 18 +- configure.ac|2 - instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt |6 +-- instsetoo_native/util/openoffice.lst.in |8 ++-- sfx2/source/appl/appserv.cxx|2 - svx/source/dialog/SafeModeDialog.cxx|2 - 9 files changed, 16 insertions(+), 40 deletions(-) New commits: commit b35b16efb643c22839b5958c0d9e2a84998f6fbd Author: Thorsten Behrens AuthorDate: Fri Sep 9 05:02:44 2022 +0200 Commit: Thorsten Behrens CommitDate: Fri Sep 9 05:02:44 2022 +0200 [CIBO] Final artwork rebranding Change-Id: I64d2cd1f2e3faccdddbcdd6c57899dd76c5e9676 diff --git a/brand/cib/intro-highres.png b/brand/cib/intro-highres.png index 6ca5d13994b0..17560c7fe464 100644 Binary files a/brand/cib/intro-highres.png and b/brand/cib/intro-highres.png differ diff --git a/brand/cib/intro-highres.svg b/brand/cib/intro-highres.svg index df139dbe0a69..b3258b6c4c7e 100644 --- a/brand/cib/intro-highres.svg +++ b/brand/cib/intro-highres.svg @@ -12,7 +12,7 @@ sodipodi:docname="intro-highres.svg" width="773" height="394" - inkscape:export-filename="C:\cygwin\home\Marina\lode\dev\FLOSS-194\brand\cib\intro.png" + inkscape:export-filename="intro-highres.png" inkscape:export-xdpi="96" inkscape:export-ydpi="96" xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape; @@ -73,7 +73,7 @@ id="namedview3470" showgrid="false" inkscape:zoom="0.94451843" - inkscape:cx="92.639801" + inkscape:cx="93.698542" inkscape:cy="265.74389" inkscape:window-x="0" inkscape:window-y="0" @@ -290,19 +290,7 @@ -http://www.inkscape.org/namespaces/inkscape; @@ -73,7 +73,7 @@ id="namedview3470" showgrid="false" inkscape:zoom="2.02" - inkscape:cx="181.43564" + inkscape:cx="181.93069" inkscape:cy="108.91089" inkscape:window-x="0" inkscape:window-y="0" @@ -290,19 +290,7 @@ - AuthorDate: Fri Sep 9 04:54:37 2022 +0200 Commit: Thorsten Behrens CommitDate: Fri Sep 9 04:54:37 2022 +0200 Update product URLs Change-Id: Ie12bf07849451445ff99a64c07fc05f01860dda8 diff --git a/configure.ac b/configure.ac index 424142530df5..db01622ac678 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([CIB Office],[6.4.0.10],[],[],[https://www.cib.de/ciboffice/]) +AC_INIT([CIB Office],[6.4.0.10],[],[],[https://www.cib.de/office/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt index dab2e830f194..3b3a2b351b07 100644 --- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt +++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt @@ -8,9 +8,9 @@ ApplicationUsersAllUsers ALLUSERS 1 ARPCOMMENTSARPCOMMENTSTEMPLATE ARPCONTACT CIB software GmbH -ARPHELPLINKhttps://www.cib.de/ciboffice -ARPURLINFOABOUThttps://www.cib.de/ciboffice -ARPURLUPDATEINFO https://www.cib.de/ciboffice +ARPHELPLINKhttps://www.cib.de/office +ARPURLINFOABOUThttps://www.cib.de/office +ARPURLUPDATEINFO https://www.cib.de/office DefaultUIFont Tahoma8 DialogCaption Windows Installer DiskPrompt [1] diff --git a/instsetoo_native/util/openoffice.lst.in b/instsetoo_native/util/openoffice.lst.in index d64b3fd5280e..9672a19a58bc 100644 --- a/instsetoo_native/util/openoffice.lst.in +++ b/instsetoo_native/util/openoffice.lst.in @@ -70,7 +70,7 @@ CIBOffice CHANGETARGETDIR 1 PATCHCODEFILE ooo_patchcodes.txt STARTCENTER_ADDFEATURE_URL http://extensions.libreoffice.org/ -STARTCENTER_INFO_URL https://www.cib.de/ciboffice +STARTCENTER_INFO_URL https://www.cib.de/office STARTCENTER_TEMPLREP_URL http://templates.libreoffice.org/ DICT_REPO_URL http://extensions.libreoffice.org/dictionaries/ STARTCENTER_HIDE_EXTERNAL_LINKS 0 @@ -123,7 +123,7 @@ CIBOfficeDev CODEFILENAME codes_ooodev.txt LOCALUSERDIR $ORIGIN/.. STARTCENTER_ADDFEATURE_URL
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - configure.ac instsetoo_native/inc_ooohelppack instsetoo_native/util sfx2/source
configure.ac|2 +-
instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt |6
+++---
instsetoo_native/util/openoffice.lst.in |8
sfx2/source/appl/appserv.cxx|2 +-
4 files changed, 9 insertions(+), 9 deletions(-)
New commits:
commit 666d288cd412daa6b7b0d3eb782d514601b9d06b
Author: Thorsten Behrens
AuthorDate: Fri Sep 9 04:49:30 2022 +0200
Commit: Thorsten Behrens
CommitDate: Fri Sep 9 04:49:30 2022 +0200
Update product URLs
Change-Id: I32399f425550db2cfeeb314a1055dbb49ca9cf74
diff --git a/configure.ac b/configure.ac
index 7acafadac987..d89c8cdfe728 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@ dnl in order to create a configure script.
# several non-alphanumeric characters, those are split off and used only for
the
# ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no
idea.
-AC_INIT([CIB Office],[6.1.7.36],[],[],[https://www.cib.de/ciboffice/])
+AC_INIT([CIB Office],[6.1.7.36],[],[],[https://www.cib.de/office/])
AC_PREREQ([2.59])
diff --git
a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
index dab2e830f194..3b3a2b351b07 100644
--- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
@@ -8,9 +8,9 @@ ApplicationUsersAllUsers
ALLUSERS 1
ARPCOMMENTSARPCOMMENTSTEMPLATE
ARPCONTACT CIB software GmbH
-ARPHELPLINKhttps://www.cib.de/ciboffice
-ARPURLINFOABOUThttps://www.cib.de/ciboffice
-ARPURLUPDATEINFO https://www.cib.de/ciboffice
+ARPHELPLINKhttps://www.cib.de/office
+ARPURLINFOABOUThttps://www.cib.de/office
+ARPURLUPDATEINFO https://www.cib.de/office
DefaultUIFont Tahoma8
DialogCaption Windows Installer
DiskPrompt [1]
diff --git a/instsetoo_native/util/openoffice.lst.in
b/instsetoo_native/util/openoffice.lst.in
index 2becd6ce9b99..a9849406f38e 100644
--- a/instsetoo_native/util/openoffice.lst.in
+++ b/instsetoo_native/util/openoffice.lst.in
@@ -71,7 +71,7 @@ CIBOffice
CHANGETARGETDIR 1
PATCHCODEFILE ooo_patchcodes.txt
STARTCENTER_ADDFEATURE_URL http://extensions.libreoffice.org/
-STARTCENTER_INFO_URL https://www.cib.de/ciboffice
+STARTCENTER_INFO_URL https://www.cib.de/office
STARTCENTER_TEMPLREP_URL http://templates.libreoffice.org/
DICT_REPO_URL http://extensions.libreoffice.org/dictionaries/
STARTCENTER_HIDE_EXTERNAL_LINKS 0
@@ -124,7 +124,7 @@ CIBOfficeDev
CODEFILENAME codes_ooodev.txt
LOCALUSERDIR $ORIGIN/..
STARTCENTER_ADDFEATURE_URL https://extensions.libreoffice.org/
-STARTCENTER_INFO_URL https://www.cib.de/ciboffice
+STARTCENTER_INFO_URL https://www.cib.de/office
STARTCENTER_TEMPLREP_URL https://templates.libreoffice.org/
DICT_REPO_URL https://extensions.libreoffice.org/dictionaries/
}
@@ -165,7 +165,7 @@ CIBOffice_SDK
CHANGETARGETDIR 1
DONTUSESTARTMENUFOLDER 1
STARTCENTER_ADDFEATURE_URL https://extensions.libreoffice.org/
-STARTCENTER_INFO_URL https://www.cib.de/ciboffice
+STARTCENTER_INFO_URL https://www.cib.de/office
STARTCENTER_TEMPLREP_URL https://templates.libreoffice.org/
DICT_REPO_URL https://extensions.libreoffice.org/dictionaries/
}
@@ -210,7 +210,7 @@ CIBOfficeDev_SDK
CHANGETARGETDIR 1
DONTUSESTARTMENUFOLDER 1
STARTCENTER_ADDFEATURE_URL https://extensions.libreoffice.org/
-STARTCENTER_INFO_URL https://www.cib.de/ciboffice
+STARTCENTER_INFO_URL https://www.cib.de/office
STARTCENTER_TEMPLREP_URL https://templates.libreoffice.org/
DICT_REPO_URL https://extensions.libreoffice.org/dictionaries/
}
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx
index 66026e064921..bca47ee34ce8 100644
--- a/sfx2/source/appl/appserv.cxx
+++ b/sfx2/source/appl/appserv.cxx
@@ -532,7 +532,7 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq )
case SID_SEND_FEEDBACK:
{
-sfx2::openUriExternally("https://www.cib.de/ciboffice;, false);
+sfx2::openUriExternally("https://www.cib.de/office;, false);
break;
}
[Libreoffice-bugs] [Bug 150604] Shortcut - delete key - doesn't delete the selected Index Entry in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=150604 Jim Raykowski changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150751] There should be a way to manually update fixed date / time
https://bugs.documentfoundation.org/show_bug.cgi?id=150751 --- Comment #6 from Justin L --- (In reply to Quazgar from comment #0) > Currently the only workaround is to change the field to non-fixed date, then > back to fixed again. This is really easy to do (at least in 7.5). Agree with WONTFIX. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150751] There should be a way to manually update fixed date / time
https://bugs.documentfoundation.org/show_bug.cgi?id=150751 --- Comment #6 from Justin L --- (In reply to Quazgar from comment #0) > Currently the only workaround is to change the field to non-fixed date, then > back to fixed again. This is really easy to do (at least in 7.5). Agree with WONTFIX. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150604] Shortcut - delete key - doesn't delete the selected Index Entry in navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=150604 --- Comment #14 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/506af0e65e8d0896e3e9f8e2d47aa65799276137 tdf#150604 related: Label Navigator context menu delete entry It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source sw/uiconfig
sw/source/uibase/utlui/content.cxx | 140 ++---
sw/uiconfig/swriter/ui/navigatorcontextmenu.ui | 89 +++
2 files changed, 190 insertions(+), 39 deletions(-)
New commits:
commit 506af0e65e8d0896e3e9f8e2d47aa65799276137
Author: Jim Raykowski
AuthorDate: Wed Sep 7 22:18:13 2022 -0800
Commit: Jim Raykowski
CommitDate: Fri Sep 9 03:08:02 2022 +0200
tdf#150604 related: Label Navigator context menu delete entry
specific to the content entry type
Change-Id: I44ff745d8e61bcf24fee351cfa4148ae3ad31dcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139628
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 4db128600edc..68691799573f 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1564,7 +1564,17 @@ IMPL_LINK(SwContentTree, CommandHdl, const
CommandEvent&, rCEvt, bool)
bool bRemoveCopyEntry = true;
bool bRemoveEditEntry = true;
bool bRemoveUnprotectEntry = true;
-bool bRemoveDeleteEntry = true;
+bool bRemoveDeleteChapterEntry = true,
+ bRemoveDeleteTableEntry = true,
+ bRemoveDeleteFrameEntry = true,
+ bRemoveDeleteImageEntry = true,
+ bRemoveDeleteOLEObjectEntry = true,
+ bRemoveDeleteBookmarkEntry = true,
+ bRemoveDeleteHyperlinkEntry = true,
+ bRemoveDeleteIndexEntry= true,
+ bRemoveDeleteCommentEntry = true,
+ bRemoveDeleteDrawingObjectEntry = true,
+ bRemoveDeleteFieldEntry = true;
bool bRemoveRenameEntry = true;
bool bRemoveSelectEntry = true;
bool bRemoveToggleExpandEntry = true;
@@ -1692,7 +1702,47 @@ IMPL_LINK(SwContentTree, CommandHdl, const
CommandEvent&, rCEvt, bool)
ContentTypeId::REGION == nContentType ||
ContentTypeId::INDEX == nContentType ||
ContentTypeId::DRAWOBJECT == nContentType);
-
+// Choose which Delete entry to show.
+if (bDeletable)
+{
+switch (nContentType)
+{
+case ContentTypeId::OUTLINE:
+bRemoveDeleteChapterEntry = false;
+break;
+case ContentTypeId::TABLE:
+bRemoveDeleteTableEntry = false;
+break;
+case ContentTypeId::FRAME:
+bRemoveDeleteFrameEntry = false;
+break;
+case ContentTypeId::GRAPHIC:
+bRemoveDeleteImageEntry = false;
+break;
+case ContentTypeId::OLE:
+bRemoveDeleteOLEObjectEntry = false;
+break;
+case ContentTypeId::BOOKMARK:
+bRemoveDeleteBookmarkEntry = false;
+break;
+case ContentTypeId::URLFIELD:
+bRemoveDeleteHyperlinkEntry = false;
+break;
+case ContentTypeId::INDEX:
+bRemoveDeleteIndexEntry = false;
+break;
+case ContentTypeId::POSTIT:
+bRemoveDeleteCommentEntry = false;
+break;
+case ContentTypeId::DRAWOBJECT:
+bRemoveDeleteDrawingObjectEntry = false;
+break;
+case ContentTypeId::TEXTFIELD:
+bRemoveDeleteFieldEntry = false;
+break;
+default: break;
+}
+}
if (ContentTypeId::FOOTNOTE == nContentType ||
ContentTypeId::ENDNOTE == nContentType)
{
void* pUserData =
weld::fromId(m_xTreeView->get_id(*xEntry));
@@ -1713,7 +1763,7 @@ IMPL_LINK(SwContentTree, CommandHdl, const CommandEvent&,
rCEvt, bool)
}
bRemoveCopyEntry = false;
}
-else if (!bReadonly && (bEditable || bDeletable))
+else if (!bReadonly && bEditable)
{
if(ContentTypeId::INDEX == nContentType)
{
@@ -1724,7 +1774,6 @@ IMPL_LINK(SwContentTree, CommandHdl, const CommandEvent&,
rCEvt, bool)
bRemoveEditEntry = false;
xPop->set_active(OString::number(405),
SwEditShell::IsTOXBaseReadonly(*pBase));
-bRemoveDeleteEntry = false;
}
else if(ContentTypeId::TABLE == nContentType)
{
@@ -1736,31 +1785,14 @@ IMPL_LINK(SwContentTree, CommandHdl, const
CommandEvent&, rCEvt, bool)
bool bProt = m_pActiveShell->HasTableAnyProtection(
, );
xPop->set_sensitive(OString::number(403), !bFull);
[Libreoffice-bugs] [Bug 141673] FILESAVE: DOCX->DOC: text in tables in footnotes is lost
https://bugs.documentfoundation.org/show_bug.cgi?id=141673 Justin L changed: What|Removed |Added Summary|FILESAVE: DOC: text in |FILESAVE: DOCX->DOC: text |tables in footnotes is lost |in tables in footnotes is ||lost -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104450] [META] DOCX (OOXML) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104450 Justin L changed: What|Removed |Added Depends on||147305 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147305 [Bug 147305] FILEOPEN DOCX: Writer hangs and consumes all available memory when opening specific docx document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=109195 Justin L changed: What|Removed |Added Depends on|147305 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=147305 [Bug 147305] FILEOPEN DOCX: Writer hangs and consumes all available memory when opening specific docx document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147305] FILEOPEN DOCX: Writer hangs and consumes all available memory when opening specific docx document
https://bugs.documentfoundation.org/show_bug.cgi?id=147305 Justin L changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Blocks|109195 |104450 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104450 [Bug 104450] [META] DOCX (OOXML) file opening issues https://bugs.documentfoundation.org/show_bug.cgi?id=109195 [Bug 109195] [META] DOCX (OOXML) Footnote and Endnote bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139273] FILEOPEN: DOC/DOCX/RTF. Endnote page style page-size different from Default Page Size
https://bugs.documentfoundation.org/show_bug.cgi?id=139273 Justin L changed: What|Removed |Added Summary|FILEOPEN: DOC/DOCX/RTF. |FILEOPEN: DOC/DOCX/RTF. |Wrong last page style (also |Endnote page style |present at copy/paste of|page-size different from |the document) |Default Page Size -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137335] FILEOPEN DOCX Whitespace should not define paragraph height (CR formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=137335 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||4683 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 134683] FILEOPEN DOCX Empty paragraph direct character size formatting not applied (CR formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=134683 Justin L changed: What|Removed |Added Summary|FILEOPEN DOCX Empty |FILEOPEN DOCX Empty |paragraph direct character |paragraph direct character |size formatting not applied |size formatting not applied ||(CR formatting) See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=13 ||7335 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 137335] FILEOPEN DOCX Whitespace should not define paragraph height (CR formatting)
https://bugs.documentfoundation.org/show_bug.cgi?id=137335 Justin L changed: What|Removed |Added Summary|FILEOPEN DOCX Whitespace|FILEOPEN DOCX Whitespace |should not define paragraph |should not define paragraph |height |height (CR formatting) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117611] Images anchored 'To Paragraph' in ODT are misplaced after saving as DOCX and anchored 'To Character'
https://bugs.documentfoundation.org/show_bug.cgi?id=117611 Justin L changed: What|Removed |Added Hardware|x86-64 (AMD64) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150766] Incomplete recalculate
https://bugs.documentfoundation.org/show_bug.cgi?id=150766 jeanmarcran...@gmail.com changed: What|Removed |Added Keywords|bibisectRequest |bibisected --- Comment #6 from jeanmarcran...@gmail.com --- d12d1a450eb7599eb60ba605ce7a7e8b12bcb744 is the first bad commit commit d12d1a450eb7599eb60ba605ce7a7e8b12bcb744 Author: Matthew Francis Date: Sun Mar 15 06:07:23 2015 +0800 source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55 (Bibisect: Skipped preceding irrelevant commit(s) b2efe90c07baa45d2ee7e13138dd306a29738473) commit 5ef856e975d7c0396984d588a43fd1a7c7085c55 Author: Kohei Yoshida AuthorDate: Tue Nov 18 21:03:05 2014 -0500 Commit: Kohei Yoshida CommitDate: Tue Nov 18 21:03:50 2014 -0500 Use group area listeners during ODS import. Change-Id: Id01f9021dda7f33255f8206174cd730507ab55ad :04 04 126e010c62ce770ece406648bd72b0d2505c593f e7bee6d7439acbe7be3fd506baefed81c493b191 M opt Bisected using https://bibisect.libreoffice.org/linux-44max.git-bundle The bisect log isn't "normal" - the very first bisection step was unconclusive, LibreOffice consistently crashed on the sort step, so I kickstarted it testing a random point. # bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2 # good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e git bisect start 'latest' 'oldest' # skip: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4 git bisect skip 8cf60cc706948588e2f33a6d98b7c55d454e362a # good: [2d15a9a7574c794c9dc50f5ff4cd5ed4464fde70] source-hash-a6fc653bbf38de453a540ca2ab69958dafa1d322 git bisect good 2d15a9a7574c794c9dc50f5ff4cd5ed4464fde70 # good: [9a82af5ef45cf613dfab0f6e979d404b717018f9] source-hash-96d091d43428472c2c68054ed5dca22f79adc705 git bisect good 9a82af5ef45cf613dfab0f6e979d404b717018f9 # good: [4f7b9e3948b9f7b42c81f5c1293aa73491001c93] source-hash-fa430e6b4e6f5d096bdf59db26e5d7393ca2297b git bisect good 4f7b9e3948b9f7b42c81f5c1293aa73491001c93 # good: [0fbc26d3c8e7c48fb6d13aa99006f355601b5f7d] source-hash-9313095ea2d5f3dcc531d658e159e16ac2cb44fd git bisect good 0fbc26d3c8e7c48fb6d13aa99006f355601b5f7d # good: [8fbd6faad6cc859f6f2ab984a031b818d9471140] source-hash-65f41639e219470c80f896129731f9ed6f072b6b git bisect good 8fbd6faad6cc859f6f2ab984a031b818d9471140 # good: [e076716822b668af0bd9f480a6f67336e0d1591b] source-hash-dbdacc73ae154237314d599194cc686bd738a9bf git bisect good e076716822b668af0bd9f480a6f67336e0d1591b # bad: [40de7a9096dba2cd21825772dc4fd776c6f7fdaa] source-hash-78ac39dcef36b3881b2574b2db1e0d5a068c7804 git bisect bad 40de7a9096dba2cd21825772dc4fd776c6f7fdaa # bad: [57ed981e95cf3b915ed02bd1f8d2a9ecf618351c] source-hash-f857358d83e7c105271eb0e2c43f0b036f14f284 git bisect bad 57ed981e95cf3b915ed02bd1f8d2a9ecf618351c # good: [8a43f1c48415bd9e44ad81ca13c31ca39d3b15e9] source-hash-a55adb16ece70360c88342ca008d5a9d5b9d5b52 git bisect good 8a43f1c48415bd9e44ad81ca13c31ca39d3b15e9 # bad: [7c712fe89744ed1190bcee076bdbf81d40f1dc85] source-hash-3f4896bcfe21794239f8ec32f8f6d7e438a7907e git bisect bad 7c712fe89744ed1190bcee076bdbf81d40f1dc85 # good: [ad806e9b6fa58c2589859cb3c55511235f2c534f] source-hash-1296f9063203a3f9488689136b833568c183edab git bisect good ad806e9b6fa58c2589859cb3c55511235f2c534f # bad: [52dc3a6032f416dfe4a7182adc1d187ffcd9af24] source-hash-764600bc6175a32d119487afda2e8409f3395666 git bisect bad 52dc3a6032f416dfe4a7182adc1d187ffcd9af24 # bad: [6ca58fb62944a6ef674e4630740673971334f424] source-hash-1b9aaba0bfe8bc0872e7ea9f9aef5961e4b52f7c git bisect bad 6ca58fb62944a6ef674e4630740673971334f424 # bad: [d12d1a450eb7599eb60ba605ce7a7e8b12bcb744] source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55 git bisect bad d12d1a450eb7599eb60ba605ce7a7e8b12bcb744 # first bad commit: [d12d1a450eb7599eb60ba605ce7a7e8b12bcb744] source-hash-5ef856e975d7c0396984d588a43fd1a7c7085c55 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 89297] Header, footer and page number missing on second page when saved as docx (continuous section breaks enhancement request)
https://bugs.documentfoundation.org/show_bug.cgi?id=89297 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||764 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 87764] FILEOPEN: DOC - new page style started if continuous section break margin changes (comment 31)
https://bugs.documentfoundation.org/show_bug.cgi?id=87764 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||297 Summary|FILEOPEN: DOC - Section |FILEOPEN: DOC - new page |columns incorrectly |style started if continuous |imported around page|section break margin |columns |changes (comment 31) --- Comment #31 from Justin L --- (In reply to Robinson Tryon (qubit) from comment #1) > Comment on attachment 111394 [details] > Text file made with scan / OCR process, .doc. This one actually looks reasonable good to me. At least it doesn't have those ridiculously thin columns any more since author Justin Luth on 2019-01-12 17:10:54 with commit 84fefd7c295fc05499ca222dff50c2fe4e0fb27e tdf#120145 ww8import: ignoreCols if section is inserted Otherwise, the column setting is duplicated both in the section and in the page style. But this bug report has become the poster child for all kinds of continuous section break issues in DOC, so I'll keep it open. (Bug 86468 with the same identified commit and lots of duplicates was marked as WONTFIX.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127368] FILEOPEN DOCX character properties cannot be applied to only the paragraph marker CR (see comment 6)
https://bugs.documentfoundation.org/show_bug.cgi?id=127368 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||5602 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 125602] FILEOPEN DOC: Incorrect paragraph font style due to CR formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=125602 Justin L changed: What|Removed |Added Summary|Incorrect paragraph font |FILEOPEN DOC: Incorrect |style in doc|paragraph font style due to ||CR formatting CC||jl...@mail.com Hardware|x86-64 (AMD64) |All See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||7368 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 150721] Ctrl+Q should close documents, not exit LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=150721 --- Comment #9 from Eyal Rozenberg --- Also support a pop-up dialog on Ctrl+Q. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 150721] Ctrl+Q should close documents, not exit LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=150721 --- Comment #9 from Eyal Rozenberg --- Also support a pop-up dialog on Ctrl+Q. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150873] Links / URLs to document aliases don't seem to work (MacOS).
https://bugs.documentfoundation.org/show_bug.cgi?id=150873
--- Comment #1 from Thomas Maeder ---
Created attachment 182329
--> https://bugs.documentfoundation.org/attachment.cgi?id=182329=edit
ZIP archive of example files
Expand the archive to the Desktop folder (for running the Applescript).
The folder created will is named "LO alias bug".
The applescript ("Open alias Applescript") illustrates how it should work: it
tells the Finder to open the alias "Target LO Writer alias", which points to
the document "Target LO Writer document.odt" that is then opened correctly.
(The aliases may need to be recreated, I don't know whether they still work.)
In the Calc document "Bug Alias.odt", column A contains two direct links to
example files "Target LO Writer document.odt" and "Target PDF document.pdf":
clicking on the links open these files flawlessly.
Column B contains the indirect links to the same files, through aliases "Target
LO Writer alias" and "Target PDF alias". Somehow, clicking on them opens the
Terminal application and does nothing else…
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150874] Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150874 v.g changed: What|Removed |Added Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150874] New: Crash in: mdds::flat_segment_tree::insert_to_pos(boost::intrusive_ptr > > &,long,long,bool)
https://bugs.documentfoundation.org/show_bug.cgi?id=150874 Bug ID: 150874 Summary: Crash in: mdds::flat_segment_tree::insert_to_pos(boos t::intrusive_ptr > > &,long,long,bool) Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: v...@chello.nl This bug was filed from the crash reporting server and is br-cfebb143-9053-4a23-bf0e-ee350f2234a9. = Software Build: https://git.libreoffice.org/core/+log/49f2b1bff42cfccbd8f788c8dc32c1c309559be0 What did I do? 3 files open, editing one. I did remove 4 rows and than the crash. After recovery rows where not removed. I did remove these and more rows, no crashes... Can not be reproduced. Win10 laptop was last restarted 17 days ago and high memory use (86%) before starting calc. 3 open calc files, 2 opened an hour ago, 1 was open for a week or two. Laptop is in sleep modus most of the days. Never had one crash with calc last 2 years. After restart 3 files recovered, no crashes Will update next few minutes to version LibreOffice_7.3.6_Win_x64 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 97101] Add a SPLIT() function for separating string cells based on a delimiter
https://bugs.documentfoundation.org/show_bug.cgi?id=97101 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||0866 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150866] Add TEXTSPLIT function to Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=150866 Regina Henschel changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=97 ||101 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150873] New: Links / URLs to document aliases don't seem to work (MacOS).
https://bugs.documentfoundation.org/show_bug.cgi?id=150873 Bug ID: 150873 Summary: Links / URLs to document aliases don't seem to work (MacOS). Product: LibreOffice Version: 7.3.5.2 release Hardware: All OS: macOS (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thms.mae...@gmail.com Description: Creating a link to a document works fine in LO for MacOS, but, in the case of aliases, ends up failing and opening the Terminal application instead. The alias file should be simply passed to the Finder which will resolve it and open the original document. Steps to Reproduce: 1. Take any file (PDF, LO, JPEG) & make a MacOS alias to it. 2. In LO (Writer, Calc, …), make a document link to the alias (One needs to change the name manually, as using the file selection dialog will choose the original file). 3. Click on the link to open the file Actual Results: Instead of opening the file referred to by the alias, the Terminal application is somehow opened instead, and the alias is not activated. Expected Results: The alias should be processed as when opening it in the MacOS Finder: the original file referred by it is opened. Reproducible: Always User Profile Reset: No Additional Info: An Applescript command (tell app Finder to open…) will handle aliases correctly, because the system will resolve the alias and then choose the right application to open the file. Somehow, this works for direct document links in LO, but not for aliases, which are handled differently, ending up opening the Terminal application for some reason. Aliases should be simply passed to the Finder, which is able to resolve them. Version: 7.3.5.2 / LibreOffice Community Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01 CPU threads: 8; OS: Mac OS X 12.5.1; UI render: default; VCL: osx Locale: fr-CH (fr_CH.UTF-8); UI: fr-FR Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 --- Comment #5 from Justin --- Created attachment 182328 --> https://bugs.documentfoundation.org/attachment.cgi?id=182328=edit file open 3 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 --- Comment #4 from Justin --- Created attachment 182327 --> https://bugs.documentfoundation.org/attachment.cgi?id=182327=edit file open 2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 Justin changed: What|Removed |Added Attachment #182326|pos 1 |file open 1 description|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 --- Comment #3 from Justin --- Created attachment 182326 --> https://bugs.documentfoundation.org/attachment.cgi?id=182326=edit pos 1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 --- Comment #2 from Justin --- Created attachment 182325 --> https://bugs.documentfoundation.org/attachment.cgi?id=182325=edit example ODS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 --- Comment #1 from Justin --- Created attachment 182324 --> https://bugs.documentfoundation.org/attachment.cgi?id=182324=edit example XLS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150872] New: XLS with split window - split bar moves left every open
https://bugs.documentfoundation.org/show_bug.cgi?id=150872 Bug ID: 150872 Summary: XLS with split window - split bar moves left every open Product: LibreOffice Version: 3.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: web...@att.net Description: split bar moves on its own, so it has to be moved again and again and again and again Steps to Reproduce: 1. open divbar.xls 2. observe horizontal position of split bar 3. Save the file, Close the file 4. open divbar.xls Actual Results: the split bar has moved left a noticeable amount, and will move more each open Expected Results: the split bar location should not change (except by explicit user action), just like with and ods file Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.3.5.2 (x64) / LibreOffice Community Build ID: 184fe81b8c8c30d8b5082578aee2fed2ea847c01 CPU threads: 16; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150871] Calc sheet UI doesn't redraw after dragging split view bar
https://bugs.documentfoundation.org/show_bug.cgi?id=150871 --- Comment #2 from Justin --- Created attachment 182323 --> https://bugs.documentfoundation.org/attachment.cgi?id=182323=edit image showing redraw issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150871] Calc sheet UI doesn't redraw after dragging split view bar
https://bugs.documentfoundation.org/show_bug.cgi?id=150871 --- Comment #1 from Justin --- Created attachment 182322 --> https://bugs.documentfoundation.org/attachment.cgi?id=182322=edit example calc file -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150871] New: Calc sheet UI doesn't redraw after dragging split view bar
https://bugs.documentfoundation.org/show_bug.cgi?id=150871 Bug ID: 150871 Summary: Calc sheet UI doesn't redraw after dragging split view bar Product: LibreOffice Version: 3.5.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: web...@att.net Description: Drag the vertical split window bar and bottom edge of the header row is speckled. Steps to Reproduce: 1. open divbar.ods 2. drag the split bar to the right Actual Results: header row edge is speckled Expected Results: It should not be speckled, but look beautiful as before the drag. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Win10 v21H2, NVIDIA GPU -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150870] FORMATTING Adding a row in an existing table removes text format (police, bold, centered) back to default. (And CTRL+Z doesn't undo the mess !)
https://bugs.documentfoundation.org/show_bug.cgi?id=150870 Telesto changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Telesto --- *** This bug has been marked as a duplicate of bug 126008 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150870] FORMATTING Adding a row in an existing table removes text format (police, bold, centered) back to default. (And CTRL+Z doesn't undo the mess !)
https://bugs.documentfoundation.org/show_bug.cgi?id=150870 Telesto changed: What|Removed |Added Status|NEW |UNCONFIRMED CC||tele...@surfxs.nl Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150870] FORMATTING Adding a row in an existing table removes text format (police, bold, centered) back to default. (And CTRL+Z doesn't undo the mess !)
https://bugs.documentfoundation.org/show_bug.cgi?id=150870 loic_dup...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150870] FORMATTING Adding a row in an existing table removes text format (police, bold, centered) back to default. (And CTRL+Z doesn't undo the mess !)
https://bugs.documentfoundation.org/show_bug.cgi?id=150870 --- Comment #1 from loic_dup...@hotmail.com --- Created attachment 182321 --> https://bugs.documentfoundation.org/attachment.cgi?id=182321=edit exemple table and HOW TO included to repoduce the bug. Wrong result visualisation (what it does on my computer) also included. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150870] New: FORMATTING Adding a row in an existing table removes text format (police, bold, centered) back to default. (And CTRL+Z doesn't undo the mess !)
https://bugs.documentfoundation.org/show_bug.cgi?id=150870 Bug ID: 150870 Summary: FORMATTING Adding a row in an existing table removes text format (police, bold, centered) back to default. (And CTRL+Z doesn't undo the mess !) Product: LibreOffice Version: 7.3.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: loic_dup...@hotmail.com Description: THE PROBLEM : - I create a [3 col x 5 rows] table. Change police, put bold and center it. - fill all cells. - I duplicate this table (with an empty line between) - I choose to add a row. BAM ! It happens. All text format is gone. THe text is here, but back to default font, and everything. HOW TO REPRODUCE : i made a exemple doc that trigger at every try the bug. BONUS POINT : try to abort changes. (spoiler : it remove the row, but doesn't get back text format. It's lost!) Steps to Reproduce: 1. I create a [3 col x 5 rows] table. Change police, put bold and center it. 2. fill all cells. 3. I duplicate this table (with an empty line between) 4. I choose to add a row. Actual Results: - Formating is destroyed, back to defalut texte format. - format erasing can NOT be reversed with CTRL+Z Expected Results: - no text format in the table is erased - no unexpected behaviour that cannot be reversed with CTRL+Z Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: I made a attachement with an exemple to reproduce. I tryed safe mode. Nope, it doesn't solve it. OPen GL report : Rendereur: GeForce RTX 2080 SUPER/PCIe/SSE2 Fournisseur: NVIDIA Corporation Version:4.6.0 NVIDIA 457.51 Version GLSL: 4.60 NVIDIA Max. taille texture 32768 x 32768 Max. vertex tex. image units: 32 Max. texture image unit?s 32 Max Geometry Texture Units: 32 Max. anisotropie 16 Taille Max. Vue 32768 x 32768 Distances maximales des clips: 8 Max. ?chantillons 16 Extensions: 428 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #7 from Thomas Maeder --- Created attachment 182320 --> https://bugs.documentfoundation.org/attachment.cgi?id=182320=edit Checkbox for separate-space mode This is the System Preferences control panel that controls the occurence of this bug. The bug only occurs on the 2nd screen if the marked checkbox is deactivated: the 2nd screen has no menu bar in this case. In separate-space mode (checkbox active), both screens have menu bars, and everything works fine (see attached screenshots). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121491] Objects silently resized when changing margins by sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=121491 --- Comment #9 from Regina Henschel --- Created attachment 182319 --> https://bugs.documentfoundation.org/attachment.cgi?id=182319=edit relevant setting The usual setting of this member is 'false' in Draw and 'true' in Impress. That can be set by the user with checkbox 'Fit object to paper format' (not persistent) in the Page Properties dialog, tab Page. Because Impress does not have this setting in the sidebar, I guess it is save to force it to 'false' here. But I'm busy with other things and will not investigate further. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #6 from Thomas Maeder --- Created attachment 182318 --> https://bugs.documentfoundation.org/attachment.cgi?id=182318=edit Autofilter menu in single-space mode, monitor 2, lowered: OK Lowering the top of the window in the buggy case restores visibility of the menu, but this is of little use in practice, as Autofilters tend to reside near the top of the screen. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #5 from Thomas Maeder --- Created attachment 182317 --> https://bugs.documentfoundation.org/attachment.cgi?id=182317=edit Autofilter menu in single-space mode, monitor 2: bug Here the Autofilter menu is partially hidden, as its position is too high. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107636] [META] User profile (user data/settings) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107636 Bug 107636 depends on bug 82402, which changed state. Bug 82402 Summary: START CENTER: Files with charts do not save thumbnail on open https://bugs.documentfoundation.org/show_bug.cgi?id=82402 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90486] [META] Chart bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=90486 Bug 90486 depends on bug 82402, which changed state. Bug 82402 Summary: START CENTER: Files with charts do not save thumbnail on open https://bugs.documentfoundation.org/show_bug.cgi?id=82402 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 61914] [META] Start Center bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=61914 Bug 61914 depends on bug 82402, which changed state. Bug 82402 Summary: START CENTER: Files with charts do not save thumbnail on open https://bugs.documentfoundation.org/show_bug.cgi?id=82402 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 82402] START CENTER: Files with charts do not save thumbnail on open
https://bugs.documentfoundation.org/show_bug.cgi?id=82402 stragu changed: What|Removed |Added CC||stephane.guil...@member.fsf ||.org Resolution|--- |WORKSFORME Hardware|Other |All Status|NEW |RESOLVED --- Comment #28 from stragu --- Tested with 6 files (thumbnail stripped when applicable): http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/odp/chart.odp (thumbnail is in the file) http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/xls/chart.xls http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/ods/chart.ods (thumbnail is in the file) http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/percentage-number-formats.pptx http://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/chart.pptx https://cgit.freedesktop.org/libreoffice/core/plain/chart2/qa/extras/data/pptx/bnc882383.pptx Using version 6.3, all files listed above show a thumbnail except for the XLS file. Version: 6.3.6.2 Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Starting with LO 7.1, the XLS file does not ask for saving changes when there's no changes + shows a preview in the start centre. Version: 7.1.8.1 / LibreOffice Community Build ID: e1f30c802c3269a1d052614453f260e49458c82c CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Marking as Resolved - Works for me, unless someone can point to a file that still doesn't show a thumbnail in the start centre (and even so, maybe better to file a new, more specific bug) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #4 from Thomas Maeder --- Created attachment 182316 --> https://bugs.documentfoundation.org/attachment.cgi?id=182316=edit Autofilter menu in single-space mode, monitor 1: OK -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #3 from Thomas Maeder --- Created attachment 182315 --> https://bugs.documentfoundation.org/attachment.cgi?id=182315=edit Autofilter menu in separate-space mode, monitor 2: OK -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #2 from Thomas Maeder --- Created attachment 182314 --> https://bugs.documentfoundation.org/attachment.cgi?id=182314=edit Autofilter menu in separate-space mode, monitor 1: OK -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 --- Comment #1 from Thomas Maeder --- Created attachment 182313 --> https://bugs.documentfoundation.org/attachment.cgi?id=182313=edit Example Calc document to reproduce the bug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150869] New: LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode.
https://bugs.documentfoundation.org/show_bug.cgi?id=150869 Bug ID: 150869 Summary: LO Calc Autofilter menu doesn't display correctly in MacOS 2nd screen in single-space mode. Product: LibreOffice Version: 7.3.5.2 release Hardware: IA64 (Itanium) OS: macOS (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: thms.mae...@gmail.com Description: When using two monitors in extended-screen mode (two monitors sharing the same space) and a Calc window opened in the 2nd screen, an Autofilter menu may display partly beyond the screen range, making it largely unusable. If the menu cell is sufficiently low, it will work, but Autofilters tend to be quite close to the top of the screen… In the 1st main screen (the one with the menu bar), Autofilter menus display flawlessly. Both screens work well if, in the System Preferences Mission Control panel, both screens are set to have their own space (menu bar on top of each one). Steps to Reproduce: 1. Use a machine with two monitors. 2. In System Preferences, Monitors, set the screens to be independent, side by side. 3. In System Preferences, Mission Control, deselect the checkbox "Monitors have separate Spaces" 4. Open the Calc spreadsheet in the attached archive and set the window to full-screen modern the second screen (the one without the menu bar). 5. Try to use an Autofilter to filter the data => the filter menu will partly display beyond the top of the screen. Actual Results: In the 2nd screen in extended-screen mode (without separate spaces), Autofilter menus may display beyond the top of the screen. Expected Results: Autofilter menus should adjust their position so that they remain in the screen, independently of the position of the cell or the display mode. Reproducible: Always User Profile Reset: No Additional Info: See attached files : - LO autofilter bug.ods : an example Calc document to reproduce the bug. - Screenshots that illustrate the problem. Single-space mode, 1st screen, full => OK Single-space mode, 2nd screen, full => bug (filter menu too high) Single-space mode, 2nd screen, reduced to avoid issue => OK Separate-space mode, all => OK -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146935] LO Calc autofilter dropdown pane scrolls sideways
https://bugs.documentfoundation.org/show_bug.cgi?id=146935 --- Comment #9 from peter.t.koz...@gmail.com --- Same in Version: 7.3.5.2 Build ID: 30(Build:2) CPU threads: 8; OS: Linux 5.19; UI render: default; VCL: gtk3 Locale: en-US (C.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149383] Crash in: SdrObject::GetTitle() - EDITING an IMAGE inside the document
https://bugs.documentfoundation.org/show_bug.cgi?id=149383 loic_dup...@hotmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA --- Comment #4 from loic_dup...@hotmail.com --- I'am unable to reproduce accurately the bug. It's too unpredictable. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145636] [SLIDESHOW and PDF] color background can be seen in edit mode but isn't shown in slideshow nor exported in PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=145636 --- Comment #5 from loic_dup...@hotmail.com --- I completely understand your point of view. ...As a developer. On the other hand, if we put ourselves from the point of view of quality assurance, I say to myself that if the lambda end user can do it, it is because the initial code (...on the microsoft side?!) allows it. So we *should* have to handle it properly? What do you think about putting it in a "future improvement" request? This is undoubtedly my perfectionist side talking, but I think it's a bad idea to leave a potential bug. After that, I ABSOLUTELY do not have the skills to improve the problem, so I will not be able to do it myself #/me==Sad. Translated with www.DeepL.com/Translator (free version) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source
include/vcl/fontcharmap.hxx | 17 ++---
vcl/inc/impfontcharmap.hxx |6 +++---
vcl/source/font/PhysicalFontFace.cxx |5 ++---
vcl/source/font/fontcharmap.cxx | 22 +++---
4 files changed, 14 insertions(+), 36 deletions(-)
New commits:
commit 88d7aa8ab79b1197191b5eb24a3b67d313797026
Author: Khaled Hosny
AuthorDate: Thu Sep 8 16:57:03 2022 +0200
Commit: خالد حسني
CommitDate: Thu Sep 8 22:15:25 2022 +0200
vcl: Drop CmapResult indirection
Change-Id: I3b1beb5e976a255ef8ecdf8670b1e59547ec5ea4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139700
Tested-by: Jenkins
Reviewed-by: خالد حسني
diff --git a/include/vcl/fontcharmap.hxx b/include/vcl/fontcharmap.hxx
index d79ffce7be92..f7bea49f0f7a 100644
--- a/include/vcl/fontcharmap.hxx
+++ b/include/vcl/fontcharmap.hxx
@@ -25,7 +25,6 @@
#include
class ImplFontCharMap;
-class CmapResult;
class FontCharMap;
class OutputDevice;
@@ -40,9 +39,9 @@ public:
**/
FontCharMap();
-/** A new FontCharMap is created based on the CmapResult
+/** A new FontCharMap is created based on passed arguments.
*/
-FontCharMap( const CmapResult& rCR );
+FontCharMap(bool bSymbolic, const sal_UCS4* pRangeCodes, int nRangeCount);
virtual ~FontCharMap() override;
@@ -154,18 +153,6 @@ private:
voidoperator=( const FontCharMap& ) = delete;
};
-// CmapResult is a normalized version of the many CMAP formats
-class VCL_PLUGIN_PUBLIC CmapResult
-{
-public:
-explicitCmapResult( bool bSymbolic = false,
-const sal_UCS4* pRangeCodes = nullptr, int
nRangeCount = 0 );
-
-const sal_UCS4* mpRangeCodes;
-int mnRangeCount;
-boolmbSymbolic;
-};
-
#endif // INCLUDED_FONTCHARMAP_HXX
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/inc/impfontcharmap.hxx b/vcl/inc/impfontcharmap.hxx
index 36809cdd986b..b2d47dc9f2b7 100644
--- a/vcl/inc/impfontcharmap.hxx
+++ b/vcl/inc/impfontcharmap.hxx
@@ -26,12 +26,12 @@
class ImplFontCharMap;
typedef tools::SvRef ImplFontCharMapRef;
-class CmapResult;
-
class ImplFontCharMap final : public SvRefBase
{
public:
-explicitImplFontCharMap( const CmapResult& );
+explicitImplFontCharMap( bool bSymbolic,
+ const sal_uInt32* pRangeCodes,
+ int nRangeCount);
virtual ~ImplFontCharMap() override;
private:
diff --git a/vcl/source/font/PhysicalFontFace.cxx
b/vcl/source/font/PhysicalFontFace.cxx
index 1133b0d6a131..9c1a1b586423 100644
--- a/vcl/source/font/PhysicalFontFace.cxx
+++ b/vcl/source/font/PhysicalFontFace.cxx
@@ -248,7 +248,7 @@ FontCharMapRef PhysicalFontFace::GetFontCharMap() const
if (hb_set_get_population(pUnicodes))
{
-// Convert HarfBuzz set to CmapResult ranges.
+// Convert HarfBuzz set to code ranges.
int nRangeCount = 0;
hb_codepoint_t nFirst, nLast = HB_SET_VALUE_INVALID;
while (hb_set_next_range(pUnicodes, , ))
@@ -263,8 +263,7 @@ FontCharMapRef PhysicalFontFace::GetFontCharMap() const
*(pCP++) = nLast + 1;
}
-CmapResult aCmapResult(bSymbol, pRangeCodes, nRangeCount);
-mxCharMap = new FontCharMap(aCmapResult);
+mxCharMap = new FontCharMap(bSymbol, pRangeCodes, nRangeCount);
}
hb_set_destroy(pUnicodes);
diff --git a/vcl/source/font/fontcharmap.cxx b/vcl/source/font/fontcharmap.cxx
index 5896e786eca0..450521cc6008 100644
--- a/vcl/source/font/fontcharmap.cxx
+++ b/vcl/source/font/fontcharmap.cxx
@@ -23,13 +23,6 @@
#include
#include
-CmapResult::CmapResult( bool bSymbolic,
-const sal_UCS4* pRangeCodes, int nRangeCount )
-: mpRangeCodes( pRangeCodes)
-, mnRangeCount( nRangeCount)
-, mbSymbolic( bSymbolic)
-{}
-
static ImplFontCharMapRef g_pDefaultImplFontCharMap;
const sal_UCS4 aDefaultUnicodeRanges[] = {0x0020,0xD800, 0xE000,0xFFF0};
const sal_UCS4 aDefaultSymbolRanges[] = {0x0020,0x0100, 0xF020,0xF100};
@@ -42,11 +35,11 @@ ImplFontCharMap::~ImplFontCharMap()
}
}
-ImplFontCharMap::ImplFontCharMap( const CmapResult& rCR )
-: mpRangeCodes( rCR.mpRangeCodes )
-, mnRangeCount( rCR.mnRangeCount )
+ImplFontCharMap::ImplFontCharMap(bool bSymbolic, const sal_UCS4* pRangeCodes,
int nRangeCount)
+: mpRangeCodes(pRangeCodes)
+, mnRangeCount(nRangeCount)
, mnCharCount( 0 )
-, m_bSymbolic(rCR.mbSymbolic)
+, m_bSymbolic(bSymbolic)
{
const sal_UCS4* pRangePtr = mpRangeCodes;
for( int i = mnRangeCount; --i >= 0; pRangePtr += 2 )
@@ -67,8 +60,7 @@ ImplFontCharMapRef const & ImplFontCharMap::getDefaultMap(
bool bSymbols )
nCodesCount = std::size(aDefaultSymbolRanges);
}
-CmapResult aDefaultCR( bSymbols, pRangeCodes, nCodesCount/2 );
-g_pDefaultImplFontCharMap =
[Libreoffice-bugs] [Bug 147495] Scrolling within Calc sheet is erratic or ignored
https://bugs.documentfoundation.org/show_bug.cgi?id=147495 --- Comment #3 from Marmel --- (In reply to Kyle from comment #2) > A work around: > > Installing imwheel... It's a little janky, but is certainly far better than the default Calc spastic scroll behavior. Thanks for the suggestion. Hopefully this issue will be addressed properly in the application itself. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 80206] FILESAVE: Save as .doc or .docx misplaces graphs, even when opened in the same version of LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=80206 Justin L changed: What|Removed |Added Whiteboard|BSA target:7.2.0|BSA |target:7.1.4| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104848] [META] DOC (binary) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104848 Justin L changed: What|Removed |Added Depends on||86879 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86879 [Bug 86879] FILEOPEN: Hangs trying to open .DOC that MSO opens in Protected View because it detected problem and hangs on editing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86879] FILEOPEN: Hangs trying to open .DOC that MSO opens in Protected View because it detected problem and hangs on editing
https://bugs.documentfoundation.org/show_bug.cgi?id=86879 Justin L changed: What|Removed |Added Blocks|104527 |104848 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104527 [Bug 104527] [META] DOC (binary) format bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=104848 [Bug 104848] [META] DOC (binary) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104527] [META] DOC (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Justin L changed: What|Removed |Added Depends on|86879 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=86879 [Bug 86879] FILEOPEN: Hangs trying to open .DOC that MSO opens in Protected View because it detected problem and hangs on editing -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104848] [META] DOC (binary) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104848 Justin L changed: What|Removed |Added Depends on||65881 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=65881 [Bug 65881] FILEOPEN: Writer freezes when trying to open a DOC with frame in header -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104527] [META] DOC (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Justin L changed: What|Removed |Added Depends on|65881 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=65881 [Bug 65881] FILEOPEN: Writer freezes when trying to open a DOC with frame in header -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 65881] FILEOPEN: Writer freezes when trying to open a DOC with frame in header
https://bugs.documentfoundation.org/show_bug.cgi?id=65881 Justin L changed: What|Removed |Added Blocks|104527 |104848 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104527 [Bug 104527] [META] DOC (binary) format bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=104848 [Bug 104848] [META] DOC (binary) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104848] [META] DOC (binary) file opening issues
https://bugs.documentfoundation.org/show_bug.cgi?id=104848 Justin L changed: What|Removed |Added Depends on||114111 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114111 [Bug 114111] FILEOPEN: Hang/Crash loading many tables in table .doc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104527] [META] DOC (binary) format bug tracker
https://bugs.documentfoundation.org/show_bug.cgi?id=104527 Justin L changed: What|Removed |Added Depends on|114111 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=114111 [Bug 114111] FILEOPEN: Hang/Crash loading many tables in table .doc -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114111] FILEOPEN: Hang/Crash loading many tables in table .doc
https://bugs.documentfoundation.org/show_bug.cgi?id=114111 Justin L changed: What|Removed |Added Blocks|104527 |104848 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104527 [Bug 104527] [META] DOC (binary) format bug tracker https://bugs.documentfoundation.org/show_bug.cgi?id=104848 [Bug 104848] [META] DOC (binary) file opening issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150845] CRASH: inserting a form
https://bugs.documentfoundation.org/show_bug.cgi?id=150845 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/filter/dif/difexp.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 91c0a4b982f5af093feb80eabe22b73376b5a430
Author: Julien Nabet
AuthorDate: Thu Sep 8 20:49:22 2022 +0200
Commit: Julien Nabet
CommitDate: Thu Sep 8 21:12:52 2022 +0200
Fix location of ScDocShell in comment
Change-Id: I316d967427b6b86d3a2dbea46f535405f2966a1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139705
Tested-by: Julien Nabet
Reviewed-by: Julien Nabet
diff --git a/sc/source/filter/dif/difexp.cxx b/sc/source/filter/dif/difexp.cxx
index 4b433c3a5704..6fbd13ab2248 100644
--- a/sc/source/filter/dif/difexp.cxx
+++ b/sc/source/filter/dif/difexp.cxx
@@ -200,7 +200,7 @@ void ScFormatFilterPluginImpl::ScExportDif( SvStream& rOut,
ScDocument* pDoc,
else
{
// for an explanation why this complicated, see
-// sc/source/ui/docsh.cxx:ScDocShell::AsciiSave()
+// sc/source/ui/docshell/docsh.cxx:ScDocShell::AsciiSave()
// In fact we should create a common method if this would be
// needed just one more time...
assert( aOS.isEmpty() && "aOS should be empty");
[Libreoffice-bugs] [Bug 150845] CRASH: inserting a form
https://bugs.documentfoundation.org/show_bug.cgi?id=150845 --- Comment #4 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f4883ff377369e36ad9f080b0c5f027023707297 tdf#150845 fix crash in writer Form->TextObject It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150845] CRASH: inserting a form
https://bugs.documentfoundation.org/show_bug.cgi?id=150845 Commit Notification changed: What|Removed |Added Whiteboard||target:7.5.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: svx/source
svx/source/svdraw/svdcrtv.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit f4883ff377369e36ad9f080b0c5f027023707297
Author: Noel Grandin
AuthorDate: Thu Sep 8 17:55:42 2022 +0200
Commit: Noel Grandin
CommitDate: Thu Sep 8 21:11:50 2022 +0200
tdf#150845 fix crash in writer Form->TextObject
regression from
commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
Author: Noel Grandin
Date: Thu May 27 10:27:46 2021 +0200
ref-count SdrObject
Change-Id: I66370566562a1275c21c24523a505704508d3d09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139703
Tested-by: Noel Grandin
Reviewed-by: Noel Grandin
diff --git a/svx/source/svdraw/svdcrtv.cxx b/svx/source/svdraw/svdcrtv.cxx
index a73c5fe531af..1aa9d1d2d54e 100644
--- a/svx/source/svdraw/svdcrtv.cxx
+++ b/svx/source/svdraw/svdcrtv.cxx
@@ -337,14 +337,14 @@ void SdrCreateView::SetCurrentObj(SdrObjKind nIdent,
SdrInventor nInvent)
{
mnCurrentInvent=nInvent;
mnCurrentIdent=nIdent;
+rtl::Reference pObj = (nIdent == SdrObjKind::NONE) ?
nullptr :
+SdrObjFactory::MakeNewObject(
+*GetModel(),
+nInvent,
+nIdent);
-if(nIdent != SdrObjKind::NONE)
+if(pObj)
{
-rtl::Reference pObj =
-SdrObjFactory::MakeNewObject(
-*GetModel(),
-nInvent,
-nIdent);
// Using text tool, mouse cursor is usually I-Beam,
// crosshairs with tiny I-Beam appears only on MouseButtonDown.
if(IsTextTool())
[Libreoffice-bugs] [Bug 150849] Autocomplete function accepting suggestions without previous user choice
https://bugs.documentfoundation.org/show_bug.cgi?id=150849 Telesto changed: What|Removed |Added CC||tele...@surfxs.nl --- Comment #3 from Telesto --- Likely bug 150331 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150803] Font style changes after undo of reject changes
https://bugs.documentfoundation.org/show_bug.cgi?id=150803 Telesto changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from Telesto --- Overlooked step 1. Open the attached file 2. Place cursor somewhere inside "You can drag and drop a selection into ..." 4. Sidebar -> Styles -> Notice OOoTextBody being applied 5. Save as DOCX 6. File -> Reload 5. Edit -> track changes -> reject all 6. CTRL+Z 7. Place cursor somewhere inside "You can drag and drop a selection into..." -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150606] Undo of table in columns adds multiple additional pages + broken layout
https://bugs.documentfoundation.org/show_bug.cgi?id=150606 Telesto changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #3 from Telesto --- Well it seems far easier to do a bibisect and having some commit as reference, compared to blind search for the cause.. The source file comes from the bug tracker: attachment 182008 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/core/layout/layout.cxx | 10 ++
1 file changed, 10 insertions(+)
New commits:
commit cacb19b479f83dc0411f165edab9fd13f05b0afb
Author: Mike Kaganski
AuthorDate: Thu Sep 8 18:07:12 2022 +0300
Commit: Mike Kaganski
CommitDate: Thu Sep 8 20:54:37 2022 +0200
Fix CppunitTest_sw_core_layout on non-default DPI
Change-Id: I84f21b165628577ad680c98b0f28ac6956328833
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139699
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/core/layout/layout.cxx b/sw/qa/core/layout/layout.cxx
index a6a949b5337b..d75157f2b860 100644
--- a/sw/qa/core/layout/layout.cxx
+++ b/sw/qa/core/layout/layout.cxx
@@ -745,6 +745,11 @@ CPPUNIT_TEST_FIXTURE(SwCoreLayoutTest,
testDoublePageBorder)
CPPUNIT_TEST_FIXTURE(SwCoreLayoutTest, testNegativePageBorder)
{
+// FIXME: the DPI check should be removed when either (1) the test is
fixed to work with
+// non-default DPI; or (2) unit tests on Windows are made to use svp VCL
plugin.
+if (!IsDefaultDPI())
+return;
+
// Given a document with a top margin and a negative border distance:
createSwDoc();
SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
@@ -782,6 +787,11 @@ CPPUNIT_TEST_FIXTURE(SwCoreLayoutTest,
testNegativePageBorder)
CPPUNIT_TEST_FIXTURE(SwCoreLayoutTest, testNegativePageBorderNoMargin)
{
+// FIXME: the DPI check should be removed when either (1) the test is
fixed to work with
+// non-default DPI; or (2) unit tests on Windows are made to use svp VCL
plugin.
+if (!IsDefaultDPI())
+return;
+
// Given a document with no top margin and a negative border distance:
createSwDoc();
SwXTextDocument* pTextDoc =
dynamic_cast(mxComponent.get());
