[Libreoffice-bugs] [Bug 151828] Table name should be retained, if table is cutted & pasted

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151828

--- Comment #4 from Jim Raykowski  ---
Here is a proposed patch to retain the table name on cut and paste:
https://gerrit.libreoffice.org/c/core/+/142984

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151828] Table name should be retained, if table is cutted & pasted

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151828

--- Comment #3 from Jim Raykowski  ---
(In reply to Heiko Tietze from comment #2)
> Same is also true for other objects such as shapes and in fact the name is
> kept but added by a number. Like "Foo" becomes "Foo 1". With subsequent
> cut/paste operations it remains "Foo 1". => needsDevAdvice
Here is a fix for this:
https://gerrit.libreoffice.org/c/core/+/142983

I searched but didn't find a bug report specific to shape names changing when
cut/paste so I've listed it under this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152135] New: Crash when Firefox add-on: Digital Eye Strain Prevention Tool activates while editing LibreOffice spreadsheet

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152135

Bug ID: 152135
   Summary: Crash when Firefox add-on: Digital Eye Strain
Prevention Tool activates while editing LibreOffice
spreadsheet
   Product: LibreOffice
   Version: 7.4.2.3 release
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Chart
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: sears.cameronp...@att.net

Description:
The crash report was successfully uploaded.
You can soon find the report at:
https://crashreport.libreoffice.org/stats/crash_details/fdcdb5d0-3519-4cbd-9150-5479a49ebf85

Steps to Reproduce:
1.Open Firefox with add-on: Digital Eye Strain Prevention Tool Ver 2.3
installed
2.Open LibreOffice spreadsheet with 2 columns data. 
3.Create XY Scatter Chart
4.When Editing chart, under View menu select Toolbars - Drawing.
5.Pick an drawing tool from the Drawing toolbar at the bottom of the screen.
6.While actively using the drawing tool, when the Firefox Digital Eye Strain
Prevention add-on activates, LibreOffice spreadsheet crashes 

Digital Eye Strain Prevention Tool will activate every 20 minutes

LibreOffice local Help is now displayed in default browser - Firefox.

LibreOffice spreadsheet does NOT crash when XY Scatter Chart is open to edit
and NO drawing tool is in use and Digital Eye Strain Prevention Tool activates.


Actual Results:
Immediate crash and close.

Expected Results:
Immediate crash and close. Has happened multiple times.


Reproducible: Always


User Profile Reset: No

Additional Info:
LibreOffice info:
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Computer info:
Processor   11th Gen Intel(R) Core(TM) i5-1155G7 @ 2.50GHz   2.50 GHz
Installed RAM   12.0 GB (11.7 GB usable)
Product ID  00342-21919-63734-AAOEM
System type 64-bit operating system, x64-based processor
Pen and touch   No pen or touch input is available for this display

Firefox 107.0 (64-bit)
Add-on (extension) Digital Eye Strain Prevention Tool Ver 2.3 Last Updated
November 4, 2021

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] assign user macro to Tools menu fails on V7.4.2.3.x64 (Windows11) works on Windows8.1 V4..(same sheet)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

--- Comment #1 from wzpd...@gmail.com ---
Function appears to add but when closed the sheet undergoes recovery every time
and the attempted change is lost. No such fail on Windows8.1 and have used that
system and function several years w/o issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] assign user macro to Tools menu fails on V7.4.2.3.x64 (Windows11) works on Windows8.1 V4..(same sheet)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

wzpd...@gmail.com changed:

   What|Removed |Added

Version|unspecified |7.4.2.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152134] New: assign user macro to Tools menu fails on V7.4.2.3.x64 (Windows11) works on Windows8.1 V4..(same sheet)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152134

Bug ID: 152134
   Summary: assign user macro to Tools menu fails on V7.4.2.3.x64
(Windows11) works on Windows8.1 V4..(same sheet)
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wzpd...@gmail.com

Cannot assign macro on Windows11 LO v7.4.2.3 x64 but can on Windows8.1 LO v4.
once macro assigned on Windows8.1 system sheet Tools menu with macro functions
on either system.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148370] In Calc, Autocomplete places black marks in cell where letters should be, instead of previously used characters

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148370

BogdanB  changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME
 CC||buzea.bog...@libreoffice.or
   ||g

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151220] LibreOffice Window Appears Extremely Small When Opened

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151220

Lucas J  changed:

   What|Removed |Added

 Resolution|DUPLICATE   |---
 Status|RESOLVED|REOPENED

--- Comment #7 from Lucas J  ---
If that is the case, then we can reopen it. I just changed the status to
REOPENED.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151660] application window problem

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151660

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue by default (not as ByRef)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147951] API returns wrong user path on Windows

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147951

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151925] With q5 VCL, cursor disappears in some paragraphs in Writer

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151925

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151916] Not working if I choose Mongolian Cyrillic

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151916

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152098] Large Writer document 15x slower to open in 7.3.7.2 and does not open at last cursor position

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152098

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152098] Large Writer document 15x slower to open in 7.3.7.2 and does not open at last cursor position

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152098

--- Comment #6 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152017] footnotes move onto the next page as I add paragraphs to my document

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152017

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152017] footnotes move onto the next page as I add paragraphs to my document

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152017

--- Comment #4 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149210] Libre Office crashes unexpectedly

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149210

--- Comment #3 from QA Administrators  ---
Dear jan.feliksiak1,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149104] Fails to paste images into Writer

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149104

--- Comment #4 from QA Administrators  ---
Dear Ian Jarvis,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149103] libre office writer, delete image or image frame causes freeze & crash

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=149103

--- Comment #6 from QA Administrators  ---
Dear Jerry,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148862] Tools Options UI cannot be resized and is too wide

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=148862

--- Comment #3 from QA Administrators  ---
Dear bryce.a.carson,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147597] File crashed when using "Toggle Print Preview"

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147597

--- Comment #3 from QA Administrators  ---
Dear Sion,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147249] cannot change fonts, colors, paragraph, etc etc. the drop down menu doesn't load

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147249

--- Comment #6 from QA Administrators  ---
Dear 11afepa6o6,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 138117] Custom toolbar icons rendered small even on option Large and not at all on option Small

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=138117

--- Comment #6 from QA Administrators  ---
Dear david mccracken,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 144705] LibreOffice Writer and/or Calc show High CPU and "not responding" in Windows 10 Task Manager

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=144705

--- Comment #3 from QA Administrators  ---
Dear Ayjaycee,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137536] Animation for object in presentation mode flashes after finishing Skia (not GDI)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=137536

--- Comment #5 from QA Administrators  ---
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 126034] FILEOPEN DOCX Paragraph border in rotated text box is not rotated with text

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=126034

--- Comment #5 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 122710] PRINT DIALOG: For "Pages to print" field interpret space as separator for a list of distinct pages to print

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=122710

--- Comment #18 from QA Administrators  ---
Dear Ulf Zibis,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113912] UI Leaving dialog open prevents docking sidebar in another window

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=113912

--- Comment #6 from QA Administrators  ---
Dear Emil Tanev,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - dbaccess/source

2022-11-19 Thread Noel Grandin (via logerrit)
 dbaccess/source/ui/uno/copytablewizard.cxx |   68 ++---
 1 file changed, 33 insertions(+), 35 deletions(-)

New commits:
commit 32d3db8d35c7de98bec8e2b6888ad04237be7f35
Author: Noel Grandin 
AuthorDate: Fri Oct 28 11:28:58 2022 +0200
Commit: Aron Budea 
CommitDate: Sun Nov 20 04:23:39 2022 +0100

make ValueTransfer easier to understand

storing references to local variables makes it harder to figure out what
the control flow is doing.

Change-Id: Ifa7fedd6e4be19a0aa8180aa4f754f1811ca44a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141965
Tested-by: Jenkins
Reviewed-by: Noel Grandin 
(cherry picked from commit ca82061c2cad00aeddb17b766063776fee0ee41a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142207
Reviewed-by: Aron Budea 

diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx 
b/dbaccess/source/ui/uno/copytablewizard.cxx
index 583811eef79b..f77fa0e480a0 100644
--- a/dbaccess/source/ui/uno/copytablewizard.cxx
+++ b/dbaccess/source/ui/uno/copytablewizard.cxx
@@ -941,40 +941,39 @@ namespace
 class ValueTransfer
 {
 public:
-ValueTransfer( const sal_Int32& _rSourcePos, const sal_Int32& 
_rDestPos, std::vector< sal_Int32 >&& _rColTypes,
+ValueTransfer( std::vector< sal_Int32 > _rColTypes,
 const Reference< XRow >& _rxSource, const Reference< XParameters 
>& _rxDest )
-:m_rSourcePos( _rSourcePos )
-,m_rDestPos( _rDestPos )
-,m_rColTypes( std::move(_rColTypes) )
+:m_ColTypes( std::move(_rColTypes) )
 ,m_xSource( _rxSource )
 ,m_xDest( _rxDest )
 {
 }
 
 template< typename VALUE_TYPE >
-void transferValue( VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( sal_Int32 ),
+void transferValue( sal_Int32 _nSourcePos, sal_Int32 _nDestPos,
+VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( sal_Int32 ),
 void (SAL_CALL XParameters::*_pSetter)( sal_Int32, VALUE_TYPE ) )
 {
-VALUE_TYPE value( (m_xSource.get()->*_pGetter)( m_rSourcePos ) );
+VALUE_TYPE value( (m_xSource.get()->*_pGetter)( _nSourcePos ) );
 if ( m_xSource->wasNull() )
-m_xDest->setNull( m_rDestPos, m_rColTypes[ m_rSourcePos ] );
+m_xDest->setNull( _nDestPos, m_ColTypes[ _nSourcePos ] );
 else
-(m_xDest.get()->*_pSetter)( m_rDestPos, value );
+(m_xDest.get()->*_pSetter)( _nDestPos, value );
 }
- template< typename VALUE_TYPE >
-void transferComplexValue( VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( 
sal_Int32 ),
+
+template< typename VALUE_TYPE >
+void transferComplexValue( sal_Int32 _nSourcePos, sal_Int32 _nDestPos,
+VALUE_TYPE ( SAL_CALL XRow::*_pGetter )( sal_Int32 ),
 void (SAL_CALL XParameters::*_pSetter)( sal_Int32, const VALUE_TYPE& ) 
)
 {
-const VALUE_TYPE value( (m_xSource.get()->*_pGetter)( m_rSourcePos ) );
+const VALUE_TYPE value( (m_xSource.get()->*_pGetter)( _nSourcePos ) );
 if ( m_xSource->wasNull() )
-m_xDest->setNull( m_rDestPos, m_rColTypes[ m_rSourcePos ] );
+m_xDest->setNull( _nDestPos, m_ColTypes[ _nSourcePos ] );
 else
-(m_xDest.get()->*_pSetter)( m_rDestPos, value );
+(m_xDest.get()->*_pSetter)( _nDestPos, value );
 }
 private:
-const sal_Int32&m_rSourcePos;
-const sal_Int32&m_rDestPos;
-const std::vector< sal_Int32 >m_rColTypes;
+const std::vector< sal_Int32 >  m_ColTypes;
 const Reference< XRow > m_xSource;
 const Reference< XParameters >  m_xDest;
 };
@@ -1142,13 +1141,12 @@ void CopyTableWizard::impl_copyRows_throw( const 
Reference< XResultSet >& _rxSou
 // notify listeners
 m_aCopyTableListeners.notifyEach( ::copyingRow, 
aCopyEvent );
 
-sal_Int32 nDestColumn( 0 );
-sal_Int32 nSourceColumn( 1 );
-ValueTransfer aTransfer( nSourceColumn, nDestColumn, 
std::vector(aSourceColTypes), xRow, xStatementParams );
+sal_Int32 nSourceColumn( 0 );
+ValueTransfer aTransfer( aSourceColTypes, xRow, xStatementParams );
 
 for ( auto const& rColumnPos : aColumnPositions )
 {
-nDestColumn = rColumnPos.first;
+sal_Int32 nDestColumn = rColumnPos.first;
 if ( nDestColumn == COLUMN_POSITION_NOT_FOUND )
 {
 ++nSourceColumn;
@@ -1174,7 +1172,7 @@ void CopyTableWizard::impl_copyRows_throw( const 
Reference< XResultSet >& _rxSou
 {
 case DataType::DOUBLE:
 case DataType::REAL:
-aTransfer.transferValue( ::getDouble, 
::setDouble );
+aTransfer.transferValue( nSourceColumn, nDestColumn, 
::getDouble, ::setDouble );
  

[Libreoffice-bugs] [Bug 152133] New: Stack Protection is not provided for BASIC call to DLL using declare - lib

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152133

Bug ID: 152133
   Summary: Stack Protection is not provided for BASIC call to DLL
using declare - lib
   Product: LibreOffice
   Version: 7.4.2.3 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tanhda...@gmail.com

Description:
When a call is made to a function provided by a declaration with a bad
signature:
Public Declare Function WSAStartup Lib "ws2_32.dll" (ByVal wVersionRequested As
Integer, lpWSAData As wsaData) As Long

-- LibreOffice Calc just crashes.
In a similar situation, MS Excel does not crash, because VBA checks and
corrects the stack.

Steps to Reproduce:
1.Type wsaData
wVersion As Integer
wHighVersion As Integer
szDescription As String * WSA_DescriptionSize
szSystemStatus As String * WSA_SysStatusSize
iMaxSockets As Integer
iMaxUdpDg As Integer
lpVendorInfo As String * 200
End Type

Public Declare Function WSAStartup Lib "ws2_32.dll" (ByVal wVersionRequested As
Integer, lpWSAData As wsaData) As Long

Sub Test()
Dim errCode As Integer
Const wsVer22 = 514
Dim SockInfo As wsaData

errCode = WSAStartup(wsVer22, SockInfo)
Exit Sub


2.Call the sub


Actual Results:
LibreOffice crashes and closes.

Expected Results:
Libre Office does not crash.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
There's not much you can do if the stack is corrupted by a call to an external
DLL. But LO should wrap calls to DLL's declared in BASIC, so that LO itself
doesn't crash.  Stack faults in this situation should either be ignored, or
cause an orderly shutdown.

The stack protection provided by MS VBA makes calls slower, and requires the
use of LastDLLError (because the wrapper code will lose GetLastError), but that
has not been a cause of complaint.

Version: 7.4.2.3 (x86) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-AU (en_AU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145069] The return value of a Basic function is not initialized

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145069

--- Comment #6 from tanh  ---
(In reply to Andreas Heinisch from comment #2)
> From
> https://docs.microsoft.com/en-us/office/vba/language/reference/user-
> interface-help/function-statement
> 
> "If Static isn't used, the value of local variables is not preserved between
> calls."
> 
> So I thought that the value should be cleared. How about recursions?

I've not seen VBA documentation that makes it clear that the name of a function
is a "local" variable. 

But all versions of VBA treat it that way. The name of a function is a local
variable of that function, and is initialised at every call of that function.

Regarding recursion 'static' is not normally used with recursive VBA functions
-- it kind of defeats the purpose in common cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 147951] API returns wrong user path on Windows

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147951

--- Comment #2 from tanh  ---
The obvious way to get %USERPROFILE% 
is 
sTemp=Environ ("USERPROFILE")

I agree that use of Environment variables is bad practice with known security
weekness: for security, LO should provide an object that provides direct access
to the WinAPI or ShellAPI path requests. Does it?

But I'm leery about changing a feature of OO that has been around since V1 just
because some other feature is needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue by default (not as ByRef)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

--- Comment #2 from tanh  ---
In LO, the statement
DummySub (a)

Does NOT create and discard a reference. Rather, it acts the same way as the
CALL syntax


LibreOffice: DummySub(a) is the same as Call DummySub(a).
MS VBA: DummySub (a) is NOT the same as Call DummySub(a)

LibreOffice: DummySub2(a,b) is NOT a syntax error.
MS VBA: DummySub2(a,b) IS a syntax error.
MS VBA: Call DummySub2(a,b) is NOT a syntax error.

LibreOffice: Call DummySub2( (a), b) is the same as Call DummySub2( a,b)
MS VBA: Call DummySub2( (a), b) is NOT the same as Call DummySub2( a,b)

==
sub Test()
Dim a As String,b
a = "X"
call DummySub2((a),b)
MsgBox (a)
End Sub

Sub DummySub2(val As String,b)
val = "Y"
End Sub
==

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151005] With "Option VBASupport 1" arguments should be treated as ByValue by default (not as ByRef)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151005

--- Comment #1 from tanh  ---
In MS VBA, arguments are passed BYREF as default. (Documentation claims that
VB.NET is different).

In MS VBA the test case shown creates a temporary reference by using an
expression

DummySub (a)

The expression (a) is created, referenced, updated to 'Y', and discarded.

Subsequent use of the variable a is not affected by the discarded (expression)


To demonstrate the same behavior using Call syntax:

Call DummySub( (a) )

Wrapping a variable in () creates an expression. The CALL syntax requires call
brackets, which are not expression brackets.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152132] New: Hash Mark Lines (#define) treated as comments in Libre Office Basic

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152132

Bug ID: 152132
   Summary: Hash Mark Lines (#define) treated as comments in Libre
Office Basic
   Product: LibreOffice
   Version: 7.4.2.3 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tanhda...@gmail.com

Description:
#if fred
Is treated as a comment.
It should always be treated as an error.

Steps to Reproduce:
Create new Basic subroutine:
sub Mysub
#if fred
dim a as int
#else
dim a as int
#endif
end sub

Run the sub.
1.Import VBA module containing #if, #else, #endif
2.Run any function in the module
3.

Actual Results:
BASIC syntax error. Variable a already defined.

Expected Results:
Lines starting with # are errors


Reproducible: Always


User Profile Reset: Yes

Additional Info:
It would be really nice if BASIC handled #if, #else the same way VBA 6 or 7 do:
as conditional compilation meta commands.  Some older OO versions handled this
differently, the initial syntax check handled #if as if: for declaration
outside of a function I got "If outside of function or sub is not allowed"

But the present implementation is even worse: #if and #else are silently
ignored when inside a function, so both branches are included.

In VBA back to Office 97, #if allows you to include different branches for
different #defines. There are predefined values ('Win32' etc), and two
different ways of defining values. #if is commonly used to allow different
branches for VBA7 and OSX: it may also be used generally, as for debug builds.

When VBA code is imported into LO, the idiosyncratic treatment of # meta
commands is confusing and unexpected: the lack of documentation contributes to
the problem.

Implementing the feature correctly would be good: implementing the feature in a
minimal way with a clear error message would be good enough.


Version: 7.4.2.3 (x86) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render:
Skia/Raster; VCL: win
Locale: en-AU (en_AU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/quartz vcl/skia vcl/source vcl/unx vcl/win

2022-11-19 Thread Khaled Hosny (via logerrit)
 vcl/inc/font/PhysicalFontFace.hxx  |2 
 vcl/inc/quartz/salgdi.h|2 
 vcl/inc/unx/freetype_glyphcache.hxx|2 
 vcl/inc/win/salgdi.h   |4 -
 vcl/inc/win/winlayout.hxx  |3 +
 vcl/quartz/ctfonts.cxx |2 
 vcl/skia/win/gdiimpl.cxx   |2 
 vcl/source/font/LogicalFontInstance.cxx|2 
 vcl/source/font/PhysicalFontFace.cxx   |2 
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |2 
 vcl/win/gdi/DWriteTextRenderer.cxx |2 
 vcl/win/gdi/salfont.cxx|   63 +
 12 files changed, 47 insertions(+), 41 deletions(-)

New commits:
commit 64d4275b60d50a87fb2bf4dd45be3c28902cec52
Author: Khaled Hosny 
AuthorDate: Sun Nov 20 02:34:26 2022 +0200
Commit: خالد حسني 
CommitDate: Sun Nov 20 02:35:17 2022 +0100

vcl: fix artificial bold and italic on Windows

Move creating DWFontFace to WinFontInstance so that it get proper font
synthesis settings.

Regression from:

commit a80239ede3236c84d7a05d0fbc0f299811fee6c0
Author: Khaled Hosny 
Date:   Sat Nov 19 03:03:15 2022 +0200

vcl: move creating DWFontFace to WinFontFace

Change-Id: Ifba947d8908a37972d723028258500b10ec24cd4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142982
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/inc/font/PhysicalFontFace.hxx 
b/vcl/inc/font/PhysicalFontFace.hxx
index 6e99ae4a098c..96f2533f22fe 100644
--- a/vcl/inc/font/PhysicalFontFace.hxx
+++ b/vcl/inc/font/PhysicalFontFace.hxx
@@ -194,7 +194,7 @@ public:
 return nullptr;
 }
 
-virtual const std::vector& GetVariations() const;
+virtual const std::vector& GetVariations(const 
LogicalFontInstance&) const;
 
 protected:
 mutable hb_face_t* mpHbFace;
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 79ea9e32e0d6..4812404bbc6e 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -72,7 +72,7 @@ public:
 
 hb_blob_t* GetHbTable(hb_tag_t nTag) const override;
 
-const std::vector& GetVariations() const override;
+const std::vector& GetVariations(const 
LogicalFontInstance&) const override;
 
 private:
 CTFontDescriptorRef mxFontDescriptor;
diff --git a/vcl/inc/unx/freetype_glyphcache.hxx 
b/vcl/inc/unx/freetype_glyphcache.hxx
index 4cf982c50a12..5bc1632ccee6 100644
--- a/vcl/inc/unx/freetype_glyphcache.hxx
+++ b/vcl/inc/unx/freetype_glyphcache.hxx
@@ -101,7 +101,7 @@ public:
 virtual hb_face_t* GetHbFace() const override;
 virtual hb_blob_t* GetHbTable(hb_tag_t nTag) const override;
 
-const std::vector& GetVariations() const override;
+const std::vector& GetVariations(const 
LogicalFontInstance&) const override;
 };
 
 class SAL_DLLPUBLIC_RTTI FreetypeFontInstance final : public 
LogicalFontInstance
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 999bb39a1812..f26f1d40f0c9 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -72,11 +72,9 @@ public:
 BYTEGetCharSet() const  { return meWinCharSet; 
}
 BYTEGetPitchAndFamily() const   { return 
mnPitchAndFamily; }
 
-IDWriteFontFace*GetDWFontFace() const;
-
 hb_blob_t*  GetHbTable(hb_tag_t nTag) const override;
 
-const std::vector& GetVariations() const override;
+const std::vector& GetVariations(const 
LogicalFontInstance&) const override;
 
 private:
 sal_IntPtr  mnId;
diff --git a/vcl/inc/win/winlayout.hxx b/vcl/inc/win/winlayout.hxx
index 702bf7bf0b2a..fb8e5a1c6e43 100644
--- a/vcl/inc/win/winlayout.hxx
+++ b/vcl/inc/win/winlayout.hxx
@@ -54,6 +54,8 @@ public:
 
 bool GetGlyphOutline(sal_GlyphId, basegfx::B2DPolyPolygon&, bool) const 
override;
 
+IDWriteFontFace* GetDWFontFace() const;
+
 private:
 explicit WinFontInstance(const WinFontFace&, const 
vcl::font::FontSelectPattern&);
 
@@ -65,6 +67,7 @@ private:
 float m_fScale;
 bool  m_bIsCJKVerticalFont;
 sal_Int32 m_nTmDescent;
+mutable sal::systools::COMReference mxDWFontFace;
 };
 
 class TextOutRenderer
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index c2f6a8a55c00..92fd35fa2cee 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -268,7 +268,7 @@ hb_blob_t* CoreTextFontFace::GetHbTable(hb_tag_t nTag) const
 return pBlob;
 }
 
-const std::vector& CoreTextFontFace::GetVariations() const
+const std::vector& CoreTextFontFace::GetVariations(const 
LogicalFontInstance&) const
 {
 CTFontRef pFont = CTFontCreateWithFontDescriptor(mxFontDescriptor, 0.0, 
nullptr);
 
diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index a9df26cb53a1..d063b440cf31 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -135,7 +135,7 @@ 

[Libreoffice-bugs] [Bug 101631] VBA function parameter is passed by reference by default

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=101631

--- Comment #11 from tanh  ---
(In reply to Aron Budea from comment #1)
> The direct reason for the self-modifying behavior is that function
> "stableford" modifies the "score" parameter, which is apparently passed by
> reference.
> 
> I can't tell if it's the correct behavior or not, got confused by different
> VB-related MS resources that state contradicting things:
> https://msdn.microsoft.com/en-us/library/aa263527(v=vs.60).aspx "Passing by
> reference is the default in Visual Basic."
> https://msdn.microsoft.com/en-us/library/ddck1z30.aspx "The default in
> Visual Basic is to pass arguments by value."
> They're for different VB versions, and not VBA, either, but it's still weird.
> 
> Until this is clarified, as a workaround you can copy the parameter to a
> local variable, and modify that.

Just for note, the 'Visual Basic" referred to in the .NET MS resource "The
default in Visual Basic is to pass arguments by value", is VB.Net

VB.net is to VBA as c# is to c, only less so.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145532] Sheet copy from doc1 to doc2 breaks "Defined Range" linkage

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145532

dev...@realcom.co.uk changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145532] Sheet copy from doc1 to doc2 breaks "Defined Range" linkage

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145532

dev...@realcom.co.uk changed:

   What|Removed |Added

 CC||dev...@realcom.co.uk

--- Comment #3 from dev...@realcom.co.uk ---
Created attachment 183684
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183684=edit
small ods with sample Defined Range use and route to failure

Attached is a sample ods file, as requested.
The file contains comments to identify 'path to failure' to recreate the fault. 

In essence, any change to the sheet population (copy, move, delete but not
rename) results in the (inter-sheet) Defined Range(s) relationships becoming
corrupt.

Probably stems from the internal sheet identity being inadequately
robust/independent.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152131] New: Dragging document from window header bar to another location copies wrong document version

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152131

Bug ID: 152131
   Summary: Dragging document from window header bar to another
location copies wrong document version
   Product: LibreOffice
   Version: unspecified
  Hardware: x86 (IA32)
OS: macOS (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: andrewjsk...@gmail.com

If you use the MacOS feature to drag the document icon in the Window title bar
to another location (such as a folder or an email), if the same document was
loaded under a particular filename and then saved using Save As... to a
different filename, the unamended document under the original filename gets
dragged, as oppposed to the most recent version.  

To reproduce this bug:

1. Create a new text document in LibreOffice Writer. Type "this is the original
document" into the document. 

2. Save it under the name "Test.odt".

3. Type "And this is an amendment" into the document.

4. Save it under the name "Test001.odt".

5. Drag the document icon from the title bar of the window to another location
(such as the desktop). You will find that the dragged document is "Test.odt"
and not "Test001.odt". If you open the dragged file, you will see that it does
not contain the words "And this is an amendment". 


The correct behaviour would be for the dragged document to be Test001.odt, and
for it to contain the words "And this is an amendment". 

Thanks


Andrew

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: offapi/com

2022-11-19 Thread Andrea Gelmini (via logerrit)
 offapi/com/sun/star/chart2/XChartTypeTemplate.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 16a7e944ab1b318fafb7dd48d48379168403d2e8
Author: Andrea Gelmini 
AuthorDate: Sat Nov 19 17:13:48 2022 +0100
Commit: Julien Nabet 
CommitDate: Sat Nov 19 23:02:12 2022 +0100

Fix typo

Change-Id: Iaa40db0f7799c70f39bb74d9768f84ff236502ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142977
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/offapi/com/sun/star/chart2/XChartTypeTemplate.idl 
b/offapi/com/sun/star/chart2/XChartTypeTemplate.idl
index 147343d4b685..994f5e9ea876 100644
--- a/offapi/com/sun/star/chart2/XChartTypeTemplate.idl
+++ b/offapi/com/sun/star/chart2/XChartTypeTemplate.idl
@@ -164,7 +164,7 @@ interface XChartTypeTemplate : 
::com::sun::star::uno::XInterface
  Then I removed the whole XChartTypeTemplate interface in
  commit 58766f997d59e4684f2887fd8cdeb12d2f8a9366.
  Which turned out to be a bad idea, so I restored it.
- I restored it in this form because I want to restore binary compatibily 
with vtable
+ I restored it in this form because I want to restore binary compatibility 
with vtable
  layout, but I don't want to restore the XDataInterpreter stuff, which was 
not
  useful for external use.
 */


[Libreoffice-bugs] [Bug 152130] New: user defined calc chart names not reflected in e.g. BASIC macros

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152130

Bug ID: 152130
   Summary: user defined calc chart names not reflected in e.g.
BASIC macros
   Product: LibreOffice
   Version: 7.4.2.3 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: trowelandmatt...@yahoo.co.uk

Description:
if a chart name is changed from defaults the default  name is retained 'in
background' of API and the chart can not be accsed by the new user name:

e.g. 
for single chart (Object 1) renamed in Calc GUI to (Chart1)
:
getByIndex(0) > gets the chart
[getByIndex(0)] .Name > gets the original default name (Object 1) 
and getByName("Object 1") also works to get the chart
but
getByName("Chart1") fails ('Chart1 not found')



Steps to Reproduce:
1.see above
2.
3.

Actual Results:
new user/GUI defined name for chart not found e.g. with basic macro  

Expected Results:
user defined chart names should be find-able with e.g. getByName , and the old
default names should not remain 'in background' being used by the API

also; getByIndex can be awkward because index positions of new vs copied charts
is not intuitive


Reproducible: Always


User Profile Reset: No

Additional Info:

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47679] Copy + Paste changes "OpenSymbol" font to "StarSymbol"

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47679

--- Comment #16 from V Stuart Foote  ---

> or a fully Open Office PUA string

s/Open Office/OpenSymbol

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 47679] Copy + Paste changes "OpenSymbol" font to "StarSymbol"

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=47679

--- Comment #15 from V Stuart Foote  ---
Testing attachment 163496 with
Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bcf09f9a9bde21aac1302cbead2b23822458
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

For string U+20AC U+2021 U+2020 U+00BB

or a fully Open Office PUA string, e.g. U+e11aU+e691U+e690U+e593U+e594

Confirm handling of the copy/paste and copy/paste special (unformatted or RTF)
is now consistent. 

But I do see that the handling of PUA glyph fallback around OpenSymbol is doing
some odd things with the sample document prepared with 7.0.0

Seems font "selection" has changed considerably (between 7.0.0 and 7.5.0) on
Windows for fallback mapping U+f080 U+f087 U+f086 U+f0bb PUA -- but I think
that is to be expected as those specific codepoints are not (never were?)
present in OpenSymbol PUA space and got StarSymbol/StarBat mappings, and the
test document as structured is no longer applicable for testing OpenSymbol PUA.

Better OpenSymbol specific PUA string (no StarBat, StarSymbol lookups) might
be:
U+e11aU+e691U+e690U+e593U+e594



-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152116] Navigator: State of outline headings is lost when navigator is closed then reopened

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152116

--- Comment #4 from V Stuart Foote  ---
(In reply to Eyal Rozenberg from comment #3)
> (In reply to R. Green from comment #0)
> I can't reproduce this with a 7.5 build:

Note: "Close then reopen"  not just collapse the SB deck, please recheck.  No
issue if the SB deck is only collapsed and expanded.  Only with a full close /
open of the SB

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152116] Navigator: State of outline headings is lost when navigator is closed then reopened

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152116

--- Comment #4 from V Stuart Foote  ---
(In reply to Eyal Rozenberg from comment #3)
> (In reply to R. Green from comment #0)
> I can't reproduce this with a 7.5 build:

Note: "Close then reopen"  not just collapse the SB deck, please recheck.  No
issue if the SB deck is only collapsed and expanded.  Only with a full close /
open of the SB

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151846] LibreOffice 7.4 missing several imports in com.sun.star.chart2 namespace

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151846

--- Comment #9 from flywire  ---
(In reply to Commit Notification from comment #8)
> Noel Grandin committed a patch related to this issue.
> It has been pushed to "master":

Doesn't look like a Resolved Fix to me. Seems a commit unintentionally broke
functionality and dev is only restoring code required for a specific example.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152129] New: Cannot move shape to left or upper adjacent position using (some) base points

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152129

Bug ID: 152129
   Summary: Cannot move shape to left or upper adjacent position
using (some) base points
   Product: LibreOffice
   Version: 6.4.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Draw
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: luk_dha...@yahoo.co.uk

Description:
Moving a shape to one of its adjacent positions can normally be done by copying
the X- or Y-coordinate to itself after selecting another base point. For
example, to move the shape to its right, you can select the top right base
point, copy the X-coordinate, then select the top left base point, then paste
the new X value. Now, this trick doesn't work anymore when moving to the left
or upper direction. It does still work however for the right and lower
directions.


Steps to Reproduce:
1. Place any shape, e.g. a rectangle.
2. Select RMB > "Position and Size...".
3. Notice the default base point is top left.
4. Copy the X-coordinate.
5. Select the top right base point (position).
6. Paste the value into the X-coordinate.
7. Click OK.

Actual Results:
The shape does not move.

Expected Results:
The shape should have moved to the left.


Reproducible: Always


User Profile Reset: No

Additional Info:
It does work when selecting the middle or lower left base point instead. So
there's an easy workaround.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152128] New: backspace key does not work when creating a new address block in mail merge

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152128

Bug ID: 152128
   Summary: backspace key does not work when creating a new
address block in mail merge
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ch...@chriscurvey.com

Description:
1. Start the Mail Merge Wizard
2. Make it a "letter"
3. Choose a spreadsheet of addresses
4. Under "address block" choose "more"
5. Create a new address block
6. Type some characters in the text box
7. Try to erase the characters using backspace

You will be unable to do so.  

Steps to Reproduce:
see description

Actual Results:
letters are not deleted when hitting the backspace key

Expected Results:
letters should be deleted when I hit the backspace key


Reproducible: Always


User Profile Reset: No

Additional Info:
filing bugs here is painful

I like Jello

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152122] Improve Help Online (/text/shared/01/01010300.xhp)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152122

--- Comment #2 from BogdanB  ---
Another prove that "Labels" need to change to "Business Cards" is here (first
paragraph):

"Contains contact information for business cards that use a layout from a
'Business Card, Work' category. Business card layouts are selected on the
Business Cards tab." --> There is no "Business Card" tab anywhere in UI, it is
named the same like for Labels.

https://help.libreoffice.org/7.5/en-US/text/shared/01/01010304.html?=SHARED=UNIX

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 143148] Use pragma once instead of include guards (Episode 2: Endgame)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=143148

--- Comment #61 from Commit Notification 
 ---
Siddharth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9cac01b4f19c8fc3adb1a19a71b2f214a1586d8f

tdf#143148 Use pragma once instead of include guards

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc sw/source

2022-11-19 Thread Siddharth (via logerrit)
 sw/inc/unostyle.hxx  |4 +---
 sw/source/ui/vba/vbaview.hxx |4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

New commits:
commit 9cac01b4f19c8fc3adb1a19a71b2f214a1586d8f
Author: Siddharth 
AuthorDate: Wed Nov 9 11:30:33 2022 +0530
Commit: Ilmari Lauhakangas 
CommitDate: Sat Nov 19 18:58:02 2022 +0100

tdf#143148 Use pragma once instead of include guards

Change-Id: I50c2c0f202780d06b556ae82b51bab5c3f79d72e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142498
Tested-by: Jenkins
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/sw/inc/unostyle.hxx b/sw/inc/unostyle.hxx
index 7091fd603602..2c936486032e 100644
--- a/sw/inc/unostyle.hxx
+++ b/sw/inc/unostyle.hxx
@@ -16,8 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_SW_INC_UNOSTYLE_HXX
-#define INCLUDED_SW_INC_UNOSTYLE_HXX
+#pragma once
 
 #include 
 #include 
@@ -391,6 +390,5 @@ class SwXTextCellStyle final : public cppu::WeakImplHelper
 
 static css::uno::Reference 
CreateXTextCellStyle(SwDocShell* pDocShell, const OUString& sName);
 };
-#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/ui/vba/vbaview.hxx b/sw/source/ui/vba/vbaview.hxx
index 7ac6003ddfc3..66d59e61b739 100644
--- a/sw/source/ui/vba/vbaview.hxx
+++ b/sw/source/ui/vba/vbaview.hxx
@@ -16,8 +16,7 @@
  *   except in compliance with the License. You may obtain a copy of
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
-#ifndef INCLUDED_SW_SOURCE_UI_VBA_VBAVIEW_HXX
-#define INCLUDED_SW_SOURCE_UI_VBA_VBAVIEW_HXX
+#pragma once
 
 #include 
 #include 
@@ -58,6 +57,5 @@ public:
 virtual OUString getServiceImplName() override;
 virtual css::uno::Sequence getServiceNames() override;
 };
-#endif // INCLUDED_SW_SOURCE_UI_VBA_VBAVIEW_HXX
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


[Libreoffice-bugs] [Bug 145532] Sheet copy from doc1 to doc2 breaks "Defined Range" linkage

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=145532

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org
 Status|UNCONFIRMED |NEEDINFO
 Whiteboard| QA:needsComment|
 Ever confirmed|0   |1

--- Comment #2 from Buovjaga  ---
(In reply to devMgr from comment #0)
> Steps to Reproduce:
> 1.Create Doc1 with Defined Range specs and valid formulae that use the D.R.s
> 2.Create Doc2 with distinct Defined Range specs and valid formulae that use
> the D.R.s

Please attach minimal example spreadsheets at this step, so we can quickly
reproduce the problem.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the documents.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152127] Improve Help Online (/text/shared/01/01010303.xhp)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152127

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
   Assignee|libreoffice-b...@lists.free |buzea.bog...@libreoffice.or
   |desktop.org |g
 Status|UNCONFIRMED |ASSIGNED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152127] New: Improve Help Online (/text/shared/01/01010303.xhp)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152127

Bug ID: 152127
   Summary: Improve Help Online (/text/shared/01/01010303.xhp)
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: buzea.bog...@libreoffice.org
CC: olivier.hal...@libreoffice.org

Description:
After I enter my data into Tools - Options - LibreOfficeDev - User Data, in the
File - New - Business Card - Private tab I get "Country/state:" and 2 input for
this fields. In Writer the order is right, first the country, than the state.
On help page they are reverse and if you fill the data based on Help, you can
consider that first is the state, than the country.

--> Country and State need to change the order in the Help Page
https://help.libreoffice.org/7.5/en-US/text/shared/01/01010303.html?=SHARED=UNIX


Steps to Reproduce:
-

Actual Results:
-

Expected Results:
-


Reproducible: Always


User Profile Reset: No

Additional Info:
-

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152123] Non-correct display of subscript and italic characters when importing .svg-files into libreoffice writer

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152123

--- Comment #3 from Eyal Rozenberg  ---
Created attachment 183683
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183683=edit
Partial reproduction on sample document

I can only partially reproduce the bug:

* Italicization is ok.
* Getting regular size instead of subscript
* Subscript horizontal placement is a little off: Too much space before the `t`
on the middle line of the example.

Build info:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bcf09f9a9bde21aac1302cbead2b23822458
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Calc: threaded

(build is from earlier today)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152119] Dropdown content control for RTL fields no longer selectable by mouse

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152119

--- Comment #2 from Eyal Rozenberg  ---
(In reply to Hossein from comment #0)

Can't reproduce with:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: bcf09f9a9bde21aac1302cbead2b23822458
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US
Build timestamp: 2022-11-19_05.43.41

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: desktop/qa desktop/source include/LibreOfficeKit sfx2/source

2022-11-19 Thread Szymon Kłos (via logerrit)
 desktop/qa/desktop_lib/test_desktop_lib.cxx |5 -
 desktop/source/lib/init.cxx |  113 +---
 include/LibreOfficeKit/LibreOfficeKit.h |4 
 include/LibreOfficeKit/LibreOfficeKit.hxx   |8 +
 sfx2/source/view/lokhelper.cxx  |6 -
 5 files changed, 103 insertions(+), 33 deletions(-)

New commits:
commit 931e3d204e59ccb2e9c479477e6e66b2c098924f
Author: Szymon Kłos 
AuthorDate: Mon Aug 29 09:34:53 2022 +0200
Commit: Szymon Kłos 
CommitDate: Sat Nov 19 18:16:16 2022 +0100

lok: masterpage: Introduce mode property to tile rendering

This is needed for Impress which can have slides in
two Edit Modes: Master Page and Page.

Change-Id: I3eca0f51ba7970e793026d1ac6aa09b19b7a904b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137869
Reviewed-by: Ashod Nakashian 
Tested-by: Szymon Kłos 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142969
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index dd84323f6c9b..e7762753775f 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -2275,7 +2275,7 @@ void DesktopLOKTest::testPaintPartTile()
 
 // Call paintPartTile() to paint the second part (in whichever view it 
finds suitable for this).
 unsigned char pPixels[256 * 256 * 4];
-pDocument->m_pDocumentClass->paintPartTile(pDocument, pPixels, 1, 256, 
256, 0, 0, 256, 256);
+pDocument->m_pDocumentClass->paintPartTile(pDocument, pPixels, 1, 0, 256, 
256, 0, 0, 256, 256);
 
 // Type again.
 Scheduler::ProcessEventsToIdle();
@@ -3624,10 +3624,11 @@ void DesktopLOKTest::testABI()
  offsetof(struct _LibreOfficeKitDocumentClass, 
sendContentControlEvent));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(65), offsetof(struct 
_LibreOfficeKitDocumentClass, getSelectionTypeAndText));
 CPPUNIT_ASSERT_EQUAL(documentClassOffset(66), offsetof(struct 
_LibreOfficeKitDocumentClass, getDataArea));
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(67), offsetof(struct 
_LibreOfficeKitDocumentClass, getEditMode));
 
 // Extending is fine, update this, and add new assert for the offsetof the
 // new method
-CPPUNIT_ASSERT_EQUAL(documentClassOffset(67), sizeof(struct 
_LibreOfficeKitDocumentClass));
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(68), sizeof(struct 
_LibreOfficeKitDocumentClass));
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 1163ef2a638f..766248ef00ef 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -998,6 +998,7 @@ static void doc_selectPart(LibreOfficeKitDocument* pThis, 
int nPart, int nSelect
 static void doc_moveSelectedParts(LibreOfficeKitDocument* pThis, int 
nPosition, bool bDuplicate);
 static char* doc_getPartName(LibreOfficeKitDocument* pThis, int nPart);
 static void doc_setPartMode(LibreOfficeKitDocument* pThis, int nPartMode);
+static int doc_getEditMode(LibreOfficeKitDocument* pThis);
 static void doc_paintTile(LibreOfficeKitDocument* pThis,
   unsigned char* pBuffer,
   const int nCanvasWidth, const int nCanvasHeight,
@@ -1013,6 +1014,7 @@ static void 
doc_paintTileToCGContext(LibreOfficeKitDocument* pThis,
 static void doc_paintPartTile(LibreOfficeKitDocument* pThis,
   unsigned char* pBuffer,
   const int nPart,
+  const int nMode,
   const int nCanvasWidth, const int nCanvasHeight,
   const int nTilePosX, const int nTilePosY,
   const int nTileWidth, const int nTileHeight);
@@ -1269,6 +1271,7 @@ LibLODocument_Impl::LibLODocument_Impl(uno::Reference 
 xC
 m_pDocumentClass->moveSelectedParts = doc_moveSelectedParts;
 m_pDocumentClass->getPartName = doc_getPartName;
 m_pDocumentClass->setPartMode = doc_setPartMode;
+m_pDocumentClass->getEditMode = doc_getEditMode;
 m_pDocumentClass->paintTile = doc_paintTile;
 #ifdef IOS
 m_pDocumentClass->paintTileToCGContext = doc_paintTileToCGContext;
@@ -3641,6 +3644,23 @@ static void doc_setPartMode(LibreOfficeKitDocument* 
pThis,
 }
 }
 
+static int doc_getEditMode(LibreOfficeKitDocument* pThis)
+{
+comphelper::ProfileZone aZone("doc_getEditMode");
+
+SolarMutexGuard aGuard;
+SetLastExceptionMsg();
+
+ITiledRenderable* pDoc = getTiledRenderable(pThis);
+if (!pDoc)
+{
+SetLastExceptionMsg("Document doesn't support tiled rendering");
+return 0;
+}
+
+return pDoc->getEditMode();
+}
+
 static void doc_paintTile(LibreOfficeKitDocument* pThis,
   unsigned char* pBuffer,
  

[Libreoffice-commits] core.git: cui/qa cui/source cui/uiconfig include/svx svx/source

2022-11-19 Thread Maxim Monastirsky (via logerrit)
 cui/qa/unit/cui-dialogs-test.cxx |3 
 cui/source/dialogs/sdrcelldlg.cxx|   43 +
 cui/source/factory/dlgfact.cxx   |4 
 cui/source/factory/dlgfact.hxx   |2 
 cui/source/inc/paragrph.hxx  |8 +
 cui/source/inc/sdrcelldlg.hxx|2 
 cui/source/tabpages/paragrph.cxx |   40 -
 cui/uiconfig/ui/formatcellsdialog.ui |  151 +--
 cui/uiconfig/ui/paragalignpage.ui|   11 ++
 include/svx/svxdlg.hxx   |2 
 svx/source/table/tablecontroller.cxx |2 
 11 files changed, 244 insertions(+), 24 deletions(-)

New commits:
commit 553cfbfc9e74a03fe02a58e9aa6076fc1dddeb7b
Author: Maxim Monastirsky 
AuthorDate: Tue Oct 4 16:05:06 2022 +0300
Commit: Maxim Monastirsky 
CommitDate: Sat Nov 19 18:13:54 2022 +0100

Prepare the dialog for cell style editing

Change-Id: I54ec1486f49f240e1ab88662b9d1b0b741cf8878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142905
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky 

diff --git a/cui/qa/unit/cui-dialogs-test.cxx b/cui/qa/unit/cui-dialogs-test.cxx
index f4f73facbaa6..cf8c302fc209 100644
--- a/cui/qa/unit/cui-dialogs-test.cxx
+++ b/cui/qa/unit/cui-dialogs-test.cxx
@@ -69,7 +69,8 @@ VclPtr 
CuiDialogsTest::createDialogByID(sal_uInt32 nID)
 {
 case 0: // "cui/ui/formatcellsdialog.ui"
 {
-pReturnDialog = mpFact->CreateSvxFormatCellsDialog(nullptr, 
mxAttr.get(), *mxModel);
+pReturnDialog
+= mpFact->CreateSvxFormatCellsDialog(nullptr, mxAttr.get(), 
*mxModel, true);
 break;
 }
 
diff --git a/cui/source/dialogs/sdrcelldlg.cxx 
b/cui/source/dialogs/sdrcelldlg.cxx
index fda8b4ce1385..3afbc0f694d3 100644
--- a/cui/source/dialogs/sdrcelldlg.cxx
+++ b/cui/source/dialogs/sdrcelldlg.cxx
@@ -21,10 +21,15 @@
 #include 
 #include 
 #include 
+#include 
+#include 
+#include 
+#include 
+#include 
 #include 
 
-SvxFormatCellsDialog::SvxFormatCellsDialog(weld::Window* pParent, const 
SfxItemSet* pAttr, const SdrModel& rModel)
-: SfxTabDialogController(pParent, "cui/ui/formatcellsdialog.ui", 
"FormatCellsDialog", pAttr)
+SvxFormatCellsDialog::SvxFormatCellsDialog(weld::Window* pParent, const 
SfxItemSet* pAttr, const SdrModel& rModel, bool bStyle)
+: SfxTabDialogController(pParent, "cui/ui/formatcellsdialog.ui", 
"FormatCellsDialog", pAttr, bStyle)
 , mrOutAttrs(*pAttr)
 , mpColorTab(rModel.GetColorList())
 , mnColorTabState ( ChangeType::NONE )
@@ -37,7 +42,29 @@ SvxFormatCellsDialog::SvxFormatCellsDialog(weld::Window* 
pParent, const SfxItemS
 AddTabPage("effects", RID_SVXPAGE_CHAR_EFFECTS);
 AddTabPage("border", RID_SVXPAGE_BORDER );
 AddTabPage("area", RID_SVXPAGE_AREA);
-AddTabPage("shadow", SvxShadowTabPage::Create, nullptr);
+
+if (bStyle)
+{
+AddTabPage("position", RID_SVXPAGE_CHAR_POSITION);
+AddTabPage("highlight", RID_SVXPAGE_BKG);
+AddTabPage("indentspacing", RID_SVXPAGE_STD_PARAGRAPH);
+AddTabPage("alignment", SvxParaAlignTabPage::Create, 
SvxParaAlignTabPage::GetSdrRanges);
+RemoveTabPage("shadow");
+}
+else
+{
+RemoveTabPage("position");
+RemoveTabPage("highlight");
+RemoveTabPage("indentspacing");
+RemoveTabPage("alignment");
+AddTabPage("shadow", SvxShadowTabPage::Create, nullptr);
+RemoveStandardButton();
+}
+
+if (bStyle && SvtCJKOptions::IsAsianTypographyEnabled())
+AddTabPage("asian", RID_SVXPAGE_PARA_ASIAN);
+else
+RemoveTabPage("asian");
 }
 
 void SvxFormatCellsDialog::PageCreated(const OString& rId, SfxTabPage )
@@ -62,6 +89,16 @@ void SvxFormatCellsDialog::PageCreated(const OString& rId, 
SfxTabPage )
 static_cast(rPage).SetColorList( mpColorTab );
 static_cast(rPage).SetColorChgd(  );
 }
+else if (rId == "alignment")
+{
+static_cast(rPage).EnableSdrVertAlign();
+}
+else if (rId == "highlight")
+{
+SfxAllItemSet aSet(*(GetInputSetImpl()->GetPool()));
+
aSet.Put(SfxUInt32Item(SID_FLAG_TYPE,static_cast(SvxBackgroundTabFlags::SHOW_CHAR_BKGCOLOR)));
+rPage.PageCreated(aSet);
+}
 else
 SfxTabDialogController::PageCreated(rId, rPage);
 }
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index fb61dafcecbb..930452d64d09 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -1428,9 +1428,9 @@ VclPtr 
AbstractDialogFactory_Impl::CreateLinksDialog(wel
 return VclPtr::Create(std::move(xLinkDlg));
 }
 
-VclPtr 
AbstractDialogFactory_Impl::CreateSvxFormatCellsDialog(weld::Window* pParent, 
const SfxItemSet* pAttr, const SdrModel& rModel)
+VclPtr 
AbstractDialogFactory_Impl::CreateSvxFormatCellsDialog(weld::Window* pParent, 
const SfxItemSet* pAttr, const SdrModel& rModel, bool bStyle)
 {
-return 
VclPtr::Create(std::make_shared(pParent,
 

[Libreoffice-bugs] [Bug 150657] CALC Chart elements disappear when the data columns are hidden

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150657

--- Comment #8 from Colin  ---
(In reply to Colin from comment #7)
> (In reply to Stéphane Guillou (stragu) from comment #6)
> > Thanks Colin.
> > 
> 
> > I am finding it hard to test the issue you are describing.
> > Could you please:
> > 
> > - Describe the simplest series of precise steps to reproduce the issue,
> > starting with which attachment to use
> 
> Hi Stéphane
> 
Oops, forgot to mention that you may wish to focus row 4 by clicking any cell
in row 3 and then a down arrow
My bad

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 43808] [META] Right-To-Left and Complex Text Layout language issues (RTL/CTL)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=43808

Eyal Rozenberg  changed:

   What|Removed |Added

 Depends on||152119


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152119
[Bug 152119] Dropdown content control for RTL fields no longer selectable by
mouse
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152119] Dropdown content control for RTL fields no longer selectable by mouse

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152119

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||43808


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=43808
[Bug 43808] [META] Right-To-Left and Complex Text Layout language issues
(RTL/CTL)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150657] CALC Chart elements disappear when the data columns are hidden

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=150657

Colin  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #7 from Colin  ---
(In reply to Stéphane Guillou (stragu) from comment #6)
> Thanks Colin.
> 

> I am finding it hard to test the issue you are describing.
> Could you please:
> 
> - Describe the simplest series of precise steps to reproduce the issue,
> starting with which attachment to use

Hi Stéphane

With the file Chart Error
Ensure group G is unhidden
Double click the chart to activate the chart editing ribbon
Select Data Range for editing
Edit the two range values so that they both commence on row 5 as opposed to row
4
Hide Group G
The chart elements should now have disappeared
Now the image of the two edit panes should help you to realise that the data
series parameter (Right click one of the data elements in the chart) to hide or
include the hidden cells is being corrupted by the edit process -  It presents
on screen as checked to include hidden cells but ignores the parameter.
changing the flag, saving, accessing the flag changing it back again will force
it to behave as expected

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152116] Navigator: State of outline headings is lost when navigator is closed then reopened

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152116

--- Comment #3 from Eyal Rozenberg  ---
(In reply to R. Green from comment #0)
I can't reproduce this with a 7.5 build:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2486d99c6053af1414117faac2c0db18c0d344c4
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

Also, for those trying to reproduce: Increase the maximum heading level
represented in the Navigator to 4, otherwise you won't see any subheadings.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152116] Navigator: State of outline headings is lost when navigator is closed then reopened

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152116

--- Comment #3 from Eyal Rozenberg  ---
(In reply to R. Green from comment #0)
I can't reproduce this with a 7.5 build:

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2486d99c6053af1414117faac2c0db18c0d344c4
CPU threads: 4; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-IL (en_IL); UI: en-US

Also, for those trying to reproduce: Increase the maximum heading level
represented in the Navigator to 4, otherwise you won't see any subheadings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: desktop/source

2022-11-19 Thread Szymon Kłos (via logerrit)
 desktop/source/lib/init.cxx |   18 +-
 1 file changed, 17 insertions(+), 1 deletion(-)

New commits:
commit bac26f91ae930902c336b1e5ceb08e1ae5de8d8a
Author: Szymon Kłos 
AuthorDate: Mon Nov 14 16:11:55 2022 +0100
Commit: Szymon Kłos 
CommitDate: Sat Nov 19 17:44:34 2022 +0100

lok: masterpage: disable callbacks on painting

We did that only for original view, but we need to disable
callbacks for used view - so when we switch mode or part it
will not send the notification to the client.

Bug fixed by this patch:
1. open impress in two LOK sessions
2. A enters MasterPage mode
3. B switched slide
4. A exits MasterPage mode

result: A was switched to the slide selected by B

Change-Id: I7dde8bb4c73862813d064319922aba4c4b727db9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142716
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142966
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 41f05517082f..1163ef2a638f 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -3817,7 +3817,8 @@ static void doc_paintPartTile(LibreOfficeKitDocument* 
pThis,
 {
 // Text documents have a single coordinate system; don't change part.
 int nOrigPart = 0;
-const bool isText = (doc_getDocumentType(pThis) == LOK_DOCTYPE_TEXT);
+const int aType = doc_getDocumentType(pThis);
+const bool isText = (aType == LOK_DOCTYPE_TEXT);
 int nViewId = nOrigViewId;
 int nLastNonEditorView = nViewId;
 if (!isText)
@@ -3853,6 +3854,14 @@ static void doc_paintPartTile(LibreOfficeKitDocument* 
pThis,
 doc_setView(pThis, nLastNonEditorView);
 }
 
+// Disable callbacks while we are painting - after setting the view
+if (nViewId != nOrigViewId && nViewId >= 0)
+{
+const auto handlerIt = 
pDocument->mpCallbackFlushHandlers.find(nViewId);
+if (handlerIt != pDocument->mpCallbackFlushHandlers.end())
+handlerIt->second->disableCallbacks();
+}
+
 nOrigPart = doc_getPart(pThis);
 if (nPart != nOrigPart)
 {
@@ -3880,6 +3889,13 @@ static void doc_paintPartTile(LibreOfficeKitDocument* 
pThis,
 }
 if (!isText && nViewId != nOrigViewId)
 {
+if (nViewId >= 0)
+{
+const auto handlerIt = 
pDocument->mpCallbackFlushHandlers.find(nViewId);
+if (handlerIt != pDocument->mpCallbackFlushHandlers.end())
+handlerIt->second->enableCallbacks();
+}
+
 doc_setView(pThis, nOrigViewId);
 }
 }


[Libreoffice-bugs] [Bug 152083] Ligatures are incorrectly reversed opening RTL PDF files

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152083

Kevin Suo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152083] Ligatures are incorrectly reversed opening RTL PDF files

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152083

--- Comment #2 from Kevin Suo  ---
The below change on gerrit could fix this issue:
https://gerrit.libreoffice.org/c/core/+/142978

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103239] [META] Toolbars bugs and enhancements

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103239
Bug 103239 depends on bug 114505, which changed state.

Bug 114505 Summary: Changing icon theme while in RTL mode causes flipped icons 
in toolbar to misbehave
https://bugs.documentfoundation.org/show_bug.cgi?id=114505

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=129661
Bug 129661 depends on bug 114505, which changed state.

Bug 114505 Summary: Changing icon theme while in RTL mode causes flipped icons 
in toolbar to misbehave
https://bugs.documentfoundation.org/show_bug.cgi?id=114505

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114505] Changing icon theme while in RTL mode causes flipped icons in toolbar to misbehave

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=114505

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #8 from Maxim Monastirsky  ---


*** This bug has been marked as a duplicate of bug 149956 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sc/source

2022-11-19 Thread Szymon Kłos (via logerrit)
 sc/source/ui/inc/inscldlg.hxx  |1 -
 sc/source/ui/miscdlgs/inscldlg.cxx |3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 325bab6a92921a0356cc3e1c66f14ad0c6200d85
Author: Szymon Kłos 
AuthorDate: Wed Nov 2 18:40:09 2022 +0100
Commit: Szymon Kłos 
CommitDate: Sat Nov 19 16:45:39 2022 +0100

Dont use equal name for label and widget

Change-Id: I71b052aff4317b416f0c02bde549461b64f1a6f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142181
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Michael Meeks 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142968
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sc/source/ui/inc/inscldlg.hxx b/sc/source/ui/inc/inscldlg.hxx
index d159c65cd8ac..b44bfb60baa9 100644
--- a/sc/source/ui/inc/inscldlg.hxx
+++ b/sc/source/ui/inc/inscldlg.hxx
@@ -30,7 +30,6 @@ private:
 std::unique_ptr m_xBtnCellsRight;
 std::unique_ptr m_xBtnInsRow;
 std::unique_ptr m_xBtnInsCol;
-std::unique_ptr m_xLbCellsRight;
 
 public:
 ScInsertCellDlg(weld::Window* pParent, bool bDisallowCellMove);
diff --git a/sc/source/ui/miscdlgs/inscldlg.cxx 
b/sc/source/ui/miscdlgs/inscldlg.cxx
index ac97c6ac3578..e077724f4264 100644
--- a/sc/source/ui/miscdlgs/inscldlg.cxx
+++ b/sc/source/ui/miscdlgs/inscldlg.cxx
@@ -32,11 +32,10 @@ ScInsertCellDlg::ScInsertCellDlg(weld::Window* pParent, 
bool bDisallowCellMove)
 , m_xBtnCellsRight(m_xBuilder->weld_radio_button("right"))
 , m_xBtnInsRow(m_xBuilder->weld_radio_button("rows"))
 , m_xBtnInsCol(m_xBuilder->weld_radio_button("cols"))
-, m_xLbCellsRight(m_xBuilder->weld_label("right"))
 {
 const ScViewData* pViewData = ScDocShell::GetViewData();
 if (pViewData && 
pViewData->GetDocument().IsLayoutRTL(pViewData->GetTabNo()))
-m_xLbCellsRight->set_label(ScResId(SCSTR_INSERT_RTL));
+m_xBtnCellsRight->set_label(ScResId(SCSTR_INSERT_RTL));
 
 if (bDisallowCellMove)
 {


[Libreoffice-commits] core.git: sd/source

2022-11-19 Thread Szymon Kłos (via logerrit)
 sd/source/ui/view/drviews1.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2dd51938908b9856bd1ad4b252cd60805262baa5
Author: Szymon Kłos 
AuthorDate: Tue Nov 15 16:49:15 2022 +0100
Commit: Szymon Kłos 
CommitDate: Sat Nov 19 16:44:21 2022 +0100

lok: masterpage: don't switch page on mode change

Go back to the last used page when closing MasterPage.
There was a bug when one user was in MasterPage mode and
other switched page - then on close we opened other user
page.

Change-Id: I02f3b36429a62b855b215803d6684b3382228326
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142740
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142967
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sd/source/ui/view/drviews1.cxx b/sd/source/ui/view/drviews1.cxx
index 64440617e611..da00680667ce 100644
--- a/sd/source/ui/view/drviews1.cxx
+++ b/sd/source/ui/view/drviews1.cxx
@@ -409,7 +409,7 @@ void DrawViewShell::ChangeEditMode(EditMode eEMode, bool 
bIsLayerModeActive)
 OUString aPageName = pPage->GetName();
 maTabControl->InsertPage(pPage->getPageId(), aPageName);
 
-if ( pPage->IsSelected() )
+if ( !comphelper::LibreOfficeKit::isActive() && 
pPage->IsSelected() )
 {
 nActualPageId = pPage->getPageId();
 }


[Libreoffice-commits] core.git: 2 commits - include/vcl sd/source vcl/jsdialog

2022-11-19 Thread Szymon Kłos (via logerrit)
 include/vcl/weld.hxx   |1 +
 sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx |5 -
 vcl/jsdialog/executor.cxx  |3 ++-
 3 files changed, 7 insertions(+), 2 deletions(-)

New commits:
commit fc656a56b283ec0eb308faf78fa171fd69b1e807
Author: Szymon Kłos 
AuthorDate: Thu Nov 17 22:25:33 2022 +0100
Commit: Szymon Kłos 
CommitDate: Sat Nov 19 16:31:58 2022 +0100

jsdialogs: correctly detect button's handler

Change-Id: I5bb3e60d52813fddfc9a5eb7a0e87d5f5e3853f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142904
Reviewed-by: Michael Meeks 
Tested-by: Jenkins CollaboraOffice 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142964
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index b024bc33c4af..9bb5bfb6ed74 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -1479,6 +1479,7 @@ public:
 virtual void set_from_icon_name(const OUString& rIconName) = 0;
 virtual OUString get_label() const = 0;
 void clicked() { signal_clicked(); }
+bool is_custom_handler_set() { return m_aClickHdl.IsSet(); }
 
 // font size is in points, not pixels, e.g. see Window::[G]etPointFont
 virtual void set_font(const vcl::Font& rFont) = 0;
diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index a389e3ab0739..51dcca8f5d16 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -59,7 +59,8 @@ bool ExecuteAction(const std::string& nWindowId, const 
OString& rWidget, StringM
 
 if (sControlType == "responsebutton")
 {
-if (pWidget == nullptr)
+auto pButton = dynamic_cast(pWidget);
+if (pWidget == nullptr || (pButton && 
!pButton->is_custom_handler_set()))
 {
 // welded wrapper not found - use response code instead
 pWidget = JSInstanceBuilder::FindWeldWidgetsMap(nWindowId, 
"__DIALOG__");
commit 71c88cf9d5f5dffa86e5a111e19468a5a2a2b6c0
Author: Szymon Kłos 
AuthorDate: Mon Nov 14 11:38:40 2022 +0100
Commit: Szymon Kłos 
CommitDate: Sat Nov 19 16:31:44 2022 +0100

lok: masterpage: don't remove old cache

In multi user view when switching between MasterPage and Page
mode it was failing to find cache because it was removed by other
views. We need that to allow invalidation after master page changed
something.

Change-Id: I070345b0fe6942965aece5bf729ceb37b7d99397
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142697
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142965
Tested-by: Jenkins
Reviewed-by: Szymon Kłos 

diff --git a/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx 
b/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx
index 465bb6c992b5..76fc3753fc53 100644
--- a/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx
+++ b/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx
@@ -27,6 +27,8 @@
 #include 
 #include 
 
+#include 
+
 namespace {
 
 /** Collection of data that is stored for all active preview caches.
@@ -298,7 +300,8 @@ std::shared_ptr PageCacheManager::ChangeSize (
 
 pResult = rpCache;
 }
-else
+// In multi user view this can happen - no issue (reset after 
switching MasterPage)
+else if (!comphelper::LibreOfficeKit::isActive())
 {
 assert(iCacheToChange != mpPageCaches->end());
 }


[Libreoffice-bugs] [Bug 152126] New: selecting a line and changing line style affects half of lines, which are not selected

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152126

Bug ID: 152126
   Summary: selecting a line and changing line style affects half
of lines, which are not selected
   Product: LibreOffice
   Version: 7.3.6.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: g.statk...@gmail.com

Created attachment 183682
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183682=edit
selecting a line and changing line style affects half of lines, which are not
selected, part belongs to different group

In Libre Office, 
selecting a line and changing line style affects half of lines, which are not
selected.

I need to use 5 different line styles, but i can use only two of them. For some
reason line styles are grouped into two groups, and n wierd manner,

because chaging the curve style affects part of the box style, which are
different figures, were drawn separately, box the first, and all box lines were
joined. Do not know why any curved line style affects some of the box lines,
which are joined, and why selected any curve style affects other curves styles?

How to fix it.

it is a fresh installation of Linux Mint 21 Cinnamon v5.4.8,  but i updated it
mny times, after installing various packages.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 117710] [META] UNO API issues

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=117710
Bug 117710 depends on bug 151846, which changed state.

Bug 151846 Summary: LibreOffice 7.4 missing several imports in 
com.sun.star.chart2 namespace
https://bugs.documentfoundation.org/show_bug.cgi?id=151846

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151846] LibreOffice 7.4 missing several imports in com.sun.star.chart2 namespace

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151846

Noel Grandin  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151846] LibreOffice 7.4 missing several imports in com.sun.star.chart2 namespace

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151846

--- Comment #8 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ec6502a1f61fcbd4bf05b62f172650fe442c3a1d

tdf#151846 Restore XChartTypeTemplate

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151846] LibreOffice 7.4 missing several imports in com.sun.star.chart2 namespace

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=151846

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.5.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: chart2/source offapi/com offapi/UnoApi_offapi.mk

2022-11-19 Thread Noel Grandin (via logerrit)
 chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx |2 
 chart2/source/controller/dialogs/ChartTypeDialogController.cxx|2 
 chart2/source/controller/dialogs/DialogModel.cxx  |8 
 chart2/source/inc/ChartTypeTemplate.hxx   |   45 +-
 chart2/source/model/main/ChartModel_Persistence.cxx   |2 
 chart2/source/model/main/Diagram.cxx  |2 
 chart2/source/model/template/AreaChartTypeTemplate.cxx|   10 
 chart2/source/model/template/AreaChartTypeTemplate.hxx|6 
 chart2/source/model/template/BarChartTypeTemplate.cxx |   14 
 chart2/source/model/template/BarChartTypeTemplate.hxx |   10 
 chart2/source/model/template/BubbleChartTypeTemplate.cxx  |   12 
 chart2/source/model/template/BubbleChartTypeTemplate.hxx  |8 
 chart2/source/model/template/ChartTypeTemplate.cxx|   83 ++-
 chart2/source/model/template/ColumnLineChartTypeTemplate.cxx  |   10 
 chart2/source/model/template/ColumnLineChartTypeTemplate.hxx  |   10 
 chart2/source/model/template/LineChartTypeTemplate.cxx|   10 
 chart2/source/model/template/LineChartTypeTemplate.hxx|   10 
 chart2/source/model/template/NetChartTypeTemplate.cxx |   10 
 chart2/source/model/template/NetChartTypeTemplate.hxx |6 
 chart2/source/model/template/PieChartTypeTemplate.cxx |   14 
 chart2/source/model/template/PieChartTypeTemplate.hxx |   10 
 chart2/source/model/template/ScatterChartTypeTemplate.cxx |   16 
 chart2/source/model/template/ScatterChartTypeTemplate.hxx |   12 
 chart2/source/model/template/StockChartTypeTemplate.cxx   |   14 
 chart2/source/model/template/StockChartTypeTemplate.hxx   |   10 
 chart2/source/tools/DiagramHelper.cxx |2 
 offapi/UnoApi_offapi.mk   |2 
 offapi/com/sun/star/chart2/ChartTypeTemplate.idl  |   46 ++
 offapi/com/sun/star/chart2/XChartTypeTemplate.idl |  224 
++
 29 files changed, 476 insertions(+), 134 deletions(-)

New commits:
commit ec6502a1f61fcbd4bf05b62f172650fe442c3a1d
Author: Noel Grandin 
AuthorDate: Fri Nov 18 10:58:28 2022 +0200
Commit: Noel Grandin 
CommitDate: Sat Nov 19 15:50:48 2022 +0100

tdf#151846 Restore XChartTypeTemplate

Which I removed in commit 58766f997d59e4684f2887fd8cdeb12d2f8a9366.

Turns out it does have some usefulness for extensions. So restore most
of it. The exception is the getDataInterpreter method, for which I have
added a placeholder, so that the restored class has the same vtable
layout as the original.

Change-Id: Ief9b48ef2c408580bc24b5a8a0e11131edb3b943
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142908
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx 
b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index eefed59e3e6a..7b911fbd3820 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -1195,7 +1195,7 @@ uno::Reference< uno::XInterface > SAL_CALL 
ChartDocumentWrapper::createInstance(
 DiagramHelper::tTemplateWithServiceName 
aTemplateWithService(
 DiagramHelper::getTemplateForDiagram( xDiagram, 
xTemplateManager ));
 if( aTemplateWithService.xChartTypeTemplate.is())
-aTemplateWithService.xChartTypeTemplate->resetStyles( 
xDiagram );//#i109371#
+aTemplateWithService.xChartTypeTemplate->resetStyles2( 
xDiagram );//#i109371#
 xTemplate->changeDiagram( xDiagram );
 if( AllSettings::GetMathLayoutRTL() )
 AxisHelper::setRTLAxisLayout( 
AxisHelper::getCoordinateSystemByIndex( xDiagram, 0 ) );
diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx 
b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
index 4c157611f21b..72c51a30d6d0 100644
--- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
+++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx
@@ -318,7 +318,7 @@ void ChartTypeDialogController::commitToModel( const 
ChartTypeParameter& rParame
 DiagramHelper::tTemplateWithServiceName aTemplateWithService(
 DiagramHelper::getTemplateForDiagram( xDiagram, xTemplateManager ));
 if( aTemplateWithService.xChartTypeTemplate.is())
-aTemplateWithService.xChartTypeTemplate->resetStyles( xDiagram );
+aTemplateWithService.xChartTypeTemplate->resetStyles2( xDiagram );
 xTemplate->changeDiagram( xDiagram );
 if( AllSettings::GetMathLayoutRTL() )
 

[Libreoffice-commits] core.git: vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2022-11-19 Thread Khaled Hosny (via logerrit)
 vcl/inc/font/PhysicalFontFace.hxx  |9 +++
 vcl/inc/quartz/salgdi.h|2 -
 vcl/inc/unx/freetype_glyphcache.hxx|2 -
 vcl/inc/unx/glyphcache.hxx |2 -
 vcl/inc/win/salgdi.h   |2 -
 vcl/quartz/ctfonts.cxx |9 ---
 vcl/source/font/PhysicalFontFace.cxx   |   30 +++--
 vcl/unx/generic/glyphs/freetype_glyphcache.cxx |   17 +++---
 vcl/win/gdi/salfont.cxx|   11 +
 9 files changed, 46 insertions(+), 38 deletions(-)

New commits:
commit a38bb773bb568ef942293f23d0701da933817e8f
Author: Khaled Hosny 
AuthorDate: Sat Nov 19 14:58:40 2022 +0200
Commit: خالد حسني 
CommitDate: Sat Nov 19 15:45:21 2022 +0100

vcl: use std::optional in PhysicalFontFace

Otherwise when a font does not, say, support variations or color
palettes, we keep querying the font each time they are requested.

Change-Id: I3a41bc73dd814b25af3a8b5b009632ecf7ef27ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142963
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/inc/font/PhysicalFontFace.hxx 
b/vcl/inc/font/PhysicalFontFace.hxx
index ae0e6ad7d5bf..6e99ae4a098c 100644
--- a/vcl/inc/font/PhysicalFontFace.hxx
+++ b/vcl/inc/font/PhysicalFontFace.hxx
@@ -194,16 +194,15 @@ public:
 return nullptr;
 }
 
-virtual std::vector GetVariations() const { return {}; };
+virtual const std::vector& GetVariations() const;
 
 protected:
 mutable hb_face_t* mpHbFace;
 mutable hb_font_t* mpHbUnscaledFont;
 mutable FontCharMapRef mxCharMap;
-mutable vcl::FontCapabilities maFontCapabilities;
-mutable bool mbFontCapabilitiesRead;
-mutable std::vector maColorPalettes;
-mutable std::vector m_aVariations;
+mutable std::optional mxFontCapabilities;
+mutable std::optional> mxColorPalettes;
+mutable std::optional> mxVariations;
 
 explicit PhysicalFontFace(const FontAttributes&);
 
diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index 121aef3cf59a..79ea9e32e0d6 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -72,7 +72,7 @@ public:
 
 hb_blob_t* GetHbTable(hb_tag_t nTag) const override;
 
-std::vector GetVariations() const override;
+const std::vector& GetVariations() const override;
 
 private:
 CTFontDescriptorRef mxFontDescriptor;
diff --git a/vcl/inc/unx/freetype_glyphcache.hxx 
b/vcl/inc/unx/freetype_glyphcache.hxx
index 0ec53c073006..4cf982c50a12 100644
--- a/vcl/inc/unx/freetype_glyphcache.hxx
+++ b/vcl/inc/unx/freetype_glyphcache.hxx
@@ -101,7 +101,7 @@ public:
 virtual hb_face_t* GetHbFace() const override;
 virtual hb_blob_t* GetHbTable(hb_tag_t nTag) const override;
 
-std::vector GetVariations() const override;
+const std::vector& GetVariations() const override;
 };
 
 class SAL_DLLPUBLIC_RTTI FreetypeFontInstance final : public 
LogicalFontInstance
diff --git a/vcl/inc/unx/glyphcache.hxx b/vcl/inc/unx/glyphcache.hxx
index a6be9e872da6..22e2f0e173d9 100644
--- a/vcl/inc/unx/glyphcache.hxx
+++ b/vcl/inc/unx/glyphcache.hxx
@@ -129,8 +129,6 @@ public:
 boolGetGlyphOutline(sal_GlyphId, 
basegfx::B2DPolyPolygon&, bool) const;
 boolGetAntialiasAdvice() const;
 
-std::vector GetVariations() const;
-
 private:
 friend class FreetypeFontInstance;
 friend class FreetypeManager;
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index e0661dec5a1c..999bb39a1812 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -76,7 +76,7 @@ public:
 
 hb_blob_t*  GetHbTable(hb_tag_t nTag) const override;
 
-std::vector GetVariations() const override;
+const std::vector& GetVariations() const override;
 
 private:
 sal_IntPtr  mnId;
diff --git a/vcl/quartz/ctfonts.cxx b/vcl/quartz/ctfonts.cxx
index 0ca4ffc953ec..c2f6a8a55c00 100644
--- a/vcl/quartz/ctfonts.cxx
+++ b/vcl/quartz/ctfonts.cxx
@@ -268,12 +268,13 @@ hb_blob_t* CoreTextFontFace::GetHbTable(hb_tag_t nTag) 
const
 return pBlob;
 }
 
-std::vector CoreTextFontFace::GetVariations() const
+const std::vector& CoreTextFontFace::GetVariations() const
 {
 CTFontRef pFont = CTFontCreateWithFontDescriptor(mxFontDescriptor, 0.0, 
nullptr);
 
-if (m_aVariations.empty())
+if (!mxVariations)
 {
+mxVariations.emplace();
 CFArrayRef pAxes = CTFontCopyVariationAxes(pFont);
 if (pAxes)
 {
@@ -300,7 +301,7 @@ std::vector 
CoreTextFontFace::GetVariations() const
 continue;
 CFNumberGetValue(pValue, kCFNumberFloatType, );
 
-m_aVariations.push_back({ nTag, fValue });
+mxVariations->push_back({ nTag, fValue });
 }
 }
 

[Libreoffice-ux-advise] [Bug 152125] New: Ease use of Unicode control characters for bidirectionality, e.g. RLI and PDI

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152125

Bug ID: 152125
   Summary: Ease use of Unicode control characters for
bidirectionality, e.g. RLI and PDI
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de
CC: libreoffice-ux-advise@lists.freedesktop.org

Created attachment 183681
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183681=edit
Examples with RTL in LTR

If you have a text run with strong RTL characters in a paragraph with base
direction left-to-right, the implementation of the BiDi-Algorithm in
LibreOffice works well.
But there are situations where bidirectional text is not rendered as necessary
if only using the BiDi-Algorithm. Since ODF has no attribute to set the base
direction on a portion of text, but only on the paragraph, such situations need
to be solved by inserting Unicode control characters. Such are:
(1) LRI, RLI, FSI, PDI (U+2066..U+2069)
(2) LRE, RLE, LRO, RLO, PDF (U+202A..U202E)
(3) LRM, RLM (U+200E, U+200F)

Problem A
You cannot see, which one is used and where it is inserted because all this
characters are hidden and have zero width. That is a problem when you need to
edit the text. Using control characters (2) is problematic, but if you do not
see them it is hard to remove such, for example.

Problem B
LibreOffice supports to enter the control characters (3). That is in Insert >
Formatting Mark > Left-to-Right Mark and Right-to-Left Mark. But there exists
no tool for the control characters (1) and (2). Entering them directly into the
text via U+ and Alt+x is very problematic, because character order might
change while entering them.

A solution for A could be, to show the illustration glyphs (that with the
dotted border in the Unicode chart files) when "Show Formatting Marks" is ON.

I have no idea for a good tool to enter these controls.

You should use the attachment and try to bring the sentence which has no
control character into the correct word order. Then you will notice the
problems for the user.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Test failure on some Windows systems with 125% display scaling, Chart2ImportTest::testAutomaticSizeBarChartVeryLongLabel

2022-11-19 Thread Ilmari Lauhakangas
A new dev is seeing this test failure on Windows with 125% scaling, the 
test passes if scaling is set to 100%:


C:/cygwin/home/Client/lode/dev/core/chart2/qa/extras/chart2import.cxx(2273) 
: error : Assertion

Test name: Chart2ImportTest::testAutomaticSizeBarChartVeryLongLabel
double equality assertion failed
- Expected: 5320
- Actual  : 4765
- Delta   : 100

Mike added tolerance to this test in 
09e499e64ec4acb24c9524c8aacabc6182124442 but in this case the difference 
seems surprisingly large.


Ilmari


[Libreoffice-bugs] [Bug 152125] New: Ease use of Unicode control characters for bidirectionality, e.g. RLI and PDI

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152125

Bug ID: 152125
   Summary: Ease use of Unicode control characters for
bidirectionality, e.g. RLI and PDI
   Product: LibreOffice
   Version: 7.5.0.0 alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Keywords: needsUXEval
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rb.hensc...@t-online.de
CC: libreoffice-ux-adv...@lists.freedesktop.org

Created attachment 183681
  --> https://bugs.documentfoundation.org/attachment.cgi?id=183681=edit
Examples with RTL in LTR

If you have a text run with strong RTL characters in a paragraph with base
direction left-to-right, the implementation of the BiDi-Algorithm in
LibreOffice works well.
But there are situations where bidirectional text is not rendered as necessary
if only using the BiDi-Algorithm. Since ODF has no attribute to set the base
direction on a portion of text, but only on the paragraph, such situations need
to be solved by inserting Unicode control characters. Such are:
(1) LRI, RLI, FSI, PDI (U+2066..U+2069)
(2) LRE, RLE, LRO, RLO, PDF (U+202A..U202E)
(3) LRM, RLM (U+200E, U+200F)

Problem A
You cannot see, which one is used and where it is inserted because all this
characters are hidden and have zero width. That is a problem when you need to
edit the text. Using control characters (2) is problematic, but if you do not
see them it is hard to remove such, for example.

Problem B
LibreOffice supports to enter the control characters (3). That is in Insert >
Formatting Mark > Left-to-Right Mark and Right-to-Left Mark. But there exists
no tool for the control characters (1) and (2). Entering them directly into the
text via U+ and Alt+x is very problematic, because character order might
change while entering them.

A solution for A could be, to show the illustration glyphs (that with the
dotted border in the Unicode chart files) when "Show Formatting Marks" is ON.

I have no idea for a good tool to enter these controls.

You should use the attachment and try to bring the sentence which has no
control character into the correct word order. Then you will notice the
problems for the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Test failure in embeddedobj on some Windows systems

2022-11-19 Thread Ilmari Lauhakangas
This failure was first observed in September this year and now another 
new dev is facing it:


C:/cygwin/home/Client/lode/dev/core/test/source/xmltesttools.cxx(174) : 
error : Assertion

Test name: testSaveOnThread::TestBody
equality assertion failed
- Expected: 0.1665in
- Actual  : 1.9685in
- In <>, attribute 'visible-area-width' of '//style:graphic-properties' 
incorrect value.


Miklos's comments from September:

"I meant that in case we get RPC_E_WRONG_THREAD at
embeddedobj/source/msole/olecomponent.cxx:1018, then we know how to work
things around. It looks like the failing scenario doesn't get this error
code, but fails in a different way, so the visible area (asserted in the
testcase) is wrong exactly the way it was wrong for everyone before
d5cd62164d32273a25913c93aa04be9f7f3a4073."

"Getting RPC_E_WRONG_THREAD on the first try is expected,
what's unexpected is that the 2nd try doesn't work the way the test
wants it."

I asked Hossein how the new dev could continue debugging the issue and 
he looked into it a bit:


"as I understand from the code, the checks does not happen when the DPI 
is not 96, in which I think most of the today's displays are not.


embeddedobj/qa/cppunit/msole.cxx:98

CPPUNIT_TEST_FIXTURE(Test, testSaveOnThread)
{
// Given an embedded object which hosts mspaint data:
if (Application::GetDefaultDevice()->GetDPIX() != 96)
{
return;
}
.
.
.
}

I changed the code to bypass this condition, and then I saw the test 
failing as I expected, as it is tailored to 96 dpi only. On my machine, 
it failed with 0.0555in instead of 0.1665in.


I also wasn't faced with RPC_E_WRONG_THREAD value of `hr`, but it was 
shown as `S_OK`, passing SUCCEEDED().


Previously, when I wanted to debug multiple values in CppunitTests, I 
usually dumped them into a temporary file. I think this idea can be used 
to dump specific values to a set of files, each for a thread. 
Alternatively, one can switch between threads in the Visual Studio 
debugger by using the appropriate window, that can be enabled from the 
debug menu. But, it is not always easy to debug a multi-threaded 
application."


If someone has ideas on how to figure this out, let me know.

Ilmari


[Libreoffice-bugs] [Bug 152017] footnotes move onto the next page as I add paragraphs to my document

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152017

--- Comment #3 from Sarah  ---
Hi Stephanie.
Apologies for my delay in replying. I did downgrade back to: 

Version: 7.4.1.2 (x64) / LibreOffice Community
Build ID: 3c58a8f3a960df8bc8fd77b461821e42c061c5f0
CPU threads: 16; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: CL

That did resolve the issue, but it has now started again. 

As my document is a genealogy course assignment, it states family member's
names and dates of birth / death, I don't want to upload it here.

I shall e-mail the document to you now.

Sarah

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 86174] logic error with mod() and int() function

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=86174

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 CC||79045_79...@mail.ru

--- Comment #6 from Roman Kuznetsov <79045_79...@mail.ru> ---
Still repro in

Version: 7.5.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ddb8a1a282aae74c1cee3a5e1f446abd0c00b116
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133796] [EDITING] Scroll Lock mode fails for horizontal cursor keys, when there are frozen rows and columns

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133796

--- Comment #6 from zzz  ---
Problem still reproduces in
Version: 7.4.2.3 (x64) / LibreOffice Community
Build ID: 382eef1f22670f7f4118c8c2dd222ec7ad009daf
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ja-JP (ja_JP); UI: en-US
Calc: CL
on Windows 10 Professional

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107701] [META] Table border bugs and enhancements

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107701
Bug 107701 depends on bug 120530, which changed state.

Bug 120530 Summary: Table border isn't redrawn until some movement
https://bugs.documentfoundation.org/show_bug.cgi?id=120530

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 120530] Table border isn't redrawn until some movement

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120530

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||kelem...@ubuntu.com,
   ||vmik...@collabora.com
 Status|NEW |RESOLVED

--- Comment #5 from Gabor Kelemen (allotropia)  ---
This seems to have been fixed in 6.3 with

https://git.libreoffice.org/core/+/d5b50e74ee822e1c8402e3044e14799e47907ff8

author  Miklos Vajna Mon Sep 16 21:15:28 2019 +0200
committer   Mike Kaganski  Tue Sep 17
18:57:09 2019 +0200

tdf#105330 sw: fix lost cursor on undoing nested table insert

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107701] [META] Table border bugs and enhancements

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107701
Bug 107701 depends on bug 119520, which changed state.

Bug 119520 Summary: The table borders/content shifting when saving with 
selected content (and afterwards when deselecting)
https://bugs.documentfoundation.org/show_bug.cgi?id=119520

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 119520] The table borders/content shifting when saving with selected content (and afterwards when deselecting)

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=119520

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||kelem...@ubuntu.com,
   ||michael.st...@allotropia.de
 Resolution|--- |FIXED

--- Comment #10 from Gabor Kelemen (allotropia)  ---
This seems to be fixed in 7.3 with

https://git.libreoffice.org/core/+/dadaf930d14283f96cc06741d2eec6d846e59f7f

author  Michael Stahl  Mon Jul 11 19:20:33
2022 +0200
committer   Miklos Vajna Thu Jul 14 16:49:07
2022 +0200

sw: fix spurious layout invalidation from ~SwCallLink()

Thanks Michael!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152075] Writer: TOC for chapter should start at current level+1, not current level

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152075

--- Comment #8 from Mike Kaganski  ---
(In reply to Peter Roelofsen from comment #7)

Having the described layout (Chapter ToC prior to the chapter itself) would
possibly best be implemented by the third element in the "For:" drop-down (next
to "Entire document" and "Chapter"), like "Specified chapter", giving a choice
similar to what "Cross-reference"->"Headings" field allows. That is a separate
issue, that needs an own proposal. This is off-topic here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152075] Writer: TOC for chapter should start at current level+1, not current level

2022-11-19 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=152075

--- Comment #8 from Mike Kaganski  ---
(In reply to Peter Roelofsen from comment #7)

Having the described layout (Chapter ToC prior to the chapter itself) would
possibly best be implemented by the third element in the "For:" drop-down (next
to "Entire document" and "Chapter"), like "Specified chapter", giving a choice
similar to what "Cross-reference"->"Headings" field allows. That is a separate
issue, that needs an own proposal. This is off-topic here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Changes in LibreOfficeKit

2022-11-19 Thread Andreas Mantke

Hi all,

I looked at Gerrit.LibreOffice and found a patch on the LibreOfficeKit
which not make it into the LibreOffice master. I think this were only a
slip of the pen:

https://gerrit.libreoffice.org/c/core/+/137869

It would be great if the developer or the reviewer could merge this
patch into the LibreOffice master too.

Regards,
Andreas

--
## Free Software Advocate
## Plone add-on developer
## My blog: http://www.amantke.de/blog



Re: contribution

2022-11-19 Thread Ilmari Lauhakangas

On 18.11.2022 14.11, Konstantin Limarev wrote:

Hi!

I’m Konstantin Limarev, 3 year experience C++ developer. I’m working on add-on 
for LibreOffice for Windows based on examples provided with SDK. I made my 
project migrating from make to CMake and wonder know if LibreOffice SDK has 
plans to migrate to CMake in roadmap, examples part at least. In any case I 
would be happy to contribute if any help required, especially in CMake 
migration.


You might enjoy this: 
https://dev.blog.documentfoundation.org/2022/04/19/using-cmake-to-build-libreoffice-cpp-sdk-examples/


We are exploring using Meson for LibreOffice core, so it would be 
interesting to see how SDK examples would build with Meson.


Ilmari


[Libreoffice-commits] core.git: solenv/clang-format vcl/inc vcl/win

2022-11-19 Thread Khaled Hosny (via logerrit)
 solenv/clang-format/excludelist |1 
 vcl/inc/win/salgdi.h|2 
 vcl/win/gdi/dw-extra.h  |  141 
 vcl/win/gdi/salfont.cxx |   36 ++
 4 files changed, 180 insertions(+)

New commits:
commit e65b0bf83b8225fde81ee7b10c1fa4b9f32b6ed1
Author: Khaled Hosny 
AuthorDate: Sat Nov 19 09:34:56 2022 +0200
Commit: خالد حسني 
CommitDate: Sat Nov 19 12:44:58 2022 +0100

vcl: add WinFontFace::GetVariations()

This makes font variation settings to be applied to glyph advances and
text layout, not only glyph shapes.

The sw-extra.h file is needed because we target Windows 7 and the
interfaces we want to use are only exposed for Windows 10. File copied
from:


https://hg.mozilla.org/mozilla-central/file/704f09a557a4dfc9057f1672b711789f64f74a82/gfx/2d/dw-extra.h

Change-Id: I7bbb4c3f2b70274754f844fedb0c4329c8f649a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142347
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/solenv/clang-format/excludelist b/solenv/clang-format/excludelist
index f3f6c774e7a3..b50d8bf4f4f0 100644
--- a/solenv/clang-format/excludelist
+++ b/solenv/clang-format/excludelist
@@ -15082,6 +15082,7 @@ vcl/win/dtrans/XNotifyingDataObject.hxx
 vcl/win/dtrans/XTDataObject.cxx
 vcl/win/dtrans/XTDataObject.hxx
 vcl/win/gdi/DWriteTextRenderer.cxx
+vcl/win/gdi/dw-extra.h
 vcl/win/gdi/gdiimpl.cxx
 vcl/win/gdi/gdiimpl.hxx
 vcl/win/gdi/salbmp.cxx
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index 8d93577e4cb1..e0661dec5a1c 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -76,6 +76,8 @@ public:
 
 hb_blob_t*  GetHbTable(hb_tag_t nTag) const override;
 
+std::vector GetVariations() const override;
+
 private:
 sal_IntPtr  mnId;
 
diff --git a/vcl/win/gdi/dw-extra.h b/vcl/win/gdi/dw-extra.h
new file mode 100644
index ..4c07d81d2126
--- /dev/null
+++ b/vcl/win/gdi/dw-extra.h
@@ -0,0 +1,141 @@
+//
+// copied from:
+// 
https://hg.mozilla.org/mozilla-central/file/704f09a557a4dfc9057f1672b711789f64f74a82/gfx/2d/dw-extra.h
+//
+
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 2 -*-
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+/*
+ * New DirectWrite interfaces based on Win10 Fall Creators Update versions
+ * of dwrite_3.h and dcommon.h (from SDK 10.0.17061.0). This particular
+ * subset of declarations is intended to be just sufficient to compile the
+ * Gecko DirectWrite font code; it omits many other new interfaces, etc.
+ */
+
+#ifndef DWRITE_EXTRA_H
+#define DWRITE_EXTRA_H
+
+#pragma once
+
+interface IDWriteFontResource;
+interface IDWriteFontFaceReference1;
+
+enum DWRITE_GLYPH_IMAGE_FORMATS {
+  DWRITE_GLYPH_IMAGE_FORMATS_NONE = 0x,
+  DWRITE_GLYPH_IMAGE_FORMATS_TRUETYPE = 0x0001,
+  DWRITE_GLYPH_IMAGE_FORMATS_CFF = 0x0002,
+  DWRITE_GLYPH_IMAGE_FORMATS_COLR = 0x0004,
+  DWRITE_GLYPH_IMAGE_FORMATS_SVG = 0x0008,
+  DWRITE_GLYPH_IMAGE_FORMATS_PNG = 0x0010,
+  DWRITE_GLYPH_IMAGE_FORMATS_JPEG = 0x0020,
+  DWRITE_GLYPH_IMAGE_FORMATS_TIFF = 0x0040,
+  DWRITE_GLYPH_IMAGE_FORMATS_PREMULTIPLIED_B8G8R8A8 = 0x0080,
+};
+
+#ifdef DEFINE_ENUM_FLAG_OPERATORS
+DEFINE_ENUM_FLAG_OPERATORS(DWRITE_GLYPH_IMAGE_FORMATS);
+#endif
+
+#define DWRITE_MAKE_FONT_AXIS_TAG(a, b, c, d) \
+  (static_cast(DWRITE_MAKE_OPENTYPE_TAG(a, b, c, d)))
+
+enum DWRITE_FONT_AXIS_TAG : UINT32 {
+  DWRITE_FONT_AXIS_TAG_WEIGHT = DWRITE_MAKE_FONT_AXIS_TAG('w', 'g', 'h', 't'),
+  DWRITE_FONT_AXIS_TAG_WIDTH = DWRITE_MAKE_FONT_AXIS_TAG('w', 'd', 't', 'h'),
+  DWRITE_FONT_AXIS_TAG_SLANT = DWRITE_MAKE_FONT_AXIS_TAG('s', 'l', 'n', 't'),
+  DWRITE_FONT_AXIS_TAG_OPTICAL_SIZE =
+  DWRITE_MAKE_FONT_AXIS_TAG('o', 'p', 's', 'z'),
+  DWRITE_FONT_AXIS_TAG_ITALIC = DWRITE_MAKE_FONT_AXIS_TAG('i', 't', 'a', 'l'),
+};
+
+enum DWRITE_FONT_AXIS_ATTRIBUTES {
+  DWRITE_FONT_AXIS_ATTRIBUTES_NONE = 0x,
+  DWRITE_FONT_AXIS_ATTRIBUTES_VARIABLE = 0x0001,
+  DWRITE_FONT_AXIS_ATTRIBUTES_HIDDEN = 0x0002,
+};
+
+struct DWRITE_FONT_AXIS_VALUE {
+  DWRITE_FONT_AXIS_TAG axisTag;
+  FLOAT value;
+};
+
+struct DWRITE_FONT_AXIS_RANGE {
+  DWRITE_FONT_AXIS_TAG axisTag;
+  FLOAT minValue;
+  FLOAT maxValue;
+};
+
+struct DWRITE_GLYPH_IMAGE_DATA {
+  const void* imageData;
+  UINT32 imageDataSize;
+  UINT32 uniqueDataId;
+  UINT32 pixelsPerEm;
+  D2D1_SIZE_U pixelSize;
+  D2D1_POINT_2L horizontalLeftOrigin;
+  D2D1_POINT_2L horizontalRightOrigin;
+  D2D1_POINT_2L verticalTopOrigin;
+  D2D1_POINT_2L verticalBottomOrigin;
+};
+
+interface DWRITE_DECLARE_INTERFACE("27F2A904-4EB8-441D-9678-0563F53E3E2F")
+IDWriteFontFace4 : public IDWriteFontFace3 {
+  STDMETHOD_(DWRITE_GLYPH_IMAGE_FORMATS, GetGlyphImageFormats)() PURE;
+  

[Libreoffice-commits] core.git: vcl/inc

2022-11-19 Thread Khaled Hosny (via logerrit)
 vcl/inc/win/salgdi.h |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit d00ed8359c082f460e5f318ddf180513ca429e46
Author: Khaled Hosny 
AuthorDate: Sat Nov 19 09:13:52 2022 +0200
Commit: خالد حسني 
CommitDate: Sat Nov 19 12:44:34 2022 +0100

vcl: make WinFontFace final

Change-Id: Ie64c155c8dc4d2a4819d4f60999cbb8355687d86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142958
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index c21c36db2dec..8d93577e4cb1 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -59,14 +59,14 @@ class ImplFontMetricData;
 #define PALRGB_TO_RGB(nPalRGB)  ((nPalRGB)&0x00ff)
 
 // win32 specific physically available font face
-class WinFontFace : public vcl::font::PhysicalFontFace
+class WinFontFace final : public vcl::font::PhysicalFontFace
 {
 public:
 explicitWinFontFace(const ENUMLOGFONTEXW&, const 
NEWTEXTMETRICW&);
-virtual ~WinFontFace() override;
+~WinFontFace() override;
 
-virtual rtl::Reference CreateFontInstance( const 
vcl::font::FontSelectPattern& ) const override;
-virtual sal_IntPtr  GetFontId() const override;
+rtl::Reference CreateFontInstance( const 
vcl::font::FontSelectPattern& ) const override;
+sal_IntPtr  GetFontId() const override;
 voidSetFontId( sal_IntPtr nId ) { mnId = nId; }
 
 BYTEGetCharSet() const  { return meWinCharSet; 
}
@@ -74,7 +74,7 @@ public:
 
 IDWriteFontFace*GetDWFontFace() const;
 
-virtual hb_blob_t*  GetHbTable(hb_tag_t nTag) const override;
+hb_blob_t*  GetHbTable(hb_tag_t nTag) const override;
 
 private:
 sal_IntPtr  mnId;


[Libreoffice-commits] core.git: vcl/inc vcl/skia vcl/win

2022-11-19 Thread Khaled Hosny (via logerrit)
 vcl/inc/skia/win/gdiimpl.hxx   |2 +-
 vcl/inc/win/DWriteTextRenderer.hxx |2 +-
 vcl/inc/win/salgdi.h   |3 +++
 vcl/skia/win/gdiimpl.cxx   |   33 +++--
 vcl/win/gdi/DWriteTextRenderer.cxx |   26 --
 vcl/win/gdi/salfont.cxx|   28 
 6 files changed, 56 insertions(+), 38 deletions(-)

New commits:
commit a80239ede3236c84d7a05d0fbc0f299811fee6c0
Author: Khaled Hosny 
AuthorDate: Sat Nov 19 03:03:15 2022 +0200
Commit: خالد حسني 
CommitDate: Sat Nov 19 12:44:10 2022 +0100

vcl: move creating DWFontFace to WinFontFace

Change-Id: Ie0e94787d962eaec7753ae50d548ad8655dbc209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142957
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/vcl/inc/skia/win/gdiimpl.hxx b/vcl/inc/skia/win/gdiimpl.hxx
index 92f873ca7d43..c5b12d08811a 100644
--- a/vcl/inc/skia/win/gdiimpl.hxx
+++ b/vcl/inc/skia/win/gdiimpl.hxx
@@ -63,7 +63,7 @@ public:
 
 protected:
 virtual void createWindowSurfaceInternal(bool forceRaster = false) 
override;
-static sk_sp createDirectWriteTypeface(HDC hdc, HFONT hfont);
+static sk_sp createDirectWriteTypeface(const WinFontInstance* 
pWinFont);
 static void initFontInfo();
 inline static sal::systools::COMReference 
dwriteFontSetBuilder;
 inline static sal::systools::COMReference 
dwritePrivateCollection;
diff --git a/vcl/inc/win/DWriteTextRenderer.hxx 
b/vcl/inc/win/DWriteTextRenderer.hxx
index 5f0dc35ddd58..b2d685b20365 100644
--- a/vcl/inc/win/DWriteTextRenderer.hxx
+++ b/vcl/inc/win/DWriteTextRenderer.hxx
@@ -60,7 +60,7 @@ private:
 D2DWriteTextOutRenderer(const D2DWriteTextOutRenderer &) = delete;
 D2DWriteTextOutRenderer & operator = (const D2DWriteTextOutRenderer &) = 
delete;
 
-bool GetDWriteFaceFromHDC(HDC hDC, IDWriteFontFace ** ppFontFace, float * 
lfSize) const;
+IDWriteFontFace* GetDWriteFace(const WinFontInstance& rWinFont, float * 
lfSize) const;
 bool performRender(GenericSalLayout const , SalGraphics 
, HDC hDC, bool& bRetry, bool bRenderingModeNatural);
 
 ID2D1Factory* mpD2DFactory;
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index db00ff03455a..c21c36db2dec 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -72,6 +72,8 @@ public:
 BYTEGetCharSet() const  { return meWinCharSet; 
}
 BYTEGetPitchAndFamily() const   { return 
mnPitchAndFamily; }
 
+IDWriteFontFace*GetDWFontFace() const;
+
 virtual hb_blob_t*  GetHbTable(hb_tag_t nTag) const override;
 
 private:
@@ -80,6 +82,7 @@ private:
 BYTEmeWinCharSet;
 BYTEmnPitchAndFamily;
 LOGFONTWmaLogFont;
+mutable sal::systools::COMReference mxDWFontFace;
 };
 
 /** Class that creates (and destroys) a compatible Device Context.
diff --git a/vcl/skia/win/gdiimpl.cxx b/vcl/skia/win/gdiimpl.cxx
index 74bc3cce5ec5..a9df26cb53a1 100644
--- a/vcl/skia/win/gdiimpl.cxx
+++ b/vcl/skia/win/gdiimpl.cxx
@@ -121,12 +121,12 @@ bool 
WinSkiaSalGraphicsImpl::RenderAndCacheNativeControl(CompatibleDC& rWhite, C
 return true;
 }
 
-sk_sp WinSkiaSalGraphicsImpl::createDirectWriteTypeface(HDC hdc, 
HFONT hfont) try
+sk_sp
+WinSkiaSalGraphicsImpl::createDirectWriteTypeface(const WinFontInstance* 
pWinFont) try
 {
 using sal::systools::ThrowIfFailed;
 IDWriteFactory* dwriteFactory;
-IDWriteGdiInterop* dwriteGdiInterop;
-WinSalGraphics::getDWriteFactory(, );
+WinSalGraphics::getDWriteFactory();
 if (!dwriteDone)
 {
 dwriteFontMgr = SkFontMgr_New_DirectWrite(dwriteFactory);
@@ -135,30 +135,20 @@ sk_sp 
WinSkiaSalGraphicsImpl::createDirectWriteTypeface(HDC hdc, HFO
 if (!dwriteFontMgr)
 return nullptr;
 
-// tdf#137122: We need to get the exact same font as HFONT refers to,
-// since VCL core computes things like glyph ids based on that, and getting
-// a different font could lead to mismatches (e.g. if there's a slightly
-// different version of the same font installed system-wide).
-// For that CreateFromFaceFromHdc() is necessary. The simpler
-// CreateFontFromLOGFONT() seems to search for the best matching font,
-// which may not be the exact font.
-sal::systools::COMReference fontFace;
-{
-comphelper::ScopeGuard g(
-[ hdc, oldFont(SelectFont(hdc, hfont)) ] { SelectFont(hdc, 
oldFont); });
-ThrowIfFailed(dwriteGdiInterop->CreateFontFaceFromHdc(hdc, ), 
SAL_WHERE);
-}
+IDWriteFontFace* fontFace = pWinFont->GetFontFace()->GetDWFontFace();
+if (!fontFace)
+return nullptr;
 
 sal::systools::COMReference collection;
 ThrowIfFailed(dwriteFactory->GetSystemFontCollection(), 
SAL_WHERE);
 sal::systools::COMReference font;
 // As said above, this fails for our fonts.
-if 

  1   2   >