[Libreoffice-bugs] [Bug 147450] Line end point moving not possible
https://bugs.documentfoundation.org/show_bug.cgi?id=147450 Buovjaga changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ilmari.lauhakangas@libreoff ||ice.org Ever confirmed|0 |1 Whiteboard| QA:needsComment| --- Comment #2 from Buovjaga --- No problem here. Can you retest with the latest version? Set to NEEDINFO. Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED WORKSFORME, if the problem went away. Version: 7.4.3.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: kf5 (cairo+wayland) Locale: fi-FI (fi_FI.UTF-8); UI: en-US 7.4.3-3 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152560] Consistent appearance of dropdowns and Application Colors background
https://bugs.documentfoundation.org/show_bug.cgi?id=152560 Buovjaga changed: What|Removed |Added Component|LibreOffice |UI Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||ilmari.lauhakangas@libreoff ||ice.org Summary|Consisgtent appearance of |Consistent appearance of |pop-ups and Appearance |dropdowns and Application |background |Colors background --- Comment #2 from Buovjaga --- Just to make the use case clear, you are using a non-dark theme in your operating system, but you want LibreOffice to look like it does in dark mode? Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the information. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152561] Consistent appearance of pop-ups and Appearance background
https://bugs.documentfoundation.org/show_bug.cgi?id=152561 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Buovjaga --- *** This bug has been marked as a duplicate of bug 152560 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152560] Consisgtent appearance of pop-ups and Appearance background
https://bugs.documentfoundation.org/show_bug.cgi?id=152560 --- Comment #1 from Buovjaga --- *** Bug 152561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537
--- Comment #13 from Mike Kaganski ---
(In reply to Seán Ó Séaghdha from comment #12)
> I’m curious now about how this situation came about. What is the use case
> for having separate styles ('style:default-style style:family="paragraph"'
> and 'style:style style:name="Standard" style:family="paragraph"')?
'style:style style:name="Standard" style:family="paragraph"' is a normal
paragraph style. It may be used as an ancestor in inheritance hierarchy; but it
is not a required hierarchy root. Any paragraph style may be set to not inherit
from *any style*, and become a root of own inheritance hierarchy (creating a
"forest" of paragraph style hierarchy trees).
>From the file format point of view, the need to store the defaults applicable
to *any* style of a given family (paragraph/text/...) that does not define a
property in its inheritance tree requires such 'style:default-style' elements.
They *allow* (but do not force) to create files that do not depend on user
settings and/or program versions (which may change the defaults).
The documentation for style:default-style is at
https://docs.oasis-open.org/office/OpenDocument/v1.3/OpenDocument-v1.3-part3-schema.html#element-style_default-style.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152562] New: Crash Report Upload Missing on LibreOffice (Portable)
https://bugs.documentfoundation.org/show_bug.cgi?id=152562 Bug ID: 152562 Summary: Crash Report Upload Missing on LibreOffice (Portable) Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ktop...@gmail.com Description: I have used both the standard LibreOffice and Portable version on Windows. With the standard version, I get a prompt to upload a crash report whenever I have a crash to assist development team in fixing that bug. However, I donot get any prompts to upload crash reports on the Portable version of LibreOffice. I know many people use the Portable version and the crash report upload feature is already available in the standard version of LibreOffice. I believe the crash upload feature should be restored on the Portable version so all crash reports on the Portable version can be uploaded for debugging. Workaround is to run standard version of LibreOffice (instead of portable) to get the crash report upload prompts. Manually filing crash reports are too time-consuming because they happen often when I work with complex spreadsheet. Actual Results: No prompts to upload crash report on LibreOffice (Portable) Expected Results: Prompt to upload crash report Reproducible: Always User Profile Reset: No Additional Info: Workaround is to run standard version of LibreOffice (instead of portable) to get the crash report upload prompts. Manually filing crash reports are too time-consuming because they happen often when I work with complex spreadsheet. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152551] "Templates and Styles" help claims incorrectly that "Unless you specify otherwise, every new LibreOffice text document is based on the default template"
https://bugs.documentfoundation.org/show_bug.cgi?id=152551 --- Comment #2 from Mike Kaganski --- (In reply to BogdanB from comment #1) > my default template is 2 cm all margins. All new documents are the > same. So, could be correct that all new documents are based on a template. The latter does not follow from the former. "I have set a default template, and my new documents are being created from it" is *not* equal to "all new documents are based on a template". > But only IF LibreOffice is taking default template when creating a new > document. LibreOffice *does* take a default template when creating a new document, *if and only if* the default template is set. When it's not set, no template is taken into account. > But also, if the default template is created based on hardcoded numbers and > a new document is created based on the same default hardcoded numbers that > could also mean that it is based on the template, because we have the same > settings in hardcoded code, template and new document created from code > (default template). This is playing words. The term "template" is used in a very specific sense in the technical documentation, which is LibreOffice help. It is about a kind of *files* (ODF) that have names, are placed somewhere in the filesystem, and so on. The term "default template" also has a very specific meaning in the documentation, namely "a template (see above) that is configured in LibreOffice (either in shared configuration, or user configuration) to be used by default". The philosophical/linguistical question "what one could call a template" is not relevant to our documentation. And the current situation is confusing. And that is especially important since MS Word, for instance, has a true "default template" (normal.dot(m)), and so people tend to expect something similar in LO *by default*. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 --- Comment #7 from BogdanB --- I confirm the behaviour with the doc "FromDesktop.odt". When toogled "Show Text Boundaries" the table bounderies are gone. But I can NOT reproduce with a new file in the same version. So, it seems that there is a problem in the structure of the new created file. Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 BogdanB changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #6 from BogdanB --- I confirm the behaviour with the doc "FromDesktop.odt". When toogled "Show Text Boundaries" the table bounderies are gone. But I can reproduce with a new file in the same version. So, it seems is a problem in the structure of the new created file. Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144814] Options dialog has some settings specific to current document & stored within it
https://bugs.documentfoundation.org/show_bug.cgi?id=144814 --- Comment #20 from Seán Ó Séaghdha --- Just adding my support for removing any document-specific settings from Tools|Options. It’s just too confusing and adding indicators or colours would be a poor fix. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #5 from BogdanB --- No problem in Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: ro-RO (ro_RO.UTF-8); UI: en-US Calc: threaded when I toogled "Show Text Boundaries" the corner of the page became visible/invisible. when I toogled "Show Table Boundaries" the invisible borders of the table became visible/invisible. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152551] "Templates and Styles" help claims incorrectly that "Unless you specify otherwise, every new LibreOffice text document is based on the default template"
https://bugs.documentfoundation.org/show_bug.cgi?id=152551 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #1 from BogdanB --- Mike, my default template is 2 cm all margins. All new documents are the same. So, could be correct that all new documents are based on a template. But only IF LibreOffice is taking default template when creating a new document. But also, if the default template is created based on hardcoded numbers and a new document is created based on the same default hardcoded numbers that could also mean that it is based on the template, because we have the same settings in hardcoded code, template and new document created from code (default template). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152537] No obvious UI to set the document default font used e.g. in Line Numbering
https://bugs.documentfoundation.org/show_bug.cgi?id=152537
--- Comment #12 from Seán Ó Séaghdha ---
I’m curious now about how this situation came about. What is the use case for
having separate styles ('style:default-style style:family="paragraph"' and
'style:style style:name="Standard" style:family="paragraph"')?
Is this just because styles in the interface require a name? But since it’s
not the name that’s shown anyway...
How is having these separate styles actually useful? (ignoring for the moment
the complexity of collapsing them)
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/utlui/content.cxx | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
New commits:
commit 3cb601245676a67f5cd523e4f400f777b3e53dc6
Author: Jim Raykowski
AuthorDate: Wed Dec 14 06:24:08 2022 -0900
Commit: Jim Raykowski
CommitDate: Sat Dec 17 05:08:20 2022 +
SwNavigator: Fix delete field content deletes one character extra
PostIt fields are no longer included in the fields content
type since commit bf28e1df0a04cf6a06d9c4cf591e238a45a34ec1 so there is
no need to check to delete them from the field content type, if ever
this was needed, and fall through to the PostIt content handling which
is where the extra character delete happens that is the cause of this
bug.
Change-Id: I61ded30fd89d87c536f0c050117d5b61fe3a9aef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144201
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 42c6168a7eb7..83d2bc08c2a5 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5386,22 +5386,17 @@ void SwContentTree::EditEntry(const weld::TreeIter&
rEntry, EditEntryMode nMode)
break;
case ContentTypeId::TEXTFIELD:
{
-const SwTextFieldContent* pTextFieldCnt = static_cast(pCnt);
if (nMode == EditEntryMode::DELETE)
{
+const SwTextFieldContent* pTextFieldCnt =
+static_cast(pCnt);
const SwTextField* pTextField =
pTextFieldCnt->GetFormatField()->GetTextField();
SwTextField::DeleteTextField(*pTextField);
}
else
-{
-if (pTextFieldCnt->GetFormatField()->GetField()->GetTypeId()
!= SwFieldTypesEnum::Postit)
-{
-nSlot = FN_EDIT_FIELD;
-break;
-}
-}
-[[fallthrough]]; // execute FN_POSTIT assuring standard mode first
+nSlot = FN_EDIT_FIELD;
}
+break;
case ContentTypeId::POSTIT:
{
auto& rView = m_pActiveShell->GetView();
[Libreoffice-bugs] [Bug 152029] Visually draw attention to in-view bookmark or hyperlink when selecting/hovering it in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=152029 --- Comment #39 from Commit Notification --- Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/1c6410fc51a89464898622ae3859931f81178a01 tdf#152029 cleanup: Bring content to attention in document view It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 Commit Notification changed: What|Removed |Added Whiteboard||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/conttree.hxx |2
sw/source/uibase/utlui/content.cxx | 542 ++---
2 files changed, 209 insertions(+), 335 deletions(-)
New commits:
commit 1c6410fc51a89464898622ae3859931f81178a01
Author: Jim Raykowski
AuthorDate: Fri Dec 9 13:36:30 2022 -0900
Commit: Jim Raykowski
CommitDate: Sat Dec 17 05:07:48 2022 +
tdf#152029 cleanup: Bring content to attention in document view
when the mouse pointer is over content type and content entries in the
Navigator content tree
Changes made:
* check for content visibility
* use m_aActiveContentArray for content types where possible
* consolidate repeated code
* check pointers before use
* stop and clear overlay when hidden shell is shown
Change-Id: I2ec41b2508e3f37ea11bfbeb695fc95e0dcca0ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143904
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/sw/source/uibase/inc/conttree.hxx
b/sw/source/uibase/inc/conttree.hxx
index af39a41cb1ae..1764377f0312 100644
--- a/sw/source/uibase/inc/conttree.hxx
+++ b/sw/source/uibase/inc/conttree.hxx
@@ -136,6 +136,8 @@ class SwContentTree final : public SfxListener
std::unique_ptr m_xOverlayCompareEntry;
std::unique_ptr m_xOverlayObject;
+void OverlayObject(std::vector&& aRanges);
+
void BringHeadingsToAttention(const SwOutlineNodes& rOutlineNodesArr);
void BringFramesToAttention(const std::vector&
rFrameFormats);
void BringBookmarksToAttention(const std::vector& rNames);
diff --git a/sw/source/uibase/utlui/content.cxx
b/sw/source/uibase/utlui/content.cxx
index 7853b1c30f90..42c6168a7eb7 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -1150,6 +1150,8 @@ SwContentTree::~SwContentTree()
IMPL_LINK(SwContentTree, MouseMoveHdl, const MouseEvent&, rMEvt, bool)
{
+if (m_eState == State::HIDDEN)
+return false;
if (rMEvt.IsLeaveWindow())
{
m_aOverlayObjectDelayTimer.Stop();
@@ -1180,8 +1182,8 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const MouseEvent&,
rMEvt, bool)
{
SwContent* pCnt =
weld::fromId(m_xTreeView->get_id(*xEntry));
const ContentTypeId nType = pCnt->GetParent()->GetType();
-if (rMEvt.IsEnterWindow() ||
-m_xTreeView->iter_compare(*xEntry,
*m_xOverlayCompareEntry) != 0)
+if (!pCnt->IsInvisible() && (rMEvt.IsEnterWindow() ||
+m_xTreeView->iter_compare(*xEntry,
*m_xOverlayCompareEntry) != 0))
{
if (nType == ContentTypeId::OUTLINE)
{
@@ -1217,23 +1219,9 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
else if (nType == ContentTypeId::REGION)
{
const SwSectionFormats& rFormats =
m_pActiveShell->GetDoc()->GetSections();
-if (const size_t nSize = rFormats.size())
-{
-auto aEntryName = pCnt->GetName();
-for (SwSectionFormats::size_type n = nSize; n;)
-{
-if (const SwSectionFormat* pFormat = rFormats[--n])
-{
-const SwSection* pSect = pFormat->GetSection();
-if (pSect && !pSect->IsHiddenFlag() &&
-pSect->GetSectionName() == aEntryName)
-{
-BringFramesToAttention(std::vector {pFormat});
-break;
-}
-}
-}
-}
+const SwSectionFormat* pFormat =
rFormats.FindFormatByName(pCnt->GetName());
+if (pFormat)
+BringFramesToAttention(std::vector {pFormat});
}
else if (nType == ContentTypeId::URLFIELD)
{
@@ -1260,11 +1248,8 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
}
else if (nType == ContentTypeId::DRAWOBJECT)
{
-if (!pCnt->IsInvisible())
-{
-std::vector aSdrObjectArr
{GetDrawingObjectsByContent(pCnt)};
-BringDrawingObjectsToAttention(aSdrObjectArr);
-}
+std::vector aSdrObjectArr
{GetDrawingObjectsByContent(pCnt)};
+BringDrawingObjectsToAttention(aSdrObjectArr);
}
else if (nType == ContentTypeId::TEXTFIELD)
{
@@ -1300,47 +1285,40 @@ IMPL_LINK(SwContentTree, MouseMoveHdl, const
MouseEvent&, rMEvt, bool)
else if (nType ==
[Libreoffice-commits] core.git: vcl/source
vcl/source/treelist/svimpbox.cxx |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
New commits:
commit eef94d7b4360e17ba21577fe52bd60214bd5280c
Author: Jim Raykowski
AuthorDate: Thu Dec 15 21:23:49 2022 -0900
Commit: Jim Raykowski
CommitDate: Sat Dec 17 05:07:19 2022 +
tdf#152517 Fix gen backend treeview ctrl+minus behavior
For gen type backends, makes the cursor node and all sub nodes
collapsed on ctrl+minus key input.
Change-Id: I53730aca29dd47766cfe8b4cdc81539633ebd8c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144286
Tested-by: Jenkins
Reviewed-by: Jim Raykowski
diff --git a/vcl/source/treelist/svimpbox.cxx b/vcl/source/treelist/svimpbox.cxx
index 63b4d928bfd5..b5efa69aa19d 100644
--- a/vcl/source/treelist/svimpbox.cxx
+++ b/vcl/source/treelist/svimpbox.cxx
@@ -2392,9 +2392,12 @@ bool SvImpLBox::KeyInput( const KeyEvent& rKEvt)
case KEY_SUBTRACT:
if (m_pView->IsExpanded(m_pCursor))
-m_pView->Collapse(m_pCursor);
-if (bMod1)
-CollapseTo(m_pTree->GetRootLevelParent(m_pCursor));
+{
+if (bMod1)
+CollapseTo(m_pCursor);
+else
+m_pView->Collapse(m_pCursor);
+}
break;
case KEY_MULTIPLY:
[Libreoffice-bugs] [Bug 86209] MENUS: Reorganize the View menu
https://bugs.documentfoundation.org/show_bug.cgi?id=86209 --- Comment #11 from Mathew Aderson --- Each action (add, edit, remove, or move) when updating your menus counts as a change. When you reach 200 changes, you are unable to take any more action until you save your menu changes. https://wordhurdle.co -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147565] Browsing comments in the navigation pane also browses hidden solved comments
https://bugs.documentfoundation.org/show_bug.cgi?id=147565 --- Comment #19 from Mathew Aderson --- I'm glad the problem is solved, thank you for sharing this information! https://fnfonline.co/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152507] Database table content not read or displayed in UI with an existing connection to ODB file
https://bugs.documentfoundation.org/show_bug.cgi?id=152507 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon in old high contrast theme extension disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 --- Comment #7 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152356] Show indication when clicking on a template in canvas
https://bugs.documentfoundation.org/show_bug.cgi?id=152356 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149183] difficulté utilisation calc suite migration en 7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=149183 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon in old high contrast theme extension disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 QA Administrators changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152348] LibreOffice Writer crash after installing Help on 4GB memory RAM
https://bugs.documentfoundation.org/show_bug.cgi?id=152348 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149183] difficulté utilisation calc suite migration en 7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=149183 --- Comment #3 from QA Administrators --- Dear air...@neuf.fr, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145336] Crash on setting table borders in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=145336 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145336] Crash on setting table borders in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=145336 --- Comment #5 from QA Administrators --- Dear Kat, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144023] Special character window not usable on Ubuntu 20.04 LTS
https://bugs.documentfoundation.org/show_bug.cgi?id=144023 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144023] Special character window not usable on Ubuntu 20.04 LTS
https://bugs.documentfoundation.org/show_bug.cgi?id=144023 --- Comment #4 from QA Administrators --- Dear JaK, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142707] PDF: Export to PDF of relative hyperlinks created by function HYPERLINK() not plausible
https://bugs.documentfoundation.org/show_bug.cgi?id=142707 QA Administrators changed: What|Removed |Added Resolution|--- |INSUFFICIENTDATA Status|NEEDINFO|RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 127593] [META] Python Macro bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=127593 Bug 127593 depends on bug 141337, which changed state. Bug 141337 Summary: Python doc.Sheets.copyByName(existingname, newname, position) does not update references in chart when copying sheets https://bugs.documentfoundation.org/show_bug.cgi?id=141337 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142707] PDF: Export to PDF of relative hyperlinks created by function HYPERLINK() not plausible
https://bugs.documentfoundation.org/show_bug.cgi?id=142707 --- Comment #5 from QA Administrators --- Dear Norbert Scheibner, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141337] Python doc.Sheets.copyByName(existingname, newname, position) does not update references in chart when copying sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=141337 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141337] Python doc.Sheets.copyByName(existingname, newname, position) does not update references in chart when copying sheets
https://bugs.documentfoundation.org/show_bug.cgi?id=141337 --- Comment #4 from QA Administrators --- Dear nib70776, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140238] LibreOffice Base - Table Control - navigating using tab and / keys not working as it used to
https://bugs.documentfoundation.org/show_bug.cgi?id=140238 --- Comment #4 from QA Administrators --- Dear Tony, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 84032] Intersection of some polygons produces wrong result
https://bugs.documentfoundation.org/show_bug.cgi?id=84032 --- Comment #9 from QA Administrators --- Dear vvort, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138980] CTRL+A cut doesn't include image frame/ with image if record changes being enabled
https://bugs.documentfoundation.org/show_bug.cgi?id=138980 --- Comment #3 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138765] set the displayed size of an image inserted in Writer by changing its DPI
https://bugs.documentfoundation.org/show_bug.cgi?id=138765 --- Comment #6 from QA Administrators --- Dear skierpage, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115270] LibreOffice Impress export *.SVG = fail. Usage of "javascript:window" in a TEXT Link results in fundamentally flawed behavior in the web browser.
https://bugs.documentfoundation.org/show_bug.cgi?id=115270 --- Comment #7 from QA Administrators --- Dear UbunLibOffImp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138588] it is can not make duplication (copy) Zotero citation.
https://bugs.documentfoundation.org/show_bug.cgi?id=138588 --- Comment #2 from QA Administrators --- Dear SergeiD, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118054] Writer doesn't show the initial image before cropping in the background (like Calc/Impress/Draw)
https://bugs.documentfoundation.org/show_bug.cgi?id=118054 --- Comment #6 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 117953] VIEWING: Default text position in form text box changes with scale (zoom) when aligned to right in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=117953 --- Comment #5 from QA Administrators --- Dear cdlvcdlv, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 115590] Image position is wrong, if svg:x and svg:y does not exist
https://bugs.documentfoundation.org/show_bug.cgi?id=115590 --- Comment #11 from QA Administrators --- Dear Regina Henschel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152521] Thick ugly black border around boolean tickbox in database table grid view
https://bugs.documentfoundation.org/show_bug.cgi?id=152521 --- Comment #7 from m.a.riosv --- Created attachment 184203 --> https://bugs.documentfoundation.org/attachment.cgi?id=184203=edit Screnshoot You are right, hope this is the one. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 altasilvap...@gmail.com changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #4 from altasilvap...@gmail.com --- Sorry for the delay; I was finally able to get back to this. I am now updated to 7.4.3.2, and can confirm the described behavior persists. I've also uploaded two test documents that I used to confirm the error: "FromDesktop.odt" 1. Right-click on desktop 2. Context menu "New" 3. Select "Open Document Text" "FromFileNew.odt" 1. Open LibreOffice 2. File menu 3. New -> Text Document Then in each file, I inserted a table of a random size, set the properties of said table to have no boundary, and then tried toggling "Show Text Boundaries" and "Show Table Boundaries". -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 --- Comment #3 from altasilvap...@gmail.com --- Created attachment 184202 --> https://bugs.documentfoundation.org/attachment.cgi?id=184202=edit Test file created from Windows Right-Click Context->New->Open Document Text -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152228] Inconsistent "Show Boundaries" behavior based on document creation method
https://bugs.documentfoundation.org/show_bug.cgi?id=152228 --- Comment #2 from altasilvap...@gmail.com --- Created attachment 184201 --> https://bugs.documentfoundation.org/attachment.cgi?id=184201=edit Test file created from LibreOffice File->New->Text Document -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152561] New: Consistent appearance of pop-ups and Appearance background
https://bugs.documentfoundation.org/show_bug.cgi?id=152561 Bug ID: 152561 Summary: Consistent appearance of pop-ups and Appearance background Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aschw...@acm.org Description: ENHANCEMENT: Would it be possible to have the Tools->Options->LIbreOffice->Appearance setting effect pop-ups? I have selected LibreOffice Dark for appearance, and would like the pop-ups to reflect this selection. Steps to Reproduce: 1. Point and Click and option in the option bar 2. Observe pop-up Actual Results: Pop-up appears in Libre Office default Appearance Expected Results: Same result Reproducible: Always User Profile Reset: No Additional Info: SEE ABOVE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152560] New: Consisgtent appearance of pop-ups and Appearance background
https://bugs.documentfoundation.org/show_bug.cgi?id=152560 Bug ID: 152560 Summary: Consisgtent appearance of pop-ups and Appearance background Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: aschw...@acm.org Description: ENHANCEMENT: Would it be possible to have the Tools->Options->LIbreOffice->Appearance setting effect pop-ups? I have selected LibreOffice Dark for appearance, and would like the pop-ups to reflect this selection. Steps to Reproduce: 1. Point and Click and option in the option bar 2. Observe pop-up Actual Results: Pop-up appears in Libre Office default Appearance Expected Results: Same result Reproducible: Always User Profile Reset: No Additional Info: SEE ABOVE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/sfxbasemodel.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 8635c9aa8c6f1078a9e220076d5a08daf30077e8
Author: Armin Le Grand (allotropia)
AuthorDate: Fri Dec 16 16:57:46 2022 +0100
Commit: Thorsten Behrens
CommitDate: Fri Dec 16 22:25:23 2022 +
Use xKeepAlive instead of m_pData
There is already an instance to keep the incarnation
alive, but it was not used. Instead m_pData can indeed
get deleted (nullptr), so better use the alive one.
Change-Id: Icdb6c841408254142561db408f876618adbc0b76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144340
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 9948aadf0d37..bcdc9f1be845 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -3259,7 +3259,7 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
return;
comphelper::OInterfaceContainerHelper2* pIC =
-m_pData->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
+xKeepAlive->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
if ( pIC )
{
SAL_INFO("sfx.doc", "SfxDocumentEvent: " + aName);
@@ -3272,7 +3272,7 @@ void SfxBaseModel::postEvent_Impl( const OUString& aName,
const Reference< frame
aDocumentEvent ) );
}
-pIC = m_pData->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
+pIC = xKeepAlive->m_aInterfaceContainer.getContainer(
cppu::UnoType::get());
if ( pIC )
{
SAL_INFO("sfx.doc", "SfxEvent: " + aName);
[Libreoffice-commits] core.git: include/xmloff reportdesign/source sdext/source writerperfect/source
include/xmloff/xmlimp.hxx |2 +-
reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx |3 ++-
sdext/source/pdfimport/sax/emitcontext.cxx |3 ++-
writerperfect/source/common/DocumentHandler.cxx |3 ++-
4 files changed, 7 insertions(+), 4 deletions(-)
New commits:
commit 5f70b0b9f6bc4ab145ddbd9155590ed4a3b1b9ec
Author: Stephan Bergmann
AuthorDate: Thu Dec 15 14:49:35 2022 +0100
Commit: Stephan Bergmann
CommitDate: Fri Dec 16 22:03:14 2022 +
loplugin:unocast (SvXMLImport)
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)
Change-Id: I773095e51958a0a050bcece6f44fe3847f962eaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144333
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/include/xmloff/xmlimp.hxx b/include/xmloff/xmlimp.hxx
index 26873175268d..14c7b92556b1 100644
--- a/include/xmloff/xmlimp.hxx
+++ b/include/xmloff/xmlimp.hxx
@@ -176,7 +176,7 @@ public:
virtual void SAL_CALL setDocumentLocator(const css::uno::Reference<
css::xml::sax::XLocator > & xLocator) override;
};
-class XMLOFF_DLLPUBLIC SAL_LOPLUGIN_ANNOTATE("crosscast") SvXMLImport : public
cppu::WeakImplHelper<
+class XMLOFF_DLLPUBLIC SvXMLImport : public cppu::WeakImplHelper<
css::xml::sax::XFastDocumentHandler,
css::lang::XServiceInfo,
css::lang::XInitialization,
diff --git a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
index eb3da46309f8..3f919548d47d 100644
--- a/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
+++ b/reportdesign/source/filter/xml/xmlImportDocumentHandler.cxx
@@ -28,6 +28,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -339,7 +340,7 @@ void SAL_CALL ImportDocumentHandler::initialize( const
uno::Sequence< uno::Any >
if (!m_xDocumentHandler.is() || !m_xModel.is())
throw uno::Exception("no delegatee and no model", nullptr);
-m_xDelegatee.set(new
SvXMLLegacyToFastDocHandler(dynamic_cast(m_xDocumentHandler.get(;
+m_xDelegatee.set(new
SvXMLLegacyToFastDocHandler(comphelper::getFromUnoTunnel(m_xDocumentHandler)));
m_xDatabaseDataProvider.set(m_xModel->getDataProvider(),uno::UNO_QUERY);
if ( !m_xDatabaseDataProvider.is() )
diff --git a/sdext/source/pdfimport/sax/emitcontext.cxx
b/sdext/source/pdfimport/sax/emitcontext.cxx
index a923488d688d..59f110191bfd 100644
--- a/sdext/source/pdfimport/sax/emitcontext.cxx
+++ b/sdext/source/pdfimport/sax/emitcontext.cxx
@@ -25,6 +25,7 @@
#include
#include
#include
+#include
#include
#if OSL_DEBUG_LEVEL > 0
@@ -42,7 +43,7 @@ SaxEmitter::SaxEmitter( const uno::Reference<
xml::sax::XDocumentHandler >& xDoc
m_xDocHdl( xDocHdl )
{
OSL_PRECOND(m_xDocHdl.is(), "SaxEmitter(): invalid doc handler");
-if (SvXMLImport *pFastHandler =
dynamic_cast(m_xDocHdl.get()))
+if (SvXMLImport *pFastHandler =
comphelper::getFromUnoTunnel(m_xDocHdl))
m_xDocHdl.set( new SvXMLLegacyToFastDocHandler( pFastHandler ) );
try
{
diff --git a/writerperfect/source/common/DocumentHandler.cxx
b/writerperfect/source/common/DocumentHandler.cxx
index 6b5ffe58ad9e..6cf42c168a51 100644
--- a/writerperfect/source/common/DocumentHandler.cxx
+++ b/writerperfect/source/common/DocumentHandler.cxx
@@ -15,6 +15,7 @@
#include
#include
+#include
#include
#include
@@ -115,7 +116,7 @@ using com::sun::star::xml::sax::XDocumentHandler;
DocumentHandler::DocumentHandler(Reference const& xHandler)
: mxHandler(xHandler)
{
-if (SvXMLImport* pFastHandler =
dynamic_cast(mxHandler.get()))
+if (SvXMLImport* pFastHandler =
comphelper::getFromUnoTunnel(mxHandler))
mxHandler.set(new SvXMLLegacyToFastDocHandler(pFastHandler));
}
[Libreoffice-bugs] [Bug 144906] CRASH when editing date field
https://bugs.documentfoundation.org/show_bug.cgi?id=144906 Caolán McNamara changed: What|Removed |Added CC||caol...@redhat.com --- Comment #7 from Caolán McNamara --- Seeing as the bt suggests SwContentTree is involved, is there a floating Navigator open at the time (the one from F5) or a Navigator open in the sidebar? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon in old high contrast theme extension disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 --- Comment #6 from Artur Wdo --- In OpenOffice is work fine. Before changes icon is dark and after any changes icon become blue. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152514] Save icon in old high contrast theme extension disappears after any changes
https://bugs.documentfoundation.org/show_bug.cgi?id=152514 --- Comment #5 from Artur Wdo --- Created attachment 184200 --> https://bugs.documentfoundation.org/attachment.cgi?id=184200=edit issue In alpha version behavior is the same. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/a11yfactory.mm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d6d15a2a4fd05af0cb66a69a789fcb1e81b59c05 Author: Andrea Gelmini AuthorDate: Fri Dec 16 22:15:10 2022 +0100 Commit: Julien Nabet CommitDate: Fri Dec 16 21:31:15 2022 + Fix typo Change-Id: I06d3c1be277efd0bfff3e3389f9f42ba6538e4c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144349 Tested-by: Julien Nabet Reviewed-by: Julien Nabet diff --git a/vcl/osx/a11yfactory.mm b/vcl/osx/a11yfactory.mm index d4b0e25047fb..56ffa9f7e008 100644 --- a/vcl/osx/a11yfactory.mm +++ b/vcl/osx/a11yfactory.mm @@ -176,7 +176,7 @@ static bool enabled = false; // -[AquaA11yWrapper childrenAttribute] is called by a // wrapper that is already attached to an NSWindow. That is // normal. What isn't normal is that the child wrapper's -// unignored accessible parent is a differnt wrapper than +// unignored accessible parent is a different wrapper than // the caller and that different wrapper is not yet // attached to an NSWindow. // TODO: switch the AquaA11yWrapper class to inherit the
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - svx/source
svx/source/tbxctrls/tbcontrl.cxx | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
New commits:
commit 163be7c572ae19d6c28bd4fb8b586f48a96c
Author: Caolán McNamara
AuthorDate: Fri Dec 16 11:42:20 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 21:19:01 2022 +
likely fix for frequent pShell->GetStyleSheetPool crash
SfxObjectShell: :Current can return null, it's based on the equally vile
SfxViewFrame: :Current
Change-Id: I1d937b92188deb06eef36af5d0835e173d588d2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144304
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 18b6eab37c62..b1f54a303e13 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1363,15 +1363,16 @@ void SvxStyleBox_Base::SetupEntry(vcl::RenderContext&
rRenderContext, sal_Int32
return;
SfxObjectShell *pShell = SfxObjectShell::Current();
+if (!pShell)
+return;
+
SfxStyleSheetBasePool* pPool = pShell->GetStyleSheetPool();
-SfxStyleSheetBase* pStyle = nullptr;
+if (!pPool)
+return;
-if ( pPool )
-{
-pStyle = pPool->First(eStyleFamily);
-while (pStyle && pStyle->GetName() != rStyleName)
-pStyle = pPool->Next();
-}
+SfxStyleSheetBase* pStyle = pPool->First(eStyleFamily);
+while (pStyle && pStyle->GetName() != rStyleName)
+pStyle = pPool->Next();
if (!pStyle )
return;
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - svx/source
svx/source/dialog/rubydialog.cxx|3 -
svx/source/gallery2/galctrl.cxx |3 -
svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx | 12 ++--
svx/source/sidebar/text/TextCharacterSpacingControl.cxx | 12 +++-
svx/source/sidebar/text/TextUnderlineControl.cxx| 40 +---
5 files changed, 42 insertions(+), 28 deletions(-)
New commits:
commit 97e0489bc9f424d2ed8fec9abcb2a04432e9425e
Author: Caolán McNamara
AuthorDate: Thu Dec 15 19:42:52 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 21:18:27 2022 +
svx: check SfxViewFrame::Current()
these ones look potentially worth backporting
Change-Id: Ie7325cd5548c0c10c6b6df9c1a771d24b029b635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144256
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svx/source/dialog/rubydialog.cxx b/svx/source/dialog/rubydialog.cxx
index 30ae2f1a30d7..c2d3969012f5 100644
--- a/svx/source/dialog/rubydialog.cxx
+++ b/svx/source/dialog/rubydialog.cxx
@@ -280,9 +280,10 @@ void SvxRubyDialog::Activate()
// tdf#141967/tdf#152495 if Activate is called during tear down bail
early
return;
}
+
//get selection from current view frame
SfxViewFrame* pCurFrm = SfxViewFrame::Current();
-Reference xCtrl = pCurFrm->GetFrame().GetController();
+Reference xCtrl(pCurFrm ? pCurFrm->GetFrame().GetController()
: nullptr);
m_pImpl->SetController(xCtrl);
if (!m_pImpl->HasSelectionChanged())
return;
diff --git a/svx/source/gallery2/galctrl.cxx b/svx/source/gallery2/galctrl.cxx
index bd17df54b737..ae9de1ce77b8 100644
--- a/svx/source/gallery2/galctrl.cxx
+++ b/svx/source/gallery2/galctrl.cxx
@@ -205,7 +205,8 @@ void GalleryPreview::PreviewMedia( const INetURLObject&
rURL )
if (!pFloater)
{
-SfxViewFrame::Current()->GetBindings().GetDispatcher()->Execute(
SID_AVMEDIA_PLAYER, SfxCallMode::SYNCHRON );
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pViewFrm->GetBindings().GetDispatcher()->Execute(
SID_AVMEDIA_PLAYER, SfxCallMode::SYNCHRON );
pFloater = avmedia::getMediaFloater();
}
diff --git a/svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx
b/svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx
index 4283f3651136..fee659817a14 100644
--- a/svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx
+++ b/svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx
@@ -346,8 +346,11 @@ void ParaLineSpacingControl::ExecuteLineSpace()
break;
}
-SfxViewFrame::Current()->GetBindings().GetDispatcher()->ExecuteList(
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+{
+pViewFrm->GetBindings().GetDispatcher()->ExecuteList(
SID_ATTR_PARA_LINESPACE, SfxCallMode::RECORD, { });
+}
}
void ParaLineSpacingControl::SetLineSpace(SvxLineSpacingItem& rLineSpace,
sal_Int32 eSpace, tools::Long lValue)
@@ -423,11 +426,10 @@ void ParaLineSpacingControl::ExecuteLineSpacing(sal_Int32
nEntry)
SetLineSpace(aSpacing, nEntry);
-SfxViewFrame* pCurrent = SfxViewFrame::Current();
-if( pCurrent )
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
{
-pCurrent->GetBindings().GetDispatcher()->ExecuteList(
-SID_ATTR_PARA_LINESPACE, SfxCallMode::RECORD, { });
+pViewFrm->GetBindings().GetDispatcher()->ExecuteList(
+SID_ATTR_PARA_LINESPACE, SfxCallMode::RECORD, { });
}
// close when the user used the buttons
diff --git a/svx/source/sidebar/text/TextCharacterSpacingControl.cxx
b/svx/source/sidebar/text/TextCharacterSpacingControl.cxx
index b2b2f87a4b08..ad96504777fb 100644
--- a/svx/source/sidebar/text/TextCharacterSpacingControl.cxx
+++ b/svx/source/sidebar/text/TextCharacterSpacingControl.cxx
@@ -106,8 +106,9 @@ TextCharacterSpacingControl::~TextCharacterSpacingControl()
void TextCharacterSpacingControl::Initialize()
{
-const SvxKerningItem* pKerningItem;
-SfxItemState eState =
SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_CHAR_KERNING,
pKerningItem);
+const SvxKerningItem* pKerningItem(nullptr);
+SfxViewFrame* pViewFrm = SfxViewFrame::Current();
+SfxItemState eState = pViewFrm ?
pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_CHAR_KERNING,
pKerningItem) : SfxItemState::UNKNOWN;
tools::Long nKerning = 0;
@@ -163,8 +164,11 @@ void
TextCharacterSpacingControl::ExecuteCharacterSpacing(tools::Long nValue, bo
SvxKerningItem aKernItem(nSign * nKern, SID_ATTR_CHAR_KERNING);
-
SfxViewFrame::Current()->GetBindings().GetDispatcher()->ExecuteList(SID_ATTR_CHAR_KERNING,
-SfxCallMode::RECORD, { });
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+{
+
pViewFrm->GetBindings().GetDispatcher()->ExecuteList(SID_ATTR_CHAR_KERNING,
+
[Libreoffice-commits] core.git: cui/source desktop/source extensions/source include/svx scripting/source sc/source sd/source sfx2/source svx/source sw/source
cui/source/dialogs/SignSignatureLineDialog.cxx|8 +
cui/source/dialogs/srchxtra.cxx | 62 -
cui/source/dialogs/zoom.cxx |8 -
cui/source/tabpages/autocdlg.cxx |3
cui/source/tabpages/border.cxx|3
cui/source/tabpages/chardlg.cxx |7 -
cui/source/tabpages/numfmt.cxx|8 -
cui/source/tabpages/numpages.cxx | 15 +-
cui/source/tabpages/page.cxx |3
cui/source/tabpages/paragrph.cxx |6
desktop/source/lib/init.cxx |8 -
extensions/source/bibliography/general.cxx|3
include/svx/ClassificationDialog.hxx |5
sc/source/ui/attrdlg/attrdlg.cxx |2
sc/source/ui/drawfunc/drtxtob.cxx | 13 +-
sc/source/ui/styleui/styledlg.cxx |3
sc/source/ui/view/editsh.cxx |5
scripting/source/protocolhandler/scripthandler.cxx|3
sd/source/ui/animations/CustomAnimationDialog.cxx |3
sd/source/ui/app/sdmod2.cxx |5
sd/source/ui/sidebar/SlideBackground.cxx | 54 +---
sd/source/ui/view/drviews2.cxx| 34 +++--
sfx2/source/dialog/securitypage.cxx |8 -
svx/source/dialog/ClassificationDialog.cxx|7 -
svx/source/form/datanavi.cxx |2
svx/source/sidebar/area/AreaPropertyPanelBase.cxx | 75 ++--
svx/source/sidebar/nbdtmg.cxx |8 -
svx/source/tbxctrls/fillctrl.cxx | 27 ++--
svx/source/tbxctrls/linectrl.cxx |8 -
sw/source/core/edit/edfcol.cxx| 16 +-
sw/source/ui/dialog/docstdlg.cxx |4
sw/source/ui/fldui/fldedt.cxx |4
sw/source/uibase/app/docsh2.cxx | 50
sw/source/uibase/ribbar/workctrl.cxx |8 -
sw/source/uibase/shells/annotsh.cxx |5
sw/source/uibase/shells/drwtxtex.cxx |3
sw/source/uibase/sidebar/PageStylesPanel.cxx | 112 ++
sw/source/uibase/sidebar/StylePresetsPanel.cxx| 15 +-
sw/source/uibase/sidebar/WriterInspectorTextPanel.cxx | 20 +--
39 files changed, 348 insertions(+), 285 deletions(-)
New commits:
commit 1726c27e0d633ab04843834d2bf987bc7645807f
Author: Caolán McNamara
AuthorDate: Fri Dec 16 12:11:38 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 21:17:15 2022 +
check SfxObjectShell::Current()
SfxObjectShell::Current() can return null, it's based on the equally
vile SfxViewFrame::Current()
Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144339
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/dialogs/SignSignatureLineDialog.cxx
b/cui/source/dialogs/SignSignatureLineDialog.cxx
index 1f1bd4551080..94306764b201 100644
--- a/cui/source/dialogs/SignSignatureLineDialog.cxx
+++ b/cui/source/dialogs/SignSignatureLineDialog.cxx
@@ -156,7 +156,7 @@ IMPL_LINK_NOARG(SignSignatureLineDialog, chooseCertificate,
weld::Button&, void)
{
// Document needs to be saved before selecting a certificate
SfxObjectShell* pShell = SfxObjectShell::Current();
-if (!pShell->PrepareForSigning(m_xDialog.get()))
+if (!pShell || !pShell->PrepareForSigning(m_xDialog.get()))
return;
Reference xSignCertificate
@@ -193,6 +193,12 @@ void SignSignatureLineDialog::Apply()
}
SfxObjectShell* pShell = SfxObjectShell::Current();
+if (!pShell)
+{
+SAL_WARN("cui.dialogs", "No SfxObjectShell!");
+return;
+}
+
Reference xValidGraphic = getSignedGraphic(true);
Reference xInvalidGraphic = getSignedGraphic(false);
pShell->SignSignatureLine(m_xDialog.get(), m_aSignatureLineId,
m_xSelectedCertifate,
diff --git a/cui/source/dialogs/srchxtra.cxx b/cui/source/dialogs/srchxtra.cxx
index d857f77c42df..40c2e369ab6b 100644
--- a/cui/source/dialogs/srchxtra.cxx
+++ b/cui/source/dialogs/srchxtra.cxx
@@ -64,9 +64,7 @@ void SvxSearchFormatDialog::PageCreated(const OString& rId,
SfxTabPage& rPage)
if (rId == "font")
{
const FontList* pApm_pFontList = nullptr;
-SfxObjectShell* pSh = SfxObjectShell::Current();
-
-if ( pSh )
+if (SfxObjectShell* pSh = SfxObjectShell::Current())
{
const SvxFontListItem* pFLItem = static_cast(
pSh->GetItem( SID_ATTR_CHAR_FONTLIST ));
@@ -119,42 +117,44 @@
SvxSearchAttributeDialog::SvxSearchAttributeDialog(weld::Window* pParent,
SfxObjectShell* pSh =
[Libreoffice-bugs] [Bug 152559] Skia - LibreOffice Draw crashed when I zoom in the view of a diagram
https://bugs.documentfoundation.org/show_bug.cgi?id=152559 --- Comment #2 from robomurphy98 --- It can test fine when "playing around" by resizing the panel, zooming in and out of the drawing view, or changing the page orientation. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152559] Skia - LibreOffice Draw crashed when I zoom in the view of a diagram
https://bugs.documentfoundation.org/show_bug.cgi?id=152559 --- Comment #1 from robomurphy98 --- Created attachment 184199 --> https://bugs.documentfoundation.org/attachment.cgi?id=184199=edit When I resize the pages panel -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152559] New: Skia - LibreOffice Draw crashed when I zoom in the view of a diagram
https://bugs.documentfoundation.org/show_bug.cgi?id=152559 Bug ID: 152559 Summary: Skia - LibreOffice Draw crashed when I zoom in the view of a diagram Product: LibreOffice Version: 7.4.3.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pabloaria...@hotmail.com Description: Good evening everyone, I have Skia enabled in LibreOffice and I started to make a small entity relationship diagram. Before starting the document I made the pages panel smaller to have a better view and I began to draw. Everything was going well but it was to enlarge the view of the drawing with the mouse the view and in this... crash. It's not the first time this has happened to me, there are other times that just changing the size of the page panels also crashes. Steps to Reproduce: 1.Open LibreOffice Draw 2.Change the size of pages panel 3.Zoom in the drawing Actual Results: Crash Expected Results: Not crash Reproducible: Sometimes User Profile Reset: Yes Additional Info: Sometimes just changing the page panel size crashes, in Impress it once happened to me. -- You are receiving this mail because: You are the assignee for the bug.
Re: transparency <-> opacity in import from MS Office
Hi Miklos, Miklos Vajna schrieb am 16.12.2022 um 15:24: Hi Regina, On Thu, Dec 15, 2022 at 08:25:29PM +0100, Regina Henschel wrote: if a MS Office user sets 80% Transparency for a stroke, MS Office writes this as . That means, that MS Office writes it out as opacity (which corresponds to the OOXML spec). Yes, this matches my understanding. But if a MS Office user sets 80% Transparency for the fill or outline of a character, MS Office writes this as . That means, that the value means transparency. Up to now there was no problem as the character outline cannot be rendered at all in LibreOffice and character fill transparency could be rendered but is not imported yet. Hmm, this may be supported partially, at least I think it worked for me for one case in commit 3a749d7278bbe65cfc063e64460df8af6bc2af47 (sw: add DOCX import for semi-transparent text, 2020-01-15). Indeed. It works for "srgbClr". I run into bug tdf#130973. I think the case "schemeClr" is missing in TextEffectsHandler::GetTextFillSolidFillAlpha. So w14:alpha ==> CharFillTransparence works and uses transparency, and a:alpha ==> FillTransparence or LineTransparence works and uses opacity. But with implementing Fontwork this element will be rendered as stroke transparency. So somewhere a conversion from transparency to opacity has to be done. I could do this in Color::addTransformation() in general or I could do this isolated in my new Fontwork import. I would like to do this in Color::addTransformation(). What is your opinion on this? In general, I think oox::drawingml::Color is meant to represent OOXML's idea about a color. So converting the value there looks a bit odd, You are right. The problem only occurs in switching Fontwork on. So it is better to make the change at that place. but recording if the value means transparency or opacity (depending on if it comes from the "a" or "w14" namespaces) is fine. Color::addTransformation() drops the namespace and Color has no member to store a namespace, so the information whether it was a w14:alpha or a a:alpha is lost. Currently that seems to be no problem. And then once you arrive to the point where you would copy the value to an UNO API property, I do not write to UNO API property directly, but generate LineProperties and FillProperties objects and use their pushToPropMap methods. Otherwise I would need to duplicate the 300 lines of gradient handling which is included in pushToPropMap. there you can decide if the value in oox::drawingml::Color needs a conversion or not. At least that's how I would do it, if you ask me. :-) I have put is now where the Fontwork shape is created. It is now rColor.addTransformation( oox::NMSP_dml | oox::AttributeConversion::decodeToken((*it).Name), oox::drawingml::MAX_PERCENT - nNumber); Previously it was rColor.addTransformation( oox::NMSP_w14 | oox::AttributeConversion::decodeToken((*it).Name), nNumber); You will see it when the next version is uploaded. BTW: I make progress, dashes are handled now. Now I'm working on unit tests. But so short before Christmas there are a lot of other things to do. Thank you for looking at the problem. Kind regards, Regina
[Libreoffice-bugs] [Bug 152558] Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions
https://bugs.documentfoundation.org/show_bug.cgi?id=152558 --- Comment #1 from Colin --- Created attachment 184198 --> https://bugs.documentfoundation.org/attachment.cgi?id=184198=edit Simple .ods with examples -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152558] New: Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions
https://bugs.documentfoundation.org/show_bug.cgi?id=152558 Bug ID: 152558 Summary: Calc Cell Borders are inconsistent with the drop-down graphic selector. Also, No help page for manual definitions Product: LibreOffice Version: 7.3.7.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: that.man.co...@gmail.com Description: The drop-down graphic pane for selecting the cell border style presents incorrect graphic illustrations of the anticipated results. I'm also convinced there used to be a much thinner "default" single-line border. The help page associated with the cell format [F1] Help function doesn't exist Steps to Reproduce: Refer to the attached demonstration file. It may help to zoom the sheet Actual Results: Borders are inconsistent with the grsphic representations. Also, I'm convinced there was a "default" single outline defined as soon as an outline was selected. Now it's blank until the characteristics have been "selected" but it was much thinner than the current Outset option which presents as the thinnest line. Expected Results: Consistency. I suspect previous work on the outline function has erroneously left the programmers' experiments as the currently delivered defaults. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.7.2 (x64) / LibreOffice Community Build ID: e114eadc50a9ff8d8c8a0567d6da8f454beeb84f CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: sv-SE (en_GB); UI: en-GB Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152517] Navigator: Ctrl+Minus collapses the whole Headings tree, not the selected node
https://bugs.documentfoundation.org/show_bug.cgi?id=152517 --- Comment #7 from Jim Raykowski --- (In reply to Jim Raykowski from comment #6) > Yes, very interesting. It seems the styles list uses nullptr as the parent > for all entries[1] which makes[2] work as expected because of[3]. > > [1] > https://opengrok.libreoffice.org/xref/core/sfx2/source/dialog/StyleList. > cxx?r=ef862ba4#949 > [2] > https://opengrok.libreoffice.org/xref/core/vcl/source/treelist/svimpbox. > cxx?r=5f9cd841#2393 > [3] > https://opengrok.libreoffice.org/xref/core/vcl/source/treelist/treelist. > cxx?r=6e2bd112=29042=1020#1020 After further investigation, it seems there is something not right with SvTreeList::GetRootLevelParent. The only place I could find it called from is[2]. TreeListBox::GetRootLevelParent seems correct though[4]. [4] https://opengrok.libreoffice.org/xref/core/dbaccess/source/ui/control/dbtreelistbox.cxx?r=5f6596bd#485 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 138775] Hiding menubar is not permanent in Single or Standard Toolbar UIs
https://bugs.documentfoundation.org/show_bug.cgi?id=138775 --- Comment #6 from gilbertohasn...@gmail.com --- Hi, bug is still present in current version. Information from About LibreOffice: Version: 7.4.2.3 / LibreOffice Community Build ID: 40(Build:3) CPU threads: 12; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-GB Ubuntu package version: 1:7.4.2~rc3-0ubuntu0.20.04.1~lo1 Calc: threaded (In reply to QA Administrators from comment #5) > Dear gilbertohasnofb, > > To make sure we're focusing on the bugs that affect our users today, > LibreOffice QA is asking bug reporters and confirmers to retest open, > confirmed bugs which have not been touched for over a year. > > There have been thousands of bug fixes and commits since anyone checked on > this bug report. During that time, it's possible that the bug has been > fixed, or the details of the problem have changed. We'd really appreciate > your help in getting confirmation that the bug is still present. > > If you have time, please do the following: > > Test to see if the bug is still present with the latest version of > LibreOffice from https://www.libreoffice.org/download/ > > If the bug is present, please leave a comment that includes the information > from Help - About LibreOffice. > > If the bug is NOT present, please set the bug's Status field to > RESOLVED-WORKSFORME and leave a comment that includes the information from > Help - About LibreOffice. > > Please DO NOT > > Update the version field > Reply via email (please reply directly on the bug tracker) > Set the bug's Status field to RESOLVED - FIXED (this status has a particular > meaning that is not > appropriate in this case) > > > If you want to do more to help you can test to see if your issue is a > REGRESSION. To do so: > 1. Download and install oldest version of LibreOffice (usually 3.3 unless > your bug pertains to a feature added after 3.3) from > https://downloadarchive.documentfoundation.org/libreoffice/old/ > > 2. Test your bug > 3. Leave a comment with your results. > 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; > 4b. If the bug was not present in 3.3 - add 'regression' to keyword > > > Feel free to come ask questions or to say hello in our QA chat: > https://web.libera.chat/?settings=#libreoffice-qa > > Thank you for helping us make LibreOffice even better for everyone! > > Warm Regards, > QA Team > > MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-22.05.9-1'
Tag 'cp-22.05.9-1' created by Andras Timar at 2022-12-16 20:17 + cp-22.05.9-1 Changes since cp-22.05.6-1-2: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-22.05.9-1'
Tag 'cp-22.05.9-1' created by Andras Timar at 2022-12-16 20:17 + cp-22.05.9-1 Changes since cp-22.05.6-1-1: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-22.05.9-1'
Tag 'cp-22.05.9-1' created by Andras Timar at 2022-12-16 20:17 + cp-22.05.9-1 Changes since cp-22.05.5-2: Aron Budea (1): Add Persian (fa-IR) dictionary --- Dictionary_fa.mk | 21 Module_dictionaries.mk|1 fa_IR/LICENSE | 15 fa_IR/META-INF/manifest.xml |6 fa_IR/README_fa_IR.txt| 26 fa_IR/description.xml | 22 fa_IR/dictionaries.xcu| 19 fa_IR/fa-IR.aff | 217 fa_IR/fa-IR.dic |104025 ++ fa_IR/icon.png|binary fa_IR/package-description.txt |4 11 files changed, 104356 insertions(+) ---
[Libreoffice-commits] core.git: 2 commits - sw/source toolkit/source writerfilter/source
sw/source/filter/ww8/docxattributeoutput.cxx | 10 +++---
sw/source/filter/ww8/rtfattributeoutput.cxx | 16 +++-
sw/source/uibase/docvw/SidebarWinAcc.cxx |3 ++-
toolkit/source/helper/unowrapper.cxx |3 ++-
writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |7 ++-
writerfilter/source/rtftok/rtfdocumentimpl.cxx|9 +++--
6 files changed, 19 insertions(+), 29 deletions(-)
New commits:
commit 1ae71d8f09771ba7180be6ebdf89d36a31eb8625
Author: Stephan Bergmann
AuthorDate: Fri Dec 16 15:10:40 2022 +0100
Commit: Stephan Bergmann
CommitDate: Fri Dec 16 20:18:04 2022 +
Revert "fix math export/import in docx/rtf"
This reverts commit 2b5953a19e36a02040f2ff08bc87efe4785f80bd. Whatever that
"gcc4.4 (and 4.3 and possibly older) have a problem with dynamic_cast
directly
to the target class" issue actually was: For one, our GCC 7 baseline
presumably
would no longer have such an issue. And for another, the added asserts
that the
results of the dynamic_casts must be non-null were presumably all bogus (and
have in part been reverted again in the meantime), as all the sources are
UNO
interface types that can presumably point at implementation objects of other
than the expected C++ class types. (Those dynamic_casts from UNO interface
types will be addressed in a follow-up commit. See the upcoming commit
introducing loplugin:unocast on why such dynamic_casts are dangerous.)
Conflicts:
sw/qa/extras/ooxmlexport/ooxmlexport.cxx
sw/qa/extras/rtfexport/rtfexport.cxx
sw/source/filter/ww8/docxattributeoutput.cxx
sw/source/filter/ww8/rtfattributeoutput.cxx
writerfilter/Library_writerfilter.mk
writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
writerfilter/source/rtftok/rtfdocumentimpl.cxx
Change-Id: I0c330a3541e64ce08bfe30ff15d51a2fd8a243b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144336
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx
b/sw/source/filter/ww8/docxattributeoutput.cxx
index da951db02828..b78094da7401 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -99,7 +99,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -5986,14 +5985,11 @@ void DocxAttributeOutput::WritePostponedMath(const
SwOLENode* pPostponedMath, sa
SAL_WARN("sw.ww8", "Broken math object");
return;
}
-// gcc4.4 (and 4.3 and possibly older) have a problem with dynamic_cast
directly to the target class,
-// so help it with an intermediate cast. I'm not sure what exactly the problem
is, seems to be unrelated
-// to RTLD_GLOBAL, so most probably a gcc bug.
-oox::FormulaExportBase* formulaexport =
dynamic_cast(dynamic_cast(xInterface.get()));
-assert( formulaexport != nullptr );
-if (formulaexport)
+if( oox::FormulaExportBase* formulaexport = dynamic_cast<
oox::FormulaExportBase* >( xInterface.get()))
formulaexport->writeFormulaOoxml( m_pSerializer,
GetExport().GetFilter().getVersion(),
oox::drawingml::DOCUMENT_DOCX, nAlign);
+else
+OSL_FAIL( "Math OLE object cannot write out OOXML" );
}
void DocxAttributeOutput::WritePostponedFormControl(const SdrObject* pObject)
diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index cd2f81a2463e..e81a299ec9f9 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -66,7 +66,6 @@
#include
#include
#include
-#include
#include
#include
#include
@@ -4188,16 +4187,15 @@ bool RtfAttributeOutput::FlyFrameOLEMath(const
SwFlyFrameFormat* pFlyFrameFormat
uno::Reference xClosable = xObj->getComponent();
if (!xClosable.is())
return false;
-// gcc4.4 (and 4.3 and possibly older) have a problem with dynamic_cast
directly to the target class,
-// so help it with an intermediate cast. I'm not sure what exactly the
problem is, seems to be unrelated
-// to RTLD_GLOBAL, so most probably a gcc bug.
-auto pBase
-=
dynamic_cast(dynamic_cast(xClosable.get()));
-assert(pBase != nullptr);
-OStringBuffer aBuf;
+auto pBase = dynamic_cast(xClosable.get());
+SAL_WARN_IF(!pBase, "sw.rtf", "Math OLE object cannot write out RTF");
if (pBase)
+{
+OStringBuffer aBuf;
pBase->writeFormulaRtf(aBuf, m_rExport.GetCurrentEncoding());
-m_aRunText->append(aBuf);
+m_aRunText->append(aBuf);
+}
+
// Replacement graphic.
m_aRunText->append("{" LO_STRING_SVTOOLS_RTF_MMATHPICT " ");
FlyFrameOLEReplacement(pFlyFrameFormat, rOLENode, rSize);
diff --git
[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-22.05.9-1'
Tag 'cp-22.05.9-1' created by Andras Timar at 2022-12-16 20:17 + cp-22.05.9-1 Changes since cp-22.05.8-4-91: --- 0 files changed ---
[Libreoffice-commits] core.git: chart2/source include/sfx2 sfx2/source
chart2/source/controller/main/ChartController.cxx |4 ++--
include/sfx2/sidebar/SidebarController.hxx|7 ++-
sfx2/source/sidebar/SidebarController.cxx | 16 +---
3 files changed, 21 insertions(+), 6 deletions(-)
New commits:
commit 88b4f966202717cd4ad38a30a8eda22c3e69ed35
Author: Stephan Bergmann
AuthorDate: Tue Dec 13 13:42:10 2022 +0100
Commit: Stephan Bergmann
CommitDate: Fri Dec 16 20:17:34 2022 +
loplugin:unocast (sfx2::sidebar::SidebarController)
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)
Change-Id: Ib681b4eaa44c65b9da5988c74c03f1829e3a1507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144334
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
index 1a59bb161ec3..2ba57aa45d33 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -377,7 +377,7 @@ void SAL_CALL ChartController::attachFrame(
uno::Reference xSidebar =
getSidebarFromModel(getChartModel());
if (xSidebar.is())
{
-auto pSidebar =
dynamic_cast(xSidebar.get());
+auto pSidebar =
comphelper::getFromUnoTunnel(xSidebar);
assert(pSidebar);
pSidebar->registerSidebarForFrame(this);
pSidebar->updateModel(getChartModel());
@@ -761,7 +761,7 @@ void SAL_CALL ChartController::dispose()
if (getModel().is())
{
uno::Reference xSidebar =
getSidebarFromModel(getChartModel());
-if (sfx2::sidebar::SidebarController* pSidebar =
dynamic_cast(xSidebar.get()))
+if (sfx2::sidebar::SidebarController* pSidebar =
comphelper::getFromUnoTunnel(xSidebar))
{
pSidebar->unregisterSidebarForFrame(this);
}
diff --git a/include/sfx2/sidebar/SidebarController.hxx
b/include/sfx2/sidebar/SidebarController.hxx
index 208af98b2fc2..be0a12b3a671 100644
--- a/include/sfx2/sidebar/SidebarController.hxx
+++ b/include/sfx2/sidebar/SidebarController.hxx
@@ -33,6 +33,7 @@
#include
#include
#include
+#include
#include
#include
@@ -48,7 +49,8 @@ typedef comphelper::WeakComponentImplHelper <
css::beans::XPropertyChangeListener,
css::ui::XSidebar,
css::frame::XStatusListener,
-css::frame::XFrameActionListener
+css::frame::XFrameActionListener,
+css::lang::XUnoTunnel
> SidebarControllerInterfaceBase;
class SfxSplitWindow;
@@ -175,6 +177,9 @@ public:
static SidebarController* GetSidebarControllerForView(const SfxViewShell*
pViewShell);
+sal_Int64 SAL_CALL getSomething(css::uno::Sequence const &
aIdentifier) override;
+static css::uno::Sequence const & getUnoTunnelId();
+
private:
SidebarController(SidebarDockingWindow* pParentWindow, const SfxViewFrame*
pViewFrame);
diff --git a/sfx2/source/sidebar/SidebarController.cxx
b/sfx2/source/sidebar/SidebarController.cxx
index a35bb1f7488c..550b1e8cc5d7 100644
--- a/sfx2/source/sidebar/SidebarController.cxx
+++ b/sfx2/source/sidebar/SidebarController.cxx
@@ -41,6 +41,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -186,10 +187,10 @@ SidebarController*
SidebarController::GetSidebarControllerForFrame (
::comphelper::getProcessComponentContext(),
xController,
[] (uno::Reference const& xRef)
-{ return nullptr != dynamic_cast(xRef.get()); }
+{ return nullptr !=
comphelper::getFromUnoTunnel(xRef); }
));
-return dynamic_cast(xListener.get());
+return comphelper::getFromUnoTunnel(xListener);
}
void SidebarController::registerSidebarForFrame(const
css::uno::Reference& xController)
@@ -1646,7 +1647,16 @@ sfx2::sidebar::SidebarController*
SidebarController::GetSidebarControllerForView
if (!xSidebar.is())
return nullptr;
-return dynamic_cast(xSidebar.get());
+return
comphelper::getFromUnoTunnel(xSidebar);
+}
+
+sal_Int64 SidebarController::getSomething(css::uno::Sequence const &
aIdentifier) {
+return comphelper::getSomethingImpl(aIdentifier, this);
+}
+
+css::uno::Sequence const & SidebarController::getUnoTunnelId() {
+static comphelper::UnoIdInit const id;
+return id.getSeq();
}
} // end of namespace sfx2::sidebar
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a2ec3af0a5b2fd168021f29e607775d2811e8193 Author: Andras Timar AuthorDate: Fri Dec 16 21:17:30 2022 +0100 Commit: Andras Timar CommitDate: Fri Dec 16 21:17:30 2022 +0100 Bump version to 22.05.9.1 Change-Id: I82b945edf12d9cd22cb433ba0059076ba5b5e9eb diff --git a/configure.ac b/configure.ac index 4585a22fc362..f0f60015a33f 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([Collabora Office],[22.05.8.4],[],[],[https://collaboraoffice.com/]) +AC_INIT([Collabora Office],[22.05.9.1],[],[],[https://collaboraoffice.com/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-commits] core.git: 2 commits - chart2/source include/svx sdext/source svx/source
chart2/source/controller/sidebar/ChartLinePanel.cxx |3 ++-
include/svx/linectrl.hxx|8 +++-
sdext/source/presenter/PresenterController.cxx |8 ++--
sdext/source/presenter/PresenterController.hxx |6 --
sdext/source/presenter/PresenterScreen.cxx |2 +-
svx/source/sidebar/line/LinePropertyPanelBase.cxx |3 ++-
svx/source/tbxctrls/linectrl.cxx| 13 -
7 files changed, 30 insertions(+), 13 deletions(-)
New commits:
commit f1b7a69b280aefe2f1b3b0f32193494fd765f2bd
Author: Stephan Bergmann
AuthorDate: Thu Dec 15 20:45:53 2022 +0100
Commit: Stephan Bergmann
CommitDate: Fri Dec 16 20:17:17 2022 +
loplugin:unocast (SvxLineStyleToolBoxControl)
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)
Change-Id: I13f71f717a8661e0889ab7acf6fe7c7ebbe3dbe6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144332
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/chart2/source/controller/sidebar/ChartLinePanel.cxx
b/chart2/source/controller/sidebar/ChartLinePanel.cxx
index d9da9a2985ef..bc905c9d9900 100644
--- a/chart2/source/controller/sidebar/ChartLinePanel.cxx
+++ b/chart2/source/controller/sidebar/ChartLinePanel.cxx
@@ -25,6 +25,7 @@
#include
#include
+#include
#include
#include
@@ -35,7 +36,7 @@ namespace {
SvxLineStyleToolBoxControl* getLineStyleToolBoxControl(const
ToolbarUnoDispatcher& rToolBoxColor)
{
css::uno::Reference xController =
rToolBoxColor.GetControllerForCommand(".uno:XLineStyle");
-SvxLineStyleToolBoxControl* pToolBoxLineStyleControl =
dynamic_cast(xController.get());
+SvxLineStyleToolBoxControl* pToolBoxLineStyleControl =
comphelper::getFromUnoTunnel(xController);
return pToolBoxLineStyleControl;
}
diff --git a/include/svx/linectrl.hxx b/include/svx/linectrl.hxx
index e2cd9e6c8852..983242b776d2 100644
--- a/include/svx/linectrl.hxx
+++ b/include/svx/linectrl.hxx
@@ -19,6 +19,8 @@
#ifndef INCLUDED_SVX_LINECTRL_HXX
#define INCLUDED_SVX_LINECTRL_HXX
+#include
+#include
#include
#include
#include
@@ -35,7 +37,8 @@ typedef std::function LineStyleSele
typedef std::function LineStyleIsNoneFunction;
// SvxLineStyleController:
-class SVXCORE_DLLPUBLIC SvxLineStyleToolBoxControl final : public
svt::PopupWindowController
+class SVXCORE_DLLPUBLIC SvxLineStyleToolBoxControl final :
+public cppu::ImplInheritanceHelper
{
private:
std::unique_ptr m_xBtnUpdater;
@@ -53,6 +56,9 @@ public:
virtual OUString SAL_CALL getImplementationName() override;
virtual css::uno::Sequence SAL_CALL getSupportedServiceNames()
override;
+sal_Int64 SAL_CALL getSomething(css::uno::Sequence const &
aIdentifier) override;
+static css::uno::Sequence const & getUnoTunnelId();
+
virtual void SAL_CALL execute(sal_Int16 nKeyModifier) override;
virtual void SAL_CALL statusChanged(const css::frame::FeatureStateEvent&
rEvent) override;
diff --git a/svx/source/sidebar/line/LinePropertyPanelBase.cxx
b/svx/source/sidebar/line/LinePropertyPanelBase.cxx
index 454e16a335f8..d04b16103e6b 100644
--- a/svx/source/sidebar/line/LinePropertyPanelBase.cxx
+++ b/svx/source/sidebar/line/LinePropertyPanelBase.cxx
@@ -18,6 +18,7 @@
*/
#include
+#include
#include
#include
#include
@@ -57,7 +58,7 @@ namespace
SvxLineStyleToolBoxControl* getLineStyleToolBoxControl(const
ToolbarUnoDispatcher& rToolBoxColor)
{
css::uno::Reference xController =
rToolBoxColor.GetControllerForCommand(".uno:XLineStyle");
-SvxLineStyleToolBoxControl* pToolBoxLineStyleControl =
dynamic_cast(xController.get());
+SvxLineStyleToolBoxControl* pToolBoxLineStyleControl =
comphelper::getFromUnoTunnel(xController);
return pToolBoxLineStyleControl;
}
}
diff --git a/svx/source/tbxctrls/linectrl.cxx b/svx/source/tbxctrls/linectrl.cxx
index 81f064fc78f4..b75fee2d88b0 100644
--- a/svx/source/tbxctrls/linectrl.cxx
+++ b/svx/source/tbxctrls/linectrl.cxx
@@ -48,6 +48,7 @@
#include
#include
+#include
using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::beans;
@@ -60,7 +61,7 @@ using namespace ::com::sun::star;
#define MAX_LINES 12
SvxLineStyleToolBoxControl::SvxLineStyleToolBoxControl( const
css::uno::Reference& rContext )
-: svt::PopupWindowController( rContext, nullptr, OUString() )
+: ImplInheritanceHelper( rContext, nullptr, OUString() )
{
addStatusListener(".uno:LineDash");
}
@@ -217,6 +218,16 @@ css::uno::Sequence
SvxLineStyleToolBoxControl::getSupportedServiceName
return { "com.sun.star.frame.ToolbarController" };
}
+sal_Int64
SvxLineStyleToolBoxControl::getSomething(css::uno::Sequence const &
aIdentifier)
+{
+return comphelper::getSomethingImpl(aIdentifier, this);
+}
+
+css::uno::Sequence const &
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - formula/source
formula/source/core/api/FormulaCompiler.cxx | 14 ++
1 file changed, 14 insertions(+)
New commits:
commit 4574c4d796d285993b88075c7d003060b7ab5757
Author: Eike Rathke
AuthorDate: Thu Dec 15 18:29:57 2022 +0100
Commit: Eike Rathke
CommitDate: Fri Dec 16 20:13:03 2022 +
crashtesting: assert seen on loading forum-mso-en4-573860.xlsx
While resolving named expression Pinnacle3
IF(AND(Pinnacle1+Pinnacle2<>11,Pinnacle1+Pinnacle2<>22,Pinnacle1+Pinnacle2>9),SUM(MID(Pinnacle1+Pinnacle2,1,1),MID(Pinnacle1+Pinnacle2,2,1)),Pinnacle1+Pinnacle2)
where resolving and inserting named expressions Pinnacle1
IF(AND(SUM($Sheet1.$D$3:$E$3)<>11;SUM($Sheet1.$D$3:$E$3)<>22;SUM($Sheet1.$D$3:$E$3)>9);SUM(MID(SUM($Sheet1.$D$3:$E$3);1;1);MID(SUM($Sheet1.$D$3:$E$3);2;1));SUM($Sheet1.$D$3:$E$3))
and Pinnacle2
IF(AND(Logic1<>11;Logic1<>22;Logic1>9);SUM(MID(Logic1;1;1);MID(Logic1;2;1));Logic1)
with Logic1
IF($Sheet1.$E$3+NilaiTahun>10;SUM(MID($Sheet1.$E$3+NilaiTahun;1;1);MID($Sheet1.$E$3+NilaiTahun;2;1));$Sheet1.$E$3+NilaiTahun)
with NilaiTahun
IF(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1))<10;SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));SUM(MID(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));1;1);SUM(MID(SUM(MID($Sheet1.$F$3;1;1);MID($Sheet1.$F$3;2;1);MID($Sheet1.$F$3;3;1);MID($Sheet1.$F$3;4;1));2;1
overall exceeds FORMULA_MAXTOKENS (8192) in the generated RPN
code, hence an ocStop is encountered as factor token.
(this cries for generating subroutine call token arrays where each
named expression could have their own RPN code and interim results
could be remembered for each while interpreting within one formula
cell; just dreaming..).
Change-Id: I744c4915a00849b107c7c25d7029aa19d976aa86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144048
Reviewed-by: Eike Rathke
Tested-by: Jenkins
(cherry picked from commit 8e392437fdb8e8d3f2bb3d41a2f06693dc733229)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144269
diff --git a/formula/source/core/api/FormulaCompiler.cxx
b/formula/source/core/api/FormulaCompiler.cxx
index 6684fd17da47..b0e21b250377 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -1934,6 +1934,11 @@ void FormulaCompiler::Factor()
case ocIfNA:
nJumpMax = 2;
break;
+case ocStop:
+// May happen only if PutCode(pFacToken) ran into overflow.
+nJumpMax = 0;
+assert(pc == FORMULA_MAXTOKENS && pArr->GetCodeError() !=
FormulaError::NONE);
+break;
default:
nJumpMax = 0;
SAL_WARN("formula.core","Jump OpCode: " << +eFacOpCode);
@@ -1973,6 +1978,14 @@ void FormulaCompiler::Factor()
case ocIfNA:
bLimitOk = (nJumpCount <= 2);
break;
+case ocStop:
+// May happen only if PutCode(pFacToken) ran into
overflow.
+// This may had resulted from a stacked token array and
+// error wasn't propagated so assert only the program
+// counter.
+bLimitOk = false;
+assert(pc == FORMULA_MAXTOKENS);
+break;
default:
bLimitOk = false;
SAL_WARN("formula.core","Jump OpCode: " <<
+eFacOpCode);
@@ -2836,6 +2849,7 @@ void FormulaCompiler::PutCode( FormulaTokenRef& p )
{
if ( pc == FORMULA_MAXTOKENS - 1 )
{
+SAL_WARN("formula.core", "FormulaCompiler::PutCode - CodeOverflow
with OpCode " << +p->GetOpCode());
p = new FormulaByteToken( ocStop );
p->IncRef();
*pCode++ = p.get();
[Libreoffice-bugs] [Bug 67622] UI: Add vertical alignment options for text frames in Impress to tool bar
https://bugs.documentfoundation.org/show_bug.cgi?id=67622 --- Comment #13 from Eyal Rozenberg --- (In reply to Tin Man from comment #8) > UX input: > Toolbar buttons for aligning the text vertically like those in Calc would be > useful indeed, not just for discoverability, but also for quick access. I think we already have these... https://i.imgur.com/FYYKjGt.png > A button for the Text dialog in the Formatting toolbar would be useful as > well -- currently, the dialog is quite undiscoverable. Do you mean "Text Attributes..." from the Format | Text Box and Shape submenu? Also exists. But - perhaps you're suggesting putting all of these on the toolbars by default? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152545] Connectors line spacing problem
https://bugs.documentfoundation.org/show_bug.cgi?id=152545 raal changed: What|Removed |Added Keywords||bibisected, bisected CC||nem...@numbertext.org Regression By||László Németh --- Comment #4 from raal --- This seems to have begun at the below commit. Adding Cc: to László Németh; Could you possibly take a look at this one? Thanks 3b1e6d7cd7c153358b0793caa2da016590f607cc is the first bad commit commit 3b1e6d7cd7c153358b0793caa2da016590f607cc Author: Jenkins Build User Date: Thu Oct 27 20:29:32 2022 +0200 source sha:eec48130271188cab63665acedbabf1ff5e850a2 https://gerrit.libreoffice.org/c/core/+/141723 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152545] Connectors line spacing problem
https://bugs.documentfoundation.org/show_bug.cgi?id=152545 raal changed: What|Removed |Added CC||r...@post.cz Keywords||regression Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #3 from raal --- Works in Version: 7.3.7.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: cs-CZ Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.1 Calc: threaded broken in Version: 7.5.0.0.beta1+ (X86_64) / LibreOffice Community Build ID: 89188837f60d83a901b2c43f73d30e1957920f50 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/jsdialog
include/vcl/jsdialog/executor.hxx| 10 ++
include/vcl/weld.hxx |2 ++
vcl/inc/jsdialog/jsdialogbuilder.hxx | 17 +
vcl/jsdialog/executor.cxx|3 +++
vcl/jsdialog/jsdialogbuilder.cxx | 14 ++
5 files changed, 46 insertions(+)
New commits:
commit cc067789ab7fd67bdd6f6ba8ce53a6580a56d7ff
Author: Szymon Kłos
AuthorDate: Tue Dec 6 18:23:32 2022 +0100
Commit: Miklos Vajna
CommitDate: Fri Dec 16 19:49:56 2022 +
jsdialog: enter/leave tab page handlers
(cherry picked from commit 1257c288a0ba03fc69e7bc29fcf05642eb91d150)
Change-Id: I2cbc0fc18f716bf214db61f0729d666a1d2d172c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144344
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/include/vcl/jsdialog/executor.hxx
b/include/vcl/jsdialog/executor.hxx
index 6e388a6a3f79..9bccad3f1865 100644
--- a/include/vcl/jsdialog/executor.hxx
+++ b/include/vcl/jsdialog/executor.hxx
@@ -72,6 +72,16 @@ public:
{
rArea.m_aCommandHdl.Call(rCmd);
}
+
+static void enter_page(weld::Notebook& rNotebook, const OString& rPage)
+{
+rNotebook.m_aEnterPageHdl.Call(rPage);
+}
+
+static void leave_page(weld::Notebook& rNotebook, const OString& rPage)
+{
+rNotebook.m_aLeavePageHdl.Call(rPage);
+}
};
namespace jsdialog
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index 3bcbc0a7a08d..c9273bf4743b 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -463,6 +463,8 @@ public:
class VCL_DLLPUBLIC Notebook : virtual public Widget
{
+friend class ::LOKTrigger;
+
protected:
Link m_aLeavePageHdl;
Link m_aEnterPageHdl;
diff --git a/vcl/inc/jsdialog/jsdialogbuilder.hxx
b/vcl/inc/jsdialog/jsdialogbuilder.hxx
index 291fd24babb7..564309a72626 100644
--- a/vcl/inc/jsdialog/jsdialogbuilder.hxx
+++ b/vcl/inc/jsdialog/jsdialogbuilder.hxx
@@ -534,6 +534,12 @@ public:
class JSNotebook final : public JSWidget
{
+Link m_aLeavePageOverridenHdl;
+Link m_aEnterPageOverridenHdl;
+
+DECL_LINK(LeaveHdl, const OString&, bool);
+DECL_LINK(EnterHdl, const OString&, bool);
+
public:
JSNotebook(JSDialogSender* pSender, ::TabControl* pControl,
SalInstanceBuilder* pBuilder,
bool bTakeOwnership);
@@ -545,6 +551,17 @@ public:
virtual void remove_page(const OString& rIdent) override;
virtual void insert_page(const OString& rIdent, const OUString& rLabel,
int nPos) override;
+
+void connect_leave_page(const Link& rLink)
+{
+m_aLeavePageHdl = LINK(this, JSNotebook, LeaveHdl);
+m_aLeavePageOverridenHdl = rLink;
+}
+void connect_enter_page(const Link& rLink)
+{
+m_aLeavePageHdl = LINK(this, JSNotebook, EnterHdl);
+m_aEnterPageOverridenHdl = rLink;
+}
};
class JSSpinButton final : public JSWidget
diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index 51dcca8f5d16..acd0e084ae76 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -91,7 +91,10 @@ bool ExecuteAction(const std::string& nWindowId, const
OString& rWidget, StringM
{
sal_Int32 page = o3tl::toInt32(rData["data"]);
+OString aCurrentPage = pNotebook->get_current_page_ident();
+LOKTrigger::leave_page(*pNotebook, aCurrentPage);
pNotebook->set_current_page(page);
+LOKTrigger::enter_page(*pNotebook,
pNotebook->get_page_ident(page));
return true;
}
diff --git a/vcl/jsdialog/jsdialogbuilder.cxx b/vcl/jsdialog/jsdialogbuilder.cxx
index da30834b0568..51566201638d 100644
--- a/vcl/jsdialog/jsdialogbuilder.cxx
+++ b/vcl/jsdialog/jsdialogbuilder.cxx
@@ -1315,6 +1315,20 @@ void JSComboBox::set_active(int pos)
bool JSComboBox::changed_by_direct_pick() const { return true; }
+IMPL_LINK(JSNotebook, LeaveHdl, const OString&, rPage, bool)
+{
+m_aLeavePageOverridenHdl.Call(rPage);
+sendFullUpdate();
+return true;
+}
+
+IMPL_LINK(JSNotebook, EnterHdl, const OString&, rPage, bool)
+{
+m_aEnterPageOverridenHdl.Call(rPage);
+sendFullUpdate();
+return true;
+}
+
JSNotebook::JSNotebook(JSDialogSender* pSender, ::TabControl* pControl,
SalInstanceBuilder* pBuilder, bool bTakeOwnership)
: JSWidget(pSender, pControl, pBuilder,
bTakeOwnership)
[Libreoffice-bugs] [Bug 152546] in Czech only! Error filtering
https://bugs.documentfoundation.org/show_bug.cgi?id=152546 raal changed: What|Removed |Added CC||kam...@post.cz, ||r...@post.cz Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from raal --- Uveďte konkrétní příklad, přiložte testovací dokument. Zkuste novější verzi LO, aktuálně podporované řady jsou 7.3 a 7.4 - https://cs.libreoffice.org/. Díky. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-4' - sw/source
sw/source/uibase/uiview/viewsrch.cxx | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
New commits:
commit 4707d8968c7d4723e45d111b2136eed78acccdee
Author: Caolán McNamara
AuthorDate: Thu Dec 15 16:20:31 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:47:08 2022 +
likely fix for frequent SfxViewFrame::GetChildWindow() crash
crash report id: 58e9a91e-9feb-4eb4-a28e-27921d3e1b99
Change-Id: I110d96f1c73f95025918ccc4043dac40c5e1dc4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144189
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 3fe2c0a1864bb775c2e35166eb0019ab18e9c661)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144259
Reviewed-by: Michael Stahl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sw/source/uibase/uiview/viewsrch.cxx
b/sw/source/uibase/uiview/viewsrch.cxx
index 04831dfccac9..118116423e45 100644
--- a/sw/source/uibase/uiview/viewsrch.cxx
+++ b/sw/source/uibase/uiview/viewsrch.cxx
@@ -821,9 +821,13 @@ SvxSearchDialog* SwView::GetSearchDialog()
{
#if HAVE_FEATURE_DESKTOP
const sal_uInt16 nId = SvxSearchDialogWrapper::GetChildWindowId();
-SvxSearchDialogWrapper *pWrp = static_cast(
SfxViewFrame::Current()->GetChildWindow(nId) );
-auto pSrchDlg = pWrp ? pWrp->getDialog() : nullptr;
-return pSrchDlg;
+SfxViewFrame* pFrame = SfxViewFrame::Current();
+if (!pFrame)
+return nullptr;
+SvxSearchDialogWrapper *pWrp =
static_cast(pFrame->GetChildWindow(nId));
+if (!pWrp)
+return nullptr;
+return pWrp->getDialog();
#else
return nullptr;
#endif
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-4' - sd/source
sd/source/core/drawdoc4.cxx | 10 --
sd/source/ui/func/undoheaderfooter.cxx|6 --
sd/source/ui/view/Outliner.cxx| 10 ++
sd/source/ui/view/ViewShellImplementation.cxx | 14 +-
4 files changed, 27 insertions(+), 13 deletions(-)
New commits:
commit a4f5719d3cbe97664738872f9a3ce9c238a06f2a
Author: Caolán McNamara
AuthorDate: Thu Dec 15 20:25:18 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:46:52 2022 +
sd: check SfxViewFrame::Current()
these ones look potentially worth backporting
Change-Id: I6153b0f9ead7caef9f228a5724f51823bcf87c07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144281
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 39e1dbdd2e012eff64855de56c0b3a49245d12c4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144294
Reviewed-by: Michael Stahl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx
index 3c75dd4315e1..59045056853e 100644
--- a/sd/source/core/drawdoc4.cxx
+++ b/sd/source/core/drawdoc4.cxx
@@ -1068,9 +1068,15 @@ void
SdDrawDocument::ImpOnlineSpellCallback(SpellCallbackInfo const * pInfo, Sdr
StartOnlineSpelling();
}
else if (nCommand == SpellCallbackCommand::STARTSPELLDLG)
-SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SPELL_DIALOG,
SfxCallMode::ASYNCHRON );
+{
+if (SfxViewFrame* pViewFrame = SfxViewFrame::Current())
+pViewFrame->GetDispatcher()->Execute( SID_SPELL_DIALOG,
SfxCallMode::ASYNCHRON );
+}
else if (nCommand == SpellCallbackCommand::AUTOCORRECT_OPTIONS)
-SfxViewFrame::Current()->GetDispatcher()->Execute(
SID_AUTO_CORRECT_DLG, SfxCallMode::ASYNCHRON );
+{
+if (SfxViewFrame* pViewFrame = SfxViewFrame::Current())
+pViewFrame->GetDispatcher()->Execute( SID_AUTO_CORRECT_DLG,
SfxCallMode::ASYNCHRON );
+}
}
// Return formatted page number (1, I, i, a, etc.)
diff --git a/sd/source/ui/func/undoheaderfooter.cxx
b/sd/source/ui/func/undoheaderfooter.cxx
index 648a2dd35842..e0183dac3142 100644
--- a/sd/source/ui/func/undoheaderfooter.cxx
+++ b/sd/source/ui/func/undoheaderfooter.cxx
@@ -39,13 +39,15 @@ SdHeaderFooterUndoAction::~SdHeaderFooterUndoAction()
void SdHeaderFooterUndoAction::Undo()
{
mpPage->setHeaderFooterSettings( maOldSettings );
-SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SWITCHPAGE,
SfxCallMode::ASYNCHRON | SfxCallMode::RECORD );
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pViewFrm->GetDispatcher()->Execute( SID_SWITCHPAGE,
SfxCallMode::ASYNCHRON | SfxCallMode::RECORD );
}
void SdHeaderFooterUndoAction::Redo()
{
mpPage->setHeaderFooterSettings( maNewSettings );
-SfxViewFrame::Current()->GetDispatcher()->Execute( SID_SWITCHPAGE,
SfxCallMode::ASYNCHRON | SfxCallMode::RECORD );
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pViewFrm->GetDispatcher()->Execute( SID_SWITCHPAGE,
SfxCallMode::ASYNCHRON | SfxCallMode::RECORD );
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx
index 342b01b050dc..a633376926a6 100644
--- a/sd/source/ui/view/Outliner.cxx
+++ b/sd/source/ui/view/Outliner.cxx
@@ -1925,13 +1925,15 @@ weld::Window* SdOutliner::GetMessageBoxParent()
switch (meMode)
{
case SEARCH:
-pChildWindow = SfxViewFrame::Current()->GetChildWindow(
-SvxSearchDialogWrapper::GetChildWindowId());
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pChildWindow = pViewFrm->GetChildWindow(
+SvxSearchDialogWrapper::GetChildWindowId());
break;
case SPELL:
-pChildWindow = SfxViewFrame::Current()->GetChildWindow(
-sd::SpellDialogChildWindow::GetChildWindowId());
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pChildWindow = pViewFrm->GetChildWindow(
+sd::SpellDialogChildWindow::GetChildWindowId());
break;
case TEXT_CONVERSION:
diff --git a/sd/source/ui/view/ViewShellImplementation.cxx
b/sd/source/ui/view/ViewShellImplementation.cxx
index 5725feb2cc4f..a0c025ce5acf 100644
--- a/sd/source/ui/view/ViewShellImplementation.cxx
+++ b/sd/source/ui/view/ViewShellImplementation.cxx
@@ -304,12 +304,16 @@ SfxInterfaceId ViewShell::Implementation::GetViewId()
const
SvxIMapDlg* ViewShell::Implementation::GetImageMapDialog()
{
-SvxIMapDlg* pDialog = nullptr;
-SfxChildWindow* pChildWindow = SfxViewFrame::Current()->GetChildWindow(
+SfxViewFrame* pViewFrm = SfxViewFrame::Current();
+if (!pViewFrm)
+return nullptr;
+
+SfxChildWindow* pChildWindow = pViewFrm->GetChildWindow(
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-4' - sw/source
sw/source/ui/fldui/fldtdlg.cxx |7 -
sw/source/ui/index/swuiidxmrk.cxx | 15
sw/source/uibase/app/docst.cxx |3 +-
sw/source/uibase/envelp/syncbtn.cxx |3 +-
sw/source/uibase/ribbar/workctrl.cxx| 14 +++
sw/source/uibase/sidebar/PageOrientationControl.cxx | 25 +++-
6 files changed, 43 insertions(+), 24 deletions(-)
New commits:
commit 6a71edb945ecf25d114ff13ade645c728971788f
Author: Caolán McNamara
AuthorDate: Thu Dec 15 16:48:09 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:46:35 2022 +
sw: check SfxViewFrame::Current()
these ones looks potentially worth backporting
Change-Id: I294fa029b53fa9d43cb738f07278301e2a06c210
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144246
Reviewed-by: Xisco Fauli
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit 30d73367f40c375121609a9878b1c9717429eae1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144295
Reviewed-by: Michael Stahl
Tested-by: Caolán McNamara
diff --git a/sw/source/ui/fldui/fldtdlg.cxx b/sw/source/ui/fldui/fldtdlg.cxx
index 53e5a51c6eaf..f2d0768d34c2 100644
--- a/sw/source/ui/fldui/fldtdlg.cxx
+++ b/sw/source/ui/fldui/fldtdlg.cxx
@@ -180,8 +180,11 @@ void SwFieldDlg::ReInitDlg()
if (bNewMode != m_bHtmlMode)
{
-SfxViewFrame::Current()->GetDispatcher()->
-Execute(FN_INSERT_FIELD,
SfxCallMode::ASYNCHRON|SfxCallMode::RECORD);
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+{
+pViewFrm->GetDispatcher()->
+Execute(FN_INSERT_FIELD,
SfxCallMode::ASYNCHRON|SfxCallMode::RECORD);
+}
Close();
}
diff --git a/sw/source/ui/index/swuiidxmrk.cxx
b/sw/source/ui/index/swuiidxmrk.cxx
index 442dbed88f8b..1075d75f4d2b 100644
--- a/sw/source/ui/index/swuiidxmrk.cxx
+++ b/sw/source/ui/index/swuiidxmrk.cxx
@@ -685,8 +685,11 @@ IMPL_LINK_NOARG(SwIndexMarkPane, CloseHdl, weld::Button&,
void)
{
if (m_bNewMark)
{
-
SfxViewFrame::Current()->GetDispatcher()->Execute(FN_INSERT_IDX_ENTRY_DLG,
-SfxCallMode::ASYNCHRON|SfxCallMode::RECORD);
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+{
+pViewFrm->GetDispatcher()->Execute(FN_INSERT_IDX_ENTRY_DLG,
+SfxCallMode::ASYNCHRON|SfxCallMode::RECORD);
+}
}
else
{
@@ -818,7 +821,8 @@ IMPL_LINK_NOARG(SwIndexMarkPane, DelHdl, weld::Button&,
void)
else
{
CloseHdl(*m_xCloseBT);
-
SfxViewFrame::Current()->GetBindings().Invalidate(FN_EDIT_IDX_ENTRY_DLG);
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pViewFrm->GetBindings().Invalidate(FN_EDIT_IDX_ENTRY_DLG);
}
}
@@ -1217,8 +1221,11 @@ IMPL_LINK_NOARG(SwAuthorMarkPane, CloseHdl,
weld::Button&, void)
{
if(bNewEntry)
{
-
SfxViewFrame::Current()->GetDispatcher()->Execute(FN_INSERT_AUTH_ENTRY_DLG,
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+{
+pViewFrm->GetDispatcher()->Execute(FN_INSERT_AUTH_ENTRY_DLG,
SfxCallMode::ASYNCHRON|SfxCallMode::RECORD);
+}
}
else
{
diff --git a/sw/source/uibase/app/docst.cxx b/sw/source/uibase/app/docst.cxx
index 2d34c0e51e3a..6ab7e659ae92 100644
--- a/sw/source/uibase/app/docst.cxx
+++ b/sw/source/uibase/app/docst.cxx
@@ -1180,7 +1180,8 @@ SfxStyleFamily SwDocShell::ApplyStyles(const OUString
, SfxStyleFamily nFa
const SwNumRule* pNumRule = pStyle->GetNumRule();
if (pNumRule->GetName() == SwResId(STR_POOLNUMRULE_NOLIST))
{
-
SfxViewFrame::Current()->GetDispatcher()->Execute(FN_NUM_BULLET_OFF);
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pViewFrm->GetDispatcher()->Execute(FN_NUM_BULLET_OFF);
break;
}
const OUString sListIdForStyle =pNumRule->GetDefaultListId();
diff --git a/sw/source/uibase/envelp/syncbtn.cxx
b/sw/source/uibase/envelp/syncbtn.cxx
index 009525d02ce5..d00ff4913cbe 100644
--- a/sw/source/uibase/envelp/syncbtn.cxx
+++ b/sw/source/uibase/envelp/syncbtn.cxx
@@ -81,7 +81,8 @@ SwSyncBtnDlg::~SwSyncBtnDlg()
IMPL_STATIC_LINK_NOARG(SwSyncBtnDlg, BtnHdl, weld::Button&, void)
{
-SfxViewFrame::Current()->GetDispatcher()->Execute(FN_UPDATE_ALL_LINKS,
SfxCallMode::ASYNCHRON);
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+pViewFrm->GetDispatcher()->Execute(FN_UPDATE_ALL_LINKS,
SfxCallMode::ASYNCHRON);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/uibase/ribbar/workctrl.cxx
b/sw/source/uibase/ribbar/workctrl.cxx
index e65a376f7592..da64e0df90ac 100644
--- a/sw/source/uibase/ribbar/workctrl.cxx
+++
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-4' - cui/source desktop/source
cui/source/customize/CustomNotebookbarGenerator.cxx | 13 -
desktop/source/lib/init.cxx | 12
2 files changed, 16 insertions(+), 9 deletions(-)
New commits:
commit 7f773612d8554a2a9131c94582359a837d0c4f7b
Author: Caolán McNamara
AuthorDate: Thu Dec 15 20:15:45 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:46:17 2022 +
misc: check SfxViewFrame::Current()
these ones look potentially worth backporting
Change-Id: Ie01c0b598c3408f4766318267de8438e997dd1a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144261
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit a36bcfc15c8287b99702be064aae93e9632e9aa0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144297
Reviewed-by: Michael Stahl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cui/source/customize/CustomNotebookbarGenerator.cxx
b/cui/source/customize/CustomNotebookbarGenerator.cxx
index 9fb71562160a..bae85525ebd6 100644
--- a/cui/source/customize/CustomNotebookbarGenerator.cxx
+++ b/cui/source/customize/CustomNotebookbarGenerator.cxx
@@ -74,11 +74,14 @@ static OUString
lcl_getAppName(vcl::EnumContext::Application eApp)
static OUString getAppNameRegistryPath()
{
vcl::EnumContext::Application eApp = vcl::EnumContext::Application::Any;
-const Reference& xFrame
-= SfxViewFrame::Current()->GetFrame().GetFrameInterface();
-const Reference xModuleManager
-=
frame::ModuleManager::create(::comphelper::getProcessComponentContext());
-eApp =
vcl::EnumContext::GetApplicationEnum(xModuleManager->identify(xFrame));
+
+if (SfxViewFrame* pViewFrame = SfxViewFrame::Current())
+{
+const Reference& xFrame =
pViewFrame->GetFrame().GetFrameInterface();
+const Reference xModuleManager
+=
frame::ModuleManager::create(::comphelper::getProcessComponentContext());
+eApp =
vcl::EnumContext::GetApplicationEnum(xModuleManager->identify(xFrame));
+}
OUString sAppName(lcl_getAppName(eApp));
return "org.openoffice.Office.UI.ToolbarMode/Applications/" + sAppName;
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 52fd35a23104..ee35a421a6c8 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -761,6 +761,10 @@ void ExecuteMarginULChange(
// Main function which toggles page orientation of the Writer doc. Needed by
ToggleOrientation
void ExecuteOrientationChange()
{
+SfxViewFrame* pViewFrm = SfxViewFrame::Current();
+if (!pViewFrm)
+return;
+
std::unique_ptr pPageItem(new SvxPageItem(SID_ATTR_PAGE));
// 1mm in twips rounded
@@ -768,22 +772,22 @@ void ExecuteOrientationChange()
constexpr tools::Long MINBODY = o3tl::toTwips(1, o3tl::Length::mm);
css::uno::Reference< css::document::XUndoManager > mxUndoManager(
-getUndoManager(
SfxViewFrame::Current()->GetFrame().GetFrameInterface() ) );
+getUndoManager( pViewFrm->GetFrame().GetFrameInterface() ) );
if ( mxUndoManager.is() )
mxUndoManager->enterUndoContext( "" );
const SvxSizeItem* pSizeItem;
-
SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_SIZE,
pSizeItem);
+pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_SIZE,
pSizeItem);
std::unique_ptr pPageSizeItem(pSizeItem->Clone());
const SvxLongLRSpaceItem* pLRSpaceItem;
-
SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_LRSPACE,
pLRSpaceItem);
+pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_LRSPACE,
pLRSpaceItem);
std::unique_ptr
pPageLRMarginItem(pLRSpaceItem->Clone());
const SvxLongULSpaceItem* pULSpaceItem;
-
SfxViewFrame::Current()->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_ULSPACE,
pULSpaceItem);
+pViewFrm->GetBindings().GetDispatcher()->QueryState(SID_ATTR_PAGE_ULSPACE,
pULSpaceItem);
std::unique_ptr
pPageULMarginItem(pULSpaceItem->Clone());
{
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-4' - sfx2/source
sfx2/source/appl/app.cxx |2 +-
sfx2/source/commandpopup/CommandPopup.cxx |2 ++
sfx2/source/control/charmapcontrol.cxx|7 +--
sfx2/source/control/request.cxx |8 +++-
4 files changed, 15 insertions(+), 4 deletions(-)
New commits:
commit b3a83c1e0b48eeb5b62ec450dff58463bcb12f1e
Author: Caolán McNamara
AuthorDate: Thu Dec 15 20:00:26 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:45:43 2022 +
sfx2: check SfxViewFrame::Current()
these ones look potentially worth backporting
Change-Id: I9391f266b08e3842f9686db6113b61fa814f3fbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144258
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 59842f25ce457bdddc5cdddbe95dda76d09353cd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144299
Reviewed-by: Michael Stahl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx
index cd4acc552132..4a85e28f2d16 100644
--- a/sfx2/source/appl/app.cxx
+++ b/sfx2/source/appl/app.cxx
@@ -422,7 +422,7 @@ IMPL_STATIC_LINK( SfxApplication, GlobalBasicErrorHdl_Impl,
StarBASIC*, pStarBas
const SfxViewFrame* pViewFrame = SfxViewFrame::Current();
std::shared_ptr xBox;
xBox.reset(Application::CreateMessageDialog(
- pViewFrame->GetFrameWeld(),
+ pViewFrame ? pViewFrame->GetFrameWeld() : nullptr,
VclMessageType::Error,
VclButtonsType::Ok,
aError,
diff --git a/sfx2/source/commandpopup/CommandPopup.cxx
b/sfx2/source/commandpopup/CommandPopup.cxx
index 47df143a889b..f4cdf92436c7 100644
--- a/sfx2/source/commandpopup/CommandPopup.cxx
+++ b/sfx2/source/commandpopup/CommandPopup.cxx
@@ -152,6 +152,8 @@ void MenuContentHandler::addCommandIfPossible(
return;
auto* pViewFrame = SfxViewFrame::Current();
+if (!pViewFrame)
+return;
SfxSlotPool& rSlotPool = SfxSlotPool::GetSlotPool(pViewFrame);
const SfxSlot* pSlot = rSlotPool.GetUnoSlot(aCommandURL.Path);
diff --git a/sfx2/source/control/charmapcontrol.cxx
b/sfx2/source/control/charmapcontrol.cxx
index 032306b8a85f..a79da745be26 100644
--- a/sfx2/source/control/charmapcontrol.cxx
+++ b/sfx2/source/control/charmapcontrol.cxx
@@ -207,8 +207,11 @@ IMPL_LINK_NOARG(SfxCharmapCtrl, OpenDlgHdl, weld::Button&,
void)
{
m_xControl->EndPopupMode();
-uno::Reference xFrame =
SfxViewFrame::Current()->GetFrame().GetFrameInterface();
-comphelper::dispatchCommand(".uno:InsertSymbol", xFrame, {});
+if (SfxViewFrame* pViewFrm = SfxViewFrame::Current())
+{
+uno::Reference xFrame =
pViewFrm->GetFrame().GetFrameInterface();
+comphelper::dispatchCommand(".uno:InsertSymbol", xFrame, {});
+}
}
void SfxCharmapCtrl::GrabFocus()
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx
index 964a256b19a7..b43d1dd991bc 100644
--- a/sfx2/source/control/request.cxx
+++ b/sfx2/source/control/request.cxx
@@ -687,8 +687,14 @@ css::uno::Reference< css::frame::XDispatchRecorder >
SfxRequest::GetMacroRecorde
{
css::uno::Reference< css::frame::XDispatchRecorder > xRecorder;
+if (!pView)
+pView = SfxViewFrame::Current();
+
+if (!pView)
+return xRecorder;
+
css::uno::Reference< css::beans::XPropertySet > xSet(
-(pView ? pView :
SfxViewFrame::Current())->GetFrame().GetFrameInterface(),
+pView->GetFrame().GetFrameInterface(),
css::uno::UNO_QUERY);
if(xSet.is())
[Libreoffice-commits] core.git: Branch 'libreoffice-7-4-4' - sd/source
sd/source/ui/sidebar/SlideBackground.cxx | 28
1 file changed, 20 insertions(+), 8 deletions(-)
New commits:
commit 470ef81889490524155ac22f25e9288f28b55f5f
Author: Caolán McNamara
AuthorDate: Thu Dec 15 21:21:44 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:45:26 2022 +
likely fix for frequent mpGradientItem->GetName() crash
crash report id: ec5a64d7-b354-457e-92a3-1bd51208e7c7
Change-Id: Ie64993190baa5e3ea9228214bea1ee4d82044c51
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144267
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
(cherry picked from commit 72f4cba0a2a917250d8af31a1208f75fbdd29d0b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144300
Reviewed-by: Michael Stahl
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/sd/source/ui/sidebar/SlideBackground.cxx
b/sd/source/ui/sidebar/SlideBackground.cxx
index 89c16e0d6fc2..61cd3763f6df 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -1022,30 +1022,42 @@ IMPL_LINK_NOARG(SlideBackground, FillStyleModifyHdl,
weld::ComboBox&, void)
case SOLID:
{
-const XFillColorItem aItem( OUString(),
mpColorItem->GetColorValue() );
-GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_COLOR,
SfxCallMode::RECORD, { });
+if (mpColorItem)
+{
+const XFillColorItem aItem( OUString(),
mpColorItem->GetColorValue() );
+
GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_COLOR,
SfxCallMode::RECORD, { });
+}
}
break;
case GRADIENT:
{
-const XFillGradientItem aItem( mpGradientItem->GetName(),
mpGradientItem->GetGradientValue() );
-
GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_GRADIENT,
SfxCallMode::RECORD, { });
+if (mpGradientItem)
+{
+const XFillGradientItem aItem( mpGradientItem->GetName(),
mpGradientItem->GetGradientValue() );
+
GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_GRADIENT,
SfxCallMode::RECORD, { });
+}
}
break;
case HATCH:
{
-const XFillHatchItem aItem( mpHatchItem->GetName(),
mpHatchItem->GetHatchValue() );
-GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_HATCH,
SfxCallMode::RECORD, { });
+if (mpHatchItem)
+{
+const XFillHatchItem aItem( mpHatchItem->GetName(),
mpHatchItem->GetHatchValue() );
+
GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_HATCH,
SfxCallMode::RECORD, { });
+}
}
break;
case BITMAP:
case PATTERN:
{
-const XFillBitmapItem aItem( mpBitmapItem->GetName(),
mpBitmapItem->GetGraphicObject() );
-GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_BITMAP,
SfxCallMode::RECORD, { });
+if (mpBitmapItem)
+{
+const XFillBitmapItem aItem( mpBitmapItem->GetName(),
mpBitmapItem->GetGraphicObject() );
+
GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_BITMAP,
SfxCallMode::RECORD, { });
+}
}
break;
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - unotools/source
unotools/source/i18n/resmgr.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 7e61545966c61102aad56bbf10bae2edfbfa9226 Author: Đoàn Trần Công Danh AuthorDate: Sun Nov 27 18:59:24 2022 +0700 Commit: Caolán McNamara CommitDate: Fri Dec 16 19:43:59 2022 + i18n: fix build with Boost 1.81.0 Boost.Locale since 1.81.0 switch to enum classes for facet type [1]. Switch our resource manager accordingly. 1: https://github.com/boostorg/locale/commit/e5ed439ea39a4de915e9fb939cca95cae7d9d8d1 Change-Id: Ief215363ceb79b2019606b20a7cde55c8df6a042 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143343 Reviewed-by: Heiko Becker Tested-by: Caolán McNamara Reviewed-by: Caolán McNamara (cherry picked from commit 23dcd4339428e4080029ec5ae658e75f01e79a62) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144310 Reviewed-by: Danh Doan Tested-by: Jenkins diff --git a/unotools/source/i18n/resmgr.cxx b/unotools/source/i18n/resmgr.cxx index ddedf5b9e8a2..3a7116350062 100644 --- a/unotools/source/i18n/resmgr.cxx +++ b/unotools/source/i18n/resmgr.cxx @@ -127,8 +127,13 @@ namespace Translate if (aFind != aCache.end()) return aFind->second; boost::locale::generator gen; +#if BOOST_VERSION < 108100 gen.characters(boost::locale::char_facet); gen.categories(boost::locale::message_facet | boost::locale::information_facet); +#else +gen.characters(boost::locale::char_facet_t::char_f); +gen.categories(boost::locale::category_t::message | boost::locale::category_t::information); +#endif #if defined(ANDROID) OString sPath(OString(lo_get_app_data_dir()) + "/program/resource"); #else
[Libreoffice-commits] core.git: svx/source
svx/source/sidebar/area/AreaPropertyPanelBase.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ae438bda3d5a0c9c9f2ed0e71104698bd2d8793d
Author: Caolán McNamara
AuthorDate: Fri Dec 16 12:15:55 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:43:10 2022 +
pSh cannot be null here, checked at the start of method
Change-Id: Ia6b8599c7ff185d5beecf6572c0df353320d8ebb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144338
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
index b11f61d775eb..5bd9eb46c8f8 100644
--- a/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
+++ b/svx/source/sidebar/area/AreaPropertyPanelBase.cxx
@@ -487,7 +487,7 @@ void AreaPropertyPanelBase::FillStyleChanged(bool
bUpdateModel)
}
else
{
-if (pSh && pSh->GetItem(SID_GRADIENT_LIST))
+if (pSh->GetItem(SID_GRADIENT_LIST))
{
SvxFillAttrBox::Fill(*mxLbFillAttr,
pSh->GetItem(SID_GRADIENT_LIST)->GetGradientList());
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - vcl/osx
vcl/osx/a11yfactory.mm | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
New commits:
commit 8c6b2b507a98c325bf0d0990e160d8e520a90671
Author: Patrick Luby
AuthorDate: Thu Dec 15 16:25:00 2022 -0500
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:42:41 2022 +
tdf#146765 Fix infinite recursion in -[NSView visibleRect]
HACK: Adding a subview to an NSView that is not attached
to an NSWindow leads to infinite recursion in the native
NSViewGetVisibleRect() function. This seems to be a new
behavior starting with macOS 12.6.2.
In the case of tdf#146765, we end up here because
-[AquaA11yWrapper childrenAttribute] is called by a
wrapper that is already attached to an NSWindow. That is
normal. What isn't normal is that the child wrapper's
unignored accessible parent is a differnt wrapper than
the caller and that different wrapper is not yet
attached to an NSWindow.
TODO: switch the AquaA11yWrapper class to inherit the
lightweight NSAccessibilityElement class instead of the
NSView class to possibly avoid the need for this hack.
Change-Id: Ic6c2a60e90a154786dd7f5935582ef7d3f57584c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144329
Tested-by: Jenkins
Reviewed-by: Noel Grandin
(cherry picked from commit 07f9f22e68a3caebe67d89c0b209059ba40be482)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144357
Reviewed-by: Caolán McNamara
diff --git a/vcl/osx/a11yfactory.mm b/vcl/osx/a11yfactory.mm
index c5aa64308010..d4b0e25047fb 100644
--- a/vcl/osx/a11yfactory.mm
+++ b/vcl/osx/a11yfactory.mm
@@ -166,7 +166,26 @@ static bool enabled = false;
if (parent) {
if ([parent isKindOfClass:[NSView class]]) {
NSView *parentView = static_cast(parent);
-[parentView addSubview:aWrapper positioned:NSWindowBelow
relativeTo:nil];
+
+// tdf#146765 Fix infinite recursion in -[NSView
visibleRect]
+// HACK: Adding a subview to an NSView that is not attached
+// to an NSWindow leads to infinite recursion in the native
+// NSViewGetVisibleRect() function. This seems to be a new
+// behavior starting with macOS 12.6.2.
+// In the case of tdf#146765, we end up here because
+// -[AquaA11yWrapper childrenAttribute] is called by a
+// wrapper that is already attached to an NSWindow. That is
+// normal. What isn't normal is that the child wrapper's
+// unignored accessible parent is a differnt wrapper than
+// the caller and that different wrapper is not yet
+// attached to an NSWindow.
+// TODO: switch the AquaA11yWrapper class to inherit the
+// lightweight NSAccessibilityElement class instead of the
+// NSView class to possibly avoid the need for this hack.
+NSWindow *window = [parentView window];
+SAL_WARN_IF(!window, "vcl.a11y","Can't add subview. Parent
view's window is nil!");
+if (window)
+[parentView addSubview:aWrapper
positioned:NSWindowBelow relativeTo:nil];
} else if ([parent
isKindOfClass:NSClassFromString(@"SalFrameWindow")]) {
NSWindow *window = static_cast(parent);
NSView *salView = [window contentView];
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/securitypage.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 1aed92da7f41dffbc675102c8f7d6b7705329554
Author: Caolán McNamara
AuthorDate: Fri Dec 16 12:13:01 2022 +
Commit: Caolán McNamara
CommitDate: Fri Dec 16 19:42:56 2022 +
provide a parent for potential message dialog
Change-Id: I7b417c64ce08cddc2c413dae3bcab3b9fe083bc6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144337
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sfx2/source/dialog/securitypage.cxx
b/sfx2/source/dialog/securitypage.cxx
index 39bdc7cb1eba..3bedf173 100644
--- a/sfx2/source/dialog/securitypage.cxx
+++ b/sfx2/source/dialog/securitypage.cxx
@@ -106,7 +106,7 @@ static bool lcl_GetPassword(
}
-static bool lcl_IsPasswordCorrect( std::u16string_view rPassword )
+static bool lcl_IsPasswordCorrect(weld::Window *pParent, std::u16string_view
rPassword)
{
bool bRes = false;
@@ -138,7 +138,7 @@ static bool lcl_IsPasswordCorrect( std::u16string_view
rPassword )
if ( !bRes )
{
-std::unique_ptr
xInfoBox(Application::CreateMessageDialog(nullptr,
+std::unique_ptr
xInfoBox(Application::CreateMessageDialog(pParent,
VclMessageType::Info,
VclButtonsType::Ok,
SfxResId(RID_SVXSTR_INCORRECT_PASSWORD)));
xInfoBox->run();
@@ -360,7 +360,7 @@ IMPL_LINK_NOARG(SfxSecurityPage_Impl,
RecordChangesCBToggleHdl, weld::Toggleable
bAlreadyDone = true;
// ask for password and if dialog is canceled or no password provided
return
-if (lcl_IsPasswordCorrect( aPasswordText ))
+if (lcl_IsPasswordCorrect(m_rMyTabPage.GetFrameWeld(), aPasswordText))
m_bOrigPasswordIsConfirmed = true;
else
bAlreadyDone = true;
@@ -400,7 +400,7 @@ IMPL_LINK_NOARG(SfxSecurityPage_Impl,
ChangeProtectionPBHdl, weld::Button&, void
// provided password still needs to be checked?
if (!bNewProtection && !m_bOrigPasswordIsConfirmed)
{
-if (lcl_IsPasswordCorrect( aPasswordText ))
+if (lcl_IsPasswordCorrect(m_rMyTabPage.GetFrameWeld(),
aPasswordText))
m_bOrigPasswordIsConfirmed = true;
else
return;
[Libreoffice-bugs] [Bug 47997] FILESAVE PPT Indent of paragraph is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=47997 --- Comment #10 from Stéphane Guillou (stragu) --- Repro in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4e4a31ac7d920c71e26ca4acd18c11ec2bd015bb CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42196] Automatically extend the chart data source range when adding rows at the end
https://bugs.documentfoundation.org/show_bug.cgi?id=42196 Stéphane Guillou (stragu) changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 42196] Automatically extend the chart data source range when adding rows at the end
https://bugs.documentfoundation.org/show_bug.cgi?id=42196 Stéphane Guillou (stragu) changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 108539] [META] Chart data table bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108539 Bug 108539 depends on bug 47584, which changed state. Bug 47584 Summary: When adding data, Calc should suggest extending the data range to include it in the chart https://bugs.documentfoundation.org/show_bug.cgi?id=47584 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42196] Automatically extend the chart data source range when adding rows at the end
https://bugs.documentfoundation.org/show_bug.cgi?id=42196 --- Comment #14 from Stéphane Guillou (stragu) --- *** Bug 47584 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 47584] When adding data, Calc should suggest extending the data range to include it in the chart
https://bugs.documentfoundation.org/show_bug.cgi?id=47584 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from Stéphane Guillou (stragu) --- *** This bug has been marked as a duplicate of bug 42196 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152557] Chart data range reduces range / removes cell when adding series, shifts labels
https://bugs.documentfoundation.org/show_bug.cgi?id=152557 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||1753 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 152557] New: Chart data range reduces range / removes cell when adding series, shifts labels
https://bugs.documentfoundation.org/show_bug.cgi?id=152557 Bug ID: 152557 Summary: Chart data range reduces range / removes cell when adding series, shifts labels Product: LibreOffice Version: Inherited From OOo Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephane.guil...@libreoffice.org Blocks: 90486 When modifying a chart data range that is not entirely rectangular, the smaller range is further reduced upon saving, ultimately losing data in the chart. Steps: 1. Open attachment 183259 2. Open data ranges dialog 3. Add ";Table1.C1:C4" to the range to add a series 4. See that extra bar was added 5. Reopen data ranges dialog to see that range was simplified to "Table1.A2:A4;Table1.B1:E4" (still only top-left cell excluded from range) Result 1: "A" label is gone, other labels are shifted to the left, even though the range still says cell A2 is included. 6. Save, reload Result 2: Data range was updated to "Table1.A3:A4;Table1.B1:E4" (i.e. two top cells of column A have been excluded), which matches the glitch witnessed in the chart. In: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4e4a31ac7d920c71e26ca4acd18c11ec2bd015bb CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Also in OOo 3.3: OpenOffice.org 3.3.0 OOO330m20(Build:9567) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90486 [Bug 90486] [META] Chart bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
