[Libreoffice-bugs] [Bug 152935] LibreOffice crashing on keyboard-shortcut (QUOTELEFT_MOD1) for changing documents within an application on Mac OS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152935

--- Comment #1 from J  ---
Came here to check if this bug had been reported yet.

+1 

I'm using MacOS Venture 13.0.1 on a 2020 Macbook Pro (Intel)

Libre Office Version 7.4.3.2

I've nothing to add to the description previously made by kdjacob2000.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149227] duplicate style in styles tab of sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149227

--- Comment #7 from Buovjaga  ---
(In reply to Robert Großkopf from comment #5)
> Could see a duplicate in German GUI with "Ergebnis" and with "Überschrift" in

What are your steps for creating such a document from scratch?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149227] duplicate style in styles tab of sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149227

Robert Großkopf  changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de

--- Comment #6 from Robert Großkopf  ---
Created attachment 184607
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184607=edit
Have a look at the difference between German und English styles

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152799] Assert with ungroup shapes and also gets some warning in console with debug LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152799

BogdanB  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #12 from BogdanB  ---
Resolved meanwhile
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c68d06dfa1498f862923eaddf3e5d247650a53d5
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 152799, which changed state.

Bug 152799 Summary: Assert with ungroup shapes and also gets some warning in 
console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152799

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108741] [META] Shapes bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108741
Bug 108741 depends on bug 152799, which changed state.

Bug 152799 Summary: Assert with ungroup shapes and also gets some warning in 
console with debug LO
https://bugs.documentfoundation.org/show_bug.cgi?id=152799

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 149227] duplicate style in styles tab of sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149227

Robert Großkopf  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #5 from Robert Großkopf  ---
Could see a duplicate in German GUI with "Ergebnis" and with "Überschrift" in

Version: 7.4.4.2 / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Bug also appears in LO 7.5.0.1 on OpenSUSE 15.3 64bit rpm Linux.

Doesn't appear in English GUI.
While it doesn't appear in English the English version of the attached file
isn't formatted the same way as the German version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa sw/source

[Miklos Vajna (via logerrit)]

 sw/qa/core/layout/data/page-remove-fly-no-table.fodt |  460 +++
 sw/qa/core/layout/layout.cxx |7 
 sw/source/core/layout/flylay.cxx |   11 
 3 files changed, 476 insertions(+), 2 deletions(-)

New commits:
commit 432aefa738ed0b3a6215629569a5bcffdeb504d5
Author: Miklos Vajna 
AuthorDate: Thu Jan 12 08:40:14 2023 +0100
Commit: Miklos Vajna 
CommitDate: Thu Jan 12 10:21:20 2023 +

tdf#152961 sw: fix layout loop on removing fly from page

Loading the document resulted in a layout loop.

This is a problem since commit cf2c070de2bafeec3b476c6bff7bb4ac87ba46db
(sw layout: invalidate margins of body content when moving a fly from
page, 2022-12-09), which started invalidating the content of an old page
in case we remove a fly from it, because some frames calculate their
margins based on the flys of the page.

Fix the problem by invalidating only the table frames of those page
lowers: the direct need for this invalidation comes from
SwTabFrame::CalcFlyOffsets(), which is not relevant for other frames.
Also, in case non-table lowers are not invalidated, then the new bugdoc
loads fine, which means this fixes the new problem while keeping the old
problem fixed.

This assumes that non-table frames have their equivalent of
SwTabFrame::CalcFlyOffsets(), which do their own invalidation, so
SwPageFrame::MoveFly() doesn't have to do it.

Change-Id: I807d55d077bb0e023beb66775ab68bbca2680eb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145384
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/sw/qa/core/layout/data/page-remove-fly-no-table.fodt 
b/sw/qa/core/layout/data/page-remove-fly-no-table.fodt
new file mode 100644
index ..035688b85b41
--- /dev/null
+++ b/sw/qa/core/layout/data/page-remove-fly-no-table.fodt
@@ -0,0 +1,460 @@
+
+http://www.w3.org/TR/css3-text/; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:office="urn:oasis:names:tc:opendocument:xmlns:office:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:fo="urn:oasis:names:tc:opendocument:xmlns:xsl-fo-compatible:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:xlink="http://www.w3.org/1999/xlink; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dc="http://purl.org/dc/elements/1.1/; xmlns:c
 alcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0" 
xmlns:style="urn:oasis:names:tc:opendocument:xmlns:style:1.0" 
xmlns:text="urn:oasis:names:tc:opendocument:xmlns:text:1.0" 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:draw="urn:oasis:names:tc:opendocument:xmlns:drawing:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:formx="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0"
 xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:officeooo="http://openoffice.org/2009/office; 
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0" 
xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:
 meta:1.0" 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 office:version="1.3" office:mimetype="application/vnd.oasis.opendocument.text">
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+  
+
+
+  
+
+
+  
+  
+
+
+  
+  
+
+
+  
+  
+
+
+  
+
+
+  
+  
+
+
+  
+  
+
+
+  
+  
+
+  
+  
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+
+  
+
+  
+
+
+  
+
+  
+
+
+  
+
+  
+  
+
+  
+
+
+  
+
+  
+  
+  
+
+  
+
+
+  
+
+  
+

[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149044

--- Comment #6 from lvm  ---
(In reply to Heiko Tietze from comment #5)
> With "autonumbering" do you mean ordered (aka numbered) list?

Yes, but it is the same for bulleted lists. And when undoing 7.4.3.2 now
selects the trigger expression ("1. " or "* "). If something is already
selected you get two selections!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149044

--- Comment #6 from lvm  ---
(In reply to Heiko Tietze from comment #5)
> With "autonumbering" do you mean ordered (aka numbered) list?

Yes, but it is the same for bulleted lists. And when undoing 7.4.3.2 now
selects the trigger expression ("1. " or "* "). If something is already
selected you get two selections!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 152979] Freeze in Basic IDE's "Preview Dialog" using kf5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152979

Robert Großkopf  changed:

   What|Removed |Added

 CC||rob...@familiegrosskopf.de

--- Comment #2 from Robert Großkopf  ---
Couldn't reproduce the bug with

Version: 7.4.4.2 / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Also tested with
Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

on OpenSUSE 15.3 64bit rpm Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||152911


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152911
[Bug 152911] VIEWING - High CPU and lag when scrolling on Wayland with modified
display scale (KF5)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152911] VIEWING - High CPU and lag when scrolling on Wayland with modified display scale (KF5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152911

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|VIEWING - High CPU and lag  |VIEWING - High CPU and lag
   |when scrolling on Wayland   |when scrolling on Wayland
   |(KF5)   |with modified display scale
   ||(KF5)
 Blocks||133092


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
[Bug 133092] [META] Crash bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Stephan Bergmann (via logerrit)]

 sw/qa/extras/odfimport/odfimport.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7b398af091c2d130becc21d38381751830398140
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 08:33:29 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 09:58:06 2023 +

loplugin:external (clang-cl)

Change-Id: I09e30d3e250bad9c328688b78cf387fcdb12c2a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145382
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/sw/qa/extras/odfimport/odfimport.cxx 
b/sw/qa/extras/odfimport/odfimport.cxx
index 67c827b091da..c42f2661a2e4 100644
--- a/sw/qa/extras/odfimport/odfimport.cxx
+++ b/sw/qa/extras/odfimport/odfimport.cxx
@@ -1379,7 +1379,7 @@ CPPUNIT_TEST_FIXTURE(Test, testForcepoint108)
 
 #ifdef _WIN32
 template 
-void runWindowsFileZoneTests(css::uno::Reference 
aDesktop,
+static void runWindowsFileZoneTests(css::uno::Reference 
aDesktop,
  const OUString& sFileName, sal_Int32 configValue, 
sal_Int32 zoneId,
  sal_Bool expectedResult)
 {

[Libreoffice-bugs] [Bug 152911] VIEWING - High CPU and lag when scrolling on Wayland (KF5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152911

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   Keywords||perf
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
Summary|VIEWING - High CPU and lag  |VIEWING - High CPU and lag
   |when scrolling on Wayland   |when scrolling on Wayland
   ||(KF5)

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
I could actually reproduce some very sluggish scrolling. On Ubuntu 20.04 with
GNOME + Wayland, all my displays at 200% scaling, starting LO with:

And then changing all my displays' scaling back to 100% (with LO still open), I
end up with extremely choppy scrolling with the mousewheel, and even more so by
dragging the scrollbar: it struggles so much that it hangs, and I managed to
make it crash(?) with the console message:

   The Wayland connection broke. Did the Wayland compositor die?

(The LO window disappears, but I still had to kill the process in the console.)

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92deea6301a02f5530f17263f58402344f82013c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+wayland)
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Not reproducible with GTK3.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85603] Filesave (Export) as (X)HTML increases memory usage and shows false statusbar indication

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85603

Roman Kuznetsov <79045_79...@mail.ru> changed:

   What|Removed |Added

 Resolution|FIXED   |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152987] New: "Font Name" drop-down list protrudes from the screen in Qt environment (VCL: qt , kf5)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152987

Bug ID: 152987
   Summary: "Font Name" drop-down list protrudes from the screen
in Qt environment (VCL: qt , kf5)
   Product: LibreOffice
   Version: 7.0 all versions
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: trivial
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ksn...@outlook.jp

Description:
The "Font Name" drop-down list extends below the screen, making it impossible
to select a font at the bottom.
My screen resolution is 1366x768, which is the same height as the minimum
operating requirements.
I have tested this phenomenon in several environments and found the following

[Kubuntu 22.10 (KDE)]
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Ubuntu package version: 1:7.4.2~rc3-0ubuntu1
Calc: threaded
・Version of KDE Frameworks
5.98.0
・The problem occurs.

[Ubuntu 22.10 (GNOME)]
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Ubuntu package version: 1:7.4.2~rc3-0ubuntu1
Calc: threaded
・The problem does not occur.

[Lubuntu 22.10 (LXQt)]
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: qt5 (cairo+xcb)
Locale: en-US (C.UTF-8); UI: en-US
Ubuntu package version: 1:7.4.2~rc3-0ubuntu1
Calc: threaded
・The problem occurs.

[Debian11 (GNOME)]
Version： 7.0.4.2
CPU threads: 2; OS: Linux 5.10
UI render: default; VCL: gtk3
Locale： ja-JP (ja-JP.UTF8); UI: ja-JP
Debian package version:1:7.0.4-4+deb11u4
Calc: threaded
・The problem does not occur.

[Debian11 (KDE)]
Version： 7.0.4.2
CPU threads: 2; OS: Linux 5.10
UI render: default; VCL: kf5
Locale： en-US (en-US.UTF8); UI: en-US
Debian package version:1:7.0.4-4+deb11u3
Calc: threaded
・The problem occurs.

I consulted ask.libreoffice.org about this problem and was told to make the
"ListBoxMaximumLineCount" smaller than the standard 25.
(https://ask.libreoffice.org/t/topic/85359/3)
However, this is not suitable for general use, since it is an Advanced Setting
and the same value works fine in other environments.
Therefore, it is desirable that the vertical size be automatically reduced as
in other environments, or that "ListBoxMaximumLineCount" be set to fit within
the screen even with minimum operating requirements as default.

Steps to Reproduce:
1.Start Libreoffice Writer,Calc,Impress or all other application use same "Font
Name"drop-down list.
2.Click "Font Name"drop-down list (Need a sufficient number of fonts.)
3.

Actual Results:
The drop-down list extends beyond the bottom edge of the screen.

Expected Results:
Drop-down lists are sized to fit on the screen.
(screenshot →
https://ask.libreoffice.org/uploads/asklibo/original/3X/e/1/e13a737aecc8ab35b8ca2f3be087d9e61d280902.png)


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.4.2.3 / LibreOffice Community
Build ID: 40(Build:3)
CPU threads: 2; OS: Linux 5.19; UI render: default; VCL: kf5 (cairo+xcb)
Locale: ja-JP (ja_JP.UTF-8); UI: ja-JP
Ubuntu package version: 1:7.4.2~rc3-0ubuntu1
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149044

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Heiko Tietze  ---
With "autonumbering" do you mean ordered (aka numbered) list?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 149044] autonumbering and the action which caused it are combined into a single undo step

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=149044

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from Heiko Tietze  ---
With "autonumbering" do you mean ordered (aka numbered) list?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: LibreOffice architecture support (was: Fwd: Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*))

[John Paul Adrian Glaubitz]

Hi Stephan!

On 1/12/23 10:48, Stephan Bergmann wrote:

On 10/01/2023 19:57, John Paul Adrian Glaubitz wrote:

Hi Stephan!


There are currently 27 different, per-platform C++ UNO bridge implementations at
bridges/source/cpp_uno/, some of which are presumably dead by now. And my recent

"Rudimentary support for dynamic_cast on UNO proxy objects" (which had to touch
each of them individually) was the latest example how even presumably dead ones
have ongoing maintenance cost. Therefore, I would like to remove (on master,
towards LO 7.6) the ones that can clearly be identified as being dead.

Below, I sorted those 27 implementations into 5 categories: Ideally, each active
implementation would be built regularly by Jenkins; those 9 that are go into 
category
1. Next, there are 2 additional implementations that I know are built for Fedora
releases; they go into category 2. Next, there are 2 additional implementations
that I presume are built for Debian releases (Rene, correct me if I'm wrong);
they go into category 3. And then there are 3 implementations that are 
presumably
in active use elsewhere (Tor, wjh-la, Sakura286, correct me if I'm wrong); which
go into category 4. That leaves 11 implementations that are presumably dead, in
category 5.



(5) Presumably dead:

[...]

* gcc3_solaris_intel
* gcc3_solaris_sparc


Oracle is still maintaining Solaris until at least 2035 and OpenIndiana is 
still maintained, too.

According to this article, LibreOffice 7.2.7 was shipped with OpenIndiana 
2022.10:


https://www.theregister.com/2022/12/07/new_version_of_openindiana/


So, I'm not sure dropping Solaris support is a good idea either.


Thanks for that link.

 From  it looks like at least OpenIndiana only supports 
x86-64, so neither gcc3_solar_intel (32-bit x86) nor gcc3_solaris_sparc (32-bit SPARC) should be relevant 
for it. I'm adding Andreas Wacknitz (who's the author of recent OpenIndiana announcements like 
) in CC, maybe he can 
shed some light on this.  (Andreas, my full original email starting this thread is at 
 "Plan to remove 
dead C++ UNO bridge implementations (bridges/source/cpp_uno/*)").

I don't know if there are any other Solaris-based offerings for which current 
LO master gcc3_solaris_intel and/or gcc3_solar_sparc would still be relevant.  
If somebody knows of any, please report back here.


I'm adding two of the Solaris maintainers at Oracle that I know to ask them 
whether
the SPARC port for LibreOffice is still relevant for them.

Adrian

--
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

[Libreoffice-bugs] [Bug 122652] [META] Memory problems in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=122652
Bug 122652 depends on bug 85603, which changed state.

Bug 85603 Summary: Filesave (Export) as (X)HTML increases memory usage and 
shows false statusbar indication
https://bugs.documentfoundation.org/show_bug.cgi?id=85603

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85603] Filesave (Export) as (X)HTML increases memory usage and shows false statusbar indication

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85603

Alexander Berg  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Alexander Berg  ---
It works now.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108799] [META] HTML export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108799
Bug 108799 depends on bug 85603, which changed state.

Bug 85603 Summary: Filesave (Export) as (X)HTML increases memory usage and 
shows false statusbar indication
https://bugs.documentfoundation.org/show_bug.cgi?id=85603

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: drawinglayer/source

[Stephan Bergmann (via logerrit)]

 drawinglayer/source/processor2d/d2dpixelprocessor2d.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit 0727e4ca62f40a32926a716fd3fe62343cc76b83
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 08:31:48 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 09:51:44 2023 +

loplugin:unnecessaryoverride (clang-cl)

Change-Id: Ib0f721cb0bb7ebfd3b422cfb9e93804a70e1270b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145381
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/drawinglayer/source/processor2d/d2dpixelprocessor2d.cxx 
b/drawinglayer/source/processor2d/d2dpixelprocessor2d.cxx
index 35cc011385aa..2f3d6e25dced 100644
--- a/drawinglayer/source/processor2d/d2dpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/d2dpixelprocessor2d.cxx
@@ -72,8 +72,6 @@ public:
 mpD2DFactory.clear();
 }
 
-~ID2D1GlobalFactoryProvider() {}
-
 sal::systools::COMReference& getID2D1Factory() { return 
mpD2DFactory; }
 };
 
@@ -89,8 +87,6 @@ public:
 {
 }
 
-~ID2D1GlobalRenderTargetProvider() {}
-
 sal::systools::COMReference& getID2D1DCRenderTarget()
 {
 if (!mpID2D1DCRenderTarget && 
aID2D1GlobalFactoryProvider.getID2D1Factory())
@@ -367,8 +363,6 @@ public:
 {
 }
 
-~SystemDependentData_ID2D1Bitmap() {}
-
 const sal::systools::COMReference& getID2D1Bitmap() const { 
return mpD2DBitmap; }
 const std::shared_ptr& getAssociatedAlpha() const { return 
maAssociatedAlpha; }
 

[Libreoffice-commits] core.git: include/toolkit

[Stephan Bergmann (via logerrit)]

 include/toolkit/awt/vclxaccessiblecomponent.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d66a97d5622bfc7c8d68452eb5a3c2378b0b1820
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 08:29:24 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 09:50:49 2023 +

loplugin:crosscast (clang-cl)

> winaccessibility/source/service/AccTopWindowListener.cxx(47,36): error: 
suspicious dynamic cross cast from 'css::accessibility::XAccessible *' to 
'VCLXAccessibleComponent *' [loplugin:crosscast]
> else if (auto pvclxcomponent = 
dynamic_cast(pAccessible))
>
^~~

Change-Id: Iee7585dd2fa0d92af3be6b89d7d08326de3d1e7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145380
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/toolkit/awt/vclxaccessiblecomponent.hxx 
b/include/toolkit/awt/vclxaccessiblecomponent.hxx
index aaf322c6477f..24003d5500f5 100644
--- a/include/toolkit/awt/vclxaccessiblecomponent.hxx
+++ b/include/toolkit/awt/vclxaccessiblecomponent.hxx
@@ -44,7 +44,7 @@ class AccessibleRelationSetHelper;
 typedef ::cppu::ImplHelper1<
 css::lang::XServiceInfo > VCLXAccessibleComponent_BASE;
 
-class TOOLKIT_DLLPUBLIC VCLXAccessibleComponent
+class TOOLKIT_DLLPUBLIC SAL_LOPLUGIN_ANNOTATE("crosscast") 
VCLXAccessibleComponent
 :public comphelper::OAccessibleExtendedComponentHelper
 ,public VCLXAccessibleComponent_BASE
 {

[Libreoffice-bugs] [Bug 152978] [UI/UX enhancement] Open object preferences or options with F4 (and add description to context menus)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152978

Heiko Tietze  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #6 from Heiko Tietze  ---
Shortcuts are defined in
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu. 

DataSourceBrowser > .uno:DBQueryPreview
SpreadsheetDocument > .uno:ToggleRelative
ChartDocument > .uno:TransformDialog
DrawingDocument > .uno:TransformDialog
text.GlobalDocument > .uno:GraphicDialog
PresentationDocument > .uno:TransformDialog
FormulaProperties > .uno:NextMark
text.WebDocument > .uno:GraphicDialog
text.TextDocument > .uno:GraphicDialog
XMLFormDocument > .uno:GraphicDialog
ReportDefinition > .uno:ControlProperties

And we can use only one per module. Meaning this requires a new UNO command,
something like .uno:ObjectProperties, which could then be assigned per module
to F4. Quite some effort.

And changing a shortcut comes on cost for people familiar with other
associations such as the mentioned ToggleRelative or the TransformDialog.

OTOH it's a tempting idea to consolidate behavior. What do you think, Maxim?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152978] [UI/UX enhancement] Open object preferences or options with F4 (and add description to context menus)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152978

Heiko Tietze  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #6 from Heiko Tietze  ---
Shortcuts are defined in
officecfg/registry/data/org/openoffice/Office/Accelerators.xcu. 

DataSourceBrowser > .uno:DBQueryPreview
SpreadsheetDocument > .uno:ToggleRelative
ChartDocument > .uno:TransformDialog
DrawingDocument > .uno:TransformDialog
text.GlobalDocument > .uno:GraphicDialog
PresentationDocument > .uno:TransformDialog
FormulaProperties > .uno:NextMark
text.WebDocument > .uno:GraphicDialog
text.TextDocument > .uno:GraphicDialog
XMLFormDocument > .uno:GraphicDialog
ReportDefinition > .uno:ControlProperties

And we can use only one per module. Meaning this requires a new UNO command,
something like .uno:ObjectProperties, which could then be assigned per module
to F4. Quite some effort.

And changing a shortcut comes on cost for people familiar with other
associations such as the mentioned ToggleRelative or the TransformDialog.

OTOH it's a tempting idea to consolidate behavior. What do you think, Maxim?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Re: LibreOffice architecture support (was: Fwd: Plan to remove dead C++ UNO bridge implementations (bridges/source/cpp_uno/*))

[Stephan Bergmann]

On 10/01/2023 19:57, John Paul Adrian Glaubitz wrote:

Hi Stephan!

There are currently 27 different, per-platform C++ UNO bridge 
implementations at
bridges/source/cpp_uno/, some of which are presumably dead by now. And 
my recent


"Rudimentary support for dynamic_cast on UNO proxy objects" (which had 
to touch
each of them individually) was the latest example how even presumably 
dead ones
have ongoing maintenance cost. Therefore, I would like to remove (on 
master,

towards LO 7.6) the ones that can clearly be identified as being dead.

Below, I sorted those 27 implementations into 5 categories: Ideally, 
each active
implementation would be built regularly by Jenkins; those 9 that are 
go into category
1. Next, there are 2 additional implementations that I know are built 
for Fedora
releases; they go into category 2. Next, there are 2 additional 
implementations
that I presume are built for Debian releases (Rene, correct me if I'm 
wrong);
they go into category 3. And then there are 3 implementations that are 
presumably
in active use elsewhere (Tor, wjh-la, Sakura286, correct me if I'm 
wrong); which
go into category 4. That leaves 11 implementations that are presumably 
dead, in

category 5.



(5) Presumably dead:

[...]

* gcc3_solaris_intel
* gcc3_solaris_sparc


Oracle is still maintaining Solaris until at least 2035 and OpenIndiana 
is still maintained, too.


According to this article, LibreOffice 7.2.7 was shipped with 
OpenIndiana 2022.10:



https://www.theregister.com/2022/12/07/new_version_of_openindiana/


So, I'm not sure dropping Solaris support is a good idea either.


Thanks for that link.

From  it looks like at least 
OpenIndiana only supports x86-64, so neither gcc3_solar_intel (32-bit 
x86) nor gcc3_solaris_sparc (32-bit SPARC) should be relevant for it. 
I'm adding Andreas Wacknitz (who's the author of recent OpenIndiana 
announcements like 
) 
in CC, maybe he can shed some light on this.  (Andreas, my full original 
email starting this thread is at 
 
"Plan to remove dead C++ UNO bridge implementations 
(bridges/source/cpp_uno/*)").


I don't know if there are any other Solaris-based offerings for which 
current LO master gcc3_solaris_intel and/or gcc3_solar_sparc would still 
be relevant.  If somebody knows of any, please report back here.

[Libreoffice-bugs] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #17 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #16)

If bug 99618 is *solved* by that bug 84502, and *this* one is solved at the
same way, then it's a dupe of 84502 the same way. And making dupes for dupes is
simply *wrong*.

Otherwise, you need to clarify which of these bugs is *not* solved yet, and so
which is not a dupe at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #17 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #16)

If bug 99618 is *solved* by that bug 84502, and *this* one is solved at the
same way, then it's a dupe of 84502 the same way. And making dupes for dupes is
simply *wrong*.

Otherwise, you need to clarify which of these bugs is *not* solved yet, and so
which is not a dupe at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 152624] LIST STYLES: Numbered Lists in LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152624

--- Comment #11 from Heiko Tietze  ---
Btw: as you are working with styles, the sidebar has a tab Styles Inspector,
which gives you some insights on the hierarchy of style attributes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152624] LIST STYLES: Numbered Lists in LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152624

--- Comment #11 from Heiko Tietze  ---
Btw: as you are working with styles, the sidebar has a tab Styles Inspector,
which gives you some insights on the hierarchy of style attributes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103369
Bug 103369 depends on bug 152624, which changed state.

Bug 152624 Summary: LIST STYLES: Numbered Lists in LibreOffice Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=152624

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152624] LIST STYLES: Numbered Lists in LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152624

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #10 from Heiko Tietze  ---
(In reply to John La Fountain from comment #7)
> The numbered list below the bulleted list is in a completely separate
> paragraph.  There's no way I want these lists to be considered to related. 

Lists are attributes of paragraphs. The ordered (aka numbered) list
"Independent...Testable" uses / has assigned the list style "Numbering 123".
Paragraphs using this list style increase the number (unless restarted
manually). So if you change the unordered (aka bullet) list to use the same
list style it is added to the beginning.

You can a) restart the list (context menu > List > Restart Numbering) or b) use
a different list style (could be just a duplicate of Numbering 123). Btw, using
the toolbar icon "Toggle ordered list" creates a new list on-the-fly and you
struggle with the continuation (the context menu offers "Add to List" though
limited on the previous paragraph).

In a nutshell, it is a desired feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 152624] LIST STYLES: Numbered Lists in LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152624

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #10 from Heiko Tietze  ---
(In reply to John La Fountain from comment #7)
> The numbered list below the bulleted list is in a completely separate
> paragraph.  There's no way I want these lists to be considered to related. 

Lists are attributes of paragraphs. The ordered (aka numbered) list
"Independent...Testable" uses / has assigned the list style "Numbering 123".
Paragraphs using this list style increase the number (unless restarted
manually). So if you change the unordered (aka bullet) list to use the same
list style it is added to the beginning.

You can a) restart the list (context menu > List > Restart Numbering) or b) use
a different list style (could be just a duplicate of Numbering 123). Btw, using
the toolbar icon "Toggle ordered list" creates a new list on-the-fly and you
struggle with the continuation (the context menu offers "Add to List" though
limited on the previous paragraph).

In a nutshell, it is a desired feature.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 148814] When editing a footer/header in Libreoffice Calc, you cannot use keyboard shortcuts (such as CTRL+C/CTRL+V/CTRL+A) in your native language. Keyboard shortcuts work only

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148814

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Tested on Windows 10, with a German keyboard hardware, and en-GB locale:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec2f1d73936c9d8cee83c0887170e9ecb8f044ba
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

Also tested on Ubuntu 20.04, with German keyboard hardware, and en-US locale:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92deea6301a02f5530f17263f58402344f82013c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

In the Header tab, I had different results depending on if the cut/copied text
was the "Sheet1" (which is a field whose number increments on other sheets, it
can be seen when opening the same dialog on a second sheet) or if it was text
that I added. I could not find issues in the Footer tab.

Changing the keyboard layout in the OS settings did not change the results. I
tested with English (United Kingdom) and German (Germany) on Windows, and with
English (Australian) and German (dead tilde) on Linux.

Ctrl + A always worked.

--- Header tab ---

1) For the original "Sheet1" text:
I _could_ copy and cut it from the Centre area, but I could _not_ paste it in
the three fields of the dialog.
However, I _could_ paste that "Sheet1" in a different app, like Notepad.
After closing the dialog, I could still paste it in a different app but still
couldn't in a Calc cell.

2) For text that I added myself:
Cutting, copying and pasting worked as expected in the dialog, in a Calc cell
after closing the dialog, and in Notepad.

If I copy or cut text that includes both "Sheet1" and some extra text, it only
pastes the custom text (and loses "Sheet1").

--- Footer tab ---

The footer tab was different in that I could copy, cut and paste anything to
and from anywhere, including the original content "Page 1". Pasting the
original "Page 1" in a Calc cell results in "Page ?", the "?" being a field.
Pasting it in Notepad results in "Page 1".

I _could_ copy text before opening the dialog, and then paste text inside the
dialog, in both Header and Footer.

On Linux, it is clearly visible that the whole of "Sheet1" is a field whereas
only the "1" of "Page 1" is a field (thanks to the shading).

--- To summarise ---

According to my tests, my summary of the issue:

"Sheet1" in "Insert > Headers and Footers... > Header" can be cut and copied
but not pasted anywhere in Calc (dialog or cells). Changing the keyboard layout
has no effect.

Leonid, can you please check again and tell us if you see something different?
And please test a newer version of LibreOffice (7.4 or above) because 7.2 and
7.3 have already reached end of life.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 132264] docx document with picture shown in wrong place

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=132264

--- Comment #7 from aj...@elfringham.co.uk ---
Bug still present although behaviour has changed slightly. Picture is still in
wrong place albeit closer than it was and text flow is still wrong. So some
text is still obscured incorrectly. The smaller reproducer does not show the
complete problem as it is missing the text that gets obscured.

Version: 7.4.4.2 / LibreOffice Community
Build ID: 40(Build:2)
CPU threads: 8; OS: Linux 6.0; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-GB
Debian package version: 1:7.4.4~rc2-2
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 121352] Calc red comment indicator is too large and obscures cell values

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=121352

--- Comment #13 from Mira Sherron  ---
Even though the red comment indicator is semi-transparent, it obscures the
values of the cells, making it very difficult to read the last digit in the
cell.

Lower zoom levels, like 60%, make this very obvious and render the document
useless.
https://bubble-shooters.co/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #16 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #15)
> Why the bug that is itself a duplicate gets own duplicates?

The forwarded bug solves the issue in a different way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #16 from Heiko Tietze  ---
(In reply to Mike Kaganski from comment #15)
> Why the bug that is itself a duplicate gets own duplicates?

The forwarded bug solves the issue in a different way.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #15 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #14)
> Duplicate of bug 99618 (F5 should show the docked Navigator if the sidebar
> is open) being itself duplicated to bug 84502 ...
> 
> *** This bug has been marked as a duplicate of bug 99618 ***

Why the bug that is itself a duplicate gets own duplicates? This distorts the
picture, making the main bug have less dupes. Indeed, in this case when the
main bug is already resolved, it might not make a big deal, but still. If bug
99618 is different enough to warrant own duplicates, then it should not be a
dupe itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

--- Comment #15 from Mike Kaganski  ---
(In reply to Heiko Tietze from comment #14)
> Duplicate of bug 99618 (F5 should show the docked Navigator if the sidebar
> is open) being itself duplicated to bug 84502 ...
> 
> *** This bug has been marked as a duplicate of bug 99618 ***

Why the bug that is itself a duplicate gets own duplicates? This distorts the
picture, making the main bug have less dupes. Indeed, in this case when the
main bug is already resolved, it might not make a big deal, but still. If bug
99618 is different enough to warrant own duplicates, then it should not be a
dupe itself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 143100] Disable cell style commands and sidebar when sheet is protected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143100

Heiko Tietze  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0.2 target:7.4.5 |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143100] Disable cell style commands and sidebar when sheet is protected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143100

--- Comment #6 from Commit Notification 
 ---
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/bb0ed581a5624a8827ede86658872daca1754675

Revert "Resolves tdf#143100 - Disable cell style commands when sheet is
protected"

It will be available in 7.4.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 143100] Disable cell style commands and sidebar when sheet is protected

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=143100

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.5.0.2  |target:7.5.0.2 target:7.4.5

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source

[Heiko Tietze (via logerrit)]

 sc/source/ui/view/formatsh.cxx |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit bb0ed581a5624a8827ede86658872daca1754675
Author: Heiko Tietze 
AuthorDate: Fri Jan 6 09:58:25 2023 +
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 09:04:48 2023 +

Revert "Resolves tdf#143100 - Disable cell style commands when sheet is 
protected"

This reverts commit a3cb71ac80c0c2971e97c033d212cf4e464fa8f0.

Reason for revert: tdf#149857

Change-Id: I5ea780b986073a8db16d5dc2ea503aa30da7ef27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145118
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 
(cherry picked from commit 3babbc31bf4bba35924c25c5fbd59e1c314d3627)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145130
Reviewed-by: Xisco Fauli 
(cherry picked from commit 9d6ae0b8d2ebb3931b3c46147e14939e7ed3f3ed)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145229

diff --git a/sc/source/ui/view/formatsh.cxx b/sc/source/ui/view/formatsh.cxx
index 5513c9d76b75..913915a20dc8 100644
--- a/sc/source/ui/view/formatsh.cxx
+++ b/sc/source/ui/view/formatsh.cxx
@@ -189,9 +189,6 @@ void ScFormatShell::GetStyleState( SfxItemSet& rSet )
 rSet.Put( SfxTemplateItem( nSlotId, pStyleSheet->GetName() 
) );
 else
 rSet.Put( SfxTemplateItem( nSlotId, OUString() ) );
-
-if ( bProtected )
-rSet.DisableItem( nSlotId );
 }
 break;
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - bridges/Library_cpp_uno.mk bridges/source

[wjh-la (via logerrit)]

 bridges/Library_cpp_uno.mk|2 
 bridges/source/cpp_uno/gcc3_linux_loongarch64/abi.cxx |  137 
 bridges/source/cpp_uno/gcc3_linux_loongarch64/abi.hxx |   51 
 bridges/source/cpp_uno/gcc3_linux_loongarch64/call.hxx|6 
 bridges/source/cpp_uno/gcc3_linux_loongarch64/call.s  |   15 +
 bridges/source/cpp_uno/gcc3_linux_loongarch64/cpp2uno.cxx |   97 +++--
 bridges/source/cpp_uno/gcc3_linux_loongarch64/share.hxx   |3 
 bridges/source/cpp_uno/gcc3_linux_loongarch64/uno2cpp.cxx |  150 +++---
 8 files changed, 288 insertions(+), 173 deletions(-)

New commits:
commit 14b4f0701c1d8f21e550c57e68c37ae3d8d6f9d6
Author: wjh-la 
AuthorDate: Tue Jan 3 17:22:11 2023 +0800
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 09:02:44 2023 +

bridges:Fixed test fail caused by bridges on the loongarch64

Some failed test are caused by the bridges when testing on the
loongarch64 machine. After adjust the function parameters and return
value processing according to the characteristics of the loongarch64
architercture. I tested in version 7.4.3 on the loongarch64 machine, and
all tests passed.

Change-Id: I9c67287cd7cc89fd79a907afdbffa507bb6052e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144986
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit d3152ea3ae0d6d1bdbc6379c3505812434da6466)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145303

diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk
index 1718202e94d0..5dc92c23cdbb 100644
--- a/bridges/Library_cpp_uno.mk
+++ b/bridges/Library_cpp_uno.mk
@@ -119,7 +119,7 @@ else ifeq ($(CPUNAME),LOONGARCH64)
 ifneq ($(filter LINUX,$(OS)),)
 bridges_SELECTED_BRIDGE := gcc3_linux_loongarch64
 bridge_asm_objects := call
-bridge_noopt_objects := cpp2uno uno2cpp
+bridge_noopt_objects := abi cpp2uno uno2cpp
 bridge_exception_objects := except
 endif
 
diff --git a/bridges/source/cpp_uno/gcc3_linux_loongarch64/abi.cxx 
b/bridges/source/cpp_uno/gcc3_linux_loongarch64/abi.cxx
new file mode 100644
index ..686cbb596317
--- /dev/null
+++ b/bridges/source/cpp_uno/gcc3_linux_loongarch64/abi.cxx
@@ -0,0 +1,137 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#include 
+
+#include "abi.hxx"
+
+int loongarch64::flatten_struct(typelib_TypeDescription* pTypeDescr, 
Registers& regs)
+{
+const typelib_CompoundTypeDescription* p
+= reinterpret_cast(pTypeDescr);
+int sum = p->nMembers;
+for (sal_Int32 i = 0; i < p->nMembers; ++i)
+{
+typelib_TypeDescriptionReference* pTypeInStruct = p->ppTypeRefs[i];
+
+switch (pTypeInStruct->eTypeClass)
+{
+case typelib_TypeClass_STRUCT:
+{
+typelib_TypeDescription* t = 0;
+TYPELIB_DANGER_GET(, pTypeInStruct);
+sum--;
+sum += flatten_struct(t, regs);
+TYPELIB_DANGER_RELEASE(t);
+}
+break;
+case typelib_TypeClass_CHAR:
+case typelib_TypeClass_BOOLEAN:
+case typelib_TypeClass_BYTE:
+case typelib_TypeClass_SHORT:
+case typelib_TypeClass_UNSIGNED_SHORT:
+case typelib_TypeClass_LONG:
+case typelib_TypeClass_UNSIGNED_LONG:
+case typelib_TypeClass_HYPER:
+case typelib_TypeClass_UNSIGNED_HYPER:
+case typelib_TypeClass_ENUM:
+regs.nr_int++;
+if (!regs.priorInt && !regs.priorFp)
+regs.priorInt = true;
+break;
+case typelib_TypeClass_FLOAT:
+case typelib_TypeClass_DOUBLE:
+regs.nr_fp++;
+if (!regs.priorInt && !regs.priorFp)
+regs.priorFp = true;
+break;
+default:
+break;
+}
+}
+return sum;
+}
+
+loongarch64::ReturnKind 
loongarch64::getReturnKind(typelib_TypeDescriptionReference* pTypeRef)
+{
+switch 

[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/reservedid.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1f9317e341e1636c869c465e152f41f5c4037386
Author: Stephan Bergmann 
AuthorDate: Thu Jan 12 08:27:00 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 09:01:16 2023 +

loplugin:reservedid (clang-cl)

...after ef533553559fe09b4afab651fc692885d1acf4ed "Rudimentary support for
dynamic_cast on UNO proxy objects" added those

> extern "C" IMAGE_DOS_HEADER const __ImageBase;

Change-Id: I4d9cf2b7617180d66a8527e0e36631f81e0fb18d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145379
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/reservedid.cxx 
b/compilerplugins/clang/reservedid.cxx
index 477f8c3ffda9..1c2cd1ebbb00 100644
--- a/compilerplugins/clang/reservedid.cxx
+++ b/compilerplugins/clang/reservedid.cxx
@@ -169,6 +169,8 @@ bool ReservedId::VisitNamedDecl(NamedDecl const * decl) {
 // vcl/source/window/cairo_cairo.cxx -> include/vcl/sysdata.hxx
 && s != "__CxxDetectRethrow"
 // bridges/source/cpp_uno/msvc_win32_x86-64/mscx.hxx
+&& s != "__ImageBase"
+// bridges/source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx, MS 
linker magic
 && s != "__PK11_GetKeyData"
 // xmlsecurity/source/xmlsec/nss/nssrenam.h
 && s != "__current_exception" // bridges/inc/except.hxx, Windows

[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65138

Heiko Tietze  changed:

   What|Removed |Added

 Depends on||150975


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=150975
[Bug 150975] View > Navigator (F5) summons a second navigator instead of
opening the sidebar deck (comment 10)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65138
Bug 65138 depends on bug 150975, which changed state.

Bug 150975 Summary: View > Navigator (F5) summons a second navigator instead of 
opening the sidebar deck (comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=150975

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103030
Bug 103030 depends on bug 150975, which changed state.

Bug 150975 Summary: View > Navigator (F5) summons a second navigator instead of 
opening the sidebar deck (comment 10)
https://bugs.documentfoundation.org/show_bug.cgi?id=150975

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 99618] UNO command to launch Navigator in sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99618

Heiko Tietze  changed:

   What|Removed |Added

 CC||aleix.altimi...@gmail.com

--- Comment #33 from Heiko Tietze  ---
*** Bug 150975 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

Heiko Tietze  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
 Blocks||65138
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #14 from Heiko Tietze  ---
Duplicate of bug 99618 (F5 should show the docked Navigator if the sidebar is
open) being itself duplicated to bug 84502 (introduced ctrl+alt+ to
open sidebar decks).

Having both the floating Navigator (ideally docked) and the Sidebar active is
desired by many users. See for example bug 148460. And even more customization
is requested in bug 85905 (undocking of "decks", rather tabs).

If the floating Navigator is docked (or probably if you are not using Wayland)
you can move it from the left side to the right and have it underneath/above
the Sidebar.

*** This bug has been marked as a duplicate of bug 99618 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=65138
[Bug 65138] [META] Sidebar feature related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150975] View > Navigator (F5) summons a second navigator instead of opening the sidebar deck (comment 10)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150975

Heiko Tietze  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
 Blocks||65138
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #14 from Heiko Tietze  ---
Duplicate of bug 99618 (F5 should show the docked Navigator if the sidebar is
open) being itself duplicated to bug 84502 (introduced ctrl+alt+ to
open sidebar decks).

Having both the floating Navigator (ideally docked) and the Sidebar active is
desired by many users. See for example bug 148460. And even more customization
is requested in bug 85905 (undocking of "decks", rather tabs).

If the floating Navigator is docked (or probably if you are not using Wayland)
you can move it from the left side to the right and have it underneath/above
the Sidebar.

*** This bug has been marked as a duplicate of bug 99618 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=65138
[Bug 65138] [META] Sidebar feature related issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 151228] [META] Search for commands

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151228

Mike Kaganski  changed:

   What|Removed |Added

 Depends on||142931


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142931
[Bug 142931] Tabbed notebook bar Icon for 'Command Popup HUD'  tdf#91874
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 91874] A Search by function or keyword over main menu-- similar to SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91874

Mike Kaganski  changed:

   What|Removed |Added

 Depends on|142931  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=142931
[Bug 142931] Tabbed notebook bar Icon for 'Command Popup HUD'  tdf#91874
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142931] Tabbed notebook bar Icon for 'Command Popup HUD' tdf#91874

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142931

Mike Kaganski  changed:

   What|Removed |Added

 Blocks|91874   |151228


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91874
[Bug 91874] A Search by function or keyword over main menu-- similar to
SpotLight, Tell Me, or Ubuntu's HUD but native for LO GUI
https://bugs.documentfoundation.org/show_bug.cgi?id=151228
[Bug 151228] [META] Search for commands
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 110434] [META] Envelope bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=110434
Bug 110434 depends on bug 107625, which changed state.

Bug 107625 Summary: Envelope dialog: Make dialog more a11y friendly
https://bugs.documentfoundation.org/show_bug.cgi?id=107625

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 102019] [META] Dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=102019
Bug 102019 depends on bug 107625, which changed state.

Bug 107625 Summary: Envelope dialog: Make dialog more a11y friendly
https://bugs.documentfoundation.org/show_bug.cgi?id=107625

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=101912
Bug 101912 depends on bug 107625, which changed state.

Bug 107625 Summary: Envelope dialog: Make dialog more a11y friendly
https://bugs.documentfoundation.org/show_bug.cgi?id=107625

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc vcl/unx

[Caolán McNamara (via logerrit)]

 vcl/inc/headless/BitmapHelper.hxx   |4 +-
 vcl/inc/headless/CairoCommon.hxx|2 -
 vcl/unx/generic/window/salframe.cxx |   61 ++--
 3 files changed, 41 insertions(+), 26 deletions(-)

New commits:
commit 1e96a295024b6a200afff2065786885ea3b131b4
Author: Caolán McNamara 
AuthorDate: Tue Jan 10 20:53:17 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Jan 12 08:49:06 2023 +

this is never a X11SalBitmap anymore

Change-Id: I9f645128709bce93be1c8548614b5e72e6667844
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145292
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/inc/headless/BitmapHelper.hxx 
b/vcl/inc/headless/BitmapHelper.hxx
index 0aed5e3693fc..dbd7e86675e3 100644
--- a/vcl/inc/headless/BitmapHelper.hxx
+++ b/vcl/inc/headless/BitmapHelper.hxx
@@ -23,7 +23,7 @@
 #include 
 #include 
 
-class BitmapHelper : public SurfaceHelper
+class VCL_DLLPUBLIC BitmapHelper : public SurfaceHelper
 {
 private:
 #ifdef HAVE_CAIRO_FORMAT_RGB24_888
@@ -37,7 +37,7 @@ public:
 unsigned char* getBits(sal_Int32& rStride);
 };
 
-class MaskHelper : public SurfaceHelper
+class VCL_DLLPUBLIC MaskHelper : public SurfaceHelper
 {
 private:
 std::unique_ptr pAlphaBits;
diff --git a/vcl/inc/headless/CairoCommon.hxx b/vcl/inc/headless/CairoCommon.hxx
index 4cbe1af538ba..cd011b2a9eab 100644
--- a/vcl/inc/headless/CairoCommon.hxx
+++ b/vcl/inc/headless/CairoCommon.hxx
@@ -234,7 +234,7 @@ private:
 sal_Int32 nWidth) const;
 };
 
-class SurfaceHelper
+class VCL_DLLPUBLIC SurfaceHelper
 {
 private:
 cairo_surface_t* pSurface;
diff --git a/vcl/unx/generic/window/salframe.cxx 
b/vcl/unx/generic/window/salframe.cxx
index bdf22ca0dc33..325cb8853fe6 100644
--- a/vcl/unx/generic/window/salframe.cxx
+++ b/vcl/unx/generic/window/salframe.cxx
@@ -38,11 +38,12 @@
 #include 
 #include 
 
+#include 
+#include 
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -307,11 +308,12 @@ static bool lcl_SelectAppIconPixmap( SalDisplay const 
*pDisplay, SalX11Screen nX
 if( aIcon.IsEmpty() )
 return false;
 
-X11SalBitmap *pBitmap = dynamic_cast < X11SalBitmap * >
+SvpSalBitmap* pBitmap = dynamic_cast
 (aIcon.ImplGetBitmapSalBitmap().get());
-if (!pBitmap) // FIXME: opengl , TODO SKIA
+if (!pBitmap) // FIXME: TODO SKIA
 return false;
 
+// Note: can't find a working environment where this seems to matter 
anymore,
 icon_pixmap = XCreatePixmap( pDisplay->GetDisplay(),
  pDisplay->GetRootWindow( nXScreen ),
  iconSize, iconSize,
@@ -319,39 +321,52 @@ static bool lcl_SelectAppIconPixmap( SalDisplay const 
*pDisplay, SalX11Screen nX
nXScreen.getXScreen() )
  );
 
-SalTwoRect aRect(0, 0, iconSize, iconSize, 0, 0, iconSize, iconSize);
+{
+cairo_surface_t* pSurface = 
cairo_xlib_surface_create(pDisplay->GetDisplay(), icon_pixmap,
+   
pDisplay->GetColormap(nXScreen).GetVisual().visual,
+   iconSize, iconSize);
+
+cairo_t* cr = cairo_create(pSurface);
+
+BitmapHelper aBitmapHelper(*pBitmap);
+cairo_surface_t* source = aBitmapHelper.getSurface(iconSize, iconSize);
 
-pBitmap->ImplDraw( icon_pixmap,
-   nXScreen,
-   DefaultDepth( pDisplay->GetDisplay(),
- nXScreen.getXScreen() ),
-   aRect,
-   DefaultGC( pDisplay->GetDisplay(),
-  nXScreen.getXScreen() ) );
+cairo_rectangle(cr, 0, 0, iconSize, iconSize);
+cairo_set_source_surface(cr, source, 0, 0);
+cairo_paint(cr);
+
+cairo_destroy(cr);
+cairo_surface_destroy(pSurface);
+}
 
 icon_mask = None;
 
 if( aIcon.IsAlpha() )
 {
 icon_mask = XCreatePixmap( pDisplay->GetDisplay(),
-   pDisplay->GetRootWindow( 
pDisplay->GetDefaultXScreen() ),
+   pDisplay->GetRootWindow(nXScreen),
iconSize, iconSize, 1);
 
-XGCValues aValues;
-aValues.foreground = 0x;
-aValues.background = 0;
-aValues.function = GXcopy;
-GC aMonoGC = XCreateGC( pDisplay->GetDisplay(), icon_mask,
-GCFunction|GCForeground|GCBackground,  );
-
 Bitmap aMask = aIcon.GetAlphaMask();
-aMask.Invert();
 
-X11SalBitmap *pMask = static_cast < X11SalBitmap * >
+SvpSalBitmap* pMask = static_cast
 (aMask.ImplGetSalBitmap().get());
 
-pMask->ImplDraw(icon_mask, nXScreen, 1, aRect, aMonoGC);
-XFreeGC( pDisplay->GetDisplay(), aMonoGC 

[Libreoffice-commits] core.git: vcl/source

[Caolán McNamara (via logerrit)]

 vcl/source/edit/vclmedit.cxx |   15 +--
 1 file changed, 13 insertions(+), 2 deletions(-)

New commits:
commit 0f348ba55db9eabe990b5bbeb42d1d94b3b70e79
Author: Caolán McNamara 
AuthorDate: Mon Jan 9 10:32:37 2023 +
Commit: Caolán McNamara 
CommitDate: Thu Jan 12 08:48:26 2023 +

Resolves: tdf#107625 make ctrl+tab act like tab when tab is an input char

Change-Id: Ic3d698920fc94df1adf142e4cbab9725ae45273c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145193
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/edit/vclmedit.cxx b/vcl/source/edit/vclmedit.cxx
index d24e118b4f7e..3008a7e887d0 100644
--- a/vcl/source/edit/vclmedit.cxx
+++ b/vcl/source/edit/vclmedit.cxx
@@ -724,8 +724,19 @@ void TextWindow::KeyInput( const KeyEvent& rKEvent )
 }
 else if ( nCode == KEY_TAB )
 {
-if ( !mbIgnoreTab || rKEvent.GetKeyCode().IsMod1() )
-bDone = mpExtTextView->KeyInput( rKEvent  );
+if (!mbIgnoreTab)
+{
+if (!rKEvent.GetKeyCode().IsMod1())
+bDone = mpExtTextView->KeyInput(rKEvent);
+else
+{
+// tdf#107625 make ctrl+tab act like tab when MultiLine Edit 
normally accepts tab as an input char
+vcl::KeyCode aKeyCode(rKEvent.GetKeyCode().GetCode(), 
rKEvent.GetKeyCode().GetModifier() & ~KEY_MOD1);
+KeyEvent aKEventWithoutMod1(rKEvent.GetCharCode(), aKeyCode, 
rKEvent.GetRepeat());
+Window::KeyInput(aKEventWithoutMod1);
+bDone = true;
+}
+}
 }
 else
 {

[Libreoffice-bugs] [Bug 152799] Assert with ungroup shapes and also gets some warning in console with debug LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152799

Xisco Faulí  changed:

   What|Removed |Added

Summary|Crash with ungroup shapes   |Assert with ungroup shapes
   |and also gets some warning  |and also gets some warning
   |in console with debug LO|in console with debug LO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152986] New: WEEKSINYEAR needs mentioning that it's based on ISO 8601

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152986

Bug ID: 152986
   Summary: WEEKSINYEAR needs mentioning that it's based on ISO
8601
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com
CC: olivier.hal...@libreoffice.org

WEEKSINYEAR function [1] counts weeks; and that count generally depends on a
convention which year a given week belongs to. E.g., there exists a convention
that the first week of a year is the week that includes Jan 1st (so the first
week of the year could have 6 days in the previous year); or that the first
week of a year is the week which has most of its days in this year; and also
the question is, what is the first day of a week (Sunday? Monday?), which can
make the difference.

WEEKSINYEAR is implemented to follow ISO 8601 conventions on this [2] (namely,
the week starts on Monday; and the first week of a year is the one with most
days in this year, which is equal to "the week containing Jan 4th", which is
equal to "the week with the first Thursday belonging this year").

This should be reflected in the help (maybe as simple as "The function is based
on ISO 8601"). Other date-related add-in functions could also need similar
clarifications.

[1]
https://help.libreoffice.org/7.5/en-US/text/scalc/01/04060111.html?DbPAR=CALC#bm_id3145237
[2]
https://opengrok.libreoffice.org/xref/core/scaddins/source/datefunc/datefunc.cxx?r=dac843c4#616

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152799] Crash with ungroup shapes and also gets some warning in console with debug LO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152799

Xisco Faulí  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #11 from Xisco Faulí  ---
Not reproducible with a release build

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d993327eab0a2c9c8820c6528075b01de68b0ec6
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152985] Page number field formats "a..aa..aaa" and "A..AA..AAA" are the same as "a b c" and "A B C"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152985

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
Created attachment 184606
  --> https://bugs.documentfoundation.org/attachment.cgi?id=184606=edit
test ODT created in LO 7.4.3.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152985] Page number field formats "a..aa..aaa" and "A..AA..AAA" are the same as "a b c" and "A B C"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152985

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|7.4.3.2 release |Inherited From OOo
 Status|NEEDINFO|NEW
 Blocks||108746
 OS|All |Linux (All)
Summary|Format page number  |Page number field formats
   ||"a..aa..aaa" and
   ||"A..AA..AAA" are the same
   ||as "a b c" and "A B C"

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
OK, I can now reproduce for a.aa..aaa and A..AA..AAA: they are both equivalent
to "a b c" and "A B C".

Steps to reproduce:
1. Open Writer
2. Ctrl + Return for a page break
3. Insert > Page Number
4. Doube-click on the field
5. Change format to "a..aa..aaa", OK
6. On the next like, do steps 3-5 again but for format "A..AA..AAA"

Reproduced in:

OpenOffice.org 3.3.0
OOO330m20 (Build:9567)

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Version: 7.5.0.1 (X86_64) / LibreOffice Community
Build ID: 77cd3d7ad4445740a0c6cf977992dafd8ebad8df
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

And a master build from today:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92deea6301a02f5530f17263f58402344f82013c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same on Win 10 (tested with LO 7.5)


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=108746
[Bug 108746] [META] Page number field bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108746] [META] Page number field bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108746

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||152985


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152985
[Bug 152985] Page number field formats "a..aa..aaa" and "A..AA..AAA" are the
same as "a b c" and "A B C"
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151504] Navigator dialog docked above sidebar increases size while editing document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151504

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|Navigator sidebar   |Navigator dialog docked
   ||above sidebar increases
   ||size while editing document

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
(In reply to Heiko Tietze from comment #5)
> Maybe a DUP of bug 85905?

I don't think so. As I understand Louise's issue, the docked navigator gets
bigger and bigger as she edits the document (and the sidebar smaller and
smaller).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 151504] Navigator sidebar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=151504

Heiko Tietze  changed:

   What|Removed |Added

 CC||heiko.tietze@documentfounda
   ||tion.org

--- Comment #5 from Heiko Tietze  ---
Maybe a DUP of bug 85905?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/Module_vcl.mk

[Tor Lillqvist (via logerrit)]

 vcl/Module_vcl.mk |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 743713648e1abc124fc5783f3ea6a20b7d73701d
Author: Tor Lillqvist 
AuthorDate: Wed Jan 11 12:56:04 2023 +0200
Commit: Tor Lillqvist 
CommitDate: Thu Jan 12 08:26:22 2023 +

Don't bother building the vcldemo executable for WASM unless using Qt5

Reduces build time a bit.

Sadly, we do need to build soffice.wasm also when not using Qt5,
because wasm/Makefile.am in online uses its .linkdeps file.

Change-Id: I48f67598050208220e63e3a0ff627f6420ff837f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145353
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist 

diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 596ed5b8c03a..b6d06a6bc351 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -37,7 +37,9 @@ $(eval $(call gb_Module_add_targets,vcl,\
 $(if $(filter DESKTOP FUZZERS,$(BUILD_TYPE)), \
 StaticLibrary_vclmain \
 $(if $(or $(DISABLE_GUI),$(DISABLE_DYNLOADING)), \
-$(if $(filter EMSCRIPTEN,$(OS)),Executable_vcldemo) \
+$(if $(filter EMSCRIPTEN,$(OS)), \
+$(if $(ENABLE_QT5),Executable_vcldemo) \
+) \
 , \
 $(if $(filter LINUX MACOSX SOLARIS WNT %BSD,$(OS)), \
 Executable_vcldemo \

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - framework/source

[Noel Grandin (via logerrit)]

 framework/source/fwe/helper/undomanagerhelper.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 412c714ea2293aba871829329036fa26b812225c
Author: Noel Grandin 
AuthorDate: Wed Jan 11 09:29:00 2023 +0200
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 08:25:03 2023 +

fix deadlock observed on jenkins

where we are locking SolarMutex and UndoManagerHelper_Impl::m_aMutex in
different orders in different code-paths, which is deadly when we call
into the same class recursively.

Thread 2 (Thread 0x7f5cf303b700 (LWP 22637)):
(this=0x7f5cf3037cd8) at include/vcl/svapp.hxx:1373
framework::UndoManagerHelper_Impl::impl_clear() (this=0x5f90d50) at
framework/source/fwe/helper/undomanagerhelper.cxx:691
  holds UndoManagerHelper_Impl::m_aMutex
  tries to acquire SolarMutex

framework::UndoManagerHelper_Impl::clear(framework::IMutexGuard&)::$_3::operator()()
const (this=0x5519040) at
framework/source/fwe/helper/undomanagerhelper.cxx:403

framework::UndoManagerHelper_Impl::clear(framework::IMutexGuard&)::$_3>::_M_invoke(std::_Any_data
const&) (__functor=...) at

/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_function.h:316
(this=0x5519040) at

/opt/rh/devtoolset-7/root/usr/lib/gcc/x86_64-redhat-linux/7/../../../../include/c++/7/bits/std_function.h:706
namespace)::UndoManagerRequest::execute() (this=0x5519030) at
framework/source/fwe/helper/undomanagerhelper.cxx:160
framework::UndoManagerHelper_Impl::impl_processRequest(std::function const&, framework::IMutexGuard&) (this=0x5f90d50, i_request=...,
i_instanceLock=...) at
framework/source/fwe/helper/undomanagerhelper.cxx:490
framework::UndoManagerHelper_Impl::clear(framework::IMutexGuard&)
(this=0x5f90d50, i_instanceLock=...) at
framework/source/fwe/helper/undomanagerhelper.cxx:402
framework::UndoManagerHelper::clear(framework::IMutexGuard&)
(this=0x5f90c38, i_instanceLock=...) at
framework/source/fwe/helper/undomanagerhelper.cxx:999
at chart2/source/model/main/UndoManager.cxx:278
void*, _typelib_TypeDescriptionReference*, bool, unsigned long*,
unsigned int, unsigned long*, double*) (pThis=0x5f90bc8,
nVtableIndex=18, pRegisterReturn=0x0, pReturnTypeRef=0xa2dac0,
bSimpleReturn=true, pStack=0x7f5cf30380e0, nStack=0,
pGPR=0x7f5cf30383e0, pFPR=0x7f5cf30383a0) at
bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77
cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*,
bridges::cpp_uno::shared::VtableSlot,
_typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*,
void*, void**, _uno_Any**) (pThis=0x5e40ac0, aVtableSlot=...,
pReturnTypeRef=0xa2dac0, nParams=0, pParams=0x0, pUnoReturn=0x0,
pUnoArgs=0x0, ppUnoExc=0x7f5cf30388e0) at
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233
pMemberDescr=0x551dd30, pReturn=0x0, pArgs=0x0,
ppException=0x7f5cf30388e0) at
bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413
binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*,
std::__debug::vector >*) const (this=0x28a3cc0,
returnValue=0x7f5cf3039040, outArguments=0x7f5cf3039008) at
binaryurp/source/incomingrequest.cxx:236
(this=0x28a3cc0) at binaryurp/source/incomingrequest.cxx:79

Thread 1 (Thread 0x7f5cfd03eec0 (LWP 22302)):
(this=0x7ffcdf1b1720, t=...) at include/osl/mutex.hxx:144

comphelper::OInterfaceContainerHelper3::addInterface(com::sun::star::uno::Reference
const&) (this=0x5f90da0, rListener=...) at
include/comphelper/interfacecontainer3.hxx:313
trying to acquire UndoManagerHelper_Impl::m_aMutex

framework::UndoManagerHelper_Impl::addModifyListener(com::sun::star::uno::Reference
const&) (this=0x5f90d50, i_listener=...) at
framework/source/fwe/helper/undomanagerhelper.cxx:286

framework::UndoManagerHelper::addModifyListener(com::sun::star::uno::Reference
const&) (this=0x5f90c38, i_listener=...) at
framework/source/fwe/helper/undomanagerhelper.cxx:1047

chart::UndoManager::addModifyListener(com::sun::star::uno::Reference
const&) (this=0x5f90bc0, i_listener=...) at
chart2/source/model/main/UndoManager.cxx:338
(this=0x1d470d0) at
chart2/source/controller/main/UndoCommandDispatch.cxx:57
chart::CommandDispatchContainer::getDispatchForURL(com::sun::star::util::URL
const&) (this=0x5f66e58, rURL=...) at
chart2/source/controller/main/CommandDispatchContainer.cxx:93
chart::ChartController::queryDispatch(com::sun::star::util::URL const&,
rtl::OUString const&, int) (this=0x5f66c50, rURL=...,
rTargetFrameName=...) at
chart2/source/controller/main/ChartController.cxx:1055
locks SolarMutex
chart::ChartController::queryDispatch(com::sun::star::util::URL const&,
rtl::OUString const&, int) () at

[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - desktop/source extensions/source

[Julien Nabet (via logerrit)]

 desktop/source/app/updater.cxx  |6 +-
 extensions/source/update/check/download.cxx |   22 +-
 2 files changed, 18 insertions(+), 10 deletions(-)

New commits:
commit dd282dde51e76bdb5e0b9b33da3c8483bfb0315a
Author: Julien Nabet 
AuthorDate: Mon Jan 9 13:54:45 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 08:23:53 2023 +

Fix types for Curl elements (update part)

"CURLOPT_REDIR_PROTOCOLS_STR" has been added with Curl 7.85
so check if Curl version is 7.85 min or use the previous version 
"CURLOPT_REDIR_PROTOCOLS"

Change-Id: Iacf6a3c37aba63d615eaa93352b098b1c9183533
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145208
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit 071c66521c6db7136ea7f4606d48ab9fbcc4c71d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145306
Reviewed-by: Xisco Fauli 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index e2cfcea15eac..9b5aa98eaf7d 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -563,7 +563,11 @@ std::string download_content(const OString& rURL, bool 
bFile, OUString& rHash)
 curl_easy_setopt(curl.get(), CURLOPT_HTTPHEADER, headerlist);
 curl_easy_setopt(curl.get(), CURLOPT_FOLLOWLOCATION, 1); // follow 
redirects
 // only allow redirect to http:// and https://
-curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS_STR, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+#if (LIBCURL_VERSION_MAJOR > 7) || (LIBCURL_VERSION_MAJOR == 7 && 
LIBCURL_VERSION_MINOR >= 85)
+curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+#else
+curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+#endif
 
 std::string response_body;
 utl::TempFile aTempFile;
diff --git a/extensions/source/update/check/download.cxx 
b/extensions/source/update/check/download.cxx
index 3b76f9cc8a27..4ba5863930ba 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -60,8 +60,8 @@ static void openFile( OutData& out )
 char * effective_url;
 curl_easy_getinfo(out.curl, CURLINFO_EFFECTIVE_URL, _url);
 
-double fDownloadSize;
-curl_easy_getinfo(out.curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
);
+curl_off_t nDownloadSize;
+curl_easy_getinfo(out.curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
);
 
 OString aURL(effective_url);
 
@@ -94,7 +94,7 @@ static void openFile( OutData& out )
 } while( osl_File_E_EXIST == rc );
 
 if( osl_File_E_None == rc )
-out.Handler->downloadStarted(out.File, 
static_cast(fDownloadSize));
+out.Handler->downloadStarted(out.File, 
static_cast(nDownloadSize));
 }
 }
 
@@ -140,7 +140,7 @@ write_function( void *ptr, size_t size, size_t nmemb, void 
*stream )
 
 
 static int
-progress_callback( void *clientp, double dltotal, double dlnow, 
SAL_UNUSED_PARAMETER double, SAL_UNUSED_PARAMETER double )
+progress_callback( void *clientp, curl_off_t dltotal, curl_off_t dlnow, 
SAL_UNUSED_PARAMETER curl_off_t, SAL_UNUSED_PARAMETER curl_off_t)
 {
 OutData *out = static_cast < OutData * > (clientp);
 
@@ -148,7 +148,7 @@ progress_callback( void *clientp, double dltotal, double 
dlnow, SAL_UNUSED_PARAM
 
 if (out && !out->StopCondition.check())
 {
-double fPercent = 0;
+float fPercent = 0;
 if ( dltotal + out->Offset )
 fPercent = (dlnow + out->Offset) * 100 / (dltotal + out->Offset);
 if( fPercent < 0 )
@@ -233,7 +233,11 @@ static bool curl_run(std::u16string_view rURL, OutData& 
out, const OString& aPro
 // enable redirection
 (void)curl_easy_setopt(pCURL, CURLOPT_FOLLOWLOCATION, 1);
 // only allow redirect to http:// and https://
-(void)curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS_STR, 
CURLPROTO_HTTP | CURLPROTO_HTTPS);
+#if (LIBCURL_VERSION_MAJOR > 7) || (LIBCURL_VERSION_MAJOR == 7 && 
LIBCURL_VERSION_MINOR >= 85)
+curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+#else
+curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+#endif
 
 // write function
 (void)curl_easy_setopt(pCURL, CURLOPT_WRITEDATA, );
@@ -274,9 +278,9 @@ static bool curl_run(std::u16string_view rURL, OutData& 
out, const OString& aPro
 {
 // this sometimes happens, when a user throws away his user data, 
but has already
 // completed the download of an update.
-double fDownloadSize;
-curl_easy_getinfo( pCURL, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
 );
-if ( -1 == fDownloadSize )
+curl_off_t nDownloadSize;
+curl_easy_getinfo( pCURL, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
 );
+if ( -1 == nDownloadSize )
 {
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - desktop/source extensions/source

[Julien Nabet (via logerrit)]

 desktop/source/app/updater.cxx  |6 +-
 extensions/source/update/check/download.cxx |   22 +-
 2 files changed, 18 insertions(+), 10 deletions(-)

New commits:
commit 3a3f6fb74781b4e1def227e88d2b96449acdc4c1
Author: Julien Nabet 
AuthorDate: Mon Jan 9 13:54:45 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 08:23:36 2023 +

Fix types for Curl elements (update part)

"CURLOPT_REDIR_PROTOCOLS_STR" has been added with Curl 7.85
so check if Curl version is 7.85 min or use the previous version 
"CURLOPT_REDIR_PROTOCOLS"

Change-Id: Iacf6a3c37aba63d615eaa93352b098b1c9183533
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145208
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit 071c66521c6db7136ea7f4606d48ab9fbcc4c71d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145304
Reviewed-by: Xisco Fauli 

diff --git a/desktop/source/app/updater.cxx b/desktop/source/app/updater.cxx
index 9f60a64d7235..f74dfbeceb6e 100644
--- a/desktop/source/app/updater.cxx
+++ b/desktop/source/app/updater.cxx
@@ -563,7 +563,11 @@ std::string download_content(const OString& rURL, bool 
bFile, OUString& rHash)
 curl_easy_setopt(curl.get(), CURLOPT_HTTPHEADER, headerlist);
 curl_easy_setopt(curl.get(), CURLOPT_FOLLOWLOCATION, 1); // follow 
redirects
 // only allow redirect to http:// and https://
-curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS_STR, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+#if (LIBCURL_VERSION_MAJOR > 7) || (LIBCURL_VERSION_MAJOR == 7 && 
LIBCURL_VERSION_MINOR >= 85)
+curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+#else
+curl_easy_setopt(curl.get(), CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+#endif
 
 std::string response_body;
 utl::TempFileNamed aTempFile;
diff --git a/extensions/source/update/check/download.cxx 
b/extensions/source/update/check/download.cxx
index 3b76f9cc8a27..4ba5863930ba 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -60,8 +60,8 @@ static void openFile( OutData& out )
 char * effective_url;
 curl_easy_getinfo(out.curl, CURLINFO_EFFECTIVE_URL, _url);
 
-double fDownloadSize;
-curl_easy_getinfo(out.curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
);
+curl_off_t nDownloadSize;
+curl_easy_getinfo(out.curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
);
 
 OString aURL(effective_url);
 
@@ -94,7 +94,7 @@ static void openFile( OutData& out )
 } while( osl_File_E_EXIST == rc );
 
 if( osl_File_E_None == rc )
-out.Handler->downloadStarted(out.File, 
static_cast(fDownloadSize));
+out.Handler->downloadStarted(out.File, 
static_cast(nDownloadSize));
 }
 }
 
@@ -140,7 +140,7 @@ write_function( void *ptr, size_t size, size_t nmemb, void 
*stream )
 
 
 static int
-progress_callback( void *clientp, double dltotal, double dlnow, 
SAL_UNUSED_PARAMETER double, SAL_UNUSED_PARAMETER double )
+progress_callback( void *clientp, curl_off_t dltotal, curl_off_t dlnow, 
SAL_UNUSED_PARAMETER curl_off_t, SAL_UNUSED_PARAMETER curl_off_t)
 {
 OutData *out = static_cast < OutData * > (clientp);
 
@@ -148,7 +148,7 @@ progress_callback( void *clientp, double dltotal, double 
dlnow, SAL_UNUSED_PARAM
 
 if (out && !out->StopCondition.check())
 {
-double fPercent = 0;
+float fPercent = 0;
 if ( dltotal + out->Offset )
 fPercent = (dlnow + out->Offset) * 100 / (dltotal + out->Offset);
 if( fPercent < 0 )
@@ -233,7 +233,11 @@ static bool curl_run(std::u16string_view rURL, OutData& 
out, const OString& aPro
 // enable redirection
 (void)curl_easy_setopt(pCURL, CURLOPT_FOLLOWLOCATION, 1);
 // only allow redirect to http:// and https://
-(void)curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS_STR, 
CURLPROTO_HTTP | CURLPROTO_HTTPS);
+#if (LIBCURL_VERSION_MAJOR > 7) || (LIBCURL_VERSION_MAJOR == 7 && 
LIBCURL_VERSION_MINOR >= 85)
+curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS_STR, "http,https");
+#else
+curl_easy_setopt(pCURL, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | 
CURLPROTO_HTTPS);
+#endif
 
 // write function
 (void)curl_easy_setopt(pCURL, CURLOPT_WRITEDATA, );
@@ -274,9 +278,9 @@ static bool curl_run(std::u16string_view rURL, OutData& 
out, const OString& aPro
 {
 // this sometimes happens, when a user throws away his user data, 
but has already
 // completed the download of an update.
-double fDownloadSize;
-curl_easy_getinfo( pCURL, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
 );
-if ( -1 == fDownloadSize )
+curl_off_t nDownloadSize;
+curl_easy_getinfo( pCURL, CURLINFO_CONTENT_LENGTH_DOWNLOAD_T, 
 );
+if ( -1 == nDownloadSize )
 {
 

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - cui/source sw/source

[Aron Budea (via logerrit)]

 cui/source/options/treeopt.cxx  |8 
 sw/source/uibase/shells/textsh1.cxx |8 
 2 files changed, 16 insertions(+)

New commits:
commit 41caa548b4655ab9be5e778cb7835584add8470c
Author: Aron Budea 
AuthorDate: Mon Jan 9 04:10:33 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 08:22:35 2023 +

Make DeepL translator experimental for now

Needs documentation.

Change-Id: If77436a37b5ec40f3eb08a32f0315c1696428c12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145184
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 
(cherry picked from commit 0a2b048482e079e4e83307ad00ba7704a4cc815e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145232
Reviewed-by: Xisco Fauli 

diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 805ddfc48317..8004c7f15a11 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -1418,6 +1418,14 @@ void OfaTreeOptionsDialog::Initialize( const Reference< 
XFrame >& _xFrame )
 nPageId = 
static_cast(SID_LANGUAGE_OPTIONS_RES[i].second);
 if ( lcl_isOptionHidden( nPageId, aOptionsDlgOpt ) )
 continue;
+
+// Disable DeepL translation settings, if experimental mode is not 
enabled
+if( RID_SVXPAGE_DEEPL_OPTIONS == nPageId )
+{
+if( ! officecfg::Office::Common::Misc::ExperimentalMode::get() 
)
+continue;
+}
+
 if ( ( RID_SVXPAGE_JSEARCH_OPTIONS != nPageId || 
SvtCJKOptions::IsJapaneseFindEnabled() ) &&
  ( RID_SVXPAGE_ASIAN_LAYOUT != nPageId|| 
SvtCJKOptions::IsAsianTypographyEnabled() ) &&
  ( RID_SVXPAGE_OPTIONS_CTL != nPageId || 
aCTLLanguageOptions.IsCTLFontEnabled() ) )
diff --git a/sw/source/uibase/shells/textsh1.cxx 
b/sw/source/uibase/shells/textsh1.cxx
index 3b6f8baa9626..832f6d7820c1 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -105,6 +105,8 @@
 #include 
 #include 
 #if !ENABLE_WASM_STRIP_EXTRA
+#include 
+#include 
 #include 
 #include 
 #endif // ENABLE_WASM_STRIP_EXTRA
@@ -2065,6 +2067,12 @@ void SwTextShell::GetState( SfxItemSet  )
 case SID_FM_TRANSLATE:
 {
 #if !ENABLE_WASM_STRIP_EXTRA
+if 
(!officecfg::Office::Common::Misc::ExperimentalMode::get()
+&& !comphelper::LibreOfficeKit::isActive())
+{
+rSet.Put(SfxVisibilityItem(nWhich, false));
+break;
+}
 const SvxDeeplOptions& rDeeplOptions = 
SvxDeeplOptions::Get();
 if (rDeeplOptions.getAPIUrl().isEmpty() || 
rDeeplOptions.getAuthKey().isEmpty())
 {

[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/dbgui/tpsort.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 34789a2a7678435b142165647aba20b55c086fcb
Author: Caolán McNamara 
AuthorDate: Tue Jan 10 10:32:10 2023 +
Commit: Xisco Fauli 
CommitDate: Thu Jan 12 08:22:13 2023 +

Resolves: tdf#152950 don't set_active while frozen

Change-Id: I7db73e37ed426aae2282a6bf1564e5d3843442cf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145230
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sc/source/ui/dbgui/tpsort.cxx b/sc/source/ui/dbgui/tpsort.cxx
index 3455f11006cf..35a24e633058 100644
--- a/sc/source/ui/dbgui/tpsort.cxx
+++ b/sc/source/ui/dbgui/tpsort.cxx
@@ -813,6 +813,8 @@ void ScTabPageSortOptions::EdOutPosModHdl()
 
 void ScTabPageSortOptions::FillAlgor()
 {
+tools::Long nCount = 0;
+
 m_xLbAlgorithm->freeze();
 m_xLbAlgorithm->clear();
 
@@ -830,18 +832,19 @@ void ScTabPageSortOptions::FillAlgor()
 lang::Locale aLocale( LanguageTag::convertToLocale( eLang ));
 const uno::Sequence aAlgos = 
m_xColWrap->listCollatorAlgorithms( aLocale );
 
-tools::Long nCount = aAlgos.getLength();
+nCount = aAlgos.getLength();
 for (const OUString& sAlg : aAlgos)
 {
 OUString sUser = m_xColRes->GetTranslation( sAlg );
 m_xLbAlgorithm->append_text(sUser);
 }
-m_xLbAlgorithm->set_active(0);   // first entry is default
-m_xFtAlgorithm->set_sensitive(nCount > 1);  // enable only if 
there is a choice
-m_xLbAlgorithm->set_sensitive(nCount > 1);  // enable only if 
there is a choice
 }
 
 m_xLbAlgorithm->thaw();
+
+m_xLbAlgorithm->set_active(nCount ? 0 : -1);// first entry is default
+m_xFtAlgorithm->set_sensitive(nCount > 1);  // enable only if there is 
a choice
+m_xLbAlgorithm->set_sensitive(nCount > 1);  // enable only if there is 
a choice
 }
 
 IMPL_LINK_NOARG(ScTabPageSortOptions, FillAlgorHdl, weld::ComboBox&, void)

[Libreoffice-bugs] [Bug 141598] Standard Filter Window Width of three monitors when selecting thousands of rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141598

Bich 30  changed:

   What|Removed |Added

Version|7.4.2.3 release |7.4.3.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141598] Standard Filter Window Width of three monitors when selecting thousands of rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141598

--- Comment #10 from Bich 30  ---
In Libreoffice version libreoffice-7.4.3.2 it still happens.

My OS is ubuntu 20.04

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 141642] RFE: Add opportunity to select only empty cells in selected range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141642

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Heiko Tietze  ---
I struggle too with this requirement, missing a clear use case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 141642] RFE: Add opportunity to select only empty cells in selected range

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141642

Heiko Tietze  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from Heiko Tietze  ---
I struggle too with this requirement, missing a clear use case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: include/comphelper svx/source

[Stephan Bergmann (via logerrit)]

 include/comphelper/accessiblecomponenthelper.hxx |8 
 svx/source/inc/charmapacc.hxx|1 +
 2 files changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 941ab8acf0765131fb9d0af560846293f3768d13
Author: Stephan Bergmann 
AuthorDate: Wed Jan 11 11:39:35 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Thu Jan 12 08:12:44 2023 +

comphelper::OCommonAccessibleComponent's XAggregation is apparently unused

It had been using WeakAggComponentImplHelper2 ever since
2f79d5f4794ec7f076bb290702b4c9c0afb2a6c8 "initial checkin - helper for
implementing an XAccessibleContext", but all the classes that derive from it
(comphelper::OAccessibleComponentHelper,
comphelper::OAccessibleExtendedComponentHelper, and classes that in turn 
derive
from those) implement queryInterface (in a way not just forwarding to the 
base
class queryInterface, as would be required for classes implementing
XAggregation) rather than queryAggregation, so aggregation was broken and 
any
delegator would be ignored when calling queryInterface on one of the derived
classes.

Also, without this commit but instead with a local

> --- a/include/comphelper/accessiblecomponenthelper.hxx
> +++ b/include/comphelper/accessiblecomponenthelper.hxx
> @@ -49,6 +49,7 @@ namespace comphelper
>  :public ::cppu::BaseMutex
>  ,public OCommonAccessibleComponent_Base
>  {
> +void SAL_CALL 
setDelegator(css::uno::Reference const &) final { 
assert(false); }
>  friend class OContextEntryGuard;
>  private:
>  css::uno::WeakReference< css::accessibility::XAccessible > 
m_aCreator; // the XAccessible which created our XAccessibleContext

on all of Linux, macOS, and Windows: `make check` still succeeded, and 
running
the resulting LibreOffice with the system in some assistive technology 
narration
mode produced audio, all without hitting that injected assert that should 
have
fired if the XAggregation mechanism had been used after all.

Change-Id: I47045824d0762a5f3de150a11576694621b163b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145330
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/include/comphelper/accessiblecomponenthelper.hxx 
b/include/comphelper/accessiblecomponenthelper.hxx
index 0c738d0e6df0..8743b322a4d8 100644
--- a/include/comphelper/accessiblecomponenthelper.hxx
+++ b/include/comphelper/accessiblecomponenthelper.hxx
@@ -26,7 +26,7 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -38,9 +38,9 @@ namespace comphelper
 
 //= OCommonAccessibleComponent
 
-typedef ::cppu::WeakAggComponentImplHelper2 <   
css::accessibility::XAccessibleContext2,
-
css::accessibility::XAccessibleEventBroadcaster
->   
OCommonAccessibleComponent_Base;
+typedef ::cppu::WeakComponentImplHelper <   
css::accessibility::XAccessibleContext2,
+
css::accessibility::XAccessibleEventBroadcaster
+>   
OCommonAccessibleComponent_Base;
 
 /** base class encapsulating common functionality for the helper classes 
implementing
 the XAccessibleComponent respectively XAccessibleExtendendComponent
diff --git a/svx/source/inc/charmapacc.hxx b/svx/source/inc/charmapacc.hxx
index 3831c3485ccf..201f53db3f37 100644
--- a/svx/source/inc/charmapacc.hxx
+++ b/svx/source/inc/charmapacc.hxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 

[Libreoffice-ux-advise] [Bug 152705] SECTION COLUMNS: Wrong text distribution

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152705

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Heiko Tietze  ---
The uniform distribution is available only for section but columns can be
defined on the page itself. If I add text like lorem, ipsum,  it
breaks at the next page and according the paragraph text flow. I don't see text
being "transferred from the third to the second column". => NEEDINFO (ideally
with an example)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 152705] SECTION COLUMNS: Wrong text distribution

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152705

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Heiko Tietze  ---
The uniform distribution is available only for section but columns can be
defined on the page itself. If I add text like lorem, ipsum,  it
breaks at the next page and according the paragraph text flow. I don't see text
being "transferred from the third to the second column". => NEEDINFO (ideally
with an example)

-- 
You are receiving this mail because:
You are the assignee for the bug.