[Libreoffice-bugs] [Bug 47148] [META] Image handling problems

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47148

Aron Budea  changed:

   What|Removed |Added

 Depends on||137260
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=13 |
   |7260|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=137260
[Bug 137260] FILESAVE: Graphics wildly enlarged or gone after PPT/PPTX
roundtrip
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 137260] FILESAVE: Graphics wildly enlarged or gone after PPT/PPTX roundtrip

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=137260

Aron Budea  changed:

   What|Removed |Added

Version|unspecified |4.2.0.4 release
 CC||aron.bu...@gmail.com
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=47 |
   |148 |
 Blocks||47148

--- Comment #7 from Aron Budea  ---
Already in 4.2.0.4.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=47148
[Bug 47148] [META] Image handling problems
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153285] EDITING: Constant crashing in CALC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153285

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
On which env are you? (Linux, macOS, Windows)
You can try to upgrade to 7.4.5 + try
https://wiki.documentfoundation.org/QA/FirstSteps

Now if you've got msOffice, don't hesitate to use it if it can help you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: framework/source

[Stephan Bergmann (via logerrit)]

 framework/source/fwe/helper/undomanagerhelper.cxx |   26 +++---
 1 file changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 061d3bc359b6b94a874c10e96ad9cc8189494e21
Author: Stephan Bergmann 
AuthorDate: Mon Jan 30 21:45:46 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Jan 31 07:54:47 2023 +

Fix locking order

JunitTest_sfx2_complex occasionally deadlocked when the main thread at

> framework::UndoManagerHelper::isUndoPossible
> chart::UndoCommandDispatch::fireStatusEvent
> chart::CommandDispatch::addStatusListener
> svt::ToolboxController::bindListener
> framework::ToolBarManager::UpdateControllers
> framework::ToolBarManager::AsyncUpdateControllersHdl
> Scheduler::CallbackTaskScheduling
> SalTimer::CallCallback
> SvpSalInstance::CheckTimeout
> SvpSalInstance::ImplYield
> SvpSalInstance::DoYield
> ImplYield
> Application::Execute
> desktop::Desktop::Main

has acquired the SolarMutex in
framework::ToolBarManager::AsyncUpdateControllersHdl and is now trying to
acquire framework::UndoManagerHelper_Impl::m_aMutex, while a 
cppu_threadpool at

> framework::UndoManagerHelper_Impl::impl_clear
> std::function::operator()
> framework::(anonymous namespace)::UndoManagerRequest::execute
> framework::UndoManagerHelper_Impl::impl_processRequest
> framework::UndoManagerHelper_Impl::clear
> framework::UndoManagerHelper::clear
> gcc3::callVirtualMethod

first acquired framework::UndoManagerHelper_Impl::m_aMutex and then tries to
acquire the SolarMutex.  That additional acquiring of the SolarMutex had 
been
added to framework::UndoManagerHelper_Impl::impl_clear in
8611f6e259b807b4f19c8dc0eab86ca648891ce3 "ref-count SdrObject".

Change-Id: Ifcb8765b29b65f773be6bbe54092346c5ae3a33b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146371
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/framework/source/fwe/helper/undomanagerhelper.cxx 
b/framework/source/fwe/helper/undomanagerhelper.cxx
index 27780dc2719e..eef1f9f452b4 100644
--- a/framework/source/fwe/helper/undomanagerhelper.cxx
+++ b/framework/source/fwe/helper/undomanagerhelper.cxx
@@ -681,22 +681,22 @@ namespace framework
 
 void UndoManagerHelper_Impl::impl_clear()
 {
-// SYNCHRONIZED --->
-::osl::ClearableMutexGuard aGuard( m_aMutex );
+EventObject aEvent;
+{
+SolarMutexGuard aGuard;
+::osl::MutexGuard aGuard2( m_aMutex );
 
-SfxUndoManager& rUndoManager = getUndoManager();
-if ( rUndoManager.IsInListAction() )
-throw UndoContextNotClosedException( OUString(), getXUndoManager() 
);
+SfxUndoManager& rUndoManager = getUndoManager();
+if ( rUndoManager.IsInListAction() )
+throw UndoContextNotClosedException( OUString(), 
getXUndoManager() );
 
-{
-::comphelper::FlagGuard aNotificationGuard( m_bAPIActionRunning );
-SolarMutexGuard aGuard2;
-rUndoManager.Clear();
-}
+{
+::comphelper::FlagGuard aNotificationGuard( 
m_bAPIActionRunning );
+rUndoManager.Clear();
+}
 
-const EventObject aEvent( getXUndoManager() );
-aGuard.clear();
-// <--- SYNCHRONIZED
+aEvent = EventObject( getXUndoManager() );
+}
 
 m_aUndoListeners.notifyEach( ::allActionsCleared, 
aEvent );
 impl_notifyModified();

[Libreoffice-bugs] [Bug 150239] Selecting whole column to copy data, by accident, freeze - how to hard limit numbers of rows when running calc?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150239

Heiko Tietze  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #6 from Heiko Tietze  ---
Maybe no confirmation but a chance to interrupt long lasting operations. Could
imagine a progress bar or an infobar with a cancel button. Eike, is this
feasible?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150239] Selecting whole column to copy data, by accident, freeze - how to hard limit numbers of rows when running calc?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150239

Heiko Tietze  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #6 from Heiko Tietze  ---
Maybe no confirmation but a chance to interrupt long lasting operations. Could
imagine a progress bar or an infobar with a cancel button. Eike, is this
feasible?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153205] Selection not cleared when clicking elsewhere after copying text by ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

--- Comment #10 from Heiko Tietze  ---
This is really a regression? I rather don't see an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Bug 103152 depends on bug 150275, which changed state.

Bug 150275 Summary: Colour toolbar doesn't disappear, if image is deleted or 
deselected (see comment 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=150275

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 108816] [META] Writer toolbar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108816
Bug 108816 depends on bug 150275, which changed state.

Bug 150275 Summary: Colour toolbar doesn't disappear, if image is deleted or 
deselected (see comment 1)
https://bugs.documentfoundation.org/show_bug.cgi?id=150275

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 85345] TOOLBAR: Color button in image toolbar doesn't deactivate when clicking the 'X' in Color floating toolbar

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85345

Heiko Tietze  changed:

   What|Removed |Added

 CC||e...@horse64.org

--- Comment #7 from Heiko Tietze  ---
*** Bug 150275 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150275] Colour toolbar doesn't disappear, if image is deleted or deselected (see comment 1)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150275

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Heiko Tietze  ---
(In reply to Buovjaga from comment #2)
> I reproduce, but I think this needs deciding: should the state of the Color
> button be remembered? So let's say the floating color toolbar closes when
> you deselect an image. Should it pop back up when you select an image again?
> I think if we go too far it might break the workflow of some people when
> dealing with many images. I imagine if I wanted to change the color settings
> of multiple images I would be happy, if I did not need to keep clicking the
> Color button to bring up the toolbar.

We do remember the on/off state. At least if you not show the color widget
either via button at the toolbar or the toggle menu entry under Format > Image
it will not be shown.

The bug is clearly that it should hide if the parent graphic object bar
disappears. And it has been reported before at bug 85345.

*** This bug has been marked as a duplicate of bug 85345 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 150275] Colour toolbar doesn't disappear, if image is deleted or deselected (see comment 1)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150275

Heiko Tietze  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |heiko.tietze@documentfounda
   |.freedesktop.org|tion.org
   Keywords|needsUXEval |
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Heiko Tietze  ---
(In reply to Buovjaga from comment #2)
> I reproduce, but I think this needs deciding: should the state of the Color
> button be remembered? So let's say the floating color toolbar closes when
> you deselect an image. Should it pop back up when you select an image again?
> I think if we go too far it might break the workflow of some people when
> dealing with many images. I imagine if I wanted to change the color settings
> of multiple images I would be happy, if I did not need to keep clicking the
> Color button to bring up the toolbar.

We do remember the on/off state. At least if you not show the color widget
either via button at the toolbar or the toggle menu entry under Format > Image
it will not be shown.

The bug is clearly that it should hide if the parent graphic object bar
disappears. And it has been reported before at bug 85345.

*** This bug has been marked as a duplicate of bug 85345 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - 4 commits - sw/CppunitTest_sw_uibase_dialog.mk sw/Module_sw.mk sw/qa sw/sdi sw/source

[Miklos Vajna (via logerrit)]

 sw/CppunitTest_sw_uibase_dialog.mk   |   76 +++
 sw/Module_sw.mk  |1 
 sw/qa/uibase/dialog/dialog.cxx   |   59 +++
 sw/qa/uibase/shells/shells.cxx   |9 +++-
 sw/qa/uibase/uno/uno.cxx |5 +-
 sw/sdi/swriter.sdi   |2 
 sw/source/uibase/dialog/regionsw.cxx |   27 
 sw/source/uibase/shells/textfld.cxx  |3 +
 sw/source/uibase/shells/textsh1.cxx  |2 
 sw/source/uibase/uno/loktxdoc.cxx|1 
 10 files changed, 179 insertions(+), 6 deletions(-)

New commits:
commit df5bd99aff6162b8c6a4e3cfcbed30bc5b3638c0
Author: Miklos Vajna 
AuthorDate: Mon Jan 9 16:27:15 2023 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 31 08:41:19 2023 +0100

sw, UpdateBookmarks: support renaming bookmarks

The problem was that the LOK API client wanted to change the name of the
bookmark, but nothing happened, because we had a sanity check that made
sure the provided vs existing bookmark names match.

The intention was that the bookmark name is just an ID (you can store
additional properties in per-doc custom properties, those can change),
so we can require that bookmarks never get renamed when using this
command.

Fix the problem by dropping this requirement and rather use renameMark()
to adjust the in-doc bookmark name if needed.

This also handles undo/redo for us.

(cherry picked from commit d2318503d559c3797965da777627e4ee45143043)

Change-Id: I7a426c865ddf24f13741c0369fb3991da2e881b2

diff --git a/sw/qa/uibase/shells/shells.cxx b/sw/qa/uibase/shells/shells.cxx
index 610890c15312..7457c62806c1 100644
--- a/sw/qa/uibase/shells/shells.cxx
+++ b/sw/qa/uibase/shells/shells.cxx
@@ -552,7 +552,7 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, 
testUpdateBookmarks)
 {
 "Bookmark": {
 "type": "string",
-"value": "ZOTERO_BREF_GiQ7DAWQYWLy"
+"value": "ZOTERO_BREF_new1"
 },
 "BookmarkText": {
 "type": "string",
@@ -562,7 +562,7 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, 
testUpdateBookmarks)
 {
 "Bookmark": {
 "type": "string",
-"value": "ZOTERO_BREF_PRxDGUb4SWXF"
+"value": "ZOTERO_BREF_new2"
 },
 "BookmarkText": {
 "type": "string",
@@ -584,6 +584,11 @@ CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, 
testUpdateBookmarks)
 // - Actual  : ABCDE
 // i.e. the content was not updated.
 CPPUNIT_ASSERT_EQUAL(OUString("Anew result 1Cnew result 2E"), aActual);
+
+// Without the accompanying fix in place, this test would have failed, 
ZOTERO_BREF_GiQ7DAWQYWLy
+// was not renamed to ZOTERO_BREF_new1.
+auto it = pDoc->getIDocumentMarkAccess()->findMark("ZOTERO_BREF_new1");
+CPPUNIT_ASSERT(it != pDoc->getIDocumentMarkAccess()->getAllMarksEnd());
 }
 
 CPPUNIT_TEST_FIXTURE(SwUibaseShellsTest, testUpdateFieldmark)
diff --git a/sw/source/uibase/shells/textsh1.cxx 
b/sw/source/uibase/shells/textsh1.cxx
index d136c80d2d07..a33f23ed9d2f 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -425,7 +425,7 @@ void UpdateBookmarks(SfxRequest& rReq, SwWrtShell& rWrtSh)
 comphelper::SequenceAsHashMap aMap(aBookmarks[nBookmarkIndex++]);
 if (aMap["Bookmark"].get() != pMark->GetName())
 {
-continue;
+rIDMA.renameMark(pMark, aMap["Bookmark"].get());
 }
 
 OUString aBookmarkText = aMap["BookmarkText"].get();
commit 2e4b3359f3bf5c29a817209c5df7506fc94cbba0
Author: Pranam Lashkari 
AuthorDate: Tue Jan 10 11:24:56 2023 +0530
Commit: Miklos Vajna 
CommitDate: Tue Jan 31 08:40:21 2023 +0100

sw: return field under cursor inside field node

Having values inside field node makes it easier to detect which commands 
value
is being returned in online. otherwise its impossible to predict the 
command from "type" and "command"
as "command" can be anything and "type" is very generic

this also makes output more consistent with "GetTextFormFields"

(cherry picked from commit 5dd5011eabc755d4ea8d282c32dd4854d532849a)

Change-Id: I1b8b39bfd0de6d7b19c2944bd42f7031d60518af

diff --git a/sw/qa/uibase/uno/uno.cxx b/sw/qa/uibase/uno/uno.cxx
index 3eb830ec8c55..b89b129100cd 100644
--- a/sw/qa/uibase/uno/uno.cxx
+++ b/sw/qa/uibase/uno/uno.cxx
@@ -407,10 +407,11 @@ CPPUNIT_TEST_FIXTURE(SwUibaseUnoTest, 
testGetTextFormField)
 // Without the accompanying fix in place, this test would have failed with:
 // - No such node (type)
 // i.e. the returned JSON was just an empty object.
+auto field = aTree.get_child("field");
 CPPUNIT_ASSERT_EQUAL(std::string("vnd.oasis.opendocument.field.UNHANDLED"),
- 

[Libreoffice-bugs] [Bug 153205] Selection not cleared when clicking elsewhere after copying text by ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

Buovjaga  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |rayk...@gmail.com
   |.freedesktop.org|
   Keywords|needsUXEval |bibisected, bisected,
   ||regression
Summary|Selection should be cleared |Selection not cleared when
   |after moving or copying |clicking elsewhere after
   |text by |copying text by
   |dragging/ctrl-dragging  |ctrl-dragging
  Regression By||Jim Raykowski
Version|3.5.0 release   |7.2.0.0.alpha0+
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #9 from Buovjaga  ---
Sorry, I did not notice the uncontroversial point about selection staying after
clicking elsewhere.

Bibisected with Windows 7.2 repo to
https://git.libreoffice.org/core/commit/a2f6b4e8995c149620db4fcfe7e355af4fbc869e
tdf#88064 In add mode don't change SetCursor and KillSel functions when shell
is popped

This is reproducible with all Linux backends as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153205] Selection not cleared when clicking elsewhere after copying text by ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

Buovjaga  changed:

   What|Removed |Added

 CC|libreoffice-ux-advise@lists |rayk...@gmail.com
   |.freedesktop.org|
   Keywords|needsUXEval |bibisected, bisected,
   ||regression
Summary|Selection should be cleared |Selection not cleared when
   |after moving or copying |clicking elsewhere after
   |text by |copying text by
   |dragging/ctrl-dragging  |ctrl-dragging
  Regression By||Jim Raykowski
Version|3.5.0 release   |7.2.0.0.alpha0+
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #9 from Buovjaga  ---
Sorry, I did not notice the uncontroversial point about selection staying after
clicking elsewhere.

Bibisected with Windows 7.2 repo to
https://git.libreoffice.org/core/commit/a2f6b4e8995c149620db4fcfe7e355af4fbc869e
tdf#88064 In add mode don't change SetCursor and KillSel functions when shell
is popped

This is reproducible with all Linux backends as well.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153287] Dark mode: Combo box and Edit box look and feel inconsistent on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153287

--- Comment #2 from Mike Kaganski  ---
Maybe a better reference behavior could be seen in system file dialogs,
featuring an edit box and comboboxes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152350] Changes to name and value of custom document property lost when resizing dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152350

--- Comment #7 from Szymon Kłos  ---
I will try to take a look next week

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114612] Make rotation uno commands work outside of Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114612

allegiantflyfares  changed:

   What|Removed |Added

URL||https://www.allegiantflyfar
   ||es.com/blog/how-can-i-talk-
   ||to-a-live-person-at-allegia
   ||nt-air/

--- Comment #3 from allegiantflyfares  ---
If you're planning a trip from the United States to Europe, Via flying is
possible, and Allegiant Air serves several direct flights toward Europe within
a reasonable airfare. And if you want to know how do i talk to a person at
allegiant air. There are several ways travelers can easily contact the airline
regarding any queries via email and customer support numbers. The airline is
known for its unparalleled hospitality and 24/7 assistance.

https://www.allegiantflyfares.com/blog/how-can-i-talk-to-a-live-person-at-allegiant-air/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153287] Dark mode: Combo box and Edit box look and feel inconsistent on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153287

--- Comment #1 from Mike Kaganski  ---
Created attachment 185020
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185020=edit
Screencast of similar controls behavior in Visual Studio 2022

For comparison: this is how similar controls behave in MS Visual Studio.

They have the same outer decoration. On hover, edit box gets much brighter
border; and comboboxes behave in one of two ways: either get the same bright
border as edit box (see the zoom box in the bottom), or don't change the
border, but slightly change the area (see the process selector). Likely the
difference depends on editability of the combobox' edit control.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: basctl/source chart2/source cui/source include/svx reportdesign/source sc/source sd/source svx/source sw/source

[Tomaž Vajngerl (via logerrit)]

 basctl/source/dlged/dlged.cxx  |2 
 basctl/source/dlged/propbrw.cxx|6 -
 chart2/source/controller/drawinglayer/DrawViewWrapper.cxx  |8 -
 chart2/source/controller/main/DrawCommandDispatch.cxx  |2 
 chart2/source/controller/main/ShapeController.cxx  |6 -
 cui/source/tabpages/tpbitmap.cxx   |4 
 cui/source/tabpages/transfrm.cxx   |   22 +--
 include/svx/svdedtv.hxx|   37 +-
 include/svx/svdpntv.hxx|8 -
 reportdesign/source/ui/report/ReportSection.cxx|4 
 reportdesign/source/ui/report/ViewsWindow.cxx  |8 -
 reportdesign/source/ui/report/propbrw.cxx  |6 -
 sc/source/ui/app/drwtrans.cxx  |   10 -
 sc/source/ui/drawfunc/drawsh2.cxx  |4 
 sc/source/ui/drawfunc/drawsh4.cxx  |2 
 sc/source/ui/drawfunc/drtxtob.cxx  |   10 -
 sc/source/ui/drawfunc/drtxtob2.cxx |6 -
 sc/source/ui/drawfunc/fuconuno.cxx |4 
 sc/source/ui/drawfunc/fuins1.cxx   |2 
 sc/source/ui/navipi/content.cxx|2 
 sc/source/ui/unoobj/docuno.cxx |2 
 sc/source/ui/unoobj/viewuno.cxx|6 -
 sc/source/ui/view/drawvie4.cxx |4 
 sc/source/ui/view/drawview.cxx |   26 ++--
 sc/source/ui/view/gridwin4.cxx |2 
 sc/source/ui/view/gridwin5.cxx |2 
 sc/source/ui/view/printfun.cxx |2 
 sc/source/ui/view/tabview5.cxx |4 
 sc/source/ui/view/tabvwsh2.cxx |   20 +--
 sc/source/ui/view/tabvwshb.cxx |   14 +-
 sc/source/ui/view/tabvwshg.cxx |4 
 sc/source/ui/view/viewfun3.cxx |2 
 sc/source/ui/view/viewfun7.cxx |   18 +--
 sd/source/core/drawdoc3.cxx|2 
 sd/source/ui/accessibility/AccessibleOutlineEditSource.cxx |8 -
 sd/source/ui/app/optsitem.cxx  |2 
 sd/source/ui/app/sdxfer.cxx|3 
 sd/source/ui/func/fuolbull.cxx |2 
 sd/source/ui/func/fuprlout.cxx |2 
 sd/source/ui/table/TableDesignPane.cxx |2 
 sd/source/ui/tools/PreviewRenderer.cxx |2 
 sd/source/ui/view/drbezob.cxx  |2 
 sd/source/ui/view/drviews1.cxx |6 -
 sd/source/ui/view/drviews7.cxx |   10 -
 sd/source/ui/view/drviewsg.cxx |4 
 sd/source/ui/view/frmview.cxx  |   12 +-
 sd/source/ui/view/sdview.cxx   |   28 ++---
 sd/source/ui/view/sdview3.cxx  |8 -
 sd/source/ui/view/sdview4.cxx  |2 
 svx/source/dialog/graphctl.cxx |2 
 svx/source/engine3d/view3d.cxx |   12 +-
 svx/source/engine3d/view3d1.cxx|   14 +-
 svx/source/form/fmshell.cxx|2 
 svx/source/form/fmshimp.cxx|5 
 svx/source/form/fmview.cxx |4 
 svx/source/gallery2/galtheme.cxx   |2 
 svx/source/sidebar/possize/PosSizePropertyPanel.cxx|   14 +-
 svx/source/svdraw/sdrpagewindow.cxx|4 
 svx/source/svdraw/svdcrtv.cxx  |   15 +-
 svx/source/svdraw/svddrgmt.cxx |   26 ++--
 svx/source/svdraw/svddrgv.cxx  |4 
 svx/source/svdraw/svdedtv.cxx  |   56 +-
 svx/source/svdraw/svdedtv1.cxx |   48 
 svx/source/svdraw/svdedtv2.cxx |   72 ++---
 svx/source/svdraw/svdedxv.cxx  |   66 +--
 svx/source/svdraw/svdglev.cxx  |   18 +--
 svx/source/svdraw/svdmrkv.cxx  |   12 +-
 svx/source/svdraw/svdpagv.cxx  |2 
 svx/source/svdraw/svdpntv.cxx  |   12 --
 svx/source/svdraw/svdpoev.cxx  |   22 +--
 svx/source/svdraw/svdview.cxx  |   10 -
 svx/source/svdraw/svdxcgv.cxx  |   

[Libreoffice-bugs] [Bug 153205] Selection should be cleared after moving or copying text by dragging/ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

--- Comment #8 from Heiko Tietze  ---
Keeping the selection allows to reposition after dragging, for example. And
provides feedback of what has been. If you click somewhere else the selection
will be cleared - but using the keyboard is very effective anyway. It is common
behavior and the same on MSO and text editors (at least Kate).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153205] Selection should be cleared after moving or copying text by dragging/ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

--- Comment #8 from Heiko Tietze  ---
Keeping the selection allows to reposition after dragging, for example. And
provides feedback of what has been. If you click somewhere else the selection
will be cleared - but using the keyboard is very effective anyway. It is common
behavior and the same on MSO and text editors (at least Kate).

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-bugs] [Bug 153287] New: Dark mode: Combo box and Edit box look and feel inconsistent on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153287

Bug ID: 153287
   Summary: Dark mode: Combo box and Edit box look and feel
inconsistent on Windows
   Product: LibreOffice
   Version: 7.6.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Keywords: topicUI
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mikekagan...@hotmail.com
CC: caol...@redhat.com

Created attachment 185019
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185019=edit
Screencast of hovering over LO edit boxes and comboboxes in dark mode

In current master (toward 7.6), the look and feel of Edit box and of Combobox
is inconsistent in dark mode on Windows.

1. The border of combobox is brighter (or maybe just "colder"?) than that of
edit box.
2. On hover, they behave differently: combobox does not react, edit box gets a
*dark* border (and basically "disappears" visually, instead of becoming
highlighted).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103369

Dieter  changed:

   What|Removed |Added

 Depends on||152870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152870
[Bug 152870] Printing/exporting to PDF shows out-of-cell numbering that is
invisible normally
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103100] [META] Writer table bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103100

Dieter  changed:

   What|Removed |Added

 Depends on||152870


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=152870
[Bug 152870] Printing/exporting to PDF shows out-of-cell numbering that is
invisible normally
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152870] Printing/exporting to PDF shows out-of-cell numbering that is invisible normally

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152870

Dieter  changed:

   What|Removed |Added

 Blocks||103100, 103369
 Status|UNCONFIRMED |NEW
 Whiteboard| QA:needsComment|
  Component|Writer  |Printing and PDF export
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #1 from Dieter  ---
I confirm it with

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103100
[Bug 103100] [META] Writer table bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103369
[Bug 103369] [META] Bullet, numbered, and outline list bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/inc

[Miklos Vajna (via logerrit)]

 sw/inc/txtftn.hxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit d9ebb2e76bf7ec068ebfceccf7f477471012d157
Author: Miklos Vajna 
AuthorDate: Mon Jan 30 20:30:53 2023 +0100
Commit: Miklos Vajna 
CommitDate: Tue Jan 31 07:14:21 2023 +

sw: document SwTextFootnote

It's a bit confusing that "footnote" may mean "footnote" or "footnote or
endnote", depending on context.

Change-Id: Ibe19dc29f68d1409feb052296e9a3537b160882e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146366
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/txtftn.hxx b/sw/inc/txtftn.hxx
index 57cab883565f..2d86bf217e64 100644
--- a/sw/inc/txtftn.hxx
+++ b/sw/inc/txtftn.hxx
@@ -28,6 +28,8 @@ class SwNodes;
 class SwDoc;
 class SwRootFrame;
 
+/// SwTextAttr subclass for footnotes and endnotes. If it's an endnote is 
decided by the owned
+/// SwFormatFootnote's m_bEndNote.
 class SW_DLLPUBLIC SwTextFootnote final : public SwTextAttr
 {
 std::optional m_oStartNode;

[Libreoffice-bugs] [Bug 145766] Print Dialog Box too long or 'print' button too low on window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145766

Dieter  changed:

   What|Removed |Added

 CC||mvarne...@yahoo.com

--- Comment #8 from Dieter  ---
*** Bug 152998 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152998] Bottom of Print Dialog Is Cut Off on 13" MacBook Pro

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152998

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Dieter  ---
Sounds like a duplicate of bug 145766. Please feel free to change it back to
UNCONFIRMED, if you disagree.

*** This bug has been marked as a duplicate of bug 145766 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 113363] [META] DOCX (OOXML) content control-related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113363

Dieter  changed:

   What|Removed |Added

 Depends on||153040


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153040
[Bug 153040] PDF Export: SDT Dropdown List is empty
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Dieter  changed:

   What|Removed |Added

 Depends on||153040


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=153040
[Bug 153040] PDF Export: SDT Dropdown List is empty
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153040] PDF Export: SDT Dropdown List is empty

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153040

Dieter  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Whiteboard| QA:needsComment|
 Status|UNCONFIRMED |NEW
 Blocks||113363, 103378
 CC||dgp-m...@gmx.de

--- Comment #3 from Dieter  ---
I confirm it with

Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=113363
[Bug 113363] [META] DOCX (OOXML) content control-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153205] Selection should be cleared after moving or copying text by dragging/ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

--- Comment #7 from Ulrich Windl  ---
(In reply to Buovjaga from comment #6)
...
> keeping the selection gives you a visual indication that the operation
> succeeded.

The issue is not that the selection is still active after move or copy is
finished, BUT that a repositioning of the cursor (e.g. by clicking) does not
clear the selection. So next character entry still does replace the selection.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-ux-advise] [Bug 153205] Selection should be cleared after moving or copying text by dragging/ctrl-dragging

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153205

--- Comment #7 from Ulrich Windl  ---
(In reply to Buovjaga from comment #6)
...
> keeping the selection gives you a visual indication that the operation
> succeeded.

The issue is not that the selection is still active after move or copy is
finished, BUT that a repositioning of the cursor (e.g. by clicking) does not
clear the selection. So next character entry still does replace the selection.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Libreoffice-commits] core.git: comphelper/source

[Noel Grandin (via logerrit)]

 comphelper/source/eventattachermgr/eventattachermgr.cxx |  111 ++--
 1 file changed, 74 insertions(+), 37 deletions(-)

New commits:
commit ba4191ff0de05334ba32b53a09ad992710f03f9d
Author: Noel Grandin 
AuthorDate: Mon Jan 30 21:48:53 2023 +0200
Commit: Noel Grandin 
CommitDate: Tue Jan 31 06:04:59 2023 +

osl::Mutex->std::mutex in ImplEventAttacherManager

Change-Id: Id8a4d2d75b1be8f23f6b1260a7a7727ab6bbd27b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146368
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/comphelper/source/eventattachermgr/eventattachermgr.cxx 
b/comphelper/source/eventattachermgr/eventattachermgr.cxx
index 1c9f1a23cdc6..ffad3bb3d0d6 100644
--- a/comphelper/source/eventattachermgr/eventattachermgr.cxx
+++ b/comphelper/source/eventattachermgr/eventattachermgr.cxx
@@ -21,7 +21,6 @@
 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -42,12 +41,13 @@
 #include 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
 
 #include 
+#include 
 #include 
 #include 
 
@@ -85,9 +85,9 @@ class ImplEventAttacherManager
 {
 friend class AttacherAllListener_Impl;
 std::deque< AttacherIndex_Impl >  aIndex;
-Mutex aLock;
+std::mutex m_aMutex;
 // Container for the ScriptListener
-OInterfaceContainerHelper3 aScriptListeners;
+OInterfaceContainerHelper4 aScriptListeners;
 // Instance of EventAttacher
 Reference< XEventAttacher2 >xAttacher;
 Reference< XComponentContext >  mxContext;
@@ -117,6 +117,12 @@ public:
 virtual void SAL_CALL read(const Reference< XObjectInputStream >& 
InStream) override;
 
 private:
+void registerScriptEvent(std::unique_lock&, sal_Int32 Index, 
const ScriptEventDescriptor& ScriptEvent);
+void registerScriptEvents(std::unique_lock&, sal_Int32 Index, 
const Sequence< ScriptEventDescriptor >& ScriptEvents);
+void attach(std::unique_lock&, sal_Int32 Index, const 
Reference< XInterface >& Object, const Any& Helper);
+void detach(std::unique_lock&, sal_Int32 nIndex, const 
Reference< XInterface >& xObject);
+void insertEntry(std::unique_lock&, sal_Int32 Index);
+
 /// @throws Exception
 Reference< XIdlReflection > getReflection();
 
@@ -180,7 +186,8 @@ void SAL_CALL AttacherAllListener_Impl::firing(const 
AllEventObject& Event)
 aScriptEvent.ScriptCode = aScriptCode;
 
 // Iterate over all listeners and pass events.
-mxManager->aScriptListeners.notifyEach( ::firing, 
aScriptEvent );
+std::unique_lock l(mxManager->m_aMutex);
+mxManager->aScriptListeners.notifyEach( l, ::firing, 
aScriptEvent );
 }
 
 
@@ -241,7 +248,8 @@ Any SAL_CALL AttacherAllListener_Impl::approveFiring( const 
AllEventObject& Even
 
 Any aRet;
 // Iterate over all listeners and pass events.
-OInterfaceIteratorHelper3 aIt( mxManager->aScriptListeners );
+std::unique_lock l(mxManager->m_aMutex);
+OInterfaceIteratorHelper4 aIt( l, mxManager->aScriptListeners );
 while( aIt.hasMoreElements() )
 {
 aRet = aIt.next()->approveFiring( aScriptEvent );
@@ -339,8 +347,7 @@ Reference< XEventAttacherManager > 
createEventAttacherManager( const Reference<
 
 ImplEventAttacherManager::ImplEventAttacherManager( const Reference< 
XIntrospection > & rIntrospection,
 const Reference< 
XComponentContext >& rContext )
-: aScriptListeners( aLock )
-, mxContext( rContext )
+: mxContext( rContext )
 , nVersion(0)
 {
 if ( rContext.is() )
@@ -363,7 +370,7 @@ ImplEventAttacherManager::ImplEventAttacherManager( const 
Reference< XIntrospect
 
 Reference< XIdlReflection > ImplEventAttacherManager::getReflection()
 {
-Guard< Mutex > aGuard( aLock );
+std::unique_lock l(m_aMutex);
 // Do we already have a service? If not, create one.
 if( !mxCoreReflection.is() )
 {
@@ -389,8 +396,17 @@ void SAL_CALL ImplEventAttacherManager::registerScriptEvent
 const ScriptEventDescriptor& ScriptEvent
 )
 {
-Guard< Mutex > aGuard( aLock );
+std::unique_lock l(m_aMutex);
+registerScriptEvent(l, nIndex, ScriptEvent);
+}
 
+void ImplEventAttacherManager::registerScriptEvent
+(
+std::unique_lock&,
+sal_Int32 nIndex,
+const ScriptEventDescriptor& ScriptEvent
+)
+{
 // Examine the index and apply the array
 std::deque::iterator aIt = implCheckIndex( nIndex );
 
@@ -424,20 +440,29 @@ void SAL_CALL 
ImplEventAttacherManager::registerScriptEvents
 const Sequence< ScriptEventDescriptor >& ScriptEvents
 )
 {
-Guard< Mutex > aGuard( aLock );
+std::unique_lock l(m_aMutex);
+registerScriptEvents(l, nIndex, ScriptEvents);
+}
 
+void ImplEventAttacherManager::registerScriptEvents
+(
+std::unique_lock& l,
+sal_Int32 nIndex,
+const Sequence< ScriptEventDescriptor >& ScriptEvents
+)
+{
 // Examine the index and apply the array
 std::deque< AttachedObject_Impl > aList 

[Libreoffice-commits] core.git: chart2/source include/svx sd/source svx/source

[Tomaž Vajngerl (via logerrit)]

 chart2/source/view/main/DrawModelWrapper.cxx  |2 -
 include/svx/svdetc.hxx|3 --
 include/svx/svdmodel.hxx  |5 ---
 sd/source/core/drawdoc.cxx|1 
 sd/source/ui/app/sdxfer.cxx   |2 -
 svx/source/customshapes/EnhancedCustomShape3d.cxx |2 -
 svx/source/dialog/graphctl.cxx|3 --
 svx/source/svdraw/svdmodel.cxx|   31 ++
 svx/source/svdraw/svdograf.cxx|8 ++---
 svx/source/svdraw/svdotext.cxx|4 +-
 svx/source/svdraw/svdxcgv.cxx |   14 -
 svx/source/unodraw/UnoGraphicExporter.cxx |   17 
 12 files changed, 25 insertions(+), 67 deletions(-)

New commits:
commit 743dd1d3c1142c1c99b0844cc26dd0be91a1de40
Author: Tomaž Vajngerl 
AuthorDate: Mon Jan 30 14:44:01 2023 +0900
Commit: Tomaž Vajngerl 
CommitDate: Tue Jan 31 05:47:27 2023 +

SdrModel: we never set scale fraction to anything else than 1/1

This removes the scale fraction on SdrModel - SetScaleFraction and
the m_aObjUnit instance variable, as it is never set to anything
else than 1/1 (and don't see it usefult to set it to anything else
than this).

Change-Id: I990d20f110b3be00e6770b68e39df212f9c576be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146348
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl 

diff --git a/chart2/source/view/main/DrawModelWrapper.cxx 
b/chart2/source/view/main/DrawModelWrapper.cxx
index 6a6488435f97..1767d2ccdb6b 100644
--- a/chart2/source/view/main/DrawModelWrapper.cxx
+++ b/chart2/source/view/main/DrawModelWrapper.cxx
@@ -48,8 +48,6 @@ DrawModelWrapper::DrawModelWrapper()
 {
 m_xChartItemPool = ChartItemPool::CreateChartItemPool();
 
-SetScaleUnit(MapUnit::Map100thMM);
-SetScaleFraction(Fraction(1, 1));
 SetDefaultFontHeight(423); // 12pt
 
 SfxItemPool* pMasterPool = ();
diff --git a/include/svx/svdetc.hxx b/include/svx/svdetc.hxx
index e6d448bfb691..266fba753f97 100644
--- a/include/svx/svdetc.hxx
+++ b/include/svx/svdetc.hxx
@@ -77,9 +77,6 @@ namespace SdrEngineDefaults
 // Incidentally, every newly instantiated SdrModel is assigned this 
MapMode by default.
 // Default MapUnit is MapUnit::Map100thMM
 inline MapUnit GetMapUnit() { return MapUnit::Map100thMM; }
-
-// Default MapFraction is 1/1.
-inline Fraction GetMapFraction() { return Fraction(1, 1); }
 };
 
 class SfxItemSet;
diff --git a/include/svx/svdmodel.hxx b/include/svx/svdmodel.hxx
index 3eac3de05489..76c63a40d351 100644
--- a/include/svx/svdmodel.hxx
+++ b/include/svx/svdmodel.hxx
@@ -173,7 +173,6 @@ protected:
 std::vector> maPages;
 std::function)> m_aUndoLink;  // link 
to a NotifyUndo-Handler
 Size   m_aMaxObjSize; // e.g. for auto-growing text
-Fraction   m_aObjUnit;   // description of the coordinate units for 
ClipBoard, Drag, ...
 MapUnitm_eObjUnit;   // see above
 FieldUnit  m_eUIUnit;  // unit, scale (e.g. 1/1000) for the UI 
(status bar) is set by ImpSetUIUnit()
 Fraction   m_aUIScale; // see above
@@ -370,10 +369,6 @@ public:
 // with the correct sizes.
 MapUnit  GetScaleUnit() const   { return 
m_eObjUnit; }
 void SetScaleUnit(MapUnit eMap);
-const Fraction&  GetScaleFraction() const   { return 
m_aObjUnit; }
-void SetScaleFraction(const Fraction& rFrac);
-// Setting both simultaneously performs a little better
-void SetScaleUnit(MapUnit eMap, const Fraction& rFrac);
 
 // maximal size e.g. for auto growing texts
 const Size&  GetMaxObjSize() const  { return 
m_aMaxObjSize; }
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index d3d5b1063694..90033352f1c9 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -165,7 +165,6 @@ SdDrawDocument::SdDrawDocument(DocumentType eType, 
SfxObjectShell* pDrDocSh)
 SetUIUnit( static_cast(pOptions->GetMetric()), Fraction( 1, 
1 ) );// default
 
 SetScaleUnit(MapUnit::Map100thMM);
-SetScaleFraction(Fraction(1, 1));
 SetDefaultFontHeight(o3tl::convert(24, o3tl::Length::pt, 
o3tl::Length::mm100));
 
 m_pItemPool->SetDefaultMetric(MapUnit::Map100thMM);
diff --git a/sd/source/ui/app/sdxfer.cxx b/sd/source/ui/app/sdxfer.cxx
index 7e7d42dacd92..d9345cc3de95 100644
--- a/sd/source/ui/app/sdxfer.cxx
+++ b/sd/source/ui/app/sdxfer.cxx
@@ -251,7 +251,7 @@ void SdTransferable::CreateData()
 CreateObjectReplacement( pPage->GetObj( 0 ) );
 
 mpVDev = VclPtr::Create( 
*Application::GetDefaultDevice() );
-mpVDev->SetMapMode( MapMode( mpSdDrawDocumentIntern->GetScaleUnit(), 
Point(), mpSdDrawDocumentIntern->GetScaleFraction(), 

[Libreoffice-bugs] [Bug 153028] Writer templates do not accept changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153028

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152718] Curve auto numbering on merged cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152718

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153050] Promote/Demote Level in Navigator Help should be Promote/Demote outline level

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153050

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153040] PDF Export: SDT Dropdown List is empty

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153040

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153044] Template actions for desktop integration: names end with wrong ellipsis

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153044

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153029] LanguageTag broken when copying table with text to Calc (causing text to show as misspelled)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153029

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153010] Inconsistency and confusing strings when numeric field's numbering format is not available for a language

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153010

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153201] Frequent and random crashes whilst editing cells and other actions.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153201

--- Comment #5 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 145906] Charts do NOT update when data is changed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145906

--- Comment #6 from QA Administrators  ---
Dear gaudless,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 88144] click handling when selecting frames with formulas is inconsistent (crippled)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88144

--- Comment #6 from QA Administrators  ---
Dear Yury,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 136763] Crash:Open Property on sidebar, after pressing some table icon [gtk3 ONLY]

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136763

--- Comment #10 from QA Administrators  ---
Dear sawakaze,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 140024] "replace custom styles" option in AutoCorrect needs critical review

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=140024

--- Comment #2 from QA Administrators  ---
Dear sdc.blanco,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 63744] Navigator view moves and closes hierarchy while typing in document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63744

--- Comment #11 from QA Administrators  ---
Dear Steve Kelem,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115257] FILESAVE: format of the base text and the ruby text lost or incorrect when saved as doc document.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115257

--- Comment #9 from QA Administrators  ---
Dear Mark Hung,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 115256] FILESAVE: incorrect ruby text position in exported rtf file.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=115256

--- Comment #5 from QA Administrators  ---
Dear Mark Hung,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 114851] Toolbar names are translated numerous times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=114851

--- Comment #4 from QA Administrators  ---
Dear Yousuf Philips (jay) (retired),

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: Branch 'private/tvajngerl/staging' - basctl/source chart2/source cui/source include/svx reportdesign/source sc/source sd/source svx/source sw/source

[Tomaž Vajngerl (via logerrit)]

 basctl/source/dlged/dlged.cxx  |2 
 basctl/source/dlged/propbrw.cxx|6 -
 chart2/source/controller/drawinglayer/DrawViewWrapper.cxx  |8 -
 chart2/source/controller/main/DrawCommandDispatch.cxx  |2 
 chart2/source/controller/main/ShapeController.cxx  |6 -
 cui/source/tabpages/tpbitmap.cxx   |4 
 cui/source/tabpages/transfrm.cxx   |   22 +--
 include/svx/svdedtv.hxx|   37 +-
 include/svx/svdpntv.hxx|8 -
 reportdesign/source/ui/report/ReportSection.cxx|4 
 reportdesign/source/ui/report/ViewsWindow.cxx  |8 -
 reportdesign/source/ui/report/propbrw.cxx  |6 -
 sc/source/ui/app/drwtrans.cxx  |   10 -
 sc/source/ui/drawfunc/drawsh2.cxx  |4 
 sc/source/ui/drawfunc/drawsh4.cxx  |2 
 sc/source/ui/drawfunc/drtxtob.cxx  |   10 -
 sc/source/ui/drawfunc/drtxtob2.cxx |6 -
 sc/source/ui/drawfunc/fuconuno.cxx |4 
 sc/source/ui/drawfunc/fuins1.cxx   |2 
 sc/source/ui/navipi/content.cxx|2 
 sc/source/ui/unoobj/docuno.cxx |2 
 sc/source/ui/unoobj/viewuno.cxx|6 -
 sc/source/ui/view/drawvie4.cxx |4 
 sc/source/ui/view/drawview.cxx |   26 ++--
 sc/source/ui/view/gridwin4.cxx |2 
 sc/source/ui/view/gridwin5.cxx |2 
 sc/source/ui/view/printfun.cxx |2 
 sc/source/ui/view/tabview5.cxx |4 
 sc/source/ui/view/tabvwsh2.cxx |   20 +--
 sc/source/ui/view/tabvwshb.cxx |   14 +-
 sc/source/ui/view/tabvwshg.cxx |4 
 sc/source/ui/view/viewfun3.cxx |2 
 sc/source/ui/view/viewfun7.cxx |   18 +--
 sd/source/core/drawdoc3.cxx|2 
 sd/source/ui/accessibility/AccessibleOutlineEditSource.cxx |8 -
 sd/source/ui/app/optsitem.cxx  |2 
 sd/source/ui/app/sdxfer.cxx|3 
 sd/source/ui/func/fuolbull.cxx |2 
 sd/source/ui/func/fuprlout.cxx |2 
 sd/source/ui/table/TableDesignPane.cxx |2 
 sd/source/ui/tools/PreviewRenderer.cxx |2 
 sd/source/ui/view/drbezob.cxx  |2 
 sd/source/ui/view/drviews1.cxx |6 -
 sd/source/ui/view/drviews7.cxx |   10 -
 sd/source/ui/view/drviewsg.cxx |4 
 sd/source/ui/view/frmview.cxx  |   12 +-
 sd/source/ui/view/sdview.cxx   |   28 ++---
 sd/source/ui/view/sdview3.cxx  |8 -
 sd/source/ui/view/sdview4.cxx  |2 
 svx/source/dialog/graphctl.cxx |2 
 svx/source/engine3d/view3d.cxx |   12 +-
 svx/source/engine3d/view3d1.cxx|   14 +-
 svx/source/form/fmshell.cxx|2 
 svx/source/form/fmshimp.cxx|5 
 svx/source/form/fmview.cxx |4 
 svx/source/gallery2/galtheme.cxx   |2 
 svx/source/sidebar/possize/PosSizePropertyPanel.cxx|   14 +-
 svx/source/svdraw/sdrpagewindow.cxx|4 
 svx/source/svdraw/svdcrtv.cxx  |   15 +-
 svx/source/svdraw/svddrgmt.cxx |   26 ++--
 svx/source/svdraw/svddrgv.cxx  |4 
 svx/source/svdraw/svdedtv.cxx  |   56 +-
 svx/source/svdraw/svdedtv1.cxx |   48 
 svx/source/svdraw/svdedtv2.cxx |   72 ++---
 svx/source/svdraw/svdedxv.cxx  |   66 +--
 svx/source/svdraw/svdglev.cxx  |   18 +--
 svx/source/svdraw/svdmrkv.cxx  |   12 +-
 svx/source/svdraw/svdpagv.cxx  |2 
 svx/source/svdraw/svdpntv.cxx  |   12 --
 svx/source/svdraw/svdpoev.cxx  |   22 +--
 svx/source/svdraw/svdview.cxx  |   10 -
 svx/source/svdraw/svdxcgv.cxx  |   

[Libreoffice-bugs] [Bug 153286] LibreOffice on MacOS underlines "first" and "office" as typos

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153286

Faisal  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
  Component|LibreOffice |Draw

--- Comment #1 from Faisal  ---
That is related to ligatures (fl, ff, fi). Reproduced on 

Version: 7.4.4.2 (x64) / LibreOffice Community
Build ID: 85569322deea74ec9134968a29af2df5663baa21
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153141] bizarre upper-, lower-case

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153141

tor...@yahoo.com changed:

   What|Removed |Added

 Resolution|NOTABUG |---
 Status|RESOLVED|REOPENED

--- Comment #4 from tor...@yahoo.com ---
Why do I "have a direct format for 'orrens' as lowercase" ?
Style Heading1 has FontEffects>Case = Without, not UPPERCASE.
^m should not uppercase 'orrens'
Why does inserting the M work differently?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153098] LO skips the 1st column of 2nd section when sections have heading with Columb Break Before text flow, while loading the document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153098

Lesline  changed:

   What|Removed |Added

 CC||leslinetest...@gmail.com

--- Comment #2 from Lesline  ---
Good Afternoon.

Thank you for reporting the bug.  Following the steps provided, I was unable to
reproduce the bug.  The builds used for testing this bug were:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d07b1cc8148140bd3a78103da668d002b9d266ab
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded


Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Kind Regards

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153286] New: LibreOffice on MacOS underlines "first" and "office" as typos

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153286

Bug ID: 153286
   Summary: LibreOffice on MacOS underlines "first" and "office"
as typos
   Product: LibreOffice
   Version: 7.3.7.2 release
  Hardware: All
OS: macOS (All)
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ddascalescu+freedesk...@gmail.com

Created attachment 185018
  --> https://bugs.documentfoundation.org/attachment.cgi?id=185018=edit
PDF exhibiting the bug

When I open the attached PDF in LibreOffice Mac, it highlights some words
containing the letter "f" as misspelled: first, office, flashing, findings. 
Other words containing "f" aren't highlighted.

The "f" doesn't appear to be some identically-looking Unicode variant of the
letter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: cui/source cui/uiconfig

[Henry Castro (via logerrit)]

 cui/source/options/optlanguagetool.cxx |3 ++
 cui/source/options/optlanguagetool.hxx |3 +-
 cui/uiconfig/ui/langtoolconfigpage.ui  |   38 -
 3 files changed, 42 insertions(+), 2 deletions(-)

New commits:
commit 326dec315c29028ad1c163020d518e1236f37b6b
Author: Henry Castro 
AuthorDate: Mon Nov 21 21:30:02 2022 -0400
Commit: Henry Castro 
CommitDate: Mon Jan 30 23:23:15 2023 +

cui: add entry "RestProtocol" to language tool dialog

Signed-off-by: Henry Castro 
Change-Id: I6511fc2b353c47b1ff537c42d3484b3a42c1b121
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143106
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145596
Tested-by: Jenkins

diff --git a/cui/source/options/optlanguagetool.cxx 
b/cui/source/options/optlanguagetool.cxx
index f0006d1dd0e0..7a087b09e8c0 100644
--- a/cui/source/options/optlanguagetool.cxx
+++ b/cui/source/options/optlanguagetool.cxx
@@ -30,6 +30,7 @@ 
OptLanguageToolTabPage::OptLanguageToolTabPage(weld::Container* pPage,
 , m_xBaseURLED(m_xBuilder->weld_entry("baseurl"))
 , m_xUsernameED(m_xBuilder->weld_entry("username"))
 , m_xApiKeyED(m_xBuilder->weld_entry("apikey"))
+, m_xRestProtocol(m_xBuilder->weld_entry("restprotocol"))
 , m_xActivateBox(m_xBuilder->weld_check_button("activate"))
 , m_xSSLDisableVerificationBox(m_xBuilder->weld_check_button("verifyssl"))
 , m_xApiSettingsFrame(m_xBuilder->weld_frame("apisettings"))
@@ -73,6 +74,7 @@ void OptLanguageToolTabPage::Reset(const SfxItemSet*)
 
 m_xUsernameED->set_text(rLanguageOpts.getUsername());
 m_xApiKeyED->set_text(rLanguageOpts.getApiKey());
+m_xRestProtocol->set_text(rLanguageOpts.getRestProtocol());
 
m_xSSLDisableVerificationBox->set_active(rLanguageOpts.getSSLVerification() != 
true);
 }
 
@@ -89,6 +91,7 @@ bool OptLanguageToolTabPage::FillItemSet(SfxItemSet*)
 
 rLanguageOpts.setUsername(m_xUsernameED->get_text());
 rLanguageOpts.setApiKey(m_xApiKeyED->get_text());
+rLanguageOpts.setRestProtocol(m_xRestProtocol->get_text());
 
rLanguageOpts.setSSLVerification(m_xSSLDisableVerificationBox->get_active() != 
true);
 return false;
 }
diff --git a/cui/source/options/optlanguagetool.hxx 
b/cui/source/options/optlanguagetool.hxx
index 666512804c62..141d88f63bb4 100644
--- a/cui/source/options/optlanguagetool.hxx
+++ b/cui/source/options/optlanguagetool.hxx
@@ -38,6 +38,7 @@ private:
 std::unique_ptr m_xBaseURLED;
 std::unique_ptr m_xUsernameED;
 std::unique_ptr m_xApiKeyED;
+std::unique_ptr m_xRestProtocol;
 std::unique_ptr m_xActivateBox;
 std::unique_ptr m_xSSLDisableVerificationBox;
 std::unique_ptr m_xApiSettingsFrame;
@@ -45,4 +46,4 @@ private:
 void EnableControls(bool bEnable);
 
 DECL_LINK(CheckHdl, weld::Toggleable&, void);
-};
\ No newline at end of file
+};
diff --git a/cui/uiconfig/ui/langtoolconfigpage.ui 
b/cui/uiconfig/ui/langtoolconfigpage.ui
index 237040fa76b7..1d7452161998 100644
--- a/cui/uiconfig/ui/langtoolconfigpage.ui
+++ b/cui/uiconfig/ui/langtoolconfigpage.ui
@@ -80,7 +80,7 @@
   
 True
 False
-5
+6
 12
 
   
@@ -191,6 +191,42 @@
 5
   
 
+
+  
+True
+False
+start
+REST protocol:
+True
+restprotocol
+  
+  
+0
+6
+  
+
+
+  
+True
+True
+  
+  
+1
+6
+  
+
+
+  
+True
+False
+start
+Your LanguageTool REST API protocol for 
usage.
+  
+  
+1
+7
+  
+
 
   
 

[Libreoffice-bugs] [Bug 153285] EDITING: Constant crashing in CALC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153285

--- Comment #1 from byl sottile  ---
Please fix..

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153285] New: EDITING: Constant crashing in CALC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153285

Bug ID: 153285
   Summary: EDITING: Constant crashing in CALC
   Product: LibreOffice
   Version: 7.4.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wmjsott...@gmail.com

Description:
Once started, Calc (office) will work, then start to slow down like it's
waiting to react to keystrokes, it gets slower and slower, then finally crashes
after freezing.

This has happened with the last 8 sessions, I rebooted my system.. previous
versions have never done this.

Responsiveness is really bad, when this happens.. I think you broke something.
Byl S
Oregon


Steps to Reproduce:
1.run it and make about 50 changes.. mostly creating colors and
merging/unmerging cells
2.
3.

Actual Results:
after a while, it slows down, then crashes, the responsiveness from keystroke
to response gets longer and longer till it crashes.


Expected Results:
Not doing this


Reproducible: Always


User Profile Reset: Yes

Additional Info:
I will try ONE more update.. then I may have to go back to EXCEL I have too
much work relying on this product.  thanks in advance

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 148872] Right-Click at the right end of Selected Text, the selection will be released

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=148872

nobu  changed:

   What|Removed |Added

Version|7.3.0.1 rc  |7.3.0.0 beta1+

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152718] Curve auto numbering on merged cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152718

Lesline  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||leslinetest...@gmail.com
 Status|UNCONFIRMED |NEEDINFO

--- Comment #1 from Lesline  ---
Hello Ruslan.

Thank you for reporting the bug.

I'd like to ask if you can kindly provide the written instructions for steps
you are taking to merge the cells as it is not entirely apparent from the
video.  The rest of the process is understood.  

I'll set the bug's status to 'NEEDINFO'. Please can you change it back to
'UNCONFIRMED' once the steps are provided.  

Many thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svtools officecfg/registry svtools/source

[Henry Castro (via logerrit)]

 include/svtools/languagetoolcfg.hxx|3 +
 officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs |6 ++
 svtools/source/config/languagetoolcfg.cxx  |   22 
+-
 3 files changed, 29 insertions(+), 2 deletions(-)

New commits:
commit 9d4ac7d73c036d8e8bdf5418919c1bfd2062ed6d
Author: Henry Castro 
AuthorDate: Mon Nov 21 21:27:24 2022 -0400
Commit: Henry Castro 
CommitDate: Mon Jan 30 22:12:31 2023 +

svtools: add new entry "RestProtocol"

Custom Rest API protocol

Signed-off-by: Henry Castro 
Change-Id: If2f72330f2ed9768f230dc88296df7f757be263a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143105
Reviewed-by: Ashod Nakashian 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145595
Tested-by: Jenkins

diff --git a/include/svtools/languagetoolcfg.hxx 
b/include/svtools/languagetoolcfg.hxx
index 3f30c4bd94a8..24c4de6408aa 100644
--- a/include/svtools/languagetoolcfg.hxx
+++ b/include/svtools/languagetoolcfg.hxx
@@ -39,6 +39,9 @@ public:
 const OUString& getBaseURL() const;
 void setBaseURL(const OUString& rVal);
 
+const OUString& getRestProtocol() const;
+void setRestProtocol(const OUString& rVal);
+
 const OUString& getUsername() const;
 void setUsername(const OUString& rVal);
 
diff --git a/officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs
index 968c9554fde7..f58d7c15e850 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs
@@ -429,6 +429,12 @@
 
 true
   
+  
+
+  LanguageTool Grammar Checker REST API protocol
+  REST API protocol
+
+  
   
 
 
diff --git a/svtools/source/config/languagetoolcfg.cxx 
b/svtools/source/config/languagetoolcfg.cxx
index fbc48d70fde7..56d4a2431056 100644
--- a/svtools/source/config/languagetoolcfg.cxx
+++ b/svtools/source/config/languagetoolcfg.cxx
@@ -31,6 +31,7 @@ struct LanguageToolOptions_Impl
 OUString sBaseURL;
 OUString sUsername;
 OUString sApiKey;
+OUString sRestProtocol;
 bool bEnabled;
 bool bSSLCertVerificatrionEnabled;
 };
@@ -39,7 +40,7 @@ const Sequence& 
SvxLanguageToolOptions::GetPropertyNames()
 {
 static Sequence const aNames{
 "LanguageTool/BaseURL",   "LanguageTool/Username",  
"LanguageTool/ApiKey",
-"LanguageTool/IsEnabled", "LanguageTool/SSLCertVerify",
+"LanguageTool/IsEnabled", "LanguageTool/SSLCertVerify", 
"LanguageTool/RestProtocol"
 };
 return aNames;
 }
@@ -66,12 +67,23 @@ OUString SvxLanguageToolOptions::getCheckerURL() const { 
return pImpl->sBaseURL
 
 const OUString& SvxLanguageToolOptions::getApiKey() const { return 
pImpl->sApiKey; }
 
+const OUString& SvxLanguageToolOptions::getRestProtocol() const { return 
pImpl->sRestProtocol; }
+
 void SvxLanguageToolOptions::setApiKey(const OUString& rVal)
 {
 pImpl->sApiKey = rVal;
 SetModified();
 }
 
+void SvxLanguageToolOptions::setRestProtocol(const OUString& rVal)
+{
+if (pImpl->sRestProtocol != rVal)
+{
+pImpl->sRestProtocol = rVal;
+SetModified();
+}
+}
+
 bool SvxLanguageToolOptions::getEnabled() const { return pImpl->bEnabled; }
 
 bool SvxLanguageToolOptions::getSSLVerification() const
@@ -142,6 +154,9 @@ void SvxLanguageToolOptions::Load(const 
css::uno::Sequence& aNames)
 case 4:
 pValues[nProp] >>= pImpl->bSSLCertVerificatrionEnabled;
 break;
+case 5:
+pValues[nProp] >>= pImpl->sRestProtocol;
+break;
 default:
 break;
 }
@@ -172,9 +187,12 @@ void SvxLanguageToolOptions::ImplCommit()
 case 4:
 pValues[nProp] <<= pImpl->bSSLCertVerificatrionEnabled;
 break;
+case 5:
+pValues[nProp] <<= pImpl->sRestProtocol;
+break;
 default:
 break;
 }
 }
 PutProperties(aNames, aValues);
-}
\ No newline at end of file
+}

[Libreoffice-commits] core.git: cui/source cui/uiconfig desktop/source include/sal include/svtools lingucomponent/source officecfg/registry svtools/source

[Mert Tumer (via logerrit)]

 cui/source/options/optlanguagetool.cxx|4 
 cui/source/options/optlanguagetool.hxx|1 
 cui/uiconfig/ui/langtoolconfigpage.ui |  239 
+-
 desktop/source/lib/init.cxx   |3 
 include/sal/log-areas.dox |4 
 include/svtools/languagetoolcfg.hxx   |3 
 lingucomponent/source/spellcheck/languagetool/languagetoolimp.cxx |   19 
 officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs|7 
 svtools/source/config/languagetoolcfg.cxx |   24 -
 9 files changed, 183 insertions(+), 121 deletions(-)

New commits:
commit 1fb964276c184b0fb052503fe7dbc05bf0331211
Author: Mert Tumer 
AuthorDate: Mon Jul 4 19:52:49 2022 +0300
Commit: Henry Castro 
CommitDate: Mon Jan 30 22:12:03 2023 +

Added option to disable ssl verification for languagetool

This will allow to use self-signed certificates with local run
languagetool APIs

Signed-off-by: Mert Tumer 
Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Andras Timar 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145594
Tested-by: Jenkins
Reviewed-by: Henry Castro 

diff --git a/cui/source/options/optlanguagetool.cxx 
b/cui/source/options/optlanguagetool.cxx
index 309ff2a09b52..f0006d1dd0e0 100644
--- a/cui/source/options/optlanguagetool.cxx
+++ b/cui/source/options/optlanguagetool.cxx
@@ -31,6 +31,7 @@ 
OptLanguageToolTabPage::OptLanguageToolTabPage(weld::Container* pPage,
 , m_xUsernameED(m_xBuilder->weld_entry("username"))
 , m_xApiKeyED(m_xBuilder->weld_entry("apikey"))
 , m_xActivateBox(m_xBuilder->weld_check_button("activate"))
+, m_xSSLDisableVerificationBox(m_xBuilder->weld_check_button("verifyssl"))
 , m_xApiSettingsFrame(m_xBuilder->weld_frame("apisettings"))
 {
 m_xActivateBox->connect_toggled(LINK(this, OptLanguageToolTabPage, 
CheckHdl));
@@ -51,6 +52,7 @@ void OptLanguageToolTabPage::EnableControls(bool bEnable)
 rLanguageOpts.setEnabled(bEnable);
 m_xApiSettingsFrame->set_visible(bEnable);
 m_xActivateBox->set_active(bEnable);
+
m_xSSLDisableVerificationBox->set_active(rLanguageOpts.getSSLVerification() != 
true);
 }
 
 IMPL_LINK_NOARG(OptLanguageToolTabPage, CheckHdl, weld::Toggleable&, void)
@@ -71,6 +73,7 @@ void OptLanguageToolTabPage::Reset(const SfxItemSet*)
 
 m_xUsernameED->set_text(rLanguageOpts.getUsername());
 m_xApiKeyED->set_text(rLanguageOpts.getApiKey());
+
m_xSSLDisableVerificationBox->set_active(rLanguageOpts.getSSLVerification() != 
true);
 }
 
 bool OptLanguageToolTabPage::FillItemSet(SfxItemSet*)
@@ -86,6 +89,7 @@ bool OptLanguageToolTabPage::FillItemSet(SfxItemSet*)
 
 rLanguageOpts.setUsername(m_xUsernameED->get_text());
 rLanguageOpts.setApiKey(m_xApiKeyED->get_text());
+
rLanguageOpts.setSSLVerification(m_xSSLDisableVerificationBox->get_active() != 
true);
 return false;
 }
 
diff --git a/cui/source/options/optlanguagetool.hxx 
b/cui/source/options/optlanguagetool.hxx
index 8ee83ed4e367..666512804c62 100644
--- a/cui/source/options/optlanguagetool.hxx
+++ b/cui/source/options/optlanguagetool.hxx
@@ -39,6 +39,7 @@ private:
 std::unique_ptr m_xUsernameED;
 std::unique_ptr m_xApiKeyED;
 std::unique_ptr m_xActivateBox;
+std::unique_ptr m_xSSLDisableVerificationBox;
 std::unique_ptr m_xApiSettingsFrame;
 
 void EnableControls(bool bEnable);
diff --git a/cui/uiconfig/ui/langtoolconfigpage.ui 
b/cui/uiconfig/ui/langtoolconfigpage.ui
index 38aa184c2469..237040fa76b7 100644
--- a/cui/uiconfig/ui/langtoolconfigpage.ui
+++ b/cui/uiconfig/ui/langtoolconfigpage.ui
@@ -76,16 +76,130 @@
   
 True
 False
-5
-12
 
-  
+  
 True
 False
-start
-Base URL:
-True
-baseurl
+5
+12
+
+  
+True
+False
+start
+Base URL:
+True
+baseurl
+  
+  
+0
+0
+  
+
+
+  
+True
+True
+True
+  
+  

[Libreoffice-commits] core.git: external/skia

[Stephan Bergmann (via logerrit)]

 external/skia/0001-Added-missing-include-cstdio.patch |   29 ++
 external/skia/UnpackedTarball_skia.mk |1 
 2 files changed, 30 insertions(+)

New commits:
commit ed68634db25103cd7d2adc29f3973f80fbaec324
Author: Stephan Bergmann 
AuthorDate: Mon Jan 30 18:39:46 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Jan 30 22:02:33 2023 +

external/skia: Still missing include

9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111" had removed 
the
whole external/skia/missing-include.patch.0, including the part added by
5877c6b118c99c9ec807a111471bfd67720a5086 "external/skia: Missing include" 
(for
snprintf in

workdir/UnpackedTarball/skia/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h),
even though at least my GCC 13 trunk build still requires that.  However, 
the
comment at


"external/skia: Missing include" pointed out that this "landed upstream at

https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/commit/29d492b60c84ca784ea0943efc7d2e6e0f3bdaac;,
so switch to using a git-format-patch of that (slightly hand-edited to fix 
up
the path of that project's vk_mem_alloc.h as included in the Skia tarball, 
and
to cater for that file's usage of CRLF line endings).

Change-Id: I31192b6e0aaf355d5cfee96badc59903ab592aae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146365
Reviewed-by: Sam James 
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/skia/0001-Added-missing-include-cstdio.patch 
b/external/skia/0001-Added-missing-include-cstdio.patch
new file mode 100644
index ..cfe2ffdb0bd8
--- /dev/null
+++ b/external/skia/0001-Added-missing-include-cstdio.patch
@@ -0,0 +1,29 @@
+From 29d492b60c84ca784ea0943efc7d2e6e0f3bdaac Mon Sep 17 00:00:00 2001
+From: Adam Sawicki 
+Date: Thu, 19 Jan 2023 13:19:55 +0100
+Subject: [PATCH] Added missing #include 
+
+For snprintf, for compatibility with GCC 13.
+Fixes #312 - thanks @marxin !
+---
+ include/vk_mem_alloc.h | 4 
+ 1 file changed, 4 insertions(+)
+
+diff --git a/include/vk_mem_alloc.h b/include/vk_mem_alloc.h
+index b787c36..0fe459b 100644
+--- a/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h
 b/third_party/vulkanmemoryallocator/include/vk_mem_alloc.h
+@@ -2614,6 +2614,10 @@ VMA_CALL_PRE void VMA_CALL_POST vmaFreeStatsString(
+ #include  // For std::popcount
+ #endif
+ 
++#if VMA_STATS_STRING_ENABLED
++#include  // For snprintf
++#endif
++
+ 
/***
+ CONFIGURATION SECTION
+ 
+-- 
+2.39.1
+
diff --git a/external/skia/UnpackedTarball_skia.mk 
b/external/skia/UnpackedTarball_skia.mk
index cb4238acaefc..cafc7a9df3b8 100644
--- a/external/skia/UnpackedTarball_skia.mk
+++ b/external/skia/UnpackedTarball_skia.mk
@@ -38,6 +38,7 @@ skia_patches := \
 constexpr-template.patch.0 \
 tdf147342.patch.0 \
 redefinition-of-op.patch.0 \
+0001-Added-missing-include-cstdio.patch \
 
 $(eval $(call gb_UnpackedTarball_set_patchlevel,skia,1))
 

[Libreoffice-bugs] [Bug 153048] Export a document with TTF fonts to PDF leads to text not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153048

--- Comment #18 from Kalytis  ---
Well, I guess the problem comes with LibreOffice, then.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153048] Export a document with TTF fonts to PDF leads to text not displayed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153048

--- Comment #17 from خالد حسني  ---
(In reply to Kalytis from comment #16)
> I'm already using 7.5.0.1, see the version mentionned on my bug.
> 
> I was talking about a way to update libharfbuzzb0 to a newer version than
> 2.7.4.1-ubuntu3.1, as it seems to be the problem here.

TDF builds use a bundled version of harfbuzz and don't use the system installed
one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153284] New: Add support for dark mode to LibreOffice Online Help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153284

Bug ID: 153284
   Summary: Add support for dark mode to LibreOffice Online Help
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: low
 Component: Documentation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fit...@ubuntu.com
CC: olivier.hal...@libreoffice.org

See https://css-tricks.com/almanac/properties/c/color-scheme/. This needs
design work to decide the colors to use.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: include/svl

[Andrea Gelmini (via logerrit)]

 include/svl/zformat.hxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 82ee2d6184a59ef4470c12bddeff03cd68d946e4
Author: Andrea Gelmini 
AuthorDate: Mon Jan 30 20:44:43 2023 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Jan 30 21:06:20 2023 +

Fix typos

Change-Id: Iaed6f8d3316200f8c5e0c96766a84d59b1066928
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146367
Tested-by: Adolfo Jayme Barrientos 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index ea08234e93a2..1fa52c3384a2 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -459,8 +459,8 @@ public:
 void GetNatNumXml(
 css::i18n::NativeNumberXmlAttributes2& rAttr,
 sal_uInt16 nNumFor ) const;
-/** Return empty string if no NatNum modifier or unvalid nNumFor
-otherwhise return "[NatNum1]" or "[NatNum12 ...]" */
+/** Return empty string if no NatNum modifier or invalid nNumFor
+otherwise return "[NatNum1]" or "[NatNum12 ...]" */
 OUString GetNatNumModifierString( sal_uInt16 nNumFor = 0 ) const;
 
 /** Switches to the first non-"gregorian" calendar, but only if the current

[Libreoffice-commits] core.git: external/skia

[Stephan Bergmann (via logerrit)]

 external/skia/constexpr-template.patch.0 |   15 +++
 1 file changed, 15 insertions(+)

New commits:
commit 1cba80e9224de8c7318aa8fddba3db6ec9915d51
Author: Stephan Bergmann 
AuthorDate: Mon Jan 30 11:53:48 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Jan 30 21:03:43 2023 +

external/skia: Another constexpr template point of instantiation issue

...with --with-latest-c++ after 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 
"Update
skia to m111",

> In file included from 
workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.cpp:8:
> In file included from 
workdir/UnpackedTarball/skia/src/core/SkBitmapDevice.h:11:
> In file included from 
workdir/UnpackedTarball/skia/include/core/SkBitmap.h:12:
> In file included from 
workdir/UnpackedTarball/skia/include/core/SkImageInfo.h:14:
> In file included from 
workdir/UnpackedTarball/skia/include/core/SkRect.h:19:
> In file included from 
/Users/stephan/llvm/inst/bin/../include/c++/v1/algorithm:1747:
> In file included from 
/Users/stephan/llvm/inst/bin/../include/c++/v1/__algorithm/inplace_merge.h:28:
> ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:63:19: error: 
invalid application of 'sizeof' to an incomplete type 'SkStrikePinner'
> static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
>   ^~~
> ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:297:7: note: in 
instantiation of member function 
'std::default_delete::operator()' requested here
>   __ptr_.second()(__tmp);
>   ^
> ~/llvm/inst/bin/../include/c++/v1/__memory/unique_ptr.h:263:75: note: in 
instantiation of member function 'std::unique_ptr::reset' 
requested here
>   _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { 
reset(); }
>   
^
> workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:46:47: note: in 
instantiation of member function 'std::unique_ptr::~unique_ptr' 
requested here
> std::unique_ptr = nullptr) SK_EXCLUDES(fLock);
>   ^
> workdir/UnpackedTarball/skia/src/core/SkStrikeCache.h:20:7: note: forward 
declaration of 'SkStrikePinner'
> class SkStrikePinner;
>   ^

Change-Id: I367323706d047da18fd8d4230a47a78fbb32b677
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146349
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/external/skia/constexpr-template.patch.0 
b/external/skia/constexpr-template.patch.0
index 4123227ba637..2e962660e4f0 100644
--- a/external/skia/constexpr-template.patch.0
+++ b/external/skia/constexpr-template.patch.0
@@ -23,6 +23,21 @@
  collectArgs(args, std::forward(remaining)...);
  }
  
+--- src/core/SkStrikeCache.h
 src/core/SkStrikeCache.h
+@@ -13,11 +13,10 @@
+ #include "include/private/base/SkLoadUserConfig.h" // IWYU pragma: keep
+ #include "include/private/base/SkMutex.h"
+ #include "src/core/SkDescriptor.h"
++#include "src/core/SkStrike.h"
+ #include "src/core/SkStrikeSpec.h"
+ #include "src/text/StrikeForGPU.h"
+ 
+-class SkStrike;
+-class SkStrikePinner;
+ class SkTraceMemoryDump;
+ 
+ //  SK_DEFAULT_FONT_CACHE_COUNT_LIMIT and SK_DEFAULT_FONT_CACHE_LIMIT can be 
set using -D on your
 --- src/gpu/ganesh/effects/GrBlendFragmentProcessor.h
 +++ src/gpu/ganesh/effects/GrBlendFragmentProcessor.h
 @@ -10,8 +10,7 @@

[Libreoffice-bugs] [Bug 118017] [META] macOS Dark Mode bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=118017

--- Comment #24 from Adolfo Jayme Barrientos  ---
eyeroll

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 152346] 7.5 alpha Windows 32-bit crashes on startup

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=152346

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||tac...@hotmail.co.jp

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
I couldn't reproduce on Windows 10, when installing with SI GUI and making sure
the destination folder was different to the previously installed 7.5.0.2 64
bits installation.

Version: 7.5.0.2 (x86) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

However, if I installed it with the defaults given to me by SI GUI, it reused
the same directory as for the 64 bits version, and would end up with a
soffice.exe that straight away gives me an error message.

Which installers did you use, David? And nobu, same question?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153280] Download version 7.3.7 does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153280

--- Comment #9 from Julien Nabet  ---
(In reply to Xisco Faulí from comment #8)
> (In reply to Julien Nabet from comment #4)
> > (In reply to Buovjaga from comment #2)
...
> > IMHO if 7.4.5 replaces 7.3.7 as the stable version and I can understand it,
> > shouldn't 7.5.0 be proposed for early adopters?
> 
> it will be this week, when it's released

Great! :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142380] DRY: Use CSS variables to eliminate repetition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142380

--- Comment #6 from Commit Notification 
 ---
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/c6cea6707879ad1c8f5bd11ff26b774f2e59b013

tdf#142380 Use CSS variable for background color

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 142380] DRY: Use CSS variables to eliminate repetition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142380

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.4.0 target:7.5.0   |target:7.4.0 target:7.5.0
   |target:7.4.0.0.beta2|target:7.4.0.0.beta2
   ||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] help.git: help3xsl/default.css

[Adolfo Jayme Barrientos (via logerrit)]

 help3xsl/default.css |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit c6cea6707879ad1c8f5bd11ff26b774f2e59b013
Author: Adolfo Jayme Barrientos 
AuthorDate: Mon Jan 30 14:46:07 2023 -0600
Commit: Adolfo Jayme Barrientos 
CommitDate: Mon Jan 30 14:46:07 2023 -0600

tdf#142380 Use CSS variable for background color

Change-Id: Ia70389ced5e8b698c034f9eec8cb4f030d27dd81

diff --git a/help3xsl/default.css b/help3xsl/default.css
index abf75f69c1..7ce0da75f3 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -31,6 +31,7 @@ do not break anything related to layout by scaling.
 :root {
   --font_mono: Menlo, "Cascadia Mono", "Cascadia Code", Consolas, "DejaVu Sans 
Mono", monospace;
   --font_body: Ubuntu, Cantarell, "Segoe UI Variable", "Segoe UI", "Noto 
Sans", "DejaVu Sans", "Lucida Grande", sans-serif, FreeSerif, NanumGothic, 
"Noto Sans Tibetan", Taprom;
+  --background-color: #f7f8f7;
 }
 
 body,
@@ -90,7 +91,7 @@ h6,
 pointer-events: auto;
 }
 body {
-background-color: #F7F8F7;
+background-color: var(--background-color);
 margin: 0;
 line-height: normal;
 }
@@ -400,10 +401,10 @@ h6 {
 }
 /* You Tube matters */
 .youtube_placeholder{
-border: 1px solid #eee;
+border: 1px dashed #eee;
 max-width:700px;
 padding: 10px;
-background-color: #eee;
+background-color: var(--background-color);
 text-align: center;
 }
 .youtube_button {

[Libreoffice-commits] core.git: helpcontent2

[Adolfo Jayme Barrientos (via logerrit)]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 887de466a689323d4c4a607fdbd74939af98d14b
Author: Adolfo Jayme Barrientos 
AuthorDate: Mon Jan 30 14:46:18 2023 -0600
Commit: Gerrit Code Review 
CommitDate: Mon Jan 30 20:46:18 2023 +

Update git submodules

* Update helpcontent2 from branch 'master'
  to c6cea6707879ad1c8f5bd11ff26b774f2e59b013
  - tdf#142380 Use CSS variable for background color

Change-Id: Ia70389ced5e8b698c034f9eec8cb4f030d27dd81

diff --git a/helpcontent2 b/helpcontent2
index 7fc1be9c61cf..c6cea6707879 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 7fc1be9c61cf8d19c7982dc6a407b7eca2ad5b93
+Subproject commit c6cea6707879ad1c8f5bd11ff26b774f2e59b013

[Libreoffice-bugs] [Bug 136406] [META] OOXML VML shape related issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=136406
Bug 136406 depends on bug 153260, which changed state.

Bug 153260 Summary: FILESAVE DOCX VML write trim=t for Fontwork shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=153260

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 128568] FILESAVE: DOCX: Fontwork broken with Word 2007-365 format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128568
Bug 128568 depends on bug 153260, which changed state.

Bug 153260 Summary: FILESAVE DOCX VML write trim=t for Fontwork shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=153260

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 107634] [META] Fontwork / WordArt bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=107634
Bug 107634 depends on bug 153260, which changed state.

Bug 153260 Summary: FILESAVE DOCX VML write trim=t for Fontwork shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=153260

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 56696] No option to make recent documents list show items for just the currently active LibO module

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56696

Andreas Heinisch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |andreas.heini...@yahoo.de
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153283] New: Application crashes when printing in Windows 10 from Writer or Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153283

Bug ID: 153283
   Summary: Application crashes when printing in Windows 10 from
Writer or Calc
   Product: LibreOffice
   Version: 7.4.5.1 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ask...@gmail.com

Description:
Application crashes when trying to print from toolbar or Windows ctrl-P. file
is not saved and shows as needing to be retored. 

Steps to Reproduce:
1.Open file in app
2.Print
3.

Actual Results:
Application closes. Print dialog says file sent to printer, but that is not the
case

Expected Results:
Sent file to printer and remained open. 


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.4.5.1 (x64) / LibreOffice Community
Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: oox/qa oox/source

[Regina Henschel (via logerrit)]

 oox/qa/unit/data/tdf153260_VML_trim_export.odt |binary
 oox/qa/unit/vml.cxx|   23 +++
 oox/source/export/vmlexport.cxx|6 --
 3 files changed, 27 insertions(+), 2 deletions(-)

New commits:
commit fc5ab71bd2b4af535c2bdd2c9ea48be378b66a19
Author: Regina Henschel 
AuthorDate: Mon Jan 30 15:32:54 2023 +0100
Commit: Regina Henschel 
CommitDate: Mon Jan 30 20:20:53 2023 +

tdf#153260 VML export write trim value true in any case

LO renders Fontwork shapes always so as if trim=true is set. But the
default value for trim attribute is 'false'. Therefore always write out
'true'. Otherwise the import will treat it as 'false' and apply the
shape height reducing workaround.

Change-Id: I626c5a84627f16011198a9a4e35d8fedf1fd1b3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146361
Tested-by: Jenkins
Reviewed-by: Regina Henschel 

diff --git a/oox/qa/unit/data/tdf153260_VML_trim_export.odt 
b/oox/qa/unit/data/tdf153260_VML_trim_export.odt
new file mode 100644
index ..407a27fff254
Binary files /dev/null and b/oox/qa/unit/data/tdf153260_VML_trim_export.odt 
differ
diff --git a/oox/qa/unit/vml.cxx b/oox/qa/unit/vml.cxx
index 6a8eab8098ab..be99a281af04 100644
--- a/oox/qa/unit/vml.cxx
+++ b/oox/qa/unit/vml.cxx
@@ -17,6 +17,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -201,6 +202,28 @@ CPPUNIT_TEST_FIXTURE(OoxVmlTest, testWatermark)
 CPPUNIT_ASSERT_EQUAL(drawing::ColorMode_WATERMARK, eMode);
 }
 
+CPPUNIT_TEST_FIXTURE(OoxVmlTest, testWriterFontworkTrimTrue)
+{
+// The document contains a shape, that will be exported as VML shape to 
docx. Error was that the
+// attribute trim was not written out and thus import had treated it as 
the default 'false' and
+// had reduced the shape height.
+loadFromURL(u"tdf153260_VML_trim_export.odt");
+
+// FIXME: tdf#153183 validation error in OOXML export: Errors: 1
+// Attribute 'ID' is not allowed to appear in element 'v:shape'.
+skipValidation();
+saveAndReload("Office Open XML Text");
+
+uno::Reference xDrawPageSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xShape(xDrawPageSupplier->getDrawPage()->getByIndex(0),
+   uno::UNO_QUERY);
+
+// Make sure the shape height is not changed.
+// Without the fix the test would have failed with expected 4999 actual 
1732.
+awt::Size aSize = xShape->getSize();
+CPPUNIT_ASSERT_DOUBLES_EQUAL(4999, aSize.Height, 2);
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index 62b102a8fa2d..ebe30bce0223 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -997,8 +997,10 @@ void VMLExport::Commit( EscherPropertyContainer& rProps, 
const tools::Rectangle&
 if (!aStyle.isEmpty())
 pAttrList->add(XML_style, aStyle);
 
-if (IsWaterMarkShape(m_pSdrObject->GetName()))
-pAttrList->add(XML_trim, "t");
+// tdf#153260. LO renders all Fontwork shapes as if 
trim="t" is set. Default
+// value is "f". So always write out "t", otherwise 
import will reduce the
+// shape height as workaround for "f".
+pAttrList->add(XML_trim, "t");
 
 m_pSerializer->singleElementNS(XML_v, XML_textpath, 
pAttrList);
 }

[Libreoffice-bugs] [Bug 113359] [META] Calc toolbar bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=113359
Bug 113359 depends on bug 150380, which changed state.

Bug 150380 Summary: Calc crash when clicking on the title of the Border Color 
toolbar popdown
https://bugs.documentfoundation.org/show_bug.cgi?id=150380

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150380] Calc crash when clicking on the title of the Border Color toolbar popdown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150380

Noel Grandin  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 112974] [META] Toolbar overflow/wrap/chevron button bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=112974
Bug 112974 depends on bug 150380, which changed state.

Bug 150380 Summary: Calc crash when clicking on the title of the Border Color 
toolbar popdown
https://bugs.documentfoundation.org/show_bug.cgi?id=150380

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 133092] [META] Crash bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=133092
Bug 133092 depends on bug 150380, which changed state.

Bug 150380 Summary: Calc crash when clicking on the title of the Border Color 
toolbar popdown
https://bugs.documentfoundation.org/show_bug.cgi?id=150380

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150380] Calc crash when clicking on the title of the Border Color toolbar popdown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150380

--- Comment #12 from Commit Notification 
 ---
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f4a24366dd111c7c7434f4a887d7097ced6b5f55

tdf#150380 Calc crash clicking on the title of the Border Color toolbar popdown

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 150380] Calc crash when clicking on the title of the Border Color toolbar popdown

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=150380

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:7.6.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/source

[Noel Grandin (via logerrit)]

 vcl/source/app/salvtables.cxx |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit f4a24366dd111c7c7434f4a887d7097ced6b5f55
Author: Noel Grandin 
AuthorDate: Mon Jan 30 15:50:31 2023 +0200
Commit: Noel Grandin 
CommitDate: Mon Jan 30 20:12:21 2023 +

tdf#150380 Calc crash clicking on the title of the Border Color toolbar 
popdown

There is probably a better fix for this, but we have a popup inside a
popup here, so some weirdness is to be expected.

At least it doesn't crash now.

Change-Id: Ifaa928c47c3cbfaec8379f01f007b0c1daf4e5a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146359
Tested-by: Noel Grandin 
Reviewed-by: Noel Grandin 

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index 733d78179500..259192c854cb 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -1322,7 +1322,13 @@ void SalInstanceContainer::move(weld::Widget* pWidget, 
weld::Container* pNewPare
 assert(!pNewParent || pNewVclParent);
 vcl::Window* pVclWindow = pVclWidget->getWidget();
 if (pNewVclParent)
-pVclWindow->SetParent(pNewVclParent->getWidget());
+{
+vcl::Window* pNew = pNewVclParent->getWidget();
+if (!pNew->isDisposed())
+pVclWindow->SetParent(pNewVclParent->getWidget());
+else
+SAL_WARN("vcl", "ignoring move because new parent is already 
disposed");
+}
 else
 {
 pVclWindow->Hide();

[Libreoffice-bugs] [Bug 129661] [META] Right-To-Left (RTL) user interface issues

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=129661
Bug 129661 depends on bug 45147, which changed state.

Bug 45147 Summary: right-to-left words appear in the wrong order in the CSV 
import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=45147

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 109239] [META] CSV import and export dialog bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=109239
Bug 109239 depends on bug 45147, which changed state.

Bug 45147 Summary: right-to-left words appear in the wrong order in the CSV 
import dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=45147

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 sw/qa/uitest/sidebar/stylesSidebar.py |   15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)

New commits:
commit 72f3df889a950218c9e801aa93bb2e755d26f3e1
Author: Xisco Fauli 
AuthorDate: Mon Jan 30 13:05:32 2023 +0100
Commit: Xisco Fauli 
CommitDate: Mon Jan 30 19:59:41 2023 +

sw: blind fix for uitest hang

Seen in 
https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/132028/consoleFull#101810144248ce9c26-9d0a-43a8-83d8-c44f54920d59

Change-Id: I67312b3f7e6c6192e14a6bb3236ba4ff959002f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146353
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/sidebar/stylesSidebar.py 
b/sw/qa/uitest/sidebar/stylesSidebar.py
index ec376a164b1d..ee20ef23d5eb 100644
--- a/sw/qa/uitest/sidebar/stylesSidebar.py
+++ b/sw/qa/uitest/sidebar/stylesSidebar.py
@@ -46,16 +46,17 @@ class StylesSidebar(UITestCase):
 xWriterDoc = self.xUITest.getTopFocusWindow()
 xWriterEdit = xWriterDoc.getChild("writer_edit")
 
-self.xUITest.executeCommand(".uno:Sidebar")
-xWriterEdit.executeAction("SIDEBAR", mkPropertyValues({"PANEL": 
"StyleListPanel"}))
-
-xFilter = xWriterEdit.getChild('filter')
-select_by_text(xFilter, "Custom Styles")
-
 expectedResults = ["customParagraphStyle", "customCharacterStyle", 
"customFrameStyle",
 "customPageStyle", "customNumberingStyle"]
 
 for i in range(5):
+
+self.xUITest.executeCommand(".uno:Sidebar")
+xWriterEdit.executeAction("SIDEBAR", 
mkPropertyValues({"PANEL": "StyleListPanel"}))
+
+xFilter = xWriterEdit.getChild('filter')
+select_by_text(xFilter, "Custom Styles")
+
 xLeft = xWriterEdit.getChild('left')
 
 #change to another style type
@@ -69,7 +70,7 @@ class StylesSidebar(UITestCase):
 self.ui_test.wait_until_property_is_updated(xFlatView, 
"SelectEntryText", expectedResults[i])
 self.assertEqual(expectedResults[i], 
get_state_as_dict(xFlatView)['SelectEntryText'])
 
-self.xUITest.executeCommand(".uno:Sidebar")
+self.xUITest.executeCommand(".uno:Sidebar")
 
 
 # vim: set shiftwidth=4 softtabstop=4 expandtab:

[Libreoffice-bugs] [Bug 153273] Scroll bar not in dark mode when system dark mode enabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153273

--- Comment #3 from Caolán McNamara  ---
I can see it, but I don't know why that is. It's the same code that renders it
in either case; (ImplDrawNativeControl in
vcl/win/gdi/salnativewidgets-luna.cxx)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153280] Download version 7.3.7 does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153280

--- Comment #8 from Xisco Faulí  ---
(In reply to Julien Nabet from comment #4)
> (In reply to Buovjaga from comment #2)
> > 7.3.7 is end of life and should not be advertised for normal use
> > https://wiki.documentfoundation.org/ReleasePlan/7.3
> > 
> > The discussion was moved to #tdf-infra chat, Bugzilla is not the right 
> > place.
> 
> IMHO if 7.4.5 replaces 7.3.7 as the stable version and I can understand it,
> shouldn't 7.5.0 be proposed for early adopters?

it will be this week, when it's released

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: sw/qa

[Xisco Fauli (via logerrit)]

 0 files changed

New commits:
commit 86558061332e9828d5a69fe97b439bf49560f552
Author: Xisco Fauli 
AuthorDate: Mon Jan 30 14:17:43 2023 +0100
Commit: Xisco Fauli 
CommitDate: Mon Jan 30 19:16:21 2023 +

sw: blind fix for uitest hang

in sw/qa/uitest/writer_tests6/ there is another test document called
edit_file_properties_before_saving.py that changes the option
"Edit document properties before saving" to True.
My theory is that it might affect save_readonly_with_password.py so let's 
move it to another folder to make sure this is not affecting the test

Change-Id: Ib75361be31aceeec33df76ae31a9ee8c261a2c7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146357
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 

diff --git a/sw/qa/uitest/writer_tests6/save_readonly_with_password.py 
b/sw/qa/uitest/writer_tests3/save_readonly_with_password.py
similarity index 100%
rename from sw/qa/uitest/writer_tests6/save_readonly_with_password.py
rename to sw/qa/uitest/writer_tests3/save_readonly_with_password.py

[Libreoffice-bugs] [Bug 153272] Writer Macro Find with certain Search Attributes performs Replacement.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153272

--- Comment #2 from Don  ---

The following  Hyphenation settings also cause the error.
"ParaIsHyphenation"
"ParaHyphenationNoCaps"
"ParaHyphenationMaxHyphens"
"ParaHyphenationMaxLeadingChars"
"ParaHyphenationMaxTrailingChars"

As well as the following Text Flow settings.
"ParaOrphans"
"ParaWidows"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-commits] core.git: vcl/inc

[Stephan Bergmann (via logerrit)]

 vcl/inc/skia/utils.hxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit 440230f1802ce03f83aa92d1b56806e068ce4800
Author: Stephan Bergmann 
AuthorDate: Mon Jan 30 17:53:23 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Mon Jan 30 18:50:46 2023 +

Silence two GCC warnings in Skia include files

Since 9c9a711ac5d8f32ac318d0e4ecab7b3a26bc2150 "Update skia to m111", 
various
versions of GCC produce

> In file included from 
workdir/UnpackedTarball/skia/include/gpu/GrRecordingContext.h:13,
>  from 
workdir/UnpackedTarball/skia/include/gpu/GrDirectContext.h:11,
>  from 
workdir/UnpackedTarball/skia/tools/sk_app/WindowContext.h:14,
>  from vcl/inc/skia/utils.hxx:35,
>  from vcl/skia/SkiaHelper.cxx:34:
> workdir/UnpackedTarball/skia/include/private/base/SkTArray.h:520:33: 
error: ‘cfi’ attribute directive ignored [-Werror=attributes]
>   520 | static T* TCast(void* buffer) {
>   | ^
> workdir/UnpackedTarball/skia/include/private/base/SkTArray.h: In 
constructor ‘SkSTArray::SkSTArray(std::initializer_list<_Up>)’:
> workdir/UnpackedTarball/skia/include/private/base/SkTArray.h:654:40: 
error: declaration of ‘data’ shadows a member of ‘SkSTArray’ 
[-Werror=shadow]
>   654 | SkSTArray(std::initializer_list data) : 
SkSTArray(data.begin(), SkToInt(data.size())) {}
>   |   ~^~~~
> workdir/UnpackedTarball/skia/include/private/base/SkTArray.h:684:22: 
note: shadowed declaration is here
>   684 | using INHERITED::data;
>   |  ^~~~

The -Werror=attributes is because GCC __attribute__((no_sanitize("...")))
accepts the same values as -fsanitize, but GCC doesn't support Clang's
-fsanitize=cfi.

The -Werror=shadow is because GCC is somewhat picky about uses of a name 
for a
variable when that name is also brought in by a using declaration from a
dependent base, as it /could/ be brought in as a variable (and not just as a
function, in which case there would normally be no such shadowing warning):

> $ cat test.cc
> template struct SkTArray { void data(); };
> template struct SkSTArray: SkTArray {
> SkSTArray(int data) { (void) data; }
> using SkTArray::data;
> };
> $ g++ -Wshadow -fsyntax-only test.cc
> test.cc: In constructor ‘SkSTArray::SkSTArray(int)’:
> test.cc:3:19: warning: declaration of ‘data’ shadows a member of 
‘SkSTArray’ [-Wshadow]
> 3 | SkSTArray(int data) { (void) data; }
>   |   ^~~~
> test.cc:4:24: note: shadowed declaration is here
> 4 | using SkTArray::data;
>   |^~~~

It feels more natural to silence these warnings at the site including the
relevant Skia include files, rather than as a patch to external/skia, as, at
least theoretically, we should also be able to build against a system's Skia
include files.

Change-Id: I0860b6a84e61da656038da8c77f3947d97ad8cf5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146364
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/vcl/inc/skia/utils.hxx b/vcl/inc/skia/utils.hxx
index 355718e8bfa1..3c19192e1c3a 100644
--- a/vcl/inc/skia/utils.hxx
+++ b/vcl/inc/skia/utils.hxx
@@ -32,7 +32,15 @@
 #include 
 #include 
 #include 
+#if defined __GNUC__ && !defined __clang__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wattributes"
+#pragma GCC diagnostic ignored "-Wshadow"
+#endif
 #include 
+#if defined __GNUC__ && !defined __clang__
+#pragma GCC diagnostic pop
+#endif
 #include 
 
 #include 

[Libreoffice-bugs] [Bug 153280] Download version 7.3.7 does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153280

--- Comment #7 from Buovjaga  ---
(In reply to Julien Nabet from comment #6)
> (In reply to Buovjaga from comment #5)
> > (In reply to Julien Nabet from comment #4)
> > > (In reply to Buovjaga from comment #2)
> > > > 7.3.7 is end of life and should not be advertised for normal use
> > > > https://wiki.documentfoundation.org/ReleasePlan/7.3
> > > > 
> > > > The discussion was moved to #tdf-infra chat, Bugzilla is not the right 
> > > > place.
> > > 
> > > IMHO if 7.4.5 replaces 7.3.7 as the stable version and I can understand 
> > > it,
> > > shouldn't 7.5.0 be proposed for early adopters?
> > 
> > Sure, but it's not released yet.
> 
> Indeed but in this case, shouldn't we let 7.3.7 as stable version unless we
> want to propose only 7.4.5 as stable version and nothing for the moment for
> early adopters?

I don't know.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Libreoffice-bugs] [Bug 153280] Download version 7.3.7 does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153280

--- Comment #6 from Julien Nabet  ---
(In reply to Buovjaga from comment #5)
> (In reply to Julien Nabet from comment #4)
> > (In reply to Buovjaga from comment #2)
> > > 7.3.7 is end of life and should not be advertised for normal use
> > > https://wiki.documentfoundation.org/ReleasePlan/7.3
> > > 
> > > The discussion was moved to #tdf-infra chat, Bugzilla is not the right 
> > > place.
> > 
> > IMHO if 7.4.5 replaces 7.3.7 as the stable version and I can understand it,
> > shouldn't 7.5.0 be proposed for early adopters?
> 
> Sure, but it's not released yet.

Indeed but in this case, shouldn't we let 7.3.7 as stable version unless we
want to propose only 7.4.5 as stable version and nothing for the moment for
early adopters?

-- 
You are receiving this mail because:
You are the assignee for the bug.