[Libreoffice-bugs] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #17 from Heiko Tietze --- We could a) stick to the OS/DE: this means NAB b) add an option to tools > options > calc > view: this inflates the options dialog further c) have some kind of interaction on the control, could be a drop down with a couple of font sizes or some ctrl+wheel response specifically on the control: with the drawback that this either holds only a limited number or is hard to figure out for average users d) follow the selected cell's font (maybe all attributes not just the size): does not work for multi-selection with varying content and in case of no selection; has also the drawback of a "jumping" UI e) follow the zoom factor on the sheet: not necessarily what users expect and, like all other options messing-up with the UI, makes the UI imbalanced (thinking of the size of associated icons left-hand and the range selector); plus in multi-line mode with an enlarged font it could become too large f) show the content somewhere else, eg. the functions pane in the sidebar or as balloon tip when hovering over the cell: the formula bar is not intended as "text viewer" for very long text in cells So what is the exact use case that cannot be solved with the formula bar? Reading bug 88141 it seems the user enters long text in cells, which is cut off because of content in neighboring cells and cannot become wrapped for some reason, and uses the formula bar to just read the content. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 Heiko Tietze changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #17 from Heiko Tietze --- We could a) stick to the OS/DE: this means NAB b) add an option to tools > options > calc > view: this inflates the options dialog further c) have some kind of interaction on the control, could be a drop down with a couple of font sizes or some ctrl+wheel response specifically on the control: with the drawback that this either holds only a limited number or is hard to figure out for average users d) follow the selected cell's font (maybe all attributes not just the size): does not work for multi-selection with varying content and in case of no selection; has also the drawback of a "jumping" UI e) follow the zoom factor on the sheet: not necessarily what users expect and, like all other options messing-up with the UI, makes the UI imbalanced (thinking of the size of associated icons left-hand and the range selector); plus in multi-line mode with an enlarged font it could become too large f) show the content somewhere else, eg. the functions pane in the sidebar or as balloon tip when hovering over the cell: the formula bar is not intended as "text viewer" for very long text in cells So what is the exact use case that cannot be solved with the formula bar? Reading bug 88141 it seems the user enters long text in cells, which is cut off because of content in neighboring cells and cannot become wrapped for some reason, and uses the formula bar to just read the content. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153506] Conditional format not preserved in copied sheet. See comment 19
https://bugs.documentfoundation.org/show_bug.cgi?id=153506 --- Comment #27 from BDF --- I observed the same issue in a slightly different way: In my company we use a large table where you enter your finished work. Because the way the file is saved is not very meant for the way we do it, the progress within the file is often not saved. The result is that some workers saved the file to their own PC, edit it over there and just copy the effected lines. This messes with the range/area of the conditional formatting in the original file. The original range is this: =$C$3:$D$1503 The current range of this year (2023-02) is this: =$C$3:$D$55;$C$58:$D$94;$C$96:$D$1503 The end result of last year was this: =$S$3:$T$23;$S$25:$T$109;$S$111:$T$127;$S$129:$T$140;$S$142:$T$215;$S$218:$T$230;$S$232:$T$247;$S$249:$T$254;$S$256:$T$291;$S$293:$T$316;$S$349:$T$356;$S$358:$T$372;$S$374:$T$398;$S$479:$T$598;$S$400:$T$477;$S$318:$T$347;$S$600:$T$606;$S$608:$T$616;$S$618:$T$677;$S$681:$T$696;$S$699:$T$700;$S$721:$T$725;$S$702:$T$719;$S$727:$T$816;$S$818:$T$873;$S$878:$T$934;$S$938:$T$964;$S$966:$T$974;$S$976:$T$978;$S$980:$T$1503 The end goal would be that you could somehow protect the conditional formatting against unwanted changes. I'm not sure if this bug report/feature request has the same core issue, but it sounds familiar enough to me. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source include/comphelper
chart2/source/controller/main/CommandDispatch.cxx | 44
chart2/source/controller/main/CommandDispatch.hxx | 15 +---
chart2/source/controller/main/CommandDispatchContainer.cxx |1
chart2/source/controller/main/ControllerCommandDispatch.cxx |2
chart2/source/controller/main/ControllerCommandDispatch.hxx |2
chart2/source/controller/main/DrawCommandDispatch.cxx |2
chart2/source/controller/main/DrawCommandDispatch.hxx |2
chart2/source/controller/main/ShapeController.cxx |2
chart2/source/controller/main/ShapeController.hxx |2
chart2/source/controller/main/StatusBarCommandDispatch.cxx |2
chart2/source/controller/main/StatusBarCommandDispatch.hxx |2
chart2/source/controller/main/UndoCommandDispatch.cxx |2
chart2/source/controller/main/UndoCommandDispatch.hxx |2
include/comphelper/compbase.hxx |4 -
14 files changed, 37 insertions(+), 47 deletions(-)
New commits:
commit bdc4dc93a9edd5f46bdede12514ac5f66bf43167
Author: Noel Grandin
AuthorDate: Tue Feb 21 14:26:39 2023 +0200
Commit: Noel Grandin
CommitDate: Wed Feb 22 07:52:17 2023 +
BaseMutex->std::mutex in CommandDispatch
Change-Id: Ic73a84eb793d45e1041698e45e2c844a1e2f2f66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147415
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/controller/main/CommandDispatch.cxx
b/chart2/source/controller/main/CommandDispatch.cxx
index c7e4f622c522..37a56e151254 100644
--- a/chart2/source/controller/main/CommandDispatch.cxx
+++ b/chart2/source/controller/main/CommandDispatch.cxx
@@ -31,7 +31,6 @@ namespace chart
CommandDispatch::CommandDispatch(
const Reference< uno::XComponentContext > & xContext ) :
-impl::CommandDispatch_Base( m_aMutex ),
m_xContext( xContext )
{
}
@@ -44,11 +43,11 @@ void CommandDispatch::initialize()
// WeakComponentImplHelperBase
/// is called when this is disposed
-void SAL_CALL CommandDispatch::disposing()
+void CommandDispatch::disposing(std::unique_lock& rGuard)
{
Reference< uno::XInterface > xEventSource(static_cast< cppu::OWeakObject*
>( this ));
for( auto& rElement : m_aListeners )
-rElement.second.disposeAndClear( xEventSource );
+rElement.second.disposeAndClear( rGuard, xEventSource );
m_aListeners.clear();
}
@@ -58,25 +57,29 @@ void SAL_CALL CommandDispatch::dispatch( const util::URL&
/* URL */, const Seque
void SAL_CALL CommandDispatch::addStatusListener( const Reference<
frame::XStatusListener >& Control, const util::URL& URL )
{
-tListenerMap::iterator aIt( m_aListeners.find( URL.Complete ));
-if( aIt == m_aListeners.end())
{
-aIt = m_aListeners.emplace(
-std::piecewise_construct,
-std::forward_as_tuple(URL.Complete),
-std::forward_as_tuple( m_aMutex )).first;
-}
-assert( aIt != m_aListeners.end());
+std::unique_lock g(m_aMutex);
+tListenerMap::iterator aIt( m_aListeners.find( URL.Complete ));
+if( aIt == m_aListeners.end())
+{
+aIt = m_aListeners.emplace(
+std::piecewise_construct,
+std::forward_as_tuple(URL.Complete),
+std::forward_as_tuple()).first;
+}
+assert( aIt != m_aListeners.end());
-aIt->second.addInterface( Control );
+aIt->second.addInterface( g, Control );
+}
fireStatusEvent( URL.Complete, Control );
}
void SAL_CALL CommandDispatch::removeStatusListener( const Reference<
frame::XStatusListener >& Control, const util::URL& URL )
{
+std::unique_lock g(m_aMutex);
tListenerMap::iterator aIt( m_aListeners.find( URL.Complete ));
if( aIt != m_aListeners.end())
-(*aIt).second.removeInterface( Control );
+(*aIt).second.removeInterface( g, Control );
}
// XModifyListener
@@ -127,19 +130,8 @@ void CommandDispatch::fireStatusEventForURL(
tListenerMap::iterator aIt( m_aListeners.find( aURL.Complete ));
if( aIt != m_aListeners.end())
{
-::comphelper::OInterfaceIteratorHelper3 aIntfIt( aIt->second );
-
-while( aIntfIt.hasMoreElements())
-{
-try
-{
-aIntfIt.next()->statusChanged( aEventToSend );
-}
-catch( const uno::Exception & )
-{
-DBG_UNHANDLED_EXCEPTION("chart2");
-}
-}
+std::unique_lock g(m_aMutex);
+aIt->second.notifyEach(g,
::frame::XStatusListener::statusChanged, aEventToSend);
}
}
}
diff --git a/chart2/source/controller/main/CommandDispatch.hxx
b/chart2/source/controller/main/CommandDispatch.hxx
index
[Libreoffice-commits] core.git: filter/source
filter/source/config/cache/basecontainer.cxx | 131 ++-
filter/source/config/cache/basecontainer.hxx | 14 +-
filter/source/config/cache/contenthandlerfactory.cxx |2
filter/source/config/cache/filterfactory.cxx | 18 +-
filter/source/config/cache/frameloaderfactory.cxx|2
filter/source/config/cache/typedetection.cxx | 79 +--
filter/source/config/cache/typedetection.hxx | 14 +-
7 files changed, 108 insertions(+), 152 deletions(-)
New commits:
commit c060e7851bd6238ad6f4bdf0997c958c561cf8cf
Author: Noel Grandin
AuthorDate: Tue Feb 21 13:59:13 2023 +0200
Commit: Noel Grandin
CommitDate: Wed Feb 22 07:50:16 2023 +
osl::Mutex->std::mutex in BaseContainer
Change-Id: I66fcebb897446a5839ebde03e8e0a91d75a5e57c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147402
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/filter/source/config/cache/basecontainer.cxx
b/filter/source/config/cache/basecontainer.cxx
index 0dee9d4ba25a..aa8ccd2d562a 100644
--- a/filter/source/config/cache/basecontainer.cxx
+++ b/filter/source/config/cache/basecontainer.cxx
@@ -33,7 +33,6 @@ namespace filter::config{
BaseContainer::BaseContainer()
: m_eType()
-, m_lListener (m_aMutex)
{
GetTheFilterCache().load(FilterCache::E_CONTAINS_STANDARD);
}
@@ -49,7 +48,7 @@ void BaseContainer::init(const OUString&
FilterCache::EItemType
eType )
{
// SAFE ->
-osl::MutexGuard aLock(m_aMutex);
+std::unique_lock aLock(m_aMutex);
m_sImplementationName = sImplementationName;
m_lServiceNames = lServiceNames ;
@@ -58,12 +57,9 @@ void BaseContainer::init(const OUString&
}
-void BaseContainer::impl_loadOnDemand()
+void BaseContainer::impl_loadOnDemand(std::unique_lock& /*rGuard*/)
{
#ifdef LOAD_IMPLICIT
-// SAFE ->
-osl::MutexGuard aLock(m_aMutex);
-
// A generic container needs all items of a set of our cache!
// Of course it can block for a while, till the cache is really filled.
// Note: don't load all sets supported by the cache here!
@@ -89,33 +85,26 @@ void BaseContainer::impl_loadOnDemand()
}
GetTheFilterCache().load(eRequiredState);
-// <- SAFE
#endif
}
-void BaseContainer::impl_initFlushMode()
+void BaseContainer::impl_initFlushMode(std::unique_lock&
/*rGuard*/)
{
-// SAFE ->
-osl::MutexGuard aLock(m_aMutex);
if (!m_pFlushCache)
m_pFlushCache = GetTheFilterCache().clone();
if (!m_pFlushCache)
throw css::uno::RuntimeException( "Can not create write copy of
internal used cache on demand.",
static_cast< OWeakObject* >(this));
-// <- SAFE
}
-FilterCache* BaseContainer::impl_getWorkingCache() const
+FilterCache* BaseContainer::impl_getWorkingCache(std::unique_lock&
/*rGuard*/) const
{
-// SAFE ->
-osl::MutexGuard aLock(m_aMutex);
if (m_pFlushCache)
return m_pFlushCache.get();
else
return ();
-// <- SAFE
}
@@ -154,15 +143,15 @@ void SAL_CALL BaseContainer::insertByName(const OUString&
sItem ,
throw css::lang::IllegalArgumentException(ex.Message, static_cast<
css::container::XNameContainer* >(this), 2);
}
-impl_loadOnDemand();
-
// SAFE -> --
-osl::MutexGuard aLock(m_aMutex);
+std::unique_lock aLock(m_aMutex);
+
+impl_loadOnDemand(aLock);
// create write copy of used cache on demand ...
-impl_initFlushMode();
+impl_initFlushMode(aLock);
-FilterCache* pCache = impl_getWorkingCache();
+FilterCache* pCache = impl_getWorkingCache(aLock);
if (pCache->hasItem(m_eType, sItem))
throw css::container::ElementExistException(OUString(), static_cast<
css::container::XNameContainer* >(this));
pCache->setItem(m_eType, sItem, aItem);
@@ -172,15 +161,15 @@ void SAL_CALL BaseContainer::insertByName(const OUString&
sItem ,
void SAL_CALL BaseContainer::removeByName(const OUString& sItem)
{
-impl_loadOnDemand();
-
// SAFE -> --
-osl::MutexGuard aLock(m_aMutex);
+std::unique_lock aLock(m_aMutex);
+
+impl_loadOnDemand(aLock);
// create write copy of used cache on demand ...
-impl_initFlushMode();
+impl_initFlushMode(aLock);
-FilterCache* pCache = impl_getWorkingCache();
+FilterCache* pCache = impl_getWorkingCache(aLock);
pCache->removeItem(m_eType, sItem); // throw exceptions automatically
// <- SAFE --
}
@@ -204,15 +193,15 @@ void SAL_CALL BaseContainer::replaceByName(const
OUString& sItem ,
throw css::lang::IllegalArgumentException(ex.Message, static_cast<
css::container::XNameContainer* >(this), 2);
}
-impl_loadOnDemand();
-
// SAFE -> --
-
[Libreoffice-bugs] [Bug 153780] Draw has problems with displaying cropped images and SVGs
https://bugs.documentfoundation.org/show_bug.cgi?id=153780 --- Comment #1 from 12345qwertyman12...@gmail.com --- Created attachment 185524 --> https://bugs.documentfoundation.org/attachment.cgi?id=185524=edit file to test -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153780] New: Draw has problems with displaying cropped images and SVGs
https://bugs.documentfoundation.org/show_bug.cgi?id=153780 Bug ID: 153780 Summary: Draw has problems with displaying cropped images and SVGs Product: LibreOffice Version: 7.5.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 12345qwertyman12...@gmail.com Description: I have an SVG that doesnt crop correctly Steps to Reproduce: 1. open "Pranshu Tanwar - CoSci ... " in libreoffice and firefox. 2. goto page 6 and look at the svg glitch Actual Results: SVG doesnt crop on Libreoffice Expected Results: SVG should crop Reproducible: Always User Profile Reset: No Additional Info: Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: 50(Build:3) CPU threads: 12; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-GB (en_GB.UTF-8); UI: en-GB 7.5.0-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: chart2/source
chart2/source/inc/ErrorBar.hxx |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
New commits:
commit cc0654cab158b73124cb9e079753482693f0bd5a
Author: Noel Grandin
AuthorDate: Tue Feb 21 14:02:31 2023 +0200
Commit: Noel Grandin
CommitDate: Wed Feb 22 07:42:23 2023 +
BaseMutex is unused in ErrorBar
Change-Id: I5e0890fcefedeaef4a8276c187d1604f8f96d23b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147414
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/chart2/source/inc/ErrorBar.hxx b/chart2/source/inc/ErrorBar.hxx
index bf31ed364d72..ed6d646be5a0 100644
--- a/chart2/source/inc/ErrorBar.hxx
+++ b/chart2/source/inc/ErrorBar.hxx
@@ -18,7 +18,6 @@
*/
#pragma once
-#include
#include "charttoolsdllapi.hxx"
#include
@@ -57,9 +56,7 @@ typedef ::cppu::WeakImplHelper<
ErrorBar_Base;
}
-class ErrorBar final :
-public cppu::BaseMutex,
-public impl::ErrorBar_Base
+class ErrorBar final : public impl::ErrorBar_Base
{
private:
OUString maDashName;
[Libreoffice-bugs] [Bug 127524] TAB STOPS: Tab stop gets lost in a line that starts with "- ", "* " or "+ " after pressing return
https://bugs.documentfoundation.org/show_bug.cgi?id=127524 Dieter changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Dieter --- WORKSFORME with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded Tested with Default Paragraph Style -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107834] [META] Paragraph tab stops bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107834 Bug 107834 depends on bug 127524, which changed state. Bug 127524 Summary: TAB STOPS: Tab stop gets lost in a line that starts with "- ", "* " or "+ " after pressing return https://bugs.documentfoundation.org/show_bug.cgi?id=127524 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sc/source
sc/source/ui/Accessibility/AccessibleContextBase.cxx | 34 ---
sc/source/ui/inc/AccessibleContextBase.hxx | 28 +--
2 files changed, 2 insertions(+), 60 deletions(-)
New commits:
commit d1c3a54c03764b87048e1ebff758b20be132378f
Author: Noel Grandin
AuthorDate: Tue Feb 21 15:25:24 2023 +0200
Commit: Noel Grandin
CommitDate: Wed Feb 22 07:28:53 2023 +
simplify ScAccessibleContextBase
no need to use two different UNO base helper classes here
Change-Id: I3aa89bf64fbd1b1d12f6c2a125ae36483899e82c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147417
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sc/source/ui/Accessibility/AccessibleContextBase.cxx
b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
index 0fc5b42a1ffe..f66f51077ca8 100644
--- a/sc/source/ui/Accessibility/AccessibleContextBase.cxx
+++ b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
@@ -95,29 +95,8 @@ void SAL_CALL ScAccessibleContextBase::disposing()
xBroadcaster->removeAccessibleEventListener(this);
mxParent = nullptr;
}
-
-ScAccessibleContextBaseWeakImpl::disposing();
}
-//= XInterface =
-
-uno::Any SAL_CALL ScAccessibleContextBase::queryInterface( uno::Type const &
rType )
-{
-uno::Any aAny (ScAccessibleContextBaseWeakImpl::queryInterface(rType));
-return aAny.hasValue() ? aAny :
ScAccessibleContextBaseImplEvent::queryInterface(rType);
-}
-
-void SAL_CALL ScAccessibleContextBase::acquire()
-noexcept
-{
-ScAccessibleContextBaseWeakImpl::acquire();
-}
-
-void SAL_CALL ScAccessibleContextBase::release()
-noexcept
-{
-ScAccessibleContextBaseWeakImpl::release();
-}
//= SfxListener =
@@ -432,19 +411,6 @@ uno::Sequence< OUString> SAL_CALL
"com.sun.star.accessibility.AccessibleContext"};
}
-//= XTypeProvider ===
-
-uno::Sequence< uno::Type > SAL_CALL ScAccessibleContextBase::getTypes()
-{
-return
comphelper::concatSequences(ScAccessibleContextBaseWeakImpl::getTypes(),
ScAccessibleContextBaseImplEvent::getTypes());
-}
-
-uno::Sequence SAL_CALL
-ScAccessibleContextBase::getImplementationId()
-{
-return css::uno::Sequence();
-}
-
//= internal
OUString
diff --git a/sc/source/ui/inc/AccessibleContextBase.hxx
b/sc/source/ui/inc/AccessibleContextBase.hxx
index 0df386d6edd5..b7276873487f 100644
--- a/sc/source/ui/inc/AccessibleContextBase.hxx
+++ b/sc/source/ui/inc/AccessibleContextBase.hxx
@@ -44,17 +44,13 @@ typedef cppu::WeakComponentImplHelper<
css::accessibility::XAccessibleComponent,
css::accessibility::XAccessibleContext,
css::accessibility::XAccessibleEventBroadcaster,
-css::lang::XServiceInfo
-> ScAccessibleContextBaseWeakImpl;
-
-typedef cppu::ImplHelper1<
+css::lang::XServiceInfo,
css::accessibility::XAccessibleEventListener
-> ScAccessibleContextBaseImplEvent;
+> ScAccessibleContextBaseWeakImpl;
class ScAccessibleContextBase
: public cppu::BaseMutex,
public ScAccessibleContextBaseWeakImpl,
-public ScAccessibleContextBaseImplEvent,
public SfxListener
{
public:
@@ -79,15 +75,6 @@ public:
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
-///= XInterface =
-
-virtual css::uno::Any SAL_CALL queryInterface(
-css::uno::Type const & rType ) override;
-
-virtual void SAL_CALL acquire() noexcept override;
-
-virtual void SAL_CALL release() noexcept override;
-
///= XAccessible
=
/// Return the XAccessibleContext.
@@ -200,17 +187,6 @@ public:
virtual css::uno::Sequence< OUString> SAL_CALL
getSupportedServiceNames() override;
-///= XTypeProvider
===
-
- /// returns the possible types
-virtual css::uno::Sequence< css::uno::Type > SAL_CALL
-getTypes() override;
-
-/** Returns an implementation id.
-*/
-virtual css::uno::Sequence SAL_CALL
-getImplementationId() override;
-
protected:
/// Return this object's description.
///
[Libreoffice-bugs] [Bug 133504] Fileopen: DOC frame with wrap is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=133504 --- Comment #4 from Dieter --- Still present in Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140163] "Clear direct formatting" deletes column breaks, but the effect is not shown until saved and reopened
https://bugs.documentfoundation.org/show_bug.cgi?id=140163 --- Comment #3 from Dieter --- Still present in Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140024] "replace custom styles" option in AutoCorrect needs critical review
https://bugs.documentfoundation.org/show_bug.cgi?id=140024 Dieter changed: What|Removed |Added CC||dgp-m...@gmx.de --- Comment #4 from Dieter --- (In reply to sdc.blanco from comment #0) > 2. Paragraph Style with four-sided border was NOT converted. Can't confirm with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded I've created a new PS, based on Numbering5 and only added four-sided border. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 51195] : LibreOffice can not save fontwork as docx
https://bugs.documentfoundation.org/show_bug.cgi?id=51195 Commit Notification changed: What|Removed |Added Whiteboard|BSA target:6.4.0|BSA target:6.4.0 ||target:7.6.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: oox/inc oox/qa oox/source
oox/inc/drawingml/fontworkhelpers.hxx | 52 +
oox/qa/unit/data/tdf51195_Fontwork_DirectColor.odt |binary
oox/qa/unit/data/tdf51195_Fontwork_Distance.odt|binary
oox/qa/unit/data/tdf51195_Fontwork_ThemeColor.odt |binary
oox/qa/unit/export.cxx | 105 +++
oox/source/drawingml/fontworkhelpers.cxx | 609 +
oox/source/export/drawingml.cxx| 36 +
7 files changed, 801 insertions(+), 1 deletion(-)
New commits:
commit b94336ac3d29180504e4bd7ada4d29ed5b6d3fda
Author: Regina Henschel
AuthorDate: Tue Feb 14 01:36:50 2023 +0100
Commit: Miklos Vajna
CommitDate: Wed Feb 22 07:12:19 2023 +
tdf#51195 Improve DML export of Fontwork shapes for docx
Fontwork in Writer has fill and outline as shape properties. The 'abc
transform' in Word uses character properties. Output of character
properties happens in DocxAttributeOutput methods in LO.
The patch modifies the character properties of the Fontwork shape,
in particular the contents of the CharInteropGrabBag, so that
DocxAttributeOutput produces a reasonably suitable markup.
Change-Id: Ic9285d9a4d6dc21cd256e448ace058f1026a2780
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146964
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/oox/inc/drawingml/fontworkhelpers.hxx
b/oox/inc/drawingml/fontworkhelpers.hxx
index f1861f266bde..7d8d0a9692dd 100644
--- a/oox/inc/drawingml/fontworkhelpers.hxx
+++ b/oox/inc/drawingml/fontworkhelpers.hxx
@@ -19,6 +19,7 @@
#pragma once
+#include
#include
#include
#include
@@ -26,7 +27,11 @@
#include "customshapeproperties.hxx"
#include
+#include
+#include
+#include
#include
+#include
namespace FontworkHelpers
{
@@ -46,5 +51,52 @@ void putCustomShapeIntoTextPathMode(
If eShapeType is not a Fontwork shape type or the special type is not yet
implemented,
it returns an empty string.*/
OString GetVMLFontworkShapetypeMarkup(const MSO_SPT eShapeType);
+
+/** Collects the properties "CharColor", "CharLumMod", "CharLumOff",
"CharColorTheme",
+"CharColorThemeReference" and "CharTransparence" from the first non-empty
run in rXText and puts
+them into rCharPropVec.*/
+void collectCharColorProps(const css::uno::Reference& rXText,
+ std::vector&
rCharPropVec);
+
+/** Applies all properties in rTextPropVec excluding "CharInteropGrabBag" to
all non-empty runs in
+rXText.*/
+void applyPropsToRuns(const std::vector&
rTextPropVec,
+ css::uno::Reference& rXText);
+
+/** Generates the properties "CharColor", "CharLumMod", "CharLumOff",
"CharColorTheme",
+"CharColorThemeReference" and "CharTransparence" from the shape properties
"FillColor",
+"FillColorLumMod, "FillColorLumOff", "FillColorTheme",
"FillColorThemeReference" and
+"FillTransparence" and puts them into rCharPropVec.*/
+void createCharFillPropsFromShape(const
css::uno::Reference& rXPropSet,
+ std::vector&
rCharPropVec);
+
+/** Creates the properties "CharTextFillTextEffect",
"CharTextOutlineTextEffect", "CharThemeColor",
+"CharThemeColorShade" or "CharThemeColorTint", and
"CharThemeOriginalColor" from the FillFoo and
+LineBar properties of the shape and puts them into rUpdatePropVec.*/
+void createCharInteropGrabBagUpdatesFromShapeProps(
+const css::uno::Reference& rXPropSet,
+std::vector& rUpdatePropVec);
+
+/** Puts all properties in rUpdatePropVec into the "CharInteropGrabBag" of all
non-empty runs in rXText.
+Existing properties are overwritten.*/
+void applyUpdatesToCharInteropGrabBag(const
std::vector& rUpdatePropVec,
+ css::uno::Reference&
rXText);
+
+// ToDo: This is essentially the same as contained in methode
DrawingML::WriteOutline. Change it
+// there to use this method too, perhaps move this method to a common location.
+/** Uses LineDash and LineCap to detect, whether the dashing comes from a
prstDash in MS Office.
+If prstDash is detected, the method puts the corresponding string for
markup into rsPrstDash
+and returns true.
+If no prstDash is detected, the method leaves rsPrstDash unchanged and
returns false. */
+bool createPrstDashFromLineDash(const css::drawing::LineDash& rLineDash,
+const css::drawing::LineCap& rLineCap,
OUString& rsPrstDash);
+
+/** Returns true if a theme color with other type than
model::ThemeColorType::Unknown was found.
+The theme color is then in aThemeColor.
+Returns false otherwise. aThemeColor is then unchanged or its type is
+model::ThemeColorType::Unknown */
+bool getThemeColorFromShape(const OUString& rPropertyName,
+const
css::uno::Reference& xPropertySet,
+model::ThemeColor& aThemeColor);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab
[Libreoffice-bugs] [Bug 140024] "replace custom styles" option in AutoCorrect needs critical review
https://bugs.documentfoundation.org/show_bug.cgi?id=140024 Dieter changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3424 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153424] Autocorrect for "Replace Custom Styles" does not work when a custom style is applied to an empty paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=153424 Dieter changed: What|Removed |Added Blocks||103341 Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0024 --- Comment #1 from Dieter --- I confirm it with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded I also confirm, that it works with text in paragraphs Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 Dieter changed: What|Removed |Added Depends on||153424 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153424 [Bug 153424] Autocorrect for "Replace Custom Styles" does not work when a custom style is applied to an empty paragraph -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/htmlexport/htmlexport.cxx | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
New commits:
commit 63784053ccd321c8f3fc7fe60f4e50fda597f553
Author: Miklos Vajna
AuthorDate: Tue Feb 21 20:23:23 2023 +0100
Commit: Miklos Vajna
CommitDate: Wed Feb 22 07:10:28 2023 +
CppunitTest_sw_htmlexport: remove magic SkipImages name handling
Now we call setFilterOptions("SkipImages") everywhere explicitly, so
preTest() can be simplified.
Change-Id: I4c01f93bae2d9a4a31f3fff82911df4c683b862b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147422
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx
b/sw/qa/extras/htmlexport/htmlexport.cxx
index 9e337d282fdc..443ae8443ba3 100644
--- a/sw/qa/extras/htmlexport/htmlexport.cxx
+++ b/sw/qa/extras/htmlexport/htmlexport.cxx
@@ -214,9 +214,7 @@ private:
virtual std::unique_ptr preTest(const char* filename) override
{
-if (getTestName().indexOf("SkipImages") != -1)
-setFilterOptions("SkipImages");
-else if (getTestName().indexOf("EmbedImages") != -1)
+if (getTestName().indexOf("EmbedImages") != -1)
setFilterOptions("EmbedImages");
else if (getTestName().indexOf("XHTML") != -1)
setFilterOptions("XHTML");
@@ -453,8 +451,12 @@ CPPUNIT_TEST_FIXTURE(HtmlExportTest,
testSkipImagesEmbedded)
assertXPath(pDoc, "//span/table", 1);
}
-DECLARE_HTMLEXPORT_TEST(testSkipImagesEmbeddedDocument,
"skipimage-embedded-document.docx")
+CPPUNIT_TEST_FIXTURE(HtmlExportTest, testSkipImagesEmbeddedDocument)
{
+createSwDoc("skipimage-embedded-document.docx");
+setFilterOptions("SkipImages");
+save(OUString::createFromAscii(mpFilter));
+
// Similar to testSkipImagesEmbedded, but with an embedded Writer object,
// not a Calc one, and this time OOXML, not WW8.
htmlDocUniquePtr pDoc = parseHtml(maTempFile);
[Libreoffice-bugs] [Bug 76253] Hyperlink text is not wrapped when cell is set text-auto-wrap
https://bugs.documentfoundation.org/show_bug.cgi?id=76253 --- Comment #9 from torikk --- At one discussion forum, it was stated that Connexx TVs were made by Furrion. So far we have not been able to verify that comment. https://www.techy2tech.com/who-makes-connex-tv/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153384] LibreOffice Writer - Resets numbering footnotes to default automatically
https://bugs.documentfoundation.org/show_bug.cgi?id=153384 Dieter changed: What|Removed |Added Whiteboard| QA:needsComment| CC||dgp-m...@gmx.de Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #1 from Dieter --- I can't confirm with Version: 7.5.0.3 (X86_64) / LibreOffice Community Build ID: c21113d003cd3efa8c53188764377a8272d9d6de CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded Does it also happen in SafeMode (Help => Restart in SafeMode)? => NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 149506] Slow start-up and opening of files since 7.3 release
https://bugs.documentfoundation.org/show_bug.cgi?id=149506 --- Comment #28 from Buovjaga --- (In reply to bunkem from comment #27) > (In reply to Buovjaga from comment #26) > > (In reply to bunkem from comment #25) > > > Yes. It was slower. > > > > > > Rough estimate for comparison. > > > Normal start up v7.2 2-3 sec; file open 2 sec > > > Slow start up v7.3 9-10 sec; file open 5 sec. > > > > If you mean to say that startup was equally slow after 'git checkout > > 846a5c424a6c16dc07eefb6827b362efed5075b1' and 'git checkout HEAD^', then > > your bibisect result is not valid. > > Sorry about that. Last week was my first time using git. While I read the > instruction in the link and also read a good portion of the git pdf, I still > can't visualize what I'm doing. > > Perhaps the other individual can give this a try and I don't seem to be able > to get it right. If you want to do it in a screensharing call with me, you can email me and we can schedule it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153350] Allow user to change bibliography citation number structure
https://bugs.documentfoundation.org/show_bug.cgi?id=153350 Dieter changed: What|Removed |Added Blocks||101258 CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101258 [Bug 101258] [META] Bibliography bugs and enhancements -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153350] Allow user to change bibliography citation number structure
https://bugs.documentfoundation.org/show_bug.cgi?id=153350 Dieter changed: What|Removed |Added Blocks||101258 CC||dgp-m...@gmx.de, ||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=101258 [Bug 101258] [META] Bibliography bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101258] [META] Bibliography bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101258 Dieter changed: What|Removed |Added Depends on||153350 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153350 [Bug 153350] Allow user to change bibliography citation number structure -- You are receiving this mail because: You are the assignee for the bug.
.gitreview added to dictionaries git submodule
https://gerrit.libreoffice.org/c/dictionaries/+/138340
("Add .gitreview used by git-review tool")
added a .gitreview to the dictionaries git repo.
As Eike pointed out in the Gerrit change, this means that people who
already have a local .gitreview in the submodule need to (re)move that
before updating the submodule:
Note this when checking out on an existing tree with ./g pull -r where
.gitreview exists already results in
error: The following untracked working tree files would be overwritten by
checkout:
.gitreview
Please move or remove them before you switch branches.
Aborting
fatal: Unable to checkout 'bcf7f049315dee2001cc2f7c7eabfbcb0b8ef21a' in
submodule path 'dictionaries'
Please announce on the dev list, the usual generated by gitreview content is
identical, but in case someone did modifications the file should be moved out
of the way, otherwise must be deleted.
Sorry for any inconvenience this may have caused.
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/doctempl.cxx | 34 ++
1 file changed, 18 insertions(+), 16 deletions(-)
New commits:
commit 3950df2b87f4657f196d56828a782e66c86ff790
Author: Noel Grandin
AuthorDate: Mon Feb 20 14:43:59 2023 +0200
Commit: Noel Grandin
CommitDate: Wed Feb 22 06:24:33 2023 +
osl::Mutex->std::mutex in SfxDocTemplate_Impl
Change-Id: Iaf1530a34841ca1140599cea6d941aa2200ade66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147326
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/doc/doctempl.cxx b/sfx2/source/doc/doctempl.cxx
index b585e8fef58f..d1aa03259983 100644
--- a/sfx2/source/doc/doctempl.cxx
+++ b/sfx2/source/doc/doctempl.cxx
@@ -19,10 +19,10 @@
#include
+#include
#include
#include
-#include
#include
#include
@@ -174,7 +174,7 @@ class SfxDocTemplate_Impl : public SvRefBase
uno::Reference< XPersist > mxInfo;
uno::Reference< XDocumentTemplates > mxTemplates;
-::osl::MutexmaMutex;
+std::mutex maMutex;
OUStringmaRootURL;
OUStringmaStandardGroup;
std::vector> maRegions;
@@ -197,9 +197,10 @@ public:
voidDecrementLock();
boolConstruct( );
-voidCreateFromHierarchy( Content );
+voidCreateFromHierarchy( std::unique_lock&
rGuard, Content );
voidReInitFromComponent();
-voidAddRegion( const OUString& rTitle,
+voidAddRegion( std::unique_lock& rGuard,
+ const OUString& rTitle,
Content& rContent );
voidRescan();
@@ -1435,14 +1436,14 @@ SfxDocTemplate_Impl::~SfxDocTemplate_Impl()
void SfxDocTemplate_Impl::IncrementLock()
{
-::osl::MutexGuard aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
mnLockCounter++;
}
void SfxDocTemplate_Impl::DecrementLock()
{
-::osl::MutexGuard aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
if ( mnLockCounter )
mnLockCounter--;
}
@@ -1481,7 +1482,8 @@ void SfxDocTemplate_Impl::DeleteRegion( size_t nIndex )
/* AddRegion adds a Region to the RegionList
*/
-void SfxDocTemplate_Impl::AddRegion( const OUString& rTitle,
+void SfxDocTemplate_Impl::AddRegion( std::unique_lock& /*rGuard*/,
+ const OUString& rTitle,
Content& rContent )
{
auto pRegion = std::make_unique( this, rTitle );
@@ -1517,7 +1519,7 @@ void SfxDocTemplate_Impl::AddRegion( const OUString&
rTitle,
}
-void SfxDocTemplate_Impl::CreateFromHierarchy( Content )
+void SfxDocTemplate_Impl::CreateFromHierarchy( std::unique_lock&
rGuard, Content )
{
uno::Reference< XResultSet > xResultSet;
Sequence< OUString > aProps { TITLE };
@@ -1551,7 +1553,7 @@ void SfxDocTemplate_Impl::CreateFromHierarchy( Content
)
const OUString aId =
xContentAccess->queryContentIdentifierString();
Content aContent( aId, aCmdEnv,
comphelper::getProcessComponentContext() );
-AddRegion( xRow->getString( 1 ), aContent );
+AddRegion( rGuard, xRow->getString( 1 ), aContent );
}
}
catch ( Exception& ) {}
@@ -1560,7 +1562,7 @@ void SfxDocTemplate_Impl::CreateFromHierarchy( Content
)
bool SfxDocTemplate_Impl::Construct( )
{
-::osl::MutexGuard aGuard( maMutex );
+std::unique_lock aGuard( maMutex );
if ( mbConstructed )
return true;
@@ -1587,7 +1589,7 @@ bool SfxDocTemplate_Impl::Construct( )
maStandardGroup = DocTemplLocaleHelper::GetStandardGroupString();
Content aTemplRoot( aRootContent, aCmdEnv, xContext );
-CreateFromHierarchy( aTemplRoot );
+CreateFromHierarchy( aGuard, aTemplRoot );
return true;
}
@@ -1602,15 +1604,14 @@ void SfxDocTemplate_Impl::ReInitFromComponent()
uno::Reference < XCommandEnvironment > aCmdEnv;
Content aTemplRoot( aRootContent, aCmdEnv,
comphelper::getProcessComponentContext() );
Clear();
-CreateFromHierarchy( aTemplRoot );
+std::unique_lock aGuard(maMutex);
+CreateFromHierarchy( aGuard, aTemplRoot );
}
}
bool SfxDocTemplate_Impl::InsertRegion( std::unique_ptr pNew,
size_t nPos )
{
-::osl::MutexGuard aGuard( maMutex );
-
// return false (not inserted) if the entry already exists
for (auto const& pRegion : maRegions)
if ( pRegion->Compare( pNew.get() ) == 0 )
@@ -1649,7 +1650,8 @@ void SfxDocTemplate_Impl::Rescan()
uno::Reference < XCommandEnvironment > aCmdEnv;
Content aTemplRoot( aRootContent, aCmdEnv,
comphelper::getProcessComponentContext() );
-CreateFromHierarchy( aTemplRoot );
+std::unique_lock aGuard(maMutex);
+CreateFromHierarchy( aGuard, aTemplRoot );
[Libreoffice-commits] core.git: xmlhelp/source
xmlhelp/source/cxxhelp/provider/resultsetbase.cxx | 58 +++---
xmlhelp/source/cxxhelp/provider/resultsetbase.hxx | 11 +---
2 files changed, 26 insertions(+), 43 deletions(-)
New commits:
commit e171af99c0ed9c0e680c9fb95340f6d8535978e9
Author: Noel Grandin
AuthorDate: Tue Feb 21 15:33:51 2023 +0200
Commit: Noel Grandin
CommitDate: Wed Feb 22 06:17:39 2023 +
osl::Mutex->std::mutex in ResultSetBase
Change-Id: I6f0afa46ad84782c3f7219bcb1b28d5627063bcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147418
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
b/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
index 2f64acaac3c1..58d8e70c5b49 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
+++ b/xmlhelp/source/cxxhelp/provider/resultsetbase.cxx
@@ -85,13 +85,8 @@ void SAL_CALL
ResultSetBase::addEventListener(
const uno::Reference< lang::XEventListener >& Listener )
{
-osl::MutexGuard aGuard( m_aMutex );
-
-if ( ! m_pDisposeEventListeners )
-m_pDisposeEventListeners.reset(
-new comphelper::OInterfaceContainerHelper3(
m_aMutex ));
-
-m_pDisposeEventListeners->addInterface( Listener );
+std::unique_lock aGuard( m_aMutex );
+m_aDisposeEventListeners.addInterface( aGuard, Listener );
}
@@ -99,32 +94,30 @@ void SAL_CALL
ResultSetBase::removeEventListener(
const uno::Reference< lang::XEventListener >& Listener )
{
-osl::MutexGuard aGuard( m_aMutex );
-
-if ( m_pDisposeEventListeners )
-m_pDisposeEventListeners->removeInterface( Listener );
+std::unique_lock aGuard( m_aMutex );
+m_aDisposeEventListeners.removeInterface( aGuard, Listener );
}
void SAL_CALL
ResultSetBase::dispose()
{
-osl::MutexGuard aGuard( m_aMutex );
+std::unique_lock aGuard( m_aMutex );
lang::EventObject aEvt;
aEvt.Source = static_cast< lang::XComponent * >( this );
-if ( m_pDisposeEventListeners && m_pDisposeEventListeners->getLength() )
+if ( m_aDisposeEventListeners.getLength(aGuard) )
{
-m_pDisposeEventListeners->disposeAndClear( aEvt );
+m_aDisposeEventListeners.disposeAndClear( aGuard, aEvt );
}
-if( m_pRowCountListeners && m_pRowCountListeners->getLength() )
+if( m_aRowCountListeners.getLength(aGuard) )
{
-m_pRowCountListeners->disposeAndClear( aEvt );
+m_aRowCountListeners.disposeAndClear( aGuard, aEvt );
}
-if( m_pIsFinalListeners && m_pIsFinalListeners->getLength() )
+if( m_aIsFinalListeners.getLength(aGuard) )
{
-m_pIsFinalListeners->disposeAndClear( aEvt );
+m_aIsFinalListeners.disposeAndClear( aGuard, aEvt );
}
}
@@ -438,20 +431,13 @@ void SAL_CALL ResultSetBase::addPropertyChangeListener(
{
if( aPropertyName == "IsRowCountFinal" )
{
-osl::MutexGuard aGuard( m_aMutex );
-if ( ! m_pIsFinalListeners )
-m_pIsFinalListeners.reset(
-new
comphelper::OInterfaceContainerHelper3(
m_aMutex ));
-
-m_pIsFinalListeners->addInterface( xListener );
+std::unique_lock aGuard( m_aMutex );
+m_aIsFinalListeners.addInterface( aGuard, xListener );
}
else if ( aPropertyName == "RowCount" )
{
-osl::MutexGuard aGuard( m_aMutex );
-if ( ! m_pRowCountListeners )
-m_pRowCountListeners.reset(
-new
comphelper::OInterfaceContainerHelper3(
m_aMutex ));
-m_pRowCountListeners->addInterface( xListener );
+std::unique_lock aGuard( m_aMutex );
+m_aRowCountListeners.addInterface( aGuard, xListener );
}
else
throw beans::UnknownPropertyException(aPropertyName);
@@ -462,17 +448,15 @@ void SAL_CALL ResultSetBase::removePropertyChangeListener(
const OUString& aPropertyName,
const uno::Reference< beans::XPropertyChangeListener >& aListener )
{
-if( aPropertyName == "IsRowCountFinal" &&
-m_pIsFinalListeners )
+if( aPropertyName == "IsRowCountFinal" )
{
-osl::MutexGuard aGuard( m_aMutex );
-m_pIsFinalListeners->removeInterface( aListener );
+std::unique_lock aGuard( m_aMutex );
+m_aIsFinalListeners.removeInterface( aGuard, aListener );
}
-else if ( aPropertyName == "RowCount" &&
- m_pRowCountListeners )
+else if ( aPropertyName == "RowCount" )
{
-osl::MutexGuard aGuard( m_aMutex );
-m_pRowCountListeners->removeInterface( aListener );
+std::unique_lock aGuard( m_aMutex );
+m_aRowCountListeners.removeInterface( aGuard, aListener );
}
else
throw beans::UnknownPropertyException(aPropertyName);
diff --git a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
index 00581142669e..4327d3e97201 100644
--- a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx
+++
[Libreoffice-bugs] [Bug 142783] SELECTING Date Field dropdown causes 'When losing focus' event.
https://bugs.documentfoundation.org/show_bug.cgi?id=142783 --- Comment #14 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/73d02cde39d964aae9beebfc4dca5891dc5814f0 tdf#142783 consider the Calendar Edit and DropDown as one compound control It will be available in 7.5.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142783] SELECTING Date Field dropdown causes 'When losing focus' event.
https://bugs.documentfoundation.org/show_bug.cgi?id=142783 Commit Notification changed: What|Removed |Added Whiteboard|target:7.6.0|target:7.6.0 target:7.5.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-5' - include/vcl vcl/source
include/vcl/ctrl.hxx |1 +
include/vcl/toolkit/calendar.hxx |1 +
vcl/source/control/calendar.cxx |7 +++
vcl/source/control/ctrl.cxx |7 ++-
4 files changed, 15 insertions(+), 1 deletion(-)
New commits:
commit 73d02cde39d964aae9beebfc4dca5891dc5814f0
Author: Caolán McNamara
AuthorDate: Tue Feb 21 13:40:43 2023 +
Commit: Adolfo Jayme Barrientos
CommitDate: Wed Feb 22 06:05:49 2023 +
tdf#142783 consider the Calendar Edit and DropDown as one compound control
for the purpose of notification of loss of focus from the control
Change-Id: I9191b413978549c6f8e1775dc96a696059150e4e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147367
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/include/vcl/ctrl.hxx b/include/vcl/ctrl.hxx
index 17c40ae66067..6300e27a747a 100644
--- a/include/vcl/ctrl.hxx
+++ b/include/vcl/ctrl.hxx
@@ -151,6 +151,7 @@ protected:
virtual void ApplySettings(vcl::RenderContext& rRenderContext) override;
+virtual bool FocusWindowBelongsToControl(const vcl::Window* pFocusWin)
const;
public:
SAL_DLLPRIVATE void ImplClearLayoutData() const;
/** draws a frame around the give rectangle, onto the given device
diff --git a/include/vcl/toolkit/calendar.hxx b/include/vcl/toolkit/calendar.hxx
index a1a1cd90105a..9652bb44640f 100644
--- a/include/vcl/toolkit/calendar.hxx
+++ b/include/vcl/toolkit/calendar.hxx
@@ -93,6 +93,7 @@ public:
private:
virtual voidStateChanged( StateChangedType nStateChange ) override;
+virtual boolFocusWindowBelongsToControl(const vcl::Window* pFocusWin)
const override;
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/control/calendar.cxx b/vcl/source/control/calendar.cxx
index 421e159eee81..5f437ff0300e 100644
--- a/vcl/source/control/calendar.cxx
+++ b/vcl/source/control/calendar.cxx
@@ -1724,4 +1724,11 @@ void CalendarField::StateChanged( StateChangedType
nStateChange )
}
}
+// tdf#142783 consider the Edit and its DropDown as one compound control for
the purpose of
+// notification of loss of focus from the control
+bool CalendarField::FocusWindowBelongsToControl(const vcl::Window* pFocusWin)
const
+{
+return DateField::FocusWindowBelongsToControl(pFocusWin) || (mpFloatWin &&
mpFloatWin->ImplIsWindowOrChild(pFocusWin));
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/control/ctrl.cxx b/vcl/source/control/ctrl.cxx
index 09fb464e662e..6d6843b9c6e4 100644
--- a/vcl/source/control/ctrl.cxx
+++ b/vcl/source/control/ctrl.cxx
@@ -223,6 +223,11 @@ OUString Control::GetDisplayText() const
return mxLayoutData ? mxLayoutData->m_aDisplayText : GetText();
}
+bool Control::FocusWindowBelongsToControl(const vcl::Window* pFocusWin) const
+{
+return ImplIsWindowOrChild(pFocusWin);
+}
+
bool Control::EventNotify( NotifyEvent& rNEvt )
{
if ( rNEvt.GetType() == NotifyEventType::GETFOCUS )
@@ -241,7 +246,7 @@ bool Control::EventNotify( NotifyEvent& rNEvt )
if ( rNEvt.GetType() == NotifyEventType::LOSEFOCUS )
{
vcl::Window* pFocusWin = Application::GetFocusWindow();
-if ( !pFocusWin || !ImplIsWindowOrChild( pFocusWin ) )
+if ( !pFocusWin || !FocusWindowBelongsToControl(pFocusWin) )
{
mbHasControlFocus = false;
CompatStateChanged( StateChangedType::ControlFocus );
[Libreoffice-bugs] [Bug 153430] loadComponentfromUrl shows "lock" error message if url contains a backslash
https://bugs.documentfoundation.org/show_bug.cgi?id=153430 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153450] Reading a RTF file, \trhdr Table row header not repeating on each page.
https://bugs.documentfoundation.org/show_bug.cgi?id=153450 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153442] Cannot set caption order for individual object types in AutoCaption
https://bugs.documentfoundation.org/show_bug.cgi?id=153442 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153446] Tabbed UI - Hidden button don't work when displayed then used
https://bugs.documentfoundation.org/show_bug.cgi?id=153446 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153443] Scrolling stutters in Writer as soon as a page is filled with characters
https://bugs.documentfoundation.org/show_bug.cgi?id=153443 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153448] Footer and header missing on first page
https://bugs.documentfoundation.org/show_bug.cgi?id=153448 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153649] New LibreOffice install in Windows 11 stuck in Safe Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153649 QA Administrators changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150140] Crash in: SfxApplication::GetSidebarTheme()
https://bugs.documentfoundation.org/show_bug.cgi?id=150140 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150140] Crash in: SfxApplication::GetSidebarTheme()
https://bugs.documentfoundation.org/show_bug.cgi?id=150140 --- Comment #3 from QA Administrators --- Dear milena.cnikolova, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153649] New LibreOffice install in Windows 11 stuck in Safe Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=153649 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150612] LibreOffice will not open except through the Windows Run command in Safe Mode
https://bugs.documentfoundation.org/show_bug.cgi?id=150612 --- Comment #3 from QA Administrators --- Dear Louiza Wise, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 150388] Example db fully obscures users doc db when Choosing Bibliography Database from Tools menu
https://bugs.documentfoundation.org/show_bug.cgi?id=150388 --- Comment #4 from QA Administrators --- Dear Tom Atkinson, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 141351] Selection switched from caption frame to embedded image when dragging frame inwards (shrinking) as character anchoring
https://bugs.documentfoundation.org/show_bug.cgi?id=141351 --- Comment #6 from QA Administrators --- Dear Telesto, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139918] Page Format Size set to A4 instead of Letter for US users
https://bugs.documentfoundation.org/show_bug.cgi?id=139918 --- Comment #17 from QA Administrators --- Dear Bob, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 58381] Unable to format Endnote page style to use multi-column layout
https://bugs.documentfoundation.org/show_bug.cgi?id=58381 --- Comment #10 from QA Administrators --- Dear gabriel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 35913] EDITING - vertical & horizontal flipping text / image / Object is inconsistent and wrong in Impress, Writer, Calc, Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=35913 --- Comment #26 from QA Administrators --- Dear Bob Harvey, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122526] English text is present in the localized version of Calc context menu for columns
https://bugs.documentfoundation.org/show_bug.cgi?id=122526 --- Comment #5 from QA Administrators --- Dear Andy, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114783] Display size of document on a HDMI attached Monitor is more than twice the expected size
https://bugs.documentfoundation.org/show_bug.cgi?id=114783 --- Comment #12 from QA Administrators --- Dear Uwe Altmann, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153779] New: FILESAVE Calc takes 4 minutes to save a file
https://bugs.documentfoundation.org/show_bug.cgi?id=153779 Bug ID: 153779 Summary: FILESAVE Calc takes 4 minutes to save a file Product: LibreOffice Version: 7.5.0.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: christothemagnific...@aussiebroadband.com.au Description: I have a graphically rich 8.9 Mbyte file I run my home budget with. Saving the file after working on it takes roughly 4 minutes. Memory usage does not exceed 55% During the save process a process/thread runs one core at 100%, and bounces around which core that is. I frequently get a dialogue box saying Calc is not responding, do I wish to force a close. Imediately then "Saving as" to the back up location takes 20 seconds and the thread only runs on a single core; It doesn't bounce around cores. Varying document format does not change behaviour. Steps to Reproduce: 1. Save a large file EG: My budget spreadsheet of 8.9 MBytes 2. Saving then takes 4 minutes 3. Actual Results: Initial "Save" takes four minutes, subsequent "Save As" takes 20 seconds. Expected Results: Save in under a second, this is what Excel does on the same document. Reproducible: Always User Profile Reset: Yes Additional Info: This has been getting progressivly worse, I assume, as the file grows in size. This is across Linux Mint from 18.0 through to 21.1 including all kernel revisions and all Libreoffice builds, both Flatpak and repository. Fresh installs or upgrades made no difference. The save destination being an SSD, a 10,000 RPM raptor hard drive or USB stick makes no difference. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153526] No Numbering/New Line After Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=153526 --- Comment #10 from Justin L --- OK - this is absolutely bizarre. When we have a ParaStyleName property assigned to a comment, it raises an exception. But if I remove the property, then we get this problem. It will be interesting trying to find the root of all this... So, the problem in my commit comes from avoiding inserting an illegal property into the top context in the case of IsInComments in lcl_startParagraphGroup. So what? Things don't work unless an exception handler is run? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 60616] Chapter info doesn't support more than one appearance in an Alphabetical index entry and only the last chapter
https://bugs.documentfoundation.org/show_bug.cgi?id=60616 --- Comment #21 from Lee <92ma...@gmail.com> --- It's been ten years since this bug was first reported. It is still a problem. There is an ugly work around, at least for the time being. LO Writer treats word entries as different if they have a different number of spaces after the index word. Corn with no space after the last n is different from Corn with one space after the last n, is different from Corn with two spaces after the last n. When formatting the entries of an index, trailing spaces are apparently truncated but - only when it's time to format the lines of the index. Using this, a convention of adding one space after index entries in chapter one and, two spaces after index entries in chapter two - or, perhaps only using this technique for those instances where something to be indexed appears in multiple chapters. It does make for an index that will appear to show the same word multiple times in an index if, that indexed work appears in multiple chapters but - that's better than having an incorrect entry (pointing to the wrong page) in the index. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153606] macOS app icon is not properly integrated
https://bugs.documentfoundation.org/show_bug.cgi?id=153606 --- Comment #17 from alexandre burton --- OK if the square is prohibited by law (i will not argue to the higher powers), the #1 is decent enough, but i still think the complexity is higher than needed. (white-within-gray-within-white) i now wonder: why the white background in the first place? (because microsoft does it?) but why not a full squircle solid LO green, and the rectangular document outline in white within? just like the LO logo on the main page. i guess my concern is about maximizing the full squircle as the "object", and minimizing the complexity of the ensemble. so the logo becomes a "branded squircle" (instead of "a squircle that serves as the background to an icon"). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153204] Draw: cannot create layer named "background"
https://bugs.documentfoundation.org/show_bug.cgi?id=153204 Olivier Hallot changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |olivier.hallot@libreoffice. |desktop.org |org -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 --- Comment #16 from V Stuart Foote --- Created attachment 185523 --> https://bugs.documentfoundation.org/attachment.cgi?id=185523=edit 10pt Meiryo and Win10 os/DE display control "Make text bigger" at 125% So reasonable UI values can be set using os/DE controls. Win10 in Dark mode with Meiryo and Meiryo UI installed. font size in cells at 10pt; UI elements: column headings, other UI text scaled 125%, and the inputwin of the Formula bar. So, while it would be nice RFE to allow this element to be scaled independent of os/DE it is "functional" os/DE provided feature. NTL the enhancement would be helpful as defaults for the os/DE should not *have* to be tweaked. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 --- Comment #16 from V Stuart Foote --- Created attachment 185523 --> https://bugs.documentfoundation.org/attachment.cgi?id=185523=edit 10pt Meiryo and Win10 os/DE display control "Make text bigger" at 125% So reasonable UI values can be set using os/DE controls. Win10 in Dark mode with Meiryo and Meiryo UI installed. font size in cells at 10pt; UI elements: column headings, other UI text scaled 125%, and the inputwin of the Formula bar. So, while it would be nice RFE to allow this element to be scaled independent of os/DE it is "functional" os/DE provided feature. NTL the enhancement would be helpful as defaults for the os/DE should not *have* to be tweaked. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 122497] [META] Table of Contents and Indexes dialog bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=122497 Bug 122497 depends on bug 105628, which changed state. Bug 105628 Summary: Change "Evaluate" to "Show" in the Entries tab of Table of Contents/Index dialog, when Chapter Number is selected https://bugs.documentfoundation.org/show_bug.cgi?id=105628 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105628] Change "Evaluate" to "Show" in the Entries tab of Table of Contents/Index dialog, when Chapter Number is selected
https://bugs.documentfoundation.org/show_bug.cgi?id=105628 sdc.bla...@youmail.dk changed: What|Removed |Added Assignee|sdc.bla...@youmail.dk |libreoffice-b...@lists.free ||desktop.org Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/uiconfig
sw/uiconfig/swriter/ui/tocentriespage.ui |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit c41e872ed248f804249ecf4d65c4afc2e426e329 Author: Seth Chaiklin AuthorDate: Tue Feb 21 15:26:51 2023 + Commit: Seth Chaiklin CommitDate: Tue Feb 21 23:49:05 2023 + tdf#105628 change "Evaluate" to "Show" for Chapter Number Change-Id: I64ac9d8957fe3ca8cbb50a0d4728ed9e127b2301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147365 Tested-by: Jenkins Reviewed-by: Seth Chaiklin diff --git a/sw/uiconfig/swriter/ui/tocentriespage.ui b/sw/uiconfig/swriter/ui/tocentriespage.ui index 10ff109d54e1..016357850b71 100644 --- a/sw/uiconfig/swriter/ui/tocentriespage.ui +++ b/sw/uiconfig/swriter/ui/tocentriespage.ui @@ -429,7 +429,7 @@ True False -Evaluate up to level: +Show up to level: True entryoutlinelevel 0 @@ -448,9 +448,10 @@ True True adjustment2 +Enter the number of levels of the heading number to show in the index. For example, select “2” to show the first two levels of the heading number. -Enter the maximum hierarchy level down to which objects are shown in the generated index. +Enter the number of levels of the heading number to show in the index. For example, select “2” to show the first two levels of the heading number. To enable heading numbers for headings, choose Tools - Heading Numbering.
[Libreoffice-bugs] [Bug 153526] No Numbering/New Line After Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=153526 raal changed: What|Removed |Added Regression By||Justin Luth -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153526] No Numbering/New Line After Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=153526 raal changed: What|Removed |Added Keywords||bibisected, bisected CC||jl...@mail.com --- Comment #9 from raal --- This seems to have begun at the below commit. Adding Cc: to Justin Luth ; Could you possibly take a look at this one? Thanks 35908e41a2428fe1c4130c34ae4062c3f0705215 is the first bad commit commit 35908e41a2428fe1c4130c34ae4062c3f0705215 Author: Jenkins Build User Date: Mon Jul 11 22:14:26 2022 +0200 source sha:cf02b94bc513ee1b742b4c5d7174632b568e8b72 https://git.libreoffice.org/core/+/cf02b94bc513ee1b742b4c5d7174632b568e8b72 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153778] RFE Improvements for the Fontwork shape type window
https://bugs.documentfoundation.org/show_bug.cgi?id=153778 --- Comment #4 from Regina Henschel --- Created attachment 185522 --> https://bugs.documentfoundation.org/attachment.cgi?id=185522=edit SoftMaker -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153778] RFE Improvements for the Fontwork shape type window
https://bugs.documentfoundation.org/show_bug.cgi?id=153778 --- Comment #3 from Regina Henschel --- Created attachment 185521 --> https://bugs.documentfoundation.org/attachment.cgi?id=185521=edit OnlyOffice -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153778] RFE Improvements for the Fontwork shape type window
https://bugs.documentfoundation.org/show_bug.cgi?id=153778 --- Comment #2 from Regina Henschel --- Created attachment 185520 --> https://bugs.documentfoundation.org/attachment.cgi?id=185520=edit MS Office WordArt -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153778] RFE Improvements for the Fontwork shape type window
https://bugs.documentfoundation.org/show_bug.cgi?id=153778 --- Comment #1 from Regina Henschel --- Created attachment 185519 --> https://bugs.documentfoundation.org/attachment.cgi?id=185519=edit MS Office 'abc transform' -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153778] New: RFE Improvements for the Fontwork shape type window
https://bugs.documentfoundation.org/show_bug.cgi?id=153778 Bug ID: 153778 Summary: RFE Improvements for the Fontwork shape type window Product: LibreOffice Version: 7.6.0.0 alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rb.hensc...@t-online.de Created attachment 185518 --> https://bugs.documentfoundation.org/attachment.cgi?id=185518=edit LibreOffice The current Fontwork shape type window has several shortcomings: (1) The selection does not cover all 40 Fontwork types available in OOXML. LibreOffice can use and render all of them. (2) The 'Curve' types have the same icon as the 'Pour' types. That is bad because you need to wait for the tooltip to be sure you use the correct icon. (3) The types "Arch Up (Curve)", "Arch Down (Curve)", "Circle (Curve)" and "Open Circle (Curve)" render the text on a single line, whereas the other types scale the text to fit between lines. So these four should be separated from the others. MS Office makes the distinction "Follow path" and "Warp". (4) The types "Arch Right" and "Arch Left", both 'Circle' and 'Pour', are very special. The have not counterpart in OOXML. In exchange with MS formats they can only be used for the binary MS formats. They should be separated from the other types too. The Fontwork shape type window is defined by the files .../toolbar/fontworkshapetype.xml. All of its items are of the kind That means, that the execution uses the dispatcher. And indeed an item works directly without changes in the code. ["mso-spt142" is the missing type "Ring Inside"]. Only that there exists no icon for it. I will attach screenshots of the similar tools in other Office applications. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153774] wrong page linked to "Evaluate up to level" option in Entries tab of Insert ToC/Index dialg
https://bugs.documentfoundation.org/show_bug.cgi?id=153774 --- Comment #1 from sdc.bla...@youmail.dk --- The OP should have specified that Type: Table of Contents was selected on the Type tab, before switching to the Entries tab. I believe this problem arises because: appears on line 45 of source/text/swriter/01/04120222.xhp The bookmark is part of the section, which gets embedded into source/text/swriter/01/04120221.xhp (the help page for ToC). This probably explains why "Alphabetical Index" is shown. But it gets worse. The embedding in 04120221.xhp is part of the section in that file, which gets embedded into 04120223.xhp (Illustration), 04120224.xhp (Tables), 04120225.xhp (user-defined), and 04120226.xhp (objects) -- so the same problem happens if these Types are selected on the Type tab, and then F1 is used in the "Evaluate up to level" Note that "Evaluate up to level" is becoming "Show up to level" (bug 105628). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-6-1' - 6 commits - configure.ac connectivity/source download.lst external/hsqldb formula/source sc/source
configure.ac |2 - connectivity/source/drivers/hsqldb/HDriver.cxx| 31 ++ download.lst |8 ++--- external/hsqldb/UnpackedTarball_hsqldb.mk |1 external/hsqldb/patches/disable-dump-script.patch | 14 + formula/source/core/api/token.cxx | 13 +++-- sc/source/core/tool/interpr4.cxx | 14 +++-- 7 files changed, 67 insertions(+), 16 deletions(-) New commits: commit f5efe5b51e449ce9742f4b4d07a5ca2c696d2ce6 Author: Thorsten Behrens AuthorDate: Wed Feb 22 00:29:07 2023 +0100 Commit: Thorsten Behrens CommitDate: Wed Feb 22 00:29:07 2023 +0100 Bump version to 6.1.7.41 Change-Id: I577f2de33498de66b83c8b8a1aa6bfbb37e1c67b diff --git a/configure.ac b/configure.ac index 3530f9bdce45..3681440963b0 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([CIB Office],[6.1.7.40],[],[],[https://www.cib.de/office/]) +AC_INIT([CIB Office],[6.1.7.41],[],[],[https://www.cib.de/office/]) AC_PREREQ([2.59]) commit 9b7f0272b1ce60934db6777882b188de1690d3eb Author: Thorsten Behrens AuthorDate: Wed Feb 22 00:27:40 2023 +0100 Commit: Thorsten Behrens CommitDate: Wed Feb 22 00:27:40 2023 +0100 nss: upgrade to release 3.88.1 Fixes CVE-2023-0767 CVE-2022-3479 Change-Id: I688dc7d0785ed3344c33e331c7e9ef37baa720ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147387 Tested-by: Jenkins Reviewed-by: Michael Stahl (cherry picked from commit 538975a0e511ad79a7dd3c71300b993d1554cd03) diff --git a/download.lst b/download.lst index 2719edd4a506..f4c91c539b0c 100644 --- a/download.lst +++ b/download.lst @@ -179,8 +179,8 @@ export MYTHES_SHA256SUM := 1e81f395d8c851c3e4e75b568e20fa2fa549354e75ab397f9de4b export MYTHES_TARBALL := a8c2c5b8f09e7ede322d5c602ff6a4b6-mythes-1.2.4.tar.gz export NEON_SHA256SUM := db0bd8cdec329b48f53a6f00199c92d5ba40b0f015b153718d1b15d3d967fbca export NEON_TARBALL := neon-0.30.2.tar.gz -export NSS_SHA256SUM := 5369ed274a19f480ec94e1faef04da63e3cbac1a82e15bb1751e58b2f274b835 -export NSS_TARBALL := nss-3.79-with-nspr-4.34.tar.gz +export NSS_SHA256SUM := fcfa26d2738ec5b0cf72ab4be784eac832a75132cda2e295799c04d62a93607a +export NSS_TARBALL := nss-3.88.1-with-nspr-4.35.tar.gz export ODFGEN_SHA256SUM := 55200027fd46623b9b38d275e7452d1b0ff8aeddcad6f9ae6dc25f610625 export ODFGEN_VERSION_MICRO := 8 export ODFGEN_TARBALL := libodfgen-0.1.$(ODFGEN_VERSION_MICRO).tar.xz commit f1df5a58bfb9315898ff54fad29834b683f000ce Author: Eike Rathke AuthorDate: Thu Feb 16 20:20:31 2023 +0100 Commit: Thorsten Behrens CommitDate: Wed Feb 22 00:26:05 2023 +0100 Obtain actual 0-parameter count for OR(), AND() and 1-parameter functions OR and AND for legacy infix notation are classified as binary operators but in fact are functions with parameter count. In case no argument is supplied, GetByte() returns 0 and for that case the implicit binary operator 2 parameters were wrongly assumed. Similar for functions expecting 1 parameter, without argument 1 was assumed. For "real" unary and binary operators the compiler already checks parameters. Omit OR and AND and 1-parameter functions from this implicit assumption and return the actual 0 count. Change-Id: Ie05398c112a98021ac2875cf7b6de994aee9d882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147173 Reviewed-by: Eike Rathke Tested-by: Jenkins (cherry picked from commit e7ce9bddadb2db222eaa5f594ef1de2e36d57e5c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147129 Reviewed-by: Caolán McNamara (cherry picked from commit d6599a2af131994487d2d9223a4fd32a8c3ddc49) diff --git a/formula/source/core/api/token.cxx b/formula/source/core/api/token.cxx index b85fdff6dc9e..fcd0c8b22970 100644 --- a/formula/source/core/api/token.cxx +++ b/formula/source/core/api/token.cxx @@ -105,17 +105,14 @@ sal_uInt8 FormulaToken::GetParamCount() const return 0; // parameters and specials // ocIf... jump commands not for FAP, have cByte then //2do: bool parameter whether FAP or not? -else if ( GetByte() ) +else if (GetByte()) return GetByte(); // all functions, also ocExternal and ocMacro -else if (SC_OPCODE_START_BIN_OP <= eOp && eOp < SC_OPCODE_STOP_BIN_OP) -return 2; // binary -else if ((SC_OPCODE_START_UN_OP <= eOp && eOp < SC_OPCODE_STOP_UN_OP) -|| eOp == ocPercentSign) -return 1; // unary +else if (SC_OPCODE_START_BIN_OP <= eOp && eOp < SC_OPCODE_STOP_BIN_OP && eOp != ocAnd && eOp != ocOr) +return 2;
[Libreoffice-bugs] [Bug 106179] [META] Writer comment bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=106179 raal changed: What|Removed |Added Depends on||153526 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153526 [Bug 153526] No Numbering/New Line After Comment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153526] No Numbering/New Line After Comment
https://bugs.documentfoundation.org/show_bug.cgi?id=153526 raal changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Keywords||filter:docx, regression Blocks||106179 --- Comment #8 from raal --- confirm with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 14844d835cc5d6dfde499a0b1074aea5dcff4fc7 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded works in Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=106179 [Bug 106179] [META] Writer comment bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 026d49e3ccd1c002fc81e44631175d0191f61561 Author: Seth Chaiklin AuthorDate: Tue Feb 21 23:25:39 2023 + Commit: Gerrit Code Review CommitDate: Tue Feb 21 23:25:39 2023 + Update git submodules * Update helpcontent2 from branch 'master' to e9cbd8e356084c3d4b384315b6687b94080dd79b - tdf#105628 "Evaluate" -> "Show" in option label and update description Update "Evaluate up to level" and its description in Alphabetical index (swriter/01/04120222.xhp). This change gets embedded into the "format" section in swriter/01/04120221.xhp, and the "format" section gets embedded into other relevant "entries" pages. some refactoring in swriter/01/04120221.xhp refactor swriter/01/04120223.xhp Change-Id: I48c45f3ebd969f02ee73ef3b3a5c9e590660496c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147366 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/helpcontent2 b/helpcontent2 index 3f7b5afe0b04..e9cbd8e35608 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 3f7b5afe0b04aabf7d1fb26b9c825def3123506e +Subproject commit e9cbd8e356084c3d4b384315b6687b94080dd79b
[Libreoffice-commits] help.git: source/text
source/text/swriter/01/04120221.xhp | 11 +-- source/text/swriter/01/04120222.xhp | 13 + source/text/swriter/01/04120223.xhp |8 ++-- 3 files changed, 12 insertions(+), 20 deletions(-) New commits: commit e9cbd8e356084c3d4b384315b6687b94080dd79b Author: Seth Chaiklin AuthorDate: Tue Feb 21 15:39:46 2023 + Commit: Seth Chaiklin CommitDate: Tue Feb 21 23:25:39 2023 + tdf#105628 "Evaluate" -> "Show" in option label and update description Update "Evaluate up to level" and its description in Alphabetical index (swriter/01/04120222.xhp). This change gets embedded into the "format" section in swriter/01/04120221.xhp, and the "format" section gets embedded into other relevant "entries" pages. some refactoring in swriter/01/04120221.xhp refactor swriter/01/04120223.xhp Change-Id: I48c45f3ebd969f02ee73ef3b3a5c9e590660496c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/147366 Reviewed-by: Seth Chaiklin Tested-by: Jenkins diff --git a/source/text/swriter/01/04120221.xhp b/source/text/swriter/01/04120221.xhp index 3ebcbe4920..c29391321f 100644 --- a/source/text/swriter/01/04120221.xhp +++ b/source/text/swriter/01/04120221.xhp @@ -27,8 +27,7 @@ - -Entries (table of contents) +Entries (table of contents) Specify the format of the entries in the table of contents. @@ -37,7 +36,7 @@ -Level +Level Select the level that you want to define. @@ -72,7 +71,7 @@ -Entry text (E) +Entry text (E) Inserts the text of the chapter heading. @@ -124,12 +123,12 @@ -Format +Format Only visible when you click the E# button in the Structure line. Select to show the chapter number with or without separator. -Tab position relative to Paragraph Style indent +Tab position relative to Paragraph Style indent Positions the tab stop relative to the "indent from left" value defined in the paragraph style selected on the Styles tab. Otherwise the tab stop is positioned relative to the left text margin. diff --git a/source/text/swriter/01/04120222.xhp b/source/text/swriter/01/04120222.xhp index 1ced699d4f..f76fb32b4d 100644 --- a/source/text/swriter/01/04120222.xhp +++ b/source/text/swriter/01/04120222.xhp @@ -1,7 +1,5 @@ - - - + - - Entries (alphabetical index) @@ -29,7 +25,7 @@ -Entries (alphabetical index) +Entries (alphabetical index) Specify the format of the alphabetical index entries. @@ -46,8 +42,9 @@ Chapter entry Select the chapter information that you want to include in the index entry. -Evaluate up to level -Enter the maximum hierarchy level down to which objects are shown in the generated index. + +Show up to level +Specify the number of levels of the heading number to show. For example, select “2” to show the first two levels of the heading number. diff --git a/source/text/swriter/01/04120223.xhp b/source/text/swriter/01/04120223.xhp index 05d703e02b..d341f717ed 100644 --- a/source/text/swriter/01/04120223.xhp +++ b/source/text/swriter/01/04120223.xhp @@ -1,7 +1,5 @@ - - - + - - Entries (illustration index) @@ -29,7 +25,7 @@ -Entries (illustration index) +Entries (illustration index) Specify the format for the illustration index entries.
[Libreoffice-bugs] [Bug 149506] Slow start-up and opening of files since 7.3 release
https://bugs.documentfoundation.org/show_bug.cgi?id=149506 --- Comment #27 from bunkem --- (In reply to Buovjaga from comment #26) > (In reply to bunkem from comment #25) > > Yes. It was slower. > > > > Rough estimate for comparison. > > Normal start up v7.2 2-3 sec; file open 2 sec > > Slow start up v7.3 9-10 sec; file open 5 sec. > > If you mean to say that startup was equally slow after 'git checkout > 846a5c424a6c16dc07eefb6827b362efed5075b1' and 'git checkout HEAD^', then > your bibisect result is not valid. Sorry about that. Last week was my first time using git. While I read the instruction in the link and also read a good portion of the git pdf, I still can't visualize what I'm doing. Perhaps the other individual can give this a try and I don't seem to be able to get it right. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153582] a5 printing is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=153582 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- No repro in Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 14844d835cc5d6dfde499a0b1074aea5dcff4fc7 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #15 from Regina Henschel --- Created attachment 185517 --> https://bugs.documentfoundation.org/attachment.cgi?id=185517=edit screenshot Calc I think the request for a larger font in the formula bar is reasonable. I use Windows with 120% screen scaling. My screenshot shows, that even with the better rendering of black font on white background, the glyphs in the formula bar are not clear enough. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #15 from Regina Henschel --- Created attachment 185517 --> https://bugs.documentfoundation.org/attachment.cgi?id=185517=edit screenshot Calc I think the request for a larger font in the formula bar is reasonable. I use Windows with 120% screen scaling. My screenshot shows, that even with the better rendering of black font on white background, the glyphs in the formula bar are not clear enough. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 152706] TRANSLATION: Error message when trying to use new translation feature
https://bugs.documentfoundation.org/show_bug.cgi?id=152706 raal changed: What|Removed |Added CC||bz.roy...@xoxy.net --- Comment #6 from raal --- *** Bug 153461 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153461] DeepL API Translate
https://bugs.documentfoundation.org/show_bug.cgi?id=153461 raal changed: What|Removed |Added Resolution|--- |DUPLICATE CC||r...@post.cz Status|UNCONFIRMED |RESOLVED --- Comment #1 from raal --- Hello, Thank you for submitting the bug. The bug has previously been reported, so this bug will be added as a duplicate of it. You will automatically be CCed to updates made to the other bug. *** This bug has been marked as a duplicate of bug 152706 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153608] Crash in: libc.so.6
https://bugs.documentfoundation.org/show_bug.cgi?id=153608 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #2 from raal --- Hello, Thank you for filing the bug. For the test, could you rename your LibreOffice directory profile (see https://wiki.documentfoundation.org/UserProfile) or run LibreOffice in safe mode (https://help.libreoffice.org/7.2/en-US/text/shared/01/profile_safe_mode.html) and give it a new try? Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153616] Writer hangs on opening a doc(x)file; have to stop Word services; NEW
https://bugs.documentfoundation.org/show_bug.cgi?id=153616 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- (In reply to Ruud de Vries from comment #0) > But I see 2 services started, both Word related. These services were not > started before the start of Writer. > And after stopping these 2 services, Writer continues, as if nothing is > wrong. > What's the name of word services? Do you mean winword.exe? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 95406] UI/Editing Feature Request: Font in Formula Bar
https://bugs.documentfoundation.org/show_bug.cgi?id=95406 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||3727 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=95 ||406 --- Comment #14 from V Stuart Foote --- bug 88141 is for ability to adjust the size of the font in only the inputwin of the Formula bar, independent of the entire UI or os/DE bug 95406 is for ability to change the font used on the input win. bug 101646 is for LO controlled scaling of the the entire UI -- distinct from the UI scaling os/DE provides. If I were to dupe rather than => NAB, I would say UX issue here is a dupe of bug 88141 -- just need ability to bump up the font size in the Formula bar. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=95 ||406 --- Comment #14 from V Stuart Foote --- bug 88141 is for ability to adjust the size of the font in only the inputwin of the Formula bar, independent of the entire UI or os/DE bug 95406 is for ability to change the font used on the input win. bug 101646 is for LO controlled scaling of the the entire UI -- distinct from the UI scaling os/DE provides. If I were to dupe rather than => NAB, I would say UX issue here is a dupe of bug 88141 -- just need ability to bump up the font size in the Formula bar. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153295] CALC Hiding Headers action is not saved if no other changes have been effected
https://bugs.documentfoundation.org/show_bug.cgi?id=153295 raal changed: What|Removed |Added Version|7.3.7.2 release |4.1.0.4 release CC||r...@post.cz OS|Windows (All) |All Blocks||116625 Whiteboard| QA:needsComment| Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from raal --- I can confirm with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 14844d835cc5d6dfde499a0b1074aea5dcff4fc7 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=116625 [Bug 116625] [META] Bugs where document modification status is wrong -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116625] [META] Bugs where document modification status is wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=116625 raal changed: What|Removed |Added Depends on||153295 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153295 [Bug 153295] CALC Hiding Headers action is not saved if no other changes have been effected -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153661] insert section as link -- UNDO option missing (resubmission)
https://bugs.documentfoundation.org/show_bug.cgi?id=153661 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Blocks||105948 CC||r...@post.cz Version|7.6.0.0 alpha0+ Master |4.1.0.4 release --- Comment #1 from raal --- I can confirm with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 14844d835cc5d6dfde499a0b1074aea5dcff4fc7 CPU threads: 4; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=105948 [Bug 105948] [META] Undo/Redo bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 raal changed: What|Removed |Added Depends on||153661 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=153661 [Bug 153661] insert section as link -- UNDO option missing (resubmission) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 118235] obsolete LO wiki help pages dominate Google search results
https://bugs.documentfoundation.org/show_bug.cgi?id=118235 Olivier Hallot changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Olivier Hallot --- (In reply to skierpage from comment #0) > If you do a Google search for "LibreOffice Calc help", the top result is > Welcome to the LibreOffice Calc Help - LibreOffice Help > https://help.libreoffice.org/Calc/Welcome_to_the_Calc_Help > Jul 19, 2013 > This has been fixed in the meantime. Any search engine that points to help.libreoffice.org/whatever will redirect to the latest published help. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153667] Form anchors change when saving odt document as doc or docx
https://bugs.documentfoundation.org/show_bug.cgi?id=153667 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Please attach test odt document. Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 --- Comment #13 from V Stuart Foote --- (In reply to iaganicshe from comment #12) > I have default Windows font for japanese which is Meiryo. > Changing default font for specific language is not that easy. > I don't like "Making text bigger across the system" solution, it makes using > other apps inconvenient. For example vertical work space in Firefox is > reduced significantly. "don't like" ≠ not able > I don't think it's a rendering problem. 9pt cells with 100% scaling look > almost the same, and they are also unreadable. For cells I set font to 11pt > and scaling to 120% to work comfortably. agree, not a rendering issue > But formula bar cannot be scaled. Its font size is the same as other UI > elements. Just for hieroglyphs that size is too small, as they contain more > pixels. Understood, and that is the nature of fonts with "coverage" of mixed usage. Meiryo is Microsoft developed for jp-JP use. When its character height is reduced too far the Kanji looks deformed. Open the UI font scale just a bit to get better rendering for applications like LibreOffice that do not provide direct UI scaling like the "enhancements" of the See Also BZ issues listed above. Only those enhancements would address this issue directly, otherwise the os/DE must be scaled, here as provided by Microsoft. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 --- Comment #13 from V Stuart Foote --- (In reply to iaganicshe from comment #12) > I have default Windows font for japanese which is Meiryo. > Changing default font for specific language is not that easy. > I don't like "Making text bigger across the system" solution, it makes using > other apps inconvenient. For example vertical work space in Firefox is > reduced significantly. "don't like" ≠ not able > I don't think it's a rendering problem. 9pt cells with 100% scaling look > almost the same, and they are also unreadable. For cells I set font to 11pt > and scaling to 120% to work comfortably. agree, not a rendering issue > But formula bar cannot be scaled. Its font size is the same as other UI > elements. Just for hieroglyphs that size is too small, as they contain more > pixels. Understood, and that is the nature of fonts with "coverage" of mixed usage. Meiryo is Microsoft developed for jp-JP use. When its character height is reduced too far the Kanji looks deformed. Open the UI font scale just a bit to get better rendering for applications like LibreOffice that do not provide direct UI scaling like the "enhancements" of the See Also BZ issues listed above. Only those enhancements would address this issue directly, otherwise the os/DE must be scaled, here as provided by Microsoft. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 138900] Inserting TOC in two-column document causes lockup
https://bugs.documentfoundation.org/show_bug.cgi?id=138900 raal changed: What|Removed |Added Keywords|bibisected | -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 --- Comment #12 from iaganic...@gmail.com --- I have default Windows font for japanese which is Meiryo. Changing default font for specific language is not that easy. I don't like "Making text bigger across the system" solution, it makes using other apps inconvenient. For example vertical work space in Firefox is reduced significantly. I don't think it's a rendering problem. 9pt cells with 100% scaling look almost the same, and they are also unreadable. For cells I set font to 11pt and scaling to 120% to work comfortably. But formula bar cannot be scaled. Its font size is the same as other UI elements. Just for hieroglyphs that size is too small, as they contain more pixels. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input
https://bugs.documentfoundation.org/show_bug.cgi?id=153727 --- Comment #12 from iaganic...@gmail.com --- I have default Windows font for japanese which is Meiryo. Changing default font for specific language is not that easy. I don't like "Making text bigger across the system" solution, it makes using other apps inconvenient. For example vertical work space in Firefox is reduced significantly. I don't think it's a rendering problem. 9pt cells with 100% scaling look almost the same, and they are also unreadable. For cells I set font to 11pt and scaling to 120% to work comfortably. But formula bar cannot be scaled. Its font size is the same as other UI elements. Just for hieroglyphs that size is too small, as they contain more pixels. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 99391] EDITING Rotating text in a cell rotates also cell background
https://bugs.documentfoundation.org/show_bug.cgi?id=99391 m.a.riosv changed: What|Removed |Added OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 99391] EDITING Rotating text in a cell rotates also cell background
https://bugs.documentfoundation.org/show_bug.cgi?id=99391 --- Comment #10 from JF --- This behaviour is also found on Windows (not just Linux). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 104182] [VIEWING] Table of contents - create index for specified discontinued levels
https://bugs.documentfoundation.org/show_bug.cgi?id=104182 --- Comment #4 from sdc.bla...@youmail.dk --- (In reply to ratrace from comment #0) > It would be helpful if i could insert a table of contents for specific > levels, that i will choose in a "form" of range (from heading (level) 2 to > heading (level) 3), for my document. I believe this is now FIXED (based on bug 130318 ) or WFM. In LO 7.6: 1. Place cursor after the level 2 heading to be indexed. 2. Open ToC dialog, select For: Chapter and set: Evaluate up to level: 3 Result: As described in OP. Level 2 Heading Only level 3 headings -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index
https://bugs.documentfoundation.org/show_bug.cgi?id=153770 --- Comment #4 from sdc.bla...@youmail.dk --- (In reply to RGB from comment #3) Thanks for this useful comment. Have known about the function, but your comment has resulted in my first experiments. > Notice that in recent versions partial TOCs will be build from the current > heading level Just to be sure that I have interpreted "build from the current heading level" correctly. The partial index is created from the immediately prior heading in relation to where the cursor is placed, and only indexes headings have a higher outline level than the immediately prior heading, stopping at (and not including) a subsequent heading that has the same outline level as the "prior heading". (at least that is what my experiments show) > using the chapter option while on a level 3 heading just to be sure: "on a heading" means that the cursor is placed AFTER the heading (not in/on the paragraph with a heading PS). > (the index will show only level 4 and lower) depending on what is set in "Evaluate up to level" > that mean that the "Chapter" label (that only refers to a level 1 heading) is > not valid anymore, it should be "Current heading level" or something like > that. Good point! Perhaps "Heading" is enough. Also this makes me realise that "Evaluate up to level" would benefit from being called "Show up to level" (in line with bug 105628 for "Chapter No." in the Entries tab) -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 153770] Proposal to modify "Create Index or Table of Contents" and Type-dependent "Create From" sections in Type tab of ToC/Index
https://bugs.documentfoundation.org/show_bug.cgi?id=153770 --- Comment #4 from sdc.bla...@youmail.dk --- (In reply to RGB from comment #3) Thanks for this useful comment. Have known about the function, but your comment has resulted in my first experiments. > Notice that in recent versions partial TOCs will be build from the current > heading level Just to be sure that I have interpreted "build from the current heading level" correctly. The partial index is created from the immediately prior heading in relation to where the cursor is placed, and only indexes headings have a higher outline level than the immediately prior heading, stopping at (and not including) a subsequent heading that has the same outline level as the "prior heading". (at least that is what my experiments show) > using the chapter option while on a level 3 heading just to be sure: "on a heading" means that the cursor is placed AFTER the heading (not in/on the paragraph with a heading PS). > (the index will show only level 4 and lower) depending on what is set in "Evaluate up to level" > that mean that the "Chapter" label (that only refers to a level 1 heading) is > not valid anymore, it should be "Current heading level" or something like > that. Good point! Perhaps "Heading" is enough. Also this makes me realise that "Evaluate up to level" would benefit from being called "Show up to level" (in line with bug 105628 for "Chapter No." in the Entries tab) -- You are receiving this mail because: You are the assignee for the bug.
