Re: LO 24.2 C++20 baseline

2023-09-24 Thread Miklos Vajna 
Hi Stephan,

On Fri, Sep 22, 2023 at 10:20:31AM +0300, Stephan Bergmann 
 wrote:
> I just submitted
> 
> "Bump baseline to C++20" to master.

gcc-12 looks fine here, but I hit an interesting problem with clang-15
(which worked fine before pulling):

$ make animations
make -j 16 -f 
/home/vmiklos/git/libreoffice/core-clang/compilerplugins/Makefile-clang.mk 
compilerplugins
make[1]: Entering directory '/home/vmiklos/git/libreoffice/core-clang'
make[1]: Nothing to be done for 'compilerplugins'.
make[1]: Leaving directory '/home/vmiklos/git/libreoffice/core-clang'
cd /home/vmiklos/git/libreoffice/core-clang/animations && make -j 16 -rs
[CXX] animations/source/animcore/animcore.cxx
[LOC] top level modules: animations
In file included from 
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:20:
In file included from 
/home/vmiklos/git/libreoffice/core-clang/workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/util/XCloneable.hpp:8:
/home/vmiklos/git/libreoffice/core-clang/workdir/UnoApiHeadersTarget/udkapi/normal/com/sun/star/uno/XInterface.hpp:32:65:
 error: invalid application of 'sizeof' to an incomplete type 
'animcore::(anonymous namespace)::AnimationNode'
template inline constexpr auto isUnoInterfaceType = sizeof (T) && 
IsUnoInterfaceType::value;
^~
/home/vmiklos/git/libreoffice/core-clang/include/unotools/weakref.hxx:119:33: 
note: in instantiation of variable template specialization 
'cppu::detail::isUnoInterfaceType' requested here
requires(!cppu::detail::isUnoInterfaceType)
^
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:309:44:
 note: in instantiation of template class 
'unotools::WeakReference' 
requested here
unotools::WeakReference mxParent;
   ^
/home/vmiklos/git/libreoffice/core-clang/animations/source/animcore/animcore.cxx:121:7:
 note: definition of 'animcore::(anonymous namespace)::AnimationNode' is not 
complete until the closing '}'
class AnimationNode final:  public AnimationNodeBase
  ^
1 error generated.
make[1]: *** 
[/home/vmiklos/git/libreoffice/core-clang/solenv/gbuild/LinkTarget.mk:340: 
/home/vmiklos/git/libreoffice/core-clang/workdir/CxxObject/animations/source/animcore/animcore.o]
 Error 1
make: *** [Makefile:121: animations] Error 2

Given that AnimationNode refers to itself, we probably can't provide a
full type for unotools::WeakReference. But then how to get around this?

Thanks,

Miklos

[Libreoffice-commits] core.git: solenv/gbuild

2023-09-24 Thread Stephan Bergmann (via logerrit) 
 solenv/gbuild/platform/com_MSC_defs.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 19e9fe7c8c89399753ac1730e1c76378b18418bc
Author: Stephan Bergmann 
AuthorDate: Sun Sep 24 18:49:09 2023 +0300
Commit: Stephan Bergmann 
CommitDate: Sun Sep 24 20:58:33 2023 +0200

Adapt a hard-coded value hack

...from 22267b7797340d1eb52ced10fe05afeb8a42fc2b "When building with 
clang-cl,
nevertheless use MSVC's CXXFLAGS_CXX11 for CLR" to
1eef07805021b7ca26a1a8894809b6d995747ba1 "Bump baseline to C++20"

Change-Id: I817a33b7ca5ae4db232bf4c983d46e808dc83f24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157230
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/solenv/gbuild/platform/com_MSC_defs.mk 
b/solenv/gbuild/platform/com_MSC_defs.mk
index 63e618783e63..0a3df54ce49c 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -271,7 +271,7 @@ gb_LTOFLAGS := $(if $(filter TRUE,$(ENABLE_LTO)),-GL)
 # in CLR meta-data - use of this type may lead to a runtime exception":
 gb_CXXCLRFLAGS := \
$(if $(COM_IS_CLANG), \
-   $(patsubst -std=%,-std:c++17 -Zc:__cplusplus,$(gb_CXXFLAGS)), \
+   $(patsubst -std=%,-std:c++20 -Zc:__cplusplus,$(gb_CXXFLAGS)), \
$(gb_CXXFLAGS)) \
$(gb_LinkTarget_EXCEPTIONFLAGS) \
-AI $(INSTDIR)/$(LIBO_URE_LIB_FOLDER) \

[Libreoffice-commits] core.git: sfx2/sdi

2023-09-24 Thread Heiko Tietze (via logerrit) 
 sfx2/sdi/sfx.sdi |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 90c97ccfd8c0324fffec8852935e71e1f0670d76
Author: Heiko Tietze 
AuthorDate: Sat Sep 23 14:57:43 2023 +0300
Commit: Heiko Tietze 
CommitDate: Sun Sep 24 19:58:58 2023 +0200

Resolves tdf#136216 - Hide uno:AdditionsDialog from customization

Change-Id: I0948a85cf222a44534473ee465087213734536b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157185
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sfx2/sdi/sfx.sdi b/sfx2/sdi/sfx.sdi
index 669934693c0f..5660596a3b3d 100644
--- a/sfx2/sdi/sfx.sdi
+++ b/sfx2/sdi/sfx.sdi
@@ -5840,9 +5840,9 @@ SfxVoidItem AdditionsDialog SID_ADDITIONS_DIALOG
 RecordAbsolute = FALSE,
 RecordPerSet;
 
-AccelConfig = TRUE,
-MenuConfig = TRUE,
-ToolBoxConfig = TRUE,
+AccelConfig = FALSE,
+MenuConfig = FALSE,
+ToolBoxConfig = FALSE,
 GroupId = SfxGroupId::Application;
 ]

[Libreoffice-commits] core.git: cui/uiconfig officecfg/registry

2023-09-24 Thread Heiko Tietze (via logerrit) 
 cui/uiconfig/ui/cuiimapdlg.ui|2 +-
 cui/uiconfig/ui/objecttitledescdialog.ui |4 
++--
 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit a5ece3a525466198c91633af3b9e0d6edfe9802f
Author: Heiko Tietze 
AuthorDate: Sat Sep 23 14:14:47 2023 +0300
Commit: Heiko Tietze 
CommitDate: Sun Sep 24 18:51:32 2023 +0200

Resolves tdf#155044 - Rename "Description" to "Alt Text"

Change-Id: Idc6602c6dfc7c6c8703fb8fc643665d7149486a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157183
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/cui/uiconfig/ui/cuiimapdlg.ui b/cui/uiconfig/ui/cuiimapdlg.ui
index 5618564cb5c3..870839b8c82a 100644
--- a/cui/uiconfig/ui/cuiimapdlg.ui
+++ b/cui/uiconfig/ui/cuiimapdlg.ui
@@ -242,7 +242,7 @@
 True
 False
 True
-_Text Alternative:
+Alt _Text:
 Enter a short description of essential features of 
the image map for persons who do not see the image.
 True
 textentry
diff --git a/cui/uiconfig/ui/objecttitledescdialog.ui 
b/cui/uiconfig/ui/objecttitledescdialog.ui
index e2cc8f1330ba..bcb121dc7797 100644
--- a/cui/uiconfig/ui/objecttitledescdialog.ui
+++ b/cui/uiconfig/ui/objecttitledescdialog.ui
@@ -12,7 +12,7 @@
   
 False
 6
-Description
+Alt Text
 True
 0
 0
@@ -90,7 +90,7 @@
 True
 False
 Give a short 
description of non-text content for users who do not see this object.
-_Text Alternative:
+Text:
 True
 object_title_entry
 0
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index d21f7ebd7a07..b31c153d6dc5 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -7252,7 +7252,7 @@ bit 3 (0x8): #define 
UICOMMANDDESCRIPTION_PROPERTIES_TOGGLEBUTTON 8
   
   
 
-  Description...
+  Alt Text...
 
 
   Add descriptions of non-text content (for 
accessibility)

[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang include/sfx2 sc/inc sc/source sd/Library_sd.mk sd/Library_sdui.mk sd/source sfx2/source

2023-09-24 Thread Noel Grandin (via logerrit) 
 compilerplugins/clang/unusedmethods.results|  438 +
 compilerplugins/clang/unusedmethods.unused-returns.results |   68 +-
 include/sfx2/sidebar/FocusManager.hxx  |2 
 sc/inc/tablink.hxx |1 
 sc/source/ui/docshell/tablink.cxx  |5 
 sd/Library_sd.mk   |2 
 sd/Library_sdui.mk |1 
 sd/source/filter/html/buttonset.cxx|  247 ---
 sd/source/filter/html/buttonset.hxx|   51 -
 sd/source/filter/html/htmlattr.cxx |   72 --
 sd/source/filter/html/htmlattr.hxx |   40 -
 sd/source/ui/dlg/assclass.cxx  |  160 
 sd/source/ui/inc/assclass.hxx  |   68 --
 sfx2/source/sidebar/FocusManager.cxx   |   28 
 14 files changed, 227 insertions(+), 956 deletions(-)

New commits:
commit c5cff66335ca162b52270059e57214c4065caf66
Author: Noel Grandin 
AuthorDate: Sat Sep 23 21:06:25 2023 +0200
Commit: Noel Grandin 
CommitDate: Sun Sep 24 18:32:29 2023 +0200

loplugin:unusedmethods

Change-Id: I231b80cb0779d92bba32da67f6878c07d757c967
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157198
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/unusedmethods.results 
b/compilerplugins/clang/unusedmethods.results
index 335a54622235..0ed5031af7c3 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -188,7 +188,7 @@ editeng/inc/edtspell.hxx:104
 __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator 
>, std::vector > WrongList::end() const
 editeng/source/editeng/impedit.hxx:234
 tools::Rectangle LOKSpecialPositioning::GetWindowPos(const 
tools::Rectangle &,enum MapUnit) const
-editeng/source/editeng/impedit.hxx:759
+editeng/source/editeng/impedit.hxx:761
 double ImpEditEngine::scaleYFontValue(unsigned short) const
 embeddedobj/source/msole/olecomponent.hxx:75
 _Bool OleComponent::InitializeObject_Impl()
@@ -278,7 +278,7 @@ include/basegfx/curve/b2dcubicbezier.hxx:194
 void basegfx::B2DCubicBezier::transform(const basegfx::B2DHomMatrix &)
 include/basegfx/curve/b2dcubicbezier.hxx:197
 void basegfx::B2DCubicBezier::fround()
-include/basegfx/matrix/b2dhommatrix.hxx:114
+include/basegfx/matrix/b2dhommatrix.hxx:113
 void basegfx::B2DHomMatrix::scale(const basegfx::B2DTuple &)
 include/basegfx/matrix/b2dhommatrixtools.hxx:132
 basegfx::B2DHomMatrix 
basegfx::utils::createRotateAroundCenterKeepAspectRatioStayInsideRange(const 
basegfx::B2DRange &,double)
@@ -298,9 +298,9 @@ include/basegfx/matrix/b3dhommatrix.hxx:105
 basegfx::B3DHomMatrix & basegfx::B3DHomMatrix::operator*=(double)
 include/basegfx/matrix/b3dhommatrix.hxx:106
 basegfx::B3DHomMatrix & basegfx::B3DHomMatrix::operator/=(double)
-include/basegfx/matrix/hommatrixtemplate.hxx:46
+include/basegfx/matrix/hommatrixtemplate.hxx:43
  basegfx::internal::ImplMatLine::ImplMatLine(unsigned short)
-include/basegfx/matrix/hommatrixtemplate.hxx:300
+include/basegfx/matrix/hommatrixtemplate.hxx:297
 _Bool basegfx::internal::ImplHomMatrixTemplate::isInvertible() const
 include/basegfx/numeric/ftools.hxx:116
 double basegfx::snapToRange(double,double,double)
@@ -338,9 +338,9 @@ include/basegfx/range/b1drange.hxx:143
 double basegfx::B1DRange::clamp(double) const
 include/basegfx/range/b2dpolyrange.hxx:64
 _Bool basegfx::B2DPolyRange::operator!=(const basegfx::B2DPolyRange &) 
const
-include/basegfx/range/b2drange.hxx:128
+include/basegfx/range/b2drange.hxx:127
 const basegfx::B2DRange & basegfx::B2DRange::getUnitB2DRange()
-include/basegfx/range/b2drange.hxx:133
+include/basegfx/range/b2drange.hxx:132
 basegfx::B2DRange basegfx::operator*(const basegfx::B2DHomMatrix &,const 
basegfx::B2DRange &)
 include/basegfx/range/b2ibox.hxx:61
  basegfx::B2IBox::B2IBox()
@@ -364,7 +364,7 @@ include/basegfx/range/b3drange.hxx:218
 const basegfx::B3DRange & basegfx::B3DRange::getUnitB3DRange()
 include/basegfx/range/b3drange.hxx:223
 basegfx::B3DRange basegfx::operator*(const basegfx::B3DHomMatrix &,const 
basegfx::B3DRange &)
-include/basegfx/range/Range2D.hxx:170
+include/basegfx/range/Range2D.hxx:176
 Tuple2D basegfx::Range2D::clamp(const 
Tuple2D &) const
 include/basegfx/tuple/b3ituple.hxx:43
  basegfx::B3ITuple::B3ITuple()
@@ -388,25 +388,27 @@ include/basegfx/tuple/Tuple2D.hxx:83
 _Bool basegfx::Tuple2D::equal(const basegfx::Tuple2D &) const
 include/basegfx/utils/b2dclipstate.hxx:72
 _Bool basegfx::utils::B2DClipState::operator!=(const 
basegfx::utils::B2DClipState &) const
-include/basegfx/utils/bgradient.hxx:132
+include/basegfx/utils/bgradient.hxx:113
  
basegfx::BColorStops::BColorStops(__gnu_debug::

[Libreoffice-commits] core.git: svx/source

2023-09-24 Thread Khaled Hosny (via logerrit) 
 svx/source/styles/CommonStylePreviewRenderer.cxx |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit d9eed9b489d8ad208df307588595f3a8d3b7539b
Author: Khaled Hosny 
AuthorDate: Sun Sep 24 18:10:21 2023 +0300
Commit: خالد حسني 
CommitDate: Sun Sep 24 18:23:47 2023 +0200

tdf#157067: Fix missing background color in style preview

Set the colors after setting the font not before as otherwise they seem
to get overridden.

Change-Id: I258cb762fd2328369bd8adae63e94ec87c666bb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157208
Tested-by: Jenkins
Reviewed-by: خالد حسني 

diff --git a/svx/source/styles/CommonStylePreviewRenderer.cxx 
b/svx/source/styles/CommonStylePreviewRenderer.cxx
index c23861e92a72..d92aac21d89c 100644
--- a/svx/source/styles/CommonStylePreviewRenderer.cxx
+++ b/svx/source/styles/CommonStylePreviewRenderer.cxx
@@ -335,12 +335,6 @@ bool CommonStylePreviewRenderer::render(const 
tools::Rectangle& aRectangle, Rend
 mrOutputDev.DrawRect(aRectangle);
 }
 
-if (maFontColor != COL_AUTO)
-mrOutputDev.SetTextColor(maFontColor);
-
-if (maHighlightColor != COL_AUTO)
-mrOutputDev.SetTextFillColor(maHighlightColor);
-
 Point aFontDrawPosition = aRectangle.TopLeft();
 aFontDrawPosition.AdjustY(mnBaseLine);
 if (eRenderAlign == RenderAlign::CENTER)
@@ -376,10 +370,16 @@ bool CommonStylePreviewRenderer::render(const 
tools::Rectangle& aRectangle, Rend
 mrOutputDev.Push(vcl::PushFlags::FONT);
 
 if (oFont)
-{
 mrOutputDev.SetFont(*oFont);
+
+if (maFontColor != COL_AUTO)
+mrOutputDev.SetTextColor(maFontColor);
+
+if (maHighlightColor != COL_AUTO)
+mrOutputDev.SetTextFillColor(maHighlightColor);
+
+if (oFont)
 oFont->QuickDrawText(&mrOutputDev, aFontDrawPosition, rText, 
nStart, nEnd - nStart, {});
-}
 else
 mrOutputDev.DrawText(aFontDrawPosition, rText, nStart, nEnd - 
nStart);

Swift Reply.

2023-09-24 Thread dogp...@gmail.com 
 Dear Sir/Madam,


Did you authorise Mr. Yong Chin Nam of Kemuning Ray Street NO.4,Tomang
Jakarta, Indonesia to pay the pending clearance charges and claim your
WORLD BANK COVID-19 lone/compensation funds valued (US$13,200,000) thirteen
million two hundred thousand US dollars??? from our BANK OF AMERICA. 3100
14th St NW STE 101, Washington, DC 20010 ?.


Below are the account details presented by Mr. Liu Kong Nam to claim your
funds into his bank account:


Account Holders Name: Mr.Yong Chin Nam
Account Number: 456-909-00943
Bank Name: HSBC BANK JAKARTA INDONESIA

Kindly get back to me.


Thanks
Mr. Kelech Kwami.
Finance Solutions Advisor.

Re: Dan Horák license statement

2023-09-24 Thread Julien Nabet 

Thank you, you've been added here:

https://wiki.documentfoundation.org/Development/Developers#H

Re: ASWATH.T license statement

2023-09-24 Thread Julien Nabet 

Thank you, you've been added here:

https://wiki.documentfoundation.org/Development/Developers#A

Re: Alexandru-Costin Gheorghiu license statement

2023-09-24 Thread Julien Nabet 

Thank you, you've been added here:

https://wiki.documentfoundation.org/Development/Developers#G

Re: Ioan-Teodor Teugea license statement

2023-09-24 Thread Julien Nabet 
Just https://wiki.documentfoundation.org/Development/Developers#T of 
course :-)

Re: Ioan-Teodor Teugea license statement

2023-09-24 Thread Julien Nabet 

Thank you, you've been added here:

https://wiki.documentfoundation.org/Development/Developers#T

[Libreoffice-commits] core.git: codemaker/source sal/qa sal/rtl

2023-09-24 Thread Stephan Bergmann (via logerrit) 
 codemaker/source/cppumaker/cpputype.cxx |6 ++
 sal/qa/rtl/oustring/rtl_OUString2.cxx   |   15 ---
 sal/rtl/ustring.cxx |   15 ---
 3 files changed, 2 insertions(+), 34 deletions(-)

New commits:
commit 414316a04fe9479dafcb36e3617ee1f5813c6a30
Author: Stephan Bergmann 
AuthorDate: Sun Sep 24 12:07:26 2023 +0300
Commit: Stephan Bergmann 
CommitDate: Sun Sep 24 17:32:22 2023 +0200

Drop some newly obsolete __clang_major__ version checks

...after 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441 "Adapt Clang and GCC 
minimum
version checks"

Change-Id: Ib25fbb76211d1bda1d230de771f207960e645421
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157204
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/codemaker/source/cppumaker/cpputype.cxx 
b/codemaker/source/cppumaker/cpputype.cxx
index cb3422de16d0..124f323630bf 100644
--- a/codemaker/source/cppumaker/cpputype.cxx
+++ b/codemaker/source/cppumaker/cpputype.cxx
@@ -3017,10 +3017,8 @@ void ExceptionType::dumpHdlFile(
 if (name_ == "com.sun.star.uno.Exception")
 {
 // LIBO_INTERNAL_ONLY implies GCC >= 7, which we need for this
-// Merely checking __has_include is not enough because some systems 
have the header,
-// but do not have a new enough Clang 9 supporting 
__builtin_FILE/LINE/FUNCTION as used by
-// that libstdc++ header.
-includes.addCustom("#if defined LIBO_INTERNAL_ONLY && ((defined 
__GNUC__ && !defined __clang__) || (defined __clang__ && __clang_major__ >= 9)) 
&& __has_include()");
+// libstdc++ header.
+includes.addCustom("#if defined LIBO_INTERNAL_ONLY && (defined 
__GNUC__ || defined __clang__) && 
__has_include()");
 includes.addCustom("#define LIBO_USE_SOURCE_LOCATION");
 includes.addCustom("#endif");
 includes.addCustom("#if defined LIBO_USE_SOURCE_LOCATION");
diff --git a/sal/qa/rtl/oustring/rtl_OUString2.cxx 
b/sal/qa/rtl/oustring/rtl_OUString2.cxx
index b633af15626c..bff3a0d145f1 100644
--- a/sal/qa/rtl/oustring/rtl_OUString2.cxx
+++ b/sal/qa/rtl/oustring/rtl_OUString2.cxx
@@ -38,23 +38,8 @@ namespace rtl_OUString
 
 namespace {
 
-// Avoid -fsanitize=undefined warning e.g. "runtime error: value 1e+99 is
-// outside the range of representable values of type 'float'" with Clang prior 
to
-// 

 "Treat the
-// range of representable values of floating-point types as [-inf, +inf] not 
as [-max, +max]"
-// (ENABLE_RUNTIME_OPTIMIZATIONS is an approximation for checking whether 
building is done without
-// -fsanitize=undefined):
 float doubleToFloat(double x) {
-#if !defined __clang__ || __clang_major__ >= 9 || ENABLE_RUNTIME_OPTIMIZATIONS
 return static_cast(x);
-#else
-return
-x < -std::numeric_limits::max()
-? -std::numeric_limits::infinity()
-: x > std::numeric_limits::max()
-? std::numeric_limits::infinity()
-: static_cast(x);
-#endif
 }
 
 }
diff --git a/sal/rtl/ustring.cxx b/sal/rtl/ustring.cxx
index ed039c4685da..6bc595b7f3bf 100644
--- a/sal/rtl/ustring.cxx
+++ b/sal/rtl/ustring.cxx
@@ -97,23 +97,8 @@ sal_Int32 SAL_CALL rtl_ustr_valueOfDouble(sal_Unicode * 
pStr, double d)
 
 namespace {
 
-// Avoid -fsanitize=undefined warning e.g. "runtime error: value 1e+99 is
-// outside the range of representable values of type 'float'" with Clang prior 
to
-// 

 "Treat the
-// range of representable values of floating-point types as [-inf, +inf] not 
as [-max, +max]"
-// (ENABLE_RUNTIME_OPTIMIZATIONS is an approximation for checking whether 
building is done without
-// -fsanitize=undefined):
 float doubleToFloat(double x) {
-#if !defined __clang__ || __clang_major__ >= 9 || ENABLE_RUNTIME_OPTIMIZATIONS
 return static_cast(x);
-#else
-return
-x < -std::numeric_limits::max()
-? -std::numeric_limits::infinity()
-: x > std::numeric_limits::max()
-? std::numeric_limits::infinity()
-: static_cast(x);
-#endif
 }
 
 }

[Libreoffice-commits] core.git: chart2/source include/cppcanvas o3tl/qa sal/qa svx/source sw/inc sw/source vcl/source vcl/unx

2023-09-24 Thread Stephan Bergmann (via logerrit) 
 chart2/source/inc/DataSeries.hxx  |2 -
 chart2/source/inc/Diagram.hxx |2 -
 include/cppcanvas/canvas.hxx  |2 -
 o3tl/qa/test-string_view.cxx  |4 --
 sal/qa/rtl/strings/test_ostring_concat.cxx|   14 --
 sal/qa/rtl/strings/test_oustring_concat.cxx   |7 -
 svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx |2 -
 sw/inc/calbck.hxx |4 +-
 sw/source/core/txtnode/modeltoviewhelper.cxx  |4 +-
 vcl/source/filter/png/PngImageReader.cxx  |7 -
 vcl/unx/generic/fontmanager/fontconfig.cxx|7 -
 11 files changed, 5 insertions(+), 50 deletions(-)

New commits:
commit 72da78be20ebe1cd62ba7a5ac6e29b9d40f00f15
Author: Stephan Bergmann 
AuthorDate: Sun Sep 24 11:57:35 2023 +0300
Commit: Stephan Bergmann 
CommitDate: Sun Sep 24 17:31:16 2023 +0200

Drop some newly obsolete __GNUC__ version checks

...after 6ef2d358ac053ce0f6de9cf0f8f25e8bae66d441 "Adapt Clang and GCC 
minimum
version checks"

Change-Id: I5f3bcda2ce8e0e093af3bdd9d2cca741a5b95306
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157202
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/chart2/source/inc/DataSeries.hxx b/chart2/source/inc/DataSeries.hxx
index 932fcd836b9a..e643486d5992 100644
--- a/chart2/source/inc/DataSeries.hxx
+++ b/chart2/source/inc/DataSeries.hxx
@@ -61,9 +61,7 @@ typedef ::cppu::WeakImplHelper<
 }
 
 class OOO_DLLPUBLIC_CHARTTOOLS DataSeries
-#if !defined __GNUC__ || __GNUC__ >= 12 || defined __clang__
 final
-#endif
 : public impl::DataSeries_Base
 , public ::property::OPropertySet
 {
diff --git a/chart2/source/inc/Diagram.hxx b/chart2/source/inc/Diagram.hxx
index 65532a9a512d..1d3e8bd78901 100644
--- a/chart2/source/inc/Diagram.hxx
+++ b/chart2/source/inc/Diagram.hxx
@@ -73,9 +73,7 @@ typedef ::cppu::WeakImplHelper<
 }
 
 class OOO_DLLPUBLIC_CHARTTOOLS Diagram
-#if !defined __GNUC__ || __GNUC__ >= 12 || defined __clang__
 final
-#endif
 : public impl::Diagram_Base
 , public ::property::OPropertySet
 {
diff --git a/include/cppcanvas/canvas.hxx b/include/cppcanvas/canvas.hxx
index 97562ede24fb..2fce102824dd 100644
--- a/include/cppcanvas/canvas.hxx
+++ b/include/cppcanvas/canvas.hxx
@@ -68,9 +68,7 @@ namespace cppcanvas
 Canvas(Canvas const &) = default;
 Canvas(Canvas &&) = default;
 Canvas & operator =(Canvas const &) = default;
-#if !(defined __GNUC__ && !defined __clang__ && __GNUC__ == 8) // bogus 
-Werror=virtual-move-assign
 Canvas & operator =(Canvas &&) = default;
-#endif
 
 virtual ~Canvas() {}
 
diff --git a/o3tl/qa/test-string_view.cxx b/o3tl/qa/test-string_view.cxx
index bbe5cbf0eddc..c534adbd945f 100644
--- a/o3tl/qa/test-string_view.cxx
+++ b/o3tl/qa/test-string_view.cxx
@@ -20,9 +20,6 @@
 #include 
 #include 
 
-// gcc 11.2.0 triggers a spurious -Werror=stringop-overread
-#if !(defined __GNUC__ && __GNUC__ == 11 && __GNUC_MINOR__ == 2)
-
 template <>
 inline std::string
 CppUnit::assertion_traits::toString(std::u16string_view 
const& x)
@@ -752,6 +749,5 @@ private:
 
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 }
-#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s 
cinkeys+=0=break: */
diff --git a/sal/qa/rtl/strings/test_ostring_concat.cxx 
b/sal/qa/rtl/strings/test_ostring_concat.cxx
index 11bf8ebf80af..f7bc41e3cf95 100644
--- a/sal/qa/rtl/strings/test_ostring_concat.cxx
+++ b/sal/qa/rtl/strings/test_ostring_concat.cxx
@@ -64,23 +64,9 @@ void test::ostring::StringConcat::checkConcat()
 CPPUNIT_ASSERT_EQUAL( OString( "foobar" ), OString( OStringBuffer( "foo" ) 
+ "bar" ));
 CPPUNIT_ASSERT_EQUAL(( typeid( OStringConcat< OStringBuffer, const char[ 4 
] > )), typeid( OStringBuffer( "foo" ) + "bar" ));
 CPPUNIT_ASSERT_EQUAL( OString( "foobar" ), OString( OStringLiteral( "foo" 
) + "bar" ));
-#if defined __GNUC__ && __GNUC__ <= 11 && !defined __clang__
-CPPUNIT_ASSERT_EQUAL(( typeid( OStringConcat< OStringLiteral<4>, const 
char[ 4 ] > )), typeid( OStringLiteral<4>( "foo" ) + "bar" ));
-// the explicit OStringLiteral<4> template argument in the unevaluated 
typeid context
-// is needed by some GCC versions, see 

-// "Failed class template argument deduction in unevaluated, 
parenthesized context"
-#else
 CPPUNIT_ASSERT_EQUAL(( typeid( OStringConcat< OStringLiteral<4>, const 
char[ 4 ] > )), typeid( OStringLiteral( "foo" ) + "bar" ));
-#endif
 CPPUNIT_ASSERT_EQUAL( OString( "foobar" ), OString( OStringLiteral( "foo" 
) + static_cast("bar") ));
-#if defined __GNUC__ && __GNUC__ <= 11 && !defined __clang__
-CPPUNIT_ASSERT_EQUAL(( typeid( OStringConcat< OStri

[Libreoffice-commits] core.git: vcl/source

2023-09-24 Thread Andrea Gelmini (via logerrit) 
 vcl/source/outdev/gradient.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 23de37d22c9fecbcffdcf4eb02c926f0f9403d5e
Author: Andrea Gelmini 
AuthorDate: Sun Sep 24 17:12:40 2023 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 24 17:24:24 2023 +0200

Fix typo

Change-Id: I88c3e9f36c38bd31cd78871d5e86c607ebb39211
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157209
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/vcl/source/outdev/gradient.cxx b/vcl/source/outdev/gradient.cxx
index ef4f883c20d2..52359a779061 100644
--- a/vcl/source/outdev/gradient.cxx
+++ b/vcl/source/outdev/gradient.cxx
@@ -162,7 +162,7 @@ void OutputDevice::ClipAndDrawGradientMetafile ( const 
Gradient &rGradient, cons
 EnableOutput( false );
 #if HAVE_FEATURE_SKIA
 // tdf#156539 Draw the gradient with polypolygonal clip when using Skia
-// For some unkown reason, the previous "draw gradient with XOR, draw
+// For some unknown reason, the previous "draw gradient with XOR, draw
 // polygon with N0, and draw gradient again with XOR" does not work
 // with Skia/Raster (at least on macOS). Fortunately, Skia supports
 // polypolygonal clipping so just clip and draw the gradient.

[Libreoffice-commits] core.git: librelogo/source

2023-09-24 Thread Julien Nabet (via logerrit) 
 librelogo/source/LibreLogo/LibreLogo.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 553e09879b1ed20f09224582ab904b6ab1646259
Author: Julien Nabet 
AuthorDate: Sun Sep 24 12:14:43 2023 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 24 13:32:45 2023 +0200

tdf#157388: LibreLogo sqrt undefined

Change-Id: Ief68aa9067e3c817f9ce5694ce015ca9049b4375
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157206
Reviewed-by: Julien Nabet 
Tested-by: Jenkins

diff --git a/librelogo/source/LibreLogo/LibreLogo.py 
b/librelogo/source/LibreLogo/LibreLogo.py
index 1cab5ec96cb4..dca6356026bb 100644
--- a/librelogo/source/LibreLogo/LibreLogo.py
+++ b/librelogo/source/LibreLogo/LibreLogo.py
@@ -194,7 +194,7 @@ class __Doc__:
 self.fontstyle = 0
 self.points = []
 
-from math import pi, sin, cos, asin, log10, hypot
+from math import pi, sin, cos, asin, log10, hypot, sqrt
 
 from com.sun.star.awt import Point as __Point__
 from com.sun.star.awt import Gradient as __Gradient__

[Libreoffice-commits] core.git: Repository.mk

2023-09-24 Thread Julien Nabet (via logerrit) 
 Repository.mk |1 -
 1 file changed, 1 deletion(-)

New commits:
commit be637958995db309782c7e1a8cc4a80a5d30c9a6
Author: Julien Nabet 
AuthorDate: Sun Sep 24 10:59:15 2023 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 24 12:00:34 2023 +0200

Blind fix for TBs sd_web error

"blind" because I don't reproduce this on pc Debian x86-64 with master 
sources updated today
+ "make clean && make"

It might be since 
https://cgit.freedesktop.org/libreoffice/core/commit/?id=28b6480c6bdd179f3943f768926b7f196226c768
tdf#105303: Drop html export wizard

Change-Id: Ib5b705a6f98d7e88d84217906b32c371aac96d8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157203
Reviewed-by: Julien Nabet 
Tested-by: Julien Nabet 

diff --git a/Repository.mk b/Repository.mk
index e26116336b2a..4d0e424f3314 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -973,7 +973,6 @@ $(eval $(call gb_Helper_register_packages_for_install,ooo,\
oox_customshapes \
oox_generated \
package_dtd \
-   sd_web \
$(call gb_Helper_optional,DESKTOP,\
$(if $(filter-out WNT,$(OS)),$(if 
$(ENABLE_MACOSX_SANDBOX),,shell_senddoc))) \
$(call gb_Helper_optional,DESKTOP,$(if $(filter-out EMSCRIPTEN MACOSX 
WNT,$(OS)),svx_gengal)) \

[Libreoffice-commits] core.git: stoc/source

2023-09-24 Thread Julien Nabet (via logerrit) 
 stoc/source/proxy_factory/proxyfac.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit aaccb43dad5290cde04b36209ca9fa95d69ba060
Author: Julien Nabet 
AuthorDate: Sat Sep 23 10:37:54 2023 +0200
Commit: Julien Nabet 
CommitDate: Sun Sep 24 09:00:26 2023 +0200

tdf#157288: "Primary key" missing when right click a field during table 
edition

Revert partly 0c2b2c9babfd781e0d9d68bb2a14a045b0c6ec4c
"Use getXWeak in stoc"

Change-Id: I0344510dee33c8740937354d64c0e60115606d26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157178
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/stoc/source/proxy_factory/proxyfac.cxx 
b/stoc/source/proxy_factory/proxyfac.cxx
index 2653363b3c36..6745d0163c70 100644
--- a/stoc/source/proxy_factory/proxyfac.cxx
+++ b/stoc/source/proxy_factory/proxyfac.cxx
@@ -292,7 +292,8 @@ Any ProxyRoot::queryAggregation( Type const & rType )
 OSL_ASSERT( cpp_env != nullptr );
 
 // mind a new delegator, calculate current root:
-Reference< XInterface > xRoot(getXWeak());
+Reference< XInterface > xRoot(
+static_cast< OWeakObject * >(this), UNO_QUERY_THROW );
 OUString oid;
 (*cpp_env->getObjectIdentifier)( cpp_env, &oid.pData, xRoot.get() 
);
 OSL_ASSERT( !oid.isEmpty() );