[Libreoffice-commits] core.git: canvas/source
canvas/source/vcl/canvashelper.cxx | 42 ++---
1 file changed, 35 insertions(+), 7 deletions(-)
New commits:
commit 4cf636fab338ad759e1a23bb8570cc9351ded0d0
Author: Patrick Luby
AuthorDate: Tue Oct 24 18:52:08 2023 -0400
Commit: Noel Grandin
CommitDate: Wed Oct 25 07:51:13 2023 +0200
tdf#157790 invert alpha mask
Due to commit 81994cb2b8b32453a92bcb011830fcb884f22ff3,
the alpha mask needs to be inverted.
Change-Id: I4771c5f6f3a08fb210b62a0533df895a4a476058
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158410
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/canvas/source/vcl/canvashelper.cxx
b/canvas/source/vcl/canvashelper.cxx
index cbbd18a376d9..0e4dfdbf633f 100644
--- a/canvas/source/vcl/canvashelper.cxx
+++ b/canvas/source/vcl/canvashelper.cxx
@@ -731,13 +731,25 @@ namespace vclcanvas
mpOutDevProvider->getOutDev().DrawTransformedBitmapEx(
aMatrix, aBmpEx, fAlpha );
if( mp2ndOutDevProvider )
{
-// HACK. Normally, CanvasHelper does not care about
-// actually what mp2ndOutDev is... well, here we do &
-// assume a 1bpp target - everything beyond 97%
-// transparency is fully transparent
-if( aBmpEx.IsAlpha() && !SkiaHelper::isVCLSkiaEnabled())
+if( aBmpEx.IsAlpha() )
{
-BitmapFilter::Filter(aBmpEx,
BitmapAlphaClampFilter(253));
+// tdf#157790 invert alpha mask
+// Due to commit
81994cb2b8b32453a92bcb011830fcb884f22ff3,
+// the alpha mask needs to be inverted. Note: when
+// testing tdf#157790, this code only gets executed
+// when Skia is enabled.
+AlphaMask aAlpha( aBmpEx.GetAlphaMask() );
+aAlpha.Invert();
+aBmpEx = BitmapEx( aBmpEx.GetBitmap(), aAlpha );
+
+// HACK. Normally, CanvasHelper does not care about
+// actually what mp2ndOutDev is... well, here we do &
+// assume a 1bpp target - everything beyond 97%
+// transparency is fully transparent
+if( !SkiaHelper::isVCLSkiaEnabled())
+{
+BitmapFilter::Filter(aBmpEx,
BitmapAlphaClampFilter(253));
+}
}
mp2ndOutDevProvider->getOutDev().DrawTransformedBitmapEx(
aMatrix, aBmpEx );
@@ -839,10 +851,26 @@ namespace vclcanvas
);
if( mp2ndOutDevProvider )
-pGrfObj->Draw(mp2ndOutDevProvider->getOutDev(),
+{
+GraphicObjectSharedPtr p2ndGrfObj = pGrfObj;
+if( aBmpEx.IsAlpha() )
+{
+// tdf#157790 invert alpha mask
+// Due to commit
81994cb2b8b32453a92bcb011830fcb884f22ff3,
+// the alpha mask needs to be inverted. Note: when
+// testing tdf#157790, this code only gets executed
+// when Skia is disabled.
+AlphaMask aAlpha( aBmpEx.GetAlphaMask() );
+aAlpha.Invert();
+BitmapEx a2ndBmpEx( aBmpEx.GetBitmap(), aAlpha );
+p2ndGrfObj = std::make_shared(
a2ndBmpEx );
+}
+
+p2ndGrfObj->Draw(mp2ndOutDevProvider->getOutDev(),
aPt,
aSz,
);
+}
// created GraphicObject, which possibly cached
// display bitmap - return cache object, to retain
[Libreoffice-bugs] [Bug 157890] LibreOffice conversion from ODT to DOCX - fontsize is wrong after conversion for empty lines
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 BogdanB changed: What|Removed |Added Summary|libreoffice conversion from |LibreOffice conversion from |odt to docx - fontsize is |ODT to DOCX - fontsize is |not correct converted for |wrong after conversion for |empty text |empty lines -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 BogdanB changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #7 from BogdanB --- Confirm this bug with Version: 7.6.0.3 (X86_64) / LibreOffice Community Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win Locale: ro-RO (en_US); UI: en-US Calc: threaded Steps to reproduce: - Open the file from comment 5. Lines 2-5 are 6pt. - Save as Word 2010-365 and File-Reload. Lines 2-5 are 11pt. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 --- Comment #6 from nhatthinh.p...@iress.com --- I am sorry open the attachment by LibreOffice Writer -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 --- Comment #5 from nhatthinh.p...@iress.com --- Created attachment 190403 --> https://bugs.documentfoundation.org/attachment.cgi?id=190403=edit Sample to test the issue Open this file by LibreOffice Calc with the version from 7.5.4.2 and greater. Then save it in *.docx Close all the document and then open the docx file to see the difference to. Please select View > Formatting Marks (Ctrl + F10) to check the difference easily. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 nhatthinh.p...@iress.com changed: What|Removed |Added Attachment #190402|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 --- Comment #4 from nhatthinh.p...@iress.com --- Created attachment 190402 --> https://bugs.documentfoundation.org/attachment.cgi?id=190402=edit Sample to test the issue -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157450] File is opened in read-only mode, when using an invalid file URL with backslashes on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=157450 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157689] XLSX Autofilter bug; all sheets contain autoFilter XML specs, but only the last sheet presents the filters
https://bugs.documentfoundation.org/show_bug.cgi?id=157689 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157691] MailMerge sends oversized pdf-attachments when mailing list > 200 recipients
https://bugs.documentfoundation.org/show_bug.cgi?id=157691 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154414] LibreOffice_7.5.1_Win_x86-64 cab file corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=154414 --- Comment #3 from QA Administrators --- Dear wekort, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154414] LibreOffice_7.5.1_Win_x86-64 cab file corrupt
https://bugs.documentfoundation.org/show_bug.cgi?id=154414 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154411] UI Freeze and OOM-kill on csv FILEOPEN if environment variable QT_SCREEN_SCALE_FACTORS is set
https://bugs.documentfoundation.org/show_bug.cgi?id=154411 --- Comment #3 from QA Administrators --- Dear pk, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 153468] The thickness of a shape created in PowerPoint 2007 changes.
https://bugs.documentfoundation.org/show_bug.cgi?id=153468 --- Comment #7 from QA Administrators --- Dear NISZ LibreOffice Team, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154249] Toggling page whitespace by double-clicking in between pages does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=154249 --- Comment #5 from QA Administrators --- Dear yaf...@yahoo.co.uk, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154216] Scroll region window object; capture tools inhibited
https://bugs.documentfoundation.org/show_bug.cgi?id=154216 --- Comment #4 from QA Administrators --- Dear NOYB, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147326] UI: "augmented reality" hovering mode (immediate display of underlying formulas etc.)
https://bugs.documentfoundation.org/show_bug.cgi?id=147326 --- Comment #10 from QA Administrators --- Dear Robert Lacroix, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 58082] Warning message "do you want to recalculate ..." when copy-paste cells from Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=58082 --- Comment #11 from QA Administrators --- Dear Rusbearing, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 46177] EDITING: Incorrect Behaviour of Direct Cursor in Right-Aligned Paragraphs
https://bugs.documentfoundation.org/show_bug.cgi?id=46177 --- Comment #15 from QA Administrators --- Dear Harald Koester, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 34955] Deleting numbering item which restarts numbering fails to retain restart
https://bugs.documentfoundation.org/show_bug.cgi?id=34955 --- Comment #13 from QA Administrators --- Dear sasha.libreoffice, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 122671] Impress: Lines don't connect/ align properly in slide show mode
https://bugs.documentfoundation.org/show_bug.cgi?id=122671 --- Comment #8 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 116338] PIVOT TABLE: Filter in drop-down list stops working after ungrouping or regrouping values
https://bugs.documentfoundation.org/show_bug.cgi?id=116338 --- Comment #7 from QA Administrators --- Dear Gilward Kukel, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g --- Comment #3 from BogdanB --- Please attach a demo document in order to test this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: configure.ac filter/Configuration_filter.mk filter/source sc/inc sc/source
configure.ac|2
filter/Configuration_filter.mk |2
filter/source/config/cache/typedetection.cxx|1
filter/source/config/fragments/filters/calc_Parquet.xcu | 19
filter/source/config/fragments/types/calc_Parquet.xcu | 17 +++
sc/inc/orcusfilters.hxx | 18 ++--
sc/source/filter/inc/orcusfiltersimpl.hxx |7 -
sc/source/filter/orcus/filterdetect.cxx |2
sc/source/filter/orcus/orcusfiltersimpl.cxx | 70 +---
sc/source/ui/docshell/docsh.cxx | 63 +-
10 files changed, 102 insertions(+), 99 deletions(-)
New commits:
commit b14583ba37a6d7ce398ccd3cf339f954785b03d8
Author: Kohei Yoshida
AuthorDate: Wed May 31 21:33:56 2023 -0400
Commit: Kohei Yoshida
CommitDate: Wed Oct 25 03:59:57 2023 +0200
Support conditional loading of Apache Parquet files into Calc
Also, use orcus::create_filter() and simplify the logic a bit. This
requires orcus 0.19.1 or newer.
Note that this change makes it possible to load Apache Parquet files
if and only if orcus has been built with the parquet import filter
enabled. Using orcus without the parquet import filter enabled will
not break the build or run-time behavior; you just can't load parquet
files.
Change-Id: I9f8820998b7b0667d1e7cd532c32b1c7e55ca999
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158411
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida
diff --git a/configure.ac b/configure.ac
index 999ab64289e8..c8466ae65e01 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10878,7 +10878,7 @@ fi
dnl ===
dnl Orcus
dnl ===
-libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.18 >= 0.18.0])
+libo_CHECK_SYSTEM_MODULE([orcus],[ORCUS],[liborcus-0.18 >= 0.19.1])
if test "$with_system_orcus" != "yes"; then
if test "$SYSTEM_BOOST" = "TRUE"; then
dnl Link with Boost.System
diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk
index bd3d3486234e..8a323e83fd54 100644
--- a/filter/Configuration_filter.mk
+++ b/filter/Configuration_filter.mk
@@ -477,6 +477,7 @@ $(eval $(call
filter_Configuration_add_types,fcfg_langpack,fcfg_calc_types.xcu,f
generic_Text \
calc_Gnumeric \
calc_Lotus \
+ calc_Parquet \
calc_QPro \
calc_MS_Excel_40 \
calc_MS_Excel_40_VorlageTemplate \
@@ -535,6 +536,7 @@ $(eval $(call
filter_Configuration_add_filters,fcfg_langpack,fcfg_calc_filters.x
calc_HTML_WebQuery \
calc_StarOffice_XML_Calc_Template \
calc_pdf_Export \
+ calc_Parquet \
dBase \
calc8 \
calc8_template \
diff --git a/filter/source/config/cache/typedetection.cxx
b/filter/source/config/cache/typedetection.cxx
index 18d13a8f7796..a83a1406d0c1 100644
--- a/filter/source/config/cache/typedetection.cxx
+++ b/filter/source/config/cache/typedetection.cxx
@@ -211,6 +211,7 @@ int getFlatTypeRank(std::u16string_view rType)
"calc_SYLK",
"calc_DIF",
"calc_dBase",
+"Apache Parquet",
// Binary (raster and vector image files)
"emf_MS_Windows_Metafile",
diff --git a/filter/source/config/fragments/filters/calc_Parquet.xcu
b/filter/source/config/fragments/filters/calc_Parquet.xcu
new file mode 100644
index ..5b0fea8257bb
--- /dev/null
+++ b/filter/source/config/fragments/filters/calc_Parquet.xcu
@@ -0,0 +1,19 @@
+
+
+IMPORT ALIEN PREFERRED
+
+
+
+Apache Parquet
+
+com.sun.star.sheet.SpreadsheetDocument
+
+Apache Parquet Spreadsheet
+
+
diff --git a/filter/source/config/fragments/types/calc_Parquet.xcu
b/filter/source/config/fragments/types/calc_Parquet.xcu
new file mode 100644
index ..6c29d886c92f
--- /dev/null
+++ b/filter/source/config/fragments/types/calc_Parquet.xcu
@@ -0,0 +1,17 @@
+
+
+com.sun.star.comp.sc.OrcusFilterDetect
+
+parquet
+
+true
+Apache Parquet
Spreadsheet
+Apache
Parquet
+
+
diff --git a/sc/inc/orcusfilters.hxx b/sc/inc/orcusfilters.hxx
index 6d17f3741ebb..f13f5cc630d2 100644
--- a/sc/inc/orcusfilters.hxx
+++ b/sc/inc/orcusfilters.hxx
@@ -25,17 +25,17 @@ namespace weld { class TreeView; }
class ScOrcusFilters
{
public:
-virtual ~ScOrcusFilters() {}
-
-virtual bool importCSV(ScDocument& rDoc, SfxMedium& rMedium) const = 0;
-
-virtual bool importGnumeric(ScDocument& rDoc, SfxMedium& rMedium) const =
0;
+enum class ImportResult
+{
+NotSupported,
+Success,
+Failure
+};
-virtual bool importExcel2003XML(ScDocument& rDoc, SfxMedium& rMedium)
const = 0;
-
-virtual bool importXLSX(ScDocument& rDoc, SfxMedium&
[Libreoffice-bugs] [Bug 157658] saving a change to password protected DOCX makes document unprotected
https://bugs.documentfoundation.org/show_bug.cgi?id=157658 schmidtnot...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from schmidtnot...@gmail.com --- [I wanted to send a reply to your email inquiry by email with a screenshot attached, but that email was rejected. So I paste my email here, albeit without the graphic since this field does not accept graphics. I hope it is helpful to you anyway. Thanks for your efforts.] Yes, the password was originally set in Microsoft Office, but the file has since been Saved As… in Libre Office, which allows for the restoration of the password by newly adding it again. So it actually has been set in LibreOffice. I cannot send the file in question since it is password protected because it contains confidential information. I see you tested in MacOS 13.2.1. I run MacOS 13.6. To reliably reproduce the bug, I close the changed document by clicking on the red Close button (top left corner of document window), which leads to the dialog box shown below. Clicking “Save” in that dialog closes the document, with the change saved. Reopening that file does not require the password. PastedGraphic-2.tiff You ask for pasting "the full information copied from Help > About LibreOffice." That is not how it appears on my Mac. The Help menu has no About LibreOffice. About LibreOffice can be found under the LibreOffice menu as the very first entry. It has a Version Information button, which offers this information: Version: 7.5.7.1 (AARCH64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 8; OS: Mac OS X 13.6; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Thanks again for your interest and attention. —Henning On Oct 22, 2023, at 16:42, bugzilla-dae...@bugs.documentfoundation.org wrote: Stéphane Guillou (stragu) changed bug 157658 What Removed Added Ever confirmed 1 CC stephane.guil...@libreoffice.org Status UNCONFIRMED NEEDINFO Summary saving a change to password protected document makes document unprotected saving a change to password protected DOCX makes document unprotected Comment # 3 on bug 157658 from Stéphane Guillou (stragu) Can't reproduce either in: Version: 7.5.7.1 (X86_64) / LibreOffice Community Build ID: 47eb0cf7efbacdee9b19ae25d6752381ede23126 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Nor on macOS: Version: 7.5.4.2 (X86_64) / LibreOffice Community Build ID: 36ccfdc35048b057fd9854c757a8b67ec53977b6 CPU threads: 2; OS: Mac OS X 13.2.1; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Was the password set originally with MS Office or with LibreOffice? Can you maybe attach an example file? Please also paste here the full information copied from Help > About LibreOffice. You are receiving this mail because: • You reported the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157083] Artifacts in logos (gen)
https://bugs.documentfoundation.org/show_bug.cgi?id=157083 --- Comment #6 from Patrick Luby --- (In reply to Xisco Faulí from comment #5) > (In reply to Noel Grandin from comment #4) > > This seems to be fixed now, probably with one of Patrick's patches > > The issue is still reproducible in > > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 3649dc202bedf72e37c77993a1f7027bfdfc6d9e > CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: x11 > Locale: es-ES (es_ES.UTF-8); UI: en-US > Calc: threaded > > See the black border around the logo I am not seeing this bug on macOS in my local master build. I tested with Skia/Metal, Skia/Raster, and Skia disabled and all render the LibreOffice logo correctly in the Start Center: Version: 24.2.0.0.alpha0+ (AARCH64) / LibreOffice Community Build ID: 3d58f3c0c22a972097956f781c51c2822e6d524f CPU threads: 8; OS: macOS 14.0; UI render: default; VCL: osx Locale: en-CA (en_CA.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157890] libreoffice conversion from odt to docx - fontsize is not correct converted for empty text
https://bugs.documentfoundation.org/show_bug.cgi?id=157890 nhatthinh.p...@iress.com changed: What|Removed |Added Component|LibreOffice |Writer OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: download.lst external/liborcus
download.lst |4 +-
external/liborcus/UnpackedTarball_liborcus.mk |2 -
external/liborcus/gnumeric-set-grammar.patch.1 | 17
external/liborcus/msvc-int-narrowing.patch.1 | 50 -
4 files changed, 2 insertions(+), 71 deletions(-)
New commits:
commit b5d194d1d37131f921853b78d659c63178de2bc6
Author: Kohei Yoshida
AuthorDate: Tue Oct 24 18:31:52 2023 -0400
Commit: Kohei Yoshida
CommitDate: Wed Oct 25 01:33:12 2023 +0200
Upgrade liborcus to 0.19.1
Change-Id: I2190419e88323bbf000602a7762e850a33b5dfdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158409
Tested-by: Jenkins
Reviewed-by: Kohei Yoshida
diff --git a/download.lst b/download.lst
index 07b4934cf760..5aeeb74a6cdc 100644
--- a/download.lst
+++ b/download.lst
@@ -498,8 +498,8 @@ OPENSSL_TARBALL := openssl-3.0.11.tar.gz
# three static lines
# so that git cherry-pick
# will not run into conflicts
-ORCUS_SHA256SUM :=
1b68f54bb08face4c3dc83c912d921373c44aed817b37d879b7a4e47f2f15e09
-ORCUS_TARBALL := liborcus-0.19.0.tar.xz
+ORCUS_SHA256SUM :=
6c9a8c03e8187f2749a84f2786d86a88ae45c99ed3a2d5fea36ba556b40c342d
+ORCUS_TARBALL := liborcus-0.19.1.tar.xz
# three static lines
# so that git cherry-pick
# will not run into conflicts
diff --git a/external/liborcus/UnpackedTarball_liborcus.mk
b/external/liborcus/UnpackedTarball_liborcus.mk
index 292435dfd00d..5968c7bb1845 100644
--- a/external/liborcus/UnpackedTarball_liborcus.mk
+++ b/external/liborcus/UnpackedTarball_liborcus.mk
@@ -20,8 +20,6 @@ $(eval $(call gb_UnpackedTarball_add_patches,liborcus,\
external/liborcus/gcc9.patch.0 \
external/liborcus/libtool.patch.0 \
external/liborcus/liborcus_newline.patch.1 \
- external/liborcus/msvc-int-narrowing.patch.1 \
- external/liborcus/gnumeric-set-grammar.patch.1 \
))
ifeq ($(OS),WNT)
diff --git a/external/liborcus/gnumeric-set-grammar.patch.1
b/external/liborcus/gnumeric-set-grammar.patch.1
deleted file mode 100644
index 42bc46177737..
--- a/external/liborcus/gnumeric-set-grammar.patch.1
+++ /dev/null
@@ -1,17 +0,0 @@
-diff --git a/src/liborcus/orcus_gnumeric.cpp b/src/liborcus/orcus_gnumeric.cpp
-index 76c13682..849759ba 100644
a/src/liborcus/orcus_gnumeric.cpp
-+++ b/src/liborcus/orcus_gnumeric.cpp
-@@ -144,6 +144,12 @@ void orcus_gnumeric::read_stream(std::string_view stream)
- if (!decompress_gzip(stream.data(), stream.size(), file_content))
- return;
-
-+if (auto* gs = mp_impl->mp_factory->get_global_settings(); gs)
-+{
-+gs->set_origin_date(1899, 12, 30);
-+
gs->set_default_formula_grammar(spreadsheet::formula_grammar_t::gnumeric);
-+}
-+
- mp_impl->read_content_xml(file_content, get_config());
- mp_impl->mp_factory->finalize();
- }
diff --git a/external/liborcus/msvc-int-narrowing.patch.1
b/external/liborcus/msvc-int-narrowing.patch.1
deleted file mode 100644
index 1075cebfdef3..
--- a/external/liborcus/msvc-int-narrowing.patch.1
+++ /dev/null
@@ -1,50 +0,0 @@
-Fix
-
- error C2398: Element '2': conversion from 'int' to 'const
std::basic_string_view>::size_type'
- requires a narrowing conversion
-
-diff --git a/src/liborcus/gnumeric_value_format_parser.cpp
b/src/liborcus/gnumeric_value_format_parser.cpp
-index 822c1ba1..014068e9 100644
a/src/liborcus/gnumeric_value_format_parser.cpp
-+++ b/src/liborcus/gnumeric_value_format_parser.cpp
-@@ -12,6 +12,10 @@
- #include
- #include
-
-+#include
-+
-+using boost::numeric_cast;
-+
- namespace orcus {
-
- std::size_t gnumeric_value_format_parser::get_pos() const
-@@ -41,7 +45,8 @@ void gnumeric_value_format_parser::segment()
- if (pos != 2)
- throw parse_error("value format segment is not formatted
properly", get_pos());
-
--std::string_view s{p0, std::distance(p0, m_cur)};
-+auto n = std::distance(p0, m_cur);
-+std::string_view s{p0, numeric_cast(n)};
- if (s.empty())
- throw parse_error("segment value is empty", get_pos());
-
-@@ -51,7 +56,8 @@ void gnumeric_value_format_parser::segment()
- }
- case '=':
- {
--std::string_view s{p0, std::distance(p0, m_cur)};
-+auto n = std::distance(p0, m_cur);
-+std::string_view s{p0, numeric_cast(n)};
- seg.type = to_gnumeric_value_format_type(s);
- if (seg.type == gnumeric_value_format_type::unknown)
- {
-@@ -65,7 +71,8 @@ void gnumeric_value_format_parser::segment()
- }
- case ':':
- {
--std::string_view s{p0, std::distance(p0, m_cur)};
-+auto n = std::distance(p0, m_cur);
-+std::string_view s{p0, numeric_cast(n)};
-
- switch (pos)
- {
[Libreoffice-bugs] [Bug 144444] [UI] Inconsistency in UI for curve points
https://bugs.documentfoundation.org/show_bug.cgi?id=14 --- Comment #5 from Adolfo Jayme Barrientos --- A command name should be written in Title Case. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 114441] Convert use of sal_uLong to better integer types
https://bugs.documentfoundation.org/show_bug.cgi?id=114441 --- Comment #72 from Hossein --- Updated statistics, created with the script in comment 58: $ ./count.sh | sort -h 1: dbaccess/ 1: unotools/ 2: drawinglayer/ 3: framework/ 6: svl/ 8: svx/ 11: toolkit/ 13: compilerplugins/ 25: starmath/ 31: svtools/ 34: filter/ 62: include/ 111: sd/ 416: vcl/ 592: sc/ 635: sw/ Total: $ git grep sal_uLong|wc -l 1956 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157906] Named ranged are lost when we convert from ods to xlsx
https://bugs.documentfoundation.org/show_bug.cgi?id=157906 --- Comment #3 from nhatthinh.p...@iress.com --- Thank you for your reply. I will test it when I can download that version. Currently, I cannot find it from the pre-release. Thinh -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157911] New: Wrong borders for tables splitted in multiple pages
https://bugs.documentfoundation.org/show_bug.cgi?id=157911 Bug ID: 157911 Summary: Wrong borders for tables splitted in multiple pages Product: LibreOffice Version: 7.6.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nick1...@gmail.com Created attachment 190401 --> https://bugs.documentfoundation.org/attachment.cgi?id=190401=edit Table border error can be easily seen. Even if only an external border for a table is selected, the borders will be formatted wrong. The problem is present even when exporting to PDF. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'libreoffice-7-6' - sw/source
sw/source/core/layout/paintfrm.cxx |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit 7ac1eada88ff81830bb0d36cda4a902084b5f8d9
Author: Michael Stahl
AuthorDate: Fri Oct 20 17:33:42 2023 +0200
Commit: Adolfo Jayme Barrientos
CommitDate: Tue Oct 24 23:56:06 2023 +0200
tdf#157145 sw: PDF/UA export: tag borders as Artifacts
(probably regression from commit 804d0a896731629397c5328c13c04a45bc55f459
moving the ProcessPrimitives to SwRootFrame::PaintSwFrame())
Change-Id: I4015ffe6566c94e9f3b3694d39e0c24797cb9039
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158266
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit e9ca8fb1af1e3d41160c13e8002f05a610a0bd0b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158281
Reviewed-by: Adolfo Jayme Barrientos
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index bd07aa9e1675..8242a99634f2 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -3514,7 +3514,10 @@ void SwRootFrame::PaintSwFrame(vcl::RenderContext&
rRenderContext, SwRect const&
// fdo#42750: delay painting these until after subsidiary lines
// fdo#45562: delay painting these until after hell layer
// fdo#47717: but do it before heaven layer
-ProcessPrimitives(gProp.pBLines->GetBorderLines_Clear());
+{
+SwTaggedPDFHelper tag(nullptr, nullptr, nullptr,
rRenderContext);
+ProcessPrimitives(gProp.pBLines->GetBorderLines_Clear());
+}
if ( pSh->Imp()->HasDrawView() )
{
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/strtmpl.hxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 3d58f3c0c22a972097956f781c51c2822e6d524f
Author: Stephan Bergmann
AuthorDate: Tue Oct 24 21:43:29 2023 +0200
Commit: Stephan Bergmann
CommitDate: Tue Oct 24 22:46:25 2023 +0200
Use requires-clauses
Change-Id: I27c990f27023aba5e77c6b406d7dbdcc898054ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158405
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/sal/rtl/strtmpl.hxx b/sal/rtl/strtmpl.hxx
index bb49cfaf0aa4..6414115d4174 100644
--- a/sal/rtl/strtmpl.hxx
+++ b/sal/rtl/strtmpl.hxx
@@ -229,12 +229,12 @@ sal_Int32 compare(S1 s1, S2 s2, Compare, Shorten_t
shortenedLength)
}
// take advantage of builtin optimisations
-template = 0>
+template requires (sizeof(C) == sizeof(wchar_t))
sal_Int32 compare(null_terminated s1, null_terminated s2, CompareNormal,
NoShortening)
{
return wcscmp(reinterpret_cast(s1.p),
reinterpret_cast(s2.p));
}
-template = 0>
+template requires (sizeof(C) == sizeof(char))
sal_Int32 compare(null_terminated s1, null_terminated s2, CompareNormal,
NoShortening)
{
return strcmp(reinterpret_cast(s1.p), reinterpret_cast(s2.p));
[Libreoffice-bugs] [Bug 124296] Writer: Link underscore disappears on edit
https://bugs.documentfoundation.org/show_bug.cgi?id=124296 Kira Tubo changed: What|Removed |Added CC||kira.t...@gmail.com --- Comment #7 from Kira Tubo --- Reproduced in: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded Interestingly, this is only reproducible if the link is first word in the line. If the link is sandwiched in between words, for example, the issue is not reproducible. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 142795] Sized-to-fit object sometimes not resized when text font size changes
https://bugs.documentfoundation.org/show_bug.cgi?id=142795 Eyal Rozenberg changed: What|Removed |Added Resolution|--- |WORKSFORME Status|UNCONFIRMED |RESOLVED --- Comment #9 from Eyal Rozenberg --- Can't reproduce at the moment - but this is mostly for lack of trying :-( Anyway, closing. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 121010] [META] Font size bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=121010 Bug 121010 depends on bug 142795, which changed state. Bug 142795 Summary: Sized-to-fit object sometimes not resized when text font size changes https://bugs.documentfoundation.org/show_bug.cgi?id=142795 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147895] Crash in: GrVkPipeline::SetDynamicBlendConstantState(GrVkGpu *, GrVkCommandBuffer *, GrSwizzle const &, GrXferProcessor const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=147895 Stéphane Guillou (stragu) changed: What|Removed |Added OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148624] Crash in: GrVkPipelineState::setAndBindInputAttachment(GrVkGpu *,gr_sp
https://bugs.documentfoundation.org/show_bug.cgi?id=148624 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7895 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147895] Crash in: GrVkPipeline::SetDynamicBlendConstantState(GrVkGpu *, GrVkCommandBuffer *, GrSwizzle const &, GrXferProcessor const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=147895 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8624 Status|UNCONFIRMED |NEEDINFO Version|unspecified |7.3.1.3 release CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 --- Comment #6 from Stéphane Guillou (stragu) --- Looks like the crash signature was last been seen in 7.3.4.2. Can you please test a recent version to see if you can still reproduce the crash? I'd say it was resolved by the fix for bug 148624, landed in 7.3.5. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147820] LibreOffice crashes when trying to rename file for new save
https://bugs.documentfoundation.org/show_bug.cgi?id=147820 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org --- Comment #8 from Stéphane Guillou (stragu) --- Not reproduced either on Ubuntu 20.02 with: Version: 6.4.7.2 Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Nor with 7.6.2.1. Can you please test with a recent version, preferably the latest of 7.6? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4ec29bf35eceddbc015b0b2631cf80453f49c2de Author: Olivier Hallot AuthorDate: Tue Oct 24 17:29:11 2023 -0300 Commit: Gerrit Code Review CommitDate: Tue Oct 24 22:29:11 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to 2250a507ab35df482392e9f1fe297bb57f300af9 - tdf#153986 Drop "Numbering" from the label in bullet list Format/Tools Change-Id: Id7b604a6c1532b4799c7ec658b1a1f9e25b4c972 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158408 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index e423f2a7995d..2250a507ab35 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit e423f2a7995db5bd4da002309afdd5efaf06af21 +Subproject commit 2250a507ab35df482392e9f1fe297bb57f300af9
[Libreoffice-commits] help.git: source/text
source/text/shared/01/06050600.xhp | 71 - source/text/swriter/01/legacynumbering.xhp | 42 - 2 files changed, 61 insertions(+), 52 deletions(-) New commits: commit 2250a507ab35df482392e9f1fe297bb57f300af9 Author: Olivier Hallot AuthorDate: Tue Oct 24 17:26:41 2023 -0300 Commit: Olivier Hallot CommitDate: Tue Oct 24 22:29:11 2023 +0200 tdf#153986 Drop "Numbering" from the label in bullet list Format/Tools Change-Id: Id7b604a6c1532b4799c7ec658b1a1f9e25b4c972 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158408 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/01/06050600.xhp b/source/text/shared/01/06050600.xhp index c08b911ab1..a8adfd731c 100644 --- a/source/text/shared/01/06050600.xhp +++ b/source/text/shared/01/06050600.xhp @@ -20,66 +20,75 @@ -Position (Lists) +Position (Lists) /text/shared/01/06050600.xhp + + + - - - - Position -Set indent, spacing, and alignment options for numbering symbols, such as numbers or bullets, to ordered and unordered lists. +Set indent, spacing, and alignment options for numbering symbols, such as numbers or bullets, to ordered and unordered lists. + do we have a how-to for numbering/bullets/outlines with/without styles? seems we really need one + + + - - Level -Select the level(s) that you want to modify. To apply the options to all the levels, select “1-10”. +Select the level(s) that you want to modify. To apply the options to all the levels, select “1-10”. - + + Position and Spacing -This page shows the position controls used in all versions of %PRODUCTNAME Writer. Some documents (produced by other applications) use another method for positioning and spacing. Opening such documents will show the position controls documented in Position for List styles (legacy).see http://specs.openoffice.org/writer/numbering/NewListLevelAttrs.odt - + +This page shows the position controls used in all versions of %PRODUCTNAME Writer. Some documents (produced by other applications) use another method for positioning and spacing. Opening such documents will show the position controls documented in Position for List styles (legacy).see http://specs.openoffice.org/writer/numbering/NewListLevelAttrs.odt + + Aligned at -Enter the distance from the left page margin at which the numbering symbol will be aligned. +Enter the distance from the left page margin at which the numbering symbol will be aligned. + + + + - - - -Numbering alignment +Alignment -Set the alignment of the numbering symbols. Select "Left" to align the numbering symbol to start directly at the "Aligned at" position. Select "Right" to align the symbol to end directly before the "Aligned at" position. Select "Centered" to center the symbol around the "Aligned at" position. +Set the alignment of the numbering symbols. Select "Left" to align the numbering symbol to start directly at the "Aligned at" position. Select "Right" to align the symbol to end directly before the "Aligned at" position. Select "Centered" to center the symbol around the "Aligned at" position. + The Numbering alignment option does not set the alignment of the paragraph. -Numbering followed by -Select the element that will follow the numbering: a tab stop, a space, a line break, or nothing. - + +Followed by +Select the element that will follow the numbering: a tab stop, a space, a line break, or nothing. + Tab stop at -If you select a tab stop to follow the numbering, you can enter a non-negative value as the tab stop position. - +If you select a tab stop to follow the numbering, you can enter a non-negative value as the tab stop position. + Indent at -Enter the distance from the left page margin to the start of all lines in the numbered paragraph that follow the first line. +Enter the distance from the left page margin to the start of all lines in the numbered paragraph that follow the first line. + + - - Default -Resets the indent and the spacing values to the default values. +Resets the indent and the spacing values to the default values. + + @@ -91,14 +100,14 @@ -This control appears only when modifying a List style. +This control appears only when modifying a List style. -Position for List styles (legacy) -Paragraph alignment -Indenting Paragraphs +Position for List styles (legacy) +Paragraph alignment +Indenting Paragraphs diff --git a/source/text/swriter/01/legacynumbering.xhp b/source/text/swriter/01/legacynumbering.xhp index 4f3248ea2d..a307d0fa2d 100644 --- a/source/text/swriter/01/legacynumbering.xhp +++ b/source/text/swriter/01/legacynumbering.xhp @@ -11,17 +11,17 @@ -Position (List Styles - Legacy) +Position (List Styles - Legacy) /text/swriter/01/legacynumbering.xhp - + numbering;OpenOffice.org OpenOffice.org legacy numbering +
[Libreoffice-bugs] [Bug 144444] [UI] Inconsistency in UI for curve points
https://bugs.documentfoundation.org/show_bug.cgi?id=14 --- Comment #4 from Commit Notification --- Olivier Hallot committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/e423f2a7995db5bd4da002309afdd5efaf06af21 tdf#14 tdf#155877 Toggle edit points -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 155877] [LOCALHELP] - DRAW - Help pages about dialogs should provide instructions for the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=155877 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5a4837c6a291f2bb7d601ba21b796eedd82b49bd Author: Olivier Hallot AuthorDate: Tue Oct 24 17:28:19 2023 -0300 Commit: Gerrit Code Review CommitDate: Tue Oct 24 22:28:19 2023 +0200 Update git submodules * Update helpcontent2 from branch 'master' to e423f2a7995db5bd4da002309afdd5efaf06af21 - tdf#14 tdf#155877 Toggle edit points + toggle edit points Change-Id: Ieee6b0030ee4b001700443aa35ac87018ec1a7f5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158399 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 1077c8e56376..e423f2a7995d 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 1077c8e56376354dc108496b6d8f45f03ead021d +Subproject commit e423f2a7995db5bd4da002309afdd5efaf06af21
[Libreoffice-commits] help.git: source/text
source/text/shared/00/00040502.xhp | 36 ++-- source/text/shared/01/0527.xhp | 13 + 2 files changed, 31 insertions(+), 18 deletions(-) New commits: commit e423f2a7995db5bd4da002309afdd5efaf06af21 Author: Olivier Hallot AuthorDate: Tue Oct 24 15:10:12 2023 -0300 Commit: Olivier Hallot CommitDate: Tue Oct 24 22:28:18 2023 +0200 tdf#14 tdf#155877 Toggle edit points + toggle edit points Change-Id: Ieee6b0030ee4b001700443aa35ac87018ec1a7f5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158399 Tested-by: Jenkins Reviewed-by: Olivier Hallot diff --git a/source/text/shared/00/00040502.xhp b/source/text/shared/00/00040502.xhp index 2d32400294..b0abc5cb6f 100644 --- a/source/text/shared/00/00040502.xhp +++ b/source/text/shared/00/00040502.xhp @@ -291,24 +291,40 @@ Object - Position and Size - Slant Corner Radius tab. Choose Format - Text Box and Shape - Object - Position and Size - Callout tab. This is only available for textbox callouts, not for custom shapes callouts. + -Choose Edit - Points. -Open context menu - choose Edit Points. -Open context menu - choose Edit Points. -F8 keyF8 key - - + +Choose Edit - Toggle point edit mode. + +Toggle point edit mode + +Choose Draw - Toggle point edit mode. +On the Draw menu of the Draw tab, choose Toggle point edit mode. + + + -Icon Edit Points +Icon Toggle point edit mode -Edit Points +Toggle point edit mode - - + + + + + +F8 + + + +F8 + + + Choose Format - Character (drawing functions). Open context menu - choose Character. diff --git a/source/text/shared/01/0527.xhp b/source/text/shared/01/0527.xhp index e468b78143..c158001e0f 100644 --- a/source/text/shared/01/0527.xhp +++ b/source/text/shared/01/0527.xhp @@ -1,6 +1,4 @@ - - - -Edit Points +Edit Points /text/shared/01/0527.xhp @@ -30,18 +27,18 @@ + - Edit Points -Lets you change the shape of the selected drawing object. +Lets you change the shape of the selected drawing object. -To edit the shape of a selected drawing object, click the Points icon on the Drawing Bar, and then drag one of the points on the object. +To edit the shape of a selected drawing object, click the Points icon on the Drawing Bar, and then drag one of the points on the object. -Edit Points Bar +Edit Points Bar
[Libreoffice-bugs] [Bug 147778] Auto Calculate is disabled after Calc is recovered from crash
https://bugs.documentfoundation.org/show_bug.cgi?id=147778 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #9 from Stéphane Guillou (stragu) --- Not reproduced in: Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Same in 7.4.7.2. Document opens after recovery, and autoCalculate is still on. I used bug 154072 to crash Calc. Kevin, do you still reproduce in 7.6.2.1 and with a new profile? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157872] Drag-and-dropping a hyperlink from its last character onto itself makes it disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=157872 Kira Tubo changed: What|Removed |Added OS|Linux (All) |All Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||kira.t...@gmail.com --- Comment #1 from Kira Tubo --- Reproduced. Mostly occurs for me if I set my cursor at the after the last 'e' in the hyperlink (as opposed to on top of the 'e'). Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157814] Word track changes makes the erasing to the end of the paragraph after saving
https://bugs.documentfoundation.org/show_bug.cgi?id=157814 Kira Tubo changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||kira.t...@gmail.com Ever confirmed|0 |1 --- Comment #1 from Kira Tubo --- Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157857] Ctrl+W closes all open documents, not just the active window
https://bugs.documentfoundation.org/show_bug.cgi?id=157857 Kira Tubo changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||kira.t...@gmail.com Ever confirmed|0 |1 --- Comment #3 from Kira Tubo --- @Damon, it doesn't seem like anyone can reproduce this issue. Can you check if this issue persists in safe mode? (Help > Restart in Safe Mode). I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157818] Background color not visible in sidebar-styles-preview
https://bugs.documentfoundation.org/show_bug.cgi?id=157818 fed...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #13 from fed...@gmail.com --- (In reply to Dieter from comment #12) > Can't confirm with > > Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: ff9c8b62c1015972e9e89799832fa3690dcd46b4 > CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: > win > Locale: de-DE (de_DE); UI: en-GB > Calc: CL threaded > > Preview works. Fedfue, have you tested in SafeMode (Help -> Restart in > SafeMode?) > => NEEDINFO yes, the same situation. (In 2 computers with Win 10). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157690] After updating to Version 7.6.2.1 page orientation for printing enveloppes is not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=157690 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Stéphane Guillou (stragu) --- Fabian and Ronnel: - What settings do you change in the Envelope dialog, if any? - Once the envelope is created, do you also see that the page format (Format > Page Style > Page) is in Portrait orientation and is wider than it is high? (For me, 22.7 cm width × 11.4 cm height.) - When you print, which orientation is used in the Print dialog? - Is the preview also wrong in the Print dialog? - Does printing to file also create a wrong output? Fabian: which version worked differently? For me, I get the same result in 7.5.7.1 and 7.6.2.1. Printing to file with "Automatic" orientation gives the expected result: a PDF of an envelope, wider than high, with horizontal text. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 136638] Table style formatting not dynamic anymore after docx export
https://bugs.documentfoundation.org/show_bug.cgi?id=136638 Kira Tubo changed: What|Removed |Added Version|7.0.0.3 release |Inherited From OOo CC||kira.t...@gmail.com --- Comment #7 from Kira Tubo --- Still reproducible in current master. Note that in 3.3, tabbing in both DOCX and original ODT file is broken. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 1ec2e39cf4d5fe0a592bc783fd8bcdc4345c8cbd CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157339] Libre insists that when I type Brandonites what I mean is Brandishes
https://bugs.documentfoundation.org/show_bug.cgi?id=157339 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO --- Comment #3 from Stéphane Guillou (stragu) --- ubbishray, please check that you don't have an autocorrect rule set up, as Kira asked, and please test if the issue persists in safe mode. Also, please update to a recent release (if 7.3.5 is actually the version you use). Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157830] When scrolling a document at a resolution of 4k, CPU usage jumps to 50% or more and performance is laggy/choppy.
https://bugs.documentfoundation.org/show_bug.cgi?id=157830 --- Comment #6 from Stéphane Guillou (stragu) --- Thank you for the thorough testing, much appreciated. I think you are seeing the same as in bug 154602. Would you agree? What would be very helpful: a bibisection of the issue to find out exactly when the issue started, if you are familiar with it, or if you are keen to spend some time in learning the process. It is described on here: https://wiki.documentfoundation.org/QA/Bibisect First thing to figure out is in which version the performance has significantly degraded. If the difference is noticeable enough, you will be able to do a bibisect. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146014] [META] Poor Scrolling Performance
https://bugs.documentfoundation.org/show_bug.cgi?id=146014 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||154602 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154602 [Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||154602 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=154602 [Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=154602 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||90796, 146014 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=90796 [Bug 90796] [META] HiDPI / Retina bugs https://bugs.documentfoundation.org/show_bug.cgi?id=146014 [Bug 146014] [META] Poor Scrolling Performance -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154602] Scrolling using keyboard very slow (GTK3) with 4K monitor
https://bugs.documentfoundation.org/show_bug.cgi?id=154602 Stéphane Guillou (stragu) changed: What|Removed |Added Component|Calc|LibreOffice --- Comment #11 from Stéphane Guillou (stragu) --- Changing component to the whole of LibreOffice as two duplicates talk about Writer. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 --- Comment #16 from Regina Henschel --- You need to remove direct formatting from the table. Otherwise the styles from the template will not become active. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be shown/hidden based on available space instead of only their order
https://bugs.documentfoundation.org/show_bug.cgi?id=157580 --- Comment #8 from V Stuart Foote --- (In reply to Stéphane Guillou (stragu) from comment #7) Not a great example, MS uses a fully scoped Ribbon API, in both UWP and win32 [1] for builds of MS Office for Windows/macOS. Not a good model as we would never implement it as native code as we have to be mindful of cross-platform parity in the UI. The Glade UI framework cobbled together for the MUFFIN NB does really support dynamic reordering or pushing from NB onto collapsed listbox beyond what was done already for the exposure chevrons. =-ref-= [1] https://learn.microsoft.com/en-us/windows/win32/windowsribbon/-uiplat-windowsribbon-entry -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be shown/hidden based on available space instead of only their order
https://bugs.documentfoundation.org/show_bug.cgi?id=157580 --- Comment #8 from V Stuart Foote --- (In reply to Stéphane Guillou (stragu) from comment #7) Not a great example, MS uses a fully scoped Ribbon API, in both UWP and win32 [1] for builds of MS Office for Windows/macOS. Not a good model as we would never implement it as native code as we have to be mindful of cross-platform parity in the UI. The Glade UI framework cobbled together for the MUFFIN NB does really support dynamic reordering or pushing from NB onto collapsed listbox beyond what was done already for the exposure chevrons. =-ref-= [1] https://learn.microsoft.com/en-us/windows/win32/windowsribbon/-uiplat-windowsribbon-entry -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157910] New: Ruby tool hard to use in dark mode
https://bugs.documentfoundation.org/show_bug.cgi?id=157910 Bug ID: 157910 Summary: Ruby tool hard to use in dark mode Product: LibreOffice Version: 7.5.7.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: m...@leowallentin.se Created attachment 190400 --> https://bugs.documentfoundation.org/attachment.cgi?id=190400=edit Screenshot where text is hardly visible When using dark mode (on the OS, LibreOffice setting is ”default look, do not use Theme”), the preview text in the ruby/furigana tool (called “Asian Phonetic Guide” in menus) is black on gray, or in other word very hard to read or even see. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157028] FILESAVE PDF Tagged PDF export makes file size grow significantly
https://bugs.documentfoundation.org/show_bug.cgi?id=157028 --- Comment #9 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/049f458143cbd02ab915271418625cda1299f4b1 tdf#157028 vcl: PDF export: inline attribute dictionaries It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/qa vcl/source
vcl/qa/cppunit/pdfexport/pdfexport.cxx | 45 ++---
vcl/source/gdi/pdfwriter_impl.cxx | 35 ++---
2 files changed, 28 insertions(+), 52 deletions(-)
New commits:
commit 049f458143cbd02ab915271418625cda1299f4b1
Author: Michael Stahl
AuthorDate: Tue Oct 24 15:58:14 2023 +0200
Commit: Michael Stahl
CommitDate: Tue Oct 24 18:46:50 2023 +0200
tdf#157028 vcl: PDF export: inline attribute dictionaries
There seems to be no reason why SE attribute dictionaries are separate
objects, they could just be inline, which saves a little space (1%)
and more importantly the PDF file is easier to read with less clutter.
Change-Id: Iaaea2432313c0b710edabecae32545205f4f495e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158392
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 8dd1a9a71fbf..70da866889aa 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -3475,11 +3475,7 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf149140)
CPPUNIT_ASSERT(pAttrs != nullptr);
for (const auto& rAttrRef : pAttrs->GetElements())
{
-auto pARef =
dynamic_cast(rAttrRef);
-CPPUNIT_ASSERT(pARef != nullptr);
-auto pAttr = pARef->LookupObject();
-CPPUNIT_ASSERT(pAttr != nullptr);
-auto pAttrDict = pAttr->GetDictionary();
+auto pAttrDict =
dynamic_cast(rAttrRef);
CPPUNIT_ASSERT(pAttrDict != nullptr);
auto pOwner
=
dynamic_cast(pAttrDict->LookupElement("O"));
@@ -3841,11 +3837,8 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf135638)
auto pS =
dynamic_cast(pObject->Lookup("S"));
if (pS && pS->GetValue() == "Figure")
{
-auto pARef =
dynamic_cast(pObject->Lookup("A"));
-CPPUNIT_ASSERT(pARef != nullptr);
-auto pAttr = pARef->LookupObject();
-CPPUNIT_ASSERT(pAttr != nullptr);
-auto pAttrDict = pAttr->GetDictionary();
+auto pAttrDict
+=
dynamic_cast(pObject->Lookup("A"));
CPPUNIT_ASSERT(pAttrDict != nullptr);
auto pOwner
=
dynamic_cast(pAttrDict->LookupElement("O"));
@@ -4398,12 +4391,8 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testSpans)
auto pS103101
=
dynamic_cast(pObject103101->Lookup("S"));
CPPUNIT_ASSERT_EQUAL(OString("Span"), pS103101->GetValue());
-auto pA103101
-=
dynamic_cast(pObject103101->Lookup("A"));
-CPPUNIT_ASSERT(pA103101);
-auto pObjectA103101 = pA103101->LookupObject();
-CPPUNIT_ASSERT(pObjectA103101);
-auto pDictA103101 = pObjectA103101->GetDictionary();
+auto pDictA103101
+=
dynamic_cast(pObject103101->Lookup("A"));
CPPUNIT_ASSERT(pDictA103101 != nullptr);
CPPUNIT_ASSERT_EQUAL(OString("Layout"),
dynamic_cast(
pDictA103101->LookupElement("O"))
@@ -4963,13 +4952,12 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf157397)
CPPUNIT_ASSERT_EQUAL(OString("StructElem"), pType160->GetValue());
auto pS160 =
dynamic_cast(pObject160->Lookup("S"));
CPPUNIT_ASSERT_EQUAL(OString("Form"), pS160->GetValue());
-auto pA160 =
dynamic_cast(pObject160->Lookup("A"));
-CPPUNIT_ASSERT(pA160);
-auto pA160Obj = pA160->LookupObject();
-auto pA160O =
dynamic_cast(pA160Obj->Lookup("O"));
+auto pA160Dict =
dynamic_cast(pObject160->Lookup("A"));
+CPPUNIT_ASSERT(pA160Dict);
+auto pA160O =
dynamic_cast(pA160Dict->LookupElement("O"));
CPPUNIT_ASSERT(pA160O);
CPPUNIT_ASSERT_EQUAL(OString("PrintField"), pA160O->GetValue());
-auto pA160Role =
dynamic_cast(pA160Obj->Lookup("Role"));
+auto pA160Role =
dynamic_cast(pA160Dict->LookupElement("Role"));
CPPUNIT_ASSERT(pA160Role);
CPPUNIT_ASSERT_EQUAL(OString("tv"), pA160Role->GetValue());
@@ -5088,13 +5076,9 @@ CPPUNIT_TEST_FIXTURE(PdfExportTest, testTdf135192)
for (const auto&
rAttrRef :
pAttrs->GetElements())
{
-auto pARef =
dynamic_cast<
-
vcl::filter::PDFReferenceElement*>(
+auto pAttrDict =
dynamic_cast<
+
[Libreoffice-bugs] [Bug 157684] Add option to set default Wrap for inserted pictures
https://bugs.documentfoundation.org/show_bug.cgi?id=157684 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=49 ||992 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103152
Stéphane Guillou (stragu) changed:
What|Removed |Added
Depends on||49992
Referenced Bugs:
https://bugs.documentfoundation.org/show_bug.cgi?id=49992
[Bug 49992] EDITING: [Editing | Formatting | Feature]: additional (permanent)
option when Paste Special {as character} an image from clipboard
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 49992] EDITING: [Editing | Formatting | Feature]: additional (permanent) option when Paste Special {as character} an image from clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=49992 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7684 URL||https://ask.libreoffice.org ||/en/question/93610/image-as ||-character-as-default/ Blocks||103152 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103152 [Bug 103152] [META] Writer image bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157684] Add option to set default Wrap for inserted pictures
https://bugs.documentfoundation.org/show_bug.cgi?id=157684 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|writing a Document with |Add option to set default |pictures got an odd |Wrap for inserted pictures |workflow| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156970] Revert 7.6 Style Box in Menu Bar to 7.5 Style Box in Menu Bar
https://bugs.documentfoundation.org/show_bug.cgi?id=156970 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7684 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 156970] Revert 7.6 Style Box in Menu Bar to 7.5 Style Box in Menu Bar
https://bugs.documentfoundation.org/show_bug.cgi?id=156970 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7684 -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157684] writing a Document with pictures got an odd workflow
https://bugs.documentfoundation.org/show_bug.cgi?id=157684 Stéphane Guillou (stragu) changed: What|Removed |Added URL||https://ask.libreoffice.org ||/t/how-can-i-set-the-defaul ||t-wrap-mode-for-inserting-i ||mages-in-text-in-writer/146 ||15 CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||6970 Status|UNCONFIRMED |NEEDINFO --- Comment #4 from Stéphane Guillou (stragu) --- (In reply to liszca from comment #2) > Also I am wondering why does "Heading 1" change its position in the pulldown > menu after being used for the first time. It keeps the user away from > haveing a routine while working with it. This was done on purpose and is tracked in bug 156970. (In reply to m.a.riosv from comment #3) > Looks like a duplicate of tdf#49992 Similar, although that one is for anchor and this is for wrap. But I assume if we give the option for one, we should give the option for the other. Workaround for this Wrap issue is to change the default Graphics style. See answer in: https://ask.libreoffice.org/t/how-can-i-set-the-default-wrap-mode-for-inserting-images-in-text-in-writer/14615 liszca, can you try changing the default Graphics style in the Styles Sidebar > Frames, and set the Wrap to "None"? Is that sufficient for you? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157350] Table ODF Table Template is not honored (In other words, non-compliance with ODF-v1.2 standard)
https://bugs.documentfoundation.org/show_bug.cgi?id=157350 Stéphane Guillou (stragu) changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #15 from Stéphane Guillou (stragu) --- Not sure what is going on here. The style itself is not correct, as applying it to a table won't use the expected red style. If I edit the modified file, save it again and extract it, the styles.xml will have all elements renamed using the "styleName.digit" structure. (And the table cell styles have no custom attributes whatsoever, hence the vanilla table.) So does one have to stick to the "styleName.digit" naming? Regina, any idea? Is that numbering thing an ODF thing or imposed only by LO? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/vcl sw/qa vcl/source
include/vcl/uitest/uiobject.hxx |6 +-
sw/qa/uitest/navigator/movechapterupdown.py | 10
sw/qa/uitest/navigator/tdf134960.py |9 ---
sw/qa/uitest/navigator/tdf137274.py |9 ---
sw/qa/uitest/navigator/tdf144672.py | 10
sw/qa/uitest/navigator/tdf151051.py | 10
sw/qa/uitest/navigator/tdf154212.py | 10
sw/qa/uitest/writer_tests7/tdf135938.py | 19
vcl/source/treelist/uiobject.cxx| 66 +---
9 files changed, 45 insertions(+), 104 deletions(-)
New commits:
commit 4edff633dd36ea47d17a993e0afb30fcfc4f9a61
Author: Noel Grandin
AuthorDate: Tue Oct 24 15:22:49 2023 +0200
Commit: Noel Grandin
CommitDate: Tue Oct 24 18:22:58 2023 +0200
tdf#153519 make TreeListEntryUIObject safer
Do not store a raw pointer to an object that go away.
Consequently we can remove the various sleep() hacks
Change-Id: I3200c26b3a2a4eb7592cb2e5c6af64d6b739d1f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158390
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/include/vcl/uitest/uiobject.hxx b/include/vcl/uitest/uiobject.hxx
index 293471add9b5..d27140b2c21b 100644
--- a/include/vcl/uitest/uiobject.hxx
+++ b/include/vcl/uitest/uiobject.hxx
@@ -492,7 +492,7 @@ class TreeListEntryUIObject final : public UIObject
{
public:
-TreeListEntryUIObject(const VclPtr& xTreeList,
SvTreeListEntry* pEntry);
+TreeListEntryUIObject(const VclPtr& xTreeList,
std::vector nTreePath);
virtual StringMap get_state() override;
@@ -507,9 +507,11 @@ public:
private:
+SvTreeListEntry* getEntry() const;
+
VclPtr mxTreeList;
-SvTreeListEntry* const mpEntry;
+std::vector maTreePath;
};
class IconViewUIObject final : public TreeListUIObject
diff --git a/sw/qa/uitest/navigator/movechapterupdown.py
b/sw/qa/uitest/navigator/movechapterupdown.py
index c9e41a0971cd..6bcda9b3d4bb 100644
--- a/sw/qa/uitest/navigator/movechapterupdown.py
+++ b/sw/qa/uitest/navigator/movechapterupdown.py
@@ -10,7 +10,6 @@
from uitest.framework import UITestCase
from libreoffice.uno.propertyvalue import mkPropertyValues
from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
-import time
class movechapterupdown(UITestCase):
@@ -26,15 +25,6 @@ class movechapterupdown(UITestCase):
# wait until the navigator panel is available
xNavigatorPanel =
self.ui_test.wait_until_child_is_available('NavigatorPanel')
-# HACK, see the `m_aUpdTimer.SetTimeout(1000)` in the
SwContentTree ctor in
-# sw/source/uibase/utlui/content.cxx, where that m_aUpdTimer is
started by
-# SwContentTree::ShowTree triggered from the SIDEBAR action above,
and which can
-# invalidate the TreeListEntryUIObjects used by the below code (see
-# 2798430c8a711861fdcdfbf9ac00a0527abd3bfc "Mark the uses of
TreeListEntryUIObject as
-# dubious"); lets double that 1000 ms timeout value here to
hopefully be on the safe
-# side:
-time.sleep(2)
-
# Given the document chapter structure:
# 1. One H1
# 1.1. one_A (H2)
diff --git a/sw/qa/uitest/navigator/tdf134960.py
b/sw/qa/uitest/navigator/tdf134960.py
index 270e9d347abb..8388b63e40f9 100644
--- a/sw/qa/uitest/navigator/tdf134960.py
+++ b/sw/qa/uitest/navigator/tdf134960.py
@@ -9,7 +9,6 @@
from uitest.framework import UITestCase
from libreoffice.uno.propertyvalue import mkPropertyValues
from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
-import time
class tdf134960_hyperlinks(UITestCase):
@@ -28,14 +27,6 @@ class tdf134960_hyperlinks(UITestCase):
# wait until the navigator panel is available
xNavigatorPanel =
self.ui_test.wait_until_child_is_available('NavigatorPanel')
-# HACK, see the `m_aUpdTimer.SetTimeout(1000)` in the SwContentTree
ctor in
-# sw/source/uibase/utlui/content.cxx, where that m_aUpdTimer is
started by
-# SwContentTree::ShowTree triggered from the SIDEBAR action above, and
which can invalidate
-# the TreeListEntryUIObjects used by the below code (see
-# 2798430c8a711861fdcdfbf9ac00a0527abd3bfc "Mark the uses of
TreeListEntryUIObject as
-# dubious"); lets double that 1000 ms timeout value here to hopefully
be on the safe side:
-time.sleep(2)
-
xContentTree = xNavigatorPanel.getChild("contenttree")
xHyperlinks = self.get_item(xContentTree, 'Hyperlinks')
self.assertEqual('Hyperlinks', get_state_as_dict(xHyperlinks)['Text'])
diff --git a/sw/qa/uitest/navigator/tdf137274.py
b/sw/qa/uitest/navigator/tdf137274.py
index 9bd780a7e5c2..5273ddcb2f91 100644
--- a/sw/qa/uitest/navigator/tdf137274.py
+++ b/sw/qa/uitest/navigator/tdf137274.py
@@ -42,15 +42,6 @@ class tdf137274(UITestCase):
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/thumbnailviewacc.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit cee0425bf7377520845d7a32e8ccb4bc92f5d43d
Author: Noel Grandin
AuthorDate: Tue Oct 24 14:53:40 2023 +0200
Commit: Noel Grandin
CommitDate: Tue Oct 24 18:22:41 2023 +0200
suppress more IndexHint accessibility warning
Change-Id: I45bc0bf74f4ebeeb4155006e67309cd476ebc3c7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158388
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sfx2/source/control/thumbnailviewacc.cxx
b/sfx2/source/control/thumbnailviewacc.cxx
index ac1e320be25b..0a0f843a52d2 100644
--- a/sfx2/source/control/thumbnailviewacc.cxx
+++ b/sfx2/source/control/thumbnailviewacc.cxx
@@ -520,6 +520,7 @@ void ThumbnailViewAcc::FireAccessibleEvent( short nEventId,
const uno::Any& rOld
aEvtObject.Source = getXWeak();
aEvtObject.NewValue = rNewValue;
aEvtObject.OldValue = rOldValue;
+aEvtObject.IndexHint = -1;
for (auto const& tmpListener : aTmpListeners)
{
[Libreoffice-bugs] [Bug 157830] When scrolling a document at a resolution of 4k, CPU usage jumps to 50% or more and performance is laggy/choppy.
https://bugs.documentfoundation.org/show_bug.cgi?id=157830 --- Comment #5 from M. Knepper --- Came here to add that I tried to replicate this on Windows 11 Pro and it does NOT occur. CPU usage is around 4% - 5% on Windows 11 Pro maximum and there are no problems scrolling. Specs are 13700k, 7900 XT, 32GB DDR5 7200mhz RAM, and Windows 11 Pro with a display resolution of 3480x2160 (4k). This seems to be a Gnome/KDE specific issue at 4k on Linux. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: include/sal
include/sal/log-areas.dox |1 - 1 file changed, 1 deletion(-) New commits: commit 20ce362ee29642251a92d086debaac06746d9d08 Author: sahil AuthorDate: Tue Oct 24 12:29:32 2023 +0530 Commit: Hossein CommitDate: Tue Oct 24 17:53:42 2023 +0200 Remove unused entry from log-areas.dox Change-Id: I1d7bb4183c45f752cddf118411259695a294b2cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158371 Reviewed-by: Hossein Tested-by: Hossein diff --git a/include/sal/log-areas.dox b/include/sal/log-areas.dox index 1b4fa4813a41..23bbed1a916b 100644 --- a/include/sal/log-areas.dox +++ b/include/sal/log-areas.dox @@ -348,7 +348,6 @@ certain functionality. @section pyuno -@li @c pyuno @li @c pyuno.runtime @section sdext
[Libreoffice-bugs] [Bug 102068] Calc: Selected cells loose selection when "Print Preview" window is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=102068 Tim Hitch changed: What|Removed |Added Hardware|x86-64 (AMD64) |All --- Comment #10 from Tim Hitch --- No Worries @nicholas. Makes sense -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102068] Calc: Selected cells loose selection when "Print Preview" window is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=102068 Nicolas Dietrich changed: What|Removed |Added OS|Windows (All) |All --- Comment #9 from Nicolas Dietrich --- @Tim: you have changed Hardware/OS of this issue from "All" to "x86-64" and "Windows". However this issue isn't specific to Windows (I have this issue on Linux), so I set it back to "All". Also I doubt it is specific to x86-64, but I don't have another architecture to check at hand, so I leave it as it is. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 102068] Calc: Selected cells loose selection when "Print Preview" window is closed
https://bugs.documentfoundation.org/show_bug.cgi?id=102068 Tim Hitch changed: What|Removed |Added Hardware|All |x86-64 (AMD64) Severity|minor |normal OS|All |Windows (All) CC||mirrlees...@outlook.com --- Comment #8 from Tim Hitch --- I have also found that when you hit the Print Preview button, with the option of print selected sheets, nothing is there. The only way to print, is to select the cells you want, and then press print button. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90664] Impress, Changing style text broke animation
https://bugs.documentfoundation.org/show_bug.cgi?id=90664
--- Comment #20 from Julien Nabet ---
Thank you Armin for your feedback.
When creating a shape without customizing style, LO goes to line 1859:
1853 // if only one shape with text and no fill or outline is
selected, animate only by first level paragraphs
1854 if( bHasText && (aTargets.size() == 1) )
1855 {
1856 Reference< XShape > xShape( rTarget, UNO_QUERY );
1857 if( xShape.is() && !hasVisibleShape( xShape ) )
1858 {
1859 mpMainSequence->createTextGroup( pCreated, 1, -1.0,
false, false );
1860 }
1861 }
We depend on hasVisibleShape which contains this:
1059 if( sShapeType == "com.sun.star.presentation.TitleTextShape" ||
sShapeType == "com.sun.star.presentation.OutlinerShape" ||
1060 sShapeType == "com.sun.star.presentation.SubtitleShape" ||
sShapeType == "com.sun.star.drawing.TextShape" )
1061 {
1062 Reference< XPropertySet > xSet( xShape, UNO_QUERY_THROW );
1063
1064 FillStyle eFillStyle;
1065 xSet->getPropertyValue( "FillStyle" ) >>= eFillStyle;
1066
1067 css::drawing::LineStyle eLineStyle;
1068 xSet->getPropertyValue( "LineStyle" ) >>= eLineStyle;
1069
1070 return eFillStyle != FillStyle_NONE || eLineStyle !=
css::drawing::LineStyle_NONE;
1071 }
So when there's no fillstyle and no line style, it returns false and LO calls
createTextGroup.
The pb is once createTextGroup is called, if fillstyle or line style changes,
we can't revert.
I don't know how to test "animate by 1st level paragraph for text shapes by
default" but I suppose reverting would cause some regression.
=> we're stuck here.
--
You are receiving this mail because:
You are the assignee for the bug.
[Libreoffice-bugs] [Bug 33201] UI: Highlight (not select) current row and column in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=33201 Sahil Gautam changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154953] [ feature request ] arrows in tabbed and grouped bar compact should reposition NB elements sliding view right or left
https://bugs.documentfoundation.org/show_bug.cgi?id=154953 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7580 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be shown/hidden based on available space instead of only their order
https://bugs.documentfoundation.org/show_bug.cgi?id=157580 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4953 --- Comment #7 from Stéphane Guillou (stragu) --- (In reply to Stéphane Guillou (stragu) from comment #6) > MS Office 365 (online) does _both_ of the above suggestions ... and OnlyOffice only reduces the number of columns (until it goes in the "More" overflow dropdown). -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be shown/hidden based on available space instead of only their order
https://bugs.documentfoundation.org/show_bug.cgi?id=157580 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4953 --- Comment #7 from Stéphane Guillou (stragu) --- (In reply to Stéphane Guillou (stragu) from comment #6) > MS Office 365 (online) does _both_ of the above suggestions ... and OnlyOffice only reduces the number of columns (until it goes in the "More" overflow dropdown). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140140] Notebookbar Customize dialog allows for drag and drop, but this has no effect and is reverted once OK is pressed
https://bugs.documentfoundation.org/show_bug.cgi?id=140140 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||7580 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be shown/hidden based on available space instead of only their order
https://bugs.documentfoundation.org/show_bug.cgi?id=157580 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0140 --- Comment #6 from Stéphane Guillou (stragu) --- (In reply to V Stuart Foote from comment #3) > Shuffling the current widget/group order based on available width seems like > a recipe for chaotic UI experience--better to keep the sequence static-- > tolerate the empty space on the MUFFIN NB. Even though some lower priority > widgets might fit. > Adjusting the intentionally lightweight MUFFIN NB framework to allow users > to set sequence and priority of exposed widgets could be a Customization > feature. Current customization is limited to expose/hide toggle per widget. Good point. Reordering is not ideal and could make things confusing. Customising the order would help, but reordering elements in the Customize dialog currently has no effect (see bug 140140). Regardless, the bad use of space remains an issue and I imagine looks like bad design to many. I strongly agree with Jeff that the default behaviour needs improving. So my current suggestion / summary would be to have a guideline like: - Tab sections should be less than X pixels in width; - If a tab section is more than X pixels, it needs to have an alternative view that can reduce it to below the limit. For the particular case of the Styles preview, we have mentioned two options for the alternative "low width" mode: - Jeff's suggestion: dropdown button to reveal the full preview - My suggestion: reduced number of columns Note that MS Office 365 (online) does _both_ of the above suggestions for its Styles widget: it will first reduce the number of columns, then convert it to a single button to pop down the full widget. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 157580] Allow notebookbar and groupedbarcompact groups sections to be shown/hidden based on available space instead of only their order
https://bugs.documentfoundation.org/show_bug.cgi?id=157580 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||0140 --- Comment #6 from Stéphane Guillou (stragu) --- (In reply to V Stuart Foote from comment #3) > Shuffling the current widget/group order based on available width seems like > a recipe for chaotic UI experience--better to keep the sequence static-- > tolerate the empty space on the MUFFIN NB. Even though some lower priority > widgets might fit. > Adjusting the intentionally lightweight MUFFIN NB framework to allow users > to set sequence and priority of exposed widgets could be a Customization > feature. Current customization is limited to expose/hide toggle per widget. Good point. Reordering is not ideal and could make things confusing. Customising the order would help, but reordering elements in the Customize dialog currently has no effect (see bug 140140). Regardless, the bad use of space remains an issue and I imagine looks like bad design to many. I strongly agree with Jeff that the default behaviour needs improving. So my current suggestion / summary would be to have a guideline like: - Tab sections should be less than X pixels in width; - If a tab section is more than X pixels, it needs to have an alternative view that can reduce it to below the limit. For the particular case of the Styles preview, we have mentioned two options for the alternative "low width" mode: - Jeff's suggestion: dropdown button to reveal the full preview - My suggestion: reduced number of columns Note that MS Office 365 (online) does _both_ of the above suggestions for its Styles widget: it will first reduce the number of columns, then convert it to a single button to pop down the full widget. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140140] Notebookbar Customize dialog allows for drag and drop, but this has no effect and is reverted once OK is pressed
https://bugs.documentfoundation.org/show_bug.cgi?id=140140 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|WRITER Notebookbar |Notebookbar Customize |configuration window allows |dialog allows for drag and |for drag and drop, but this |drop, but this has no |has no effect and is|effect and is reverted once |reverted once OK is pressed |OK is pressed -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139007] [META] PDF accessibility
https://bugs.documentfoundation.org/show_bug.cgi?id=139007 Bug 139007 depends on bug 156565, which changed state. Bug 156565 Summary: FILESAVE PDF Using tabulator inside a link results to a PAC2021 "Inconsistent entry found" error https://bugs.documentfoundation.org/show_bug.cgi?id=156565 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156565] FILESAVE PDF Using tabulator inside a link results to a PAC2021 "Inconsistent entry found" error
https://bugs.documentfoundation.org/show_bug.cgi?id=156565 Michael Stahl (allotropia) changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |michael.st...@allotropia.de |desktop.org | CC||michael.st...@allotropia.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Michael Stahl (allotropia) --- fixed on master -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103378 Bug 103378 depends on bug 156565, which changed state. Bug 156565 Summary: FILESAVE PDF Using tabulator inside a link results to a PAC2021 "Inconsistent entry found" error https://bugs.documentfoundation.org/show_bug.cgi?id=156565 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156565] FILESAVE PDF Using tabulator inside a link results to a PAC2021 "Inconsistent entry found" error
https://bugs.documentfoundation.org/show_bug.cgi?id=156565 --- Comment #5 from Commit Notification --- Michael Stahl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4c5283a3a11008a06a995c49ed34dc1f6066 tdf#156565 sw: PDF/UA export: only one Link ILSE per link It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 156565] FILESAVE PDF Using tabulator inside a link results to a PAC2021 "Inconsistent entry found" error
https://bugs.documentfoundation.org/show_bug.cgi?id=156565 Commit Notification changed: What|Removed |Added Whiteboard||target:24.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: sw/inc sw/source vcl/qa
sw/inc/EnhancedPDFExportHelper.hxx |3
sw/source/core/text/EnhancedPDFExportHelper.cxx | 49 ++-
vcl/qa/cppunit/pdfexport/pdfexport.cxx | 102 ++--
3 files changed, 141 insertions(+), 13 deletions(-)
New commits:
commit 4c5283a3a11008a06a995c49ed34dc1f6066
Author: Michael Stahl
AuthorDate: Tue Oct 24 13:51:39 2023 +0200
Commit: Michael Stahl
CommitDate: Tue Oct 24 16:44:45 2023 +0200
tdf#156565 sw: PDF/UA export: only one Link ILSE per link
The problem is that for a hyperlink, multiple Link SEs are created, but
only one Link annotation; the Link SEs all point to the annotation but
the annotation can only point to one Link SE.
So try to create only one Link SE for a hyperlink, similar to commit
ee3c3fcf5c48964f7bc1d64484409f072c614866. This could be
further subdivided by Spans when formatting properties change but it
looks complicated and rarely needed.
Change-Id: I7d158b599ec744b03e78eeca88d717183f2ba1dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158387
Tested-by: Jenkins
Reviewed-by: Michael Stahl
diff --git a/sw/inc/EnhancedPDFExportHelper.hxx
b/sw/inc/EnhancedPDFExportHelper.hxx
index 1ab0f8868af4..542138157d2f 100644
--- a/sw/inc/EnhancedPDFExportHelper.hxx
+++ b/sw/inc/EnhancedPDFExportHelper.hxx
@@ -39,6 +39,7 @@ class SwPrintData;
class SwTextPainter;
class SwEditShell;
class StringRangeEnumerator;
+class SwTextAttr;
class SwTextNode;
class SwTable;
class SwNumberTreeNode;
@@ -161,7 +162,7 @@ class SwTaggedPDFHelper
void EndCurrentSpan();
void CreateCurrentSpan(SwTextPaintInfo const& rInf, OUString const&
rStyleName);
-bool CheckContinueSpan(SwTextPaintInfo const& rInf, std::u16string_view
rStyleName);
+bool CheckContinueSpan(SwTextPaintInfo const& rInf, std::u16string_view
rStyleName, SwTextAttr const* pInetFormatAttr);
bool CheckReopenTag();
void CheckRestoreTag() const;
diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx
b/sw/source/core/text/EnhancedPDFExportHelper.cxx
index ff47a693769f..999e599b4478 100644
--- a/sw/source/core/text/EnhancedPDFExportHelper.cxx
+++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx
@@ -156,6 +156,7 @@ struct SwEnhancedPDFState
};
::std::optional m_oCurrentSpan;
+::std::optional m_oCurrentLink;
SwEnhancedPDFState(LanguageType const eLanguageDefault)
: m_eLanguageDefault(eLanguageDefault)
@@ -1597,13 +1598,18 @@ void SwTaggedPDFHelper::BeginBlockStructureElements()
void SwTaggedPDFHelper::EndStructureElements()
{
-if (mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentSpan)
+if (mpFrameInfo != nullptr)
{
-if (mpFrameInfo != nullptr)
+if (mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentSpan)
{ // close span at end of paragraph
mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentSpan.reset();
++m_nEndStructureElement;
}
+if (mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentLink)
+{ // close link at end of paragraph
+mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentLink.reset();
+++m_nEndStructureElement;
+}
}
while ( m_nEndStructureElement > 0 )
@@ -1640,8 +1646,32 @@ void SwTaggedPDFHelper::CreateCurrentSpan(
}
bool SwTaggedPDFHelper::CheckContinueSpan(
-SwTextPaintInfo const& rInf, std::u16string_view const rStyleName)
+SwTextPaintInfo const& rInf, std::u16string_view const rStyleName,
+SwTextAttr const*const pInetFormatAttr)
{
+// for now, don't create span inside of link - this should be very rare
+// situation and it looks complicated to implement.
+assert(!mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentSpan
+|| !mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentLink);
+if (mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentLink)
+{
+if (pInetFormatAttr && pInetFormatAttr ==
*mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentLink)
+{
+return true;
+}
+else
+{
+mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentLink.reset();
+EndTag();
+return false;
+}
+}
+if (mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentSpan && pInetFormatAttr)
+{
+EndCurrentSpan();
+return false;
+}
+
if (!mpPDFExtOutDevData->GetSwPDFState()->m_oCurrentSpan)
return false;
@@ -1691,7 +1721,7 @@ void SwTaggedPDFHelper::BeginInlineStructureElements()
}
// note: ILSE may be nested, so only end the span if needed to start new
one
-bool const isContinueSpan(CheckContinueSpan(rInf, sStyleName));
+bool const isContinueSpan(CheckContinueSpan(rInf, sStyleName,
pInetFormatAttr));
sal_uInt16 nPDFType = USHRT_MAX;
OUString aPDFType;
@@ -1714,8 +1744,15 @@ void SwTaggedPDFHelper::BeginInlineStructureElements()
//
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-23.05' - sw/qa sw/source
sw/qa/core/layout/data/floattable-nested-rowspan.docx |binary
sw/qa/core/layout/tabfrm.cxx | 11 +
sw/source/core/layout/tabfrm.cxx | 37 ++
3 files changed, 48 insertions(+)
New commits:
commit 3be73099197aa8892ad34f267e3908734464dddf
Author: Miklos Vajna
AuthorDate: Fri Oct 20 08:57:08 2023 +0200
Commit: Caolán McNamara
CommitDate: Tue Oct 24 16:41:40 2023 +0200
tdf#157590 sw floattable: avoid hang in the nested + row span case
Regression from commit 905962db870e9d1cf1dcf3bd1be44c347cddafe1 (sw
floattable: handle AllowOverlap==false in the layout, 2023-08-10), the
document load resulted in a hang due to a layout loop.
What happens is that SwTabFrame::MakeAll() first does a Split(), but the
problematic row has cells with rowspans, and once this is combined with
multi-page nested floating tables, we move all the content to the next
page (we only leave a stub table frame on the old page), so the next
time SwTabFrame::MakeAll() is called, we do a Join(), and this leads to
a loop.
The traditional Writer way here would be to add a loop control, but we
can do a little bit better: nobody really asked for row span handling
with nested floating tables, so just don't split rows with row span in
this case, move the entire row forward instead. This is enough to avoid
the layout loop, and a next iteration can still use
SwFlowFrame::MoveBwd() / SwFlowFrame::MoveFwd() to split the complex
row.
The bug is fairly hard to hit, any naive simplification to the original
bugdoc leads to a working layout. Carefully keeping the size of the
document, it's possible to at least simplify the content of the table
cells (while keeping their size unchanged), so we avoid half of the
tables and half of the shapes for a faster test case.
(cherry picked from commit 8e03dfd6a4bff4eabf779ace9b758b49cf80f8ba)
Change-Id: Ib14154200c45ecb7f59e85f9f4f1fe0124c4256e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158379
Tested-by: Jenkins CollaboraOffice
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/sw/qa/core/layout/data/floattable-nested-rowspan.docx
b/sw/qa/core/layout/data/floattable-nested-rowspan.docx
new file mode 100644
index ..48cbdbfe59c3
Binary files /dev/null and
b/sw/qa/core/layout/data/floattable-nested-rowspan.docx differ
diff --git a/sw/qa/core/layout/tabfrm.cxx b/sw/qa/core/layout/tabfrm.cxx
index 64a30e8368db..44ee7c2a6966 100644
--- a/sw/qa/core/layout/tabfrm.cxx
+++ b/sw/qa/core/layout/tabfrm.cxx
@@ -82,6 +82,17 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitFlyInInlineTable)
CPPUNIT_ASSERT(!pTab->GetFollow());
}
}
+
+CPPUNIT_TEST_FIXTURE(Test, testSplitFlyNestedRowSpan)
+{
+// Given a document with nested floating tables and a row with rowspan
cells at page boundary:
+// When loading that document:
+// Without the accompanying fix in place, this test would have resulted in
a layout loop.
+createSwDoc("floattable-nested-rowspan.docx");
+
+// Then make sure the resulting page count matches Word:
+CPPUNIT_ASSERT_EQUAL(6, getPages());
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/layout/tabfrm.cxx b/sw/source/core/layout/tabfrm.cxx
index 344039b1bffe..b97536d015c6 100644
--- a/sw/source/core/layout/tabfrm.cxx
+++ b/sw/source/core/layout/tabfrm.cxx
@@ -2608,6 +2608,43 @@ void SwTabFrame::MakeAll(vcl::RenderContext*
pRenderContext)
// See if this is a split fly that can also grow.
auto pUpperFly = static_cast(GetUpper());
bFlySplit = pUpperFly->IsFlySplitAllowed();
+
+if (bFlySplit)
+{
+// See if this is a nested split fly where the inner
table also has
+// rowspans.
+SwTextFrame* pAnchorCharFrame =
pUpperFly->FindAnchorCharFrame();
+if (pAnchorCharFrame && pAnchorCharFrame->IsInFly())
+{
+// Find the row we'll split.
+SwTwips nRemaining
+= aRectFnSet.YDiff(nDeadLine,
aRectFnSet.GetTop(getFrameArea()));
+nRemaining -= aRectFnSet.GetTopMargin(*this);
+const SwFrame* pRow = Lower();
+for (; pRow->GetNext(); pRow = pRow->GetNext())
+{
+if (nRemaining <
aRectFnSet.GetHeight(pRow->getFrameArea()))
+{
+break;
+}
+
+nRemaining -=
aRectFnSet.GetHeight(pRow->getFrameArea());
+}
+
[Libreoffice-bugs] [Bug 42673] With disconnected network printers, Calc hangs opening some files (waiting on e.g. the Windows print spooler)
https://bugs.documentfoundation.org/show_bug.cgi?id=42673 Stéphane Guillou (stragu) changed: What|Removed |Added URL||https://ask.libreoffice.org ||/t/calc-loading-native-ods- ||file-is-very-slow-hanging/6 ||1022 Summary|With disconnected network |With disconnected network |printers, Calc hangs|printers, Calc hangs |opening some files waiting |opening some files (waiting |on the Windows print|on e.g. the Windows print |spooler |spooler) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 154206] Missing/disappearing text cursor in Ubuntu Xorg session (gtk3)
https://bugs.documentfoundation.org/show_bug.cgi?id=154206 tester user changed: What|Removed |Added Attachment #185979|Снимок ÑкÑана |Снимок ÑкÑана Ð¾Ñ filename|Ð¾Ñ 2023-03-15 |2023-03-15 15-55-42.png |15-55-42.png| Attachment #185979|Scrinshot |Screenshot description|| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 157831] Slow loading pages
https://bugs.documentfoundation.org/show_bug.cgi?id=157831 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #2 from Stéphane Guillou (stragu) --- Steve, do you have a disconnected / unavailable network printer? Can you remove any unavailable printer in the Windows settings, and then see if the issue is resolved? (Or alternatively, try opening Calc without being connected to to the network.) I suspect something similar to bug 42673, although it's supposed to be Calc-only. -- You are receiving this mail because: You are the assignee for the bug.
