date:20231218

core.git: sw/qa writerfilter/source

2023-12-18 Thread Justin Luth (via logerrit)

 sw/qa/extras/rtfexport/data/tdf158586_pageBreak0B.rtf |   15 +++
 sw/qa/extras/rtfexport/rtfexport8.cxx |6 ++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx|2 ++
 3 files changed, 23 insertions(+)

New commits:
commit 940b60c903b11340979eaf37b9b1dad5d823a1c4
Author: Justin Luth 
AuthorDate: Wed Dec 13 20:07:20 2023 -0500
Commit: Miklos Vajna 
CommitDate: Tue Dec 19 08:59:10 2023 +0100

partial revert tdf#153178 writerfilter: do not create text frame spuriously

If HoriAnchor/VertAnchor are assigned, that is enough to create a frame.

make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_0B

Note: because of a regression, this was already one page before
this commit, so need to go back to the time of the reverted patch.

Change-Id: Iddbe1cc4ba6d6e95e2d977a227ae6cab5271007e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160743
Reviewed-by: Justin Luth 
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/qa/extras/rtfexport/data/tdf158586_pageBreak0B.rtf 
b/sw/qa/extras/rtfexport/data/tdf158586_pageBreak0B.rtf
new file mode 100644
index ..587e90500505
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158586_pageBreak0B.rtf
@@ -0,0 +1,15 @@
+{\rtf1
+
+\paperw8419\paperh5953
+
+\spltpgpar
+
+\ltrpar \sectd
+
+\pard\plain \phpg\pvpg
+
+\page \sect \sectd \sbknone
+
+\pard\plain First page
+\par
+}
diff --git a/sw/qa/extras/rtfexport/rtfexport8.cxx 
b/sw/qa/extras/rtfexport/rtfexport8.cxx
index 80309ff9b65e..bcba0a9beb97 100644
--- a/sw/qa/extras/rtfexport/rtfexport8.cxx
+++ b/sw/qa/extras/rtfexport/rtfexport8.cxx
@@ -56,6 +56,12 @@ DECLARE_RTFEXPORT_TEST(testTdf158586_0, 
"tdf158586_pageBreak0.rtf")
 // assertXPathContent(pLayout, "//page[1]/body/txt"_ostr, "First page");}
 }
 
+DECLARE_RTFEXPORT_TEST(testTdf158586_0B, "tdf158586_pageBreak0B.rtf")
+{
+// The specified page break must be lost because it is in a text frame
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+}
+
 DECLARE_RTFEXPORT_TEST(testTdf158586_1, "tdf158586_pageBreak1.rtf")
 {
 // None of the specified text frame settings initiates a real text frame - 
page break not lost
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 1a4f33f28df8..0abbccaed0e3 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -4010,6 +4010,8 @@ bool RTFFrame::hasProperties() const
 {
 // tdf#153178 \dxfrtext \dfrmtxtx \dfrmtxty \wrapdefault do *not* create 
frame
 return m_nX != 0 || m_nY != 0 || m_nW != 0 || m_nH != 0
+   || (m_nHoriAnchor && m_nHoriAnchor != 
NS_ooxml::LN_Value_doc_ST_HAnchor_text)
+   || (m_nVertAnchor && m_nVertAnchor != 
NS_ooxml::LN_Value_doc_ST_VAnchor_margin)
|| (m_oWrap && *m_oWrap != NS_ooxml::LN_Value_doc_ST_Wrap_auto);
 }

[Bug 158715] Periodically call home to check for need for update due to security vulnerability

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158715

--- Comment #29 from Heiko Tietze  ---
(In reply to John Mills from comment #27)
> security is an area that you can't leave to the possibility
> a person is running an extension.

We ship and install extensions by default. Could be done here as well.
Extensions are easy to patch out - for non-TDF builds, easy to modify, and
allow much more flexibility than core programming.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158715] Periodically call home to check for need for update due to security vulnerability

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158715

--- Comment #29 from Heiko Tietze  ---
(In reply to John Mills from comment #27)
> security is an area that you can't leave to the possibility
> a person is running an extension.

We ship and install extensions by default. Could be done here as well.
Extensions are easy to patch out - for non-TDF builds, easy to modify, and
allow much more flexibility than core programming.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158586] FILEOPEN RTF: missing page break

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158586

--- Comment #9 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/798649ec30b536614048aa457fb9c8d4dce30b31

tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158586] FILEOPEN RTF: missing page break

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158586

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/CppunitTest_sw_rtfexport8.mk sw/Module_sw.mk sw/qa writerfilter/source

2023-12-18 Thread Justin Luth (via logerrit)

 sw/CppunitTest_sw_rtfexport8.mk  |   14 +++
 sw/Module_sw.mk  |1 
 sw/qa/extras/rtfexport/data/tdf158586_pageBreak0.rtf |   15 +++
 sw/qa/extras/rtfexport/data/tdf158586_pageBreak1.rtf |   15 +++
 sw/qa/extras/rtfexport/rtfexport8.cxx|   72 +++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx   |   11 +-
 6 files changed, 123 insertions(+), 5 deletions(-)

New commits:
commit 798649ec30b536614048aa457fb9c8d4dce30b31
Author: Justin Luth 
AuthorDate: Tue Dec 12 16:46:49 2023 -0500
Commit: Miklos Vajna 
CommitDate: Tue Dec 19 08:55:59 2023 +0100

tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame

This fixes a LO 7.6.4 regression of a lost page break,
as well as another example where part of the paragraph moves to next page,
from mstahl's commit 4e2f2489c4c7436f8b3a21a530bc625cbef4e365

It seems likely that the run should only be checked
when we know that there is a real frame here,
which essentially becomes a run for most purposes
(except perhaps for page breaks - as seen for DOCX).

This code block was introduced with
commit 0d9132c5046e15540abc20e45d64080708626441
Author: Miklos Vajna on Sat Mar 24 13:04:54 2012 +0100
fdo#47036 fix RTF import of shapes inside text frames
at the start of the doc
and in the other block of touched code, it did test inFrame.

The unit test works when compiling right after the regression,
but has broken because of tdf#153194.

Since this will get backported way back and all over,
it is a good time to introduce rtfexport8.

make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_0
make CppunitTest_sw_rtfexport8 CPPUNIT_TEST_NAME=testTdf158586_1

Change-Id: Ib4b75efb8422d96e693da337cbef97520e975f3f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160655
Reviewed-by: Justin Luth 
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/CppunitTest_sw_rtfexport8.mk b/sw/CppunitTest_sw_rtfexport8.mk
new file mode 100644
index ..9f0a2d85ab4f
--- /dev/null
+++ b/sw/CppunitTest_sw_rtfexport8.mk
@@ -0,0 +1,14 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+#*
+
+$(eval $(call sw_rtfexport_test,8))
+
+# vim: set noet sw=4 ts=4:
diff --git a/sw/Module_sw.mk b/sw/Module_sw.mk
index 0123a56468de..00847e8aeac5 100644
--- a/sw/Module_sw.mk
+++ b/sw/Module_sw.mk
@@ -67,6 +67,7 @@ $(eval $(call gb_Module_add_slowcheck_targets,sw,\
 CppunitTest_sw_rtfexport5 \
 CppunitTest_sw_rtfexport6 \
 CppunitTest_sw_rtfexport7 \
+CppunitTest_sw_rtfexport8 \
 CppunitTest_sw_docbookexport \
 CppunitTest_sw_fodfexport \
 CppunitTest_sw_htmlexport \
diff --git a/sw/qa/extras/rtfexport/data/tdf158586_pageBreak0.rtf 
b/sw/qa/extras/rtfexport/data/tdf158586_pageBreak0.rtf
new file mode 100644
index ..53c619265156
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158586_pageBreak0.rtf
@@ -0,0 +1,15 @@
+{\rtf1
+
+\paperw8419\paperh5953
+
+\spltpgpar
+
+\ltrpar \sectd
+
+\pard\plain \wraptight
+
+\page \sect \sectd \sbknone
+
+\pard\plain First page
+\par
+}
diff --git a/sw/qa/extras/rtfexport/data/tdf158586_pageBreak1.rtf 
b/sw/qa/extras/rtfexport/data/tdf158586_pageBreak1.rtf
new file mode 100644
index ..bc09fe02aa2f
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158586_pageBreak1.rtf
@@ -0,0 +1,15 @@
+{\rtf1
+
+\paperw8419\paperh5953
+
+\spltpgpar
+
+\ltrpar \sectd
+
+\pard\plain \wrapdefault\pvmrg\posxl\absw0\absh0\phcol 
\posyil\abslock\dxfrtext10
+
+\page \sect \sectd \sbknone
+
+\pard\plain Second page
+\par
+}
diff --git a/sw/qa/extras/rtfexport/rtfexport8.cxx 
b/sw/qa/extras/rtfexport/rtfexport8.cxx
new file mode 100644
index ..80309ff9b65e
--- /dev/null
+++ b/sw/qa/extras/rtfexport/rtfexport8.cxx
@@ -0,0 +1,72 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+using namespace css;

[Bug 158583] FILEOPEN RTF: break splits paragraph across two pages

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158583

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158583] FILEOPEN RTF: break splits paragraph across two pages

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158583

--- Comment #4 from Commit Notification 
 ---
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/798649ec30b536614048aa457fb9c8d4dce30b31

tdf#158583 tdf#158586 RTF writerfilter: only startRun for real frame

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158114] Show lost linked images

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158114

--- Comment #10 from Heiko Tietze  ---
Strike-through implies a permanent unavailability, we better go with italic and
perhaps some icon too. Reopen the ticket?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158114] Show lost linked images

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158114

--- Comment #10 from Heiko Tietze  ---
Strike-through implies a permanent unavailability, we better go with italic and
perhaps some icon too. Reopen the ticket?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 120255] [META] Base feature enhancements

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=120255
Bug 120255 depends on bug 158736, which changed state.

Bug 158736 Summary: database feature to catch up to MS office 97
https://bugs.documentfoundation.org/show_bug.cgi?id=158736

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158736] database feature to catch up to MS office 97

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158736

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #5 from Heiko Tietze  ---
Many thanks for submitting the enhancement idea, Art. But in this case we
rather abstain from adding it to the application.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158736] database feature to catch up to MS office 97

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158736

Heiko Tietze  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WONTFIX

--- Comment #5 from Heiko Tietze  ---
Many thanks for submitting the enhancement idea, Art. But in this case we
rather abstain from adding it to the application.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158770] German "Umlaut" from a PDF cannot be pasted

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158770

documentfoundation.yt...@mar.aleeas.com changed:

   What|Removed |Added

 CC||documentfoundation.ytpqh@ma
   ||r.aleeas.com

--- Comment #1 from documentfoundation.yt...@mar.aleeas.com ---
Created attachment 191498
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191498=edit
Screenshot of LibreOffice writer showing the error with the German "Umlaut"
Symbol

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158729] Cropped images change on compression

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158729

--- Comment #12 from carlo...@gmail.com ---
This is a quite critical bug to me because it makes cropping images unusable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158770] New: German "Umlaut" from a PDF cannot be pasted

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158770

Bug ID: 158770
   Summary: German "Umlaut" from a PDF cannot be pasted
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: documentfoundation.yt...@mar.aleeas.com

Description:
German "Umlaut" symbols (ä,ö,ü) cannot be pasted correctly from the clipboard
when they are taken from a PDF file.

The same symbols can be copied/pasted correctly in any other application that I
tested. For example: Kate, VSCodium, Joplin, etc.

When the PDF file is opened in the browser (Firefox) the German "Umlaut"
symbols can be copied correctly, but if the PDF is opened on "Okular", the
symbols cannot be pasted into LibreOffice.

Steps to Reproduce:
1. Download the following PDF File >
https://www.amboss.com/media/de/m2-lernplan-f24
2. Open the PDF in Okular
3. Go to page 3 and copy some words with the German "Umlaut" (ä,ö,ü). For
example: "Dyslipidämie"
4. Paste the word into LibreOffice (Calc, Writer, etc).
5. See the error (The German Umlaut is not shown properly).

Actual Results:
The German Umlaut (ä,ö,ü) is not shown correctly.

Expected Results:
The German Umlaut should be pasted correctly in LibreOffice, as in any other
software.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 7.5.9.2 (X86_64) / LibreOffice Community
Build ID: 50(Build:2)
CPU threads: 8; OS: Linux 6.6; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US); UI: en-US
7.5.9-2
Calc: threaded

-
The error also occurs on "LibreOffice Fresh" installed from the Official AUR
Repository on Arch Linux (Endeavour OS - KDE).

The error also occurs when LibreOffice is in German (with the German package
installed from Arch Repository). Moreover, if the OS is in German, the same bug
appears. 

It seems a problem specific to LibreOffice because any other software can paste
the Umlaut correctly from that PDF file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158729] Cropped images change on compression

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158729

--- Comment #11 from carlo...@gmail.com ---
I mean, if I do not mark the resolution checkbox the bug is still present.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 139532] [META] DOCX Floating table related issues

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=139532
Bug 139532 depends on bug 158081, which changed state.

Bug 158081 Summary: Fourth part of multi-page floating tables
https://bugs.documentfoundation.org/show_bug.cgi?id=158081

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - include/sfx2 sfx2/source sw/inc sw/qa sw/source

2023-12-18 Thread Miklos Vajna (via logerrit)

 include/sfx2/viewsh.hxx  |4 
 sfx2/source/view/viewfrm.cxx |2 ++
 sw/inc/view.hxx  |9 ++---
 sw/qa/uibase/uiview/uiview.cxx   |   19 +++
 sw/source/uibase/uiview/view.cxx |8 +++-
 5 files changed, 38 insertions(+), 4 deletions(-)

New commits:
commit e6bdd44e314907535db181d5f65342c1bfa7e3da
Author: Miklos Vajna 
AuthorDate: Mon Dec 18 17:21:15 2023 +0100
Commit: Miklos Vajna 
CommitDate: Tue Dec 19 08:20:18 2023 +0100

tdf#158686 sw floattable: fix print preview crash

Regression from commit b8521d969ab5be4fc947e467d4afe969f9d3b563
(tdf#157263 sw floattable: prefer join over split after moving fwd,
2023-09-25), enabling Options -> Writer -> Formatting Aids -> Hidden
Characters, then opening the bugdoc, finally Toggle Print Preview on the
toolbar resulted in a crash.

We have a memory corruption here:

==11968==ERROR: AddressSanitizer: heap-use-after-free on address 
0x60f734e0 at pc 0x7f473822d2ee bp 0x7fffdadd3660 sp 0x7fffdadd3658
READ of size 8 at 0x60f734e0 thread T0
#0 0x7f473822d2ed in rtl::Reference::operator->() 
const /include/rtl/ref.hxx:216:9
#1 0x7f473821feeb in FmFormShell::IsActiveControl() const 
/svx/source/form/fmshell.cxx:1227:12
#2 0x7f46dad4d52a in SwView::SelectShell() 
/sw/source/uibase/uiview/view.cxx:296:40
#3 0x7f46dad496a6 in SwView::AttrChangedNotify(LinkParamNone*) 
/sw/source/uibase/uiview/view.cxx:572:13
...
#32 0x7f4748944cda in 
SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) 
/sfx2/source/view/viewfrm.cxx:2552:32
#33 0x7f47488f4e3b in SfxViewFrame::ExecView_Impl(SfxRequest&) 
/sfx2/source/view/viewfrm.cxx:2637:29
freed by thread T0 here:
#0 0x5568ff2f9a7b in operator delete(void*, unsigned long) 
/home/abuild/rpmbuild/BUILD/llvm-15.0.7.src/build/../projects/compiler-rt/lib/asan/asan_new_delete.cpp:164:3
#1 0x7f4738214346 in FmFormShell::~FmFormShell() 
/svx/source/form/fmshell.cxx:181:1
#2 0x7f4746b04b9d in SfxDispatcher::FlushImpl() 
/sfx2/source/control/dispatch.cxx:1412:13
#3 0x7f4746aff767 in SfxDispatcher::Flush() 
/sfx2/source/control/dispatch.cxx:157:26
#4 0x7f47489100dc in 
SfxViewFrame::PopShellAndSubShells_Impl(SfxViewShell&) 
/sfx2/source/view/viewfrm.cxx:1100:24
#5 0x7f47489441a3 in 
SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) 
/sfx2/source/view/viewfrm.cxx:2538:13
#6 0x7f47488f4e3b in SfxViewFrame::ExecView_Impl(SfxRequest&) 
/sfx2/source/view/viewfrm.cxx:2637:29

I.e. a new SwPagePreview replaces the old SwView, but the order is that
SfxViewFrame::SwitchToViewShell_Impl() starts with deleting the
SfxShells of the old SwView in PopShellAndSubShells_Impl(), then it
creates the new shell, finally deletes the old shell. Given that the new
shell hides hidden characters and the old shell did not, this triggers a
size notification for the half-deleted old shell and we crash.

Seeing that SwView::AttrChangedNotify() already had code to delay the
selection of an SfxShell in the old SwView, fix the problem by
introducing a new flag that allows not selecting an SfxShell at all if
the old view is known to be deleted in the near future anyway.

An alternative would be to make sure that all relevant pointers are
maintained using an SfxBroadcaster / SfxListener protocol, but after
fixing some 4 of them and that's still not enough, probably it's better
to handle this at a higher level. It's also a bit unclear how this
"worked" in the past; looks like the old view didn't get the size change
notification by accident.

Change-Id: I423ff946f8235848cc3a870bc52fcf88a721fd2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160925
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins
(cherry picked from commit 164fb25f7b2db7d833d6d0f28e49c5cac68426b3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160935

diff --git a/include/sfx2/viewsh.hxx b/include/sfx2/viewsh.hxx
index 14d9ca94881c..c1a2bc90a19d 100644
--- a/include/sfx2/viewsh.hxx
+++ b/include/sfx2/viewsh.hxx
@@ -227,6 +227,10 @@ public:
 SfxViewShell( SfxViewFrame& rFrame, 
SfxViewShellFlags nFlags );
 virtual ~SfxViewShell() override;
 
+/// Informs the view shell that it'll be deleted before the main loop 
processes the next user
+/// input.
+virtual void SetDying() {}
+
 SfxInPlaceClient*   GetIPClient() const;
 SfxInPlaceClient*   GetUIActiveClient() const;
 SfxInPlaceClient*   FindIPClient( const css::uno::Reference < 
css::embed::XEmbeddedObject >&  xObj, vcl::Window *pObjParentWin ) const;
diff --git

[Bug 120063] [META] Options dialog's expert configuration bugs and enhancements

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=120063
Bug 120063 depends on bug 158593, which changed state.

Bug 158593 Summary: Expert dialog crashes when editing locked down "set" 
configuration
https://bugs.documentfoundation.org/show_bug.cgi?id=158593

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/inc

2023-12-18 Thread Miklos Vajna (via logerrit)

 sw/inc/fmtfld.hxx |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 83cbadeaf6b784fa9ae2ca47d1a10bc942adfe79
Author: Miklos Vajna 
AuthorDate: Mon Dec 18 20:22:48 2023 +0100
Commit: Miklos Vajna 
CommitDate: Tue Dec 19 08:09:21 2023 +0100

sw: document SwFormatFieldHint

Describe the typical producer and typical consumer.

Change-Id: Iea2ae67f6a17bc5d84ce0bdc0690d13a22218ae4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160950
Tested-by: Jenkins
Reviewed-by: Miklos Vajna 

diff --git a/sw/inc/fmtfld.hxx b/sw/inc/fmtfld.hxx
index 0c8d5fda7110..ab1953f00114 100644
--- a/sw/inc/fmtfld.hxx
+++ b/sw/inc/fmtfld.hxx
@@ -180,6 +180,11 @@ enum class SwFormatFieldHintWhich
 RESOLVED   = 5
 };
 
+/// This SfxHint subclass is produced by code that changes the doc model (e.g. 
SwNodes::ChgNode()),
+/// the typical which id is SwFormatFieldHintWhich::INSERTED or 
SwFormatFieldHintWhich::REMOVED.
+///
+/// The consumer of this hint is SwPostItMgr::Notify(), i.e. the sidebar on 
the right hand side of
+/// the Writer edit window that hosts the comments as post-its.
 class SW_DLLPUBLIC SwFormatFieldHint final : public SfxHint
 {
 const SwFormatField*   m_pField;

core.git: configmgr/source

2023-12-18 Thread Stephan Bergmann (via logerrit)

 configmgr/source/access.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f8199c424412f56edb1c64fada27e0c94d34fe79
Author: Stephan Bergmann 
AuthorDate: Mon Dec 18 23:00:26 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Tue Dec 19 07:57:32 2023 +0100

tdf#158593 Make configmgr READONLY Property more useful

...to reflect whether or not the corresponding item can be modified.  Which
matches what the READONLY flag is actually used for today.  (And the 
original,
somewhat arbitrary semantics had been assigned without much thought, IIRC, 
and
it should be OK to change them.)

Change-Id: I8185e47519a5cb4aff6e8f260326845276b0c092
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160957
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx
index 3075bc0a32f6..1e2d73dafe9c 100644
--- a/configmgr/source/access.cxx
+++ b/configmgr/source/access.cxx
@@ -2209,7 +2209,7 @@ css::beans::Property Access::asProperty() {
  (nillable ? css::beans::PropertyAttribute::MAYBEVOID : 0) |
  (getRootAccess()->isUpdate() && removable
   ? css::beans::PropertyAttribute::REMOVABLE : 0) |
- (!getRootAccess()->isUpdate() || p->getFinalized() != Data::NO_LAYER
+ (!getRootAccess()->isUpdate() || isFinalized()
   ? css::beans::PropertyAttribute::READONLY : 0))); //TODO: 
MAYBEDEFAULT
 }

[Bug 158678] Problem with vertical bar in MathML import

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158678

--- Comment #8 from Mike Kaganski  ---
Note that the MML file may also be viewed in Firefox browser, to check the
intended rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158678] Problem with vertical bar in MathML import

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158678

Mike Kaganski  changed:

   What|Removed |Added

Summary|Problem with vertical bar   |Problem with vertical bar
   |in math object  |in MathML import
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 OS|Linux (All) |All
   Hardware|x86-64 (AMD64)  |All

--- Comment #7 from Mike Kaganski  ---
Opening attachment 191497 in Math reproduces the problem.
The ODF file from attachment 191444 is not relevant, because it's the artifact
of the incorrect import. But indeed, there is an import problem here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158678] Problem with vertical bar in math object

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158678

Mike Kaganski  changed:

   What|Removed |Added

 Attachment #191444|0   |1
is obsolete||

--- Comment #6 from Mike Kaganski  ---
Created attachment 191497
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191497=edit
MathML file showing the problem on import

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158769] New: bug in Libreoffice

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158769

Bug ID: 158769
   Summary: bug in Libreoffice
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: BASIC
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: halya...@gmail.com

Description:
Bug is generated in Libreoffice

Actual Results:
sgrhtut

Expected Results:
et5tu6u


Reproducible: Always


User Profile Reset: No

Additional Info:
ettuy7i7

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158439] Design: UI Inconsistency in "Target in Document" dialog to define a hyperlink

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158439

--- Comment #5 from Daveo  ---
In reply to  Heiko Tietze Comment #3.
Yes, I have a major objection, for the reason stated by Stéphane Guillou in
comment#4.
This ill conceived proposal has been raised in the past and closed as a Won't
Fix, because NOT "all choices have been done at the point." where the user may
wish to "Apply" and continue to add more Hyperlinks.
I have clients using LO Calc spreadsheets where a number of hyperlinks need to
be updated in the same session, so it will be an inconvenience and a likely
customer objection to using LO.
If new users don't understand the difference between the words "Apply" and
"Close", add tooltips to the buttons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158439] Design: UI Inconsistency in "Target in Document" dialog to define a hyperlink

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158439

--- Comment #5 from Daveo  ---
In reply to  Heiko Tietze Comment #3.
Yes, I have a major objection, for the reason stated by Stéphane Guillou in
comment#4.
This ill conceived proposal has been raised in the past and closed as a Won't
Fix, because NOT "all choices have been done at the point." where the user may
wish to "Apply" and continue to add more Hyperlinks.
I have clients using LO Calc spreadsheets where a number of hyperlinks need to
be updated in the same session, so it will be an inconvenience and a likely
customer objection to using LO.
If new users don't understand the difference between the words "Apply" and
"Close", add tooltips to the buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.

New Defects reported by Coverity Scan for LibreOffice

2023-12-18 Thread scan-admin

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
50 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1559313:  Null pointer dereferences  (NULL_RETURNS)



*** CID 1559313:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/ui/view/output.cxx: 2604 in ScOutputData::AddPDFNotes()()
2598 
2599 // Note title is the cell address (as on 
printed note pages)
2600 ScAddress aAddress( nMergeX, nMergeY, nTab );
2601 aNote.Title = 
aAddress.Format(ScRefFlags::VALID, mpDoc, mpDoc->GetAddressConvention());
2602 
2603 // Content has to be a simple string without 
line breaks
>>> CID 1559313:  Null pointer dereferences  (NULL_RETURNS)
>>> Dereferencing a pointer that might be "nullptr" "pNote" when calling 
>>> "GetText".
2604 OUString aContent = pNote->GetText();
2605 aNote.Contents = aContent.replaceAll("\n", " 
");
2606 
2607 pPDFData->CreateNote( aNoteRect, aNote );
2608 }
2609 }



To view the defects in Coverity Scan visit, 
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3DIL98_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi2wJbLo4SieEDO47Z86J2qHiYTc68ToGCAScYAxXsrQ6h-2Brwf6c60AtoSxv7dg3zNC3VNrGJrHkEi8HaVXIezgLnlbCqRg2htZZjGIPBKjLfR-2BoQwU5PvaUsGTj8rusn-2FAP7YVtiQp25eZ1yWzNHYG2JPfFbU6D0VEQKdEUo6uu4-3D

[Bug 89633] CALC does not properly import / edit Excel hyperlinked cells containing formula or numeric

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89633

Matt K  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #13 from Matt K  ---
>From what I see, you can use the "=HYPERLINK("http://www.example.com ",9)"
syntax for cells you want to be able to use hyperlink and do things like SUM
with.  You can even format the cell as currency.  Also, opening the original
.xls in LO and saving changes made using the "=HYPERLINK" syntax as .xls again
persists and opens in both Excel and LO fine, and all the original excel links
still work.  There should be no need to save as .ods if you ultimately want to
get back to .xls format.  So, I don't see any issues that need to be fixed here
-- marking NEEDINFO in case there is something I might be missing.

Here is what I tested with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c498e2acd64688df9aa32bbcc820d8513a5373ea
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158408] Enhancement and RFC: File Language Versioning within Writer

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158408

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #2 from V Stuart Foote  ---
-1, not seeing the use case for handling concurrent text streams in multiple
languages within an OASIS *ODF centric* document.

Individual Paragraphs can be authored in any language, and as Heiko notes whole
ODF sections can be hidden/exported to suit any specific authoring need.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158408] Enhancement and RFC: File Language Versioning within Writer

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158408

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org

--- Comment #2 from V Stuart Foote  ---
-1, not seeing the use case for handling concurrent text streams in multiple
languages within an OASIS *ODF centric* document.

Individual Paragraphs can be authored in any language, and as Heiko notes whole
ODF sections can be hidden/exported to suit any specific authoring need.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158408] Enhancement and RFC: File Language Versioning within Writer

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158408

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158520] Writer: Index-tagged headings not considered headings cross-reference-wise

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158520

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158408] Enhancement and RFC: File Language Versioning within Writer

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158408

QA Administrators  changed:

   What|Removed |Added

 Whiteboard| QA:needsComment|

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158512] FILEOPEN PPTX Placeholder on master slide with Use background fill opened incorrectly on slide

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158512

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158517] the writer series print function does not produce the required documents

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158517

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158511] LibreOffice Writer: make it possible to export Custom Properties to PDF

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158511

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158729] Cropped images change on compression

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158729

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158729] Cropped images change on compression

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158729

--- Comment #10 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155423] crashing

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155423

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |INSUFFICIENTDATA

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155107] Crashed when i tried to disable macros

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155107

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155423] crashing

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155423

--- Comment #4 from QA Administrators  ---
Dear Gerald Sherman,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155957] Recent Special Char Wrong

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155957

--- Comment #2 from QA Administrators  ---
Dear Jens-D Doll,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155107] Crashed when i tried to disable macros

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155107

--- Comment #4 from QA Administrators  ---
Dear Evan Watkins,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 148411] Accessing "Help" options crashes LibreOffice

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=148411

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 148411] Accessing "Help" options crashes LibreOffice

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=148411

--- Comment #13 from QA Administrators  ---
Dear James Burke,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146256] Customization for Base "Standard" toolbar is stored in document

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146256

--- Comment #2 from QA Administrators  ---
Dear Andreas Säger,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155307] Libreoffice crashes every time on iMac with M1 CPU

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155307

--- Comment #10 from QA Administrators  ---
Dear Tom Lin,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146290] UI: Can not input number manually in the spin button field of the Data Series dialog

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=146290

--- Comment #3 from QA Administrators  ---
Dear yichuang驿窗,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145855] Grammar check doesn't work

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=145855

--- Comment #10 from QA Administrators  ---
Dear Dennis Rice,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155876] [LOCALHELP] - Calc - Help pages about dialogs should provide instructions for the Tabbed UI

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155876

--- Comment #48 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/help/commit/07a822f717dc58bf03b542636bc9ef7d77d6066f

tdf#155876 UI cmds Calc-Sheet menu (34)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - helpcontent2

2023-12-18 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bfabeac87c7fb2a5ebf24cf96489a60fab8370e6
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 23:58:37 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Dec 19 03:58:37 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-24-2'
  to 07a822f717dc58bf03b542636bc9ef7d77d6066f
  - tdf#155876 UI cmds Calc-Sheet menu (34)

+ Sheet menu for Calc, end
+ refactoring

Change-Id: Iddbd6f37722ea6eb020431cecf42966ffee703ba
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160959
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 0565c612d43abbbd3ad454843d59770349b82487)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160937

diff --git a/helpcontent2 b/helpcontent2
index 33e3184a74de..07a822f717dc 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 33e3184a74dee2ee21c8229965bf19bd487c336d
+Subproject commit 07a822f717dc58bf03b542636bc9ef7d77d6066f

help.git: Branch 'libreoffice-24-2' - AllLangHelp_scalc.mk source/text

2023-12-18 Thread Olivier Hallot (via logerrit)

 AllLangHelp_scalc.mk|3 ++
 source/text/scalc/00/sheet_menu.xhp |   16 ++
 source/text/scalc/01/0222.xhp   |   17 ---
 source/text/scalc/01/DeleteAllNotes.xhp |7 ++
 source/text/scalc/01/DeleteNote.xhp |5 +---
 source/text/scalc/01/JumpToNextTable.xhp|   31 
 source/text/scalc/01/JumpToNextTableSel.xhp |2 -
 source/text/scalc/01/JumpToPrevTable.xhp|   31 
 source/text/scalc/01/NavigateMenu.xhp   |   31 
 source/text/scalc/01/events_sheet.xhp   |1 
 source/text/scalc/01/hide_sheet.xhp |4 +--
 source/text/scalc/main0116.xhp  |   21 ++
 source/text/shared/01/06140500.xhp  |1 
 13 files changed, 137 insertions(+), 33 deletions(-)

New commits:
commit 07a822f717dc58bf03b542636bc9ef7d77d6066f
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 23:47:16 2023 -0300
Commit: Olivier Hallot 
CommitDate: Tue Dec 19 03:58:37 2023 +0100

tdf#155876 UI cmds Calc-Sheet menu (34)

+ Sheet menu for Calc, end
+ refactoring

Change-Id: Iddbd6f37722ea6eb020431cecf42966ffee703ba
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160959
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit 0565c612d43abbbd3ad454843d59770349b82487)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160937

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 968c68ce67..1b7d10db70 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -292,10 +292,13 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/InsertCurrentDate \
 helpcontent2/source/text/scalc/01/InsertCurrentTime \
 helpcontent2/source/text/scalc/01/JumpToNextTableSel \
+helpcontent2/source/text/scalc/01/JumpToNextTable \
 helpcontent2/source/text/scalc/01/JumpToPrevTableSel \
+helpcontent2/source/text/scalc/01/JumpToPrevTable \
 helpcontent2/source/text/scalc/01/live_data_stream \
 helpcontent2/source/text/scalc/01/ManageNames \
 helpcontent2/source/text/scalc/01/MergeCellsMenu \
+helpcontent2/source/text/scalc/01/NavigateMenu \
 helpcontent2/source/text/scalc/01/NormalViewMode \
 helpcontent2/source/text/scalc/01/recalculate_hard \
 helpcontent2/source/text/scalc/01/SelectColumn \
diff --git a/source/text/scalc/00/sheet_menu.xhp 
b/source/text/scalc/00/sheet_menu.xhp
index 7cd27e75cc..d7ef89f44c 100644
--- a/source/text/scalc/00/sheet_menu.xhp
+++ b/source/text/scalc/00/sheet_menu.xhp
@@ -441,5 +441,21 @@
 
   
 
+
+  
+  Choose 
Sheet - Navigate.
+
+
+  
+  Choose 
Sheet - Navigate - To Next Sheet.
+  
+  CommandCtrl
 + Tab
+
+
+  
+  Choose 
Sheet - Navigate - To Previous Sheet.
+  
+  CommandCtrl
 + Shift +Tab
+
 
 
diff --git a/source/text/scalc/01/0222.xhp 
b/source/text/scalc/01/0222.xhp
index cba783f834..2dc0c3abfd 100644
--- a/source/text/scalc/01/0222.xhp
+++ b/source/text/scalc/01/0222.xhp
@@ -10,7 +10,7 @@
 
   
 
-  Go to Sheet
+  Go to Sheet
   /text/scalc/01/0222.xhp
 
 
@@ -18,9 +18,9 @@
 
   
   
-  
-  
-  
+  
+  
+  
 Go to sheet
 jump; to given sheet
 sheet; go to directly
@@ -28,15 +28,16 @@
   
   
 Go to Sheet
-Go to a 
specified sheet.
+Go to a 
specified sheet.
   
   
+
 Choose 
Sheet - Navigate - Go To Sheet.
   
-  
+  
   Type a sheet name
-  Type some characters contained in the searched sheet 
name. List of sheets will be limited to the sheet names containing these 
characters. Search is case-sensitive. If empty, all visible sheets are 
listed.
+  Type some characters contained in the searched sheet 
name. List of sheets will be limited to the sheet names containing these 
characters. Search is case-sensitive. If empty, all visible sheets are 
listed.
   Sheets
-  Lists the sheets in the current document. Hidden sheets 
are not listed. To select a sheet, press the up or down arrow keys to move to a 
sheet in the list. Double-clicking on a name will directly jump to this 
sheet.
+  Lists the sheets in the current document. Hidden sheets 
are not listed. To select a sheet, press the up or down arrow keys to move to a 
sheet in the list. Double-clicking on a name will directly jump to this 
sheet.
 
 
diff --git a/source/text/scalc/01/DeleteAllNotes.xhp 
b/source/text/scalc/01/DeleteAllNotes.xhp
index 9285224807..5b7844a441 100644
--- a/source/text/scalc/01/DeleteAllNotes.xhp
+++ b/source/text/scalc/01/DeleteAllNotes.xhp
@@ -15,9 +15,8 @@
 /text/scalc/01/DeleteAllNotes.xhp
 
 
-
-
-
+
+
 
 Delete All 
Comments
 Deletes all 
cell notes of the current sheet.
@@ -25,7 +24,7 @@
 
 
 
-
+
 
 
 
diff --git a/source/text/scalc/01/DeleteNote.xhp

core.git: helpcontent2

2023-12-18 Thread Stéphane Guillou (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ca046e50ff48b06d3ea12ded48c3420be0fff341
Author: Stéphane Guillou 
AuthorDate: Tue Dec 19 03:58:10 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Tue Dec 19 03:58:10 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to a08e4de6931f915b708a749d82d841bf0f6a8032
  - tdf#156156: add Gallery sidebar deck help button's HID

Change-Id: I15ff9b62bd14eef98eca54886f933eb4da21a26d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160868
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 0565c612d43a..a08e4de6931f 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0565c612d43abbbd3ad454843d59770349b82487
+Subproject commit a08e4de6931f915b708a749d82d841bf0f6a8032

help.git: source/text

2023-12-18 Thread Stéphane Guillou (via logerrit)

 source/text/shared/01/gallery.xhp |1 +
 1 file changed, 1 insertion(+)

New commits:
commit a08e4de6931f915b708a749d82d841bf0f6a8032
Author: Stéphane Guillou 
AuthorDate: Mon Dec 18 15:10:30 2023 +0100
Commit: Olivier Hallot 
CommitDate: Tue Dec 19 03:58:09 2023 +0100

tdf#156156: add Gallery sidebar deck help button's HID

Change-Id: I15ff9b62bd14eef98eca54886f933eb4da21a26d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160868
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/shared/01/gallery.xhp 
b/source/text/shared/01/gallery.xhp
index 54b50a2c1a..25ec161a3f 100644
--- a/source/text/shared/01/gallery.xhp
+++ b/source/text/shared/01/gallery.xhp
@@ -36,6 +36,7 @@
 
 
 
+
 
 Gallery
 Opens the Gallery deck of the Sidebar, 
where you can select images and audio clips to insert into your 
document.

[Bug 155876] [LOCALHELP] - Calc - Help pages about dialogs should provide instructions for the Tabbed UI

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155876

--- Comment #47 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/help/commit/33e3184a74dee2ee21c8229965bf19bd487c336d

tdf#155876 UI cmds Calc-Sheet menu (33)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - helpcontent2

2023-12-18 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 18d46526edc08a6c49afc43c9ff0dee482d0cf35
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 23:56:36 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Dec 19 03:56:36 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'libreoffice-24-2'
  to 33e3184a74dee2ee21c8229965bf19bd487c336d
  - tdf#155876 UI cmds Calc-Sheet menu (33)

+ Sheet menu for Calc: manage Comments submenu
+ untangle Calc comments from Writer
+ refactoring

Change-Id: I22b8e79b96d72b8918da04bc802cdd29c5d9dba0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160958
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160936

diff --git a/helpcontent2 b/helpcontent2
index 12ca81577572..33e3184a74de 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 12ca81577572bb0bb3f974956d6ea174cdc3dff8
+Subproject commit 33e3184a74dee2ee21c8229965bf19bd487c336d

help.git: Branch 'libreoffice-24-2' - AllLangHelp_scalc.mk source/text

2023-12-18 Thread Olivier Hallot (via logerrit)

 AllLangHelp_scalc.mk  |5 +
 source/text/scalc/00/sheet_menu.xhp   |   82 --
 source/text/scalc/01/DeleteAllNotes.xhp   |   32 +++
 source/text/scalc/01/DeleteNote.xhp   |   32 +++
 source/text/scalc/01/HideNote.xhp |   31 +++
 source/text/scalc/01/SheetCommentMenu.xhp |   34 
 source/text/scalc/01/ShowNote.xhp |   31 +++
 source/text/shared/00/0404.xhp|   52 +++
 source/text/shared/01/0405.xhp|   82 +++---
 source/text/shared/01/view_comments.xhp   |   11 
 10 files changed, 329 insertions(+), 63 deletions(-)

New commits:
commit 33e3184a74dee2ee21c8229965bf19bd487c336d
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 22:25:00 2023 -0300
Commit: Olivier Hallot 
CommitDate: Tue Dec 19 03:56:35 2023 +0100

tdf#155876 UI cmds Calc-Sheet menu (33)

+ Sheet menu for Calc: manage Comments submenu
+ untangle Calc comments from Writer
+ refactoring

Change-Id: I22b8e79b96d72b8918da04bc802cdd29c5d9dba0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160958
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 
(cherry picked from commit afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160936

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 8b630a5e2f..968c68ce67 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -189,6 +189,8 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/data_provider \
 helpcontent2/source/text/scalc/01/databar_more_options \
 helpcontent2/source/text/scalc/01/default_number_formats \
+helpcontent2/source/text/scalc/01/DeleteNote \
+helpcontent2/source/text/scalc/01/DeleteAllNotes \
 helpcontent2/source/text/scalc/01/duplicate_sheet \
 helpcontent2/source/text/scalc/01/EditSelectMenu \
 helpcontent2/source/text/scalc/01/events_sheet \
@@ -285,6 +287,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/func_workday \
 helpcontent2/source/text/scalc/01/func_year \
 helpcontent2/source/text/scalc/01/func_yearfrac \
+helpcontent2/source/text/scalc/01/HideNote \
 helpcontent2/source/text/scalc/01/hide_sheet \
 helpcontent2/source/text/scalc/01/InsertCurrentDate \
 helpcontent2/source/text/scalc/01/InsertCurrentTime \
@@ -300,7 +303,9 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/SelectRow \
 helpcontent2/source/text/scalc/01/SetInputMode \
 helpcontent2/source/text/scalc/01/shared_spreadsheet \
+helpcontent2/source/text/scalc/01/SheetCommentMenu \
 helpcontent2/source/text/scalc/01/sheet_tab_color \
+helpcontent2/source/text/scalc/01/ShowNote \
 helpcontent2/source/text/scalc/01/solver \
 helpcontent2/source/text/scalc/01/solver_options \
 helpcontent2/source/text/scalc/01/solver_options_algo \
diff --git a/source/text/scalc/00/sheet_menu.xhp 
b/source/text/scalc/00/sheet_menu.xhp
index ca278f7fbf..7cd27e75cc 100644
--- a/source/text/scalc/00/sheet_menu.xhp
+++ b/source/text/scalc/00/sheet_menu.xhp
@@ -362,10 +362,84 @@
   On the 
Layout menu of the Layout tab, choose 
Column Break.
 
 
+
+  
+  Choose 
Sheet - Cell Comments.
+
+
 Choose Sheet - Cell Comments - Edit 
Comment
-Choose Sheet - Cell Comments - Hide 
Comment
-Choose Sheet - Cell Comments - Show 
Comment
-Choose Sheet - Cell Comments - Delete 
Comment
-Choose Sheet - Cell Comments - Delete All 
Comments
+
+
+  
+  Choose 
Sheet - Cell Comments - Hide Comment
+  
+  Choose Hide 
Comment.
+  
+  
+
+  
+Icon Hide 
Comment
+  
+  
+Hide 
Comment
+  
+
+  
+
+
+  
+  Choose 
Sheet - Cell Comments - Show Comment
+  
+  Choose Show 
Comment.
+  
+  
+
+  
+Icon Show 
Comment
+  
+  
+Show 
Comment
+  
+
+  
+
+
+
+  
+  Choose 
Sheet - Cell Comments - Delete Comment
+  
+  Choose 
Delete Comment.
+  
+  Choose 
Review - Delete Comment.
+  
+  
+
+  
+Icon Delete 
Comment
+  
+  
+Delete 
Comment
+  
+
+  
+
+
+
+  
+  Choose 
Sheet - Cell Comments - Delete All Comments
+  
+  Choose 
Review - Delete All Comments.
+  
+  
+
+  
+Icon Delete All 
Comments
+  
+  
+Delete All 
Comments
+  
+
+  
+
 
 
diff --git a/source/text/scalc/01/DeleteAllNotes.xhp 
b/source/text/scalc/01/DeleteAllNotes.xhp
new file mode 100644
index 00..9285224807
--- /dev/null
+++ b/source/text/scalc/01/DeleteAllNotes.xhp
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+Delete All Comments
+/text/scalc/01/DeleteAllNotes.xhp
+
+
+
+
+
+
+Delete All 
Comments
+Deletes all 
cell notes of the current sheet.
+
+
+
+

[Bug 155876] [LOCALHELP] - Calc - Help pages about dialogs should provide instructions for the Tabbed UI

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155876

--- Comment #46 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/0565c612d43abbbd3ad454843d59770349b82487

tdf#155876 UI cmds Calc-Sheet menu (34)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2023-12-18 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 34cf1d2e0f53fed3be177dffcf6d7ae42bc2924b
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 23:54:39 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Dec 19 03:54:39 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to 0565c612d43abbbd3ad454843d59770349b82487
  - tdf#155876 UI cmds Calc-Sheet menu (34)

+ Sheet menu for Calc, end
+ refactoring

Change-Id: Iddbd6f37722ea6eb020431cecf42966ffee703ba
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160959
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index afcd5a5df56c..0565c612d43a 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18
+Subproject commit 0565c612d43abbbd3ad454843d59770349b82487

help.git: AllLangHelp_scalc.mk source/text

2023-12-18 Thread Olivier Hallot (via logerrit)

 AllLangHelp_scalc.mk|3 ++
 source/text/scalc/00/sheet_menu.xhp |   16 ++
 source/text/scalc/01/0222.xhp   |   17 ---
 source/text/scalc/01/DeleteAllNotes.xhp |7 ++
 source/text/scalc/01/DeleteNote.xhp |5 +---
 source/text/scalc/01/JumpToNextTable.xhp|   31 
 source/text/scalc/01/JumpToNextTableSel.xhp |2 -
 source/text/scalc/01/JumpToPrevTable.xhp|   31 
 source/text/scalc/01/NavigateMenu.xhp   |   31 
 source/text/scalc/01/events_sheet.xhp   |1 
 source/text/scalc/01/hide_sheet.xhp |4 +--
 source/text/scalc/main0116.xhp  |   21 ++
 source/text/shared/01/06140500.xhp  |1 
 13 files changed, 137 insertions(+), 33 deletions(-)

New commits:
commit 0565c612d43abbbd3ad454843d59770349b82487
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 23:47:16 2023 -0300
Commit: Olivier Hallot 
CommitDate: Tue Dec 19 03:54:38 2023 +0100

tdf#155876 UI cmds Calc-Sheet menu (34)

+ Sheet menu for Calc, end
+ refactoring

Change-Id: Iddbd6f37722ea6eb020431cecf42966ffee703ba
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160959
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 968c68ce67..1b7d10db70 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -292,10 +292,13 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/InsertCurrentDate \
 helpcontent2/source/text/scalc/01/InsertCurrentTime \
 helpcontent2/source/text/scalc/01/JumpToNextTableSel \
+helpcontent2/source/text/scalc/01/JumpToNextTable \
 helpcontent2/source/text/scalc/01/JumpToPrevTableSel \
+helpcontent2/source/text/scalc/01/JumpToPrevTable \
 helpcontent2/source/text/scalc/01/live_data_stream \
 helpcontent2/source/text/scalc/01/ManageNames \
 helpcontent2/source/text/scalc/01/MergeCellsMenu \
+helpcontent2/source/text/scalc/01/NavigateMenu \
 helpcontent2/source/text/scalc/01/NormalViewMode \
 helpcontent2/source/text/scalc/01/recalculate_hard \
 helpcontent2/source/text/scalc/01/SelectColumn \
diff --git a/source/text/scalc/00/sheet_menu.xhp 
b/source/text/scalc/00/sheet_menu.xhp
index 7cd27e75cc..d7ef89f44c 100644
--- a/source/text/scalc/00/sheet_menu.xhp
+++ b/source/text/scalc/00/sheet_menu.xhp
@@ -441,5 +441,21 @@
 
   
 
+
+  
+  Choose 
Sheet - Navigate.
+
+
+  
+  Choose 
Sheet - Navigate - To Next Sheet.
+  
+  CommandCtrl
 + Tab
+
+
+  
+  Choose 
Sheet - Navigate - To Previous Sheet.
+  
+  CommandCtrl
 + Shift +Tab
+
 
 
diff --git a/source/text/scalc/01/0222.xhp 
b/source/text/scalc/01/0222.xhp
index cba783f834..2dc0c3abfd 100644
--- a/source/text/scalc/01/0222.xhp
+++ b/source/text/scalc/01/0222.xhp
@@ -10,7 +10,7 @@
 
   
 
-  Go to Sheet
+  Go to Sheet
   /text/scalc/01/0222.xhp
 
 
@@ -18,9 +18,9 @@
 
   
   
-  
-  
-  
+  
+  
+  
 Go to sheet
 jump; to given sheet
 sheet; go to directly
@@ -28,15 +28,16 @@
   
   
 Go to Sheet
-Go to a 
specified sheet.
+Go to a 
specified sheet.
   
   
+
 Choose 
Sheet - Navigate - Go To Sheet.
   
-  
+  
   Type a sheet name
-  Type some characters contained in the searched sheet 
name. List of sheets will be limited to the sheet names containing these 
characters. Search is case-sensitive. If empty, all visible sheets are 
listed.
+  Type some characters contained in the searched sheet 
name. List of sheets will be limited to the sheet names containing these 
characters. Search is case-sensitive. If empty, all visible sheets are 
listed.
   Sheets
-  Lists the sheets in the current document. Hidden sheets 
are not listed. To select a sheet, press the up or down arrow keys to move to a 
sheet in the list. Double-clicking on a name will directly jump to this 
sheet.
+  Lists the sheets in the current document. Hidden sheets 
are not listed. To select a sheet, press the up or down arrow keys to move to a 
sheet in the list. Double-clicking on a name will directly jump to this 
sheet.
 
 
diff --git a/source/text/scalc/01/DeleteAllNotes.xhp 
b/source/text/scalc/01/DeleteAllNotes.xhp
index 9285224807..5b7844a441 100644
--- a/source/text/scalc/01/DeleteAllNotes.xhp
+++ b/source/text/scalc/01/DeleteAllNotes.xhp
@@ -15,9 +15,8 @@
 /text/scalc/01/DeleteAllNotes.xhp
 
 
-
-
-
+
+
 
 Delete All 
Comments
 Deletes all 
cell notes of the current sheet.
@@ -25,7 +24,7 @@
 
 
 
-
+
 
 
 
diff --git a/source/text/scalc/01/DeleteNote.xhp 
b/source/text/scalc/01/DeleteNote.xhp
index 979de1d3e5..39e610c5b8 100644
--- a/source/text/scalc/01/DeleteNote.xhp
+++

[Bug 155876] [LOCALHELP] - Calc - Help pages about dialogs should provide instructions for the Tabbed UI

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=155876

--- Comment #45 from Commit Notification 
 ---
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18

tdf#155876 UI cmds Calc-Sheet menu (33)

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2023-12-18 Thread Olivier Hallot (via logerrit)

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 02ab65c86b8c5b273709ecf270a7111b4720680c
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 23:54:14 2023 -0300
Commit: Gerrit Code Review 
CommitDate: Tue Dec 19 03:54:14 2023 +0100

Update git submodules

* Update helpcontent2 from branch 'master'
  to afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18
  - tdf#155876 UI cmds Calc-Sheet menu (33)

+ Sheet menu for Calc: manage Comments submenu
+ untangle Calc comments from Writer
+ refactoring

Change-Id: I22b8e79b96d72b8918da04bc802cdd29c5d9dba0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160958
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 07ac0b21979b..afcd5a5df56c 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 07ac0b21979bf5168f635b8b9f243a856353a4fa
+Subproject commit afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18

help.git: AllLangHelp_scalc.mk source/text

2023-12-18 Thread Olivier Hallot (via logerrit)

 AllLangHelp_scalc.mk  |5 +
 source/text/scalc/00/sheet_menu.xhp   |   82 --
 source/text/scalc/01/DeleteAllNotes.xhp   |   32 +++
 source/text/scalc/01/DeleteNote.xhp   |   32 +++
 source/text/scalc/01/HideNote.xhp |   31 +++
 source/text/scalc/01/SheetCommentMenu.xhp |   34 
 source/text/scalc/01/ShowNote.xhp |   31 +++
 source/text/shared/00/0404.xhp|   52 +++
 source/text/shared/01/0405.xhp|   82 +++---
 source/text/shared/01/view_comments.xhp   |   11 
 10 files changed, 329 insertions(+), 63 deletions(-)

New commits:
commit afcd5a5df56c3d4ad3b265572ff1a343c4e4ba18
Author: Olivier Hallot 
AuthorDate: Mon Dec 18 22:25:00 2023 -0300
Commit: Olivier Hallot 
CommitDate: Tue Dec 19 03:54:14 2023 +0100

tdf#155876 UI cmds Calc-Sheet menu (33)

+ Sheet menu for Calc: manage Comments submenu
+ untangle Calc comments from Writer
+ refactoring

Change-Id: I22b8e79b96d72b8918da04bc802cdd29c5d9dba0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/160958
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 8b630a5e2f..968c68ce67 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -189,6 +189,8 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/data_provider \
 helpcontent2/source/text/scalc/01/databar_more_options \
 helpcontent2/source/text/scalc/01/default_number_formats \
+helpcontent2/source/text/scalc/01/DeleteNote \
+helpcontent2/source/text/scalc/01/DeleteAllNotes \
 helpcontent2/source/text/scalc/01/duplicate_sheet \
 helpcontent2/source/text/scalc/01/EditSelectMenu \
 helpcontent2/source/text/scalc/01/events_sheet \
@@ -285,6 +287,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/func_workday \
 helpcontent2/source/text/scalc/01/func_year \
 helpcontent2/source/text/scalc/01/func_yearfrac \
+helpcontent2/source/text/scalc/01/HideNote \
 helpcontent2/source/text/scalc/01/hide_sheet \
 helpcontent2/source/text/scalc/01/InsertCurrentDate \
 helpcontent2/source/text/scalc/01/InsertCurrentTime \
@@ -300,7 +303,9 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
 helpcontent2/source/text/scalc/01/SelectRow \
 helpcontent2/source/text/scalc/01/SetInputMode \
 helpcontent2/source/text/scalc/01/shared_spreadsheet \
+helpcontent2/source/text/scalc/01/SheetCommentMenu \
 helpcontent2/source/text/scalc/01/sheet_tab_color \
+helpcontent2/source/text/scalc/01/ShowNote \
 helpcontent2/source/text/scalc/01/solver \
 helpcontent2/source/text/scalc/01/solver_options \
 helpcontent2/source/text/scalc/01/solver_options_algo \
diff --git a/source/text/scalc/00/sheet_menu.xhp 
b/source/text/scalc/00/sheet_menu.xhp
index ca278f7fbf..7cd27e75cc 100644
--- a/source/text/scalc/00/sheet_menu.xhp
+++ b/source/text/scalc/00/sheet_menu.xhp
@@ -362,10 +362,84 @@
   On the 
Layout menu of the Layout tab, choose 
Column Break.
 
 
+
+  
+  Choose 
Sheet - Cell Comments.
+
+
 Choose Sheet - Cell Comments - Edit 
Comment
-Choose Sheet - Cell Comments - Hide 
Comment
-Choose Sheet - Cell Comments - Show 
Comment
-Choose Sheet - Cell Comments - Delete 
Comment
-Choose Sheet - Cell Comments - Delete All 
Comments
+
+
+  
+  Choose 
Sheet - Cell Comments - Hide Comment
+  
+  Choose Hide 
Comment.
+  
+  
+
+  
+Icon Hide 
Comment
+  
+  
+Hide 
Comment
+  
+
+  
+
+
+  
+  Choose 
Sheet - Cell Comments - Show Comment
+  
+  Choose Show 
Comment.
+  
+  
+
+  
+Icon Show 
Comment
+  
+  
+Show 
Comment
+  
+
+  
+
+
+
+  
+  Choose 
Sheet - Cell Comments - Delete Comment
+  
+  Choose 
Delete Comment.
+  
+  Choose 
Review - Delete Comment.
+  
+  
+
+  
+Icon Delete 
Comment
+  
+  
+Delete 
Comment
+  
+
+  
+
+
+
+  
+  Choose 
Sheet - Cell Comments - Delete All Comments
+  
+  Choose 
Review - Delete All Comments.
+  
+  
+
+  
+Icon Delete All 
Comments
+  
+  
+Delete All 
Comments
+  
+
+  
+
 
 
diff --git a/source/text/scalc/01/DeleteAllNotes.xhp 
b/source/text/scalc/01/DeleteAllNotes.xhp
new file mode 100644
index 00..9285224807
--- /dev/null
+++ b/source/text/scalc/01/DeleteAllNotes.xhp
@@ -0,0 +1,32 @@
+
+
+
+
+
+
+Delete All Comments
+/text/scalc/01/DeleteAllNotes.xhp
+
+
+
+
+
+
+Delete All 
Comments
+Deletes all 
cell notes of the current sheet.
+
+
+
+
+
+
+
+
+
diff --git a/source/text/scalc/01/DeleteNote.xhp 
b/source/text/scalc/01/DeleteNote.xhp
new file mode

[Bug 158768] Frozen columns in an RTL worksheet transported to its left side

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158768

--- Comment #4 from ady  ---
(In reply to Eyal Rozenberg from comment #3)
> Let's add Andreas for good measure.

:D An additional good measure would be to make the Rows header cross the
Columns header near Column A (when "freeze panes" is OFF) at the "zero/origin"
of the axis. That is, when Column A is located at the left side of the screen
(i.e. Columns header goes from left to right), then the Rows header should be
located on the left too. And when Column A is located at the right side of the
screen (i.e. Columns header goes from right to left), then the Rows header
should be located on the right too.

Please note that I am not mentioning the conditions for which the first column
is located on one side or the other (there are enough reports about that
already). I am just saying that the Rows header should always cross the Column
header at the "zero/origin" point, near Column A and near the Name box.
Following that condition, the frozen columns reported here should be fine
again.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158714] EDITING - Crash when entering diacritics in Calc.

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158714

tunaira...@yahoo.co.uk changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

--- Comment #3 from tunaira...@yahoo.co.uk ---
I'm entering the diacritics by pressing the specific key in my keyboard then
the corresponding letter.

For instance, to enter "á", I would first press the "´" key (acute) then the
"a" key, but just the accent key is enough to make LibreOffice freeze.

I'm using the Brazilian Portuguese (pt_BR) ABNT2 layout, which is the default
for keyboards in the country.

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158768] Frozen columns in an RTL worksheet transported to its left side

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158768

Eyal Rozenberg  changed:

   What|Removed |Added

Summary|Calc behavior change in |Frozen columns in an RTL
   |frozen columns on RTL   |worksheet transported to
   |sheets  |its left side

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158768] Calc behavior change in frozen columns on RTL sheets

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158768

Eyal Rozenberg  changed:

   What|Removed |Added

 OS|Windows (All)   |All

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158768] Calc behavior change in frozen columns on RTL sheets

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158768

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #3 from Eyal Rozenberg  ---
Let's add Andreas for good measure.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158768] Calc behavior change in frozen columns on RTL sheets

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158768

--- Comment #2 from Eyal Rozenberg  ---
Created attachment 191496
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191496=edit
Screenshot of mis-rendered sheet

Confirming also with:

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 516f800f84b533db0082b1f39c19d1af40ab29c8
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US
Calc: threaded

Adding screenshot of bug manifesting. In the screenshot, I've inserted some
text into row 2:

A2 "The"
B2 "quick"
C3 "brown"

Note that "quick" is half-painted over by the row number indicators.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158768] Calc behavior change in frozen columns on RTL sheets

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158768

ady  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Version|7.6.4.1 release |7.6.3.2 release
 Status|UNCONFIRMED |NEW
 Blocks||129661
 CC||eyalr...@gmx.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||7784
Summary|Calc 7.6.4.1 behavior   |Calc behavior change in
   |change in frozen RTL sheets |frozen columns on RTL
   ||sheets
   Keywords||bibisectRequest, regression

--- Comment #1 from ady  ---
FWIW, the original topic is at 


My _guess_ is that this started with tdf#157784 (please don't just read the
Summary of that report, because the commit applied in that report is not really
about that exact Summary).

In tdf#157784, there are relevant "see also" reports, and several comments
regarding several RTL items.

Repro in LO 7.6.3.2 by opening the attachment as-is. In LO 7.5.3.2 not repro
(same file opened as-is) > regression.

IOW, my _guess_ is that setting the Rows header where it is ATM located
according to the commit in tdf#157784, also the "frozen" _columns_ are located
together with it, and following the same order as the "unfrozen" columns.

As more than one user said at the time, the headers have to cross at the axis
"origin, zero".

Since I am only guessing, I am not CC'ing Andreas Heinisch yet (I am CC'ing
Eyal). I'd rather wait for some actual confirmation by someone bibisecting
this.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=129661
[Bug 129661] [META] Right-To-Left (RTL) user interface issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 129661] [META] Right-To-Left (RTL) user interface issues

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=129661

ady  changed:

   What|Removed |Added

 Depends on||158768


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=158768
[Bug 158768] Calc behavior change in frozen columns on RTL sheets
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158593] Expert dialog crashes when editing locked down "set" configuration

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158593

Stephan Bergmann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |sberg@gmail.com
   |desktop.org |
 CC||sberg@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156820] Crash when changing color with custom colour picker accessed from overflowing toolbar

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=156820

Matt K  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |matt...@gmail.com
   |desktop.org |

--- Comment #19 from Matt K  ---
Fix is tracked in: https://gerrit.libreoffice.org/c/core/+/160956

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - cui/source

2023-12-18 Thread Samuel Mehrbrodt (via logerrit)

 cui/source/options/optaboutconfig.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 89fe91ec83c8c5d690d753bc4011e2e3f9e3da89
Author: Samuel Mehrbrodt 
AuthorDate: Mon Dec 18 15:28:27 2023 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Mon Dec 18 22:26:16 2023 +0100

tdf#158720 Fix crash when searching expert config with gen vcl plugin

Change-Id: Ida2f17c8dfb638bb6791dba32ae3b190b06254de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160920
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit 9e02641932992cad3f8d4e363414b2756f0f8e52)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160931

diff --git a/cui/source/options/optaboutconfig.cxx 
b/cui/source/options/optaboutconfig.cxx
index 6e3bdd9b2747..1b02642e6d00 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -1073,7 +1073,6 @@ void CuiAboutConfigTabPage::InsertEntry(const 
prefBoxEntry& rEntry)
 m_xPrefBox->set_text(*xParentEntry, "", 1);
 m_xPrefBox->set_text(*xParentEntry, "", 2);
 m_xPrefBox->set_text(*xParentEntry, "", 3);
-m_xPrefBox->set_text_emphasis(*m_xScratchIter, 
rEntry.pUserData->bWasModified, -1);
 m_xPrefBox->set_sensitive(*xParentEntry, true);
 }

[Bug 158713] Disappearing footnotes in tables when displayed at end of document

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158713

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Version|7.6.2.1 release |7.1.8.1 release

--- Comment #7 from Telesto  ---
Also in
Version: 7.1.8.0.0+ (x64) / LibreOffice Community
Build ID: a94b58277c7aeaa83ce14347cd0b8f7137969d03
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

fine with
Version: 7.0.7.0.0+ (x64)
Build ID: 626ea4e62a3e5005fe9825923a1c0c5bdb61cc08
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158713] Disappearing footnotes in tables when displayed at end of document

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158713

Telesto  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158745] Image becomes invisible, when it's automatically shifted on the next page

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158745

Telesto  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
Version|7.5.9.2 release |6.1.0.3 release

--- Comment #3 from Telesto  ---
Also in
Version: 6.1.6.3
Build ID: 5896ab1714085361c45cf540f76f60673dd96a72
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL

still OK in
Versie: 5.2.4.2 
Build ID: 3d5603e1122f0f102b62521720ab13a38a4e0eb0
CPU Threads: 4; Versie besturingssysteem:Windows 6.2; UI Render: GL; 
Locale: nl-NL (nl_NL); Calc: CL

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 126008] TABLES STYLES: Inserting or removing a row/column changes entire table's formatting (see comment 5)

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=126008

Telesto  changed:

   What|Removed |Added

 CC||kai-lo2...@mktfabian.de

--- Comment #94 from Telesto  ---
*** Bug 158757 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158757] Font size change is automatically cancelled

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158757

Telesto  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||tele...@surfxs.nl
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Telesto  ---
Thanks for the report. A long standing, known problem :-(

*** This bug has been marked as a duplicate of bug 126008 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: starmath/source

2023-12-18 Thread Mike Kaganski (via logerrit)

 starmath/source/view.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 29b11fa3b5574dc3f42f55b0716f71054030c6c2
Author: Mike Kaganski 
AuthorDate: Mon Dec 18 20:56:58 2023 +0300
Commit: Mike Kaganski 
CommitDate: Mon Dec 18 20:48:17 2023 +0100

tdf#158766: handle Escape key in SmGraphicWidget

Same as in SmEditTextWindow

Change-Id: I4088fa2deb8b14d5cc0f48423dba492c45b0f61f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160927
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index fd765986c659..8f88b5ced643 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -707,6 +707,12 @@ bool SmGraphicWidget::KeyInput(const KeyEvent& rKEvt)
 return true;
 }
 
+if (rKEvt.GetKeyCode().GetCode() == KEY_ESCAPE)
+{
+// Terminate possible InPlace mode
+return GetView().Escape();
+}
+
 if (!SmViewShell::IsInlineEditEnabled())
 return GetView().KeyInput(rKEvt);

core.git: Branch 'libreoffice-24-2' - editeng/source

2023-12-18 Thread Samuel Mehrbrodt (via logerrit)

 editeng/source/misc/acorrcfg.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c2de1babeaa4cee171afadd6d337ffd1f17664a7
Author: Samuel Mehrbrodt 
AuthorDate: Mon Dec 18 14:36:39 2023 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Mon Dec 18 20:40:39 2023 +0100

tdf#158186 Fix saving ApplyNumberingAfterSpace

Change-Id: I6880f75c140f6e800bbdb6c56dd1ff166a3191d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160916
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 
(cherry picked from commit cefe7488930895a971dce41a286144dae39f57d4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160930

diff --git a/editeng/source/misc/acorrcfg.cxx b/editeng/source/misc/acorrcfg.cxx
index 47f634d4347f..fcafbfca6f0c 100644
--- a/editeng/source/misc/acorrcfg.cxx
+++ b/editeng/source/misc/acorrcfg.cxx
@@ -421,9 +421,9 @@ Sequence  SvxSwAutoCorrCfg::GetPropertyNames()
 "Format/ByInput/ApplyNumbering/SpecialCharacter/FontCharset",   //45
 "Format/ByInput/ApplyNumbering/SpecialCharacter/FontPitch", //46
 "Format/Option/SetDOIAttribute",//47
-"Format/ByInput/ApplyNumberingAfterSpace",  //48
+"Format/ByInput/ApplyBulletsAfterSpace",//48
 };
-const int nCount = 48;
+const int nCount = 49;
 Sequence aNames(nCount);
 OUString* pNames = aNames.getArray();
 for(int i = 0; i < nCount; i++)

core.git: officecfg/registry

2023-12-18 Thread Samuel Mehrbrodt (via logerrit)

 officecfg/registry/schema/org/openoffice/Office/Draw.xcs |   42 +++
 1 file changed, 42 insertions(+)

New commits:
commit 62d80667f5b164e7a6377c22b0f37407ccf8eb59
Author: Samuel Mehrbrodt 
AuthorDate: Mon Dec 18 11:38:56 2023 +0100
Commit: Samuel Mehrbrodt 
CommitDate: Mon Dec 18 20:40:16 2023 +0100

Revert "[API CHANGE] Remove unused CrossFading group"

This reverts commit cbc6bb9fdaf4acc815b9f11fba73c33d25a81e8f.

Reason for revert: This config group is supposed to be used, see tdf#158304 
for details.

Bug reference now added to the config group.

Change-Id: Id8d15b3f3c6abdec541e8ed7d3965259428b64fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160866
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Draw.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Draw.xcs
index 290d8148bd1a..c7ce19c2d6f4 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Draw.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Draw.xcs
@@ -336,6 +336,48 @@
   false
 
   
+  
+
+  Contains a specification of how to morph between objects (e.g. 
how many steps and whether to regard the object's attributes).
+  These settings are supposed to be saved, see 
https://bugs.documentfoundation.org/show_bug.cgi?id=158304
+
+
+  
+  
+Specifies the number of intermediate morphing steps between 
two objects.
+Steps
+  
+  
+
+  
+Specifies that there has to be at least one morphing 
step.
+  
+
+
+  
+Specifies that there may be at least this many morphing 
steps.
+  
+
+  
+  16
+
+
+  
+  
+Indicates whether two objects to be morphed shall have the 
same orientation.
+Orientation
+  
+  true
+
+
+  
+  
+Indicates whether to consider objects' attributes (e.g. 
colors) when morphing one object into another.
+Attributes
+  
+  true
+
+

[Bug 158122] odd fonts in pivot table

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158122

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INSUFFICIENTDATA

--- Comment #12 from Stéphane Guillou (stragu) 
 ---
Thanks for the info.
Given that you can't reproduce the issue anymore, let's mark as "insufficient
data" but please set back ton "unconfirmed" if you witness it again and can
provide some more information.
Might be worth also asking your system administrator to update to a more recent
version of LO, if only for the recent security fixes.
Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 153660] Single Undo should remove all diagonal borders created with Toolbar>Borders

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=153660

Timur  changed:

   What|Removed |Added

 CC||rafael.palma.l...@gmail.com

--- Comment #3 from Timur  ---
*** Bug 158748 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107739] [META] Field bugs and enhancements

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=107739
Bug 107739 depends on bug 108112, which changed state.

Bug 108112 Summary: Date in conditional text makes the text disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=108112

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158439] Design: UI Inconsistency in "Target in Document" dialog to define a hyperlink

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158439

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
(In reply to Heiko Tietze from comment #3)
> (In reply to Adalbert Hanßen from comment #0)
> > After clicking Apply, the sub-dialog Target in document should automatically
> > terminate because all choices have been done at that point.
> +1, any objection?
Yes, my comment 2, point (1). I think some workflows rely on the Target in
Document staying opened, so I vote for keeping the current Apply button as it
is, but adding an OK button to apply and close at once.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158747] Cell format changes when using cross border (row)

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158747

Rafael Lima  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rafael.palma.l...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Rafael Lima  ---
I can reproduce the issue... applying criss-cross borders remove direct
formatting as reported by the OP.

Repro with

Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Ubuntu package version: 4:7.6.4-0ubuntu0.23.10.1
Calc: threaded

Also with

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 2a9dbaf0d30fb458e7823488145515cd8693822c
CPU threads: 12; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158408] Enhancement and RFC: File Language Versioning within Writer

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158408

--- Comment #1 from Heiko Tietze  ---
The website metaphor does not work very well on dynamic content. The language
attribute plays an important role in many ways, the least would be citations.

But you could create two sections, fill one with content in language A and the
other with B, and hide it depending on a variable. Works out of the box.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108112] Date in conditional text makes the text disappear

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108112

sdc.bla...@youmail.dk changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=68
   ||364

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 82627] FILEOPEN DOCX: Text Not Rotated in Text Boxes with Rotation

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82627

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8744

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 115679] FORMATTING: can not make a zero-padded numbered list format

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=115679

Dieter  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED

--- Comment #6 from Dieter  ---
VERIFIED with

Version: 24.2.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 5f390384195b7264c6e52add9e90a39790285249
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Miklos, thank you for fixing it!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158735] Solver options are no longer saved during a spreadsheet load.

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158735

--- Comment #2 from ady  ---
(In reply to m.a.riosv from comment #1)
> 
> *** This bug has been marked as a duplicate of bug 38948 ***

One of the following alternatives should be true:

* Either the reporter of bug 158735 is confused about the versions in which the
problem first showed up (and about the older versions in which there was no
problem); 

* or bug 158735 is not really a duplicate of bug 38948.

The versions for each of these 2 reports don't match, and actually they seem
quite inverted / opposite to each other.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158703] Crash if I use the space bar several times and then punctuation (French Locale)

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158703

Xisco Faulí  changed:

   What|Removed |Added

 CC||mikekagan...@hotmail.com

--- Comment #11 from Xisco Faulí  ---
(In reply to Julien Nabet from comment #9)
> It resembles the pb which has been fixed with
> 971c9945825db02a4809538d26fff3ae77d16866
> 
> 1) const OUString& rTxt which had been replaced with std::u16string_view rTxt
> 2) as Mike indicated:
> // rTxt may refer to the frame text that will change in the calls to
> rDoc.Delete / rDoc.Insert;
> // keep a local copy for later use
> OUString aOrigTxt = rTxt;
> 
> I tried to apply the same but it still crashes.
> After this part:
> 730 if ( nEndPos - nPos > 0 )
> 731 rDoc.Delete( nPos, nEndPos ); 
> 
> rTxt has a smaller size whereas nEndPos hasn't changed so crash.
> 
> No idea what to do.

Hi Mike,
I thought you might be interested in this issue

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108112] Date in conditional text makes the text disappear

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=108112

Andreas Heinisch  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #17 from Andreas Heinisch  ---


*** This bug has been marked as a duplicate of bug 68364 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158439] Design: UI Inconsistency in "Target in Document" dialog to define a hyperlink

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158439

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
(In reply to Heiko Tietze from comment #3)
> (In reply to Adalbert Hanßen from comment #0)
> > After clicking Apply, the sub-dialog Target in document should automatically
> > terminate because all choices have been done at that point.
> +1, any objection?
Yes, my comment 2, point (1). I think some workflows rely on the Target in
Document staying opened, so I vote for keeping the current Apply button as it
is, but adding an OK button to apply and close at once.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158744] FILEOPEN DOCX Rotated text appears horizontal inside shape in canvas

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158744

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

Version|7.6.4.1 release |24.2.0.0 alpha0+
Summary|Saving .docx as .odt|FILEOPEN DOCX Rotated text
   |damages figures |appears horizontal inside
   ||shape in canvas
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=82
   ||627

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 143781] [META] Development- and code-related bug reports and tasks

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
Bug 143781 depends on bug 158041, which changed state.

Bug 158041 Summary: Drop unused Writer - Print config keys
https://bugs.documentfoundation.org/show_bug.cgi?id=158041

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158599] Hangs when opening options menu

2023-12-18 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=158599

--- Comment #4 from Cora Loftis  ---
Hello,

I came across this bug report. I've been experiencing the same issue. Whenever
I click the Options menu in either the RPM or Flatpak versions of LibreOffice,
the app hangs before displaying a dialog box to Force Quit or Wait.

I have tried opening LibreOffice in Safe Mode, and the same issue occurs in
Safe Mode. I have also tried to reset it to factory settings, purge install and
config / caches and reinstall. Nothing seems to remedy it.

I even tried to downgrade the package via DNF from 7.6.4.1 to 7.6.2.1, but the
issue persists.

SYSTEM INFORMATION: 
OS: Fedora 39
DE: GNOME 45.2
Kernel: 6.6.6-200.fc39.x86_64


LIBREOFFICE VERSION INFORMATION:
Version: 7.6.4.1 (X86_64)
Build ID: 60(Build:1)
CPU threads: 16; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Please let me know if you have any questions.

Thanks,
Cora

-- 
You are receiving this mail because:
You are the assignee for the bug.

1 2 3 4 >

1 - 100 of 348 matches

Mail list logo