[Bug 158801] CRASH: after pressing return a few times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158801

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
  Regression By||Miklos Vajna
 CC||vmik...@collabora.com,
   ||xiscofa...@libreoffice.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8341

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Miklos Vajna 2023-11-29 08:35:35 +0100
committer   Miklos Vajna 2023-11-29 09:57:41
+0100
commit  ce2fc5eb29b4e252993b549dee002fa8948c8386 (patch)
tree6b84cc1b392f7e458d90ae2307a6f16f77911b58
parent  2bf8231ab5709f0d7577d6da53f50bc7f0b65079 (diff)
tdf#158341 sw floattable: fix layout loop when fly is below the body frame

Bisected with: bibisect-linux64-24.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158801] New: CRASH: after pressing return a few times

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158801

Bug ID: 158801
   Summary: CRASH: after pressing return a few times
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 108606 from bug 60342
2. Press return 10 times

-> LibreOffice crashes after pressing return 4-5 times

Reproduced in

Version: 24.2.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 0034d2ab9382da86340738137218791a4ccc9c90
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: fr-FR (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/CppunitTest_sw_rtfexport8.mk

[Xisco Fauli (via logerrit)]

 sw/CppunitTest_sw_rtfexport8.mk |4 
 1 file changed, 4 insertions(+)

New commits:
commit 2eb428a8890dda29fbdc8b639fc1377080fab59f
Author: Xisco Fauli 
AuthorDate: Wed Dec 20 12:49:14 2023 +0100
Commit: Xisco Fauli 
CommitDate: Thu Dec 21 08:34:31 2023 +0100

CppunitTest_sw_rtfexport8: avoid external fonts

Change-Id: I7fb3f54134e3cf5a2f4fd318f36df35a4b5967dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161068
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/CppunitTest_sw_rtfexport8.mk b/sw/CppunitTest_sw_rtfexport8.mk
index 9f0a2d85ab4f..94e535c0fbe2 100644
--- a/sw/CppunitTest_sw_rtfexport8.mk
+++ b/sw/CppunitTest_sw_rtfexport8.mk
@@ -11,4 +11,8 @@
 
 $(eval $(call sw_rtfexport_test,8))
 
+ifneq ($(filter MORE_FONTS,$(BUILD_TYPE)),)
+$(eval $(call gb_CppunitTest_set_non_application_font_use,sw_rtfexport8,abort))
+endif
+
 # vim: set noet sw=4 ts=4:

[Bug 158695] --convert-to bogusly needs libcui (--disable-gui build)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158695

--- Comment #1 from Rene Engelhard  ---
This btw is a regression. 7.5.x didn't need cui for --convert-to

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158799] Editing. Have a cell background separate from the document background.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158799

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=14
   ||2679
URL||https://ask.libreoffice.org
   ||/t/change-background-of-act
   ||ive-cell-when-entering-data
   ||/99685/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 142679] Edit mode should use a transparent background if the cell has a background image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=142679

Mike Kaganski  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8799

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158375] Ability to disable active content in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158375

--- Comment #10 from Commit Notification 
 ---
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/09b13f3f85b3ef6ffe4d46e2ca5170ad81045ff4

tdf#158375: adapt UI when DDE is disabled via DisableActiveContent

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: include/svtools sc/inc sc/source sd/source sw/source

[Sarper Akdemir (via logerrit)]

 include/svtools/strings.hrc |1 +
 sc/inc/strings.hrc  |1 +
 sc/source/ui/docshell/docsh4.cxx|7 +++
 sc/source/ui/view/tabvwshb.cxx  |   10 ++
 sd/source/ui/func/fulink.cxx|   13 +
 sw/source/uibase/shells/textfld.cxx |   13 +
 sw/source/uibase/uiview/view2.cxx   |   11 +++
 7 files changed, 56 insertions(+)

New commits:
commit 09b13f3f85b3ef6ffe4d46e2ca5170ad81045ff4
Author: Sarper Akdemir 
AuthorDate: Mon Dec 18 17:28:20 2023 +0300
Commit: Sarper Akdemir 
CommitDate: Thu Dec 21 07:49:16 2023 +0100

tdf#158375: adapt UI when DDE is disabled via DisableActiveContent

When DisableActiveContent is set, provide now non-functional areas
meaningful error messages / popup dialogs.

Change-Id: I34bffee10fb0ba5c0194193f3d3d81b93d7dbd26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160923
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins

diff --git a/include/svtools/strings.hrc b/include/svtools/strings.hrc
index 53cefc48d8ff..ab18119242b3 100644
--- a/include/svtools/strings.hrc
+++ b/include/svtools/strings.hrc
@@ -264,6 +264,7 @@
 #define STR_FIELD_INVITENC_("STR_FIELD_INVITE", 
"Invite")
 
 #define STR_WARNING_ACTIVE_CONTENT_DISABLED 
NC_("STR_WARNING_ACTIVE_CONTENT_DISABLED", "Active content is disabled.")
+#define STR_WARNING_EXTERNAL_LINK_EDIT_DISABLED 
NC_("STR_ERROR_EXTERNAL_LINK_EDIT_DISABLED", "It is not possible to edit 
external links. Active content is disabled in the security settings.")
 #define STR_SVT_DEFAULT_SERVICE_LABEL   
NC_("STR_SVT_DEFAULT_SERVICE_LABEL", "$user$'s $service$")
 
 #define STR_WARNING_JAVANOTFOUND
NC_("STR_WARNING_JAVANOTFOUND", "%PRODUCTNAME requires a Java runtime 
environment (JRE) to perform this task. Please install a JRE and restart 
%PRODUCTNAME. %FAQLINK")
diff --git a/sc/inc/strings.hrc b/sc/inc/strings.hrc
index d58777176e52..266cb4cc6c5b 100644
--- a/sc/inc/strings.hrc
+++ b/sc/inc/strings.hrc
@@ -371,6 +371,7 @@
 #define STR_ENABLE_CONTENT  NC_("STR_ENABLE_CONTENT", 
"Allow updating")
 /*tooltip for the "Allow updating" infobar button*/
 #define STR_ENABLE_CONTENT_TOOLTIP  
NC_("STR_ENABLE_CONTENT_TOOLTIP", "Only allow updating if you trust this 
document.")
+#define STR_ENABLE_CONTENT_TOOLTIP_DISABLED 
NC_("STR_ENABLE_CONTENT_TOOLTIP_DISABLED", "Active content is disabled in the 
security settings. It is not possible to allow updating.")
 /*Insert image dialog*/
 #define STR_ANCHOR_TO_CELL  NC_("STR_ANCHOR_TO_CELL", 
"To cell")
 #define STR_ANCHOR_TO_CELL_RESIZE   
NC_("STR_ANCHOR_TO_CELL_RESIZE", "To cell (resize with cell)")
diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index 964515743c27..4de5b1950183 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -566,6 +566,13 @@ void ScDocShell::Execute( SfxRequest& rReq )
 rBtn.set_label(ScResId(STR_ENABLE_CONTENT));
 
rBtn.set_tooltip_text(ScResId(STR_ENABLE_CONTENT_TOOLTIP));
 rBtn.connect_clicked(LINK(this, ScDocShell, 
ReloadAllLinksHdl));
+
+// when active content is disabled the "Allow 
updating" button has no functionality.
+if 
(officecfg::Office::Common::Security::Scripting::DisableActiveContent::get())
+{
+
rBtn.set_tooltip_text(ScResId(STR_ENABLE_CONTENT_TOOLTIP_DISABLED));
+rBtn.set_sensitive(false);
+}
 }
 }
 rReq.Done();
diff --git a/sc/source/ui/view/tabvwshb.cxx b/sc/source/ui/view/tabvwshb.cxx
index f0415d03d9aa..ad0e757ce0aa 100644
--- a/sc/source/ui/view/tabvwshb.cxx
+++ b/sc/source/ui/view/tabvwshb.cxx
@@ -64,6 +64,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -485,6 +486,15 @@ void ScTabViewShell::ExecDrawIns(SfxRequest& rReq)
 case SID_LINKS:
 {
 SvxAbstractDialogFactory* pFact = 
SvxAbstractDialogFactory::Create();
+if 
(officecfg::Office::Common::Security::Scripting::DisableActiveContent::get())
+{
+std::unique_ptr 
xError(Application::CreateMessageDialog(
+nullptr, VclMessageType::Warning, VclButtonsType::Ok,
+SvtResId(STR_WARNING_EXTERNAL_LINK_EDIT_DISABLED)));
+xError->run();
+break;
+}
+
 ScopedVclPtr 
pDlg(pFact->CreateLinksDialog(pWin->GetFrameWeld(), rDoc.GetLinkManager()));
 pDlg->Execute();
 rBindings.Invalidate( nSlot );
diff --git 

[Bug 108253] [META] Calc cell formula bugs and enhancements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=108253
Bug 108253 depends on bug 54255, which changed state.

Bug 54255 Summary: MATCH does not find empty cells
https://bugs.documentfoundation.org/show_bug.cgi?id=54255

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 54255] MATCH does not find empty cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54255

Mike Kaganski  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |NOTABUG

--- Comment #18 from Mike Kaganski  ---
(In reply to David Lynch from comment #17)

As you mentioned, the specification defines the Search argument as 'Scalar',
which is defined in ODF 1.3 sect. 4.11.2 'Scalar' (there's the same definition
in ODF 1.2, so the spec version doesn't matter in this case):

> A Scalar value is a value that has a single value. A reference to more than 
> one
> cell is not a scalar (by itself), and is converted to one as described below. 
> An
> array with more than one element is not a scalar. The types Number (including 
> a
> complex number), Logical, and Text are scalars.

Further, there is ODF 1.3 sect. 4.7 'Empty Cell':

> An empty cell is neither zero nor the empty string, and an empty cell can be
> distinguished from cells containing values (including zero and the empty 
> string).
> An empty cell is not the same as an Error, in particular, it is 
> distinguishable
> from the Error #N/A (not available).

No, there is no need in MATCH to define any kind of "exception allowed for
empty cells", because the standard already defines that empty cell is not the
same as the scalars you can put into the function's 'Search' argument. Neither
"" nor 0 (nor any regex) may match an empty cell.

No, this in not a bug, nor should it change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158753] Chart wizard jumps back to chart type selection when window closes and opens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158753

--- Comment #7 from rrosn...@gmail.com ---
If course you can't reproduce it on Windows, that's why it's explicitly marked
as a Linux problem. I never had that problem on Windows either, of course I
can't tell if macOS users might be affected too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158800] bug generated in libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158800

Mike Kaganski  changed:

   What|Removed |Added

  Component|Impress |deletionRequest

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: configure.ac filter/Configuration_filter.mk officecfg/Configuration_officecfg.mk postprocess/CustomTarget_registry.mk solenv/bin

[Andras Timar (via logerrit)]

 configure.ac |1 +
 filter/Configuration_filter.mk   |2 ++
 officecfg/Configuration_officecfg.mk |   32 
 postprocess/CustomTarget_registry.mk |   15 +++
 solenv/bin/removereportbuilder.xslt  |   19 +++
 5 files changed, 61 insertions(+), 8 deletions(-)

New commits:
commit a2a9850217b3f711440283131fdfc58a9a254919
Author: Andras Timar 
AuthorDate: Sun Dec 17 17:37:51 2023 +0100
Commit: Andras Timar 
CommitDate: Thu Dec 21 07:03:28 2023 +0100

get rid of warnings when reportbuilder is not configured for build

In the LOK case for example, where there is no reportbuilder, there
were a lot of bogus warning messages at startup, confimgr complained
that there were translations for non existing configuration nodes,
all belonged to reportbuilder.

Change-Id: I7f9cef3206bddd9e333b97ee966fb950fbb352d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160887
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161048
Tested-by: Jenkins
Reviewed-by: Andras Timar 

diff --git a/configure.ac b/configure.ac
index e9755b9ee584..788342733d1c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -12974,6 +12974,7 @@ if test "$enable_report_builder" != "no" -a 
"$with_java" != "no"; then
 BUILD_TYPE="$BUILD_TYPE JFREEREPORT"
 NEED_ANT=TRUE
 fi
+BUILD_TYPE="$BUILD_TYPE REPORTBUILDER"
 else
 AC_MSG_RESULT([no])
 ENABLE_REPORTBUILDER=
diff --git a/filter/Configuration_filter.mk b/filter/Configuration_filter.mk
index 8a323e83fd54..29d503c0cc33 100644
--- a/filter/Configuration_filter.mk
+++ b/filter/Configuration_filter.mk
@@ -307,6 +307,7 @@ $(eval $(call 
filter_Configuration_add_others,fcfg_langpack,fcfg_database_others
frameloaders/org_openoffice_comp_dbflt_DBContentLoader2 \
 ))
 
+ifeq ($(ENABLE_REPORTBUILDER),TRUE)
 # fcfg_reportbuilder
 $(eval $(call 
filter_Configuration_add_types,fcfg_langpack,fcfg_reportbuilder_types.xcu,filter/source/config/fragments/types,\
StarBaseReport \
@@ -317,6 +318,7 @@ $(eval $(call 
filter_Configuration_add_filters,fcfg_langpack,fcfg_reportbuilder_
StarBaseReport \
StarBaseReportChart \
 ))
+endif
 
 # fcfg_writer
 $(eval $(call 
filter_Configuration_add_types,fcfg_langpack,fcfg_writer_types.xcu,filter/source/config/fragments/types,\
diff --git a/officecfg/Configuration_officecfg.mk 
b/officecfg/Configuration_officecfg.mk
index fc5a4ed6ebe7..aa4eec7b054c 100644
--- a/officecfg/Configuration_officecfg.mk
+++ b/officecfg/Configuration_officecfg.mk
@@ -64,12 +64,16 @@ $(eval $(call 
gb_Configuration_add_spool_modules,registry,officecfg/registry/dat
org/openoffice/Setup-base.xcu \
org/openoffice/Setup-math.xcu \
org/openoffice/Setup-report.xcu \
-   org/openoffice/Setup-reportbuilder.xcu \
+   $(call gb_Helper_optional,REPORTBUILDER, \
+   org/openoffice/Setup-reportbuilder.xcu \
+   ) \
org/openoffice/Setup-start.xcu \
org/openoffice/UserProfile-unixdesktop.xcu \
org/openoffice/VCL-unixdesktop.xcu \
org/openoffice/Office/Accelerators-macosx.xcu \
-   org/openoffice/Office/Accelerators-reportbuilder.xcu \
+   $(call gb_Helper_optional,REPORTBUILDER, \
+   org/openoffice/Office/Accelerators-reportbuilder.xcu \
+   ) \
org/openoffice/Office/Accelerators-unxwnt.xcu \
$(call gb_Helper_optional,LIBRELOGO, \
org/openoffice/Office/Addons-librelogo.xcu \
@@ -93,7 +97,9 @@ $(eval $(call 
gb_Configuration_add_spool_modules,registry,officecfg/registry/dat
org/openoffice/Office/Common-ctl.xcu \
org/openoffice/Office/Common-ctlseqcheck.xcu \
org/openoffice/Office/DataAccess-evoab2.xcu \
-   org/openoffice/Office/DataAccess-reportbuilder.xcu \
+   $(call gb_Helper_optional,REPORTBUILDER, \
+   org/openoffice/Office/DataAccess-reportbuilder.xcu \
+   ) \
org/openoffice/Office/Paths-macosx.xcu \
org/openoffice/Office/Paths-unxwnt.xcu \
org/openoffice/Office/Paths-unixdesktop.xcu \
@@ -109,13 +115,17 @@ $(eval $(call 
gb_Configuration_add_spool_modules,registry,officecfg/registry/dat
org/openoffice/Office/Embedding-impress.xcu \
org/openoffice/Office/Embedding-math.xcu \
org/openoffice/Office/Embedding-base.xcu \
-   org/openoffice/Office/Embedding-reportbuilder.xcu \
+   $(call gb_Helper_optional,REPORTBUILDER, \
+   org/openoffice/Office/Embedding-reportbuilder.xcu \
+   ) \
org/openoffice/Office/Embedding-writer.xcu \
$(call gb_Helper_optional,LIBRELOGO, \
org/openoffice/Office/UI/WriterCommands-librelogo.xcu \
org/openoffice/Office/UI/WriterWindowState-librelogo.xcu \
) \
-   

[Bug 158800] bug generated in libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158800

BogdanB  changed:

   What|Removed |Added

 CC||buzea.bog...@libreoffice.or
   ||g
 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 76007] FORMATTING: Make it possible to insert a Table in a Footnote or Endnote

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=76007

--- Comment #11 from Mike Kaganski  ---
The code makes explicit checks to not put tables there. E.g.,
SwDoc::InsertTable; SwBaseShell::InsertTable; SwTextShell::GetState (case
FN_INSERT_TABLE), etc.

Just disabling the checks in the mentioned three places already enables to
insert tables into footnotes / endnotes. They seem to behave correctly; they
even save both to ODT and DOCX (and may be seen if then opened in Word - both
in ODT and DOCX, even though re-opening ODT in Writer drops the tables, because
there's something in import code that also needs tweaking).

I believe that there should be no real difficylt problems supporting this. In
fact, this may be an interesting easyhack - the pointers here give the idea
what to look for in the code (basically, all uses of FrameTypeFlags::FOOTNOTE
and StartOfSectionIndex are suspects).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141908

--- Comment #42 from Commit Notification 
 ---
Kira Tubo committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8555c3180c367d684af48b7ecb7ceb333fcd0962

tdf#141908: replace hex colors with color keywords

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/qa

[Kira Tubo (via logerrit)]

 sw/qa/core/theme/ThemeTest.cxx   |   10 +-
 sw/qa/extras/rtfimport/rtfimport.cxx |4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

New commits:
commit 8555c3180c367d684af48b7ecb7ceb333fcd0962
Author: Kira Tubo 
AuthorDate: Thu Dec 7 21:59:48 2023 -0800
Commit: Ilmari Lauhakangas 
CommitDate: Thu Dec 21 06:43:54 2023 +0100

tdf#141908: replace hex colors with color keywords

Update hex colors 0x00, 0xFF, and 0xFF with COL_BLACK, 
COL_WHITE,
and COL_LIGHTRED, respectively. See comment #30 for more details.

Change-Id: I82ff851d8c19f9ef4aeeb01bff313160da615222
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160452
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/sw/qa/core/theme/ThemeTest.cxx b/sw/qa/core/theme/ThemeTest.cxx
index 4be895dd3f06..1c2f00e33c65 100644
--- a/sw/qa/core/theme/ThemeTest.cxx
+++ b/sw/qa/core/theme/ThemeTest.cxx
@@ -320,7 +320,7 @@ void checkEffects(std::vector const& 
rEffectStyleList)
 CPPUNIT_ASSERT_EQUAL(false, rEffect.mbRotateWithShape);
 
 CPPUNIT_ASSERT_EQUAL(model::ColorType::RGB, rEffect.maColor.getType());
-CPPUNIT_ASSERT_EQUAL(Color(0x00), rEffect.maColor.getRGB());
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, rEffect.maColor.getRGB());
 
 CPPUNIT_ASSERT_EQUAL(size_t(1), 
rEffect.maColor.getTransformations().size());
 CPPUNIT_ASSERT_EQUAL(model::TransformationType::Alpha,
@@ -351,9 +351,9 @@ CPPUNIT_TEST_FIXTURE(SwCoreThemeTest, 
testDrawPageThemeExistsDOCX)
 CPPUNIT_ASSERT_EQUAL(Color(0x9B8357), 
pTheme->GetColor(model::ThemeColorType::Accent4));
 CPPUNIT_ASSERT_EQUAL(Color(0xC2BC80), 
pTheme->GetColor(model::ThemeColorType::Accent5));
 CPPUNIT_ASSERT_EQUAL(Color(0x94A088), 
pTheme->GetColor(model::ThemeColorType::Accent6));
-CPPUNIT_ASSERT_EQUAL(Color(0x00), 
pTheme->GetColor(model::ThemeColorType::Dark1));
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, 
pTheme->GetColor(model::ThemeColorType::Dark1));
 CPPUNIT_ASSERT_EQUAL(Color(0x637052), 
pTheme->GetColor(model::ThemeColorType::Dark2));
-CPPUNIT_ASSERT_EQUAL(Color(0xFF), 
pTheme->GetColor(model::ThemeColorType::Light1));
+CPPUNIT_ASSERT_EQUAL(COL_WHITE, 
pTheme->GetColor(model::ThemeColorType::Light1));
 CPPUNIT_ASSERT_EQUAL(Color(0xCCDDEA), 
pTheme->GetColor(model::ThemeColorType::Light2));
 
 model::FontScheme const& rFontScheme = pTheme->getFontScheme();
@@ -397,9 +397,9 @@ CPPUNIT_TEST_FIXTURE(SwCoreThemeTest, 
testDrawPageThemeExistsODT)
 CPPUNIT_ASSERT_EQUAL(Color(0x9B8357), 
pTheme->GetColor(model::ThemeColorType::Accent4));
 CPPUNIT_ASSERT_EQUAL(Color(0xC2BC80), 
pTheme->GetColor(model::ThemeColorType::Accent5));
 CPPUNIT_ASSERT_EQUAL(Color(0x94A088), 
pTheme->GetColor(model::ThemeColorType::Accent6));
-CPPUNIT_ASSERT_EQUAL(Color(0x00), 
pTheme->GetColor(model::ThemeColorType::Dark1));
+CPPUNIT_ASSERT_EQUAL(COL_BLACK, 
pTheme->GetColor(model::ThemeColorType::Dark1));
 CPPUNIT_ASSERT_EQUAL(Color(0x637052), 
pTheme->GetColor(model::ThemeColorType::Dark2));
-CPPUNIT_ASSERT_EQUAL(Color(0xFF), 
pTheme->GetColor(model::ThemeColorType::Light1));
+CPPUNIT_ASSERT_EQUAL(COL_WHITE, 
pTheme->GetColor(model::ThemeColorType::Light1));
 CPPUNIT_ASSERT_EQUAL(Color(0xCCDDEA), 
pTheme->GetColor(model::ThemeColorType::Light2));
 }
 
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 3d516a004218..11bd8ab39484 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1780,7 +1780,7 @@ CPPUNIT_TEST_FIXTURE(Test, test158044Tdf)
 auto fillStyle = getProperty(xPara, "FillStyle");
 
 CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_NONE, fillStyle);
-CPPUNIT_ASSERT_EQUAL(Color(0xff), fillColor);
+CPPUNIT_ASSERT_EQUAL(COL_WHITE, fillColor);
 }
 
 {
@@ -1805,7 +1805,7 @@ CPPUNIT_TEST_FIXTURE(Test, test158044Tdf)
 
 CPPUNIT_ASSERT_LESS(sal_Int32(2), tabStops.getLength());
 CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_SOLID, fillStyle);
-CPPUNIT_ASSERT_EQUAL(Color(0xff), fillColor);
+CPPUNIT_ASSERT_EQUAL(COL_LIGHTRED, fillColor);
 }
 
 {

[Bug 141908] CppUnittests: replace usage of sal_Int32 with colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=141908

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:7.3.0 target:7.4.0   |target:7.3.0 target:7.4.0
   |reviewed:2022 target:7.5.0  |reviewed:2022 target:7.5.0
   |target:7.6.0 target:24.2.0  |target:7.6.0 target:24.2.0
   ||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158800] New: bug generated in libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158800

Bug ID: 158800
   Summary: bug generated in libreoffice
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: halya...@gmail.com

Description:
libreoffice is having bug

Steps to Reproduce:
1.ry6tu
2.ety
3.uju

Actual Results:
ertrt

Expected Results:
rerr


Reproducible: Always


User Profile Reset: No

Additional Info:
eeety

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158799] Editing. Have a cell background separate from the document background.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158799

--- Comment #1 from Mike Kaganski  ---
What is the goal of this? How would it improve workflow of users? Any feature
should only ne introduced not just because it is possible, but because it is
shown to be an improvement, which is greater than the problems of implementing
it, documenting, supporting, and confusing users who don't need it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: external/lcms2

[Taichi Haradaguchi (via logerrit)]

 external/lcms2/lcms2-2.4-windows.patch |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 324a12413f28ca506487f677d68b840529130aef
Author: Taichi Haradaguchi <20001...@ymail.ne.jp>
AuthorDate: Thu Dec 14 22:01:40 2023 +0900
Commit: Taichi Haradaguchi <20001...@ymail.ne.jp>
CommitDate: Thu Dec 21 04:49:20 2023 +0100

external/lcms2: fix lcms2-2.4-windows.patch

fix typos and macros in code.

Change-Id: I0886f3d95d87be70be1e7e6a220617f728fe6653
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161056
Tested-by: Jenkins
Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp>

diff --git a/external/lcms2/lcms2-2.4-windows.patch 
b/external/lcms2/lcms2-2.4-windows.patch
index 0281a7769a91..1b5dfdffe8a2 100644
--- a/external/lcms2/lcms2-2.4-windows.patch
+++ b/external/lcms2/lcms2-2.4-windows.patch
@@ -1,4 +1,4 @@
-This patch is neccesary for Windows (32-bit) build.
+This patch is necessary for Windows (32-bit) build.
 
 (In Jenkins' build message)
 > icc_transform.o : error LNK2019: unresolved external symbol 
 > _cmsGetColorSpace referenced in function "public: static class 
 > std::unique_ptr fxcodec::IccTransform> > __cdecl 
 > fxcodec::IccTransform::CreateTransformSRGB(class pdfium::span const >)" 
 > (?CreateTransformSRGB@IccTransform@fxcodec@@SA?AV?$unique_ptr@VIccTransform@fxcodec@@U?$default_delete@VIccTransform@fxcodec@@@std@@@std@@V?$span@$$CBE@pdfium@@@Z)
@@ -21,7 +21,7 @@ This patch is neccesary for Windows (32-bit) build.
 +// LibreOffice always builds this as DLL and with the stdcall calling
 +// convention, so make this usable from outside without having to
 +// specify CMS_DLL manually whenever the library is used.
-+#if !defined(CMS_DLL_BUILD) && !defined(CMS_DLL) && !defined(_WIN64)
++#if !defined(CMS_DLL_BUILD) && !defined(CMS_DLL) && defined(_MSC_VER) && 
defined(_M_IX86)
 +#define CMS_DLL
 +#endif
 +

[Bug 158788] Applying math formula (MAX()) to individual array elements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158788

--- Comment #7 from ady  ---
[OT]

(In reply to m.a.riosv from comment #6)
> =SUMPRODUCT({-10;10;20;30};CURRENT()>0)

@Jonathan Watt,

JIC, FYI, SUMPRODUCT() is already an array function that does not require CSE,
so the formula that Miguel presented in comment 6 should be introduced with a
simple [ENTER].

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158569] FILEOPEN XLSX Add Calc data model structure for sheet-level settings

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158569

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158746] Precise object positioning is a game of patience.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158746

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158746] Precise object positioning is a game of patience.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158746

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158562] EDITING: Cursor movement and typing out of sync preventing work in complex documents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158562

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158520] Writer: Index-tagged headings not considered headings cross-reference-wise

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158520

QA Administrators  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEEDINFO|UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158511] LibreOffice Writer: make it possible to export Custom Properties to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158511

QA Administrators  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158520] Writer: Index-tagged headings not considered headings cross-reference-wise

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158520

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158511] LibreOffice Writer: make it possible to export Custom Properties to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158511

--- Comment #3 from QA Administrators  ---
[Automated Action] NeedInfo-To-Unconfirmed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 92778] EPS images stop rendering after short period of time

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92778

--- Comment #15 from QA Administrators  ---
Dear Chris Cameron,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156026] Glitch when inserting bookmark

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156026

--- Comment #2 from QA Administrators  ---
Dear jon.nicolas,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 153727] Calc inputwin for formula bar using system font, too small for CJK input

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=153727

--- Comment #26 from QA Administrators  ---
Dear iaganicshe,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 93823] EDITING: Numbering mixed between different custom levels in master document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93823

--- Comment #9 from QA Administrators  ---
Dear Milan Bouchet-Valat,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 128211] FILEOPEN DOCX Tracked changes appear accepted in header with Link to Previous set

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=128211

--- Comment #8 from QA Administrators  ---
Dear NISZ LibreOffice Team,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 126716] Export/Save as HTML produce different result from DOCX numbered list

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=126716

--- Comment #16 from QA Administrators  ---
Dear echan00,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158533] Incorrectly export number 0 form calc to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158533

--- Comment #6 from Kira Tubo  ---
(In reply to Heiko Tietze from comment #5)
> Weird option, probably there for compatibility. Feels wrong to ignore this
> settings on export to PDF (or anything else). And, by default the option is
> checked.

If we are keeping things as is, then probably the next best thing is to update
the documentation to clarify how the settings affect the exported PDFs. 

Add info that settings under Format - Page Style - Sheet affects exported PDF: 
https://help.libreoffice.org/latest/en-US/text/scalc/guide/print_details.html?DbPAR=CALC#bm_id3154346

Clarify that settings under Tools - Options - LibreOffice Calc - View has NO
effect on exported PDF:
https://help.libreoffice.org/latest/en-US/text/shared/optionen/01060100.html?DbPAR=SHARED#bm_id3147242

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158533] Incorrectly export number 0 form calc to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158533

--- Comment #6 from Kira Tubo  ---
(In reply to Heiko Tietze from comment #5)
> Weird option, probably there for compatibility. Feels wrong to ignore this
> settings on export to PDF (or anything else). And, by default the option is
> checked.

If we are keeping things as is, then probably the next best thing is to update
the documentation to clarify how the settings affect the exported PDFs. 

Add info that settings under Format - Page Style - Sheet affects exported PDF: 
https://help.libreoffice.org/latest/en-US/text/scalc/guide/print_details.html?DbPAR=CALC#bm_id3154346

Clarify that settings under Tools - Options - LibreOffice Calc - View has NO
effect on exported PDF:
https://help.libreoffice.org/latest/en-US/text/shared/optionen/01060100.html?DbPAR=SHARED#bm_id3147242

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158789] Allow SUMIF and SUBTOTAL to apply to arrays

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158789

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #7 from m.a.riosv  ---
As detailed in
https://ask.libreoffice.org/t/is-there-an-alternative-to-sumif-for-arrays/99693/2
Both functions work using all the parameters.
=SUMIF({1;20;3};">1";{1;20;3})
or
=SUMIFS({1;20;3};{1;20;3};">1")

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158788] Applying math formula (MAX()) to individual array elements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158788

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #6 from m.a.riosv  ---
A formula like
=SUMPRODUCT({-10;10;20;30};CURRENT()>0)
seems to work as you expect, looking simple.

Don't expect a function like you want implemented, there are enough functions
pending to develop for compatibility with Excel.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158799] New: Editing. Have a cell background separate from the document background.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158799

Bug ID: 158799
   Summary: Editing. Have a cell background separate from the
document background.
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mapur...@hotmail.com

I can change the cell background that appears when I’m entering data by
setting:

Tools - LibreOffice - Application Colors - Document Background

However, this changes the background of the other nine sheets that are part of
the spreadsheet.

It seems having the background of the cell, when in Edit mode, transparent is
not feasible. Is it possible, in a future release, to be able to set the
background colour of the Edited cell separately from the colour of the Document
Background? I.e an option like:

Tools - LibreOffice - Application Colors - Edited Cell Background

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 155120] EDITING - Draw is very slow, requires wait time before and after every mouse click and release

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=155120

--- Comment #12 from steve  ---
@birnb...@posteo.de are you able to reproduce the problem in LO 7.6.4?
https://www.libreoffice.org/download/download-libreoffice/

And if the issues persists, another test would be to see how a current main
build behaves for you:
https://dev-builds.libreoffice.org/daily/master/current.html

I recall the issue where elements had a yellow tint when using skia. But that
has long been addressed. I'd have to dig up the old bug, but don't have the
capacity at this moment.

You are also using an outdated macOS version. You probably want to update to
13.6.3 to ensure you have all important patches from Apple for macOS 13.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145081] Line spacing style type "Fixed" is exposed on the property side bar but not on the style sheet dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=145081

Kira Tubo  changed:

   What|Removed |Added

   Assignee|kira.t...@gmail.com |libreoffice-b...@lists.free
   ||desktop.org
 Status|ASSIGNED|NEW

--- Comment #7 from Kira Tubo  ---
I've found some issues with attempting to fix this bug. Based on my findings, I
don't know if this can still be classified as a "beginner" hack anymore. 

I found that cui/uiconfig/ui/paraindentspacing.ui, was missing the "Fixed"
value. Adding the value seems to fix Draw and Impress, however, it creates a
duplicate "Fixed" value to Writer. I'm guessing paraindentspacing.ui is a
global setting, and something else is affecting either Writer or Draw/Impress
separately. 

I also found svx/uiconfig/ui/paralinespacingcontrol.ui, but this only seems to
affect the Line Spacing dropdown on the Properties side bar. 

I'll be unassigning this from myself for anyone else that may be interested in
picking this up. 

Some more information from Buovjaga that may be useful (thanks Buovjaga!):

> For svx/uiconfig/ui/paralinespacingcontrol.ui the corresponding .cxx
> file is svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx where
> you see
>
> , mxLineDist(m_xBuilder->weld_combo_box("line_dist"))
>
> For cui/uiconfig/ui/paraindentspacing.ui the .cxx is
> cui/source/tabpages/paragrph.cxx where you see
>
> , m_xLineDist(m_xBuilder->weld_combo_box("comboLB_LINEDIST"))
>
> It seems these are the relevant ones and there are no others controlling
> how the dropdown appears in Edit Styles. I searched for LLINESPACE_DURCH
> (German for Leading) and there were no hits in other .cxx files than
> these two.
>
> It might be some clue that there is logic for LLINESPACE_FIX in both
> .cxx files.
>
> I wonder if SvxStdParagraphTabPage::FillItemSet() in
> cui/source/tabpages/paragrph.cxx is responsible for the "magical"
> appearance of Fixed in Writer.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158753] Chart wizard jumps back to chart type selection when window closes and opens

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158753

--- Comment #6 from m.a.riosv  ---
I can't reproduce, let see if someone with Linus can test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 106316] New sidebar deck for comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106316

--- Comment #15 from Eyal Rozenberg  ---
> As Comments are also some kind of Review Information

Perhaps, but they are not changes. A record of changes can be displayed in a
sidebar, as it is not part of what the final document is. Comments _are_ a part
of the final document, albeit not a part of its body. They don't belong in a
sidebar, they belong somewhere that is more part of the document. They
certainly don't belong somewhere that's interchangeable with styles, navigator,
style inspector etc.

So, I'm against creating a sidebar deck for comments.

As for a comment _pane_, which is not in the sidebar, that's a different
matter.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 106316] New sidebar deck for comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=106316

--- Comment #15 from Eyal Rozenberg  ---
> As Comments are also some kind of Review Information

Perhaps, but they are not changes. A record of changes can be displayed in a
sidebar, as it is not part of what the final document is. Comments _are_ a part
of the final document, albeit not a part of its body. They don't belong in a
sidebar, they belong somewhere that is more part of the document. They
certainly don't belong somewhere that's interchangeable with styles, navigator,
style inspector etc.

So, I'm against creating a sidebar deck for comments.

As for a comment _pane_, which is not in the sidebar, that's a different
matter.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158588

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com

--- Comment #12 from Eyal Rozenberg  ---
This is not at all merely a dialog design problem! It's way more than that!

First, I don't see why it's legitimate, that an editor whose native format is
ODT would make changes to an opened ODT which is saved with no user actions.
The input ODT is just fine as an output ODT.

Second - the Save/Save As... dialog didn't ask me whether I wanted to embed
fonts. Who told LO I was willing to embed _any_ fonts? I sure didn't! At the
very least it should let me get to another dialog where that setting is present
- if not outright have it in the Save dialog. I get asked about PGP encryption
but not about font embedding; why?

Third, how come the choice of whether or not to embed fonts is a property of
the document? I mean, it can tell me whether it _has_ embedded fonts, but how
can another person's document hold a preference of mine? This is weird. Does
the ODF mandate this?


If you believe these should separate issues, please say which belong here and
which don't.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158588

Eyal Rozenberg  changed:

   What|Removed |Added

 CC||eyalr...@gmx.com

--- Comment #12 from Eyal Rozenberg  ---
This is not at all merely a dialog design problem! It's way more than that!

First, I don't see why it's legitimate, that an editor whose native format is
ODT would make changes to an opened ODT which is saved with no user actions.
The input ODT is just fine as an output ODT.

Second - the Save/Save As... dialog didn't ask me whether I wanted to embed
fonts. Who told LO I was willing to embed _any_ fonts? I sure didn't! At the
very least it should let me get to another dialog where that setting is present
- if not outright have it in the Save dialog. I get asked about PGP encryption
but not about font embedding; why?

Third, how come the choice of whether or not to embed fonts is a property of
the document? I mean, it can tell me whether it _has_ embedded fonts, but how
can another person's document hold a preference of mine? This is weird. Does
the ODF mandate this?


If you believe these should separate issues, please say which belong here and
which don't.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 157698] [META] Unify lockdown UX in the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=157698
Bug 157698 depends on bug 158759, which changed state.

Bug 158759 Summary: Unify lockdown behavior of Options dialog page Application 
Colors
https://bugs.documentfoundation.org/show_bug.cgi?id=158759

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: cui/source cui/uiconfig

[Balazs Varga (via logerrit)]

 cui/source/options/optcolor.cxx  |  205 +++
 cui/source/options/optcolor.hxx  |2 
 cui/uiconfig/ui/optappearancepage.ui |   62 +++---
 3 files changed, 183 insertions(+), 86 deletions(-)

New commits:
commit 0cd74b5be297f638d455b9b267462192f2e6620c
Author: Balazs Varga 
AuthorDate: Tue Dec 19 20:54:39 2023 +0100
Commit: Balazs Varga 
CommitDate: Thu Dec 21 00:22:27 2023 +0100

tdf#158759 - UI: Part 56 - Unify lockdown behavior of Options dialog

for General - Application Colors Page.

Change-Id: I2fb6c73cef82c12c3c8f3c49fb0e4b62703a1de3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161030
Tested-by: Jenkins
Reviewed-by: Balazs Varga 

diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index c8841205f3b4..f1e1b8a26b18 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -21,6 +21,8 @@
 
 #include 
 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -36,6 +38,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 using namespace ::com::sun::star;
 using namespace ::svtools;
 
@@ -87,6 +91,8 @@ struct
 OUString pColor;
 // has checkbox?
 bool bCheckBox;
+//prop name
+std::u16string_view sPropName;
 }
 const vEntryInfo[] =
 {
@@ -98,67 +104,67 @@ const vEntryInfo[] =
 
 // The list of these entries (enum ColorConfigEntry) are in colorcfg.hxx.
 
-{ Group_General, IDS(doccolor) },
-{ Group_General, IDS_CB(docboundaries) },
-{ Group_General, IDS(appback) },
-{ Group_General, IDS_CB(objboundaries) },
-{ Group_General, IDS_CB(tblboundaries) },
-{ Group_General, IDS(font) },
-{ Group_General, IDS_CB(unvisitedlinks) },
-{ Group_General, IDS_CB(visitedlinks) },
-{ Group_General, IDS(autospellcheck) },
-{ Group_General, IDS(grammarcheck) },
-{ Group_General, IDS(smarttags) },
-{ Group_General, IDS_CB(shadows) },
-
-{ Group_Writer,  IDS(writergrid) },
-{ Group_Writer,  IDS_CB(field) },
-{ Group_Writer,  IDS_CB(index) },
-{ Group_Writer,  IDS(direct) },
-{ Group_Writer,  IDS(script) },
-{ Group_Writer,  IDS_CB(section) },
-{ Group_Writer,  IDS(hdft) },
-{ Group_Writer,  IDS(pagebreak) },
-
-{ Group_Html,IDS(sgml) },
-{ Group_Html,IDS(htmlcomment) },
-{ Group_Html,IDS(htmlkeyword) },
-{ Group_Html,IDS(unknown) },
-
-{ Group_Calc,IDS(calcgrid) },
-{ Group_Calc,IDS(brk) },
-{ Group_Calc,IDS(brkmanual) },
-{ Group_Calc,IDS(brkauto) },
-{ Group_Calc,IDS_CB(hiddencolrow) },
-{ Group_Calc,IDS_CB(textoverflow) },
-{ Group_Calc,IDS(comments) },
-{ Group_Calc,IDS(det) },
-{ Group_Calc,IDS(deterror) },
-{ Group_Calc,IDS(ref) },
-{ Group_Calc,IDS(notes) },
-{ Group_Calc,IDS(values) },
-{ Group_Calc,IDS(formulas) },
-{ Group_Calc,IDS(text) },
-{ Group_Calc,IDS(protectedcells) },
-
-{ Group_Draw,IDS(drawgrid) },
-
-{ Group_Basic,   IDS(basiceditor) },
-{ Group_Basic,   IDS(basicid) },
-{ Group_Basic,   IDS(basiccomment) },
-{ Group_Basic,   IDS(basicnumber) },
-{ Group_Basic,   IDS(basicstring) },
-{ Group_Basic,   IDS(basicop) },
-{ Group_Basic,   IDS(basickeyword) },
-{ Group_Basic,   IDS(error) },
-
-{ Group_Sql, IDS(sqlid) },
-{ Group_Sql, IDS(sqlnumber) },
-{ Group_Sql, IDS(sqlstring) },
-{ Group_Sql, IDS(sqlop) },
-{ Group_Sql, IDS(sqlkeyword) },
-{ Group_Sql, IDS(sqlparam) },
-{ Group_Sql, IDS(sqlcomment) }
+{ Group_General, IDS(doccolor), std::u16string_view(u"/DocColor") },
+{ Group_General, IDS_CB(docboundaries), 
std::u16string_view(u"/DocBoundaries") },
+{ Group_General, IDS(appback), std::u16string_view(u"/AppBackground") },
+{ Group_General, IDS_CB(objboundaries), 
std::u16string_view(u"/ObjectBoundaries") },
+{ Group_General, IDS_CB(tblboundaries), 
std::u16string_view(u"/TableBoundaries") },
+{ Group_General, IDS(font), std::u16string_view(u"/FontColor") },
+{ Group_General, IDS_CB(unvisitedlinks), std::u16string_view(u"/Links") },
+{ Group_General, IDS_CB(visitedlinks), 
std::u16string_view(u"/LinksVisited") },
+{ Group_General, IDS(autospellcheck), std::u16string_view(u"/Spell") },
+{ Group_General, IDS(grammarcheck), std::u16string_view(u"/Grammar") },
+{ Group_General, IDS(smarttags), std::u16string_view(u"/SmartTags") },
+{ Group_General, IDS_CB(shadows), std::u16string_view(u"/Shadow") },
+
+{ Group_Writer,  IDS(writergrid), std::u16string_view(u"/WriterTextGrid") 
},
+{ Group_Writer,  IDS_CB(field), 
std::u16string_view(u"/WriterFieldShadings") },
+{ Group_Writer,  IDS_CB(index), std::u16string_view(u"/WriterIdxShadings") 
},
+{ Group_Writer,  IDS(direct), std::u16string_view(u"/WriterDirectCursor") 
},
+{ Group_Writer,  

[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158588

Eyal Rozenberg  changed:

   What|Removed |Added

 Attachment #191303|File new.odt|After saving with Writer:
description||new.odt
 Attachment #191303|File new.odt|new.odt
   filename||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158588

Eyal Rozenberg  changed:

   What|Removed |Added

 Attachment #191303|File new.odt|After saving with Writer:
description||new.odt
 Attachment #191303|File new.odt|new.odt
   filename||

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158588

Eyal Rozenberg  changed:

   What|Removed |Added

 Attachment #191302|File old.dt |Original smaller document:
description||old.odt
 Attachment #191302|File old.odt|old.odt
   filename||

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158588] Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158588

Eyal Rozenberg  changed:

   What|Removed |Added

 Attachment #191302|File old.dt |Original smaller document:
description||old.odt
 Attachment #191302|File old.odt|old.odt
   filename||

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input (comment 5, comment 9)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158112

--- Comment #22 from libretist  ---
(In reply to V Stuart Foote from comment #21)
> @Mike's suggestion in bug 156443 of logging the key input between 's
> KEYDOWN and KEYUP and parsing that value would allow continued handling of
> the SB shortcuts as +[1-9], and to keep the MS Win Alt codes, and
> likewise the extended Unicode NumPad Alt codes with "EnableHexNumpad"
> Windows registry enabled.

Can Mike's suggestion distinguish between ALT+7 as a LibreOffice shortcut and
ALT+7 as input for the bullet point sign "•" in Windows ?
(see here: https://bugs.documentfoundation.org/show_bug.cgi?id=156443#c4 )
If not, then it doesn't seem like a good suggestion to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156443] Windows: alt+numpad doesn't work for Unicode decimal codes, like in WordPad/Word

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=156443

--- Comment #4 from libretist  ---
How would your proposed method distinguish between ALT+7 as a LibreOffice
shortcut and ALT+7 as input for the bullet point sign "•" in Windows ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/osx

[Patrick Luby (via logerrit)]

 vcl/osx/salinst.cxx |   13 +
 1 file changed, 13 insertions(+)

New commits:
commit 9f92a39234dfae40fe19ab6fa47caf8b21dd8847
Author: Patrick Luby 
AuthorDate: Wed Dec 20 09:32:06 2023 -0500
Commit: Patrick Luby 
CommitDate: Wed Dec 20 23:47:53 2023 +0100

Related: tdf#155266 stop delaying painting timer while swiping

After fixing several flushing issues in tdf#155266, scrollbars
still will not redraw until swiping has ended or paused when
using Skia/Raster or Skia disabled. So, stop the delay by only
including NSEventMaskScrollWheel if the current event type is
not NSEventTypeScrollWheel.

Change-Id: I9348e5a38b4d0fedbf424b92a71eed25280fc21f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161075
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 62ec90dd0005..7f755bb618b3 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -733,6 +733,7 @@ bool AquaSalInstance::AnyInput( VclInputFlags nType )
 
 unsigned/*NSUInteger*/ nEventMask = 0;
 if( nType & VclInputFlags::MOUSE)
+{
 nEventMask |=
 NSEventMaskLeftMouseDown| NSEventMaskRightMouseDown| 
NSEventMaskOtherMouseDown|
 NSEventMaskLeftMouseUp  | NSEventMaskRightMouseUp  | 
NSEventMaskOtherMouseUp  |
@@ -740,6 +741,18 @@ bool AquaSalInstance::AnyInput( VclInputFlags nType )
 NSEventMaskScrollWheel  |
 // NSEventMaskMouseMoved|
 NSEventMaskMouseEntered | NSEventMaskMouseExited;
+
+// Related: tdf#155266 stop delaying painting timer while swiping
+// After fixing several flushing issues in tdf#155266, scrollbars
+// still will not redraw until swiping has ended or paused when
+// using Skia/Raster or Skia disabled. So, stop the delay by only
+// including NSEventMaskScrollWheel if the current event type is
+// not NSEventTypeScrollWheel.
+NSEvent* pCurrentEvent = [NSApp currentEvent];
+if( pCurrentEvent && [pCurrentEvent type] == NSEventTypeScrollWheel )
+nEventMask &= ~NSEventMaskScrollWheel;
+}
+
 if( nType & VclInputFlags::KEYBOARD)
 nEventMask |= NSEventMaskKeyDown | NSEventMaskKeyUp | 
NSEventMaskFlagsChanged;
 if( nType & VclInputFlags::OTHER)

[Bug 158797] problem scrolling and selecting cells in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158797

Patrick Luby  changed:

   What|Removed |Added

 CC||plub...@libreoffice.org

--- Comment #2 from Patrick Luby  ---
There is a fix for issue 155266 but, unfortunately, the fix will not be
available until the LibreOffice 7.6.5 release.

Fortunately, a tester has found a workaround for LibreOffice 7.5.9 and 7.6.4:
switch to Skia/Metal rendering.

To enable Skia/Metal rendering, do the following steps:

1. Open the Options dialog by selecting the LibreOffice > Preferences menu
2. Select LibreOffice > View in the left panel
3. In the right panel, check the "Use Skia for all rendering" and uncheck
"Force Skia software rendering" checkboxes as shown in the following screen
snapshot:
 https://bugs.documentfoundation.org/attachment.cgi?id=191409
4. Press the "OK" button and restart if prompted

If that does not work, another workaround is to install LibreOffice 24.2.0
Beta1 which has the fix. Please let us know if you need steps to download the
beta version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158789] Allow SUMIF and SUBTOTAL to apply to arrays

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158789

--- Comment #6 from Jonathan Watt  ---
Sure, I understand it doesn't currently work that way, as shown in comment 0
when I asked "Could support...be added?"

But Google Sheets and Zoho Sheets both support this FWIW.

And it seems inconsistent to me that arrays work in SUM but not SUMIF:

=SUM({-10,10,20,30}) <- works
=SUMIF({-10,10,20,30},">0")  <- doesn't work

That said, it's the perogative of those of you who actually write the
LibreOffice code to decide if you want to accept this enhancement request or
not.

Thanks for your time. And thanks for your work on LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158798] New: Nomenclature: "Arrange" commands not homogeneous in UI

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158798

Bug ID: 158798
   Summary: Nomenclature: "Arrange" commands not homogeneous in UI
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: olivier.hal...@libreoffice.org

On the user interface there are different names for too similar Arrange
commands:

Writer/Calc: Format 

3fB7Y||Bring to Front
a7yVj||Forward One (.uno:ObjectForwardOne)
63eWW||Back One (.uno:ObjectBackOne)
7bpa4||Send to Back

DRAW/IMPRESS:

3fB7Y||Bring to Front
GFbAp||Bring Forward (.uno:Forward)
7ove4||Send Backward (.uno:Backward)
7bpa4||Send to Back

These commands should be named equally, as they give the same results.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158511] LibreOffice Writer: make it possible to export Custom Properties to PDF

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158511

--- Comment #2 from D.Bugger  ---
Created attachment 191536
  --> https://bugs.documentfoundation.org/attachment.cgi?id=191536=edit
Document Properties window

Hallo Dieter, thanks for replying.
The attachment contains the Document Properties window for a PDF file produced
using either OpenOffice or LibreOffice. So, somehow, Custom Properties in a PDF
file seem to be possible. Why should they not have the same meaning as in LO??

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158797] problem scrolling and selecting cells in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158797

ady  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from ady  ---
Probably a duplicate of tdf#155266. I am setting it so. If it is not really the
same, please set the report back to UNCONFIRMED and explain the difference.

*** This bug has been marked as a duplicate of bug 155266 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 33961] cross reference to a list number, dot bug

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=33961

--- Comment #15 from Anzal Khan  ---
Thnaks for sharing these types of posts on this topic and i provides the best
book named as https://carolynadamshanchett.com/;>The blog

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Resurrecting --enable-online-update-mar

[Stephan Bergmann]

On 12/15/23 13:53, Stephan Bergmann wrote:
A Windows (or Linux, mostly for testing purposes) build that configures 
--enable-online-update-mar will now generate a build that includes the 
relevant code and UI, but, lacking further 
--with-online-update-mar-...=... configure options, will not provide 
that feature in a working form.  Recent Windows nightly builds generated 
from distro-configs/LibreOfficeWin64.conf should be in that state, with 
the UI to "Enable automatic upate" at "Tools - Options... - LibreOffice 
- Online Update".  (For non-GTK VCL backends, there's still a bug that 
the "Automatic Update" section on that options page is mixed into the 
traditional --enable-online-update options at the top of the page, 
instead of down at the bottom; fixing of 
cui/uiconfig/ui/optonlineupdatepage.ui welcome...)


(The UI has meanwhile been hidden behind experimental mode with 
 
"Hide --enable-online-updaet-mar GUI behind ExperimentalMode for now".)


To have a working feature, one would at least need to provide additional 
--enable-online-update-mar-certificateder=... and 
--enable-online-update-mar-channel=... configure options.  (In the past, 
such additional configuration data had to be provided in an ini file 
referenced by a --with-update-config=... configure option.  I have 
dropped the need for that additional ini file now, turning its entries 
into individual --enable-online-update-mar-...=... configure options.) 
The certificateder option's value must be the pathname of an existing 
certificate in DER format (that will be compiled into the code) (what 
the certificte-der=... line used to specify in the --with-update-config 
ini file).  The channel option's value must match the channel name under 
which updates are available on the server (see below).


For builds based on distro-configs/LibreOfficeWin64.conf, a 
--with-online-update-mar-channel=LOOnlineUpdater has meanwhile been set 
with 
 
"Set --with-online-update-mar-channel for 
distro-configs/LibreOfficeWin64.conf"...


@Cloph:  We'll need to find a way to specify a certificate there for TDF 
builds that enable that feature.


...but we'll still need to pass an appropriate 
--with-online-update-mar-certificateder=... into such builds, ideally 
for the upcoming LO 24.2.0 RC1 builds.


The server that is contacted by LO is still hardcoded (in 
officecfg/registry/schema/org/openoffice/Office/Update.xcs) to 
 (but can be overridden with a 
LIBO_UPDATER_URL env var for testing).  On that server, LO expects to 
find a /update/check/1/LibreOffice/$SHA/$PLATFORM/$CHANNEL file 
containing the relevant update information (where $SHA is the LO 
installation's buildid, i.e., git SHA, $PLATFORM is e.g. Windows_X86_64, 
and $CHANNEL is the above --albne-online-update-mar-channel value). 
There apparently still are old Makefile.in targets (create-mar et al) to 
create such files and the actual mar files they reference, but those 
also appear to have rotten, and I still need to look into them deeper.


@Cloph:  We'll need to set up a server (and update its URL in 
Update.xcs) and set up a process to generate mar files.  It would be 
great if you find time to help me with that.


The hardcoded server URL has meanwhile been updated to an appropriate 
value with 
 
"Update --enable-online-update-mar server URL".

[Bug 158797] problem scrolling and selecting cells in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158797

jorge...@colostate.edu changed:

   What|Removed |Added

 OS|All |macOS (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158797] New: problem scrolling and selecting cells in calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158797

Bug ID: 158797
   Summary: problem scrolling and selecting cells in calc
   Product: LibreOffice
   Version: 7.5.9.2 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jorge...@colostate.edu

Description:
After updating from version 7.5.8.2(x86_64) to 7.59 and then 7.6.4 (to see if
the problem was solved) I struggle when scrolling in a Calc spreadsheet. The
"graphic display" of the table moves "slowly" and some cells or rows remain
visible on top of others. It is even difficult to get to the first column
because the table stops moving before gettin there (say at column C or B). I
re-installed version 7.5.8.2 and there I no such a problem in this version. I
am using MacOSX 13.4.1 in an intel MacMini

Steps to Reproduce:
1.Just open a spreadsheet with ~ 10 columns and ~ 500 rows and try to scroll or
select a range of cells using the mouse
2.
3.

Actual Results:
the spreadsheet "moves" slowly and out of sync, I would say

Expected Results:
Normal navigation and selection in a spreadsheet, but it is not happening


Reproducible: Always


User Profile Reset: No

Additional Info:
I hope my description of the problem is clear enough, I don't know how to
describe it better sorry.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - officecfg/registry

[Stephan Bergmann (via logerrit)]

 officecfg/registry/schema/org/openoffice/Office/Update.xcs |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1c069c14a130010ec6cf53bd1b7d84a9df589f36
Author: Stephan Bergmann 
AuthorDate: Wed Dec 20 13:27:10 2023 +0100
Commit: Stephan Bergmann 
CommitDate: Wed Dec 20 22:40:20 2023 +0100

Update --enable-online-update-mar server URL

...after consultation with hostmas...@documentfoundation.org about an
appropriate URL

Change-Id: Ie8214081b68fb14f1a7824ea7cc2301abe8c1642
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161070
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 
(cherry picked from commit 0d036d22a54234c2b9283ad2e9f37cca7513d50f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161026

diff --git a/officecfg/registry/schema/org/openoffice/Office/Update.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Update.xcs
index 1eed1a870206..6657389db6d5 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Update.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Update.xcs
@@ -41,7 +41,7 @@
 
 The URL that is used for the update check
 
-http://vm195.documentfoundation.org/
+https://update-mar.libreoffice.org/
 
 
 

core.git: include/sfx2 sc/source sd/source sfx2/source

[Miklos Vajna (via logerrit)]

 include/sfx2/lokhelper.hxx  |2 ++
 include/sfx2/request.hxx|5 +
 sc/source/core/data/global.cxx  |   11 +--
 sd/source/ui/view/viewshel.cxx  |   15 ++-
 sfx2/source/control/request.cxx |   11 +++
 sfx2/source/notify/hintpost.cxx |   37 +
 sfx2/source/view/lokhelper.cxx  |   11 +++
 7 files changed, 81 insertions(+), 11 deletions(-)

New commits:
commit ee7ca8e4ea8ed93655f99e77a9e77032ac830c46
Author: Miklos Vajna 
AuthorDate: Wed Dec 20 16:12:12 2023 +0100
Commit: Miklos Vajna 
CommitDate: Wed Dec 20 22:37:32 2023 +0100

cool#7865 sfx2 lok: fix bad view id on async command dispatch

If you try hard enough, it's possible to request an "add conditional
format" dialog in one view and have the dialog pop up in an other view.
This is related to cool#7853 but it focuses on the wider problem.

What happens is that sometimes we do want to execute an uno command in
an async way, e.g. one dialog opening an other dialog in its response
handler: making sure the dialog is not manually / synchronously spinning
the main loop while it's running is wanted. Also fixing each & every
async command dispatch manually would be a lot of work.

Fix the problem by remembering the current view in SfxHintPoster::Post()
as it posts events to the main loop and restoring that view if necessary
in SfxHintPoster::DoEvent_Impl().

Other comments:

- An alternative would be to just dispatch all these UNO commands
  synchronously, but see above, there are cases where we want to stay
  async, a nested main loop would be worse.

- An even more general fix would be to handle all calls to
  Application::PostUserEvent(), but vcl doesn't know what is the
  current view and would have trouble switching to that view (only sfx2
  and higher up knows that), so do this only at a SfxHintPoster::Post()
  level, this is already meant to fix all async uno commands.

- There was a single case in sd/ where we tried to dispatch an async
  event while switching views, so switch to a sync command dispatch
  there to avoid the problem. CppunitTest_sd_tiledrendering would hang
  without this and would emit a warning in SfxHintPoster::Post().

- Restore the sc/ code to do its async dispatch as it used to, so now
  CppunitTest_sc_tiledrendering's testOpenURL is a test case that covers
  this change.

Change-Id: I765e618f55caad791aa1fe7569a32bcc31622525
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161071
Reviewed-by: Miklos Vajna 
Tested-by: Jenkins

diff --git a/include/sfx2/lokhelper.hxx b/include/sfx2/lokhelper.hxx
index 98eeccb74476..dc144503b8dd 100644
--- a/include/sfx2/lokhelper.hxx
+++ b/include/sfx2/lokhelper.hxx
@@ -93,6 +93,8 @@ public:
 static void destroyView(int nId);
 /// Set a view shell as current one.
 static void setView(int nId);
+/// Determines if a call to setView() is in progress or not.
+static bool isSettingView();
 /// Set the edit mode for a document with callbacks disabled.
 static void setEditMode(int nMode, vcl::ITiledRenderable* pDoc);
 /// Get view shell with id
diff --git a/include/sfx2/request.hxx b/include/sfx2/request.hxx
index 5c7db9925560..16c1ad8c7273 100644
--- a/include/sfx2/request.hxx
+++ b/include/sfx2/request.hxx
@@ -119,6 +119,11 @@ public:
 /** Return the window that should be used as the parent for any dialogs 
this request creates
 */
 weld::Window* GetFrameWeld() const;
+
+void SetLokViewId(int nId);
+
+int GetLokViewId() const;
+
 private:
 const SfxRequest&   operator=(const SfxRequest &) = delete;
 };
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 15fdc7dfb39d..29a616c6b6e8 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -879,17 +879,8 @@ void ScGlobal::OpenURL(const OUString& rURL, const 
OUString& rTarget, bool bIgno
 SfxBoolItem aBrowsing( SID_BROWSE, true );
 
 // No SID_SILENT anymore
-SfxCallMode nCall = SfxCallMode::RECORD;
-if (comphelper::LibreOfficeKit::isActive())
-{
-nCall |= SfxCallMode::SYNCHRON;
-}
-else
-{
-nCall |= SfxCallMode::ASYNCHRON;
-}
 pViewFrm->GetDispatcher()->ExecuteList(SID_OPENDOC,
-nCall,
+SfxCallMode::ASYNCHRON | SfxCallMode::RECORD,
 { , , , , ,  });
 }
 
diff --git a/sd/source/ui/view/viewshel.cxx b/sd/source/ui/view/viewshel.cxx
index 09c1f95102f9..2ed4099fc5d9 100644
--- a/sd/source/ui/view/viewshel.cxx
+++ b/sd/source/ui/view/viewshel.cxx
@@ -307,10 +307,23 @@ void ViewShell::Activate(bool bIsMDIActivate)
 // thus, the Navigator will also get a current status
 SfxBoolItem aItem( SID_NAVIGATOR_INIT, true );
 if (GetDispatcher() != nullptr)
+{
+

core.git: Branch 'libreoffice-24-2' - translations

[Martin Srebotnjak (via logerrit)]

 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit efc041a4146909f5b4c073e0a6fca738520dc1a2
Author: Martin Srebotnjak 
AuthorDate: Wed Dec 20 22:30:21 2023 +0100
Commit: Gerrit Code Review 
CommitDate: Wed Dec 20 22:30:21 2023 +0100

Update git submodules

* Update translations from branch 'libreoffice-24-2'
  to 7186dfba8effe91ac5b532c343422a87f78ebe59
  - Updated Slovenian translation

Change-Id: I4abd1636021dabc93c91f1c51d3f8b0aadbb320b

diff --git a/translations b/translations
index 5a154bf69785..7186dfba8eff 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 5a154bf69785663f526502c2027e4ed7b45e7c62
+Subproject commit 7186dfba8effe91ac5b532c343422a87f78ebe59

translations.git: Branch 'libreoffice-24-2' - source/sl

[Martin Srebotnjak (via logerrit)]

 source/sl/cui/messages.po |  264 
 source/sl/dbaccess/messages.po|4 
 source/sl/filter/messages.po  |   10 
 source/sl/filter/source/config/fragments/filters.po   |4 
 source/sl/filter/source/config/fragments/types.po |4 
 source/sl/fpicker/messages.po |   10 
 source/sl/helpcontent2/source/text/sbasic/guide.po|4 
 source/sl/helpcontent2/source/text/sbasic/python.po   |   12 
 source/sl/helpcontent2/source/text/sbasic/shared.po   |   24 
 source/sl/helpcontent2/source/text/sbasic/shared/03.po|25318 +-
 source/sl/helpcontent2/source/text/scalc.po   |   48 
 source/sl/helpcontent2/source/text/scalc/00.po|  432 
 source/sl/helpcontent2/source/text/scalc/01.po|  244 
 source/sl/helpcontent2/source/text/scalc/02.po|   20 
 source/sl/helpcontent2/source/text/scalc/guide.po |   12 
 source/sl/helpcontent2/source/text/schart/01.po   |   12 
 source/sl/helpcontent2/source/text/sdatabase.po   |4 
 source/sl/helpcontent2/source/text/shared.po  |8 
 source/sl/helpcontent2/source/text/shared/00.po   |   76 
 source/sl/helpcontent2/source/text/shared/01.po   |   76 
 source/sl/helpcontent2/source/text/shared/02.po   |8 
 source/sl/helpcontent2/source/text/shared/guide.po|   62 
 source/sl/helpcontent2/source/text/shared/menu.po |   84 
 source/sl/helpcontent2/source/text/shared/optionen.po |   90 
 source/sl/helpcontent2/source/text/simpress.po|4 
 source/sl/helpcontent2/source/text/simpress/00.po |4 
 source/sl/helpcontent2/source/text/simpress/01.po |  130 
 source/sl/helpcontent2/source/text/simpress/02.po |4 
 source/sl/helpcontent2/source/text/simpress/guide.po  |   14 
 source/sl/helpcontent2/source/text/swriter.po |   60 
 source/sl/helpcontent2/source/text/swriter/00.po  |   14 
 source/sl/helpcontent2/source/text/swriter/01.po  |   38 
 source/sl/helpcontent2/source/text/swriter/02.po  |4 
 source/sl/helpcontent2/source/text/swriter/guide.po   |   18 
 source/sl/helpcontent2/source/text/swriter/librelogo.po   |8 
 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po |   23 
 source/sl/readlicense_oo/docs.po  |   12 
 source/sl/sc/messages.po  |  201 
 source/sl/sd/messages.po  |  302 
 source/sl/setup_native/source/mac.po  |   12 
 source/sl/sfx2/messages.po|  557 
 source/sl/starmath/messages.po|   56 
 source/sl/svtools/messages.po |   10 
 source/sl/svx/messages.po |  192 
 source/sl/sw/messages.po  |  412 
 source/sl/uui/messages.po |   21 
 source/sl/vcl/messages.po |   31 
 source/sl/xmlsecurity/messages.po |6 
 48 files changed, 16157 insertions(+), 12806 deletions(-)

New commits:
commit 7186dfba8effe91ac5b532c343422a87f78ebe59
Author: Martin Srebotnjak 
AuthorDate: Wed Dec 20 22:29:43 2023 +0100
Commit: Andras Timar 
CommitDate: Wed Dec 20 22:30:17 2023 +0100

Updated Slovenian translation

Change-Id: I4abd1636021dabc93c91f1c51d3f8b0aadbb320b

diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po
index 1e215a9e8aa..da32ac995f9 100644
--- a/source/sl/cui/messages.po
+++ b/source/sl/cui/messages.po
@@ -3,8 +3,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 24.02
"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI
"
-"POT-Creation-Date: 2023-11-12 23:29+0100
"
-"PO-Revision-Date: 2023-11-21 11:21+0200
"
+"POT-Creation-Date: 2023-12-10 12:10+0100
"
+"PO-Revision-Date: 2023-12-19 10:08+0200
"
 "Last-Translator: Martin Srebotnjak 
"
 "Language-Team: sl.libreoffice.org
"
 "Language: sl
"
@@ -124,6 +124,36 @@ msgctxt "stock"
 msgid "_Yes"
 msgstr "_Da"
 
+#: cui/inc/personas.hrc:22
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "White"
+msgstr "Bela"
+
+#: cui/inc/personas.hrc:23
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Gray"
+msgstr "Siva"
+
+#: cui/inc/personas.hrc:24
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Dark"
+msgstr "Temna"
+
+#: cui/inc/personas.hrc:25
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Pink"
+msgstr "Rožnata"
+
+#: cui/inc/personas.hrc:26
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Sand"
+msgstr "Peščena"
+
+#: cui/inc/personas.hrc:27
+msgctxt 

core.git: vcl/unx

[Michael Weghorn (via logerrit)]

 vcl/unx/gtk4/a11y.cxx |   20 +++-
 1 file changed, 15 insertions(+), 5 deletions(-)

New commits:
commit 1a81fd69e10ad1ce7193fe7231ff29b2b94f67c7
Author: Michael Weghorn 
AuthorDate: Wed Dec 20 08:14:24 2023 +0100
Commit: Michael Weghorn 
CommitDate: Wed Dec 20 22:29:50 2023 +0100

gtk4 a11y: Take SELECTABLE/EXPANDABLE states into account

The Gtk API has no direct equivalent for the selectable
and expandable states, but sets them on the AT-SPI layer
whenever a value for the selected/expanded states is
explicitly set.
Therefore, only explicitly set values for these
if the selectable/expandable state is present,
to avoid the expandable/selectable state being
set on AT-SPI layer when it shouldn't.

Change-Id: Ib0cf2095d4834869856bf786e662115f6a328e13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161046
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/unx/gtk4/a11y.cxx b/vcl/unx/gtk4/a11y.cxx
index 48c22beb21ee..6bc89f15c401 100644
--- a/vcl/unx/gtk4/a11y.cxx
+++ b/vcl/unx/gtk4/a11y.cxx
@@ -296,11 +296,7 @@ static void applyStates(GtkAccessible* pGtkAccessible,
 pGtkAccessible, GTK_ACCESSIBLE_STATE_BUSY,
 bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::BUSY),
 GTK_ACCESSIBLE_STATE_DISABLED,
-bool(!(nStates & 
com::sun::star::accessibility::AccessibleStateType::ENABLED)),
-GTK_ACCESSIBLE_STATE_EXPANDED,
-bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::EXPANDED),
-GTK_ACCESSIBLE_STATE_SELECTED,
-bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::SELECTED), -1);
+bool(!(nStates & 
com::sun::star::accessibility::AccessibleStateType::ENABLED)), -1);
 
 // when explicitly setting any value for GTK_ACCESSIBLE_STATE_CHECKED,
 // Gtk will also report ATSPI_STATE_CHECKABLE on the AT-SPI layer
@@ -314,6 +310,20 @@ static void applyStates(GtkAccessible* pGtkAccessible,
 gtk_accessible_update_state(pGtkAccessible, 
GTK_ACCESSIBLE_STATE_CHECKED, eState, -1);
 }
 
+if (nStates & 
com::sun::star::accessibility::AccessibleStateType::EXPANDABLE)
+{
+gtk_accessible_update_state(
+pGtkAccessible, GTK_ACCESSIBLE_STATE_EXPANDED,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::EXPANDED), -1);
+}
+
+if (nStates & 
com::sun::star::accessibility::AccessibleStateType::SELECTABLE)
+{
+gtk_accessible_update_state(
+pGtkAccessible, GTK_ACCESSIBLE_STATE_SELECTED,
+bool(nStates & 
com::sun::star::accessibility::AccessibleStateType::SELECTED), -1);
+}
+
 const sal_Int16 nRole = xContext->getAccessibleRole();
 if (nRole == com::sun::star::accessibility::AccessibleRole::TOGGLE_BUTTON)
 {

translations.git: source/sl

[Martin Srebotnjak (via logerrit)]

 source/sl/cui/messages.po |  264 
 source/sl/dbaccess/messages.po|4 
 source/sl/filter/messages.po  |   10 
 source/sl/filter/source/config/fragments/filters.po   |4 
 source/sl/filter/source/config/fragments/types.po |4 
 source/sl/fpicker/messages.po |   10 
 source/sl/helpcontent2/source/text/sbasic/guide.po|4 
 source/sl/helpcontent2/source/text/sbasic/python.po   |   12 
 source/sl/helpcontent2/source/text/sbasic/shared.po   |   24 
 source/sl/helpcontent2/source/text/sbasic/shared/03.po|25318 +-
 source/sl/helpcontent2/source/text/scalc.po   |   48 
 source/sl/helpcontent2/source/text/scalc/00.po|  432 
 source/sl/helpcontent2/source/text/scalc/01.po|  244 
 source/sl/helpcontent2/source/text/scalc/02.po|   20 
 source/sl/helpcontent2/source/text/scalc/guide.po |   12 
 source/sl/helpcontent2/source/text/schart/01.po   |   12 
 source/sl/helpcontent2/source/text/sdatabase.po   |4 
 source/sl/helpcontent2/source/text/shared.po  |8 
 source/sl/helpcontent2/source/text/shared/00.po   |   76 
 source/sl/helpcontent2/source/text/shared/01.po   |   76 
 source/sl/helpcontent2/source/text/shared/02.po   |8 
 source/sl/helpcontent2/source/text/shared/guide.po|   62 
 source/sl/helpcontent2/source/text/shared/menu.po |   84 
 source/sl/helpcontent2/source/text/shared/optionen.po |   90 
 source/sl/helpcontent2/source/text/simpress.po|4 
 source/sl/helpcontent2/source/text/simpress/00.po |4 
 source/sl/helpcontent2/source/text/simpress/01.po |  130 
 source/sl/helpcontent2/source/text/simpress/02.po |4 
 source/sl/helpcontent2/source/text/simpress/guide.po  |   14 
 source/sl/helpcontent2/source/text/swriter.po |   60 
 source/sl/helpcontent2/source/text/swriter/00.po  |   14 
 source/sl/helpcontent2/source/text/swriter/01.po  |   38 
 source/sl/helpcontent2/source/text/swriter/02.po  |4 
 source/sl/helpcontent2/source/text/swriter/guide.po   |   18 
 source/sl/helpcontent2/source/text/swriter/librelogo.po   |8 
 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po |   23 
 source/sl/readlicense_oo/docs.po  |   12 
 source/sl/sc/messages.po  |  201 
 source/sl/sd/messages.po  |  302 
 source/sl/setup_native/source/mac.po  |   12 
 source/sl/sfx2/messages.po|  557 
 source/sl/starmath/messages.po|   56 
 source/sl/svtools/messages.po |   10 
 source/sl/svx/messages.po |  192 
 source/sl/sw/messages.po  |  412 
 source/sl/uui/messages.po |   21 
 source/sl/vcl/messages.po |   31 
 source/sl/xmlsecurity/messages.po |6 
 48 files changed, 16157 insertions(+), 12806 deletions(-)

New commits:
commit 452b2a23361827712588035978e0acc8cc03479a
Author: Martin Srebotnjak 
AuthorDate: Wed Dec 20 22:29:43 2023 +0100
Commit: Andras Timar 
CommitDate: Wed Dec 20 22:29:43 2023 +0100

Updated Slovenian translation

Change-Id: I4abd1636021dabc93c91f1c51d3f8b0aadbb320b

diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po
index 1e215a9e8aa..da32ac995f9 100644
--- a/source/sl/cui/messages.po
+++ b/source/sl/cui/messages.po
@@ -3,8 +3,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: LibreOffice 24.02
"
 "Report-Msgid-Bugs-To: 
https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI
"
-"POT-Creation-Date: 2023-11-12 23:29+0100
"
-"PO-Revision-Date: 2023-11-21 11:21+0200
"
+"POT-Creation-Date: 2023-12-10 12:10+0100
"
+"PO-Revision-Date: 2023-12-19 10:08+0200
"
 "Last-Translator: Martin Srebotnjak 
"
 "Language-Team: sl.libreoffice.org
"
 "Language: sl
"
@@ -124,6 +124,36 @@ msgctxt "stock"
 msgid "_Yes"
 msgstr "_Da"
 
+#: cui/inc/personas.hrc:22
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "White"
+msgstr "Bela"
+
+#: cui/inc/personas.hrc:23
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Gray"
+msgstr "Siva"
+
+#: cui/inc/personas.hrc:24
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Dark"
+msgstr "Temna"
+
+#: cui/inc/personas.hrc:25
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Pink"
+msgstr "Rožnata"
+
+#: cui/inc/personas.hrc:26
+msgctxt "RID_CUI_PERSONAS_COLOR"
+msgid "Sand"
+msgstr "Peščena"
+
+#: cui/inc/personas.hrc:27
+msgctxt 

[Bug 105844] FILESAVE: Very slow saving with password compared to 5.2.5

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=105844

--- Comment #44 from Commit Notification 
 ---
Michael Stahl committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/4995e0669da0e499743b21c60da1ca8b14a1c78c

tdf#105844 offapi,package,sfx2: use Argon2 for wholesome ODF encryption

It will be available in 24.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - bin/lo-all-static-libs external/argon2 offapi/com offapi/UnoApi_offapi.mk package/inc package/Library_package2.mk package/source sfx2/source

[Michael Stahl (via logerrit)]

 bin/lo-all-static-libs 
 |1 
 
external/argon2/0001-Fix-possible-compiler-error-due-to-undefined-_MSC_VE.patch 
|   32 +++
 external/argon2/UnpackedTarball_argon2.mk  
 |6 
 offapi/UnoApi_offapi.mk
 |1 
 offapi/com/sun/star/embed/XEncryptionProtectedStorage.idl  
 |8 
 offapi/com/sun/star/xml/crypto/KDFID.idl   
 |   47 +
 package/Library_package2.mk
 |1 
 package/inc/EncryptedDataHeader.hxx
 |9 
 package/inc/EncryptionData.hxx 
 |   10 -
 package/inc/PackageConstants.hxx   
 |5 
 package/inc/ZipPackage.hxx 
 |1 
 package/inc/ZipPackageEntry.hxx
 |5 
 package/inc/ZipPackageFolder.hxx   
 |6 
 package/inc/ZipPackageStream.hxx   
 |   14 +
 package/source/manifest/ManifestDefines.hxx
 |5 
 package/source/manifest/ManifestExport.cxx 
 |   43 +++-
 package/source/manifest/ManifestImport.cxx 
 |   47 -
 package/source/zipapi/XUnbufferedStream.cxx
 |2 
 package/source/zipapi/ZipFile.cxx  
 |   94 +-
 package/source/zippackage/ZipPackage.cxx   
 |   77 +++-
 package/source/zippackage/ZipPackageFolder.cxx 
 |   20 +-
 package/source/zippackage/ZipPackageStream.cxx 
 |   56 -
 sfx2/source/doc/objstor.cxx
 |8 
 23 files changed, 428 insertions(+), 70 deletions(-)

New commits:
commit 4995e0669da0e499743b21c60da1ca8b14a1c78c
Author: Michael Stahl 
AuthorDate: Tue Dec 19 19:13:00 2023 +0100
Commit: Michael Stahl 
CommitDate: Wed Dec 20 22:23:20 2023 +0100

tdf#105844 offapi,package,sfx2: use Argon2 for wholesome ODF encryption

https://www.rfc-editor.org/rfc/rfc9106.html

* add css::xml::crypto::KDFID constant group
* add "KeyDerivationFunction" to setEncryptionAlgorithms sequence
* Argon2 is used by default for wholesome ODF encryption, but
  $LO_ARGON2_DISABLE can be set to use PBKDF2
* extend various structs in package
* use 3 new ODF attributes "loext:argon2-iterations" "loext:argon2-memory"
  "loext:argon2-lanes" to store the arguments
* use this URL for now:
  "urn:org:documentfoundation:names:experimental:office:manifest:argon2id"
* use default arguments according to second recommendation from "7.4.
  Recommendations" of RFC9106; 64 MiB RAM should hopefully not be too
  much even for 32 bit builds

Change-Id: I683118cc5e0706bd6544db6fb909096768ac9920
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161009
Tested-by: Jenkins
Reviewed-by: Michael Stahl 
(cherry picked from commit 2f512aaa6c39390a5a0eb1d1e37f070127d068a4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161024

diff --git a/bin/lo-all-static-libs b/bin/lo-all-static-libs
index 009ddce23730..dd85567f188d 100755
--- a/bin/lo-all-static-libs
+++ b/bin/lo-all-static-libs
@@ -110,6 +110,7 @@ echo $INSTDIR/$LIBO_LIB_FOLDER/lib*.a \
  $foolibs \
  $WORKDIR/LinkTarget/StaticLibrary/lib*.a \
  $oslibs \
+ $WORKDIR/UnpackedTarball/argon2/libargon2.a \
  $WORKDIR/UnpackedTarball/icu/source/lib/*.a \
  $WORKDIR/UnpackedTarball/liblangtag/liblangtag/.libs/*.a \
  $WORKDIR/UnpackedTarball/lcms2/src/.libs/*.a \
diff --git 
a/external/argon2/0001-Fix-possible-compiler-error-due-to-undefined-_MSC_VE.patch
 
b/external/argon2/0001-Fix-possible-compiler-error-due-to-undefined-_MSC_VE.patch
new file mode 100644
index ..538b41e3ec9f
--- /dev/null
+++ 
b/external/argon2/0001-Fix-possible-compiler-error-due-to-undefined-_MSC_VE.patch
@@ -0,0 +1,32 @@
+From 48829f87ebafbb9938d23a8f0bff4d11d770690e Mon Sep 17 00:00:00 2001
+From: Patrick Steinhardt 
+Date: Thu, 20 Feb 2020 17:37:32 +0100
+Subject: [PATCH] Fix possible compiler error due to undefined _MSC_VER
+
+In order to determine how to set up the ARGON2_PUBLIC and ARGON2_LOCAL
+macros, we check for various different environments via preprocessor
+defines. For Microsoft Visual Studio, we check that the macro _MSC_VER
+evaluates to non-zero via `#elif _MSC_VER`. This may raise a compile
+error when compiling with "-Werror=undef" if the variable isn't defined.
+
+Fix the issue by using `#elif 

core.git: Branch 'libreoffice-7-6' - sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/slideshow/showwin.cxx |   12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

New commits:
commit 0a438f285f3b5310f5d7b63f0a3c6a857be360f2
Author: Caolán McNamara 
AuthorDate: Wed Dec 20 16:37:52 2023 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Dec 20 22:14:45 2023 +0100

Resolves: tdf#158332 'fake' keystroke exits presentation

the fake keystroke is to make tooltips go away before menus which
used to be a problem versions of gtk3 < 3.24 that resultsed in no
menus appearing. Our min is still 3.18 so technically we need to retain
that until bumping past that as baseline.

Change-Id: I94aa309665c50c8ca310285d1e691030f443934a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161022
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sd/source/ui/slideshow/showwin.cxx 
b/sd/source/ui/slideshow/showwin.cxx
index 8e1f8a6d49cd..dfa04f47a07e 100644
--- a/sd/source/ui/slideshow/showwin.cxx
+++ b/sd/source/ui/slideshow/showwin.cxx
@@ -97,6 +97,12 @@ void ShowWindow::dispose()
 
 void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 {
+// Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
+// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 3.24)
+bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
+if (bFakeKeyPress)
+return;
+
 bool bReturn = false;
 
 if( SHOWWINDOWMODE_PREVIEW == meShowWindowMode )
@@ -126,11 +132,7 @@ void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 }
 else if( SHOWWINDOWMODE_BLANK == meShowWindowMode )
 {
-bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
-// Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
-// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 2.34)
-if (!bFakeKeyPress)
-RestartShow();
+RestartShow();
 bReturn = true;
 }
 else if( SHOWWINDOWMODE_PAUSE == meShowWindowMode )

core.git: Branch 'libreoffice-24-2' - sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/slideshow/showwin.cxx |   12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

New commits:
commit 39f21446c0f0e9872f8871ab88233f5cbaa5eacc
Author: Caolán McNamara 
AuthorDate: Wed Dec 20 16:37:52 2023 +
Commit: Adolfo Jayme Barrientos 
CommitDate: Wed Dec 20 22:14:29 2023 +0100

Resolves: tdf#158332 'fake' keystroke exits presentation

the fake keystroke is to make tooltips go away before menus which
used to be a problem versions of gtk3 < 3.24 that resultsed in no
menus appearing. Our min is still 3.18 so technically we need to retain
that until bumping past that as baseline.

Change-Id: I94aa309665c50c8ca310285d1e691030f443934a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161081
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sd/source/ui/slideshow/showwin.cxx 
b/sd/source/ui/slideshow/showwin.cxx
index 4bc0d414307c..d6ecc19a69d0 100644
--- a/sd/source/ui/slideshow/showwin.cxx
+++ b/sd/source/ui/slideshow/showwin.cxx
@@ -98,6 +98,12 @@ void ShowWindow::dispose()
 
 void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 {
+// Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
+// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 3.24)
+bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
+if (bFakeKeyPress)
+return;
+
 bool bReturn = false;
 
 if( SHOWWINDOWMODE_PREVIEW == meShowWindowMode )
@@ -127,11 +133,7 @@ void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 }
 else if( SHOWWINDOWMODE_BLANK == meShowWindowMode )
 {
-bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
-// Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
-// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 2.34)
-if (!bFakeKeyPress)
-RestartShow();
+RestartShow();
 bReturn = true;
 }
 else if( SHOWWINDOWMODE_PAUSE == meShowWindowMode )

[Bug 158762] Paragraph imported without numbering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158762

--- Comment #2 from Commit Notification 
 ---
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fad76223d1cff3746a5d2e4ce56b93ecd1c80f61

tdf#158762 RTF writerfilter: fix list import

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158762] Paragraph imported without numbering

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158762

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/qa writerfilter/source

[Oliver Specht (via logerrit)]

 sw/qa/extras/rtfexport/data/tdf158762.rtf|  335 +++
 sw/qa/extras/rtfexport/rtfexport7.cxx|   11 
 writerfilter/source/dmapper/DomainMapper.cxx |1 
 3 files changed, 347 insertions(+)

New commits:
commit fad76223d1cff3746a5d2e4ce56b93ecd1c80f61
Author: Oliver Specht 
AuthorDate: Tue Dec 19 07:38:02 2023 +0100
Commit: Thorsten Behrens 
CommitDate: Wed Dec 20 22:08:17 2023 +0100

tdf#158762 RTF writerfilter: fix list import

While importing the properties NumberingRules and NumberingStyleName
interfere with each other. Avoid overwriting NumberingRules with an
invalid NumberingStyleName.

Regression from 588ff9a228f4894142264c68392ed1e9800a4d7d

Change-Id: I706ea514da43faae0fdb9a2c0d4f5b1928ef55f8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160967
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens 

diff --git a/sw/qa/extras/rtfexport/data/tdf158762.rtf 
b/sw/qa/extras/rtfexport/data/tdf158762.rtf
new file mode 100755
index ..2953c2acf29a
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/tdf158762.rtf
@@ -0,0 +1,335 @@
+{
tf1deflang1025nsinsicpg1252\uc1deff0\deff0\stshfdbch0\stshfloch0\stshfhich0\stshfbi0\deflang3079\deflangfe3079
  hemelang3079hemelangfe0 hemelangcs0{onttbl{0bidi roman
charset0prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New 
Roman};}
+{34bidi romancharset0prq2{\*\panose 02040503050406030204}Cambria Math;}{
40bidi swisscharset0prq2{\*\panose }Tahoma{\*alt Times 
New Roman};}
+{lomajor31500bidi romancharset0prq2{\*\panose 02020603050405020304}Times 
New Roman{\*alt Times New Roman};}{dbmajor31501bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{himajor31502bidi romancharset0prq2{\*\panose 
02040503050406030204}Cambria;}{bimajor31503bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{lominor31504bidi romancharset0prq2{\*\panose 02020603050405020304}Times 
New Roman{\*alt Times New Roman};}{dbminor31505bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{himinor31506bidi swisscharset0prq2{\*\panose 
020f0502020204030204}Calibri;}{biminor31507bidi romancharset0
prq2{\*\panose 02020603050405020304}Times New Roman{\*alt Times New Roman};}
+{43bidi romancharset238prq2 Times New Roman CE{\*alt Times New Roman};}{
44bidi romancharset204prq2 Times New Roman Cyr{\*alt Times New Roman};}{
46bidi romancharset161prq2 Times New Roman Greek{\*alt Times New Roman};}
+{47bidi romancharset162prq2 Times New Roman Tur{\*alt Times New 
Roman};}{48bidi romancharset177prq2 Times New Roman (Hebrew){\*alt Times 
New Roman};}
+{49bidi romancharset178prq2 Times New Roman (Arabic){\*alt Times New 
Roman};}{50bidi romancharset186prq2 Times New Roman Baltic{\*alt Times 
New Roman};}
+{51bidi romancharset163prq2 Times New Roman (Vietnamese){\*alt Times New 
Roman};}{383bidi romancharset238prq2 Cambria Math CE;}{384bidi roman
charset204prq2 Cambria Math Cyr;}
+{386bidi romancharset161prq2 Cambria Math Greek;}{387bidi roman
charset162prq2 Cambria Math Tur;}{390bidi romancharset186prq2 Cambria 
Math Baltic;}{391bidi romancharset163prq2 Cambria Math (Vietnamese);}
+{443bidi swisscharset238prq2 Tahoma CE{\*alt Times New Roman};}{444
bidi swisscharset204prq2 Tahoma Cyr{\*alt Times New Roman};}{446bidi 
swisscharset161prq2 Tahoma Greek{\*alt Times New Roman};}
+{447bidi swisscharset162prq2 Tahoma Tur{\*alt Times New Roman};}{448
bidi swisscharset177prq2 Tahoma (Hebrew){\*alt Times New Roman};}{449bidi 
swisscharset178prq2 Tahoma (Arabic){\*alt Times New Roman};}
+{450bidi swisscharset186prq2 Tahoma Baltic{\*alt Times New Roman};}{451
bidi swisscharset163prq2 Tahoma (Vietnamese){\*alt Times New Roman};}{452
bidi swisscharset222prq2 Tahoma (Thai){\*alt Times New Roman};}
+{lomajor31508bidi romancharset238prq2 Times New Roman CE{\*alt Times 
New Roman};}{lomajor31509bidi romancharset204prq2 Times New Roman Cyr{\*
alt Times New Roman};}
+{lomajor31511bidi romancharset161prq2 Times New Roman Greek{\*alt Times 
New Roman};}{lomajor31512bidi romancharset162prq2 Times New Roman Tur{\*
alt Times New Roman};}
+{lomajor31513bidi romancharset177prq2 Times New Roman (Hebrew){\*alt 
Times New Roman};}{lomajor31514bidi romancharset178prq2 Times New Roman 
(Arabic){\*alt Times New Roman};}
+{lomajor31515bidi romancharset186prq2 Times New Roman Baltic{\*alt 
Times New Roman};}{lomajor31516bidi romancharset163prq2 Times New Roman 
(Vietnamese){\*alt Times New Roman};}
+{dbmajor31518bidi romancharset238prq2 Times New Roman CE{\*alt Times 
New Roman};}{dbmajor31519bidi roman

Minutes from the UX/design meeting 2023-Dec-20

[Heiko Tietze]

Present: Sahil, Rafael, John, Heiko
Comments: Dieter, Stuart

Tickets/Topics

 * Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158588
   + improve help (Dieter, bug 130185)
   + dummy text with no embedded font = 28k, with all options on = 22000k
 with "only used" 927k, with all but limited to latin = 1800k
   + disable CTL & CJK depending on options and
   + check by default and disable the "Only used fonts" unless
 the first option "Embed fonts" is activated (Heiko)
   + if the document contains and CTL/CJK font it would be
 pointless to exclude them when saving used fonts only;
 and the other option makes not much sense alone (Rafael)
   + font scripts options needs a dev check
   => do it

 * FORMCONTROLS Enhancement: Fill Cell with Text Box in Calc
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158273
   + check/enable anchor to cell (resize with cell) and fit to cell size
 by default (Heiko)
   + changing this makes users needy and they may ask for better chart
 positioning, for example; how about a dedicated command to
 achieve the goal (Rafael)
   + could also be done per macro (Sahil)
   + goal was here to insert/manipulate many form controls; the workflow
 with copy/paste is tedious as cursor down or enter does not
 behave like at normal cells; which could be changed (Heiko)
  => comment

 * Incorrectly export number 0 form calc to PDF
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158533
   + option to show/include zero is on by default and one has to disable
 it intentionally
   + same behavior on Excel
   + dependency to some archived PDF format is unclear
   => ask the ESC

 * New sidebar deck for comments
   + https://bugs.documentfoundation.org/show_bug.cgi?id=106316
   + splitter to expand the comments margin (Jim)
   + comments in margin is sufficient for ordinary users (John)
   + vertical space in margin is not enough for academia; management
 is missing, eg. to find unresolved comments (Rafael)
   + sidebar has limited vertical space
 + but allows the list being unsynchronized ie. many comments on one
 single page overlapping each other
   + requirements: add filter by status, eg. resolved
 no urgent need for the procrastination option "hide temporarily"
   + mockup design: take the Onlyoffice example 
https://bug-attachments.documentfoundation.org/attachment.cgi?id=191371; sort is

 missing; referenced text should be visible in the sidebar pane
   + enhancements: predefined responses? might be useful for some (Rafael),
 but should be done resp. the list filled by users (Sahil)
   + replace the comments in margin or amends it (John)
   => improve the mockup and ask the community in a blog post


OpenPGP_signature.asc
Description: OpenPGP digital signature

Minutes from the UX/design meeting 2023-Dec-20

[Heiko Tietze]

Present: Sahil, Rafael, John, Heiko
Comments: Dieter, Stuart

Tickets/Topics

 * Redesign font embedding options in sfx2/uiconfig/ui/documentfontspage.ui
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158588
   + improve help (Dieter, bug 130185)
   + dummy text with no embedded font = 28k, with all options on = 22000k
 with "only used" 927k, with all but limited to latin = 1800k
   + disable CTL & CJK depending on options and
   + check by default and disable the "Only used fonts" unless
 the first option "Embed fonts" is activated (Heiko)
   + if the document contains and CTL/CJK font it would be
 pointless to exclude them when saving used fonts only;
 and the other option makes not much sense alone (Rafael)
   + font scripts options needs a dev check
   => do it

 * FORMCONTROLS Enhancement: Fill Cell with Text Box in Calc
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158273
   + check/enable anchor to cell (resize with cell) and fit to cell size
 by default (Heiko)
   + changing this makes users needy and they may ask for better chart
 positioning, for example; how about a dedicated command to
 achieve the goal (Rafael)
   + could also be done per macro (Sahil)
   + goal was here to insert/manipulate many form controls; the workflow
 with copy/paste is tedious as cursor down or enter does not
 behave like at normal cells; which could be changed (Heiko)
  => comment

 * Incorrectly export number 0 form calc to PDF
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158533
   + option to show/include zero is on by default and one has to disable
 it intentionally
   + same behavior on Excel
   + dependency to some archived PDF format is unclear
   => ask the ESC

 * New sidebar deck for comments
   + https://bugs.documentfoundation.org/show_bug.cgi?id=106316
   + splitter to expand the comments margin (Jim)
   + comments in margin is sufficient for ordinary users (John)
   + vertical space in margin is not enough for academia; management
 is missing, eg. to find unresolved comments (Rafael)
   + sidebar has limited vertical space
 + but allows the list being unsynchronized ie. many comments on one
 single page overlapping each other
   + requirements: add filter by status, eg. resolved
 no urgent need for the procrastination option "hide temporarily"
   + mockup design: take the Onlyoffice example 
https://bug-attachments.documentfoundation.org/attachment.cgi?id=191371; sort is

 missing; referenced text should be visible in the sidebar pane
   + enhancements: predefined responses? might be useful for some (Rafael),
 but should be done resp. the list filled by users (Sahil)
   + replace the comments in margin or amends it (John)
   => improve the mockup and ask the community in a blog post


OpenPGP_signature.asc
Description: OpenPGP digital signature

[Bug 158796] CRASH: pasting and undoing a WPC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158796

Xisco Faulí  changed:

   What|Removed |Added

   Keywords||bibisected, bisected,
   ||regression
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de,
   ||xiscofa...@libreoffice.org
  Regression By||Regina Henschel

--- Comment #1 from Xisco Faulí  ---
Regression introduced by:

author  Regina Henschel2023-09-06 23:03:39
+0200
committer   Miklos Vajna 2023-11-15 11:13:31
+0100
commit  0430adb42bc38f037b907984e71c144d863796cb (patch)
treecb2104e03b5f35f8eebfa0eecc142918e3522861
parent  c0df28f957b43f0ecbffdc994ee0702dbe5bc33f (diff)
Import Wordprocessing Canvas, wpc:wpc element

Bisected with: bibisect-linux64-24.2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158796] New: CRASH: pasting and undoing a WPC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158796

Bug ID: 158796
   Summary: CRASH: pasting and undoing a WPC
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: xiscofa...@libreoffice.org

Steps to reproduce:
1. Open attachment 57348 from bug 46361
2. Select all
3. Copy
4. Paste twice
5. Undo twice

-> Crash

Reproduced in

Version: 24.2.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 0034d2ab9382da86340738137218791a4ccc9c90
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: fr-FR (es_ES.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/CppunitTest_sw_ooxmlexport20.mk

[Xisco Fauli (via logerrit)]

 sw/CppunitTest_sw_ooxmlexport20.mk |5 -
 1 file changed, 5 deletions(-)

New commits:
commit cb5642b1b542e79d98e3f6786beb7de427f44bb5
Author: Xisco Fauli 
AuthorDate: Wed Dec 20 13:01:33 2023 +0100
Commit: Xisco Fauli 
CommitDate: Wed Dec 20 21:35:02 2023 +0100

CppunitTest_sw_ooxmlexport20: remove copy leftover

from

author  Xisco Fauli 2023-10-30 16:22:07 
+0100
committer   Xisco Fauli 2023-10-31 
08:43:11 +0100
commit  117133575961dbce292a24f8afa1414785f2282c (patch)
tree29e6a859c0f48659fc5cc0dfd89da72037cb3db3 
/sw/CppunitTest_sw_ooxmlexport20.mk
parent  a04fc307ba2706bb9e5b8441aaf4380797b5f397 (diff)
CppunitTest_sw_ooxmlexport5: split into two

Change-Id: I5ef959adb119af22b6c17ef7d64465166a13360b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161069
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/sw/CppunitTest_sw_ooxmlexport20.mk 
b/sw/CppunitTest_sw_ooxmlexport20.mk
index b2b778a4a12e..a308873a24dc 100644
--- a/sw/CppunitTest_sw_ooxmlexport20.mk
+++ b/sw/CppunitTest_sw_ooxmlexport20.mk
@@ -11,9 +11,4 @@
 
 $(eval $(call sw_ooxmlexport_test,20))
 
-$(eval $(call gb_CppunitTest_use_uiconfigs,sw_ooxmlexport5, \
-svt \
-svx \
-))
-
 # vim: set noet sw=4 ts=4:

[Bug 56126] EDITING: Conditional field and vertical separator

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=56126

Andreas Heinisch  changed:

   What|Removed |Added

 CC||andreas.heini...@yahoo.de

--- Comment #14 from Andreas Heinisch  ---
This is due to the fact that the conditions are internally separated using the
vertical separator. I will have a look if we can chose a high ascii character
as a separator. I hope it will not break any legacy files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 2 commits - sd/source vcl/unx

[Caolán McNamara (via logerrit)]

 sd/source/ui/slideshow/showwin.cxx |   12 +++-
 vcl/unx/gtk3/gtkinst.cxx   |4 ++--
 2 files changed, 9 insertions(+), 7 deletions(-)

New commits:
commit 8f07984471add9cb2e7b4fddcfaa505cc7d508fe
Author: Caolán McNamara 
AuthorDate: Wed Dec 20 16:37:52 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Dec 20 21:21:22 2023 +0100

Resolves: tdf#158332 'fake' keystroke exits presentation

the fake keystroke is to make tooltips go away before menus which
used to be a problem versions of gtk3 < 3.24 that resultsed in no
menus appearing. Our min is still 3.18 so technically we need to retain
that until bumping past that as baseline.

Change-Id: I94aa309665c50c8ca310285d1e691030f443934a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161080
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/ui/slideshow/showwin.cxx 
b/sd/source/ui/slideshow/showwin.cxx
index 5e4018b2ba10..d6ecc19a69d0 100644
--- a/sd/source/ui/slideshow/showwin.cxx
+++ b/sd/source/ui/slideshow/showwin.cxx
@@ -98,6 +98,12 @@ void ShowWindow::dispose()
 
 void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 {
+// Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
+// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 3.24)
+bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
+if (bFakeKeyPress)
+return;
+
 bool bReturn = false;
 
 if( SHOWWINDOWMODE_PREVIEW == meShowWindowMode )
@@ -127,11 +133,7 @@ void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 }
 else if( SHOWWINDOWMODE_BLANK == meShowWindowMode )
 {
-bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
-// Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
-// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 3.24)
-if (!bFakeKeyPress)
-RestartShow();
+RestartShow();
 bReturn = true;
 }
 else if( SHOWWINDOWMODE_PAUSE == meShowWindowMode )
commit 6b05dc79e531633d84a1b6ed60f3d281d02c713e
Author: Caolán McNamara 
AuthorDate: Wed Dec 20 16:34:11 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Dec 20 21:21:13 2023 +0100

comment re GTK 2.34 should be 3.24

Change-Id: I9acc070e6983f7f5e72120029fa968f0f15306e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161079
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/sd/source/ui/slideshow/showwin.cxx 
b/sd/source/ui/slideshow/showwin.cxx
index 4bc0d414307c..5e4018b2ba10 100644
--- a/sd/source/ui/slideshow/showwin.cxx
+++ b/sd/source/ui/slideshow/showwin.cxx
@@ -129,7 +129,7 @@ void ShowWindow::KeyInput(const KeyEvent& rKEvt)
 {
 bool bFakeKeyPress = rKEvt.GetKeyCode().GetFullCode() == 0;
 // Ignore workaround of https://gitlab.gnome.org/GNOME/gtk/issues/1785
-// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 2.34)
+// See calls to GtkSalFrame::makeFakeKeyPress (Fixed in GTK 3.24)
 if (!bFakeKeyPress)
 RestartShow();
 bReturn = true;
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 3def046ce22a..2bd6b384ce9c 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -11093,7 +11093,7 @@ private:
 // Send a keyboard event through gtk_main_do_event to toggle any 
active tooltip offs
 // before trying to launch the menu
 // https://gitlab.gnome.org/GNOME/gtk/issues/1785
-// Fixed in GTK 2.34
+// Fixed in GTK 3.24
 GdkEvent *pKeyEvent = GtkSalFrame::makeFakeKeyPress(pWidget);
 gtk_main_do_event(pKeyEvent);
 
@@ -11455,7 +11455,7 @@ public:
 // Send a keyboard event through gtk_main_do_event to toggle any 
active tooltip offs
 // before trying to launch the menu
 // https://gitlab.gnome.org/GNOME/gtk/issues/1785
-// Fixed in GTK 2.34
+// Fixed in GTK 3.24
 GdkEvent *pKeyEvent = GtkSalFrame::makeFakeKeyPress(pWidget);
 gtk_main_do_event(pKeyEvent);
 

core.git: sw/source

[Noel Grandin (via logerrit)]

 sw/source/uibase/utlui/content.cxx |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit b5ab2d274ab3731eca3e7f9d8cce9de53eb927c4
Author: Noel Grandin 
AuthorDate: Wed Dec 20 12:23:09 2023 +0200
Commit: Noel Grandin 
CommitDate: Wed Dec 20 21:07:27 2023 +0100

no need to use unique_ptr here

Change-Id: I1e7ef79eefa18c39f647749d6f7c94e2bff20462
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161057
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 72fd76cbe1ce..4ee3c315e4df 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -5738,10 +5738,10 @@ void SwContentTree::GotoContent(const SwContent* pCnt)
 
 m_pActiveShell->AssureStdMode();
 
-std::optional> oPosition;
+std::optional oPosition;
 if (m_bSelectTo)
-oPosition.emplace(new 
SwPosition(m_pActiveShell->GetCursor()->GetPoint()->nNode,
- 
m_pActiveShell->GetCursor()->GetPoint()->nContent));
+oPosition.emplace(m_pActiveShell->GetCursor()->GetPoint()->nNode,
+  m_pActiveShell->GetCursor()->GetPoint()->nContent);
 
 switch(m_nLastSelType = pCnt->GetParent()->GetType())
 {
@@ -5881,8 +5881,8 @@ void SwContentTree::GotoContent(const SwContent* pCnt)
 m_pActiveShell->AssureStdMode();
 
 m_pActiveShell->SetMark();
-m_pActiveShell->GetCursor()->GetMark()->nNode = 
oPosition.value()->nNode;
-m_pActiveShell->GetCursor()->GetMark()->nContent = 
oPosition.value()->nContent;
+m_pActiveShell->GetCursor()->GetMark()->nNode = oPosition->nNode;
+m_pActiveShell->GetCursor()->GetMark()->nContent = oPosition->nContent;
 m_pActiveShell->UpdateCursor();
 
 m_pActiveShell->GetView().GetEditWin().GrabFocus();

core.git: 2 commits - extensions/source forms/source package/inc package/source sw/source

[Caolán McNamara (via logerrit)]

 extensions/source/update/feed/updatefeed.cxx   |8 +++-
 forms/source/helper/controlfeatureinterception.cxx |3 +--
 package/inc/ThreadedDeflater.hxx   |9 +
 package/source/zipapi/ThreadedDeflater.cxx |8 
 sw/source/core/edit/edtab.cxx  |4 
 5 files changed, 17 insertions(+), 15 deletions(-)

New commits:
commit 6ef28599b227042e3b64075143207af2c674719d
Author: Caolán McNamara 
AuthorDate: Wed Dec 20 15:39:50 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Dec 20 20:59:04 2023 +0100

cid#1545612 COPY_INSTEAD_OF_MOVE

and

cid#1545605 COPY_INSTEAD_OF_MOVE
cid#1545587 COPY_INSTEAD_OF_MOVE

Change-Id: Iafb1d81dbacfefe70fbddd84b29e827dc137ef07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161077
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/extensions/source/update/feed/updatefeed.cxx 
b/extensions/source/update/feed/updatefeed.cxx
index b1bc6851edef..f9e6a5706c91 100644
--- a/extensions/source/update/feed/updatefeed.cxx
+++ b/extensions/source/update/feed/updatefeed.cxx
@@ -449,15 +449,13 @@ UpdateInformationProvider::load(const OUString& rURL)
 uno::Reference< ucb::XCommandProcessor > 
xCommandProcessor(m_xUniversalContentBroker->queryContent(xId), 
uno::UNO_QUERY_THROW);
 rtl::Reference< ActiveDataSink > aSink(new ActiveDataSink());
 
-// Disable KeepAlive in webdav - don't want millions of office
-// instances phone home & clog up servers
-uno::Sequence< beans::NamedValue > aProps { { "KeepAlive", uno::Any(false) 
} };
-
 ucb::OpenCommandArgument3 aOpenArgument;
 aOpenArgument.Mode = ucb::OpenMode::DOCUMENT;
 aOpenArgument.Priority = 32768;
 aOpenArgument.Sink = *aSink;
-aOpenArgument.OpeningFlags = aProps;
+// Disable KeepAlive in webdav - don't want millions of office
+// instances phone home & clog up servers
+aOpenArgument.OpeningFlags = { { "KeepAlive", uno::Any(false) } };
 
 ucb::Command aCommand;
 aCommand.Name = "open";
diff --git a/forms/source/helper/controlfeatureinterception.cxx 
b/forms/source/helper/controlfeatureinterception.cxx
index 091af550cc29..f95445a4f90a 100644
--- a/forms/source/helper/controlfeatureinterception.cxx
+++ b/forms/source/helper/controlfeatureinterception.cxx
@@ -71,8 +71,7 @@ namespace frm
 
 if ( m_xFirstDispatchInterceptor == _rxInterceptor )
 {   // our chain will have a new first element
-Reference< XDispatchProviderInterceptor >  xSlave( 
m_xFirstDispatchInterceptor->getSlaveDispatchProvider(), UNO_QUERY );
-m_xFirstDispatchInterceptor = xSlave;
+
m_xFirstDispatchInterceptor.set(m_xFirstDispatchInterceptor->getSlaveDispatchProvider(),
 UNO_QUERY);
 }
 // do this before removing the interceptor from the chain as we won't 
know it's slave afterwards)
 
diff --git a/package/inc/ThreadedDeflater.hxx b/package/inc/ThreadedDeflater.hxx
index 361129d0f927..9b5867021cd6 100644
--- a/package/inc/ThreadedDeflater.hxx
+++ b/package/inc/ThreadedDeflater.hxx
@@ -52,10 +52,11 @@ public:
 // Unlike with Deflater class, bNoWrap is always true.
 ThreadedDeflater(sal_Int32 nSetLevel);
 ~ThreadedDeflater() COVERITY_NOEXCEPT_FALSE;
-void deflateWrite(
-const css::uno::Reference& xInStream,
-std::function&, sal_Int32)> 
aProcessInputFunc,
-std::function&, sal_Int32)> 
aProcessOutputFunc);
+void deflateWrite(const css::uno::Reference& 
xInStream,
+  const std::function&, sal_Int32)>&
+  rProcessInputFunc,
+  const std::function&, sal_Int32)>&
+  rProcessOutputFunc);
 sal_Int64 getTotalIn() const { return totalIn; }
 sal_Int64 getTotalOut() const { return totalOut; }
 
diff --git a/package/source/zipapi/ThreadedDeflater.cxx 
b/package/source/zipapi/ThreadedDeflater.cxx
index f574105ad4ef..b76f3adfcd26 100644
--- a/package/source/zipapi/ThreadedDeflater.cxx
+++ b/package/source/zipapi/ThreadedDeflater.cxx
@@ -76,21 +76,21 @@ ThreadedDeflater::~ThreadedDeflater() 
COVERITY_NOEXCEPT_FALSE { clear(); }
 
 void ThreadedDeflater::deflateWrite(
 const css::uno::Reference& xInStream,
-std::function&, sal_Int32)> 
aProcessInputFunc,
-std::function&, sal_Int32)> 
aProcessOutputFunc)
+const std::function&, sal_Int32)>& 
rProcessInputFunc,
+const std::function&, sal_Int32)>& 
rProcessOutputFunc)
 {
 sal_Int64 nThreadCount = 
comphelper::ThreadPool::getSharedOptimalPool().getWorkerCount();
 sal_Int64 batchSize = MaxBlockSize * nThreadCount;
 inBuffer.realloc(batchSize);
 prevDataBlock.realloc(MaxBlockSize);
 outBuffers.resize(nThreadCount);
-maProcessOutputFunc = aProcessOutputFunc;
+maProcessOutputFunc = rProcessOutputFunc;
 bool firstTask = true;
 
 while (xInStream->available() > 0)
 {
 sal_Int64 

core.git: include/tools

[Mike Kaganski (via logerrit)]

 include/tools/bigint.hxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit a2a02508d5aa6332c71245bb13f4c40f61790a72
Author: Mike Kaganski 
AuthorDate: Wed Dec 20 13:48:11 2023 +0300
Commit: Mike Kaganski 
CommitDate: Wed Dec 20 20:30:10 2023 +0100

Fix BigInt::Abs

It would fail to negate SAL_MIN_INT32.

Change-Id: Ia5d34fc31917cabee2a1b130ef69c91b202592fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161063
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/tools/bigint.hxx b/include/tools/bigint.hxx
index 644bb4c3e29d..2b7d9870d3e3 100644
--- a/include/tools/bigint.hxx
+++ b/include/tools/bigint.hxx
@@ -187,7 +187,16 @@ inline BigInt BigInt::Abs() const
 if (IsBig())
 aRes.bIsNeg = false;
 else if ( nVal < 0 )
-aRes.nVal = -nVal;
+{
+if (nVal == std::numeric_limits::min())
+{
+aRes.nNum[0] = -sal_Int64(std::numeric_limits::min());
+aRes.nLen = 1;
+aRes.bIsNeg = false;
+}
+else
+aRes.nVal = -nVal;
+}
 return aRes;
 }
 

core.git: 2 commits - include/tools tools/qa tools/source vcl/source

[Mike Kaganski (via logerrit)]

 include/tools/bigint.hxx |   76 ++--
 tools/qa/cppunit/test_bigint.cxx |   12 -
 tools/source/generic/bigint.cxx  |  237 ---
 vcl/source/control/longcurr.cxx  |   13 --
 4 files changed, 172 insertions(+), 166 deletions(-)

New commits:
commit 36df3f9ad2f71c122af3cf9fbc58c661f416658e
Author: Mike Kaganski 
AuthorDate: Wed Dec 20 12:17:31 2023 +0300
Commit: Mike Kaganski 
CommitDate: Wed Dec 20 20:30:01 2023 +0100

Make BigInt::DivMod public, to allow optimized division

Change-Id: I4f79c30b9ab997d01e59a0dec76986e74abfc11f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161053
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/include/tools/bigint.hxx b/include/tools/bigint.hxx
index 1b089e173ef0..644bb4c3e29d 100644
--- a/include/tools/bigint.hxx
+++ b/include/tools/bigint.hxx
@@ -46,8 +46,7 @@ private:
 TOOLS_DLLPRIVATE void AddBig(BigInt& rB, BigInt& rRes);
 TOOLS_DLLPRIVATE void SubBig(BigInt& rB, BigInt& rRes);
 TOOLS_DLLPRIVATE void MultBig(BigInt const& rB, BigInt& rRes) const;
-TOOLS_DLLPRIVATE void DivModBig(BigInt const& rB, BigInt& rRes, bool bMod) 
const;
-TOOLS_DLLPRIVATE void DivMod(BigInt const& rVal, bool bMod);
+TOOLS_DLLPRIVATE void DivModBig(BigInt const& rB, BigInt* pDiv, BigInt* 
pMod) const;
 
 public:
 BigInt()
@@ -113,6 +112,8 @@ public:
 
 BigInt& operator  =( sal_Int32 nValue );
 
+void DivMod(BigInt const& rVal, BigInt* pDiv, BigInt* pMod) const;
+
 /* Scale and round value */
 static tools::Long Scale(tools::Long nVal, tools::Long nMult, tools::Long 
nDiv);
 
diff --git a/tools/source/generic/bigint.cxx b/tools/source/generic/bigint.cxx
index 3f4a82ffe33e..240494dfc15d 100644
--- a/tools/source/generic/bigint.cxx
+++ b/tools/source/generic/bigint.cxx
@@ -276,7 +276,7 @@ void BigInt::MultBig(const BigInt& rB, BigInt& rRes) const
 }
 }
 
-void BigInt::DivModBig(const BigInt& rB, BigInt& rRes, bool bMod) const
+void BigInt::DivModBig(const BigInt& rB, BigInt* pDiv, BigInt* pMod) const
 {
 assert(IsBig() && rB.IsBig());
 assert(nLen >= rB.nLen);
@@ -299,6 +299,9 @@ void BigInt::DivModBig(const BigInt& rB, BigInt& rRes, bool 
bMod) const
 assert(nDenMostSig >= 0x1 / 2);
 const sal_uInt64 nDen2ndSig = rB.nLen > 1 ? den[rB.nLen - 2] : 0;
 
+BigInt aTmp;
+BigInt& rRes = pDiv ? *pDiv : aTmp;
+
 for (size_t j = num.size() - 1; j >= den.size(); j--)
 { // guess divisor
 assert(num[j] < nDenMostSig || (num[j] == nDenMostSig && num[j - 1] == 
0));
@@ -344,17 +347,19 @@ void BigInt::DivModBig(const BigInt& rB, BigInt& rRes, 
bool bMod) const
 }
 }
 
-if (bMod)
+if (pMod)
 {
-rRes.nLen = DivInPlace(num, nMult, nMult);
-assert(rRes.nLen <= MAX_DIGITS);
-rRes.bIsNeg = bIsNeg;
-std::copy_n(num.begin(), rRes.nLen, rRes.nNum);
+pMod->nLen = DivInPlace(num, nMult, nMult);
+assert(pMod->nLen <= MAX_DIGITS);
+pMod->bIsNeg = bIsNeg;
+std::copy_n(num.begin(), pMod->nLen, pMod->nNum);
+pMod->Normalize();
 }
-else
+if (pDiv) // rRes references pDiv
 {
-rRes.bIsNeg = bIsNeg != rB.bIsNeg;
-rRes.nLen = nLen - rB.nLen + 1;
+pDiv->bIsNeg = bIsNeg != rB.bIsNeg;
+pDiv->nLen = nLen - rB.nLen + 1;
+pDiv->Normalize();
 }
 }
 
@@ -566,8 +571,9 @@ BigInt& BigInt::operator*=( const BigInt& rVal )
 return *this;
 }
 
-void BigInt::DivMod(const BigInt& rVal, bool bMod)
+void BigInt::DivMod(const BigInt& rVal, BigInt* pDiv, BigInt* pMod) const
 {
+assert(pDiv || pMod); // Avoid useless calls
 if (!rVal.IsBig())
 {
 if ( rVal.nVal == 0 )
@@ -578,66 +584,99 @@ void BigInt::DivMod(const BigInt& rVal, bool bMod)
 
 if (rVal.nVal == 1)
 {
-if (bMod)
-*this = 0;
+if (pDiv)
+{
+*pDiv = *this;
+pDiv->Normalize();
+}
+if (pMod)
+*pMod = 0;
 return;
 }
 
 if (!IsBig())
 {
 // No overflows may occur here
-nVal = bMod ? nVal % rVal.nVal : nVal / rVal.nVal;
+const sal_Int32 nDiv = nVal / rVal.nVal; // Compilers usually 
optimize adjacent
+const sal_Int32 nMod = nVal % rVal.nVal; // / and % into a single 
instruction
+if (pDiv)
+*pDiv = nDiv;
+if (pMod)
+*pMod = nMod;
 return;
 }
 
 if ( rVal.nVal == -1 )
 {
-if (bMod)
-*this = 0;
-else
-bIsNeg = !bIsNeg;
+if (pDiv)
+{
+*pDiv = *this;
+pDiv->bIsNeg = !bIsNeg;
+pDiv->Normalize();
+}
+if (pMod)
+*pMod = 0;
 return;
 

[Bug 158276] Since version 7.5.8.2 (x86_64) bookmarks in LO Writer do not hold alpha sort

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158276

--- Comment #7 from raal  ---
(In reply to BrianH from comment #6)
> Thanks for working on this. I find the number of steps to do the daily build
> process kind of overwhelming and am not familiar with the technical side of
> it. Can anyone say when this fix will be part of a normal update?

Hello Brian, you can download daily version here:
http://dev-builds.libreoffice.org/daily/master/
Wait few days to be sure the bugfix is in the build.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: basctl/source sc/source

[Caolán McNamara (via logerrit)]

 basctl/source/basicide/basides1.cxx |2 +-
 sc/source/ui/drawfunc/drawsh.cxx|4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit c905505348d8b44f54f1f51a2f33aca878fe6375
Author: Caolán McNamara 
AuthorDate: Wed Dec 20 15:44:08 2023 +
Commit: Caolán McNamara 
CommitDate: Wed Dec 20 20:22:30 2023 +0100

capture these explicitly by name

Change-Id: I0908aedada9c59426373080d7d3894b452693939
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161076
Tested-by: Jenkins
Reviewed-by: Caolán McNamara 

diff --git a/basctl/source/basicide/basides1.cxx 
b/basctl/source/basicide/basides1.cxx
index 9ef9f75e3f40..806ce96a88a2 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -794,7 +794,7 @@ void Shell::ExecuteGlobal( SfxRequest& rReq )
 auto pRequest = std::make_shared(rReq);
 rReq.Ignore(); // the 'old' request is not relevant any more
 auto xDlg = std::make_shared(pCurWin ? 
pCurWin->GetFrameWeld() : nullptr, m_pCurLocalizationMgr);
-weld::DialogController::runAsync(xDlg, [=](sal_Int32 /*nResult*/){
+weld::DialogController::runAsync(xDlg, [pRequest](sal_Int32 
/*nResult*/){
 pRequest->Done();
 });
 }
diff --git a/sc/source/ui/drawfunc/drawsh.cxx b/sc/source/ui/drawfunc/drawsh.cxx
index 837cf4bc0222..679378bbafb8 100644
--- a/sc/source/ui/drawfunc/drawsh.cxx
+++ b/sc/source/ui/drawfunc/drawsh.cxx
@@ -492,7 +492,7 @@ void ScDrawShell::ExecuteLineDlg( const SfxRequest& rReq )
 pObj,
 bHasMarked));
 
-pDlg->StartExecuteAsync([=](sal_Int32 nResult){
+pDlg->StartExecuteAsync([pDlg, pRequest, pView, bHasMarked](sal_Int32 
nResult){
 if ( nResult == RET_OK )
 {
 if( bHasMarked )
@@ -524,7 +524,7 @@ void ScDrawShell::ExecuteAreaDlg( const SfxRequest& rReq )
 pWin, ,
 rViewData.GetDocument().GetDrawLayer(), true, false));
 
-pDlg->StartExecuteAsync([=](sal_Int32 nResult){
+pDlg->StartExecuteAsync([pDlg, pRequest, pView, bHasMarked](sal_Int32 
nResult){
 if ( nResult == RET_OK )
 {
 if( bHasMarked )

[Bug 158375] Ability to disable active content in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158375

--- Comment #9 from Commit Notification 
 ---
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9157d8de8d8a7a2707179f371f4e4771f41777be

tdf#158375: disable DDE when DisableActiveContent is set

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158375] Ability to disable active content in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158375

--- Comment #8 from Commit Notification 
 ---
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7bb50fd2398220c3b162e7242c1cc8d6c4c31463

tdf#158375: adapt UI when embedded content is disabled via option

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158375] Ability to disable active content in LibreOffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158375

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:24.2.0   |target:24.2.0 target:24.8.0

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: 2 commits - comphelper/source include/comphelper include/svtools officecfg/registry sc/source sd/source sfx2/source svl/source sw/source

[Sarper Akdemir (via logerrit)]

 comphelper/source/container/embeddedobjectcontainer.cxx|4 +++
 include/comphelper/embeddedobjectcontainer.hxx |3 ++
 include/svtools/strings.hrc|1 
 officecfg/registry/schema/org/openoffice/Office/Common.xcs |2 -
 sc/source/ui/docshell/docsh4.cxx   |4 +++
 sc/source/ui/drawfunc/fuins2.cxx   |   11 
 sd/source/ui/func/fuinsert.cxx |   11 
 sfx2/source/appl/linkmgr2.cxx  |   10 +++
 sfx2/source/appl/lnkbase2.cxx  |4 +++
 svl/source/svdde/ddecli.cxx|   17 -
 svl/source/svdde/ddesvr.cxx|   17 -
 sw/source/uibase/app/docsh2.cxx|2 +
 sw/source/uibase/wrtsh/wrtsh1.cxx  |   12 +
 13 files changed, 85 insertions(+), 13 deletions(-)

New commits:
commit 9157d8de8d8a7a2707179f371f4e4771f41777be
Author: Sarper Akdemir 
AuthorDate: Mon Dec 18 16:37:16 2023 +0300
Commit: Sarper Akdemir 
CommitDate: Wed Dec 20 20:15:29 2023 +0100

tdf#158375: disable DDE when DisableActiveContent is set

Change-Id: I167f6ea5d740b5a53cd02a9b865e65ff980a8877
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160922
Reviewed-by: Stephan Bergmann 
Tested-by: Jenkins

diff --git a/comphelper/source/container/embeddedobjectcontainer.cxx 
b/comphelper/source/container/embeddedobjectcontainer.cxx
index 9a971b41b3f6..23915d3e13ab 100644
--- a/comphelper/source/container/embeddedobjectcontainer.cxx
+++ b/comphelper/source/container/embeddedobjectcontainer.cxx
@@ -46,6 +46,8 @@
 #include 
 #include 
 
+#include 
+
 #include 
 #include 
 
@@ -1492,6 +1494,8 @@ bool EmbeddedObjectContainer::SetPersistentEntries(const 
uno::Reference< embed::
 
 bool EmbeddedObjectContainer::getUserAllowsLinkUpdate() const
 {
+if 
(officecfg::Office::Common::Security::Scripting::DisableActiveContent::get())
+return false;
 return pImpl->mbUserAllowsLinkUpdate;
 }
 
diff --git a/include/comphelper/embeddedobjectcontainer.hxx 
b/include/comphelper/embeddedobjectcontainer.hxx
index cc040da152c3..8c75718dce35 100644
--- a/include/comphelper/embeddedobjectcontainer.hxx
+++ b/include/comphelper/embeddedobjectcontainer.hxx
@@ -182,7 +182,10 @@ public:
 */
 bool SetPersistentEntries(const css::uno::Reference< 
css::embed::XStorage >& _xStorage,bool _bClearModifiedFlag = true);
 
+// if DisableActiveContent configuration option is set, this always 
returns false
 bool getUserAllowsLinkUpdate() const;
+
+// if DisableActiveContent configuration option is set, this has no effect
 void setUserAllowsLinkUpdate(bool bNew);
 };
 
diff --git a/officecfg/registry/schema/org/openoffice/Office/Common.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
index 537220b79be2..1ea33be5ba77 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Common.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Common.xcs
@@ -2512,7 +2512,7 @@
 
   
 Specifies whether or not to disable active content. Right now
-only disables active embedded content (OLE).
+only disables active embedded content (OLE) and DDE.
   
   false
 
diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index f8a33f91d1e8..964515743c27 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -109,6 +109,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -2501,6 +2502,9 @@ bool ScDocShell::DdeSetData( const OUString& rItem,
 
 ::sfx2::SvLinkSource* ScDocShell::DdeCreateLinkSource( const OUString& rItem )
 {
+if 
(officecfg::Office::Common::Security::Scripting::DisableActiveContent::get())
+return nullptr;
+
 //  only check for valid item string - range is parsed again in 
ScServerObject ctor
 
 //  named range?
diff --git a/sfx2/source/appl/linkmgr2.cxx b/sfx2/source/appl/linkmgr2.cxx
index f529fb11d468..a20501a1bad6 100644
--- a/sfx2/source/appl/linkmgr2.cxx
+++ b/sfx2/source/appl/linkmgr2.cxx
@@ -21,6 +21,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -281,6 +282,11 @@ void LinkManager::UpdateAllLinks(
 bool bUpdateGrfLinks,
 weld::Window* pParentWin )
 {
+// when active content is disabled don't bother updating all links
+// also (when bAskUpdate == true) don't show the pop up.
+
if(officecfg::Office::Common::Security::Scripting::DisableActiveContent::get())
+return;
+
 // First make a copy of the array in order to update links
 // links in ... no contact between them!
 std::vector aTmpArr;
@@ -354,8 +360,12 @@ SvLinkSourceRef LinkManager::CreateObj( SvBaseLink const * 
pLink )
 case 

core.git: embeddedobj/Library_emboleobj.mk embeddedobj/source

[Sarper Akdemir (via logerrit)]

 embeddedobj/Library_emboleobj.mk|4 
 embeddedobj/source/commonembedding/xfactory.cxx |   16 
 embeddedobj/source/msole/xolefactory.cxx|   13 +
 3 files changed, 33 insertions(+)

New commits:
commit 75df80e34efcd2d39a49ec91654480e156bcec1f
Author: Sarper Akdemir 
AuthorDate: Mon Dec 18 16:23:27 2023 +0300
Commit: Sarper Akdemir 
CommitDate: Wed Dec 20 20:15:02 2023 +0100

tdf#158375: further disable embedded objects

there was the possibility of constructing an OOoEmbeddedObjectFactory
or OleEmbeddedObjectFactory directly instead of
UNOEmbeddedObjectCreator.

So disable all createInstance calls for them too. Securing there won't
be active embedded objects.

Change-Id: Ib47ad920d4951790c12d1a8587505cab2f1e126d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160921
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/embeddedobj/Library_emboleobj.mk b/embeddedobj/Library_emboleobj.mk
index b7fde953c466..d92f86f2c7d3 100644
--- a/embeddedobj/Library_emboleobj.mk
+++ b/embeddedobj/Library_emboleobj.mk
@@ -10,6 +10,10 @@
 
 $(eval $(call gb_Library_Library,emboleobj))
 
+$(eval $(call gb_Library_use_custom_headers,emboleobj,\
+   officecfg/registry \
+))
+
 $(eval $(call 
gb_Library_set_componentfile,emboleobj,embeddedobj/source/msole/emboleobj$(if 
$(filter WNT,$(OS)),.windows),services))
 
 $(eval $(call gb_Library_set_include,emboleobj,\
diff --git a/embeddedobj/source/commonembedding/xfactory.cxx 
b/embeddedobj/source/commonembedding/xfactory.cxx
index c6f57aa9c643..1460b31fd54b 100644
--- a/embeddedobj/source/commonembedding/xfactory.cxx
+++ b/embeddedobj/source/commonembedding/xfactory.cxx
@@ -23,9 +23,11 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
+#include 
 
 #include "xfactory.hxx"
 #include 
@@ -41,6 +43,8 @@ uno::Reference< uno::XInterface > SAL_CALL 
OOoEmbeddedObjectFactory::createInsta
 const 
uno::Sequence< beans::PropertyValue >& aMediaDescr,
 const 
uno::Sequence< beans::PropertyValue >& lObjArgs )
 {
+if ( 
officecfg::Office::Common::Security::Scripting::DisableActiveContent::get() )
+throw lang::NoSupportException("Active embedded content is disabled!");
 if ( !xStorage.is() )
 throw lang::IllegalArgumentException( "No parent storage is provided!",
 static_cast< ::cppu::OWeakObject* 
>(this),
@@ -118,6 +122,8 @@ uno::Reference< uno::XInterface > SAL_CALL 
OOoEmbeddedObjectFactory::createInsta
 const uno::Sequence< beans::PropertyValue >& aMediaDescr,
 const uno::Sequence< beans::PropertyValue >& lObjArgs )
 {
+if ( 
officecfg::Office::Common::Security::Scripting::DisableActiveContent::get() )
+throw lang::NoSupportException("Active embedded content is disabled!");
 if ( !xStorage.is() )
 throw lang::IllegalArgumentException( "No parent storage is provided!",
 static_cast< ::cppu::OWeakObject* 
>(this),
@@ -169,6 +175,8 @@ uno::Reference< uno::XInterface > SAL_CALL 
OOoEmbeddedObjectFactory::createInsta
 const OUString& sEntName,
 const uno::Sequence< 
beans::PropertyValue >& lObjArgs )
 {
+if ( 
officecfg::Office::Common::Security::Scripting::DisableActiveContent::get() )
+throw lang::NoSupportException("Active embedded content is disabled!");
 uno::Reference< uno::XInterface > xResult;
 
 if ( !xStorage.is() )
@@ -212,6 +220,8 @@ uno::Reference< uno::XInterface > SAL_CALL 
OOoEmbeddedObjectFactory::createInsta
 const uno::Sequence< beans::PropertyValue >& lObjArgs )
 {
 // the initialization is completely controlled by user
+if ( 
officecfg::Office::Common::Security::Scripting::DisableActiveContent::get() )
+throw lang::NoSupportException("Active embedded content is disabled!");
 if ( !xStorage.is() )
 throw lang::IllegalArgumentException( "No parent storage is provided!",
 uno::Reference< uno::XInterface >( 
static_cast< ::cppu::OWeakObject* >(this) ),
@@ -257,6 +267,8 @@ uno::Reference< uno::XInterface > SAL_CALL 
OOoEmbeddedObjectFactory::createInsta
 const uno::Sequence< 
beans::PropertyValue >& aMediaDescr,
 const uno::Sequence< 
beans::PropertyValue >& lObjArgs )
 {
+if ( 
officecfg::Office::Common::Security::Scripting::DisableActiveContent::get() )
+throw lang::NoSupportException("Active embedded content is disabled!");
 uno::Reference< uno::XInterface > xResult;
 
 uno::Sequence< beans::PropertyValue > aTempMedDescr( aMediaDescr );

[Bug 158112] Sidebar pane shortcuts conflict with Alt+NumPad input (comment 5, comment 9)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158112

--- Comment #21 from V Stuart Foote  ---
@Mike's suggestion in bug 156443 of logging the key input between 's
KEYDOWN and KEYUP and parsing that value would allow continued handling of the
SB shortcuts as +[1-9], and to keep the MS Win Alt codes, and likewise the
extended Unicode NumPad Alt codes with "EnableHexNumpad" Windows registry
enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158276] Since version 7.5.8.2 (x86_64) bookmarks in LO Writer do not hold alpha sort

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158276

--- Comment #6 from BrianH  ---
Thanks for working on this. I find the number of steps to do the daily build
process kind of overwhelming and am not familiar with the technical side of it.
Can anyone say when this fix will be part of a normal update?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158789] Allow SUMIF and SUBTOTAL to apply to arrays

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=158789

Werner Tietz  changed:

   What|Removed |Added

 Resolution|--- |NOTABUG
 Status|UNCONFIRMED |RESOLVED

--- Comment #5 from Werner Tietz  ---
SUMIF doesnt (and wasnt!) work this way! 
⇒ resolved ⇒ notabug

-- 
You are receiving this mail because:
You are the assignee for the bug.