[Bug 158935] New: Firebird: Decimal numbers add one decimal place, if input are integer values.
https://bugs.documentfoundation.org/show_bug.cgi?id=158935 Bug ID: 158935 Summary: Firebird: Decimal numbers add one decimal place, if input are integer values. Product: LibreOffice Version: 7.6.4.1 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rob...@familiegrosskopf.de Created attachment 191658 --> https://bugs.documentfoundation.org/attachment.cgi?id=191658=edit Open the database file and execute SELECT * FROM "tbl_One" in Tools → SQL Open the attached database. Go to Tools → SQL. Start SELECT * FROM "tbl_One" and let show the output. It will show for fields with 2 decimal places values like 1.000, 2.000, 10.000, 20.000 It will show the right decimal places for 1.10, 2.10, 10.10, 20.10 Screenshot will show the behavior also. Query in the database file will show how many decimal places have been defined. If you connect a subform with a form and use a numeric field with decimal places the connection wont work. When refreshing the subform all data input will disappear, because the connection will look, for example, for 2 decimal places while there appear 3 places as entry in the subform. SO this behavior with wrong decimal places isn't only "cosmetical". -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158933] Calc File>Export as PDF... erases text in cells with certain background colors when Security> Set Passwords is set
https://bugs.documentfoundation.org/show_bug.cgi?id=158933 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158793] EDITING: WordPerfect 4.2 import shows wrong extended characters
https://bugs.documentfoundation.org/show_bug.cgi?id=158793 raal changed: What|Removed |Added Whiteboard||libwpd -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158793] EDITING: WordPerfect 4.2 import shows wrong extended characters
https://bugs.documentfoundation.org/show_bug.cgi?id=158793 raal changed: What|Removed |Added Product|LibreOffice |Document Liberation Project Status|UNCONFIRMED |NEW Ever confirmed|0 |1 Component|Writer |General CC||r...@post.cz --- Comment #3 from raal --- Confirm with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded and Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158864] Many/most dark mode UI elements have too strong a contrast
https://bugs.documentfoundation.org/show_bug.cgi?id=158864 Eyal Rozenberg changed: What|Removed |Added OS|All |Windows (All) --- Comment #8 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #7) > Sorry John, not seeing an issue with panels in the LibreOffice UI. Could you > do a side-by-side with comments. Look at the pressed buttons. Agree with John. Marking as Windows for now - if you believe I'm wrong, please change it back. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158864] Many/most dark mode UI elements have too strong a contrast
https://bugs.documentfoundation.org/show_bug.cgi?id=158864 Eyal Rozenberg changed: What|Removed |Added OS|All |Windows (All) --- Comment #8 from Eyal Rozenberg --- (In reply to V Stuart Foote from comment #7) > Sorry John, not seeing an issue with panels in the LibreOffice UI. Could you > do a side-by-side with comments. Look at the pressed buttons. Agree with John. Marking as Windows for now - if you believe I'm wrong, please change it back. -- You are receiving this mail because: You are on the CC list for the bug.
Outreachy Dec 2023 - Weekly Update 3
Hello everyone, I wish to share my last week's progress. This week I mostly worked on fixing issues in the previous patch and working on the QtInstanceBuilder. The tough issue here is to convert already existing gtk ui files into a format that can be compatible with Qt. Taking guide from vcl parser and gtk3 to gtk4 conversion, for a few ui files, I've started basic parsing and conversion code for a few UI files. But It requires much more parsing and conversion logic. But would be a good starting point. Next week I will continue working on this. If anyone has suggestions or insights to share, please feel free to do so. Thanks to Michael and Heiko for their guidance. Wishing you all a very happy new year! Thank you
core.git: Branch 'libreoffice-24-2' - include/comphelper
include/comphelper/interfacecontainer3.hxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit 86afab127963a5fdca254d762b879da67953f39f
Author: Caolán McNamara
AuthorDate: Sat Dec 23 20:43:27 2023 +
Commit: Noel Grandin
CommitDate: Sat Dec 30 19:06:29 2023 +0100
OInterfaceIteratorHelper3 always copies maData contents in ctor
while I think the idea is that the copy on write should only
be done by OInterfaceContainerHelper3, i.e. that ownership
really transfers to OInterfaceIteratorHelper3 and OInterfaceContainerHelper3
makes a new one if that turns out to be necessary
Change-Id: I6e97e3b303f133edbbb35ac23f39cf5348ad49fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161257
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
(cherry picked from commit 28616cf0989dab2ca2a1710c64f6fb1c1d78c584)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161328
Reviewed-by: Noel Grandin
diff --git a/include/comphelper/interfacecontainer3.hxx
b/include/comphelper/interfacecontainer3.hxx
index 4b3d44bab69d..02f96658dcd2 100644
--- a/include/comphelper/interfacecontainer3.hxx
+++ b/include/comphelper/interfacecontainer3.hxx
@@ -63,7 +63,8 @@ public:
OInterfaceIteratorHelper3(OInterfaceContainerHelper3& rCont_)
: rCont(rCont_)
, maData(rCont.maData)
-, nRemain(maData->size())
+// const_cast so we don't trigger make_unique via
o3tl::cow_wrapper::operator->
+, nRemain(std::as_const(maData)->size())
{
}
@@ -96,12 +97,12 @@ template
const css::uno::Reference&
OInterfaceIteratorHelper3::next()
{
nRemain--;
-return (*maData)[nRemain];
+return (*std::as_const(maData))[nRemain];
}
template void OInterfaceIteratorHelper3::remove()
{
-rCont.removeInterface((*maData)[nRemain]);
+rCont.removeInterface((*std::as_const(maData))[nRemain]);
}
/**
core.git: xmlsecurity/source
xmlsecurity/source/helper/UriBindingHelper.cxx |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
New commits:
commit d2fd70c655b45f1d4ea570fa0455231d5d059709
Author: Noel Grandin
AuthorDate: Sat Dec 30 15:16:26 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 30 19:05:49 2023 +0100
no need to use SvLockBytes in UriBindingHelper
we already have other, simpler facilities for wrapping streams
Change-Id: Icff4cca2d6327dad9c5964ca61d578506009d047
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161445
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/xmlsecurity/source/helper/UriBindingHelper.cxx
b/xmlsecurity/source/helper/UriBindingHelper.cxx
index f6c36d2c8b36..600f560860a4 100644
--- a/xmlsecurity/source/helper/UriBindingHelper.cxx
+++ b/xmlsecurity/source/helper/UriBindingHelper.cxx
@@ -21,6 +21,7 @@
#include
#include
+#include
#include
#include
@@ -54,10 +55,8 @@ uno::Reference< io::XInputStream > SAL_CALL
UriBindingHelper::getUriBinding( con
}
else
{
-SvFileStream* pStream = new SvFileStream( uri, StreamMode::READ );
-sal_uInt64 nBytes = pStream->TellEnd();
-SvLockBytesRef xLockBytes = new SvLockBytes( pStream, true );
-xInputStream = new utl::OInputStreamHelper( xLockBytes, nBytes );
+std::unique_ptr pStream(new SvFileStream( uri,
StreamMode::READ ));
+xInputStream = new utl::OInputStreamWrapper( std::move(pStream) );
}
return xInputStream;
}
core.git: 2 commits - forms/source
forms/source/component/ImageControl.cxx | 14 ---
forms/source/component/imgprod.cxx | 149 +++-
forms/source/component/imgprod.hxx |4
3 files changed, 20 insertions(+), 147 deletions(-)
New commits:
commit ec29db74bf5ffba086f5ced6053814d548616f7d
Author: Noel Grandin
AuthorDate: Sat Dec 30 15:13:50 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 30 19:05:38 2023 +0100
no need to use SvLockBytes in OImageControlModel
we already have other, simpler facilities for wrapping streams
Change-Id: Ic6f88821e089951999395507bc84e68ea339d9de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161444
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/ImageControl.cxx
b/forms/source/component/ImageControl.cxx
index c2bc0953c6c8..a4930849c4fc 100644
--- a/forms/source/component/ImageControl.cxx
+++ b/forms/source/component/ImageControl.cxx
@@ -52,6 +52,7 @@
#include
#include
#include
+#include
#include
#include
@@ -399,7 +400,6 @@ void OImageControlModel::read(const
Reference& _rxInStream)
bool OImageControlModel::impl_updateStreamForURL_lck( const OUString& _rURL,
ValueChangeInstigator _eInstigator )
{
// create a stream for the image specified by the URL
-std::unique_ptr< SvStream > pImageStream;
Reference< XInputStream > xImageStream;
if ( ::svt::GraphicAccess::isSupportedURL( _rURL ) )
@@ -408,19 +408,11 @@ bool OImageControlModel::impl_updateStreamForURL_lck(
const OUString& _rURL, Val
}
else
{
-pImageStream = ::utl::UcbStreamHelper::CreateStream( _rURL,
StreamMode::READ );
+std::unique_ptr< SvStream > pImageStream =
::utl::UcbStreamHelper::CreateStream( _rURL, StreamMode::READ );
bool bSetNull = (pImageStream == nullptr) || (ERRCODE_NONE !=
pImageStream->GetErrorCode());
if ( !bSetNull )
-{
-// get the size of the stream
-sal_uInt64 const nSize = pImageStream->remainingSize();
-if (pImageStream->GetBufferSize() < 8192)
-pImageStream->SetBufferSize(8192);
-pImageStream->Seek(STREAM_SEEK_TO_BEGIN);
-
-xImageStream = new ::utl::OInputStreamHelper( new SvLockBytes(
pImageStream.get(), false ), nSize );
-}
+xImageStream = new ::utl::OInputStreamWrapper(
std::move(pImageStream) );
}
if ( xImageStream.is() )
commit 04c3ef3c7224644b7e54ff215343391cef77f7b5
Author: Noel Grandin
AuthorDate: Sat Dec 30 15:08:30 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 30 19:05:29 2023 +0100
ImgProdLockBytes is unnecessary
we already have facilities for doing this kind of wrapping
(removes another instance of SvLockBytes)
Change-Id: Ie3546efe06580f9492d8f6ddbc1a2e904036465a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161443
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/imgprod.cxx
b/forms/source/component/imgprod.cxx
index 002ef0cc56e8..d53796fc1f3a 100644
--- a/forms/source/component/imgprod.cxx
+++ b/forms/source/component/imgprod.cxx
@@ -32,133 +32,9 @@
#include
#include
+#include
#include
-namespace {
-
-class ImgProdLockBytes : public SvLockBytes
-{
-css::uno::Reference< css::io::XInputStream > xStmRef;
-css::uno::Sequence maSeq;
-
-public:
-
-ImgProdLockBytes( SvStream* pStm, bool bOwner );
-explicit ImgProdLockBytes( css::uno::Reference< css::io::XInputStream >
xStreamRef );
-
-virtual ErrCode ReadAt( sal_uInt64 nPos, void* pBuffer, std::size_t
nCount, std::size_t * pRead ) const override;
-virtual ErrCode WriteAt( sal_uInt64 nPos, const void* pBuffer,
std::size_t nCount, std::size_t * pWritten ) override;
-virtual ErrCode Flush() const override;
-virtual ErrCode SetSize( sal_uInt64 nSize ) override;
-virtual ErrCode Stat( SvLockBytesStat* ) const override;
-};
-
-}
-
-ImgProdLockBytes::ImgProdLockBytes( SvStream* pStm, bool bOwner ) :
-SvLockBytes( pStm, bOwner )
-{
-}
-
-
-ImgProdLockBytes::ImgProdLockBytes( css::uno::Reference< css::io::XInputStream
> _xStmRef ) :
-xStmRef(std::move( _xStmRef ))
-{
-if( !xStmRef.is() )
-return;
-
-const sal_uInt32nBytesToRead = 65535;
-sal_uInt32 nRead;
-
-do
-{
-css::uno::Sequence< sal_Int8 > aReadSeq;
-
-nRead = xStmRef->readSomeBytes( aReadSeq, nBytesToRead );
-
-if( nRead )
-{
-const sal_uInt32 nOldLength = maSeq.getLength();
-maSeq.realloc( nOldLength + nRead );
-memcpy( maSeq.getArray() + nOldLength, aReadSeq.getConstArray(),
aReadSeq.getLength() );
-}
-}
-while( nBytesToRead == nRead );
-}
-
-ErrCode ImgProdLockBytes::ReadAt(sal_uInt64 const nPos,
-void* pBuffer, std::size_t nCount, std::size_t * pRead)
[Bug 127294] Add more tips of the day (and make it module-specific eventually)
https://bugs.documentfoundation.org/show_bug.cgi?id=127294 --- Comment #89 from Keniva menan --- Apart from more daily new techniques to improve your life you can go ahead with an international blog http://www.techbnnews.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158934] New: Password removed from Writer file on its own
https://bugs.documentfoundation.org/show_bug.cgi?id=158934 Bug ID: 158934 Summary: Password removed from Writer file on its own Product: LibreOffice Version: 7.6.2.1 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: conni...@pacbell.net Description: I was concerned to discover that one of my Writer files that is password protected opened today without requiring me to enter its password. I am 100% certain I didn’t remove it manually. I’m wondering if it was auto-recovered and if that triggered this? Is this a bug or has anyone else experienced this? I have a Dell desktop running Windows 10. When I posted this on the LibreOffice forum I was told that auto-recovery should not remove a password. I have been using software for decades (and have worked in IT) and know that I would have had to do Save As to be able to remove the password. I typically save my file as I work with Ctrl-S. I can't see how I could have accidentally removed the password. I live alone so nobody else could have done this. Based on my backups, I can see that the last password protected file was on 12/6. The 12/27 version had the password removed (sharing in case you made any updates during this time). I hope that it was somehow a user error though I can't see how I could have done this. I want to ensure that the file in question is for my eyes only. Sharing in case anyone else reports this same behavior. Thanks. Actual Results: I'm not sure how you can do this. Expected Results: I would expect password to remain until a user selects Save As and unticks the Save with password link. Reproducible: Didn't try User Profile Reset: No Additional Info: Not removed the password! :) Version: 7.6.2.1 (X86_64) / LibreOffice Community Build ID: 56f7684011345957bbf33a7ee678afaf4d2ba333 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158816] Dependence on ~/Documents
https://bugs.documentfoundation.org/show_bug.cgi?id=158816 raal changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||r...@post.cz Resolution|--- |NOTABUG --- Comment #10 from raal --- Hello, if I understand correctly the discussion, we can close the bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158846] Crash Report Upload Missing on LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=158846 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- According the https://ask.libreoffice.org/t/finding-the-crash-report/71227 the crash reports should be in C:\Users\YourName\AppData\Roaming\LibreOffice\4\crash -- You are receiving this mail because: You are the assignee for the bug.
[Bug 47531] external references in charts
https://bugs.documentfoundation.org/show_bug.cgi?id=47531 --- Comment #9 from Doug --- If this has been deleted because it has been solved please provide a link to the solution, so that I can review and try it. It is also impossible to link more than one external chart to any spreadsheet through the linking solution. See the procedure in this discussion link: https://ask.libreoffice.org/t/how-do-you-create-a-chart-in-a-spreadsheet-that-uses-data-contained-in-another-calc-spresdsheet/48542/7 If you would review more info about this "Deleted/Left Out Functionality", removed, ignored or drooped functionality please review this link: https://ask.libreoffice.org/t/calc-functionality-lost/99603/5 I would appreciate a response and review of the bug, rather than a flat rejection. Calc can use URL links to other spreadsheets, and used to do this when it was Star Office. It also worked in Excel. Why has it been swept under the table? On 12/26/2023 12:50 PM, bugzilla-dae...@bugs.documentfoundation.org wrote: > Julien Nabet changed bug 158870, -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158616] Verankerung von Bildern im Writer funktioniert nicht mehr
https://bugs.documentfoundation.org/show_bug.cgi?id=158616 raal changed: What|Removed |Added CC||r...@post.cz Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from raal --- Hello, we need a test files to reproduce. If you find some time, please, can you prepare such files? How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Moving bug to Needinfo for now. Thank you -- You are receiving this mail because: You are the assignee for the bug.
[Bug 32484] Allow anchor settings in frame styles
https://bugs.documentfoundation.org/show_bug.cgi?id=32484 Justin L changed: What|Removed |Added Version|3.3.0 RC1 |Inherited From OOo -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158849] Creating serial letter into a single document does not work correctly.
https://bugs.documentfoundation.org/show_bug.cgi?id=158849 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #4 from raal --- Created attachment 191657 --> https://bugs.documentfoundation.org/attachment.cgi?id=191657=edit generated file Tested with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded - saved file looks good to me. Please check it, maybe I misunderstood the problem. Thanks. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158933] Calc File>Export as PDF... erases text in cells with certain background colors when Security> Set Passwords is set
https://bugs.documentfoundation.org/show_bug.cgi?id=158933 --- Comment #2 from sam --- Created attachment 191656 --> https://bugs.documentfoundation.org/attachment.cgi?id=191656=edit Screenshot of the output pdf, which is INCORRECT when a password is entered -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158933] Calc File>Export as PDF... erases text in cells with certain background colors when Security> Set Passwords is set
https://bugs.documentfoundation.org/show_bug.cgi?id=158933 --- Comment #1 from sam --- Created attachment 191655 --> https://bugs.documentfoundation.org/attachment.cgi?id=191655=edit Screenshot of the output pdf, which is connect when no password is entered This a screenshot of the PDF generated when using the PDF export without specifying a password. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158933] New: Calc File>Export as PDF... erases text in cells with certain background colors when Security> Set Passwords is set
https://bugs.documentfoundation.org/show_bug.cgi?id=158933 Bug ID: 158933 Summary: Calc File>Export as PDF... erases text in cells with certain background colors when Security> Set Passwords is set Product: LibreOffice Version: 7.6.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: busma...@hotmail.com Created attachment 191654 --> https://bugs.documentfoundation.org/attachment.cgi?id=191654=edit Libreoffice calc spreadsheet demonstrating bug when exporting password protected PDF _ 1. Overview On Libre office Calc, under linux Ubuntu 23.10, when exporting a document as a PDF and specifying a password, the content of cells are erased when those cells have a colored background. This bug does not exist under Libre office calc on windows (tried). ___ 2. Steps required to reproduce the bug: 2.1 On linux, Open the attached spreadsheet PDF_Export_test.ods 2.2 File> Export as PDF... 2.3 In PDF Options>Security, click on [Set Passwords...] 2.4 Enter the password 'bug' in set open password "Password:" and "Confirm:" text boxes. 2.5 Click [OK] 2.6 Click [Export] 2.7 Set a name for the document and click [Export] 2.8 Open the document 2.8.1 click on the document 2.8.2 type password bug 3. review the document: the 4 first background colored rows are now empty. The only non empty rows are the last two. __ 3. Contextual information This bug affects Libre Office Calc on Linux only. Tried on versions: 7.5.9.2 (Manual debian package install) and 7.6.3.2 (Snap) === LIBRE OFFICE CALC VERSION INFORMATION == Version: 7.6.3.2 (X86_64) / LibreOffice Community Build ID: 4fe86607b5ac922e55f140471fda9b60bdaa980d CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-GB Calc: threaded === OPERATING SYSTEM INFORMATION === - **OS Name:** Ubuntu 23.10 - **OS Build:**(null) - **OS Type:** 64-bit - **GNOME Version:** Not Available - **Windowing System:**Wayland - **Kernel Version:** Linux 6.5.0-14-generic -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138153] Image off page after changing anchor to 'to character' inside a caption frame (and undo doesn't solve it)
https://bugs.documentfoundation.org/show_bug.cgi?id=138153 --- Comment #8 from Telesto --- Created attachment 191653 --> https://bugs.documentfoundation.org/attachment.cgi?id=191653=edit Simplified bug doc (In reply to sdc.blanco from comment #7) > Created attachment 191647 [details] > simpler document with critical image and caption frame Thanks for looking into it :-). A smaller example surely appreciated. I'm able to reproduce this with your simplified version, with a small modification: a page break before the image. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sc/source
sc/source/core/data/attarray.cxx |1 +
sc/source/ui/view/viewfunc.cxx |1 -
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 46b06663ae767d3423f2135fa91800cfa304877b
Author: Mike Kaganski
AuthorDate: Sat Dec 30 18:37:58 2023 +0600
Commit: Mike Kaganski
CommitDate: Sat Dec 30 17:45:12 2023 +0100
tdf#158254: don't shrink to data area when applying to entire sheet
Commit ac859a4c6a7fce4efee9cdd45821a0c9e40e9e9a (tdf#147842 shrink
selection to data area when applying to entire sheet, 2022-10-18)
tried to workaround the problem of applying to the massive amount
of columns. This caused regressions, where it was impossible to pre-
format entire rows.
This change removes the call to ShrinkToDataArea from
ScViewFunc::ApplySelectionPattern (it is used elsewhere, so the
commit is not reverted completely).
Instead, it addresses the bottleneck in the bugdoc in tdf#147842,
which is ScAttrArray::RemoveCellCharAttribs: since the document
had hidden rows, selecting all made multi-selection split into
separate stripes, and the fulction was called repeatedly, and
itself called ScEditUtil::RemoveCharAttribs for every cell in
~ 1000 columns * 100 rows, even though most of the cells in
that range were empty - so no char attribs could exist. Asking
for the last used row (the same as done in ShrinkToDataArea)
makes the operation fast again, and keeps assigning the format
to the entire range.
Change-Id: I9635ea1a392b3a1e048c0888f4786a3628675fc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161442
Tested-by: Mike Kaganski
Reviewed-by: Mike Kaganski
diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index 4b9bbc7a4e2c..fcdb0be9da5e 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -404,6 +404,7 @@ void ScAttrArray::RemoveCellCharAttribs( SCROW nStartRow,
SCROW nEndRow,
// cache mdds position, this doesn't modify the mdds container, just
EditTextObject's
sc::ColumnBlockPosition blockPos;
rDocument.InitColumnBlockPosition( blockPos, nTab, nCol );
+nEndRow = rDocument.GetLastDataRow(nTab, nCol, nCol, nEndRow);
for (SCROW nRow = nStartRow; nRow <= nEndRow; ++nRow)
{
ScAddress aPos(nCol, nRow, nTab);
diff --git a/sc/source/ui/view/viewfunc.cxx b/sc/source/ui/view/viewfunc.cxx
index 2958f13cd2eb..97d7338ece91 100644
--- a/sc/source/ui/view/viewfunc.cxx
+++ b/sc/source/ui/view/viewfunc.cxx
@@ -1253,7 +1253,6 @@ void ScViewFunc::ApplySelectionPattern( const
ScPatternAttr& rAttr, bool bCursor
ScDocShell* pDocSh = rViewData.GetDocShell();
ScDocument& rDoc= pDocSh->GetDocument();
ScMarkData aFuncMark( rViewData.GetMarkData() ); // local copy for
UnmarkFiltered
-ShrinkToDataArea( aFuncMark, rDoc );
ScViewUtil::UnmarkFiltered( aFuncMark, rDoc );
bool bRecord = true;
[Bug 158929] LibreOffice disappeared
https://bugs.documentfoundation.org/show_bug.cgi?id=158929 Julien Nabet changed: What|Removed |Added Summary|LibreOffice Disapperaed |LibreOffice disappeared -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158929] LibreOffice Disapperaed
https://bugs.documentfoundation.org/show_bug.cgi?id=158929 Dieter changed: What|Removed |Added Component|Writer |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150686] Macro connected through Tools → Customize → Events → View created leads to error when document is opened again
https://bugs.documentfoundation.org/show_bug.cgi?id=150686 Robert Großkopf changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Robert Großkopf --- Tested again. Bug exists up to LO 7.4.3.2, but with current version there is no error any more. I will close this one as WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 raal changed: What|Removed |Added Depends on||158752 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158752 [Bug 158752] Move windows independently on Linux -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158752] Move windows independently on Linux
https://bugs.documentfoundation.org/show_bug.cgi?id=158752 raal changed: What|Removed |Added CC||r...@post.cz Status|UNCONFIRMED |NEW Blocks||103182 Ever confirmed|0 |1 --- Comment #4 from raal --- Hello, this is related to GTK3 and I can confirm it. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158932] New: move heading up -- promote / denote outline level (NAVIGATOR)
https://bugs.documentfoundation.org/show_bug.cgi?id=158932 Bug ID: 158932 Summary: move heading up -- promote / denote outline level (NAVIGATOR) Product: LibreOffice Version: 24.2.0.0 alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu Created attachment 191652 --> https://bugs.documentfoundation.org/attachment.cgi?id=191652=edit promote / denote pictogram suggestion hi, right now in Navigator, we have these 2 options: upward / downward double triangles or left or right double triangles The up / down ones work... But the "back to the beginning" or "jump to the end" or "fast forward" or "fast rewind" ones don't The solution that offers itself is the "volume" (sound) icon that we see at the "show up to outline level" (of) dropdown... That icon could be used, accompanied with an arrow, up or downward, on the right side, and the fact that it is "promoting" or "denoting" would be visually clear... -- You are receiving this mail because: You are the assignee for the bug.
core.git: desktop/source filter/source sw/source xmloff/source
desktop/source/pkgchk/unopkg/unopkg_misc.cxx|3 +--
filter/source/config/cache/filterfactory.cxx|3 +--
sw/source/core/docnode/retrievedinputstreamdata.cxx |3 +--
xmloff/source/chart/SchXMLChartContext.cxx |3 +--
4 files changed, 4 insertions(+), 8 deletions(-)
New commits:
commit 427d8f61d7bc4087a9408ba7f0b8a718943f4240
Author: Caolán McNamara
AuthorDate: Sat Dec 30 11:59:45 2023 +
Commit: Caolán McNamara
CommitDate: Sat Dec 30 16:23:05 2023 +0100
cid#1546349 COPY_INSTEAD_OF_MOVE
and
cid#1546236 COPY_INSTEAD_OF_MOVE
cid#1546126 COPY_INSTEAD_OF_MOVE
cid#1546042 COPY_INSTEAD_OF_MOVE
Change-Id: I24b60d855f564ba8551501fc1dc614b24d5505c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161440
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
b/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
index 553952917748..ba49544f0fec 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_misc.cxx
@@ -349,9 +349,8 @@ Reference connectToOffice(
bool verbose )
{
OUString pipeId( ::dp_misc::generateRandomPipeId() );
-OUString acceptArg = "--accept=pipe,name=" + pipeId + ";urp;";
-Sequence args { "--nologo", "--nodefault", acceptArg };
+Sequence args { "--nologo", "--nodefault", "--accept=pipe,name="
+ pipeId + ";urp;" };
OUString appURL( getExecutableDir() + "/soffice" );
if (verbose)
diff --git a/filter/source/config/cache/filterfactory.cxx
b/filter/source/config/cache/filterfactory.cxx
index 1c6fadca6c86..9b0793b94e1e 100644
--- a/filter/source/config/cache/filterfactory.cxx
+++ b/filter/source/config/cache/filterfactory.cxx
@@ -152,8 +152,7 @@ css::uno::Reference< css::container::XEnumeration >
SAL_CALL FilterFactory::crea
if (pos != -1)
{
OSL_FAIL("DEPRECATED!
Please use new query format: 'matchByDocumentService=...'");
-OUString sPatchedQuery(OUString::Concat("matchByDocumentService=") +
sNewQuery.subView(7));
-sNewQuery = sPatchedQuery;
+sNewQuery = OUString::Concat("matchByDocumentService=") +
sNewQuery.subView(7);
}
// analyze query and split it into its tokens
diff --git a/sw/source/core/docnode/retrievedinputstreamdata.cxx
b/sw/source/core/docnode/retrievedinputstreamdata.cxx
index 311be07ca719..607f14c21359 100644
--- a/sw/source/core/docnode/retrievedinputstreamdata.cxx
+++ b/sw/source/core/docnode/retrievedinputstreamdata.cxx
@@ -38,8 +38,7 @@ SwRetrievedInputStreamDataManager::tDataKey
SwRetrievedInputStreamDataManager::R
// create empty data container for given thread Consumer
tDataKey nDataKey( snNextKeyValue );
-tData aNewEntry( pThreadConsumer );
-maInputStreamData[ nDataKey ] = aNewEntry;
+maInputStreamData[nDataKey] = tData(pThreadConsumer);
// prepare next data key value
if ( snNextKeyValue < SAL_MAX_UINT64 )
diff --git a/xmloff/source/chart/SchXMLChartContext.cxx
b/xmloff/source/chart/SchXMLChartContext.cxx
index dc3e4266be03..a6420f79e7f2 100644
--- a/xmloff/source/chart/SchXMLChartContext.cxx
+++ b/xmloff/source/chart/SchXMLChartContext.cxx
@@ -1051,9 +1051,8 @@ css::uno::Reference< css::xml::sax::XFastContextHandler >
SchXMLChartContext::cr
{
xProp->setPropertyValue("HasMainTitle", uno::Any(true) );
}
-uno::Reference< drawing::XShape > xTitleShape =
xDoc->getTitle();
pContext = new SchXMLTitleContext( mrImportHelper, GetImport(),
- maMainTitle, xTitleShape );
+ maMainTitle,
xDoc->getTitle() );
}
break;
case XML_ELEMENT(CHART, XML_SUBTITLE):
[Bug 158931] Display of SVG images containing the text-anchor="end" attribute and subscript text
https://bugs.documentfoundation.org/show_bug.cgi?id=158931 --- Comment #3 from raal --- Created attachment 191651 --> https://bugs.documentfoundation.org/attachment.cgi?id=191651=edit LO 24.8 on the left, Firefox right -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158931] Display of SVG images containing the text-anchor="end" attribute and subscript text
https://bugs.documentfoundation.org/show_bug.cgi?id=158931 raal changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #2 from raal --- Hello, I doesn't see the problem with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Comparing LO with Firefox. Please could you test it with dev version? You can download it here: http://dev-builds.libreoffice.org/daily/master/ Thank you -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a9c9b4241d7ce214bce5c2301447735d51f0c8a9 Author: Martin Srebotnjak AuthorDate: Sat Dec 30 16:10:02 2023 +0100 Commit: Gerrit Code Review CommitDate: Sat Dec 30 16:10:02 2023 +0100 Update git submodules * Update translations from branch 'libreoffice-24-2' to 4e4a02b232e29942163038227662df5b7fc9032e - Updated Slovenian translation Change-Id: I0d82b9e27efc285b815382c3adb6f51e18776bcf diff --git a/translations b/translations index 21fad4fcec07..4e4a02b232e2 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 21fad4fcec07cef0c0385cd8b0531233b716f237 +Subproject commit 4e4a02b232e29942163038227662df5b7fc9032e
translations.git: Branch 'libreoffice-24-2' - source/sl
source/sl/cui/messages.po | 14 source/sl/filter/messages.po |4 source/sl/fpicker/messages.po |4 source/sl/helpcontent2/source/text/sbasic/python.po |4 source/sl/helpcontent2/source/text/sbasic/shared.po |4 source/sl/helpcontent2/source/text/sbasic/shared/03.po| 54 source/sl/helpcontent2/source/text/scalc.po | 52 source/sl/helpcontent2/source/text/scalc/00.po| 750 +- source/sl/helpcontent2/source/text/scalc/01.po| 586 +-- source/sl/helpcontent2/source/text/scalc/guide.po |8 source/sl/helpcontent2/source/text/schart/01.po |4 source/sl/helpcontent2/source/text/sdraw/01.po| 52 source/sl/helpcontent2/source/text/shared/00.po | 152 +- source/sl/helpcontent2/source/text/shared/01.po | 66 source/sl/helpcontent2/source/text/shared/guide.po| 320 source/sl/helpcontent2/source/text/shared/help.po | 26 source/sl/helpcontent2/source/text/shared/menu.po |4 source/sl/helpcontent2/source/text/shared/optionen.po |4 source/sl/helpcontent2/source/text/simpress/01.po |4 source/sl/helpcontent2/source/text/simpress/guide.po |4 source/sl/helpcontent2/source/text/smath/01.po|6 source/sl/helpcontent2/source/text/swriter/00.po | 86 - source/sl/helpcontent2/source/text/swriter/01.po |4 source/sl/helpcontent2/source/text/swriter/guide.po |4 source/sl/helpcontent2/source/text/swriter/librelogo.po |4 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po | 116 + source/sl/readlicense_oo/docs.po |4 source/sl/sc/messages.po | 69 source/sl/sd/messages.po |4 source/sl/setup_native/source/mac.po |4 source/sl/starmath/messages.po|4 source/sl/svtools/messages.po | 170 +- source/sl/svx/messages.po |8 source/sl/sw/messages.po |4 source/sl/uui/messages.po | 26 source/sl/vcl/messages.po |4 source/sl/xmlsecurity/messages.po | 16 37 files changed, 1998 insertions(+), 651 deletions(-) New commits: commit 4e4a02b232e29942163038227662df5b7fc9032e Author: Martin Srebotnjak AuthorDate: Sat Dec 30 16:08:55 2023 +0100 Commit: Andras Timar CommitDate: Sat Dec 30 16:09:56 2023 +0100 Updated Slovenian translation Change-Id: I0d82b9e27efc285b815382c3adb6f51e18776bcf diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po index da32ac995f9..d3435110a5c 100644 --- a/source/sl/cui/messages.po +++ b/source/sl/cui/messages.po @@ -3,14 +3,14 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 24.02 " "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI " -"POT-Creation-Date: 2023-12-10 12:10+0100 " +"POT-Creation-Date: 2023-12-23 09:14+0100 " "PO-Revision-Date: 2023-12-19 10:08+0200 " "Last-Translator: Martin Srebotnjak " "Language-Team: sl.libreoffice.org " -"Language: sl " "MIME-Version: 1.0 " "Content-Type: text/plain; charset=UTF-8 " "Content-Transfer-Encoding: 8bit " +"Language: sl " "Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3); " "X-Generator: Virtaal 0.7.1 " "X-Accelerator-Marker: ~ " @@ -13491,27 +13491,27 @@ msgctxt "optonlineupdatepage|privacy" msgid "Privacy Policy" msgstr "Politika zasebnosti" -#: cui/uiconfig/ui/optonlineupdatepage.ui:529 +#: cui/uiconfig/ui/optonlineupdatepage.ui:528 msgctxt "optonlineupdatepage|enableMar" msgid "Enable au_tomatic update" msgstr "Omogoči _samodejno posodabljanje" -#: cui/uiconfig/ui/optonlineupdatepage.ui:538 +#: cui/uiconfig/ui/optonlineupdatepage.ui:537 msgctxt "extended_tip|enableMar" msgid "Mark to enable automatic update." msgstr "Potrdite, da omogočite samodejno posodabljanje." -#: cui/uiconfig/ui/optonlineupdatepage.ui:547 +#: cui/uiconfig/ui/optonlineupdatepage.ui:546 msgctxt "optonlineupdatepage|labelMar" msgid "Automatic Update" msgstr "Samodejna posodobitev" -#: cui/uiconfig/ui/optonlineupdatepage.ui:561 +#: cui/uiconfig/ui/optonlineupdatepage.ui:565 msgctxt "optonlineupdatepage|label1" msgid "Online Update Options" msgstr "Možnosti spletne posodobitve" -#: cui/uiconfig/ui/optonlineupdatepage.ui:569 +#: cui/uiconfig/ui/optonlineupdatepage.ui:573 msgctxt "extended_tip|OptOnlineUpdatePage" msgid "Specifies
core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9e00b676ee500aa46ce539f4adf8c4de73039b36 Author: Martin Srebotnjak AuthorDate: Sat Dec 30 16:09:09 2023 +0100 Commit: Gerrit Code Review CommitDate: Sat Dec 30 16:09:09 2023 +0100 Update git submodules * Update translations from branch 'master' to 2a46004be910e61d7a2d7c3cbc09e773654d4095 - Updated Slovenian translation Change-Id: I0d82b9e27efc285b815382c3adb6f51e18776bcf diff --git a/translations b/translations index 4eb96d17e8d5..2a46004be910 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 4eb96d17e8d53f48a7709ae657534cc451c7e4c8 +Subproject commit 2a46004be910e61d7a2d7c3cbc09e773654d4095
translations.git: source/sl
source/sl/cui/messages.po | 14 source/sl/filter/messages.po |4 source/sl/fpicker/messages.po |4 source/sl/helpcontent2/source/text/sbasic/python.po |4 source/sl/helpcontent2/source/text/sbasic/shared.po |4 source/sl/helpcontent2/source/text/sbasic/shared/03.po| 54 source/sl/helpcontent2/source/text/scalc.po | 52 source/sl/helpcontent2/source/text/scalc/00.po| 750 +- source/sl/helpcontent2/source/text/scalc/01.po| 586 +-- source/sl/helpcontent2/source/text/scalc/guide.po |8 source/sl/helpcontent2/source/text/schart/01.po |4 source/sl/helpcontent2/source/text/sdraw/01.po| 52 source/sl/helpcontent2/source/text/shared/00.po | 152 +- source/sl/helpcontent2/source/text/shared/01.po | 66 source/sl/helpcontent2/source/text/shared/guide.po| 320 source/sl/helpcontent2/source/text/shared/help.po | 26 source/sl/helpcontent2/source/text/shared/menu.po |4 source/sl/helpcontent2/source/text/shared/optionen.po |4 source/sl/helpcontent2/source/text/simpress/01.po |4 source/sl/helpcontent2/source/text/simpress/guide.po |4 source/sl/helpcontent2/source/text/smath/01.po|6 source/sl/helpcontent2/source/text/swriter/00.po | 86 - source/sl/helpcontent2/source/text/swriter/01.po |4 source/sl/helpcontent2/source/text/swriter/guide.po |4 source/sl/helpcontent2/source/text/swriter/librelogo.po |4 source/sl/officecfg/registry/data/org/openoffice/Office/UI.po | 116 + source/sl/readlicense_oo/docs.po |4 source/sl/sc/messages.po | 69 source/sl/sd/messages.po |4 source/sl/setup_native/source/mac.po |4 source/sl/starmath/messages.po|4 source/sl/svtools/messages.po | 170 +- source/sl/svx/messages.po |8 source/sl/sw/messages.po |4 source/sl/uui/messages.po | 26 source/sl/vcl/messages.po |4 source/sl/xmlsecurity/messages.po | 16 37 files changed, 1998 insertions(+), 651 deletions(-) New commits: commit 2a46004be910e61d7a2d7c3cbc09e773654d4095 Author: Martin Srebotnjak AuthorDate: Sat Dec 30 16:08:55 2023 +0100 Commit: Andras Timar CommitDate: Sat Dec 30 16:08:55 2023 +0100 Updated Slovenian translation Change-Id: I0d82b9e27efc285b815382c3adb6f51e18776bcf diff --git a/source/sl/cui/messages.po b/source/sl/cui/messages.po index da32ac995f9..d3435110a5c 100644 --- a/source/sl/cui/messages.po +++ b/source/sl/cui/messages.po @@ -3,14 +3,14 @@ msgid "" msgstr "" "Project-Id-Version: LibreOffice 24.02 " "Report-Msgid-Bugs-To: https://bugs.libreoffice.org/enter_bug.cgi?product=LibreOffice_status=UNCONFIRMED=UI " -"POT-Creation-Date: 2023-12-10 12:10+0100 " +"POT-Creation-Date: 2023-12-23 09:14+0100 " "PO-Revision-Date: 2023-12-19 10:08+0200 " "Last-Translator: Martin Srebotnjak " "Language-Team: sl.libreoffice.org " -"Language: sl " "MIME-Version: 1.0 " "Content-Type: text/plain; charset=UTF-8 " "Content-Transfer-Encoding: 8bit " +"Language: sl " "Plural-Forms: nplurals=4; plural=(n%100==1 ? 0 : n%100==2 ? 1 : n%100==3 || n%100==4 ? 2 : 3); " "X-Generator: Virtaal 0.7.1 " "X-Accelerator-Marker: ~ " @@ -13491,27 +13491,27 @@ msgctxt "optonlineupdatepage|privacy" msgid "Privacy Policy" msgstr "Politika zasebnosti" -#: cui/uiconfig/ui/optonlineupdatepage.ui:529 +#: cui/uiconfig/ui/optonlineupdatepage.ui:528 msgctxt "optonlineupdatepage|enableMar" msgid "Enable au_tomatic update" msgstr "Omogoči _samodejno posodabljanje" -#: cui/uiconfig/ui/optonlineupdatepage.ui:538 +#: cui/uiconfig/ui/optonlineupdatepage.ui:537 msgctxt "extended_tip|enableMar" msgid "Mark to enable automatic update." msgstr "Potrdite, da omogočite samodejno posodabljanje." -#: cui/uiconfig/ui/optonlineupdatepage.ui:547 +#: cui/uiconfig/ui/optonlineupdatepage.ui:546 msgctxt "optonlineupdatepage|labelMar" msgid "Automatic Update" msgstr "Samodejna posodobitev" -#: cui/uiconfig/ui/optonlineupdatepage.ui:561 +#: cui/uiconfig/ui/optonlineupdatepage.ui:565 msgctxt "optonlineupdatepage|label1" msgid "Online Update Options" msgstr "Možnosti spletne posodobitve" -#: cui/uiconfig/ui/optonlineupdatepage.ui:569 +#: cui/uiconfig/ui/optonlineupdatepage.ui:573 msgctxt "extended_tip|OptOnlineUpdatePage" msgid "Specifies
[Bug 146053] Output to HTML: wrong use of p tags results in useless border
https://bugs.documentfoundation.org/show_bug.cgi?id=146053 --- Comment #3 from achim --- Quick test with 7.6.4.1 bugs still exist Cheers Achim Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.utf8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #20 from LOO Debugger --- Created attachment 191650 --> https://bugs.documentfoundation.org/attachment.cgi?id=191650=edit APSO install attempt failure message -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #19 from LOO Debugger --- Created attachment 191649 --> https://bugs.documentfoundation.org/attachment.cgi?id=191649=edit Trace dumped displayed on CLI after failed attempt to install APSO -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #18 from LOO Debugger --- Additional information: Reading: https://superuser.com/questions/1753373/libre-office-create-is-not-enabled-for-python-macro I tried to install APSO: https://extensions.libreoffice.org/en/extensions/show/apso-alternative-script-organizer-for-python And got this error message in attached picture. And now when I open libreoffice, I get the generic GUI proposing to create a Writer/Calc/... document. But whatever I do there (trying to open a Wirter doc or to open the Tools>Extensions menu), now LOo crashes!!! cf. new trace in attachment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 --- Comment #17 from LOO Debugger --- :( Thanks anyway for your time & help! -- You are receiving this mail because: You are the assignee for the bug.
core.git: starmath/source
starmath/source/mathml/iterator.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 5b93f1f7cbbec881d13e573a5901a5d353e0dd54
Author: Arnaud VERSINI
AuthorDate: Thu Dec 28 15:35:33 2023 +0100
Commit: Arnaud Versini
CommitDate: Sat Dec 30 15:26:05 2023 +0100
starmath : remove useless delete indirection
Change-Id: Ib308ce7735bdd1dea8611b08a8b73dd2686ca0d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161387
Tested-by: Jenkins
Reviewed-by: Noel Grandin
Reviewed-by: Arnaud Versini
diff --git a/starmath/source/mathml/iterator.cxx
b/starmath/source/mathml/iterator.cxx
index 24de35c18323..fa19f11b019b 100644
--- a/starmath/source/mathml/iterator.cxx
+++ b/starmath/source/mathml/iterator.cxx
@@ -16,8 +16,6 @@
namespace mathml
{
-static inline void deleteElement(SmMlElement* aSmMlElement, void*) { delete
aSmMlElement; }
-
static inline void cloneElement(SmMlElement* aSmMlElement, void* aData)
{
// Prepare data
@@ -58,7 +56,7 @@ void SmMlIteratorFree(SmMlElement* pMlElementTree)
{
SmMlIteratorFree(pMlElementTree->getSubElement(i));
}
-deleteElement(pMlElementTree, nullptr);
+delete pMlElementTree;
}
SmMlElement* SmMlIteratorCopy(SmMlElement* pMlElementTree)
core.git: sc/inc sc/source
sc/inc/column.hxx | 37 +-
sc/inc/table.hxx | 35 +
sc/source/core/data/column.cxx | 84 -
sc/source/core/data/table2.cxx | 68 -
4 files changed, 81 insertions(+), 143 deletions(-)
New commits:
commit 7e5a345897e633083ce0194a34c4faac54d28371
Author: Mike Kaganski
AuthorDate: Sat Dec 30 18:08:56 2023 +0600
Commit: Mike Kaganski
CommitDate: Sat Dec 30 14:43:38 2023 +0100
tdf#158254: generalize and use algorithm to apply with allocation
Commit 17bcf1073bf21088b9845e36fe735622d8f88fd7 (introduce ScColumnData
for ScColumn/ScTable code sharing, 2022-05-05) implemented an algorithm
to only allocate needed amount of columns, and/or apply to default data
when needed. It was done for ApplySelectionCache, ChangeSelectionIndent,
ClearSelectionItems. Yet, many other functions need the same approach.
This change introduces ScTable::ApplyWithAllocation template, which
allows to use this algorithm uniformly to any operation on a selection,
which ultimately applies to ScColumnData. The code in the functions
mentioned above is replaced with its use; and ApplySelectionStyle is
fixed using it.
Change-Id: Ic8890d9980fcb01b61bb83b355c623f866a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161441
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 87273f0f83ba..0e07ed8142b0 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -145,8 +145,9 @@ public:
const ScPatternAttr*GetPattern( SCROW nRow ) const;
const ScPatternAttr*GetMostUsedPattern( SCROW nStartRow, SCROW nEndRow
) const;
-SCROW ApplySelectionCache( ScItemPoolCache& rCache, const
ScMarkData& rMark, ScEditDataArray* pDataArray, bool* const pIsChanged,
- SCCOL nCol );
+voidApplySelectionStyle(const ScStyleSheet& rStyle, SCROW nTop,
SCROW nBottom);
+voidApplySelectionCache(ScItemPoolCache& rCache, SCROW nStartRow,
SCROW nEndRow,
+ScEditDataArray* pDataArray, bool*
pIsChanged);
voidApplyPatternArea( SCROW nStartRow, SCROW nEndRow, const
ScPatternAttr& rPatAttr,
ScEditDataArray* pDataArray = nullptr,
bool* const pIsChanged = nullptr);
@@ -168,12 +169,17 @@ public:
boolIsAllAttrEqual( const ScColumnData& rCol, SCROW nStartRow,
SCROW nEndRow ) const;
-voidClearSelectionItems( const sal_uInt16* pWhich, const
ScMarkData& rMark, SCCOL nCol );
-voidChangeSelectionIndent( bool bIncrement, const ScMarkData&
rMark, SCCOL nCol );
+voidClearSelectionItems(const sal_uInt16* pWhich, SCROW nStartRow,
SCROW nEndRow);
+voidChangeSelectionIndent(bool bIncrement, SCROW nStartRow, SCROW
nEndRow);
boolTestInsertRow( SCSIZE nSize ) const;
voidInsertRow( SCROW nStartRow, SCSIZE nSize );
voidDeleteRow( SCROW nStartRow, SCSIZE nSize );
+
+// Applies a function to the selected ranges.
+// The function looks like
+// ApplyDataFunc(ScColumnData& applyTo, SCROW nTop, SCROW nBottom)
+template void Apply(const ScMarkData&, SCCOL,
ApplyDataFunc);
};
// Use protected inheritance to prevent publishing some internal ScColumnData
@@ -549,7 +555,6 @@ public:
const ScPatternAttr& rPattern, SvNumFormatType
nNewType );
voidApplyStyle( SCROW nRow, const ScStyleSheet* rStyle );
-voidApplySelectionStyle(const ScStyleSheet& rStyle, const
ScMarkData& rMark);
voidApplySelectionLineStyle( const ScMarkData& rMark,
const ::editeng::SvxBorderLine* pLine,
bool bColorOnly );
voidAddCondFormat(SCROW nStartRow, SCROW nEndRow, sal_uInt32
nIndex );
@@ -576,12 +581,8 @@ public:
voidRemoveProtected( SCROW nStartRow, SCROW nEndRow );
-SCROW ApplySelectionCache( ScItemPoolCache& rCache, const
ScMarkData& rMark, ScEditDataArray* pDataArray, bool* const pIsChanged );
void DeleteSelection( InsertDeleteFlags nDelFlag, const ScMarkData& rMark,
bool bBroadcast );
-voidClearSelectionItems( const sal_uInt16* pWhich, const
ScMarkData& rMark );
-voidChangeSelectionIndent( bool bIncrement, const ScMarkData&
rMark );
-
tools::Long GetNeededSize(
SCROW nRow, OutputDevice* pDev, double nPPTX, double nPPTY,
const Fraction& rZoomX, const Fraction& rZoomY,
@@ -1067,4 +1068,22 @@ inline void ScColumnData::DeleteRow(SCROW nStartRow,
SCSIZE nSize)
pAttrArray->DeleteRow( nStartRow, nSize );
}
+template
+void ScColumnData::Apply(const ScMarkData& rMark, SCCOL nCol, ApplyDataFunc
apply)
+{
+if
[Bug 158550] [META] Regressions from "reduce Calc's INITIALCOLCOUNT to 1"
https://bugs.documentfoundation.org/show_bug.cgi?id=158550 Bug 158550 depends on bug 158254, which changed state. Bug 158254 Summary: Can not apply any cell styles to the right of area with content https://bugs.documentfoundation.org/show_bug.cgi?id=158254 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107332] [META] Calc cell and page styles bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107332 Bug 107332 depends on bug 158254, which changed state. Bug 158254 Summary: Can not apply any cell styles to the right of area with content https://bugs.documentfoundation.org/show_bug.cgi?id=158254 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158931] Display of SVG images containing the text-anchor="end" attribute and subscript text
https://bugs.documentfoundation.org/show_bug.cgi?id=158931 --- Comment #1 from dattero2...@live.it --- Created attachment 191648 --> https://bugs.documentfoundation.org/attachment.cgi?id=191648=edit Example of image that causes the behaviour -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158931] New: Display of SVG images containing the text-anchor="end" attribute and subscript text
https://bugs.documentfoundation.org/show_bug.cgi?id=158931 Bug ID: 158931 Summary: Display of SVG images containing the text-anchor="end" attribute and subscript text Product: LibreOffice Version: 7.4.7.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: dattero2...@live.it Description: Any Libreoffice application fails to properly display inserted SVG images if they contain subscript text (attribute dy="-4.80px" of "tspan" tag) and are aligned to the right (text-anchor="end"). In particular, that text is displayed in a wrong position. Other applications (web browsers, Inkscape, Ristretto image viewer, etc.) display the image properly. In my case, the image was generated using SVG terminal of gnuplot (using the command set label "text_with subscript" right). Even in the exported PDF files, the problem is still there. Steps to Reproduce: 1.Open any Libreoffice application (e.g. Writer) 2.Import an SVG image with the described characteristics 3. (optional) export as PDF Actual Results: Image not displayed properly Expected Results: The image should have been displayed as in a web browser or any other image viewer Reproducible: Always User Profile Reset: No Additional Info: Version: 7.4.7.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-GB Debian package version: 4:7.4.7-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157110] Endnotes -- export endnotes, "send endnotes to clipboard", "select all endnotes"...
https://bugs.documentfoundation.org/show_bug.cgi?id=157110 --- Comment #3 from peter josvai --- PS: "Extracting the endnotes" out of a document is NOT that difficult in the end... One: "brute force" way is to print the file to PDF, starting at the first endnote page... then copy paste... Two: copy pasting it into tinymce actually gives you pretty good results... That brown fox example will produce the following: // HTML CODE: ifox: that animal we all know iito grab: take, catch, snatch // HTML CODE end The div ids make it easily parseable... /\/\/\/\/\/\/\/\ PS: But why is it necessary at all to get the endnotes "out" of a book? :) Because (for various reasons) endnotes of a paper book should be published online... not printed in the book itself... Even the endnotes of an ebook can be way better accessed and browsed if they are published online... in a web page... as HTML5 .. -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/inc editeng/source
editeng/inc/EditLineList.hxx | 53 +++---
editeng/inc/editdoc.hxx|1
editeng/source/editeng/editdoc.cxx | 64 -
3 files changed, 41 insertions(+), 77 deletions(-)
New commits:
commit 020444ed98d7a31403787238cd753e112a6a56fb
Author: Tomaž Vajngerl
AuthorDate: Mon Dec 25 00:06:07 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Dec 30 14:17:16 2023 +0100
editeng: move EditLineList methods definition into header
Class is simple enough and more or less just wraps the vector
anyway.
Change-Id: I65a2980e8dd3c70b87e617920db623782d43b1b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161361
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/inc/EditLineList.hxx b/editeng/inc/EditLineList.hxx
index 2b3874913cad..a3a547d7ce24 100644
--- a/editeng/inc/EditLineList.hxx
+++ b/editeng/inc/EditLineList.hxx
@@ -19,8 +19,12 @@
#pragma once
+#include "EditLine.hxx"
+
+#include
#include
#include
+#include
class EditLineList
{
@@ -28,18 +32,43 @@ class EditLineList
LinesType maLines;
public:
-EditLineList();
-~EditLineList();
-
-void Reset();
-void DeleteFromLine(sal_Int32 nDelFrom);
-sal_Int32 FindLine(sal_Int32 nChar, bool bInclEnd);
-sal_Int32 Count() const;
-const EditLine& operator[](sal_Int32 nPos) const;
-EditLine& operator[](sal_Int32 nPos);
-
-void Append(EditLine* p);
-void Insert(sal_Int32 nPos, EditLine* p);
+EditLineList() = default;
+
+void Reset() { maLines.clear(); }
+
+void DeleteFromLine(sal_Int32 nDelFrom)
+{
+assert(nDelFrom <= (static_cast(maLines.size()) - 1));
+LinesType::iterator it = maLines.begin();
+std::advance(it, nDelFrom);
+maLines.erase(it, maLines.end());
+}
+
+sal_Int32 FindLine(sal_Int32 nChar, bool bInclEnd)
+{
+sal_Int32 n = maLines.size();
+for (sal_Int32 i = 0; i < n; ++i)
+{
+const EditLine& rLine = *maLines[i];
+if ((bInclEnd && (rLine.GetEnd() >= nChar)) || (rLine.GetEnd() >
nChar))
+{
+return i;
+}
+}
+
+DBG_ASSERT(!bInclEnd, "Line not found: FindLine");
+return n - 1;
+}
+
+sal_Int32 Count() const { return maLines.size(); }
+const EditLine& operator[](sal_Int32 nPos) const { return *maLines[nPos]; }
+EditLine& operator[](sal_Int32 nPos) { return *maLines[nPos]; }
+
+void Append(EditLine* p) {
maLines.push_back(std::unique_ptr(p)); }
+void Insert(sal_Int32 nPos, EditLine* p)
+{
+maLines.insert(maLines.begin() + nPos, std::unique_ptr(p));
+}
};
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx
index 3db8a8a64a63..e400a3b42e4a 100644
--- a/editeng/inc/editdoc.hxx
+++ b/editeng/inc/editdoc.hxx
@@ -33,7 +33,6 @@
#include "TextPortion.hxx"
#include "ItemList.hxx"
#include "ContentNode.hxx"
-#include "EditLine.hxx"
#include "EditLineList.hxx"
#include
diff --git a/editeng/source/editeng/editdoc.cxx
b/editeng/source/editeng/editdoc.cxx
index e37bc47a7fa3..153cc25dfc1f 100644
--- a/editeng/source/editeng/editdoc.cxx
+++ b/editeng/source/editeng/editdoc.cxx
@@ -890,70 +890,6 @@ void ConvertAndPutItems( SfxItemSet& rDest, const
SfxItemSet& rSource, const Map
}
}
-EditLineList::EditLineList()
-{
-}
-
-EditLineList::~EditLineList()
-{
-Reset();
-}
-
-void EditLineList::Reset()
-{
-maLines.clear();
-}
-
-void EditLineList::DeleteFromLine(sal_Int32 nDelFrom)
-{
-assert(nDelFrom <= (static_cast(maLines.size()) - 1));
-LinesType::iterator it = maLines.begin();
-std::advance(it, nDelFrom);
-maLines.erase(it, maLines.end());
-}
-
-sal_Int32 EditLineList::FindLine(sal_Int32 nChar, bool bInclEnd)
-{
-sal_Int32 n = maLines.size();
-for (sal_Int32 i = 0; i < n; ++i)
-{
-const EditLine& rLine = *maLines[i];
-if ( (bInclEnd && (rLine.GetEnd() >= nChar)) ||
- (rLine.GetEnd() > nChar) )
-{
-return i;
-}
-}
-
-DBG_ASSERT( !bInclEnd, "Line not found: FindLine" );
-return n - 1;
-}
-
-sal_Int32 EditLineList::Count() const
-{
-return maLines.size();
-}
-
-const EditLine& EditLineList::operator[](sal_Int32 nPos) const
-{
-return *maLines[nPos];
-}
-
-EditLine& EditLineList::operator[](sal_Int32 nPos)
-{
-return *maLines[nPos];
-}
-
-void EditLineList::Append(EditLine* p)
-{
-maLines.push_back(std::unique_ptr(p));
-}
-
-void EditLineList::Insert(sal_Int32 nPos, EditLine* p)
-{
-maLines.insert(maLines.begin()+nPos, std::unique_ptr(p));
-}
-
EditPaM::EditPaM() : pNode(nullptr), nIndex(0) {}
EditPaM::EditPaM(ContentNode* p, sal_Int32 n) : pNode(p), nIndex(n) {}
core.git: 2 commits - editeng/inc editeng/Library_editeng.mk editeng/source solenv/clang-format
editeng/Library_editeng.mk |1
editeng/inc/EditLine.hxx|4 +
editeng/inc/EditLineList.hxx| 45 ++
editeng/inc/editdoc.hxx | 23 -
editeng/source/editeng/EditLine.cxx | 90
editeng/source/editeng/editdoc.cxx | 66 --
solenv/clang-format/excludelist |1
7 files changed, 142 insertions(+), 88 deletions(-)
New commits:
commit 4acb0979b10bf35cf929078e53ea249e1416
Author: Tomaž Vajngerl
AuthorDate: Sun Dec 24 23:55:58 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Dec 30 14:17:08 2023 +0100
editeng: move EditLineList to its own header file
Change-Id: Ic19aa0826050a768e9976d8d3db9eadb108607f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161360
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/inc/EditLineList.hxx b/editeng/inc/EditLineList.hxx
new file mode 100644
index ..2b3874913cad
--- /dev/null
+++ b/editeng/inc/EditLineList.hxx
@@ -0,0 +1,45 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the "License"); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#pragma once
+
+#include
+#include
+
+class EditLineList
+{
+typedef std::vector> LinesType;
+LinesType maLines;
+
+public:
+EditLineList();
+~EditLineList();
+
+void Reset();
+void DeleteFromLine(sal_Int32 nDelFrom);
+sal_Int32 FindLine(sal_Int32 nChar, bool bInclEnd);
+sal_Int32 Count() const;
+const EditLine& operator[](sal_Int32 nPos) const;
+EditLine& operator[](sal_Int32 nPos);
+
+void Append(EditLine* p);
+void Insert(sal_Int32 nPos, EditLine* p);
+};
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx
index c53abc62949c..3db8a8a64a63 100644
--- a/editeng/inc/editdoc.hxx
+++ b/editeng/inc/editdoc.hxx
@@ -34,6 +34,7 @@
#include "ItemList.hxx"
#include "ContentNode.hxx"
#include "EditLine.hxx"
+#include "EditLineList.hxx"
#include
#include
@@ -159,28 +160,6 @@ public:
sal_Int32 GetPos(const TextPortion* p) const;
};
-class EditLineList
-{
-typedef std::vector > LinesType;
-LinesType maLines;
-
-public:
-EditLineList();
-~EditLineList();
-
-void Reset();
-void DeleteFromLine(sal_Int32 nDelFrom);
-sal_Int32 FindLine(sal_Int32 nChar, bool bInclEnd);
-sal_Int32 Count() const;
-const EditLine& operator[](sal_Int32 nPos) const;
-EditLine& operator[](sal_Int32 nPos);
-
-void Append(EditLine* p);
-void Insert(sal_Int32 nPos, EditLine* p);
-};
-
-
-
class ParaPortion
{
friend class ImpEditEngine; // to adjust the height
commit 9a62dcf59af3513a82fb5640314021d064d8b9b7
Author: Tomaž Vajngerl
AuthorDate: Sun Dec 24 22:45:54 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Dec 30 14:16:59 2023 +0100
editeng: move impl. of EditLine methods to own cxx sourcefile
Change-Id: I9856302967de59368dc60b3e01f4a36fdb97e00e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161359
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/Library_editeng.mk b/editeng/Library_editeng.mk
index e0834b96f983..49225b910d14 100644
--- a/editeng/Library_editeng.mk
+++ b/editeng/Library_editeng.mk
@@ -56,6 +56,7 @@ $(eval $(call gb_Library_add_exception_objects,editeng,\
editeng/source/editeng/editdbg \
editeng/source/editeng/editdoc \
editeng/source/editeng/editeng \
+editeng/source/editeng/EditLine \
editeng/source/editeng/editobj \
editeng/source/editeng/editsel \
editeng/source/editeng/editundo \
diff --git a/editeng/inc/EditLine.hxx b/editeng/inc/EditLine.hxx
index df1dec9f0ae2..165f3fcf0a59 100644
--- a/editeng/inc/EditLine.hxx
+++ b/editeng/inc/EditLine.hxx
@@ -19,6 +19,10 @@
#pragma once
+#include
+#include
+#include
+
class ParaPortion;
class EditLine
diff --git a/editeng/source/editeng/EditLine.cxx
b/editeng/source/editeng/EditLine.cxx
new file mode 100644
index ..7724f8f12a79
--- /dev/null
+++ b/editeng/source/editeng/EditLine.cxx
@@
core.git: editeng/CppunitTest_editeng_core.mk editeng/inc editeng/qa editeng/source
editeng/CppunitTest_editeng_core.mk |1
editeng/inc/EditLine.hxx| 58 +-
editeng/qa/unit/EditLineTest.cxx| 111
editeng/source/editeng/editdoc.cxx | 63
4 files changed, 154 insertions(+), 79 deletions(-)
New commits:
commit 72fde57386eb7b53f4b1a0954a1595e36cf17e5f
Author: Tomaž Vajngerl
AuthorDate: Sun Dec 24 22:34:40 2023 +0900
Commit: Tomaž Vajngerl
CommitDate: Sat Dec 30 14:16:43 2023 +0100
editeng: EditLine test and refactor constructors, operators
Change-Id: Ia60ce07073725bf66bf299edaf7b3cd24cfe59c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161358
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
diff --git a/editeng/CppunitTest_editeng_core.mk
b/editeng/CppunitTest_editeng_core.mk
index 43df48cbe38a..d28c7fcb4365 100644
--- a/editeng/CppunitTest_editeng_core.mk
+++ b/editeng/CppunitTest_editeng_core.mk
@@ -15,6 +15,7 @@ $(eval $(call
gb_CppunitTest_add_exception_objects,editeng_core, \
editeng/qa/unit/core-test \
editeng/qa/unit/ESelectionTest \
editeng/qa/unit/EPaMTest \
+editeng/qa/unit/EditLineTest \
))
$(eval $(call gb_CppunitTest_use_library_objects,editeng_core,editeng))
diff --git a/editeng/inc/EditLine.hxx b/editeng/inc/EditLine.hxx
index 2b6bc2a71efb..df1dec9f0ae2 100644
--- a/editeng/inc/EditLine.hxx
+++ b/editeng/inc/EditLine.hxx
@@ -29,22 +29,29 @@ public:
private:
CharPosArrayType aPositions;
std::vector aKashidaPositions;
-sal_Int32 nTxtWidth;
-sal_Int32 nStartPosX;
-sal_Int32 nStart; // could be replaced by nStartPortion
-sal_Int32 nEnd; // could be replaced by nEndPortion
-sal_Int32 nStartPortion;
-sal_Int32 nEndPortion;
-sal_uInt16 nHeight; // Total height of the line
-sal_uInt16 nTxtHeight; // Pure Text height
-sal_uInt16 nMaxAscent;
-bool bHangingPunctuation : 1;
-bool bInvalid : 1; // for skillful formatting
+sal_Int32 nTxtWidth = 0;
+sal_Int32 nStartPosX = 0;
+sal_Int32 nStart = 0; // could be replaced by nStartPortion
+sal_Int32 nEnd = 0; // could be replaced by nEndPortion
+sal_Int32 nStartPortion = 0;
+sal_Int32 nEndPortion = 0;
+sal_uInt16 nHeight = 0; // Total height of the line
+sal_uInt16 nTxtHeight = 0; // Pure Text height
+sal_uInt16 nMaxAscent = 0;
+bool bHangingPunctuation : 1 = false;
+bool bInvalid : 1 = true; // for skillful formatting
public:
-EditLine();
-EditLine(const EditLine&);
-~EditLine();
+EditLine() = default;
+EditLine(const EditLine& rEditLine)
+: nStart(rEditLine.nStart)
+, nEnd(rEditLine.nEnd)
+, nStartPortion(rEditLine.nStartPortion)
+, nEndPortion(rEditLine.nEndPortion)
+, bHangingPunctuation(rEditLine.bHangingPunctuation)
+, bInvalid(true)
+{
+}
bool IsIn(sal_Int32 nIndex) const { return ((nIndex >= nStart) && (nIndex
< nEnd)); }
@@ -103,8 +110,27 @@ public:
EditLine* Clone() const;
-EditLine& operator=(const EditLine& rLine);
-friend bool operator==(const EditLine& r1, const EditLine& r2);
+EditLine& operator=(const EditLine& rLine)
+{
+nEnd = rLine.nEnd;
+nStart = rLine.nStart;
+nEndPortion = rLine.nEndPortion;
+nStartPortion = rLine.nStartPortion;
+return *this;
+}
+
+bool operator==(const EditLine& rLine) const
+{
+return nStart == rLine.nStart && nEnd == rLine.nEnd && nStartPortion
== rLine.nStartPortion
+ && nEndPortion == rLine.nEndPortion;
+}
};
+template
+inline std::basic_ostream& operator<<(std::basic_ostream& stream,
+ EditLine const& rLine)
+{
+return stream << "EditLine(" << rLine.GetStart() << ", " << rLine.GetEnd()
<< ")";
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/editeng/qa/unit/EditLineTest.cxx b/editeng/qa/unit/EditLineTest.cxx
new file mode 100644
index ..6991ba67755c
--- /dev/null
+++ b/editeng/qa/unit/EditLineTest.cxx
@@ -0,0 +1,111 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include
+
+namespace
+{
+class EditLineTest : public test::BootstrapFixture
+{
+};
+
+CPPUNIT_TEST_FIXTURE(EditLineTest, testConstruction)
+{
+EditLine aNew;
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aNew.GetStart());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aNew.GetEnd());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aNew.GetStartPortion());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(0), aNew.GetEndPortion());
+CPPUNIT_ASSERT_EQUAL(sal_uInt16(0), aNew.GetMaxAscent());
+
[Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Aron Budea changed: What|Removed |Added Depends on||158317 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158317 [Bug 158317] void SfxItemPool::unregisterSfxPoolItem(const SfxPoolItem &): Assertion `nullptr != ppRegisteredSfxPoolItems' failed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 Aron Budea changed: What|Removed |Added Depends on|158317 | Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158317 [Bug 158317] void SfxItemPool::unregisterSfxPoolItem(const SfxPoolItem &): Assertion `nullptr != ppRegisteredSfxPoolItems' failed. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158903] LibreCalc cut and browser bug Version: 7.4.7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=158903 i...@disroot.org changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|NOTABUG |--- --- Comment #3 from i...@disroot.org --- (In reply to m.a.riosv from comment #2) > It is not possible, that kind of selection. then how to work with massive data tables? it works well in Microsoft Excel, so why can not in LibreCalc too? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 153527] LibreOffice 7.5 Calc: unable to apply formatting to all cells in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=153527 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #35 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/161442 -- You are receiving this mail because: You are the assignee for the bug.
core.git: forms/source include/tools tools/source
forms/source/component/DatabaseForm.cxx |6 +++---
include/tools/inetmsg.hxx |6 +++---
tools/source/inet/inetstrm.cxx |5 +
3 files changed, 7 insertions(+), 10 deletions(-)
New commits:
commit 7de4661827c5bed7beaf2c286242e48cfe4154e8
Author: Noel Grandin
AuthorDate: Sat Dec 30 09:49:57 2023 +0200
Commit: Noel Grandin
CommitDate: Sat Dec 30 13:45:53 2023 +0100
no need to use SvLockBytes in forms
Change-Id: Ide586997d504e0fbdb72aa1db77c49ba3d6007c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161437
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/forms/source/component/DatabaseForm.cxx
b/forms/source/component/DatabaseForm.cxx
index 0d6aafaaa5cf..4bad0608b5bc 100644
--- a/forms/source/component/DatabaseForm.cxx
+++ b/forms/source/component/DatabaseForm.cxx
@@ -938,11 +938,11 @@ void ODatabaseForm::InsertTextPart( INetMIMEMessage&
rParent, std::u16string_vie
pChild->SetContentTransferEncoding("8bit");
// Body
-SvMemoryStream* pStream = new SvMemoryStream;
+std::unique_ptr pStream(new SvMemoryStream);
pStream->WriteLine( OUStringToOString(rData,
rtl_getTextEncodingFromMimeCharset(pBestMatchingEncoding)) );
pStream->FlushBuffer();
pStream->Seek( 0 );
-pChild->SetDocumentLB( new SvLockBytes(pStream, true) );
+pChild->SetDocumentLB( std::move(pStream) );
rParent.AttachChild( std::move(pChild) );
}
@@ -1001,7 +1001,7 @@ void ODatabaseForm::InsertFilePart( INetMIMEMessage&
rParent, std::u16string_vie
// Body
-pChild->SetDocumentLB( new SvLockBytes(pStream.release(), true) );
+pChild->SetDocumentLB( std::move(pStream) );
rParent.AttachChild( std::move(pChild) );
}
diff --git a/include/tools/inetmsg.hxx b/include/tools/inetmsg.hxx
index 8617b0b91bf1..8171da95d1af 100644
--- a/include/tools/inetmsg.hxx
+++ b/include/tools/inetmsg.hxx
@@ -77,7 +77,7 @@ class SAL_WARN_UNUSED UNLESS_MERGELIBS(TOOLS_DLLPUBLIC)
INetMIMEMessage
::std::vector< std::unique_ptr >
m_aHeaderList;
-SvLockBytesRef m_xDocLB;
+std::unique_ptr m_xDocLB;
::std::map m_nMIMEIndex;
INetMIMEMessage* pParent;
@@ -139,8 +139,8 @@ public:
}
}
-SvLockBytes* GetDocumentLB() const { return m_xDocLB.get(); }
-void SetDocumentLB (SvLockBytes *pDocLB) { m_xDocLB = pDocLB; }
+SvStream* GetDocumentLB() const { return m_xDocLB.get(); }
+void SetDocumentLB (std::unique_ptr pDocLB) { m_xDocLB =
std::move(pDocLB); }
static bool ParseDateField (
std::u16string_view rDateField, DateTime& rDateTime);
diff --git a/tools/source/inet/inetstrm.cxx b/tools/source/inet/inetstrm.cxx
index ac33f5eda4a3..f4a841da9331 100644
--- a/tools/source/inet/inetstrm.cxx
+++ b/tools/source/inet/inetstrm.cxx
@@ -75,10 +75,7 @@ int INetMIMEMessageStream::GetBodyLine(char* pData,
sal_uInt32 nSize)
if (pSourceMsg->GetDocumentLB())
{
-if (pMsgStrm == nullptr)
-pMsgStrm.reset(new SvStream (pSourceMsg->GetDocumentLB()));
-
-sal_uInt32 nRead = pMsgStrm->ReadBytes(pWBuf, (pWEnd - pWBuf));
+sal_uInt32 nRead = pSourceMsg->GetDocumentLB()->ReadBytes(pWBuf,
(pWEnd - pWBuf));
pWBuf += nRead;
}
[Bug 97991] Reducing the size of the Windows Installer
https://bugs.documentfoundation.org/show_bug.cgi?id=97991 Bug 97991 depends on bug 158930, which changed state. Bug 158930 Summary: the main MSI archive for x86-64 contains 32 bits binaries https://bugs.documentfoundation.org/show_bug.cgi?id=158930 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158930] the main MSI archive for x86-64 contains 32 bits binaries
https://bugs.documentfoundation.org/show_bug.cgi?id=158930 Mike Kaganski changed: What|Removed |Added Resolution|--- |NOTABUG Status|UNCONFIRMED |RESOLVED --- Comment #1 from Mike Kaganski --- Absolutely not a bug. We must provide binaries for 32-bit subsystem, because otherwise 32-bit apps running on 64-bit system won't be able to access the functionality (property pages, thumbnail preview, etc.) that needs loading of respective COM DLLs into the process. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157110] Endnotes -- export endnotes, "send endnotes to clipboard", "select all endnotes"...
https://bugs.documentfoundation.org/show_bug.cgi?id=157110 Dieter changed: What|Removed |Added Ever confirmed|1 |0 Status|REOPENED|UNCONFIRMED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 153527] LibreOffice 7.5 Calc: unable to apply formatting to all cells in spreadsheet
https://bugs.documentfoundation.org/show_bug.cgi?id=153527 Mike Kaganski changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8254 --- Comment #34 from Mike Kaganski --- Relevant commit is 17bcf1073bf21088b9845e36fe735622d8f88fd7. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158508] Impress FILEOPEN. Missing images from PPTX file exported from Google Slides
https://bugs.documentfoundation.org/show_bug.cgi?id=158508 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #9 from raal --- No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158254] Can not apply any cell styles to the right of area with content
https://bugs.documentfoundation.org/show_bug.cgi?id=158254 Mike Kaganski changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #8 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/161441 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 138153] Image off page after changing anchor to 'to character' inside a caption frame (and undo doesn't solve it)
https://bugs.documentfoundation.org/show_bug.cgi?id=138153 --- Comment #7 from sdc.bla...@youmail.dk --- Created attachment 191647 --> https://bugs.documentfoundation.org/attachment.cgi?id=191647=edit simpler document with critical image and caption frame @Telesto, is it possible that this ticket is a false alarm? Reasons: 1. I tried to prepare a simpler test file, starting from scratch with an image in a frame, like your case and could not reproduce the problem. 2. Copied image from original attachment to a new document, added caption (and therefore frame), but could not reproduce the problem. 3. Copied frame (on the second page of original attachment) to new document. (see new attachment here) (and repro with this new document), but then copy and paste the image into the document, add a caption frame, and cannot repro. I tried to look at the xml, and could not see an obvious problem, but I am not an expert in reading/interpreting XML. Anyway -- I suspect this "bug" (?) is because of some defect in the actual test case, and not in LO. If you cannot make a new reproducible case, maybe you should close this ticket as INVALID? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158905] Base Form Wizard not working.
https://bugs.documentfoundation.org/show_bug.cgi?id=158905 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #2 from Robert Großkopf --- Might be a special bug of Ubuntu packed version. Tested this with LO 7.3.6.2 here on OpenSuSE with original packages from LO - form has been created without problems. Same result with LO 7.6.4.1. - no problem. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158929] LibreOffice Disapperaed
https://bugs.documentfoundation.org/show_bug.cgi?id=158929 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal --- Hello, this probably belongs to Ask https://ask.libreoffice.org/c/english/5 You can download and install LO from https://www.libreoffice.org/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157110] Endnotes -- export endnotes, "send endnotes to clipboard", "select all endnotes"...
https://bugs.documentfoundation.org/show_bug.cgi?id=157110 peter josvai changed: What|Removed |Added Status|NEEDINFO|REOPENED --- Comment #2 from peter josvai --- hi, Dieter! By "export" I mean "create an ODT / HTML / TXT pasteable document of" the endnotes... As if saying: "Copy endnotes", which you could then paste... Creating a document of the endnotes would be almost the same thing. Just like in the case of "send outline to clipboard"... it can be pasted into an ODT document... FOR EXAMPLE: Imagine "The brown fox* was pretty quick at grabbing* the chickens." and imagine numbers instead of the * ... and the consequent entries in the endnote section: 1. fox: that animal we all know 2. to grab: take, catch, snatch Now, right click in the endnote section / or go "File / Send / "Send endnote to clipboard"... and the endnotes could be pasted in a new document : 1. fox: that animal we all know 2. to grab: take, catch, snatch /\/\/\/\/\/\/\ explanation: It is next to impossible to get the endnotes "out" of a text.. unless you're willing to deal with roman numerals... AND copy-pasting into an HTML editor like tinymce... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158854] When Opening any Base Report in Linux, I get a Runtime Error: [jni_uno bridge error] UNO calling Java method execute: non-UNO exception occurred: java.lang.NoClassDefFoundError:
https://bugs.documentfoundation.org/show_bug.cgi?id=158854 Robert Großkopf changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #2 from Robert Großkopf --- Seems you are using the version from OpenSUSE, not the version directly packed by Libre Office. What you report is a bug of the packages in OpenSUSE. Also Ubuntu will produce the same buggy behavior. No problem to execute reports with OpenSUSE (15.4) and packages from LibreOffice here. Create a folder for the packages of LO. Download main package, language package and help package. Unzip the packages to get the rpms inside this packes. Move all this rpms to the new created folder. Then open Yast and add this folder as another installation source. Choose all *.rpms inside this folder and install. Many warnings will appear, because Yast misses signing, but you could ignore all this warning. Alternative without using Yast and installing as user: Create a folder "install" in the new folder for the *.rpm-packages. Open Install and start konsole (terminal). Execute for i in ../*.rpm; do rpm2cpio $i | cpio -id; done and you will get the whole installation as normal user. Have installed about 30 different versions of LO this way here for testing. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150686] Macro connected through Tools → Customize → Events → View created leads to error when document is opened again
https://bugs.documentfoundation.org/show_bug.cgi?id=150686 raal changed: What|Removed |Added CC||r...@post.cz --- Comment #3 from raal --- No repro with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 71c28942fbc7f36e5bcd46c5a6cdfbb3fcbcd6a0 CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 118310] Column chart: datetime X values are grouped by date
https://bugs.documentfoundation.org/show_bug.cgi?id=118310 --- Comment #12 from Yauhen Kharuzhy --- Still reproducible with same conditions in 7.6.4.1 -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - canvas/Library_canvasfactory.mk canvas/source comphelper/source connectivity/source drawinglayer/source editeng/source embeddedobj/source emfio/source filter/source framework/sou
canvas/Library_canvasfactory.mk |2 - canvas/source/factory/cf_service.cxx|4 +- comphelper/source/misc/configuration.cxx| 27 +--- connectivity/source/drivers/dbase/DTable.cxx|4 +- connectivity/source/drivers/file/FConnection.cxx|4 +- drawinglayer/source/geometry/viewinformation2d.cxx |5 +- editeng/source/editeng/eertfpar.cxx |4 +- editeng/source/editeng/impedit2.cxx |4 +- editeng/source/editeng/impedit3.cxx |4 +- editeng/source/items/numitem.cxx|4 +- editeng/source/items/textitem.cxx |4 +- editeng/source/rtf/svxrtf.cxx |4 +- embeddedobj/source/commonembedding/persistence.cxx |4 +- emfio/source/reader/emfreader.cxx |4 +- emfio/source/reader/mtftools.cxx| 10 ++--- filter/source/config/cache/filtercache.cxx |2 - filter/source/graphicfilter/icgm/actimpr.cxx|6 +-- filter/source/graphicfilter/icgm/bitmap.cxx |4 +- filter/source/msfilter/msdffimp.cxx |4 +- filter/source/pdf/pdfexport.cxx |2 - framework/source/fwe/helper/titlehelper.cxx |3 + framework/source/jobs/jobexecutor.cxx |4 +- framework/source/services/desktop.cxx |4 +- framework/source/services/modulemanager.cxx |4 +- hwpfilter/source/hwpread.cxx|4 +- hwpfilter/source/hwpreader.cxx |6 +-- i18nutil/source/utility/paper.cxx |2 - include/comphelper/configuration.hxx| 12 +++ include/unotools/configmgr.hxx | 10 - lotuswordpro/source/filter/lwpcelllayout.cxx|4 +- lotuswordpro/source/filter/lwptablelayout.cxx |4 +- sc/qa/unit/datacache.cxx|4 +- sc/qa/unit/ucalc_range.cxx |4 +- sc/source/core/data/documen2.cxx|4 +- sc/source/core/data/documen4.cxx|4 +- sc/source/core/data/documentimport.cxx |6 +-- sc/source/core/data/global2.cxx |4 +- sc/source/core/data/globalx.cxx |4 +- sc/source/core/tool/calcconfig.cxx |6 +-- sc/source/core/tool/compiler.cxx|2 - sc/source/core/tool/optutil.cxx |4 +- sc/source/filter/excel/impop.cxx|4 +- sc/source/filter/excel/read.cxx |4 +- sc/source/filter/excel/xicontent.cxx|6 +-- sc/source/filter/excel/xiescher.cxx |4 +- sc/source/filter/excel/xipage.cxx |4 +- sc/source/filter/excel/xipivot.cxx |4 +- sc/source/filter/excel/xlroot.cxx |4 +- sc/source/filter/lotus/op.cxx |4 +- sc/source/filter/qpro/qpro.cxx |4 +- sc/source/filter/rtf/eeimpars.cxx |2 - sc/source/filter/xml/xmlrowi.cxx|4 +- sc/source/ui/docshell/docsh2.cxx|6 +-- sc/source/ui/docshell/docsh3.cxx|2 - sc/source/ui/docshell/externalrefmgr.cxx|4 +- sc/source/ui/docshell/impex.cxx | 12 +++ sc/source/ui/docshell/tablink.cxx |4 +- sc/source/ui/view/drawvie3.cxx |4 +- sd/source/core/TransitionPreset.cxx |2 - sd/source/core/drawdoc.cxx |6 +-- sd/source/core/drawdoc4.cxx |4 +- sd/source/filter/ppt/pptin.cxx |6 +-- sd/source/ui/app/sddll.cxx | 16 - sd/source/ui/docshell/docshell.cxx |2 - sd/source/ui/view/sdview.cxx|4 +- sfx2/source/appl/app.cxx|4 +- sfx2/source/appl/appbas.cxx |8 ++-- sfx2/source/appl/appinit.cxx|3 + sfx2/source/appl/workwin.cxx|3 + sfx2/source/control/shell.cxx |2 - sfx2/source/doc/docfile.cxx |2 - sfx2/source/doc/objstor.cxx | 12 +++ sfx2/source/doc/objxtor.cxx |5 +- sfx2/source/view/classificationhelper.cxx |2 -
[Bug 158623] a few templates thumbnails could use indexed colours
https://bugs.documentfoundation.org/show_bug.cgi?id=158623 --- Comment #4 from Jérôme --- (In reply to Stéphane Guillou (stragu) from comment #3) > Can you submit a patch for review? Not before a few months. > Do you mean some of them don't have a template associated to them anymore? I mean those wizards may not require a document preview image. Perhaps we could do more than using indexed colour for the preview image : just delete those preview images. The documents could still be used without preview image. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 97991] Reducing the size of the Windows Installer
https://bugs.documentfoundation.org/show_bug.cgi?id=97991 Jérôme changed: What|Removed |Added Depends on||158930 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158930 [Bug 158930] the main MSI archive for x86-64 contains 32 bits binaries -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158930] the main MSI archive for x86-64 contains 32 bits binaries
https://bugs.documentfoundation.org/show_bug.cgi?id=158930 Jérôme changed: What|Removed |Added Blocks||97991 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=97991 [Bug 97991] Reducing the size of the Windows Installer -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158930] New: the main MSI archive for x86-64 contains 32 bits binaries
https://bugs.documentfoundation.org/show_bug.cgi?id=158930
Bug ID: 158930
Summary: the main MSI archive for x86-64 contains 32 bits
binaries
Product: LibreOffice
Version: 24.8.0.0 alpha0+ Master
Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Installation
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: jerome.bo...@laposte.net
Created attachment 191646
--> https://bugs.documentfoundation.org/attachment.cgi?id=191646=edit
result of : find . -iregex '.*\.\(\(dll\)\|\(exe\)\|\(pyd\)\)$' -type f -exec
file {} \; | grep -v x86-64
The nightly build LibreOfficeDev_24.8.0.0.alpha0_Win_x86-64.msi for x86-64
contains 32 bit binaries.
The total installed size is 3,6 MB.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 90858] Shape doesnt return to original position after Undoing anchor
https://bugs.documentfoundation.org/show_bug.cgi?id=90858 sdc.bla...@youmail.dk changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=90 | |933 | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90933] EDITING: Moving an image or object positioned to "entire page" (and anchored "to paragraph" or "to character") changes the position setting to "entire paragraph area"
https://bugs.documentfoundation.org/show_bug.cgi?id=90933 sdc.bla...@youmail.dk changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=90 | |858 | -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90933] EDITING: Moving an image or object positioned to "entire page" (and anchored "to paragraph" or "to character") changes the position setting to "entire paragraph area"
https://bugs.documentfoundation.org/show_bug.cgi?id=90933 sdc.bla...@youmail.dk changed: What|Removed |Added Summary|EDITING: Moving an image or |EDITING: Moving an image or |object changes positions|object positioned to |relative to settings|"entire page" (and anchored ||"to paragraph" or "to ||character") changes the ||position setting to "entire ||paragraph area" --- Comment #14 from sdc.bla...@youmail.dk --- repro (where "paragraph area" and "margin" are now both "Entire paragraph area") (otoh, if the anchor is set "to page", then Alt-Left does not change the position settings.) Adjusting bug summary to be more concrete/precise Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/core/text/itrcrsr.cxx | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
New commits:
commit 2c8e9ed3cbe3aed5520ce8f5888dd083f8ee50c3
Author: Mike Kaganski
AuthorDate: Sat Dec 30 15:08:32 2023 +0600
Commit: Mike Kaganski
CommitDate: Sat Dec 30 11:49:10 2023 +0100
Simplify a bit
Change-Id: Ic2fa4c0a1c7424ff2114c494d0c4e06a3f8b1cce
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161439
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx
index 30b605cac011..7a74df60c990 100644
--- a/sw/source/core/text/itrcrsr.cxx
+++ b/sw/source/core/text/itrcrsr.cxx
@@ -82,7 +82,7 @@ static void lcl_GetCharRectInsideField( SwTextSizeInfo& rInf,
SwRect& rOrig,
if ( ! pPor->GetNextPortion() || nFieldIdx + nFieldLen > nCharOfst
)
break;
-nFieldIdx = nFieldIdx + nFieldLen;
+nFieldIdx += nFieldLen;
rOrig.Pos().AdjustX(pPor->Width() );
pPor = pPor->GetNextPortion();
@@ -471,7 +471,7 @@ void SwTextCursor::GetEndCharRect(SwRect* pOrig, const
TextFrameIndex nOfst,
// Search for the last Text/EndPortion of the line
while( pPor )
{
-nX = nX + pPor->Width();
+nX += pPor->Width();
if( pPor->InTextGrp() || ( pPor->GetLen() && !pPor->IsFlyPortion()
&& !pPor->IsHolePortion() ) || pPor->IsBreakPortion() )
{
@@ -1009,7 +1009,7 @@ void SwTextCursor::GetCharRect_( SwRect* pOrig,
TextFrameIndex const nOfst,
while( pNext && !pNext->InFieldGrp() )
{
OSL_ENSURE( !pNext->GetLen(), "Where's my field
follow?" );
-nAddX = nAddX + pNext->Width();
+nAddX += pNext->Width();
pNext = pNext->GetNextPortion();
}
if( !pNext )
@@ -1382,7 +1382,7 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
if ( pPor->InSpaceGrp() && nSpaceAdd )
{
const_cast(GetInfo()).SetIdx( nCurrStart );
-nWidth = nWidth + pPor->CalcSpacing( nSpaceAdd, GetInfo() );
+nWidth += pPor->CalcSpacing( nSpaceAdd, GetInfo() );
}
if( ( pPor->InFixMargGrp() && ! pPor->IsMarginPortion() ) ||
( pPor->IsMultiPortion() &&
static_cast(pPor)->HasTabulator() )
@@ -1416,8 +1416,8 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
while (ConsiderNextPortionForCursorOffset(pPor, nWidth30, nX))
{
-nX = nX - nWidth;
-nCurrStart = nCurrStart + pPor->GetLen();
+nX -= nWidth;
+nCurrStart += pPor->GetLen();
pPor = pPor->GetNextPortion();
nWidth = pPor->Width();
if ( m_pCurr->IsSpaceAdd() || pKanaComp )
@@ -1425,7 +1425,7 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
if ( pPor->InSpaceGrp() && nSpaceAdd )
{
const_cast(GetInfo()).SetIdx( nCurrStart );
-nWidth = nWidth + pPor->CalcSpacing( nSpaceAdd, GetInfo() );
+nWidth += pPor->CalcSpacing( nSpaceAdd, GetInfo() );
}
if( ( pPor->InFixMargGrp() && ! pPor->IsMarginPortion() ) ||
@@ -1467,7 +1467,7 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
SwLinePortion *pNextPor = pPor->GetNextPortion();
while( pNextPor && pNextPor->InFieldGrp() && !pNextPor->Width() )
{
-nCurrStart = nCurrStart + pPor->GetLen();
+nCurrStart += pPor->GetLen();
pPor = pNextPor;
if( !pPor->IsFlyPortion() && !pPor->IsMarginPortion() )
bLastHyph = pPor->InHyphGrp();
@@ -1671,7 +1671,7 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
{
const sal_uInt16 nPreWidth =
static_cast(pPor)->PreWidth();
if ( nX > nPreWidth )
-nX = nX - nPreWidth;
+nX -= nPreWidth;
else
nX = 0;
}
[Bug 105948] [META] Undo/Redo bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=105948 Bug 105948 depends on bug 90858, which changed state. Bug 90858 Summary: Shape doesnt return to original position after Undoing anchor https://bugs.documentfoundation.org/show_bug.cgi?id=90858 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 108741] [META] Shapes bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=108741 Bug 108741 depends on bug 90858, which changed state. Bug 90858 Summary: Shape doesnt return to original position after Undoing anchor https://bugs.documentfoundation.org/show_bug.cgi?id=90858 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90858] Shape doesnt return to original position after Undoing anchor
https://bugs.documentfoundation.org/show_bug.cgi?id=90858 sdc.bla...@youmail.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90858] Shape doesnt return to original position after Undoing anchor
https://bugs.documentfoundation.org/show_bug.cgi?id=90858 --- Comment #8 from sdc.bla...@youmail.dk --- Created attachment 191645 --> https://bugs.documentfoundation.org/attachment.cgi?id=191645=edit test results showing wfm closing as WFM. Attached document shows identical position of shape before and after "undo", following STR in OP Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 90993] EDITING: Objects anchored to frame disappear when frame anchor is changed.
https://bugs.documentfoundation.org/show_bug.cgi?id=90993 --- Comment #13 from sdc.bla...@youmail.dk --- repro Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL threaded When anchor of frame is changed (to anything), then the shape (anchored "to frame") is hidden (as seen in Navigator). Saving and reloading the document will make the shape unhidden. This bug is a duplicate (or close to) bug 128471 (which is more general, because not just limited to "page" anchor. Bug 90993 uses save and reload to return the shape. Bug 128471 uses copy and paste to return the shape, so I will leave both versions. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158866] Pasting 2 pictures into the same cell will cause the picture to display incorrectly in LibreOffice Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=158866 BogdanB changed: What|Removed |Added Summary|Pasting 2 pictures into the |Pasting 2 pictures into the |same cell will cause the|same cell will cause the |picture to display |picture to display |incorrectly in LibreOffice |incorrectly in LibreOffice |Clac|Calc Blocks||102593 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=102593 [Bug 102593] [META] Paste bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102593] [META] Paste bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102593 BogdanB changed: What|Removed |Added Depends on||158866 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158866 [Bug 158866] Pasting 2 pictures into the same cell will cause the picture to display incorrectly in LibreOffice Calc -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 BogdanB changed: What|Removed |Added Depends on||158873 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158873 [Bug 158873] Hyperlinks do not change colour when visited -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158873] Hyperlinks do not change colour when visited
https://bugs.documentfoundation.org/show_bug.cgi?id=158873 BogdanB changed: What|Removed |Added Blocks||107733 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107733 [Bug 107733] [META] Hyperlink bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158909] changing Font Size Issue
https://bugs.documentfoundation.org/show_bug.cgi?id=158909 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||121010 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=121010 [Bug 121010] [META] Font size bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 121010] [META] Font size bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=121010 BogdanB changed: What|Removed |Added Depends on||158909 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158909 [Bug 158909] changing Font Size Issue -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107659] [META] Macro bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107659 BogdanB changed: What|Removed |Added Depends on||158889 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158889 [Bug 158889] Macro kill => any attempt to access macros crashes LOo -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158889] Macro kill => any attempt to access macros crashes LOo
https://bugs.documentfoundation.org/show_bug.cgi?id=158889 BogdanB changed: What|Removed |Added Blocks||107659 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107659 [Bug 107659] [META] Macro bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 BogdanB changed: What|Removed |Added Depends on||158423 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158423 [Bug 158423] CppunitTest_unoxml_domtest failing with libxml-2.12 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158423] CppunitTest_unoxml_domtest failing with libxml-2.12
https://bugs.documentfoundation.org/show_bug.cgi?id=158423 BogdanB changed: What|Removed |Added Blocks||143781 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158803] Fix issues found by pyflakes
https://bugs.documentfoundation.org/show_bug.cgi?id=158803 BogdanB changed: What|Removed |Added CC||buzea.bog...@libreoffice.or ||g Blocks||143781 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=143781 [Bug 143781] [META] Development- and code-related bug reports and tasks -- You are receiving this mail because: You are the assignee for the bug.
[Bug 143781] [META] Development- and code-related bug reports and tasks
https://bugs.documentfoundation.org/show_bug.cgi?id=143781 BogdanB changed: What|Removed |Added Depends on||158803 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158803 [Bug 158803] Fix issues found by pyflakes -- You are receiving this mail because: You are the assignee for the bug.
[Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103341 BogdanB changed: What|Removed |Added Depends on||158454 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158454 [Bug 158454] Add Thai Autocorrect Support -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158454] Add Thai Autocorrect Support
https://bugs.documentfoundation.org/show_bug.cgi?id=158454 BogdanB changed: What|Removed |Added Blocks||103341 CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103341 [Bug 103341] [META] AutoCorrect and Word Completion bugs and enhancements -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158925] The PDF created from master document does not create links for indexes in included documents
https://bugs.documentfoundation.org/show_bug.cgi?id=158925 BogdanB changed: What|Removed |Added Blocks||107805 Summary|created pdf from master |The PDF created from master |document does not create|document does not create |links for indexes in|links for indexes in |included documents |included documents CC||buzea.bog...@libreoffice.or ||g Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107805 [Bug 107805] [META] Writer master document issues -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107805] [META] Writer master document issues
https://bugs.documentfoundation.org/show_bug.cgi?id=107805 BogdanB changed: What|Removed |Added Depends on||158925 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=158925 [Bug 158925] The PDF created from master document does not create links for indexes in included documents -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/core/text/itrcrsr.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 76094232350d01ab7dabdc8f7c0043fa5c6ff4c8
Author: Mike Kaganski
AuthorDate: Sat Dec 30 15:00:07 2023 +0600
Commit: Mike Kaganski
CommitDate: Sat Dec 30 11:09:44 2023 +0100
No need to decrement the position for Hole portion case
Otherwise a click to the right of a centered paragraph in DOCX with
trailing spaces would put cursor before the last space, not after.
Change-Id: Idc0cb1b69f7271e1f9af2e23389aaf11adcbd186
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161438
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/source/core/text/itrcrsr.cxx b/sw/source/core/text/itrcrsr.cxx
index 6da37f66a5de..30b605cac011 100644
--- a/sw/source/core/text/itrcrsr.cxx
+++ b/sw/source/core/text/itrcrsr.cxx
@@ -1364,7 +1364,6 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
// in which nX is situated.
SwLinePortion *pPor = m_pCurr->GetFirstPortion();
TextFrameIndex nCurrStart = m_nStart;
-bool bHolePortion = false;
bool bLastHyph = false;
std::deque *pKanaComp = m_pCurr->GetpKanaComp();
@@ -1419,7 +1418,6 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
{
nX = nX - nWidth;
nCurrStart = nCurrStart + pPor->GetLen();
-bHolePortion = pPor->IsHolePortion();
pPor = pPor->GetNextPortion();
nWidth = pPor->Width();
if ( m_pCurr->IsSpaceAdd() || pKanaComp )
@@ -1520,7 +1518,7 @@ TextFrameIndex
SwTextCursor::GetModelPositionForViewPoint( SwPosition *pPos, con
return TextFrameIndex(0);
// 7849, 7816: pPor->GetHyphPortion is mandatory!
-if( bHolePortion || ( !bRightAllowed && bLastHyph ) ||
+if( ( !bRightAllowed && bLastHyph ) ||
( pPor->IsMarginPortion() && !pPor->GetNextPortion() &&
// 46598: Consider the situation: We might end up behind the
last character,
// in the last line of a centered paragraph
