[Bug 159468] Lets discussed about Online shopping
https://bugs.documentfoundation.org/show_bug.cgi?id=159468 Dabeer khalid changed: What|Removed |Added URL||https://imarkplace.com/ -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159468] New: Lets discussed about Online shopping
https://bugs.documentfoundation.org/show_bug.cgi?id=159468 Bug ID: 159468 Summary: Lets discussed about Online shopping Product: Impress Remote Version: 1.0.0 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: General Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hasnain.imarkpl...@gmail.com Description: Let's delve into the world of online shopping! From emerging trends to consumer preferences, join the discussion and explore the dynamic landscape of e-commerce. Actual Results: Click our website https://imarkplace.com/ Expected Results: Clicks Reproducible: Always User Profile Reset: Yes Additional Info: Imarkplace has been launched in the year 2021 with the objective to make online shopping more convenient. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa
sw/qa/extras/ooxmlexport/ooxmllinks.cxx | 48 ++--
1 file changed, 28 insertions(+), 20 deletions(-)
New commits:
commit 4253acd5300c526b062fc5b5f109e93e6e9d08df
Author: Miklos Vajna
AuthorDate: Wed Jan 31 07:11:05 2024 +0100
Commit: Miklos Vajna
CommitDate: Wed Jan 31 08:15:27 2024 +0100
CppunitTest_sw_ooxmllinks: avoid DECLARE_LINKS_EXPORT_TEST at one place
Reduce the amount of code that's inside the macro body, and then no need
go via Writer-specific macros.
Change-Id: I6a09754f04e3103195b0ca585c820ddc98efd4ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162787
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/ooxmlexport/ooxmllinks.cxx
b/sw/qa/extras/ooxmlexport/ooxmllinks.cxx
index ccc08515644d..d58952cb6b5f 100644
--- a/sw/qa/extras/ooxmlexport/ooxmllinks.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmllinks.cxx
@@ -32,24 +32,7 @@
if (!bUseTempDir)
\
return;
\
\
-uno::Reference xParagraph = getParagraph(1);
\
-/* can be changed only after import */
\
-uno::Reference xText = getRun(xParagraph, 1);
\
-
\
-/* Get original link */
\
-OUString sOriginalFileName = getProperty(xText,
"HyperLinkURL"); \
-INetURLObject aOriginalURL(sOriginalFileName);
\
-CPPUNIT_ASSERT(!aOriginalURL.HasError());
\
-OUString sFileName = aOriginalURL.GetLastName();
\
-CPPUNIT_ASSERT(!sFileName.isEmpty());
\
-
\
-/* Get temp path */
\
-OUString sTempDir = utl::GetTempNameBaseDirectory();
\
-
\
-/* Create & apply new URL */
\
-OUString sOriginalFileInTempDir = sTempDir + sFileName;
\
-uno::Reference xPropertySet(xText,
css::uno::UNO_QUERY); \
-xPropertySet->setPropertyValue("HyperLinkURL",
css::uno::Any(sOriginalFileInTempDir)); \
+UseTempDir();
\
}
\
\
public:
\
@@ -82,6 +65,28 @@ public:
officecfg::Office::Common::Save::URL::FileSystem::set(!bAbsolute,
xChanges);
xChanges->commit();
}
+
+void UseTempDir()
+{
+uno::Reference xParagraph = getParagraph(1);
+/* can be changed only after import */
+uno::Reference xText = getRun(xParagraph, 1);
+
+/* Get original link */
+OUString sOriginalFileName = getProperty(xText,
"HyperLinkURL");
+INetURLObject aOriginalURL(sOriginalFileName);
+CPPUNIT_ASSERT(!aOriginalURL.HasError());
+OUString sFileName = aOriginalURL.GetLastName();
+CPPUNIT_ASSERT(!sFileName.isEmpty());
+
+/* Get temp path */
+OUString sTempDir = utl::GetTempNameBaseDirectory();
+
+/* Create & apply new URL */
+OUString sOriginalFileInTempDir = sTempDir + sFileName;
+uno::Reference xPropertySet(xText,
css::uno::UNO_QUERY);
+xPropertySet->setPropertyValue("HyperLinkURL",
css::uno::Any(sOriginalFileInTempDir));
+}
};
/* IMPORT */
@@ -142,9 +147,12 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf123627_import)
/* EXPORT */
-DECLARE_LINKS_EXPORT_TEST(testRelativeToRelativeExport, "relative-link.docx",
USE_RELATIVE,
- USE_TEMP_DIR)
+CPPUNIT_TEST_FIXTURE(Test, testRelativeToRelativeExport)
{
+SetAbsolute(USE_RELATIVE);
+createSwDoc("relative-link.docx");
+UseTempDir();
+saveAndReload(mpFilter);
xmlDocUniquePtr pXmlDoc = parseExport("word/_rels/document.xml.rels");
core.git: static/source
static/source/embindmaker/embindmaker.cxx | 65 ++
1 file changed, 32 insertions(+), 33 deletions(-)
New commits:
commit 9c416f6704a2b80b31b73104174f13c5294fbd61
Author: Stephan Bergmann
AuthorDate: Tue Jan 30 21:59:40 2024 +0100
Commit: Stephan Bergmann
CommitDate: Wed Jan 31 08:04:28 2024 +0100
Embind clean up, only pass in-out/out params by raw pointer
Change-Id: I141d3aace7b76182fe464626bbb8a336c8ec6a3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162783
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index 262e202313a8..6a9083f28516 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -263,16 +263,12 @@ bool passByReference(rtl::Reference const&
manager, OUString const&
}
void dumpType(std::ostream& out, rtl::Reference const& manager,
- std::u16string_view name, bool isConst)
+ std::u16string_view name)
{
sal_Int32 k;
std::vector args;
OUString n(
b2u(codemaker::UnoType::decompose(u2b(resolveAllTypedefs(manager,
name)), , )));
-if (isConst)
-{
-out << "const ";
-}
for (sal_Int32 i = 0; i != k; ++i)
{
out << "::css::uno::Sequence<";
@@ -345,7 +341,7 @@ void dumpType(std::ostream& out,
rtl::Reference const& manager,
{
out << ", ";
}
-dumpType(out, manager, b2u(arg), false);
+dumpType(out, manager, b2u(arg));
}
out << ">";
}
@@ -403,7 +399,7 @@ void dumpAttributes(std::ostream& out,
rtl::Reference const& manage
{
out << "+[](::com::sun::star::uno::Reference<" << cppName(name)
<< "> const & the_self, ";
-dumpType(out, manager, attr.type, false);
+dumpType(out, manager, attr.type);
if (passByReference(manager, attr.type))
{
out << " const &";
@@ -425,6 +421,15 @@ void dumpAttributes(std::ostream& out,
rtl::Reference const& manage
}
}
+bool hasInOutParameters(unoidl::InterfaceTypeEntity::Method const& method)
+{
+return std::any_of(method.parameters.begin(), method.parameters.end(),
+ [](auto const& parameter) {
+ return parameter.direction
+ !=
unoidl::InterfaceTypeEntity::Method::Parameter::DIRECTION_IN;
+ });
+}
+
void dumpParameters(std::ostream& out, rtl::Reference const&
manager,
unoidl::InterfaceTypeEntity::Method const& method, bool
declarations)
{
@@ -439,32 +444,26 @@ void dumpParameters(std::ostream& out,
rtl::Reference const& manage
{
out << ", ";
}
-bool isConst;
-bool isRef;
-if (param.direction ==
unoidl::InterfaceTypeEntity::Method::Parameter::DIRECTION_IN)
-{
-isConst = passByReference(manager, param.type);
-isRef = isConst;
-}
-else
-{
-isConst = false;
-isRef = true;
-}
-// For the embind wrapper, we define a pointer instead of a reference:
if (declarations)
{
-dumpType(out, manager, param.type, isConst);
+dumpType(out, manager, param.type);
+if (param.direction ==
unoidl::InterfaceTypeEntity::Method::Parameter::DIRECTION_IN)
+{
+if (passByReference(manager, param.type))
+{
+out << " const &";
+}
+}
+else
+{
+out << " *";
+}
out << " ";
}
-if (isRef)
+else if (param.direction !=
unoidl::InterfaceTypeEntity::Method::Parameter::DIRECTION_IN)
{
out << "*";
}
-if (declarations)
-{
-out << " ";
-}
out << param.name;
}
}
@@ -497,7 +496,12 @@ void dumpWrapper(std::ostream& out,
rtl::Reference const& manager,
}
out << "->" << method.name << "(";
dumpParameters(out, manager, method, false);
-out << "); }, ::emscripten::allow_raw_pointers())
";
+out << "); }";
+if (hasInOutParameters(method))
+{
+out << ", ::emscripten::allow_raw_pointers()";
+}
+out << ")
";
}
void dumpMethods(std::ostream& out, rtl::Reference const& manager,
@@ -506,12 +510,7 @@ void dumpMethods(std::ostream& out,
rtl::Reference const& manager,
{
for (auto const& meth : entity->getDirectMethods())
{
-if (!baseTrail.empty()
-|| std::any_of(
- meth.parameters.begin(), meth.parameters.end(), [](auto
const& parameter)
[Bug 159278] API call to XStorable.storeToURL with Password does not work for DOCX output
https://bugs.documentfoundation.org/show_bug.cgi?id=159278 --- Comment #3 from Paul --- Document with macro attached. It seems to show the problem that I experience with the UNO (Java) API. It is currently configured to set the password and save the current to c:\temp\Output.docx. The resulting docx file does not require a password. If lines 13 and 14 are uncommented (and 15/16 are commented out), it saves Output.doc and the open password is needed to open the document in Word. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159278] API call to XStorable.storeToURL with Password does not work for DOCX output
https://bugs.documentfoundation.org/show_bug.cgi?id=159278 --- Comment #2 from Paul --- Created attachment 192278 --> https://bugs.documentfoundation.org/attachment.cgi?id=192278=edit Document with macro showing issue -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158167] Calc: Move selected row and scroll sheet extremely slow with CPU in local debug build
https://bugs.documentfoundation.org/show_bug.cgi?id=158167 Buovjaga changed: What|Removed |Added CC||ilmari.lauhakangas@libreoff ||ice.org --- Comment #15 from Buovjaga --- (In reply to Matt K from comment #14) > Created attachment 192006 [details] > Windows Performance Analyzer output > > I took a perf trace under Windows using the Windows Performance Recorder UI > tool with CPU Usage collection selected. I've attached the output which > shows the code is spending at least 15 seconds (3 intervals of almost 5 > seconds each) doing sclo.dll!ScColContainer::resize which just calls > "reserve" on a std::vector container. I don't know why moving a row has > anything to do with resizing columns, but maybe someone more familiar with > the code can determine the problem. That sounds exactly like the bibisect result I got for bug 159131, so can Timur or others still repro after Noel's fix? Noel does say in the fixing commit: "I'm not sure why the above commit causes trouble on Windows, but not Linux" -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159131] Calc v7.5 is laggy when moving a line (row)
https://bugs.documentfoundation.org/show_bug.cgi?id=159131 Buovjaga changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #11 from Buovjaga --- I confirm the lag is gone now in Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: dfcdef6d94993131b5f150d00d08cc81a987eebb CPU threads: 2; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Thanks! Others can test with Win-x86_64@tb77-TDF from https://dev-builds.libreoffice.org/daily/master/current.html -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159135] With "outline folding", strange cursor behaviour
https://bugs.documentfoundation.org/show_bug.cgi?id=159135 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|With "outline folding", |With "outline folding", |strange cursor beavihor |strange cursor behaviour -- You are receiving this mail because: You are the assignee for the bug.
core.git: basic/source
basic/source/uno/namecont.cxx | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
New commits:
commit 942e9a79f066a26276e299660ba56874874841c6
Author: Mike Kaganski
AuthorDate: Wed Jan 31 10:26:04 2024 +0600
Commit: Mike Kaganski
CommitDate: Wed Jan 31 06:56:42 2024 +0100
Related: tdf#159458 Move variable URL re-creation to a central place
Change-Id: Ib73ae476f308b2579a15c9b2474a55e3558c134c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162786
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/basic/source/uno/namecont.cxx b/basic/source/uno/namecont.cxx
index eb04dd2ee767..430cab8b3264 100644
--- a/basic/source/uno/namecont.cxx
+++ b/basic/source/uno/namecont.cxx
@@ -562,6 +562,7 @@ void checkAndCopyFileImpl( const INetURLObject&
rSourceFolderInetObj,
}
constexpr OUString sUserBasicVariablePrefix = u"$(USER)/basic/"_ustr;
+constexpr OUString sInstBasicVariablePrefix = u"$(INST)/" LIBO_SHARE_FOLDER
"/basic/"_ustr;
void createVariableURL( OUString& rStr, std::u16string_view rLibName,
std::u16string_view rInfoFileName, bool bUser )
@@ -572,7 +573,7 @@ void createVariableURL( OUString& rStr, std::u16string_view
rLibName,
}
else
{
-rStr = "$(INST)/" LIBO_SHARE_FOLDER "/basic/";
+rStr = sInstBasicVariablePrefix;
}
rStr += OUString::Concat(rLibName) + "/" + rInfoFileName + ".xlb/";
}
@@ -1268,7 +1269,13 @@ void SfxLibraryContainer::checkStorageURL( const
OUString& aSourceURL,
}
else
{
-aUnexpandedStorageURL.clear();
+// try to re-create the variable URL: helps moving the profile
+if (OUString aRest;
aSourceURL.startsWith(expand_url(sUserBasicVariablePrefix), ))
+aUnexpandedStorageURL = sUserBasicVariablePrefix + aRest;
+else if (aSourceURL.startsWith(expand_url(sInstBasicVariablePrefix),
))
+aUnexpandedStorageURL = sInstBasicVariablePrefix + aRest;
+else
+aUnexpandedStorageURL.clear(); // This will use eventual value of
aLibInfoFileURL
}
INetURLObject aInetObj( aExpandedSourceURL );
@@ -2525,18 +2532,9 @@ void SAL_CALL SfxLibraryContainer::renameLibrary( const
OUString& Name, const OU
INetURLObject::EncodeMechanism::All );
OUString aDestDirPath = aDestInetObj.GetMainURL(
INetURLObject::DecodeMechanism::NONE );
-OUString aDestDirUnexpandedPath = aDestDirPath;
-if
(pImplLib->maUnexpandedStorageURL.startsWith(sUserBasicVariablePrefix))
-{
-// try to re-create the variable URL: helps moving the profile
-OUString aUserBasicURL = expand_url(sUserBasicVariablePrefix);
-if (OUString aRest; aDestDirPath.startsWith(aUserBasicURL, ))
-aDestDirUnexpandedPath = sUserBasicVariablePrefix + aRest;
-}
-
// Store new URL
OUString aLibInfoFileURL = pImplLib->maLibInfoFileURL;
-checkStorageURL(aDestDirUnexpandedPath, pImplLib->maLibInfoFileURL,
pImplLib->maStorageURL,
+checkStorageURL(aDestDirPath, pImplLib->maLibInfoFileURL,
pImplLib->maStorageURL,
pImplLib->maUnexpandedStorageURL );
try
core.git: Branch 'distro/vector/vector-7.5.9' - 2 commits - include/test sw/qa sw/source test/source
include/test/xmltesttools.hxx |3
sw/qa/extras/odfexport/data/bookmark_order.fodt |9
sw/qa/extras/odfexport/odfexport2.cxx | 96 ++
sw/qa/extras/uiwriter/uiwriter4.cxx | 15 -
sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py |6
sw/source/core/unocore/unoportenum.cxx | 114 +++-
test/source/xmltesttools.cxx| 13 +
7 files changed, 199 insertions(+), 57 deletions(-)
New commits:
commit 8babfc57769d30ee5f471fcabd6ba7abe444ae5a
Author: Mike Kaganski
AuthorDate: Tue Jul 4 06:20:36 2023 +0300
Commit: Mike Kaganski
CommitDate: Wed Jan 31 11:43:13 2024 +0600
Fix a UITest on Windows
Change-Id: I9645cea2394f945355f86b3f6013d1d0f5117c76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153940
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
b/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
index eb43912782bc..0c556b6c2b65 100644
--- a/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
+++ b/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
@@ -9,6 +9,7 @@
from uitest.framework import UITestCase
from uitest.uihelper.common import get_state_as_dict, get_url_for_data_file
from libreoffice.uno.propertyvalue import mkPropertyValues
+import platform
class dateFormFieldDialog(UITestCase):
@@ -138,6 +139,9 @@ class dateFormFieldDialog(UITestCase):
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"ALT+DOWN"}))
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"ESC"}))
xWriterEdit.executeAction("TYPE", mkPropertyValues({"KEYCODE":
"UP"}))
-self.assertEqual(writer_doc.getText().getString(), "
Click to choose a date")
+if platform.system() == "Windows":
+self.assertEqual(writer_doc.getText().getString(), "
Click to choose a date")
+else:
+self.assertEqual(writer_doc.getText().getString(), "
Click to choose a date")
# vim: set shiftwidth=4 softtabstop=4 expandtab:
commit 4a487be6cb281fc5080969c2a1639090ac2a6bd3
Author: Mike Kaganski
AuthorDate: Tue Jan 30 17:15:07 2024 +0600
Commit: Mike Kaganski
CommitDate: Wed Jan 31 11:42:59 2024 +0600
tdf#159438: when there's no frame, close previous bookmark first
Commit 260d6cc6471444b4ef20ed6673831b0b12f96333 (INTEGRATION: CWS mtg2
(1.30.120); FILE MERGED, 2005-12-21) for #i58438# made sure to process
previously opened bookmarks that close at this node, before opening
the bookmarks that start here.
Commit 76a4305d1e90b6617054dd33036e64f005dbcf04 (sw: fix inconsistent
bookmark behavior around at-char/as-char anchored frames, 2017-12-21)
re-introduced the problem accidentally: it only intended to handle
case when there is an anchored frame here.
This change re-instates the correct order (close bookmarks first; then
process collapsed ones; then open new bookmarks) in case there's no
anchored frames here.
To avoid a problem when a non-collapsed bookmark starts and ends at
the same point (e.g., its text was deleted), it gets converted to
collapsed in lcl_FillBookmark. Thus, testRemoveBookmarkText was fixed
in sw/qa/extras/uiwriter/uiwriter4.cxx. There is no reason to keep
the separate -begin/-end elements, especially since on the following
open/save round-trip, it will become collapsed anyway.
Change-Id: Ib555a76f6f776001e12908a1299c24eebf591f6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162743
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/include/test/xmltesttools.hxx b/include/test/xmltesttools.hxx
index 09f06af5eb0d..2a2893728cad 100644
--- a/include/test/xmltesttools.hxx
+++ b/include/test/xmltesttools.hxx
@@ -96,6 +96,9 @@ protected:
* Assert that rXPath exists, has exactly 1 result set nodes and does
*not* have an attribute named rAttribute.
*/
void assertXPathNoAttribute(const xmlDocUniquePtr& pXmlDoc, const
OString& rXPath, const OString& rAttribute);
+// Assert that the node name of the single node returned by an XPath is as
specified,
+// e.g. to check order of elements, where getXPathPosition is unapplicable
+void assertXPathNodeName(const xmlDocUniquePtr& pXmlDoc, const OString&
rXPath, const OString& rExpectedName);
static void registerODFNamespaces(xmlXPathContextPtr& pXmlXpathCtx);
static void registerOOXMLNamespaces(xmlXPathContextPtr& pXmlXpathCtx);
diff --git a/sw/qa/extras/odfexport/data/bookmark_order.fodt
b/sw/qa/extras/odfexport/data/bookmark_order.fodt
new file mode 100644
index ..c7eac58758ff
--- /dev/null
+++ b/sw/qa/extras/odfexport/data/bookmark_order.fodt
@@ -0,0 +1,9 @@
+
+
+
+
[Bug 156370] Assigning a paragraph style causes the cursor jumps back to section title
https://bugs.documentfoundation.org/show_bug.cgi?id=156370 Stéphane Guillou (stragu) changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #14 from Stéphane Guillou (stragu) --- Ha, turns out it was most likely due to Outline Folding being on. Marking as duplicate of bug 154701, which is resolved in the soon-to-be-released version 24.2. Thanks! *** This bug has been marked as a duplicate of bug 154701 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157042] [Linux only] Calc crashes when closed in rtl::str::release<_rtl_uString>(_rtl_uString*) (steps in comment 27)
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 --- Comment #30 from Stéphane Guillou (stragu) --- Created attachment 192277 --> https://bugs.documentfoundation.org/attachment.cgi?id=192277=edit minidump with 7.6.5 daily build Version: 7.6.5.0.0+ (X86_64) / LibreOffice Community Build ID: 5db313902110c95c440bb0e96f46acc97092d7ca CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded In console: warn:sfx.control:458070:458070:sfx2/source/control/dispatch.cxx:1211: Childwindow slot missing: 25917 warn:sfx.control:458070:458070:sfx2/source/control/dispatch.cxx:1211: Childwindow slot missing: 26189 warn:sfx.control:458070:458070:sfx2/source/control/dispatch.cxx:1211: Childwindow slot missing: 26190 warn:xmloff:458070:458070:xmloff/source/text/XMLTextListAutoStylePool.cxx:163: getStyleFamilies() from XModel failed for export! warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 5 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 2 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 5 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 10 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 2 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 3 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 5 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 2 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 5 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 10 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 2 warn:editeng:458070:458070:editeng/source/uno/unofield.cxx:375: Id service unknown: 3 warn:xmloff:458070:458070:xmloff/source/text/XMLTextListAutoStylePool.cxx:163: getStyleFamilies() from XModel failed for export! warn:xmloff:458070:458070:xmloff/source/text/XMLTextListAutoStylePool.cxx:163: getStyleFamilies() from XModel failed for export! warn:legacy.osl:458070:458070:xmloff/source/core/SettingsExportHelper.cxx:176: this type is not implemented now warn:legacy.tools:458070:458070:sfx2/source/bastyp/progress.cxx:200: Can't make progress bar! warn:legacy.tools:458070:458070:sfx2/source/bastyp/progress.cxx:200: Can't make progress bar! warn:sfx.appl:458070:458070:sfx2/source/appl/app.cxx:166: Memory leak: some object shells were not removed! warn:unotools.config:458070:458070:unotools/source/config/configmgr.cxx:147: ConfigManager not empty -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157042] [Linux only] Calc crashes when closed in rtl::str::release<_rtl_uString>(_rtl_uString*) (steps in comment 27)
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 --- Comment #29 from Stéphane Guillou (stragu) --- Tried bibisecting, but libreoffice-64-7.6 master does not crash with those steps. I also tried adding a dictionary to have auto spellcheck active. (Repository is currently at 30ee116ee498160a366a5a618649f832ae371f7d) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157042] [Linux only] Calc crashes when closed in rtl::str::release<_rtl_uString>(_rtl_uString*) (steps in comment 27)
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 Stéphane Guillou (stragu) changed: What|Removed |Added Keywords||bibisectRequest, regression Summary|[Linux only] Calc crashes |[Linux only] Calc crashes |when closed in |when closed in |rtl::str::release<_rtl_uStr |rtl::str::release<_rtl_uStr |ing>(_rtl_uString*) |ing>(_rtl_uString*) (steps ||in comment 27) Crash report or||["void crash signature||rtl::str::release<_rtl_uStr ||ing>(_rtl_uString*)"] --- Comment #28 from Stéphane Guillou (stragu) --- (In reply to John Stamp from comment #27) > I think that I found a reliable way to trigger the crash. At least, I can > reliably trigger it with 24.2.0-rc2 in Debian testing. > > * Start Calc with a new spreadsheet. > > * Enter some text into a cell and hit return. > > * Copy the cell with ctrl-c or right click. > > * Close Calc. This should trigger the crash. > > I could save the file or not before closing, and even as its own separate > step, but this rtl_uString_release crash only happens when I close Calc. Thank you! Using these steps, I could crash it with: Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Crash report: https://crashreport.libreoffice.org/stats/crash_details/39f7ddbb-7fa1-40fc-9b40-f36d280aedde No crash with gtk3 VCL plugin, no crash in 7.5.9.2. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159211] Test failure 24.2.0.1 final only on s390x: testTdf157635::TestBody
https://bugs.documentfoundation.org/show_bug.cgi?id=159211 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159223] Focus switching back to previous window when clicking on text after changing window
https://bugs.documentfoundation.org/show_bug.cgi?id=159223 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156347] When using --show argument LibreOffice starts but presentation not visible
https://bugs.documentfoundation.org/show_bug.cgi?id=156347 --- Comment #6 from QA Administrators --- Dear FingerlessGloves, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156147] Cannot open some of the sheets in .ods files after upgrading fm 6.4 to 7.4
https://bugs.documentfoundation.org/show_bug.cgi?id=156147 --- Comment #3 from QA Administrators --- Dear Dennis, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156313] 'General error.General input/output error.'was reported when loading a .pdf file.
https://bugs.documentfoundation.org/show_bug.cgi?id=156313 --- Comment #6 from QA Administrators --- Dear 2318494274, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159184] Test failure 24.2.0.1 final only on s390x: PngFilterTest
https://bugs.documentfoundation.org/show_bug.cgi?id=159184 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159418] Missing Navigation Arrows for Editing Index Entry
https://bugs.documentfoundation.org/show_bug.cgi?id=159418 QA Administrators changed: What|Removed |Added Keywords||bibisectRequest -- You are receiving this mail because: You are the assignee for the bug.
[Bug 139757] Dual monitor: Vertical windows taskbar is drawn on top of all libre menus
https://bugs.documentfoundation.org/show_bug.cgi?id=139757 --- Comment #6 from QA Administrators --- Dear dainius.mazuika, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159175] 2 GB of ram used when clicking open new calc document 10 times
https://bugs.documentfoundation.org/show_bug.cgi?id=159175 --- Comment #5 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 78027] FILEOPEN: Importing of Excel files with non-uniform formated diagram title
https://bugs.documentfoundation.org/show_bug.cgi?id=78027 --- Comment #15 from QA Administrators --- Dear Jan, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156370] Assigning a paragraph style causes the cursor jumps back to section title
https://bugs.documentfoundation.org/show_bug.cgi?id=156370 --- Comment #13 from QA Administrators --- Dear vicxp0518, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Bug 94929] Selection stays current location even after selecting or modifying a cell outside selection
https://bugs.documentfoundation.org/show_bug.cgi?id=94929 --- Comment #16 from QA Administrators --- Dear B.J. Herbison, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
core.git: basic/source
basic/source/uno/namecont.cxx | 27 +++
1 file changed, 23 insertions(+), 4 deletions(-)
New commits:
commit 907d4107896234b2e7ebfd42f40cee3bd5b1d01e
Author: Mike Kaganski
AuthorDate: Wed Jan 31 00:44:19 2024 +0600
Commit: Mike Kaganski
CommitDate: Wed Jan 31 03:35:15 2024 +0100
tdf#159458: make sure to update unexpanded URL when renaming library
1. If passed new source URL is expanded (i.e., trying to expand it in
SfxLibraryContainer::checkStorageURL didn't change it), previously
aUnexpandedStorageURL was unchanged. It should be cleared - then it
will be set automatically to the URL to lib info file.
2. Try to create the "variable" path (starting with "$(USER)/basic/")
because this avoids absolute paths to the libraries, which make it
harder to move the profile.
Change-Id: Ie83ea9a32cfddf37727d238547663aeb72487ee3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162777
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/basic/source/uno/namecont.cxx b/basic/source/uno/namecont.cxx
index b133b064..eb04dd2ee767 100644
--- a/basic/source/uno/namecont.cxx
+++ b/basic/source/uno/namecont.cxx
@@ -537,7 +537,9 @@ void SAL_CALL SfxLibraryContainer::storeLibraries( )
}
}
-static void checkAndCopyFileImpl( const INetURLObject& rSourceFolderInetObj,
+namespace
+{
+void checkAndCopyFileImpl( const INetURLObject& rSourceFolderInetObj,
const INetURLObject& rTargetFolderInetObj,
std::u16string_view rCheckFileName,
std::u16string_view rCheckExtension,
@@ -559,12 +561,14 @@ static void checkAndCopyFileImpl( const INetURLObject&
rSourceFolderInetObj,
}
}
-static void createVariableURL( OUString& rStr, std::u16string_view rLibName,
+constexpr OUString sUserBasicVariablePrefix = u"$(USER)/basic/"_ustr;
+
+void createVariableURL( OUString& rStr, std::u16string_view rLibName,
std::u16string_view rInfoFileName, bool bUser )
{
if( bUser )
{
-rStr = "$(USER)/basic/";
+rStr = sUserBasicVariablePrefix;
}
else
{
@@ -572,6 +576,7 @@ static void createVariableURL( OUString& rStr,
std::u16string_view rLibName,
}
rStr += OUString::Concat(rLibName) + "/" + rInfoFileName + ".xlb/";
}
+}
void SfxLibraryContainer::init( const OUString& rInitialDocumentURL, const
uno::Reference< embed::XStorage >& rxInitialStorage )
{
@@ -1261,6 +1266,11 @@ void SfxLibraryContainer::checkStorageURL( const
OUString& aSourceURL,
{
aUnexpandedStorageURL = aSourceURL;
}
+else
+{
+aUnexpandedStorageURL.clear();
+}
+
INetURLObject aInetObj( aExpandedSourceURL );
OUString aExtension = aInetObj.getExtension();
if( aExtension == "xlb" )
@@ -2515,9 +2525,18 @@ void SAL_CALL SfxLibraryContainer::renameLibrary( const
OUString& Name, const OU
INetURLObject::EncodeMechanism::All );
OUString aDestDirPath = aDestInetObj.GetMainURL(
INetURLObject::DecodeMechanism::NONE );
+OUString aDestDirUnexpandedPath = aDestDirPath;
+if
(pImplLib->maUnexpandedStorageURL.startsWith(sUserBasicVariablePrefix))
+{
+// try to re-create the variable URL: helps moving the profile
+OUString aUserBasicURL = expand_url(sUserBasicVariablePrefix);
+if (OUString aRest; aDestDirPath.startsWith(aUserBasicURL, ))
+aDestDirUnexpandedPath = sUserBasicVariablePrefix + aRest;
+}
+
// Store new URL
OUString aLibInfoFileURL = pImplLib->maLibInfoFileURL;
-checkStorageURL( aDestDirPath, pImplLib->maLibInfoFileURL,
pImplLib->maStorageURL,
+checkStorageURL(aDestDirUnexpandedPath, pImplLib->maLibInfoFileURL,
pImplLib->maStorageURL,
pImplLib->maUnexpandedStorageURL );
try
[Bug 108037] CRASH: Huge memory usage (2.800 MB in 64-bit), additionally crash (on 1.400 MB in 32-bit) when exporting 58-pages ODP to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=108037 Matt K changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |matt...@gmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #16 from Matt K --- A significant fix is available at: https://gerrit.libreoffice.org/c/core/+/162785. Tested on x64 system and no crashes were observed. Memory usage reduced from 2.8G to 1.9G and time to export reduced from ~1 minute to 7 seconds. There may still be room for improvement in reducing memory usage. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159467] XLOOKUP does not work if embedded in another XLOOKUP
https://bugs.documentfoundation.org/show_bug.cgi?id=159467 --- Comment #2 from Gabor Kelemen (allotropia) --- Created attachment 192276 --> https://bugs.documentfoundation.org/attachment.cgi?id=192276=edit The example file after modifying the search input of XLOOKUP -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159467] XLOOKUP does not work if embedded in another XLOOKUP
https://bugs.documentfoundation.org/show_bug.cgi?id=159467 --- Comment #1 from Gabor Kelemen (allotropia) --- Created attachment 192275 --> https://bugs.documentfoundation.org/attachment.cgi?id=192275=edit The example file after opening, this works -- You are receiving this mail because: You are the assignee for the bug.
[Bug 150900] [META] Excel Functions
https://bugs.documentfoundation.org/show_bug.cgi?id=150900 Gabor Kelemen (allotropia) changed: What|Removed |Added Depends on||159467 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159467 [Bug 159467] XLOOKUP does not work if embedded in another XLOOKUP -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159467] New: XLOOKUP does not work if embedded in another XLOOKUP
https://bugs.documentfoundation.org/show_bug.cgi?id=159467 Bug ID: 159467 Summary: XLOOKUP does not work if embedded in another XLOOKUP Product: LibreOffice Version: 24.8.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: kelem...@ubuntu.com Blocks: 150900 Created attachment 192274 --> https://bugs.documentfoundation.org/attachment.cgi?id=192274=edit Example file from Excel 2021/O365 Attached example file was taken from https://trumpexcel.com/xlookup-function/ and demonstrates various uses of the XLOOKUP function. After the patch 1. Open attached file 2. Go to the "Ex 5" sheet 3. In the A12 cell enter a value from the A2:A8 range such as "Ned" -> In B12 the XLOOKUP gives back #N/A error instead of the matching value from the B2:B8 range. This happens because XLOOKUP has the ability to run an embedded function as its 4th if_not_found parameter, and here that one gives back the #N/A error. Excel handles this in an unusual way and does not propagate this error as the final result of the XLOOKUP function, but Calc does. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 9de73be119eb288ee0a1f54e9c0f2b236ef41821 CPU threads: 2; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: threaded (this is local build from https://gerrit.libreoffice.org/c/core/+/131905 ) Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=150900 [Bug 150900] [META] Excel Functions -- You are receiving this mail because: You are the assignee for the bug.
For Mac version, is it possible to build language packages directly into main package?
Hi all, For Mac version, currently released packages are a main package (LibreOffice_24.0.3_MacOS_x86-64.dmg) and different language packages (LibreOffice_24.0.3_MacOS_x86-64_langpack_*.dmg). But it is really difficult to install those packages in a MacOS system and caused a lot of complaints from our customers. We are thinking if it is possible to build a main packages with certain language pack (for example, en and zh_TW) into it to form ONE dmg package instead of three? If yes, what options should we use when compiling? If not, is there any other solution for that, to simplify the installation on a MacOS system? Thanks, Dev
[Bug 157042] [Linux only] Calc crashes when closed in rtl::str::release<_rtl_uString>(_rtl_uString*)
https://bugs.documentfoundation.org/show_bug.cgi?id=157042 --- Comment #27 from John Stamp --- I think that I found a reliable way to trigger the crash. At least, I can reliably trigger it with 24.2.0-rc2 in Debian testing. * Start Calc with a new spreadsheet. * Enter some text into a cell and hit return. * Copy the cell with ctrl-c or right click. * Close Calc. This should trigger the crash. I could save the file or not before closing, and even as its own separate step, but this rtl_uString_release crash only happens when I close Calc. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159453] Importing DOCX: Position of frame has gone
https://bugs.documentfoundation.org/show_bug.cgi?id=159453 raal changed: What|Removed |Added Keywords||bibisected, bisected Regression By||Michael Stahl CC||michael.st...@allotropia.de ||, r...@post.cz --- Comment #3 from raal --- This seems to have begun at the below commit in bibisect repository/OS linux-64-7.6. Adding Cc: to Michael Stahl ; Could you possibly take a look at this one? Thanks a5cb46f8588ccf7fe086a6fb317daee904d87844 is the first bad commit commit a5cb46f8588ccf7fe086a6fb317daee904d87844 Author: Jenkins Build User Date: Tue Oct 31 00:18:58 2023 +0100 source sha:e2076cf7a92694bc94bdc9f3173c2bddbe881a89 158289: tdf#155682 sw floattable: fix DOCX with big pictures causes endless loop | https://gerrit.libreoffice.org/c/core/+/158289 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159466] trying to print an envelope
https://bugs.documentfoundation.org/show_bug.cgi?id=159466 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Please attach a sample file, and paste the information in Menu/Help/About LibreOffice, there is an icon to copy. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159461] Dialog "XML Filter Settings" is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=159461 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||miguelangelrv@libreoffice.o ||rg --- Comment #2 from m_a_riosv --- Still reproducible with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 107237] [META] Notebookbar Tabbed
https://bugs.documentfoundation.org/show_bug.cgi?id=107237 V Stuart Foote changed: What|Removed |Added Depends on||159459 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159459 [Bug 159459] Some options unreachable while using the Tabbed UI -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159459] Some options unreachable while using the Tabbed UI
https://bugs.documentfoundation.org/show_bug.cgi?id=159459 V Stuart Foote changed: What|Removed |Added Severity|normal |enhancement CC||vsfo...@libreoffice.org Blocks||107237 --- Comment #1 from V Stuart Foote --- This is expected. The "standard" menubar is directly available in the MUFFIN Notebook bar UIs including the Tabbed UI. First button icon at left of the top row holding the tabs. Once exposed the menubar will continue to show. The Notebook bars are a loose assemblage of UNO controls with some framework wrapping their behavior. Extension authors are responsible for adding the Notebook bar support. IMHO => NAB and not worth dev effort to implement Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=107237 [Bug 107237] [META] Notebookbar Tabbed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159453] Importing DOCX: Position of frame has gone
https://bugs.documentfoundation.org/show_bug.cgi?id=159453 m_a_riosv changed: What|Removed |Added Ever confirmed|0 |1 CC||miguelangelrv@libreoffice.o ||rg Status|UNCONFIRMED |NEW --- Comment #2 from m_a_riosv --- Still reproducible also with Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159448] Format-Conditional-Condition submenu is not translated
https://bugs.documentfoundation.org/show_bug.cgi?id=159448 m_a_riosv changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from m_a_riosv --- I can reproduce with French. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: fr-FR Calc: CL threaded but not with German. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: de-DE Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: chart2/source
chart2/source/view/charttypes/PieChart.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dfcdef6d94993131b5f150d00d08cc81a987eebb Author: Andrea Gelmini AuthorDate: Tue Jan 30 16:46:16 2024 +0100 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Tue Jan 30 23:59:55 2024 +0100 Fix typo Change-Id: I384f3c97286a5b336d44df42e911870100542198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162766 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx index 3635ea3fd3bc..2d72da5f5886 100644 --- a/chart2/source/view/charttypes/PieChart.cxx +++ b/chart2/source/view/charttypes/PieChart.cxx @@ -468,7 +468,7 @@ void PieChart::createTextLabelShape( * * Therefore, handle this by making the label as small as possible. * - * Complication (tdf122765.pptx): it is possiible for the aOuterPosition + * Complication (tdf122765.pptx): it is possible for the aOuterPosition * to be outside of the available outer rectangle (somehow), * so in that bizarre case just try the positive value of the result... */
core.git: static/source
static/source/embindmaker/embindmaker.cxx |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
New commits:
commit 9f236a078cd179835b8c651990e3afecee6170ca
Author: Stephan Bergmann
AuthorDate: Tue Jan 30 21:10:59 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 30 23:57:16 2024 +0100
Pass the_self by const ref in Embind wrapper functions
Change-Id: Ie8bfec2a9fdd5f126fd2879d2ba06f1fa5c1019e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162781
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index c7aba58c3089..262e202313a8 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -473,8 +473,9 @@ void dumpWrapper(std::ostream& out,
rtl::Reference const& manager,
OUString const& interfaceName,
unoidl::InterfaceTypeEntity::Method const& method,
std::list const& baseTrail)
{
-out << ".function(\"" << method.name << "\", +[](" <<
cppName(interfaceName);
-out << " * the_self";
+out << ".function(\"" << method.name << "\",
+[](::com::sun::star::uno::Reference<"
+<< cppName(interfaceName);
+out << "> const & the_self";
if (!method.parameters.empty())
{
out << ", ";
@@ -486,6 +487,10 @@ void dumpWrapper(std::ostream& out,
rtl::Reference const& manager,
out << "static_cast<" << cppName(base) << " *>(";
}
out << "the_self";
+if (!baseTrail.empty())
+{
+out << ".get()";
+}
for (std::size_t i = 0; i != baseTrail.size(); ++i)
{
out << ")";
[Bug 159448] Format-Conditional-Condition submenu is not translated
https://bugs.documentfoundation.org/show_bug.cgi?id=159448 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Looks fine on Spanish. Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 3be785e088cc0aa726509cf6b52b1d3b03817172 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159175] 2 GB of ram used when clicking open new calc document 10 times
https://bugs.documentfoundation.org/show_bug.cgi?id=159175 Telesto changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #4 from Telesto --- I have to recheck this... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159375] Opening Tools > Options dialog takes too long
https://bugs.documentfoundation.org/show_bug.cgi?id=159375 Telesto changed: What|Removed |Added Keywords||perf -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159466] New: trying to print an envelope
https://bugs.documentfoundation.org/show_bug.cgi?id=159466 Bug ID: 159466 Summary: trying to print an envelope Product: LibreOffice Version: 7.2.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: robinehow...@netzero.com Description: wont rotate to the proper orientation and the format option is not active to do so Steps to Reproduce: 1.as per online help documentation 2. 3. Actual Results: wont enable rotation Expected Results: rotation Reproducible: Always User Profile Reset: No Additional Info: none does not work as expected -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159465] New: Crash in: SwRedlineAcceptPanel::SwRedlineAcceptPanel(weld::Widget *)
https://bugs.documentfoundation.org/show_bug.cgi?id=159465 Bug ID: 159465 Summary: Crash in: SwRedlineAcceptPanel::SwRedlineAcceptPanel(weld::Widge t *) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: hily...@sympatico.ca This bug was filed from the crash reporting server and is br-bb6c9e7c-5f66-4981-b280-241b6beb9437. = -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159210] Jumping to Last Page (Ctrl+End) in Document Extremely Slow
https://bugs.documentfoundation.org/show_bug.cgi?id=159210 --- Comment #2 from Tex2002ans --- (In reply to Stéphane Guillou (stragu) from comment #1) > Unbearably slow to open with: > > Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community > [...] Yes. To initially open the DOCX will currently take: - ~10.5 minutes on LO 7.6.4 - ~7.5 minutes on LO 24.8.0 (See Bug #158556 for status on that LOADING speed.) This report was split to focus on atrocious performance AFTER LOAD instead. - - - So if you're going to test this DOCX... definitely get up and stretch, make yourself a cup of tea, and return to the computer after. :P (Personally, I sat there watching a video on my phone + timer running while keeping the corner of my eye for changes to my screen.) -- You are receiving this mail because: You are the assignee for the bug.
core.git: static/source
static/source/unoembindhelpers/PrimaryBindings.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit 9a982f8cb62da5a82ae1426aa40900dd360c93b5
Author: Stephan Bergmann
AuthorDate: Tue Jan 30 20:40:11 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 30 22:46:36 2024 +0100
Embinding OUString shouldn't need allow_raw_pointers
Change-Id: I92608ebe4edf65c7de96587aa39e990fb09c3e19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162779
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/unoembindhelpers/PrimaryBindings.cxx
b/static/source/unoembindhelpers/PrimaryBindings.cxx
index b57749170470..4277af563936 100644
--- a/static/source/unoembindhelpers/PrimaryBindings.cxx
+++ b/static/source/unoembindhelpers/PrimaryBindings.cxx
@@ -40,8 +40,7 @@ EMSCRIPTEN_BINDINGS(PrimaryBindings)
.value("FromAny", unoembindhelpers::uno_Reference::FromAny);
class_("OUString")
-.constructor(+[](const std::u16string& rString) -> OUString { return
OUString(rString); },
- allow_raw_pointers())
+.constructor(+[](const std::u16string& rString) -> OUString { return
OUString(rString); })
.function("toString", +[](const OUString& rSelf) -> std::u16string {
return std::u16string(rSelf.getStr(), rSelf.getLength());
});
[Bug 159464] Short text in sections combined with long endnotes makes parts of text hidden under red arrow
https://bugs.documentfoundation.org/show_bug.cgi?id=159464 --- Comment #1 from lukasz.wlas...@hotmail.com --- Created attachment 192272 --> https://bugs.documentfoundation.org/attachment.cgi?id=192272=edit File with example of bug -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - filter/qa include/unotest unotest/source vcl/qa xmlsecurity/qa
filter/qa/pdf.cxx | 10 -
include/unotest/macros_test.hxx |6 ++-
unotest/source/cpp/macros_test.cxx| 46 ++
vcl/qa/cppunit/filter/ipdf/ipdf.cxx | 10 -
xmlsecurity/qa/unit/pdfsigning/pdfsigning.cxx |9 -
xmlsecurity/qa/unit/signing/signing.cxx |5 +-
xmlsecurity/qa/unit/signing/signing2.cxx |5 +-
7 files changed, 46 insertions(+), 45 deletions(-)
New commits:
commit 93444f3aaeb2c082abe52f3842674ddc7654426c
Author: Michael Stahl
AuthorDate: Mon Jan 29 15:24:05 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 30 22:45:27 2024 +0100
tdf#105844 unotest,xmlsecurity: fix tests on MacOSX
The new tests fail with:
> core/xmlsecurity/qa/unit/signing/signing2.cxx:
> 252: Assertion
> Test name: testPasswordPreserveMacroSignatureODFWholesomeLO242::TestBody
> equality assertion failed
> - Expected: 1
> - Actual : 4
This is because only the first test that runs sees the testing CA
certificates that are copied in MacrosTest::setUpNssGpg(); when the
second test runs, they have somehow vanished.
This is because apparently SQLite on MacOSX, unlike on Linux, monitors
the file descriptors of its database files, and then invalidates itself
when setUpNssGpg() via osl::File::copy() renames and unlinks the
existing database files:
> cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib:
database integrity compromised by API violation: vnode renamed while in use:
core/workdir/CppunitTest/xmlsecurity_signing2.test.user/cert9.db.osl-tmp
> cppunittester[29873:5483181] [logging] invalidated open fd: 5 (0x20)
> cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib:
database integrity compromised by API violation: vnode unlinked while in use:
core/workdir/CppunitTest/xmlsecurity_signing2.test.user/cert9.db.osl-tmp
> cppunittester[29873:5483181] [logging] invalidated open fd: 5 (0x11)
> cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib:
database integrity compromised by API violation: vnode renamed while in use:
core/workdir/CppunitTest/xmlsecurity_signing2.test.user/key4.db.osl-tmp
> cppunittester[29873:5483181] [logging] invalidated open fd: 6 (0x20)
> cppunittester[29873:5483181] [logging] BUG IN CLIENT OF libsqlite3.dylib:
database integrity compromised by API violation: vnode unlinked while in use:
core/workdir/CppunitTest/xmlsecurity_signing2.test.user/key4.db.osl-tmp
> cppunittester[29873:5483181] [logging] invalidated open fd: 6 (0x11)
Split MacrosTest::setUpNssGpg()/tearDownNssGpg() into functions
setUpX509() which only does something on the 1st invocation, and
setUpGpg()/tearDownGpg() which may be invoked per-test (they could also
be run once for the whole test suite, but not obvious how to do that);
PDF related tests don't need GPG.
Presumably this is (along with the WNT-specific problem fixed in commit
3e9a700091872480dd085f0928d1d30b7d74cfd7) the reason why most of the
tests not only accept the expected result of SignatureState::OK but also
SignatureState::NOTVALIDATED.
Change-Id: I59b85ca651cecaccfdea729ed1e645c53079c8bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162693
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit 8d65e55fa02014d156b7e569466aceb8836837fa)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162715
Reviewed-by: Stephan Bergmann
diff --git a/filter/qa/pdf.cxx b/filter/qa/pdf.cxx
index 4b0ef3fa1af7..9ab11cd36d71 100644
--- a/filter/qa/pdf.cxx
+++ b/filter/qa/pdf.cxx
@@ -36,7 +36,6 @@ public:
}
void setUp() override;
-void tearDown() override;
void doTestCommentsInMargin(bool commentsInMarginEnabled);
};
@@ -44,14 +43,7 @@ void Test::setUp()
{
UnoApiTest::setUp();
-MacrosTest::setUpNssGpg(m_directories, "filter_pdf");
-}
-
-void Test::tearDown()
-{
-MacrosTest::tearDownNssGpg();
-
-UnoApiTest::tearDown();
+MacrosTest::setUpX509(m_directories, "filter_pdf");
}
CPPUNIT_TEST_FIXTURE(Test, testSignCertificateSubjectName)
diff --git a/include/unotest/macros_test.hxx b/include/unotest/macros_test.hxx
index c960ff76ea26..cf667125e8f0 100644
--- a/include/unotest/macros_test.hxx
+++ b/include/unotest/macros_test.hxx
@@ -96,8 +96,10 @@ public:
static std::unique_ptr parseExportStream(const OUString& url,
const OUString&
rStreamName);
-void setUpNssGpg(const test::Directories& rDirectories, const OUString&
rTestName);
-void tearDownNssGpg();
+// note: there is no tearDownX509
+void setUpX509(const test::Directories& rDirectories, const OUString&
rTestName);
+void setUpGpg(const test::Directories& rDirectories, const OUString&
[Bug 159464] New: Short text in sections combined with long endnotes makes parts of text hidden under red arrow
https://bugs.documentfoundation.org/show_bug.cgi?id=159464 Bug ID: 159464 Summary: Short text in sections combined with long endnotes makes parts of text hidden under red arrow Product: LibreOffice Version: 7.6.0.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lukasz.wlas...@hotmail.com Description: During using sections with endnotes at the end of section some parts of text are hidden under following conditions: Text in sections is shorter than a page (in my case most often around half of page) Endnotes are long and make text exceeds one page or reach almost page. After saving document and opening some parts of text are hidden under red arrow Steps to Reproduce: 1.Write text shorter than a page and make it section 2.Add around 5–6 long endnotes (20–30 rows) 3.Add new section after old section, save and open. Actual Results: Quite randomly it bugged. I attached example. Expected Results: Text shouldn't hide. Reproducible: Sometimes User Profile Reset: Yes Additional Info: Version: 7.6.0.3 (X86_64) / LibreOffice Community Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265 CPU threads: 12; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: pl-PL (pl_PL); UI: pl-PL Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159184] Test failure 24.2.0.1 final only on s390x: PngFilterTest
https://bugs.documentfoundation.org/show_bug.cgi?id=159184 --- Comment #2 from Gwyn Ciesla --- I'll do. I'll verify all the s390x-only test bugs against 24.2.0.3 and send one message. -- You are receiving this mail because: You are the assignee for the bug.
core.git: static/source
static/source/embindmaker/embindmaker.cxx | 99 +++---
1 file changed, 79 insertions(+), 20 deletions(-)
New commits:
commit 1b371a4e1fac86fb483a7e62225e130d3684bb59
Author: Stephan Bergmann
AuthorDate: Tue Jan 30 18:09:50 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 30 22:38:14 2024 +0100
embindmaker: Handle new-style services
Change-Id: I41309a20666c17f0c8c8d456943b3c78d0273905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162772
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index 2c707f9f118a..c7aba58c3089 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -118,11 +118,26 @@ std::pair
parseRegistryArgument(sal_uInt32 argument)
struct Module
{
std::map> modules;
-std::vector interfaces;
+std::vector> mappings;
};
+OUString
+getServiceConstructorName(unoidl::SingleInterfaceBasedServiceEntity::Constructor
const& constructor)
+{
+return constructor.defaultConstructor ? u"create"_ustr : constructor.name;
+}
+
+OUString jsName(OUString const& name) { return name.replace('.', '$'); }
+
+OUString
+jsServiceConstructor(OUString const& service,
+ unoidl::SingleInterfaceBasedServiceEntity::Constructor
const& constructor)
+{
+return "uno_Function_" + jsName(service) + "$$" +
getServiceConstructorName(constructor);
+}
+
void scan(rtl::Reference const& cursor, std::u16string_view
prefix,
- Module* module, std::vector& interfaces)
+ Module* module, std::vector& interfaces,
std::vector& services)
{
assert(cursor.is());
assert(module != nullptr);
@@ -145,13 +160,31 @@ void scan(rtl::Reference const&
cursor, std::u16string_view p
sub = std::make_shared();
}
scan(static_cast(ent.get())->createCursor(),
- Concat2View(name + "."), sub.get(), interfaces);
+ Concat2View(name + "."), sub.get(), interfaces, services);
break;
}
case unoidl::Entity::SORT_INTERFACE_TYPE:
-module->interfaces.emplace_back(name);
+module->mappings.emplace_back(id, "uno_Type_" + jsName(name));
interfaces.emplace_back(name);
break;
+case unoidl::Entity::SORT_SINGLE_INTERFACE_BASED_SERVICE:
+{
+auto const& ctors
+=
static_cast(ent.get())
+ ->getConstructors();
+if (!ctors.empty())
+{
+auto sub = std::make_shared();
+for (auto const& ctor : ctors)
+{
+
sub->mappings.emplace_back(getServiceConstructorName(ctor),
+ jsServiceConstructor(name,
ctor));
+}
+module->modules[id] = sub;
+services.emplace_back(name);
+}
+}
+break;
default:
break;
}
@@ -160,8 +193,6 @@ void scan(rtl::Reference const& cursor,
std::u16string_view p
OUString cppName(OUString const& name) { return "::" + name.replaceAll(u".",
u"::"); }
-OUString jsName(OUString const& name) { return name.replace('.', '$'); }
-
OUString resolveOuterTypedefs(rtl::Reference const& manager,
OUString const& name)
{
for (OUString n(name);;)
@@ -529,17 +560,32 @@ void dumpBase(std::ostream& out,
rtl::Reference const& manager,
dumpMethods(out, manager, interface, ent, baseTrail);
}
+void dumpRegisterFunctionProlog(std::ostream& out, unsigned long long& counter)
+{
+out << "static void __attribute__((noinline)) register" << counter << "() {
";
+}
+
+void dumpRegisterFunctionEpilog(std::ostream& out, unsigned long long& counter)
+{
+out << "}
";
+++counter;
+if (counter == 0)
+{
+std::cerr << "Emitting too many register functions
";
+std::exit(EXIT_FAILURE);
+}
+}
+
void writeJsMap(std::ostream& out, Module const& module, std::string const&
prefix)
{
auto comma = false;
-for (auto const& ifc : module.interfaces)
+for (auto const & [ id, to ] : module.mappings)
{
if (comma)
{
out << ",
";
}
-out << prefix << "'" << ifc.copy(ifc.lastIndexOf('.') + 1) << "':
instance.uno_Type_"
-<< jsName(ifc);
+out << prefix << "'" << id << "': instance." << to;
comma = true;
}
for (auto const & [ id, sub ] : module.modules)
@@ -589,9 +635,10 @@ SAL_IMPLEMENT_MAIN()
}
auto const module = std::make_shared();
std::vector interfaces;
+std::vector services;
for (auto const& prov : mgr->getPrimaryProviders())
core.git: static/source
static/source/unoembindhelpers/PrimaryBindings.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 4a806d6b02fcfa795dd4c47932e98f9fbc1b8ca8
Author: Stephan Bergmann
AuthorDate: Tue Jan 30 18:11:14 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 30 22:37:34 2024 +0100
Expose comphelper::getProcessComponentContext through Embind
Change-Id: I8b2cec04a1ffb99c33d39d8a63aa67778e960ab7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162773
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/unoembindhelpers/PrimaryBindings.cxx
b/static/source/unoembindhelpers/PrimaryBindings.cxx
index db75924b76f0..b57749170470 100644
--- a/static/source/unoembindhelpers/PrimaryBindings.cxx
+++ b/static/source/unoembindhelpers/PrimaryBindings.cxx
@@ -11,6 +11,7 @@
#include
+#include
#include
#include
#include
@@ -112,6 +113,7 @@ EMSCRIPTEN_BINDINGS(PrimaryBindings)
allow_raw_pointers());
function("getCurrentModelFromViewSh", );
+function("getUnoComponentContext",
::getProcessComponentContext);
}
#endif
[Bug 105537] [META] Assertion failed crashes
https://bugs.documentfoundation.org/show_bug.cgi?id=105537 Bug 105537 depends on bug 159386, which changed state. Bug 159386 Summary: Selecting all in a certain table causes assert in SfxPoolItem::SetWhich with a debug build https://bugs.documentfoundation.org/show_bug.cgi?id=159386 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159386] Selecting all in a certain table causes assert in SfxPoolItem::SetWhich with a debug build
https://bugs.documentfoundation.org/show_bug.cgi?id=159386 Caolán McNamara changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #11 from Caolán McNamara --- good enough, at least for now, I hope -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159386] Selecting all in a certain table causes assert in SfxPoolItem::SetWhich with a debug build
https://bugs.documentfoundation.org/show_bug.cgi?id=159386 --- Comment #10 from Commit Notification --- Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ed16c7fbdce8bf22d32d2a2b3d250e382ea404d9 Resolves: tdf#159386 deref of null result of Clone It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/uibase/uiview/viewstat.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ed16c7fbdce8bf22d32d2a2b3d250e382ea404d9
Author: Caolán McNamara
AuthorDate: Tue Jan 30 09:16:08 2024 +
Commit: Caolán McNamara
CommitDate: Tue Jan 30 22:32:59 2024 +0100
Resolves: tdf#159386 deref of null result of Clone
Change-Id: I8e903a20bd28c778a39418bc89e42ae1c6932dc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162736
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sw/source/uibase/uiview/viewstat.cxx
b/sw/source/uibase/uiview/viewstat.cxx
index 2bcb6844ac16..77182fa44efa 100644
--- a/sw/source/uibase/uiview/viewstat.cxx
+++ b/sw/source/uibase/uiview/viewstat.cxx
@@ -573,7 +573,7 @@ void SwView::GetState(SfxItemSet )
SfxPoolItemHolder aResult;
if(nAlias)
GetViewFrame().GetDispatcher()->QueryState(nAlias,
aResult);
-if(aResult)
+if (aResult && !IsInvalidItem(aResult.getItem()) &&
!IsDisabledItem(aResult.getItem()))
{
if (!(m_nSelectionType & SelectionType::DrawObject))
{
[Bug 159386] Selecting all in a certain table causes assert in SfxPoolItem::SetWhich with a debug build
https://bugs.documentfoundation.org/show_bug.cgi?id=159386 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: static/source
static/source/embindmaker/embindmaker.cxx | 174 +-
1 file changed, 148 insertions(+), 26 deletions(-)
New commits:
commit 7e0a4322147892021f3d93fb8de23ed293d575a7
Author: Stephan Bergmann
AuthorDate: Tue Jan 30 13:32:26 2024 +0100
Commit: Stephan Bergmann
CommitDate: Tue Jan 30 22:18:15 2024 +0100
embindmaker: Handle interface inheritance
Change-Id: I81e6f8a60bd34a9a3807adfb15c341303b9a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162771
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/static/source/embindmaker/embindmaker.cxx
b/static/source/embindmaker/embindmaker.cxx
index 0da6ce2ad41c..2c707f9f118a 100644
--- a/static/source/embindmaker/embindmaker.cxx
+++ b/static/source/embindmaker/embindmaker.cxx
@@ -10,13 +10,16 @@
#include
#include
+#include
#include
#include
#include
#include
+#include
#include
#include
#include
+#include
#include
#include
#include
@@ -159,21 +162,6 @@ OUString cppName(OUString const& name) { return "::" +
name.replaceAll(u".", u":
OUString jsName(OUString const& name) { return name.replace('.', '$'); }
-void dumpAttributes(std::ostream& out, OUString const& name,
-rtl::Reference const& entity)
-{
-for (auto const& attr : entity->getDirectAttributes())
-{
-out << ".function(\"get" << attr.name << "\", &" <<
cppName(name) << "::get"
-<< attr.name << ")
";
-if (!attr.readOnly)
-{
-out << ".function(\"set" << attr.name << "\", &" <<
cppName(name) << "::set"
-<< attr.name << ")
";
-}
-}
-}
-
OUString resolveOuterTypedefs(rtl::Reference const& manager,
OUString const& name)
{
for (OUString n(name);;)
@@ -346,6 +334,66 @@ void dumpType(std::ostream& out,
rtl::Reference const& manager,
}
}
+void dumpAttributes(std::ostream& out, rtl::Reference const&
manager,
+OUString const& name,
rtl::Reference const& entity,
+std::list const& baseTrail)
+{
+for (auto const& attr : entity->getDirectAttributes())
+{
+out << ".function(\"get" << attr.name << "\", ";
+if (baseTrail.empty())
+{
+out << "&" << cppName(name) << "::get" << attr.name;
+}
+else
+{
+out << "+[](::com::sun::star::uno::Reference<" << cppName(name)
+<< "> const & the_self) { return ";
+for (auto const& base : baseTrail)
+{
+out << "static_cast<" << cppName(base) << " *>(";
+}
+out << "the_self.get()";
+for (std::size_t i = 0; i != baseTrail.size(); ++i)
+{
+out << ")";
+}
+out << "->get" << attr.name << "(); }";
+}
+out << ")
";
+if (!attr.readOnly)
+{
+out << ".function(\"set" << attr.name << "\", ";
+if (baseTrail.empty())
+{
+out << "&" << cppName(name) << "::set" << attr.name;
+}
+else
+{
+out << "+[](::com::sun::star::uno::Reference<" << cppName(name)
+<< "> const & the_self, ";
+dumpType(out, manager, attr.type, false);
+if (passByReference(manager, attr.type))
+{
+out << " const &";
+}
+out << " the_value) { ";
+for (auto const& base : baseTrail)
+{
+out << "static_cast<" << cppName(base) << " *>(";
+}
+out << "the_self.get()";
+for (std::size_t i = 0; i != baseTrail.size(); ++i)
+{
+out << ")";
+}
+out << "->set" << attr.name << "(the_value); }";
+}
+out << ")
";
+}
+}
+}
+
void dumpParameters(std::ostream& out, rtl::Reference const&
manager,
unoidl::InterfaceTypeEntity::Method const& method, bool
declarations)
{
@@ -391,7 +439,8 @@ void dumpParameters(std::ostream& out,
rtl::Reference const& manage
}
void dumpWrapper(std::ostream& out, rtl::Reference const& manager,
- OUString const& interfaceName,
unoidl::InterfaceTypeEntity::Method const& method)
+ OUString const& interfaceName,
unoidl::InterfaceTypeEntity::Method const& method,
+ std::list const& baseTrail)
{
out << ".function(\"" << method.name << "\", +[](" <<
cppName(interfaceName);
out << " * the_self";
@@ -400,22 +449,35 @@ void dumpWrapper(std::ostream& out,
rtl::Reference const& manager,
out << ", ";
}
dumpParameters(out, manager, method, true);
-out << ") { return the_self->" << method.name << "(";
+out << ") { return ";
+for (auto const&
[Bug 159463] New: Changing which list style a paragraph style is associated with does not affect existing lists
https://bugs.documentfoundation.org/show_bug.cgi?id=159463 Bug ID: 159463 Summary: Changing which list style a paragraph style is associated with does not affect existing lists Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ka...@goodtimes.fi Steps to reproduce: 1. Pick a list paragraph style and associate it with a list style. 2. Create a list using the style. 3. Edit the list paragraph style again and associate it with a different list style. Expected results: The list created in step 2 is updated to reflect the list style now associated with the paragraph style. Actual results: The list is stuck with the original list style. -- You are receiving this mail because: You are the assignee for the bug.
core.git: bin/lo-xlate-lang
bin/lo-xlate-lang |1 + 1 file changed, 1 insertion(+) New commits: commit 82e90e1b2a8873334f1fcd00dde769e45af37b5b Author: Rene Engelhard AuthorDate: Sat Jan 27 18:03:37 2024 +0100 Commit: René Engelhard CommitDate: Tue Jan 30 21:03:34 2024 +0100 add hy to bin/lo-xlate-lang Change-Id: I1205da81fc179affa58478860928e74a501d4c0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162644 Tested-by: René Engelhard Tested-by: Jenkins Reviewed-by: René Engelhard diff --git a/bin/lo-xlate-lang b/bin/lo-xlate-lang index 06530621731a..9b939012e99a 100755 --- a/bin/lo-xlate-lang +++ b/bin/lo-xlate-lang @@ -177,6 +177,7 @@ __DATA__ :am:amharic :gug:guarani :szl:upper_silesian +:hy:armenian 01:en-US:english_american 03:pt:portuguese 07:ru:russian
core.git: Branch 'libreoffice-24-2' - include/svx sc/qa svx/source
include/svx/svdpagv.hxx | 10 --
sc/qa/unit/tiledrendering/data/invalidate-on-save.ods |binary
sc/qa/unit/tiledrendering/tiledrendering.cxx | 30 ++
svx/source/svdraw/svdpagv.cxx | 17 +++---
svx/source/svdraw/svdpntv.cxx | 15 ++---
5 files changed, 53 insertions(+), 19 deletions(-)
New commits:
commit 0690f0cc3683dbe47ae237b3a00d02ba4db6966c
Author: Caolán McNamara
AuthorDate: Thu Jan 18 09:31:17 2024 +
Commit: Caolán McNamara
CommitDate: Tue Jan 30 20:59:57 2024 +0100
cool#7769 Reduce unnecessary invalidations on calc save
https://github.com/CollaboraOnline/online/issues/7769
Reduce unnecessary invalidations. Don't invalidate windows
if layer visibility didn't really change.
Change-Id: Ic2abd78d60aea2e8676c8e56608cf51e941f5918
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162301
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/include/svx/svdpagv.hxx b/include/svx/svdpagv.hxx
index 777ca7d9b1b2..58354a3d8d50 100644
--- a/include/svx/svdpagv.hxx
+++ b/include/svx/svdpagv.hxx
@@ -102,7 +102,8 @@ public:
private:
void ImpInvalidateHelpLineArea(sal_uInt16 nNum) const;
-void SetLayer(const OUString& rName, SdrLayerIDSet& rBS, bool bJa);
+// return true if changed, false if unchanged
+bool SetLayer(const OUString& rName, SdrLayerIDSet& rBS, bool bJa);
bool IsLayer(const OUString& rName, const SdrLayerIDSet& rBS) const;
/// Let's see if the current Group (pCurrentGroup) is still inserted
@@ -182,10 +183,13 @@ public:
tools::Rectangle& MarkBound() { return aMarkBound; }
tools::Rectangle& MarkSnap() { return aMarkSnap; }
-void SetLayerVisible(const OUString& rName, bool bShow) {
-SetLayer(rName, aLayerVisi, bShow);
+bool SetLayerVisible(const OUString& rName, bool bShow) {
+const bool bChanged = SetLayer(rName, aLayerVisi, bShow);
+if (!bChanged)
+return false;
if(!bShow) AdjHdl();
InvalidateAllWin();
+return true;
}
bool IsLayerVisible(const OUString& rName) const { return IsLayer(rName,
aLayerVisi); }
diff --git a/sc/qa/unit/tiledrendering/data/invalidate-on-save.ods
b/sc/qa/unit/tiledrendering/data/invalidate-on-save.ods
new file mode 100644
index ..efe2c225a410
Binary files /dev/null and
b/sc/qa/unit/tiledrendering/data/invalidate-on-save.ods differ
diff --git a/sc/qa/unit/tiledrendering/tiledrendering.cxx
b/sc/qa/unit/tiledrendering/tiledrendering.cxx
index 00fda9336f4a..9e07c0c060c7 100644
--- a/sc/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sc/qa/unit/tiledrendering/tiledrendering.cxx
@@ -3113,6 +3113,36 @@ CPPUNIT_TEST_FIXTURE(ScTiledRenderingTest,
testGetViewRenderState)
CPPUNIT_ASSERT_EQUAL(";Default"_ostr, pModelObj->getViewRenderState());
}
+// Saving shouldn't trigger an invalidation
+CPPUNIT_TEST_FIXTURE(ScTiledRenderingTest, testNoInvalidateOnSave)
+{
+comphelper::LibreOfficeKit::setCompatFlag(
+comphelper::LibreOfficeKit::Compat::scPrintTwipsMsgs);
+
+loadFromFile(u"invalidate-on-save.ods");
+
+// .uno:Save modifies the original file, make a copy first
+saveAndReload("calc8");
+ScModelObj* pModelObj =
comphelper::getFromUnoTunnel(mxComponent);
+CPPUNIT_ASSERT(pModelObj);
+
pModelObj->initializeForTiledRendering(uno::Sequence());
+
+ScTabViewShell* pView =
dynamic_cast(SfxViewShell::Current());
+CPPUNIT_ASSERT(pView);
+
+Scheduler::ProcessEventsToIdle();
+
+// track invalidations
+ViewCallback aView;
+
+uno::Sequence aArgs;
+dispatchCommand(mxComponent, ".uno:Save", aArgs);
+
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT(!aView.m_bInvalidateTiles);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/svx/source/svdraw/svdpagv.cxx b/svx/source/svdraw/svdpagv.cxx
index 86210865e72c..4e5d7a47286c 100644
--- a/svx/source/svdraw/svdpagv.cxx
+++ b/svx/source/svdraw/svdpagv.cxx
@@ -557,15 +557,22 @@ void SdrPageView::AdjHdl()
GetView().AdjustMarkHdl();
}
-void SdrPageView::SetLayer(const OUString& rName, SdrLayerIDSet& rBS, bool bJa)
+// return true if changed, false if unchanged
+bool SdrPageView::SetLayer(const OUString& rName, SdrLayerIDSet& rBS, bool bJa)
{
-if(!GetPage())
-return;
+if (!GetPage())
+return false;
SdrLayerID nID = GetPage()->GetLayerAdmin().GetLayerID(rName);
-if(SDRLAYER_NOTFOUND != nID)
-rBS.Set(nID, bJa);
+if (SDRLAYER_NOTFOUND == nID)
+return false;
+
+if (rBS.IsSet(nID) == bJa)
+return false;
+
+rBS.Set(nID, bJa);
+return true;
}
bool SdrPageView::IsLayer(const OUString& rName, const SdrLayerIDSet& rBS)
const
diff --git a/svx/source/svdraw/svdpntv.cxx b/svx/source/svdraw/svdpntv.cxx
index
core.git: Branch 'distro/collabora/co-24.04' - chart2/source
chart2/source/controller/main/ChartController.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 350789a2477653d4e7de9acd1be055c755d61b21
Author: Caolán McNamara
AuthorDate: Sun Jan 28 14:37:39 2024 +
Commit: Caolán McNamara
CommitDate: Tue Jan 30 20:59:06 2024 +0100
When chart is active pass uno:ChangeTheme through to its parent frame
so theme changes can happen when chart has control of the UI
Change-Id: Id7fd17d697d5ff8c03f1f46d80894e4f69cb9b9d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162620
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/chart2/source/controller/main/ChartController.cxx
b/chart2/source/controller/main/ChartController.cxx
index 666d6b636740..ae09e6813dd5 100644
--- a/chart2/source/controller/main/ChartController.cxx
+++ b/chart2/source/controller/main/ChartController.cxx
@@ -55,6 +55,7 @@
#include
#include
+#include
#include
#include
@@ -1302,6 +1303,8 @@ void SAL_CALL ChartController::dispatch(
}
}
}
+else if( aCommand == "ChangeTheme" )
+comphelper::dispatchCommand(".uno:ChangeTheme", getFrame(), rArgs);
}
void SAL_CALL ChartController::addStatusListener(
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Bug 133092 depends on bug 151352, which changed state. Bug 151352 Summary: CRASH: closing form while the tip of the day dialog is displayed https://bugs.documentfoundation.org/show_bug.cgi?id=151352 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 125257] [META] Tip of the day
https://bugs.documentfoundation.org/show_bug.cgi?id=125257 Bug 125257 depends on bug 151352, which changed state. Bug 151352 Summary: CRASH: closing form while the tip of the day dialog is displayed https://bugs.documentfoundation.org/show_bug.cgi?id=151352 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: cui/source
cui/source/dialogs/tipofthedaydlg.cxx | 28 ++--
cui/source/inc/tipofthedaydlg.hxx |2 +-
2 files changed, 11 insertions(+), 19 deletions(-)
New commits:
commit b01a9f8c9da419969575d0dc20e7346306ae96d3
Author: Caolán McNamara
AuthorDate: Tue Jan 30 11:40:01 2024 +
Commit: Caolán McNamara
CommitDate: Tue Jan 30 20:51:15 2024 +0100
tdf#151352 keep a reference to the parent
and use that in the dtor instead of a pointer.
FWIW the XWindow isn't actually a vcl::Window in the Gtk case, so
VCLUnoHelper::GetWindow doesn't do anything there. But using an
XWindow gives a safe view wrt life cycle.
Change-Id: I4d0fd707ea931a76d6f87f434f7ece8df066785c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162744
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/cui/source/dialogs/tipofthedaydlg.cxx
b/cui/source/dialogs/tipofthedaydlg.cxx
index f1cb7afc2c1f..bbb26a054be9 100644
--- a/cui/source/dialogs/tipofthedaydlg.cxx
+++ b/cui/source/dialogs/tipofthedaydlg.cxx
@@ -50,7 +50,7 @@ const Size ThumbSize(150, 150);
TipOfTheDayDialog::TipOfTheDayDialog(weld::Window* pParent)
: GenericDialogController(pParent, "cui/ui/tipofthedaydialog.ui",
"TipOfTheDayDialog")
-, m_pParent(pParent)
+, m_xParent(pParent ? pParent->GetXWindow() : nullptr)
, m_pText(m_xBuilder->weld_label("lbText"))
, m_pShowTip(m_xBuilder->weld_check_button("cbShowTip"))
, m_pNext(m_xBuilder->weld_button("btnNext"))
@@ -62,15 +62,11 @@ TipOfTheDayDialog::TipOfTheDayDialog(weld::Window* pParent)
m_nCurrentTip = officecfg::Office::Common::Misc::LastTipOfTheDayID::get();
m_pPreview->set_size_request(ThumbSize.Width(), ThumbSize.Height());
-if (pParent != nullptr)
+if (m_xParent.is())
{
-css::uno::Reference xWindow = pParent->GetXWindow();
-if (xWindow.is())
-{
-VclPtr xVclWin(VCLUnoHelper::GetWindow(xWindow));
-if (xVclWin != nullptr)
-xVclWin->AddEventListener(LINK(this, TipOfTheDayDialog,
Terminated));
-}
+VclPtr xVclWin(VCLUnoHelper::GetWindow(m_xParent));
+if (xVclWin != nullptr)
+xVclWin->AddEventListener(LINK(this, TipOfTheDayDialog,
Terminated));
}
const auto t0 = std::chrono::system_clock::now().time_since_epoch();
@@ -94,7 +90,7 @@ IMPL_LINK(TipOfTheDayDialog, Terminated, VclWindowEvent&,
rEvent, void)
{
if (rEvent.GetId() == VclEventId::ObjectDying)
{
-m_pParent = nullptr;
+m_xParent.clear();
TipOfTheDayDialog::response(RET_OK);
}
}
@@ -107,15 +103,11 @@ TipOfTheDayDialog::~TipOfTheDayDialog()
officecfg::Office::Common::Misc::ShowTipOfTheDay::set(m_pShowTip->get_active(),
xChanges);
xChanges->commit();
-if (m_pParent != nullptr)
+if (m_xParent.is())
{
-css::uno::Reference xWindow =
m_pParent->GetXWindow();
-if (xWindow.is())
-{
-VclPtr xVclWin(VCLUnoHelper::GetWindow(xWindow));
-if (xVclWin != nullptr)
-xVclWin->RemoveEventListener(LINK(this, TipOfTheDayDialog,
Terminated));
-}
+VclPtr xVclWin(VCLUnoHelper::GetWindow(m_xParent));
+if (xVclWin != nullptr)
+xVclWin->RemoveEventListener(LINK(this, TipOfTheDayDialog,
Terminated));
}
}
diff --git a/cui/source/inc/tipofthedaydlg.hxx
b/cui/source/inc/tipofthedaydlg.hxx
index 69af1996e454..1f86d1bf238c 100644
--- a/cui/source/inc/tipofthedaydlg.hxx
+++ b/cui/source/inc/tipofthedaydlg.hxx
@@ -27,7 +27,7 @@ class TipOfTheDayDialog : public weld::GenericDialogController
{
private:
CuiGraphicPreviewWindow m_aPreview;
-weld::Window* m_pParent;
+css::uno::Reference m_xParent;
std::unique_ptr m_pText;
std::unique_ptr m_pShowTip;
[Bug 158997] Calc Format>Columns>Optimal Width (with no extra width) causes some columns to be too narrow
https://bugs.documentfoundation.org/show_bug.cgi?id=158997 --- Comment #32 from OfficeUser --- > (note that the text width for pair kerning on has slightly increased > somewhere between 7.6.4 and patch~1, which explains the slight change from > 20.97 to 21.11 in my previous test.) How do you come to that conclusion, that this is not caused by Caolán's patch? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159131] Calc v7.5 is laggy when moving a line (row)
https://bugs.documentfoundation.org/show_bug.cgi?id=159131 Noel Grandin changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - sw/source
sw/source/ui/dialog/swdlgfact.cxx |8 +++-
sw/source/ui/dialog/swdlgfact.hxx |5 +++--
sw/source/uibase/shells/textsh1.cxx | 14 ++
sw/source/uibase/uiview/view0.cxx |9 +++--
4 files changed, 27 insertions(+), 9 deletions(-)
New commits:
commit 84572ef8c27fc4d4a7720303972f877ed2db8f79
Author: Noel Grandin
AuthorDate: Tue Jan 30 16:14:08 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 30 20:13:17 2024 +0100
make redline-accept dialog async
Change-Id: Ib0cd3145b1f2d12926c1c17335551f0ba576bd7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162763
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index 46825f29a320..a0f7ec33225f 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -283,7 +283,13 @@ short AbstractSwContentControlListItemDlg_Impl::Execute()
short AbstractSwModalRedlineAcceptDlg_Impl::Execute()
{
-return m_xDlg->run();
+assert(false);
+return -1;
+}
+
+bool
AbstractSwModalRedlineAcceptDlg_Impl::StartExecuteAsync(VclAbstractDialog::AsyncContext&
rCtx)
+{
+return weld::DialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
}
short AbstractGlossaryDlg_Impl::Execute()
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 88e9d2b632c7..9e04a8b70db3 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -509,13 +509,14 @@ public:
class AbstractSwModalRedlineAcceptDlg_Impl : public
AbstractSwModalRedlineAcceptDlg
{
-std::unique_ptr m_xDlg;
+std::shared_ptr m_xDlg;
public:
-explicit
AbstractSwModalRedlineAcceptDlg_Impl(std::unique_ptr p)
+explicit
AbstractSwModalRedlineAcceptDlg_Impl(std::shared_ptr p)
: m_xDlg(std::move(p))
{
}
virtual short Execute() override;
+virtual bool StartExecuteAsync(VclAbstractDialog::AsyncContext &) override;
};
class SwGlossaryDlg;
diff --git a/sw/source/uibase/shells/textsh1.cxx
b/sw/source/uibase/shells/textsh1.cxx
index 1a70f027fdef..a1680e5be43a 100644
--- a/sw/source/uibase/shells/textsh1.cxx
+++ b/sw/source/uibase/shells/textsh1.cxx
@@ -1253,10 +1253,16 @@ void SwTextShell::Execute(SfxRequest )
rVFrame.ToggleChildWindow(FN_REDLINE_ACCEPT);
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
-ScopedVclPtr
xDlg(pFact->CreateSwModalRedlineAcceptDlg(GetView().GetEditWin().GetFrameWeld()));
-
-xDlg->Execute();
-rReq.Done();
+auto xRequest = std::make_shared(rReq);
+rReq.Ignore(); // the 'old' request is not relevant any more
+VclPtr
pDlg(pFact->CreateSwModalRedlineAcceptDlg(GetView().GetEditWin().GetFrameWeld()));
+pDlg->StartExecuteAsync(
+[pDlg, xRequest] (sal_Int32 /*nResult*/)->void
+{
+pDlg->disposeOnce();
+xRequest->Done();
+}
+);
}
break;
commit 9f5dd47de9c0dc9e95980fa08b4358aa9228c5c0
Author: Noel Grandin
AuthorDate: Tue Jan 30 16:10:17 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 30 20:13:07 2024 +0100
make outline-tab dialog async
Change-Id: Ie4fd5e9893af6687230bc2a02d4459a1140d0e6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162762
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/source/uibase/uiview/view0.cxx
b/sw/source/uibase/uiview/view0.cxx
index 4e9b743b6cd6..2a27bd95b5a9 100644
--- a/sw/source/uibase/uiview/view0.cxx
+++ b/sw/source/uibase/uiview/view0.cxx
@@ -752,8 +752,13 @@ void SwView::ExecNumberingOutline(SfxItemPool & rPool)
{
SfxItemSetFixed aTmp(rPool);
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
-ScopedVclPtr
pDlg(pFact->CreateOutlineTabDialog(GetFrameWeld(), , GetWrtShell()));
-pDlg->Execute();
+VclPtr
pDlg(pFact->CreateOutlineTabDialog(GetFrameWeld(), , GetWrtShell()));
+pDlg->StartExecuteAsync(
+[pDlg] (sal_Int32 /*nResult*/)->void
+{
+pDlg->disposeOnce();
+}
+);
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
core.git: 2 commits - sw/inc sw/source
sw/inc/swabstdlg.hxx | 10 +-
sw/source/ui/dialog/swdlgfact.cxx| 18 +++---
sw/source/ui/dialog/swdlgfact.hxx| 16 ++--
sw/source/ui/table/rowht.cxx |8
sw/source/uibase/inc/insfnote.hxx| 10 +-
sw/source/uibase/inc/rowht.hxx |5 +
sw/source/uibase/shells/tabsh.cxx| 11 +--
sw/source/uibase/shells/textsh1.cxx | 30 ++
sw/source/uibase/uiview/viewdlg2.cxx | 11 +--
9 files changed, 72 insertions(+), 47 deletions(-)
New commits:
commit 95dc399434ea08b7c762f918d0c6360ef3e0e179
Author: Noel Grandin
AuthorDate: Tue Jan 30 15:57:46 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 30 20:12:58 2024 +0100
make set-row-height dialog async
Change-Id: I03e27c09da4f8b58468d4e551413946f03b25f1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162761
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 621ac8cd666f..c8974620060e 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -436,6 +436,13 @@ public:
virtual void Apply() = 0;
};
+class AbstractSwTableHeightDlg : public VclAbstractDialog
+{
+protected:
+virtual ~AbstractSwTableHeightDlg() override = default;
+public:
+virtual void Apply() = 0;
+};
class SwAbstractDialogFactory
{
@@ -497,7 +504,7 @@ public:
virtual VclPtr
CreateSwSelGlossaryDlg(weld::Window *pParent, const OUString ) = 0;
virtual VclPtr CreateSwSortingDialog(weld::Window
*pParent, SwWrtShell ) = 0;
-virtual VclPtr CreateSwTableHeightDialog(weld::Window
*pParent, SwWrtShell ) = 0;
+virtual VclPtr
CreateSwTableHeightDialog(weld::Window *pParent, SwWrtShell ) = 0;
virtual VclPtr CreateSwColumnDialog(weld::Window
*pParent, SwWrtShell ) = 0;
virtual VclPtr
CreateSplitTableDialog(weld::Window* pParent, SwWrtShell ) = 0;
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index 66a77db67b4b..46825f29a320 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -155,7 +155,13 @@ bool
AbstractSwTableWidthDlg_Impl::StartExecuteAsync(AsyncContext )
short AbstractSwTableHeightDlg_Impl::Execute()
{
-return m_xDlg->run();
+assert(false);
+return -1;
+}
+
+bool AbstractSwTableHeightDlg_Impl::StartExecuteAsync(AsyncContext )
+{
+return weld::GenericDialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
}
short AbstractSwMergeTableDlg_Impl::Execute()
@@ -1128,7 +1134,7 @@ VclPtr
SwAbstractDialogFactory_Impl::CreateSwColumnDialog(wel
return
VclPtr::Create(std::make_shared(pParent,
rSh));
}
-VclPtr
SwAbstractDialogFactory_Impl::CreateSwTableHeightDialog(weld::Window *pParent,
SwWrtShell )
+VclPtr
SwAbstractDialogFactory_Impl::CreateSwTableHeightDialog(weld::Window *pParent,
SwWrtShell )
{
return
VclPtr::Create(std::make_unique(pParent,
rSh));
}
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 5ebcbdd7509e..88e9d2b632c7 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -271,15 +271,17 @@ public:
virtual void Apply() override { m_xDlg->Apply(); }
};
-class AbstractSwTableHeightDlg_Impl : public VclAbstractDialog
+class AbstractSwTableHeightDlg_Impl : public AbstractSwTableHeightDlg
{
-std::unique_ptr m_xDlg;
+std::shared_ptr m_xDlg;
public:
-explicit AbstractSwTableHeightDlg_Impl(std::unique_ptr p)
+explicit AbstractSwTableHeightDlg_Impl(std::shared_ptr p)
: m_xDlg(std::move(p))
{
}
virtual short Execute() override;
+virtual bool StartExecuteAsync(AsyncContext ) override;
+virtual void Apply() override { m_xDlg->Apply(); }
};
class AbstractSwMergeTableDlg_Impl : public VclAbstractDialog
@@ -795,7 +797,7 @@ public:
virtual VclPtr CreateSwAutoMarkDialog(weld::Window
*pParent, SwWrtShell ) override;
virtual VclPtr
CreateSwSelGlossaryDlg(weld::Window *pParent, const OUString )
override;
virtual VclPtr CreateSwSortingDialog(weld::Window
*pParent, SwWrtShell ) override;
-virtual VclPtr CreateSwTableHeightDialog(weld::Window
*pParent, SwWrtShell ) override;
+virtual VclPtr
CreateSwTableHeightDialog(weld::Window *pParent, SwWrtShell ) override;
virtual VclPtr CreateSwColumnDialog(weld::Window
*pParent, SwWrtShell ) override;
virtual VclPtr
CreateSplitTableDialog(weld::Window* pParent, SwWrtShell ) override;
diff --git a/sw/source/ui/table/rowht.cxx b/sw/source/ui/table/rowht.cxx
index f46297bf7de5..7a7c26906f5e 100644
--- a/sw/source/ui/table/rowht.cxx
+++ b/sw/source/ui/table/rowht.cxx
@@ -61,12 +61,4 @@ SwTableHeightDlg::SwTableHeightDlg(weld::Window *pParent,
SwWrtShell )
}
}
-short SwTableHeightDlg::run()
-{
-short nRet = GenericDialogController::run();
-if (nRet == RET_OK)
-
core.git: 2 commits - sw/inc sw/source
sw/inc/swabstdlg.hxx| 10 +-
sw/source/ui/dbui/dbinsdlg.cxx | 15 ---
sw/source/ui/dialog/swdlgfact.cxx | 18 +++---
sw/source/ui/dialog/swdlgfact.hxx | 16 ++--
sw/source/ui/misc/srtdlg.cxx|8
sw/source/ui/table/convert.cxx | 12 +---
sw/source/ui/table/tautofmt.cxx |6 ++
sw/source/uibase/inc/srtdlg.hxx |3 +--
sw/source/uibase/inc/tautofmt.hxx |4 ++--
sw/source/uibase/shells/tabsh.cxx | 11 +--
sw/source/uibase/shells/textsh1.cxx | 15 ---
11 files changed, 81 insertions(+), 37 deletions(-)
New commits:
commit b70d96db53085bdd4e66c22857590d5b2cd391f9
Author: Noel Grandin
AuthorDate: Tue Jan 30 15:36:56 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 30 20:12:38 2024 +0100
make sorting dialog async
Change-Id: I9773ec07e13144662a06307452b17f9e96527e89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162759
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 597781c04f13..4ea4085f387e 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -419,6 +419,13 @@ public:
virtual std::optional GetSelectedLanguage() = 0;
};
+class AbstractSwSortDlg : public VclAbstractDialog
+{
+protected:
+virtual ~AbstractSwSortDlg() override = default;
+public:
+virtual void Apply() = 0;
+};
class AbstractSwTableWidthDlg : public VclAbstractDialog
{
@@ -488,7 +495,7 @@ public:
virtual VclPtr
CreateSwSelGlossaryDlg(weld::Window *pParent, const OUString ) = 0;
-virtual VclPtr CreateSwSortingDialog(weld::Window
*pParent, SwWrtShell ) = 0;
+virtual VclPtr CreateSwSortingDialog(weld::Window
*pParent, SwWrtShell ) = 0;
virtual VclPtr CreateSwTableHeightDialog(weld::Window
*pParent, SwWrtShell ) = 0;
virtual VclPtr CreateSwColumnDialog(weld::Window
*pParent, SwWrtShell ) = 0;
virtual VclPtr
CreateSplitTableDialog(weld::Window* pParent, SwWrtShell ) = 0;
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index 155a8d854571..5b26dcd38c59 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -185,7 +185,13 @@ bool
AbstractGenericDialog_Impl::StartExecuteAsync(AsyncContext )
short AbstractSwSortDlg_Impl::Execute()
{
-return m_xDlg->run();
+assert(false);
+return -1;
+}
+
+bool AbstractSwSortDlg_Impl::StartExecuteAsync(AsyncContext )
+{
+return weld::GenericDialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
}
short AbstractMultiTOXMarkDlg_Impl::Execute()
@@ -1121,7 +1127,7 @@ VclPtr
SwAbstractDialogFactory_Impl::CreateSwTableHeightDialo
return
VclPtr::Create(std::make_unique(pParent,
rSh));
}
-VclPtr
SwAbstractDialogFactory_Impl::CreateSwSortingDialog(weld::Window *pParent,
SwWrtShell )
+VclPtr
SwAbstractDialogFactory_Impl::CreateSwSortingDialog(weld::Window *pParent,
SwWrtShell )
{
return
VclPtr::Create(std::make_unique(pParent,
rSh));
}
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 2a67b5547d64..92e565f5bfcf 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -185,15 +185,17 @@ public:
virtual bool StartExecuteAsync(AsyncContext ) override;
};
-class AbstractSwSortDlg_Impl : public VclAbstractDialog
+class AbstractSwSortDlg_Impl : public AbstractSwSortDlg
{
-std::unique_ptr m_xDlg;
+std::shared_ptr m_xDlg;
public:
-explicit AbstractSwSortDlg_Impl(std::unique_ptr p)
+explicit AbstractSwSortDlg_Impl(std::shared_ptr p)
: m_xDlg(std::move(p))
{
}
virtual short Execute() override;
+virtual bool StartExecuteAsync(AsyncContext ) override;
+virtual void Apply() override { m_xDlg->Apply(); }
};
class AbstractMultiTOXMarkDlg_Impl : public VclAbstractDialog
@@ -790,7 +792,7 @@ public:
virtual VclPtr CreateSwAutoMarkDialog(weld::Window
*pParent, SwWrtShell ) override;
virtual VclPtr
CreateSwSelGlossaryDlg(weld::Window *pParent, const OUString )
override;
-virtual VclPtr CreateSwSortingDialog(weld::Window
*pParent, SwWrtShell ) override;
+virtual VclPtr CreateSwSortingDialog(weld::Window
*pParent, SwWrtShell ) override;
virtual VclPtr CreateSwTableHeightDialog(weld::Window
*pParent, SwWrtShell ) override;
virtual VclPtr CreateSwColumnDialog(weld::Window
*pParent, SwWrtShell ) override;
virtual VclPtr
CreateSplitTableDialog(weld::Window* pParent, SwWrtShell ) override;
diff --git a/sw/source/ui/misc/srtdlg.cxx b/sw/source/ui/misc/srtdlg.cxx
index 724390ff6edb..49ffa058636f 100644
--- a/sw/source/ui/misc/srtdlg.cxx
+++ b/sw/source/ui/misc/srtdlg.cxx
@@ -217,14 +217,6 @@ sal_Unicode SwSortDlg::GetDelimChar() const
return cRet;
}
-short SwSortDlg::run()
-{
-short nRet = GenericDialogController::run();
-
[Bug 159131] Calc v7.5 is laggy when moving a line (row)
https://bugs.documentfoundation.org/show_bug.cgi?id=159131 Commit Notification changed: What|Removed |Added Whiteboard||target:24.8.0 -- You are receiving this mail because: You are the assignee for the bug.
core.git: 2 commits - sc/source sw/inc sw/source
sc/source/core/data/colcontainer.cxx |5 +---
sc/source/core/data/table2.cxx |2 +
sw/inc/swabstdlg.hxx |1
sw/source/ui/dialog/swdlgfact.cxx|8 +-
sw/source/ui/dialog/swdlgfact.hxx|6 +++--
sw/source/ui/misc/glossary.cxx |8 --
sw/source/uibase/dochdl/gloshdl.cxx | 42 +--
sw/source/uibase/inc/glossary.hxx|3 --
sw/source/uibase/shells/textglos.cxx |3 --
9 files changed, 44 insertions(+), 34 deletions(-)
New commits:
commit b4e5aa7bffc32aa15359808085cc69638467f5d5
Author: Noel Grandin
AuthorDate: Tue Jan 30 15:22:36 2024 +0200
Commit: Noel Grandin
CommitDate: Tue Jan 30 20:12:20 2024 +0100
make glossary dialog async
Change-Id: I7ed5da9e06656bc658728b8e61b02f767ddd6bb4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162750
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 65fbf918efca..f9398ad73fca 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -93,6 +93,7 @@ class AbstractGlossaryDlg : public VclAbstractDialog
protected:
virtual ~AbstractGlossaryDlg() override = default;
public:
+virtual void Apply() = 0;
virtual OUStringGetCurrGrpName() const = 0;
virtual OUStringGetCurrShortName() const = 0;
};
diff --git a/sw/source/ui/dialog/swdlgfact.cxx
b/sw/source/ui/dialog/swdlgfact.cxx
index 8676ec08a8d2..8b79dc4446bf 100644
--- a/sw/source/ui/dialog/swdlgfact.cxx
+++ b/sw/source/ui/dialog/swdlgfact.cxx
@@ -270,7 +270,13 @@ short AbstractSwModalRedlineAcceptDlg_Impl::Execute()
short AbstractGlossaryDlg_Impl::Execute()
{
-return m_xDlg->run();
+assert(false);
+return -1;
+}
+
+bool AbstractGlossaryDlg_Impl::StartExecuteAsync(AsyncContext )
+{
+return weld::GenericDialogController::runAsync(m_xDlg, rCtx.maEndDialogFn);
}
short AbstractFieldInputDlg_Impl::Execute()
diff --git a/sw/source/ui/dialog/swdlgfact.hxx
b/sw/source/ui/dialog/swdlgfact.hxx
index 2fd0b0b70183..c8c6de47d489 100644
--- a/sw/source/ui/dialog/swdlgfact.hxx
+++ b/sw/source/ui/dialog/swdlgfact.hxx
@@ -515,13 +515,15 @@ public:
class SwGlossaryDlg;
class AbstractGlossaryDlg_Impl : public AbstractGlossaryDlg
{
-std::unique_ptr m_xDlg;
+std::shared_ptr m_xDlg;
public:
-explicit AbstractGlossaryDlg_Impl(std::unique_ptr p)
+explicit AbstractGlossaryDlg_Impl(std::shared_ptr p)
: m_xDlg(std::move(p))
{
}
virtual short Execute() override;
+virtual bool StartExecuteAsync(AsyncContext ) override;
+virtual void Apply() override { m_xDlg->Apply(); }
virtual OUStringGetCurrGrpName() const override;
virtual OUStringGetCurrShortName() const override;
};
diff --git a/sw/source/ui/misc/glossary.cxx b/sw/source/ui/misc/glossary.cxx
index 9769e78d8a0c..c68d4d75f86f 100644
--- a/sw/source/ui/misc/glossary.cxx
+++ b/sw/source/ui/misc/glossary.cxx
@@ -421,14 +421,6 @@ IMPL_LINK(SwGlossaryDlg, GrpSelect, weld::TreeView&, rBox,
void)
}
}
-short SwGlossaryDlg::run()
-{
-short nRet = SfxDialogController::run();
-if (nRet == RET_OK)
-Apply();
-return nRet;
-}
-
void SwGlossaryDlg::Apply()
{
const OUString aGlosName(m_xShortNameEdit->get_text());
diff --git a/sw/source/uibase/dochdl/gloshdl.cxx
b/sw/source/uibase/dochdl/gloshdl.cxx
index e70ed7ffc4b2..dcc90033cd9b 100644
--- a/sw/source/uibase/dochdl/gloshdl.cxx
+++ b/sw/source/uibase/dochdl/gloshdl.cxx
@@ -69,25 +69,35 @@ struct TextBlockInfo_Impl
void SwGlossaryHdl::GlossaryDlg()
{
SwAbstractDialogFactory* pFact = SwAbstractDialogFactory::Create();
-ScopedVclPtr
pDlg(pFact->CreateGlossaryDlg(m_rViewFrame, this, m_pWrtShell));
-OUString sName;
-OUString sShortName;
+VclPtr pDlg(pFact->CreateGlossaryDlg(m_rViewFrame,
this, m_pWrtShell));
-if( RET_EDIT == pDlg->Execute() )
-{
-sName = pDlg->GetCurrGrpName();
-sShortName = pDlg->GetCurrShortName();
-}
+pDlg->StartExecuteAsync(
+[this, pDlg] (sal_Int32 nResult)->void
+{
+OUString sName;
+OUString sShortName;
+if (nResult == RET_OK)
+pDlg->Apply();
+if (nResult == RET_EDIT)
+{
+sName = pDlg->GetCurrGrpName();
+sShortName = pDlg->GetCurrShortName();
+}
+pDlg->disposeOnce();
+m_pCurGrp.reset();
+if(HasGlossaryList())
+{
+GetGlossaryList()->ClearGroups();
+}
-pDlg.disposeAndClear();
-m_pCurGrp.reset();
-if(HasGlossaryList())
-{
-GetGlossaryList()->ClearGroups();
-}
+if( !sName.isEmpty() || !sShortName.isEmpty() )
+m_rStatGlossaries.EditGroupDoc( sName, sShortName );
-if( !sName.isEmpty() || !sShortName.isEmpty() )
-
[Bug 103266] [META] Command line bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103266 Bug 103266 depends on bug 158695, which changed state. Bug 158695 Summary: --convert-to bogusly needs libcui (--disable-gui build) https://bugs.documentfoundation.org/show_bug.cgi?id=158695 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158695] --convert-to bogusly needs libcui (--disable-gui build)
https://bugs.documentfoundation.org/show_bug.cgi?id=158695 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159431] Shift+Ctrl+Return doesn't insert column break as advertised
https://bugs.documentfoundation.org/show_bug.cgi?id=159431 --- Comment #3 from Norman --- (In reply to Telesto from comment #2) > No issue here > Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 566bb271b8fe5882f24fef230e06c2af4ea12b33 > CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win > Locale: nl-NL (nl_NL); UI: en-US > Calc: CL threaded Please consult affiliated bug 159430, which almost certainly suffers from the same problem, and includes more information about my keyboard. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159462] chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices
https://bugs.documentfoundation.org/show_bug.cgi?id=159462 --- Comment #4 from Justin L --- (In reply to Justin L from comment #2) > The bestFit shrinking algorithm should also be applied to center/inside-edge I'd like to retract this statement. A bit more playing around suggests this is not actually true. I'm not sure what is going on here... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159393] Writer shutdown after a Ctrl-Enter for new page in document
https://bugs.documentfoundation.org/show_bug.cgi?id=159393 --- Comment #2 from Telesto --- Something to try: Tools -> Options -> View -> Check Force Skia Software rendering. Does the crash still occur? Another question: Does also happen in single monitor setup? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159352] Scrolling very laggy jerky on MacOS 13.6.3 Intel since update 7.5.9.2
https://bugs.documentfoundation.org/show_bug.cgi?id=159352 --- Comment #3 from John D. Furber --- This problem was solved by following Patrick's Comment # 8. Now my Libre Office 7.5.9.2 works fine on my 2020 MacBookPro Intel running MacOS Ventura 13.6.3. -John Furber Patrick Luby 2023-12-13 13:07:55 UTC To enable Skia/Metal rendering, do the following steps: 1. Open the Options dialog by selecting the LibreOffice > Preferences menu 2. Select LibreOffice > View in the left panel 3. In the right panel, check the "Use Skia for all rendering" and uncheck "Force Skia software rendering" checkboxes as shown in the following screen snapshot: https://bugs.documentfoundation.org/attachment.cgi?id=191409 4. Press the "OK" button and restart if prompted -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159462] chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices
https://bugs.documentfoundation.org/show_bug.cgi?id=159462 --- Comment #3 from Justin L --- Created attachment 192271 --> https://bugs.documentfoundation.org/attachment.cgi?id=192271=edit insideWrapping_mso2010.pdf: how it looks in the program that created it Granted, this is not a "nice" example. It was designed to show how MS handles a somewhat bizarre situation, compared to how LO does it. LO ends up looking somewhat OK in this example because it ALWAYS limits the width to 80% of the radius. For a very large pie, LO wouldn't wrap which might cause it to spill out of the slice if it doesn't bestFit. As can be seen here, MSO can sometimes not bother to bestFit and just spill outside of the pie chart too. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159431] Shift+Ctrl+Return doesn't insert column break as advertised
https://bugs.documentfoundation.org/show_bug.cgi?id=159431 --- Comment #2 from Telesto --- No issue here Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 566bb271b8fe5882f24fef230e06c2af4ea12b33 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa sw/source
sw/qa/core/text/itrform2.cxx | 40 +++
sw/source/core/text/itrform2.cxx |9 ++--
2 files changed, 47 insertions(+), 2 deletions(-)
New commits:
commit 256e2c679bcbb3ea446884d0ff4e3f8687b82ede
Author: Miklos Vajna
AuthorDate: Tue Jan 30 16:51:49 2024 +0100
Commit: Miklos Vajna
CommitDate: Tue Jan 30 19:56:35 2024 +0100
tdf#159452 sw content control, PDF export: fix checked checkboxes
Regression from commit 9bad5be0ffdcdee92d40162b598ed2ab2815e5d5 (sw
content controls, checkbox: add PDF export, 2022-09-13), we used to
export checkbox content controls as plain text, but once checkbox
content controls are exported as forms, the state of the checkboxes are
lost.
Writer content control checkboxes support custom values for the checked
and unchecked states, but the PDF export does not. On one hand,
PDFWriterImpl::createDefaultCheckBoxAppearance() assumes that the
checked state should be a checkmark, not the Writer default 'BALLOT BOX
WITH X' (U+2612). On the other hand, the PDF spec section 12.7.4.2.3
"Check Boxes" says that the checked state should be "Yes", which
explains why our checked state is not recognized by PDF readers.
Fix the problem by making the export of checked/unchecked states
conditional in SwContentControlPortion::DescribePDFControl(): the
checked state then shows up as expected.
Leave the unchecked case unchanged, the current markup there doesn't
cause problems.
Change-Id: I9063d8607c8cccfa080921af38b3cbfe40905115
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162765
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/core/text/itrform2.cxx b/sw/qa/core/text/itrform2.cxx
index fc8e981dcf5f..6d59140f97f0 100644
--- a/sw/qa/core/text/itrform2.cxx
+++ b/sw/qa/core/text/itrform2.cxx
@@ -16,6 +16,10 @@
#include
#include
#include
+#include
+#include
+#include
+#include
namespace
{
@@ -166,6 +170,42 @@ CPPUNIT_TEST_FIXTURE(Test, testSplitFlyAnchorLeftMargin)
// i.e. the left margin was lost.
CPPUNIT_ASSERT_EQUAL(static_cast(6480),
pLastPara->getFramePrintArea().Left());
}
+
+CPPUNIT_TEST_FIXTURE(Test, testCheckedCheckboxContentControlPDF)
+{
+std::shared_ptr pPDFium = vcl::pdf::PDFiumLibrary::get();
+if (!pPDFium)
+return;
+
+// Given a file with a checked checkbox content control:
+createSwDoc();
+SwDoc* pDoc = getSwDoc();
+SwWrtShell* pWrtShell = pDoc->GetDocShell()->GetWrtShell();
+pWrtShell->InsertContentControl(SwContentControlType::CHECKBOX);
+// Toggle it, so we get a checked one:
+SwTextContentControl* pTextContentControl =
pWrtShell->CursorInsideContentControl();
+const SwFormatContentControl& rFormatContentControl =
pTextContentControl->GetContentControl();
+pWrtShell->GotoContentControl(rFormatContentControl);
+
+// When exporting to PDF:
+save("writer_pdf_Export");
+
+// Then make sure that a checked checkbox form widget is emitted:
+std::unique_ptr pPdfDocument = parsePDFExport();
+std::unique_ptr pPage = pPdfDocument->openPage(0);
+CPPUNIT_ASSERT_EQUAL(1, pPage->getAnnotationCount());
+std::unique_ptr pAnnotation =
pPage->getAnnotation(0);
+CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFAnnotationSubType::Widget,
pAnnotation->getSubType());
+CPPUNIT_ASSERT_EQUAL(vcl::pdf::PDFFormFieldType::CheckBox,
+ pAnnotation->getFormFieldType(pPdfDocument.get()));
+OUString aActual = pAnnotation->getFormFieldValue(pPdfDocument.get());
+// Without the accompanying fix in place, this test would have failed with:
+// - Expected: Yes
+// - Actual : Off
+// i.e. the /AP -> /N key of the checkbox widget annotation object didn't
have a sub-key that
+// would match /V, leading to not showing the checked state.
+CPPUNIT_ASSERT_EQUAL(OUString("Yes"), aActual);
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index 5690d228cf59..2d8c3978d73c 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -1018,8 +1018,13 @@ bool SwContentControlPortion::DescribePDFControl(const
SwTextPaintInfo& rInf) co
pDescriptor = std::make_unique();
auto pCheckBoxWidget =
static_cast(pDescriptor.get());
pCheckBoxWidget->Checked = pContentControl->GetChecked();
-pCheckBoxWidget->OnValue = pContentControl->GetCheckedState();
-pCheckBoxWidget->OffValue = pContentControl->GetUncheckedState();
+// If it's checked already, then leave the default "Yes" OnValue
unchanged, so the
+// appropriate appearance is found by PDF readers.
+if (!pCheckBoxWidget->Checked)
+{
+pCheckBoxWidget->OnValue = pContentControl->GetCheckedState();
+
[Bug 159251] After using the navigator w/rtl user interface, text is garbled during selection
https://bugs.documentfoundation.org/show_bug.cgi?id=159251 --- Comment #11 from Yotam Benshalom --- Even hovering above a navigator's entry and viewing its' tooltip triggers this bug. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159462] chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices
https://bugs.documentfoundation.org/show_bug.cgi?id=159462 --- Comment #2 from Justin L --- Created attachment 192270 --> https://bugs.documentfoundation.org/attachment.cgi?id=192270=edit insideWrapping.xlsx: text attempts to fit into slice also with center placement The bestFit shrinking algorithm should also be applied to center/inside-edge placements. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159458] When library is renamed using Basic Macro Organizer, path to library is not updated in dialog.xlc and script.xlc
https://bugs.documentfoundation.org/show_bug.cgi?id=159458 Mike Kaganski changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | Status|NEW |ASSIGNED --- Comment #2 from Mike Kaganski --- https://gerrit.libreoffice.org/c/core/+/162777 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159462] chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices
https://bugs.documentfoundation.org/show_bug.cgi?id=159462 --- Comment #1 from Justin L --- Created attachment 192269 --> https://bugs.documentfoundation.org/attachment.cgi?id=192269=edit bestFitVertical_mso2010.pdf: how it looks in the program that created the file -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146756] FILEOPEN PPTX: labels of pie chart wrap much too aggressively (compared to 365) as well as too conservatively
https://bugs.documentfoundation.org/show_bug.cgi?id=146756 Justin L changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||9462 -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 75057] [META] OOXML Chart object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Justin L changed: What|Removed |Added Depends on||159462 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159462 [Bug 159462] chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159462] New: chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices
https://bugs.documentfoundation.org/show_bug.cgi?id=159462 Bug ID: 159462 Summary: chart: best fit algorithm should be able to "shrink" text width to fit into "vertical" slices Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Chart Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jl...@mail.com CC: jl...@mail.com Blocks: 75057 Created attachment 192268 --> https://bugs.documentfoundation.org/attachment.cgi?id=192268=edit bestFitVertical.xlsx: MSO bestFit inconsistency demo Slices near the Y-axis are best suited for well-wrapped text. Unfortunately, LO's algorithm has no ability to look for the "best width". So it cannot place as many labels inside the slice as needed for compatibility documents. However, there are other cases where LO's algorithm is able to bestFit content where MSO fails, and as this document shows, MSO isn't very predictable in determining whether content should bestFit or not. Fixing this will require adding a significant amount of intelligence to the bestFit algorithm. It will need to loop and try three or four different widths. Due to 3D manipulation, simple tricks like comparing the slice area to the text area will not work - unless your area formula takes into account the 3D rotation. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=75057 [Bug 75057] [META] OOXML Chart object issues -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-7-6' - sc/qa scripting/source
sc/qa/extras/macros-test.cxx | 27 +++
sc/qa/extras/testdocuments/tdf159412.fods | 41 ++
scripting/source/basprov/basscript.cxx| 19 ++---
3 files changed, 83 insertions(+), 4 deletions(-)
New commits:
commit 5db313902110c95c440bb0e96f46acc97092d7ca
Author: Mike Kaganski
AuthorDate: Sun Jan 28 23:53:22 2024 +0600
Commit: Christian Lohmaier
CommitDate: Tue Jan 30 19:21:00 2024 +0100
tdf#159412: make sure to keep the value while changing the type
SbxValue::SetType clears the original value. We need to use the Get/Put
cycle, asking for a specific type in Get, and then making sure that the
variable is not fixed on Put.
Change-Id: I0a6c106d511e8491c89a5a2153f47a708f83ee1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162664
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
(cherry picked from commit 4541614e5f88604b4b1e17b0223d11c2e330d451)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162622
Reviewed-by: Xisco Fauli
(cherry picked from commit fe805d8b9120371d6a602d3219ecb284f3586240)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162719
Reviewed-by: Christian Lohmaier
diff --git a/sc/qa/extras/macros-test.cxx b/sc/qa/extras/macros-test.cxx
index b35266db5b03..d3bdc5b6ecb3 100644
--- a/sc/qa/extras/macros-test.cxx
+++ b/sc/qa/extras/macros-test.cxx
@@ -897,6 +897,33 @@ CPPUNIT_TEST_FIXTURE(ScMacrosTest, testTdf116127)
CPPUNIT_ASSERT_EQUAL(Any(true), aRet);
}
+CPPUNIT_TEST_FIXTURE(ScMacrosTest, testTdf159412)
+{
+// Run a macro, that itself calls two other functions using invoke,
+// passing a small integer value to agruments of types Long and Double
+createScDoc("tdf159412.fods");
+
+css::uno::Any aRet;
+css::uno::Sequence aOutParamIndex;
+css::uno::Sequence aOutParam;
+css::uno::Sequence aParams;
+
+SfxObjectShell::CallXScript(
+mxComponent,
+
"vnd.sun.Star.script:Standard.Module1.TestInvoke?language=Basic=document",
+aParams, aRet, aOutParamIndex, aOutParam);
+
+OUString aReturnValue;
+aRet >>= aReturnValue;
+
+// Without the fix in place, this test would have failed with
+// - Expected: 1 Long/2 Double
+// - Actual : 0 Long/0 Double
+// i.e., the passed 1 and 2 values were lost.
+
+CPPUNIT_ASSERT_EQUAL(OUString("1 Long/2 Double"), aReturnValue);
+}
+
ScMacrosTest::ScMacrosTest()
: ScModelTestBase("/sc/qa/extras/testdocuments")
{
diff --git a/sc/qa/extras/testdocuments/tdf159412.fods
b/sc/qa/extras/testdocuments/tdf159412.fods
new file mode 100644
index ..ec537dd06167
--- /dev/null
+++ b/sc/qa/extras/testdocuments/tdf159412.fods
@@ -0,0 +1,41 @@
+
+
+http://openoffice.org/2004/office;
xmlns:table="urn:oasis:names:tc:opendocument:xmlns:table:1.0"
xmlns:script="urn:oasis:names:tc:opendocument:xmlns:script:1.0"
office:version="1.3"
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
+
+
+
+
+
+ REM * BASIC *
+
+Function TestInvoke
+ script =
ThisComponent.scriptProvider.getScript(vnd.sun.star.script:Standard.Module1.S_Ref_Long?language=Basiclocation=document)
+ ret = script.invoke(Array(1), Array(), Array())
+
+ script =
ThisComponent.scriptProvider.getScript(vnd.sun.star.script:Standard.Module1.S_Ref_Dbl?language=Basiclocation=document)
+ ret = ret / script.invoke(Array(2), Array(), Array())
+
+ TestInvoke = ret
+End Function
+
+Function S_Ref_Long(n As Long)
+ S_Ref_Long = CStr(n) TypeName(n)
+End Function
+
+Function S_Ref_Dbl(n As Double)
+ S_Ref_Dbl = CStr(n) TypeName(n)
+End Function
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
diff --git a/scripting/source/basprov/basscript.cxx
b/scripting/source/basprov/basscript.cxx
index f3ab8d2dd224..e8adce1647bf 100644
--- a/scripting/source/basprov/basscript.cxx
+++ b/scripting/source/basprov/basscript.cxx
@@ -41,6 +41,17 @@ using namespace ::com::sun::star::document;
using namespace ::com::sun::star::beans;
+static void ChangeTypeKeepingValue(SbxVariable& var, SbxDataType to)
+{
+SbxValues val(to);
+var.Get(val);
+bool bSetFlag = var.IsSet(SbxFlagBits::Fixed);
+var.ResetFlag(SbxFlagBits::Fixed);
+var.Put(val);
+if (bSetFlag)
+var.SetFlag(SbxFlagBits::Fixed);
+}
+
namespace basprov
{
@@ -218,14 +229,14 @@ constexpr OUStringLiteral BASSCRIPT_PROPERTY_CALLER =
u"Caller";
{
sal_Int32 val = xSbxVar->GetLong();
if (val >= -16777216 && val <= 16777215)
-xSbxVar->SetType(t);
+ChangeTypeKeepingValue(*xSbxVar, t);
}
else if (t == SbxDOUBLE && (a == SbxINTEGER || a
== SbxLONG))
-
core.git: include/test sw/qa sw/source test/source
include/test/xmltesttools.hxx |3
sw/qa/extras/odfexport/data/bookmark_order.fodt |9 +
sw/qa/extras/odfexport/odfexport2.cxx | 96
sw/qa/extras/uiwriter/uiwriter4.cxx | 15 +--
sw/source/core/unocore/unoportenum.cxx | 112 ++--
test/source/xmltesttools.cxx| 13 ++
6 files changed, 193 insertions(+), 55 deletions(-)
New commits:
commit 1d7ce421480d9170316533de03feb8d04eb5c767
Author: Mike Kaganski
AuthorDate: Tue Jan 30 17:15:07 2024 +0600
Commit: Mike Kaganski
CommitDate: Tue Jan 30 18:50:00 2024 +0100
tdf#159438: when there's no frame, close previous bookmark first
Commit 260d6cc6471444b4ef20ed6673831b0b12f96333 (INTEGRATION: CWS mtg2
(1.30.120); FILE MERGED, 2005-12-21) for #i58438# made sure to process
previously opened bookmarks that close at this node, before opening
the bookmarks that start here.
Commit 76a4305d1e90b6617054dd33036e64f005dbcf04 (sw: fix inconsistent
bookmark behavior around at-char/as-char anchored frames, 2017-12-21)
re-introduced the problem accidentally: it only intended to handle
case when there is an anchored frame here.
This change re-instates the correct order (close bookmarks first; then
process collapsed ones; then open new bookmarks) in case there's no
anchored frames here.
To avoid a problem when a non-collapsed bookmark starts and ends at
the same point (e.g., its text was deleted), it gets converted to
collapsed in lcl_FillBookmark. Thus, testRemoveBookmarkText was fixed
in sw/qa/extras/uiwriter/uiwriter4.cxx. There is no reason to keep
the separate -begin/-end elements, especially since on the following
open/save round-trip, it will become collapsed anyway.
Change-Id: Ib555a76f6f776001e12908a1299c24eebf591f6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162743
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/include/test/xmltesttools.hxx b/include/test/xmltesttools.hxx
index d18b5d51e813..bf91c5b20151 100644
--- a/include/test/xmltesttools.hxx
+++ b/include/test/xmltesttools.hxx
@@ -104,6 +104,9 @@ protected:
* Assert that rXPath exists, has exactly 1 result set nodes and does
*not* have an attribute named rAttribute.
*/
void assertXPathNoAttribute(const xmlDocUniquePtr& pXmlDoc, const
OString& rXPath, const OString& rAttribute);
+// Assert that the node name of the single node returned by an XPath is as
specified,
+// e.g. to check order of elements, where getXPathPosition is unapplicable
+void assertXPathNodeName(const xmlDocUniquePtr& pXmlDoc, const OString&
rXPath, const OString& rExpectedName);
static void registerODFNamespaces(xmlXPathContextPtr& pXmlXpathCtx);
static void registerOOXMLNamespaces(xmlXPathContextPtr& pXmlXpathCtx);
diff --git a/sw/qa/extras/odfexport/data/bookmark_order.fodt
b/sw/qa/extras/odfexport/data/bookmark_order.fodt
new file mode 100644
index ..c7eac58758ff
--- /dev/null
+++ b/sw/qa/extras/odfexport/data/bookmark_order.fodt
@@ -0,0 +1,9 @@
+
+
+
+
+
+ foobar
+
+
+
\ No newline at end of file
diff --git a/sw/qa/extras/odfexport/odfexport2.cxx
b/sw/qa/extras/odfexport/odfexport2.cxx
index c88e64c38ee3..53431d985e1a 100644
--- a/sw/qa/extras/odfexport/odfexport2.cxx
+++ b/sw/qa/extras/odfexport/odfexport2.cxx
@@ -1305,6 +1305,102 @@ CPPUNIT_TEST_FIXTURE(Test, testTdf159382)
}
}
+CPPUNIT_TEST_FIXTURE(Test, testTdf159438)
+{
+// Given a text with bookmarks, where an end of one bookmark is the
position of another,
+// and the start of a third
+loadAndReload("bookmark_order.fodt");
+auto xPara = getParagraph(1);
+
+// Check that the order of runs is correct (bookmarks don't overlap)
+
+{
+auto run = getRun(xPara, 1);
+CPPUNIT_ASSERT_EQUAL(u"Bookmark"_ustr, getProperty(run,
"TextPortionType"));
+CPPUNIT_ASSERT_EQUAL(true, getProperty(run, "IsStart"));
+CPPUNIT_ASSERT_EQUAL(false, getProperty(run, "IsCollapsed"));
+auto named = getProperty>(run,
"Bookmark");
+CPPUNIT_ASSERT_EQUAL(u"bookmark1"_ustr, named->getName());
+}
+
+{
+auto run = getRun(xPara, 2);
+CPPUNIT_ASSERT_EQUAL(u"Text"_ustr, getProperty(run,
"TextPortionType"));
+CPPUNIT_ASSERT_EQUAL(u"foo"_ustr, run->getString());
+}
+
+{
+auto run = getRun(xPara, 3);
+CPPUNIT_ASSERT_EQUAL(u"Bookmark"_ustr, getProperty(run,
"TextPortionType"));
+CPPUNIT_ASSERT_EQUAL(false, getProperty(run, "IsStart"));
+CPPUNIT_ASSERT_EQUAL(false, getProperty(run, "IsCollapsed"));
+auto named = getProperty>(run,
"Bookmark");
+CPPUNIT_ASSERT_EQUAL(u"bookmark1"_ustr, named->getName());
+}
+
+{
+auto run = getRun(xPara, 4);
+CPPUNIT_ASSERT_EQUAL(u"Bookmark"_ustr, getProperty(run,
[Bug 159008] Autorecovery files are deleted on close when you say no to saving a modified document - would be nice to keep anyway as a safety net.
https://bugs.documentfoundation.org/show_bug.cgi?id=159008 Justin L changed: What|Removed |Added Summary|Autorecovery files are hard |Autorecovery files are |deleted when you say no to |deleted on close when you |saving the current open |say no to saving a modified |document and cannot be |document - would be nice to |found even with data|keep anyway as a safety |recovery software |net. Version|7.5.2.2 release |Inherited From OOo Severity|normal |enhancement OS|Windows (All) |All Hardware|x86-64 (AMD64) |All --- Comment #6 from Justin L --- (In reply to Jeff from comment #5) > Would it makes sense to put in a feature request to add an option for "save > autorecovery backup file" No - the fact that it is attached as a duplicate is enough I think. This is an extremely niche request. LO could NOT prompt you on open to say that there is a dangling document - that would be terribly annoying and confusing because you already said you didn't want it saved on exit. So it would completely be left to the user to actively seek and recover that file. Plus, it would eventually lead to a large build-up of files. You can achieve the result you want by pointing your backup software at LO's backup folder. -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 159008] Autorecovery files are deleted on close when you say no to saving a modified document - would be nice to keep anyway as a safety net.
https://bugs.documentfoundation.org/show_bug.cgi?id=159008 Justin L changed: What|Removed |Added Summary|Autorecovery files are hard |Autorecovery files are |deleted when you say no to |deleted on close when you |saving the current open |say no to saving a modified |document and cannot be |document - would be nice to |found even with data|keep anyway as a safety |recovery software |net. Version|7.5.2.2 release |Inherited From OOo Severity|normal |enhancement OS|Windows (All) |All Hardware|x86-64 (AMD64) |All --- Comment #6 from Justin L --- (In reply to Jeff from comment #5) > Would it makes sense to put in a feature request to add an option for "save > autorecovery backup file" No - the fact that it is attached as a duplicate is enough I think. This is an extremely niche request. LO could NOT prompt you on open to say that there is a dangling document - that would be terribly annoying and confusing because you already said you didn't want it saved on exit. So it would completely be left to the user to actively seek and recover that file. Plus, it would eventually lead to a large build-up of files. You can achieve the result you want by pointing your backup software at LO's backup folder. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159458] When library is renamed using Basic Macro Organizer, path to library is not updated in dialog.xlc and script.xlc
https://bugs.documentfoundation.org/show_bug.cgi?id=159458 Mike Kaganski changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Mike Kaganski --- The code pointer for the "library name changed" event in the dialog: https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/moduldl2.cxx?r=d9d9ec70=11283=308#308 it calls SfxLibraryContainer::renameLibrary (basic/source/uno/namecont.cxx). And it seems to me, that it doesn't fix the basic::SfxLibrary::maUnexpandedStorageURL, which stays "$(USER)/basic/Library1/script.xlb/" in the end of the function, when it is re-added to the container. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159461] Dialog "XML Filter Settings" is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=159461 --- Comment #1 from Manuel Reimer --- There is an even easier way to reproduce the issue. - Open the XML filter settings dialog - Choose any existing entry - Click on "Edit..." - Click on "OK" in the now opening dialog --> LibreOffice hangs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159461] New: Dialog "XML Filter Settings" is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=159461
Bug ID: 159461
Summary: Dialog "XML Filter Settings" is broken
Product: LibreOffice
Version: 7.6.4.1 release
Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: manuel.rei...@gmx.de
Description:
I wanted to follow the tutorial posted here:
https://forum.openoffice.org/en/forum/viewtopic.php?t=3490
When doing so ("Tools" -> "XML Filter Settings..." -> "New...", enter data) and
pressing "OK", then the dialog just hangs until Gnome asks me to forcefully
quit the application.
So my next try was to probably work around this by exporting an existing entry,
editing it outside of Libre Office and importing it again. But if I use "Save
as Package..." on any existing item, then all I get is an empty ".jar" file
with only an empty directory inside it. Opening this file again throws an error
message
No XML filter could be installed because the package 'test.jar' does not
contain any XML filters.
So at least for me the whole XML filter dialog is broken completely. Seems to
be impossible to create a new XML filter.
Steps to Reproduce:
Try to follow the tutorial here:
https://forum.openoffice.org/en/forum/viewtopic.php?t=3490
To create a new XML filter.
Actual Results:
Dialog hangs
Expected Results:
Filter creating should work
Reproducible: Always
User Profile Reset: No
Additional Info:
Version: 7.6.4.1 (X86_64) / LibreOffice Community
Build ID: 60(Build:1)
CPU threads: 6; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: de-DE (en_US.UTF-8); UI: en-US
7.6.4-2
Calc: threaded
--
You are receiving this mail because:
You are the assignee for the bug.
