core.git: basic/source
basic/source/comp/loops.cxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 8bbfbe92c01bff38ed2241da56560b84f7954beb
Author: Mike Kaganski
AuthorDate: Tue Feb 27 13:44:37 2024 +0600
Commit: Mike Kaganski
CommitDate: Tue Feb 27 10:33:52 2024 +0100
tdf#159908: return early to avoid nullptr dereference
When aLvalue is not a variable, its GetRealVar() returns nullptr.
That was dereferenced unconditionally later in the check of the
variable after NEXT.
Change-Id: Ia46f23a7e720431bf62ace998848b684aa8449e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164002
Tested-by: Jenkins
Reviewed-by: Mike Kaganski
diff --git a/basic/source/comp/loops.cxx b/basic/source/comp/loops.cxx
index 07aac44943a6..f903f650a2bf 100644
--- a/basic/source/comp/loops.cxx
+++ b/basic/source/comp/loops.cxx
@@ -210,6 +210,11 @@ void SbiParser::For()
if( bForEach )
Next();
SbiExpression aLvalue( this, SbOPERAND );
+if (!aLvalue.IsVariable())
+{
+bAbort = true;
+return; // the error is alredy set in SbiExpression ctor
+}
aLvalue.Gen(); // variable on the Stack
if( bForEach )
[Bug 159685] FILEOPEN PPTX: Mathematical Equation is missing (which works in 7.6.4.1 and broken in 24.2.0.3 (tested on windows))
https://bugs.documentfoundation.org/show_bug.cgi?id=159685 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO CC||stephane.guillou@libreoffic ||e.org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158510] FILEOPEN PPT/PPTX If audio file has absolute path in relationships and is not found, it should be searched from the location where the file is opened
https://bugs.documentfoundation.org/show_bug.cgi?id=158510 Vladislav Tarakanov changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |vladislav.taraka...@bk.ru |desktop.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159683] Crash on closing LibreOffice with certain content on the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=159683 Stéphane Guillou (stragu) changed: What|Removed |Added Version|24.8.0.0 alpha0+ Master |24.2.0.3 release -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159922] New: libreoffice 会把wps文档的文档网格设置解析成稿纸设置
https://bugs.documentfoundation.org/show_bug.cgi?id=159922 Bug ID: 159922 Summary: libreoffice 会把wps文档的文档网格设置解析成稿纸设置 Product: LibreOffice Version: 7.6.5.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: 645848...@qq.com Description: libreoffice 会把wps文档的文档网格设置解析成稿纸设置 Actual Results: 文档在Libreoffice中打开时会以稿纸页面设置的方式打开 Expected Results: 应该是以行格/列格的配置打开 Reproducible: Always User Profile Reset: Yes Additional Info: 无 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 154501] Fileopen PPTX: Table with rotated text rendering wrong again
https://bugs.documentfoundation.org/show_bug.cgi?id=154501 Timur changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||8565 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158565] FILEOPEN PPTX Vertical alignment in table cells with rotated text is incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=158565 Timur changed: What|Removed |Added CC||ti...@libreoffice.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||4501 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 124647] CRASH: after undoing deletion ( steps in comment 5 )
https://bugs.documentfoundation.org/show_bug.cgi?id=124647 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=15 ||9683 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159683 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159683 [Bug 159683] Crash on closing LibreOffice with certain content on the clipboard -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159683] Crash on closing LibreOffice with certain content on the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=159683 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||133092 Severity|normal |critical CC||stephane.guillou@libreoffic ||e.org See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||4647 OS|All |Windows (All) Crash report or||["SwHTMLWriter::GetCSS1Sele crash signature||ctor(SwFormat const ||*,rtl::OString ||&,rtl::OUString &,unsigned ||short &,rtl::OUString *)"] --- Comment #8 from Stéphane Guillou (stragu) --- No crash in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded However, crashed as described on Windows 11: Version: 24.2.0.3 (X86_64) / LibreOffice Community Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1 CPU threads: 4; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Crash report: https://crashreport.libreoffice.org/stats/crash_details/ddf410e0-0f9d-45a8-81a2-9e32f4f39844 As Telesto said, let's keep it Windows-specific. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159681] Document Recovery warning keeps appearing on closing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=159681 --- Comment #4 from PeeWee --- This only happens in the macOS version of LibreOffice. I am using an Intel Mac Mini 2018 running macOS Sonoma 14.3.1. I do have laptops that run LibreOffice using Windows 11 and Ubuntu. No problem with the laptops with the same version of LibreOffice. I also use an Intel MacBook Pro 2012 running macOS Catalina 10.15.7 with the same version of LibreOffice 24.2. No problem with this setup. This problem happens with Writer, Impress and Draw. I have not tested the other LO modules because do not use them. LibreOffice info on Intel Mac Mini 2018 Version: 24.2.0.3 (X86_(64) / LibreOffice Community Build: da48488a73ddd66ea24cf16bb Environme:nt CPU threads: 4; OS, macOS 14.3.1 User interface: UI render: default; VCL: osx Locale: en-GB (en.UTF-8); UI: en-US Misc: Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159590] How shall one deal e.g. with Repeated crashes when pasting a picture from the clipboard?
https://bugs.documentfoundation.org/show_bug.cgi?id=159590 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #9 from Stéphane Guillou (stragu) --- Thanks for that. (In reply to Adalbert Hanßen from comment #8) > 7.6 and 24.2, currently I use > [24.8] > for my work. And have you been able to reproduce the crash in 24.8? The benefit of using the stable versions 7.6 or 24.2 would be more stability, as you know, but also easier crash reporting (if it is offered to you on restart of LO). If the crash dump in .config/libreoffice/4/crash is not too big, you can also attach that. If you find reliable steps to crash it, please let us know, possibly with a smaller document to start from. But hopefully, you just find that the issue is already resolved in 7.6/24.2/24.8. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 67347] FILEOPEN: MS .pptx Textbox with stacked text imported wrong size
https://bugs.documentfoundation.org/show_bug.cgi?id=67347 --- Comment #39 from Commit Notification --- Attila Szűcs committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0079f0e77e74a355d57b24d3a6b6d1a29f45eb79 tdf#67347 pptx import: stacked + horz/vert aligment It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 64679] [META] Printer settings related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=64679 Aron Budea changed: What|Removed |Added Keywords|skillJava, skillJavaScript, | |skillUI | CC|olivier.hallot@libreoffice. | |org | Component|Documentation |Printing and PDF export URL|https://reactmasters.in/| OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159521] LibreOffice Calc 24.2.0.3 (X86_64) ODS files saved with new experimental password protection feature causes data loss (Windows 7)
https://bugs.documentfoundation.org/show_bug.cgi?id=159521
--- Comment #9 from Stéphane Guillou (stragu)
---
(In reply to Michael Stahl (allotropia) from comment #7)
> (In reply to Stéphane Guillou (stragu) from comment #6)
>
> > - I tested with the STR from comment 0 ("string" in A1, saved with password
> > "test"), with the results above (prompted for password, but not accepted).
> > Have you tried those?
>
> i had not, but now i have (on Linux, master and 24.2.0.3), can't reproduce
> it...
Comment 0 steps now work as expected with:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
core.git: oox/source
oox/source/drawingml/shape.cxx | 41 +
1 file changed, 41 insertions(+)
New commits:
commit 0079f0e77e74a355d57b24d3a6b6d1a29f45eb79
Author: Attila Szűcs
AuthorDate: Mon Feb 26 10:04:23 2024 +0100
Commit: Attila Szűcs
CommitDate: Tue Feb 27 09:51:43 2024 +0100
tdf#67347 pptx import: stacked + horz/vert aligment
In case of Stacked, PP calculates in the vertical direction
with the horizontal alignment.
We simulate it by setting TextVerticalAdjust at import time
(from PPTX) based on the ParagraphAdjust of the 1. paragraph
It is not perfect, because we have 1 TextVerticalAdjust / 1 shape,
and it does not support justified,
while we can have many ParagraphAdjust / 1 shape
(if the shape have more paragraphs)
For a better solution we should re-implement the entire stacked
thing, but that is a much bigger task.
Change-Id: I4011be0f118b870ab7f9e2ddc15c6dc5a21f8a89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163934
Reviewed-by: Caolán McNamara
Tested-by: Jenkins
Reviewed-by: Attila Szűcs
diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx
index 8f3aedf3488a..d9a3f8b8db59 100644
--- a/oox/source/drawingml/shape.cxx
+++ b/oox/source/drawingml/shape.cxx
@@ -90,6 +90,7 @@
#include
#include
#include
+#include
#include
#include
@@ -1354,6 +1355,46 @@ Reference< XShape > const & Shape::createAndInsert(
// add properties from textbody to shape properties
if( mpTextBody )
{
+// tdf#67347: In case of Stacked, PP calculates in the vertical
direction with the
+// horizontal alignment.
+// In LO, we simulate it by setting TextVerticalAdjust based on
the ParagraphAdjust
+// of the 1. paragraph
+// It is not perfect, because we have 1 TextVerticalAdjust / 1
shape, and it
+// does not support justified, while we can have many
ParagraphAdjust / 1 shape
+// (if the shape have more paragraphs)
+if
(mpTextBody->getTextProperties().maPropertyMap.hasProperty(PROP_WritingMode)
+&&
mpTextBody->getTextProperties().maPropertyMap.getProperty(PROP_WritingMode)
+ == uno::Any(text::WritingMode2::STACKED)
+&& mpTextBody->getParagraphs().size() > 0
+&& aServiceName != "com.sun.star.drawing.GroupShape")
+{
+std::optional& oParaAdjust
+=
mpTextBody->getParagraphs()[0]->getProperties().getParaAdjust();
+
+if (oParaAdjust)
+{
+switch (*oParaAdjust)
+{
+case ParagraphAdjust::ParagraphAdjust_LEFT:
+mpTextBody->getTextProperties().meVA
+= TextVerticalAdjust::TextVerticalAdjust_TOP;
+break;
+case ParagraphAdjust::ParagraphAdjust_CENTER:
+mpTextBody->getTextProperties().meVA
+=
TextVerticalAdjust::TextVerticalAdjust_CENTER;
+break;
+case ParagraphAdjust::ParagraphAdjust_RIGHT:
+mpTextBody->getTextProperties().meVA
+=
TextVerticalAdjust::TextVerticalAdjust_BOTTOM;
+break;
+default:
+break;
+}
+mpTextBody->getTextProperties().maPropertyMap.setProperty(
+PROP_TextVerticalAdjust,
mpTextBody->getTextProperties().meVA);
+}
+}
+
mpTextBody->getTextProperties().pushTextDistances(Size(aShapeRectHmm.Width,
aShapeRectHmm.Height));
aShapeProps.assignUsed(
mpTextBody->getTextProperties().maPropertyMap );
// Push char properties as well - specifically useful when this is
a placeholder
core.git: Branch 'libreoffice-24-2' - sw/inc sw/source
sw/inc/pagedesc.hxx|6 +--
sw/source/core/doc/docfmt.cxx | 12 +++---
sw/source/core/layout/pagedesc.cxx | 74 ++---
3 files changed, 46 insertions(+), 46 deletions(-)
New commits:
commit a06a5905df7af2f6b69133e419dbfa99d232ab02
Author: Michael Stahl
AuthorDate: Fri Feb 23 17:18:04 2024 +0100
Commit: Xisco Fauli
CommitDate: Tue Feb 27 09:48:26 2024 +0100
tdf#147731 sw: fix memory leak in SwDoc::CopyPageDesc()
Commit 963de9feb37105560fde14b44d992e47f341bb5b "sw: fix issue with
copying stashed frame format" fixed the actual bug here, but introduced
a new memory leak.
This causes an assert in CppunitTest_uiwriter3:
cppunittester: svl/source/items/itempool.cxx:779: void
SfxItemPool::Remove(const SfxPoolItem&): Assertion `rItem.GetRefCount() &&
"RefCount == 0, Remove impossible"' failed.
The assert happens only when this is backported to the libreoffice-7-6
branch, because commit ab7c81f55621d7b0d1468c63305163016dd78837 "ITEM:
Get away from classic 'poolable' Item flag" removed the assert.
The problem is that a SwFormatFrameSize inside a footer SwFrameFormat is
leaked 4 times, because 4 SwFrameFormats are leaked; the leak is that
SwDoc::CopyPageDesc() creates a new pNewFormat, passed it to
StashFrameFormat(), which copies it but doesn't free it.
There is also a usage of std::shared_ptr here that is very questionable;
SwFrameFormat should never be shared between different SwPageDesc.
(regression from commit b802ab694a8a7357d4657f3e11b571144fa7c7bf)
Change-Id: I44133bc5e6789a51ce064f1aa5ea8b325224365b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163854
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
(cherry picked from commit 5c4ae1b19c51dcd62dad8e1d3e8beb87a0311352)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163846
Reviewed-by: Xisco Fauli
diff --git a/sw/inc/pagedesc.hxx b/sw/inc/pagedesc.hxx
index 11bb347aa1fb..ddc7e659a5bb 100644
--- a/sw/inc/pagedesc.hxx
+++ b/sw/inc/pagedesc.hxx
@@ -151,9 +151,9 @@ class SW_DLLPUBLIC SwPageDesc final
struct StashedPageDesc
{
-std::shared_ptr m_pStashedFirst;
-std::shared_ptr m_pStashedLeft;
-std::shared_ptr m_pStashedFirstLeft;
+std::optional m_oStashedFirst;
+std::optional m_oStashedLeft;
+std::optional m_oStashedFirstLeft;
};
mutable StashedPageDesc m_aStashedHeader;
diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index d6c943dbcdc8..1c696bebb6a0 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -1553,21 +1553,21 @@ void SwDoc::CopyPageDesc( const SwPageDesc& rSrcDesc,
SwPageDesc& rDstDesc,
{
if (pStashedFormatSrc->GetDoc() != this)
{
-SwFrameFormat* pNewFormat = new
SwFrameFormat(GetAttrPool(), "CopyDesc", GetDfltFrameFormat());
+SwFrameFormat newFormat(GetAttrPool(), "CopyDesc",
GetDfltFrameFormat());
SfxItemSet aAttrSet(pStashedFormatSrc->GetAttrSet());
aAttrSet.ClearItem(RES_HEADER);
aAttrSet.ClearItem(RES_FOOTER);
-pNewFormat->DelDiffs( aAttrSet );
-pNewFormat->SetFormatAttr( aAttrSet );
+newFormat.DelDiffs(aAttrSet);
+newFormat.SetFormatAttr(aAttrSet);
if (bHeader)
-CopyHeader(*pStashedFormatSrc, *pNewFormat);
+CopyHeader(*pStashedFormatSrc, newFormat);
else
-CopyFooter(*pStashedFormatSrc, *pNewFormat);
+CopyFooter(*pStashedFormatSrc, newFormat);
-rDstDesc.StashFrameFormat(*pNewFormat, bHeader, bLeft,
bFirst);
+rDstDesc.StashFrameFormat(newFormat, bHeader, bLeft,
bFirst);
}
else
{
diff --git a/sw/source/core/layout/pagedesc.cxx
b/sw/source/core/layout/pagedesc.cxx
index 2b7882332789..f9679bb2a8e7 100644
--- a/sw/source/core/layout/pagedesc.cxx
+++ b/sw/source/core/layout/pagedesc.cxx
@@ -83,13 +83,13 @@ SwPageDesc::SwPageDesc( const SwPageDesc )
, m_FootnoteInfo( rCpy.GetFootnoteInfo() )
, m_pdList( nullptr )
{
-m_aStashedHeader.m_pStashedFirst = rCpy.m_aStashedHeader.m_pStashedFirst;
-m_aStashedHeader.m_pStashedLeft = rCpy.m_aStashedHeader.m_pStashedLeft;
-m_aStashedHeader.m_pStashedFirstLeft =
rCpy.m_aStashedHeader.m_pStashedFirstLeft;
+m_aStashedHeader.m_oStashedFirst = rCpy.m_aStashedHeader.m_oStashedFirst;
+m_aStashedHeader.m_oStashedLeft = rCpy.m_aStashedHeader.m_oStashedLeft;
+m_aStashedHeader.m_oStashedFirstLeft =
core.git: sw/qa sw/source
sw/qa/extras/ww8export/data/listWithLgl.doc |binary
sw/qa/extras/ww8export/ww8export4.cxx | 24
sw/source/filter/ww8/wrtw8num.cxx |9 -
sw/source/filter/ww8/ww8par3.cxx| 11 +++
4 files changed, 43 insertions(+), 1 deletion(-)
New commits:
commit a73b3994fb6a2cc10b2d65cbaad201762610cecc
Author: Miklos Vajna
AuthorDate: Tue Feb 27 08:29:31 2024 +0100
Commit: Miklos Vajna
CommitDate: Tue Feb 27 09:39:12 2024 +0100
Related: tdf#150408 DOC filter: handle legal numbering
The bugdoc's 2nd para started with 'Sect I.01', while Word rendered this
as 'Sect 1.01'.
The reason for this difference is that there is an "is legal" boolean
property on the numbering that we ignored from [MS-DOC] during
import/export.
Fix the problem by WW8ListManager::ReadLVL() and
WW8AttributeOutput::NumberingLevel() to handle this, building on top of
the existing DOCX work.
RTF still needs doing.
Change-Id: I57ec402c1dd829251afa639ddfa7fc6620da1125
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164000
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/qa/extras/ww8export/data/listWithLgl.doc
b/sw/qa/extras/ww8export/data/listWithLgl.doc
new file mode 100644
index ..94de2967febc
Binary files /dev/null and b/sw/qa/extras/ww8export/data/listWithLgl.doc differ
diff --git a/sw/qa/extras/ww8export/ww8export4.cxx
b/sw/qa/extras/ww8export/ww8export4.cxx
index 92023fb7a36e..ea50ed2a19b9 100644
--- a/sw/qa/extras/ww8export/ww8export4.cxx
+++ b/sw/qa/extras/ww8export/ww8export4.cxx
@@ -230,6 +230,30 @@ DECLARE_WW8EXPORT_TEST(testInlinePageBreakFirstLine,
"inlinePageBreakFirstLine.d
CPPUNIT_ASSERT(IsFirstLine(aTextNodes[2]));
}
+CPPUNIT_TEST_FIXTURE(Test, testLegalNumbering)
+{
+auto verify = [this]() {
+// Second level's numbering should use Arabic numbers for first level
reference
+auto xPara = getParagraph(1);
+CPPUNIT_ASSERT_EQUAL(OUString("CH I"), getProperty(xPara,
"ListLabelString"));
+xPara = getParagraph(2);
+// Without the accompanying fix in place, this test would have failed
with:
+// - Expected: Sect 1.01
+// - Actual : Sect I.01
+// i.e. fLegal was ignored on import/export.
+CPPUNIT_ASSERT_EQUAL(OUString("Sect 1.01"),
getProperty(xPara, "ListLabelString"));
+xPara = getParagraph(3);
+CPPUNIT_ASSERT_EQUAL(OUString("CH II"), getProperty(xPara,
"ListLabelString"));
+xPara = getParagraph(4);
+CPPUNIT_ASSERT_EQUAL(OUString("Sect 2.01"),
getProperty(xPara, "ListLabelString"));
+};
+
+createSwDoc("listWithLgl.doc");
+verify();
+saveAndReload(mpFilter);
+verify();
+}
+
DECLARE_WW8EXPORT_TEST(testNonInlinePageBreakFirstLine,
"nonInlinePageBreakFirstLine.doc")
{
SwDoc* pDoc = getSwDoc();
diff --git a/sw/source/filter/ww8/wrtw8num.cxx
b/sw/source/filter/ww8/wrtw8num.cxx
index 8d59434db652..681961a3770c 100644
--- a/sw/source/filter/ww8/wrtw8num.cxx
+++ b/sw/source/filter/ww8/wrtw8num.cxx
@@ -279,7 +279,7 @@ void WW8AttributeOutput::NumberingLevel( sal_uInt8
/*nLevel*/,
sal_Int16 nListTabPos,
const OUString ,
const SvxBrushItem* pBrush, //For i120928,to transfer graphic of bullet
-bool /*isLegal*/
+bool isLegal
)
{
// Start value
@@ -303,6 +303,13 @@ void WW8AttributeOutput::NumberingLevel( sal_uInt8
/*nLevel*/,
nAlign = 0;
break;
}
+
+if (isLegal)
+{
+// 3rd bit.
+nAlign |= 0x04;
+}
+
m_rWW8Export.m_pTableStrm->WriteUChar( nAlign );
// Write the rgbxchNums[9], positions of placeholders for paragraph
diff --git a/sw/source/filter/ww8/ww8par3.cxx b/sw/source/filter/ww8/ww8par3.cxx
index 85563c7d1245..3af2f3dc4f9d 100644
--- a/sw/source/filter/ww8/ww8par3.cxx
+++ b/sw/source/filter/ww8/ww8par3.cxx
@@ -365,6 +365,8 @@ struct WW8LVL // only THE entries, WE need!
short nDxaLeft1; // first line indent
sal_uInt8 nNFC; // number format code
+/// Legal numbering: whether this level overrides the nfc of all inherited
level numbers.
+bool fLegal;
// Offset of fieldcodes in Num-X-String
sal_uInt8 aOfsNumsXCH[WW8ListManager::nMaxLevel];
sal_uInt8 nLenGrpprlChpx; // length, in bytes, of the LVL's grpprlChpx
@@ -659,7 +661,15 @@ bool WW8ListManager::ReadLVL(SwNumFormat& rNumFormat,
std::unique_ptr(aLVL.nStartAt));
rNumFormat.SetNumberingType( nType );
+rNumFormat.SetIsLegal(aLVL.fLegal);
rNumFormat.SetNumAdjust( eAdj );
if( style::NumberingType::CHAR_SPECIAL == nType )
[Bug 159912] FILEOPEN: wrong rotation of 3D object
https://bugs.documentfoundation.org/show_bug.cgi?id=159912 Xisco Faulí changed: What|Removed |Added Keywords|regression |implementationError -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'distro/collabora/co-24.04' - sc/source
sc/source/ui/view/tabvwsh4.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 2a2a9c179801f3dff95ac44468b1d61795677090
Author: Szymon Kłos
AuthorDate: Mon Feb 26 15:39:30 2024 +0100
Commit: Andras Timar
CommitDate: Tue Feb 27 09:30:51 2024 +0100
lok: don't hide tooltip on every action
Signed-off-by: Szymon Kłos
Change-Id: I62f69071a4857f7413a995da1ff9fc6ba2f942d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163947
Reviewed-by: Gülşah Köse
Tested-by: Jenkins CollaboraOffice
(cherry picked from commit 8b56971baa473547000eed4d4235977f5df0cfe5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163848
diff --git a/sc/source/ui/view/tabvwsh4.cxx b/sc/source/ui/view/tabvwsh4.cxx
index 7d20ed10a085..0afd430728de 100644
--- a/sc/source/ui/view/tabvwsh4.cxx
+++ b/sc/source/ui/view/tabvwsh4.cxx
@@ -268,7 +268,9 @@ void ScTabViewShell::Deactivate(bool bMDI)
{
HideNoteMarker(); // note marker
-if ( pHdl )
+// in LOK case this could be trigerred on every action from other view
(doc_setView)
+// we don't want to hide tooltip only because other view did some
action
+if ( pHdl && !comphelper::LibreOfficeKit::isActive() )
pHdl->HideTip();// Hide formula auto input tip
}
}
[Bug 159681] Document Recovery warning keeps appearing on closing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=159681 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159681] Document Recovery warning keeps appearing on closing LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=159681 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #3 from Stéphane Guillou (stragu) --- Thanks for the report. - Can you please share the full information copied from LibreOffice > About? - What hardware do you use? - Does it happen with a specific component, or any component? (Writer, Calc...) Looks a bit like bug 153209 or bug 148829. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159865] Font of the drop down menu in Page Size is very low (in NB bar Tabbed UI)
https://bugs.documentfoundation.org/show_bug.cgi?id=159865 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 target:24.2.2 -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-2' - include/svx svx/source sw/source
include/svx/sidebar/ValueSetWithTextControl.hxx |1 -
svx/source/sidebar/tools/ValueSetWithTextControl.cxx |9 -
sw/source/uibase/sidebar/PageSizeControl.cxx |1 -
3 files changed, 11 deletions(-)
New commits:
commit 759c9ea8e66b5fc1a362cf914055ac498fbbd80a
Author: Justin Luth
AuthorDate: Mon Feb 26 11:09:59 2024 -0500
Commit: Xisco Fauli
CommitDate: Tue Feb 27 09:27:32 2024 +0100
tdf#159865 Revert "tdf#136905 NBB: let ValueSetWithTextControl set optimal"
...height
This reverts my 24.2 commit 1876feb8a8805b2f80537e2828c152ccbdf67fe2.
Change-Id: I70c3668393a13992f9ce489e86b07860218445b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163954
Tested-by: Justin Luth
Reviewed-by: Justin Luth
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163961
Tested-by: Jenkins
diff --git a/include/svx/sidebar/ValueSetWithTextControl.hxx
b/include/svx/sidebar/ValueSetWithTextControl.hxx
index 407e9606757f..ac397f9fdab6 100644
--- a/include/svx/sidebar/ValueSetWithTextControl.hxx
+++ b/include/svx/sidebar/ValueSetWithTextControl.hxx
@@ -40,7 +40,6 @@ public:
SVX_DLLPRIVATE virtual void SetDrawingArea(weld::DrawingArea*
pDrawingArea) override;
-void SetOptimalDrawingAreaHeight();
void AddItem(const OUString& rItemText, const OUString& rItemText2);
SVX_DLLPRIVATE virtual void UserDraw(const UserDrawEvent& rUDEvt) override;
diff --git a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
index 91cea51325e6..b5b1f2be3ce9 100644
--- a/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
+++ b/svx/source/sidebar/tools/ValueSetWithTextControl.cxx
@@ -43,15 +43,6 @@ void
ValueSetWithTextControl::SetDrawingArea(weld::DrawingArea* pDrawingArea)
SetColCount();
}
-void ValueSetWithTextControl::SetOptimalDrawingAreaHeight()
-{
-const vcl::Font
aFont(Application::GetSettings().GetStyleSettings().GetLabelFont());
-const sal_Int32 nRowHeight = aFont.GetFontSize().Height() * 9 / 4; // see
UserDraw()
-const Size aSize(GetOutputSizePixel().Width(), nRowHeight *
maItems.size());
-GetDrawingArea()->set_size_request(aSize.Width(), aSize.Height());
-SetOutputSizePixel(aSize);
-}
-
void ValueSetWithTextControl::AddItem(
const OUString& rItemText,
const OUString& rItemText2 )
diff --git a/sw/source/uibase/sidebar/PageSizeControl.cxx
b/sw/source/uibase/sidebar/PageSizeControl.cxx
index 4ea5995c098f..a2dbe406f335 100644
--- a/sw/source/uibase/sidebar/PageSizeControl.cxx
+++ b/sw/source/uibase/sidebar/PageSizeControl.cxx
@@ -168,7 +168,6 @@ PageSizeControl::PageSizeControl(PageSizePopup* pControl,
weld::Widget* pParent)
}
mxSizeValueSet->SetNoSelection();
mxSizeValueSet->SetSelectHdl( LINK(this, PageSizeControl, ImplSizeHdl ) );
-mxSizeValueSet->SetOptimalDrawingAreaHeight();
mxSizeValueSet->Show();
mxSizeValueSet->Resize();
core.git: desktop/qa desktop/source include/LibreOfficeKit
desktop/qa/desktop_lib/test_desktop_lib.cxx |5 ++---
desktop/source/lib/init.cxx | 17 -
include/LibreOfficeKit/LibreOfficeKit.h |2 --
include/LibreOfficeKit/LibreOfficeKit.hxx |5 -
4 files changed, 6 insertions(+), 23 deletions(-)
New commits:
commit d5fbbc750ca96f0541e7bd81dd0657fac53803db
Author: Caolán McNamara
AuthorDate: Fri Feb 23 10:01:50 2024 +
Commit: Caolán McNamara
CommitDate: Tue Feb 27 09:25:23 2024 +0100
use getCommandValues instead of adding a getViewRenderState
Change-Id: Ib6db5dd8ef1db2745cb3c616bb81b1ac2baf6504
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163812
Tested-by: Jenkins CollaboraOffice
Reviewed-by: Miklos Vajna
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163931
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 2457771c384c..c9f276a67eeb 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -3681,13 +3681,12 @@ void DesktopLOKTest::testABI()
offsetof(struct _LibreOfficeKitDocumentClass,
getA11yFocusedParagraph));
CPPUNIT_ASSERT_EQUAL(documentClassOffset(71),
offsetof(struct _LibreOfficeKitDocumentClass,
getA11yCaretPosition));
+
CPPUNIT_ASSERT_EQUAL(documentClassOffset(72),
offsetof(struct _LibreOfficeKitDocumentClass,
hyperlinkInfoAtPosition));
-CPPUNIT_ASSERT_EQUAL(documentClassOffset(73),
- offsetof(struct _LibreOfficeKitDocumentClass,
getViewRenderState));
// As above
-CPPUNIT_ASSERT_EQUAL(documentClassOffset(74), sizeof(struct
_LibreOfficeKitDocumentClass));
+CPPUNIT_ASSERT_EQUAL(documentClassOffset(73), sizeof(struct
_LibreOfficeKitDocumentClass));
}
CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 83a547d3e211..93efef57d138 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1299,8 +1299,6 @@ static void
doc_setAccessibilityState(LibreOfficeKitDocument* pThis, int nId, bo
static char* doc_getA11yFocusedParagraph(LibreOfficeKitDocument* pThis);
static int doc_getA11yCaretPosition(LibreOfficeKitDocument* pThis);
-
-static char* doc_getViewRenderState(LibreOfficeKitDocument* pThis);
} // extern "C"
namespace {
@@ -1495,8 +1493,6 @@ LibLODocument_Impl::LibLODocument_Impl(uno::Reference
xC
m_pDocumentClass->getA11yFocusedParagraph =
doc_getA11yFocusedParagraph;
m_pDocumentClass->getA11yCaretPosition = doc_getA11yCaretPosition;
-m_pDocumentClass->getViewRenderState = doc_getViewRenderState;
-
gDocumentClass = m_pDocumentClass;
}
pClass = m_pDocumentClass.get();
@@ -4921,15 +4917,6 @@ static size_t
doc_renderShapeSelection(LibreOfficeKitDocument* pThis, char** pOu
return 0;
}
-static char* doc_getViewRenderState(LibreOfficeKitDocument* pThis)
-{
-ITiledRenderable* pDoc = getTiledRenderable(pThis);
-if (!pDoc)
-return nullptr;
-
-return convertOString(pDoc->getViewRenderState());
-}
-
namespace {
/** Class to react on finishing of a dispatched command.
@@ -6386,6 +6373,10 @@ static char*
doc_getCommandValues(LibreOfficeKitDocument* pThis, const char* pCo
{
return getRulerState(pThis);
}
+else if (aCommand == ".uno:ViewRenderState")
+{
+return convertOString(pDoc->getViewRenderState());
+}
else if (aCommand.starts_with(aViewRowColumnHeaders))
{
tools::Rectangle aRectangle;
diff --git a/include/LibreOfficeKit/LibreOfficeKit.h
b/include/LibreOfficeKit/LibreOfficeKit.h
index f66083e2d301..78651128d3ac 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/include/LibreOfficeKit/LibreOfficeKit.h
@@ -517,8 +517,6 @@ struct _LibreOfficeKitDocumentClass
/// @see lok::Document::hyperlinkInfoAtPosition().
char* (*hyperlinkInfoAtPosition) (LibreOfficeKitDocument* pThis, int x,int
y);
-char* (*getViewRenderState) (LibreOfficeKitDocument* pThis);
-
#endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
};
diff --git a/include/LibreOfficeKit/LibreOfficeKit.hxx
b/include/LibreOfficeKit/LibreOfficeKit.hxx
index b6cc69e8c92c..e94053378355 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -894,11 +894,6 @@ public:
return mpDoc->pClass->getA11yCaretPosition(mpDoc);
}
-char* getViewRenderState()
-{
-return mpDoc->pClass->getViewRenderState(mpDoc);
-}
-
#endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
};
[Bug 133092] [META] Crash bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=133092 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159666 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159666 [Bug 159666] Crash when table and line object are selected at the same time -- You are receiving this mail because: You are the assignee for the bug.
[Bug 112182] [META] Selection of text, cells and objects
https://bugs.documentfoundation.org/show_bug.cgi?id=112182 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||159666 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=159666 [Bug 159666] Crash when table and line object are selected at the same time -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159666] Crash when table and line object are selected at the same time
https://bugs.documentfoundation.org/show_bug.cgi?id=159666 Stéphane Guillou (stragu) changed: What|Removed |Added Version|7.6.4.1 release |7.3.0.0 alpha0+ Crash report or|["SdrEdgeObj::GetConnectedN |["SdrEdgeObj::GetConnectedN crash signature|ode(bool)"] |ode(bool)","SdrObject::getP ||arentSdrObjListFromSdrObjec ||t() const"] Blocks||112182, 133092 CC||stephane.guillou@libreoffic ||e.org Severity|normal |critical Status|RESOLVED|VERIFIED --- Comment #13 from Stéphane Guillou (stragu) --- Thanks everyone, verified in: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Back in 7.3, I got the signature "SdrObject::getParentSdrObjListFromSdrObject() const": https://crashreport.libreoffice.org/stats/crash_details/37b29a9a-22b4-456d-9322-dedfe425b0de Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112182 [Bug 112182] [META] Selection of text, cells and objects https://bugs.documentfoundation.org/show_bug.cgi?id=133092 [Bug 133092] [META] Crash bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159921] number of pages indication: display format options (enhancement request)
https://bugs.documentfoundation.org/show_bug.cgi?id=159921 peter josvai changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159921] New: number of pages indication: display format options (enhancement request)
https://bugs.documentfoundation.org/show_bug.cgi?id=159921 Bug ID: 159921 Summary: number of pages indication: display format options (enhancement request) Product: LibreOffice Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@cspv.hu Created attachment 192817 --> https://bugs.documentfoundation.org/attachment.cgi?id=192817=edit the calendar configuring popup At the bottom of the page we see the number of pages displayed. It used to be, for ages, only one number, say "5". That would mean in the old times that you're working on "page 5". The length of your text is a crucial factor. Most of us write watching the number of words and characters all the time. I used an instance of Writer 7.4 the other day, and it was so refreshing! As I looked at the "number of pages", it was what it looked like. Like in the "old days". Page 4 of 18 as opposed to Page 4 and 5 of 18 It's simple, like with € 2.99 we read it as "2..." As to the number of pages indication, we read it as "Page 4" Annoying as it is, it could be helped, easily. But the thing we are talking about is the one and only thing: the format in which that number is being displayed. Now, everywhere we see numbers displayed as crucial info, we have the option to set the format that best fits us. We don't need all the people of the world to like the format you like. You can just set it for yourself. Take the calendar in Linux Desktop Environments, such as Gnome. Just one click (on the clock), ans you're there, and yo can set the format you like best. And you set it, and you're happy. Just hit "configure" :) It would be so great (saving us a major annoyance 300 times on a daily basis) to have the configure option for the "number of pages" display format we have 3 numbers in that sequence: say, the "from" (or smaller), the "to" (or greater), and the "of" numbers... I'd like to have it, perhaps, like "%from-%to (of%of) maybe I'd like to change it further :) maybe I'd omit the "%from" number... Either way, it'd be cool, cause we'd have the "configure" option! :) I wish we had that... - - - thank you for developing Libreoffice, and Writer! - - - - -- You are receiving this mail because: You are the assignee for the bug.
core.git: desktop/source
desktop/source/lib/init.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a9386139613735c45765a540ce8fac98f5639d49 Author: Andrea Gelmini AuthorDate: Mon Feb 26 21:49:12 2024 +0100 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Tue Feb 27 09:13:58 2024 +0100 Fix typo Change-Id: I48f1487f11ba35b61327b148d51f8ecb4f36b78e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163992 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index a53a228ada06..83a547d3e211 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -4826,7 +4826,7 @@ static void doc_postWindowKeyEvent(LibreOfficeKitDocument* /*pThis*/, unsigned n // // Typically a problem arises when double clicking a shape in calc. The 1st // click selects the shape, triggering generation of a preview, but the second -// shape engers into edit mode before doc_renderShapeSelection has a chance to +// shape enters into edit mode before doc_renderShapeSelection has a chance to // fire, at which point the shape is no longer selected. Rather than generate // an error just return a 0 length result if there is no shape selected, so we // continue to generate an error if a shape is selected, but could not provide
core.git: desktop/source
desktop/source/lib/init.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a507daadb1e033eaccc24f0d0115f5010c58873b Author: Andrea Gelmini AuthorDate: Mon Feb 26 21:48:13 2024 +0100 Commit: Taichi Haradaguchi <20001...@ymail.ne.jp> CommitDate: Tue Feb 27 09:12:58 2024 +0100 Fix typo Change-Id: Id1e21804fb2bc93887892192e38b655c8654ed7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163991 Reviewed-by: Taichi Haradaguchi <20001...@ymail.ne.jp> Tested-by: Taichi Haradaguchi <20001...@ymail.ne.jp> diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index f2382e05952d..a53a228ada06 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -4826,7 +4826,7 @@ static void doc_postWindowKeyEvent(LibreOfficeKitDocument* /*pThis*/, unsigned n // // Typically a problem arises when double clicking a shape in calc. The 1st // click selects the shape, triggering generation of a preview, but the second -// shape engers into edit mode befoce doc_renderShapeSelection has a chance to +// shape engers into edit mode before doc_renderShapeSelection has a chance to // fire, at which point the shape is no longer selected. Rather than generate // an error just return a 0 length result if there is no shape selected, so we // continue to generate an error if a shape is selected, but could not provide
[Bug 159680] Memory not freed after PDF export
https://bugs.documentfoundation.org/show_bug.cgi?id=159680 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org --- Comment #3 from Stéphane Guillou (stragu) --- Tested on Linux: Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded When opened, settles at about 830 mb. When exporting, goes to 900 mb. Settles back to 880 mb afterwards. If I export again, it settles to 910 mb, but doesn't go further with subsequent exports. It does look macOS-specific. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/inc
sw/inc/fmteiro.hxx |5 +
1 file changed, 5 insertions(+)
New commits:
commit 3fb07fbd8edb7c048ca9e2ec5fa0a5206e05b8d0
Author: Miklos Vajna
AuthorDate: Tue Feb 27 08:21:38 2024 +0100
Commit: Miklos Vajna
CommitDate: Tue Feb 27 09:11:01 2024 +0100
sw: document SwFormatEditInReadonly
What it is, which item set can contain it, where is the UI.
Change-Id: I470b057418c551da78b174dd02a22206a18dd03f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163999
Reviewed-by: Miklos Vajna
Tested-by: Jenkins
diff --git a/sw/inc/fmteiro.hxx b/sw/inc/fmteiro.hxx
index 15643f41d925..7ec165654c27 100644
--- a/sw/inc/fmteiro.hxx
+++ b/sw/inc/fmteiro.hxx
@@ -26,6 +26,11 @@
class IntlWrapper;
+/// Allows you to edit the contents of a TextFrame in a document that is
read-only.
+///
+/// Appears in the item set of an sw::SpzFrameFormat.
+///
+/// Insert -> Frame -> Frame -> Options -> Editable in read-only document on
the UI.
class SW_DLLPUBLIC SwFormatEditInReadonly final : public SfxBoolItem
{
public:
[Bug 159656] "7.6" still shown in the taskbar thumbnail by KDE Plasma when running the v24 appimage
https://bugs.documentfoundation.org/show_bug.cgi?id=159656 --- Comment #3 from Michael Weghorn --- (In reply to Michael Weghorn from comment #2) > On my Debian testing, that desktop file also has an entry "Name=LibreOffice > Writer", and that's what I see when hovering over the taskbar entry in my > KDE Plasma X11 session on Debian testing when starting the Debian-provided > LibreOffice Writer. > > Do your desktop files contain any "Name=" entry that contains the version > number? I just changed the "Name" entry in /usr/share/applications/libreoffice-startcenter.desktop to "Name=LibreOffice Test123" and started the AppImage version and then "LibreOffice Test123" is actually shown as the name when hovering over the taskbar entry of the LO StartCenter window in my Plasma X11 session. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 159656] "7.6" still shown in the taskbar thumbnail by KDE Plasma when running the v24 appimage
https://bugs.documentfoundation.org/show_bug.cgi?id=159656
--- Comment #2 from Michael Weghorn ---
2 things I can think of that *might* be relevant here:
1) The use of themed application icons, i.e. depending on what icon theme is in
use (likely set in GNOME or KDE system settings), the icons from that theme may
be preferred, not any shipped with LibreOffice.
2) The .desktop files from underneath $XDG_DATA_DIRS (see the desktop entry
spec: [1]), like /usr/share/applications/libreoffice-startcenter.desktop or
/usr/share/applications/libreoffice-writer.desktop
>From what I know, in particular on Wayland, the app-id set for the "window"
(might be called "surface" in Wayland terminology, but I'm not sure) is used to
associate the window with a desktop entry, and window managers/Wayland
compositors/task bar entry managers use the icon (and maybe more data) from
these.
Example:
app-id is set to "libreoffice-writer"
-> corresponding desktop file is
/usr/share/applications/libreoffice-writer.desktop
The desktop file has an entry "Icon=libreoffice-writer" -> An icon with that
name is used, presumably preferring the one from the currently set icon theme.
On my Debian testing, that desktop file also has an entry "Name=LibreOffice
Writer", and that's what I see when hovering over the taskbar entry in my KDE
Plasma X11 session on Debian testing when starting the Debian-provided
LibreOffice Writer.
Do your desktop files contain any "Name=" entry that contains the version
number?
I don't know about all of the details and there might be other things that come
into play.
Not sure what of the current behavior would then even be correct from a
technical perspective ("works as designed"), as e.g. supporting theming
generally seems to be a good idea in my eyes.
One way to override the current behavior that might possibly work is to prepend
a directory containing own .desktop files to XDG_DATA_DIRS so that one is
checked first. (Might have to be done on session start as the process managing
the taskbar likely uses its own environment and not environment variables set
only on LO start.)
[1]
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 159898] Writer context menu displays greyed out non-available options
https://bugs.documentfoundation.org/show_bug.cgi?id=159898 Heiko Tietze changed: What|Removed |Added Keywords|needsUXEval | CC||heiko.tietze@documentfounda ||tion.org -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158101] Disabled popup menu items are visible with non-gtk backend
https://bugs.documentfoundation.org/show_bug.cgi?id=158101 Heiko Tietze changed: What|Removed |Added CC||da...@robley.au --- Comment #12 from Heiko Tietze --- *** Bug 159898 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug.
[Bug 159898] Writer context menu displays greyed out non-available options
https://bugs.documentfoundation.org/show_bug.cgi?id=159898 Heiko Tietze changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Heiko Tietze --- I don't remember why I agreed to this. Of course we should carefully hide entries that don't apply at all and show disabled if temporarily unavailable. But wasn't this fixed for bug 158101? *** This bug has been marked as a duplicate of bug 158101 *** -- You are receiving this mail because: You are the assignee for the bug.
