core.git: Branch 'libreoffice-24-2' - external/skia

2024-03-16 Thread Patrick Luby (via logerrit)
 external/skia/Library_skia.mk |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 0696fa0845feaab96a90dfdce96131998961b50a
Author: Patrick Luby 
AuthorDate: Sat Mar 16 14:46:29 2024 -0400
Commit: Adolfo Jayme Barrientos 
CommitDate: Sun Mar 17 07:09:04 2024 +0100

tdf#160036 Enable SKSL when using Skia/Raster

Starting with the upgrade of Skia from m111 to m116, SKSL is disabled
by default for Skia/Raster so define SK_RASTER_PIPELINE_OPS_ALL to
enable it.

Change-Id: Ibd10efa0540f1e87123c341b529c8e3931e1a8fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164933
Tested-by: Jenkins
Reviewed-by: Patrick Luby 
(cherry picked from commit 22dbaf45fb378107ad7daa0d7894939d6e0c7ee3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164876
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/external/skia/Library_skia.mk b/external/skia/Library_skia.mk
index c2163d299327..55af14cd2daf 100644
--- a/external/skia/Library_skia.mk
+++ b/external/skia/Library_skia.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_Library_add_defs,skia,\
 -DSK_USER_CONFIG_HEADER="<$(BUILDDIR)/config_host/config_skia.h>" \
 $(if $(filter INTEL,$(CPUNAME)),$(if $(filter 
WNT,$(OS)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE1,-DSK_CPU_SSE_LEVEL=0)) \
 $(if $(filter X86_64,$(CPUNAME)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE2) 
\
+-DSK_ENABLE_SKSL_IN_RASTER_PIPELINE \
 ))
 
 # SK_DEBUG controls runtime checks and is controlled by config_skia.h and 
depends on DBG_UTIL.
@@ -565,6 +566,8 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/sksl/analysis/SkSLReturnsInputAlpha \
 UnpackedTarball/skia/src/sksl/analysis/SkSLSymbolTableStackBuilder \
 UnpackedTarball/skia/src/sksl/analysis/SkSLSwitchCaseContainsExit \
+UnpackedTarball/skia/src/sksl/analysis/SkSLGetLoopControlFlowInfo \
+UnpackedTarball/skia/src/sksl/analysis/SkSLIsDynamicallyUniformExpression \
 UnpackedTarball/skia/src/sksl/codegen/SkSLGLSLCodeGenerator \
 UnpackedTarball/skia/src/sksl/codegen/SkSLMetalCodeGenerator \
 UnpackedTarball/skia/src/sksl/codegen/SkSLPipelineStageCodeGenerator \
@@ -572,6 +575,8 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/sksl/codegen/SkSLSPIRVtoHLSL \
 UnpackedTarball/skia/src/sksl/codegen/SkSLVMCodeGenerator \
 UnpackedTarball/skia/src/sksl/codegen/SkSLWGSLCodeGenerator \
+UnpackedTarball/skia/src/sksl/codegen/SkSLRasterPipelineBuilder \
+UnpackedTarball/skia/src/sksl/codegen/SkSLRasterPipelineCodeGenerator \
 UnpackedTarball/skia/src/sksl/transform/SkSLAddConstToVarModifiers \
 UnpackedTarball/skia/src/sksl/transform/SkSLEliminateDeadFunctions \
 UnpackedTarball/skia/src/sksl/transform/SkSLEliminateDeadGlobalVariables \


New implementation for extruded custom shapes

2024-03-16 Thread Regina Henschel

Hi all,

The current solution for extruded custom shapes is only suitable for 
shapes from binary MS Office files. Even not all features of ODF are 
implemented. And there are no ways at all to display modern 3D objects 
from OOXML.


Would anyone like to implement a new version for extruded custom shapes 
together with me?


Kind regards,
Regina



core.git: external/skia sw/qa vcl/qa

2024-03-16 Thread Patrick Luby (via logerrit)
 external/skia/Library_skia.mk  |5 +
 sw/qa/extras/ooxmlexport/ooxmlexport16.cxx |5 -
 vcl/qa/cppunit/BackendTest.cxx |4 
 3 files changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 39663a323c3330c18b610fcdc9e9c75ddac770f1
Author: Patrick Luby 
AuthorDate: Sat Mar 16 14:46:29 2024 -0400
Commit: Patrick Luby 
CommitDate: Sat Mar 16 23:23:18 2024 +0100

tdf#160036 Enable SKSL when using Skia/Raster

Starting with the upgrade of Skia from m111 to m116, SKSL is disabled
by default for Skia/Raster so define SK_RASTER_PIPELINE_OPS_ALL to
enable it.

Also, reenable XOR drawing unit tests that were previously failing.

Change-Id: Ibd10efa0540f1e87123c341b529c8e3931e1a8fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164933
Tested-by: Jenkins
Reviewed-by: Patrick Luby 

diff --git a/external/skia/Library_skia.mk b/external/skia/Library_skia.mk
index c2163d299327..55af14cd2daf 100644
--- a/external/skia/Library_skia.mk
+++ b/external/skia/Library_skia.mk
@@ -23,6 +23,7 @@ $(eval $(call gb_Library_add_defs,skia,\
 -DSK_USER_CONFIG_HEADER="<$(BUILDDIR)/config_host/config_skia.h>" \
 $(if $(filter INTEL,$(CPUNAME)),$(if $(filter 
WNT,$(OS)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE1,-DSK_CPU_SSE_LEVEL=0)) \
 $(if $(filter X86_64,$(CPUNAME)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE2) 
\
+-DSK_ENABLE_SKSL_IN_RASTER_PIPELINE \
 ))
 
 # SK_DEBUG controls runtime checks and is controlled by config_skia.h and 
depends on DBG_UTIL.
@@ -565,6 +566,8 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/sksl/analysis/SkSLReturnsInputAlpha \
 UnpackedTarball/skia/src/sksl/analysis/SkSLSymbolTableStackBuilder \
 UnpackedTarball/skia/src/sksl/analysis/SkSLSwitchCaseContainsExit \
+UnpackedTarball/skia/src/sksl/analysis/SkSLGetLoopControlFlowInfo \
+UnpackedTarball/skia/src/sksl/analysis/SkSLIsDynamicallyUniformExpression \
 UnpackedTarball/skia/src/sksl/codegen/SkSLGLSLCodeGenerator \
 UnpackedTarball/skia/src/sksl/codegen/SkSLMetalCodeGenerator \
 UnpackedTarball/skia/src/sksl/codegen/SkSLPipelineStageCodeGenerator \
@@ -572,6 +575,8 @@ $(eval $(call 
gb_Library_add_generated_exception_objects,skia,\
 UnpackedTarball/skia/src/sksl/codegen/SkSLSPIRVtoHLSL \
 UnpackedTarball/skia/src/sksl/codegen/SkSLVMCodeGenerator \
 UnpackedTarball/skia/src/sksl/codegen/SkSLWGSLCodeGenerator \
+UnpackedTarball/skia/src/sksl/codegen/SkSLRasterPipelineBuilder \
+UnpackedTarball/skia/src/sksl/codegen/SkSLRasterPipelineCodeGenerator \
 UnpackedTarball/skia/src/sksl/transform/SkSLAddConstToVarModifiers \
 UnpackedTarball/skia/src/sksl/transform/SkSLEliminateDeadFunctions \
 UnpackedTarball/skia/src/sksl/transform/SkSLEliminateDeadGlobalVariables \
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx 
b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
index febcec916aae..2ac490d61a14 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport16.cxx
@@ -30,7 +30,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 
 class Test : public SwModelTestBase
@@ -765,10 +764,6 @@ DECLARE_OOXMLEXPORT_TEST(testTdf136841, "tdf136841.docx")
 CPPUNIT_ASSERT_EQUAL( tools::Long(76), bitmap.GetSizePixel().Width());
 CPPUNIT_ASSERT_EQUAL( tools::Long(76), bitmap.GetSizePixel().Height());
 
-// FIXME this still has some issues with skia
-if (SkiaHelper::isVCLSkiaEnabled())
-return;
-
 // Without the fix in place, this test would have failed with
 // - Expected: Color: R:228 G:71 B:69 A:0
 // - Actual  : Color: R:0 G:0 B:0 A:0
diff --git a/vcl/qa/cppunit/BackendTest.cxx b/vcl/qa/cppunit/BackendTest.cxx
index a90a96e3110e..a5b1a158ecc4 100644
--- a/vcl/qa/cppunit/BackendTest.cxx
+++ b/vcl/qa/cppunit/BackendTest.cxx
@@ -15,7 +15,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
@@ -626,9 +625,6 @@ public:
 {
 if (getDefaultDeviceBitCount() < 24)
 return;
-// FIXME this still has some issues with skia
-if (SkiaHelper::isVCLSkiaEnabled())
-return;
 vcl::test::OutputDeviceTestAnotherOutDev aOutDevTest;
 Bitmap aBitmap = aOutDevTest.setupXOR();
 auto eResult = 
vcl::test::OutputDeviceTestAnotherOutDev::checkXOR(aBitmap);


core.git: sc/source

2024-03-16 Thread Rafael Lima (via logerrit)
 sc/source/ui/miscdlgs/solveroptions.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f58b9659067de7fd8fcd8391b4bf1a2513cedaf7
Author: Rafael Lima 
AuthorDate: Wed Mar 13 23:30:17 2024 +0100
Commit: Adolfo Jayme Barrientos 
CommitDate: Sat Mar 16 22:48:50 2024 +0100

tdf#160122 Increase height of the Solver Options dialog

Currently the Solver Options dialog (Tools - Solver and then click the 
Options button) has a height of 6 rows, which is good for the Linear and Swarm 
non-linear solvers, since they have 4-5 options.

However, the SCO and DEPS engines have 12 and 19 options, respectively, so 
it is very unconfortable to view and scroll through these options with such a 
small dialog.

This patch raises the height of the dialog to 12, so that scrolling is 
minimized, making it more confortable to navigate through the solver options.

Change-Id: I51c1c6880613818dd91c6bb8494775c863e8b406
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164749
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/sc/source/ui/miscdlgs/solveroptions.cxx 
b/sc/source/ui/miscdlgs/solveroptions.cxx
index 3d5b2b47c178..81f5c8b7b4ce 100644
--- a/sc/source/ui/miscdlgs/solveroptions.cxx
+++ b/sc/source/ui/miscdlgs/solveroptions.cxx
@@ -69,7 +69,7 @@ ScSolverOptionsDialog::ScSolverOptionsDialog(weld::Window* 
pParent,
 , m_xBtnEdit(m_xBuilder->weld_button("edit"))
 {
 
m_xLbSettings->set_size_request(m_xLbSettings->get_approximate_digit_width() * 
32,
-m_xLbSettings->get_height_rows(6));
+m_xLbSettings->get_height_rows(12));
 
 m_xLbSettings->enable_toggle_buttons(weld::ColumnToggleType::Check);
 


core.git: vcl/source

2024-03-16 Thread Caolán McNamara (via logerrit)
 vcl/source/gdi/metaact.cxx |   19 ++-
 1 file changed, 18 insertions(+), 1 deletion(-)

New commits:
commit 7f43f00d55bc32fd62c2f72cb0343f9419eb8491
Author: Caolán McNamara 
AuthorDate: Sat Mar 16 20:56:01 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Mar 16 22:30:25 2024 +0100

ofz#67445 Timeout

Change-Id: I968f57c9c71e764ade189deca1534983e33cc401
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164932
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index bea295fb416e..81d72cdf8dbd 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -735,9 +735,26 @@ MetaStretchTextAction::MetaStretchTextAction( const Point& 
rPt, sal_uInt32 nWidt
 
 void MetaStretchTextAction::Execute( OutputDevice* pOut )
 {
-if (!AllowDim(pOut->LogicToPixel(maPt).Y()))
+if (!AllowRect(pOut->LogicToPixel(tools::Rectangle(maPt, Size(mnWidth, 
pOut->GetTextHeight())
 return;
 
+static bool bFuzzing = comphelper::IsFuzzing();
+if (bFuzzing && mnWidth > 1)
+{
+FontLineStyle eUnderline = pOut->GetFont().GetUnderline();
+FontLineStyle eOverline = pOut->GetFont().GetOverline();
+
+if (eUnderline == LINESTYLE_SMALLWAVE || eUnderline == LINESTYLE_WAVE 
||
+eUnderline == LINESTYLE_DOUBLEWAVE || eUnderline == 
LINESTYLE_BOLDWAVE ||
+eOverline == LINESTYLE_SMALLWAVE || eOverline == LINESTYLE_WAVE ||
+eOverline == LINESTYLE_DOUBLEWAVE || eOverline == 
LINESTYLE_BOLDWAVE)
+{
+SAL_WARN("vcl.gdi", "MetaStretchTextAction::Execute, skipping 
suspicious WaveTextLine of length: "
+<< mnWidth << " for fuzzing performance");
+return;
+}
+}
+
 pOut->DrawStretchText( maPt, mnWidth, maStr, mnIndex, mnLen );
 }
 


core.git: solenv/gdb

2024-03-16 Thread Caolán McNamara (via logerrit)
 solenv/gdb/libreoffice/basegfx.py |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 65e3e9b448bb547167ef7ec6d2dfe537ecf8a565
Author: Caolán McNamara 
AuthorDate: Sat Mar 16 21:04:11 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Mar 16 22:29:38 2024 +0100

fix gdb pretty-printer for basegfx::B2DPolygon

probably broken since around:

commit 347112fbd89ebd2a244052f14e085c9d3c90838d
Date:   Sun Oct 8 13:14:39 2023 +0300

Drop temporary aliases from Tuple2D and Tuple3D

Change-Id: I117e719dd654fb063811750fdf20d353a82b6996
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164934
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/solenv/gdb/libreoffice/basegfx.py 
b/solenv/gdb/libreoffice/basegfx.py
index c14968c91eb2..b6291605c5f2 100644
--- a/solenv/gdb/libreoffice/basegfx.py
+++ b/solenv/gdb/libreoffice/basegfx.py
@@ -98,7 +98,7 @@ class B2DPolygonPrinter(object):
 #  self.value.address, self.index))
 self.index += 1
 return ('point %d' % (self.index-1),
-'(%15f, %15f)' % (currPoint['mfX'], currPoint['mfY']))
+'(%15f, %15f)' % (currPoint['mnX'], currPoint['mnY']))
 
 class _bezierIterator(six.Iterator):
 def __init__(self, count, value):
@@ -129,9 +129,9 @@ class B2DPolygonPrinter(object):
 self.index += 1
 return ('point %d' % (self.index-1),
 'p: (%15f, %15f) c-1: (%15f, %15f) c1: (%15f, %15f)' %
-(currPoint['mfX'],   currPoint['mfY'],
- prevControl['mfX'], prevControl['mfY'],
- nextControl['mfX'], nextControl['mfY']))
+(currPoint['mnX'],   currPoint['mnY'],
+ prevControl['mnX'], prevControl['mnY'],
+ nextControl['mnX'], nextControl['mnY']))
 
 class B2DPolyPolygonPrinter(object):
 '''Prints a B2DPolyPolygon object.'''


core.git: vcl/headless

2024-03-16 Thread Caolán McNamara (via logerrit)
 vcl/headless/CairoCommon.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 0aaf804de48076bd8bed6459b7c40d87eea4535e
Author: Caolán McNamara 
AuthorDate: Sat Mar 16 19:56:28 2024 +
Commit: Caolán McNamara 
CommitDate: Sat Mar 16 22:29:20 2024 +0100

ofz#67408 Build failure

use of undeclared identifier 'SVP_CAIRO_ALPHA

Change-Id: I546d2d203929702e46bd6de6242d70c21b636885
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164931
Tested-by: Caolán McNamara 
Reviewed-by: Caolán McNamara 

diff --git a/vcl/headless/CairoCommon.cxx b/vcl/headless/CairoCommon.cxx
index 182a44b9aaf2..9a84903e5483 100644
--- a/vcl/headless/CairoCommon.cxx
+++ b/vcl/headless/CairoCommon.cxx
@@ -21,9 +21,7 @@
 #include 
 #include 
 #include 
-#ifdef ANDROID
-#include  // for correct compilation in only android
-#endif
+#include 
 #include 
 #include 
 #include 


core.git: xmlsecurity/uiconfig

2024-03-16 Thread Rafael Lima (via logerrit)
 xmlsecurity/uiconfig/ui/securitylevelpage.ui |  102 +--
 1 file changed, 51 insertions(+), 51 deletions(-)

New commits:
commit 24cf7ffcb06c47e1084f08c7bcdcf15fb29f75ea
Author: Rafael Lima 
AuthorDate: Sat Mar 16 15:02:32 2024 +0100
Commit: Mike Kaganski 
CommitDate: Sat Mar 16 20:47:28 2024 +0100

Resave securitylevelpage.ui with newer Glade

Change-Id: I9a2c3b5d93453730baccec37fa0a3ac91808bad9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164873
Tested-by: Jenkins
Reviewed-by: Mike Kaganski 

diff --git a/xmlsecurity/uiconfig/ui/securitylevelpage.ui 
b/xmlsecurity/uiconfig/ui/securitylevelpage.ui
index 5292a72fcf17..911bed1c3768 100644
--- a/xmlsecurity/uiconfig/ui/securitylevelpage.ui
+++ b/xmlsecurity/uiconfig/ui/securitylevelpage.ui
@@ -1,29 +1,29 @@
 
-
+
 
   
-  
+  
   
 True
-False
+False
 True
 True
-6
+6
 vertical
-6
-12
-True
+6
+12
+True
 
   
 _Low (not recommended).
 All macros will be executed without confirmation.
 Use this setting only if you are certain that all documents that will be 
opened are safe.
 True
-True
-False
+True
+False
 True
-True
-True
+True
+True
 high
 
   
@@ -32,8 +32,8 @@ Use this setting only if you are certain that all documents 
that will be opened
 
   
   
-1
-3
+1
+3
   
 
 
@@ -41,11 +41,11 @@ Use this setting only if you are certain that all documents 
that will be opened
 _Medium.
 Confirmation required before executing macros from untrusted 
sources.
 True
-True
-False
+True
+False
 True
-True
-True
+True
+True
 high
 
   
@@ -54,8 +54,8 @@ Confirmation required before executing macros from untrusted 
sources.
 
   
   
-1
-2
+1
+2
   
 
 
@@ -64,12 +64,12 @@ Confirmation required before executing macros from 
untrusted sources.
 Only signed macros and macros from trusted file locations are executed.
 Unsigned macros are disabled.
 True
-True
-False
+True
+False
 True
-True
+True
 True
-True
+True
 
   
 Only signed macros or macros 
from a trusted file location are allowed to run. Macros signed with untrusted 
certificates will require confirmation to run, when located in untrusted file 
locations. Trusted certificates and trusted file locations can be set on the 
Trusted Sources tab page.
@@ -77,8 +77,8 @@ Unsigned macros are disabled.
 
   
   
-1
-1
+1
+1
   
 
 
@@ -87,11 +87,11 @@ Unsigned macros are disabled.
 Only macros from trusted file locations are allowed to run.
 All other macros, regardless whether signed or not, are disabled.
 True
-True
-False
+True
+False
 True
-True
-True
+True
+True
 high
 
   
@@ -100,60 +100,60 @@ All other macros, regardless whether signed or not, are 
disabled.
 
   
   
-1
-0
+1
+0
   
 
 
   
-False
-True
+False
+True
 center
 center
-res/lock.png
+res/lock.png
   
   
-0
-0
+0
+0
   
 
 
   
-False
-True
+False
+True
 center
 center
-res/lock.png
+res/lock.png
   
   
-0
-1
+0
+1
   
 
 
   
-False
-True
+False
+True
 center
 center
-res/lock.png
+res/lock.png
   
   
-0
-2
+0
+2
   
 
 
   
-False
-True
+False
+True
 center
 center
-res/lock.png
+res/lock.png
   
   
-0
-3
+0
+3
   
 
   


core.git: idl/inc

2024-03-16 Thread dmc_dev (via logerrit)
 idl/inc/basobj.hxx   |6 +-
 idl/inc/bastype.hxx  |7 +--
 idl/inc/command.hxx  |5 +
 idl/inc/database.hxx |5 +
 idl/inc/globals.hxx  |6 +-
 idl/inc/hash.hxx |5 +
 idl/inc/module.hxx   |5 +
 idl/inc/object.hxx   |7 +--
 idl/inc/parser.hxx   |5 +
 idl/inc/slot.hxx |6 +-
 idl/inc/types.hxx|6 +-
 11 files changed, 11 insertions(+), 52 deletions(-)

New commits:
commit d969251911a3499c78a3e09e0a6eb0285e8ab05c
Author: dmc_dev 
AuthorDate: Sat Mar 16 11:58:41 2024 -0500
Commit: Ilmari Lauhakangas 
CommitDate: Sat Mar 16 20:20:21 2024 +0100

tdf#143148 update all headers in idl/inc to use #pragma once

Change-Id: I65a5d21bed1753f3dbb5ad1b87fb76ea16066413
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164928
Tested-by: Ilmari Lauhakangas 
Reviewed-by: Ilmari Lauhakangas 

diff --git a/idl/inc/basobj.hxx b/idl/inc/basobj.hxx
index 2bdd8e622e44..c7d8b77f1466 100644
--- a/idl/inc/basobj.hxx
+++ b/idl/inc/basobj.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_BASOBJ_HXX
-#define INCLUDED_IDL_INC_BASOBJ_HXX
+#pragma once
 
 #include 
 #include "bastype.hxx"
@@ -122,7 +121,4 @@ public:
 { aRef = pRef; }
 };
 
-#endif // INCLUDED_IDL_INC_BASOBJ_HXX
-
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/bastype.hxx b/idl/inc/bastype.hxx
index 7494b35a8813..ff4938764c6e 100644
--- a/idl/inc/bastype.hxx
+++ b/idl/inc/bastype.hxx
@@ -17,9 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_BASTYPE_HXX
-#define INCLUDED_IDL_INC_BASTYPE_HXX
-
+#pragma once
 
 #include 
 #include 
@@ -70,7 +68,4 @@ public:
 
 boolReadStringSvIdl( SvStringHashEntry const * pName, SvTokenStream & 
rInStm, OString& aString );
 
-
-#endif // INCLUDED_IDL_INC_BASTYPE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/command.hxx b/idl/inc/command.hxx
index ea5e0f4464f5..1a3e08cb3446 100644
--- a/idl/inc/command.hxx
+++ b/idl/inc/command.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_COMMAND_HXX
-#define INCLUDED_IDL_INC_COMMAND_HXX
+#pragma once
 
 #include 
 #include 
@@ -42,6 +41,4 @@ void Init();
 class SvIdlWorkingBase;
 bool ReadIdl( SvIdlWorkingBase * pDataBase, const SvCommand & rCommand );
 
-#endif // INCLUDED_IDL_INC_COMMAND_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/database.hxx b/idl/inc/database.hxx
index dcdf935931c5..74c7c22e81b8 100644
--- a/idl/inc/database.hxx
+++ b/idl/inc/database.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_DATABASE_HXX
-#define INCLUDED_IDL_INC_DATABASE_HXX
+#pragma once
 
 #include "module.hxx"
 #include "hash.hxx"
@@ -136,6 +135,4 @@ public:
 boolWriteSfx( SvStream & );
 };
 
-#endif // INCLUDED_IDL_INC_DATABASE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/globals.hxx b/idl/inc/globals.hxx
index 0739d8757b32..b72d53fafae2 100644
--- a/idl/inc/globals.hxx
+++ b/idl/inc/globals.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_GLOBALS_HXX
-#define INCLUDED_IDL_INC_GLOBALS_HXX
+#pragma once
 
 #include "hash.hxx"
 #include 
@@ -122,7 +121,4 @@ HASH_INLINE(ReadOnlyDoc)
 HASH_INLINE(struct)
 HASH_INLINE(DisableFlags)
 
-
-#endif // INCLUDED_IDL_INC_GLOBALS_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/hash.hxx b/idl/inc/hash.hxx
index 86b2af448133..fd0a6f466375 100644
--- a/idl/inc/hash.hxx
+++ b/idl/inc/hash.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_HASH_HXX
-#define INCLUDED_IDL_INC_HASH_HXX
+#pragma once
 
 #include 
 #include 
@@ -56,6 +55,4 @@ public:
 OString GetNearString( std::string_view rName ) const;
 };
 
-#endif // INCLUDED_IDL_INC_HASH_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/module.hxx b/idl/inc/module.hxx
index 08c14cc9c2b2..68069e4d28d4 100644
--- a/idl/inc/module.hxx
+++ b/idl/inc/module.hxx
@@ -17,8 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#ifndef INCLUDED_IDL_INC_MODULE_HXX
-#define INCLUDED_IDL_INC_MODULE_HXX
+#pragma once
 
 #include "object.hxx"
 
@@ -32,6 +31,4 @@ public:
 voidWriteSfx( SvIdlDataBase & rBase, SvStream & rOutStm );
 };
 
-#endif // INCLUDED_IDL_INC_MODULE_HXX
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/idl/inc/object.hxx b/idl/inc/object.hxx
index 4254a4e1f318..1c1ff4c37988 100644
--- a/idl/inc/object.hxx
+++ b/idl/inc/object.hxx
@@ -17,13 +17,10 @@
  *   the License at http://www.apache.org/lic

core.git: sc/inc sc/source sw/inc sw/qa sw/source

2024-03-16 Thread Noel Grandin (via logerrit)
 sc/inc/docpool.hxx   |2 --
 sc/source/ui/inc/pfuncache.hxx   |3 ---
 sc/source/ui/view/pfuncache.cxx  |9 +++--
 sw/inc/tox.hxx   |8 +++-
 sw/qa/unit/sw-dialogs-test.cxx   |2 --
 sw/qa/unit/sw-dialogs-test_2.cxx |3 ---
 sw/source/core/crsr/crstrvl.cxx  |2 +-
 7 files changed, 7 insertions(+), 22 deletions(-)

New commits:
commit 471bbaf15fb392a194b9392d982cf2e33495f4b3
Author: Noel Grandin 
AuthorDate: Sat Mar 16 17:58:30 2024 +0200
Commit: Noel Grandin 
CommitDate: Sat Mar 16 19:58:41 2024 +0100

loplugin:unusedfields

Change-Id: I91ec189ea1f389a978ef56339bbf6b43cbec6798
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164929
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/sc/inc/docpool.hxx b/sc/inc/docpool.hxx
index 614e3d4229b8..af6d9535177d 100644
--- a/sc/inc/docpool.hxx
+++ b/sc/inc/docpool.hxx
@@ -28,8 +28,6 @@ class ScDocument;
 
 class SC_DLLPUBLIC ScDocumentPool final : public SfxItemPool
 {
-std::vector mvPoolDefaults;
-
 public:
 ScDocumentPool();
 private:
diff --git a/sc/source/ui/inc/pfuncache.hxx b/sc/source/ui/inc/pfuncache.hxx
index 7cd286f39223..7eddedd258be 100644
--- a/sc/source/ui/inc/pfuncache.hxx
+++ b/sc/source/ui/inc/pfuncache.hxx
@@ -90,9 +90,6 @@ class ScPrintFuncCache
 std::vector   nFirstAttr;
 std::vector aLocations;
 boolbLocInitialized;
-SizeaPrintPageSize;  // print page size in 
Print dialog
-boolbPrintPageLandscape; // print page orientation 
in Print dialog
-boolbUsePrintDialogSetting;  // use Print dialog 
setting
 
 public:
 ScPrintFuncCache(ScDocShell* pD, const ScMarkData& rMark, 
ScPrintSelectionStatus aStatus,
diff --git a/sc/source/ui/view/pfuncache.cxx b/sc/source/ui/view/pfuncache.cxx
index 078633da5da0..aa6abd52e7ff 100644
--- a/sc/source/ui/view/pfuncache.cxx
+++ b/sc/source/ui/view/pfuncache.cxx
@@ -28,16 +28,13 @@
 #include 
 
 ScPrintFuncCache::ScPrintFuncCache(ScDocShell* pD, const ScMarkData& rMark,
-   ScPrintSelectionStatus aStatus, Size 
aPageSize, bool bLandscape,
-   bool bUsed)
+   ScPrintSelectionStatus aStatus, Size 
aPrintPageSize, bool bPrintPageLandscape,
+   bool bUsePrintDialogSetting)
 :
 aSelection(std::move( aStatus )),
 pDocSh( pD ),
 nTotalPages( 0 ),
-bLocInitialized( false ),
-aPrintPageSize( aPageSize ),
-bPrintPageLandscape( bLandscape ),
-bUsePrintDialogSetting( bUsed )
+bLocInitialized( false )
 {
 //  page count uses the stored cell widths for the printer anyway,
 //  so ScPrintFunc with the document's printer can be used to count
diff --git a/sw/inc/tox.hxx b/sw/inc/tox.hxx
index 74b26b9515d7..bd1c25f50668 100644
--- a/sw/inc/tox.hxx
+++ b/sw/inc/tox.hxx
@@ -54,11 +54,9 @@ namespace sw {
 };
 struct FindContentFrameHint final : SfxHint {
 SwContentFrame*& m_rpContentFrame;
-const SwDoc& m_rDoc;
 const SwRootFrame& m_rLayout;
-FindContentFrameHint(SwContentFrame*& rpContentFrame, const SwDoc& 
rDoc, const SwRootFrame& rLayout)
+FindContentFrameHint(SwContentFrame*& rpContentFrame,const 
SwRootFrame& rLayout)
 : m_rpContentFrame(rpContentFrame)
-, m_rDoc(rDoc)
 , m_rLayout(rLayout)
 {}
 };
@@ -185,10 +183,10 @@ public:
 SwDoc& GetDoc() const { return m_rDoc; }
 void CollectTextMarks(SwTOXMarks& rMarks) const
 { 
const_cast(this)->GetNotifier().Broadcast(sw::CollectTextMarksHint(rMarks));
 }
-SwContentFrame* FindContentFrame(const SwDoc& rDoc, const SwRootFrame& 
rLayout) const
+SwContentFrame* FindContentFrame(const SwRootFrame& rLayout) const
 {
 SwContentFrame* pContentFrame = nullptr;
-
const_cast(this)->GetNotifier().Broadcast(sw::FindContentFrameHint(pContentFrame,
 rDoc, rLayout));
+
const_cast(this)->GetNotifier().Broadcast(sw::FindContentFrameHint(pContentFrame,
 rLayout));
 return pContentFrame;
 }
 void 
CollectTextTOXMarksForLayout(std::vector>&
 rMarks, const SwRootFrame* pLayout) const
diff --git a/sw/qa/unit/sw-dialogs-test.cxx b/sw/qa/unit/sw-dialogs-test.cxx
index 0e9bd50db309..ee5d3dec4d11 100644
--- a/sw/qa/unit/sw-dialogs-test.cxx
+++ b/sw/qa/unit/sw-dialogs-test.cxx
@@ -10,7 +10,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -28,7 +27,6 @@ class SwDialogsTest : public ScreenshotTest
 {
 private:
 css::uno::Reference component_;
-osl::Module libSwui_;
 
 /// helper method to populate KnownDialogs, called in setUp(). Needs to be
 /// written and has to add entries to KnownDialogs
diff --git a/sw/qa/unit/sw-dialogs-test_2.cxx b/sw/qa/unit/sw-dialogs-test_2.cxx
index e0de8

core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 55bf8a21d06c47760976f4d0051248797be47a61
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:07:37 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:51:03 2024 +0100

Fix typo

Change-Id: I67c1591af46b530c3cbf46b0871d863a5c0aec24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164907
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 5efe74036760..4bfabb381414 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -1684,7 +1684,7 @@ class SFScriptForge:
 """
 Gets the offset between GMT and the given timezone and locale, 
in minutes.
 Args
-``imezone``: the timezone for which the offset to the 
GMT will be calculated.
+``timezone``: the timezone for which the offset to the 
GMT will be calculated.
 
 ``locale``: the locale specifying the country for 
which the offset will be calculated,
 given either in "la-CO" or "CO" formats.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 08750535c5c88dced2e46710506efc06d8312c0f
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:05:28 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:50:47 2024 +0100

Fix typo

Change-Id: Ie04b3b3a96b2d4651b6dc477215f29a48c1be4c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164901
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index e3f4c3a2fecd..5efe74036760 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -3440,7 +3440,7 @@ class SFDialogs:
 accuracy: int = ...
 ) -> Optional[DIALOGCONTROL]:
 """
-Create a new control of type ``CurrenyField`` in the actual 
dialog.
+Create a new control of type ``CurrencyField`` in the actual 
dialog.
 Args
 ``controlname``:  the name of the new control. It must 
not exist yet.
 


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a0d5d8d16595dd9e9b2adcdd1817650b25569554
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:05:46 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:50:27 2024 +0100

Fix typo

Change-Id: I1264c4594bbedf7398816552795e33c489ef2863
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164902
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 8a2a3f050be1..e3f4c3a2fecd 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -769,7 +769,7 @@ class SFScriptForge:
 Use the console when the Python shell is not available, for 
example in ``Calc`` user defined functions (UDF)
 or during events processing.
 
-Use the ``DebugPrint()`` and ``DebuDisplay()`` methods to log any 
relevant information, events  and data
+Use the ``DebugPrint()`` and ``DebugDisplay()`` methods to log any 
relevant information, events  and data
 of any type to the console.
 
 Console entries can be dumped to a text file or visualized in a 
dialogue.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 3764ae10f86f4b40f98b0e69e61268604c331c27
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:10:47 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:49:54 2024 +0100

Fix typo

Change-Id: I8c5c281897c53afb456b63c5f3838059bd1887d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164912
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 251e24184ca8..8a2a3f050be1 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -2749,7 +2749,7 @@ class SFDatabases:
 ``sqlcommand``: a table name, a query name or a 
``SELECT SQL`` statement.
 
 ``directsql``: when ``True``, no syntax conversion is 
done by LibreOffice.
-Ignored when ``sqlommand`` is a table or a query name. 
Defaults to ``False``.
+Ignored when ``sqlcommand`` is a table or a query 
name. Defaults to ``False``.
 
 ``header``: when ``True``, a header row is inserted on 
the top of the list with the
 column names. Defaults to ``False``.
@@ -4441,7 +4441,7 @@ class SFDocuments:
 IsWriter: bool
 """ ``True`` when type of document = ``Writer``."""
 Keywords: str
-""" Get/set the ``Keywords`` property of the document as a 
comma-seprated list of keywords.
+""" Get/set the ``Keywords`` property of the document as a 
comma-separated list of keywords.
 This property is not applicable to ``Base`` documents. """
 Readonly: bool
 """ ``True`` if the document is actually in read-only mode.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 42a01a525b325bf381cb5e08bc74416d1d4d64a5
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:08:33 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:49:23 2024 +0100

Fix typo

Change-Id: Iac27e35e92ec8f481d0d6ba71c87f72e10a99ffb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164910
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index f47592d1888a..251e24184ca8 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -977,7 +977,7 @@ class SFScriptForge:
 
 def CreateFolder(self, foldername: FILE) -> bool:
 """
-Creates the specified ``olderame``.
+Creates the specified ``foldername``.
 If the specified folder has a parent folder that does not 
exist, it is created.
 Args
 foldername: a string representing the folder to 
create. It must not exist.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5569de72d7e8c4db34df5ffa10e0f46234cff1e7
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:11:12 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:48:44 2024 +0100

Fix typo

Change-Id: I07c180c9b659950fa0ecc4bf8ca26f2d133a393c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164913
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 6cc54616e70d..f47592d1888a 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -2843,7 +2843,7 @@ class SFDatabases:
 call the ``Commit()`` method to apply the changes to the 
database.
 
 Args
-``tranactionmode``: specifies the transaction mode.
+``transactionmode``: specifies the transaction mode.
 This argument must be one of the constants defined in 
``com.sun.star.sdbc.TransactionIsolation``
 (Default = ``NONE``)
 Returns


core.git: 2 commits - wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.py  |2 +-
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d845d151fd17428082aef4033353a60d7540ec3d
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:13:38 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:47:47 2024 +0100

Fix typo

Change-Id: I5bece7e286f8ebced0f5f45fff7377037b546a37
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164918
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.py 
b/wizards/source/scriptforge/python/scriptforge.py
index c01d40b57fe0..cdb627fdc258 100644
--- a/wizards/source/scriptforge/python/scriptforge.py
+++ b/wizards/source/scriptforge/python/scriptforge.py
@@ -56,7 +56,7 @@
 ScriptForge(hostname = 'localhost', port = 2024)
 
 When the user uses an IDE like PyCharm or VSCode, (s)he might benefit 
from the typing
-hints provided by them thanks to the twin scriptforhe.pyi module.
+hints provided by them thanks to the twin scriptforge.pyi module.
 
 Specific documentation about the use of ScriptForge from Python scripts:
 
https://help.libreoffice.org/latest/en-US/text/sbasic/shared/03/sf_intro.html?DbPAR=BASIC
commit da7c50f6f74e79201e23cdc032b2288b6679e2c9
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:12:29 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:47:34 2024 +0100

Fix typo

Change-Id: I0db6ac0b9edfd6953d668dd0949c692630665a2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164915
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 41d10c27f2b3..6cc54616e70d 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -6835,7 +6835,7 @@ class SFWidgets:
script: SCRIPT_URI = ...,
) -> int:
 """
-Inserts a radio btton in the menu.
+Inserts a radio button in the menu.
 Args
 ``menuitem``: defines the text to be displayed in the 
menu.
 This argument also defines the hierarchy of the item 
inside the menu by using the submenu


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 66567a0bcd9374fcc99813315c02b64b2c5a2066
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:03:22 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:47:17 2024 +0100

Fix typo

Change-Id: I3620d218898a91293d57611d4dcf062f75045892
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164897
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index dbbf38da8391..41d10c27f2b3 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -6686,7 +6686,7 @@ class SFDocuments:
 
 ``printoddpages``: print the right pages when ``True`` 
(default).
 
-``printimages``: print the graphic objects when 
``True`` (defauly).
+``printimages``: print the graphic objects when 
``True`` (default).
 Returns
  ``True`` when successful.
 """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c1215a2e085395a38fb83ad1a854d698c0e9cf31
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:08:08 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:46:56 2024 +0100

Fix typo

Change-Id: I0a68811af1f5b9d32f453592ec357fa694747d35
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164909
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 5ef926d44fe2..dbbf38da8391 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -6569,7 +6569,7 @@ class SFDocuments:
 Returns a Database service instance (service = 
``SFDatabases.Database``) giving access
 to the execution of SQL commands on the database linked with 
the actual form document.
 Args
-``user``, ``oassword``: the login parameters.
+``user``, ``password``: the login parameters.
 """
 ...
 


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b360a2b64f4c6937f92fc01614d21faeeca42bf2
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:03:07 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:46:34 2024 +0100

Fix typo

Change-Id: Ibb07cca05ef733932326ceb29aa3fd1cd1e969d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164896
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index f70e3490ce6d..5ef926d44fe2 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -6601,7 +6601,7 @@ class SFDocuments:
 
 ``printoddpages``: print the right pages when ``True`` 
(default).
 
-``printimages``: print the graphic objects when 
``True`` (defauly).
+``printimages``: print the graphic objects when 
``True`` (default).
 Returns
  ``True`` when successful.
 """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3f9a557813633f95ff7191241955fa343093be21
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:07:03 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:46:08 2024 +0100

Fix typo

Change-Id: Id099d4e9471415d572f7eac56e70d20cbae8e577
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164906
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 4ae1e93dfdde..f70e3490ce6d 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -608,7 +608,7 @@ class SFScriptForge:
 
 ``title``: String expression displayed in the title 
bar of the dialog box.
 
-``default``: String expression displayed in the text 
box as default ifno other input is given.
+``default``: String expression displayed in the text 
box as default if no other input is given.
 
 ``xpostwips``: Integer expression that specifies the 
horizontal position of the dialog.
 The position is an absolute coordinate and does not 
refer to the window of LibreOffice.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7abfe574e2c5ef026ea31d5ae2e76315fa842569
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:06:47 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:45:46 2024 +0100

Fix typo

Change-Id: I42521b965da582e00e4fa9186bb5de3ea3defd4f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164905
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index c9ab46376efb..4ae1e93dfdde 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -7000,7 +7000,7 @@ class SFWidgets:
 """
 Displays the popup menu and waits for a user action.
 Args
-``returnid``: if ``True`` (default), the numeric 
identfier of the selected item is returned.
+``returnid``: if ``True`` (default), the numeric 
identifier of the selected item is returned.
 If ``False``, the method returns the item's name.
 Returns
 The item clicked by the user.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d7d37ac32c5c7828d376fd71e4a3f5fbc359a22f
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:09:53 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:45:20 2024 +0100

Fix typo

Change-Id: I2e38b46435d927fe4fe8d656c92e7a75a5771ba1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164911
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index b3e88e901081..c9ab46376efb 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -130,7 +130,7 @@ SCRIPT_URI = TypeVar('SCRIPT_URI', str, str)
 """
 SQL_SELECT = TypeVar('SQL_SELECT', str, str)
 """ A SQL command containing a SELECT statement, a tablename or a queryname.
-In a SELECT statement, table-, qyery- and field names may be surrounded by 
square brackets. """
+In a SELECT statement, table-, query- and field names may be surrounded by 
square brackets. """
 SQL_ACTION = TypeVar('SQL_ACTION', str, str)
 """ A SQL command containing an action statement (CREATE TABLE, INSERT, 
DELETE, ...).
 Table- and field names may be surrounded by square brackets. """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7e0a186d18b1fabe85816d9656925dce9b552dd0
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:07:55 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:44:56 2024 +0100

Fix typo

Change-Id: I3f6f98e2781dd6ca37483ca4224b76f7b474a909
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164908
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index b39777162f79..b3e88e901081 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -3912,7 +3912,7 @@ class SFDialogs:
 
 ``border``: "3D" (default), "FLAT" or "NONE".
 
-``mintome``:  the smallest time that can be entered in 
the control. Default = 0h.
+``mintime``:  the smallest time that can be entered in 
the control. Default = 0h.
 
 ``maxtime``:  the largest time that can be entered in 
the control. Default = 24h.
 Returns


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 36f6aea73fcac19d14d5362476e9de6887d92612
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:12:36 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:44:32 2024 +0100

Fix typo

Change-Id: I5b5182b56259808e7c4c351f24510806bf79c9fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164916
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 371d7b8c22c1..b39777162f79 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -6975,7 +6975,7 @@ class SFWidgets:
tooltip: str = ...,
) -> int:
 """
-Inserts a radio btton in the menu.
+Inserts a radio button in the menu.
 Args
 ``menuitem``: defines the text to be displayed in the 
menu.
 This argument also defines the hierarchy of the item 
inside the menu by using the submenu


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5640b1b0d340301e0b90506952eef2d67e0b8ad1
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:04:55 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:44:11 2024 +0100

Fix typo

Change-Id: I58ae1ae35bef53a79dfb60ac17b485e7e22a8d87
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164900
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index f823d713ff58..371d7b8c22c1 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -4835,7 +4835,7 @@ class SFDocuments:
 
 def IsLoaded(self, formdocument: str) -> bool:
 """
-Return ``True`` if the given form Ddcument is currently open.
+Return ``True`` if the given form Document is currently open.
 Args
 ``formdocument``: A valid hierarchical form document 
name as a case-sensitive string.
 """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c68303fb07ad061fc55e978064fe8bb959a3a6fe
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:14:06 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:43:42 2024 +0100

Fix typo

Change-Id: I6e332fc1366cf6cc20f7d4bbb546996bcfcfc6f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164919
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index a1b244e111de..f823d713ff58 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -4108,7 +4108,7 @@ class SFDialogs:
 Format: Literal["Standard (short)", "Standard (short YY)", "Standard 
(short )", "Standard (long)",
 "DD/MM/YY", "MM/DD/YY", "YY/MM/DD", "DD/MM/", "MM/DD/", 
"/MM/DD", "YY-MM-DD", "-MM-DD",
 "24h short", "24h long", "12h short", "12h long"]
-""" Get/set the format used to display dates and times. Applicable to 
``DateField, TimeFiels, FormattedField``
+""" Get/set the format used to display dates and times. Applicable to 
``DateField, TimeField, FormattedField``
 controls.   """
 Height: int
 """ Get/set the height of the control.   """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7c42fca202ae6aeecbb85b18e9166bab050a48f9
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:13:28 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:42:52 2024 +0100

Fix typo

Change-Id: I5c2075d5c3e87fe5e4f56d884bf7bcfb7371498b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164917
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.py 
b/wizards/source/scriptforge/python/scriptforge.py
index e339ada06d63..c01d40b57fe0 100644
--- a/wizards/source/scriptforge/python/scriptforge.py
+++ b/wizards/source/scriptforge/python/scriptforge.py
@@ -41,7 +41,7 @@
 The scriptforge.pyi module
 - provides the static type checking of all the visible interfaces of 
the ScriptForge API.
 - when the user uses an IDE like PyCharm or VSCode, (s)he might 
benefit from the typing
-  hints provided by them thanks to the twin scriptforhe.pyi module.
+  hints provided by them thanks to the twin scriptforge.pyi module.
 
 Usage:
 


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 26785eed7615fb9467892d59f6b9a525e388980f
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:15:14 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:42:08 2024 +0100

Fix typo

Change-Id: Ib1f5fdc8c44c62619325f6d21d834459905fab44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164921
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index c08c618373cf..a1b244e111de 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -1578,7 +1578,7 @@ class SFScriptForge:
 
 def Language(self, region: str = ...) -> str:
 """
-Gets tthe name of the language, in English, of the specified 
region.
+Gets the name of the language, in English, of the specified 
region.
 Args
 ``region``: formatted as "la-CO" or "la".
 """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5b7e83ddb004c1e97ccaba3ef6967f152c44e7f5
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:14:16 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:41:44 2024 +0100

Fix typo

Change-Id: I54dff81d7dffda684f3e39a5ebf1dda06959b9dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164920
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 143e93ab865d..c08c618373cf 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -6389,7 +6389,7 @@ class SFDocuments:
 Format: Literal["Standard (short)", "Standard (short YY)", "Standard 
(short )", "Standard (long)",
 "DD/MM/YY", "MM/DD/YY", "YY/MM/DD", "DD/MM/", "MM/DD/", 
"/MM/DD", "YY-MM-DD", "-MM-DD",
 "24h short", "24h long", "12h short", "12h long"]
-""" Get/set the format used to display dates and times. Applicable to 
``DateField, TimeFiels, FormattedField``
+""" Get/set the format used to display dates and times. Applicable to 
``DateField, TimeField, FormattedField``
 controls.   """
 ListCount: int
 """ Get the number of rows in the control. Applicable to ``ComboBox, 
ListBox`` controls.  """


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 85eb0d1394f1c867e932671192fecc815c5915eb
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:16:25 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:38:12 2024 +0100

Fix typo

Change-Id: I965793a29a92eedbb541a22b5be0350c6b98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164923
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins
Tested-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 7b2cd2fc9b77..143e93ab865d 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -5605,7 +5605,7 @@ class SFDocuments:
 ``sheetname``: the name of the new sheet.
 
 ``beforesheet``: the name (string) or index (numeric, 
starting from 1) of the sheet
-efore which to insert the new sheet. This argument is 
optional and the default behavior
+before which to insert the new sheet. This argument is 
optional and the default behavior
 is to insert the sheet at the last position.
 Returns
 ``True`` if the sheet could be inserted successfully.


core.git: wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit da56c68f5a3ff0c7f310224e83b7a60cb8b38632
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:12:12 2024 +0100
Commit: Julien Nabet 
CommitDate: Sat Mar 16 19:37:42 2024 +0100

Fix typo

Change-Id: I493fece1547f15d1e428146928e34807a96636a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164914
Tested-by: Julien Nabet 
Reviewed-by: Julien Nabet 

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index 0f0e77d98cfd..7b2cd2fc9b77 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -5697,7 +5697,7 @@ class SFDocuments:
 When ``False`` range selection is allowed.
 
 ``closeafterselect``: when ``True`` (default) the 
dialog is closed immediately after
-the selection is made. wWhen ``False`` the user can 
change the selection as many times
+the selection is made. When ``False`` the user can 
change the selection as many times
 as needed. Dialog closure is manual.
 Returns
 The selected range as a string, or the empty string 
when the user cancelled the request.


David Carter License statement

2024-03-16 Thread David
All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

Very Respectfully,

David Carter


Re: Official support for windows-arm64

2024-03-16 Thread Sophia Schröder




And even if it was - a change in the buildsystem (be it cmake, meson 
or whatever else) doesn't change that architecture-specific *code* (or 
compiler options, for some matters) needs to be changed.


Build system stuff doesn't change that. 


That is completely clear to me. But if cmake for windows is even portet 
to arm, it should be easier to work with on arm for windows arm 
architecture.


But anyway, I'll shut up now.


Re: Official support for windows-arm64

2024-03-16 Thread Rene Engelhard

Hi,

Am 16.03.24 um 17:23 schrieb Sophia Schröder:
then I probably misunderstood the ESC minutes from 2024/02/29: 

Yes.


+ cmake find modules for SDK examples (Hossein)
  + Set of patches from Konstantin (WIP)
https://gerrit.libreoffice.org/c/core/+/162978
  + Similar structure is needed for qmake


That is solely for the examples shipped in  the SDK. Not for LO itself.


And even if it was - a change in the buildsystem (be it cmake, meson or 
whatever else) doesn't change that architecture-specific *code* (or 
compiler options, for some matters) needs to be changed.


Build system stuff doesn't change that.


Regards,


Rene



Re: Official support for windows-arm64

2024-03-16 Thread Sophia Schröder

Hi Ilmary,

then I probably misunderstood the ESC minutes from 2024/02/29:

+ cmake find modules for SDK examples (Hossein)
  + Set of patches from Konstantin (WIP)
https://gerrit.libreoffice.org/c/core/+/162978
  + Similar structure is needed for qmake
  + would this mean duplicated build systems for each example? 
(Miklos)
    + for each example, the maintenance would be low, hopefully 
(Hossein)
  + would be the goal to have old/cmake/qmake, 3 parallel build 
systems? (Miklos)

    + yes, for now (Hossein)
    + the cmake part for each example is small
  + smells like explosion of combinatorics (Stephan)
    + would be careful before going down that road
  + if the end goal is to settle down on cmake, love it (Thorsten)
    + but 3 in the long run is far from ideal.
  + cmake is not that exotic, we require it already for doxygen 
(Miklos)

    + which makes it supported on CI already (Thorsten)
  + if interested in doing the work + update the docs, then why 
not, as long as it's a single build system (Stephan)
    + but then do avoid qmake, and do switch over from gmake at the 
end

    + avoids the exploson


Sorry for the noise


Am 16.03.24 um 17:18 schrieb Ilmari Lauhakangas:

On 16.3.2024 17.41, Sophia Schröder wrote:

Hi all,

Just a side note from a community member:

I don't know how much the hassle and the costs are,
but LibreOffice wants to switch to Cmake anyway.
(I saw Cmake mentioned at Linaro's webpage).


There has been quite a lot of work toward building LibreOffice with 
Meson. There has not been discussion about investing time into 
building with CMake.


Ilmari

Re: Official support for windows-arm64

2024-03-16 Thread Ilmari Lauhakangas

On 16.3.2024 17.41, Sophia Schröder wrote:

Hi all,

Just a side note from a community member:

I don't know how much the hassle and the costs are,
but LibreOffice wants to switch to Cmake anyway.
(I saw Cmake mentioned at Linaro's webpage).


There has been quite a lot of work toward building LibreOffice with 
Meson. There has not been discussion about investing time into building 
with CMake.


Ilmari


Re: Official support for windows-arm64

2024-03-16 Thread Sophia Schröder

Hi all,

Just a side note from a community member:

I don't know how much the hassle and the costs are,
but LibreOffice wants to switch to Cmake anyway.
(I saw Cmake mentioned at Linaro's webpage).

Probably we can kill several birds with one stone.
Or at least can do some steps in that direction...

Am 15.03.24 um 15:12 schrieb Thorsten Behrens:

Hi Pierrick,

Christian Lohmaier wrote:

and we discussed that with Microsoft, which could sponsors
up to two (physical) machines for this.

Let us know how we can help!

Thanks for the offer, now the hard part begins: Finding people with
the required skills to make use of that ;-)


Provided there's some easy access to native ARM hardware, Stephan (in
Cc) would be interested in prodding the bridge problem a bit. I'd be
happy to fund at least the engineering hours for a while.

Cheers, Thorsten


Cheers, Sophia

core.git: 2 commits - external/skia include/oox RepositoryExternal.mk solenv/gbuild vcl/Library_vclplug_gen.mk vcl/Library_vclplug_osx.mk vcl/Library_vclplug_win.mk

2024-03-16 Thread Noel Grandin (via logerrit)
 RepositoryExternal.mk   |   15 ++
 external/skia/Library_skia.mk   |   85 ++--
 external/skia/Module_skia.mk|2 
 include/oox/core/recordparser.hxx   |4 -
 solenv/gbuild/PrecompiledHeaders.mk |1 
 vcl/Library_vclplug_gen.mk  |4 -
 vcl/Library_vclplug_osx.mk  |5 --
 vcl/Library_vclplug_win.mk  |8 ---
 8 files changed, 53 insertions(+), 71 deletions(-)

New commits:
commit d097dbc8688b32e7865eca3baab1dd406c306441
Author: Noel Grandin 
AuthorDate: Sat Mar 16 13:21:03 2024 +0100
Commit: Noel Grandin 
CommitDate: Sat Mar 16 16:02:31 2024 +0100

Revert "make skia into static library"

This reverts commit 806b6014db796a3970332f9cefaaabf9355d0d8f.

Reverting for now, this does not work with --enable-mergelib

Change-Id: Ib44f819d0da9ed3769f76fc40b5c15ce097390a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164872
Tested-by: René Engelhard 
Reviewed-by: René Engelhard 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index ffe20765c2fa..60499758de40 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -135,20 +135,15 @@ $(call gb_LinkTarget_set_include,$(1),\
-I$(SRCDIR)/external/skia/inc/ \
$$(INCLUDE) \
 )
-$(call gb_LinkTarget_use_static_libraries,$(1),skia)
+$(call gb_LinkTarget_use_libraries,$(1),skia)
 $(call gb_LinkTarget_add_defs,$(1),\
-DSK_USER_CONFIG_HEADER="<$(BUILDDIR)/config_host/config_skia.h>" \
+   -DSKIA_DLL \
 )
-
 endef
-
-define gb_ExternalProject__use_skia
-$(call gb_ExternalProject_use_static_libraries,$(1),\
-  skia \
-)
-
-endef
-
+$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo,\
+skia \
+))
 endif
 
 ifeq (SANE,$(filter SANE,$(BUILD_TYPE)))
diff --git a/external/skia/StaticLibrary_skia.mk b/external/skia/Library_skia.mk
similarity index 95%
rename from external/skia/StaticLibrary_skia.mk
rename to external/skia/Library_skia.mk
index 250f846f51a6..c2163d299327 100644
--- a/external/skia/StaticLibrary_skia.mk
+++ b/external/skia/Library_skia.mk
@@ -7,18 +7,19 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_StaticLibrary_StaticLibrary,skia))
+$(eval $(call gb_Library_Library,skia))
 
-$(eval $(call gb_StaticLibrary_set_warnings_disabled,skia))
+$(eval $(call gb_Library_set_warnings_disabled,skia))
 
-$(eval $(call gb_StaticLibrary_use_unpacked,skia,skia))
+$(eval $(call gb_Library_use_unpacked,skia,skia))
 
-$(eval $(call gb_StaticLibrary_use_clang,skia))
+$(eval $(call gb_Library_use_clang,skia))
 #This currently results in all sorts of compile complaints
-#$(eval $(call 
gb_StaticLibrary_set_clang_precompiled_header,skia,external/skia/inc/pch/precompiled_skia))
+#$(eval $(call 
gb_Library_set_clang_precompiled_header,skia,external/skia/inc/pch/precompiled_skia))
 
-$(eval $(call gb_StaticLibrary_add_defs,skia,\
+$(eval $(call gb_Library_add_defs,skia,\
 -DSKIA_IMPLEMENTATION=1 \
+-DSKIA_DLL \
 -DSK_USER_CONFIG_HEADER="<$(BUILDDIR)/config_host/config_skia.h>" \
 $(if $(filter INTEL,$(CPUNAME)),$(if $(filter 
WNT,$(OS)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE1,-DSK_CPU_SSE_LEVEL=0)) \
 $(if $(filter X86_64,$(CPUNAME)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE2) 
\
@@ -31,7 +32,7 @@ $(eval $(call gb_StaticLibrary_add_defs,skia,\
 # Some code may be always built with optimizations, even with Skia debug 
enabled (see
 # $(gb_COMPILEROPTFLAGS) usage).
 ifeq ($(ENABLE_SKIA_DEBUG),)
-$(eval $(call gb_StaticLibrary_add_cxxflags,skia, \
+$(eval $(call gb_Library_add_cxxflags,skia, \
 $(gb_COMPILEROPTFLAGS) \
 $(PCH_NO_CODEGEN) \
 ))
@@ -40,11 +41,11 @@ endif
 ifeq ($(OS),WNT)
 # Skia can be built with or without UNICODE set, in LO sources we explicitly 
use the *W unicode
 # variants, so build Skia with UNICODE to make it also use the *W variants.
-$(eval $(call gb_StaticLibrary_add_defs,skia,\
+$(eval $(call gb_Library_add_defs,skia,\
 -DUNICODE -D_UNICODE \
 ))
 ifneq ($(gb_ENABLE_PCH),)
-$(eval $(call gb_StaticLibrary_add_cxxflags,skia, \
+$(eval $(call gb_Library_add_cxxflags,skia, \
 -FIsrc/utils/win/SkDWriteNTDDI_VERSION.h \
 ))
 endif
@@ -52,13 +53,13 @@ endif
 # The clang-cl provided with at least VS 2019 16.11.28 is known-broken with 
-std:c++20:
 ifneq ($(filter -std:c++20,$(CXXFLAGS_CXX11)),)
 ifeq ($(LO_CLANG_VERSION),12)
-$(eval $(call gb_StaticLibrary_add_cxxflags,skia, \
+$(eval $(call gb_Library_add_cxxflags,skia, \
 -std:c++17 \
 ))
 endif
 endif
 
-$(eval $(call gb_StaticLibrary_use_system_win32_libs,skia,\
+$(eval $(call gb_Library_use_system_win32_libs,skia,\
 fontsub \
 ole32 \
 oleaut32 \
@@ -79,7 +80,7 @@ endif
 
 else ifeq ($(OS),MACOSX)
 
-$(eval $(call gb_StaticLibrary_use_system_darwin_frameworks,skia,\
+$(eval $(call gb_Library_use_system_darwin_frameworks,skia,\
 Cocoa \
 Metal \
 QuartzCore \
@@ -87,13 +88,13 @@ $(eval $(call 
gb_

GSOC Contributor

2024-03-16 Thread Ahmed OSAMA
Hi,
I am Ahmed Osama, a third year student at the German international
University majoring in computer science (Software Engineering).I am
interested in contributing in LibreOffice this year as I see many projects
that meet my interests and skills.

Regards,
Ahmed Osama.


core.git: 2 commits - wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5208cc2995a0dfb0377b9d14df469e67939de012
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:06:27 2024 +0100
Commit: Andrea Gelmini 
CommitDate: Sat Mar 16 13:00:38 2024 +0100

Fix typo

Change-Id: Ic25c4b9fe4fe898de328f1ea98ef69983c66a7c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164904
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index a698f7710d4e..0f0e77d98cfd 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -1398,7 +1398,7 @@ class SFScriptForge:
 or by a successful invocation of the L10N service with the 
``FolderName`` argument.
 The generated file should pass successfully the ``"msgfmt 
--check 'the pofile'"`` GNU command.
 Args
-``filename``: the complete file name (in 
``filesstem.FileNaming`` notation)
+``filename``: the complete file name (in 
``filesystem.FileNaming`` notation)
 to export to. If it exists, it is overwritten without 
warning.
 
 ``header``: comments that will appear on top of the 
generated file. Do not include
commit 4640cec9206f890bd79fee2310f6ee144aa12752
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:06:10 2024 +0100
Commit: Andrea Gelmini 
CommitDate: Sat Mar 16 13:00:24 2024 +0100

Fix typo

Change-Id: I794f03ec9fe6cc7f1adfe790432a3e252da54b70
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164903
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index d4556830e225..a698f7710d4e 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -3483,7 +3483,7 @@ class SFDialogs:
 
 ``border``: "3D" (default), "FLAT" or "NONE".
 
-``dropdown``: when ``True`` a dropdwn button is shown. 
Default = ``False``.
+``dropdown``: when ``True`` a dropdown button is 
shown. Default = ``False``.
 
 ``mindate``:  the smallest date that can be entered in 
the control. Default = 1900-01-01.
 
@@ -3492,7 +3492,7 @@ class SFDialogs:
 A ``SFDialogs.SF_DialogControl`` instance or ``None``.
 """
 ...
-
+
 def CreateFileControl(self,
   controlname: str,
   place: Union[UNO, Tuple[int, int, int, int]],


core.git: 2 commits - wizards/source

2024-03-16 Thread Andrea Gelmini (via logerrit)
 wizards/source/scriptforge/python/scriptforge.pyi |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ff7ed8ccca4165ecc4b23a9670ceb63fe8e8a313
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:04:16 2024 +0100
Commit: Andrea Gelmini 
CommitDate: Sat Mar 16 13:00:11 2024 +0100

Fix typo

Change-Id: I8c2e3dcfddd27aa7d32feb7a3c7923b411cdafa6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164899
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index d37105b4a36e..d4556830e225 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -4178,11 +4178,11 @@ class SFDialogs:
 TripleState: bool
 """ Get/set whether the ``checkbox`` control may appear dimmed 
(grayed)."""
 URL: str
-""" Get/set the URL to open when clcking the ``hyperlink`` control. """
+""" Get/set the URL to open when clicking the ``hyperlink`` control. 
"""
 Value: Any
 """
 Get/set the content of the control:
-
+
 - ``Button``: bool - For toggle buttons only.
 - ``CheckBox``: bool, int - 0, ``False``: not checked, 1, ``True``: 
checked, 2: grayed, don't know.
 - ``ComboBox``: str - The selected value. The ``ListIndex`` property 
is an alternate option.
commit effb43e5ac8ebb478e6d277a66c844d14769415e
Author: Andrea Gelmini 
AuthorDate: Sat Mar 16 10:03:46 2024 +0100
Commit: Andrea Gelmini 
CommitDate: Sat Mar 16 12:59:58 2024 +0100

Fix typo

Change-Id: I26ad4b2cc6738087bb9cbae6eb5e852d7d520c05
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164898
Reviewed-by: Jean-Pierre Ledure 
Tested-by: Jenkins

diff --git a/wizards/source/scriptforge/python/scriptforge.pyi 
b/wizards/source/scriptforge/python/scriptforge.pyi
index dc2569279786..d37105b4a36e 100644
--- a/wizards/source/scriptforge/python/scriptforge.pyi
+++ b/wizards/source/scriptforge/python/scriptforge.pyi
@@ -1190,7 +1190,7 @@ class SFScriptForge:
 """
 Moves one or more files from one location to another.
 Returns ``True`` if at least one file has been moved or 
``False`` if an error occurred.
-An error will also occur if the source parameter uses wildcard 
characters anddoes not match any files.
+An error will also occur if the source parameter uses wildcard 
characters and does not match any files.
 
 The method stops immediately after it encounters an error. The 
method does not
 roll back nor does it undo changes made before the error 
occurred.


core.git: README.md

2024-03-16 Thread Stephan Bergmann (via logerrit)
 README.md |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0a4f0ae2cfba246cb6a2708b9db5dab8fc71e6a9
Author: Stephan Bergmann 
AuthorDate: Sat Mar 16 09:24:12 2024 +0100
Commit: Stephan Bergmann 
CommitDate: Sat Mar 16 11:53:25 2024 +0100

Building with Clang needs at least libstdc++ 10

Not sure how 02f48a32400f81413329d81203c417521882cab6 "Adjust for new linux
baseline" had decided to declare "Clang 12 with libstdc++ 8.5" sufficient 
for
building on Linux.  But I just experienced that building recent master on 
Ubuntu
20.04 with its libstdc++ 9.4.0, against a (lode-built) Clang 12.0.1, failed 
with

> codemaker/source/commonjava/commonjava.cxx:45:21: error: no matching 
literal operator for call to 'operator""_ostr' with arguments of types 'const 
char *' and 'unsigned long', and no matching literal operator template
> { "void"_ostr, "java/lang/Void"_ostr },
> ^

etc., apparently because the use of std::copy_n in constexpr 
O[U]StringLiteral
ctors is not yet constexpr there.  And


indeed lists "P0202R3" (i.e.,
 "Add
Constexpr Modifiers to Functions in  and  Headers") as 
only
available since "GCC libstdc++": "10".

Change-Id: I9d8ee2833f3b0c6c24059ec6e5d4dc8994058a1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/164895
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann 

diff --git a/README.md b/README.md
index f529e48d4714..441ce61e9686 100644
--- a/README.md
+++ b/README.md
@@ -42,7 +42,7 @@ run and compile LibreOffice, also used by the TDF builds:
 * Build: 12 (13 for aarch64) + Xcode 14
 * Linux:
 * Runtime: RHEL 8 or CentOS 8 and comparable
-* Build: either GCC 12; or Clang 12 with libstdc++ 8.5
+* Build: either GCC 12; or Clang 12 with libstdc++ 10
 * iOS (only for LibreOfficeKit):
 * Runtime: 11.4 (only support for newer i devices == 64 bit)
 * Build: Xcode 9.3 and iPhone SDK 11.4