date:20240507

https://bugs.documentfoundation.org/show_bug.cgi?id=160946

ady  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0036

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160978] [META] WiX based MSI installer packaging

https://bugs.documentfoundation.org/show_bug.cgi?id=160978

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||160980


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160980
[Bug 160980] Jenkins TB78 WiX builds of msi package are not signed
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160980] Jenkins TB78 WiX builds of msi package are not signed

https://bugs.documentfoundation.org/show_bug.cgi?id=160980

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||160978
 CC||cl...@documentfoundation.or
   ||g,
   ||stephane.guillou@libreoffic
   ||e.org,
   ||vsfo...@libreoffice.org,
   ||xiscofa...@libreoffice.org


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160978
[Bug 160978] [META] WiX based MSI installer packaging
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160980] New: Jenkins TB78 WiX builds of msi package are not signed

https://bugs.documentfoundation.org/show_bug.cgi?id=160980

Bug ID: 160980
   Summary: Jenkins TB78 WiX builds of msi package are not signed
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vsfo...@libreoffice.org

A little annoying if fully installing the WiX dev build MSI packaging, can they
be signed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156781] Display of comments is DPI dependent, both on screen and output

https://bugs.documentfoundation.org/show_bug.cgi?id=156781

--- Comment #13 from Hossein  ---
Also reproducible with the latest LO 24.8 dev master, without Skia/Vulkan:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9422879a5cf74120c1057b0f8150529e304f7c95
CPU threads: 20; OS: Windows 11 (10.0 build 22631); UI render: default; VCL:
win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

The output is different on 100%, 200%, and 300% scaling.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160979] WiX packaged MSI installer offering only LO "program" and "font" for custom install

https://bugs.documentfoundation.org/show_bug.cgi?id=160979

--- Comment #1 from V Stuart Foote  ---
Created attachment 194017
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194017=edit
Clip of options panel of an msiexec install of the TB78 20240507 WiX build

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160979] WiX packaged MSI installer offering only LO "program" and "font" for custom install

https://bugs.documentfoundation.org/show_bug.cgi?id=160979

V Stuart Foote  changed:

   What|Removed |Added

 CC||vsfo...@libreoffice.org
 Blocks||160978


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160978
[Bug 160978] [META] WiX based MSI installer packaging
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160978] [META] WiX based MSI installer packaging

https://bugs.documentfoundation.org/show_bug.cgi?id=160978

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||160979


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160979
[Bug 160979] WiX packaged MSI installer offering only LO "program" and "font"
for custom install
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160979] New: WiX packaged MSI installer offering only LO "program" and "font" for custom install

https://bugs.documentfoundation.org/show_bug.cgi?id=160979

Bug ID: 160979
   Summary: WiX packaged MSI installer offering only LO "program"
and "font" for custom install
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vsfo...@libreoffice.org

Current Jenkins TB78 Windows build with WiX packaging [1] does not provide
customization option selections available with Cygwin msitools based builds.

Typical msiexec.exe /a Administrative installs for testing not affected, but
doing actual /i installs are uncomfortable with the package as is. Expect also
we'll need to test the optional features with the WiX packaging get laid down
correctly.

=-ref-=

[1]
https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb78-pollux-TDF_wix/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156781] Display of comments is DPI dependent, both on screen and output

https://bugs.documentfoundation.org/show_bug.cgi?id=156781

--- Comment #12 from Hossein  ---
(In reply to m_a_riosv from comment #11)
> Created attachment 194015 [details]
> File with screenshots 100% 200% 300%
> 
> Attached draw file:n
> Version: 24.2.3.2 (X86_64) / LibreOffice Community
> Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
> CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: default; VCL: win
> Locale: es-ES (es_ES); UI: en-US
> Calc: CL threaded
> Screen resolution 2240x1400, text scale 175%
@m_a_riosv:
You need to restart LibreOffice each time. Have you done that? Otherwise, you
will get the same result.

I still reproduce the problem with the latest LO 24.8 dev master:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9422879a5cf74120c1057b0f8150529e304f7c95
CPU threads: 20; OS: Windows 11 (10.0 build 22631); UI render: Skia/Vulkan;
VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 143781] [META] Development- and code-related bug reports and tasks

https://bugs.documentfoundation.org/show_bug.cgi?id=143781

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||160978


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160978
[Bug 160978] [META] WiX based MSI installer packaging
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160978] [META] WiX based MSI installer packaging

https://bugs.documentfoundation.org/show_bug.cgi?id=160978

V Stuart Foote  changed:

   What|Removed |Added

 Blocks||143781
 CC||cl...@documentfoundation.or
   ||g, jpakk...@gmail.com,
   ||mikekagan...@hotmail.com,
   ||t...@libreoffice.org,
   ||vsfo...@libreoffice.org,
   ||xiscofa...@libreoffice.org
  Alias||WiX-msicreator


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=143781
[Bug 143781] [META] Development- and code-related bug reports and tasks
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160978] New: [META] WiX based MSI installer packaging

https://bugs.documentfoundation.org/show_bug.cgi?id=160978

Bug ID: 160978
   Summary: [META] WiX based MSI installer packaging
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Installation
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: vsfo...@libreoffice.org

With Jenkins TB78 reliably turning msicreator [1] python based WiX packaged
builds we should more broadly compare UI and experience with the WiX packaging
to our legacy perl based Cygwin msitools packaging.

=-ref-=
[1] https://github.com/jpakkane/msicreator

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-7-6-7' - dictionaries

 dictionaries |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7b1944c9141fb26d519076f680b0837d89099a64
Author: Xisco Fauli 
AuthorDate: Tue May 7 18:28:12 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Tue May 7 18:28:12 2024 +0200

Update git submodules

* Update dictionaries from branch 'libreoffice-7-6-7'
  to c2812ca5c0d0b6eddf451b98186691c7ab75ddb2
  - upgrade Ukrainian dictionaries to 6.4.4

Change-Id: Idf246940bdf58844212420975ab52c19b08327ec
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 
Reviewed-by: Andriy Rysin 
(cherry picked from commit 0ca7301c3c00d6e7936fd912ba775d0008f7fee4)
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166907
Tested-by: Christian Lohmaier 
Reviewed-by: Christian Lohmaier 
(cherry picked from commit 0c5d6db9f4d3e465547e3a177360662e0f475d62)
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166909
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/dictionaries b/dictionaries
index f747c9370dcb..c2812ca5c0d0 16
--- a/dictionaries
+++ b/dictionaries
@@ -1 +1 @@
-Subproject commit f747c9370dcb6991d216368f598504208ac151b0
+Subproject commit c2812ca5c0d0b6eddf451b98186691c7ab75ddb2

dictionaries.git: Branch 'libreoffice-7-6-7' - uk_UA/description.xml uk_UA/uk_UA.aff uk_UA/uk_UA.dic

 uk_UA/description.xml |2 
 uk_UA/uk_UA.aff   | 2459 
 uk_UA/uk_UA.dic   |142223 
+-
 3 files changed, 74844 insertions(+), 69840 deletions(-)

New commits:
commit c2812ca5c0d0b6eddf451b98186691c7ab75ddb2
Author: Xisco Fauli 
AuthorDate: Mon Apr 29 18:14:57 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Tue May 7 18:28:12 2024 +0200

upgrade Ukrainian dictionaries to 6.4.4

Change-Id: Idf246940bdf58844212420975ab52c19b08327ec
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166872
Tested-by: Xisco Fauli 
Reviewed-by: Xisco Fauli 
Reviewed-by: Andriy Rysin 
(cherry picked from commit 0ca7301c3c00d6e7936fd912ba775d0008f7fee4)
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166907
Tested-by: Christian Lohmaier 
Reviewed-by: Christian Lohmaier 
(cherry picked from commit 0c5d6db9f4d3e465547e3a177360662e0f475d62)
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/166909
Reviewed-by: Adolfo Jayme Barrientos 

diff --git a/uk_UA/description.xml b/uk_UA/description.xml
index 4941499..f221da9 100644
--- a/uk_UA/description.xml
+++ b/uk_UA/description.xml
@@ -1,6 +1,6 @@
 
 http://openoffice.org/extensions/description/2006; 
xmlns:d="http://openoffice.org/extensions/description/2006;  
xmlns:xlink="http://www.w3.org/1999/xlink;>
-
+
 
 
 Ukrainian spelling dictionary, hyphenation rules, 
and thesaurus
diff --git a/uk_UA/uk_UA.aff b/uk_UA/uk_UA.aff
index 3faea89..2343c2a 100644
--- a/uk_UA/uk_UA.aff
+++ b/uk_UA/uk_UA.aff
@@ -287,12 +287,12 @@ SFX ( ін ьонах лін
 SFX ( ір ьорах лір
 SFX ( іт ьотах літ
 SFX ) Y 6
+SFX ) сти дучи [аея]сти
 SFX ) атися учись жатися
 SFX ) атися учися жатися ###
-SFX ) стися дучись ястися
-SFX ) стися дучися ястися ###
 SFX ) ати учи жати
-SFX ) сти дучи ясти
+SFX ) стися дучись [аея]стися
+SFX ) стися дучися [аея]стися ###
 SFX * Y 3
 SFX * ік оці ік
 SFX * іг озі іг
@@ -326,126 +326,126 @@ SFX - ь ей ь
 SFX - ь ям ь
 SFX - ь ями ь
 SFX - ь ях ь
-SFX . Y 5
-SFX . е а ще
-SFX . е 0 ще
-SFX . е ам ще
-SFX . е ами ще
-SFX . е ах ще
-SFX 0 Y 113
-SFX 0 ій ою ій
-SFX 0 ій оєві ій
-SFX 0 ій оєм ій
-SFX 0 ій ої ій
-SFX 0 іб обі .іб
-SFX 0 ів ові .ів
-SFX 0 ід оді .ід
-SFX 0 іж ожі .іж
-SFX 0 із озі .із
-SFX 0 ім омі .ім
-SFX 0 ін оні .ін
-SFX 0 іп опі .іп
-SFX 0 ір орі .ір
-SFX 0 іс осі .іс
-SFX 0 іт оті .іт
-SFX 0 іш оші .іш
-SFX 0 ізд озді ізд
-SFX 0 ізт озті ізт
-SFX 0 ірд орді ірд
-SFX 0 ірт орті ірт
-SFX 0 ісд осді ісд
-SFX 0 іст ості іст
-SFX 0 ізд озду ізд
-SFX 0 ізк озку ізк
-SFX 0 ізт озту ізт
-SFX 0 ірд орду ірд
-SFX 0 ірк орку ірк
-SFX 0 ірт орту ірт
-SFX 0 ісд осду ісд
-SFX 0 іск оску іск
-SFX 0 іст осту іст
-SFX 0 ізд оздові ізд
-SFX 0 ізк озкові ізк
-SFX 0 ізт озтові ізт
-SFX 0 ірд ордові ірд
-SFX 0 ірк оркові ірк
-SFX 0 ірт ортові ірт
-SFX 0 ісд осдові ісд
-SFX 0 іск оскові іск
-SFX 0 іст остові іст
-SFX 0 ізд оздом ізд
-SFX 0 ізк озком ізк
-SFX 0 ізт озтом ізт
-SFX 0 ірд ордом ірд
-SFX 0 ірк орком ірк
-SFX 0 ірт ортом ірт
-SFX 0 ісд осдом ісд
-SFX 0 іск оском іск
-SFX 0 іст остом іст
-SFX 0 іб обові іб
-SFX 0 ід одові ід
-SFX 0 іг огові іг
-SFX 0 із озові із
-SFX 0 ік окові ік
-SFX 0 іл олові іл
-SFX 0 ім омові ім
-SFX 0 ін онові ін
-SFX 0 іп опові іп
-SFX 0 ір орові ір
-SFX 0 іс осові іс
-SFX 0 іт отові іт
-SFX 0 ік оці потік
-SFX 0 іж ожу іж
-SFX 0 іш ошу іш
-SFX 0 іж ожем іж
-SFX 0 іш ошем іш
-SFX 0 іж ожеві іж
-SFX 0 іш ошеві іш
-SFX 0 інь оню інь
-SFX 0 інь оневі інь
-SFX 0 інь онем інь
-SFX 0 інь оні інь
-SFX 0 іль олю іль
-SFX 0 іль олеві іль
-SFX 0 іль олем іль
-SFX 0 іль олі іль
-SFX 0 іб обу іб
-SFX 0 ів ову ів
-SFX 0 ід оду ід
-SFX 0 іг огу іг
-SFX 0 із озу із
-SFX 0 ік оку ік
-SFX 0 іл олу іл
-SFX 0 ім ому ім
-SFX 0 ін ону ін
-SFX 0 іп опу іп
-SFX 0 ір ору ір
-SFX 0 іс осу іс
-SFX 0 іт оту іт
-SFX 0 іч очу іч
-SFX 0 іб обом іб
-SFX 0 ів овом ів
-SFX 0 ід одом ід
-SFX 0 іг огом іг
-SFX 0 із озом із
-SFX 0 ік оком ік
-SFX 0 іл олом іл
-SFX 0 ім омом ім
-SFX 0 ін оном ін
-SFX 0 іп опом іп
-SFX 0 ір ором ір
-SFX 0 іс осом іс
-SFX 0 іт отом іт
-SFX 0 іч очом іч
-SFX 0 ік оці стік
-SFX 0 івш овшу івш
-SFX 0 івш овшеві івш
-SFX 0 івш овшем івш
-SFX 0 івш овші івш
-SFX 0 ість остю ість
-SFX 0 ість остеві ість
-SFX 0 ість остем ість
-SFX 0 ість ості ість
+SFX . Y 113
+SFX . ій ою ій
+SFX . ій оєві ій
+SFX . ій оєм ій
+SFX . ій ої ій
+SFX . іб обі .іб
+SFX . ів ові .ів
+SFX . ід оді .ід
+SFX . іж ожі .іж
+SFX . із озі .із
+SFX . ім омі .ім
+SFX . ін оні .ін
+SFX . іп опі .іп
+SFX . ір орі .ір
+SFX . іс осі .іс
+SFX . іт оті .іт
+SFX . іш оші .іш
+SFX . ізд озді ізд
+SFX . ізт озті ізт
+SFX . ірд орді ірд
+SFX . ірт орті ірт
+SFX . ісд осді ісд
+SFX . іст ості іст
+SFX . ізд озду ізд
+SFX . ізк озку ізк
+SFX . ізт озту ізт
+SFX . ірд орду ірд
+SFX . ірк орку ірк
+SFX . ірт орту ірт
+SFX . ісд осду ісд
+SFX . іск оску іск
+SFX . іст осту іст
+SFX . ізд оздові ізд
+SFX . ізк озкові ізк
+SFX .

core.git: Branch 'libreoffice-7-6-7' - sc/qa sc/source

2024-05-07 Thread Andreas Heinisch (via logerrit)

 sc/qa/uitest/pasteSpecial/tdf160765.py |   34 +
 sc/source/ui/miscdlgs/inscodlg.cxx |4 ++-
 2 files changed, 37 insertions(+), 1 deletion(-)

New commits:
commit d4cfeb2a69e40148ab080eae179e6278837fc754
Author: Andreas Heinisch 
AuthorDate: Fri Apr 26 20:29:53 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Tue May 7 18:27:42 2024 +0200

tdf#160765 - Paste Special Dialog: Remember comments checkbox

After the change of tdf#139858 the comments checkbox was not remembered 
anymore after closing the dialog. In order to fix this issue, additionally 
check not only the NOTE flag but also for the ADDNOTES one.

Change-Id: I8b24d231313b57a05b7e527c0865686762e5a2b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166762
Reviewed-by: Andreas Heinisch 
Tested-by: Jenkins
(cherry picked from commit 7e30434655754277bfa7ce7d8ec37b07181d2c92)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166838
Reviewed-by: Xisco Fauli 
(cherry picked from commit 30524d5998d38b7e216b721859c72fbfc56a5b5a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166890
Signed-off-by: Xisco Fauli 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167231
Reviewed-by: Christian Lohmaier 
Tested-by: Christian Lohmaier 

diff --git a/sc/qa/uitest/pasteSpecial/tdf160765.py 
b/sc/qa/uitest/pasteSpecial/tdf160765.py
index 0b56be4c2dfa..c0c264432ef4 100644
--- a/sc/qa/uitest/pasteSpecial/tdf160765.py
+++ b/sc/qa/uitest/pasteSpecial/tdf160765.py
@@ -13,8 +13,42 @@ from libreoffice.calc.document import get_cell_by_position
 from libreoffice.uno.propertyvalue import mkPropertyValues
 from uitest.uihelper.calc import enter_text_to_cell
 from libreoffice.calc.paste_special import reset_default_values
+from uitest.uihelper.common import get_state_as_dict
 
 class tdf160765(UITestCase):
+def test_tdf160765_paste_special_comments_checked(self):
+with self.ui_test.create_doc_in_start_center("calc"):
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+
+# Insert a comment in cell A1
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL":"A1"}))
+xArgs = mkPropertyValues({"Text": "Comment 1"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation", 
xArgs)
+
+# Copy cell A1 to clipboard
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": "A1"}))
+self.xUITest.executeCommand(".uno:Copy")
+
+# Paste data using special options (check only comments)
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": "A2"}))
+with 
self.ui_test.execute_dialog_through_command(".uno:PasteSpecial") as 
xPasteSpecialDlg:
+reset_default_values(self, xPasteSpecialDlg)
+xDateTimeChkBox = xPasteSpecialDlg.getChild("datetime")
+xDateTimeChkBox.executeAction("CLICK", tuple())
+xTextChkBox = xPasteSpecialDlg.getChild("text")
+xTextChkBox.executeAction("CLICK", tuple())
+xNumbersChkBox = xPasteSpecialDlg.getChild("numbers")
+xNumbersChkBox.executeAction("CLICK", tuple())
+xCommentsChkBox = xPasteSpecialDlg.getChild("comments")
+xCommentsChkBox.executeAction("CLICK", tuple())
+
+with 
self.ui_test.execute_dialog_through_command(".uno:PasteSpecial") as 
xPasteSpecialDlg:
+xCommentsChkBox = xPasteSpecialDlg.getChild("comments")
+# Without the fix in place, this test would have failed with
+# AssertionError: 'true' != 'false'
+# i.e., the comments checkbox was not remembered
+
self.assertEqual(get_state_as_dict(xCommentsChkBox)["Selected"], "true")
+
 def test_tdf160765_undo_paste_comment(self):
 with self.ui_test.create_doc_in_start_center("calc") as document:
 xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
diff --git a/sc/source/ui/miscdlgs/inscodlg.cxx 
b/sc/source/ui/miscdlgs/inscodlg.cxx
index 84292dcd91c4..378b10f37fd0 100644
--- a/sc/source/ui/miscdlgs/inscodlg.cxx
+++ b/sc/source/ui/miscdlgs/inscodlg.cxx
@@ -231,7 +231,9 @@ void ScInsertContentsDlg::SetInsContentsCmdBits(const 
InsertDeleteFlags eFlags)
 mxBtnInsNumbers->set_active((InsertDeleteFlags::VALUE & eFlags) == 
InsertDeleteFlags::VALUE);
 mxBtnInsDateTime->set_active((InsertDeleteFlags::DATETIME & eFlags) == 
InsertDeleteFlags::DATETIME);
 mxBtnInsStrings->set_active((InsertDeleteFlags::STRING & eFlags) == 
InsertDeleteFlags::STRING);
-mxBtnInsNotes->set_active((InsertDeleteFlags::NOTE & eFlags) == 
InsertDeleteFlags::NOTE);
+// tdf#160765 - additionally check either NOTE or ADDNOTES
+mxBtnInsNotes->set_active(((InsertDeleteFlags::NOTE | 
InsertDeleteFlags::ADDNOTES) & eFlags)
+

core.git: Branch 'libreoffice-7-6-7' - sc/qa sc/source

2024-05-07 Thread Andreas Heinisch (via logerrit)

 sc/qa/uitest/pasteSpecial/tdf160765.py |   75 +
 sc/source/ui/view/viewfun3.cxx |3 -
 2 files changed, 77 insertions(+), 1 deletion(-)

New commits:
commit e600195ae980f297b414ef69161de7b629f59346
Author: Andreas Heinisch 
AuthorDate: Mon Apr 22 20:06:50 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Tue May 7 18:27:06 2024 +0200

tdf#160765 - Save content for undo when pasting notes

even if no content was changed after pasting special. Otherwise, the undo 
functionality crashes due to undoing a cell with no content where the 
annotation indicator will remain (unod/redo of note captions are handled via 
drawing undo).

Change-Id: I7007fce510d6e9896cbda11a1e14a61b5ccb34a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166469
Tested-by: Jenkins
Reviewed-by: Stéphane Guillou 
Reviewed-by: Andreas Heinisch 
(cherry picked from commit a1694b194c2b3e89250c5b79a69e7dd184b69976)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166524
Reviewed-by: Xisco Fauli 
(cherry picked from commit 4d744d94cc4ee114a7e5d5373b2b599baed31ee5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166846
Tested-by: Christian Lohmaier 
Reviewed-by: Christian Lohmaier 

diff --git a/sc/qa/uitest/pasteSpecial/tdf160765.py 
b/sc/qa/uitest/pasteSpecial/tdf160765.py
new file mode 100644
index ..0b56be4c2dfa
--- /dev/null
+++ b/sc/qa/uitest/pasteSpecial/tdf160765.py
@@ -0,0 +1,75 @@
+# -*- tab-width: 4; indent-tabs-mode: nil; py-indent-offset: 4 -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+from uitest.framework import UITestCase
+
+from libreoffice.calc.document import get_cell_by_position
+from libreoffice.uno.propertyvalue import mkPropertyValues
+from uitest.uihelper.calc import enter_text_to_cell
+from libreoffice.calc.paste_special import reset_default_values
+
+class tdf160765(UITestCase):
+def test_tdf160765_undo_paste_comment(self):
+with self.ui_test.create_doc_in_start_center("calc") as document:
+xGridWin = self.xUITest.getTopFocusWindow().getChild("grid_window")
+
+# Write text to cell A1 and B1
+enter_text_to_cell(xGridWin, "A1", "A1 sample text")
+enter_text_to_cell(xGridWin, "B1", "B1 sample text")
+
+# Insert a comment in cell B1
+xArgs = mkPropertyValues({"Text": "Comment 1"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation", 
xArgs)
+
+# Insert a comment in cell A2
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL":"A2"}))
+xArgs = mkPropertyValues({"Text": "Comment 2"})
+self.xUITest.executeCommandWithParameters(".uno:InsertAnnotation", 
xArgs)
+
+# Copy cell A2 to clipboard
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": "A2"}))
+self.xUITest.executeCommand(".uno:Copy")
+
+# Set cursor to cells and paste data using special options (check 
only comments)
+targetCells = ["A1", "B1"]
+for index, targetCell in enumerate(targetCells):
+xGridWin.executeAction("SELECT", mkPropertyValues({"CELL": 
targetCell}))
+with 
self.ui_test.execute_dialog_through_command(".uno:PasteSpecial") as 
xPasteSpecialDlg:
+reset_default_values(self, xPasteSpecialDlg)
+xDateTimeChkBox = xPasteSpecialDlg.getChild("datetime")
+xDateTimeChkBox.executeAction("CLICK", tuple())
+xTextChkBox = xPasteSpecialDlg.getChild("text")
+xTextChkBox.executeAction("CLICK", tuple())
+xNumbersChkBox = xPasteSpecialDlg.getChild("numbers")
+xNumbersChkBox.executeAction("CLICK", tuple())
+xCommentsChkBox = xPasteSpecialDlg.getChild("comments")
+xCommentsChkBox.executeAction("CLICK", tuple())
+
+# Undo both inserted comments
+self.xUITest.executeCommand(".uno:Undo")
+# Without the fix in place, this test would have failed with
+# AssertionError: 'Comment 1' != ''
+# i.e., the cell does not contain any comment
+self.assertEqual("Comment 1", get_cell_by_position(document, 0, 1, 
0).Annotation.String)
+self.xUITest.executeCommand(".uno:Undo")
+self.assertEqual("", get_cell_by_position(document, 0, 0, 
0).Annotation.String)
+
+# Redo both inserted comments
+self.xUITest.executeCommand(".uno:Redo")
+# Without the fix in place, this test would have failed with
+# AssertionError: 'Comment 2' != ''
+# i.e.,

[Bug 160945] LibreOffice crashes at startup

https://bugs.documentfoundation.org/show_bug.cgi?id=160945

Stephan Bergmann  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEEDINFO

--- Comment #7 from Stephan Bergmann  ---
(In reply to ff-mickael_jackson from comment #5)
> https://crashreport.libreoffice.org/stats/crash_details/48497b5d-8982-4459-
> 989e-337734989814

...has

> 0 msca_uno.dllvtableCall  
> bridges/source/cpp_uno/msvc_win32_arm64/cpp2uno.cxx:290
> 1 msca_uno.dllvtableCall  
> bridges/source/cpp_uno/msvc_win32_arm64/cpp2uno.cxx:255
> 2 msca_uno.dllvtableSlotCall  
> E:/r/workdir/AsmObject/bridges/source/cpp_uno/msvc_win32_arm64/vtableslotcall.asm:4106
>  

which suggests an issue in bridges/soruce/cpp_uno/msvc_win32_arm64/ that may
well have been fixed recently (towards LO 24.8) with

"Some fixing of msvc_win32_arm64 UNO bridge" et al.

@ff-mickael_jackson, can you check whether a recent Windows ARM64 nightly build
(see "Win-Arm64@tb77-TDF" at
) fixes the
issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-24-2' - officecfg/registry

2024-05-07 Thread Samuel Mehrbrodt (via logerrit)

 officecfg/registry/data/org/openoffice/Office/Paths.xcu |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 81bc6152fecfb9220ec1a36b8a7edc8634467e19
Author: Samuel Mehrbrodt 
AuthorDate: Thu May 2 10:23:22 2024 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 7 18:17:02 2024 +0200

tdf#160153 Restore Storage config item

Revert "[API CHANGE] Remove deprecated Storage config item"

This reverts commit 3cee7edeb31ac64e078159c7a63ebf4f54793da7.

As documented in the bug report, the config item is still used.
Thus, remove the deprecation notice, too.

Change-Id: Ia9beefe8e98bce8d70c546d27999d81c5cc9fd62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166904
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Jenkins
(cherry picked from commit 80fcd2290dfc9748bb7f4e322b22b773b61daa67)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167219
Reviewed-by: Xisco Fauli 

diff --git a/officecfg/registry/data/org/openoffice/Office/Paths.xcu 
b/officecfg/registry/data/org/openoffice/Office/Paths.xcu
index a0aae4547ba8..b5b304b8f362 100644
--- a/officecfg/registry/data/org/openoffice/Office/Paths.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Paths.xcu
@@ -153,6 +153,11 @@
 
   
 
+
+  
+$(userpath)/store
+  
+
 
   
 true

core.git: 2 commits - emfio/qa emfio/source extensions/qa extensions/source

 emfio/qa/cppunit/emf/EmfImportTest.cxx   | 1052 +--
 emfio/qa/cppunit/wmf/wmfimporttest.cxx   |  290 +--
 emfio/source/emfuno/xemfparser.cxx   |6 
 emfio/source/reader/emfreader.cxx|2 
 emfio/source/reader/mtftools.cxx |2 
 extensions/qa/bibliography/bibliography.cxx  |2 
 extensions/qa/update/test_update.cxx |   10 
 extensions/source/abpilot/abpfinalpage.cxx   |   22 
 extensions/source/abpilot/admininvokationpage.cxx|6 
 extensions/source/abpilot/datasourcehandling.cxx |8 
 extensions/source/abpilot/fieldmappingimpl.cxx   |   12 
 extensions/source/abpilot/fieldmappingpage.cxx   |6 
 extensions/source/abpilot/tableselectionpage.cxx |4 
 extensions/source/abpilot/typeselectionpage.cxx  |   22 
 extensions/source/abpilot/unodialogabp.cxx   |   10 
 extensions/source/bibliography/bibbeam.cxx   |4 
 extensions/source/bibliography/bibconfig.cxx |   22 
 extensions/source/bibliography/bibload.cxx   |   22 
 extensions/source/bibliography/bibview.cxx   |4 
 extensions/source/bibliography/datman.cxx|  158 -
 extensions/source/bibliography/framectr.cxx  |   18 
 extensions/source/bibliography/general.cxx   |  166 -
 extensions/source/bibliography/toolbar.cxx   |   46 
 extensions/source/config/ldap/ldapaccess.cxx |4 
 extensions/source/config/ldap/ldapuserprofilebe.cxx  |   26 
 extensions/source/dbpilots/commonpagesdbp.cxx|   34 
 extensions/source/dbpilots/controlwizard.cxx |   38 
 extensions/source/dbpilots/gridwizard.cxx|   20 
 extensions/source/dbpilots/groupboxwiz.cxx   |   32 
 extensions/source/dbpilots/listcombowizard.cxx   |   28 
 extensions/source/dbpilots/optiongrouplayouter.cxx   |   18 
 extensions/source/dbpilots/wizardservices.cxx|   12 
 extensions/source/logging/consolehandler.cxx |6 
 extensions/source/logging/csvformatter.cxx   |8 
 extensions/source/logging/filehandler.cxx|6 
 extensions/source/logging/logger.cxx |6 
 extensions/source/logging/loggerconfig.cxx   |6 
 extensions/source/logging/loghandler.cxx |   10 
 extensions/source/logging/plaintextformatter.cxx |8 
 extensions/source/logging/simpletextformatter.cxx|4 
 extensions/source/propctrlr/MasterDetailLinkDialog.cxx   |4 
 extensions/source/propctrlr/browserline.cxx  |   16 
 extensions/source/propctrlr/browserlistbox.cxx   |4 
 extensions/source/propctrlr/browserpage.cxx  |4 
 extensions/source/propctrlr/buttonnavigationhandler.cxx  |4 
 extensions/source/propctrlr/cellbindinghandler.cxx   |4 
 extensions/source/propctrlr/controlfontdialog.cxx|6 
 extensions/source/propctrlr/defaultforminspection.cxx|4 
 extensions/source/propctrlr/defaulthelpprovider.cxx  |4 
 extensions/source/propctrlr/editpropertyhandler.cxx  |6 
 extensions/source/propctrlr/eformspropertyhandler.cxx|   14 
 extensions/source/propctrlr/eventhandler.cxx |   16 
 extensions/source/propctrlr/fontdialog.cxx   |8 
 extensions/source/propctrlr/formcomponenthandler.cxx |   44 
 extensions/source/propctrlr/formcontroller.cxx   |8 
 extensions/source/propctrlr/formgeometryhandler.cxx  |8 
 extensions/source/propctrlr/formlinkdialog.cxx   |   32 
 extensions/source/propctrlr/formmetadata.cxx |4 
 extensions/source/propctrlr/genericpropertyhandler.cxx   |   10 
 extensions/source/propctrlr/handlerhelper.cxx|   10 
 extensions/source/propctrlr/inspectorhelpwindow.cxx  |4 
 extensions/source/propctrlr/inspectormodelbase.cxx   |8 
 extensions/source/propctrlr/listselectiondlg.cxx |6 
 extensions/source/propctrlr/newdatatype.cxx  |6 
 extensions/source/propctrlr/objectinspectormodel.cxx |6 
 extensions/source/propctrlr/pcrunodialogs.cxx|   10 
 extensions/source/propctrlr/propcontroller.cxx   |   52 
 extensions/source/propctrlr/propertyeditor.cxx   |6 
 extensions/source/propctrlr/propertyhandler.hxx  |2 
 extensions/source/propctrlr/selectlabeldialog.cxx|8 
 extensions/source/propctrlr/sqlcommanddesign.cxx |   12

core.git: Branch 'libreoffice-7-6-7' - sc/source

2024-05-07 Thread Patrick Luby (via logerrit)

 sc/source/ui/app/transobj.cxx |   31 +--
 1 file changed, 29 insertions(+), 2 deletions(-)

New commits:
commit bae8980495d54d235b71938bc313be22d7455585
Author: Patrick Luby 
AuthorDate: Sat May 4 19:58:03 2024 -0400
Commit: Christian Lohmaier 
CommitDate: Tue May 7 18:14:44 2024 +0200

tdf#160855 fix crash due to Skia's internal maximum pixel limit

Somewhere in the tens of thousands of selected fill cells,
the size of the VirtualDevice exceeds 1 GB of pixels. But
Skia, at least on macOS, will fail to create a surface.
Even if there is ample free memory, Skia/Raster will fail.

The second problem is that even if you disable Skia, the
crash is just delayed when a BitmapEx is created from the
VirtualDevice and malloc() fails.

Since this data flavor really triggers one or more system
memory limits, lower the resolution of the bitmap by keeping
the VirtualDevice pixel size within an arbitrary number of
pixels.

Note: the artibrary "maximum number of pixels" limit that
that Skia can handle may need to be raised or lowered for
platforms other than macOS.

Change-Id: Ie087f2db152470aa70521fbe5fe6c7cedd8504af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167145
Reviewed-by: Noel Grandin 
Tested-by: Jenkins
Reviewed-by: Patrick Luby 
(cherry picked from commit 8d9f54165d28d83092667b7bfcd0ee48ade54c87)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167217
Tested-by: Christian Lohmaier 
Reviewed-by: Christian Lohmaier 

diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index 5f0599c888b3..e5ed3b1afe2a 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -405,11 +405,38 @@ bool ScTransferObj::GetData( const 
datatransfer::DataFlavor& rFlavor, const OUSt
  aReducedBlock.aEnd.Col(), 
aReducedBlock.aEnd.Row(),
  aReducedBlock.aStart.Tab() );
 ScopedVclPtrInstance< VirtualDevice > pVirtDev;
-
pVirtDev->SetOutputSizePixel(pVirtDev->LogicToPixel(aMMRect.GetSize(), 
MapMode(MapUnit::Map100thMM)));
+
+// tdf#160855 fix crash due to Skia's internal maximum pixel limit
+// Somewhere in the tens of thousands of selected fill cells,
+// the size of the VirtualDevice exceeds 1 GB of pixels. But
+// Skia, at least on macOS, will fail to create a surface.
+// Even if there is ample free memory, Skia/Raster will fail.
+// The second problem is that even if you disable Skia, the
+// crash is just delayed when a BitmapEx is created from the
+// VirtualDevice and malloc() fails.
+// Since this data flavor really triggers one or more system
+// memory limits, lower the resolution of the bitmap by keeping
+// the VirtualDevice pixel size within an arbitrary number of
+// pixels.
+// Note: the artibrary "maximum number of pixels" limit that
+// that Skia can handle may need to be raised or lowered for
+// platforms other than macOS.
+static constexpr tools::Long nCopyToImageMaxPixels = 8192 * 8192;
+Fraction aScale(1.0);
+Size aPixelSize = pVirtDev->LogicToPixel(aMMRect.GetSize(), 
MapMode(MapUnit::Map100thMM));
+tools::Long nPixels(aPixelSize.Width() * aPixelSize.Height());
+if (nPixels < 0 || nPixels > nCopyToImageMaxPixels)
+{
+aScale = Fraction(nCopyToImageMaxPixels, nPixels);
+aPixelSize = pVirtDev->LogicToPixel(aMMRect.GetSize(), 
MapMode(MapUnit::Map100thMM, Point(), aScale, aScale));
+nPixels = aPixelSize.Width() * aPixelSize.Height();
+}
+
+pVirtDev->SetOutputSizePixel(aPixelSize);
 
 PaintToDev( pVirtDev, *m_pDoc, 1.0, aReducedBlock );
 
-pVirtDev->SetMapMode( MapMode( MapUnit::MapPixel ) );
+pVirtDev->SetMapMode( MapMode( MapUnit::MapPixel, Point(), aScale, 
aScale ) );
 BitmapEx aBmp = pVirtDev->GetBitmapEx( Point(), 
pVirtDev->GetOutputSize() );
 bOK = SetBitmapEx( aBmp, rFlavor );
 }

[Bug 101522] [META] Media playback bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=101522

--- Comment #27 from kuchtosikho  ---
ok nice... https://kuchtosikho.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 123972] UI menu disappears before submenu can open (GTK3 and Wayland)

https://bugs.documentfoundation.org/show_bug.cgi?id=123972

Xisco Faulí  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|NEW |UNCONFIRMED

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'libreoffice-7-6-7' - sw/source

2024-05-07 Thread Michael Stahl (via logerrit)

 sw/source/filter/html/htmlctxt.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 598cc6c5f03bf0aae525e80ae6960de2c78efeae
Author: Michael Stahl 
AuthorDate: Thu Apr 25 18:20:20 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Tue May 7 18:11:51 2024 +0200

tdf#154581 tdf#157411 tdf#158549 sw: HTML import: fix SfxItemIter reuse

This is obviously wrong, as ALG just pointed out: the aIter is at the
end after the 1st loop, so the 2nd loop does nothing.
Thx Gabor for checking all the reported bugs.

(regression from commit db115bec9254417ef7a3faf687478fe5424ab378)

Change-Id: Iae37b9ab5c630d0ee774f42c84d5e76349b92a90
Tested-by: Gabor Kelemen 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166643
Reviewed-by: Michael Stahl 
Tested-by: Jenkins
(cherry picked from commit ac05822b8957d80018d3ce1cbf97cd9faa0dfe99)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166715
Tested-by: Christian Lohmaier 
Reviewed-by: Xisco Fauli 
Reviewed-by: Ilmari Lauhakangas 
Reviewed-by: Christian Lohmaier 

diff --git a/sw/source/filter/html/htmlctxt.cxx 
b/sw/source/filter/html/htmlctxt.cxx
index 80245ba2ea6a..0e87b83644f8 100644
--- a/sw/source/filter/html/htmlctxt.cxx
+++ b/sw/source/filter/html/htmlctxt.cxx
@@ -656,7 +656,8 @@ void SwHTMLParser::InsertAttrs( SfxItemSet ,
 }
 #endif
 
-for (const SfxPoolItem* pItem = aIter.GetCurItem(); pItem; pItem = 
aIter.NextItem())
+SfxItemIter aIter2(rItemSet);
+for (const SfxPoolItem* pItem = aIter2.GetCurItem(); pItem; pItem = 
aIter2.NextItem())
 {
 HTMLAttr **ppAttr = nullptr;

core.git: download.lst

 download.lst |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 0c7c6ba98fba651c8ae4015dbbf450c23611667a
Author: Xisco Fauli 
AuthorDate: Tue May 7 16:16:33 2024 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 7 18:11:11 2024 +0200

libatomic_ops: Upgrade to 7.8.2

Change-Id: I7fcf8011cbb1fb5e5ba2f0a9737190bffa13114d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167287
Reviewed-by: Xisco Fauli 
Tested-by: Jenkins

diff --git a/download.lst b/download.lst
index e0f142b4d63d..a7874c271ab2 100644
--- a/download.lst
+++ b/download.lst
@@ -374,8 +374,8 @@ LIBASSUAN_TARBALL := libassuan-2.5.7.tar.bz2
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-LIBATOMIC_OPS_SHA256SUM := 
15676e7674e11bda5a7e50a73f4d9e7d60452271b8acf6fd39a71fefdf89fa31
-LIBATOMIC_OPS_TARBALL := libatomic_ops-7.8.0.tar.gz
+LIBATOMIC_OPS_SHA256SUM := 
d305207fe207f2b3fb5cb4c019da12b44ce3fcbc593dfd5080d867b1a2419b51
+LIBATOMIC_OPS_TARBALL := libatomic_ops-7.8.2.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts

[Bug 123972] UI menu disappears before submenu can open (GTK3 and Wayland)

https://bugs.documentfoundation.org/show_bug.cgi?id=123972

kuchtosikho  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #30 from kuchtosikho  ---
excellent post https://kuchtosikho.com/

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sw/source

2024-05-07 Thread Jim Raykowski (via logerrit)

 sw/source/uibase/utlui/content.cxx |   24 +++-
 1 file changed, 19 insertions(+), 5 deletions(-)

New commits:
commit 9ccdb4c63445ad9ca7bdba869e1bb967b7f622c8
Author: Jim Raykowski 
AuthorDate: Sun May 5 22:13:54 2024 -0800
Commit: Jim Raykowski 
CommitDate: Tue May 7 18:07:26 2024 +0200

tdf#160598 follow up to make delete key work

Adds delete key handling for delete all footnotes/endnotes from the
Navigator.

Change-Id: Ic1d49377631344ac5e6fdc81c07eebde0470a6be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167180
Reviewed-by: Jim Raykowski 
Tested-by: Jenkins

diff --git a/sw/source/uibase/utlui/content.cxx 
b/sw/source/uibase/utlui/content.cxx
index 3e5a2faa8043..5642ff20a790 100644
--- a/sw/source/uibase/utlui/content.cxx
+++ b/sw/source/uibase/utlui/content.cxx
@@ -4769,13 +4769,27 @@ IMPL_LINK(SwContentTree, KeyInputHdl, const KeyEvent&, 
rEvent, bool)
 else if(aCode.GetCode() == KEY_DELETE && 0 == aCode.GetModifier())
 {
 std::unique_ptr xEntry(m_xTreeView->make_iterator());
-if (m_xTreeView->get_selected(xEntry.get()) && lcl_IsContent(*xEntry, 
*m_xTreeView))
+if (!m_pActiveShell->GetView().GetDocShell()->IsReadOnly()
+&& m_xTreeView->get_selected(xEntry.get()))
 {
-
assert(dynamic_cast(weld::fromId(m_xTreeView->get_id(*xEntry;
-if 
(weld::fromId(m_xTreeView->get_id(*xEntry))->GetParent()->IsDeletable()
 &&
-!m_pActiveShell->GetView().GetDocShell()->IsReadOnly())
+if (lcl_IsContent(*xEntry, *m_xTreeView))
+{
+
assert(dynamic_cast(weld::fromId(m_xTreeView->get_id(*xEntry;
+if 
(weld::fromId(m_xTreeView->get_id(*xEntry))->GetParent()->IsDeletable())
+{
+EditEntry(*xEntry, EditEntryMode::DELETE);
+}
+}
+else
 {
-EditEntry(*xEntry, EditEntryMode::DELETE);
+SwContentType* pContentType
+= 
weld::fromId(m_xTreeView->get_id(*xEntry));
+if (pContentType->GetMemberCount()
+&& (pContentType->GetType() == ContentTypeId::FOOTNOTE
+|| pContentType->GetType() == 
ContentTypeId::ENDNOTE))
+{
+ExecuteContextMenuAction("deleteallfootnotes");
+}
 }
 }
 }

[Bug 160754] Footnote indent is broken in this example

https://bugs.documentfoundation.org/show_bug.cgi?id=160754

--- Comment #6 from Mike Kaganski  ---
Indeed, it is expected and normal; the file has the compatibility flag that
tells it to behave as DOCX works: NoGapAfterNoteNumber. Since the file was
created by re-saving a DOCX, this is normal.

The problem is that I didn't make the flag shown in
Options->Writer->Compatibility (like bug 153138).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157453] ListBox in Table Control does not follow the property "line count"

https://bugs.documentfoundation.org/show_bug.cgi?id=157453

--- Comment #8 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, it always displays 3
articles, whatever the value I put in General > Line count

The property seems to be FM_PROP_LINECOUNT and when git grepping this I got:
svx/source/fmcomp/gridcell.cxx:2464:doPropertyListening( FM_PROP_LINECOUNT
);
svx/source/fmcomp/gridcell.cxx:2498:// we no longer pay attention to
FM_PROP_LINECOUNT
svx/source/fmcomp/gridcell.cxx:2577:doPropertyListening( FM_PROP_LINECOUNT
);
svx/source/fmcomp/gridcell.cxx:2634:// ignore FM_PROP_LINECOUNT
svx/source/form/formcontrolfactory.cxx:397:   
_rxControlModel->setPropertyValue( FM_PROP_LINECOUNT, Any( sal_Int16( 20 ) ) );
svx/source/inc/fmprop.hxx:91:inline constexpr OUString FM_PROP_LINECOUNT =
u"LineCount"_ustr;

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58038] FORMATTING: Format text toolbar commands are not working in chart titles nor text boxes drawn inside charts with the draw bar

https://bugs.documentfoundation.org/show_bug.cgi?id=58038

Buovjaga  changed:

   What|Removed |Added

 CC||ilmari.lauhakangas@libreoff
   ||ice.org

--- Comment #12 from Buovjaga  ---
How do you add a text box inside a Chart? I mean, does "inside" mean something
special? Just drawing one on top of a chart, it works fine to format text via
the toolbar.

Arch Linux 64-bit
Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 8; OS: Linux 6.8; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
24.2.2-2
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'feature/allo_contract45533' - framework/source

2024-05-07 Thread Tibor Nagy (via logerrit)

 framework/source/services/desktop.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit cddfc67bfaa5f580d952ccc3005f7cae11a9c933
Author: Tibor Nagy 
AuthorDate: Mon May 6 10:43:34 2024 +0200
Commit: Nagy Tibor 
CommitDate: Tue May 7 17:16:14 2024 +0200

The previous behavior of using the TerminationVetoException has changed

"Since LibreOffice 5.3: Throwing this exception will only prevent 
termination. Exiting LibreOffice will close all the windows but the process 
will keep running."

Currently, the behavior is different, because not only is LibreOffice
prevented from terminating, but the last document cannot be closed either. 
The expected behavior is all windows should be closed, but the
process should be kept running when using a TerminationVetoException.

Change-Id: I8764aefccc4c9feec3ee0e45a54bf0aebcf16c5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167194
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Jenkins
(cherry picked from commit 64a50c65ee15c03f58ccf25308a70dfd24e791fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167224
Reviewed-by: Nagy Tibor 
Tested-by: Nagy Tibor 

diff --git a/framework/source/services/desktop.cxx 
b/framework/source/services/desktop.cxx
index 35dfcd2e21eb..e0388f75b985 100644
--- a/framework/source/services/desktop.cxx
+++ b/framework/source/services/desktop.cxx
@@ -201,6 +201,8 @@ sal_Bool SAL_CALL Desktop::terminate()
 aGuard.clear();
 
 // Allow using of any UI ... because Desktop.terminate() was designed as 
UI functionality in the past.
+// try to close all open frames
+bool bFramesClosed = impl_closeFrames(!bRestartableMainLoop);
 
 // Ask normal terminate listener. They could veto terminating the process.
 Desktop::TTerminateListenerList lCalledTerminationListener;
@@ -210,8 +212,7 @@ sal_Bool SAL_CALL Desktop::terminate()
 return false;
 }
 
-// try to close all open frames
-if (!impl_closeFrames(!bRestartableMainLoop))
+if (!bFramesClosed)
 {
 impl_sendCancelTerminationEvent(lCalledTerminationListener);
 return false;

core.git: Branch 'distro/cib/libreoffice-6-4' - sfx2/source

2024-05-07 Thread Balazs Varga (via logerrit)

 sfx2/source/dialog/backingwindow.cxx |   10 +-
 1 file changed, 9 insertions(+), 1 deletion(-)

New commits:
commit 1e3d7374a2e70c56d082954d9ecad718b01c27fb
Author: Balazs Varga 
AuthorDate: Tue May 7 10:03:53 2024 +0200
Commit: Balazs Varga 
CommitDate: Tue May 7 17:08:49 2024 +0200

tdf#160961: hide open remote file button from startcenter if the

.uno:OpenRemote command is not available (e.g disabled in a config file).
We also hide the Open remote file (and other) buttons in the Menubar
if they are settled to disable.

cherry-picked from commit: 2fdcdad742bc26be509dde53f061f96a9620fd0a

Change-Id: I413e2c381ad5651c2cbef728bc5568fdcd746e9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167263
Tested-by: allotropia jenkins 
Reviewed-by: Balazs Varga 

diff --git a/sfx2/source/dialog/backingwindow.cxx 
b/sfx2/source/dialog/backingwindow.cxx
index e4059d50c275..41998fbfa8bd 100644
--- a/sfx2/source/dialog/backingwindow.cxx
+++ b/sfx2/source/dialog/backingwindow.cxx
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -239,7 +240,14 @@ void BackingWindow::initControls()
 mpLocalView->ShowTooltips( true );
 
 setupButton( mpOpenButton );
-setupButton( mpRemoteButton );
+
+// Hide OpenRemote button on startpage if the OpenRemote uno command is 
not available
+SvtCommandOptions aCmdOptions;
+if (aCmdOptions.Lookup(SvtCommandOptions::CMDOPTION_DISABLED, 
"OpenRemote"))
+mpRemoteButton->Hide();
+else
+setupButton( mpRemoteButton );
+
 setupButton( mpRecentButton );
 setupButton( mpTemplateButton );
 setupButton( mpWriterAllButton );

core.git: configure.ac odk/CustomTarget_doxygen.mk

2024-05-07 Thread Christian Lohmaier (via logerrit)

 configure.ac|   18 --
 odk/CustomTarget_doxygen.mk |8 
 2 files changed, 20 insertions(+), 6 deletions(-)

New commits:
commit 83d3f9b819ee23efa314953fc2fde4412d90a60b
Author: Christian Lohmaier 
AuthorDate: Tue May 7 14:19:50 2024 +0200
Commit: Christian Lohmaier 
CommitDate: Tue May 7 17:08:44 2024 +0200

use windows doxygen in wsl-as-helper case

basically reverts f7fe6a0bed2c2aee19535a26181a2edfb103e587

avoiding the penalty for accessing files in the windows-realm from
within the wsl-container significantly accelerates the doc-generation

Change-Id: I95af905bda7225a9c1924a41e952656dffbfbc0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167279
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/configure.ac b/configure.ac
index e04f4a846642..5954533a7f1b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9488,8 +9488,9 @@ else
 fi
 else
 AC_MSG_CHECKING([for doxygen])
-DOXYGEN=$with_doxygen
-AC_MSG_RESULT([$DOXYGEN])
+PathFormat "$with_doxygen"
+DOXYGEN="$formatted_path_unix"
+AC_MSG_RESULT([$formatted_path])
 fi
 if test -n "$DOXYGEN"; then
 DOXYGEN_VERSION=`$DOXYGEN --version 2>/dev/null`
@@ -9498,6 +9499,19 @@ else
 AC_MSG_ERROR([found doxygen is too old; need at least version 
1.8.4 or specify --without-doxygen])
 fi
 fi
+if test -n "$WSL_ONLY_AS_HELPER"; then
+dnl what really should be tested is whether it is doxygen from 
windows-realm
+dnl i.e. one that runs on the windows-side and deals with 
windows-pathnames
+dnl using doxygen from wsl container would be possible, but 
there's a performance
+dnl penalty when accessing the files outside the container
+AC_MSG_CHECKING([whether doxygen is a windows executable])
+if $(file "$DOXYGEN" | grep -q "PE32"); then
+AC_MSG_RESULT([yes])
+else
+AC_MSG_RESULT([no])
+AC_MSG_ERROR([please provide a path to a windows version of 
doxygen or use --without-doxygen])
+fi
+fi
 fi
 fi
 AC_SUBST([DOXYGEN])
diff --git a/odk/CustomTarget_doxygen.mk b/odk/CustomTarget_doxygen.mk
index 42132387457b..03b43c0c7180 100644
--- a/odk/CustomTarget_doxygen.mk
+++ b/odk/CustomTarget_doxygen.mk
@@ -22,8 +22,8 @@ odk_cpp_INCFILELIST := com/sun/star/uno/Any.h \
com/sun/star/uno/Type.h \
com/sun/star/uno/Type.hxx
 
-# Cygwin Doxygen needs unix paths, wsl-as-helper needs paths into windows-realm
-odk_cygwin_path = $(if $(MSYSTEM),$(call gb_Helper_wsl_path,$(1)),$(call 
gb_Helper_cyg_path,$(1)))
+# Cygwin Doxygen needs unix paths, wsl-as-helper works in windows-realm
+odk_cygwin_path = $(if $(MSYSTEM),$(1),$(call gb_Helper_cyg_path,$(1)))
 odk_cpp_PREFIX := $(call odk_cygwin_path,$(INSTDIR)/$(SDKDIRNAME)/include/)
 odk_cpp_DOXY_INPUT := $(call odk_cygwin_path,$(SRCDIR)/odk/docs/cpp/main.dox \
$(SRCDIR)/include/sal/log-areas.dox \
@@ -57,7 +57,7 @@ $(gb_CustomTarget_workdir)/odk/docs/cpp/doxygen.log : \
$(call gb_Package_get_target,odk_headers_generated)
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),GEN,1)
$(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),GEN)
-   rm -rf $(odk_cpp_DOXY_WORKDIR)/ && $(call gb_Helper_wsl_path,$(WSL) 
$(DOXYGEN) $<) > $@
+   rm -rf $(odk_cpp_DOXY_WORKDIR)/ && $(DOXYGEN) $< > $@
$(call gb_Trace_EndRange,$(subst $(WORKDIR)/,,$@),GEN)
 
 $(eval $(call gb_CustomTarget_register_targets,odk/docs,\
@@ -98,7 +98,7 @@ $(gb_CustomTarget_workdir)/odk/docs/idl/doxygen.log : \
$(SRCDIR)/odk/docs/idl/main.dox
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),GEN,1)
$(call gb_Trace_StartRange,$(subst $(WORKDIR)/,,$@),GEN)
-   rm -rf $(odk_idl_DOXY_WORKDIR)/ && $(call gb_Helper_wsl_path,$(WSL) 
$(DOXYGEN) $<) > $@
+   rm -rf $(odk_idl_DOXY_WORKDIR)/ && $(DOXYGEN) $< > $@
$(call gb_Trace_EndRange,$(subst $(WORKDIR)/,,$@),GEN)
 
 # vim: set noet sw=4 ts=4:

core.git: sd/qa sd/source

2024-05-07 Thread Méven Car (via logerrit)

 sd/qa/unit/tiledrendering/data/test.ppsx |binary
 sd/qa/unit/tiledrendering/tiledrendering.cxx |   15 +++
 sd/source/ui/view/ViewShellBase.cxx  |   13 +
 3 files changed, 28 insertions(+)

New commits:
commit fbd8cfb046fd0882402e01c2e0b2955e6972737f
Author: Méven Car 
AuthorDate: Tue Feb 20 12:51:39 2024 +0100
Commit: Miklos Vajna 
CommitDate: Tue May 7 17:00:55 2024 +0200

Impress: transmit document's property StartWithPresentation

This is transmitted as stateChanged event.

This property is set for ppsx/pps files.

Change-Id: Ic2f495cb9923b385bce7d93a2d8121d2945221ab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163652
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
(cherry picked from commit b951c57d4b723621d211b552f2cd238ae0dc246a)

Change-Id: I7eedc855255a30abdfdf61c8315b4f8238c07ca9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165094
Tested-by: Jenkins CollaboraOffice 
Reviewed-by: Miklos Vajna 
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167277
Tested-by: Jenkins

diff --git a/sd/qa/unit/tiledrendering/data/test.ppsx 
b/sd/qa/unit/tiledrendering/data/test.ppsx
new file mode 100644
index ..2b955adeca97
Binary files /dev/null and b/sd/qa/unit/tiledrendering/data/test.ppsx differ
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx 
b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index b15821f1329b..7f8c4fa19338 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -2983,6 +2983,21 @@ CPPUNIT_TEST_FIXTURE(SdTiledRenderingTest, 
testSidebarHide)
 CPPUNIT_ASSERT(it != aView.m_aStateChanges.end());
 }
 
+CPPUNIT_TEST_FIXTURE(SdTiledRenderingTest, testStartPresentation)
+{
+SdXImpressDocument* pXImpressDocument = createDoc("test.ppsx");
+ViewCallback aView;
+CPPUNIT_ASSERT(pXImpressDocument->GetDoc()->IsStartWithPresentation());
+Scheduler::ProcessEventsToIdle();
+
+const auto it = aView.m_aStateChanges.find(".uno:StartWithPresentation");
+CPPUNIT_ASSERT(it != aView.m_aStateChanges.end());
+
+const auto value = it->second;
+CPPUNIT_ASSERT(value.get_child_optional("state").has_value());
+CPPUNIT_ASSERT_EQUAL(std::string("true"), 
value.get_child("state").get_value());
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/view/ViewShellBase.cxx 
b/sd/source/ui/view/ViewShellBase.cxx
index 8a25f0593b87..a86a448900f4 100644
--- a/sd/source/ui/view/ViewShellBase.cxx
+++ b/sd/source/ui/view/ViewShellBase.cxx
@@ -19,6 +19,8 @@
 
 #include 
 
+#include 
+
 #include 
 #include 
 #include 
@@ -1031,6 +1033,17 @@ void ViewShellBase::afterCallbackRegistered()
 std::set aDocumentColors = pDocShell->GetDocColors();
 svx::theme::notifyLOK(pThemeColors, aDocumentColors);
 }
+
+if (mpDocument && mpDocument->IsStartWithPresentation())
+{
+// Be consistent with SidebarController, emit JSON.
+boost::property_tree::ptree aTree;
+aTree.put("commandName", ".uno:StartWithPresentation");
+aTree.put("state", "true");
+std::stringstream aStream;
+boost::property_tree::write_json(aStream, aTree);
+libreOfficeKitViewCallback(LOK_CALLBACK_STATE_CHANGED, 
OString(aStream.str()));
+}
 }
 
 void ViewShellBase::NotifyCursor(SfxViewShell* pOtherShell) const

[Bug 160977] New: make zoom selection quicker

https://bugs.documentfoundation.org/show_bug.cgi?id=160977

Bug ID: 160977
   Summary: make zoom selection quicker
   Product: LibreOffice
   Version: 24.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: j22...@gmail.com

Description:
When clicking the zoom level (on the lower right of the window), one can select
the zoom level (Optimal, Fit width, 100% etc.).

Steps to Reproduce:
You want to select a zoom level of "Fit width", as quick as possible.

1. Click on the lower right corner of the window, where the zoom level is shown
(eg 100%)
2. The zoom level dialog is shown.
3. You select "Fit width"

Actual Results:
4. you need to press OK to apply the change

Expected Results:
it would be great if it would also be possible like this:
4. you apply the change both by pressing OK or by double clicking into "Fit
width"


Reproducible: Always


User Profile Reset: No

Additional Info:
The double click is much faster because it saves one step. If I remember
correctly, MS Word works like that (at least it did many years ago).


PS. By the way, both in the zoom level indicator (lower right of the window)
and on the Zoom level selection dialog, I suggest using the percentage symbol
separated from the number with one space. I mean to use '100 %' instead of
'100%'. 

In English there is not really a 'rule' (it is OK both with and without the
space). But in many other languages, the space is the correct form. Therefore,
why not use a space and accommodate more users?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'distro/collabora/co-24.04' - sc/inc sc/source

 sc/inc/attarray.hxx  |4 +++-
 sc/inc/column.hxx|3 ++-
 sc/inc/table.hxx |6 --
 sc/source/core/data/attarray.cxx |   25 +++--
 sc/source/core/data/column.cxx   |5 +++--
 sc/source/core/data/document.cxx |3 ++-
 sc/source/core/data/table2.cxx   |   10 ++
 7 files changed, 39 insertions(+), 17 deletions(-)

New commits:
commit 6716251560b940a5c5113695c86e6be0e2974845
Author: Noel Grandin 
AuthorDate: Mon May 6 10:56:12 2024 +0200
Commit: Caolán McNamara 
CommitDate: Tue May 7 16:26:37 2024 +0200

speed up copy/paste large spreadsheet ranges

The problem is that we are spending a lot of time inside
SfxItemPool::tryToGetEqualItem
So cache the result of that call in a map.

Note that this is not needed on master, where the ScPatternAttr
de-duplication is quite different and a lot more efficient.

Change-Id: I32ca1d140a62ea576d621322696e098b884a783c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167193
Reviewed-by: Caolán McNamara 
Tested-by: Jenkins CollaboraOffice 
Tested-by: Caolán McNamara 

diff --git a/sc/inc/attarray.hxx b/sc/inc/attarray.hxx
index a7e1c08a9f49..59279f95fbc3 100644
--- a/sc/inc/attarray.hxx
+++ b/sc/inc/attarray.hxx
@@ -217,7 +217,9 @@ public:
 voidDeleteArea( SCROW nStartRow, SCROW nEndRow );
 voidMoveTo( SCROW nStartRow, SCROW nEndRow, ScAttrArray& rAttrArray );
 voidCopyArea(
-SCROW nStartRow, SCROW nEndRow, tools::Long nDy, ScAttrArray& 
rAttrArray, ScMF nStripFlags = ScMF::NONE) const;
+SCROW nStartRow, SCROW nEndRow, tools::Long nDy, ScAttrArray& 
rAttrArray,
+std::unordered_map* 
pPatternPutCache = nullptr,
+ScMF nStripFlags = ScMF::NONE) const;
 
 voidDeleteHardAttr( SCROW nStartRow, SCROW nEndRow );
 
diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 70b2924aa10b..31ab3574815a 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -344,7 +344,8 @@ public:
 void DeleteRanges( const std::vector& rRanges, 
InsertDeleteFlags nDelFlag );
 
 void CopyToClip(
-sc::CopyToClipContext& rCxt, SCROW nRow1, SCROW nRow2, ScColumn& 
rColumn ) const;
+sc::CopyToClipContext& rCxt, SCROW nRow1, SCROW nRow2, ScColumn& 
rColumn,
+std::unordered_map* 
pPatternPutCache = nullptr ) const;
 
 void CopyStaticToDocument(
 SCROW nRow1, SCROW nRow2, const SvNumberFormatterMergeMap& rMap, 
ScColumn& rDestCol );
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index d69a07bdf92e..a50e3c75491b 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -539,8 +539,10 @@ public:
 SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, InsertDeleteFlags 
nDelFlag,
 bool bBroadcast = true, sc::ColumnSpanSet* pBroadcastSpans = nullptr );
 
-void CopyToClip( sc::CopyToClipContext& rCxt, SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow2, ScTable* pTable );
-void CopyToClip( sc::CopyToClipContext& rCxt, const ScRangeList& rRanges, 
ScTable* pTable );
+void CopyToClip( sc::CopyToClipContext& rCxt, SCCOL nCol1, SCROW nRow1, 
SCCOL nCol2, SCROW nRow2, ScTable* pTable,
+ std::unordered_map* pPatternPutCache = nullptr );
+void CopyToClip( sc::CopyToClipContext& rCxt, const ScRangeList& rRanges, 
ScTable* pTable,
+ std::unordered_map* pPatternPutCache = nullptr );
 
 void CopyStaticToDocument(
 SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2, const 
SvNumberFormatterMergeMap& rMap,
diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index 4c31fb86e3cc..6d4b2811cd84 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -2433,7 +2433,9 @@ void ScAttrArray::MoveTo(SCROW nStartRow, SCROW nEndRow, 
ScAttrArray& rAttrArray
  * Copy between documents (Clipboard)
  */
 void ScAttrArray::CopyArea(
-SCROW nStartRow, SCROW nEndRow, tools::Long nDy, ScAttrArray& rAttrArray, 
ScMF nStripFlags) const
+SCROW nStartRow, SCROW nEndRow, tools::Long nDy, ScAttrArray& rAttrArray,
+std::unordered_map* 
pPatternPutCache,
+ScMF nStripFlags) const
 {
 nStartRow -= nDy;   // Source
 nEndRow -= nDy;
@@ -2457,7 +2459,7 @@ void ScAttrArray::CopyArea(
 if (mvData[i].nEndRow >= nStartRow)
 {
 const ScPatternAttr* pOldPattern = mvData[i].pPattern;
-const ScPatternAttr* pNewPattern;
+const ScPatternAttr* pNewPattern = nullptr;
 
 if (IsDefaultItem( pOldPattern ))
 {
@@ -2484,10 +2486,21 @@ void ScAttrArray::CopyArea(
 }
 else
 {
-if (bSamePool)
-pNewPattern = 
>DirectPutItemInPool(*pOldPattern);
-else
-pNewPattern = pOldPattern->PutInPool( 
,  );
+if (pPatternPutCache)
+{
+

[Bug 160963] Installing extension from file results in Restart loop

https://bugs.documentfoundation.org/show_bug.cgi?id=160963

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
Thank you for the report. This is resolved in the upcoming 24.8 version.

*** This bug has been marked as a duplicate of bug 117100 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160767] Mac Mouse and Trackpad Freezes Repeatedly, only in LibreOffice Writer, Mac Sonoma

https://bugs.documentfoundation.org/show_bug.cgi?id=160767

Patrick Luby (volunteer)  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |guibomac...@gmail.com
   |desktop.org |
 CC||guibomac...@gmail.com
 Status|NEEDINFO|ASSIGNED

--- Comment #2 from Patrick Luby (volunteer)  ---
(In reply to Geo from comment #0)
> When working in a LibreOffice writer document (on MI Mac, with Sonoma, the
> ability to use the trackpad or mouse within the document itself freezes. The
> keys, up down, etc., continue to work. The freeze stops after a few saves of
> the document.

I think I might know what is causing this bug: if I have automatic
spellchecking enabled, spellchecking does not pause when you swipe the trackpad
but pressing any key does. I am guessing that the freezing stops when
LibreOffice has finished its initial spellchecking of the document.

If I remove the following fix for tdf#155266 that I made back in December 2023,
swiping works while automatic spellchecking is enabled:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9f92a39234dfae40fe19ab6fa47caf8b21dd8847

So, I will see if I can rework the fix for tdf#155266 to fix the "swipes are
ignored during spellchecking" behavior.

In the meantime, a temporary workaround that I found is to switch to using the
Page-Up (fn-arrowup) or Page-Down (fn-arrowdown) to interrupt the automatic
spellchecking.

I'll post again when I have a fix that you can test.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 137931] Show the UI selection dialog on first start-up

https://bugs.documentfoundation.org/show_bug.cgi?id=137931

--- Comment #61 from Pedro  ---
https://fosstodon.org/@libodesign/112285659953746809

According to the results of the poll placed on fosstodon.org, which had 520
respondents, 20% of respondents didn't know that there were alternative UIs
present in LibreOffice.
If even in the users of a federated network, with an over-representation of
technology savvy people, 20% of people don't know about the alternative UIs
that LibO offers then for the more general population that number will probably
be even higher. This to me demonstrates the need to implement the UI selection
dialog on first start-up as Free Office and Softmaker Office do. The current
Tip of the day is clearly not working.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: vcl/uiconfig

2024-05-07 Thread Michael Weghorn (via logerrit)

 vcl/uiconfig/ui/combobox.ui |5 +
 1 file changed, 5 insertions(+)

New commits:
commit 9f078ed7b625e86182d64d5ccfbb410cdd38081c
Author: Michael Weghorn 
AuthorDate: Tue May 7 10:04:16 2024 +0200
Commit: Michael Weghorn 
CommitDate: Tue May 7 16:17:26 2024 +0200

tdf#160971 gtk3 a11y: Set role for custom editable combobox

Set the combobox a11y role for the box in the .ui file
used for the custom gtk3 combobox implementation.

With this in place, moving focus to the "Font Name" or
another editable combobox in the Writer toolbar now
makes Orca announce that one as "editable combobox"
rather than just "text".

See also

commit 1e851093f0148d2c55fc3fd377d274f6703c71c9
Author: Michael Weghorn 
Date:   Thu Apr 18 14:02:25 2024 +0200

tdf#159910 gtk3 a11y: Keep a11y props for combobox

for a very similar change that caused the proper
role to be announced for non-editable comboboxes.

Change-Id: I3062e5c062911040ef0ec5721d15fee78d85d0dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167262
Tested-by: Jenkins
Reviewed-by: Michael Weghorn 

diff --git a/vcl/uiconfig/ui/combobox.ui b/vcl/uiconfig/ui/combobox.ui
index 6abaa6a25171..a9c697f10bc7 100644
--- a/vcl/uiconfig/ui/combobox.ui
+++ b/vcl/uiconfig/ui/combobox.ui
@@ -67,6 +67,11 @@
 2
   
 
+
+  
+combo-box
+  
+

core.git: 2 commits - vcl/inc vcl/Library_vclplug_gtk3_kde5.mk vcl/Library_vclplug_gtk3.mk vcl/unx

2024-05-07 Thread Michael Weghorn (via logerrit)

 vcl/Library_vclplug_gtk3.mk|1 
 vcl/Library_vclplug_gtk3_kde5.mk   |1 
 vcl/inc/unx/gtk/atkbridge.hxx  |   25 -
 vcl/unx/gtk3/a11y/atkbridge.cxx|   32 ---
 vcl/unx/gtk3/a11y/atkutil.cxx  |   67 -
 vcl/unx/gtk3/a11y/atkutil.hxx  |   26 -
 vcl/unx/gtk3/gtkinst.cxx   |8 --
 vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkbridge.cxx |   12 
 8 files changed, 172 deletions(-)

New commits:
commit 26e7ddb2c87642099f1320279c96a9176ef18dfe
Author: Michael Weghorn 
AuthorDate: Tue May 7 08:38:29 2024 +0200
Commit: Michael Weghorn 
CommitDate: Tue May 7 16:16:55 2024 +0200

gtk3 a11y: Drop WindowEventHandler completely

As mentioned in

commit c45c64aeb57dce91965d7be54601128946455c90
Author: Michael Weghorn 
Date:   Mon May 6 14:44:36 2024 +0200

tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds

, the a11y bridge should not have to handle VCL events itself,
but all relevant events should be forwarded to the a11y
event listener as appropriate `AccessibleEventObject` and be handled
by the a11y event listener instead, see `AtkListener::notifyEvent`
for the gtk3 implementation.

Now that handling of all VCL events has been dropped in
previous commits, drop the `WindowEventHandler` completely.
This also means that the call to `InitAtkBridge` when initializing
the `GtkInstance` and the `DeInitAtkBridge` on destruction
is no longer necessary.

In a quick test with the Orca screen reader and the gtk3
VCL plugin, nothing suspicious showed up, things were
still working as expected and experienced prior to the
change series dropping the VCL event handling from the
gtk3 a11y bridge.

Change-Id: Ieed270b636f361c57cd4e78aceaecc7d174409d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167256
Reviewed-by: Michael Weghorn 
Tested-by: Jenkins

diff --git a/vcl/Library_vclplug_gtk3.mk b/vcl/Library_vclplug_gtk3.mk
index 0809edd770a7..ff631f17b450 100644
--- a/vcl/Library_vclplug_gtk3.mk
+++ b/vcl/Library_vclplug_gtk3.mk
@@ -82,7 +82,6 @@ $(eval $(call gb_Library_use_externals,vclplug_gtk3,\
 
 $(eval $(call gb_Library_add_exception_objects,vclplug_gtk3,\
 vcl/unx/gtk3/a11y/atkaction \
-vcl/unx/gtk3/a11y/atkbridge \
 vcl/unx/gtk3/a11y/atkcomponent \
 vcl/unx/gtk3/a11y/atkeditabletext \
 vcl/unx/gtk3/a11y/atkfactory \
diff --git a/vcl/Library_vclplug_gtk3_kde5.mk b/vcl/Library_vclplug_gtk3_kde5.mk
index 853ec7aafa4e..c58619af8c5d 100644
--- a/vcl/Library_vclplug_gtk3_kde5.mk
+++ b/vcl/Library_vclplug_gtk3_kde5.mk
@@ -88,7 +88,6 @@ $(eval $(call gb_Library_use_externals,vclplug_gtk3_kde5,\
 
 $(eval $(call gb_Library_add_exception_objects,vclplug_gtk3_kde5,\
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkaction \
-   vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkbridge \
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkcomponent \
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkeditabletext \
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkfactory \
diff --git a/vcl/inc/unx/gtk/atkbridge.hxx b/vcl/inc/unx/gtk/atkbridge.hxx
deleted file mode 100644
index e77a9ab571e3..
--- a/vcl/inc/unx/gtk/atkbridge.hxx
+++ /dev/null
@@ -1,25 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#pragma once
-
-bool InitAtkBridge();
-void DeInitAtkBridge();
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/unx/gtk3/a11y/atkbridge.cxx b/vcl/unx/gtk3/a11y/atkbridge.cxx
deleted file mode 100644
index c7cb32ca3ce2..
--- a/vcl/unx/gtk3/a11y/atkbridge.cxx
+++ /dev/null
@@ -1,32 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at

core.git: 2 commits - vcl/unx

2024-05-07 Thread Michael Weghorn (via logerrit)

 vcl/unx/gtk3/a11y/atkutil.cxx |   92 --
 1 file changed, 92 deletions(-)

New commits:
commit fedd4886b0b63ea3254ea4ce4b7f9b5b73af95f0
Author: Michael Weghorn 
AuthorDate: Tue May 7 08:19:35 2024 +0200
Commit: Michael Weghorn 
CommitDate: Tue May 7 16:16:41 2024 +0200

gtk3 a11y: Drop VclEventId::MenuHighlight processing

Drop the manual processing of `VclEventId::MenuHighlight`
in the gtk3 a11y bridge.

As mentioned in

commit c45c64aeb57dce91965d7be54601128946455c90
Author: Michael Weghorn 
Date:   Mon May 6 14:44:36 2024 +0200

tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds

, the a11y bridge should not have to handle VCL events itself,
but all relevant events should be forwarded to the a11y
event listener as appropriate `AccessibleEventObject` and be handled
by the a11y event listener instead, see `AtkListener::notifyEvent`
for the gtk3 implementation.

In a quick test, menu items were still announced
just fine by the Orca screen reader when using the
gtk3 VCL plugin with this commit in place.

By now, most menus should be native GTK widgets anyway.
For non-native menus,
`OAccessibleMenuBaseComponent::ProcessMenuEvent` contains
handling for the `VclEventId::MenuHighlight` event that
should be taking care of forwarding that as the corresponding
a11y event to the a11y bridges. If anything is missing after
this commit, that's probably a good starting point for further
analysis.

Change-Id: Ia8686101dc559ed98b48285eac15c35fc10818af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167254
Reviewed-by: Michael Weghorn 
Tested-by: Jenkins

diff --git a/vcl/unx/gtk3/a11y/atkutil.cxx b/vcl/unx/gtk3/a11y/atkutil.cxx
index 6cc52a56ba6c..d10bc3b27967 100644
--- a/vcl/unx/gtk3/a11y/atkutil.cxx
+++ b/vcl/unx/gtk3/a11y/atkutil.cxx
@@ -306,47 +306,12 @@ rtl::Reference 
GtkSalData::GetDocumentFocusListener()
 return xDFL;
 }
 
-static void handle_menu_highlighted(::VclMenuEvent const * pEvent)
-{
-try
-{
-Menu* pMenu = pEvent->GetMenu();
-sal_uInt16 nPos = pEvent->GetItemPos();
-
-if( pMenu &&  nPos != 0x)
-{
-uno::Reference< accessibility::XAccessible > xAccessible ( 
pMenu->GetAccessible() );
-
-if( xAccessible.is() )
-{
-uno::Reference< accessibility::XAccessibleContext > xContext ( 
xAccessible->getAccessibleContext() );
-
-if( xContext.is() )
-
atk_wrapper_notify_focus_change(xContext->getAccessibleChild(nPos));
-}
-}
-}
-catch (const uno::Exception&)
-{
-g_warning( "Exception caught processing menu highlight events" );
-}
-}
-
-/*/
-
 static void WindowEventHandler(void *, VclSimpleEvent& rEvent)
 {
 try
 {
 switch (rEvent.GetId())
 {
-case VclEventId::MenuHighlight:
-if (const VclMenuEvent* pMenuEvent = dynamic_cast())
-{
-handle_menu_highlighted(pMenuEvent);
-}
-break;
-
 case VclEventId::TabpageActivate:
 handle_tabpage_activated(static_cast< ::VclWindowEvent const * 
>()->GetWindow());
 break;
commit f44b1cf1fc2925d54512f1f04361ac2c2fc7d276
Author: Michael Weghorn 
AuthorDate: Tue May 7 08:08:49 2024 +0200
Commit: Michael Weghorn 
CommitDate: Tue May 7 16:16:33 2024 +0200

gtk3 a11y: Drop VclEventId::ToolboxHighlight{,Off} processing

Drop the manual processing of `VclEventId::ToolboxHighlight`
in the gtk3 a11y bridge.

As mentioned in

commit c45c64aeb57dce91965d7be54601128946455c90
Author: Michael Weghorn 
Date:   Mon May 6 14:44:36 2024 +0200

tdf#160806 tdf#160837 gtk3 a11y: Drop handling of some VclEventIds

, the a11y bridge should not have to handle VCL events itself,
but all relevant events should be forwarded to the a11y
event listener as appropriate `AccessibleEventObject` and be handled
by the a11y event listener instead, see `AtkListener::notifyEvent`
for the gtk3 implementation.

In a quick test, toolbar items were still announced
just fine by the Orca screen reader when using the
gtk3 VCL plugin with this commit in place.

`VCLXAccessibleToolBox::ProcessWindowEvent` handles
`VclEventId::ToolboxHighlight` and
`VclEventId::ToolboxHighlightOff` whose manual processing
is now dropped from gtk3, so the former might be a good place
to further look into if anything is still missing after
this commit.

The now dropped handling was originally added in

commit e9816343cd71dfe556e6ace12d67c642a8dde635
Author: Jens-Heiner

core.git: external/skia RepositoryExternal.mk solenv/gbuild vcl/Library_vclplug_gen.mk vcl/Library_vclplug_osx.mk vcl/Library_vclplug_win.mk

 RepositoryExternal.mk   |   15 --
 external/skia/Module_skia.mk|2 
 external/skia/StaticLibrary_skia.mk |   85 +---
 solenv/gbuild/PrecompiledHeaders.mk |1 
 vcl/Library_vclplug_gen.mk  |4 +
 vcl/Library_vclplug_osx.mk  |5 ++
 vcl/Library_vclplug_win.mk  |8 ++-
 7 files changed, 69 insertions(+), 51 deletions(-)

New commits:
commit 6517ce70e50e61441484e7ee7a4be0e265020175
Author: Noel Grandin 
AuthorDate: Mon Apr 29 20:39:48 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue May 7 15:54:49 2024 +0200

make skia into static library

(1) we only use it from inside vcl
(2) it exports a boatload of symbols
(3) its a performance hotspot

so lets link it inside and give the optimiser as
much room as possible.
Change-Id: If19d5556e3b45f40ef09d1e9225d12ef5f1ec32a

Change-Id: I3d5edca20f5a15e8981f17fe9fcb9a338006eaff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167273
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index c72b814b8a07..2ae5f3753464 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -135,15 +135,20 @@ $(call gb_LinkTarget_set_include,$(1),\
-I$(SRCDIR)/external/skia/inc/ \
$$(INCLUDE) \
 )
-$(call gb_LinkTarget_use_libraries,$(1),skia)
+$(call gb_LinkTarget_use_static_libraries,$(1),skia)
 $(call gb_LinkTarget_add_defs,$(1),\
-DSK_USER_CONFIG_HEADER="<$(BUILDDIR)/config_host/config_skia.h>" \
-   -DSKIA_DLL \
 )
+
 endef
-$(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo,\
-skia \
-))
+
+define gb_ExternalProject__use_skia
+$(call gb_ExternalProject_use_static_libraries,$(1),\
+  skia \
+)
+
+endef
+
 endif
 
 ifeq (SANE,$(filter SANE,$(BUILD_TYPE)))
diff --git a/external/skia/Module_skia.mk b/external/skia/Module_skia.mk
index 4cb8b51570df..44cc06542c48 100644
--- a/external/skia/Module_skia.mk
+++ b/external/skia/Module_skia.mk
@@ -11,7 +11,7 @@ $(eval $(call gb_Module_Module,skia))
 
 $(eval $(call gb_Module_add_targets,skia,\
UnpackedTarball_skia \
-   Library_skia \
+   StaticLibrary_skia \
 ))
 
 
diff --git a/external/skia/Library_skia.mk b/external/skia/StaticLibrary_skia.mk
similarity index 95%
rename from external/skia/Library_skia.mk
rename to external/skia/StaticLibrary_skia.mk
index 9d240e40da0c..a52144fe1be2 100644
--- a/external/skia/Library_skia.mk
+++ b/external/skia/StaticLibrary_skia.mk
@@ -7,19 +7,18 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_Library_Library,skia))
+$(eval $(call gb_StaticLibrary_StaticLibrary,skia))
 
-$(eval $(call gb_Library_set_warnings_disabled,skia))
+$(eval $(call gb_StaticLibrary_set_warnings_disabled,skia))
 
-$(eval $(call gb_Library_use_unpacked,skia,skia))
+$(eval $(call gb_StaticLibrary_use_unpacked,skia,skia))
 
-$(eval $(call gb_Library_use_clang,skia))
+$(eval $(call gb_StaticLibrary_use_clang,skia))
 #This currently results in all sorts of compile complaints
-#$(eval $(call 
gb_Library_set_clang_precompiled_header,skia,external/skia/inc/pch/precompiled_skia))
+#$(eval $(call 
gb_StaticLibrary_set_clang_precompiled_header,skia,external/skia/inc/pch/precompiled_skia))
 
-$(eval $(call gb_Library_add_defs,skia,\
+$(eval $(call gb_StaticLibrary_add_defs,skia,\
 -DSKIA_IMPLEMENTATION=1 \
--DSKIA_DLL \
 -DSK_USER_CONFIG_HEADER="<$(BUILDDIR)/config_host/config_skia.h>" \
 $(if $(filter INTEL,$(CPUNAME)),$(if $(filter 
WNT,$(OS)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE1,-DSK_CPU_SSE_LEVEL=0)) \
 $(if $(filter X86_64,$(CPUNAME)),-DSK_CPU_SSE_LEVEL=SK_CPU_SSE_LEVEL_SSE2) 
\
@@ -33,7 +32,7 @@ $(eval $(call gb_Library_add_defs,skia,\
 # Some code may be always built with optimizations, even with Skia debug 
enabled (see
 # $(gb_COMPILEROPTFLAGS) usage).
 ifeq ($(ENABLE_SKIA_DEBUG),)
-$(eval $(call gb_Library_add_cxxflags,skia, \
+$(eval $(call gb_StaticLibrary_add_cxxflags,skia, \
 $(gb_COMPILEROPTFLAGS) \
 $(PCH_NO_CODEGEN) \
 ))
@@ -42,11 +41,11 @@ endif
 ifeq ($(OS),WNT)
 # Skia can be built with or without UNICODE set, in LO sources we explicitly 
use the *W unicode
 # variants, so build Skia with UNICODE to make it also use the *W variants.
-$(eval $(call gb_Library_add_defs,skia,\
+$(eval $(call gb_StaticLibrary_add_defs,skia,\
 -DUNICODE -D_UNICODE \
 ))
 ifneq ($(gb_ENABLE_PCH),)
-$(eval $(call gb_Library_add_cxxflags,skia, \
+$(eval $(call gb_StaticLibrary_add_cxxflags,skia, \
 -FIsrc/utils/win/SkDWriteNTDDI_VERSION.h \
 ))
 endif
@@ -54,13 +53,13 @@ endif
 # The clang-cl provided with at least VS 2019 16.11.28 is known-broken with 
-std:c++20:
 ifneq ($(filter -std:c++20,$(CXXFLAGS_CXX11)),)
 ifeq ($(LO_CLANG_VERSION),12)
-$(eval $(call gb_Library_add_cxxflags,skia, \
+$(eval $(call gb_StaticLibrary_add_cxxflags,skia, \
 -std:c++17 \
 ))
 endif

[Bug 160547] Database Connection: JDBC-Connection with DuckDB fails

https://bugs.documentfoundation.org/show_bug.cgi?id=160547

--- Comment #4 from Julien Nabet  ---
"getTypeInfo" not supported in JDBC driver, see:
https://github.com/duckdb/duckdb-java/blob/main/src/main/java/org/duckdb/DuckDBDatabaseMetaData.java

Now I don't know if having this method implemented in JDBC is mandatory for LO
or if we could find a way to make it optional.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sc/source

2024-05-07 Thread Heiko Tietze (via logerrit)

 sc/source/ui/view/hdrcont.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit f1d69a84ac82034d7f98877780c549f06d93792d
Author: Heiko Tietze 
AuthorDate: Fri May 3 11:16:40 2024 +0200
Commit: Heiko Tietze 
CommitDate: Tue May 7 15:49:22 2024 +0200

Resolves tdf#160324 - Larger hit area for col/row resize actions

Tentative solution made optional depending on experimental settings

Change-Id: I6d527d2b0d0de3b48f123b626ebf0b6ce60299a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167041
Tested-by: Jenkins
Reviewed-by: Heiko Tietze 

diff --git a/sc/source/ui/view/hdrcont.cxx b/sc/source/ui/view/hdrcont.cxx
index 98ebabb702c3..bf97dbb01f95 100644
--- a/sc/source/ui/view/hdrcont.cxx
+++ b/sc/source/ui/view/hdrcont.cxx
@@ -35,6 +35,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define SC_DRAG_MIN 2
 
@@ -627,6 +628,9 @@ void ScHeaderControl::Paint( vcl::RenderContext& 
/*rRenderContext*/, const tools
 
 SCCOLROW ScHeaderControl::GetMousePos(const Point& rPos, bool& rBorder) const
 {
+// #define nHitArea 5
+const int nHitArea( 
officecfg::Office::Common::Misc::ExperimentalMode::get() ? 5 : 2 );
+
 boolbFound = false;
 SCCOLROWnPos = GetPos();
 SCCOLROWnHitNo = nPos;
@@ -650,7 +654,7 @@ SCCOLROW ScHeaderControl::GetMousePos(const Point& rPos, 
bool& rBorder) const
 nScrPos += GetEntrySize( nEntryNo - 1 ) * nLayoutSign;  //! 
GetHiddenCount() ??
 
 nDif = nMousePos - nScrPos;
-if (nDif >= -2 && nDif <= 2)
+if (nDif >= -nHitArea && nDif <= +nHitArea)
 {
 bFound = true;
 nHitNo=nEntryNo-1;

[Bug 132157] [META] BigPtrArray::Index2Block undo crashes

https://bugs.documentfoundation.org/show_bug.cgi?id=132157

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||160943


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160943
[Bug 160943] Crash in: BigPtrArray::Index2Block(int) const
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160943] Crash in: BigPtrArray::Index2Block(int) const

https://bugs.documentfoundation.org/show_bug.cgi?id=160943

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Status|UNCONFIRMED |NEEDINFO
 Blocks||132157
 Ever confirmed|0   |1

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
Thank you for the report.
Version 7.4 is not maintained anymore, please install a current version, 24.2
preferably, and let us know (with more precise steps and possibly a sample
file) if you can still reproduce the issue.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=132157
[Bug 132157] [META] BigPtrArray::Index2Block undo crashes
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: officecfg/registry sc/inc sc/source sc/uiconfig

2024-05-07 Thread Heiko Tietze (via logerrit)

 officecfg/registry/schema/org/openoffice/Office/Calc.xcs |   10 ++
 sc/inc/ViewSettingsSequenceDefines.hxx   |   35 +-
 sc/inc/unonames.hxx  |1 
 sc/inc/viewopti.hxx  |1 
 sc/source/core/data/postit.cxx   |4 -
 sc/source/core/tool/viewopti.cxx |   21 --
 sc/source/ui/inc/tpview.hxx  |2 
 sc/source/ui/optdlg/tpview.cxx   |   11 +++
 sc/source/ui/unoobj/confuno.cxx  |5 +
 sc/source/ui/unoobj/viewuno.cxx  |4 +
 sc/source/ui/view/viewdata.cxx   |4 +
 sc/uiconfig/scalc/ui/tpviewpage.ui   |   52 +++
 12 files changed, 112 insertions(+), 38 deletions(-)

New commits:
commit a5d0114bbb40f5bffcb19d6e6b3a5bf43aab1446
Author: Heiko Tietze 
AuthorDate: Tue May 7 08:56:07 2024 +0200
Commit: Heiko Tietze 
CommitDate: Tue May 7 15:48:04 2024 +0200

Resolves tdf#156885 - Make comment authorship optional

Change-Id: I3422c9e5606fa9eb9aa450f518af8426e598ab8f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167260
Tested-by: Jenkins
Reviewed-by: Balazs Varga 
Reviewed-by: Heiko Tietze 

diff --git a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
index fb6edf076f17..7303d1bacd00 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Calc.xcs
@@ -106,13 +106,21 @@
   true
 
 
-  
+  
   
 If less than 1, the size of comment indicator is calculated 
dynamically; otherwise this value will be used.
 Comment indicator size
   
   0
 
+
+  
+  
+Indicates whether authorship metadata for comments on hover 
are shown.
+Comment authorship
+  
+  true
+
 
   
   
diff --git a/sc/inc/ViewSettingsSequenceDefines.hxx 
b/sc/inc/ViewSettingsSequenceDefines.hxx
index 0c04aa594e68..1cb2b59eb9fc 100644
--- a/sc/inc/ViewSettingsSequenceDefines.hxx
+++ b/sc/inc/ViewSettingsSequenceDefines.hxx
@@ -24,7 +24,7 @@
 // this are the defines for the position of the settings in the
 // ViewSettingsSequence
 
-#define SC_VIEWSETTINGS_COUNT   26
+#define SC_VIEWSETTINGS_COUNT   27
 
 #define SC_VIEW_ID  0
 #define SC_TABLE_VIEWSETTINGS   1
@@ -36,22 +36,23 @@
 #define SC_PAGE_BREAK_PREVIEW   7
 #define SC_SHOWZERO 8
 #define SC_SHOWNOTES9
-#define SC_SHOWFORMULASMARKS10
-#define SC_SHOWGRID 11
-#define SC_GRIDCOLOR12
-#define SC_SHOWPAGEBR   13
-#define SC_COLROWHDR14
-#define SC_SHEETTABS15
-#define SC_OUTLSYMB 16
-#define SC_VALUE_HIGHLIGHTING   17
-#define SC_SNAPTORASTER 18
-#define SC_RASTERVIS19
-#define SC_RASTERRESX   20
-#define SC_RASTERRESY   21
-#define SC_RASTERSUBX   22
-#define SC_RASTERSUBY   23
-#define SC_RASTERSYNC   24
-#define SC_FORMULA_BAR_HEIGHT   25
+#define SC_SHOWNOTEAUTHOR   10
+#define SC_SHOWFORMULASMARKS11
+#define SC_SHOWGRID 12
+#define SC_GRIDCOLOR13
+#define SC_SHOWPAGEBR   14
+#define SC_COLROWHDR15
+#define SC_SHEETTABS16
+#define SC_OUTLSYMB 17
+#define SC_VALUE_HIGHLIGHTING   18
+#define SC_SNAPTORASTER 19
+#define SC_RASTERVIS20
+#define SC_RASTERRESX   21
+#define SC_RASTERRESY   22
+#define SC_RASTERSUBX   23
+#define SC_RASTERSUBY   24
+#define SC_RASTERSYNC   25
+#define SC_FORMULA_BAR_HEIGHT   26
 
 // this are the defines for the position of the settings in the
 // TableViewSettingsSequence
diff --git a/sc/inc/unonames.hxx b/sc/inc/unonames.hxx
index 07c9c39ace30..13bb2600f471 100644
--- a/sc/inc/unonames.hxx
+++ b/sc/inc/unonames.hxx
@@ -561,6 +561,7 @@ inline constexpr OUString SC_UNO_SHOWFORM = 
u"ShowFormulas"_ustr;
 inline constexpr OUString SC_UNO_SHOWGRID = u"ShowGrid"_ustr;
 inline constexpr OUString SC_UNO_SHOWHELP = u"ShowHelpLines"_ustr;
 inline constexpr OUString SC_UNO_SHOWNOTES=

[Bug 101216] [META] Calc comment bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=101216
Bug 101216 depends on bug 156885, which changed state.

Bug 156885 Summary: add toggle to show / hide authorship metadata in popup Calc 
comments
https://bugs.documentfoundation.org/show_bug.cgi?id=156885

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160972] spam

https://bugs.documentfoundation.org/show_bug.cgi?id=160972

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |INVALID
  Component|General |deletionRequest
Product|Impress Remote  |LibreOffice
Summary|Klingelton Kostenlos:   |spam
   |Wilder Westen Tone  |
 Status|UNCONFIRMED |RESOLVED
Version|1.0.2   |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: download.lst external/lxml

 download.lst   
 |4 
 
external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 
|   31 ---
 external/lxml/UnpackedTarball_lxml.mk  
 |3 
 external/lxml/Wincompatible-function-pointer-types.patch   
 |   83 --
 external/lxml/Wincompatible-pointer-types.patch
 |   65 ---
 5 files changed, 2 insertions(+), 184 deletions(-)

New commits:
commit 606623d0fc5321754d9a054881ae9cac94cd9f04
Author: Xisco Fauli 
AuthorDate: Tue May 7 14:07:14 2024 +0200
Commit: Xisco Fauli 
CommitDate: Tue May 7 15:38:36 2024 +0200

lxml: upgrade to 5.2.1

* 0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 got
  obsoleted with 
https://github.com/lxml/lxml/commit/9686dd9c7670d18acff6360c8444520273d5f1b2

* Wincompatible-function-pointer-types.patch and
Wincompatible-pointer-types.patch got obsoleted with
https://github.com/lxml/lxml/commit/6bdf4c321b92e002123b4c162c75524dbeb4d54d

Change-Id: I8f0dcba3bd64a1766a2292b687c8959c739ced6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167278
Tested-by: Jenkins
Reviewed-by: Xisco Fauli 

diff --git a/download.lst b/download.lst
index 27ffbbb97306..e0f142b4d63d 100644
--- a/download.lst
+++ b/download.lst
@@ -441,8 +441,8 @@ LPSOLVE_TARBALL := 
26b3e95ddf3d9c077c480ea45874b3b8-lp_solve_5.5.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
-LXML_SHA256SUM := 
2455cfaeb7ac70338b3257f41e21f0724f4b5b0c0e7702da67ee6c3640835b67
-LXML_TARBALL := lxml-4.9.2.tgz
+LXML_SHA256SUM := 
3f7765e69bbce0906a7c74d5fe46d2c7a7596147318dbc08e4a2431f3060e306
+LXML_TARBALL := lxml-5.2.1.tar.gz
 # three static lines
 # so that git cherry-pick
 # will not run into conflicts
diff --git 
a/external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
 
b/external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
deleted file mode 100644
index ce1ec383cc63..
--- 
a/external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1
+++ /dev/null
@@ -1,31 +0,0 @@
-From 9686dd9c7670d18acff6360c8444520273d5f1b2 Mon Sep 17 00:00:00 2001
-From: Jakub Wilk 
-Date: Fri, 16 Jun 2023 09:24:21 +0200
-Subject: [PATCH] Make regexp string raw to correct its escape sequence usage
- (GH-371)
-
-Fixes:
-
-$ python3 -Wd setup.py
-setup.py:117: DeprecationWarning: invalid escape sequence \.
-...

- setup.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/setup.py b/setup.py
-index 709cbc68..7a3f46e5 100644
 a/setup.py
-+++ b/setup.py
-@@ -114,7 +114,7 @@ extra_options['packages'] = [
- 
- def setup_extra_options():
- is_interesting_package = re.compile('^(libxml|libxslt|libexslt)$').match
--is_interesting_header = re.compile('^(zconf|zlib|.*charset)\.h$').match
-+is_interesting_header = re.compile(r'^(zconf|zlib|.*charset)\.h$').match
- 
- def extract_files(directories, pattern='*'):
- def get_files(root, dir_path, files):
--- 
-2.39.2
-
diff --git a/external/lxml/UnpackedTarball_lxml.mk 
b/external/lxml/UnpackedTarball_lxml.mk
index 58905943c7ee..0216801cb1a8 100644
--- a/external/lxml/UnpackedTarball_lxml.mk
+++ b/external/lxml/UnpackedTarball_lxml.mk
@@ -14,10 +14,7 @@ $(eval $(call 
gb_UnpackedTarball_set_tarball,lxml,$(LXML_TARBALL)))
 $(eval $(call gb_UnpackedTarball_set_patchlevel,lxml,0))
 
 $(eval $(call gb_UnpackedTarball_add_patches,lxml, \
-   
external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 
\
external/lxml/replace-setuptools-with-distutils.patch.1 \
-   external/lxml/Wincompatible-function-pointer-types.patch \
-   external/lxml/Wincompatible-pointer-types.patch \
 ))
 
 # vim: set noet sw=4 ts=4:
diff --git a/external/lxml/Wincompatible-function-pointer-types.patch 
b/external/lxml/Wincompatible-function-pointer-types.patch
deleted file mode 100644
index 644082fdc8bc..
--- a/external/lxml/Wincompatible-function-pointer-types.patch
+++ /dev/null
@@ -1,83 +0,0 @@
 src/lxml/etree.c
-+++ src/lxml/etree.c
-@@ -113118,7 +113118,7 @@
-  * self._orig_loader = _register_document_loader() if 
set_document_loader else NULL
-  * if self._validator is not None:
-  */
--  __pyx_v_self->_c_ctxt->sax->serror = 
__pyx_f_4lxml_5etree__receiveParserError;
-+  __pyx_v_self->_c_ctxt->sax->serror = 
(xmlStructuredErrorFunc)__pyx_f_4lxml_5etree__receiveParserError;
- 
-   /* "src/lxml/parser.pxi":587
-  * self._doc = None
-@@ -117606,7 +117606,7 @@
-  * sax.startElementNs = NULL
-  * sax.endElementNs = NULL
-  */
--__pyx_v_sax->serror = __pyx_f_4lxml_5etree__receiveParserError;
-+__pyx_v_sax->serror = 
(xmlStructuredErrorFunc)__pyx_f_4lxml_5etree__receiveParserError;
- 
- /*

core.git: sc/source

2024-05-07 Thread Andrea Gelmini (via logerrit)

 sc/source/ui/app/transobj.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 11dcaad533553999dc643807f6f21f8f98bc9e20
Author: Andrea Gelmini 
AuthorDate: Tue May 7 11:33:06 2024 +0200
Commit: Julien Nabet 
CommitDate: Tue May 7 15:32:50 2024 +0200

Fix typo

Change-Id: I8772d0e12b169559a3bf99347097939ede5db582
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167266
Tested-by: Jenkins
Reviewed-by: Julien Nabet 

diff --git a/sc/source/ui/app/transobj.cxx b/sc/source/ui/app/transobj.cxx
index f242abc497b0..0d926b980fc2 100644
--- a/sc/source/ui/app/transobj.cxx
+++ b/sc/source/ui/app/transobj.cxx
@@ -418,7 +418,7 @@ bool ScTransferObj::GetData( const 
datatransfer::DataFlavor& rFlavor, const OUSt
 // memory limits, lower the resolution of the bitmap by keeping
 // the VirtualDevice pixel size within an arbitrary number of
 // pixels.
-// Note: the artibrary "maximum number of pixels" limit that
+// Note: the arbitrary "maximum number of pixels" limit that
 // that Skia can handle may need to be raised or lowered for
 // platforms other than macOS.
 static constexpr tools::Long nCopyToImageMaxPixels = 8192 * 8192;

[Bug 137184] FILESAVE RTF Text in footer aligned incorrectly

https://bugs.documentfoundation.org/show_bug.cgi?id=137184

--- Comment #5 from Buovjaga  ---
(In reply to Dieter from comment #4)
> Still a problem with
> 
> Version: 24.2.3.2 (X86_64) / LibreOffice Community
> Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
> CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL:
> win
> Locale: de-DE (de_DE); UI: en-GB
> Calc: CL threaded
> 
> Footer is now aligned on the left, but footer is empty. That might be the
> expected behaviour if "Same Content on Left and Right Pages" is enabled (see
> comment 2).
> 
> Buovjaga, I think bug summary should be changed or the report should be
> closed, because original problem seems to be resolved. What do you think?

Reported as bug 160976.

I don't think it's expected behaviour because there is no right page footer in
the document. The footer on the first page is "First Page Footer".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160976] FILESAVE RTF Footer content lost after saving from DOCX to RTF

https://bugs.documentfoundation.org/show_bug.cgi?id=160976

Buovjaga  changed:

   What|Removed |Added

  Regression By||Tomaž Vajngerl
 Ever confirmed|0   |1
 CC||qui...@gmail.com
 Blocks||113423
 Status|UNCONFIRMED |NEW


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=113423
[Bug 113423] [META] RTF (text) header and footer-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 113423] [META] RTF (text) header and footer-related issues

https://bugs.documentfoundation.org/show_bug.cgi?id=113423

Buovjaga  changed:

   What|Removed |Added

 Depends on||160976


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160976
[Bug 160976] FILESAVE RTF Footer content lost after saving from DOCX to RTF
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 136472] FILEOPEN DOCX: be like DOC - import bTitlePage into Default Page Style (as separate first header), not First Page style

https://bugs.documentfoundation.org/show_bug.cgi?id=136472

Buovjaga  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=16
   ||0976

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160976] New: FILESAVE RTF Footer content lost after saving from DOCX to RTF

https://bugs.documentfoundation.org/show_bug.cgi?id=160976

Bug ID: 160976
   Summary: FILESAVE RTF Footer content lost after saving from
DOCX to RTF
   Product: LibreOffice
   Version: 24.2.0.0 alpha0+
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Keywords: bibisected, bisected, dataLoss, regression
  Severity: major
  Priority: high
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: ilmari.lauhakan...@libreoffice.org

1. Open attachment 104763 from bug 82734
2. Save as RTF and reload

Footer on second page has disappeared.

Bibisected with linux-64-24.2 to 4b0fa253a4540f5461397815d290586f9ddabe61
tdf#136472 adjust ooxml import to handle first header/footer

Originally reported by Dieter in bug 137184 comment 4.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 108386] [META] Calc sorting related bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=108386
Bug 108386 depends on bug 152635, which changed state.

Bug 152635 Summary: Image anchored to cell jump around when sorting + autofilter
https://bugs.documentfoundation.org/show_bug.cgi?id=152635

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103512] [META] AutoFilter-related bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103512
Bug 103512 depends on bug 152635, which changed state.

Bug 152635 Summary: Image anchored to cell jump around when sorting + autofilter
https://bugs.documentfoundation.org/show_bug.cgi?id=152635

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 87740] [META] Anchor and text wrapping bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=87740
Bug 87740 depends on bug 152635, which changed state.

Bug 152635 Summary: Image anchored to cell jump around when sorting + autofilter
https://bugs.documentfoundation.org/show_bug.cgi?id=152635

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152635] Image anchored to cell jump around when sorting + autofilter

https://bugs.documentfoundation.org/show_bug.cgi?id=152635

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 CC||rb.hensc...@t-online.de
 Whiteboard||target:24.8.0 target:24.2.4

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Fixed by Regina with:

https://git.libreoffice.org/core/commit/f0a2969d15e3101d7f96a7fe77bca06a5d70f57a
tdf#160329 update objects after row sort is finished
It will be available in 24.8.0.

https://git.libreoffice.org/core/commit/1347274fc1cb780db4c7c9b8c0272e1730b95c04
tdf#160329 update objects after row sort is finished
It will be available in 24.2.4.

I checked with linux-64-24.8 bibisect repo at corresponding build
[921f5f782a764a4b51f12b95986f16f6278333e8].
Thanks Regina!

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: editeng/qa editeng/source

 editeng/qa/lookuptree/lookuptree_test.cxx   |   26 
 editeng/qa/unit/core-test.cxx   |  396 ++--
 editeng/source/accessibility/AccessibleContextBase.cxx  |   10 
 editeng/source/accessibility/AccessibleEditableTextPara.cxx |   80 +-
 editeng/source/accessibility/AccessibleImageBullet.cxx  |   20 
 editeng/source/accessibility/AccessibleStaticTextBase.cxx   |6 
 editeng/source/editeng/editdbg.cxx  |2 
 editeng/source/editeng/editdoc.cxx  |8 
 editeng/source/editeng/editview.cxx |   40 -
 editeng/source/editeng/eehtml.cxx   |2 
 editeng/source/editeng/eertfpar.cxx |2 
 editeng/source/editeng/impedit.cxx  |4 
 editeng/source/editeng/impedit2.cxx |2 
 editeng/source/editeng/impedit3.cxx |4 
 editeng/source/editeng/impedit4.cxx |2 
 editeng/source/items/flditem.cxx|2 
 editeng/source/items/legacyitem.cxx |2 
 editeng/source/items/numitem.cxx|   14 
 editeng/source/items/svxfont.cxx|8 
 editeng/source/misc/SvXMLAutoCorrectExport.cxx  |4 
 editeng/source/misc/SvXMLAutoCorrectImport.cxx  |4 
 editeng/source/misc/acorrcfg.cxx|6 
 editeng/source/misc/svxacorr.cxx|   18 
 editeng/source/misc/swafopt.cxx |2 
 editeng/source/misc/unolingu.cxx|6 
 editeng/source/outliner/outliner.cxx|4 
 editeng/source/uno/UnoForbiddenCharsTable.cxx   |6 
 editeng/source/uno/unofield.cxx |   38 -
 editeng/source/uno/unonrule.cxx |   12 
 editeng/source/uno/unopracc.cxx |2 
 editeng/source/uno/unotext.cxx  |   28 
 editeng/source/uno/unotext2.cxx |4 
 editeng/source/xml/xmltxtexp.cxx|2 
 editeng/source/xml/xmltxtimp.cxx|2 
 34 files changed, 384 insertions(+), 384 deletions(-)

New commits:
commit 37722469bee4fe170e9514e32d6112ca31c2d934
Author: Noel Grandin 
AuthorDate: Tue May 7 12:56:38 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue May 7 14:59:35 2024 +0200

loplugin:ostr in editeng

Change-Id: I7353710e1558d486130ace09844ce97150eb4c43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167272
Tested-by: Jenkins
Reviewed-by: Noel Grandin 

diff --git a/editeng/qa/lookuptree/lookuptree_test.cxx 
b/editeng/qa/lookuptree/lookuptree_test.cxx
index 486c871ca09f..bdad1418ca21 100644
--- a/editeng/qa/lookuptree/lookuptree_test.cxx
+++ b/editeng/qa/lookuptree/lookuptree_test.cxx
@@ -58,13 +58,13 @@ void LookupTreeTest::testTrie()
 trie.insert( u"abcdefghijklmnopqrstuvwxyz" );
 trie.findSuggestions( u"a", suggestions);
 CPPUNIT_ASSERT_EQUAL( size_t(2), suggestions.size() );
-CPPUNIT_ASSERT_EQUAL( OUString("abc"), suggestions[0] );
-CPPUNIT_ASSERT_EQUAL( OUString("abcdefghijklmnopqrstuvwxyz"), 
suggestions[1] );
+CPPUNIT_ASSERT_EQUAL( u"abc"_ustr, suggestions[0] );
+CPPUNIT_ASSERT_EQUAL( u"abcdefghijklmnopqrstuvwxyz"_ustr, suggestions[1] );
 suggestions.clear();
 
 trie.findSuggestions( u"abc", suggestions);
 CPPUNIT_ASSERT_EQUAL( size_t(1), suggestions.size() );
-CPPUNIT_ASSERT_EQUAL( OUString("abcdefghijklmnopqrstuvwxyz"), 
suggestions[0] );
+CPPUNIT_ASSERT_EQUAL( u"abcdefghijklmnopqrstuvwxyz"_ustr, suggestions[0] );
 suggestions.clear();
 
 trie.findSuggestions( u"abe", suggestions);
@@ -74,41 +74,41 @@ void LookupTreeTest::testTrie()
 trie.insert( u"abe" );
 trie.findSuggestions( u"", suggestions);
 CPPUNIT_ASSERT_EQUAL( size_t(3), suggestions.size() );
-CPPUNIT_ASSERT_EQUAL( OUString("abc"), suggestions[0] );
-CPPUNIT_ASSERT_EQUAL( OUString("abcdefghijklmnopqrstuvwxyz"), 
suggestions[1] );
-CPPUNIT_ASSERT_EQUAL( OUString("abe"), suggestions[2] );
+CPPUNIT_ASSERT_EQUAL( u"abc"_ustr, suggestions[0] );
+CPPUNIT_ASSERT_EQUAL( u"abcdefghijklmnopqrstuvwxyz"_ustr, suggestions[1] );
+CPPUNIT_ASSERT_EQUAL( u"abe"_ustr, suggestions[2] );
 suggestions.clear();
 
 trie.insert( u"H31l0" );
 trie.findSuggestions( u"H", suggestions);
 
 CPPUNIT_ASSERT_EQUAL( size_t(1), suggestions.size() );
-CPPUNIT_ASSERT_EQUAL( OUString("H31l0"), suggestions[0] );
+CPPUNIT_ASSERT_EQUAL( u"H31l0"_ustr, suggestions[0] );
 suggestions.clear();
 
 trie.insert( u"H1" );
 trie.findSuggestions( u"H", suggestions);
 CPPUNIT_ASSERT_EQUAL( size_t(2), suggestions.size() );
-

[Bug 160966] Text lost on save

https://bugs.documentfoundation.org/show_bug.cgi?id=160966

che...@web.de changed:

   What|Removed |Added

Version|unspecified |7.3.7.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160966] Text lost on save

https://bugs.documentfoundation.org/show_bug.cgi?id=160966

--- Comment #6 from che...@web.de ---
*big

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160966] Text lost on save

https://bugs.documentfoundation.org/show_bug.cgi?id=160966

--- Comment #5 from che...@web.de ---
I'm using Ubuntu 22.04. Unfortunately there was a bug update yesterday, so I'm
not sure what the version was at the time being. 

Impress is at 7.3.7.2 right now. However I cannot rule out that I
created/edited the document with LibreOffice under Windows at some point. The
problem occurred in the Ubuntu OS though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 152627] PDF with hyperlinks: links are lost with import to Draw

https://bugs.documentfoundation.org/show_bug.cgi?id=152627

V Stuart Foote  changed:

   What|Removed |Added

 CC||longmanpauli...@gmail.com

--- Comment #11 from V Stuart Foote  ---
*** Bug 160975 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160975] When opening a saved PDF file, the existing hyperlinks are missing !!!!!!

https://bugs.documentfoundation.org/show_bug.cgi?id=160975

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||vsfo...@libreoffice.org
 Resolution|--- |DUPLICATE

--- Comment #1 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 152627 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145972] UI: Displayed image width PROPERTY relative to page erroneous after changing default measurement unit to Pt

https://bugs.documentfoundation.org/show_bug.cgi?id=145972

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|UI: Displayed image width   |UI: Displayed image width
   |PROPERTY relative to page   |PROPERTY relative to page
   |becomes 1% when checked if  |erroneous after changing
   |default measurement unit|default measurement unit to
   |set to pt   |Pt

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 109311] [META] Measurement unit bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=109311

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||145972


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=145972
[Bug 145972] UI: Displayed image width PROPERTY relative to page becomes 1%
when checked if default measurement unit set to pt
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 145972] UI: Displayed image width PROPERTY relative to page becomes 1% when checked if default measurement unit set to pt

https://bugs.documentfoundation.org/show_bug.cgi?id=145972

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org,
   ||vmik...@collabora.com
Version|6.2.0.3 release |7.2.0.0 alpha1+
   Keywords|bibisectRequest |bibisected, bisected
  Regression By||Miklos Vajna
 Blocks||109311

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
(In reply to Telesto from comment #2)
> Also in
> Version: 6.2.9.0.0+ (x86)
> 
> still OK with
> Version: 6.0.6.0.0+
For me, testing with a new profile each time, it started in LO 7.2: width at a
wrong 5% after switching to Point unit. Maybe your profile was interfering with
you tests?

Bibisected with linux-64-7.2 repo to first bad build
[de2eefc55492407153136f104eb6414ed0472d7b] which points to:

commit  02c435082058ecf7f9d4d73cb47d31d0218dc10d
author  Miklos VajnaMon Jun 07 18:03:33 2021 +0200
committer   Miklos VajnaMon Jun 07 18:49:07 2021 +0200
sw keep aspect ratio: add filter for this setting
SwViewOption::IsKeepRatio() was only in-memory, so ticking that checkbox
and restarting soffice disabled it again.
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116791

And then, somewhere in 7.3, the height follows suit at 3% - which is still the
case in a recent daily build.

Miklos, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=109311
[Bug 109311] [META] Measurement unit bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 40469] Modifed Frame Style Options Not Preserved, "Keep Ratio" Option Unavailable

https://bugs.documentfoundation.org/show_bug.cgi?id=40469

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2588

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 132588] The keep ratio button state isn't kept for frames

https://bugs.documentfoundation.org/show_bug.cgi?id=132588

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=40
   ||469
 CC||stephane.guillou@libreoffic
   ||e.org
Summary|The keep ratio button isn't |The keep ratio button state
   |working for frames  |isn't kept for frames

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
See related earlier bug 40469 with code pointers.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160968] MacOS 10.14 is not supported in latest releases (May of 2024)

https://bugs.documentfoundation.org/show_bug.cgi?id=160968

Buovjaga  changed:

   What|Removed |Added

 Status|VERIFIED|RESOLVED
 Resolution|FIXED   |NOTABUG

--- Comment #8 from Buovjaga  ---
That wasn't the topic, though, so keeping as notabug. And website issues are
not reported on Bugzilla anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 40469] Modifed Frame Style Options Not Preserved, "Keep Ratio" Option Unavailable

https://bugs.documentfoundation.org/show_bug.cgi?id=40469

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=45499

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: desktop/qa desktop/source

 desktop/qa/deployment_misc/test_dp_version.cxx|   14 -
 desktop/qa/desktop_app/test_desktop_app.cxx   |   32 
+--
 desktop/qa/desktop_lib/test_desktop_lib.cxx   |   70 
+++
 desktop/qa/unit/desktop-lok-init.cxx  |6 
 desktop/source/app/app.cxx|   40 
++--
 desktop/source/app/appinit.cxx|2 
 desktop/source/app/check_ext_deps.cxx |   24 +-
 desktop/source/app/dispatchwatcher.cxx|   54 
++---
 desktop/source/app/langselect.cxx |2 
 desktop/source/app/officeipcthread.cxx|   16 -
 desktop/source/app/opencl.cxx |   10 -
 desktop/source/app/sofficemain.cxx|2 
 desktop/source/deployment/dp_log.cxx  |4 
 desktop/source/deployment/gui/dp_gui_dependencydialog.cxx |5 
 desktop/source/deployment/gui/dp_gui_dialog2.cxx  |   86 
-
 desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx|8 
 desktop/source/deployment/gui/dp_gui_service.cxx  |6 
 desktop/source/deployment/gui/dp_gui_theextmgr.cxx|   16 -
 desktop/source/deployment/gui/dp_gui_updatedialog.cxx |   62 
+++---
 desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx  |   32 
+--
 desktop/source/deployment/gui/license_dialog.cxx  |   20 +-
 desktop/source/deployment/inc/dp_ucb.h|4 
 desktop/source/deployment/manager/dp_activepackages.hxx   |2 
 desktop/source/deployment/manager/dp_extensionmanager.cxx |   64 
+++---
 desktop/source/deployment/manager/dp_informationprovider.cxx  |   12 -
 desktop/source/deployment/manager/dp_manager.cxx  |   24 +-
 desktop/source/deployment/manager/dp_manager.h|2 
 desktop/source/deployment/manager/dp_managerfac.cxx   |6 
 desktop/source/deployment/manager/dp_properties.cxx   |6 
 desktop/source/deployment/misc/dp_dependencies.cxx|   20 +-
 desktop/source/deployment/misc/dp_descriptioninfoset.cxx  |   80 

 desktop/source/deployment/misc/dp_misc.cxx|   26 +-
 desktop/source/deployment/misc/dp_platform.cxx|4 
 desktop/source/deployment/misc/dp_ucb.cxx |4 
 desktop/source/deployment/misc/dp_update.cxx  |4 
 desktop/source/deployment/registry/component/dp_component.cxx |   92 
+-
 desktop/source/deployment/registry/configuration/dp_configuration.cxx |   26 +-
 desktop/source/deployment/registry/dp_backend.cxx |   16 -
 desktop/source/deployment/registry/dp_backenddb.cxx   |   10 -
 desktop/source/deployment/registry/dp_registry.cxx|8 
 desktop/source/deployment/registry/executable/dp_executable.cxx   |   16 -
 desktop/source/deployment/registry/help/dp_help.cxx   |   14 -
 desktop/source/deployment/registry/package/dp_package.cxx |   62 
+++---
 desktop/source/deployment/registry/script/dp_script.cxx   |   22 +-
 desktop/source/deployment/registry/sfwk/dp_parceldesc.cxx |2 
 desktop/source/deployment/registry/sfwk/dp_sfwk.cxx   |   30 
+--
 desktop/source/lib/init.cxx   |   20 +-
 desktop/source/lib/lokclipboard.cxx   |9 
 desktop/source/lib/lokclipboard.hxx   |2 
 desktop/source/lib/lokinteractionhandler.cxx  |   10 -
 desktop/source/migration/migration.cxx|   30 
+--
 desktop/source/migration/services/basicmigration.cxx  |4 
 desktop/source/migration/services/jvmfwk.cxx  |   20 +-
 desktop/source/migration/services/oo3extensionmigration.cxx   |   12 -
 desktop/source/migration/services/wordbookmigration.cxx   |4 
 desktop/source/offacc/acceptor.cxx|   16 -
 desktop/source/pkgchk/unopkg/unopkg_app.cxx   |   42 
++--
 desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx|4 
 desktop/source/pkgchk/unopkg/unopkg_misc.cxx  |   12 -
 desktop/source/splash/splash.cxx  |   24 +-
 desktop/source/splash/unxsplash.cxx   |4 
 61 files changed, 642 insertions(+), 638 deletions(-)

core.git: solenv/gbuild

 solenv/gbuild/platform/com_MSC_defs.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c87077f653739d00ed5237d54838c1a454d65c4f
Author: Noel Grandin 
AuthorDate: Tue May 7 12:49:07 2024 +0200
Commit: Noel Grandin 
CommitDate: Tue May 7 14:40:58 2024 +0200

fix Windows incremental build

after
commit 4c86718e78c6b18c84774e48ca025694364c251a
Author: Christian Lohmaier 
Date:   Thu Apr 18 12:45:01 2024 +0200
initial support for running autogen.sh inside wsl from git-bash

otherwise we end up with mixed cygwin/windows paths in our .d
files, which the make executable we use will not like.

Change-Id: Ia1325793f47657a23774c216df319ae6afd6d638
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167269
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier 

diff --git a/solenv/gbuild/platform/com_MSC_defs.mk 
b/solenv/gbuild/platform/com_MSC_defs.mk
index 871bbfdc6189..1ab191f27776 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -243,7 +243,7 @@ gb_COMPILERDEBUGOPTFLAGS :=
 ifeq ($(gb_FULLDEPS),$(true))
 gb_COMPILERDEPFLAGS := -showIncludes
 define gb_create_deps
-| $(call gb_Helper_cyg_path,$(GBUILDDIR)/platform/filter-showIncludes.awk 
-vdepfile=$(1) -vobjectfile=$(2) -vsourcefile=$(3)); exit $${PIPESTATUS[0]}
+| $(GBUILDDIR)/platform/filter-showIncludes.awk -vdepfile=$(1) 
-vobjectfile=$(2) -vsourcefile=$(3); exit $${PIPESTATUS[0]}
 endef
 else
 gb_COMPILERDEPFLAGS :=

[Bug 160975] New: When opening a saved PDF file, the existing hyperlinks are missing !!!!!!

https://bugs.documentfoundation.org/show_bug.cgi?id=160975

Bug ID: 160975
   Summary: When opening a saved PDF file, the existing hyperlinks
are missing !!
   Product: LibreOffice
   Version: 24.2.2.2 release
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: longmanpauli...@gmail.com

Description:
When opening a saved PDF file, the existing hyperlinks are missing !!
The PDF file, open's correctly in a web browser and the links work okay.
The PDF file, will also load into Libre office.
But the hyperlinks are missing 

Actual Results:
Chose open file, selected PDF file, and noticed the hyperlinks were missing.

Expected Results:
For the PDF file to open and the existing hyperlinks to remain.


Reproducible: Always


User Profile Reset: No

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-GB
Module: TextDocument
[Information guessed from browser]
OS: Windows (All)
OS is 64bit: no

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160968] MacOS 10.14 is not supported in latest releases (May of 2024)

https://bugs.documentfoundation.org/show_bug.cgi?id=160968

steve  changed:

   What|Removed |Added

 Status|RESOLVED|VERIFIED
 Resolution|NOTABUG |FIXED

--- Comment #7 from steve  ---
since actual changes were made setting this to fixed instead of notabug

-- 
You are receiving this mail because:
You are the assignee for the bug.

GSoC: Adding native support for histogram chart

2024-05-07 Thread Devansh Varshney

Hi everyone,

I am Devansh and this year I have been selected for the* Google Summer of
Code (GSoC) program with LibreOffice* to *Add the support for the Histogram
Chart* - GSoC Idea list (
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Histogram_.28and_other_missing.29_Chart_Type
) and *Tomaž Vajngerl* is going to be* my mentor,* who has guided me
throughout the proposal process and will continue to do so until the
project's completion.

I gravitated towards adding the support for the Histogram chart (and if
time permits other missing charts also from the MS Office 2016) stems from
my family background in science, engineering, and finance, where data
visualization plays a crucial role. Working on this project allows me to
connect with my family's work and explain my contributions in a meaningful
way.

Second, while preparing the proposal report I came across that the *CERN*
also uses the LibreOffice for their work is doing a work around because of
no native support of these new chart types. (
https://indico.cern.ch/event/977476/contributions/4204938/attachments/2191304/3703670/EN-Plotting-a-histogram-in-libreoffice.pdf)
which was the point where I can see the impact of this task. Not only this
*IndiaMart*, a prominent B2B marketplace where my friends work told me that
it also uses LibreOffice.

Seeing the potential impact of this project on real-world users was a
significant motivator for me. This project checks all the right boxes for
me.

I have been impressed by the LibreOffice community and documentation, which
are among the best I've seen.
I'd like to extend my gratitude to the community members who have helped me
get started with my contributions, including Hossein, Heiko, Michael,
Marco, and especially Ilmari, who was the first to guide me.

Regards,
Devansh
(IRC: devansh)

[Bug 160974] New: Hide Open Remote commands from popup menus

https://bugs.documentfoundation.org/show_bug.cgi?id=160974

Bug ID: 160974
   Summary: Hide Open Remote commands from popup menus
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com
Blocks: 103239

Created attachment 194016
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194016=edit
Screenshot of the problem

This is a followup to bug 160961

In case some enterprise deployment wants to disable certain UNO commands from
being active in the menu, toolbar, sidebar or start center, this is possible by
using a config extension and list the command in the
ooO::Commands::Execute::Disabled config key tree.
This does not work in case of the Open or Recent Documents dropdowns: the
button is not hidden, neither does it work.

1. Open a new Writer document, change UI to Tabbed (but also happens in the
standard toolbar mode)
2. Install attachment 194000 [details] extension from bug 160961, restart
Writer
-> In the File -> Open and File -> Recent Documents dropdowns the Open Remote
button is visible, but does not pop up the dialog.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d5d9eaa61505cebaf3bde4bfc157d8e19fec8de
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103239
[Bug 103239] [META] Toolbars bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103239] [META] Toolbars bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103239

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||160974


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160974
[Bug 160974] Hide Open Remote commands from popup menus
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160968] MacOS 10.14 is not supported in latest releases (May of 2024)

https://bugs.documentfoundation.org/show_bug.cgi?id=160968

--- Comment #6 from Mike Saunders  ---
(In reply to Buovjaga from comment #5)
> (In reply to Mike Saunders from comment #4)
> > I just updated the text string, so it should be fixed now.
> 
> Thanks. Can you also change the Mac OS X string?

Done too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 151382] UI: Keep ratio setting lost after opening Image properties Position and Size dialog, a change, OK and reopening the dialog

https://bugs.documentfoundation.org/show_bug.cgi?id=151382

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=13
   ||2591
Version|7.5.0.0 alpha0+ |7.3.1.3 release
   Keywords||bibisected, bisected,
   ||regression
 CC||caolan.mcnamara@collabora.c
   ||om,
   ||stephane.guillou@libreoffic
   ||e.org
  Regression By||Caolán McNamara

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Reproduced in recent daily build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7a895ec4205659038aa95941b65715fed1a3e7be
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

... and in 7.3.7, but no repro in:

Version: 7.3.0.3 / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL

Bibisected with linux-64-7.3 repo to first bad build
[596229b236011767a88288b8f3e10a929e95577b] which is
27b03993c49b3c8a3bafa736db9ca25e834a2195, a cherrypick of:

commit  a59952f64c6e78f8e5bad6d6ab8373879f6a826f
author  Caolán McNamara Wed Feb 09 13:54:42 2022 +
committer   Caolán McNamara Wed Feb 09 20:59:06 2022 +0100
Resolves: tdf#132591 set property if Fixed Ratio checkbox was toggled
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129730

Caolán, can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103314] [META] Templates bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103314

Laurent Balland  changed:

   What|Removed |Added

 Depends on||160712


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160712
[Bug 160712] Bundled Impress templates should use placeholders instead of dummy
text
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: cui/source cui/uiconfig schema/libreoffice sw/qa sw/source xmloff/source

2024-05-07 Thread László Németh (via logerrit)

 cui/source/inc/paragrph.hxx|3 
 cui/source/tabpages/paragrph.cxx   |   38 +
 cui/uiconfig/ui/textflowpage.ui|   29 +
 schema/libreoffice/OpenDocument-v1.3+libreoffice-schema.rng|2 
 sw/qa/extras/layout/data/tdf132599_always.fodt |  249 
++
 sw/qa/extras/layout/layout3.cxx|   27 +
 sw/qa/extras/odfexport/data/tdf132599_always.fodt  |  249 
++
 sw/qa/extras/odfexport/data/tdf132599_column.fodt  |   12 
 sw/qa/extras/odfexport/data/tdf132599_page_in_last_column.fodt |   12 
 sw/qa/extras/odfexport/data/tdf132599_page_in_not_last_column.fodt |   12 
 sw/qa/extras/odfexport/data/tdf132599_spread-left-page.fodt|   20 
 sw/qa/extras/odfexport/data/tdf132599_spread.fodt  |   16 
 sw/qa/extras/odfexport/odfexport2.cxx  |   15 
 sw/source/core/text/guess.cxx  |   40 +
 xmloff/source/text/txtprhdl.cxx|1 
 xmloff/source/text/txtprmap.cxx|2 
 16 files changed, 678 insertions(+), 49 deletions(-)

New commits:
commit c8a99cb8dce54de506ba66d1cc0818b9b5f7858b
Author: László Németh 
AuthorDate: Mon May 6 17:17:43 2024 +0200
Commit: László Németh 
CommitDate: Tue May 7 13:58:28 2024 +0200

tdf#132599 sw schema xmloff: add hyphenation-keep-type='always'

Add new hyphenation option to limit hyphenation
of the last full line of the hyphenated paragraph.

Move also loext:hyphenation-keep-type to paragraph-properties,
following the associated hyphenation-keep.

Note: value "always" is defined by CSS 4 hyphenate-limit-last,
see https://www.w3.org/TR/css-text-4/#hyphenate-line-limits.

Follow-up to commit 6e8819f29b6051a0e551d77512830539913ec277
"tdf#132599 cui offapi sw xmloff: add hyphenation-keep-type".

Change-Id: I2121269205fc89fb5367dccdca00195aac68f3e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167232
Tested-by: Jenkins
Reviewed-by: László Németh 

diff --git a/cui/source/inc/paragrph.hxx b/cui/source/inc/paragrph.hxx
index b35111f43b33..e219aa622e07 100644
--- a/cui/source/inc/paragrph.hxx
+++ b/cui/source/inc/paragrph.hxx
@@ -221,6 +221,7 @@ private:
 weld::TriStateEnabled aKeepParaState;
 weld::TriStateEnabled aOrphanState;
 weld::TriStateEnabled aWidowState;
+weld::TriStateEnabled aAcrossParagraphState;
 weld::TriStateEnabled aAcrossColumnState;
 weld::TriStateEnabled aAcrossPageState;
 weld::TriStateEnabled aAcrossSpreadState;
@@ -272,6 +273,7 @@ private:
 
 // avoid hyphenation across
 std::unique_ptr m_xAcrossText;
+std::unique_ptr m_xAcrossParagraphBox;
 std::unique_ptr m_xAcrossColumnBox;
 std::unique_ptr m_xAcrossPageBox;
 std::unique_ptr m_xAcrossSpreadBox;
@@ -294,6 +296,7 @@ private:
 DECL_LINK(PageBreakTypeHdl_Impl, weld::ComboBox&, void);
 DECL_LINK(PageNumBoxClickHdl_Impl, weld::Toggleable&, void);
 DECL_LINK(KeepParaBoxClickHdl_Impl, weld::Toggleable&, void);
+DECL_LINK(AcrossParagraphHdl_Impl, weld::Toggleable&, void);
 DECL_LINK(AcrossColumnHdl_Impl, weld::Toggleable&, void);
 DECL_LINK(AcrossPageHdl_Impl, weld::Toggleable&, void);
 DECL_LINK(AcrossSpreadHdl_Impl, weld::Toggleable&, void);
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 034983ea73ce..56b697a046a6 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -1618,6 +1618,7 @@ bool SvxExtParagraphTabPage::FillItemSet( SfxItemSet* 
rOutSet )
  m_xMaxHyphenEdit->get_value_changed_from_saved() ||
  m_xMinWordLength->get_value_changed_from_saved() ||
  m_aHyphenZone.get_value_changed_from_saved() ||
+ m_xAcrossParagraphBox->get_state_changed_from_saved() ||
  m_xAcrossColumnBox->get_state_changed_from_saved() ||
  m_xAcrossPageBox->get_state_changed_from_saved() ||
  m_xAcrossSpreadBox->get_state_changed_from_saved() )
@@ -1643,6 +1644,7 @@ bool SvxExtParagraphTabPage::FillItemSet( SfxItemSet* 
rOutSet )
 aHyphen.GetTextHyphenZone() = 
static_cast(m_aHyphenZone.GetCoreValue(eUnit));
 aHyphen.SetHyphen( eHyphenState == TRISTATE_TRUE );
 aHyphen.SetNoLastWordHyphenation(m_xHyphenNoLastWordBox->get_state() 
!= TRISTATE_TRUE);
+const TriState eAcrossParagraphState = 
m_xAcrossParagraphBox->get_state();
 const TriState eAcrossColumnState = m_xAcrossColumnBox->get_state();
 const TriState eAcrossPageState = m_xAcrossPageBox->get_state();
 const TriState eAcrossSpreadState = m_xAcrossSpreadBox->get_state();
@@ -1666,12 +1668,19 @@ bool SvxExtParagraphTabPage::FillItemSet( SfxItemSet* 
rOutSet )

[Bug 103314] [META] Templates bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103314
Bug 103314 depends on bug 160899, which changed state.

Bug 160899 Summary: Candy: Enabling Master Elements results in shapes with 
default blue background
https://bugs.documentfoundation.org/show_bug.cgi?id=160899

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103270] [META] Image/Picture dialog bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103270

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|125239  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125239
[Bug 125239] Default "Keep ratio" in Image properties editor in Writer to
ticked
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103152] [META] Writer image bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103152

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|125239  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=125239
[Bug 125239] Default "Keep ratio" in Image properties editor in Writer to
ticked
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 125239] Default "Keep ratio" in Image properties editor in Writer to ticked

https://bugs.documentfoundation.org/show_bug.cgi?id=125239

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=80 |
   |281 |
 Status|NEW |RESOLVED
 Blocks|103152, 103270  |
 Resolution|--- |DUPLICATE
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #7 from Stéphane Guillou (stragu) 
 ---


*** This bug has been marked as a duplicate of bug 80281 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103270
[Bug 103270] [META] Image/Picture dialog bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 80281] FORMATTING: "Keep ratio" should be on by default for images or photos

https://bugs.documentfoundation.org/show_bug.cgi?id=80281

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=12 |
   |5239|
 CC||stec...@gmail.com

--- Comment #14 from Stéphane Guillou (stragu) 
 ---
*** Bug 125239 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103152] [META] Writer image bugs and enhancements

https://bugs.documentfoundation.org/show_bug.cgi?id=103152

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||80281


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=80281
[Bug 80281] FORMATTING: "Keep ratio" should be on by default for images or
photos
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 80281] FORMATTING: "Keep ratio" should be on by default for images or photos

https://bugs.documentfoundation.org/show_bug.cgi?id=80281

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Version|4.3.0.1 rc  |Inherited From OOo
 Blocks||103152
Summary|FORMATTING: "Keep aspect|FORMATTING: "Keep ratio"
   |ratio" checkbox of images   |should be on by default for
   |or photos not always|images or photos
   |honoured|

--- Comment #13 from Stéphane Guillou (stragu) 
 ---
(In reply to Heiko Tietze from comment #12)
> We discussed the topic in the design meeting.
> 
> Proportional scaling is enabled for images while using the mouse and we
> should do the same when working with the dialog. So simply check "Keep
> ratio" in the Position & Size dialog by default for images.
Changing the summary accordingly.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103152
[Bug 103152] [META] Writer image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160906] Crash when changing formatting (e.g. font) inside Text Box Form Control

https://bugs.documentfoundation.org/show_bug.cgi?id=160906

Armin Le Grand  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |armin.le.gr...@me.com
   |desktop.org |

--- Comment #3 from Armin Le Grand  ---
Taking a look...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160973] Hide Open Remote commands from Tabbed UI

https://bugs.documentfoundation.org/show_bug.cgi?id=160973

--- Comment #1 from Gabor Kelemen (allotropia)  ---
Note: the example extension shows that this is a more generic problem in case
of the Tabbed UI. 
There is configuration contained to hide the "Export Directly to PDF" command,
which is also visible (but unusable) in the Tabbed UI.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107237] [META] Notebookbar Tabbed

https://bugs.documentfoundation.org/show_bug.cgi?id=107237

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Depends on||160973


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=160973
[Bug 160973] Hide Open Remote commands from Tabbed UI
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160973] Hide Open Remote commands from Tabbed UI

https://bugs.documentfoundation.org/show_bug.cgi?id=160973

Gabor Kelemen (allotropia)  changed:

   What|Removed |Added

 Blocks||107237
 CC||balazs.varga...@gmail.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=107237
[Bug 107237] [META] Notebookbar Tabbed
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160973] New: Hide Open Remote commands from Tabbed UI

https://bugs.documentfoundation.org/show_bug.cgi?id=160973

Bug ID: 160973
   Summary: Hide Open Remote commands from Tabbed UI
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: kelem...@ubuntu.com

This is a followup to bug 160961

In case some enterprise deployment wants to disable certain UNO commands from
being active in the menu, toolbar, sidebar or start center, this is possible by
using a config extension and list the command in the
ooO::Commands::Execute::Disabled config key tree.
This does not work in case of the Tabbed UI: the button is not hidden, neither
does it work.

1. Open a new Writer document, change UI to Tabbed
2. Install attachment 194000 extension from bug 160961, restart Writer
-> File tab -> Open Remote button is visible, but does not pop up the dialog.

Also happens in the Tabbed Compact UI and of course in Calc, Impress too.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6d5d9eaa61505cebaf3bde4bfc157d8e19fec8de
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158255] Fatal exception: Signal 6 when opening or converting prior working document ( SwSectionFrame::Notify() )

https://bugs.documentfoundation.org/show_bug.cgi?id=158255

--- Comment #7 from Wahrendorff  ---
I am not sure how this is related, but:

When I open the problematic odt in Libreoffice and then start our Software to
generate one File it actually crashes the opened Libreoffice process, starts a
new one and manages to generate the Files we expect. 路

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107639] User feedback that slide transition doesnt work due to OpenGL version (comment 4 for proposed solution)

https://bugs.documentfoundation.org/show_bug.cgi?id=107639

V Stuart Foote  changed:

   What|Removed |Added

Summary|User feedback that slide|User feedback that slide
   |transition doesnt work due  |transition doesnt work due
   |to OpenGL version   |to OpenGL version (comment
   ||4 for proposed solution)
 CC||kain...@gmail.com,
   ||qui...@gmail.com,
   ||riz...@libreoffice.org

--- Comment #10 from V Stuart Foote  ---
@Heiko, @quikee, * -- seems annotating the icon theme is still viable approach
to warning OpenGL needed for particular transition. 

Can we "stamp" the affected icon(s)? Or is a whole new version of each icon
needed?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160968] MacOS 10.14 is not supported in latest releases (May of 2024)