[Bug 109087] [META] Calc sheet header and footer bugs and enhancements

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109087
Bug 109087 depends on bug 160057, which changed state.

Bug 160057 Summary: Document Calc's separate Footer and Header tabs if "Same 
content on first page" is off
https://bugs.documentfoundation.org/show_bug.cgi?id=160057

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 80430] [META] Documentation gap for new features

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 160057, which changed state.

Bug 160057 Summary: Document Calc's separate Footer and Header tabs if "Same 
content on first page" is off
https://bugs.documentfoundation.org/show_bug.cgi?id=160057

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160057] Document Calc's separate Footer and Header tabs if "Same content on first page" is off

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160057

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|FIXED   |---

--- Comment #6 from Stéphane Guillou (stragu) 
 ---
Olivier, this is not fixed - unless there's a change not referenced here that
I'm not aware of?
Page still doesn't document the tabs:

https://help.libreoffice.org/24.8/en-US/text/scalc/01/02120100.html

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160997] after the last update can´t open files

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160997

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org
 OS|All |Windows (All)
   Hardware|x86 (IA32)  |x86-64 (AMD64)

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
- Which version did you update from?
- How did you update?
- Do you get a crash report dialog after the crash? If so, could you please
share a link to a crash report?
- Can you please test the recently released 24.2.3?

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 104444] [META] DOCX (OOXML) table-related issues

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=10

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||161001


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161001
[Bug 161001] DOCX nested table popped out of surrounding table
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161001] DOCX nested table popped out of surrounding table

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161001

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Blocks||10
 Ever confirmed|0   |1
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||9453
 OS|Linux (All) |All
Version|7.0 all versions|7.6.6.3 release
  Component|LibreOffice |filters and storage
 CC||stephane.guillou@libreoffic
   ||e.org,
   ||vmik...@collabora.com
 Status|UNCONFIRMED |NEW
Summary|Word to PDF, move table |DOCX nested table popped
   |content up  |out of surrounding table
   Keywords||bibisected, bisected,
   ||filter:docx, regression
  Regression By||Miklos Vajna

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Thanks for the report!

I can reproduce at fileopen in a recent daily build:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92815f3a464b447898ecf52492247335228e4a72
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

...and 7.6.6, but not in 7.5.9 -> regression.

Also on Windows 11.

Bibisected with linux-64-7.6 repo to first bad build
[1235fa4aa4d7ffa258bdffae06299ef14ce19016] which points to
f1307f09e60e715877769e9fa12c0a6313fa0c1a which is a cherrypick of:

commit  f74a6ef94ac957e4c146fc9923d30ce6bd31b5ce
author  Miklos VajnaTue Feb 13 08:09:23 2024 +0100
committer   Miklos VajnaTue Feb 13 10:00:30 2024 +0100
tdf#159453 sw floattable: fix unexpected overlap of in-header fly and body text
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163290

Miklos, can you please have a look?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=10
[Bug 10] [META] DOCX (OOXML) table-related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154059] Toolbar's icons don't show its enable/disable status in vcl:gen

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154059

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #15 from Dieter  ---
Roman, it seems, that nobody could confirm the bug for more than one year. Is
it still present for you in actual version LO  24.2.3?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154790] Copy and paste alter all Heading paragraph styles throughout the remainder of the document

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154790

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #8 from Dieter  ---
Dale, followinf discussion at ask.libreoffice your problem might be a duplicate
of bug 151974, that has been resolved meanwhile. So could you please retest
with actual version of LO? Thank you.
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 153830] Severe performance loss under the KDE environment (kf5 + cairo)

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153830

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 CC||dgp-m...@gmx.de

--- Comment #7 from Dieter  ---
Adrlopgal, nobody could confirm the bug for more than one year. So could you
please test, if it is still reproducible for you in actual version LO 24.2.3?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154686] "Apply border and shadow" option should be removed from AutoCaption dialog

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154686

Dieter  changed:

   What|Removed |Added

 CC||dgp-m...@gmx.de

--- Comment #4 from Dieter  ---
(In reply to Heiko Tietze from comment #3)
> The participants decided to dig into the issue and find out what exactly the
> option is good for and how to use it before hiding it.

Any results after more than one year?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161000] Form controls (anchored to page) misplaced (shifted down) in XLSX file

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161000

--- Comment #4 from Stéphane Guillou (stragu) 
 ---
Created attachment 194044
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194044=edit
comparison LO 24.8alpha0+ (left) and MS 365 (right)

Comparison between LO and MS 365. Note the shift down for all checkboxes.
Position setting in MS 365 is "move but don't size with cells".
In LO, controls are anchored to page.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 133999] [META] XLSX (OOXML) Form Controls related issues

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=133999

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on||161000


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=161000
[Bug 161000] Form controls (anchored to page) misplaced (shifted down) in XLSX
file
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161000] Form controls (anchored to page) misplaced (shifted down) in XLSX file

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161000

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
 Blocks||133999
Summary|When Excel file to PDF, |Form controls (anchored to
   |form fields are misplaced.  |page) misplaced (shifted
   ||down) in XLSX file
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW
  Component|LibreOffice |filters and storage
Version|7.2.0.1 rc  |4.0.0.3 release
 OS|Linux (All) |All
   Keywords||filter:xlsx

--- Comment #3 from Stéphane Guillou (stragu) 
 ---
Reproduced that the checkboxes are shifted down compared to the file opened in
Excel. (No need to export to PDF to see the issue.)

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92815f3a464b447898ecf52492247335228e4a72
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Same on Windows 11.

Already the case in LO 4.0.0.3.


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=133999
[Bug 133999] [META] XLSX (OOXML) Form Controls related issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157678] LibreOffice very low frame rate on second screen

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157678

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160811] Bullet levels are not handled properly in converted pptx presentation

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160811

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160801] Writer crash when use clear formatting after insert page break

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160801

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160802] Unable to enter non-ASCII character when recording changes

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160802

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160807] LibreOffice Writer "Enter Password" dialog is not horizontally centered; it's too far to the right

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160807

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160809] Inserted blank page has page border of subsequent (non-blank, styled) page

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160809

QA Administrators  changed:

   What|Removed |Added

 Whiteboard|| QA:needsComment

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157678] LibreOffice very low frame rate on second screen

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157678

--- Comment #3 from QA Administrators  ---
Dear thibaud88501,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157676] Shift Enter

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157676

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157673] Library Office Writer crashes.

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157673

--- Comment #3 from QA Administrators  ---
Dear pand,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157676] Shift Enter

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157676

--- Comment #3 from QA Administrators  ---
Dear FG,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157673] Library Office Writer crashes.

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157673

QA Administrators  changed:

   What|Removed |Added

 Resolution|--- |INSUFFICIENTDATA
 Status|NEEDINFO|RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158109] FILESAVE: Exporting to PDF

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158109

--- Comment #5 from QA Administrators  ---
Dear Joel Hilsenrath,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 146989] Crash when opening Printer Settings ("EXCEPTION_ACCESS_VIOLATION_READ" in ssp2mu.dll)

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=146989

--- Comment #6 from QA Administrators  ---
Dear muesliflyer,

This bug has been in NEEDINFO status with no change for at least
6 months. Please provide the requested information as soon as
possible and mark the bug as UNCONFIRMED. Due to regular bug
tracker maintenance, if the bug is still in NEEDINFO status with
no change in 30 days the QA team will close the bug as INSUFFICIENTDATA
due to lack of needed information.

For more information about our NEEDINFO policy please read the
wiki located here:
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

If you have already provided the requested information, please
mark the bug as UNCONFIRMED so that the QA team knows that the
bug is ready to be confirmed.

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-NeedInfo-Ping

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 89703] Writer loses outline numbering after HTML file save

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89703

--- Comment #12 from QA Administrators  ---
Dear Brian Piccioni,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55058] EMF+ List of EMF import bugs with examples

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=55058

--- Comment #70 from QA Administrators  ---
Dear mathog,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 147669] Calc - MATCH gives wrong result with an inline array

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147669

--- Comment #3 from QA Administrators  ---
Dear David Lynch,

To make sure we're focusing on the bugs that affect our users today,
LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed
bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this
bug report. During that time, it's possible that the bug has been fixed, or the
details of the problem have changed. We'd really appreciate your help in
getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice
from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information
from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to
RESOLVED-WORKSFORME and leave a comment that includes the information from Help
- About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular
meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a
REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your
bug pertains to a feature added after 3.3) from
https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat:
https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107184] Furigana (ruby) character selection system very clunky, produces unexpected/unpreventable/undesired output

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107184

--- Comment #11 from Seán Ó Séaghdha  ---
While the info on Latex is interesting, it’s not really useful for a GUI
program like LO.  What happens when the delimiter is part of the text?

The simplest solution would be for LO to do NO second-guessing about what is a
word or what isn’t a word.  You can’t know all possible user contexts.  The
selection should be accepted as a word or sequence that you want to add one set
of ruby text to.

As it is, the dialogue is very useful if you’re adding phonetics to continuous
text in a language that uses spaces (or maybe where the syllable is
predictable), but this feature is most used for Japanese where it’s used more
for the occasional unusual or lesser-know pronunciation, not for long stretches
of text.

The educational use for Chinese might still do that though.

Maybe it actually needs two modes?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161001] Word to PDF, move table content up

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161001

nengxing_xu  changed:

   What|Removed |Added

 OS|All |Linux (All)
   Hardware|All |x86-64 (AMD64)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161001] Word to PDF, move table content up

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161001

--- Comment #2 from nengxing_xu  ---
Created attachment 194043
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194043=edit
source word file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160999] Find sidebar results presented with huge gratuitous spaces

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160999

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 CC||stephane.guillou@libreoffic
   ||e.org

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Reproduced in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92815f3a464b447898ecf52492247335228e4a72
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161001] Word to PDF, move table content up

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161001

--- Comment #1 from nengxing_xu  ---
Created attachment 194042
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194042=edit
Image show error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161001] New: Word to PDF, move table content up

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161001

Bug ID: 161001
   Summary: Word to PDF, move table content up
   Product: LibreOffice
   Version: 7.0 all versions
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nengxing...@foxitsoftware.com

Description:
Word to PDF, move table content up

Actual Results:
Word to PDF, move table content up

Expected Results:
Word to PDF conversion, table content correct


Reproducible: Always


User Profile Reset: Yes

Additional Info:
No more information

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160994] when opened file, all the colors (including for fonts) and shapes have disappeared

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160994

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

Summary|: when opened file, all the |when opened file, all the
   |colors (including for   |colors (including for
   |fonts) and shapes have  |fonts) and shapes have
   |disappeared |disappeared
 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Stéphane Guillou (stragu) 
 ---
Have you inadvertently turned on one of the options in "View >
Color/Grayscale"? The default should be "Color".
If that's not the issue, please share a screenshot of what it looks like.
Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160994] : when opened file, all the colors (including for fonts) and shapes have disappeared

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160994

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 CC||stephane.guillou@libreoffic
   ||e.org
 Resolution|INVALID |---

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160816] Can't paste text copied from PDFs

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160816

--- Comment #4 from Steve271  ---
Not Reproducible with either:

Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

or

Version: 7.3.7.2 / LibreOffice Community
Build ID: 30(Build:2)
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.4
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160994] : when opened file, all the colors (including for fonts) and shapes have disappeared

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160994

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Stéphane Guillou (stragu) 
 ---
already reported by Peter in bug 160994, marking as invalid.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161000] When Excel file to PDF, form fields are misplaced.

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161000

--- Comment #2 from nengxing_xu  ---
Created attachment 194041
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194041=edit
image show error

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161000] When Excel file to PDF, form fields are misplaced.

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161000

--- Comment #1 from nengxing_xu  ---
Created attachment 194040
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194040=edit
source excle file

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 161000] New: When Excel file to PDF, form fields are misplaced.

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=161000

Bug ID: 161000
   Summary: When Excel file to PDF,  form fields are misplaced.
   Product: LibreOffice
   Version: 7.2.0.1 rc
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: nengxing...@foxitsoftware.com

Description:
After converting the Excel file to PDF, the form fields are misplaced.

Actual Results:
After converting the Excel file to PDF, the form fields are misplaced.

Expected Results:
After converting the Excel file to PDF, the form fields Need the correct


Reproducible: Always


User Profile Reset: No

Additional Info:
No more information

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156365] Trails in typing cursor

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156365

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
(In reply to bintoro from comment #8) 
> I'm seeing this in LO 7.6.2.1 on an Intel Mac with Skia enabled. No need for
> dark mode or bidirectional text.
Can you please share the full version info copied from LibreOffice > About? If
you use "Skia/Metal", I think you are seeing bug 153306, which should be fixed
in 24.2.3. Please test that version and report back if you can still see the
issue.

@Hossein: given that this report is originally about Skia/Vulkan, I think we
should close as duplicate of bug 155320.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 153306] Cursor leftovers keep being displayed when using Skia Metal

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=153306

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||8886

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 158886] Drag-and-drop selection of text with the mouse no longer shows highlight, or leaves a trail of highlight and cursors (macOS)

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=158886

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=15
   ||3306
 Status|NEW |NEEDINFO

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
The very similar bug 153306 (for Skia/Vulkan) is fixed in 24.2.3. mmclean,
please test 24.2.3 and report back if the issue is resolved for you too, in
which case we could mark as a duplicate (although earliest version affected
does not match).
(I don't have the same macOS installation as I had in comment 1 so can't test
again reliably.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107184] Furigana (ruby) character selection system very clunky, produces unexpected/unpreventable/undesired output

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107184

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||sean.an...@gmail.com

--- Comment #10 from Stéphane Guillou (stragu) 
 ---
*** Bug 154724 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154724] Ruby splits word with no user control

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154724

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #7 from Stéphane Guillou (stragu) 
 ---
Proposed solution in bug 107184 could fit all scripts/languages. I think topic
is close enough to close as duplicate and consolidate.
Seán, can you please comment there with what your preferred solution would look
like?

*** This bug has been marked as a duplicate of bug 107184 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107184] Furigana (ruby) character selection system very clunky, produces unexpected/unpreventable/undesired output

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107184

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 CC||stephane.guillou@libreoffic
   ||e.org
URL||https://ask.libreoffice.org
   ||/t/asiatic-phonetic-guide-f
   ||eature-request/96084

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 50607] [META] Asian Phonetic Guide ( Ruby ) issues

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=50607

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Depends on|157366  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=157366
[Bug 157366] Asian phonetic guide:  make it easy to see which kana belong to
which kanji
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 107184] Furigana (ruby) character selection system very clunky, produces unexpected/unpreventable/undesired output

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=107184

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=15 |
   |7366|
 CC||ben.engb...@be-logical.nl

--- Comment #9 from Stéphane Guillou (stragu) 
 ---
*** Bug 157366 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 157366] Asian phonetic guide: make it easy to see which kana belong to which kanji

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=157366

Stéphane Guillou (stragu)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Blocks|50607   |
 Resolution|--- |DUPLICATE
   See Also|https://bugs.documentfounda |
   |tion.org/show_bug.cgi?id=10 |
   |7184|

--- Comment #5 from Stéphane Guillou (stragu) 
 ---
(In reply to ben.engb...@be-logical.nl from comment #3)
> Apart from my suggestion (introduce a switch between the ´default' view and
> the 'splitted' view, I have nothing new to add to Bug 107184
Thank you Ben! Feel free to comment there too if something is missing.

*** This bug has been marked as a duplicate of bug 107184 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=50607
[Bug 50607] [META] Asian Phonetic Guide ( Ruby ) issues
-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: helpcontent2

2024-05-08 Thread Stanislav Horacek (via logerrit)
 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad1f0bdeac30fca1dc56a08803ef23f2aca4db05
Author: Stanislav Horacek 
AuthorDate: Thu May 9 01:52:46 2024 +0200
Commit: Gerrit Code Review 
CommitDate: Thu May 9 01:52:46 2024 +0200

Update git submodules

* Update helpcontent2 from branch 'master'
  to 761a64f3ca3e8f66c711bcadaa8c5ced105a99cd
  - fix row/column type of labels in description of their recognizing

Change-Id: I4b9dcd95b432aea717eeb017fc94fa02a3bc84d5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167247
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 3bc0152a9ce7..761a64f3ca3e 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 3bc0152a9ce77d7ac1c27331cc176cd80af96692
+Subproject commit 761a64f3ca3e8f66c711bcadaa8c5ced105a99cd


help.git: source/text

2024-05-08 Thread Stanislav Horacek (via logerrit)
 source/text/scalc/guide/address_auto.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 761a64f3ca3e8f66c711bcadaa8c5ced105a99cd
Author: Stanislav Horacek 
AuthorDate: Mon May 6 20:22:17 2024 +0200
Commit: Olivier Hallot 
CommitDate: Thu May 9 01:52:46 2024 +0200

fix row/column type of labels in description of their recognizing

Change-Id: I4b9dcd95b432aea717eeb017fc94fa02a3bc84d5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/167247
Tested-by: Jenkins
Reviewed-by: Olivier Hallot 

diff --git a/source/text/scalc/guide/address_auto.xhp 
b/source/text/scalc/guide/address_auto.xhp
index f14b44d2f8..c946f723f0 100644
--- a/source/text/scalc/guide/address_auto.xhp
+++ b/source/text/scalc/guide/address_auto.xhp
@@ -43,7 +43,7 @@
 
 Recognizing Names as 
Addressing
 You can use cells with text to 
refer to the rows or to the columns that contain the 
cells.removed table as a workaround for issue 
108715
-If the resulting cell is 
below or above another cell containing text, %PRODUCTNAME Calc assumes the text 
as a row label, else %PRODUCTNAME Calc assumes the text as a column 
label.
+If the resulting cell is 
below or above another cell containing text, %PRODUCTNAME Calc assumes the text 
as a column label, else %PRODUCTNAME Calc assumes the text as a row 
label.
 Example 
spreadsheet
 In the example spreadsheet, you 
can use the string 'Column One' in a formula to 
refer to the cell range B3 to B5, or 'Column Two' for the 
cell range C2 to C5. 
You can also use 'Row One' for the cell range B3 to D3, or 'Row Two' for the cell range B4 to D4. The result of a 
formula that uses a cell name, for example, SUM('Column 
One'), is 600.
 Automatically finding labels is a legacy feature 
and deactivated by default as it can produce nondeterministic behavior 
depending on actual document content. To turn this function on, choose 
%PRODUCTNAME - 
PreferencesTools - 
Options - %PRODUCTNAME Calc - 
Calculate and mark the Automatically find column and row 
labels check box.


[Bug 160644] Upon opening, LibreOffice sometimes crashes (perhaps once a week)

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160644

--- Comment #19 from Patrick Luby (volunteer)  ---
I have a new guess as to what might be causing the system crashes: one or more
clipboard history applications are using up most of system memory. After fixing
tdf#160855, we now know that one or more clipboard history applications are
pasting immediately after copying in Calc and, if you frequently select and
copy hundreds of thousands of cells, the data formats that Calc sends to the
system clipboard get very large. See my following comment for more background
info:

https://bugs.documentfoundation.org/show_bug.cgi?id=160855#c26

To test this, would it be possible for you to run the Activity Monitor
application in the background but this time with the search field empty? This
will display all applications running on your machine. Set the Memory column to
sort highest to lowest like shown in attachment #194039.

Then, launch LibreOffice and select 10+ cells and copy. Repeat this with
different cell ranges at least 10 times, get a screen snapshot of the Activity
Monitor window, and attach it to this bug? If 10 times causes a system crash,
retry but only half the number of times.

If one or more clipboard history applications have the highest memory usage, we
can check if those applications let you lower the maximum history size.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160644] Upon opening, LibreOffice sometimes crashes (perhaps once a week)

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160644

--- Comment #18 from Patrick Luby (volunteer)  ---
Created attachment 194039
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194039=edit
Acitivity Monitor with all applications sorted by memory usage

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160983] RecalcOptimalRowHeightMode should be effective for CSV imports also

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160983

--- Comment #2 from Craig Ruff  ---
Not sure why you are asking how to, when I import some CVS files with wide text
columns or text columns that include new line characters, Calc first imports
the CSV files then spends time "adjusting the row heights" according to the
status message at the bottom of the window. The some rows of the CVS files end
up being marked as 39.37" high, and scrolling in Calc is brain damaged such
that you get large jumps and can't review them at all. Since there is no
inherent height information in the CSV file, Calc is the one actor performing
this behavior. It seems readily analogous to that being done when reading an
ODF or XLS file.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 156365] Trails in typing cursor

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=156365

Hossein  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Summary|Trails in typing cursor |Trails in typing cursor
   |(dark mode) |
 Status|UNCONFIRMED |NEW
 OS|Windows (All)   |All

--- Comment #9 from Hossein  ---
Setting the status to "NEW" as per comment 8. The trails are better visible in
dark mode, but I have removed the word "dark" from the title as per discussion
in the above mentioned commit.

@bintoro:
Could you please test with the latest version to see if you still can reproduce
it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160497] FR: Print (or export) only tracked changes

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160497

--- Comment #4 from Eyal Rozenberg  ---
I support this feature request, or rather: I support the ability to export the
list of tracked changes.

(In reply to Heiko Tietze from comment #3)
> printing sounds very niche (and we have the responsibility of
> conservation)

Disagree. If it is not niche to go over the tracked changes (e.g. in a
sidebar), it is not niche to export/print them.

Export could be:

* to a Writer document with the changes in sequence - in styled paragraphs.
* to a Calc table (not a CSV table, since we need the formatting), maybe.

and the export could be either into a file or into a new document. The file can
then be printed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160497] FR: Print (or export) only tracked changes

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160497

--- Comment #4 from Eyal Rozenberg  ---
I support this feature request, or rather: I support the ability to export the
list of tracked changes.

(In reply to Heiko Tietze from comment #3)
> printing sounds very niche (and we have the responsibility of
> conservation)

Disagree. If it is not niche to go over the tracked changes (e.g. in a
sidebar), it is not niche to export/print them.

Export could be:

* to a Writer document with the changes in sequence - in styled paragraphs.
* to a Calc table (not a CSV table, since we need the formatting), maybe.

and the export could be either into a file or into a new document. The file can
then be printed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160999] Find sidebar results presented with huge gratuitous spaces

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160999

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||95405


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=95405
[Bug 95405] Sidebar deck for find/search and replace
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160999] Find sidebar results presented with huge gratuitous spaces

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160999

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 194038
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194038=edit
Spaced-out results of search in document from attachment 194036

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160998] Quick find shows junk/placeholder glyphs instead of the matching line text

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160998

--- Comment #1 from Eyal Rozenberg  ---
Created attachment 194037
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194037=edit
Search results for קורה in find sidebar, in attachment 194035

Note that the search results also exhibit bug 160998, but that one can be
reproduced much more easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: sd/source

2024-05-08 Thread Gabor Kelemen (via logerrit)
 sd/source/ui/view/frmview.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 5ce5ffe817479faecf7889d0024e91c8a2ad6a2c
Author: Gabor Kelemen 
AuthorDate: Wed Apr 24 09:08:37 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Thu May 9 00:31:09 2024 +0200

Use less SdOptionsLayout->IsHandlesBezier in favor of officecfg

Change-Id: Id2f005413f255b4a0f0e0cd240cb8700c27ee204
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166598
Reviewed-by: Thorsten Behrens 
Tested-by: Jenkins

diff --git a/sd/source/ui/view/frmview.cxx b/sd/source/ui/view/frmview.cxx
index 1fa0c4eba45d..250a088bffb1 100644
--- a/sd/source/ui/view/frmview.cxx
+++ b/sd/source/ui/view/frmview.cxx
@@ -289,12 +289,14 @@ void FrameView::Update(SdOptions const * pOptions)
 mbRuler = officecfg::Office::Impress::Layout::Display::Ruler::get();
 SetDragStripes( 
officecfg::Office::Impress::Layout::Display::Guide::get() );
 SetNoDragXorPolys ( 
!officecfg::Office::Impress::Layout::Display::Contour::get() );
+SetPlusHandlesAlwaysVisible( 
officecfg::Office::Impress::Layout::Display::Bezier::get() );
 }
 else
 {
 mbRuler = officecfg::Office::Draw::Layout::Display::Ruler::get();
 SetDragStripes( officecfg::Office::Draw::Layout::Display::Guide::get() 
);
 SetNoDragXorPolys ( 
!officecfg::Office::Draw::Layout::Display::Contour::get() );
+SetPlusHandlesAlwaysVisible( 
officecfg::Office::Draw::Layout::Display::Bezier::get() );
 }
 
 SetGridVisible( pOptions->IsGridVisible() );
@@ -305,7 +307,6 @@ void FrameView::Update(SdOptions const * pOptions)
 SetOFrmSnap( pOptions->IsSnapFrame() );
 SetOPntSnap( pOptions->IsSnapPoints() );
 SetHlplVisible( pOptions->IsHelplines() );
-SetPlusHandlesAlwaysVisible( pOptions->IsHandlesBezier() );
 SetSnapMagneticPixel( pOptions->GetSnapArea() );
 SetMarkedHitMovesAlways( pOptions->IsMarkedHitMovesAlways() );
 SetMoveOnlyDragging( pOptions->IsMoveOnlyDragging() );


core.git: sd/source

2024-05-08 Thread Gabor Kelemen (via logerrit)
 sd/source/core/drawdoc.cxx  |   14 +++-
 sd/source/ui/app/sdmod.cxx  |   12 ---
 sd/source/ui/app/sdmod1.cxx |   36 -
 sd/source/ui/app/sdmod2.cxx |   48 +---
 4 files changed, 88 insertions(+), 22 deletions(-)

New commits:
commit 055e7d866680390dca6e18864ca4297cc0ebda84
Author: Gabor Kelemen 
AuthorDate: Tue Apr 23 20:04:43 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Thu May 9 00:30:52 2024 +0200

Use less SdOptionsLayout->GetMetric/SetMetric in favor of officecfg

Change-Id: I12c9f69e0db1bf3e726b7d642e9a6855b031d3b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166597
Reviewed-by: Thorsten Behrens 
Tested-by: Jenkins

diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 5def1937684d..b759f9b4e883 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -36,6 +36,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 #include 
@@ -53,6 +54,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -156,12 +159,19 @@ SdDrawDocument::SdDrawDocument(DocumentType eType, 
SfxObjectShell* pDrDocSh)
 sal_Int32 nX, nY;
 SdOptions* pOptions = SD_MOD()->GetSdOptions(meDocType);
 pOptions->GetScale( nX, nY );
+SvtSysLocale aSysLocale;
 
 // Allow UI scale only for draw documents.
 if( eType == DocumentType::Draw )
-SetUIUnit( static_cast(pOptions->GetMetric()), Fraction( 
nX, nY ) );  // user-defined
+if (aSysLocale.GetLocaleData().getMeasurementSystemEnum() == 
MeasurementSystem::Metric)
+SetUIUnit( 
static_cast(officecfg::Office::Draw::Layout::Other::MeasureUnit::Metric::get()),
 Fraction( nX, nY ) );  // user-defined
+else
+SetUIUnit( 
static_cast(officecfg::Office::Draw::Layout::Other::MeasureUnit::NonMetric::get()),
 Fraction( nX, nY ) );  // user-defined
 else
-SetUIUnit( static_cast(pOptions->GetMetric()), Fraction( 1, 
1 ) );// default
+if (aSysLocale.GetLocaleData().getMeasurementSystemEnum() == 
MeasurementSystem::Metric)
+SetUIUnit( 
static_cast(officecfg::Office::Impress::Layout::Other::MeasureUnit::Metric::get()),
 Fraction( 1, 1 ) );// default
+else
+SetUIUnit( 
static_cast(officecfg::Office::Impress::Layout::Other::MeasureUnit::NonMetric::get()),
 Fraction( 1, 1 ) );// default
 
 SetScaleUnit(MapUnit::Map100thMM);
 SetDefaultFontHeight(o3tl::convert(24, o3tl::Length::pt, 
o3tl::Length::mm100));
diff --git a/sd/source/ui/app/sdmod.cxx b/sd/source/ui/app/sdmod.cxx
index f18dd647a209..d534fe51aa23 100644
--- a/sd/source/ui/app/sdmod.cxx
+++ b/sd/source/ui/app/sdmod.cxx
@@ -141,18 +141,6 @@ SdOptions* SdModule::GetSdOptions(DocumentType eDocType)
 
 pOptions = pImpressOptions;
 }
-if( pOptions )
-{
-sal_uInt16 nMetric = pOptions->GetMetric();
-
-::sd::DrawDocShell* pDocSh = dynamic_cast< ::sd::DrawDocShell *>( 
SfxObjectShell::Current() );
-SdDrawDocument* pDoc = nullptr;
-if (pDocSh)
-pDoc = pDocSh->GetDoc();
-
-if( nMetric != 0x && pDoc && eDocType == pDoc->GetDocumentType() )
-PutItem( SfxUInt16Item( SID_ATTR_METRIC, nMetric ) );
-}
 
 return pOptions;
 }
diff --git a/sd/source/ui/app/sdmod1.cxx b/sd/source/ui/app/sdmod1.cxx
index 14f507fb1a1d..023e44a7c1e6 100644
--- a/sd/source/ui/app/sdmod1.cxx
+++ b/sd/source/ui/app/sdmod1.cxx
@@ -21,7 +21,9 @@
 #include 
 #include 
 #include 
+#include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -53,6 +55,9 @@
 #include 
 #include 
 
+#include 
+#include 
+
 using ::sd::framework::FrameworkHelper;
 using ::com::sun::star::uno::Reference;
 using ::com::sun::star::frame::XFrame;
@@ -126,9 +131,21 @@ void SdModule::Execute(SfxRequest& rReq)
 DocumentType eDocType = 
pDocSh->GetDoc()->GetDocumentType();
 
 PutItem( *pItem );
-SdOptions* pOptions = GetSdOptions( eDocType );
-if(pOptions)
-pOptions->SetMetric( 
static_cast(eUnit) );
+SvtSysLocale aSysLocale;
+
std::shared_ptr batch(
+
comphelper::ConfigurationChanges::create());
+
+if (eDocType == DocumentType::Impress)
+if 
(aSysLocale.GetLocaleData().getMeasurementSystemEnum() == 
MeasurementSystem::Metric)
+
officecfg::Office::Impress::Layout::Other::MeasureUnit::Metric::set(static_cast(eUnit),
 batch);
+else
+

[Bug 160999] New: Find sidebar results presented with huge gratuitous spaces

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160999

Bug ID: 160999
   Summary: Find sidebar results presented with huge gratuitous
spaces
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Created attachment 194036
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194036=edit
Document in which searching triggers the bug

Consider the attached document. 

If I:

1. Open the document in LO Writer
2. Open the Find sidebar
3. Search for the phrase "One"

I get several matches, as I should - but there's a huge amount of white-space
between each match, which is not at all useful for me.

Seen with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92815f3a464b447898ecf52492247335228e4a72
CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160998] Quick find shows junk/placeholder glyphs instead of the matching line text

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160998

Eyal Rozenberg  changed:

   What|Removed |Added

 Blocks||95405
 CC||eyalr...@gmx.com


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=95405
[Bug 95405] Sidebar deck for find/search and replace
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160998] New: Quick find shows junk/placeholder glyphs instead of the matching line text

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160998

Bug ID: 160998
   Summary: Quick find shows junk/placeholder glyphs instead of
the matching line text
   Product: LibreOffice
   Version: 24.8.0.0 alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: eyalr...@gmx.com

Created attachment 194035
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194035=edit
Document in which searching triggers the bug

Consider the attached document. That is a document in Hebrew, with a ToC. It
exhibits another issue (bug 148686), but that should not be relevant for our
purposes.

If I:

1. Open the document in LO Writer
2. Open the find toolbar
3. Search for קורה

I get several matches, as I should - but some of the match paragraphs contain
upright-rectangle glyphs instead of Hebrew text. I'll attach both the document
and a screenshot.

Seen with:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 92815f3a464b447898ecf52492247335228e4a72
CPU threads: 4; OS: Linux 6.6; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160544] Quickfind sidebar: Make the sidebar the default for ctrl+F

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160544

--- Comment #19 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #0)
> Follow-up to bug 95405: The sidebar is supposed to be an improvement to the
> classic toolbar. We should default the quicksearch to this control - and
> have the legacy toolbar as an alternative option. 

When we have a decent search sidebar, then let's talk about that. 

Fix some of its bugs (I'm going to file a couple after my first single use),
add some of the Find dialog functionality, etc... 

So, for now, definite no-no from me.

Even in principle I'm not sure I would support this, because the sidebar takes
a huge chunk of your viewport away, while the find bar is just a vertical bar,
and at the bottom where it's less noticeable than a top toolbar.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160544] Quickfind sidebar: Make the sidebar the default for ctrl+F

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160544

--- Comment #19 from Eyal Rozenberg  ---
(In reply to Heiko Tietze from comment #0)
> Follow-up to bug 95405: The sidebar is supposed to be an improvement to the
> classic toolbar. We should default the quicksearch to this control - and
> have the legacy toolbar as an alternative option. 

When we have a decent search sidebar, then let's talk about that. 

Fix some of its bugs (I'm going to file a couple after my first single use),
add some of the Find dialog functionality, etc... 

So, for now, definite no-no from me.

Even in principle I'm not sure I would support this, because the sidebar takes
a huge chunk of your viewport away, while the find bar is just a vertical bar,
and at the bottom where it's less noticeable than a top toolbar.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

--- Comment #6 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #2)
> As a cumbersome workaround:
> 1. Hide columns/rows
> 2. Define a single print range
> 3. Print

Is that really so cumbersome?

Also, other alternatives:

* Copy the two ranges to a new sheet

or

* link to the ranges from a new sheet (i.e. use =OldSheet!B11 , or wherever the
range starts, then drag to copy with the rows and columns to get the full
range; and elsewhere on the same page repeat the same for the second range

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

--- Comment #6 from Eyal Rozenberg  ---
(In reply to Stéphane Guillou (stragu) from comment #2)
> As a cumbersome workaround:
> 1. Hide columns/rows
> 2. Define a single print range
> 3. Print

Is that really so cumbersome?

Also, other alternatives:

* Copy the two ranges to a new sheet

or

* link to the ranges from a new sheet (i.e. use =OldSheet!B11 , or wherever the
range starts, then drag to copy with the rows and columns to get the full
range; and elsewhere on the same page repeat the same for the second range

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160983] RecalcOptimalRowHeightMode should be effective for CSV imports also

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160983

m_a_riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #1 from m_a_riosv  ---
How to?, CSV is imported as unformatted text, what it is.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160997] New: after the last update can´t open files

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160997

Bug ID: 160997
   Summary: after the last update can´t open files
   Product: LibreOffice
   Version: 24.2.1.2 release
  Hardware: x86 (IA32)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: susanbf...@web.de

Description:
after the last update, Libre Office does not open any files and crashes every
time I start it

Steps to Reproduce:
1.select file
2.file does not open
3.Libre Office crashes. Period

Actual Results:
The program crashes. Every single time

Expected Results:
the file opens and I can work on it


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Version: 24.2.2.2 (X86_64) / LibreOffice Community
Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 154724] Ruby splits word with no user control

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=154724

Dieter  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||dgp-m...@gmx.de
 Ever confirmed|0   |1

--- Comment #6 from Dieter  ---
Sean, can you still reproduce the bug in an actual version of LO (24.2.3 or
actual master)?
=> NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 120200] [META] Update or correct help for features

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=120200

Olivier Hallot  changed:

   What|Removed |Added

 Depends on|147847  |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147847
[Bug 147847] Document PDF/A-1a output possibility
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 147847] Document PDF/A-1a output possibility

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147847

Olivier Hallot  changed:

   What|Removed |Added

 Blocks|120200  |103378


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103378
[Bug 103378] [META] PDF export bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=120200
[Bug 120200] [META] Update or correct help for features
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 103378] [META] PDF export bugs and enhancements

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=103378

Olivier Hallot  changed:

   What|Removed |Added

 Depends on||147847


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=147847
[Bug 147847] Document PDF/A-1a output possibility
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 147847] Document PDF/A-1a output possibility

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=147847

Olivier Hallot  changed:

   What|Removed |Added

  Component|Documentation   |Printing and PDF export

--- Comment #2 from Olivier Hallot  ---
The bug description indicates that exporting to PDF/A-1b produces PDF/A-1a.

This is a bug in PDF export. There is no point in producing end user
documentation of a bug that should be fixed.

Resetting component.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160926] Duplicate push buttons appearing

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160926

--- Comment #27 from NOYB  ---
Created attachment 194034
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194034=edit
with column freeze

Some more observations.

The twin button appears the same distance below the row freeze as the original
distance from top of sheet.

Happens also with column freeze, but depending on positioning may be hidden.

See attached screen image capture.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160926] Duplicate push buttons appearing

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160926

--- Comment #26 from NOYB  ---
Created attachment 194033
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194033=edit
repetitive variation with only one sheet

I can also reproduce issue with nutka's method and this repetitive variation
with only one sheet.  See attached screen recording video.

1. Open document.
2. Freeze a rows below where push button will be placed.
3. Enter Design Mode.

4. Insert push button above row freeze.
5. Exit Design Mode.
6. Twin button appears.

7. Enter Design Mode.
8. Delete push button

Repeat steps 4 - 8

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160769] LibreOffice 24.2 Document recovery (from timed autoSave) doesn't restore all open files after crash

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160769

bikehel...@gmail.com changed:

   What|Removed |Added

 Resolution|NOTABUG |---
 Ever confirmed|0   |1
 Status|RESOLVED|REOPENED

--- Comment #6 from bikehel...@gmail.com ---
(In reply to Justin L from comment #4)
> Quoting from bug 57414 comment 22:
> 
> There are three types of Recovery. One is emergencySave (an exception in the
> program triggers a save-and-restart), another is SessionSave (when the OS
> shuts down), and the third is a timed autoRecovery.
> 
> In the case of EmergencySave and SessionSave, the intent is to recover the
> working environment, so ALL documents are attempted to be recovered.
> 
> In the most general case (the timed autoRecovery) the patches only try to
> recover modified documents that have a recovery file.
> 
> 
> So, I tend to agree with Mike in comment 1 and the request to specifically
> do it this way in bug 148438. In response to OP, I'd say that recent
> documents exists to find those documents easily, so I don't see how
> re-opening documents manually could be a problem.
> 
> In general, it is not a good idea to have lots of documents open, so having
> LO "recover" the entire last environment would not be smart and encourage
> bad behaviour. In this case LO itself has no idea why it is restarting, so
> it is best to just recover modified-but-not-saved files.

That suggests that there is a bug here? If emergencySave is supposed to recover
everything, and after a crash it doesn't, then clearly it crashed in such a way
that it did not have a chance to do so, and is depending upon the timed
autoRecovery instead? So there's a bug, just not the one from the original
post. It still seems like it would be more prudent to give people the choice.
An overlapping layer of reliability.

The recent documents list is often not long enough, and organizes based on time
originally opened, not which documents were recently used. If your work
involves opening and closing a bunch of incoming documents or supplier sheets
throughout the day, but not working with them, and instead working within other
documents that are left opened longer - then it will not have useful files in
the list.

At the end of the day it's your choice as the developers/maintainers, but I
would encourage you to think of users that are in the business world and not in
the programming or home use world. It may be bad behaviour, but it's exactly
how many businesses work, like restaurants.

Another option if this is very unappealing, would be to create a "recently
saved" list - as this type of user has no use for recently opened documents,
and only cares about the ones that they are saving. The priority is completely
opposite to how Justin outlined. Work sheets and supplier pricing updates and
whatnot can just be redownloaded/reopened from email, but the documents opened
for a long time are actually the priority. Those ones are the ones that are
sometimes ignored by auto recovery and the recents list, depending on saving
behaviour and how long ago they were originally open.

Just food for thought, but I think they could be good changes to broaden the
appeal to different types of users and use cases.

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: fpicker/source

2024-05-08 Thread Noel Grandin (via logerrit)
 fpicker/source/office/OfficeFilePicker.cxx   |   10 +--
 fpicker/source/office/OfficeFolderPicker.cxx |4 -
 fpicker/source/office/RemoteFilesDialog.cxx  |   70 ++---
 fpicker/source/office/breadcrumb.cxx |   16 ++--
 fpicker/source/office/commonpicker.cxx   |4 -
 fpicker/source/office/contentenumeration.cxx |   28 
 fpicker/source/office/fileview.cxx   |   18 ++---
 fpicker/source/office/fpsmartcontent.cxx |4 -
 fpicker/source/office/iodlg.cxx  |   88 +--
 fpicker/source/office/iodlgimp.cxx   |2 
 10 files changed, 122 insertions(+), 122 deletions(-)

New commits:
commit d9427b9f0c291bd24e5e5e53e3f415c724dad746
Author: Noel Grandin 
AuthorDate: Wed May 8 11:57:48 2024 +0200
Commit: Noel Grandin 
CommitDate: Wed May 8 21:23:12 2024 +0200

loplugin:ostr in fpicker

Change-Id: I891d31ae35419fb26d7070c8a9e3437b86e124d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167338
Reviewed-by: Noel Grandin 
Tested-by: Jenkins

diff --git a/fpicker/source/office/OfficeFilePicker.cxx 
b/fpicker/source/office/OfficeFilePicker.cxx
index c0ba40632a0c..e348789037e9 100644
--- a/fpicker/source/office/OfficeFilePicker.cxx
+++ b/fpicker/source/office/OfficeFilePicker.cxx
@@ -879,7 +879,7 @@ void SAL_CALL SvtFilePicker::appendFilterGroup( const 
OUString& sGroupTitle,
 // check the names
 if ( FilterNameExists( aFilters ) )
 throw IllegalArgumentException(
-"filter name exists",
+u"filter name exists"_ustr,
 getXWeak(), 1);
 
 // ensure that we have a filter list
@@ -1029,7 +1029,7 @@ bool SvtFilePicker::implHandleInitializationArgument( 
const OUString& _rName, co
 /* XServiceInfo */
 OUString SAL_CALL SvtFilePicker::getImplementationName()
 {
-return "com.sun.star.svtools.OfficeFilePicker";
+return u"com.sun.star.svtools.OfficeFilePicker"_ustr;
 }
 
 /* XServiceInfo */
@@ -1041,7 +1041,7 @@ sal_Bool SAL_CALL SvtFilePicker::supportsService( const 
OUString& sServiceName )
 /* XServiceInfo */
 Sequence< OUString > SAL_CALL SvtFilePicker::getSupportedServiceNames()
 {
-return { "com.sun.star.ui.dialogs.OfficeFilePicker" };
+return { u"com.sun.star.ui.dialogs.OfficeFilePicker"_ustr };
 }
 
 extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
@@ -1081,7 +1081,7 @@ std::shared_ptr 
SvtRemoteFilePicker::implCreateDialog(weld::
 /* XServiceInfo */
 OUString SAL_CALL SvtRemoteFilePicker::getImplementationName()
 {
-return "com.sun.star.svtools.RemoteFilePicker";
+return u"com.sun.star.svtools.RemoteFilePicker"_ustr;
 }
 
 /* XServiceInfo */
@@ -1093,7 +1093,7 @@ sal_Bool SAL_CALL SvtRemoteFilePicker::supportsService( 
const OUString& sService
 /* XServiceInfo */
 Sequence< OUString > SAL_CALL SvtRemoteFilePicker::getSupportedServiceNames()
 {
-return { "com.sun.star.ui.dialogs.RemoteFilePicker" };
+return { u"com.sun.star.ui.dialogs.RemoteFilePicker"_ustr };
 }
 
 
diff --git a/fpicker/source/office/OfficeFolderPicker.cxx 
b/fpicker/source/office/OfficeFolderPicker.cxx
index 779bbffda7ad..1c803e737820 100644
--- a/fpicker/source/office/OfficeFolderPicker.cxx
+++ b/fpicker/source/office/OfficeFolderPicker.cxx
@@ -149,7 +149,7 @@ void SvtFolderPicker::cancel()
 /* XServiceInfo */
 OUString SAL_CALL SvtFolderPicker::getImplementationName()
 {
-return "com.sun.star.svtools.OfficeFolderPicker";
+return u"com.sun.star.svtools.OfficeFolderPicker"_ustr;
 }
 
 /* XServiceInfo */
@@ -161,7 +161,7 @@ sal_Bool SAL_CALL SvtFolderPicker::supportsService( const 
OUString& sServiceName
 /* XServiceInfo */
 Sequence< OUString > SAL_CALL SvtFolderPicker::getSupportedServiceNames()
 {
-return { "com.sun.star.ui.dialogs.OfficeFolderPicker" };
+return { u"com.sun.star.ui.dialogs.OfficeFolderPicker"_ustr };
 }
 
 extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx 
b/fpicker/source/office/RemoteFilesDialog.cxx
index ad23cc0dd888..50c897f35b48 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -27,20 +27,20 @@
 using namespace ::svt;
 
 RemoteFilesDialog::RemoteFilesDialog( weld::Window* pParent, PickerFlags nBits 
)
-: SvtFileDialog_Base( pParent, "fps/ui/remotefilesdialog.ui", 
"RemoteFilesDialog" )
+: SvtFileDialog_Base( pParent, u"fps/ui/remotefilesdialog.ui"_ustr, 
u"RemoteFilesDialog"_ustr )
 , m_xContext( comphelper::getProcessComponentContext() )
 , m_xMasterPasswd( PasswordContainer::create( m_xContext ) )
 , m_bIsInExecute( false )
-, m_xOk_btn(m_xBuilder->weld_button("ok"))
-, m_xCancel_btn(m_xBuilder->weld_button("cancel"))
-, m_xManageServices(m_xBuilder->weld_menu_button("add_service_btn"))
-, m_xServices_lb(m_xBuilder->weld_combo_box("services_lb"))
-, m_xPathContainer(m_xBuilder->weld_container("breadcrumb_container"))
-, 

[Bug 160985] Save a copy CSV to XLSX

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160985

ady  changed:

   What|Removed |Added

 CC||xiscofa...@libreoffice.org

--- Comment #11 from ady  ---
(In reply to Andrey from comment #10)
> there were
> incorrect values in 5 cells that I didn't notice right away. LO QUIETLY
> changed the values. I think this is a major bug.

I would tend to agree that the issue is important, even though the regression
has been present for such a long time and it happens on XLSX but not on ODS
files.

Unfortunately, it has to be bisected (either in LO 5.0, or maybe even before LO
4.0 as I mentioned) before it can be fixed.


@Xisco?

-- 
You are receiving this mail because:
You are the assignee for the bug.

core.git: Branch 'feature/cib_contract49c' - 2 commits - officecfg/registry sd/Library_sd.mk sd/sdi sd/source

2024-05-08 Thread Sarper Akdemir (via logerrit)
 officecfg/registry/schema/org/openoffice/Office/Impress.xcs |   40 +
 sd/Library_sd.mk|1 
 sd/sdi/NotesPanelView.sdi   |   11 
 sd/source/ui/framework/module/ImpressModule.cxx |2 
 sd/source/ui/framework/module/ModuleController.cxx  |2 
 sd/source/ui/framework/module/NotesPaneModule.cxx   |  268 
 sd/source/ui/framework/module/NotesPaneModule.hxx   |   91 
 sd/source/ui/inc/framework/factories/BasicPaneFactory.hxx   |1 
 sd/source/ui/view/NotesPanelViewShell.cxx   |5 
 9 files changed, 405 insertions(+), 16 deletions(-)

New commits:
commit 8af78dc0de96daab6a23a21e152d5c91b93ee74c
Author: Sarper Akdemir 
AuthorDate: Wed May 8 17:36:01 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Wed May 8 20:55:44 2024 +0200

tdf#33603: do not block SID_SAVEDOC slots on NotesPanelViewShell

Change-Id: Icc7320b0960f0d73027359b7525a37b44bdd7ee7

diff --git a/sd/sdi/NotesPanelView.sdi b/sd/sdi/NotesPanelView.sdi
index 90217efaa4e8..b54addb52b8c 100644
--- a/sd/sdi/NotesPanelView.sdi
+++ b/sd/sdi/NotesPanelView.sdi
@@ -195,17 +195,6 @@ interface NotesPanelView
 ExecMethod = FuPermanent ;
 StateMethod = GetMenuState ;
 ]
-SID_SAVEDOC // ole : no, status : ?
-[
-ExecMethod = Execute ;
-StateMethod = GetMenuState ;
-GroupId = SfxGroupId::Document ;
-]
-SID_SAVEASDOC // ole : no, status : ?
-[
-ExecMethod = Execute ;
-GroupId = SfxGroupId::Document ;
-]
 SID_RULER // ole : no, status : ?
 [
 ExecMethod = FuSupport ;
diff --git a/sd/source/ui/view/NotesPanelViewShell.cxx 
b/sd/source/ui/view/NotesPanelViewShell.cxx
index 5b7bdcf6329f..7bc46a5464b6 100644
--- a/sd/source/ui/view/NotesPanelViewShell.cxx
+++ b/sd/source/ui/view/NotesPanelViewShell.cxx
@@ -1338,11 +1338,6 @@ void NotesPanelViewShell::Execute(SfxRequest& rReq)
 
 switch (rReq.GetSlot())
 {
-case SID_SAVEDOC:
-case SID_SAVEASDOC:
-PrepareClose();
-break;
-
 case SID_SEARCH_ITEM:
 // Forward this request to the common (old) code of the
 // document shell.
commit 537be0af79d95852eb66d7683908b683ce2b7f2f
Author: Sarper Akdemir 
AuthorDate: Wed May 8 14:14:58 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Wed May 8 20:54:36 2024 +0200

tdf#33603: sd: make state of notes pane persist across runs

Introduces new NotesPaneModule which manages the visibility
of NotesPane across modes and different runs.

Also introduces new three config values under
Office/Impress/MuliPaneGUI/NotesPane/Visible ImpressView,
OutlineView and NotesView.

Similar to what was there for SlideSorterBar.

Change-Id: Id540c508e81878e5a8e1aebd6544839e70b813c8

diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs 
b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
index 876780d1bd09..54fec3bd1989 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
@@ -1308,6 +1308,46 @@
   
 
   
+  
+
+  Values related to the slide sorter.
+  Notes Pane Options
+
+
+  
+Options that control the visibility of the slide 
sorter.
+Notes Pane Visibility
+  
+  
+
+  Visibility of the Notes Pane in the Impress view.
+  Notes Pane Visibility ImpressView
+
+false
+  
+   
+
+  Visibility of the Notes Pane in the Outline view.
+  Notes Pane Visibility OutlineView
+
+false
+  
+  
+
+  Visibility of the Notes Pane in the Notes view.
+  Notes Pane Visibility NotesView
+
+false
+  
+  
+
+  Visibility of the Notes Pane in the Handout view.
+  Notes Pane Visibility HandoutView
+
+false
+  
+
+  
   
 
   Values related to the slide sorter.
diff --git a/sd/Library_sd.mk b/sd/Library_sd.mk
index b633ee26f7d6..0cb001c98e31 100644
--- a/sd/Library_sd.mk
+++ b/sd/Library_sd.mk
@@ -279,6 +279,7 @@ $(eval $(call gb_Library_add_exception_objects,sd,\
sd/source/ui/framework/module/DrawModule \
sd/source/ui/framework/module/ImpressModule \
sd/source/ui/framework/module/ModuleController \
+   sd/source/ui/framework/module/NotesPaneModule \
sd/source/ui/framework/module/PresentationModule \
sd/source/ui/framework/module/ShellStackGuard \
sd/source/ui/framework/module/SlideSorterModule \
diff --git 

[Bug 160996] New: printing does not honour printer job options "automatic rotation" setting

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160996

Bug ID: 160996
   Summary: printing does not honour printer job options
"automatic rotation" setting
   Product: LibreOffice
   Version: 24.2.3.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: wrh...@live.co.uk

Created attachment 194032
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194032=edit
collection of screenshots showing the problem

This is important for my Brother QL-570 label printer. Labels are 29mm wide x
by 90mm tall and are on a roll which processes them in Portrait format. I want
to type in a page defined as 90mm wide and 29mm tall ie landscape format eg a
typical address.

Mr A Smith, Chief Executive
Some big corporation name
123 Main street
BIGTOWN
AB2 3CS

If I export this as a pdf I can print the pdf to my Brother QL0750 label
printer and specify for that print job the page should be automatically rotated
to fit in the printer label. That works fine.

There seems to be no way to do that in Libreoffice Writer.

Samples of the various screens attached.

Ubuntu

-- 
You are receiving this mail because:
You are the assignee for the bug.

Minutes from the UX/design meeting 2023-May-08

2024-05-08 Thread Heiko Tietze

Present:  Sahil, John, Hossein, Cor, Eyal, Heiko
Comments: Stuart, Stephane, Dieter

Tickets/Topics

 * Major design changes ongoing for "Better handling for multiline tabs
   + https://bugs.documentfoundation.org/show_bug.cgi?id=99528

 * List images in order of document appearance in Calc Navigator
   + https://bugs.documentfoundation.org/show_bug.cgi?id=160353
   + at least four different sort orders: row first, col first,
 alphabetically, by insertion time (Heiko)
   + limited use case (John)
   + Navigator lists objects from all sheets making the sort order
 problematic (John)
 + maybe reported somewhere; unclear if users accept when the
   Navigator restricts objects to the current sheet
   => keep with low priority

 * Icons for promote / demote outline level should be improved
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158932
   + clear depiction of the action (Stuart)
   + there are issues with RTL UI (Hossein)
 + dup at https://bugs.documentfoundation.org/show_bug.cgi?id=154523
 + see also https://bugs.documentfoundation.org/show_bug.cgi?id=70102
   => duplicate

 * Print multiple non-contiguous print ranges on a single page in
   LibreOffice Calc
   + https://bugs.documentfoundation.org/show_bug.cgi?id=160610
   + prone to complications; (cumbersome) alternatives possible (Stephané)
   + hiding rows is possibly a proper workaround for the rare need (Cor)
   => suggest WF if there's no clear response

 * Print (or export) only tracked changes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=160497
   + sidebar lists all TC (Dieter)
   + macro on ask.libo solves the use case (Heiko)
   + reasonable use case for some (Cor, John)
   + but macro is a good solution
   => resolve WF


OpenPGP_signature.asc
Description: OpenPGP digital signature


Minutes from the UX/design meeting 2023-May-08

2024-05-08 Thread Heiko Tietze

Present:  Sahil, John, Hossein, Cor, Eyal, Heiko
Comments: Stuart, Stephane, Dieter

Tickets/Topics

 * Major design changes ongoing for "Better handling for multiline tabs
   + https://bugs.documentfoundation.org/show_bug.cgi?id=99528

 * List images in order of document appearance in Calc Navigator
   + https://bugs.documentfoundation.org/show_bug.cgi?id=160353
   + at least four different sort orders: row first, col first,
 alphabetically, by insertion time (Heiko)
   + limited use case (John)
   + Navigator lists objects from all sheets making the sort order
 problematic (John)
 + maybe reported somewhere; unclear if users accept when the
   Navigator restricts objects to the current sheet
   => keep with low priority

 * Icons for promote / demote outline level should be improved
   + https://bugs.documentfoundation.org/show_bug.cgi?id=158932
   + clear depiction of the action (Stuart)
   + there are issues with RTL UI (Hossein)
 + dup at https://bugs.documentfoundation.org/show_bug.cgi?id=154523
 + see also https://bugs.documentfoundation.org/show_bug.cgi?id=70102
   => duplicate

 * Print multiple non-contiguous print ranges on a single page in
   LibreOffice Calc
   + https://bugs.documentfoundation.org/show_bug.cgi?id=160610
   + prone to complications; (cumbersome) alternatives possible (Stephané)
   + hiding rows is possibly a proper workaround for the rare need (Cor)
   => suggest WF if there's no clear response

 * Print (or export) only tracked changes
   + https://bugs.documentfoundation.org/show_bug.cgi?id=160497
   + sidebar lists all TC (Dieter)
   + macro on ask.libo solves the use case (Heiko)
   + reasonable use case for some (Cor, John)
   + but macro is a good solution
   => resolve WF


OpenPGP_signature.asc
Description: OpenPGP digital signature


core.git: Branch 'feature/cib_contract49c' - 2 commits - include/svx svx/source sw/source

2024-05-08 Thread Michael Stahl (via logerrit)
 include/svx/svdobj.hxx |8 
 include/svx/svdovirt.hxx   |4 
 svx/source/svdraw/svdobj.cxx   |   10 ++
 svx/source/svdraw/svdovirt.cxx |   20 
 sw/source/core/draw/dcontact.cxx   |5 +++--
 sw/source/uibase/utlui/content.cxx |2 +-
 6 files changed, 42 insertions(+), 7 deletions(-)

New commits:
commit 5c9f940245e8f128979e6c45d3c5eb2192f4b8cc
Author: Michael Stahl 
AuthorDate: Wed May 8 14:20:26 2024 +0200
Commit: Thorsten Behrens 
CommitDate: Wed May 8 20:54:07 2024 +0200

tdf#156484 svx,sw: fix visibility of shapes in header/footer

Similar to commit ae132145ff42a95dc24fb124847c04af4b8c8dab, also forward
IsVisible() and IsPrintable() from SdrVirtObj to its real object;
evidently the properties aren't copied when creating SdrVirtObj but
there is no reason for that to have these properties independent.

This triggers an assert in VOCOfDrawVirtObj::createPrimitive2DSequence()
because that is called during layout from getObjectRange(); the assert
was added in commit ae3ec0d53a22ae5d2b7fb244a6056d0627b71873 and
intended for painting, but this isn't painting, and it's not easily
possible to detect if the function is called during painting, so remove
the assert.

Change-Id: Id2a04a5d07f43b86eb9c524b30ba74ecaf6a95c8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167364
Tested-by: allotropia jenkins 
Reviewed-by: Thorsten Behrens 

diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 892beb56668c..396c09e8cd94 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -752,10 +752,10 @@ public:
 bool IsMoveProtect() const { return m_bMovProt;}
 void SetResizeProtect(bool bProt);
 bool IsResizeProtect() const { return m_bSizProt;}
-void SetPrintable(bool bPrn);
-bool IsPrintable() const { return !m_bNoPrint;}
-void SetVisible(bool bVisible);
-bool IsVisible() const { return mbVisible;}
+virtual void SetPrintable(bool isPrintable);
+virtual bool IsPrintable() const;
+virtual void SetVisible(bool isVisible);
+virtual bool IsVisible() const;
 void SetMarkProtect(bool bProt);
 bool IsMarkProtect() const { return m_bMarkProt;}
 virtual bool IsSdrTextObj() const { return false; }
diff --git a/include/svx/svdovirt.hxx b/include/svx/svdovirt.hxx
index 17c869313067..ca5f6858ecaa 100644
--- a/include/svx/svdovirt.hxx
+++ b/include/svx/svdovirt.hxx
@@ -61,6 +61,10 @@ public:
 const SdrObject& GetReferencedObj() const;
 virtual void NbcSetAnchorPos(const Point& rAnchorPos) override;
 
+virtual void SetPrintable(bool isPrintable) override;
+virtual bool IsPrintable() const override;
+virtual void SetVisible(bool isVisible) override;
+virtual bool IsVisible() const override;
 virtual void TakeObjInfo(SdrObjTransformInfoRec& rInfo) const override;
 virtual SdrInventor GetObjInventor() const override;
 virtual SdrObjKind GetObjIdentifier() const override;
diff --git a/svx/source/svdraw/svdobj.cxx b/svx/source/svdraw/svdobj.cxx
index f4d13219db0d..b23e18a6a4d3 100644
--- a/svx/source/svdraw/svdobj.cxx
+++ b/svx/source/svdraw/svdobj.cxx
@@ -2675,6 +2675,11 @@ void SdrObject::SetResizeProtect(bool bProt)
 }
 }
 
+bool SdrObject::IsPrintable() const
+{
+return !m_bNoPrint;
+}
+
 void SdrObject::SetPrintable(bool bPrn)
 {
 if( bPrn == m_bNoPrint )
@@ -2689,6 +2694,11 @@ void SdrObject::SetPrintable(bool bPrn)
 }
 }
 
+bool SdrObject::IsVisible() const
+{
+return mbVisible;
+}
+
 void SdrObject::SetVisible(bool bVisible)
 {
 if( bVisible != mbVisible )
diff --git a/svx/source/svdraw/svdovirt.cxx b/svx/source/svdraw/svdovirt.cxx
index b1fe6f5cb9bb..2e1641d3864e 100644
--- a/svx/source/svdraw/svdovirt.cxx
+++ b/svx/source/svdraw/svdovirt.cxx
@@ -97,6 +97,26 @@ void SdrVirtObj::NbcSetAnchorPos(const Point& rAnchorPos)
 m_aAnchor=rAnchorPos;
 }
 
+bool SdrVirtObj::IsPrintable() const
+{
+return mxRefObj->IsPrintable();
+}
+
+void SdrVirtObj::SetPrintable(bool const isPrintable)
+{
+mxRefObj->SetPrintable(isPrintable);
+}
+
+bool SdrVirtObj::IsVisible() const
+{
+return mxRefObj->IsVisible();
+}
+
+void SdrVirtObj::SetVisible(bool const isVisible)
+{
+mxRefObj->SetVisible(isVisible);
+}
+
 void SdrVirtObj::TakeObjInfo(SdrObjTransformInfoRec& rInfo) const
 {
 mxRefObj->TakeObjInfo(rInfo);
diff --git a/sw/source/core/draw/dcontact.cxx b/sw/source/core/draw/dcontact.cxx
index aac8f2393c61..115887a368dc 100644
--- a/sw/source/core/draw/dcontact.cxx
+++ b/sw/source/core/draw/dcontact.cxx
@@ -2216,8 +2216,9 @@ namespace sdr::contact
 
 void VOCOfDrawVirtObj::createPrimitive2DSequence(const DisplayInfo& 
rDisplayInfo, drawinglayer::primitive2d::Primitive2DDecompositionVisitor& 
rVisitor) const
 {
-// tdf#91260 have already checked top-level one is on the right 
page
-

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

--- Comment #5 from Cor Nouws  ---
(In reply to Cor Nouws from comment #4)

> Did you consider hiding rows/columns in a range, so that only visible stuff
> is printed? That would (in some cases) remove the need to have multiple
> print ranges?
[Heiko kindly reminds that Stéphane also mentioned hiding stuff :) ]

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

--- Comment #5 from Cor Nouws  ---
(In reply to Cor Nouws from comment #4)

> Did you consider hiding rows/columns in a range, so that only visible stuff
> is printed? That would (in some cases) remove the need to have multiple
> print ranges?
[Heiko kindly reminds that Stéphane also mentioned hiding stuff :) ]

-- 
You are receiving this mail because:
You are on the CC list for the bug.

core.git: forms/source

2024-05-08 Thread Armin Le Grand (allotropia) (via logerrit)
 forms/source/richtext/parametrizedattributedispatcher.cxx |   14 +++---
 forms/source/richtext/parametrizedattributedispatcher.hxx |6 +++---
 forms/source/richtext/specialdispatchers.cxx  |   14 ++
 forms/source/richtext/specialdispatchers.hxx  |2 +-
 4 files changed, 21 insertions(+), 15 deletions(-)

New commits:
commit 24d78fcb5399b2c783ab7908263a1b54bb687a22
Author: Armin Le Grand (allotropia) 
AuthorDate: Tue May 7 13:59:18 2024 +0200
Commit: Armin Le Grand 
CommitDate: Wed May 8 20:49:51 2024 +0200

tdf#160906 use SfxPoolItemHolder

to avoid handling already deleted SfxPoolItems.

Change-Id: I1f1f8f93cae8db7f7c8df66c2c7f3c02b59a39c3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167274
Reviewed-by: Armin Le Grand 
Tested-by: Jenkins

diff --git a/forms/source/richtext/parametrizedattributedispatcher.cxx 
b/forms/source/richtext/parametrizedattributedispatcher.cxx
index 15b69b0888b6..a86441cd87dd 100644
--- a/forms/source/richtext/parametrizedattributedispatcher.cxx
+++ b/forms/source/richtext/parametrizedattributedispatcher.cxx
@@ -88,7 +88,7 @@ namespace frm
 }
 
 
-const SfxPoolItem* 
OParametrizedAttributeDispatcher::convertDispatchArgsToItem( const Sequence< 
PropertyValue >& _rArguments )
+SfxPoolItemHolder 
OParametrizedAttributeDispatcher::convertDispatchArgsToItem( const Sequence< 
PropertyValue >& _rArguments )
 {
 // get the real slot id. This may differ from our attribute id: for 
instance, both
 // SID_ATTR_CHAR_HEIGHT and SID_ATTR_CHAR_LATIN_HEIGHT are mapped to 
the same which id
@@ -97,16 +97,16 @@ namespace frm
 SfxAllItemSet aParameterSet( getEditView()->GetEmptyItemSet() );
 TransformParameters( nSlotId, _rArguments, aParameterSet );
 
-const SfxPoolItem* pArgument = nullptr;
 if ( aParameterSet.Count() )
 {
 OSL_ENSURE( aParameterSet.Count() == 1, 
"OParametrizedAttributeDispatcher::convertDispatchArgsToItem: Arguments which 
form more than 1 item? How this?" );
 WhichId nAttributeWhich = 
aParameterSet.GetPool()->GetWhichIDFromSlotID( nSlotId );
-pArgument = aParameterSet.GetItem( nAttributeWhich );
-OSL_ENSURE( pArgument, 
"OParametrizedAttributeDispatcher::convertDispatchArgsToItem: suspicious: there 
were arguments, but they're not for my slot!" );
+SfxPoolItemHolder aArgument(*aParameterSet.GetPool(), 
aParameterSet.GetItem(nAttributeWhich));
+OSL_ENSURE( aArgument.getItem(), 
"OParametrizedAttributeDispatcher::convertDispatchArgsToItem: suspicious: there 
were arguments, but they're not for my slot!" );
+return aArgument;
 }
 
-return pArgument;
+return SfxPoolItemHolder();
 }
 
 
@@ -116,8 +116,8 @@ namespace frm
 OSL_ENSURE( _rURL.Complete == getFeatureURL().Complete, 
"OParametrizedAttributeDispatcher::dispatch: invalid URL!" );
 if ( m_pMasterDispatcher )
 {
-const SfxPoolItem* pConvertedArgument = convertDispatchArgsToItem( 
_rArguments );
-m_pMasterDispatcher->executeAttribute( m_nAttributeId, 
pConvertedArgument );
+const SfxPoolItemHolder 
aConvertedArgument(convertDispatchArgsToItem(_rArguments));
+m_pMasterDispatcher->executeAttribute(m_nAttributeId, 
aConvertedArgument.getItem());
 }
 }
 
diff --git a/forms/source/richtext/parametrizedattributedispatcher.hxx 
b/forms/source/richtext/parametrizedattributedispatcher.hxx
index 69844731612e..8a68486c131b 100644
--- a/forms/source/richtext/parametrizedattributedispatcher.hxx
+++ b/forms/source/richtext/parametrizedattributedispatcher.hxx
@@ -21,7 +21,7 @@
 
 #include "attributedispatcher.hxx"
 
-class SfxPoolItem;
+class SfxPoolItemHolder;
 
 namespace frm
 {
@@ -47,10 +47,10 @@ namespace frm
 
 protected:
 // own overridables
-/** convert the arguments as got in a XDispatch::dispatch call into an 
SfxPoolItem, which can
+/** convert the arguments as got in a XDispatch::dispatch call into an 
SfxPoolItemHolder, which can
 be used with a IMultiAttributeDispatcher::executeAttribute
 */
-virtual const SfxPoolItem* convertDispatchArgsToItem(
+virtual SfxPoolItemHolder convertDispatchArgsToItem(
 const css::uno::Sequence< css::beans::PropertyValue >& _rArguments 
);
 };
 
diff --git a/forms/source/richtext/specialdispatchers.cxx 
b/forms/source/richtext/specialdispatchers.cxx
index 283f0db8e09a..b13d29aeeb98 100644
--- a/forms/source/richtext/specialdispatchers.cxx
+++ b/forms/source/richtext/specialdispatchers.cxx
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 
 
 
 namespace frm
@@ -139,7 +140,7 @@ namespace frm
 }
 
 
-const SfxPoolItem* OAsianFontLayoutDispatcher::convertDispatchArgsToItem( 
const Sequence< PropertyValue >& _rArguments )
+SfxPoolItemHolder 

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

Cor Nouws  changed:

   What|Removed |Added

Version|24.2.2.2 release|Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

Cor Nouws  changed:

   What|Removed |Added

Version|24.2.2.2 release|Inherited From OOo

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #4 from Cor Nouws  ---
(In reply to Orwel from comment #0)
> Expected Results:
> Would be great if the dimension of the paper allows it, a possibility to
> print both ranges on one sheet would exist.
Hi Orwel,
For some cases it could be useful, especially when e.g. the width of the ranges
are similar. In other cases it will produce nasty/ugly results.
So if added as option, one to handle with care.

Did you consider hiding rows/columns in a range, so that only visible stuff is
printed? That would (in some cases) remove the need to have multiple print
ranges?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160610] Print multiple non-contiguous print ranges on a single page in LibreOffice Calc

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160610

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #4 from Cor Nouws  ---
(In reply to Orwel from comment #0)
> Expected Results:
> Would be great if the dimension of the paper allows it, a possibility to
> print both ranges on one sheet would exist.
Hi Orwel,
For some cases it could be useful, especially when e.g. the width of the ranges
are similar. In other cases it will produce nasty/ugly results.
So if added as option, one to handle with care.

Did you consider hiding rows/columns in a range, so that only visible stuff is
printed? That would (in some cases) remove the need to have multiple print
ranges?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 160926] Duplicate push buttons appearing

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160926

--- Comment #25 from nutka  ---
(In reply to ady from comment #24)
> @Nutka, could you please follow the steps from comment 17 and report back?
The problem still persists (either for the steps described by @NOYB or by me).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 109087] [META] Calc sheet header and footer bugs and enhancements

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=109087
Bug 109087 depends on bug 160057, which changed state.

Bug 160057 Summary: Document Calc's separate Footer and Header tabs if "Same 
content on first page" is off
https://bugs.documentfoundation.org/show_bug.cgi?id=160057

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 80430] [META] Documentation gap for new features

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=80430
Bug 80430 depends on bug 160057, which changed state.

Bug 160057 Summary: Document Calc's separate Footer and Header tabs if "Same 
content on first page" is off
https://bugs.documentfoundation.org/show_bug.cgi?id=160057

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160057] Document Calc's separate Footer and Header tabs if "Same content on first page" is off

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160057

Olivier Hallot  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 160995] : when opened file, all the colors (including for fonts) and shapes have disappeared

2024-05-08 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=160995

Peter Fry  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |peterglenn...@aol.com
   |desktop.org |
 CC||peterglenn...@aol.com
 Ever confirmed|0   |1
 Status|UNCONFIRMED |NEW

--- Comment #1 from Peter Fry  ---
Created attachment 194031
  --> https://bugs.documentfoundation.org/attachment.cgi?id=194031=edit
green diamond on black background with color texts and photos

-- 
You are receiving this mail because:
You are the assignee for the bug.

  1   2   3   >