core.git: Branch 'libreoffice-24-8' - vcl/qt5
vcl/qt5/QtObject.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 359cdd6b3b401519621dd10fc072305d627dccc0 Author: Michael Weghorn AuthorDate: Fri Jun 21 20:39:46 2024 +0200 Commit: Michael Weghorn CommitDate: Sat Jun 22 06:56:37 2024 +0200 tdf#149461 qt5: Provide a QWindow for OpenGL rendering on X11 When using the qt5 or kf5 VCL plugins on X11/XWayland (as can be forced using QT_QPA_PLUGIN=xcb on Wayland), ensure that a QWindow exists for the QtObjectWidget created in the QtObject ctor, as that is needed for OpenGL rendering. This makes OpenGL Impress slide transitions like the "Tiles" one work. Don't force native windows on Wayland, as that causes other issues, see also QtFrame::ResolveWindowHandle and the bugs referenced in there. Change-Id: I8fac34d2f1cc7cc723ad4570546276a05641dd88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169348 Reviewed-by: Michael Weghorn Tested-by: Jenkins (cherry picked from commit 89372e62454a72c6c400f00bfe3221bc0fe6d23e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169367 diff --git a/vcl/qt5/QtObject.cxx b/vcl/qt5/QtObject.cxx index b9f1b804f95c..8c9535b41f20 100644 --- a/vcl/qt5/QtObject.cxx +++ b/vcl/qt5/QtObject.cxx @@ -48,6 +48,11 @@ QtObject::QtObject(QtFrame* pParent, bool bShow) // which is not a problem with the QtMultimedia approach that the qt6 VCL plugin uses; // stay with the QtObjectWidget introduced in commit 4366e0605214260e55a937173b0c2e02225dc843 m_pQWidget = new QtObjectWidget(*this); + +// invoke QWidget::winId() to ensure a native window for OpenGL rendering is available on X11, +// don't do it on Wayland, as that breaks rendering otherwise, s.a. QtFrame::ResolveWindowHandle +if (QGuiApplication::platformName() == "xcb") +m_pQWidget->winId(); m_pQWindow = m_pQWidget->windowHandle(); }
core.git: Branch 'libreoffice-24-8' - 2 commits - vcl/inc vcl/qt5
vcl/inc/qt5/QtObject.hxx|7 ++-
vcl/qt5/QtObject.cxx| 31 +--
vcl/qt5/QtOpenGLContext.cxx |9 +
3 files changed, 36 insertions(+), 11 deletions(-)
New commits:
commit 734a74dec8f20d46d6a236071d4601aa763763e7
Author: Michael Weghorn
AuthorDate: Fri Jun 21 19:53:50 2024 +0200
Commit: Michael Weghorn
CommitDate: Sat Jun 22 06:56:30 2024 +0200
tdf#149461 qt6: Provide a QWindow for OpenGL rendering
As described at [1], "QWindow supports rendering using
OpenGL [...]".
Using a QWindow for OpenGL rendering had been introduced
in
commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3
Date: Fri Dec 14 12:44:20 2018 +0300
tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL
, but then
commit 4366e0605214260e55a937173b0c2e02225dc843
Date: Tue May 24 11:34:59 2022 +0200
tdf#148864 Qt switch QtObjectWindow to QWidget
had switched from QWindow to QWidget, and OpenGL slide
transitions like the "Tiles" one stopped working.
At least for qt6, which now uses QtMultimedia for video
playback (see the tdf#145735 commits), issues like tdf#148864
("Kubuntu 22.04 LTS LibreOffice Impress 7.3.3 Fails to Play Embedded
Videos") and tdf#125517 ("LO Impress: Can't stop presentation
with video and go to the next slide") related to video playback
appear to be no problem, so switch back to using QWindow there.
Explicitly set the window background to transparent
in `QtOpenGLContext::ImplInit`, as not doing so
caused slide content in presentation mode to not
be updated properly when testing with the attachment 183972
from tdf#149461 on Wayland.
(This was not an issue when running on XWayland, i.e.
with QT_QPA_PLATFORM=xcb).
With this in place, OpenGL transitions work with qt6.
With QT_QPA_PLATFORM=xcb, it looks all fine in my tests
on Debian testing.
With QT_QPA_PLATFORM=wayland, the slide text from attachment 183972
sometimes incorrectly showed up for a fraction of a second after
the slide transition finished, then disappeared again until
it was triggered to show as it should (e.g. by pressing the right
arrow key), s. screencast attachment 194899 in tdf#149461.
A multitude of warnings like the following are shown on stderr
in that case, which don't show up for xcb:
warn:vcl.opengl:47352:47352:vcl/source/opengl/OpenGLHelper.cxx:709: GL
Error 0506 (invalid framebuffer operation) in file
/home/michi/development/git/libreoffice/slideshow/source/engine/opengl/TransitionImpl.cxx
at line 398
That looks like a separate issue to me, however which would
need further analysis.
Keep using the QtObjectWindow approach for qt5 to
not regress on video playback.
[1] https://doc.qt.io/qt-5/qtgui-index.html#opengl-and-opengl-es-integration
Change-Id: I6e1eb989254e2cbbfada6f719ee0518571df4c42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169347
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
(cherry picked from commit b296b33cfbde5113f27ddef71a48380cb6ce5e06)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169366
diff --git a/vcl/inc/qt5/QtObject.hxx b/vcl/inc/qt5/QtObject.hxx
index bc5a8e584b8f..e5f9944d6b86 100644
--- a/vcl/inc/qt5/QtObject.hxx
+++ b/vcl/inc/qt5/QtObject.hxx
@@ -24,6 +24,7 @@
#include
#include
+#include
#include
class QtFrame;
@@ -36,7 +37,11 @@ class QtObject final : public QObject, public SalObject
SystemEnvData m_aSystemData;
QtFrame* m_pParent;
-QtObjectWidget* m_pQWidget;
+
+// window, required for OpenGL rendering
+QWindow* m_pQWindow;
+QWidget* m_pQWidget;
+
QRegion m_pRegion;
bool m_bForwardKey;
diff --git a/vcl/qt5/QtObject.cxx b/vcl/qt5/QtObject.cxx
index 229916bcd1ff..b9f1b804f95c 100644
--- a/vcl/qt5/QtObject.cxx
+++ b/vcl/qt5/QtObject.cxx
@@ -23,6 +23,7 @@
#include
#include
+#include
#include
#include
#include
@@ -36,7 +37,19 @@ QtObject::QtObject(QtFrame* pParent, bool bShow)
if (!m_pParent || !pParent->GetQWidget())
return;
-m_pQWidget = new QtObjectWidget(*this);
+if (QLibraryInfo::version().majorVersion() > 5)
+{
+m_pQWindow = new QWindow;
+m_pQWidget = QWidget::createWindowContainer(m_pQWindow,
pParent->GetQWidget());
+}
+else
+{
+// with the qt5 VCL plugin, the above would cause issues with video
playback (s. tdf#148864, tdf#125517),
+// which is not a problem with the QtMultimedia approach that the qt6
VCL plugin uses;
+// stay with the QtObjectWidget introduced in commit
4366e0605214260e55a937173b0c2e02225dc843
+m_pQWidget = new QtObjectWidget(*this);
+m_pQWindow = m_pQWidget->windowHandle();
+}
// set layout, used for video playback, see
[Bug 161412] Warning in PDF password dialog should eventually disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=161412 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161412] Warning in PDF password dialog should eventually disappear
https://bugs.documentfoundation.org/show_bug.cgi?id=161412 Stéphane Guillou (stragu) changed: What|Removed |Added Severity|normal |minor CC||stephane.guillou@libreoffic ||e.org Whiteboard| QA:needsComment| Priority|medium |low --- Comment #1 from Stéphane Guillou (stragu) --- Reproduced in: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 151d997365f7bf271d63af535d29a9c3439c6d46 CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 153101] Add option to disable Update Notifications for Technological Enthusiast ("fresh") Releases
https://bugs.documentfoundation.org/show_bug.cgi?id=153101 Stéphane Guillou (stragu) changed: What|Removed |Added CC||kense...@netscape.net --- Comment #4 from Stéphane Guillou (stragu) --- *** Bug 161432 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161432] LibreOffice 7.6.7.2 is repeatedly prompting to upgrade to v24.2.3 on MacOS 13.6.7 (on Intel)
https://bugs.documentfoundation.org/show_bug.cgi?id=161432 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE Whiteboard| QA:needsComment| CC||stephane.guillou@libreoffic ||e.org --- Comment #1 from Stéphane Guillou (stragu) --- Thanks for the report. Because the 7.6 branch has reached End of Life[1], it makes sense to point users to the branch that will receive updates and has become the de facto "mature" branch - especially since security update won't get to that branch. Longer-term support exists from ecosystem companies[2]. So I would close as "not a bug", but I see it has been suggested before to allow turning this branch-hopping update suggestion off and I think it's a good candidate for duplicate. [1]: https://wiki.documentfoundation.org/ReleasePlan/7.6 [2]: https://www.libreoffice.org/download/libreoffice-in-business/ *** This bug has been marked as a duplicate of bug 153101 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161444] When switching sheets, newly-focused sheet should fire object:state-changed:focused prior to object:active-descendant-changed
https://bugs.documentfoundation.org/show_bug.cgi?id=161444 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Version|unspecified |24.2.3.2 release Keywords||accessibility Ever confirmed|0 |1 Status|UNCONFIRMED |NEW -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161727] LOOKUP works in 7.0.4.2 but not in 7.6.7.2
https://bugs.documentfoundation.org/show_bug.cgi?id=161727 Stéphane Guillou (stragu) changed: What|Removed |Added CC||er...@redhat.com --- Comment #5 from Stéphane Guillou (stragu) --- Eike, you advice would be appreciated here too :) -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161620] In Draw: Background transparency setting don't follow exporting to PNG.
https://bugs.documentfoundation.org/show_bug.cgi?id=161620 --- Comment #10 from Stéphane Guillou (stragu) --- No problem at all Rene, thank you for reporting issues you run into! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104742] [META] Network-involved bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=104742 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||141639 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=141639 [Bug 141639] The file may become corrupted in LibreOffice when offline file synchronization is enabled on Windows. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141639] The file may become corrupted in LibreOffice when offline file synchronization is enabled on Windows.
https://bugs.documentfoundation.org/show_bug.cgi?id=141639 Stéphane Guillou (stragu) changed: What|Removed |Added Hardware|x86 (IA32) |x86-64 (AMD64) Blocks||104742 Version|unspecified |7.1.1.2 release Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=104742 [Bug 104742] [META] Network-involved bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141639] The file may become corrupted in LibreOffice when offline file synchronization is enabled on Windows.
https://bugs.documentfoundation.org/show_bug.cgi?id=141639 Stéphane Guillou (stragu) changed: What|Removed |Added Version|2.3.0 |unspecified Product|Impress Remote |LibreOffice Component|General |LibreOffice -- You are receiving this mail because: You are the assignee for the bug.
[Bug 141639] The file may become corrupted in LibreOffice when offline file synchronization is enabled on Windows.
https://bugs.documentfoundation.org/show_bug.cgi?id=141639 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1446 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161446] Writer files containing images get corrupted when saving to CIFS Shares when SAMBA server has SMB2 Leases disabled
https://bugs.documentfoundation.org/show_bug.cgi?id=161446 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO Whiteboard| QA:needsComment| Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||1639 --- Comment #1 from Stéphane Guillou (stragu) --- Thank you for the report. Version 7.4 is not maintained anymore. Some CIFS and SAMBA issues have been fixed since, for example bug 158975 and bug 55004. Please test version 24.2.4 or above and let us know if you can still reproduce. Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161737] Regression: spell checking triggered by NNBSP
https://bugs.documentfoundation.org/show_bug.cgi?id=161737 --- Comment #2 from Maxime --- Created attachment 194905 --> https://bugs.documentfoundation.org/attachment.cgi?id=194905=edit A text document using the NNBSP character. Here is a show-case of the issue. Best regards. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161447] slow, keep getting NO RESPONSE message
https://bugs.documentfoundation.org/show_bug.cgi?id=161447 Stéphane Guillou (stragu) changed: What|Removed |Added Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Stéphane Guillou (stragu) --- On top of m_a_riosv question, please let us know if the situation improved after the scans, and with the latest version (24.2.4 or above). You say "it only started doing this the last couple of weeks", please let us know if that's since an update of LibreOffice or unrelated. Thank you! -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160644] LibreOffice crashes with LaunchBar and Keyboard Maestro (comment 20)
https://bugs.documentfoundation.org/show_bug.cgi?id=160644 Stéphane Guillou (stragu) changed: What|Removed |Added Summary|Upon opening, LibreOffice |LibreOffice crashes with |sometimes crashes (perhaps |LaunchBar and Keyboard |once a week)|Maestro (comment 20) CC||stephane.guillou@libreoffic ||e.org Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #26 from Stéphane Guillou (stragu) --- Do you still experience this with the latest versions of all involved apps? Wondering if the fix for bug 159529 helps in any way. Or even bug 155212 (which is not yet included in a release, but you could test a daily build). -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161455] Unexpected Selecting when character is selected and use TAB to move to next cell
https://bugs.documentfoundation.org/show_bug.cgi?id=161455 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161704] the data in the cell is not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=161704 --- Comment #3 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160648] after leaving the Edit-dialogue of an entry in the conditional formattings, the selection spuriously jumps to another one
https://bugs.documentfoundation.org/show_bug.cgi?id=160648 --- Comment #4 from QA Administrators --- [Automated Action] NeedInfo-To-Unconfirmed -- You are receiving this mail because: You are the assignee for the bug.
[Bug 156466] FILESAVE DOC: Saved file made Word hang
https://bugs.documentfoundation.org/show_bug.cgi?id=156466 --- Comment #4 from QA Administrators --- Dear Regina Henschel, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Bug 94220] UI: Formula bar and cell edit show line break after hyphen
https://bugs.documentfoundation.org/show_bug.cgi?id=94220 --- Comment #7 from QA Administrators --- Dear tmacalp, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 104840] [META] Saved DOC files that MS Word can't open
https://bugs.documentfoundation.org/show_bug.cgi?id=104840 Bug 104840 depends on bug 156466, which changed state. Bug 156466 Summary: FILESAVE DOC: Saved file made Word hang https://bugs.documentfoundation.org/show_bug.cgi?id=156466 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Bug 132929] Shape at the wrong position after save and reload caused by undo (see comment 2)
https://bugs.documentfoundation.org/show_bug.cgi?id=132929 --- Comment #9 from QA Administrators --- Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 69686] Footer is not rendered correctly for complex Microsoft_ITAD_CDI_Case_Study_April.docx
https://bugs.documentfoundation.org/show_bug.cgi?id=69686 --- Comment #13 from QA Administrators --- Dear John Platts, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 125596] DOCX: Writer misidentify text language (and appropriate font) in MS Word file (MSO2019)
https://bugs.documentfoundation.org/show_bug.cgi?id=125596 --- Comment #7 from QA Administrators --- Dear Ratchanan Srirattanamet, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 120206] When switching keyboard layout, scrolling should not behave as though Scroll Lock was toggled
https://bugs.documentfoundation.org/show_bug.cgi?id=120206 --- Comment #15 from QA Administrators --- Dear Eyal Rozenberg, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160648] after leaving the Edit-dialogue of an entry in the conditional formattings, the selection spuriously jumps to another one
https://bugs.documentfoundation.org/show_bug.cgi?id=160648 Christoph Anton Mitterer changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #3 from Christoph Anton Mitterer --- Hey. Meanwhile I'm running on a newer version, but the described problem still persists (just checked it again). For that, the detailed version info is: Version: 24.2.4.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: en-US (C); UI: en-US Debian package version: 4:24.2.4-1+b1 Calc: threaded Cheers, Chris. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160648] after leaving the Edit-dialogue of an entry in the conditional formattings, the selection spuriously jumps to another one
https://bugs.documentfoundation.org/show_bug.cgi?id=160648 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Priority|medium |low Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from Stéphane Guillou (stragu) --- Christoph, can you please share the full version info copied from Help - About LibreOffice (or LibreOffice - About on macOS)? There's a button to copy it. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 146718] Crash in: SwDBManager::MergeMailFiles(SwWrtShell *,SwMergeDescriptor const &) - Mailmerge print form letter, individual documents, path with non-existing user
https://bugs.documentfoundation.org/show_bug.cgi?id=146718 Stéphane Guillou (stragu) changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||0653 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160653] Crash in: SwDBManager::MergeMailFiles(SwWrtShell *,SwMergeDescriptor const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=160653 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Ever confirmed|0 |1 See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||6718 Status|UNCONFIRMED |NEEDINFO --- Comment #5 from Stéphane Guillou (stragu) --- Could you please test again in version 24.2, with PDF output, and see if it still crashes? Thank you. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 160710] Clarify "Save Document as URL"
https://bugs.documentfoundation.org/show_bug.cgi?id=160710 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 CC||stephane.guillou@libreoffic ||e.org Whiteboard| QA:needsComment| --- Comment #1 from Stéphane Guillou (stragu) --- I can't find this in the UI. Do you know where it is used? -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161620] In Draw: Background transparency setting don't follow exporting to PNG.
https://bugs.documentfoundation.org/show_bug.cgi?id=161620 --- Comment #9 from Rene Hache --- Ok, Thank You. So sorry for all the trouble and for taking your precious time. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 120902] inconsistent behaviour of the menu icons regarding Cell Background and cell border
https://bugs.documentfoundation.org/show_bug.cgi?id=120902 ady changed: What|Removed |Added CC||a4jp@gmail.com --- Comment #2 from ady --- *** Bug 161738 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161738] LibreOffice Calc borders
https://bugs.documentfoundation.org/show_bug.cgi?id=161738 ady changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Keywords||topicUI OS|Windows (All) |All Resolution|--- |DUPLICATE CC||heiko.tietze@documentfounda ||tion.org --- Comment #1 from ady --- The current "borders" icon is not a split icon, as the Background color is. You are requesting to split the borders icon, in a similar way as the background color icon. This has been requested in other tickets. I'll set this new ticket as duplicate of one such prior requests. Although usually newer reports are set as dupes of older ones, someone else might decide to revert the dupe relation, depending on simplicity and accuracy of the comments and samples. *** This bug has been marked as a duplicate of bug 120902 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144453] [META] VBA-Error 423, Unimplemented Member
https://bugs.documentfoundation.org/show_bug.cgi?id=144453 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||161325 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161325 [Bug 161325] listobjects 423 not found -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161325] listobjects 423 not found
https://bugs.documentfoundation.org/show_bug.cgi?id=161325 Stéphane Guillou (stragu) changed: What|Removed |Added Blocks||144453 URL||https://learn.microsoft.com ||/en-us/office/vba/api/excel ||.listobjects CC||stephane.guillou@libreoffic ||e.org Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=144453 [Bug 144453] [META] VBA-Error 423, Unimplemented Member -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161334] Not properly Save my data Existing Location
https://bugs.documentfoundation.org/show_bug.cgi?id=161334 Stéphane Guillou (stragu) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||stephane.guillou@libreoffic ||e.org Resolution|--- |INVALID Whiteboard| QA:needsComment| --- Comment #1 from Stéphane Guillou (stragu) --- Sorry, I can't make sense of this report in its current form. If you have more details, please share them and set back to "unconfirmed". Please feel free to use automated translation like LibreTranslate / Google Translate if needed. -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/source
sw/source/uibase/shells/textfld.cxx | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
New commits:
commit b7fce2b26ee4ba585544457adc742807a2129d2c
Author: Justin Luth
AuthorDate: Fri Jun 21 17:05:47 2024 -0400
Commit: Justin Luth
CommitDate: Sat Jun 22 03:26:18 2024 +0200
NFC sw textfld.cxx: make rDoc an actual reference
Change-Id: I84d65e80f27cdc2cbfc4f56c89e5a391e0fd9e1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169350
Reviewed-by: Justin Luth
Tested-by: Jenkins
diff --git a/sw/source/uibase/shells/textfld.cxx
b/sw/source/uibase/shells/textfld.cxx
index bd0861ace3f0..54602e0199b7 100644
--- a/sw/source/uibase/shells/textfld.cxx
+++ b/sw/source/uibase/shells/textfld.cxx
@@ -1092,12 +1092,12 @@ FIELD_INSERT:
pDlg->StartExecuteAsync([pShell, , pDlg](int nResult) {
if ( nResult == RET_OK )
{
-auto rDoc = rSh.GetDoc();
+auto& rDoc = *rSh.GetDoc();
rSh.LockView(true);
rSh.StartAllAction();
rSh.SwCursorShell::Push();
-
rDoc->GetIDocumentUndoRedo().StartUndo(SwUndoId::INSERT_PAGE_NUMBER, nullptr);
+
rDoc.GetIDocumentUndoRedo().StartUndo(SwUndoId::INSERT_PAGE_NUMBER, nullptr);
const size_t nPageDescIndex = rSh.GetCurPageDesc();
const SwPageDesc& rDesc = rSh.GetPageDesc(nPageDescIndex);
@@ -1117,7 +1117,7 @@ FIELD_INSERT:
if (ppMark != rIDMA.getAllMarksEnd() && *ppMark)
{
SwPaM aDeleteOldPageNum((*ppMark)->GetMarkStart(),
(*ppMark)->GetMarkEnd());
-
rDoc->getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
+
rDoc.getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
}
SwPageDesc aNewDesc(rDesc);
@@ -1242,7 +1242,7 @@ FIELD_INSERT:
if (ppMark != rIDMA.getAllMarksEnd() && *ppMark)
{
SwPaM aDeleteOldPageNum((*ppMark)->GetMarkStart(),
(*ppMark)->GetMarkEnd());
-
rDoc->getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
+
rDoc.getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
}
SwTextNode* pTextNode =
rSh.GetCursor()->GetPoint()->GetNode().GetTextNode();
@@ -1250,7 +1250,7 @@ FIELD_INSERT:
// Insert new line if there is already text in header/footer
if (pTextNode && !pTextNode->GetText().isEmpty())
{
-
rDoc->getIDocumentContentOperations().SplitNode(*rSh.GetCursor()->GetPoint(),
false);
+
rDoc.getIDocumentContentOperations().SplitNode(*rSh.GetCursor()->GetPoint(),
false);
// Go back to start of header/footer
if (bHeader)
@@ -1292,7 +1292,7 @@ FIELD_INSERT:
aMgr.InsertField(aData);
if (pDlg->GetIncludePageTotal())
{
-
rDoc->getIDocumentContentOperations().InsertString(*rSh.GetCursor(), u" /
"_ustr);
+
rDoc.getIDocumentContentOperations().InsertString(*rSh.GetCursor(), u" /
"_ustr);
SwInsertField_Data
aPageTotalData(SwFieldTypesEnum::DocumentStatistics, DS_PAGE,
OUString(), OUString(),
SVX_NUM_PAGEDESC);
aMgr.InsertField(aPageTotalData);
@@ -1317,7 +1317,7 @@ FIELD_INSERT:
if (ppMark != rIDMA.getAllMarksEnd() && *ppMark)
{
SwPaM aDeleteOldPageNum((*ppMark)->GetMarkStart(),
(*ppMark)->GetMarkEnd());
-
rDoc->getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
+
rDoc.getIDocumentContentOperations().DeleteAndJoin(aDeleteOldPageNum);
}
pTextNode =
rSh.GetCursor()->GetPoint()->GetNode().GetTextNode();
@@ -1325,7 +1325,7 @@ FIELD_INSERT:
// Insert new line if there is already text in
header/footer
if (pTextNode && !pTextNode->GetText().isEmpty())
{
-rDoc->getIDocumentContentOperations().SplitNode(
+rDoc.getIDocumentContentOperations().SplitNode(
*rSh.GetCursor()->GetPoint(), false);
// Go back to start of header/footer
rSh.SetCursorInHdFt(nPageDescIndex, bHeader,
/*Even=*/true);
@@ -1346,7 +1346,7 @@ FIELD_INSERT:
aEvenMgr.InsertField(aData);
if (pDlg->GetIncludePageTotal())
{
-
rDoc->getIDocumentContentOperations().InsertString(*rSh.GetCursor(), u" /
"_ustr);
+
[Bug 103182] [META] GTK3-specific bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182 Stéphane Guillou (stragu) changed: What|Removed |Added Depends on||161362 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161362 [Bug 161362] Can Location be added to Linux system file open/save dialog -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161362] Can Location be added to Linux system file open/save dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=161362 Stéphane Guillou (stragu) changed: What|Removed |Added CC||stephane.guillou@libreoffic ||e.org Blocks||103182 OS|All |Linux (All) --- Comment #3 from Stéphane Guillou (stragu) --- Caolán, what's your take? Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=103182 [Bug 103182] [META] GTK3-specific bugs -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157529] FILEOPEN PPTX: Text shows that is invisible in PowerPoint
https://bugs.documentfoundation.org/show_bug.cgi?id=157529 Tibor Nagy changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |tibor.nagy.extern@allotropi |desktop.org |a.de -- You are receiving this mail because: You are the assignee for the bug.
[Bug 157019] FILEOPEN PPTX: Round corners of rectangle shape render as square corners
https://bugs.documentfoundation.org/show_bug.cgi?id=157019 Bug 157019 depends on bug 160490, which changed state. Bug 160490 Summary: FILEOPEN PPTX Automatically resized textbox is not exactly as tall as in PP https://bugs.documentfoundation.org/show_bug.cgi?id=160490 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
GSoC Weekly Update: LUA UNO Language binding in LibreOffice
Hello, Over the past week, I worked on changing the UNO interface methods that were hard-coded as individual C++ functions to a single a C++ method mapped to the __index metamethod. As discussed with Stephan, I used the css.scripting.Invocation interface to find out the number and types of arguments the given UNO method expects. With that information I then converted the given Lua arguments to C++ css::uno::Any arguments and used css.scripting.XInvocation's invoke method to make the actual UNO method call. The plan for the coming week is to be able to pass more arguments and return types in genericFunction. https://gerrit.libreoffice.org/c/core/+/168298 Regards, Venetia Furtado
[Bug 161738] New: LibreOffice Calc borders
https://bugs.documentfoundation.org/show_bug.cgi?id=161738 Bug ID: 161738 Summary: LibreOffice Calc borders Product: LibreOffice Version: 24.2.4.2 release Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: a4jp@gmail.com Description: The current border isn't selected if I click the border icon on the left side but the dropdown opens every time. *The color icons work properly though and save the currently selected color. Click the left side for the saved current color and right side for the dropdown. Steps to Reproduce: The current border isn't applied if I click the border icon on the left side but a dropdown opens every time. The color icons work properly though. Click the left side for the current color and right side for the dropdown. The border button has the same design as the color buttons. Actual Results: The dropdown opens every time and we have to reselect the border type every time. Expected Results: We select the border we want from the drop down from the left side of the icon (same as the color icons) then we get a preview of the border on the left side of the icon and we can easily click the left side to repeatedly select the same saved border. Reproducible: Always User Profile Reset: Yes Additional Info: Word allows this and your color icons work properly. Just not the border icon that has the same design as the color icons. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161646] Let Page Number Wizard (optionally) insert headers/footers in the margin area
https://bugs.documentfoundation.org/show_bug.cgi?id=161646 --- Comment #5 from Justin L --- Created attachment 194904 --> https://bugs.documentfoundation.org/attachment.cgi?id=194904=edit 161646_fitExistingMarginsPageNumbering.odt: testing document The following implementation seems to work pretty good: https://gerrit.libreoffice.org/c/core/+/169349 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161620] In Draw: Background transparency setting don't follow exporting to PNG.
https://bugs.documentfoundation.org/show_bug.cgi?id=161620 Stéphane Guillou (stragu) changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO|RESOLVED --- Comment #8 from Stéphane Guillou (stragu) --- The issue is that the app you use for looking at the image uses a different background that blend with your transparent image. If you want to compare apples to apples, please open the image in an application that uses a white background behind images. For example, Firefox does that, in my tests. Or change Irfan's background colour: https://irfanview-forum.de/forum/program/support/1264- -- You are receiving this mail because: You are the assignee for the bug.
core.git: cli_ure/Module_cli_ure.mk config_host.mk.in configure.ac odk/CustomTarget_check.mk odk/Module_odk.mk Repository.mk testtools/Module_testtools.mk unoil/Module_unoil.mk
Repository.mk | 16 ++-- cli_ure/Module_cli_ure.mk |2 config_host.mk.in |1 configure.ac | 156 ++ odk/CustomTarget_check.mk |4 - odk/Module_odk.mk |2 testtools/Module_testtools.mk |2 unoil/Module_unoil.mk |2 8 files changed, 106 insertions(+), 79 deletions(-) New commits: commit 4031659233958a5bf93ea86e8fe117fd0dd45c10 Author: RMZeroFour AuthorDate: Wed Jun 12 21:25:42 2024 +0530 Commit: Hossein CommitDate: Sat Jun 22 00:11:16 2024 +0200 .NET Bindings: Switch for old windows CLI bindings This commit adds an --enable-cli/--disable-cli switch to autoconf to control generation of the old CLI bindings (Windows only). It is enabled by default, to not be a breaking change to users just yet. Over time, when the old bindings are deprecated in favor of the new .NET bindings, it could be set to disabled by default. Change-Id: Ib60b372459cb0c735275ed17d004d037279357eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168751 Tested-by: Jenkins Reviewed-by: Hossein diff --git a/Repository.mk b/Repository.mk index 18ebd4372f31..c4e8b8d3299e 100644 --- a/Repository.mk +++ b/Repository.mk @@ -89,7 +89,9 @@ $(eval $(call gb_Helper_register_executables,NONE, \ )) $(eval $(call gb_Helper_register_executables_for_install,SDK,sdk, \ - $(if $(filter MSC,$(COM)),$(if $(filter-out AARCH64_TRUE,$(CPUNAME)_$(CROSS_COMPILING)),climaker)) \ + $(if $(ENABLE_CLI),\ + $(if $(filter MSC,$(COM)),$(if $(filter-out AARCH64_TRUE,$(CPUNAME)_$(CROSS_COMPILING)),climaker)) \ + ) \ cppumaker \ javamaker \ netmaker \ @@ -591,14 +593,16 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE, \ swqahelper \ wpftqahelper \ precompiled_system \ - $(if $(filter MSC,$(COM)),cli_cppuhelper) \ + $(if $(ENABLE_CLI),$(if $(filter MSC,$(COM)),cli_cppuhelper)) \ $(if $(filter $(OS),ANDROID),lo-bootstrap) \ $(if $(filter $(OS),MACOSX),OOoSpotlightImporter) \ )) $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_URE,ure, \ affine_uno_uno \ - $(if $(filter MSC,$(COM)),$(if $(filter-out AARCH64_TRUE,$(CPUNAME)_$(CROSS_COMPILING)),cli_uno)) \ + $(if $(ENABLE_CLI),\ + $(if $(filter MSC,$(COM)),$(if $(filter-out AARCH64_TRUE,$(CPUNAME)_$(CROSS_COMPILING)),cli_uno)) \ + ) \ i18nlangtag \ $(if $(ENABLE_JAVA), \ java_uno \ @@ -862,7 +866,7 @@ endif # Other packages could be potentially autoinstalled. $(eval $(call gb_Helper_register_packages, \ test_unittest \ - cli_basetypes_copy \ + $(if $(ENABLE_CLI),cli_basetypes_copy) \ extras_wordbook \ instsetoo_native_setup \ $(if $(ENABLE_OOENV),instsetoo_native_ooenv) \ @@ -905,7 +909,9 @@ $(eval $(call gb_Helper_register_packages_for_install,postgresqlsdbc,\ $(eval $(call gb_Helper_register_packages_for_install,sdk,\ odk_share_readme \ odk_share_readme_generated \ - $(if $(filter WNT,$(OS)),$(if $(filter-out AARCH64_TRUE,$(CPUNAME)_$(CROSS_COMPILING)),odk_cli)) \ + $(if $(ENABLE_CLI),\ + $(if $(filter WNT,$(OS)),$(if $(filter-out AARCH64_TRUE,$(CPUNAME)_$(CROSS_COMPILING)),odk_cli)) \ + ) \ odk_config \ $(if $(filter WNT,$(OS)),odk_config_win) \ odk_docs \ diff --git a/cli_ure/Module_cli_ure.mk b/cli_ure/Module_cli_ure.mk index ba18aecd1e4b..b1cdc680d9db 100644 --- a/cli_ure/Module_cli_ure.mk +++ b/cli_ure/Module_cli_ure.mk @@ -9,6 +9,7 @@ $(eval $(call gb_Module_Module,cli_ure)) +ifeq ($(ENABLE_CLI),TRUE) ifeq ($(COM),MSC) ifneq ($(CPUNAME)_$(CROSS_COMPILING),AARCH64_TRUE) $(eval $(call gb_Module_add_targets,cli_ure,\ @@ -24,5 +25,6 @@ $(eval $(call gb_Module_add_targets,cli_ure,\ )) endif endif +endif # vim: set noet sw=4 ts=4: diff --git a/config_host.mk.in b/config_host.mk.in index b9a7cbfb4cae..f5666b16aa13 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -154,6 +154,7 @@ export DEFAULT_CRASHDUMP_VALUE=@DEFAULT_CRASHDUMP_VALUE@ export ENABLE_CAIRO_CANVAS=@ENABLE_CAIRO_CANVAS@ export ENABLE_CAIRO_RGBA=@ENABLE_CAIRO_RGBA@ export ENABLE_CIPHER_OPENSSL_BACKEND=@ENABLE_CIPHER_OPENSSL_BACKEND@ +export ENABLE_CLI=@ENABLE_CLI@ export ENABLE_CLUCENE=@ENABLE_CLUCENE@ export ENABLE_LIBCMIS=@ENABLE_LIBCMIS@ export ENABLE_COINMP=@ENABLE_COINMP@ diff --git a/configure.ac b/configure.ac index 43036fd9dfc7..50f26eba6611 100644 --- a/configure.ac +++ b/configure.ac @@ -2165,6 +2165,11 @@ AC_ARG_ENABLE(customtarget-components, AS_HELP_STRING([--enable-customtarget-components], [Generates the static UNO object constructor mapping from the build.])) +AC_ARG_ENABLE(cli, +AS_HELP_STRING([--disable-cli], +[Disable the generation of old CLI
[Bug 161736] Manage changes dialog opens very slowly and rejecting entry's is slow too (for complex ODT with track changes and comments)
https://bugs.documentfoundation.org/show_bug.cgi?id=161736 m_a_riosv changed: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m_a_riosv --- Looks like a strange case, 477 pages with everything misspelled. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161737] Regression: spell checking triggered by NNBSP
https://bugs.documentfoundation.org/show_bug.cgi?id=161737 m_a_riosv changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||miguelangelrv@libreoffice.o ||rg Ever confirmed|0 |1 --- Comment #1 from m_a_riosv --- Please attach a sample file, showing the issue. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 102495] [META] KDE (kf5) VCL backend bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=102495 Bug 102495 depends on bug 149461, which changed state. Bug 149461 Summary: OpenGL slide transitions not working properly with kf5 VCL plugin https://bugs.documentfoundation.org/show_bug.cgi?id=149461 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: vcl/qt5
vcl/qt5/QtObject.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit 89372e62454a72c6c400f00bfe3221bc0fe6d23e Author: Michael Weghorn AuthorDate: Fri Jun 21 20:39:46 2024 +0200 Commit: Michael Weghorn CommitDate: Fri Jun 21 23:19:09 2024 +0200 tdf#149461 qt5: Provide a QWindow for OpenGL rendering on X11 When using the qt5 or kf5 VCL plugins on X11/XWayland (as can be forced using QT_QPA_PLUGIN=xcb on Wayland), ensure that a QWindow exists for the QtObjectWidget created in the QtObject ctor, as that is needed for OpenGL rendering. This makes OpenGL Impress slide transitions like the "Tiles" one work. Don't force native windows on Wayland, as that causes other issues, see also QtFrame::ResolveWindowHandle and the bugs referenced in there. Change-Id: I8fac34d2f1cc7cc723ad4570546276a05641dd88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169348 Reviewed-by: Michael Weghorn Tested-by: Jenkins diff --git a/vcl/qt5/QtObject.cxx b/vcl/qt5/QtObject.cxx index b9f1b804f95c..8c9535b41f20 100644 --- a/vcl/qt5/QtObject.cxx +++ b/vcl/qt5/QtObject.cxx @@ -48,6 +48,11 @@ QtObject::QtObject(QtFrame* pParent, bool bShow) // which is not a problem with the QtMultimedia approach that the qt6 VCL plugin uses; // stay with the QtObjectWidget introduced in commit 4366e0605214260e55a937173b0c2e02225dc843 m_pQWidget = new QtObjectWidget(*this); + +// invoke QWidget::winId() to ensure a native window for OpenGL rendering is available on X11, +// don't do it on Wayland, as that breaks rendering otherwise, s.a. QtFrame::ResolveWindowHandle +if (QGuiApplication::platformName() == "xcb") +m_pQWidget->winId(); m_pQWindow = m_pQWidget->windowHandle(); }
core.git: 2 commits - vcl/inc vcl/qt5
vcl/inc/qt5/QtObject.hxx|7 ++-
vcl/qt5/QtObject.cxx| 31 +--
vcl/qt5/QtOpenGLContext.cxx |9 +
3 files changed, 36 insertions(+), 11 deletions(-)
New commits:
commit b296b33cfbde5113f27ddef71a48380cb6ce5e06
Author: Michael Weghorn
AuthorDate: Fri Jun 21 19:53:50 2024 +0200
Commit: Michael Weghorn
CommitDate: Fri Jun 21 23:19:02 2024 +0200
tdf#149461 qt6: Provide a QWindow for OpenGL rendering
As described at [1], "QWindow supports rendering using
OpenGL [...]".
Using a QWindow for OpenGL rendering had been introduced
in
commit 56b19f9a814ae5a39ed760ee542d715493cd0bf3
Date: Fri Dec 14 12:44:20 2018 +0300
tdf#121247, tdf#121266 KDE5: Add basic support for OpenGL
, but then
commit 4366e0605214260e55a937173b0c2e02225dc843
Date: Tue May 24 11:34:59 2022 +0200
tdf#148864 Qt switch QtObjectWindow to QWidget
had switched from QWindow to QWidget, and OpenGL slide
transitions like the "Tiles" one stopped working.
At least for qt6, which now uses QtMultimedia for video
playback (see the tdf#145735 commits), issues like tdf#148864
("Kubuntu 22.04 LTS LibreOffice Impress 7.3.3 Fails to Play Embedded
Videos") and tdf#125517 ("LO Impress: Can't stop presentation
with video and go to the next slide") related to video playback
appear to be no problem, so switch back to using QWindow there.
Explicitly set the window background to transparent
in `QtOpenGLContext::ImplInit`, as not doing so
caused slide content in presentation mode to not
be updated properly when testing with the attachment 183972
from tdf#149461 on Wayland.
(This was not an issue when running on XWayland, i.e.
with QT_QPA_PLATFORM=xcb).
With this in place, OpenGL transitions work with qt6.
With QT_QPA_PLATFORM=xcb, it looks all fine in my tests
on Debian testing.
With QT_QPA_PLATFORM=wayland, the slide text from attachment 183972
sometimes incorrectly showed up for a fraction of a second after
the slide transition finished, then disappeared again until
it was triggered to show as it should (e.g. by pressing the right
arrow key), s. screencast attachment 194899 in tdf#149461.
A multitude of warnings like the following are shown on stderr
in that case, which don't show up for xcb:
warn:vcl.opengl:47352:47352:vcl/source/opengl/OpenGLHelper.cxx:709: GL
Error 0506 (invalid framebuffer operation) in file
/home/michi/development/git/libreoffice/slideshow/source/engine/opengl/TransitionImpl.cxx
at line 398
That looks like a separate issue to me, however which would
need further analysis.
Keep using the QtObjectWindow approach for qt5 to
not regress on video playback.
[1] https://doc.qt.io/qt-5/qtgui-index.html#opengl-and-opengl-es-integration
Change-Id: I6e1eb989254e2cbbfada6f719ee0518571df4c42
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169347
Tested-by: Jenkins
Reviewed-by: Michael Weghorn
diff --git a/vcl/inc/qt5/QtObject.hxx b/vcl/inc/qt5/QtObject.hxx
index bc5a8e584b8f..e5f9944d6b86 100644
--- a/vcl/inc/qt5/QtObject.hxx
+++ b/vcl/inc/qt5/QtObject.hxx
@@ -24,6 +24,7 @@
#include
#include
+#include
#include
class QtFrame;
@@ -36,7 +37,11 @@ class QtObject final : public QObject, public SalObject
SystemEnvData m_aSystemData;
QtFrame* m_pParent;
-QtObjectWidget* m_pQWidget;
+
+// window, required for OpenGL rendering
+QWindow* m_pQWindow;
+QWidget* m_pQWidget;
+
QRegion m_pRegion;
bool m_bForwardKey;
diff --git a/vcl/qt5/QtObject.cxx b/vcl/qt5/QtObject.cxx
index 229916bcd1ff..b9f1b804f95c 100644
--- a/vcl/qt5/QtObject.cxx
+++ b/vcl/qt5/QtObject.cxx
@@ -23,6 +23,7 @@
#include
#include
+#include
#include
#include
#include
@@ -36,7 +37,19 @@ QtObject::QtObject(QtFrame* pParent, bool bShow)
if (!m_pParent || !pParent->GetQWidget())
return;
-m_pQWidget = new QtObjectWidget(*this);
+if (QLibraryInfo::version().majorVersion() > 5)
+{
+m_pQWindow = new QWindow;
+m_pQWidget = QWidget::createWindowContainer(m_pQWindow,
pParent->GetQWidget());
+}
+else
+{
+// with the qt5 VCL plugin, the above would cause issues with video
playback (s. tdf#148864, tdf#125517),
+// which is not a problem with the QtMultimedia approach that the qt6
VCL plugin uses;
+// stay with the QtObjectWidget introduced in commit
4366e0605214260e55a937173b0c2e02225dc843
+m_pQWidget = new QtObjectWidget(*this);
+m_pQWindow = m_pQWidget->windowHandle();
+}
// set layout, used for video playback, see QtPlayer::createPlayerWindow
QVBoxLayout* layout = new QVBoxLayout;
@@ -58,10 +71,7 @@ QtObject::~QtObject()
}
}
-QWindow*
[Bug 160639] GIF draws over itself in presentation mode
https://bugs.documentfoundation.org/show_bug.cgi?id=160639 --- Comment #5 from Telesto --- Created attachment 194903 --> https://bugs.documentfoundation.org/attachment.cgi?id=194903=edit Screenshot @Stragu The red line is ghosting. Not visible in chromium. Visible with skia/raster skia/metal and "default" rendering Performance is also bad, especially in presentation mode; especially with skia/raster. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161737] New: Regression: spell checking triggered by NNBSP
https://bugs.documentfoundation.org/show_bug.cgi?id=161737 Bug ID: 161737 Summary: Regression: spell checking triggered by NNBSP Product: LibreOffice Version: 24.2.4.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: maxim.7x...@simplelogin.fr CC: so...@libreoffice.org In LO 24.2.4.2 using a narrow no-break space (NNBSP) next to any word is interpreted as a spelling mistake—contrary to the previous version (24.2.3.2). Using a classic no-break space (NBSP) do not trigger any error. Steps to Reproduce: 1. Create a new document in LibreOffice (Writer, Calc... do not matter) 2. Enable spell checking (if it was not the case yet) 3. Write a sentence and replace a space with a NNBSP (U+202F) 4. Wait for spell checking Actual Results: The word next to the NNBSP is now considered as misspelled. Expected Results: Words should be checked without considering NNBSP, NBSP, etc. Reproducible: Always User Profile Reset: No Version: 24.2.4.2 (X86_64) / LibreOffice Community Build ID: 420(Build:2) CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: kf5 (cairo+xcb) Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR Debian package version: 4:24.2.4-1~bpo12+1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161620] In Draw: Background transparency setting don't follow exporting to PNG.
https://bugs.documentfoundation.org/show_bug.cgi?id=161620 --- Comment #7 from Rene Hache --- Created attachment 194902 --> https://bugs.documentfoundation.org/attachment.cgi?id=194902=edit Stéphane's example on my laptop Stéphane's example on my laptop, A little difference between the 2 version. Like I said, it could be my screen, I even test different screen brightness settings, still always a litte different. I wonder if it's something else on my laptop that could cause this. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161620] In Draw: Background transparency setting don't follow exporting to PNG.
https://bugs.documentfoundation.org/show_bug.cgi?id=161620 --- Comment #6 from Rene Hache --- Created attachment 194901 --> https://bugs.documentfoundation.org/attachment.cgi?id=194901=edit Draw background Test for compare -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161620] In Draw: Background transparency setting don't follow exporting to PNG.
https://bugs.documentfoundation.org/show_bug.cgi?id=161620 --- Comment #5 from Rene Hache --- I updated to the latest version 24.2.4.2 (Hate updating, it reset my LibreOffice docuemnts pins on the taskbar icon, but that's a Windows issue, not LibreOffice) Still do the same thing, but with more research, recreating from a new test file, and a detail I forgot to check last time, I notice that exported PNG is indeed more transparent than the original JPG of the background, but still not as quite transparent as the ODG when I have it open on my screen. If I compare all 3 version of the background (original, PNG export and in Draw) I have 3 different transparency. It could be my screen and not LibreOffice. I will add "Draw BG Test Compare" as an example. It's not a huge deal, I could just increase the transparency a little more before exporting. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161724] FILEOPEN PPTX: image completely disappears, other quite off (zoomed in?)
https://bugs.documentfoundation.org/show_bug.cgi?id=161724 Telesto changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #2 from Telesto --- Confirm Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 151d997365f7bf271d63af535d29a9c3439c6d46 CPU threads: 8; OS: macOS 14.3; UI render: Skia/Raster; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161664] [CRASH] Assert fails when changing object area fill with the color tool in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=161664 --- Comment #6 from Regina Henschel --- It happens too for the color drop-down list in the properties part in the Sidebar. It does not happen, using the color drop-down list in the style dialog when creating a new style. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161632] Crash dragging item from gallery a second time into a document
https://bugs.documentfoundation.org/show_bug.cgi?id=161632 --- Comment #5 from Telesto --- No crash Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 151d997365f7bf271d63af535d29a9c3439c6d46 CPU threads: 8; OS: macOS 14.3; UI render: default; VCL: osx Locale: nl-NL (nl_NL.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161632] Crash dragging item from gallery a second time into a document
https://bugs.documentfoundation.org/show_bug.cgi?id=161632 Telesto changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=16 | |1461| Resolution|--- |DUPLICATE Status|NEEDINFO|RESOLVED --- Comment #4 from Telesto --- *** This bug has been marked as a duplicate of bug 161461 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161664] [CRASH] Assert fails when changing object area fill with the color tool in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=161664 Regina Henschel changed: What|Removed |Added CC||rb.hensc...@t-online.de --- Comment #5 from Regina Henschel --- Created attachment 194900 --> https://bugs.documentfoundation.org/attachment.cgi?id=194900=edit Callstack by VS I see the same problem with line color drop-line list from toolbar. Draw a line, open the drop-down, select color -> assert fails. I have used a clean debug-build from today master. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a820696263e62ffc7ebe0a9f6d51bec2e1354926 CPU threads: 32; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win Locale: de-DE (de_DE); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161645] Font Colour not working
https://bugs.documentfoundation.org/show_bug.cgi?id=161645 --- Comment #4 from Bogaboga Man --- (In reply to m_a_riosv from comment #3) > Pls don't sent private messages. > > Forwarded Message > Subject: Re: [Bug 161645] Font Colour not working > Date: Wed, 19 Jun 2024 20:17:45 +0200 > From: Dr. Mark Bugeja MD > To: bugzilla-dae...@bugs.documentfoundation.org > > > Dear Sirs/ Madams, > > Don't make life complicated. I have mentioned what needs to be looked into > and the rest is up to your developer/s to work it out. I merely opened a > blank sheet and wrote a few characters in a cell and tried to apply the > change font colour. The text remained unchanged. I did this AFTER I checked > the highlight option for col and row. > > Please simplify your reporting procedures and requirements. It is putting me > off reporting anything else I happen to encounter and I'd much rather use > some other software to get the jobs done. In fact I don't use libreoffice > that much to be quite honest because despite so many versions having been > released, there are still basic defects that seem to have slipped through > the net and no one seems to have noticed! Is the software checked at all for > basic functions before being released? > > Sorry if I may sound negative about all this but getting replies like this > puts me off! I appreciate it is free software but there is a limit to how > much one can tolerate. At least show that you have made some attempt to > replicate the issue being reported! If you did, you would not be asking > further clarifications. > > Mark I am interested in this. Can you attach the problem file? All is OK for me after checking with the latest release. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149461] OpenGL slide transitions not working properly with kf5 VCL plugin
https://bugs.documentfoundation.org/show_bug.cgi?id=149461 Michael Weghorn changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |m.wegh...@posteo.de |desktop.org | Status|NEW |ASSIGNED --- Comment #12 from Michael Weghorn --- Pending Gerrit changes: https://gerrit.libreoffice.org/c/core/+/169346 https://gerrit.libreoffice.org/c/core/+/169347 https://gerrit.libreoffice.org/c/core/+/169348 With these in place, the OpenGL slide transitions from attachment 183972 work fine for me with both, the qt5/kf5 and qt6/kf6 VCL plugins on X11. For qt6 on Wayland, I still see an issue: The slide text from attachment 18972 sometimes incorrectly showed up for a fraction of a second after the slide transition finished, then disappeared again until it was triggered to show as it should (e.g. by pressing the right arrow key), s. screencast attachment 194899. A multitude of warnings like the following are shown on stderr in that case, which don't show up for xcb: warn:vcl.opengl:47352:47352:vcl/source/opengl/OpenGLHelper.cxx:709: GL Error 0506 (invalid framebuffer operation) in file /home/michi/development/git/libreoffice/slideshow/source/engine/opengl/TransitionImpl.cxx at line 398 That's a separate issue, though, and might even be a problem elsewhere, e.g. in Qt. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 101220] Fonts subset into PDF are not being used to render PDF to canvas, receive questionable fallback replacement
https://bugs.documentfoundation.org/show_bug.cgi?id=101220 Buovjaga changed: What|Removed |Added See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=16 | |1733| CC||zarifah...@outlook.com --- Comment #39 from Buovjaga --- *** Bug 161733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 Bug 99746 depends on bug 161733, which changed state. Bug 161733 Summary: FILEOPEN PDF Layout of text in boxes varies due to font fallback https://bugs.documentfoundation.org/show_bug.cgi?id=161733 What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161733] FILEOPEN PDF Layout of text in boxes varies due to font fallback
https://bugs.documentfoundation.org/show_bug.cgi?id=161733 Buovjaga changed: What|Removed |Added Resolution|--- |DUPLICATE See Also|https://bugs.documentfounda | |tion.org/show_bug.cgi?id=10 | |1220| Status|UNCONFIRMED |RESOLVED --- Comment #12 from Buovjaga --- *** This bug has been marked as a duplicate of bug 101220 *** -- You are receiving this mail because: You are the assignee for the bug.
[Bug 135907] Undo of applying character style not working properly
https://bugs.documentfoundation.org/show_bug.cgi?id=135907 --- Comment #12 from aharnack --- The problem still persists in the described way. It can also be re-produced the following way: 1. open a new writer document and enter some text: "Lorem ipsum dolor sit amet" 2. save, close and re-open it (not strictly necessary but it makes the effect clearer) 4. select a word by double-clicking on it: "ipsum" 5. assign a character style clearly distinguishable from normal text like "Strong Emphasize" 6 collapse the selection by pressing ESC 7 select character style "Standard" (so that the next typed character would appear in default text style) 8 undo twice (by toolbar icon, menu entry or ctrl-Z) Changing the character style of the previously selected word to "Strong Emphasize"should have been undone now and the word should appear in normal text again, but it is still shown in "Strong Emphasize". However, the document is now marked as unchanged, as can be seen on the "Save" icon in the toolbar. Closing the document would not ask to save it. Saving the document with "Save As" under a different name, on the other hand, will contain the change. Interesting also the following effect, continuing immediately after point 8. above: 9. re-do once and undo once, now the selection is undone properly 10. re-do twice and undo twice, the problem is back again The issue has been re-produced on the following OO and LO versions: LibreOffice 7.4.7.2 on Debian 12.5 OpenOffice 4.1.15 on Debian 12.5 OpenOffice 4.1.15 on Windows 11 LibreOffice 7.0.7.2 on Debian 11.9 OpenOffice 4.1.15 on Debian 10.13 OpenOffice 4.1.6 on Windows 10 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 149461] OpenGL slide transitions not working properly with kf5 VCL plugin
https://bugs.documentfoundation.org/show_bug.cgi?id=149461 --- Comment #11 from Michael Weghorn --- Created attachment 194899 --> https://bugs.documentfoundation.org/attachment.cgi?id=194899=edit Screencast (presentation screen only) with qt6 on Wayland with pending fixes -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161733] FILEOPEN PDF Layout of text in boxes varies due to font fallback
https://bugs.documentfoundation.org/show_bug.cgi?id=161733 --- Comment #11 from Buovjaga --- (In reply to V Stuart Foote from comment #10) > Seems like a dupe of => WF see also bug 101220 and its dupes... Might be, but the difference between attachment 126482 from bug 101220 and Microsoft Print to PDF in this bug (as also tested by myself) is that attachment 126482 shows Calibri as the font while MS insists on applying CIDFont+F1 instead of Times New Roman. -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/source include/editeng
editeng/source/editeng/editeng.cxx | 18 ++
editeng/source/editeng/impedit.hxx |1 +
editeng/source/editeng/impedit3.cxx |6 ++
include/editeng/editeng.hxx |1 -
4 files changed, 13 insertions(+), 13 deletions(-)
New commits:
commit 6e3cefc89e80ec0f7fab058a583d3ac4c702400e
Author: Noel Grandin
AuthorDate: Fri Jun 21 17:36:06 2024 +0200
Commit: Noel Grandin
CommitDate: Fri Jun 21 20:51:41 2024 +0200
move ensureDocumentFormatted from EditEngine to ImpEditEngine
so we have the implementation in one class, instead of bouncing
back and forth between two.
Change-Id: I851578ff553b01fb7d48cf5aa8f7a2d795496751
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169340
Reviewed-by: Noel Grandin
Tested-by: Jenkins
diff --git a/editeng/source/editeng/editeng.cxx
b/editeng/source/editeng/editeng.cxx
index e86e4b40b5d4..7707ce81ce42 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -420,12 +420,6 @@ sal_Int32 EditEngine::GetParagraphCount() const
return getImpl().maEditDoc.Count();
}
-void EditEngine::ensureDocumentFormatted() const
-{
-if (!getImpl().IsFormatted())
-getImpl().FormatDoc();
-}
-
sal_Int32 EditEngine::GetLineCount( sal_Int32 nParagraph ) const
{
return getImpl().GetLineCount(nParagraph);
@@ -459,7 +453,7 @@ tools::Rectangle EditEngine::GetParaBounds( sal_Int32 nPara
)
sal_uInt32 EditEngine::GetTextHeight( sal_Int32 nParagraph ) const
{
-ensureDocumentFormatted();
+getImpl().EnsureDocumentFormatted();
sal_uInt32 nHeight = getImpl().GetParaHeight(nParagraph);
return nHeight;
}
@@ -801,14 +795,14 @@ bool EditEngine::PostKeyEvent( const KeyEvent& rKeyEvent,
EditView* pEditView, v
sal_uInt32 EditEngine::GetTextHeight() const
{
-ensureDocumentFormatted();
+getImpl().EnsureDocumentFormatted();
sal_uInt32 nHeight = !IsEffectivelyVertical() ? getImpl().GetTextHeight()
: getImpl().CalcTextWidth( true );
return nHeight;
}
sal_uInt32 EditEngine::CalcTextWidth()
{
-ensureDocumentFormatted();
+getImpl().EnsureDocumentFormatted();
sal_uInt32 nWidth = !IsEffectivelyVertical() ?
getImpl().CalcTextWidth(true) : getImpl().GetTextHeight();
return nWidth;
}
@@ -1147,7 +1141,7 @@ tools::Long EditEngine::GetFirstLineStartX( sal_Int32
nParagraph )
if ( pPPortion )
{
DBG_ASSERT(getImpl().IsFormatted() || !getImpl().IsFormatting(),
"GetFirstLineStartX: Doc not formatted - unable to format!");
-ensureDocumentFormatted();
+getImpl().EnsureDocumentFormatted();
const EditLine& rFirstLine = pPPortion->GetLines()[0];
nX = rFirstLine.GetStartPosX();
}
@@ -1192,7 +1186,7 @@ bool EditEngine::IsRightToLeft( sal_Int32 nPara ) const
bool EditEngine::IsTextPos( const Point& rPaperPos, sal_uInt16 nBorder )
{
-ensureDocumentFormatted();
+getImpl().EnsureDocumentFormatted();
// take unrotated positions for calculation here
Point aDocPos = GetDocPos( rPaperPos );
@@ -1580,7 +1574,7 @@ tools::Rectangle EditEngine::GetCharacterBounds( const
EPosition& rPos ) const
ParagraphInfos EditEngine::GetParagraphInfos( sal_Int32 nPara )
{
// This only works if not already in the format ...
-ensureDocumentFormatted();
+getImpl().EnsureDocumentFormatted();
ParagraphInfos aInfos;
aInfos.bValid = getImpl().IsFormatted();
diff --git a/editeng/source/editeng/impedit.hxx
b/editeng/source/editeng/impedit.hxx
index 6a686723a184..768bbbadfc29 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -988,6 +988,7 @@ public:
void ScaleContentToFitWindow(o3tl::sorted_vector&
rRepaintParagraphs);
void FormatDoc();
void FormatFullDoc();
+void EnsureDocumentFormatted();
voidDraw( OutputDevice& rOutDev, const Point&
rStartPos, Degree10 nOrientation );
voidDraw( OutputDevice& rOutDev, const
tools::Rectangle& rOutRect, const Point& rStartDocPos, bool bClip );
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index df5a13a83e71..7c1ccc19cfa8 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -500,6 +500,12 @@ void
ImpEditEngine::ScaleContentToFitWindow(o3tl::sorted_vector& aRep
}
}
+void ImpEditEngine::EnsureDocumentFormatted()
+{
+if (!IsFormatted())
+FormatDoc();
+}
+
void ImpEditEngine::FormatDoc()
{
if (!IsUpdateLayout() || IsFormatting())
diff --git a/include/editeng/editeng.hxx b/include/editeng/editeng.hxx
index 27e5da82febc..e2b40613b0f2 100644
--- a/include/editeng/editeng.hxx
+++ b/include/editeng/editeng.hxx
@@ -196,7 +196,6 @@ private:
SAL_DLLPRIVATE bool HasText() const;
SAL_DLLPRIVATE const EditSelectionEngine& GetSelectionEngine() const;
SAL_DLLPRIVATE void SetInSelectionMode(bool b);
-
[Bug 101220] Fonts subset into PDF are not being used to render PDF to canvas, receive questionable fallback replacement
https://bugs.documentfoundation.org/show_bug.cgi?id=101220 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1733 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161733] FILEOPEN PDF Layout of text in boxes varies due to font fallback
https://bugs.documentfoundation.org/show_bug.cgi?id=161733 V Stuart Foote changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=10 ||1220 --- Comment #10 from V Stuart Foote --- Seems like a dupe of => WF see also bug 101220 and its dupes... -- You are receiving this mail because: You are the assignee for the bug.
[Bug 99746] [META] PDF import filter in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=99746 V Stuart Foote changed: What|Removed |Added Depends on||161733 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=161733 [Bug 161733] FILEOPEN PDF Layout of text in boxes varies due to font fallback -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161733] FILEOPEN PDF Layout of text in boxes varies due to font fallback
https://bugs.documentfoundation.org/show_bug.cgi?id=161733 V Stuart Foote changed: What|Removed |Added Blocks||99746 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=99746 [Bug 99746] [META] PDF import filter in Draw -- You are receiving this mail because: You are the assignee for the bug.
[Bug 158454] Add Thai Autocorrect Support
https://bugs.documentfoundation.org/show_bug.cgi?id=158454 --- Comment #4 from Commit Notification --- Theppitak Karoonboonyanan committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/76c96ca7c9a6e0d847ec5dc186c6e47ab6061f5f tdf#158454 Add Thai Autocorrect Support, coding part It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
core.git: editeng/qa editeng/source include/editeng sw/qa sw/source
editeng/qa/unit/core-test.cxx| 33 +++-
editeng/source/editeng/edtspell.cxx | 62 +---
editeng/source/misc/svxacorr.cxx | 231 +--
include/editeng/svxacorr.hxx | 72 -
sw/qa/extras/uiwriter/data/tdf158454.odt |binary
sw/qa/extras/uiwriter/uiwriter6.cxx | 39 +
sw/source/core/edit/acorrect.cxx | 176 ---
7 files changed, 451 insertions(+), 162 deletions(-)
New commits:
commit 76c96ca7c9a6e0d847ec5dc186c6e47ab6061f5f
Author: Theppitak Karoonboonyanan
AuthorDate: Thu Nov 30 22:34:29 2023 +0700
Commit: Jonathan Clark
CommitDate: Fri Jun 21 20:34:22 2024 +0200
tdf#158454 Add Thai Autocorrect Support, coding part
SvxAutoCorrDoc::ChgAutoCorrWord() implementations: correct multiple patterns
* include/editeng/svxacorr.hxx, editeng/source/misc/svxacorr.cxx:
- Add classes SvxAutocorrWordList::{Iterator,WordSearchStatus}.
- Make SvxAutocorrWordList::SearchWordsInList() return WordSearchStatus
so the search can be continued with the added
SvxAutocorrWordList::SearchWordsNext() method.
- Make SvxAutoCorrect::SearchWordsInList(), and its
lcl_SearchWordsInList()
companion, return WordSearchStatus propagated from
SvxAutocorrWordList::SearchWordsInList().
- SvxAutocorrWordList::WordMatches():
The existing mechanism of preventing collision of patterns like in
tdf#83037 (→ and ← and ↔ autocorrect collisions) was by storing
the matched string of wildcard pattern back to the list without
overwriting existing one. If the matched string was found in the list,
it would just be treated as no matching.
While this worked well for collision prevention, it caused failure
on the new exhaustive wildcard pattern visiting method when
autocorrecting
the second text chunk with the same content. In such situation,
all intermediate stages of corrections of the first text chunk would be
recorded into the list. And, in the second chunk, the first stage would
just be applied from the recorded pattern, but all the next stages
would be refused due to the "collision" with the recorded patterns.
Moreover, the new method would cause the list to grow more quickly
as the autocorrections are done.
To solve the problem, just "peek" for the collision instead of
actually storing it. And SvxAutocorrWordList::ContainsPattern()
is added for this purpose.
* editeng/qa/unit/core-test.cxx:
- Modify TestAutoCorrDoc::ChgAutoCorrWord() to iterate through all
patterns,
instead of finishing at the first one.
* editeng/source/editeng/edtspell.cxx:
- Ditto for EdtAutoCorrDoc::ChgAutoCorrWord().
* sw/source/core/edit/acorrect.cxx:
- Ditto for SwAutoCorrDoc::ChgAutoCorrWord().
- SwAutoCorrDoc::ChgAutoCorrWord(): Remove old dead code for
autocorrection
on text with redlines.
* sw/qa/extras/uiwriter/uiwriter6.cxx,
+sw/qa/extras/uiwriter/data/tdf158454.odt:
- Add unit test "testTdf158454".
Change-Id: I8fb4a628a977b79b0ed2f239fd3749f15823b5df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160160
Tested-by: Jenkins
Reviewed-by: Jonathan Clark
diff --git a/editeng/qa/unit/core-test.cxx b/editeng/qa/unit/core-test.cxx
index a57a533c42c4..f4032b09e120 100644
--- a/editeng/qa/unit/core-test.cxx
+++ b/editeng/qa/unit/core-test.cxx
@@ -440,18 +440,35 @@ private:
{
//fprintf(stderr, "TestAutoCorrDoc::ChgAutoCorrWord
");
-if (m_rText.isEmpty())
+if (m_rText.isEmpty()) {
return false;
+}
LanguageTag aLanguageTag(m_eLang);
-const SvxAutocorrWord* pFnd
-= rACorrect.SearchWordsInList(m_rText, rSttPos, nEndPos, *this,
aLanguageTag);
-if (pFnd && pFnd->IsTextOnly())
+sal_Int32 sttPos = rSttPos;
+auto pStatus = rACorrect.SearchWordsInList(m_rText, sttPos, nEndPos,
+ *this, aLanguageTag);
+if (pStatus)
{
-m_rText = m_rText.replaceAt(rSttPos, nEndPos, pFnd->GetLong());
-if (pPara)
-pPara->clear(); // =>GetString();
-return true;
+sal_Int32 minSttPos = sttPos;
+do {
+const SvxAutocorrWord* pFnd = pStatus->GetAutocorrWord();
+if (pFnd && pFnd->IsTextOnly())
+{
+m_rText = m_rText.replaceAt(sttPos, nEndPos,
pFnd->GetLong());
+nEndPos = sttPos + pFnd->GetLong().getLength();
+if( pPara ) {
+pPara->clear(); // =>GetString();
+}
+return true;
+}
+if (sttPos < minSttPos) {
+minSttPos
[Bug 158454] Add Thai Autocorrect Support
https://bugs.documentfoundation.org/show_bug.cgi?id=158454 Commit Notification changed: What|Removed |Added Whiteboard|target:24.8.0 |target:24.8.0 |target:24.2.0.2 |target:24.2.0.2 ||target:25.2.0 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161733] FILEOPEN PDF Layout of text in boxes varies due to font fallback
https://bugs.documentfoundation.org/show_bug.cgi?id=161733 V Stuart Foote changed: What|Removed |Added CC||vsfo...@libreoffice.org --- Comment #9 from V Stuart Foote --- Created attachment 194898 --> https://bugs.documentfoundation.org/attachment.cgi?id=194898=edit PDF inserted as image rendered with full fidelity And no font issues in PDF handling with the pdfium insert image filter rather than poppler/cairo open filter. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144208] Slow File OPEN of 477 pages ODT with 282 comments and track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=144208 --- Comment #27 from Buovjaga --- (In reply to Telesto from comment #26) > There is substantial an improvement file-open performance :-). > > But, I want to note, the fixes here create a hug discrepancy between opening > performance and the overall experience working with the document itself > > A) scroll document with mouse scroll wheel or by Pressing Page Down in > single page view causes. A very choppy scroll experience (waiting 5 second > before a page appears on my old machine). Independent if the changes being > visible or hidden > > B) Opening Manage changes dialog is slow. Reject entry inside the manage > changes dialog being slow as well (bug 161736) > > I somewhat optimistically expected/hoped those would be gone (indirectly) by > all the optimizations done for file-open. Appears not to be the case. For slowness in editing we do have bug 60418, bug 61558 and bug 119175. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144208] Slow File OPEN of 477 pages ODT with 282 comments and track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=144208 --- Comment #26 from Telesto --- There is substantial an improvement file-open performance :-). But, I want to note, the fixes here create a hug discrepancy between opening performance and the overall experience working with the document itself A) scroll document with mouse scroll wheel or by Pressing Page Down in single page view causes. A very choppy scroll experience (waiting 5 second before a page appears on my old machine). Independent if the changes being visible or hidden B) Opening Manage changes dialog is slow. Reject entry inside the manage changes dialog being slow as well (bug 161736) I somewhat optimistically expected/hoped those would be gone (indirectly) by all the optimizations done for file-open. Appears not to be the case. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161736] Manage changes dialog opens very slowly and rejecting entry's is slow too (for complex ODT with track changes and comments)
https://bugs.documentfoundation.org/show_bug.cgi?id=161736 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||4208 -- You are receiving this mail because: You are the assignee for the bug.
[Bug 144208] Slow File OPEN of 477 pages ODT with 282 comments and track changes
https://bugs.documentfoundation.org/show_bug.cgi?id=144208 Telesto changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=16 ||1736 -- You are receiving this mail because: You are the assignee for the bug.
core.git: sw/qa
sw/qa/extras/ooxmlexport/data/tdf161631.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport21.cxx | 11 +++
2 files changed, 11 insertions(+)
New commits:
commit a820696263e62ffc7ebe0a9f6d51bec2e1354926
Author: Xisco Fauli
AuthorDate: Fri Jun 21 17:07:39 2024 +0200
Commit: Xisco Fauli
CommitDate: Fri Jun 21 19:37:49 2024 +0200
tdf#161631: sw_ooxmlexport21: Add unittest
Change-Id: I1496b82e67c5f408bd682b4998e3afaf74c37318
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169339
Tested-by: Jenkins
Reviewed-by: Xisco Fauli
diff --git a/sw/qa/extras/ooxmlexport/data/tdf161631.docx
b/sw/qa/extras/ooxmlexport/data/tdf161631.docx
new file mode 100644
index ..a1e91c05633c
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/tdf161631.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
index 81a5703b9ced..43dff8ae68cf 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport21.cxx
@@ -38,6 +38,17 @@ public:
}
};
+DECLARE_OOXMLEXPORT_TEST(testTdf161631, "tdf161631.docx")
+{
+CPPUNIT_ASSERT_EQUAL(1, getPages());
+CPPUNIT_ASSERT_EQUAL(1, getParagraphs());
+
+// Without the fix in place, this test would have failed with
+// - Expected: Some text
+// - Actual :
+CPPUNIT_ASSERT_EQUAL(u"Some text"_ustr, getParagraph(1)->getString());
+}
+
DECLARE_OOXMLEXPORT_TEST(testTdf158597, "tdf158597.docx")
{
// test with 2 properties: font size, italic (toggle)
[Bug 161736] New: Manage changes dialog opens very slowly and rejecting entry's is slow too (for complex ODT with track changes and comments)
https://bugs.documentfoundation.org/show_bug.cgi?id=161736 Bug ID: 161736 Summary: Manage changes dialog opens very slowly and rejecting entry's is slow too (for complex ODT with track changes and comments) Product: LibreOffice Version: 25.2.0.0 alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: Manage changes dialog opens very slowly and rejecting entry's is slow too (for complex ODT with track changes and comments) Steps to Reproduce: 1. Open attachment 167028 (bug 144208) (wait until CPU drops) 2. Edit -> Track Changes -> Manage (Dialog takes long time to load) 3. Press reject to reject the first entry; freezing again) Actual Results: Very slow workflow Expected Results: Bit faster. Lots of time appears to be spend in TransferableHelper::TransferableHelper Reproducible: Always User Profile Reset: No Additional Info: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c39e4f6b8a942680bc7250177c34fd034a0605e0 CPU threads: 4; OS: Windows 8.1 X86_64 (6.3 build 9600); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161735] New: UI: Manage changes dialog reopens when launching Writer after crash with Manage Change dialog open
https://bugs.documentfoundation.org/show_bug.cgi?id=161735 Bug ID: 161735 Summary: UI: Manage changes dialog reopens when launching Writer after crash with Manage Change dialog open Product: LibreOffice Version: 25.2.0.0 alpha0+ Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: tele...@surfxs.nl Description: UI: Manage changes dialog reopens when launching Writer after crash with Manage Change dialog open Steps to Reproduce: 1. Open Writer 2. Edit -> Track Changes -> Manage Changes 3. Kill the soffice process 4. Launch LibreOffice (start center) 5. Click Writer -> Manage Changes dialog opens It's not only annoying bit also impractical. 1. Open attachment 167028 2. Edit -> Track Changes -> Manage Changes (LibO will freeze) 3. Kill the soffice process 4. Ignore the recovery 5. Launch LibreOffice (start center) 6. Open attachment 167028 -> again a hang Actual Results: UI: Manage changes dialog reopens when launching Writer after crash with Manage Change dialog open Expected Results: No restoring of the manage change dialog Reproducible: Always User Profile Reset: No Additional Info: Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: c39e4f6b8a942680bc7250177c34fd034a0605e0 CPU threads: 4; OS: Windows 8.1 X86_64 (6.3 build 9600); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded -- You are receiving this mail because: You are the assignee for the bug.
core.git: Branch 'libreoffice-24-8' - external/libcmis ucb/source
external/libcmis/UnpackedTarball_libcmis.mk |1
external/libcmis/exceptions.patch.1 | 171
ucb/source/ucp/cmis/cmis_content.cxx| 35 +
ucb/source/ucp/cmis/cmis_repo_content.cxx | 35 +
4 files changed, 240 insertions(+), 2 deletions(-)
New commits:
commit 16c0dfed795e2c6cfb88488f776f1ef496079c99
Author: Michael Stahl
AuthorDate: Fri Jun 21 15:48:05 2024 +0200
Commit: Michael Stahl
CommitDate: Fri Jun 21 19:17:27 2024 +0200
libcmis,ucb: get more informative error messages for CMIS UCP
Currently it reports pretty much everything as
"The specified device is invalid."
but clearly we can do better.
Try not to change the public API of libcmis too much; it has 2 string
members in libcmis::Exception, add a bunch more type values such as
"dnsFailed", "connectFailed", "connectTimeout", "transferFailed".
Also there were 2 HttpSession functions that convert libcmis::Exception
to CurlException - very odd, was apparently done to appease Coverity,
but the exception specifications that caused Coverity to complain were
removed from libcmis anyway; let's remove that, every caller of these
functions i looked at would immediately convert it back to
libcmis::Exception anyway.
Change-Id: Iee853af8bb541e6b071b75d593b6c031f67a886d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169335
Tested-by: Jenkins
Reviewed-by: Michael Stahl
(cherry picked from commit f91effb36b2be1ff8937d684191fb2f19d6ac97d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169303
diff --git a/external/libcmis/UnpackedTarball_libcmis.mk
b/external/libcmis/UnpackedTarball_libcmis.mk
index ede32bc8fad3..af5feed5e96a 100644
--- a/external/libcmis/UnpackedTarball_libcmis.mk
+++ b/external/libcmis/UnpackedTarball_libcmis.mk
@@ -21,6 +21,7 @@ $(eval $(call gb_UnpackedTarball_add_patches,libcmis,\
external/libcmis/http-session-cleanup.patch.1 \
external/libcmis/factory-no-retry-ssl.patch.1 \
external/libcmis/sharepoint-auth.patch.1 \
+ external/libcmis/exceptions.patch.1 \
))
# vim: set noet sw=4 ts=4:
diff --git a/external/libcmis/exceptions.patch.1
b/external/libcmis/exceptions.patch.1
new file mode 100644
index ..29a66f229c4c
--- /dev/null
+++ b/external/libcmis/exceptions.patch.1
@@ -0,0 +1,171 @@
+--- libcmis/src/libcmis/http-session.cxx.orig 2024-06-21 12:22:36.083125022
+0200
libcmis/src/libcmis/http-session.cxx 2024-06-21 13:08:37.403016695
+0200
+@@ -653,7 +653,8 @@
+ m_authProvided = authProvider->authenticationQuery( m_username,
m_password );
+ if ( !m_authProvided )
+ {
+-throw CurlException( "User cancelled authentication request" );
++// report this as 401 so it becomes permissionDenied
++throw CurlException("User cancelled authentication request",
CURLE_OK, "", 401);
+ }
+ }
+ }
+@@ -762,6 +762,7 @@
+ if ( CURLE_SSL_CACERT == errCode )
+ {
+ vector< string > certificates;
++string err(errBuff);
+
+ // We somehow need to rerun the request to get the certificate
+ curl_easy_setopt(m_curlHandle, CURLOPT_SSL_VERIFYHOST, 0);
+@@ -814,7 +815,7 @@
+ }
+ else
+ {
+-throw CurlException( "Invalid SSL certificate" );
++throw CurlException(err, CURLE_SSL_CACERT);
+ }
+ }
+ }
+@@ -827,7 +828,6 @@
+
+
+ void HttpSession::checkOAuth2( string url )
+-try
+ {
+ if ( m_oauth2Handler )
+ {
+@@ -836,10 +836,6 @@
+ oauth2Authenticate( );
+ }
+ }
+-catch ( const libcmis::Exception& e )
+-{
+-throw CurlException( e.what( ) );
+-}
+
+ long HttpSession::getHttpStatus( )
+ {
+@@ -906,15 +902,10 @@
+ }
+
+ void HttpSession::oauth2Refresh( )
+-try
+ {
+ const ScopeGuard inOauth2Guard(m_inOAuth2Authentication, true);
+ m_oauth2Handler->refresh( );
+ }
+-catch ( const libcmis::Exception& e )
+-{
+-throw CurlException( e.what() );
+-}
+
+ void HttpSession::initProtocols( )
+ {
+@@ -981,11 +972,43 @@
+ break;
+ default:
+ msg = what();
+-if ( !isCancelled( ) )
+-msg += ": " + m_url;
+-else
+-type = "permissionDenied";
+-break;
++switch (m_code)
++{
++case CURLE_COULDNT_RESOLVE_PROXY:
++case CURLE_COULDNT_RESOLVE_HOST:
++type = "dnsFailed";
++break;
++case CURLE_COULDNT_CONNECT:
++case CURLE_SSL_CONNECT_ERROR:
++case CURLE_SSL_CERTPROBLEM:
++case CURLE_SSL_CIPHER:
++case CURLE_PEER_FAILED_VERIFICATION:
++#if CURL_AT_LEAST_VERSION(7, 19, 0)
++case
[Bug 106045] [META] Vertical and rotated text direction issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106045 Bug 106045 depends on bug 155772, which changed state. Bug 155772 Summary: Japanese, vertical CTL text: some pasted text displayed incorrectly https://bugs.documentfoundation.org/show_bug.cgi?id=155772 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 83066] [META] CJK (Chinese, Japanese, Korean, and Vietnamese) language issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 155772, which changed state. Bug 155772 Summary: Japanese, vertical CTL text: some pasted text displayed incorrectly https://bugs.documentfoundation.org/show_bug.cgi?id=155772 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 155772] Japanese, vertical CTL text: some pasted text displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=155772 Jonathan Clark changed: What|Removed |Added Resolution|--- |FIXED Version|7.5.4.2 release |Inherited From OOo Assignee|libreoffice-b...@lists.free |jonat...@libreoffice.org |desktop.org | Status|NEW |RESOLVED Whiteboard||target:25.2.0 --- Comment #9 from Jonathan Clark --- After applying the fix for bug 107209, I can no longer reproduce this issue. It's likely this was a duplicate, but the steps to reproduce are very different and don't fit my current understanding of the issue. I think it would be best to separately verify this bug, so I am instead marking it fixed. Jonathan Clark committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c7f1e41ca672f6bb1055b92012fff0d92a5ff805 tdf#107209 Writer correct vertical text break after fly portions It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161086] bitmap image transforms itself depending on position on a page - SVG with an embedded PNG
https://bugs.documentfoundation.org/show_bug.cgi?id=161086 Noel Grandin changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 161734] LibreOffice 7.6 - Error message when opening LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=161734 --- Comment #1 from stepped_canyon...@icloud.com --- Created attachment 194897 --> https://bugs.documentfoundation.org/attachment.cgi?id=194897=edit Screenshot of Warning Message when opening LibreOffice.app or existing docx, doc, xls or xslx file -- You are receiving this mail because: You are the assignee for the bug.
core.git: svx/source svx/uiconfig
svx/source/form/filtnav.cxx|2 +- svx/uiconfig/ui/filternavigator.ui | 13 + 2 files changed, 10 insertions(+), 5 deletions(-) New commits: commit c5bbbe987321d8f9e101fab9d67ddbf3d4f8dfca Author: Jim Raykowski AuthorDate: Thu Jun 20 17:04:11 2024 -0800 Commit: Jim Raykowski CommitDate: Fri Jun 21 18:29:40 2024 +0200 tdf#161537 fix Filter Navigator no longer shows the name of the field Change-Id: I3dae3458ac5795b217743b1e6897345a22f1bf61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169310 Reviewed-by: Jim Raykowski Tested-by: Jenkins diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx index 722deefaca35..fe633e9fdd20 100644 --- a/svx/source/form/filtnav.cxx +++ b/svx/source/form/filtnav.cxx @@ -1061,7 +1061,7 @@ FmFilterNavigator::FmFilterNavigator(vcl::Window* pTopLevel, std::unique_ptrconnect_custom_get_size(LINK(this, FmFilterNavigator, CustomGetSizeHdl)); m_xTreeView->connect_custom_render(LINK(this, FmFilterNavigator, CustomRenderHdl)); -m_xTreeView->set_column_custom_renderer(0, true); +m_xTreeView->set_column_custom_renderer(1, true); m_xTreeView->connect_changed(LINK(this, FmFilterNavigator, SelectHdl)); m_xTreeView->connect_key_press(LINK(this, FmFilterNavigator, KeyInputHdl)); diff --git a/svx/uiconfig/ui/filternavigator.ui b/svx/uiconfig/ui/filternavigator.ui index 46820867f42e..8999be58f37b 100644 --- a/svx/uiconfig/ui/filternavigator.ui +++ b/svx/uiconfig/ui/filternavigator.ui @@ -4,7 +4,7 @@ - + @@ -43,16 +43,21 @@ - + +False + + + + 6 - + 0 - + True
[Bug 113195] [META] Japanese language-specific CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113195 Bug 113195 depends on bug 107209, which changed state. Bug 107209 Summary: Text layout error; text lines overlap randomly in long "complicated" documents https://bugs.documentfoundation.org/show_bug.cgi?id=107209 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Bug 106045] [META] Vertical and rotated text direction issues
https://bugs.documentfoundation.org/show_bug.cgi?id=106045 Bug 106045 depends on bug 107209, which changed state. Bug 107209 Summary: Text layout error; text lines overlap randomly in long "complicated" documents https://bugs.documentfoundation.org/show_bug.cgi?id=107209 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: svx/uiconfig
svx/uiconfig/ui/filternavigator.ui | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 28438a5b1f1903fe0a69d53f9bba7d3837380b57 Author: Jim Raykowski AuthorDate: Thu Jun 20 16:51:01 2024 -0800 Commit: Jim Raykowski CommitDate: Fri Jun 21 18:27:52 2024 +0200 Resave with newer Glade version Change-Id: I2b3adc322b4dc928069f306ccb673fa23fba70a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169309 Tested-by: Jenkins Reviewed-by: Jim Raykowski diff --git a/svx/uiconfig/ui/filternavigator.ui b/svx/uiconfig/ui/filternavigator.ui index 99297b0dc10f..46820867f42e 100644 --- a/svx/uiconfig/ui/filternavigator.ui +++ b/svx/uiconfig/ui/filternavigator.ui @@ -1,5 +1,5 @@ - + @@ -16,29 +16,29 @@ True -False +False True True True -True +True True True -in +in --1 +-1 True -True -True +True +True True True liststore1 -False +False True -1 -True +1 +True
[Bug 71732] [META] Bugs related to text rendering, typography and font features in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=71732 Bug 71732 depends on bug 107209, which changed state. Bug 107209 Summary: Text layout error; text lines overlap randomly in long "complicated" documents https://bugs.documentfoundation.org/show_bug.cgi?id=107209 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
core.git: drawinglayer/source
drawinglayer/source/processor2d/vclpixelprocessor2d.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 7b807a6b793198c00db9b2c2c3a5eb3ebfe16ad9
Author: Noel Grandin
AuthorDate: Fri Jun 21 12:28:30 2024 +0200
Commit: Noel Grandin
CommitDate: Fri Jun 21 18:25:10 2024 +0200
tdf#161086 bitmap location wrong with SVG with an embedded PNG
we need to transform the location of the wallpaper rect to match where
we want the wallpaper to start tiling from.
regression from
commit 3cbe3a0259bea4dec70e72191ec3c03441926a07
Author: Noel Grandin
Date: Mon Jun 14 15:05:59 2021 +0200
tdf#101083 speed up SVG rendering with pattern fill
Change-Id: I624edd63135875fdc9526015f0f5642d5c694934
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169332
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
index 4882847bcc2c..394b18ca7162 100644
--- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
+++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx
@@ -1091,6 +1091,10 @@ void VclPixelProcessor2D::processPatternFillPrimitive2D(
mpOutputDevice->IntersectClipRegion(vcl::Region(aMask));
Wallpaper aWallpaper(aTileImage);
aWallpaper.SetColor(COL_TRANSPARENT);
+Point aPaperPt(aMaskRect.getX() % aTileImage.GetSizePixel().Width(),
+ aMaskRect.getY() % aTileImage.GetSizePixel().Height());
+tools::Rectangle aPaperRect(aPaperPt, aTileImage.GetSizePixel());
+aWallpaper.SetRect(aPaperRect);
mpOutputDevice->DrawWallpaper(aMaskRect, aWallpaper);
mpOutputDevice->Pop();
return;
@@ -1117,6 +1121,10 @@ void VclPixelProcessor2D::processPatternFillPrimitive2D(
{
Wallpaper aWallpaper(aTileImage);
aWallpaper.SetColor(COL_TRANSPARENT);
+Point aPaperPt(aMaskRect.getX() % aTileImage.GetSizePixel().Width(),
+ aMaskRect.getY() % aTileImage.GetSizePixel().Height());
+tools::Rectangle aPaperRect(aPaperPt, aTileImage.GetSizePixel());
+aWallpaper.SetRect(aPaperRect);
mpOutputDevice->DrawWallpaper(aMaskRect, aWallpaper);
}
[Bug 161086] bitmap image transforms itself depending on position on a page - SVG with an embedded PNG
https://bugs.documentfoundation.org/show_bug.cgi?id=161086 --- Comment #7 from Commit Notification --- Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b807a6b793198c00db9b2c2c3a5eb3ebfe16ad9 tdf#161086 bitmap location wrong with SVG with an embedded PNG It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
