[GSoC] Final Report

[Aditya Sahu]

Hi,
You can check the final GSoC Report here [1]. Thank you LibreOffice
community for guidance and help. Special thanks to Tomaž who was super
helpful during the whole project. I'm grateful to do this project with such
a great mentor.
I will be submitting final changes in upcoming days and keep you updated
about the progress. It has been a pleasure contributing to LO.

Warm Regards,
Aditya Sahu


[1] https://gist.github.com/aditya-sahu/b36dfe02c4f58b869bde18d47030a04a
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 12 Report

[Aditya Sahu]

Hi,
I'm working on some last additions on the XML Engine. Last week I worked on
adding a ZIP file, and writing mimetype and xml file+content inside it. I
implemented GalleryXMLEngine::writeGalleryTheme, and am now working towards
reading part of it so that tests work for the XML Engine as well.

Warm Regards,
Aditya Sahu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 11 Report

[Aditya Sahu]

Hi, sorry for late submission. Here's the week 11 highlights:
* Started implementing writeGalleryTheme for GalleryXMLEngine [1]
* Refactoring of GalleryObjectCollection is still required before anything
- so looking into that


[1] https://gerrit.libreoffice.org/c/core/+/100609

Warm Regards,
Aditya Sahu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 10 Report

[Aditya Sahu]

Hi,
Week 10 report:
* Introduced GalleryFileStorage interface that would be used by XML and
binary engines
+ It is empty right now, but as I add methods in XML Engine,
sequentially those methods will be added one by one
* Working on GalleryXMLEngine now
+ [1] introduced it - however, currently it's WIP.
+ So far, I have learnt how to read ZIP files, read XML files, write to
XML files
* XML walker to access the xml files
* XML writer to write them, element by element

To do for this week:
* Learn to do encapsulation of multiple files in a ZIP is left
* Add methods to GalleryXMLEngine and by the end of the week, have it
working

Warm Regards,
Aditya Sahu


[1] https://gerrit.libreoffice.org/c/core/+/100158
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 9 Report

[Aditya Sahu]

Hi all,
9 weeks have been completed and here are the highlights of what I did last
week:
* Commit [1] and [2] were reviewed and pushed to remote
+ They're already summarized in my previous email
* Commit [3] was pushed to remote
+ It implements 3 functions of GalleryObjectCollection class
* Worked on Commit [4] and [5]
+ It is yet to be pushed to remote
* Refactoring work is almost done
+ Final changes remaining
+ Plan is to do them alongside the next phase
* I have published some articles on the work done till now
+ [5] briefs the project summary and distribution of phases (7 min read)
+ [6] elaborates on the unit testing phase (4 min read)
+ [7] is about refactoring work done till now (6 min read)

Tasks for next week:
* Create an XML engine which would read from and write to XML files
* Learn to create a ZIP file, put contents in it, read/write from/to it
(design of the ZIP file should be similar to ODF)

I'll be waiting for feedback.
Warm Regards,
Aditya Sahu

References:
[1] https://gerrit.libreoffice.org/c/core/+/99035
[2] https://gerrit.libreoffice.org/c/core/+/99479
[3] https://gerrit.libreoffice.org/c/core/+/99789
[4] https://gerrit.libreoffice.org/c/core/+/99940
[5]
https://medium.com/@adityasahu1511/google-summer-of-code-with-libreoffice-project-overview-bb993b4d067b?source=friends_link&sk=81f8f10ca4fe50785bd86c4c6aef1b9d
[6]
https://medium.com/@adityasahu1511/google-summer-of-code-20-with-libreoffice-part-1-9bcf11a05701?source=friends_link&sk=27e7df527c6b06f195ca7fb3d8164515
[7]
https://medium.com/@adityasahu1511/google-summer-of-code-20-with-libreoffice-part-2-26033988dbd0?source=friends_link&sk=851f56d3f80d76538a70034771bd8510
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 8 Report

[Aditya Sahu]

Hi, sorry for sending the report a bit late - got caught up in some
personal business. Here are the highlights of last week:

* Change [1] was pushed to remote this week.
+ Implement GalleryStorageLocations, a shared class which contains
locations
 to binary files like aThmURL, aSdgURL, aSdvURL and aStrURL.
+ The class shares its members between GalleryBinaryEngine and
GalleryBinaryEngineEntry.

* Change [2] was completed and is under review
+ Implemented GalleryObjectCollection, a shared class which contains an
object list to be used by GalleryTheme and GalleryBinaryEngine.
* Renaming of its functions is needed which will be done in an
upcoming change.
+  This class is primarily owned by GalleryTheme, and shared with
GalleryBinaryEngine.
+ This change also contains further refactoring work:
 * ImplCreateUniqueURL, InsertGraphic() were refactored.
 * Implements
comphelper::GraphicMimeTypeHelper::GetExtensionForConvertDataFormat()
 *   Refactors Actualize() and introduce updateSvDrawObject(),
updateTheme()
+ As pointed out by my mentor, I realize that this one specific change
is quite big and apologize for that; so from now on I will make sure to do
separate changes for different things/functionalities as it would be easier
to locate the commit if regression occurs.

* Change [3] is completed and under review
+ Refactored GalleryTheme::InsertFileOrDirURL function, leaving only
the last 3 functions from that class to be refactored.

[1] https://gerrit.libreoffice.org/c/core/+/98979
[2] https://gerrit.libreoffice.org/c/core/+/99035
[3] https://gerrit.libreoffice.org/c/core/+/99479

Warm Regards,
Aditya Sahu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 7 Report

[Aditya Sahu]

Hi,

* Change [1] was pushed to remote this week
+ Large change deals with 8 functions that were refactored
* Classes were re-structured further and implementing new classes for
better shareability
+ Change [2] deals with that - it's also a large patch and work is in
progress
To-do tasks for this week:
* Finish with this phase to move on to next one

[1] https://gerrit.libreoffice.org/c/core/+/98492
[2] https://gerrit.libreoffice.org/c/core/+/98979


Warm Regards,
Aditya Sahu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 6 Report

[Aditya Sahu]

Hi,

Here is the week 6 Report:
* Worked on patch [1] which was pushed to remote this week
+ Implemented InitGalleryTheme() and DestroyGalleryTheme() to handle
the lifecycle of SotStorage object
* Removed long chains from the code I wrote
+ e.g.,
pGalleryTheme2->pThm->getGalleryBinaryEngine()->GetSvDrawStorage() from the
code and improved it by implementing new functions in GalleryThemeEntry
+ Two chains were removed last week, a lot more to come in the next
patch
* Resumed working on refactoring more functions
+ Submitted [2] which is still WIP
+ GetModel() and GetModelStream() were refactored
+ implCreateUniqueURL() and ImplGetURL() are now in galmisc.cxx, which
is the right place for now..

To-do tasks for this week would be:
* Finish further refactoring on InsertModel(), InsertModelStream(),
InsertObject()
* GalleryTheme class should be done by the end of the week.

Warm Regards,
Aditya Sahu

.
[1] https://gerrit.libreoffice.org/c/core/+/96764
[2] https://gerrit.libreoffice.org/c/core/+/98492
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 5 Report

[Aditya Sahu]

Hi all,
I am excited to announce that the first evaluation has been completed and
I'm happy to have made it in the second phase of coding. Thanks to my
mentor for his continuous support. Here's the week 5 report:
* I was stuck with a problem and after not getting it myself, I discussed
it with my mentor
+ Basically, it occurred during the refactoring of aSvDrawStorageRef to
binary engine.
+ I did not give much time this week to work on this issue, that's why
there is a bit of lag.
+ Yesterday, after communicating with my mentor, I applied his solution
and now it seems to be working almost fine.. [1]
+ Will make further improvement to it today.


Warm Regards,
Aditya Sahu


[1] https://gerrit.libreoffice.org/c/core/+/96764
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 4 Report

[Aditya Sahu]

Hi,
It has been an exciting summer so far working towards the project. Special
thanks to my mentor for providing guidance. This week's highlights:
* Patch [1] was pushed to remote.
+ It moves three functionalities to the gallery binary engine
* Worked on another patch for moving more functionalities
+ After code review, there were mistakes that I need to work upon
+ Will try to fix them and provide a better patch.

Upcoming milestones:
* Try to finish refactoring to move to the next phase, hopefully done by
the end of this week.
* After the current phase is completed, publish a blog about the overall
progress and accomplishments.

Warm Regards,
Aditya Sahu


[1] https://gerrit.libreoffice.org/c/core/+/96541
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 3 Report

[Aditya Sahu]

Hey!

Week 3 report for project - Move the Gallery Code to Use ZIP Files:
* Done GalleryThemeEntry refactoring
+ 4 data members, 7 functions have been moved from GalleryThemeEntry
+ 4 new functions introduced to the binary engine.
+ Commit [1] was pushed to remote this week.
* Moved to GalleryTheme class for refactoring
+ Worked on commits [2] and [3] - yet to be pushed to remote.
+ Remaining with some more members to move -  the work is still in
progress..

Have a great week ahead!

Warm Regards,
Aditya Sahu


[1] https://gerrit.libreoffice.org/c/core/+/96253
[2] https://gerrit.libreoffice.org/c/core/+/96527
[3] https://gerrit.libreoffice.org/c/core/+/96764/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 2 Report

[Aditya Sahu]

Hello,

This was the second week for the project "Move Gallery Code to Use ZIP
Files". Learning some good stuff for sure! :)

This week's report:

* Continued refactoring of GalleryThemeEntry
+ Moved some R/W stuff to the new class GalleryBinaryEngine [1]
+ aThmURL, aSdgURL, aSdvURL, aStrURL are now part of GalleryBinaryEngine
+ Also moved some functions which now exist as
GalleryBinaryEngine::ImplGetURLIgnoreCase(),
GalleryBinaryEngine::CreateUniqueURL().
+  Hopefully, no change in external behaviour is reflected.
* My commit was reviewed and pushed to remote [2]
* One more patch on its way [3]

Thanks to my mentor and the org for their continuous guidance.

Warm Regards,
Aditya Sahu


[1]
https://opengrok.libreoffice.org/xref/core/include/svx/gallerybinaryengine.hxx?r=e0c9ed26#25
[2] https://gerrit.libreoffice.org/c/core/+/95922
[3] https://gerrit.libreoffice.org/c/core/+/96253
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Week 1 Report

[Aditya Sahu]

Hi,

This was the first week of GSoC project - quite good.. Here is this week's
report:

* Moved on to the next phase of the project i.e., code refactoring
+ Created GalleryBinaryEngine class that would deal with all the
reading and writing of files.
+ Must be done such that older classes have no knowledge of R/W of
files.
+ Started moving data members and functions from GalleryThemeEntry
class to the new class.
+ Work is in progress - just started moving stuff
* This week I wasn't able to provide solid results because most of the time
spent on reading the code than writing it
* My commit was pushed to remote this week [1]

Warm regards,
Aditya Sahu


[1] https://gerrit.libreoffice.org/c/core/+/94646
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Community Bonding Period Report

[Aditya Sahu]

Hi

* Started first phase of implementation of the project "Move Gallery Code
to ZIP File" [1]
+ Wrote unit tests for Gallery, GalleryTheme, GalleryThemeEntry classes.
+ Two commits were pushed to master [2], [3]
+ Familiarized myself with gallery codebase

* Tasks for next week when coding period begins
+ Finish remaining unit tests
+ Move to next phase of project

Thanks to mentor for continuous support. Will be sending a weekly report
when the coding period begins.

Hope you are keeping yourselves safe amidst the pandemic!

Warm regards,
Aditya Sahu
IRC: 

[1] https://summerofcode.withgoogle.com/projects/#5814711242719232
[2] https://gerrit.libreoffice.org/c/core/+/92679
[3] https://gerrit.libreoffice.org/c/core/+/93305
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC Introduction] Community Bonding Period

[Aditya Sahu]

Hi,

I am Aditya Sahu, final year computer science engineering undergrad from
New Delhi, India. My proposal for Google Summer of Code 2020 has been
selected this year for the project "Move the gallery code to use ZIP
files".

I would sincerely like to thank the LibreOffice team for your support and
the help that you provided me at times - from my first difficulty while
building LO on my system - to helping me fix difficult bugs.

I shall be reworking gallery code to eliminate the implementation of
binaries that LO presently uses to contain the themes. You can read more
about it here: [1]. Most grateful to my mentors: Tomaž Vajngerl and Michael
Meeks for filling me in with the details of the project with whom I shall
be working this summer.

I am available on both email and IRC if anyone feels the need to contact
me. My IRC nick is . Will provide weekly status update once
the coding period starts. Hope to have an exciting summer ahead!

Cheers,
Aditya Sahu


[1] https://summerofcode.withgoogle.com/projects/#5814711242719232
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Seeking Help in Resolving easyHack

[Aditya Sahu]

Hi,
I'm trying to fix tdf#47065
 as it's a
challenging *easyHack*. I have decided to move one step at a time in order
to resolve it at a slow and steady pace.
My first step is to find out a way to check if the lock from the previously
opened file is released and the file is now ready to use. In the change [1]
 ,
I have tried to check if the file lock has been disappeared, please let me
know if it is the right way to do it.  I also tested the change on my
local machine to see if it works.

I've made use of this expression:

*bool* bHandleSysLocked

= ( bLoading 

&& bUseSystemLock

&& !pImpl 
->xStream
.is
() && !pImpl
->m_pOutStream

);


Also, when reviewing the change, please try to ignore the function and
variable names which were chosen arbitrarily..
Any given help is appreciated. Thanks!

--
Regards,
Aditya

[1] https://gerrit.libreoffice.org/#/c/84919/4/sfx2/source/doc/docfile.cxx
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: header footer background images don't display on file reopen

[Aditya Sahu]

This e-mail is to inform that the bug tdf#116382 [1] has been resolved
successfully. Now, the menu item Border and Background accessed from header
and footer drop-down menu opens the "Border/Background" dialog with a
different set of tabpages ( Borders, Area and Transparency). This should
not cause the problem of disappearance of header/footer background image
each time when the .odt file is saved and re-opened.

The patch has also resolved some other bugs: tdf#115457
<https://bugs.documentfoundation.org/show_bug.cgi?id=115457>, tdf#100503
<https://bugs.documentfoundation.org/show_bug.cgi?id=100503>. Affected
users are requested to please verify that these bugs have been resolved by
the patch [2] and thereafter update their status. As for me, it was really
a great experience resolving the bug and it would not have been possible
without Jim's help. I look forward to resolve more easyHacks on
LibreOffice. Loving the community so far!  ☺

See:
[1] Resolved - Fixed : tdf#116382 :
https://bugs.documentfoundation.org/show_bug.cgi?id=116382
<https://bugs.documentfoundation.org/show_bug.cgi?id=116382>
[2] Patch can be found here : https://gerrit.libreoffice.org/#/c/67483/

Cheers,
Aditya Sahu 

On Thu, Feb 7, 2019 at 8:08 PM Michael Stahl  wrote:

> On 07.02.19 15:19, Michael Stahl wrote:
> > On 27.01.19 02:17, Jim Raykowski wrote:
> >> Trying to make header and footer background images redisplay on
> >> opening. I noticed draw:fill="bitmap" in
> >> style:header-footer-properties in a .fodt test file.
> >>
> >> ...
> >>
> >> 
> >>
> >> 
> >>
> >>  >> fo:margin-bottom="0.1965in" draw:fill="bitmap" style:repeat="repeat"
> >> draw:fill-image-ref-point="top-left">
> >>
> >> 
> >>
> >>
> iVBORw0KGgoNSUhEUgAAApUAAACpCAYAAAENcfbOCXBIWXMAAA7EAAAOxQGMMD9a
>
> >>
> >>
> >> ...
> >>
> >> If draw:fill="bitmap" is removed the image shows in the header on
> >> reopen. When not removed blue background fill is shown.
> >>
> >> Is draw:fill="bitmap" needed?
> >
> > what's odd about this is that you have draw:fill="bitmap" attribute but
> > not draw:fill-image-name="..." - that's even more invalid than Regina
> > says :)
> >
> > iirc the idea was that both draw:fill attributes (new and not-yet-valid)
> > and style:background-image element (old and valid) should be exported,
> > so that old LO/OOo versions can read the style:background-image and new
> > LO versions the draw:fill attributes which have more features.
> >
> > when i try with Writer 6.1, i get the draw:fill-image-name plus a couple
> > more (draw:opacity="100%" draw:fill-image-width="0cm"
> > draw:fill-image-height="0cm" style:repeat="repeat"
> > draw:fill-image-ref-point-x="0%" draw:fill-image-ref-point-y="0%"
> > draw:fill-image-ref-point="center" draw:tile-repeat-offset="0%
> > vertical") ... not sure why you manage to get only draw:fill?
>
> okay - it depends on *how* you set the background image.
>
> i've used the Format->Page dialog to set it, that works fine as above.
>
> but there's a second way, in the document view via the blue header
> button drop-down menu "Border and Backgrounds..." - set an image there
> and i get similar results as you (data loss).
>
> apparently there's a bug to have the blue button drop-down call the same
> dialog as Format->Page dialog, which ought to fix the problem.
>
> https://bugs.documentfoundation.org/show_bug.cgi?id=116382
>
>  is apparently working on this...
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Help regarding

[Aditya Sahu]

  1.  How to access the “mbEnableDrawingLayerFillStyles” from hdft::svx... for 
now I have set it to true and the dialog design has been changed to the new 
one(as needed) but , ti’s still dysfunctional as the handler has not been 
properly initialized with proper values..
  2.  I have to add
static const sal_uInt16 nCopyFlags[] = {
SID_COLOR_TABLE,
SID_GRADIENT_LIST,
SID_HATCH_LIST,
SID_BITMAP_LIST,
SID_PATTERN_LIST,
0
};
To my SfxItemSet aSet in HeaderFooterWin.cxx.. But when 
iterating each of the values in nCopyFlags, I am using 
GetItemSet().GetItem(nCopyFlags[a]) ..

for(sal_uInt16 a(0); nCopyFlags[a]; a++)
  {
   const SfxPoolItem* pItem = 
GetItemSet().GetItem(nCopyFlags[a]);

   if(pItem)
{
aSet->Put(*pItem);
}
else
{
OSL_ENSURE(false, "XPropertyList missing (!)");
}
}


  1.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Conflict with submitted change

[Aditya Sahu]

Hi,
I submitted a change ( Change-Id: I440c637dd2a566f820a6e8fac826f35cabb9c05f
) but after doing that, I found out that it is having conflict with some
other change ( Change-Id: I937ed12f2a96943664087ddcdd035f1347e84a57 ).
What should be my move here?
--
Best Regards,
Aditya Sahu
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Aditya Sahu license statement

[Aditya Sahu]

All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

A Fresher Needs Help in Contributing

[Aditya Sahu]

Hi, I'm an engineering student from India. I'm interested in participating
in GSoC by contributing in LibreOffice. I'm having some trouble
understanding the code, and as to where do I start contributing. I need
help taking my first step towards open source community. (I have knowledge
of C++)
Help Appreciated; Thanks in advance.

--
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Aditya Sahu license statement

[Aditya Sahu]

All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.


Sent from Mail for Windows 10 by Aditya Sahu

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

Regarding Google Summer of Code'18

[Aditya Sahu]

Sir/Ma'am,
This is in reference to GSOC'18.
First, a little about me:
I am a second year computer science
engineering student from India. I have programming experience of 3 years in
C++ and C.
I have not yet started to contribute to any Free and open source software
till the date. But I'm looking forward to do so.
I've been using LibreOffice open source softwares like writer, impress and
many more for a long time and now I want to contribute towards an open
source project, but before that I'd want to know a few things which are
probably not mentioned in Libre's wiki page and other links since I want to
enter GSOC'18 and also to make real use  of my programming skills. So here
are my queries:
1.As far as I know, there are various ways in which a user can contribute
to FOSS. One being bug finding, another being providing working codes,
suggestion for enhancements, etc.
In order to get into GSOC, which type of contribution should I make more?
2. How many projects should I contribute to to get selected in GSOC?
3. If I make contributions to a project and it gets pulled into master, who
would know that I did it? I mean will there be any proof of my successful
contributions so that I can add it to my CV or something like that.
4. What is the magnitude of projects that I have to contribute? One, two,
three or more?
5. Do I need to create a project on behalf of LibreOffice before I apply
for the program? Or do I have to do it alone..
-

That's all I had in mind. I apologize if I've asked a query whose answer is
already mentioned on your website..
I hope you answer to the queries; really important for career :-)
Thanks!
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice