[PUSHED] fdo#64011 fix the position and the drawing from left to righ...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3912 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3912 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5cc8eabf474918968bea026dba9c5add2bb4f28e Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Faisal al-otaibi fmalota...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#35320 A fix for Arabic justification problem caused by k...
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3644 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3644/1 fdo#35320 A fix for Arabic justification problem caused by kashidas Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec --- M vcl/source/gdi/sallayout.cxx 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx index 9d315e3..d4696c7 100644 --- a/vcl/source/gdi/sallayout.cxx +++ b/vcl/source/gdi/sallayout.cxx @@ -1274,7 +1274,7 @@ // calculate gap, ignore if too small int nGapWidth = pG-mnNewWidth - pG-mnOrigWidth; // worst case is one kashida even for mini-gaps -if( 3 * nGapWidth nKashidaWidth ) +if( nGapWidth nKashidaWidth ) continue; nKashidaCount = 0; -- To view, visit https://gerrit.libreoffice.org/3644 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#35320 A fix for Arabic justification problem caused by k...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3644 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3644 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I512e6332a632acf90e4f995fbc7fd19e7ef094ec Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] more fix to fdo#62470
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3305 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3305 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2bd1d69142bb0a920bdb58c833f8cbbb461a8350 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Faisal al-otaibi fmalota...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#62470 fix the input change when the table RTL
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3133 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3133 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e963c1bb71c63bffe8c8f95c091a5692c21cd31 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Faisal al-otaibi fmalota...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fdo#62470 fix the table format dialog reading
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3134 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3134 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I624cf7c162d3983fe4625e8e2e6fef4fc556eed0 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Faisal al-otaibi fmalota...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] more fix for fdo#62399
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3145 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3145 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa8a665dfa0b0dcb5230bafa1e3537f450afb9c Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Faisal al-otaibi fmalota...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix fdo#62050: for impress
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2922 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2922 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I188ce05350f721081378509915158d4ec4e5f8cf Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] In writer’s RTL UI show author name and date at right side o...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2923 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2923 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie15482e9953d14927b4f918c43537100a8332689 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix fdo#62050 : Initially disable RTL for comment window.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2831 Approvals: Ahmad Harthi: Verified; Looks good to me, approved abdulmajeed ahmed: Looks good to me, but someone else must approve -- To view, visit https://gerrit.libreoffice.org/2831 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3af4ae428b67151d1907b9e60a97049e0e6 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: abdulmajeed ahmed aalabdulraz...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Resolves fdo#60554
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/2375 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/2375 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d3464e8b75cc9b72a1592d8ef276243202e68b8 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Karthikeyan Krishnamurthi karthike...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Lior Kaplan kaplanl...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Fixes fdo#46186, The Table Remains in the defined writing mo...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1964 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1964 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9d6bdde5019322488be66fa89a6488d348b2cf44 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: gokul s gswaminat...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] fix fdo#59892 completely and fdo#33302 partially.
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1961 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1961 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I83b1e077faf0f2578308e03b7598557f60e7cfd8 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[master]: Resolves the bug fdo#59117 missing borders of last column
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1834 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1834 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e21c7dd469ed5ba29e66f79da471b662632182e Gerrit-PatchSet: 4 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Karthikeyan Krishnamurthi karthike...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Michael Stahl mst...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Change in core[master]: More fixes to fdo#57422
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1521 Approvals: Ahmad Harthi: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1521 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib89aee7c817811c7b3751dc6f941a34ed763d993 Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa Gerrit-Reviewer: Faisal al-otaibi fmalota...@kacst.edu.sa Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org Gerrit-Reviewer: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: abdulmajeed ahmed aalabdulraz...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] More fixes to fdo#57422
Hi,
I have submitted a patch for review:
https://gerrit.libreoffice.org/1521
To pull it, you can do:
git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1521/1
More fixes to fdo#57422
* Code cleanup + replacing drawText() with drawTextLayout().
This solves mirrored LTR text in an RTL ui
Change-Id: Ib89aee7c817811c7b3751dc6f941a34ed763d993
---
M sdext/source/presenter/PresenterButton.cxx
M sdext/source/presenter/PresenterSlideShowView.cxx
2 files changed, 20 insertions(+), 51 deletions(-)
diff --git a/sdext/source/presenter/PresenterButton.cxx
b/sdext/source/presenter/PresenterButton.cxx
index ac8e813..b7415a5 100644
--- a/sdext/source/presenter/PresenterButton.cxx
+++ b/sdext/source/presenter/PresenterButton.cxx
@@ -413,29 +413,15 @@
rendering::RenderState aRenderState (geometry::AffineMatrix2D(1,0,0,
0,1,0), NULL,
Sequencedouble(4), rendering::CompositeOperation::SOURCE);
PresenterCanvasHelper::SetDeviceColor(aRenderState, rpFont-mnColor);
+
+aRenderState.AffineTransform.m02 = (rSize.Width - aTextBBox.X2 +
aTextBBox.X1)/2;
+aRenderState.AffineTransform.m12 = (rSize.Height - aTextBBox.Y2 +
aTextBBox.Y1)/2 - aTextBBox.Y1;
+
/// this is responsible of the close button
-/// check whether RTL interface or not
-if(!Application::GetSettings().GetLayoutRTL()){
-aRenderState.AffineTransform.m02 = (rSize.Width - aTextBBox.X2 +
aTextBBox.X1)/2;
-aRenderState.AffineTransform.m12 = (rSize.Height - aTextBBox.Y2 +
aTextBBox.Y1)/2 - aTextBBox.Y1;
-
-rxCanvas-drawText(
-aContext,
-rpFont-mxFont,
-rendering::ViewState(geometry::AffineMatrix2D(1,0,0, 0,1,0), NULL),
-aRenderState,
-rendering::TextDirection::WEAK_LEFT_TO_RIGHT);
-}else{
-aRenderState.AffineTransform.m02 = (rSize.Width + aTextBBox.X2 -
aTextBBox.X1)/2;
-aRenderState.AffineTransform.m12 = (rSize.Height - aTextBBox.Y2 +
aTextBBox.Y1)/2 - aTextBBox.Y1;
-
-rxCanvas-drawText(
-aContext,
-rpFont-mxFont,
-rendering::ViewState(geometry::AffineMatrix2D(1,0,0, 0,1,0), NULL),
-aRenderState,
-rendering::TextDirection::WEAK_RIGHT_TO_LEFT);
-}
+rxCanvas-drawTextLayout(
+xLayout,
+rendering::ViewState(geometry::AffineMatrix2D(1,0,0, 0,1,0), NULL),
+aRenderState);
}
void PresenterButton::Invalidate (void)
diff --git a/sdext/source/presenter/PresenterSlideShowView.cxx
b/sdext/source/presenter/PresenterSlideShowView.cxx
index 894e6d8..be99fa5 100644
--- a/sdext/source/presenter/PresenterSlideShowView.cxx
+++ b/sdext/source/presenter/PresenterSlideShowView.cxx
@@ -782,35 +782,18 @@
break;
/// this is responsible of the presentation exit text inside the
slide windows
-/// check whether RTL interface or not
-if(!Application::GetSettings().GetLayoutRTL()){
-PresenterCanvasHelper::SetDeviceColor(aRenderState,
util::Color(0x00ff));
-aRenderState.AffineTransform.m02 = 20;
-aRenderState.AffineTransform.m12 = 40;
-const rendering::StringContext aContext (
-msClickToExitPresentationText, 0,
msClickToExitPresentationText.getLength());
-pFont-PrepareFont(mxCanvas);
-mxCanvas-drawText(
-aContext,
-pFont-mxFont,
-aViewState,
-aRenderState,
-rendering::TextDirection::WEAK_LEFT_TO_RIGHT);
-}
-else{
-PresenterCanvasHelper::SetDeviceColor(aRenderState,
util::Color(0x00ff));
-aRenderState.AffineTransform.m02 = rRepaintBox.Width-20;
-aRenderState.AffineTransform.m12 = 40;
-const rendering::StringContext aContext (
-msClickToExitPresentationText, 0,
msClickToExitPresentationText.getLength());
-pFont-PrepareFont(mxCanvas);
-mxCanvas-drawText(
-aContext,
-pFont-mxFont,
-aViewState,
-aRenderState,
-rendering::TextDirection::WEAK_RIGHT_TO_LEFT);
-}
+PresenterCanvasHelper::SetDeviceColor(aRenderState,
util::Color(0x00ff));
+aRenderState.AffineTransform.m02 = 20;
+aRenderState.AffineTransform.m12 = 40;
+const rendering::StringContext aContext (
+msClickToExitPresentationText, 0,
msClickToExitPresentationText.getLength());
+pFont-PrepareFont(mxCanvas);
+const Referencerendering::XTextLayout xLayout (
+
pFont-mxFont-createTextLayout(aContext,rendering::TextDirection::WEAK_LEFT_TO_RIGHT,0));
+mxCanvas-drawTextLayout(
+xLayout,
+aViewState,
+aRenderState);
}
while (false);
--
To view, visit https://gerrit.libreoffice.org/1521
To unsubscribe, visit
