[Libreoffice-commits] core.git: Changes to 'refs/changes/38/238/3'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/38/238/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/38/238/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/10/2610/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/11/2611/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/11/2611/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/56/2156/1'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'refs/changes/56/2156/2'
___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sysui/desktop
sysui/desktop/man/unopkg.1 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 57037ea47fc203db08b2cf4a57c305df0a156307 Author: Benjamin Drung Date: Sat Mar 9 02:14:17 2013 +0100 Related to fdo#60724: Fix grammar. Change-Id: I6094a7c3ee2ed4e30d955024ef81811bca572dcd Reviewed-on: https://gerrit.libreoffice.org/2611 Reviewed-by: Björn Michaelsen Tested-by: Björn Michaelsen diff --git a/sysui/desktop/man/unopkg.1 b/sysui/desktop/man/unopkg.1 index dad74dd..9bc9244 100644 --- a/sysui/desktop/man/unopkg.1 +++ b/sysui/desktop/man/unopkg.1 @@ -27,7 +27,7 @@ features you would normally expect in an office suite. There exists many LibreOffice extensions all over the word. For example, see \fBhttp://extensions.libreoffice.org/\fR -This tool allows to manage the extensions from the command line. +This tool allows managing the extensions from the command line. .SH SUB\-COMMANDS .TP ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sysui/desktop
sysui/desktop/man/libreoffice.1 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 700e5facbe21c72c5f3f4208f0416e079d40399e Author: Benjamin Drung Date: Sat Mar 9 00:10:19 2013 +0100 Fix typo in libreoffice man page. Change-Id: Ieb3e74630e48feaf69f5d58e9b7eb57779033356 Reviewed-on: https://gerrit.libreoffice.org/2610 Reviewed-by: Björn Michaelsen Tested-by: Björn Michaelsen diff --git a/sysui/desktop/man/libreoffice.1 b/sysui/desktop/man/libreoffice.1 index ebc3843..2b458ef 100644 --- a/sysui/desktop/man/libreoffice.1 +++ b/sysui/desktop/man/libreoffice.1 @@ -122,7 +122,7 @@ or the kill command (UNIX based systems). .TP \fB\-\-infilter=""\fR Force an input filter type if possible. -For example -infilter="Calc Office Open XML" only +For example \-\-infilter="Calc Office Open XML" only .TP \fB\-\-math\fR ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Related to fdo#60724: Fix grammar.
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2611 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/2611/1 Related to fdo#60724: Fix grammar. Change-Id: I6094a7c3ee2ed4e30d955024ef81811bca572dcd --- M sysui/desktop/man/unopkg.1 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysui/desktop/man/unopkg.1 b/sysui/desktop/man/unopkg.1 index dad74dd..9bc9244 100644 --- a/sysui/desktop/man/unopkg.1 +++ b/sysui/desktop/man/unopkg.1 @@ -27,7 +27,7 @@ There exists many LibreOffice extensions all over the word. For example, see \fBhttp://extensions.libreoffice.org/\fR -This tool allows to manage the extensions from the command line. +This tool allows managing the extensions from the command line. .SH SUB\-COMMANDS .TP -- To view, visit https://gerrit.libreoffice.org/2611 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6094a7c3ee2ed4e30d955024ef81811bca572dcd Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Benjamin Drung ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Fix typo in libreoffice man page.
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/2610 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/2610/1 Fix typo in libreoffice man page. Change-Id: Ieb3e74630e48feaf69f5d58e9b7eb57779033356 --- M sysui/desktop/man/libreoffice.1 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysui/desktop/man/libreoffice.1 b/sysui/desktop/man/libreoffice.1 index ebc3843..2b458ef 100644 --- a/sysui/desktop/man/libreoffice.1 +++ b/sysui/desktop/man/libreoffice.1 @@ -122,7 +122,7 @@ .TP \fB\-\-infilter=""\fR Force an input filter type if possible. -For example -infilter="Calc Office Open XML" only +For example \-\-infilter="Calc Office Open XML" only .TP \fB\-\-math\fR -- To view, visit https://gerrit.libreoffice.org/2610 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb3e74630e48feaf69f5d58e9b7eb57779033356 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Benjamin Drung ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - svtools/source
svtools/source/config/colorcfg.cxx | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
New commits:
commit f10bb02eb3083a089e3ca28c45983e616ef84d58
Author: Benjamin Drung
Date: Fri Jun 8 00:19:25 2012 +0200
fdo#35365 Set the default font color to black and the document color to
white.
The font and document color of a Writer document or an Impress presentation
should not be derived from a desktop theme. A Writer documents needs to look
good on paper. An Impress presentation may have it's own theme. The
appearance
of a document should not change by changing the desktop theme.
With this change a document looks the same on any computer if the user do
not
change the default colors.
Change-Id: Ia42ca7882f0d2dd1f2a304db5e4b5aaba23244fc
Reviewed-on: https://gerrit.libreoffice.org/2156
Reviewed-by: Björn Michaelsen
Tested-by: Björn Michaelsen
diff --git a/svtools/source/config/colorcfg.cxx
b/svtools/source/config/colorcfg.cxx
index abdb852..4f899af 100644
--- a/svtools/source/config/colorcfg.cxx
+++ b/svtools/source/config/colorcfg.cxx
@@ -412,12 +412,12 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry
eEntry)
{
static const sal_Int32 aAutoColors[] =
{
-0, // DOCCOLOR
+COL_WHITE, // DOCCOLOR
0xc0c0c0, // DOCBOUNDARIES
0x808080, // APPBACKGROUND
0xc0c0c0, // OBJECTBOUNDARIES
0xc0c0c0, // TABLEBOUNDARIES
-0, // FONTCOLOR
+COL_BLACK, // FONTCOLOR
0xcc, // LINKS
0x80, // LINKSVISITED
0xff, // SPELL
@@ -462,18 +462,10 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry
eEntry)
Color aRet;
switch(eEntry)
{
-case DOCCOLOR :
-aRet =
Application::GetSettings().GetStyleSettings().GetWindowColor();
-break;
-
case APPBACKGROUND :
aRet =
Application::GetSettings().GetStyleSettings().GetWorkspaceColor();
break;
-case FONTCOLOR :
-aRet =
Application::GetSettings().GetStyleSettings().GetWindowTextColor();
-break;
-
case LINKS :
aRet =
Application::GetSettings().GetStyleSettings().GetLinkColor();
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-ux-advise] [PATCH] fdo#35365 default font color for documents
Am Mittwoch, den 27.06.2012, 10:56 +0200 schrieb Stefan Knorr: > Hi all, > > I am not a user of high-contrast themes, and might not be able to help > very much here. I am adding Christophe from a11y here who might be able > to share some more ideas. > > > So, High-Contrast... there are two types of high-contrast themes in most > OS's, namely dark on light and light on dark. I think the users of the > different types have different needs, too. > Ooo, and thus, LibO generally cater to light on dark themes (as is > evident in our hicontrast theme). Which incidentally, is the type of > theme making trouble here. The question is: Should the theme influence the document? What does other application do? Does an image viewer increases the contrast of an image if the user uses a high-contrast theme? Does a PDF viewer displays a PDF file differently if the user uses a high-contrast theme? -- Benjamin Drung Debian & Ubuntu Developer signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#35365 default font color for documents
Hi, Am Freitag, den 08.06.2012, 21:47 +0200 schrieb Jan Holesovsky: > Hi Benjamin, > > Benjamin Drung píše v Pá 08. 06. 2012 v 01:18 +0200: > > > here's a patch to fix bug fdo#35365. Please also apply the patch in the > > 3.5 and 3.6 branch. > > > > The underlying bug fdo#50861 is only partially fixed by this patch. At > > least two solutions comes to my mind for a full fix: > > 1) Store the default colors in the document. > > 2) Hardcode the default colors. > > > > What do you think? What's the right approach to fix fdo#50861? > > Thank you very much for the patch! Unfortunately, I am afraid this > breaks the way we are handling the hicontrast theme that is supposed to > target visually impaired people - we use dark background and white text > in the hicontrast case (which wouldn't be the case any more with this > patch). > > Adding the UX advise people what they think - I have no experience with > accessibility, so cannot say what is right in this area. If they agree > that we should let the hicontrast behavior as it is, I'd prefer: > > case DOCCOLOR : > -aRet = > Application::GetSettings().GetStyleSettings().GetWindowColor(); > +aRet = > Application::GetSettings().GetStyleSettings().GetHighContrastMode()? > COL_BLACK: COL_WHITE; > break; > > and similarly for FONTCOLOR - how does that sound to you? Does it make a difference for visually impaired people between black on white and white on black? Is it really a good idea to allow the desktop theme to influence the appearance of the document? Imagine following: I create a document where LibreOffice is configured with black font on white background. I select a brown 1 for the text and save it. Then someone with a hiconstrast theme opens the document and will see dark brown text on a black background. The contrast was reduces instead of increased. Please read bug #50861 and the examples given in comment 2 [1]. [1] https://bugs.freedesktop.org/show_bug.cgi?id=50861#c2 > BTW, this all color setting thing requires a cleanup - why should we > have the baroque StyleSettings class, and on top of that this > ColorConfig approach to colors? Are you interested in cleaning up / > consolidating the approach to colors as a follow-up? ;-) Yes and no. On the one hand it is appealing to me, but on the other hand other free software projects already consume enough of my spare time. > > My current and all future contributions to LibreOffice, unless > > stated otherwise, are licensed under LGPLv3+/MPL until further notice. > > If you can send it as a separate mail, ideally with a subject like > "License statement", that would be most appreciated, so that we can > clearly link that from the page where we collect the statements. Done. -- Benjamin Drung Debian & Ubuntu Developer signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
All of my past and future contributions to LibreOffice, unless stated otherwise, are licensed under LGPLv3+/MPL until further notice. -- Benjamin Drung Debian & Ubuntu Developer signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#35365 default font color for documents
Hi,
here's a patch to fix bug fdo#35365. Please also apply the patch in the
3.5 and 3.6 branch.
The underlying bug fdo#50861 is only partially fixed by this patch. At
least two solutions comes to my mind for a full fix:
1) Store the default colors in the document.
2) Hardcode the default colors.
What do you think? What's the right approach to fix fdo#50861?
My current and all future contributions to LibreOffice, unless
stated otherwise, are licensed under LGPLv3+/MPL until further notice.
PS: Thanks to Björn Michaelsen, who helped me to dive into the code on
the LinuxTag.
--
Benjamin Drung
Debian & Ubuntu Developer
From 456ec746d130d736caa526dfddc8d138fff6c797 Mon Sep 17 00:00:00 2001
From: Benjamin Drung
Date: Fri, 8 Jun 2012 00:19:25 +0200
Subject: [PATCH] fdo#35365 Set the default font color to black and the
document color to white.
The font and document color of a Writer document or an Impress presentation
should not be derived from a desktop theme. A Writer documents needs to look
good on paper. An Impress presentation may have it's own theme. The appearance
of a document should not change by changing the desktop theme.
With this change a document looks the same on any computer if the user do not
change the default colors.
Change-Id: Ia42ca7882f0d2dd1f2a304db5e4b5aaba23244fc
---
svtools/source/config/colorcfg.cxx | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/svtools/source/config/colorcfg.cxx b/svtools/source/config/colorcfg.cxx
index abdb852..4f899af 100644
--- a/svtools/source/config/colorcfg.cxx
+++ b/svtools/source/config/colorcfg.cxx
@@ -412,12 +412,12 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry eEntry)
{
static const sal_Int32 aAutoColors[] =
{
-0, // DOCCOLOR
+COL_WHITE, // DOCCOLOR
0xc0c0c0, // DOCBOUNDARIES
0x808080, // APPBACKGROUND
0xc0c0c0, // OBJECTBOUNDARIES
0xc0c0c0, // TABLEBOUNDARIES
-0, // FONTCOLOR
+COL_BLACK, // FONTCOLOR
0xcc, // LINKS
0x80, // LINKSVISITED
0xff, // SPELL
@@ -462,18 +462,10 @@ Color ColorConfig::GetDefaultColor(ColorConfigEntry eEntry)
Color aRet;
switch(eEntry)
{
-case DOCCOLOR :
-aRet = Application::GetSettings().GetStyleSettings().GetWindowColor();
-break;
-
case APPBACKGROUND :
aRet = Application::GetSettings().GetStyleSettings().GetWorkspaceColor();
break;
-case FONTCOLOR :
-aRet = Application::GetSettings().GetStyleSettings().GetWindowTextColor();
-break;
-
case LINKS :
aRet = Application::GetSettings().GetStyleSettings().GetLinkColor();
break;
--
1.7.9.5
signature.asc
Description: This is a digitally signed message part
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
