[PATCH] conversion the calc default option page to .ui

2013-05-30 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4092

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/4092/1

conversion the calc default option page to .ui

Change-Id: I09d8b012633e7fce916b54eee6b1b0d9db50ac23
---
M sc/UIConfig_scalc.mk
M sc/inc/helpids.h
M sc/source/ui/inc/optdlg.hrc
M sc/source/ui/inc/tpdefaults.hxx
M sc/source/ui/optdlg/tpdefaults.cxx
M sc/source/ui/src/optdlg.src
A sc/uiconfig/scalc/ui/optdefaultpage.ui
7 files changed, 150 insertions(+), 93 deletions(-)



diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk
index cf715ff..94a8aea 100644
--- a/sc/UIConfig_scalc.mk
+++ b/sc/UIConfig_scalc.mk
@@ -80,6 +80,7 @@
sc/uiconfig/scalc/ui/leftheaderdialog \
sc/uiconfig/scalc/ui/managenamesdialog \
sc/uiconfig/scalc/ui/optcalculatepage \
+   sc/uiconfig/scalc/ui/optdefaultpage \
sc/uiconfig/scalc/ui/printeroptions \
sc/uiconfig/scalc/ui/protectsheetdlg \
sc/uiconfig/scalc/ui/sheetprintpage \
diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h
index 3eff53e..8bbc07a 100644
--- a/sc/inc/helpids.h
+++ b/sc/inc/helpids.h
@@ -65,7 +65,6 @@
 #define HID_SCPAGE_AREAS
"SC_HID_SCPAGE_AREAS"
 #define HID_SCPAGE_COMPATIBILITY
"SC_HID_SCPAGE_COMPATIBILITY"
 #define HID_SCPAGE_PRINT
"SC_HID_SCPAGE_PRINT"
-#define HID_SCPAGE_DEFAULTS 
"SC_HID_SCPAGE_DEFAULTS"
 #define HID_SCPAGE_SUBT_GROUP1  
"SC_HID_SCPAGE_SUBT_GROUP1"
 #define HID_SCPAGE_SUBT_GROUP2  
"SC_HID_SCPAGE_SUBT_GROUP2"
 #define HID_SCPAGE_SUBT_GROUP3  
"SC_HID_SCPAGE_SUBT_GROUP3"
diff --git a/sc/source/ui/inc/optdlg.hrc b/sc/source/ui/inc/optdlg.hrc
index ad60340..515ddcb 100644
--- a/sc/source/ui/inc/optdlg.hrc
+++ b/sc/source/ui/inc/optdlg.hrc
@@ -156,11 +156,4 @@
 #define FT_KEY_BINDINGS   2
 #define LB_KEY_BINDINGS   3
 
-// TP_DEFAULTS
-#define FL_INIT_SPREADSHEET  1
-#define FT_NSHEETS   2
-#define ED_NSHEETS   3
-#define FT_SHEETPREFIX   4
-#define ED_SHEETPREFIX   5
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/inc/tpdefaults.hxx b/sc/source/ui/inc/tpdefaults.hxx
index bd967bb..4c13f2a 100644
--- a/sc/source/ui/inc/tpdefaults.hxx
+++ b/sc/source/ui/inc/tpdefaults.hxx
@@ -7,8 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef __SC_TPDEFAULTS_HXX__
-#define __SC_TPDEFAULTS_HXX__
+//#ifndef __SC_TPDEFAULTS_HXX__
+//#define __SC_TPDEFAULTS_HXX__
 
 #include 
 #include 
@@ -38,16 +38,15 @@
 DECL_LINK( PrefixEditOnFocusHdl, Edit* );
 
 private:
-FixedLine aFLInitSpreadSheet;
-FixedText aFtNSheets;
-NumericField  aEdNSheets;
-FixedText aFtSheetPrefix;
-Edit  aEdSheetPrefix;
+FixedText*m_pFtNSheets;
+NumericField* m_pEdNSheets;
+FixedText*m_pFtSheetPrefix;
+Edit* m_pEdSheetPrefix;
 
 // Stores old Sheet Prefix
 OUString maOldPrefixValue;
 };
 
-#endif
+//#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/ui/optdlg/tpdefaults.cxx 
b/sc/source/ui/optdlg/tpdefaults.cxx
index 2dc5a42..06a75cd 100644
--- a/sc/source/ui/optdlg/tpdefaults.cxx
+++ b/sc/source/ui/optdlg/tpdefaults.cxx
@@ -19,36 +19,35 @@
 
 
 ScTpDefaultsOptions::ScTpDefaultsOptions(Window *pParent, const SfxItemSet 
&rCoreSet) :
-SfxTabPage(pParent, ScResId(RID_SCPAGE_DEFAULTS), rCoreSet),
-aFLInitSpreadSheet ( this, ScResId( FL_INIT_SPREADSHEET ) ),
-aFtNSheets ( this, ScResId( FT_NSHEETS ) ),
-aEdNSheets ( this, ScResId( ED_NSHEETS ) ),
-aFtSheetPrefix ( this, ScResId( FT_SHEETPREFIX ) ),
-aEdSheetPrefix ( this, ScResId( ED_SHEETPREFIX ) )
+SfxTabPage(pParent, "OptDefaultPage", 
"modules/scalc/ui/optdefaultpage.ui", rCoreSet)
+
 {
-FreeResource();
+get( m_pFtNSheets, "textsheetsnumber");
+get( m_pEdNSheets, "sheetsnumber");
+get( m_pFtSheetPrefix, "textsheetprefix");
+get( m_pEdSheetPrefix, "sheetprefix");
 
 // the following computation must be modified accordingly if a third line 
is added to this dialog
-long nTxtW1 = aFtNSheets.GetCtrlTextWidth( aFtNSheets.GetText() );
-long nCtrlW1 = aFtNSheets.GetSizePixel().Width();
-long nTxtW2 = aFtSheetPrefix.GetCtrlTextWidth(aFtSheetPrefix.GetText() );
-long nCtrlW2 = aFtSheetPrefix.GetSizePixel().Width();
+long nTxtW1  = m_pFtNSheets->GetCtrlTextWidth( m_pFtNSheets->GetText() );
+long nCtrlW1 = m_pFtNSheets->GetSizePixel().Width();
+long nTxtW2  = 
m_pFtSheetPrefix->GetCtrlTextWidth(m_pFtSheetPrefix->GetText() );
+long nCtrlW2 = m_pFtSheetPrefix->GetSizePixel().Width();
 if ( nTxtW1 >= nCtrlW1 || nTxtW2 >= nCtrlW2)
 {
 long nTxtW = std::m

[PATCH] fdo#63323 fix the comment position when the mouse over cell

2013-05-28 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/4069

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/4069/1

fdo#63323 fix the comment position when the mouse over cell

fix the X position when the sheet are RTL.

Change-Id: I9b38a840fb17a70e1ba60d46b8c83b7e498501e1
---
M sc/source/ui/view/gridwin5.cxx
1 file changed, 4 insertions(+), 0 deletions(-)



diff --git a/sc/source/ui/view/gridwin5.cxx b/sc/source/ui/view/gridwin5.cxx
index 7055c22..756f75c 100644
--- a/sc/source/ui/view/gridwin5.cxx
+++ b/sc/source/ui/view/gridwin5.cxx
@@ -222,6 +222,10 @@
 MapMode aDrawMode = GetDrawMapMode();
 Point aCurPosHmm = PixelToLogic(aScreenPos, aDrawMode );
 Point aGridOff = aCurPosHmm -aOldPos;
+// fdo#63323 fix the X Position for the showing comment 
when
+// the mouse over the cell when the sheet are RTL
+if ( pDoc->IsNegativePage(nTab))
+aGridOff.setX(aCurPosHmm.getX() + aOldPos.getX());
 pNoteMarker->SetGridOff( aGridOff );
 }
 }

-- 
To view, visit https://gerrit.libreoffice.org/4069
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b38a840fb17a70e1ba60d46b8c83b7e498501e1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63878 fix the zoom bug on RTL sheet

2013-05-17 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3954

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/3954/1

fdo#63878 fix the zoom bug on RTL sheet

fix the X position after check if the sheet are RTL

Change-Id: Icbb9ce44508698e0f03898b202e033c07ae2de70
---
M sc/source/ui/view/drawview.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx
index e249e8c..92e9200 100644
--- a/sc/source/ui/view/drawview.cxx
+++ b/sc/source/ui/view/drawview.cxx
@@ -782,6 +782,9 @@
 Point aCurPos =  pViewData->GetScrPos(  aOldStt.Col(), aOldStt.Row(), 
eWhich, sal_True );
 Point aCurPosHmm = pGridWin->PixelToLogic(aCurPos, aDrawMode );
 Point aGridOff = ( aCurPosHmm - aOldPos );
+// fdo#63878 Fix the X position for RTL Sheet
+if( pDoc->IsNegativePage( GetTab() ) )
+aGridOff.setX( aCurPosHmm.getX() + aOldPos.getX() );
 pObj->SetGridOffset( aGridOff );
 }
 }

-- 
To view, visit https://gerrit.libreoffice.org/3954
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icbb9ce44508698e0f03898b202e033c07ae2de70
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#64011 fix the position and the drawing from left to righ...

2013-05-14 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3912

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3912/1

fdo#64011 fix the position and the drawing from left to right in RTL sheet

this will fix the start position for drawing and you can draw shapes
from left to right when the Sheet are RTL

Change-Id: I5cc8eabf474918968bea026dba9c5add2bb4f28e
---
M sc/source/ui/drawfunc/fuconstr.cxx
1 file changed, 7 insertions(+), 0 deletions(-)



diff --git a/sc/source/ui/drawfunc/fuconstr.cxx 
b/sc/source/ui/drawfunc/fuconstr.cxx
index 5d8f270..381aeb4 100644
--- a/sc/source/ui/drawfunc/fuconstr.cxx
+++ b/sc/source/ui/drawfunc/fuconstr.cxx
@@ -83,6 +83,7 @@
 // involved. Lets calculate where aPos would be at 100% zoom
 // that's the actual correct position for the object ( when you
 // restore the zoom.
+sal_Bool bNegative = pDoc->IsNegativePage(pView->GetTab());
 Rectangle aObjRect( rInOutPos, rInOutPos );
 ScRange aRange = pDoc->GetRange( pView->GetTab(), aObjRect );
 ScAddress aOldStt = aRange.aStart;
@@ -98,6 +99,12 @@
 Point aOff = ( rInOutPos - aCurPosHmm );
 rInOutPos = aOldPos + aOff;
 aRetGridOff = aCurPosHmm - aOldPos;
+// fdo#64011 fix the X position when the sheet are RTL
+if ( bNegative )
+{
+aRetGridOff.setX( aCurPosHmm.getX() + aOldPos.getX() );
+rInOutPos.setX( aOff.getX() - aOldPos.getX() );
+}
 }
 return aRetGridOff;
 }

-- 
To view, visit https://gerrit.libreoffice.org/3912
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5cc8eabf474918968bea026dba9c5add2bb4f28e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63878 fix the zoom problem when the sheet are RTL

2013-05-04 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3789

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/3789/1

fdo#63878 fix the zoom problem when the sheet are RTL

Change-Id: Ie451b7a84b5481e9209c5b6d6d439844de5082fd
---
M sc/source/ui/view/drawview.cxx
1 file changed, 3 insertions(+), 0 deletions(-)



diff --git a/sc/source/ui/view/drawview.cxx b/sc/source/ui/view/drawview.cxx
index e249e8c..2fe614c 100644
--- a/sc/source/ui/view/drawview.cxx
+++ b/sc/source/ui/view/drawview.cxx
@@ -782,6 +782,9 @@
 Point aCurPos =  pViewData->GetScrPos(  aOldStt.Col(), aOldStt.Row(), 
eWhich, sal_True );
 Point aCurPosHmm = pGridWin->PixelToLogic(aCurPos, aDrawMode );
 Point aGridOff = ( aCurPosHmm - aOldPos );
+// fdo#63878 Fix the X position for RTL Sheet
+if( aGridOff.getX() < 0 )
+aGridOff.setX( aCurPosHmm.getX() + aOldPos.getX() );
 pObj->SetGridOffset( aGridOff );
 }
 }

-- 
To view, visit https://gerrit.libreoffice.org/3789
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie451b7a84b5481e9209c5b6d6d439844de5082fd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fix fdo#63619 no need for RTL mark

2013-04-30 Thread Faisal al-otaibi (via Code Review) 
Faisal al-otaibi has abandoned this change.

Change subject: fix fdo#63619 no need for RTL mark
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/3498
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I88588be252455bbb353c757a75f2ec9ea2d17e9e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 
Gerrit-Reviewer: Eike Rathke 
Gerrit-Reviewer: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fix fdo#63619 no need for RTL mark

2013-04-20 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3498

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/3498/1

fix fdo#63619 no need for RTL mark

Change-Id: I88588be252455bbb353c757a75f2ec9ea2d17e9e
---
M i18npool/source/localedata/data/ar_DZ.xml
M i18npool/source/localedata/data/ar_EG.xml
M i18npool/source/localedata/data/ar_LB.xml
M i18npool/source/localedata/data/ar_OM.xml
M i18npool/source/localedata/data/ar_SA.xml
M i18npool/source/localedata/data/ar_TN.xml
6 files changed, 12 insertions(+), 12 deletions(-)



diff --git a/i18npool/source/localedata/data/ar_DZ.xml 
b/i18npool/source/localedata/data/ar_DZ.xml
index 7c2649a..a96ab94 100644
--- a/i18npool/source/localedata/data/ar_DZ.xml
+++ b/i18npool/source/localedata/data/ar_DZ.xml
@@ -51,7 +51,7 @@
 م
 metric
   
-  
+  
 D/M
 
   General
@@ -444,7 +444,7 @@
   
 
   DZD
-  د.ج.‏
+   د.ج.
   DZD
   دينار جزائري
   2
diff --git a/i18npool/source/localedata/data/ar_EG.xml 
b/i18npool/source/localedata/data/ar_EG.xml
index 09ce368..f608ccb 100644
--- a/i18npool/source/localedata/data/ar_EG.xml
+++ b/i18npool/source/localedata/data/ar_EG.xml
@@ -51,7 +51,7 @@
 م
 metric
   
-  
+  
 D/M
 
   General
@@ -449,7 +449,7 @@
   
 
   EGP
-  ج.م.‏
+   ج.م.
   EGP
   EGP
   2
diff --git a/i18npool/source/localedata/data/ar_LB.xml 
b/i18npool/source/localedata/data/ar_LB.xml
index 86aba61..0a058a5 100644
--- a/i18npool/source/localedata/data/ar_LB.xml
+++ b/i18npool/source/localedata/data/ar_LB.xml
@@ -51,7 +51,7 @@
 م
 metric
   
-  
+  
   
   
   
@@ -294,7 +294,7 @@
   
 
   LBP
-  ل.ل.‏
+   ل.ل.
   LBP
   LBP
   2
diff --git a/i18npool/source/localedata/data/ar_OM.xml 
b/i18npool/source/localedata/data/ar_OM.xml
index a31b967..e6b56d4 100644
--- a/i18npool/source/localedata/data/ar_OM.xml
+++ b/i18npool/source/localedata/data/ar_OM.xml
@@ -51,7 +51,7 @@
 م
 metric
   
-  
+  
 D/M
 
   General
@@ -332,7 +332,7 @@
   
 
   OMR
-  ر.ع
+   ر.ع
   OMR
   ريال عماني
   2
diff --git a/i18npool/source/localedata/data/ar_SA.xml 
b/i18npool/source/localedata/data/ar_SA.xml
index 01b596c..52aea03 100644
--- a/i18npool/source/localedata/data/ar_SA.xml
+++ b/i18npool/source/localedata/data/ar_SA.xml
@@ -51,7 +51,7 @@
 م
 metric
   
-  
+  
   
   
   
@@ -294,7 +294,7 @@
   
 
   SAR
-  ر.س.‏
+   ر.س.
   SAR
   SAR
   2
diff --git a/i18npool/source/localedata/data/ar_TN.xml 
b/i18npool/source/localedata/data/ar_TN.xml
index b69ad31..1b6f313 100644
--- a/i18npool/source/localedata/data/ar_TN.xml
+++ b/i18npool/source/localedata/data/ar_TN.xml
@@ -51,7 +51,7 @@
 م
 metric
   
-  
+  
   
   
   
@@ -294,7 +294,7 @@
   
 
   TND
-  د.ت.‏
+   د.ت.
   TND
   TND
   3

-- 
To view, visit https://gerrit.libreoffice.org/3498
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88588be252455bbb353c757a75f2ec9ea2d17e9e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] more fix to fdo#62470

2013-04-10 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3305

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/3305/1

more fix to fdo#62470

fix some problem appear when delete the right border.

Change-Id: I2bd1d69142bb0a920bdb58c833f8cbbb461a8350
---
M sw/source/core/docnode/ndtbl1.cxx
1 file changed, 26 insertions(+), 22 deletions(-)



diff --git a/sw/source/core/docnode/ndtbl1.cxx 
b/sw/source/core/docnode/ndtbl1.cxx
index 9fa5d7e..3eb533b 100644
--- a/sw/source/core/docnode/ndtbl1.cxx
+++ b/sw/source/core/docnode/ndtbl1.cxx
@@ -696,33 +696,37 @@
 {
 if( bLeftOver && bRightOver)
 {
-if ( bLeftOver ? bLeftValid : bVertValid )
-{
-aBox.SetLine( bLeftOver ? pLeft : 0,
-  BOX_LINE_RIGHT );
-bVertValid ? nType |= 0x0020 : nType |= 
0x0010;
-}
-if ( bRightOver ? bRightValid : bVertValid )
-{
-aBox.SetLine( bRightOver ? pRight : pVert,
-  BOX_LINE_LEFT );
-bVertValid ? nType |= 0x0008 : nType |= 
0x0004;
-}
+if ( bLeftValid )
+{
+aBox.SetLine( pLeft, BOX_LINE_RIGHT );
+nType |= 0x0010;
+}
+if ( bRightValid )
+{
+aBox.SetLine( pRight, BOX_LINE_LEFT );
+nType |= 0x0004;
+}
 }
 else
 {
-if ( bRightOver ? bLeftValid : bVertValid )
+if ( bLeftValid )
+{
+aBox.SetLine( bRightOver ? pLeft : 0, 
BOX_LINE_RIGHT );
+bVertValid ? nType |= 0x0020 : nType |= 0x0010;
+}
+if ( bLeftOver )
+{
+if ( bRightValid )
 {
-aBox.SetLine( bRightOver ? pLeft : 0,
-  BOX_LINE_RIGHT );
-bVertValid ? nType |= 0x0020 : nType |= 
0x0010;
+aBox.SetLine( pRight, BOX_LINE_LEFT );
+nType |= 0x0004;
 }
-if ( bLeftOver ? bRightValid : bVertValid )
-{
-aBox.SetLine( bLeftOver ? pRight : pVert,
-  BOX_LINE_LEFT );
-bVertValid ? nType |= 0x0008 : nType |= 
0x0004;
-}
+}
+else if ( bVertValid )
+{
+aBox.SetLine( pVert, BOX_LINE_LEFT );
+nType |= 0x0008;
+}
 }
 }
 else

-- 
To view, visit https://gerrit.libreoffice.org/3305
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2bd1d69142bb0a920bdb58c833f8cbbb461a8350
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] more fix for fdo#62399

2013-03-31 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3145

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/3145/1

more fix for fdo#62399

this will fix the border position, when the borders from the same
side are different in cells format dialog, when the sheet RTL.

Change-Id: I9fa8a665dfa0b0dcb5230bafa1e3537f450afb9c
---
M sc/source/ui/view/tabvwsha.cxx
1 file changed, 6 insertions(+), 5 deletions(-)



diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index 43a04a4..20b3d39 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -485,15 +485,16 @@
 //Fix border incorrect for RTL fdo#62399
 if( pDoc->IsLayoutRTL( GetViewData()->GetTabNo() ) )
 {
-SvxBoxItem aNewFrame( aLineOuter );
+SvxBoxItem aNewFrame( aLineOuter );
+SvxBoxInfoItem aTempInfo( aLineInner );
+
 if ( aLineInner.IsValid(VALID_LEFT) )
 aNewFrame.SetLine( aLineOuter.GetLeft(), BOX_LINE_RIGHT );
 if ( aLineInner.IsValid(VALID_RIGHT) )
 aNewFrame.SetLine( aLineOuter.GetRight(), BOX_LINE_LEFT );
-if ( aLineInner.IsValid(VALID_TOP) )
-aNewFrame.SetLine( aLineOuter.GetTop(), BOX_LINE_TOP );
-if ( aLineInner.IsValid(VALID_BOTTOM) )
-aNewFrame.SetLine( aLineOuter.GetBottom() , BOX_LINE_BOTTOM );
+
+aLineInner.SetValid( VALID_LEFT, aTempInfo.IsValid(VALID_RIGHT));
+aLineInner.SetValid( VALID_RIGHT, aTempInfo.IsValid(VALID_LEFT));
 
 pOldSet->Put( aNewFrame );
 }

-- 
To view, visit https://gerrit.libreoffice.org/3145
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fa8a665dfa0b0dcb5230bafa1e3537f450afb9c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#62470 fix the table format dialog reading

2013-03-31 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3134

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/3134/1

fdo#62470 fix the table format dialog reading

this will fix the wrong reading in table format borders
dialog.

Change-Id: I624cf7c162d3983fe4625e8e2e6fef4fc556eed0
---
M sw/source/core/docnode/ndtbl1.cxx
1 file changed, 18 insertions(+), 1 deletion(-)



diff --git a/sw/source/core/docnode/ndtbl1.cxx 
b/sw/source/core/docnode/ndtbl1.cxx
index e38d9aa6..62725c8 100644
--- a/sw/source/core/docnode/ndtbl1.cxx
+++ b/sw/source/core/docnode/ndtbl1.cxx
@@ -934,7 +934,8 @@
  bRightSet= sal_False,
  bHoriSet = sal_False,
  bVertSet = sal_False,
- bDistanceSet = sal_False;
+ bDistanceSet = sal_False,
+ bRTLTab  = sal_False;
 
 aSetBoxInfo.ResetFlags();
 
@@ -1115,6 +1116,22 @@
 }
 }
 }
+
+// fdo#62470 fix the reading for table format.
+if ( bRTLTab )
+{
+SvxBoxItem aTempBox((const SvxBoxItem&) 
rSet.Get(RES_BOX));
+SvxBoxInfoItem aTempBoxInfo((const SvxBoxInfoItem&) 
rSet.Get(SID_ATTR_BORDER_INNER));
+
+aTempBox.SetLine( aSetBox.GetRight(), BOX_LINE_RIGHT);
+aSetBox.SetLine( aSetBox.GetLeft(), BOX_LINE_RIGHT);
+aSetBox.SetLine( aTempBox.GetRight(), BOX_LINE_LEFT);
+
+aTempBoxInfo.SetValid( VALID_LEFT, aSetBoxInfo.IsValid(VALID_LEFT) 
);
+aSetBoxInfo.SetValid( VALID_LEFT, aSetBoxInfo.IsValid(VALID_RIGHT) 
);
+aSetBoxInfo.SetValid( VALID_RIGHT, 
aTempBoxInfo.IsValid(VALID_LEFT) );
+}
+
 rSet.Put( aSetBox );
 rSet.Put( aSetBoxInfo );
 }

-- 
To view, visit https://gerrit.libreoffice.org/3134
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I624cf7c162d3983fe4625e8e2e6fef4fc556eed0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#62470 fix the input change when the table RTL

2013-03-31 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3133

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/3133/1

fdo#62470 fix the input change when the table RTL

this fix the wrong borders changes when the table RTL.

Change-Id: I6e963c1bb71c63bffe8c8f95c091a5692c21cd31
---
M sw/source/core/docnode/ndtbl1.cxx
1 file changed, 59 insertions(+), 22 deletions(-)



diff --git a/sw/source/core/docnode/ndtbl1.cxx 
b/sw/source/core/docnode/ndtbl1.cxx
index 591b013..e38d9aa6 100644
--- a/sw/source/core/docnode/ndtbl1.cxx
+++ b/sw/source/core/docnode/ndtbl1.cxx
@@ -691,33 +691,70 @@
 }
 }
 
-// Left Border
-if ( bLeftOver )
+// Fix fdo#62470 correct the input for RTL table
+if (bRTL)
 {
-if( bLeftValid )
+if( bLeftOver && bRightOver)
+{
+if ( bLeftOver ? bLeftValid : bVertValid )
+{
+aBox.SetLine( bLeftOver ? pLeft : 0,
+  BOX_LINE_RIGHT );
+bVertValid ? nType |= 0x0020 : nType |= 
0x0010;
+}
+if ( bRightOver ? bRightValid : bVertValid )
+{
+aBox.SetLine( bRightOver ? pRight : pVert,
+  BOX_LINE_LEFT );
+bVertValid ? nType |= 0x0008 : nType |= 
0x0004;
+}
+}
+else
+{
+if ( bRightOver ? bLeftValid : bVertValid )
+{
+aBox.SetLine( bRightOver ? pLeft : 0,
+  BOX_LINE_RIGHT );
+bVertValid ? nType |= 0x0020 : nType |= 
0x0010;
+}
+if ( bLeftOver ? bRightValid : bVertValid )
+{
+aBox.SetLine( bLeftOver ? pRight : pVert,
+  BOX_LINE_LEFT );
+bVertValid ? nType |= 0x0008 : nType |= 
0x0004;
+}
+}
+}
+else
+{
+// Left Border
+if ( bLeftOver )
 {
-aBox.SetLine( pLeft, BOX_LINE_LEFT );
-nType |= 0x0004;
+if( bLeftValid )
+{
+aBox.SetLine( pLeft, BOX_LINE_LEFT );
+nType |= 0x0004;
+}
 }
-}
-else if( bVertValid )
-{
-aBox.SetLine( pVert, BOX_LINE_LEFT );
-nType |= 0x0008;
-}
+else if( bVertValid )
+{
+aBox.SetLine( pVert, BOX_LINE_LEFT );
+nType |= 0x0008;
+}
 
-// Right Border
-if( bRightValid )
-{
-if ( bRightOver )
+// Right Border
+if( bRightValid )
 {
-aBox.SetLine( pRight, BOX_LINE_RIGHT );
-nType |= 0x0010;
-}
-else if ( bVertValid )
-{
-aBox.SetLine( 0, BOX_LINE_RIGHT );
-nType |= 0x0020;
+if ( bRightOver )
+{
+aBox.SetLine( pRight, BOX_LINE_RIGHT );
+nType |= 0x0010;
+}
+else if ( bVertValid )
+{
+aBox.SetLine( 0, BOX_LINE_RIGHT );
+nType |= 0x0020;
+}
 }
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/3133
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e963c1bb71c63bffe8c8f95c091a5692c21cd31
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix fdo#37464 - Cell Border works backwards on Right-to-Left...

2013-03-17 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2782

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/2782/1

Fix fdo#37464 - Cell Border works backwards on Right-to-Left sheet

Change-Id: Idb73d3029880b66602f163b2ab03c2b37c2306db
---
M sc/source/core/data/attarray.cxx
1 file changed, 32 insertions(+), 7 deletions(-)



diff --git a/sc/source/core/data/attarray.cxx b/sc/source/core/data/attarray.cxx
index ebf246a..bf75271 100644
--- a/sc/source/core/data/attarray.cxx
+++ b/sc/source/core/data/attarray.cxx
@@ -1105,13 +1105,38 @@
 nDistBottom = 0;
 
 SvxBoxItem aNewFrame( *pOldFrame );
-
-if ( bLeft ? pBoxInfoItem->IsValid(VALID_LEFT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
-aNewFrame.SetLine( bLeft ? pBoxItem->GetLeft() : 
pBoxInfoItem->GetVert(),
-BOX_LINE_LEFT );
-if ( (nDistRight==0) ? pBoxInfoItem->IsValid(VALID_RIGHT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
-aNewFrame.SetLine( (nDistRight==0) ? pBoxItem->GetRight() : 
pBoxInfoItem->GetVert(),
-BOX_LINE_RIGHT );
+bool bRTL=pDocument->IsLayoutRTL(nTab);
+// fdo#37464 check if the sheet are RTL then replace right <=> left
+if (bRTL)
+{
+if( bLeft && nDistRight==0)
+{
+if ( bLeft ? pBoxInfoItem->IsValid(VALID_LEFT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
+aNewFrame.SetLine( bLeft ? pBoxItem->GetLeft() : 
pBoxInfoItem->GetVert(),
+BOX_LINE_RIGHT );
+if ( (nDistRight==0) ? pBoxInfoItem->IsValid(VALID_RIGHT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
+aNewFrame.SetLine( (nDistRight==0) ? pBoxItem->GetRight() : 
pBoxInfoItem->GetVert(),
+BOX_LINE_LEFT );
+}
+else
+{
+if ( (nDistRight==0) ? pBoxInfoItem->IsValid(VALID_LEFT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
+aNewFrame.SetLine( (nDistRight==0) ? pBoxItem->GetLeft() : 
pBoxInfoItem->GetVert(),
+BOX_LINE_RIGHT );
+if ( bLeft ? pBoxInfoItem->IsValid(VALID_RIGHT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
+aNewFrame.SetLine( bLeft ? pBoxItem->GetRight() : 
pBoxInfoItem->GetVert(),
+BOX_LINE_LEFT );
+}
+}
+else
+{
+if ( bLeft ? pBoxInfoItem->IsValid(VALID_LEFT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
+aNewFrame.SetLine( bLeft ? pBoxItem->GetLeft() : 
pBoxInfoItem->GetVert(),
+BOX_LINE_LEFT );
+if ( (nDistRight==0) ? pBoxInfoItem->IsValid(VALID_RIGHT) : 
pBoxInfoItem->IsValid(VALID_VERT) )
+aNewFrame.SetLine( (nDistRight==0) ? pBoxItem->GetRight() : 
pBoxInfoItem->GetVert(),
+BOX_LINE_RIGHT );
+}
 if ( bTop ? pBoxInfoItem->IsValid(VALID_TOP) : 
pBoxInfoItem->IsValid(VALID_HORI) )
 aNewFrame.SetLine( bTop ? pBoxItem->GetTop() : pBoxInfoItem->GetHori(),
 BOX_LINE_TOP );

-- 
To view, visit https://gerrit.libreoffice.org/2782
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb73d3029880b66602f163b2ab03c2b37c2306db
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix fdo#62399 Border incorrect for RTL

2013-03-16 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2781

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/2781/1

Fix fdo#62399 Border incorrect for RTL

this patch will fix the incorrect border when you use
the cell format dialog.

Change-Id: Ieeeae4060a15e96e0de0f335f3c460df86f7dbf9
---
M sc/source/ui/view/tabvwsha.cxx
1 file changed, 18 insertions(+), 1 deletion(-)



diff --git a/sc/source/ui/view/tabvwsha.cxx b/sc/source/ui/view/tabvwsha.cxx
index 9dab0b3..979591a 100644
--- a/sc/source/ui/view/tabvwsha.cxx
+++ b/sc/source/ui/view/tabvwsha.cxx
@@ -482,7 +482,24 @@
 
 // Umrandungs-Items holen und in den Set packen:
 GetSelectionFrame( aLineOuter, aLineInner );
-pOldSet->Put( aLineOuter );
+//Fix border incorrect for RTL fdo#62399
+if( pDoc->IsLayoutRTL( GetViewData()->GetTabNo() ) )
+{
+SvxBoxItem aNewFrame( aLineOuter );
+if ( aLineInner.IsValid(VALID_LEFT) )
+aNewFrame.SetLine( aLineOuter.GetLeft(), BOX_LINE_RIGHT );
+if ( aLineInner.IsValid(VALID_RIGHT) )
+aNewFrame.SetLine( aLineOuter.GetRight(), BOX_LINE_LEFT );
+if ( aLineInner.IsValid(VALID_TOP) )
+aNewFrame.SetLine( aLineOuter.GetTop(), BOX_LINE_TOP );
+if ( aLineInner.IsValid(VALID_BOTTOM) )
+aNewFrame.SetLine( aLineOuter.GetBottom() , BOX_LINE_BOTTOM );
+
+pOldSet->Put( aNewFrame );
+}
+else
+pOldSet->Put( aLineOuter );
+
 pOldSet->Put( aLineInner );
 
 // NumberFormat Value aus Value und Language erzeugen und eintueten

-- 
To view, visit https://gerrit.libreoffice.org/2781
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeeae4060a15e96e0de0f335f3c460df86f7dbf9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#57422 fixing the Listener for the buttons and scrollbar

2013-03-11 Thread Faisal al-otaibi (via Code Review) 
Faisal al-otaibi has abandoned this change.

Change subject: fdo#57422 fixing the Listener for the buttons and scrollbar
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/2094
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic30487fc1f4eeef447c9676b94fe6b9e93de8378
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 
Gerrit-Reviewer: Caolán McNamara 
Gerrit-Reviewer: Fridrich Strba 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57422 fixing the Listener for the buttons and scrollbar

2013-02-11 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/2094

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/2094/1

fdo#57422 fixing the Listener for the buttons and scrollbar

this patch will fix the listener for all buttons and
scrollbars that in presenter console.

Change-Id: Ic30487fc1f4eeef447c9676b94fe6b9e93de8378
---
M sdext/source/presenter/PresenterSlideSorter.cxx
M sdext/source/presenter/PresenterToolBar.cxx
M vcl/unx/gtk/window/gtkframe.cxx
M vcl/win/source/window/salframe.cxx
4 files changed, 23 insertions(+), 36 deletions(-)



diff --git a/sdext/source/presenter/PresenterSlideSorter.cxx 
b/sdext/source/presenter/PresenterSlideSorter.cxx
index bdffca4..ffe60c5 100644
--- a/sdext/source/presenter/PresenterSlideSorter.cxx
+++ b/sdext/source/presenter/PresenterSlideSorter.cxx
@@ -511,26 +511,14 @@
 void SAL_CALL PresenterSlideSorter::mousePressed (const css::awt::MouseEvent& 
rEvent)
 throw(css::uno::RuntimeException)
 {
-css::awt::MouseEvent rTemp =rEvent;
-/// check whether RTL interface or not
-if(Application::GetSettings().GetLayoutRTL()){
-awt::Rectangle aBox = mxWindow->getPosSize();
-rTemp.X=aBox.Width-rEvent.X;
-}
-const geometry::RealPoint2D aPosition(rTemp.X, rEvent.Y);
+const geometry::RealPoint2D aPosition(rEvent.X, rEvent.Y);
 mnSlideIndexMousePressed = mpLayout->GetSlideIndexForPosition(aPosition);
 }
 
 void SAL_CALL PresenterSlideSorter::mouseReleased (const css::awt::MouseEvent& 
rEvent)
 throw(css::uno::RuntimeException)
 {
-css::awt::MouseEvent rTemp =rEvent;
-/// check whether RTL interface or not
-if(Application::GetSettings().GetLayoutRTL()){
-awt::Rectangle aBox = mxWindow->getPosSize();
-rTemp.X=aBox.Width-rEvent.X;
-}
-const geometry::RealPoint2D aPosition(rTemp.X, rEvent.Y);
+const geometry::RealPoint2D aPosition(rEvent.X, rEvent.Y);
 const sal_Int32 nSlideIndex 
(mpLayout->GetSlideIndexForPosition(aPosition));
 
 if (nSlideIndex == mnSlideIndexMousePressed && mnSlideIndexMousePressed >= 
0)
@@ -574,13 +562,7 @@
 {
 if (mpMouseOverManager.get() != NULL)
 {
-css::awt::MouseEvent rTemp =rEvent;
-/// check whether RTL interface or not
-if(Application::GetSettings().GetLayoutRTL()){
-awt::Rectangle aBox = mxWindow->getPosSize();
-rTemp.X=aBox.Width-rEvent.X;
-}
-const geometry::RealPoint2D aPosition(rTemp.X, rEvent.Y);
+geometry::RealPoint2D aPosition(rEvent.X, rEvent.Y);
 sal_Int32 nSlideIndex (mpLayout->GetSlideIndexForPosition(aPosition));
 
 if (nSlideIndex < 0)
diff --git a/sdext/source/presenter/PresenterToolBar.cxx 
b/sdext/source/presenter/PresenterToolBar.cxx
index 76aaa7c..20200f9 100644
--- a/sdext/source/presenter/PresenterToolBar.cxx
+++ b/sdext/source/presenter/PresenterToolBar.cxx
@@ -1020,11 +1020,6 @@
 const bool bOverWindow,
 const bool bMouseDown)
 {
-css::awt::MouseEvent rTemp =rEvent;
-if(Application::GetSettings().GetLayoutRTL()){
-awt::Rectangle aWindowBox = mxWindow->getPosSize();
-rTemp.X=aWindowBox.Width-rTemp.X;
-}
 ElementContainer::iterator iPart;
 ElementContainer::const_iterator iEnd (maElementContainer.end());
 for (iPart=maElementContainer.begin(); iPart!=iEnd; ++iPart)
@@ -1038,13 +1033,13 @@
 
 awt::Rectangle aBox ((*iElement)->GetBoundingBox());
 const bool bIsOver = bOverWindow
-&& aBox.X <= rTemp.X
-&& aBox.Width+aBox.X-1 >= rTemp.X
-&& aBox.Y <= rTemp.Y
-&& aBox.Height+aBox.Y-1 >= rTemp.Y;
+&& aBox.X <= rEvent.X
+&& aBox.Width+aBox.X-1 >= rEvent.X
+&& aBox.Y <= rEvent.Y
+&& aBox.Height+aBox.Y-1 >= rEvent.Y;
 (*iElement)->SetState(
 bIsOver,
-bIsOver && rTemp.Buttons!=0 && bMouseDown && 
rTemp.ClickCount>0);
+bIsOver && rEvent.Buttons!=0 && bMouseDown && 
rEvent.ClickCount>0);
 }
 }
 }
diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index 6343f5b..21bc119 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -2967,7 +2967,9 @@
 
 // --- RTL --- (mirror mouse pos)
 if( Application::GetSettings().GetLayoutRTL() )
-aEvent.mnX = pThis->maGeometry.nWidth-1-aEvent.mnX;
+// Disable mirroring for presenter console
+if(!(pThis->m_aTitle !="" && pThis->m_bFullscreen))
+aEvent.mnX = pThis->maGeometry.nWidth-1-aEvent.mnX;
 
 vcl::DeletionListener aDel( pThis );
 
@@ -3031,7 +3033,9 @@
 
 // --- RTL --- (mirror mouse pos)
 if( Application::GetSettings().GetLayoutRTL() )
-aEvent.mnX = pThis->maGeometry.nWidth-1-aEvent.mnX;
+// Disable mirroring for presenter console
+if(!(pThis->m_aT

[PATCH] fdo#60213- fix the right-click misbehavior

2013-02-02 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1971

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/71/1971/1

fdo#60213- fix the right-click misbehavior

Change-Id: Iea44c9e70efeb84482aefc70b311f1781241b030
---
M sd/source/ui/toolpanel/LayoutMenu.cxx
1 file changed, 8 insertions(+), 6 deletions(-)



diff --git a/sd/source/ui/toolpanel/LayoutMenu.cxx 
b/sd/source/ui/toolpanel/LayoutMenu.cxx
index b602b2f..24bcdc1 100644
--- a/sd/source/ui/toolpanel/LayoutMenu.cxx
+++ b/sd/source/ui/toolpanel/LayoutMenu.cxx
@@ -857,13 +857,15 @@
 {
 if (GetShellManager() != NULL)
 GetShellManager()->MoveToTop(this);
+Point aPosition (0,0);
 if (rEvent.IsMouseEvent())
 {
 // Do not show the context menu when the mouse was not
 // pressed over an item.
+// We have to explicitly specify the location of the menu
+// when the LayoutMenu is undocked
 if (GetItemId(rEvent.GetMousePosPixel()) > 0)
-mrBase.GetViewFrame()->GetDispatcher()->ExecutePopup(
-SdResId(RID_TASKPANE_LAYOUTMENU_POPUP));
+aPosition = rEvent.GetMousePosPixel();
 }
 else
 {
@@ -873,13 +875,13 @@
 if (GetSelectItemId() != (sal_uInt16)-1)
 {
 Rectangle aBBox (GetItemRect(GetSelectItemId()));
-Point aPosition (aBBox.Center());
-mrBase.GetViewFrame()->GetDispatcher()->ExecutePopup(
+aPosition = aBBox.Center();
+}
+}
+mrBase.GetViewFrame()->GetDispatcher()->ExecutePopup(
 SdResId(RID_TASKPANE_LAYOUTMENU_POPUP),
 this,
 &aPosition);
-}
-}
 }
 break;
 

-- 
To view, visit https://gerrit.libreoffice.org/1971
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iea44c9e70efeb84482aefc70b311f1781241b030
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove duplicate code from PresenterToolBar.cxx

2012-12-23 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1474

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/1474/1

Remove duplicate code from PresenterToolBar.cxx

Change-Id: Icd6f71ce2daa896494c8efe76779d49e16c547bf
---
M sdext/source/presenter/PresenterToolBar.cxx
1 file changed, 40 insertions(+), 120 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1474
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd6f71ce2daa896494c8efe76779d49e16c547bf
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove duplicate code from Presenter Help View

2012-12-18 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1391

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/1391/1

Remove duplicate code from Presenter Help View

Change-Id: Ie33419ffe04dccc71956f7475d7b7a4acee7df12
---
M sdext/source/presenter/PresenterHelpView.cxx
1 file changed, 31 insertions(+), 47 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1391
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie33419ffe04dccc71956f7475d7b7a4acee7df12
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57422 - presenter console RTL support needs completion

2012-12-12 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1305

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1305/1

fdo#57422 - presenter console RTL support needs completion

Fixing the number problem that on Title on standard view.
*Remove duplicate code

Change-Id: Ib310be580766a3197e5481c4185f0261fece0906
---
M sdext/source/presenter/PresenterPaneBorderPainter.cxx
1 file changed, 61 insertions(+), 137 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1305
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib310be580766a3197e5481c4185f0261fece0906
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57422 - presenter console RTL support needs completion

2012-12-11 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1302

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/1302/1

fdo#57422 - presenter console RTL support needs completion

This patch will fix the RTL layout on Help view

Change-Id: I1cba5691649a0494efb9db63b8292525ff0c3656
---
M sdext/source/presenter/PresenterHelpView.cxx
1 file changed, 73 insertions(+), 33 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1302
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cba5691649a0494efb9db63b8292525ff0c3656
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

fdo#57422 - presenter console RTL support needs completion

2012-12-11 Thread Faisal al-otaibi (via Code Review) 
Faisal al-otaibi has abandoned this change.

Change subject: fdo#57422 - presenter console RTL support needs completion
..


Patch Set 2: Abandoned

--
To view, visit https://gerrit.libreoffice.org/1285
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ic6cec4d85045d11eed84a2e39cad384c5f189fb4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 
Gerrit-Reviewer: Faisal al-otaibi 
Gerrit-Reviewer: Michael Meeks 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#57422 - presenter console RTL support needs completion

2012-12-10 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1285

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/1285/1

fdo#57422 - presenter console RTL support needs completion

this patch fix the RTL layout in help view

Change-Id: Ic6cec4d85045d11eed84a2e39cad384c5f189fb4
---
M sdext/source/presenter/PresenterHelpView.cxx
M sdext/source/presenter/PresenterPaneBorderPainter.cxx
2 files changed, 148 insertions(+), 28 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1285
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6cec4d85045d11eed84a2e39cad384c5f189fb4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix the Ignore system input language label truncated

2012-11-23 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1155

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1155/1

Fix the Ignore system input language label truncated

This fix label Ignore system input language on
Options-Language Setting-Languages
truncated

Change-Id: Iaa9606160d7cfc96fcbb02116020cd8d46ffb4e7
---
M cui/source/options/optgdlg.src
1 file changed, 2 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1155
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa9606160d7cfc96fcbb02116020cd8d46ffb4e7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#42070-Fix RTL support in presenter console

2012-11-13 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1053

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1053/1

fdo#42070-Fix RTL support in presenter console

Problems that still exist:
1-Help layout.
2-Slide sorter view (slides alignment).
3-Note view buttons.
4-Scroll bars.

Change-Id: Ie78519358d2f6d847692ee870ecdc1790c5244e6
---
M sdext/Library_presenter.mk
M sdext/source/presenter/PresenterButton.cxx
M sdext/source/presenter/PresenterPaneBorderPainter.cxx
M sdext/source/presenter/PresenterSlideShowView.cxx
M sdext/source/presenter/PresenterSlideSorter.cxx
M sdext/source/presenter/PresenterToolBar.cxx
M sdext/source/presenter/PresenterWindowManager.cxx
7 files changed, 590 insertions(+), 194 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1053
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie78519358d2f6d847692ee870ecdc1790c5244e6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change some comments to meet doxygen standards

2012-09-09 Thread Faisal al-otaibi (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/591

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/591/1

Change some comments to meet doxygen standards

Change-Id: I3e5a40237f2ec3ac884c50e34a1592a029d9050d
---
M sc/inc/AccessibleFilterMenu.hxx
M sc/inc/AccessibleGlobal.hxx
M sc/inc/addincol.hxx
M sc/inc/address.hxx
M sc/inc/attarray.hxx
M sc/inc/attrib.hxx
M sc/inc/autonamecache.hxx
7 files changed, 49 insertions(+), 53 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/591
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e5a40237f2ec3ac884c50e34a1592a029d9050d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice